IRC Chat : 2014-03-12 - OpenMRS

00:10:42 *** willa has quit IRC
00:18:02 *** NameFILIP has joined #openmrs
00:18:02 *** ChanServ sets mode: +v NameFILIP
00:24:44 *** NameFILIP has quit IRC
00:47:33 *** lstanisic has quit IRC
00:57:52 *** wluyima has joined #openmrs
00:57:53 *** ChanServ sets mode: +v wluyima
00:58:20 *** ryates has quit IRC
01:01:37 *** ryates has joined #openmrs
01:03:14 *** yanosz has quit IRC
01:11:43 *** yanosz has joined #openmrs
01:21:27 *** NameFILIP has joined #openmrs
01:21:28 *** ChanServ sets mode: +v NameFILIP
01:25:57 *** NameFILIP has quit IRC
01:32:33 *** Tajha has quit IRC
01:34:35 *** wluyima has quit IRC
01:34:48 *** Tajha has joined #openmrs
01:57:45 *** Tajha has quit IRC
02:16:15 *** Tajha has joined #openmrs
02:22:13 *** NameFILIP has joined #openmrs
02:22:13 *** ChanServ sets mode: +v NameFILIP
02:26:39 *** NameFILIP has quit IRC
02:31:40 *** wluyima has joined #openmrs
02:31:40 *** ChanServ sets mode: +v wluyima
03:02:39 *** dmexs has joined #openmrs
03:03:06 *** dmexs has quit IRC
03:04:04 *** dmexs has joined #openmrs
03:09:47 *** upul has joined #openmrs
03:23:14 *** NameFILIP has joined #openmrs
03:23:14 *** ChanServ sets mode: +v NameFILIP
03:27:47 *** NameFILIP has quit IRC
03:31:24 *** harsz89 has quit IRC
03:33:13 *** GitHub156 has joined #openmrs
03:33:13 <GitHub156> [openmrs-core] wluyima pushed 1 new commit to 1.10.x: http://git.io/CycZgA
03:33:13 <GitHub156> openmrs-core/1.10.x 5ad6a65 wyclif: Renamed GP for next order number seed and set voided by for voided order in test data
03:33:13 *** GitHub156 has left #openmrs
03:33:39 *** GitHub61 has joined #openmrs
03:33:39 <GitHub61> [openmrs-core] wluyima closed pull request #735: TRUNK-4276 Changesets that convert units from text to concept should use... (1.10.x...TRUNK-4276) http://git.io/DiP95g
03:33:39 *** GitHub61 has left #openmrs
03:38:11 *** dmexs has quit IRC
03:39:18 *** akashagarwal has quit IRC
03:55:18 *** akashagarwal has joined #openmrs
04:22:19 *** GitHub139 has joined #openmrs
04:22:19 <GitHub139> [openmrs-core] wluyima pushed 1 new commit to 1.10.x: http://git.io/O2y2WQ
04:22:19 <GitHub139> openmrs-core/1.10.x b738e2f wyclif: Renamed OrderContext.addAttribute to setAttribute and added some debugging lines when getting the order number generator - TRUNK-4270
04:22:19 *** GitHub139 has left #openmrs
04:24:00 *** NameFILIP has joined #openmrs
04:24:01 *** ChanServ sets mode: +v NameFILIP
04:28:56 *** NameFILIP has quit IRC
04:33:24 <OpenMRSBot> Recent updates in the world of ci: TRUNK-ONEPOINTTENX-166 has FAILED (2 tests failed) : Updated by Wyclif Luyima <https://ci.openmrs.org/browse/TRUNK-ONEPOINTTENX-166>
04:46:43 *** shubh has joined #openmrs
04:52:42 *** wluyima has quit IRC
05:25:00 *** NameFILIP has joined #openmrs
05:25:00 *** ChanServ sets mode: +v NameFILIP
05:29:34 *** NameFILIP has quit IRC
05:50:50 *** ergaurav2 has joined #openmrs
05:57:23 *** shubh has quit IRC
06:00:31 *** upul has quit IRC
06:02:41 *** k-joseph has joined #openmrs
06:02:54 *** ergaurav2 has quit IRC
06:26:35 *** NameFILIP has joined #openmrs
06:26:35 *** ChanServ sets mode: +v NameFILIP
06:31:11 *** NameFILIP has quit IRC
06:37:45 *** ergaurav2 has joined #openmrs
06:42:35 *** kriks has joined #openmrs
06:46:28 *** xiaoxi has joined #openmrs
06:49:40 *** NameFILIP has joined #openmrs
06:49:40 *** ChanServ sets mode: +v NameFILIP
06:59:04 *** NameFILIP has quit IRC
07:05:16 *** suranga_ has quit IRC
07:10:15 *** robbyoconnor has joined #openmrs
07:10:15 *** ChanServ sets mode: +v robbyoconnor
07:12:52 *** NameFILIP has joined #openmrs
07:12:53 *** ChanServ sets mode: +v NameFILIP
07:36:39 *** ergaurav2 has quit IRC
07:48:47 *** aka_007 has joined #openmrs
07:55:24 *** k-joseph has quit IRC
07:56:02 *** k-joseph has joined #openmrs
08:05:49 *** kriks has quit IRC
08:20:56 *** ergaurav2 has joined #openmrs
08:41:23 *** k-joseph has quit IRC
08:52:04 *** ergaurav2 has quit IRC
09:51:05 *** ayeung has joined #openmrs
10:05:14 *** k-joseph has joined #openmrs
10:38:59 *** k-joseph has quit IRC
10:42:08 *** aka_007 has quit IRC
10:45:49 *** k-joseph has joined #openmrs
11:25:53 *** k-joseph has quit IRC
11:38:20 *** k-joseph has joined #openmrs
11:42:41 *** k-joseph has quit IRC
11:48:46 *** xiaoxi has quit IRC
11:56:16 *** andrew_sz has joined #openmrs
12:04:28 *** akwatuha_____ has joined #openmrs
12:20:14 <andrew_sz> It's kinda urgent, can someone help to me with this? https://github.com/openmrs/openmrs-core/pull/731 (the last comment)
12:27:28 <downey> andrew_sz: you might have better luck asking your question here directly
12:28:31 *** ergaurav2 has joined #openmrs
12:30:16 *** elly__ has joined #openmrs
12:33:56 *** ojwanganto has joined #openmrs
12:34:05 *** jt48 has joined #openmrs
12:34:21 *** NameFILIP has quit IRC
12:36:37 *** NameFILIP has joined #openmrs
12:36:37 *** ChanServ sets mode: +v NameFILIP
12:38:21 *** lstanisic has joined #openmrs
12:50:02 *** willa has joined #openmrs
12:51:10 *** mareias has joined #openmrs
12:55:18 <OpenMRSBot> Recent updates in the world of ci: NIGHTLY-BRANCH110X-13 has FAILED : Scheduled build <https://ci.openmrs.org/browse/NIGHTLY-BRANCH110X-13>
12:56:44 *** aka_007 has joined #openmrs
12:59:05 *** rafa has joined #openmrs
12:59:28 *** rafa is now known as Guest58050
13:00:02 *** Guest58050 is now known as rafa
13:00:11 *** ChanServ sets mode: +v rafa
13:03:11 *** mareias has quit IRC
13:04:42 *** NameFILIP has quit IRC
13:05:25 *** NameFILIP has joined #openmrs
13:05:25 *** ChanServ sets mode: +v NameFILIP
13:07:21 *** akashagarwal has quit IRC
13:08:59 *** wluyima has joined #openmrs
13:08:59 *** ChanServ sets mode: +v wluyima
13:09:50 *** NameFILIP has quit IRC
13:18:05 *** sashrika has joined #openmrs
13:20:52 *** NameFILIP has joined #openmrs
13:20:52 *** ChanServ sets mode: +v NameFILIP
13:22:39 *** akashagarwal has joined #openmrs
13:24:48 *** GitHub60 has joined #openmrs
13:24:48 <GitHub60> [openmrs-core] vinkesh opened pull request #774: Adding new validation rules for orders and drugOrders. (1.10.x...TRUNK-4217) http://git.io/EQqHdQ
13:24:48 *** GitHub60 has left #openmrs
13:37:16 *** suranga_ has joined #openmrs
13:40:31 *** mareias has joined #openmrs
13:45:14 *** sashrika has quit IRC
13:45:40 *** sashrika has joined #openmrs
13:52:43 *** akashagarwal has quit IRC
13:58:11 *** elliott_w has joined #openmrs
13:58:11 *** ChanServ sets mode: +o elliott_w
14:03:25 <wluyima> !scrumon
14:03:25 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster - you may begin when ready.
14:04:13 <wluyima> order: rafa , djazayeri , elliott_w , wluyima and dkayiwa if present
14:04:20 <wluyima> !seen dkayiwa
14:04:20 <OpenMRSBot> wluyima: dkayiwa was last seen in #openmrs 16 hours, 24 minutes, and 25 seconds ago: <dkayiwa> khatman: byeology :)
14:05:02 <rafa> Today:
14:05:02 <rafa> * OpenMRS Univ session
14:05:02 <rafa> * Reviewing pull requests
14:05:02 <rafa> * Design forum
14:05:02 <rafa> No blockers.
14:06:13 <djazayeri> Today: lots of calls, and doing some Mirebalais-specific tickets.
14:06:15 <djazayeri> No blockers.
14:06:35 <elliott_w> Yesterday: Modulus generating RSS feeds
14:06:35 <elliott_w> Today: Navbar changes, Infrastructure LDAP documentation, moving old module repository data to modulus
14:06:35 <elliott_w> No blockers
14:07:09 <wluyima> Tuesday:
14:07:09 <wluyima> - order entry bi weekly call
14:07:11 <wluyima> - Review and merge pull requests
14:07:12 <wluyima> - Code cleanups:
14:07:14 <wluyima> - started on - TRUNK-4302 - The API should be able to assign OrderTypes
14:07:15 <wluyima> Wednesday:
14:07:17 <wluyima> - PM call
14:07:18 <wluyima> - design call
14:07:19 <wluyima> - Complete TRUNK-4302 - The API should be able to assign OrderTypes
14:07:20 <wluyima> Blockers: None
14:07:45 <wluyima> anybody else that wants to give an update?
14:07:54 *** Akshika47 has joined #openmrs
14:07:59 <wluyima> !scrumoff
14:07:59 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
14:09:45 <andrew_sz> wluyima: Can you help me with this question? https://github.com/openmrs/openmrs-core/pull/731 (last comment)
14:12:18 *** Akshika47 has quit IRC
14:12:22 <andrew_sz> wluyima: This ticket is important for me, because I'd like to be more familiar that what's under the hood :)
14:19:21 <downey> andrew_sz: you might have better luck asking your question here directly
14:20:22 <andrew_sz> one thing not clear to me, how should I decide, that which OrderType is associated to an Order by default? Is it appropriate like this, because as I saw, the order_type_id field is removed previously in the changeset and there's no information about the type of an order?
14:20:44 <andrew_sz> the diff: https://github.com/coldcue/openmrs-core/commit/c9ff66e41c3ccd60dc6922725c88e9e51170c462
14:21:12 *** NameFILIP has quit IRC
14:21:55 *** NameFILIP has joined #openmrs
14:21:56 *** ChanServ sets mode: +v NameFILIP
14:22:11 <wluyima> hi andrew_sz
14:23:10 <andrew_sz> hi
14:23:53 <wluyima> andrew_sz: i comment on the ticket about how to set order types, see my ticket comment on 2014-03-10 09:43:44 EDT
14:25:31 <andrew_sz> wluyima: ohh, now its clear... how blind I am
14:26:14 *** NameFILIP has quit IRC
14:27:03 <andrew_sz> wluyima: I'll get it done right now, as you said, its urgent
14:27:30 <wluyima> andrew_sz: i have updated the description of the ticket, read the 3 bullet carefully
14:28:32 <andrew_sz> wluyima: Thanks for the detailed description, it helps a lot for a noob like me :)
14:28:44 <andrew_sz> wluyima: I mean, noob with the system
14:40:39 *** Akshika47 has joined #openmrs
14:41:55 *** NameFILIP has joined #openmrs
14:41:56 *** ChanServ sets mode: +v NameFILIP
14:53:12 *** dkayiwa has joined #openmrs
14:55:42 *** kriks has joined #openmrs
14:58:27 *** kriks has quit IRC
14:59:20 *** khatman has joined #openmrs
15:01:38 <khatman> dkayiwa: I kind want to leave the form that is automatically generated by XForms. It's very basic. Not fancy. But it's OK
15:02:37 <khatman> dkayiwa: the challenge now is to see it work. Show me which way to go
15:03:23 <dkayiwa> khatman: you are free to make the form look any way you want
15:04:11 <khatman> dkayiwa: Yah. i say all of the staff on CSS and all. I'll deal with that later. Right now I want to see it work
15:04:42 <dkayiwa> khatman: it should work out of the box
15:05:12 <khatman> dkayiwa: How do I deploy it?
15:05:35 <khatman> dkayiwa: any URL? i can't find staff on that
15:05:36 *** mareias has quit IRC
15:05:54 <dkayiwa> khatman: https://wiki.openmrs.org/display/docs/XForms+Module+User+Guide
15:05:55 <OpenMRSBot> <http://ln-s.net/8afL> (at wiki.openmrs.org)
15:07:36 <khatman> dkayiwa: OK. let me see...
15:07:50 *** khatman has quit IRC
15:10:30 *** harsz89 has joined #openmrs
15:10:30 *** ChanServ sets mode: +v harsz89
15:11:08 *** akashagarwal has joined #openmrs
15:15:15 *** kriks has joined #openmrs
15:17:18 *** khatman has joined #openmrs
15:18:30 <khatman> dkayiwa: I don't if fatigue's getting the best of me but, I only see a small heading that talks "Uploading XForm" and the narration
15:18:42 <khatman> but as to the how part. I can't see it
15:18:53 <dkayiwa> khatman: what do you wanna do?
15:19:47 <khatman> dkayiwa: I'm the stage when I configured all of the schema and when i click "design xform" it automatically populates the form
15:20:02 <khatman> dkayiwa: so I'm saying, i'm cool with the form as it is.
15:20:39 <khatman> dkayiwa: I'll fiddle with it later so that it looks pretty. I just wanna deploy it and see it capturing data
15:22:34 <dkayiwa> khatman: capture data right from the server you have been using to design it
15:24:50 <khatman> dkayiwa: yah. I don't know if I'm bieng stupid again but the question is "how do i see the form such that I can capture data with it?"
15:26:44 <khatman> dkayiwa: :) I see another big error here. Can I show you on your email?
15:26:44 <dkayiwa> khatman: did you read the whole of the wiki page i just sent you?
15:26:49 <khatman> yes
15:26:52 <khatman> i did
15:27:28 <khatman> dkayiwa: the site is saying "HTTP Status 500 - PermGen space"
15:27:36 *** lnball has joined #openmrs
15:29:44 <dkayiwa> khatman: https://wiki.openmrs.org/display/docs/XForms+Module+User+Guide
15:29:45 <OpenMRSBot> <http://ln-s.net/8afL> (at wiki.openmrs.org)
15:29:55 <dkayiwa> khatman: https://wiki.openmrs.org/display/docs/Troubleshooting+Memory+Errors
15:29:56 <OpenMRSBot> <http://ln-s.net/8zIh> (at wiki.openmrs.org)
15:30:13 *** Akshika47 has quit IRC
15:30:16 <khatman> dkayiwa: let me restart my Tomcat and i'll get back to you
15:32:38 *** ergaurav2 has quit IRC
15:34:35 *** GitHub160 has joined #openmrs
15:34:36 <GitHub160> [openmrs-core] kkaczmarczyk opened pull request #775: TRUNK-4279: Add DrugValidator and validate drugReferenceMaps from it (1.10.x...TRUNK-4279) http://git.io/z_v1eQ
15:34:36 *** GitHub160 has left #openmrs
15:35:10 *** khatman has quit IRC
15:39:56 *** elly__ has quit IRC
15:53:18 *** akwatuha_____ has quit IRC
15:59:45 *** willa has quit IRC
16:08:24 *** khatman has joined #openmrs
16:08:39 <khatman> dkayiwa: did I get something wrong?
16:10:55 *** ojwanganto has quit IRC
16:14:43 *** ergaurav2 has joined #openmrs
16:15:40 *** khatman_ has joined #openmrs
16:16:45 *** k-joseph has joined #openmrs
16:19:24 *** khatman has quit IRC
16:19:53 *** khatman_ has quit IRC
16:23:05 *** shubh has joined #openmrs
16:24:01 *** khatman has joined #openmrs
16:25:37 *** harsz89 has quit IRC
16:27:02 *** GitHub137 has joined #openmrs
16:27:02 <GitHub137> [openmrs-core] harsha89 opened pull request #776: Added order type custom getter methods as per TRUNK-4312 (1.10.x...TRUNK_4312) http://git.io/XVgw7g
16:27:02 *** GitHub137 has left #openmrs
16:28:25 <dkayiwa> wluyima: hi
16:28:37 <wluyima> hi dkayiwa
16:29:22 <dkayiwa> wluyima: do you have more order entry tickets that have low complexity? I do not want to finish them :)
16:29:38 <dkayiwa> wluyima: but i can finish them if you say so :)
16:30:45 <wluyima> dkayiwa: low priority?
16:30:51 <wluyima> low complexity?
16:31:09 <wluyima> dkayiwa: i think all the tickets are not complex for you
16:31:25 <wluyima> dkayiwa: i.e the ones ready for work?
16:31:44 <dkayiwa> wluyima: just wanted to ensure that i do not consume them all and leave the volunteers with none from the current sprint :)
16:31:51 <wluyima> dkayiwa: how about https://tickets.openmrs.org/browse/RESTWS-425
16:31:55 <khatman> dkayiwa: I'm waiting to hear from you :)
16:32:16 <dkayiwa> wluyima: ok let me first finish the one i have
16:32:25 *** mareias has joined #openmrs
16:32:27 <dkayiwa> khatman: about what?
16:32:27 <wluyima> dkayiwa: you want complex one and leave simpler ones for volunteers, right?
16:32:54 <dkayiwa> wluyima: correct. i do not want to rob them for a chance of joining the sprint :)
16:32:57 <khatman> dkayiwa: about our conversation from the email
16:33:07 <wluyima> dkayiwa: we are actually almost getting done with the tickets?
16:33:15 <dkayiwa> wluyima: oh i see
16:33:37 <dkayiwa> wluyima: i have seen a couple of them do the order entry tickets. So i wanted them to keep the fire
16:33:50 <wluyima> dkayiwa: actually the rest ticket is fairly simpler
16:33:55 <wluyima> do you want to work on https://tickets.openmrs.org/browse/TRUNK-4302?
16:34:12 <wluyima> dkayiwa: i had picked it up but i haven't test started on it
16:34:39 <wluyima> dkayiwa: i have unassigned myself from https://tickets.openmrs.org/browse/TRUNK-4302, so you can pick that up
16:34:40 <khatman> dkayiwa: do you read me?
16:34:52 <dkayiwa> wluyima: let me look at it
16:35:25 <dkayiwa> khatman: what was the problem?
16:36:09 <dkayiwa> wluyima: is it of more complexity than TRUNK-4289?
16:37:03 *** GitHub62 has joined #openmrs
16:37:03 <GitHub62> [openmrs-core] harsha89 closed pull request #776: Added order type custom getter methods as per TRUNK-4312 (1.10.x...TRUNK_4312) http://git.io/XVgw7g
16:37:03 *** GitHub62 has left #openmrs
16:38:24 *** harsz89 has joined #openmrs
16:38:24 *** ChanServ sets mode: +v harsz89
16:38:49 *** khatman has quit IRC
16:39:40 <wluyima> dkayiwa: so does that mean you will work on that?
16:40:03 <dkayiwa> wluyima: if they are of almost the same complexity, then i can work on TRUNK-4289
16:40:14 <wluyima> dkayiwa: https://tickets.openmrs.org/browse/TRUNK-4302 is a little more complex
16:40:32 <dkayiwa> wluyima: ok
16:41:24 *** khatman has joined #openmrs
16:41:39 <wluyima> dkayiwa: but i have been surprised by these guys, they can do almost all these tickets with a little guidance
16:41:56 <dkayiwa> wluyima: man, very true :)
16:42:21 <dkayiwa> wluyima: i think we just need to advertise the sprint a bit more :)
16:42:21 *** GibriL has joined #openmrs
16:42:50 <khatman> dkayiwa: hello!
16:42:53 <dkayiwa> wluyima: i have seen them even do some core tickets (not in the sprint) of reasonable complexity
16:42:57 <dkayiwa> khatman: hi
16:43:51 <khatman> dkayiwa: how did you find the schema?
16:43:51 <GibriL> Hi all
16:44:21 <dkayiwa> khatman: are you Patrick Toroitich?
16:44:29 <GibriL> Please can anyone here help with xFormHeler module
16:45:35 <khatman> dkayiwa: the schema you just commented on was mine. Sorry.
16:45:39 <wluyima> dkayiwa: true
16:45:59 <dkayiwa> khatman: so how does it connect to his email thread?
16:46:01 <khatman> dkayiwa: i thought you were responding to what we were chatting about earlier
16:57:20 *** khatman has quit IRC
17:00:49 *** khatman has joined #openmrs
17:06:35 *** mareias has quit IRC
17:10:12 *** GitHub102 has joined #openmrs
17:10:12 <GitHub102> [openmrs-core] rkorytkowski closed pull request #769: TRUNK-4294 [Add User] Password requirements should be shown beforehand as per the global properties (master...TRUNK-4294-b) http://git.io/K2n0UQ
17:10:12 *** GitHub102 has left #openmrs
17:10:12 *** GitHub118 has joined #openmrs
17:10:12 <GitHub118> [openmrs-core] rkorytkowski pushed 2 new commits to master: http://git.io/GVMpmQ
17:10:12 <GitHub118> openmrs-core/master 2930fc8 ujjwalarora: TRUNK-4294
17:10:12 <GitHub118> openmrs-core/master f338537 Rafal Korytkowski: Merge pull request #769 from ujjwalarora/TRUNK-4294-b...
17:10:12 *** GitHub118 has left #openmrs
17:14:20 <dkayiwa> khatman: am confused regarding how it relates to the email thread where you sent the schema screenshot
17:16:22 *** khatman_ has joined #openmrs
17:16:49 *** khatman has quit IRC
17:16:49 *** khatman_ is now known as khatman
17:17:06 *** suraj has joined #openmrs
17:18:22 <OpenMRSBot> Recent updates in the world of ci: TRUNK-MASTER-345 has FAILED (2 tests failed) : Updated by Rafał Korytkowski <https://ci.openmrs.org/browse/TRUNK-MASTER-345>
17:25:23 <harsz89> hi wluyima
17:25:33 <wluyima> harsz89: hi
17:25:47 <harsz89> wluyima, is it okey add some test ordery types to standard test data set
17:25:58 <harsz89> wluyima, or do it needs to create seperate data file
17:27:01 <wluyima> harsz89: we actually makes sense and okay to add them to standard test data because one, they are required for existing text orders and also there is no existing tests you will will since you are introducing something new
17:27:37 <harsz89> wluyima, okey i'll do it
17:27:41 <harsz89> wluyima, thank you :)
17:28:17 *** sas_ has joined #openmrs
17:28:30 *** sas_ has quit IRC
17:29:53 *** khatman_ has joined #openmrs
17:29:59 *** khatman has quit IRC
17:29:59 *** khatman_ is now known as khatman
17:34:15 *** ChanServ sets mode: +o ryates
17:35:42 *** travis-ci has joined #openmrs
17:35:42 <travis-ci> [travis-ci] [openmrs/openmrs-core] [f338537] [Rafal Korytkowski] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/20624313
17:35:42 *** travis-ci has left #openmrs
17:41:13 *** khatman has quit IRC
17:42:03 <andrew_sz> wluyima: I think two changeset is not right, 201403070131-TRUNK-4286 preCondition should be without <not>
17:42:25 *** khatman has joined #openmrs
17:45:22 <andrew_sz> wluyima: because it should run when there is no entity in the table, but instead it runs otherwise
17:46:27 *** GitHub121 has joined #openmrs
17:46:27 <GitHub121> [openmrs-core] rkorytkowski pushed 1 new commit to master: http://git.io/c2yslw
17:46:27 <GitHub121> openmrs-core/master 0fee185 Rafal Korytkowski: Fixed build
17:46:27 *** GitHub121 has left #openmrs
17:46:53 <wluyima> andrew_sz: the problem is that if you add a column with a not null constraint to a table containing rows, then it will fail unless you have defined a default value which we don't' want, makes sense?
17:46:57 *** GitHub62 has joined #openmrs
17:46:57 <GitHub62> [openmrs-core] rkorytkowski pushed 1 new commit to master: http://git.io/NLqSZA
17:46:57 <GitHub62> openmrs-core/master e5de1e6 Rafal Korytkowski: Fixed formatting
17:46:57 *** GitHub62 has left #openmrs
17:48:38 *** GitHub147 has joined #openmrs
17:48:38 <GitHub147> [openmrs-core] rkorytkowski pushed 1 new commit to 1.10.x: http://git.io/kmitSQ
17:48:38 <GitHub147> openmrs-core/1.10.x 1555f99 Rafal Korytkowski: Fixed build...
17:48:38 *** GitHub147 has left #openmrs
17:48:44 <wluyima> andrew_sz: so you have to first add the column, set the new column values for existing rows and then set the not null constraint and you don't want that to be all in one change set because all the three need separate precondition otherwise if it one and it fails midway, things get screwed up
17:50:42 <andrew_sz> wluyima: I know that how constraints work, but I've started a new test database and 201403070131-TRUNK-4286 failed to run, which should add drugorder and testorder type to an empty table
17:54:43 *** GitHub191 has joined #openmrs
17:54:43 <GitHub191> [openmrs-core] rkorytkowski pushed 2 new commits to master: http://git.io/Bbtxhg
17:54:43 <GitHub191> openmrs-core/master c86fb54 sashrika: TRUNK-301: added a new table which show all forms that using a particular field
17:54:43 <GitHub191> openmrs-core/master be6116e Rafal Korytkowski: Merge pull request #766 from sashrika/TRNK-301...
17:54:43 *** GitHub191 has left #openmrs
17:54:43 *** GitHub173 has joined #openmrs
17:54:43 <GitHub173> [openmrs-core] rkorytkowski closed pull request #766: TRUNK-301: added a new table which show all forms that using a particula... (master...TRNK-301) http://git.io/8YC9BA
17:54:43 *** GitHub173 has left #openmrs
17:56:02 <ayeung> hi, guys, where can I get the omod for https://wiki.openmrs.org/display/projects/De-Identified+Patient+Data+Export? I cannot find it from the module repository.
17:56:03 *** GibriL has quit IRC
17:57:33 *** GitHub166 has joined #openmrs
17:57:33 <GitHub166> [openmrs-core] harsha89 reopened pull request #776: Added order type custom getter methods as per TRUNK-4312 (1.10.x...TRUNK_4312) http://git.io/XVgw7g
17:57:33 *** GitHub166 has left #openmrs
17:57:53 *** GitHub76 has joined #openmrs
17:57:53 <GitHub76> [openmrs-core] harsha89 closed pull request #776: Added order type custom getter methods as per TRUNK-4312 (1.10.x...TRUNK_4312) http://git.io/XVgw7g
17:57:53 *** GitHub76 has left #openmrs
17:59:57 *** GitHub110 has joined #openmrs
17:59:57 <GitHub110> [openmrs-core] harsha89 opened pull request #777: Added order type custom getter methods as per TRUNK-4312 (1.10.x...TRUNK_4312) http://git.io/wo1Bbw
17:59:57 *** GitHub110 has left #openmrs
18:02:31 <OpenMRSBot> Recent updates in the world of ci: TRUNK-ONEPOINTTENX-167 has FAILED (2 tests failed) : Updated by Rafal Korytkowski <https://ci.openmrs.org/browse/TRUNK-ONEPOINTTENX-167>
18:04:49 <downey> ayeung: sgithens is probably the best person with the answer, but i don't see him in the channel at the moment
18:05:16 <ayeung> thanks, downey ... already sent sgithens an email
18:12:34 *** mareias has joined #openmrs
18:13:28 *** travis-ci has joined #openmrs
18:13:28 <travis-ci> [travis-ci] [openmrs/openmrs-core] [0fee185] [Rafal Korytkowski] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/20627007
18:13:28 *** travis-ci has left #openmrs
18:13:43 *** travis-ci has joined #openmrs
18:13:43 <travis-ci> [travis-ci] [openmrs/openmrs-core] [e5de1e6] [Rafal Korytkowski] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/20627040
18:13:43 *** travis-ci has left #openmrs
18:14:19 *** aka_007 has quit IRC
18:15:23 *** k-joseph has quit IRC
18:16:22 *** aka_007 has joined #openmrs
18:17:07 *** k-joseph has joined #openmrs
18:35:02 *** travis-ci has joined #openmrs
18:35:02 <travis-ci> [travis-ci] [openmrs/openmrs-core] [be6116e] [Rafal Korytkowski] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/20627512
18:35:02 *** travis-ci has left #openmrs
18:40:49 *** ergaurav2 has quit IRC
18:53:11 *** kriks has quit IRC
18:59:33 *** GitHub100 has joined #openmrs
18:59:33 <GitHub100> [openmrs-core] NameFILIP opened pull request #778: TRUNK-3889. Pickup module resources from module api (master...TRUNK-3889) http://git.io/Yz1hMw
18:59:33 *** GitHub100 has left #openmrs
19:02:59 *** mareias has quit IRC
19:04:15 *** mareias has joined #openmrs
19:16:16 *** ddesimone_ has joined #openmrs
19:36:46 *** kriks has joined #openmrs
19:41:46 *** khatman has quit IRC
19:48:34 *** sashrika has quit IRC
20:18:00 *** k-joseph_ has joined #openmrs
20:18:25 *** k-joseph has quit IRC
20:25:28 *** GitHub72 has joined #openmrs
20:25:28 <GitHub72> [openmrs-core] suraj5 opened pull request #779: Trunk 3850 (1.9.x...trunk-3850) http://git.io/b5Y1jg
20:25:28 *** GitHub72 has left #openmrs
20:28:22 *** mareias has quit IRC
20:29:48 <andrew_sz> Should I get order_type with a select or it's good as is? https://github.com/coldcue/openmrs-core/commit/5f5298761bf3f0c773f6d464272aab5d2b0c7f69
20:43:39 <andrew_sz> Can someone help me, that how I'm supposed to test changesets within Database1_9To1_10UpgradeTest?
20:44:58 <andrew_sz> Do I have to add some rows then the let the changeset modify them?
20:45:06 <andrew_sz> -the
20:50:55 *** wluyima has quit IRC
20:52:15 *** wluyima has joined #openmrs
20:52:15 *** ChanServ sets mode: +v wluyima
20:55:25 <wluyima> andrew_sz: there existing tests in Database1_9To1_10UpgradeTest that you can look at for an example
20:55:40 <wluyima> andrew_sz: but never mind i will complete that ticket and add the test
20:56:03 *** jjyu has joined #openmrs
20:56:05 <wluyima> andrew_sz: what you have done is sufficient to unlock other tickets once i merge it,
20:56:27 <wluyima> andrew_sz: i will add the test
20:58:14 *** shubh has quit IRC
21:00:29 *** k-joseph_ has quit IRC
21:02:19 *** jjyu has quit IRC
21:08:34 *** suraj has quit IRC
21:16:28 *** GitHub21 has joined #openmrs
21:16:28 <GitHub21> [openmrs-core] NameFILIP opened pull request #780: TRUNK-4029: Hibernate config in parent pom.xml is outdated (master...TRUNK-4029) http://git.io/HiNDOw
21:16:28 *** GitHub21 has left #openmrs
21:17:45 *** mareias has joined #openmrs
21:21:56 *** djazayeri has quit IRC
21:24:41 <wluyima> andrew_sz: don't address the comments i have added, am going to address them
21:28:33 *** k-joseph has joined #openmrs
21:30:33 *** mareias has quit IRC
21:34:59 <andrew_sz> wluyima: oops, I've addressed them before reading the chat, can you please take a look at it (even if you wont merge it), because I'm curious that is it right what I've done?
21:36:47 *** wluyima has quit IRC
21:40:27 *** NameFILIP has quit IRC
21:44:26 *** NameFILIP has joined #openmrs
21:44:26 *** ChanServ sets mode: +v NameFILIP
21:45:57 <downey> suranga_: one week until LibrePlanet :)
21:47:13 *** NameFILIP has quit IRC
21:51:13 *** dkayiwa has quit IRC
21:57:40 *** jt48 has quit IRC
22:18:06 *** NameFILIP has joined #openmrs
22:18:06 *** ChanServ sets mode: +v NameFILIP
22:22:07 *** mareias has joined #openmrs
22:22:29 *** NameFILIP has quit IRC
22:22:37 *** aka_007 has quit IRC
22:22:47 *** GitHub78 has joined #openmrs
22:22:47 <GitHub78> [openmrs-core] coldcue opened pull request #781: TRUNK-4173: Refactor OrderService.getOrders (1.10.x...TRUNK-4173) http://git.io/o3KjPw
22:22:47 *** GitHub78 has left #openmrs
22:24:14 *** wluyima has joined #openmrs
22:24:14 *** ChanServ sets mode: +v wluyima
22:43:59 *** k-joseph has quit IRC
22:46:50 *** mareias has quit IRC
22:52:25 *** akashagarwal has quit IRC
23:15:52 *** akashagarwal has joined #openmrs
23:18:57 *** NameFILIP has joined #openmrs
23:18:57 *** ChanServ sets mode: +v NameFILIP
23:23:13 *** NameFILIP has quit IRC
23:30:22 *** ddesimone_ has quit IRC
23:47:51 *** rafa has quit IRC
23:48:29 *** wluyima has quit IRC
23:55:24 *** wluyima has joined #openmrs
23:55:24 *** ChanServ sets mode: +v wluyima
23:59:15 <andrew_sz> wluyima: are you here?