| 00:05:16 | *** cpower has quit IRC |
| 00:07:42 | <shubh> downey: any comments on my doubt? |
| 00:17:37 | *** jkeiper has quit IRC |
| 00:25:25 | *** ergaurav2 has quit IRC |
| 00:26:35 | *** ddesimone_ has quit IRC |
| 00:27:28 | *** wluyima has joined #openmrs |
| 00:27:29 | *** ChanServ sets mode: +v wluyima |
| 00:34:29 | *** kriks has quit IRC |
| 00:44:40 | *** dkithmal_ has quit IRC |
| 00:47:34 | *** lstanisic has quit IRC |
| 00:58:59 | *** sgithens has quit IRC |
| 01:03:59 | *** shubh has quit IRC |
| 01:07:49 | *** ayeung has quit IRC |
| 01:22:55 | *** shubh has joined #openmrs |
| 01:35:39 | *** shubh has quit IRC |
| 01:55:15 | *** suranga has quit IRC |
| 01:55:43 | *** gabbymoore has quit IRC |
| 02:20:11 | *** suranga has joined #openmrs |
| 02:21:31 | *** wluyima has quit IRC |
| 02:31:08 | *** Akshika47 has joined #openmrs |
| 02:34:25 | *** himangi has quit IRC |
| 02:35:19 | <downey> Akshika47: What can I do for you? |
| 02:35:32 | *** shubh has joined #openmrs |
| 02:36:38 | <Akshika47> @downey: it is about a pull request. which was made las 21st february. I am afraid the person viewing has forgotten it |
| 02:36:39 | <Akshika47> :) |
| 02:37:08 | <downey> Akshika47: Did you update the JIRA issue to status of Code Review? |
| 02:37:23 | <Akshika47> @downey: yes |
| 02:37:41 | <downey> Akshika47: OK, which is the JIRA project (aka issue number)? |
| 02:38:23 | <Akshika47> @downey : https://tickets.openmrs.org/browse/TRUNK-2873 this is the link, I put a message to the dev list too |
| 02:38:36 | <downey> Akshika47: OK, you've done all you need to do |
| 02:38:45 | <downey> Akshika47: You will be contacted in case of any follow up |
| 02:38:50 | <Akshika47> @downey: please bear with me if I am troubling. |
| 02:39:21 | <downey> Akshika47: There are currently 121 issues in code review, yours will be reviewed in due course. :) |
| 02:39:29 | <Akshika47> @downey: Thanks. please ask the person who is reviewing them to look at it |
| 02:39:32 | <downey> ... that's for the TRUNK project, there are of course other JIRA projects as well |
| 02:39:42 | <Akshika47> @downey: ohhhhhhhh |
| 02:39:49 | *** shubh has quit IRC |
| 02:39:54 | <Akshika47> @downey: I understand. It is okay |
| 02:40:04 | <Akshika47> @downey: sorry for disturbing |
| 02:40:16 | <downey> Akshika47: https://tickets.openmrs.org/browse/TRUNK#selectedTab=com.atlassian.jira.plugin.system.project%3Aissues-panel |
| 02:40:19 | <downey> No problem. :) |
| 02:40:48 | *** GitHub157 has joined #openmrs |
| 02:40:48 | <GitHub157> [openmrs-core] ehsdev opened pull request #703: TRUNK 4281: translate hard coded messages for cohorts (master...patch-1) http://git.io/jc1aSg |
| 02:40:48 | *** GitHub157 has left #openmrs |
| 03:00:06 | *** k-joseph has joined #openmrs |
| 03:32:38 | *** jkeiper has joined #openmrs |
| 03:32:38 | *** ChanServ sets mode: +v jkeiper |
| 03:42:56 | *** wluyima has joined #openmrs |
| 03:42:56 | *** ChanServ sets mode: +v wluyima |
| 03:47:34 | *** casygans has joined #openmrs |
| 03:57:05 | *** Akshika47 has quit IRC |
| 04:06:28 | <casygans> Hi suranga |
| 04:06:46 | <casygans> I need to talk to you about CDA generator suranga |
| 04:17:21 | *** endeepak has joined #openmrs |
| 04:29:39 | *** harshadura has joined #openmrs |
| 04:29:39 | *** ChanServ sets mode: +v harshadura |
| 04:33:06 | *** GitHub14 has joined #openmrs |
| 04:33:06 | <GitHub14> [openmrs-core] akshika47 opened pull request #704: Trunk-4139 (1.10.x...Trunk-4139.1) http://git.io/qcPNTA |
| 04:33:06 | *** GitHub14 has left #openmrs |
| 04:44:02 | *** Wobbity has joined #openmrs |
| 04:46:39 | *** Wobbity has quit IRC |
| 04:57:24 | *** endeepak has quit IRC |
| 05:11:01 | <k-joseph> wluyima: hi |
| 05:15:29 | *** k-joseph has quit IRC |
| 05:17:57 | *** coder006 has joined #openmrs |
| 05:19:01 | *** k-joseph has joined #openmrs |
| 05:19:08 | *** endeepak has joined #openmrs |
| 05:19:42 | <k-joseph> wluyima: i have left you a comment at https://github.com/openmrs/openmrs-core/pull/695/files#r10243253 that needs your quick response :) |
| 05:20:25 | *** dkayiwa has joined #openmrs |
| 05:21:12 | *** wluyima has quit IRC |
| 05:23:53 | *** upul has quit IRC |
| 05:39:40 | *** ergaurav2 has joined #openmrs |
| 05:40:39 | *** casygans has quit IRC |
| 06:03:36 | *** ergaurav2 has quit IRC |
| 06:04:18 | *** dkayiwa has quit IRC |
| 06:06:27 | *** shubh has joined #openmrs |
| 06:37:37 | *** jkeiper has quit IRC |
| 06:43:38 | *** GitHub112 has joined #openmrs |
| 06:43:38 | <GitHub112> [openmrs-core] akshika47 opened pull request #705: Solution for Trunk-4283 (1.10.x...Trunk-4283.2) http://git.io/qXKCrw |
| 06:43:38 | *** GitHub112 has left #openmrs |
| 07:03:18 | *** Vineet has joined #openmrs |
| 07:05:11 | *** elliott_w has quit IRC |
| 07:15:35 | *** harshadura has quit IRC |
| 07:27:43 | *** harshadura has joined #openmrs |
| 07:27:43 | *** ChanServ sets mode: +v harshadura |
| 07:31:37 | *** k-joseph has quit IRC |
| 07:31:51 | *** k-joseph has joined #openmrs |
| 07:45:20 | *** endeepak has quit IRC |
| 08:06:29 | *** Akshika47 has joined #openmrs |
| 08:16:28 | *** Vineet has quit IRC |
| 08:21:54 | *** shubh has quit IRC |
| 08:25:42 | *** endeepak has joined #openmrs |
| 08:37:18 | *** kriks has joined #openmrs |
| 09:05:27 | *** robbyoconnor has joined #openmrs |
| 09:05:27 | *** ChanServ sets mode: +v robbyoconnor |
| 09:09:33 | *** robbyoconnor has quit IRC |
| 09:09:57 | *** robbyoconnor has joined #openmrs |
| 09:09:57 | *** ChanServ sets mode: +v robbyoconnor |
| 09:10:05 | *** akwatuha_____ has joined #openmrs |
| 09:45:51 | *** dkayiwa has joined #openmrs |
| 09:47:02 | *** VaibhavAgarwal has joined #openmrs |
| 09:52:57 | *** ayeung has joined #openmrs |
| 09:58:39 | *** ergaurav2 has joined #openmrs |
| 10:09:44 | <k-joseph> dkayiwa: hi |
| 10:11:32 | <dkayiwa> k-joseph: hi |
| 10:19:20 | <k-joseph> dkayiwa: when writing atestcase how can i get the open form id, whose request url is /forms/formEdit.form?formId=5? |
| 10:19:52 | <k-joseph> dkayiwa: that is after i have this MockHttpServletRequest request = new MockHttpServletRequest("GET", "/forms/formEdit.form?formId=5"); |
| 10:20:25 | <k-joseph> dkayiwa: i was trying this: formService.getForm(5) which returns null |
| 10:20:25 | *** aka_007 has joined #openmrs |
| 10:20:54 | <Akshika47> dkayiwa: |
| 10:21:57 | <Akshika47> is there any special convention writting test case in this class "Database1_9To1_10Upgrade" |
| 10:21:58 | <Akshika47> ? |
| 10:23:42 | <dkayiwa> Akshika47: look at the existing ones |
| 10:24:12 | <Akshika47> dkayiwa: well there is a line called |
| 10:24:24 | <Akshika47> upgradeTestUtil.upgrade(); |
| 10:24:37 | <Akshika47> in every test case. it is bit confusing |
| 10:25:12 | <k-joseph> dkayiwa: my test case looks like http://pastebin.com/uPtXLq2Q |
| 10:27:56 | *** endeepak has quit IRC |
| 10:29:32 | <dkayiwa> k-joseph: in the test database, do you have a form with id 5 |
| 10:31:54 | *** GitHub172 has joined #openmrs |
| 10:31:54 | <GitHub172> [openmrs-core] dkayiwa closed pull request #704: Trunk-4139 (1.10.x...Trunk-4139.1) http://git.io/qcPNTA |
| 10:31:54 | *** GitHub172 has left #openmrs |
| 10:33:39 | *** GitHub77 has joined #openmrs |
| 10:33:39 | <GitHub77> [openmrs-core] dkayiwa closed pull request #703: TRUNK 4281: translate hard coded messages for cohorts (master...patch-1) http://git.io/jc1aSg |
| 10:33:39 | *** GitHub77 has left #openmrs |
| 10:36:28 | *** endeepak has joined #openmrs |
| 10:39:46 | *** pushkar has joined #openmrs |
| 10:42:00 | <k-joseph> dkayiwa: sorry, i had not looked well, i misglanced at form_field as form, issue fixed |
| 10:43:24 | *** ujjwal92 has joined #openmrs |
| 10:45:02 | <k-joseph> dkayiwa: looks like my FormFormControllerTest.xml file is not doing what i expected, :) |
| 10:48:34 | <ujjwal92> hi all |
| 10:49:35 | <ujjwal92> could aanybody pls change https://tickets.openmrs.org/browse/TRUNK-1931 to back to 'Ready to work'. I changed to 'Waiting on Information' by mistake |
| 10:50:27 | <dkayiwa> ujjwal92: done |
| 10:50:51 | <ujjwal92> dkayiwa: thanks |
| 11:01:58 | *** kriks has quit IRC |
| 11:05:29 | *** k-joseph has quit IRC |
| 11:21:03 | *** Akshika47 has quit IRC |
| 11:25:14 | *** tyro has joined #openmrs |
| 11:35:50 | *** Akshika47 has joined #openmrs |
| 11:39:10 | <tyro> hello |
| 11:39:23 | *** VaibhavAgarwal has quit IRC |
| 11:40:05 | <tyro> can someone help me contact Jeremy Keiper |
| 11:46:57 | <Akshika47> dkayiwa: |
| 11:58:32 | *** coder006 has quit IRC |
| 12:05:25 | *** GitHub97 has joined #openmrs |
| 12:05:25 | <GitHub97> [openmrs-core] dkayiwa closed pull request #700: TRUNK-3293 error checking to relationship start/end dates (master...Trunk-3293) http://git.io/hAlSbg |
| 12:05:25 | *** GitHub97 has left #openmrs |
| 12:11:09 | *** tyro has quit IRC |
| 12:29:18 | *** GitHub63 has joined #openmrs |
| 12:29:18 | <GitHub63> [openmrs-core] akshika47 opened pull request #706: Trunk-4139 (1.10.x...Trunk-4139new) http://git.io/TwoCHw |
| 12:29:18 | *** GitHub63 has left #openmrs |
| 12:30:52 | *** elly__ has joined #openmrs |
| 12:36:47 | *** GitHub19 has joined #openmrs |
| 12:36:47 | <GitHub19> [openmrs-core] dkayiwa pushed 2 new commits to master: http://git.io/gagJlg |
| 12:36:47 | <GitHub19> openmrs-core/master e82fcb1 Akash Agrawall: Trunk-377 Clarify required fields on management interfaces |
| 12:36:47 | <GitHub19> openmrs-core/master db7520a dkayiwa: Merge pull request #688 from aka001/TRUNK-377... |
| 12:36:47 | *** GitHub19 has left #openmrs |
| 12:36:47 | *** GitHub115 has joined #openmrs |
| 12:36:47 | <GitHub115> [openmrs-core] dkayiwa closed pull request #688: Trunk-377 Clarify required fields on management interfaces (master...TRUNK-377) http://git.io/Bk6QjA |
| 12:36:47 | *** GitHub115 has left #openmrs |
| 12:43:01 | <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-MASTER-322 has FAILED (1 tests failed) : Updated by dkayiwa <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-322> |
| 12:46:52 | *** travis-ci has joined #openmrs |
| 12:46:52 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [db7520a] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/20049650 |
| 12:46:52 | *** travis-ci has left #openmrs |
| 12:48:06 | *** himangi has joined #openmrs |
| 12:50:14 | *** ujjwal92 has quit IRC |
| 12:50:15 | <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-MASTER-322 has FAILED (2 tests failed) : Rebuilt 1 times <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-322> |
| 12:55:38 | *** Akshika47 has quit IRC |
| 12:57:37 | *** ergaurav2 has quit IRC |
| 12:58:26 | *** GitHub140 has joined #openmrs |
| 12:58:26 | <GitHub140> [openmrs-core] dkayiwa pushed 2 new commits to master: http://git.io/V-NXMA |
| 12:58:27 | <GitHub140> openmrs-core/master bcb0833 vaibhav-hp: Add helpful text next to mappings on Concept Edit page |
| 12:58:27 | <GitHub140> openmrs-core/master 94e63de dkayiwa: Merge pull request #702 from vaibhav-hp/TRUNK-1743... |
| 12:58:27 | *** GitHub140 has left #openmrs |
| 12:58:31 | *** GitHub94 has joined #openmrs |
| 12:58:32 | <GitHub94> [openmrs-core] dkayiwa closed pull request #702: Add helpful text next to mappings on Concept Edit page (master...TRUNK-1743) http://git.io/jO2s5g |
| 12:58:32 | *** GitHub94 has left #openmrs |
| 13:00:58 | *** aka_007 has quit IRC |
| 13:01:02 | *** jkeiper has joined #openmrs |
| 13:01:02 | *** ChanServ sets mode: +v jkeiper |
| 13:03:20 | *** himangi has quit IRC |
| 13:08:11 | *** travis-ci has joined #openmrs |
| 13:08:11 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [94e63de] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/20051147 |
| 13:08:11 | *** travis-ci has left #openmrs |
| 13:10:06 | *** k-joseph has joined #openmrs |
| 13:10:32 | <k-joseph> dkayiwa: hi |
| 13:10:48 | <dkayiwa> k-joseph: hi |
| 13:11:35 | *** aka_007 has joined #openmrs |
| 13:13:01 | *** endeepak has quit IRC |
| 13:13:31 | *** endeepak has joined #openmrs |
| 13:13:46 | <k-joseph> dkayiwa: writting the FormFormControllerTest but has some issue, trying to troubleshoot the issue shows me that my FormFormControllerTest.xml isn't working well, any help on how to look much into so as to correct it will be highly appreciated |
| 13:14:36 | *** elliott_w has joined #openmrs |
| 13:14:36 | *** ChanServ sets mode: +o elliott_w |
| 13:15:13 | <dkayiwa> k-joseph: what does not working well mean |
| 13:15:45 | *** sashrika has joined #openmrs |
| 13:15:54 | *** ChanServ sets mode: +v sashrika |
| 13:16:40 | *** GitHub87 has joined #openmrs |
| 13:16:40 | <GitHub87> [openmrs-core] dkayiwa pushed 2 new commits to master: http://git.io/nMOvyA |
| 13:16:40 | <GitHub87> openmrs-core/master c8f1a82 ShubhamRai: TRUNK-4148 Providers are no longer listed by default |
| 13:16:40 | <GitHub87> openmrs-core/master 8e10c46 dkayiwa: Merge pull request #685 from ShubhamRai/TRUNK-4148... |
| 13:16:40 | *** GitHub87 has left #openmrs |
| 13:16:40 | *** GitHub129 has joined #openmrs |
| 13:16:40 | <GitHub129> [openmrs-core] dkayiwa closed pull request #685: TRUNK-4148 Providers are no longer listed by default (master...TRUNK-4148) http://git.io/dwHabg |
| 13:16:40 | *** GitHub129 has left #openmrs |
| 13:18:02 | *** jkeiper has quit IRC |
| 13:18:02 | *** jkeiper has joined #openmrs |
| 13:18:02 | *** morgan.freenode.net sets mode: +v jkeiper |
| 13:18:03 | *** elliott_w has quit IRC |
| 13:18:03 | *** elliott_w has joined #openmrs |
| 13:18:03 | *** dickson.freenode.net sets mode: +o elliott_w |
| 13:18:03 | *** sashrika has quit IRC |
| 13:18:03 | *** sashrika has joined #openmrs |
| 13:18:03 | *** herbert.freenode.net sets mode: +v sashrika |
| 13:23:11 | <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-MASTER-325 has FAILED (1 tests failed) : Updated by dkayiwa <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-325> |
| 13:27:05 | *** ergaurav2 has joined #openmrs |
| 13:27:39 | *** travis-ci has joined #openmrs |
| 13:27:39 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [8e10c46] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/20052384 |
| 13:27:39 | *** travis-ci has left #openmrs |
| 13:29:49 | *** TR_ has joined #openmrs |
| 13:30:10 | *** TR_ has left #openmrs |
| 13:33:14 | <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-MASTER-325 has FAILED (2 tests failed) : Rebuilt 1 times <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-325> |
| 13:41:09 | <k-joseph> dkayiwa: to explain my issue, here is my unit test http://pastebin.com/5PfZABxr , i request you examine it, i expected the gp to be set to any value i offer it in the xml file above, but this is not sorking as i expected, what could be the problem |
| 13:42:35 | <dkayiwa> k-joseph: what do you mean by it is not sorting as expected? |
| 13:43:24 | *** shubh has joined #openmrs |
| 13:44:50 | <k-joseph> dkayiwa: sorry, i meant not working as i expected :) |
| 13:44:51 | <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-MASTER-326 has FAILED (2 tests failed) : Manual build by Daniel Kayiwa <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-326> |
| 13:46:19 | *** GitHub61 has joined #openmrs |
| 13:46:19 | <GitHub61> [openmrs-core] coldcue opened pull request #707: TRUNK-4286: OrderType classes, xml added and hibernate configuration added (master...TRUNK-4286) http://git.io/wAtLHA |
| 13:46:19 | *** GitHub61 has left #openmrs |
| 13:47:48 | *** andrew_sz has joined #openmrs |
| 13:50:21 | <dkayiwa> k-joseph: what is the expected? |
| 13:52:07 | <k-joseph> dkayiwa: when the gp value is true, i expected the forms to be locked and thus inability to delete or save a form for this is what is seen when practically running it, and when false the oposite |
| 13:56:25 | *** GitHub120 has joined #openmrs |
| 13:56:25 | <GitHub120> [openmrs-core] dkayiwa pushed 1 new commit to 1.10.x: http://git.io/dPpuiQ |
| 13:56:25 | <GitHub120> openmrs-core/1.10.x db284a1 dkayiwa: Using getReturnedClass for: Add missing CRUD methods for Order... |
| 13:56:25 | *** GitHub120 has left #openmrs |
| 13:58:00 | *** GitHub19 has joined #openmrs |
| 13:58:00 | <GitHub19> [openmrs-core] ehsdev opened pull request #708: TRUNK 4281: translate hard coded messages for cohorts (1.9.x...1.9.x) http://git.io/RhnRuA |
| 13:58:00 | *** GitHub19 has left #openmrs |
| 14:02:02 | *** GitHub42 has joined #openmrs |
| 14:02:02 | <GitHub42> [openmrs-core] dkayiwa closed pull request #708: TRUNK 4281: translate hard coded messages for cohorts (1.9.x...1.9.x) http://git.io/RhnRuA |
| 14:02:02 | *** GitHub42 has left #openmrs |
| 14:02:16 | <k-joseph> dkayiwa: !!! |
| 14:09:21 | <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-ONEPOINTTENX-143 has FAILED (2 tests failed) : Updated by dkayiwa <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-143> |
| 14:13:29 | *** wluyima has joined #openmrs |
| 14:13:29 | *** ChanServ sets mode: +v wluyima |
| 14:14:34 | <andrew_sz> hmm, wiki.openmrs.org is not working |
| 14:15:46 | <andrew_sz> nothing. its back |
| 14:23:27 | <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-ONEPOINTTENX-143 has FAILED (2 tests failed) : Updated by dkayiwa <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-143> || TRUNK-MASTER-326 has FAILED (2 tests failed) : Manual build by Daniel Kayiwa <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-326> || TRUNK-MASTER-325 has FAILED (2 tests failed) : Rebuilt 1 times <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-325> || TRUNK-MASTER-322 has FAILED (2 tests failed) : Rebuilt 1 times <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-322> || RESTWS-RESTWS-122 has FAILED : Dependant of TRUNK-LATEST-143 <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-122> || LOGIC-LOGIC-46 has FAILED : Dependant of TRUNK-LATEST-143 <https://ci-stg.openmrs.org/browse/LOGIC-LOGIC-46> || TRUNK-MASTER-321 has FAILED (2 tests failed) : Rebuilt 1 times <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-321> || TRUNK-ONEPOINTTENX-140 has FAILED (2 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-140> || SON-OPENMRSCOREMASTER-163 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-163> || SON-OPENMRSCOREMASTER-162 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-162> || EMRAPI-EMRAPI-497 has FAILED (1 tests failed) : Dependant of REP-REP-250 <https://ci-stg.openmrs.org/browse/EMRAPI-EMRAPI-497> || SON-OPENMRSCOREMASTER-161 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-161> || SON-OPENMRSCOREMASTER-160 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-160> || TRUNK-ONEPOINTTENX-137 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-137> || SON-OPENMRSCOREMASTER-159 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-159> || REP-REP-241 has FAILED (5 tests failed) : Updated by Michael Seaton <https://ci-stg.openmrs.org/browse/REP-REP-241> || SON-OPENMRSCOREMASTER-158 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-158> || REP-REP-236 has FAILED (1 tests failed) : Updated by Michael Seaton <https://ci-stg.openmrs.org/browse/REP-REP-236> |
| 14:25:52 | <jkeiper> hi ppl |
| 14:32:52 | *** lstanisic has joined #openmrs |
| 14:33:37 | *** dkayiwa has quit IRC |
| 14:52:16 | *** dkithmal has joined #openmrs |
| 15:04:41 | *** harsz89 has joined #openmrs |
| 15:04:41 | *** ChanServ sets mode: +v harsz89 |
| 15:07:30 | <wluyima> !scrumon |
| 15:07:30 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster - you may begin when ready. |
| 15:09:11 | <wluyima> order: elliott_w , k-joseph, and daniel if he is online and anyone else who has an update, |
| 15:09:19 | *** LeeBreisacher has joined #openmrs |
| 15:10:31 | *** DrSeus has joined #openmrs |
| 15:10:52 | <k-joseph> wluyima: i guess the order matters |
| 15:10:53 | *** DrSeus has quit IRC |
| 15:12:19 | <wluyima> yes |
| 15:12:25 | <wluyima> elliott_w: ? |
| 15:15:32 | <wluyima> ok k-joseph you can give your update |
| 15:16:18 | <k-joseph> 04/3/2014 |
| 15:16:27 | <k-joseph> 1. For the Order entry sprint {Made a commit in response to wluyima 's comment on TRUNK-4274, ticket in code review state} |
| 15:16:27 | <k-joseph> 2. For the current branch 1.11* {Worked on the remaining part of TRUNK-4030} |
| 15:16:27 | <k-joseph> 4. Fixing my mind on GsoC proposal :) |
| 15:16:48 | <k-joseph> Blockers: None |
| 15:16:53 | <wluyima> k-joseph: ok |
| 15:16:58 | <wluyima> Monday: |
| 15:16:59 | <wluyima> - Code review and merge pull requests |
| 15:17:01 | <wluyima> - design call |
| 15:17:02 | <wluyima> - Curate order type tickets |
| 15:17:04 | <wluyima> - Worked on - TRUNK-4276 - Changesets that convert units from text to concept should use a file and not a global property |
| 15:17:05 | <wluyima> Tuesday: |
| 15:17:06 | <wluyima> - Code review and merge pull requests |
| 15:17:08 | <wluyima> - order entry bi weekly call |
| 15:17:09 | <wluyima> - Complete - TRUNK-4276 - Changesets that convert units from text to concept should use a file and not a global property |
| 15:17:09 | <wluyima> Blockers: None |
| 15:17:13 | *** cpower has joined #openmrs |
| 15:17:14 | *** ChanServ sets mode: +v cpower |
| 15:17:24 | <cpower> Hello! |
| 15:17:29 | <cpower> Sorry I'm late |
| 15:17:35 | <cpower> Are we ready to scrum? |
| 15:17:52 | <cpower> !scrumon cpower |
| 15:17:52 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 15:18:05 | <wluyima> cpower: we were scrumming |
| 15:18:12 | <cpower> ahh cool |
| 15:18:15 | <cpower> ;-) |
| 15:18:19 | <wluyima> cpower: and i was about about to stop it |
| 15:18:24 | <cpower> ok |
| 15:18:27 | <wluyima> !scrumoff |
| 15:18:27 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:18:57 | *** ergaurav2 has quit IRC |
| 15:19:13 | *** robbyoconnor has quit IRC |
| 15:20:16 | *** sgithens has joined #openmrs |
| 15:26:52 | <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1814 has FAILED : Rebuilt 1 times <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1814> |
| 15:29:55 | *** elly__ has quit IRC |
| 15:30:11 | *** ergaurav2 has joined #openmrs |
| 15:30:43 | *** GitHub26 has joined #openmrs |
| 15:30:43 | <GitHub26> [openmrs-core] alexisduque opened pull request #709: Trunk 4282: Orders.orderer should be required (1.10.x...TRUNK-4282) http://git.io/EspJ9w |
| 15:30:43 | *** GitHub26 has left #openmrs |
| 15:31:07 | *** aka_007 has quit IRC |
| 15:32:36 | *** k-joseph has quit IRC |
| 15:44:50 | *** skathpalia has joined #openmrs |
| 15:45:24 | *** skathpalia has left #openmrs |
| 15:56:18 | *** GitHub29 has joined #openmrs |
| 15:56:18 | <GitHub29> [openmrs-core] wluyima closed pull request #707: TRUNK-4286: OrderType classes, xml added and hibernate configuration added (master...TRUNK-4286) http://git.io/wAtLHA |
| 15:56:18 | *** GitHub29 has left #openmrs |
| 15:59:08 | *** saumya has joined #openmrs |
| 16:00:01 | *** saumya has joined #openmrs |
| 16:00:47 | *** saumya has joined #openmrs |
| 16:01:08 | *** saumya has joined #openmrs |
| 16:02:15 | *** sam95 has joined #openmrs |
| 16:02:25 | *** saumya has quit IRC |
| 16:04:48 | *** Akshika47 has joined #openmrs |
| 16:05:50 | *** Akshika47_ has joined #openmrs |
| 16:08:59 | *** Akshika47 has quit IRC |
| 16:10:56 | *** sam95 has quit IRC |
| 16:14:31 | *** sam95 has joined #openmrs |
| 16:22:02 | *** GitHub66 has joined #openmrs |
| 16:22:02 | <GitHub66> [openmrs-core] ehsdev opened pull request #710: TRUNK 4281: translate hard coded messages for cohorts (1.9.x...1.9.x) http://git.io/7X3eKw |
| 16:22:02 | *** GitHub66 has left #openmrs |
| 16:22:41 | <shubh> harsz89: i have a doubt.When creating a patient, we can assign different values to the same identifier type.Is this behaviour correct? |
| 16:26:39 | <harsz89> shubh, mhhh |
| 16:26:47 | <harsz89> shubh, wht u mean by different values? |
| 16:27:25 | <harsz89> shubh, as far as the identifier correctly validate it, it should be correct |
| 16:27:26 | <shubh> harsz89: how can one patient have more than one value for the same identifier type? |
| 16:29:21 | *** dkithmal has quit IRC |
| 16:29:45 | *** dkithmal has joined #openmrs |
| 16:31:03 | <harsz89> shubh, mhhh um not familiar about that use case :( |
| 16:31:18 | <harsz89> shubh, i assume u mean one patient having different identifiers |
| 16:32:10 | <shubh> harsz89: no i mean the option of adding the same identifier again and again on the patient create page and giving different values to it |
| 16:32:45 | <harsz89> shubh, yeap i have seen it, not know about the use case of it :( |
| 16:33:35 | <downey> shubh: Did you have an actual question? |
| 16:34:24 | <shubh> harsz89: my question is this intentional or is this a bug? |
| 16:34:46 | <shubh> downey: sry i addressed harsz89 |
| 16:34:55 | *** kriks has joined #openmrs |
| 16:35:09 | <harsz89> downey, his question is |
| 16:35:30 | <harsz89> downey, letz say if some one add two patient identifiers in same type |
| 16:35:33 | <downey> shubh: As I mentioned last night, if you think it's a bug, you should create a bug report for it describing what you expect to happen vs. what actually happens :) |
| 16:35:40 | <harsz89> downey, what will be the use of it :) |
| 16:36:16 | <harsz89> downey, it can be two Old Identification Numbers for same patient :) |
| 16:37:30 | <shubh> downey: ok i'll create a bug report describing what i expect to happen |
| 16:37:37 | <downey> shubh: Thanks :) |
| 16:46:59 | *** dkithmal has quit IRC |
| 16:51:13 | *** sam95 has quit IRC |
| 17:03:33 | *** djazayeri has joined #openmrs |
| 17:03:33 | *** ChanServ sets mode: +o djazayeri |
| 17:10:37 | *** GitHub100 has joined #openmrs |
| 17:10:37 | <GitHub100> [openmrs-core] coldcue opened pull request #711: TRUNK-4286: OrderType classes, xml and hibernate configuration added (1.10.x...TRUNK-4286) http://git.io/7TtcIg |
| 17:10:37 | *** GitHub100 has left #openmrs |
| 17:13:58 | *** Akshika47_ has quit IRC |
| 17:15:18 | *** harshadura has quit IRC |
| 17:15:56 | *** endeepak has joined #openmrs |
| 17:16:34 | *** andrew_sz has quit IRC |
| 17:16:48 | *** andrew_sz has joined #openmrs |
| 17:28:46 | *** harshadura has joined #openmrs |
| 17:28:46 | *** ChanServ sets mode: +v harshadura |
| 17:29:38 | *** sam95 has joined #openmrs |
| 17:36:18 | *** harshadura has quit IRC |
| 17:45:50 | *** Anushya__ has joined #openmrs |
| 17:52:38 | *** endeepak has quit IRC |
| 17:53:06 | *** Anushya has quit IRC |
| 17:53:08 | *** Anushya__ is now known as Anushya |
| 17:54:34 | *** ujjwal92 has joined #openmrs |
| 18:11:40 | *** harsz89 has quit IRC |
| 18:19:00 | *** robbyoconnor has joined #openmrs |
| 18:19:00 | *** ChanServ sets mode: +v robbyoconnor |
| 18:19:36 | *** aka_007 has joined #openmrs |
| 18:33:20 | *** akwatuha_____ has quit IRC |
| 18:35:36 | *** aka_007 has quit IRC |
| 18:47:58 | *** robbyoconnor has quit IRC |
| 18:50:44 | *** k-joseph has joined #openmrs |
| 18:53:30 | *** lbat has joined #openmrs |
| 19:00:49 | *** k-joseph has quit IRC |
| 19:06:53 | *** sashrika has quit IRC |
| 19:07:45 | <lbat> Hi, started to work on the following ticket (https://tickets.openmrs.org/browse/TRUNK-4166)... I am not sure wich branch I should commit to - master or 1.9.x? |
| 19:07:52 | <andrew_sz> Hi, I have a strange problem, when I'd like to test the API in the original 1.10.x branch, I get these errors: https://gist.github.com/coldcue/9353342 |
| 19:08:02 | <andrew_sz> What should I do to make it run? |
| 19:08:13 | <andrew_sz> Skip tests maybe? |
| 19:08:38 | <ergaurav2> hello all |
| 19:08:44 | <ergaurav2> I am trying to add a patient |
| 19:13:43 | *** aka_007 has joined #openmrs |
| 19:26:22 | *** LeeBreisacher has left #openmrs |
| 19:36:02 | <jkeiper> andrew_sz: you can try to run one of those tests and see why it fails ... |
| 19:36:25 | <jkeiper> andrew_sz: if you -DskipTests=true then you might miss something important |
| 19:38:05 | <jkeiper> lbat: I would test the problem against trunk (master) and if it still exists, make a pull request based on a branch from master |
| 19:38:45 | <ergaurav2> Hello all |
| 19:38:53 | <jkeiper> lbat: if trunk (master) has already solved the problem, then perhaps find the changeset that fixed it or checkout a branch of 1.9.x for your code |
| 19:38:58 | <jkeiper> ergaurav2: hi |
| 19:39:01 | <ergaurav2> I am trying to add the new Patient but it's not getting adding |
| 19:39:06 | <ergaurav2> *added |
| 19:39:21 | <jkeiper> ergaurav2: what version of OpenMRS and how are you adding the patient? |
| 19:40:32 | <ergaurav2> @jkeiper: I have taken the checkout from the git |
| 19:40:42 | <ergaurav2> I guess it's a latest code |
| 19:41:04 | <jkeiper> ergaurav2: so you are using master / 1.11-SNAPSHOT? |
| 19:42:03 | <lbat> jkeiper: thx - problem still exists in master... will solve it based on master |
| 19:42:11 | <aka_007> ergaurav2, yaa I too have faced the same problem. |
| 19:42:14 | <jkeiper> lbat: great, thanks! |
| 19:42:22 | <ergaurav2> @jkeiper yes, I have adding it using the admin login in the page : http://localhost:8080/openmrs/admin/person/addPerson.htm?personType=patient&viewType=edit |
| 19:42:43 | <jkeiper> ergaurav2: that is for adding a person ... you want to add a patient? |
| 19:42:44 | <aka_007> ergaurav2, lbat but it gets added when trying to add from find/create patient button. So I guess you can do it now easily |
| 19:42:54 | <jkeiper> ergaurav2: ah i see, personType=patient |
| 19:43:02 | <jkeiper> ergaurav2: try registering a new patient through registration |
| 19:43:27 | <ergaurav2> jkeiper: you mean adding a new user ? |
| 19:43:28 | <aka_007> jkeiper, there is some bug in it. using find/create patient button we can register a patient easily. |
| 19:43:51 | <jkeiper> aka_007: interesting ... has the bug been filed? |
| 19:44:07 | <aka_007> jkeiper, I filed it. but it's under needs assessment. :( |
| 19:44:13 | <jkeiper> aka_007: ok |
| 19:44:55 | <ergaurav2> @ aka_007 yeah you are right ! |
| 19:45:03 | <aka_007> ergaurav2, :) |
| 19:45:34 | <ergaurav2> same problem in adding a person |
| 19:45:43 | <ergaurav2> @aka_007 have you noticed it ? |
| 19:46:39 | <aka_007> ergaurav2, yaa. I was fixing a bug regarding patient when I noticed it. I have filed it. it's under "needs assessment" category, it will be assessed by mentors and be given the status "ready for work". |
| 19:47:02 | <ergaurav2> @aka_007, ohkk gr8 !!! |
| 19:47:09 | <aka_007> ergaurav2, :) |
| 19:50:31 | <ergaurav2> Hey I have created a new user |
| 19:50:43 | <ergaurav2> and when I click on the Find Patient it gives me a error |
| 19:50:48 | <ergaurav2> Insufficient Privileges |
| 19:53:49 | <aka_007> ergaurav2, you have logged in with username: admin and password: Admin123 , right? |
| 19:55:15 | <aka_007> ergaurav2, between you are from which university. Your IP and my IP exactly matches. ?? |
| 19:55:37 | <aka_007> ergaurav2, :p |
| 19:56:29 | *** ergaurav2 has quit IRC |
| 20:00:58 | *** coder006 has joined #openmrs |
| 20:01:18 | <coder006> nribeka: there? |
| 20:01:32 | <nribeka> hi coder006 |
| 20:01:41 | <coder006> hi |
| 20:02:11 | <coder006> what would be better |
| 20:02:12 | <coder006> ? |
| 20:02:42 | <coder006> as in to fix a bug first or to get familiar with the development using grails and rest api |
| 20:02:43 | <coder006> ? |
| 20:05:33 | *** kriks has quit IRC |
| 20:07:38 | <coder006> nribeka: there? |
| 20:12:17 | <coder006> nribeka: one more question...pull request has to be sent to openmrs-core? |
| 20:13:13 | *** sam95 has quit IRC |
| 20:13:48 | <aka_007> coder006, yes. |
| 20:14:06 | <nribeka> coder006: you probably should learn more about openmrs |
| 20:14:13 | <nribeka> look for tickets around openmrs |
| 20:14:26 | <nribeka> this project is external to openmrs and might not get selected :) |
| 20:16:09 | <coder006> nribeka: what are the possibilities? |
| 20:16:33 | <nribeka> the priority will be project for openmrs |
| 20:16:51 | *** ergaurav2 has joined #openmrs |
| 20:17:25 | <coder006> nribeka: any other organization as well under openmrs? |
| 20:17:34 | <nribeka> just openmrs |
| 20:17:43 | <coder006> nribeka: and what are the high priority projects? |
| 20:17:46 | <coder006> nribeka: i am trying to learn about it for past one week |
| 20:17:53 | *** dkayiwa has joined #openmrs |
| 20:17:55 | <coder006> nribeka: even learned grails for it |
| 20:18:42 | <nribeka> coder006: ? |
| 20:19:04 | <coder006> nribeka: the mobile device monitoring system |
| 20:19:19 | <coder006> nribeka: i talked to u about it 2-3 days ago |
| 20:19:26 | <coder006> nribeka: when u updated the ideas page |
| 20:21:11 | <nribeka> coder006: those are the potential projects. there is no guarantee that each of the project will be selected |
| 20:21:20 | <nribeka> i think you're starting on the wrong foot here |
| 20:21:43 | <nribeka> you need to realize the idea behind gsoc is to engage student with open source project |
| 20:21:58 | <nribeka> this is not a job that will make money |
| 20:27:22 | <jkeiper> :-D |
| 20:27:34 | <coder006> nribeka: i understand that...i think i misunderstood |
| 20:27:56 | <coder006> nribeka: i thought u were trying to say that this project is not of priority to openmrs |
| 20:30:36 | *** GitHub143 has joined #openmrs |
| 20:30:36 | <GitHub143> [openmrs-core] dkayiwa reopened pull request #661: [#TRUNK-4030] locking mechanism for form_id (master...TRUNK-4030) http://git.io/CZxLrA |
| 20:30:36 | *** GitHub143 has left #openmrs |
| 20:31:26 | <coder006> nribeka: both TRUNK and FRM are open for bug fixing? |
| 20:32:49 | <nribeka> yep, you can browse https://tickets.openmrs.org |
| 20:33:33 | *** GitHub148 has joined #openmrs |
| 20:33:33 | <GitHub148> [openmrs-core] dkayiwa closed pull request #661: [#TRUNK-4030] locking mechanism for form_id (master...TRUNK-4030) http://git.io/CZxLrA |
| 20:33:33 | *** GitHub148 has left #openmrs |
| 20:35:50 | <aka_007> dkayiwa, I have noticed a bug in openmrs 1.11.x . It is in "needs assessment" phase. Can I start working on it? It's much noticeable. If you want I can explain the bug to you. |
| 20:35:52 | <aka_007> nribeka, I didn't get you. ? |
| 20:36:20 | <dkayiwa> aka_007: which ticket url? |
| 20:36:21 | <nribeka> aka_007: ? |
| 20:37:43 | <aka_007> dkayiwa, https://tickets.openmrs.org/browse/TRUNK-4269 |
| 20:38:15 | <aka_007> nribeka, I am talking about a ticket with "needs assessment" status .. :) |
| 20:43:30 | <dkayiwa> aka_007: does this still happen after discarding any local changes that you may have? |
| 20:44:00 | <aka_007> dkayiwa, yes this was also reported by ergaurav2 in irc today. |
| 20:44:29 | <aka_007> dkayiwa, this bug is also reproduced by harsz89 . |
| 20:44:33 | <aka_007> !seen harsz89 |
| 20:44:33 | <OpenMRSBot> aka_007: harsz89 was last seen in #openmrs 4 hours, 8 minutes, and 16 seconds ago: <harsz89> downey, it can be two Old Identification Numbers for same patient :) |
| 20:44:48 | *** ujjwal92 has quit IRC |
| 20:45:51 | <dkayiwa> aka_007: checking it out on my master now |
| 20:46:00 | <aka_007> dkayiwa, okay. :) |
| 20:49:50 | <aka_007> dkayiwa, I am stuck on a small area. Kindly reply when you are free. |
| 20:58:49 | *** VaibhavAgarwal has joined #openmrs |
| 21:00:25 | <aka_007> dkayiwa, I have updated the description https://tickets.openmrs.org/browse/TRUNK-4269, making the bug more specific. :) |
| 21:01:02 | *** dkithmal has joined #openmrs |
| 21:02:43 | <dkayiwa> aka_007: which button do you click to get the blank page? |
| 21:03:08 | *** VaibhavAgarwal has quit IRC |
| 21:03:42 | <aka_007> dkayiwa, the button "Create Person" on this page http://localhost:8080/openmrs/admin/person/addPerson.htm?personType=patient&viewType=edit |
| 21:04:53 | <dkayiwa> aka_007: it works very well for me |
| 21:05:14 | <dkayiwa> aka_007: i think you have local changes which cause the bug |
| 21:06:50 | <aka_007> dkayiwa, Are you creating the patient from this URL http://localhost:8080/openmrs/findPatient.htm |
| 21:08:06 | <aka_007> dkayiwa, this error is reproduced by some other people also. |
| 21:08:27 | <aka_007> dkayiwa, try creating the patient from this page http://localhost:8080/openmrs/admin/person/addPerson.htm?personType=patient&viewType=edit |
| 21:09:36 | <dkayiwa> aka_007: i go to the administration page |
| 21:09:45 | <dkayiwa> aka_007: then select Manage Persons |
| 21:09:51 | <aka_007> dkayiwa, nooo |
| 21:09:54 | <dkayiwa> aka_007: then Create Person |
| 21:10:01 | <aka_007> dkayiwa, click on find Patient -> create patient |
| 21:10:05 | <dkayiwa> aka_007: did you include the exact steps on the ticket? |
| 21:10:15 | <aka_007> dkayiwa, extremely sorry for that. |
| 21:10:19 | <aka_007> dkayiwa, doing it |
| 21:11:50 | <aka_007> dkayiwa, updated https://tickets.openmrs.org/browse/TRUNK-4269 |
| 21:14:11 | <ergaurav2> @dkayiwa One point to add I have not add made any local changes and get this bug |
| 21:15:02 | <dkayiwa> ergaurav2: aka_007 had not included the steps for reproducing the bug |
| 21:15:49 | <aka_007> dkayiwa, I have included the steps now in the beg. Sorry for the inconvinience caused. |
| 21:16:35 | <ergaurav2> dkayiwa, ohh, okk |
| 21:16:49 | <aka_007> dkayiwa, **bug |
| 21:17:20 | <dkayiwa> aka_007: i have followed your steps and reproduced it. So just make it Ready for Work |
| 21:17:30 | <dkayiwa> make = made |
| 21:17:50 | <ergaurav2> I am using the Add User module, it also allows to Use a person who already exists And in the box |
| 21:18:11 | <ergaurav2> we are allowed to "Enter person name or id" |
| 21:18:27 | <aka_007> dkayiwa, okay I will start working on it. thanx for reviewing it. If you are free can you answer one more query? |
| 21:18:27 | <ergaurav2> But it's not taking the id (working fine for person name) |
| 21:18:50 | *** wluyima has quit IRC |
| 21:19:41 | <ergaurav2> For me, it's a kind of bug, can anyone please confirm ? |
| 21:24:50 | <ergaurav2> @aka_007 can we directly add on JIRA if we think it's a kind of bug ? |
| 21:25:44 | <aka_007> ergaurav2, yes you can, mention the exact steps required to reproduce the bug. So that it can be reviewed early and with ease by mentors. |
| 21:26:00 | *** djazayeri has quit IRC |
| 21:26:40 | <ergaurav2> @aka_007, can we also add the enhancements ? |
| 21:29:29 | *** sgithens has quit IRC |
| 21:31:58 | <shubh> dkayiwa: i am working on https://tickets.openmrs.org/browse/TRUNK-3254. I am not able to find addIdentifierCriteria method in PatientSearchCriteria. |
| 21:35:52 | <aka_007> dkayiwa, I have added the problem I am facing in the ticket https://tickets.openmrs.org/browse/TRUNK-2224. Kindly have a look whenever you are free. :) |
| 21:36:38 | <dkayiwa> shubh: you are right. Wolf Schlegel greatly refactored and tested it. So he addressed all of it. Just closed the ticket |
| 21:39:28 | <shubh> dkayiwa: there is a similar ticket https://tickets.openmrs.org/browse/TRUNK-3255. Does this need any work? |
| 21:43:16 | <dkayiwa> shubh: no work. i have closed it too. thanks :) |
| 21:43:48 | <shubh> dkayiwa: happy to help :) |
| 21:51:55 | <aka_007> dkayiwa, you there.? |
| 21:52:01 | <dkayiwa> aka_007: yes |
| 21:53:07 | <aka_007> dkayiwa, I have added the problem I am facing in the comments of the ticket https://tickets.openmrs.org/browse/TRUNK-2224. Please have a look at it. |
| 21:54:25 | <dkayiwa> aka_007: ok |
| 21:56:09 | <aka_007> ergaurav2, the bug does affect openmrs version 1.11 only. So kindly don't change the version I have mentioned in the ticket. :) |
| 22:02:54 | <dkayiwa> aka_007: i dot not seem to understand your problem |
| 22:03:51 | <Anushya_> dkayiwa> are you there? |
| 22:04:02 | <dkayiwa> Anushya_: yes |
| 22:04:16 | <Anushya_> I need to set up some time with you, Jonathan to talk over Allergies |
| 22:04:24 | <Anushya_> Does 10amEST work for you? |
| 22:04:52 | <dkayiwa> Anushya_: ummmmmm wondering what that is in EAT :) |
| 22:05:33 | <Anushya_> let me check |
| 22:06:54 | <Anushya_> you're based in Uganda right? |
| 22:08:11 | <aka_007> dkayiwa, when I try to concatenate two message.properties messages like "Patient.cannot.delete" and "Patient.deleted" and display it on the screen using this command in the controller |
| 22:09:21 | *** k-joseph has joined #openmrs |
| 22:10:02 | <dkayiwa> aka_007: why do you concatenate them? |
| 22:10:32 | <dkayiwa> Anushya_: when you do not type my irc name, i may not notice that you are waiting for a response from me :) |
| 22:10:37 | <dkayiwa> Anushya_: yes iam :) |
| 22:11:01 | <dkayiwa> Anushya_: how did you know? :) |
| 22:11:02 | <aka_007> dkayiwa, to display the message "Patient cannot be deleted" and "Delete reason is empty" as you said I need to supply the reason for this ticket https://tickets.openmrs.org/browse/TRUNK-2224 |
| 22:11:23 | <dkayiwa> aka_007: use one message key |
| 22:11:54 | <aka_007> dkayiwa, then should I print just "Delete reason is empty" or "Patient cannot be deleted" ? |
| 22:12:29 | <dkayiwa> aka_007: do what the ticket says |
| 22:13:17 | <ergaurav2> dkayiwa, If we open a new ticket can be assign it to you for review ? |
| 22:13:28 | <aka_007> dkayiwa, okay. so I am just showing the reason as for now. thanks :) |
| 22:13:40 | <Anushya_> dkayiwa, 10am EST is 6pm in Uganda |
| 22:13:58 | <dkayiwa> Anushya_: which week day? |
| 22:14:03 | <Anushya_> tommorrow |
| 22:14:12 | <dkayiwa> Anushya_: cool |
| 22:14:16 | <Anushya_> the 5th of March |
| 22:14:20 | <Anushya_> ok |
| 22:14:25 | <Anushya_> i'll send out an invite then |
| 22:14:29 | <dkayiwa> Anushya_: ok |
| 22:27:48 | <ergaurav2> I have opened a ticket https://tickets.openmrs.org/browse/TRUNK-4297 how it can be assigned for review ? |
| 22:33:44 | *** dkayiwa_ has joined #openmrs |
| 22:34:04 | *** lbat has quit IRC |
| 22:34:35 | <dkayiwa_> ergaurav2: you can claim it now |
| 22:36:22 | *** dkayiwa has quit IRC |
| 22:39:59 | *** dkayiwa_ has quit IRC |
| 22:40:01 | *** GitHub188 has joined #openmrs |
| 22:40:01 | <GitHub188> [openmrs-core] aka001 opened pull request #712: Trunk 2224 (master...TRUNK-2224) http://git.io/WA2xMw |
| 22:40:01 | *** GitHub188 has left #openmrs |
| 22:40:23 | <ergaurav2> dkayiwa_, thanks, I have started analysis :) |
| 22:40:46 | *** GitHub14 has joined #openmrs |
| 22:40:46 | <GitHub14> [openmrs-core] aka001 closed pull request #674: TRUNK-2224 Show appropriate notification message when void reason is emp... (master...TRUNK2224) http://git.io/yxtbsw |
| 22:40:46 | *** GitHub14 has left #openmrs |
| 22:44:39 | <aka_007> !seen dkayiwa |
| 22:44:39 | <OpenMRSBot> aka_007: dkayiwa was last seen in #openmrs 30 minutes and 10 seconds ago: <dkayiwa> Anushya_: ok |
| 22:55:15 | <coder006> nribeka: there? |
| 22:56:17 | <coder006> nribeka: i was looking at HTML issues |
| 22:56:23 | <coder006> https://tickets.openmrs.org/browse/HTML-448 |
| 22:56:46 | <coder006> where in the actual code will i find this module? |
| 22:59:42 | <andrew_sz> coder006: "Currently TimeWidget in HTML Form Entry is three dropdowns for hours, minutes, and seconds." Its in the HTML Form Entry module |
| 23:00:15 | <andrew_sz> coder006: here: https://github.com/openmrs/openmrs-module-htmlformentry |
| 23:00:16 | <OpenMRSBot> <http://ln-s.net/-53M> (at github.com) |
| 23:00:54 | <coder006> andrew_sz: is it not necessary to contribute to openmrs-core ? |
| 23:01:43 | <andrew_sz> coder006: I'm sure that it isn't, but ask a more competent person |
| 23:03:10 | <andrew_sz> coder006: I think you should do what you're the best in, so if you're good in HTML stuff, then this community will have benefits from you |
| 23:03:38 | <andrew_sz> in that particular project |
| 23:06:15 | <andrew_sz> coder006: I think this is one of the main reasons why it's good to contribute to open source project, because you're not forced to do what you don't want... you can do what you want |
| 23:07:14 | <coder006> andrew_sz: exactly!!! |
| 23:09:32 | <aka_007> andrew_sz, I have 2 commits for a pull request. Is it fine or should I squash it into one commit. ?? |
| 23:09:56 | <suranga> aka_007: please squash :) |
| 23:10:31 | <aka_007> suranga, okay. thanx. :) |
| 23:11:28 | *** dkithmal has quit IRC |
| 23:17:37 | <coder006> andrew_sz: any idea how to run this application? |
| 23:18:17 | *** djazayeri has joined #openmrs |
| 23:18:17 | *** ChanServ sets mode: +o djazayeri |
| 23:36:39 | *** aka_007 has quit IRC |
| 23:38:43 | <suranga> coder006: cd webapp and mvn jetty:run |
| 23:56:16 | <ergaurav2> suranga: I guess coder006 is asking about html-form entry module ;) |
| 23:56:36 | <ergaurav2> @suranga |
| 23:59:39 | *** robbyoconnor has joined #openmrs |
| 23:59:40 | *** ChanServ sets mode: +v robbyoconnor |