IRC Chat : 2014-02-26 - OpenMRS

00:00:08 <downey> andrew_sz: usually using some permutation of his name
00:00:33 <andrew_sz> downey: like jt48?
00:00:59 <andrew_sz> downey: ah i see, of his name
00:01:07 <downey> andrew_sz: well, jt48 is not a permutation of "Pascal Brandt" :)
00:01:24 <andrew_sz> i though some pemutation of characters :D
00:01:30 <downey> right ;-)
00:03:11 <andrew_sz> downey: you must be living on west on the globe, if you're awake now, aren't you?
00:03:24 <andrew_sz> of*
00:04:00 <downey> andrew_sz: I'm in the US currently
00:16:21 <andrew_sz> downey: Is there any chance that the master branch will have spring framework 4.0.x dependencies till may?
00:18:38 <downey> andrew_sz: that's a good question for someone in this channel, or the dev@ mailing list :)
00:25:03 *** samgtr has quit IRC
00:36:01 *** dkithmal__ has joined #openmrs
00:41:09 *** dkithmal__ has quit IRC
00:45:57 *** andrew_sz has quit IRC
00:46:37 *** ddesimone_ has quit IRC
01:27:35 *** lstanisic has quit IRC
01:32:02 *** A_Szilagyi has joined #openmrs
01:37:08 <A_Szilagyi> Hello. I'm new to OpenMRS contributions, and I was working on an intro ticket related to the Reporting Compatibility Module. While examining the code, I noticed that there are identical classes in the Reporting Compatibility repository and the Core repository. Is this common for modules? What is the difference? Which should I be focusing on?
01:37:44 *** cioan has quit IRC
01:52:49 *** GitHub117 has joined #openmrs
01:52:49 <GitHub117> [openmrs-core] wluyima pushed 1 new commit to 1.10.x: http://git.io/xD1kLA
01:52:49 <GitHub117> openmrs-core/1.10.x db6745c wyclif: Follow up to fix hibernate criteria for searching drugs by mapping
01:52:49 *** GitHub117 has left #openmrs
02:03:30 <OpenMRSBot> Recent updates in the world of openmrsci: SON-OPENMRSCOREMASTER-158 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-158>
02:08:34 *** A_Szilagyi has quit IRC
02:14:35 *** lstanisic has joined #openmrs
02:15:14 *** suranga_ has quit IRC
02:24:02 *** wluyima has quit IRC
03:35:20 *** robbyoconnor has joined #openmrs
03:35:20 *** ChanServ sets mode: +v robbyoconnor
03:47:01 *** robbyoconnor has quit IRC
04:15:26 *** suranga_ has joined #openmrs
04:27:35 *** lstanisic has quit IRC
04:48:07 *** shubh has joined #openmrs
05:07:38 *** jt48 has quit IRC
05:16:01 *** wluyima has joined #openmrs
05:21:10 <shubh> i had made a pull request for one issue and on github it is showing "Travis CI build failed". Does that mean there is something wrong with my commit?
05:40:18 *** k-joseph has joined #openmrs
05:41:32 <k-joseph> wluyima: hi
05:43:00 <k-joseph> wluyima: i think @Akshika is right in his comment at https://tickets.openmrs.org/browse/TRUNK-4272?focusedCommentId=205641&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-205641 that TRUNK-4272 and TRUNK-4239 are the same!!!
05:46:28 *** shubh has quit IRC
05:49:18 *** wluyima has quit IRC
06:01:27 *** Tajha has quit IRC
06:05:41 *** shubh has joined #openmrs
06:25:41 *** VaibhavAgarwal has joined #openmrs
06:29:49 *** VaibhavAgarwal has quit IRC
06:49:23 *** shubh has quit IRC
07:12:11 *** andrew_sz has joined #openmrs
07:14:54 *** Moshon has joined #openmrs
07:16:52 *** Anushya has joined #openmrs
07:17:16 *** Anushya_ has joined #openmrs
07:20:05 *** saramirza has joined #openmrs
07:20:53 *** sara_ has joined #openmrs
07:24:27 <Anushya_> dkayiwa: are you around?
08:11:01 *** aka_007 has joined #openmrs
08:11:32 *** dkayiwa has joined #openmrs
08:15:15 *** k-joseph has quit IRC
08:25:08 *** Tajha has joined #openmrs
09:03:30 *** robbyoconnor has joined #openmrs
09:03:31 *** ChanServ sets mode: +v robbyoconnor
09:15:50 *** Moshon has quit IRC
09:23:48 *** k-joseph has joined #openmrs
09:30:54 *** aka_007 has quit IRC
09:35:14 *** suranga_ has quit IRC
09:39:42 *** himangi has joined #openmrs
09:53:10 *** aka_007 has joined #openmrs
09:58:36 <aka_007> dkayiwa, Hie, Is it necessary that the pr for a ticket must pass the build CI test?
09:58:51 <dkayiwa> aka_007: yes
09:58:56 <aka_007> dkayiwa, okay
09:59:22 <dkayiwa> aka_007: you can test that by simply running mvn clean install locally
09:59:48 <aka_007> dkayiwa, yaa .
10:12:32 *** harsz89 has joined #openmrs
10:12:32 *** ChanServ sets mode: +v harsz89
10:13:57 *** lgargu has joined #openmrs
11:01:49 *** lgargu has quit IRC
11:02:33 <aka_007> harsz89, after making a small change in java file, we have to run whole of mvn clean install to see the reflected changes. Is there some other way to do so? Can't we individually compile it?
11:03:13 <harsz89> aka_007, mhhh unfortunately you needs to run it as i know
11:03:21 <harsz89> aka_007, yeah itz take time :(
11:03:38 <harsz89> aka_007, but i dont see anyway to avoid it
11:04:28 <harsz89> aka_007, but may be you can run only a package of tests
11:04:29 <aka_007> harsz89, ohh okay. :( . Some way should be there to just compile that file and all the files associated with it.
11:05:03 <harsz89> aka_007, you needs to run all tests anyway
11:05:21 <aka_007> harsz89, yaa . got it. thanx :)
11:05:27 <harsz89> aka_007, omrs-sdk will comeup some hot deployment functions
11:05:38 <harsz89> aka_007, hope we can use it in near future :)
11:06:24 <aka_007> harsz89, looking forward to it. The delay is more but adjustible. :)
11:06:46 <harsz89> aka_007, cool :)
11:12:35 *** k-joseph has quit IRC
11:15:20 <harsz89> rafa, hi
11:36:18 <aka_007> dkayiwa, Kindly have a look at the comments section https://tickets.openmrs.org/browse/TRUNK-2224, whenever you are free. :)
11:39:07 *** GitHub62 has joined #openmrs
11:39:07 <GitHub62> [openmrs-core] dkayiwa pushed 1 new commit to 1.10.x: http://git.io/CEEWSQ
11:39:07 <GitHub62> openmrs-core/1.10.x 219f817 dkayiwa: Add missing CRUD methods for Order Frequency - TRUNK-4188
11:39:07 *** GitHub62 has left #openmrs
11:45:55 *** GitHub135 has joined #openmrs
11:45:55 <GitHub135> [openmrs-core] dkayiwa pushed 1 new commit to 1.10.x: http://git.io/DIIMqA
11:45:55 <GitHub135> openmrs-core/1.10.x 04791e4 dkayiwa: un commenting out the validator for: Add missing CRUD methods for Order...
11:45:55 *** GitHub135 has left #openmrs
11:48:00 *** aka_007 has quit IRC
11:48:37 *** raonyguimaraes has joined #openmrs
11:51:37 *** ayeung has joined #openmrs
12:00:35 *** VaibhavAgarwal has joined #openmrs
12:03:49 <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-ONEPOINTTENX-128 has FAILED (1 tests failed) : Updated by dkayiwa <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-128>
12:06:05 *** harsz89 has quit IRC
12:12:02 *** aka_007 has joined #openmrs
12:12:53 <aka_007> dkayiwa, hie.
12:14:11 *** kriks has joined #openmrs
12:14:51 <dkayiwa> aka_007: hi
12:16:33 <aka_007> dkayiwa, I have worked on this ticket https://tickets.openmrs.org/browse/TRUNK-2224 . I have attached the screenshot that I get when I click the lower most delete button without any reason. Kindly clarify whether it's correct or not.
12:17:27 <aka_007> dkayiwa, image name: patient_delete_without_void_reason.png
12:19:21 <andrew_sz> dkayiwa: can you review my code?
12:19:25 <andrew_sz> !ticket TRUNK-3197
12:19:26 <OpenMRSBot> andrew_sz: [#TRUNK-3197] Add an option for each sort Obs on each column in asc/desc - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3197
12:20:37 <andrew_sz> dkayiwa: it's my first commit, I hope I did everything right
12:21:20 *** elly__ has joined #openmrs
12:39:16 *** akwatuha_____ has joined #openmrs
12:45:18 *** lstanisic has joined #openmrs
13:01:04 *** samgtr has joined #openmrs
13:02:19 *** raonyguimaraes has quit IRC
13:02:37 *** GitHub88 has joined #openmrs
13:02:38 <GitHub88> [openmrs-core] vaibhav-hp opened pull request #672: TRUNK-3293-new updated fix and added RelationshipValidator,unit tests (master...TRUNK-3293-new) http://git.io/k9ZbQg
13:02:38 *** GitHub88 has left #openmrs
13:06:18 *** jt48 has joined #openmrs
13:07:07 *** kriks has quit IRC
13:33:23 *** sacheth has joined #openmrs
13:34:44 *** dkithmal__ has joined #openmrs
13:37:18 <sacheth> Hello, I am trying to join the OpenMRS University call, but cannot find the link. Can someone guide me?
13:37:19 *** himangi has quit IRC
13:38:57 <sacheth> @rafa Hello, I am trying to join the OpenMRS University call, but cannot find the link. Can you guide me?
13:40:11 <rafa> sacheth: all is here https://wiki.openmrs.org/display/RES/OpenMRS+University
13:40:12 <OpenMRSBot> <http://ln-s.net/98-d> (at wiki.openmrs.org)
13:41:53 <sacheth> @rafa Thank you. The link opens up in ether pad, how can I connect with skype/Adobe connect?
13:42:07 *** samgtr has left #openmrs
13:42:57 <rafa> sacheth: do you see the column on the right: How to join?
13:43:06 <rafa> sacheth: you can find a link to adobe connect there: http://connect.iu.edu/omrsu
13:43:32 <rafa> sacheth: the call has not yet started
13:44:02 <sacheth> @rafa Thanks! its at 9.00 am?
13:44:20 <rafa> it's in 15 minutes
13:44:42 <rafa> the hour depends on where you live :)
13:46:19 *** GitHub57 has joined #openmrs
13:46:20 <GitHub57> [openmrs-core] aka001 opened pull request #673: TRUNK-2224 Show appropriate notification message when void reason is emp... (master...TRUNK-2224) http://git.io/G27l-w
13:46:20 *** GitHub57 has left #openmrs
13:46:30 *** suranga_ has joined #openmrs
13:46:32 <sacheth> @rafa yes! its 7.30pm my time! :)
13:47:09 <aka_007> rafa, hie
13:47:20 <rafa> aka_007: hi
13:48:13 <andrew_sz> does anyone know when Pascal Brandt is on this channel?
13:48:29 <aka_007> rafa, I have made a pull request, git shows that I have changed in 3000 files(empty lines changes as shown by git). Will this be accepted as a pr or I need to commit another one. ?
13:48:38 <aka_007> rafa, https://github.com/openmrs/openmrs-core/pull/673/
13:49:22 <rafa> aka_007: do you know why is that?
13:49:29 <aka_007> rafa, no.
13:50:12 <rafa> aka_007: what do you see when you type git log?
13:50:44 <rafa> aka_007: sorry: git diff upstream/master
13:50:54 <aka_007> rafa, oh okay
13:51:30 <aka_007> rafa, it shows fatal: ambiguous argument 'upstream/master': unknown revision or path not in the working tree.
13:51:30 <aka_007> Use '--' to separate paths from revisions
13:52:07 <rafa> aka_007: did you configure upstream to point to https://github.com/openmrs/openmrs-core/?
13:52:46 <rafa> aka_007: i.e.
13:52:46 <rafa> git remote add upstream https://github.com/openmrs/openmrs-core.git
13:53:07 <aka_007> rafa, ohh I changed the variable upstream to origin3
13:53:20 <rafa> aka_007: ok so type git diff origin3/master
13:53:24 <aka_007> rafa, I did git remote add origin3 http://github.com/aka001/openmrs-core.git
13:53:30 <aka_007> rafa, okay
13:54:06 <rafa> aka_007: tell me if it displays you all those files?
13:54:18 <aka_007> rafa, shows same error. no it doesn't.
13:54:33 <aka_007> rafa, previously when I did git commit -m "xyz" it showed me all those files.
13:54:45 <rafa> aka_007: I see
13:54:50 <rafa> aka_007: then it's a bad commit
13:55:10 <rafa> aka_007: I don't know what changed all those files on your pc
13:55:22 <aka_007> rafa, I remember the changes that I made. Shall I clone the repository and do the changes again?
13:55:38 <rafa> aka_007: yes, it would be best
13:55:48 <rafa> aka_007: we can't accept the pull request as it is now
13:56:11 <rafa> aka_007: please commit only the files that you actually changed
13:56:42 <aka_007> rafa, okay . I have also attached the screenshot in the ticket https://tickets.openmrs.org/browse/TRUNK-2224. As to how it looks. Kindly have a look whenever you are free.
14:10:14 *** VaibhavAgarwal has quit IRC
14:14:06 *** VaibhavAgarwal has joined #openmrs
14:16:17 *** robbyoconnor has quit IRC
14:22:19 *** wluyima has joined #openmrs
14:26:09 *** mareias has joined #openmrs
14:39:01 *** dkithmal has joined #openmrs
14:41:35 *** dkithmal__ has quit IRC
14:43:13 *** dkayiwa has quit IRC
14:43:58 *** aka_007 has quit IRC
14:53:08 *** sacheth has quit IRC
14:57:25 *** dkithmal has quit IRC
15:06:01 <downey> rafa: Can you point me to the release notes page for openmrs 2.0? I can't seem to find it :)
15:07:18 *** dkithmal has joined #openmrs
15:07:20 <OpenMRSBot> Recent updates in the world of openmrsci: REP-REP-241 has FAILED (5 tests failed) : Updated by Michael Seaton <https://ci-stg.openmrs.org/browse/REP-REP-241>
15:08:46 *** dkithmal_ has joined #openmrs
15:11:35 *** dkithmal has quit IRC
15:13:06 *** mareias has quit IRC
15:21:51 *** TN has joined #openmrs
15:23:30 *** TN has quit IRC
15:24:02 *** aka_007 has joined #openmrs
15:24:39 *** TN has joined #openmrs
15:24:46 <TN> Hello
15:28:01 *** TN has quit IRC
15:39:17 <downey> ok, how about djazayeri: Can you point me to the release notes page for openmrs 2.0? I can't seem to find it :)
15:44:07 *** dkithmal__ has joined #openmrs
15:45:36 *** samgtr has joined #openmrs
15:46:19 *** GitHub24 has joined #openmrs
15:46:19 <GitHub24> [openmrs-core] aka001 opened pull request #674: TRUNK-2224 Show appropriate notification message when void reason is emp... (master...TRUNK2224) http://git.io/yxtbsw
15:46:19 *** GitHub24 has left #openmrs
15:46:30 <downey> *sigh* I guess we'll never get 2.0 released.
15:51:54 *** VaibhavAgarwal has quit IRC
15:52:58 *** dkithmal_ has quit IRC
15:59:54 *** elly__ has quit IRC
16:13:21 *** akwatuha_____ has quit IRC
16:34:02 *** mareias has joined #openmrs
16:52:06 *** harsz89 has joined #openmrs
16:52:06 *** ChanServ sets mode: +v harsz89
16:59:01 *** sacheth has joined #openmrs
17:00:12 *** kushal_ has joined #openmrs
17:06:29 *** kushal_ has quit IRC
17:06:50 *** dkithmal__ has quit IRC
17:06:51 *** mareias has quit IRC
17:09:08 <djazayeri> downey: hey, I (or rafa) needs to copy over the draft blog post to the wiki, and format it as release notes
17:10:05 *** robbyoconnor has joined #openmrs
17:10:05 *** ChanServ sets mode: +v robbyoconnor
17:10:21 <djazayeri> rafa: you around?
17:10:35 <downey> djazayeri: OK ... Does someone have the list of contributors?
17:11:07 <djazayeri> downey: We'll have to generate that.
17:11:25 <downey> Gotcha
17:15:09 *** ASzilagyi has joined #openmrs
17:21:06 <ASzilagyi> I'm working on intro ticket: https://tickets.openmrs.org/browse/RCM-8, and am confused by duplicate classes in the RCM repository and the core repository (specifically the HibernateReportingCompatibilityDAO.java). Which am I supposed to modify?
17:22:03 <aka_007> downey, hie
17:22:34 <downey> aka_007: Hello
17:23:21 <aka_007> downey, in the latest version there is no option to void patient in UI. instead there is option to delete which purges patients. Shouldn't this feature be included in openmrs.
17:29:57 *** mareias has joined #openmrs
17:46:38 <aka_007> harsz89, hie
17:46:49 <harsz89> aka_007, hi
17:47:18 *** sacheth has quit IRC
17:47:31 <aka_007> harsz89, In this ticket do we need to only change the redirect page: https://tickets.openmrs.org/browse/TRUNK-3968 (I have commented on it too).
17:47:46 *** mseaton has quit IRC
17:51:37 <harsz89> aka_007, i have no idea about it
17:51:48 <harsz89> aka_007, since you have comment out there
17:51:59 <harsz89> aka_007, resource person will reply there
17:52:00 <harsz89> :)
17:52:24 <aka_007> harsz89, okay. yaa got it. :)
17:54:43 <downey> aka_007: If you're asking for my opinion, I have none. :)
17:55:30 <aka_007> downey, okay. :) . May be daniel can tell about it. :)
17:55:44 <aka_007> downey, awaiting for his opinion.
18:08:16 *** GitHub63 has joined #openmrs
18:08:17 <GitHub63> [openmrs-core] akshika47 opened pull request #675: Trunk-4239 (1.10.x...Trunk-4236.1) http://git.io/FAMUBg
18:08:17 *** GitHub63 has left #openmrs
18:11:58 <downey> djazayeri / rafa - http://openmrs.org/2014/02/introducing-openmrs-2-0/
18:17:59 *** Akshika47 has joined #openmrs
18:18:23 <Akshika47> +rF
18:18:26 <Akshika47> +rafa
18:18:33 <Akshika47> u there?
18:20:42 <downey> Akshika47: Can someone else help you? :)
18:21:23 <Akshika47> downey: if he is willing to view my two pull requests. it is Yes. Else No
18:21:24 <Akshika47> :)
18:21:49 <downey> Akshika47: Did you update the status in the JIRA issue? If yes, it will be reviewed.
18:22:22 <Akshika47> downey: yes , then it is fine :)
18:22:40 <downey> Akshika47: A brief check of the pull request and the JIRA issue shows that everything is in order :)
18:23:25 <Akshika47> downey: I did not get you :(
18:23:57 <downey> Akshika47: You've submitted the pull request, linked to it in a JIRA comment, and set the status of the JIRA issue to Code Review, which is all you need to do.
18:24:58 <Akshika47> downey: ahh haa :) got it. is it okay to claim another ticket and work on it? since I have already claimed the two that I have made the pulls on?
18:25:17 <downey> Akshika47: Are the other two in code review status now?
18:25:34 <Akshika47> downey: yes
18:25:54 <downey> Akshika47: Then it's probably fine if you want to claim another issue to work on. :)
18:26:49 <Akshika47> downey: Great. I had almost completed another one. I will claim it and work on it. Thank you Downey.
18:28:29 *** robbyoconnor has quit IRC
18:37:30 *** dkayiwa has joined #openmrs
18:44:41 *** dkithmal__ has joined #openmrs
18:45:07 <aka_007> dkayiwa, hie.
18:45:17 <dkayiwa> aka_007: hi
18:45:43 <aka_007> dkayiwa, Kindly elaborate on this ticket https://tickets.openmrs.org/browse/TRUNK-3968 . I have commented on this. :)
18:46:37 <dkayiwa> aka_007: have you carefully read all the comments?
18:48:06 <aka_007> dkayiwa, yes. I did. The main concept is to redirect to a person's page when we click on person. So that we actually feel that we are voiding the person(actually we are voiding both person and patient).
18:48:54 <dkayiwa> aka_007: so what exactly is giving you trouble? :)
18:49:47 <aka_007> dkayiwa, just needed the clarification that changing the url is sufficient or not. Now I got it. :)
18:58:59 *** ASzilagyi has quit IRC
19:00:23 *** dkithmal__ has quit IRC
19:14:48 *** mareias has quit IRC
19:20:39 *** harsz89 has quit IRC
19:21:45 <downey> Any hackers here interested in design? Check out: http://designforhackers.com/
19:35:55 *** dkayiwa_ has joined #openmrs
19:36:16 *** mareias has joined #openmrs
19:36:43 *** harsz89 has joined #openmrs
19:36:44 *** ChanServ sets mode: +v harsz89
19:37:39 *** dkayiwa has quit IRC
19:42:08 *** aka_ has joined #openmrs
19:47:36 *** mareias has quit IRC
19:47:36 *** dkayiwa_ has quit IRC
19:47:39 *** aka_007 has quit IRC
19:47:39 *** suranga_ has quit IRC
19:47:41 *** Tajha has quit IRC
19:47:41 *** Anushya has quit IRC
19:47:41 *** andrew_sz has quit IRC
19:47:47 *** Anushya_ is now known as Anushya
19:54:51 *** Tajha has joined #openmrs
19:58:06 *** GitHub36 has joined #openmrs
19:58:07 <GitHub36> [openmrs-core] ShubhamRai opened pull request #676: TRUNK-3335 Retired Provider Attribute Types should not be shown when add... (master...TRUNK-3335) http://git.io/ZGLY7g
19:58:07 *** GitHub36 has left #openmrs
19:58:30 *** Anushya is now known as 21WACGU20
19:58:35 *** dkayiwa has joined #openmrs
19:58:35 *** suranga_ has joined #openmrs
19:58:35 *** Anushya has joined #openmrs
19:58:35 *** andrew_sz has joined #openmrs
19:59:07 *** dkayiwa has quit IRC
19:59:08 *** suranga_ has quit IRC
19:59:09 *** Anushya has quit IRC
19:59:09 *** andrew_sz has quit IRC
19:59:49 *** Akshika47 has quit IRC
20:01:10 *** Tajha_ has joined #openmrs
20:01:26 *** ryates has quit IRC
20:01:30 *** Tajha has quit IRC
20:01:43 *** ryates_ has joined #openmrs
20:01:46 *** ryates_ has joined #openmrs
20:01:55 *** ryates_ is now known as ryates
20:02:49 *** ChanServ sets mode: +o ryates
20:05:22 *** dkayiwa has joined #openmrs
20:05:22 *** suranga_ has joined #openmrs
20:05:22 *** Anushya has joined #openmrs
20:05:22 *** andrew_sz has joined #openmrs
20:11:22 *** jmiranda_ has joined #openmrs
20:16:08 *** k-joseph has joined #openmrs
20:18:50 *** jmiranda has quit IRC
20:37:48 *** kriks has joined #openmrs
20:55:29 *** k-joseph has quit IRC
20:57:15 *** GitHub24 has joined #openmrs
20:57:15 <GitHub24> [openmrs-core] ShubhamRai opened pull request #677: Trunk 3779 (master...TRUNK-3779) http://git.io/zR3cqw
20:57:15 *** GitHub24 has left #openmrs
21:23:16 *** kriks has quit IRC
21:25:37 *** lnball_ has joined #openmrs
21:25:40 *** shubh has joined #openmrs
21:27:57 *** lnball_ is now known as lnball
21:28:14 *** andrew_sz has quit IRC
21:45:59 *** dkayiwa has quit IRC
22:07:49 *** rafa has quit IRC
22:11:07 *** wluyima has quit IRC
22:27:22 *** shubh has quit IRC
23:17:42 *** robbyoconnor has joined #openmrs
23:17:42 *** ChanServ sets mode: +v robbyoconnor
23:36:48 *** wluyima has joined #openmrs
23:37:48 *** ayeung has quit IRC