00:07:47
|
<OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-106 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-106>
|
00:17:49
|
<OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1777 has FAILED (1 tests failed) : Dependant of RDD-RDD-412 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1777>
|
00:33:54
|
<OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-107 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-107>
|
00:45:56
|
<OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-108 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-108>
|
00:54:22
|
*** downey has quit IRC
|
00:55:58
|
<OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-109 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-109>
|
00:57:33
|
*** downey has joined #openmrs
|
00:57:33
|
*** ChanServ sets mode: +o downey
|
00:59:59
|
<OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-110 has FAILED (2 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-110>
|
01:03:18
|
*** akashagarwal has joined #openmrs
|
01:04:01
|
*** akashagarwal has joined #openmrs
|
01:20:05
|
<OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-111 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-111>
|
01:22:12
|
*** akashagarwal has joined #openmrs
|
02:02:14
|
<OpenMRSBot> Recent updates in the world of openmrsci: SON-OPENMRSCOREMASTER-156 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-156>
|
02:34:26
|
*** akashagarwal has joined #openmrs
|
02:43:52
|
*** aka_007 has quit IRC
|
02:44:21
|
*** Akshika47 has joined #openmrs
|
02:48:47
|
*** raonyguimaraes has quit IRC
|
02:53:11
|
<Akshika47> @djazayeri :
|
02:53:51
|
<Akshika47> I am working on a Ticket has been reported by you. I made a pull request. Still not reviewed
|
03:05:24
|
*** upul has joined #openmrs
|
03:28:03
|
*** tknopejenkins has joined #openmrs
|
03:38:57
|
<downey> Akshika47: What ticket?
|
03:41:55
|
<downey> Akshika47: You only made your commit on TRUNK-3255 yesterday. This is the weekend. You need to be patient. Give it a week or two.
|
03:42:22
|
<downey> Sorry, I meant TRUNK-2873.
|
03:42:35
|
<Akshika47> @downey: yeah. Sorry about that.
|
03:42:54
|
<Akshika47> @downey: :(
|
03:45:26
|
<Akshika47> @downey: apologies, I thought it was missed.
|
04:05:38
|
*** Akshika47 has quit IRC
|
05:08:36
|
*** akashagarwal has quit IRC
|
05:18:12
|
*** sgithens has joined #openmrs
|
05:19:00
|
*** sgithens has quit IRC
|
05:26:31
|
*** akashagarwal has joined #openmrs
|
05:32:04
|
*** akashagarwal has quit IRC
|
05:33:35
|
*** k-joseph has joined #openmrs
|
05:52:03
|
*** harsz89 has joined #openmrs
|
05:52:03
|
*** ChanServ sets mode: +v harsz89
|
06:09:33
|
*** shubh has joined #openmrs
|
06:16:03
|
*** shubh has quit IRC
|
06:29:18
|
*** shubh has joined #openmrs
|
06:31:22
|
*** lbat has joined #openmrs
|
06:32:27
|
*** akashagarwal has joined #openmrs
|
06:37:34
|
*** tknopejenkins has quit IRC
|
06:54:59
|
*** k-joseph has quit IRC
|
06:55:56
|
*** aka_007 has joined #openmrs
|
06:59:19
|
*** Moshon has joined #openmrs
|
07:02:59
|
*** upul has quit IRC
|
07:17:29
|
*** Moshon has quit IRC
|
07:22:30
|
<aka_007> harsz89, hie
|
07:22:48
|
<harsz89> aka_007, hi
|
07:23:26
|
<aka_007> harsz89, I am trying to include a checkbox to include or exclude the search of voided persons in the ticket https://tickets.openmrs.org/browse/TRUNK-3967
|
07:23:34
|
<harsz89> aka_007, okey
|
07:24:23
|
<aka_007> harsz89, Can you have a look at this pull request and please clarify why it's not working https://github.com/openmrs/openmrs-core/pull/662
|
07:29:44
|
<harsz89> aka_007, itz not working means?
|
07:30:06
|
<aka_007> harsz89, means the checkbox appears but on clicking it, it doesn't search for voided persons. :(
|
07:30:44
|
<harsz89> aka_007, so you have to set a listner or take tht option whether click or not to the server
|
07:32:26
|
<aka_007> harsz89, but in this case the checkbox appears, and in other areas like provider. Same way it's implemented, here also the function "findCountAndPeople" can find voided people
|
07:32:43
|
<aka_007> harsz89, as given in the description of it in DWRpersonservice.java
|
07:38:08
|
*** shubh has quit IRC
|
07:39:33
|
<aka_007> harsz89, any idea about it?
|
07:40:12
|
<harsz89> aka_007, mhh
|
07:40:39
|
<harsz89> aka_007, cant you debug and see whether itz actually calls tht method
|
07:41:35
|
<aka_007> harsz89, yaa it does, I did. It just doesn't search for voided persons.(it searches for non-voided ones and returns the result).
|
07:42:06
|
<harsz89> aka_007, so if tht calls then something to do with underline method
|
07:42:45
|
<aka_007> harsz89, hmm okay.
|
07:42:55
|
<harsz89> aka_007, is there a service to search voided patient
|
07:42:59
|
<harsz89> aka_007, ??
|
07:43:33
|
<aka_007> harsz89, yes. in argument list there is one argument which states whether to include or not voided patient. Still thats not working.
|
07:43:54
|
*** shubh has joined #openmrs
|
07:43:56
|
<harsz89> aka_007, mhh so thtz d problem them
|
07:44:38
|
<aka_007> harsz89, hmm okay.
|
07:45:09
|
<harsz89> aka_007, needs to check with dkayiwa
|
07:45:18
|
<harsz89> aka_007, but those methods should word
|
07:45:22
|
<harsz89> aka_007, work*
|
07:45:40
|
<harsz89> aka_007, because those are most stable ones in the core
|
07:46:48
|
<aka_007> harsz89, yaa I was thinking the same so I thought of asking you before making any changes. Yesterday I was talking to daniel, I will consult him again today about this. thanx
|
07:52:04
|
<harsz89> aka_007, can you go implementation of that method and have a look
|
07:52:24
|
<harsz89> aka_007, you sure about hitting your method with correct parameters ryt? :)
|
07:52:42
|
<harsz89> aka_007, see the parameters values at the debugger
|
07:52:51
|
<aka_007> harsz89, okay.
|
07:57:52
|
*** Moshon has joined #openmrs
|
08:04:35
|
*** dkayiwa has joined #openmrs
|
08:04:36
|
*** Moshon has quit IRC
|
08:11:52
|
*** Moshon has joined #openmrs
|
08:15:34
|
*** Moshon_ has joined #openmrs
|
08:19:47
|
*** Moshon has quit IRC
|
08:20:21
|
*** Moshon_ is now known as Moshon
|
08:41:40
|
*** aka_007 has quit IRC
|
08:56:39
|
*** harsz89 has quit IRC
|
09:08:29
|
*** harsz89 has joined #openmrs
|
09:08:29
|
*** ChanServ sets mode: +v harsz89
|
09:25:43
|
*** aka_007 has joined #openmrs
|
09:38:57
|
*** akashagarwal has quit IRC
|
09:39:32
|
*** akashagarwal has joined #openmrs
|
09:52:29
|
*** harsz89 has quit IRC
|
09:55:40
|
*** isaac has joined #openmrs
|
09:55:44
|
*** akashagarwal has joined #openmrs
|
09:56:11
|
*** akashagarwal has quit IRC
|
09:56:51
|
*** akashagarwal has joined #openmrs
|
09:57:54
|
*** akashagarwal has joined #openmrs
|
09:58:58
|
*** akashagarwal has quit IRC
|
09:59:35
|
*** akashagarwal has joined #openmrs
|
09:59:50
|
*** Moshon has quit IRC
|
10:04:06
|
*** harsz89 has joined #openmrs
|
10:04:07
|
*** ChanServ sets mode: +v harsz89
|
10:04:22
|
*** ayeung has joined #openmrs
|
10:04:28
|
*** akashagarwal has quit IRC
|
10:09:46
|
<aka_007> harsz89, hie..
|
10:11:07
|
<harsz89> aka_007, hi
|
10:13:37
|
<aka_007> harsz89, in PatientSearchCriteriaTest.java file if I use Context.getPatientService().getAllPatients() I get an error in mvn clean install .
|
10:14:01
|
<harsz89> aka_007, is it failing
|
10:14:21
|
<aka_007> harsz89, yes it's showing "BUILD FAILURE"
|
10:14:34
|
<aka_007> harsz89, along with COMPILATION ERROR
|
10:14:35
|
*** lbat has quit IRC
|
10:14:41
|
<harsz89> aka_007, okey whatz d error?
|
10:14:52
|
<harsz89> aka_007, do you done any changes?
|
10:15:02
|
<aka_007> harsz89, cannot find symbol.
|
10:15:19
|
<aka_007> harsz89, yes. I added a function. But the error is in this line
|
10:15:41
|
<harsz89> aka_007, mhhh
|
10:15:53
|
<harsz89> aka_007, was it build success before?
|
10:15:55
|
<aka_007> harsz89, List<patient> pat = Context.getPatientService().getAllPatients();
|
10:15:58
|
<aka_007> harsz89, yes
|
10:16:12
|
<harsz89> aka_007, so error is on your method :D
|
10:16:33
|
<aka_007> harsz89, yes. But why is the error in this line. I am unable to understand.
|
10:17:38
|
<harsz89> aka_007, mhhh can you debug the test?
|
10:17:44
|
<harsz89> you can find :)
|
10:18:17
|
<aka_007> harsz89, ohh by running mvn -X clean install ?
|
10:18:36
|
<harsz89> aka_007, nope you can run only a unit test via eclipse
|
10:18:59
|
<harsz89> aka_007, im doing through intelij but dnt know eclipse but should be possble
|
10:19:08
|
<aka_007> harsz89, okay. got it.
|
10:20:18
|
*** rafa has joined #openmrs
|
10:20:19
|
*** ChanServ sets mode: +v rafa
|
10:23:04
|
*** Moshon has joined #openmrs
|
10:26:36
|
*** lbat has joined #openmrs
|
10:30:32
|
*** r0bby has quit IRC
|
10:31:00
|
*** r0bby has joined #openmrs
|
10:31:00
|
*** ChanServ sets mode: +v r0bby
|
10:36:04
|
*** shubh has quit IRC
|
10:58:37
|
*** Moshon_ has joined #openmrs
|
11:01:13
|
*** Moshon has quit IRC
|
11:01:17
|
*** Moshon_ is now known as Moshon
|
11:03:36
|
*** burke has quit IRC
|
11:05:14
|
*** burke_ has joined #openmrs
|
11:07:28
|
*** harsz89 has quit IRC
|
11:11:36
|
*** isaac has quit IRC
|
11:11:42
|
*** aka_007 has quit IRC
|
11:12:02
|
*** isaac has joined #openmrs
|
11:14:51
|
*** akashagarwal has joined #openmrs
|
11:25:19
|
*** harsz89 has joined #openmrs
|
11:25:19
|
*** ChanServ sets mode: +v harsz89
|
11:25:50
|
*** r0bby has quit IRC
|
11:26:16
|
*** r0bby has joined #openmrs
|
11:26:17
|
*** ChanServ sets mode: +v r0bby
|
11:27:20
|
*** Moshon has quit IRC
|
11:28:21
|
*** Moshon has joined #openmrs
|
11:31:12
|
*** r0bby has quit IRC
|
11:35:15
|
*** r0bby has joined #openmrs
|
11:35:15
|
*** ChanServ sets mode: +v r0bby
|
11:43:11
|
*** r0bby has quit IRC
|
11:43:33
|
*** r0bby has joined #openmrs
|
11:43:33
|
*** ChanServ sets mode: +v r0bby
|
11:46:39
|
*** r0bby has quit IRC
|
11:47:03
|
*** r0bby has joined #openmrs
|
11:47:03
|
*** ChanServ sets mode: +v r0bby
|
11:47:40
|
*** aka_007 has joined #openmrs
|
11:50:53
|
*** r0bby has quit IRC
|
11:51:18
|
*** r0bby has joined #openmrs
|
11:51:19
|
*** ChanServ sets mode: +v r0bby
|
11:51:20
|
*** dkayiwa has quit IRC
|
11:58:05
|
*** akashagarwal has joined #openmrs
|
12:02:04
|
*** aka_007 has quit IRC
|
12:12:17
|
*** Moshon has quit IRC
|
12:18:08
|
*** lstanisic has joined #openmrs
|
12:22:09
|
*** willa has joined #openmrs
|
12:28:14
|
*** elly__ has joined #openmrs
|
12:28:44
|
*** akwatuha_____ has joined #openmrs
|
12:48:12
|
*** GitHub37 has joined #openmrs
|
12:48:12
|
<GitHub37> [openmrs-core] jkondrat opened pull request #663: TRUNK-3986: Add ConceptNameTagValidator to Core API (1.9.x...TRUNK-3986) http://git.io/9AHCcQ
|
12:48:12
|
*** GitHub37 has left #openmrs
|
12:57:54
|
*** isaac has quit IRC
|
12:57:55
|
*** shubh has joined #openmrs
|
12:58:09
|
*** Akshika47 has joined #openmrs
|
12:58:36
|
<Akshika47> hi
|
13:05:27
|
<Akshika47> @downwy:I have an issue with when writing to the liquibase update file with a Changeset, What is the convention using for changeset ID?
|
13:05:44
|
<Akshika47> +rafa
|
13:06:05
|
*** jkeiper has joined #openmrs
|
13:06:19
|
*** ChanServ sets mode: +v jkeiper
|
13:09:29
|
<harsz89> Akshika47, you can go through the previous ids for identifiy any related pattern
|
13:10:26
|
<harsz89> Akshika47, you can use date and time at the change
|
13:10:34
|
<Akshika47> +harsz89: great, thank u, hope I could use today's timestamp :)
|
13:10:36
|
<Akshika47> ahh yeah
|
13:10:38
|
<Akshika47> :D
|
13:10:40
|
<Akshika47> great
|
13:10:44
|
<Akshika47> I will do that
|
13:10:44
|
<harsz89> Akshika47, :)
|
13:10:50
|
<harsz89> Akshika47, cool :)
|
13:20:35
|
<downey> Akshika47: Your question was already answered at: https://wiki.openmrs.org/display/docs/Database+Update+Conventions
|
13:37:06
|
*** harshadura has joined #openmrs
|
13:37:06
|
*** ChanServ sets mode: +v harshadura
|
13:43:05
|
*** cioan has joined #openmrs
|
13:47:22
|
*** lstanisic_ has joined #openmrs
|
13:47:58
|
*** lstanisic has quit IRC
|
13:47:59
|
*** lstanisic_ is now known as lstanisic
|
13:50:09
|
*** suranga_ has joined #openmrs
|
13:56:27
|
*** wluyima has joined #openmrs
|
13:57:21
|
*** GitHub151 has joined #openmrs
|
13:57:21
|
<GitHub151> [openmrs-core] suraj5 opened pull request #664: Trunk-3850 (1.9.x...trunk-3850) http://git.io/XOiGqw
|
13:57:21
|
*** GitHub151 has left #openmrs
|
13:58:59
|
*** Akshika47 has quit IRC
|
13:59:20
|
<wluyima> hi djazayeri
|
14:09:36
|
*** wluyima has left #openmrs
|
14:12:50
|
*** wluyima has joined #openmrs
|
14:26:37
|
*** dkithmal has joined #openmrs
|
14:28:15
|
*** aka_007 has joined #openmrs
|
14:28:39
|
<aka_007> wluyima, hie.
|
14:33:19
|
<aka_007> wluyima, kindly clarify about this ticket https://tickets.openmrs.org/browse/TRUNK-2877 . There is a bit of controversy regarding it in the comments.
|
14:40:57
|
<wluyima> aka_007: i have commented on the ticket
|
14:42:56
|
<aka_007> wluyima, in both the pages, right? page 1(step1) and page 2(step2) of the openmrs installation wizard.
|
14:43:38
|
<wluyima> wluyima: i don't know how many they are off the top of my head, you can try to run the install wizard and find the pages where the use has to enter the password
|
14:43:50
|
<wluyima> aka_007: i don't know how many they are off the top of my head, you can try to run the install wizard and find the pages where the use has to enter the password
|
14:44:59
|
<aka_007> wluyima, yaa sure. Thanx :)
|
14:46:41
|
<aka_007> rafa, hie
|
14:50:37
|
<aka_007> rafa, I have a pull request for the ticket https://tickets.openmrs.org/browse/TRUNK-377 . Kindly review it whenever you are free. :)
|
15:05:09
|
*** aka_007 has quit IRC
|
15:06:04
|
*** isaac__ has joined #openmrs
|
15:10:39
|
*** cpower___ has joined #openmrs
|
15:10:50
|
<cpower___> Hello!
|
15:10:57
|
<cpower___> Are we ready to scrum?
|
15:12:09
|
<cpower___> !scrumon cpower
|
15:12:09
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
15:12:47
|
<cpower___> Order: rafa , wluyima , djazayeri
|
15:14:42
|
<cpower___> rafa: you are up
|
15:15:38
|
*** shubh has quit IRC
|
15:15:45
|
<cpower___> ok...
|
15:15:56
|
<cpower___> wluyima: how about you
|
15:17:23
|
<cpower___> ok two for two
|
15:17:33
|
<cpower___> djazayeri: anything?
|
15:17:37
|
<wluyima> cpower___: ok
|
15:17:43
|
<wluyima> cpower___: just a sec
|
15:17:47
|
<cpower___> ok
|
15:18:00
|
<djazayeri> Working on a RESTWS bug, as a tangent to some Appointment Scheduling work for Mirebalais
|
15:18:02
|
<djazayeri> no blockers
|
15:21:37
|
<cpower___> wluyima: ...
|
15:21:40
|
<wluyima> Friday:
|
15:21:41
|
<wluyima> - RESTWS-409 - Discontinue an order via rest
|
15:21:42
|
<wluyima> - RESTWS-407 - Place a lab test order via rest
|
15:21:46
|
<wluyima> - RESTWS-406 - Place a drug order via rest (in 1.10+)
|
15:21:46
|
<wluyima> - RESTWS-408 - Revise an order via rest
|
15:21:47
|
<wluyima> - Started on RESTWS-415 - Fetch a patients active orders via rest
|
15:21:48
|
<wluyima> Monday:
|
15:21:49
|
<wluyima> - Complete RESTWS-415 - Fetch a patients active orders via rest
|
15:21:50
|
<wluyima> - RESTWS-404 - Fetch drug by reference mapping
|
15:21:51
|
<wluyima> - Curate more core api tickets for order entry and create new iteration in jira
|
15:21:52
|
<wluyima> Blockers: None
|
15:22:12
|
<cpower___> Design call in 40 mins
|
15:22:18
|
<cpower___> !scrumoff
|
15:22:18
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
15:22:34
|
<wluyima> djazayeri: for some reason i can create a new iteration in jira, seems like jura expects you to do so
|
15:22:44
|
<wluyima> djazayeri: can we do that later today?
|
15:22:54
|
<djazayeri> wluyima: sure
|
15:22:56
|
<wluyima> djazayeri: will need to create a new iteration in the afternoon
|
15:23:00
|
<wluyima> djazayeri: thanks
|
15:23:03
|
*** r0bby has quit IRC
|
15:41:36
|
*** k-joseph has joined #openmrs
|
15:54:22
|
*** cpower___ is now known as help
|
15:54:52
|
*** help is now known as Guest26769
|
15:55:16
|
*** Guest26769 is now known as cpower
|
15:59:13
|
*** isaac__ has quit IRC
|
15:59:54
|
*** elly__ has quit IRC
|
16:02:26
|
*** isaac__ has joined #openmrs
|
16:02:29
|
*** k-joseph has quit IRC
|
16:03:40
|
<rafa> can anyone access http://breeze.iu.edu/omrsd or it's just me?
|
16:05:15
|
<rafa> nevermind
|
16:05:51
|
<burke_> can anyone access http://notes.openmrs.org or it's just me?
|
16:05:54
|
<jkeiper> ryates: notes.openmrs.org seems to not work
|
16:06:55
|
<ryates> jkeiper: Yes I have filed a ticket with OSU see: https://tickets.openmrs.org/browse/ITSM-3913
|
16:07:34
|
<jkeiper> ryates: thanks
|
16:07:44
|
*** isaac__ has quit IRC
|
16:08:07
|
*** lgargu has joined #openmrs
|
16:12:50
|
*** elliott_w has joined #openmrs
|
16:12:50
|
*** ChanServ sets mode: +o elliott_w
|
16:14:47
|
*** jt48 has joined #openmrs
|
16:17:13
|
*** dkayiwa has joined #openmrs
|
16:17:43
|
*** burke_ is now known as burke
|
16:17:43
|
*** ChanServ sets mode: +o burke
|
16:17:51
|
*** r0bby has joined #openmrs
|
16:17:51
|
*** ChanServ sets mode: +v r0bby
|
16:18:30
|
*** r0bby has quit IRC
|
16:21:11
|
<downey> Fortunately, everyone was a good citizen and put all their important/permanent notes in the wiki :)
|
16:23:23
|
*** akwatuha_____ has quit IRC
|
16:25:06
|
<harsz89> rafa, when you have a time please review https://github.com/openmrs/openmrs-module-webservices.rest/pull/88 which is fix for restws-281 :)
|
16:27:18
|
*** elly__ has joined #openmrs
|
16:27:20
|
*** dkithmal has quit IRC
|
16:27:48
|
*** dkithmal has joined #openmrs
|
16:35:44
|
*** dkithmal has quit IRC
|
17:00:06
|
*** cpower has quit IRC
|
17:00:13
|
*** djazayeri has quit IRC
|
17:00:16
|
*** elly__ has quit IRC
|
17:00:17
|
*** lgargu has quit IRC
|
17:00:19
|
*** wluyima has quit IRC
|
17:00:20
|
*** suranga_ has quit IRC
|
17:00:21
|
*** cioan has quit IRC
|
17:00:24
|
*** willa has quit IRC
|
17:00:26
|
*** ayeung has quit IRC
|
17:00:30
|
*** harshadura has quit IRC
|
17:00:33
|
*** burke has quit IRC
|
17:00:33
|
*** lbat has quit IRC
|
17:00:34
|
*** rafa has quit IRC
|
17:00:36
|
*** downey has quit IRC
|
17:05:55
|
*** harshadura has joined #openmrs
|
17:05:55
|
*** burke has joined #openmrs
|
17:05:55
|
*** lbat has joined #openmrs
|
17:05:55
|
*** rafa has joined #openmrs
|
17:05:55
|
*** downey has joined #openmrs
|
17:05:55
|
*** leguin.freenode.net sets mode: +vovo harshadura burke rafa downey
|
17:06:17
|
*** harsz89 has quit IRC
|
17:06:23
|
*** Guest26769 has joined #openmrs
|
17:06:23
|
*** dkithmal has joined #openmrs
|
17:06:23
|
*** elly__ has joined #openmrs
|
17:06:23
|
*** lgargu has joined #openmrs
|
17:06:23
|
*** wluyima has joined #openmrs
|
17:06:23
|
*** suranga_ has joined #openmrs
|
17:06:23
|
*** cioan has joined #openmrs
|
17:06:23
|
*** willa has joined #openmrs
|
17:06:23
|
*** ayeung has joined #openmrs
|
17:06:24
|
*** Guest26769 has quit IRC
|
17:06:24
|
*** Guest26769 has joined #openmrs
|
17:08:15
|
*** ryates has quit IRC
|
17:09:05
|
*** jkeiper has quit IRC
|
17:10:25
|
*** jkeiper has joined #openmrs
|
17:10:25
|
*** ChanServ sets mode: +v jkeiper
|
17:14:01
|
<dkayiwa> wluyima: hi
|
17:14:50
|
<wluyima> dkayiwa: can you stop working on https://tickets.openmrs.org/browse/TRUNK-4173 in the meantime, the design has changed
|
17:14:56
|
<wluyima> dkayiwa: sorry about that
|
17:15:55
|
<dkayiwa> wluyima: sure
|
17:16:02
|
<dkayiwa> wluyima: which ticket do you now recommend that i take up?
|
17:18:06
|
*** ryates has joined #openmrs
|
17:18:06
|
*** ChanServ sets mode: +o ryates
|
17:18:11
|
*** harsz89 has joined #openmrs
|
17:18:12
|
*** ChanServ sets mode: +v harsz89
|
17:21:19
|
*** VaibhavAgarwal has joined #openmrs
|
17:30:19
|
*** harshadura has quit IRC
|
17:41:37
|
*** mareias has joined #openmrs
|
17:44:19
|
*** 17SAAJX3R has joined #openmrs
|
17:44:19
|
*** djazayeri has joined #openmrs
|
17:44:19
|
*** leguin.freenode.net sets mode: +o djazayeri
|
17:49:09
|
*** raonyguimaraes has joined #openmrs
|
17:55:11
|
*** 17SAAJX3R has quit IRC
|
17:56:52
|
*** lgargu has quit IRC
|
18:03:31
|
*** mareias has quit IRC
|
18:12:57
|
<wluyima> dkayiwa: from the email i sent or https://tickets.openmrs.org/browse/RESTWS-417
|
18:13:31
|
<wluyima> dkayiwa: recall in the email i sent there were 3 tickets, so you can pick from the other 2
|
18:13:41
|
<dkayiwa> wluyima: yes i have already done so :)
|
18:13:55
|
<wluyima> dkayiwa: done what?
|
18:13:58
|
<dkayiwa> wluyima: i have picked TRUNK-4188
|
18:14:03
|
<dkayiwa> !ticket TRUNK-4188
|
18:14:04
|
<OpenMRSBot> dkayiwa: [#TRUNK-4188] Add missing CRUD methods for Order Frequency - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-4188
|
18:14:18
|
<wluyima> dkayiwa: cool
|
18:25:25
|
*** Akshika47 has joined #openmrs
|
18:25:43
|
<Akshika47> +rafa
|
18:30:01
|
*** dkithmal has quit IRC
|
18:48:48
|
<Akshika47> rafa
|
18:49:27
|
*** cospih__ has joined #openmrs
|
19:02:22
|
<downey> Akshika47: Go ahead and ask your question and rafa (or others) will answer when they can.
|
19:04:33
|
<Akshika47> @downey: I just wanted to remind him the two pull requests I made. dkayiwa said he is the person regarding pull requests this week :)
|
19:05:10
|
*** GitHub28 has joined #openmrs
|
19:05:11
|
<GitHub28> [openmrs-core] mylesbarros opened pull request #666: TRUNK-3848 when upload a new module the tasks stop working (master...master) http://git.io/3O39Og
|
19:05:11
|
*** GitHub28 has left #openmrs
|
19:05:51
|
<downey> Akshika47: Did you update the appropriate JIRA issue?
|
19:07:04
|
<Akshika47> @downey : I made the pull request regarding the bug given in the Ticket.
|
19:07:30
|
<downey> Akshika47: If you've updated the JIRA issue, that's all you need to do :)
|
19:07:43
|
*** VaibhavAgarwal has quit IRC
|
19:07:59
|
<Akshika47> @downey: Great. Thank you
|
19:10:17
|
<OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-112 has FAILED (1 tests failed) : Updated by Mark Goodrich <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-112>
|
19:14:35
|
<wluyima> rafa, djazayeri : what is the reason for having ResourceDocCreator.fakeTest, it is failing
|
19:14:46
|
<djazayeri> wluyima: offhand I have no idea what that does
|
19:15:47
|
<wluyima> djazayeri: am going to at @Ignore to it and ask rafal to look comment on the commit
|
19:16:00
|
<wluyima> djazayeri: at -> add
|
19:16:14
|
*** Aritz has joined #openmrs
|
19:16:48
|
*** aka_007 has joined #openmrs
|
19:16:55
|
<Aritz> hi everyone
|
19:17:07
|
<Aritz> i hope you had a fantastic day :)
|
19:17:16
|
<djazayeri> wluyima: I assume the reason for that is that being there is because maven complains if there is a *Test class with no enabled tests in it
|
19:17:34
|
<djazayeri> wluyima: I agree that you can ask Rafal to take a look at it, but what's the actual error?
|
19:17:52
|
<aka_007> gsoc organisation list is out. http://www.google-melange.com/gsoc/org/list/public/google/gsoc2014 :)
|
19:17:54
|
<OpenMRSBot> <http://ln-s.net/B6lq> (at www.google-melange.com)
|
19:18:01
|
<wluyima> djazayeri ClassDefNotFound org/openmrs/TestOrder
|
19:18:14
|
<djazayeri> wluyima: sounds like an actual problem
|
19:18:32
|
<djazayeri> wluyima: I guess it's fine to put a class-level @Ignore on the test, and create a ticket for Rafal
|
19:19:26
|
<wluyima> djazayeri: ok, might be some problem because it started when i added a subclass handler for TestOrder
|
19:22:57
|
*** jmiranda has joined #openmrs
|
19:25:47
|
*** napoleoncomplex has joined #openmrs
|
19:32:49
|
*** Aritz has quit IRC
|
19:33:46
|
*** napoleoncomplex has quit IRC
|
19:43:37
|
<aka_007> dkayiwa, hie
|
19:44:07
|
<dkayiwa> aka_007: hi
|
19:45:04
|
<aka_007> dkayiwa, I have finished working on this ticket https://tickets.openmrs.org/browse/TRUNK-2877 . I should push it in which branch of openmrs (1.9.x or 1.8.x)(in my repository) or anyone will work?
|
19:45:35
|
<dkayiwa> aka_007: push it to the master branch
|
19:46:38
|
<aka_007> dkayiwa, okay.
|
19:52:26
|
*** harsz89 has quit IRC
|
19:56:46
|
*** GitHub183 has joined #openmrs
|
19:56:46
|
<GitHub183> [openmrs-core] aka001 opened pull request #667: TRUNK-2877 Don't set password values in the UI in the installation wizar... (master...TRUNK-2877) http://git.io/xY_-zA
|
19:56:46
|
*** GitHub183 has left #openmrs
|
20:00:28
|
<OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-113 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-113>
|
20:00:32
|
*** Aritz has joined #openmrs
|
20:03:30
|
<aka_007> dkayiwa, I have submitted the pull request for TRUNK-2877. Kindly review it whenever possible. :)
|
20:03:33
|
<aka_007> dkayiwa, https://github.com/openmrs/openmrs-core/pull/667
|
20:04:39
|
<dkayiwa> aka_007: rafa is the one reviewing this week since he is on the community dev swim lane :)
|
20:04:42
|
*** harsz89 has joined #openmrs
|
20:04:43
|
*** ChanServ sets mode: +v harsz89
|
20:05:01
|
<aka_007> dkayiwa, shall I notify him also?
|
20:05:13
|
<dkayiwa> aka_007: no problem
|
20:05:45
|
<dkayiwa> wluyima: hi
|
20:07:40
|
<downey> aka_007: If you've updated the JIRA issue with your pull request, that's all you need to do. You don't need to remind people in IRC. :)
|
20:13:19
|
<wluyima> hi dkayiwa
|
20:13:46
|
<dkayiwa> wluyima: do you have any idea as to what could cause this error in the refapp? java.lang.NoClassDefFoundError: org/openmrs/module/appui/UiSessionContext
|
20:14:00
|
<dkayiwa> wluyima: even after having? <aware_of_module>org.openmrs.module.appui</aware_of_module>
|
20:14:41
|
<wluyima> dkayiwa: is that when you are running init tests or when running the RA?
|
20:14:57
|
<dkayiwa> wluyima: when running the real webapp
|
20:14:58
|
<wluyima> dkayiwa: aware of is not the same as require
|
20:15:27
|
<dkayiwa> wluyima: and to make matters worse, it happens randomly. sometimes it works other times it does not
|
20:15:27
|
<aka_007> downey, sorry for that, was just excited to get my first pr reviewed. :)
|
20:15:59
|
<dkayiwa> wluyima: i suspect it could be a bug in our class loader because aware_of_module is supposed to take care of that
|
20:16:21
|
<wluyima> dkayiwa: define appui as a required the module in the config.xml file and make sure appui-omod is on the class path because UISessionContext is a class in the mood project
|
20:16:30
|
<dkayiwa> wluyima: i want the xforms module to just be aware of those refapp modules but definitely not require them :)
|
20:17:01
|
<wluyima> dkayiwa: have you seen my last text?
|
20:17:15
|
<downey> aka_007: No problem :-) Just remember there are 27 open pull requests for openmrs-core repo alone, as well as all the others, so it will take a little time.
|
20:17:47
|
<dkayiwa> wluyima: yes i do not want the xforms module to require any of the refapp modules. Am not a fun of maintaining two xforms modules (one for refapp and another for legacy app)
|
20:18:03
|
<aka_007> downey, Will remember that next time onwards.
|
20:18:06
|
<wluyima> dkayiwa: do you have UISessionContext is a web class, so make sure you have the appui-omod too in the pom file as a depenency
|
20:18:30
|
<dkayiwa> wluyima: i already have it in the pom file and the module compiles fine
|
20:18:54
|
<dkayiwa> wluyima: by the way, the same module sometimes works without that error but fails other times. :)
|
20:19:11
|
<wluyima> dkayiwa: not appui-omod, am not saying appui-api
|
20:19:22
|
<wluyima> dkayiwa: you need both
|
20:19:46
|
<dkayiwa> wluyima: i have <artifactId>appui-omod</artifactId> and <artifactId>appui-api</artifactId>
|
20:20:11
|
<dkayiwa> wluyima: and i guess the module would not compile if i did not have them :)
|
20:20:18
|
<wluyima> dkayiwa: so you don't want to require the modules?
|
20:20:27
|
<dkayiwa> wluyima: NO
|
20:20:34
|
<dkayiwa> wluyima: i just want to be aware of them
|
20:21:03
|
*** Akshika47 has quit IRC
|
20:21:06
|
<dkayiwa> wluyima: i do not want my xforms module users to start requiring these refeapp modules in the legacy app
|
20:21:14
|
<wluyima> dkayiwa: hmmâ¦.can you try to add it as a required module just to be sure the problem is not with aware of module tag
|
20:21:23
|
<dkayiwa> wluyima: cool
|
20:22:10
|
<wluyima> dkayiwa: if require works and aware of fails, then the bug could be, note that when you use ware of, then you have to do things via reflection
|
20:22:58
|
<dkayiwa> wluyima: not when the refapp modules are loaded (That is when loading the page controller)
|
20:23:16
|
<dkayiwa> wluyima: by the way, the same page works very well certain times :)
|
20:25:00
|
<wluyima> dkayiwa: if sometimes it works, make sure you are not loading module classes on the fly because i think it might work
|
20:25:16
|
<wluyima> dkayiwa: try require module just to be sure of what the problem is
|
20:28:11
|
<dkayiwa> wluyima: ok
|
20:37:03
|
*** aka_007 has quit IRC
|
20:55:30
|
*** aka_007_ has joined #openmrs
|
21:00:23
|
<wluyima> hi djazayeri
|
21:00:45
|
<djazayeri> wluyima: hi
|
21:04:18
|
<wluyima> djazayeri: i was thinking that it would be convenient for rest client when revising an order to just provide the action, starDate, previousOrder and any changed fields and let the resource do the business of cloning when save is called, what do you think?
|
21:06:22
|
<djazayeri> wluyima: I would avoid trying to be too clever; I don't think there's a significant use case for what you're describing. Any realistic client app is going to be setting all the fields via javascript, html, etc.
|
21:07:03
|
<djazayeri> wluyima: so, I would lean against it, since it adds a bit of complexity (and maybe unexpected behavior) without a significant upside
|
21:08:06
|
<wluyima> djazayeri: so when one is revising an order can they change the concept and in case of a drug order can they change the drug fields?
|
21:08:20
|
<djazayeri> wluyima: you definitely can't change the concept in a revision
|
21:08:42
|
<djazayeri> wluyima: I don't know if it's okay to change the Drug formulation in a revision
|
21:10:51
|
<wluyima> djazayeri: and DrugOrder.drug is not required, right?
|
21:11:08
|
<djazayeri> wluyima: correct, though the common use case would be to specify it.
|
21:11:18
|
<wluyima> djazayeri: ok
|
21:11:22
|
<wluyima> djazayeri: thanks
|
21:23:57
|
*** ddesimone_ has joined #openmrs
|
22:03:40
|
*** shubh has joined #openmrs
|
22:06:31
|
<shubh> dkayiwa: i wanted to work on this issue https://tickets.openmrs.org/browse/TRUNK-3335.But by mistake i clicked on Wait for more Information and now i am not able to claim the issue.Could you tell me how to do it?
|
22:07:59
|
<dkayiwa> shubh: try again now
|
22:08:52
|
<shubh> dkayiwa: now i am able to do it. thanks
|
22:20:01
|
*** cioan has quit IRC
|
22:28:50
|
*** aka_007_ has quit IRC
|
22:54:49
|
*** shubh has quit IRC
|
23:07:15
|
*** MoCoStudent has joined #openmrs
|
23:08:18
|
<MoCoStudent> Quick question - I recently submitted a pull request for an intro ticket and in my pull request there's a comment that reads... "All is well â The Travis CI build passed"
|
23:08:55
|
<MoCoStudent> I have a vague idea of what Travis CI does - is this a normal thing for tickets, though, or did someone manually push this into Travis?
|
23:10:49
|
<djazayeri> MoCoStudent: It's automatic. Any time you submit a PR to the openmrs-core project, travis automatically runs all the unit tests after applying the PR.
|
23:11:25
|
<MoCoStudent> Gotcha - makes sense. Just wanted to clarify. Thanks for answering.
|
23:11:31
|
<djazayeri> MoCoStudent: therefore the person who is going to review the code knows at a glance that the submitted code at least doesn't break unit tests
|
23:12:40
|
<djazayeri> MoCoStudent: if travis were to report failure, that generally means that you (the submitter of the PR) messed up and submitted code that breaks automated testing, and you should cancel the PR, fix it, and resubmit.
|
23:13:23
|
<MoCoStudent> Okay. I'll keep an eye out for human feedback, then.
|
23:13:33
|
<MoCoStudent> That'll certainly be useful on future submissions
|
23:14:45
|
*** wluyima has quit IRC
|
23:22:05
|
*** eckhart has joined #openmrs
|
23:26:11
|
*** myles has joined #openmrs
|
23:26:35
|
*** myles has left #openmrs
|
23:27:03
|
*** MoCoStudent_ has joined #openmrs
|
23:27:29
|
*** lbat has quit IRC
|
23:30:05
|
*** raonyguimaraes has quit IRC
|
23:32:20
|
<eckhart> @dkayiwa Hello, I represent a group of students at Moravian College working on the intro ticket RCM-8, and we noticed you were active in the comments. As we are new to contributions, we had a question about the nature of the issue. It appears that there is a repository on Git for the RCM, however there appears to be duplicate classes in the core (in api/db/hibernate, in particular we were looking at the HibernatePatientSetDAO.java). Could you explain the
|
23:32:20
|
<eckhart> current state of the RCM and perhaps direct us toward the proper location to make our fixes?
|
23:36:25
|
*** dkithmal has joined #openmrs
|
23:37:02
|
*** jmdilts has joined #openmrs
|
23:37:07
|
*** eckhart has left #openmrs
|
23:37:24
|
*** jjp has joined #openmrs
|
23:37:41
|
*** eckhart has joined #openmrs
|
23:38:47
|
<jmdilts> Working on Ticket RCM-73, creating unit tests. I am receiving an error message when using the openmrs test generator: "the view that generated the event is unknown".. Can anyone talk me through this error?
|
23:41:48
|
*** MoCoStudent_ has quit IRC
|
23:41:50
|
*** jjp has quit IRC
|
23:43:40
|
*** dkayiwa has quit IRC
|
23:45:09
|
*** elliott_w has quit IRC
|
23:45:13
|
*** jmdilts has quit IRC
|
23:47:37
|
*** jt48 has quit IRC
|
23:53:09
|
*** MoCoStudent has quit IRC
|
23:55:53
|
*** jjd has joined #openmrs
|
23:57:47
|
*** ayeung has quit IRC
|
23:58:40
|
*** dkithmal has quit IRC
|