IRC Chat : 2014-02-20 - OpenMRS

00:14:48 *** shubh has quit IRC
00:16:58 *** wluyima has joined #openmrs
00:30:30 *** GitHub52 has joined #openmrs
00:30:31 <GitHub52> [openmrs-core] usn1485 opened pull request #654: Trunk-4140 (master...master) http://git.io/fFwi5w
00:30:31 *** GitHub52 has left #openmrs
00:50:37 <wluyima> hi djazayeri
00:51:51 <djazayeri> wluyima: hi
00:52:44 <wluyima> djazayeri: you said we need new resources for encounter and obs, right?
00:53:07 <djazayeri> wluyima: I believe so, yes
00:53:32 <djazayeri> wluyima: (in the same way that we added ConceptResource1_9 even though Concept itself didn't change, but its properties did.
00:53:37 <wluyima> djazayeri: does this imply that when i load a 1_8 resource, then the related resources that get loaded are for that same version
00:54:07 <wluyima> djazayeri: ok
00:56:31 <djazayeri> wluyima: the idea is that if a resource (and its referenced resources) did not change in a major OpenMRS release, we just carry forward the old resource
00:56:41 <wluyima> djazayeri: then i smell inconsistence here
00:56:47 <djazayeri> wluyima: e.g. nothing has changed about User in a long time so we keep carrying it forwards
00:57:45 <djazayeri> wluyima: if we make changes to a domain object, we need a new resource version
00:58:06 <wluyima> djazayeri: if concept required a new resource because concept map resource changes, then why don't obs, drugs not have 1_9 resources since also concept was changed, because am assuming different resource get loaded on the owner depending on the version
00:58:33 <wluyima> djazayeri: as why doesn't the chain go on
00:58:34 <djazayeri> wluyima: if the domain object itself has no changes, but resources it refers to change, then we still need a new resource version, but it's a phantom one, e.g. like is done with Concept
00:58:46 <djazayeri> wluyima: good question. I _hope_ we thought it through before
00:58:59 <wluyima> djazayeri: i smell some incosistence here
00:59:27 <wluyima> djazayeri: can u skpye for at least 5min?
00:59:56 <djazayeri> wluyima: sure, give me 2 minutes though
01:33:07 *** jb360 has joined #openmrs
01:59:55 *** harshadura has joined #openmrs
01:59:55 *** ChanServ sets mode: +v harshadura
02:02:16 <OpenMRSBot> Recent updates in the world of openmrsci: SON-OPENMRSCOREMASTER-152 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-152>
02:19:01 *** wluyima has quit IRC
03:15:07 *** harsz89 has quit IRC
03:31:38 *** wluyima has joined #openmrs
04:06:30 *** casygans has joined #openmrs
04:07:34 <casygans> Is pascal around
04:24:24 *** casygans has quit IRC
04:36:19 *** jb360 has quit IRC
05:01:41 *** harshadura_ has joined #openmrs
05:03:56 *** harshadura_ has joined #openmrs
05:04:46 *** harshadura has quit IRC
05:07:33 *** harshadura has joined #openmrs
05:07:33 *** ChanServ sets mode: +v harshadura
05:09:29 *** harshadura_ has quit IRC
05:15:50 *** harshadura_ has joined #openmrs
05:19:03 *** harshadura has quit IRC
05:19:41 *** harshadura__ has joined #openmrs
05:21:49 *** harshadura has joined #openmrs
05:21:50 *** ChanServ sets mode: +v harshadura
05:22:44 *** harshadura_ has quit IRC
05:23:37 *** harshadura_ has joined #openmrs
05:24:33 *** harshadura__ has quit IRC
05:26:52 *** harshadura has quit IRC
05:36:51 *** harshadura has joined #openmrs
05:36:51 *** ChanServ sets mode: +v harshadura
05:38:26 *** harshadura__ has joined #openmrs
05:39:09 *** harshadura_ has quit IRC
05:41:36 *** harshadura has quit IRC
05:42:54 *** harshadura has joined #openmrs
05:42:54 *** ChanServ sets mode: +v harshadura
05:43:48 *** harshadura__ has quit IRC
05:44:53 *** harshadura_ has joined #openmrs
05:47:29 *** harshadura has quit IRC
05:52:01 *** harshadura__ has joined #openmrs
05:52:37 *** harshadura_ has quit IRC
05:55:37 *** wluyima has quit IRC
05:58:17 *** harshadura has joined #openmrs
05:58:17 *** ChanServ sets mode: +v harshadura
06:00:32 *** harshadura__ has quit IRC
06:07:07 *** maurya has joined #openmrs
06:07:17 *** ChanServ sets mode: +v maurya
06:07:24 *** harshadura_ has joined #openmrs
06:10:13 *** harshadura has quit IRC
06:11:16 *** harshadura has joined #openmrs
06:11:16 *** ChanServ sets mode: +v harshadura
06:12:57 *** harshadura_ has quit IRC
06:14:32 *** psbrandt has joined #openmrs
06:14:32 *** ChanServ sets mode: +v psbrandt
06:25:32 *** harshadura_ has joined #openmrs
06:26:03 *** maurya has quit IRC
06:28:10 *** harshadura_ has quit IRC
06:28:36 *** harshadura has quit IRC
06:30:15 *** harshadura_ has joined #openmrs
06:35:53 *** akashagarwal has quit IRC
06:39:03 *** harshadura_ has quit IRC
06:40:17 *** harshadura has joined #openmrs
06:40:17 *** ChanServ sets mode: +v harshadura
06:49:56 *** harshadura_ has joined #openmrs
06:52:00 *** harshadura has quit IRC
06:52:38 *** casygans has joined #openmrs
06:53:14 <casygans> hey can anyone tell me where to checkout the list for openmrs gsoc projects
06:54:44 *** harshadura__ has joined #openmrs
06:57:30 *** harshadura_ has quit IRC
06:58:47 *** harshadura has joined #openmrs
06:58:47 *** ChanServ sets mode: +v harshadura
07:01:54 *** harshadura__ has quit IRC
07:03:52 *** chimwemwe has joined #openmrs
07:21:16 *** KOOchieng has joined #openmrs
07:21:45 *** KOOchieng is now known as Moshon
07:22:44 *** casygans has quit IRC
07:25:59 *** Moshon has quit IRC
07:31:32 *** psbrandt has quit IRC
07:34:04 *** Moshon has joined #openmrs
07:38:14 *** jmiranda has quit IRC
07:39:39 *** psbrandt has joined #openmrs
07:39:40 *** ChanServ sets mode: +v psbrandt
07:44:51 *** Moshon has quit IRC
07:55:55 *** aka_007 has joined #openmrs
08:01:49 *** harshadura_ has joined #openmrs
08:03:00 *** lgargu has joined #openmrs
08:05:00 *** harshadura has quit IRC
08:06:20 *** lgargu has quit IRC
08:07:47 *** akashagarwal has joined #openmrs
08:21:04 <aka_007> harshadura_, hie
08:21:43 *** psbrandt has quit IRC
08:26:47 <aka_007> harshadura_, you there... ?
08:35:59 *** aka_007 has quit IRC
08:37:10 *** aka_007 has joined #openmrs
08:53:29 *** Moshon has joined #openmrs
09:07:52 *** shangxiao has joined #openmrs
09:07:54 *** shangxiao_ has joined #openmrs
09:14:45 *** aka_007 has quit IRC
09:15:16 *** aka_007 has joined #openmrs
09:16:29 <aka_007> I am getting an error while running... I did some changes in a file ...
09:16:33 <aka_007> error: [ERROR] /home/aka/Ubuntu One/gsoc/openmrs-core/api/src/main/java/org/openmrs/api/db/hibernate/HibernatePatientDAO.java:[53,7] error: HibernatePatientDAO is not abstract and does not override abstract method getCountOfPatients1(String,boolean) in PatientDAO
09:16:47 <aka_007> please help downey
09:19:27 *** shangxiao_ has quit IRC
09:19:28 *** shangxiao has quit IRC
09:20:03 <aka_007> harshadura_, you there...??
09:26:29 *** aka_007 has quit IRC
09:33:19 *** shangxiao has joined #openmrs
09:33:24 *** shangxiao_ has joined #openmrs
09:59:36 *** robbyoconnor has joined #openmrs
09:59:36 *** ChanServ sets mode: +v robbyoconnor
10:40:43 *** raonyguimaraes has joined #openmrs
11:09:52 *** Moshon has quit IRC
11:12:26 *** Moshon has joined #openmrs
11:25:22 *** raonyguimaraes has quit IRC
11:28:42 *** shubh has joined #openmrs
11:30:27 *** shangxiao_ has quit IRC
11:30:27 *** shangxiao has quit IRC
11:39:38 *** dkayiwa has joined #openmrs
12:35:59 *** aka_007 has joined #openmrs
12:40:56 <aka_007> dkayiwa, hie...
12:41:07 <dkayiwa> aka_007: hi
12:42:17 <aka_007> dkayiwa, I added a function in HibernatePatientDAO.java... and I am trying to call it from DWRPatientService.java .. when I run mvn clean install after doing these changes...
12:42:53 <aka_007> dkayiwa, I get error... I am giving you the pastebin link...
12:44:01 <aka_007> dkayiwa, http://pastebin.com/GrbK1pjG ...
12:44:22 <aka_007> dkayiwa, kindly have a look at this... I am unable to figure out the cause of this...
12:45:17 <dkayiwa> aka_007: can you ping me in 30 mins? :)
12:45:26 <aka_007> dkayiwa, yaa sure... :)
12:53:36 *** Moshon has quit IRC
12:56:03 <aka_007> harshadura_, hie...
12:57:24 <harshadura_> hi aka_007
12:57:36 <harshadura_> srry was out
12:58:13 <aka_007> harshadura_, encountering an error...
12:58:25 <aka_007> harshadura_, I added a function in HibernatePatientDAO.java... and I am trying to call it from DWRPatientService.java .. when I run mvn clean install after doing these changes...
12:58:56 <aka_007> harshadura_, I get an error .... the pastebin link for it is... http://pastebin.com/GrbK1pjG ...
12:59:09 <harshadura_> aka_007: checking
12:59:15 <aka_007> harshadura_, okay... :)
13:03:32 <aka_007> harshadura_, I have also defined this function in PatientDAO.java file... as public Long getCountOfPatients1(String query, boolean includeVoided);
13:03:37 <harshadura_> aka_007: can u pastepin the DWRPatientService.java
13:04:45 <aka_007> harshadura_, http://pastebin.com/yPzEaEgu .... Done.. :)
13:07:06 <aka_007> harshadura_, actually the search functionality of all patients which includes the voided ones also is needed in the ticket... hence I am making the changes...
13:21:40 <harshadura_> aka_007: can u remove the PatientService ps = Context.getPatientService(); and edit , patientCount += ps.getCountOfPatients(searchValue); to
13:21:54 <harshadura_> patientCount += Context.getPatientService().getCountOfPatients(searchValue);
13:25:31 <aka_007> harshadura_, the error is in first function "findCountAndPatients1" I made a separate function to check the voided ones...
13:25:58 <aka_007> harshadura_, shall I remove the line "PatientService ps=Context.getPatientService();" completely... ??
13:26:28 <aka_007> harshadura_, Can you please point out the line number involving the change... ??
13:27:34 <harshadura_> aka_007: 200
13:28:53 <aka_007> harshadura_, yaa changed... running mvn clean install again...
13:32:04 *** cioan has joined #openmrs
13:37:11 <dkayiwa> rafa: hi
13:37:58 <aka_007> harshadura_, but will this line patientCount += Context.getPatientService().getCountOfPatients(searchValue); also include the voided patients ??
13:41:48 <aka_007> harshadura_, you there... ??
13:45:30 <aka_007> dkayiwa, hie
13:47:15 <dkayiwa> aka_007: hi
13:48:46 <aka_007> dkayiwa, in PatientSearchCriteria.java file ... in prepareCriteria function which attribute of criteria.add determines whether the patients to be selected are voided or not... ??
13:49:02 <aka_007> dkayiwa, criteria.add(Restrictions.disjunction().add(prepareCriterionForName(query)).add(prepareCriterionForAttribute(query))
13:49:03 <aka_007> .add(prepareCriterionForIdentifier(query, new ArrayList<PatientIdentifierType>(), false)));
13:49:10 <aka_007> dkayiwa, criteria.add(Restrictions.eq("voided", false));
13:53:31 *** r0bby_ has joined #openmrs
13:53:31 *** ChanServ sets mode: +v r0bby_
13:53:54 *** aka_ has joined #openmrs
13:54:00 <aka_> dkayiwa, I am working on this ticket... https://tickets.openmrs.org/browse/TRUNK-3967
13:54:38 <aka_> dkayiwa, I was disconnected due to network issues.... :(
13:59:42 *** aka_007 has quit IRC
13:59:42 *** robbyoconnor has quit IRC
13:59:42 *** akashagarwal has quit IRC
13:59:45 *** jkeiper has quit IRC
13:59:46 *** burke has quit IRC
13:59:52 *** akashagarwal has joined #openmrs
14:07:26 <dkayiwa> aka_: hi
14:08:20 <aka_> dkayiwa, I am trying to figure out the code... 10 minutes...
14:08:34 <dkayiwa> aka_: take your time. am here all day :)
14:09:44 *** jkeiper has joined #openmrs
14:09:44 *** burke has joined #openmrs
14:09:44 *** leguin.freenode.net sets mode: +vo jkeiper burke
14:10:10 <aka_> dkayiwa, okay.. :)
14:13:43 *** wluyima has joined #openmrs
14:16:54 <wluyima> hi dkayiwa
14:17:02 <dkayiwa> wluyima: hi
14:19:23 *** shubh has quit IRC
14:20:40 *** jkeiper has quit IRC
14:20:40 *** burke has quit IRC
14:29:55 <wluyima> dkayiwa: did you see the email i sent out? Anushya also wanted to catch up with you , did you hear from her?
14:30:43 <dkayiwa> wluyima: am still waiting on her because i gave her a go ahead for any time she wants to catch up with me apart from only Friday evenings :)
14:33:51 *** jkeiper has joined #openmrs
14:33:51 *** burke has joined #openmrs
14:33:51 *** leguin.freenode.net sets mode: +vo jkeiper burke
14:34:43 <wluyima> ok
14:34:52 <wluyima> dkayiwa: ok
14:39:50 *** raonyguimaraes has joined #openmrs
15:03:27 <aka_> dkayiwa, I have added a function in the DWRPatientService.java ... Do I need to mention that I have used in some files(like dwr.xml) if I want to use it as :
15:03:31 <aka_> dkayiwa, DWRPatientService.findCountAndPatients1(text, opts.includeVoided, opts.start, opts.length, getMatchCount, resultHandler);
15:08:16 <dkayiwa> aka_: on the weekly developers call
15:08:26 <aka_> dkayiwa, okay... :)
15:16:02 *** kushal_ has joined #openmrs
15:16:39 <kushal_> dkayiwa: hi. Are u free?
15:16:53 <dkayiwa> kushal_: on the weekly dev call
15:17:34 <harshadura_> aka_: IIRC the dwr method signatures are needed to mention in config.xml
15:18:34 <harshadura_> aka_: https://wiki.openmrs.org/display/docs/DWR+in+OpenMRS
15:22:26 *** aka_ has quit IRC
15:23:05 <downey> ConferenceCallWithoutHeadphones--
15:23:06 <downey> :)
15:23:17 *** aka_007 has joined #openmrs
15:23:28 <aka_007> harshadura_, ohh okay...
15:23:35 <aka_007> harshadura_, thanx.. :)
15:23:56 <aka_007> harshadura_, one more doubt...
15:25:02 <downey> aka_007: everyone is in the weekly developers meeting right now.
15:25:03 <downey> !devmtg
15:25:05 <OpenMRSBot> downey: "devmtg" --- Reminder: Developer Forum Thursday at 10:00 AM Eastern Time - https://wiki.openmrs.org/display/RES/Developers+Forum
15:25:39 <aka_007> downey, Can I too join in this(just want to hear what is going on) ??
15:25:55 <downey> aka_007: Yes, all are welcome :) be sure to mute your microphone unless speaking though ;-)
15:26:12 <aka_007> downey, yaa okay.. :)
15:28:10 <wluyima> dkayiwa: have you seen the other commits i added to tickets, the tickets in the needs review column on the order entry dashboard
15:28:14 <rafa> dkayiwa: hey
15:28:31 <dkayiwa> wluyima: yes i eventually saw them :)
15:28:35 <rafa> dkayiwa: would you like to test https://sourceforge.net/projects/openmrs/files/releases/OpenMRS_2.0/openmrs-2.0-standalone.zip/download on mac?
15:28:41 <OpenMRSBot> <http://ln-s.net/B2wS> (at sourceforge.net)
15:28:43 <dkayiwa> rafa: cool
15:28:50 <rafa> dkayiwa: thank you :)
15:29:24 *** kushal_ has quit IRC
15:31:24 *** Moshon has joined #openmrs
15:35:05 <wluyima> dkayiwa: cool
15:35:06 <Moshon> wluyima: Hi
15:40:38 *** r0bby_ has quit IRC
15:41:37 <Moshon> dkayiwa: Hi
15:42:06 <dkayiwa> Moshon: hi
15:42:59 <Moshon> dkayiwa: Having slight problem with the Logic module. Wondering if you could assist. :)
15:49:33 <Moshon> dkayiwa: OpenMRS 1.9.7, Logic module 0.5.2. I have defined custom rules but I can't access them on the 'Token Registration' Tab. The tab displays the text 'Processing..', which never seems to go away
16:00:37 *** harshadura_ has quit IRC
16:07:36 <dkayiwa> Moshon: hi
16:09:57 <dkayiwa> rafa: hi
16:10:24 <rafa> dkayiwa: hi
16:11:38 <dkayiwa> rafa: just finished the download, so still testing. One thing i have noted though is that we may need to warn them that first run takes quite some time before they can see a login page. :)
16:12:17 <rafa> dkayiwa: that's true, it takes some time, especially when you choose demo
16:12:25 <dkayiwa> rafa: exactly
16:16:34 <Moshon> dkayiwa: hi, any advice?
16:16:49 <dkayiwa> Moshon: can you send me a screenshot of what you see?
16:17:08 <dkayiwa> Moshon: at http://snag.gy/
16:18:10 <Moshon> dkayiwa: sure, doing that in a moment.
16:18:53 *** harsz89 has joined #openmrs
16:18:53 *** ChanServ sets mode: +v harsz89
16:19:11 *** r0bby_ has joined #openmrs
16:19:11 *** ChanServ sets mode: +v r0bby_
16:20:50 <aka_007> harsz89, hie...
16:22:17 *** wluyima has quit IRC
16:23:16 <aka_007> harsz89, how do I test whether a particular java function has been called or not while a page loads(for debugging purpose). Like is there some way we can print something(system.out.println) in that function and expect it to be displayed in the server console.. ??
16:23:18 <aka_007> dkayiwa, hie
16:24:00 <dkayiwa> aka_007: hi
16:24:11 <Moshon> dkayiwa: http://snag.gy/Rb9Xh.jpg
16:24:15 <aka_007> dkayiwa, how do I test whether a particular java function has been called or not while a page loads(for debugging purpose). Like is there some way we can print something(system.out.println) in that function and expect it to be displayed in the server console.. ??
16:27:37 <aka_007> dkayiwa, I have defined new functions for searching void patients, when I try to search by UI the page loads to infinity... How do I figure out that the java functions that I have defined are called or not... ??
16:27:41 <harsz89> aka_007, cant you debug?
16:27:46 <dkayiwa> aka_007: do you already have a unit test for it?
16:28:43 <aka_007> dkayiwa, harsz89, no I don't have a unit test for it.. it's a new method.... Can't I check whether it's called or not? when a particular page is loaded...
16:29:15 <dkayiwa> aka_007: in which class is the new method
16:29:38 <aka_007> dkayiwa, DWRPatientService
16:30:50 <dkayiwa> aka_007: can you paste the method at pastebin.com
16:31:28 <aka_007> dkayiwa, http://pastebin.com/yPzEaEgu
16:31:54 <aka_007> dkayiwa, the new method is findCountAndPatients1
16:33:21 <dkayiwa> Moshon: can you reproduce it at http://demo.openmrs.org/openmrs
16:34:08 <dkayiwa> aka_007: you can always run openmrs in debug mode and put a break point
16:35:00 <aka_007> dkayiwa, in eclipse.. ?? I was just using normal editor to do this...
16:35:32 <dkayiwa> aka_007: i use eclipse :)
16:35:39 <aka_007> dkayiwa, okay
16:35:59 *** Moshon has quit IRC
16:36:16 *** harshadura has joined #openmrs
16:36:16 *** ChanServ sets mode: +v harshadura
16:36:59 *** k-joseph has joined #openmrs
16:37:14 <harsz89> harsz89, hope your problem resolved :)
16:37:24 <harsz89> aka_007, ^
16:37:55 *** Moshon has joined #openmrs
16:38:00 <aka_007> harsz89, yaa I am downloading an integrating it with openmrs thanx ... dkayiwa and harsz89 :)
16:39:08 *** Moshon has quit IRC
16:39:43 *** Moshon has joined #openmrs
16:40:22 <dkayiwa> rafa: hi
16:48:09 <aka_007> dkayiwa, in my eclipse when I am trying to run the program it shows reference to undefined variable maven_exec... I am following this link https://wiki.openmrs.org/display/docs/Using+the+Maven+plugin+for+Eclipse
16:48:38 <aka_007> dkayiwa, I am in the step "setup maven commands in eclipse" kindly help ...
16:55:44 *** aka_007 has quit IRC
16:58:18 <Moshon> dkayiwa: http://demo.openmrs.org/openmrs/module/logic/manageTokens.list
16:58:58 <Moshon> dkayiwa: Am getting exactly the same result
16:59:40 <Moshon> dkayiwa: I have defined a rule name 'IsMalePaedetric'
17:01:28 <Moshon> dkayiwa: I intend to use it within a htmlformentry form inside the tag <includeIf>
17:02:55 <dkayiwa> Moshon: can you ask about it on the mailing list
17:03:38 *** aka_007 has joined #openmrs
17:03:52 *** r0bby_ has quit IRC
17:04:42 <aka_007> dkayiwa, you there... ??
17:05:20 <Moshon> dkayiwa: ok. Thanks
17:06:09 <aka_007> dkayiwa, can you help me with the eclipse integration part... I am facing an error... :(
17:07:24 <dkayiwa> aka_007: have you looked at our wiki pages for that?
17:07:53 *** r0bby_ has joined #openmrs
17:07:53 *** ChanServ sets mode: +v r0bby_
17:08:11 <aka_007> dkayiwa, yaa I have been following this link https://wiki.openmrs.org/display/docs/Using+the+Maven+plugin+for+Eclipse#UsingtheMavenpluginforEclipse-Generate_Eclipse_Projects
17:08:25 <aka_007> dkayiwa, I am getting error in the step "setup maven commands in Eclipse"
17:08:55 *** kushal_ has joined #openmrs
17:10:02 <kushal_> dkayiwa: Hi, Can we talk now?
17:10:32 <dkayiwa> kushal_: hi
17:10:57 <kushal_> I hae a doubt.
17:11:00 <kushal_> Have*
17:11:00 <dkayiwa> kushal_: can you ping me in 10 mins?
17:11:16 <kushal_> dkayiwa: sure :)
17:21:54 *** r0bby_ has quit IRC
17:21:55 *** robbyoconnor has joined #openmrs
17:21:56 *** ChanServ sets mode: +v robbyoconnor
17:22:21 *** harshadura has quit IRC
17:31:59 *** robbyoconnor has quit IRC
17:36:34 <kushal_> dkayiwa : Hi.
17:37:20 <dkayiwa> kushal_: hi
17:37:50 <kushal_> can you help me with the trunk-344
17:38:20 <kushal_> dkayiwa : I already have put a pull request.
17:38:40 <kushal_> dkayiwa : can u suggest me the changes.
17:39:44 <dkayiwa> !ticket trunk-344
17:39:46 <OpenMRSBot> dkayiwa: [#TRUNK-344] PersonName.getFullName() should use the configured nameLayout - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-344
17:41:53 *** GitHub108 has joined #openmrs
17:41:53 <GitHub108> [openmrs-core] madawa-rc opened pull request #655: TRUNK-2312: Navigation Menu Expand Vertically (master...TRUNK-2312) http://git.io/bIbRzw
17:41:53 *** GitHub108 has left #openmrs
17:42:09 <dkayiwa> kushal_: i have comented on the ticket. is that enough for you to proceed?
17:43:29 *** Moshon has quit IRC
17:43:29 <kushal_> dkayiwa : That means i have to check the preferred name and return accordingly?
17:44:01 <dkayiwa> kushal_: in the unit test, just set PersonName.format to the value which will make the test pass
17:45:30 <kushal_> dkayiwa : Ok. Thanks :)
17:48:03 *** djazayeri has quit IRC
17:58:08 *** kushal_ has quit IRC
18:01:42 *** aka_007 has quit IRC
18:08:21 *** djazayeri has joined #openmrs
18:08:21 *** ChanServ sets mode: +o djazayeri
18:30:12 *** wluyima has joined #openmrs
18:39:43 *** mccallumg has joined #openmrs
18:39:43 *** ChanServ sets mode: +v mccallumg
18:40:48 <mccallumg> @suranga I need some ideas for GSOC projects. Anything related to android going on?
18:41:29 <wluyima> hi djazayeri
18:41:33 <wluyima> or rafa
18:41:55 <wluyima> djazayeri: or rafa can you make me a project admin for the rest module in jura?
18:46:25 *** raonyguimaraes has quit IRC
18:46:53 <djazayeri> wluyima: I can, yes; you sure you're looking at RESTWS, and not REST, right?
18:47:08 <wluyima> RESTWD
18:47:48 <wluyima> djazayeri: RESTWS, am trying to create a new iteration on the order entry agile dashboard in jira and the button says i need to be an admin
18:47:55 <djazayeri> wluyima: you're already listed as both an Administrator and an Approver
18:48:45 <wluyima> djazayeri: ah, it has to be in core
18:49:07 <wluyima> djazayeri: can you try to add to the for project?
18:49:53 <djazayeri> wluyima: I just made you an approver, let's see if that's enough
18:50:06 <djazayeri> wluyima: gotta run, back in 10 minutes
18:51:32 <wluyima> djazayeri still can't but i was able to in the past, let me ask michael
18:53:57 <wluyima> djazayeri: apparently it seems you have to end the current one as the person who created it before the button becomes active for to create a new one
18:57:29 *** k-joseph has quit IRC
19:02:50 *** k-joseph has joined #openmrs
19:03:00 <dkayiwa> rafa: hi
19:03:47 *** k-joseph has quit IRC
19:04:01 <djazayeri> wluyima: that doesn't sound right to me
19:06:54 *** chimwemwe has joined #openmrs
19:07:16 <chimwemwe> djazayeri: hi
19:09:23 <djazayeri> chimwemwe: hi
19:10:14 <chimwemwe> djazayeri: I'm working on the Rest API - Baobab Systems intergration with the OpenMRS stack...
19:10:59 <djazayeri> chimwemwe: cool
19:12:28 <chimwemwe> djazayeri: However, I've observed if I try to work tith the 1.9.x version, without other libraries I don't need like Reporting Module which is called by EmrAPI, it crashes which I think means that version 1.9.x is now dependent on an external library. Is this normal or not?
19:12:57 <djazayeri> chimwemwe: the EMRAPI module has dependencies, including Reporting
19:13:24 <djazayeri> chimwemwe: if you use purely 1.9.x + the RESTWS module, you don't need any other dependencies
19:13:41 <djazayeri> chimwemwe: but if you also use EMR API, that does have other requirements.
19:14:02 <chimwemwe> djazayeri: unfortunately it seems there's a requirement which was I think left there accidentally
19:14:55 <chimwemwe> djazayeri: There's a call to a method in EMR API when creating encounters for creating visits it seems
19:15:19 <djazayeri> chimwemwe: there is no call from OpenMRS core to EMR API
19:16:06 <djazayeri> chimwemwe: did you install with other modules, and then remove them maybe?
19:16:24 <chimwemwe> djazayeri: if you can, can you try running 1.9.x without the EMR API module and try creating an encounter, it's crashing on my machine
19:16:50 <chimwemwe> djazayeri: let me hunt for the line and show you
19:22:44 <chimwemwe> djazayeri: the error I was getting is at: https://pastee.org/b5jsu
19:23:20 <chimwemwe> djazayeri: of interest is line 3:
19:23:27 <chimwemwe> djazayeri: Error message: Failed to instantiate assignment handler object for class class: org.openmrs.module.emrapi.adt.EmrApiVisitAssignmentHandler
19:24:22 <djazayeri> chimwemwe: can you search your codebase and look for "org.openmrs.module.emrapi.adt.EmrApiVisitAssignmentHandler"
19:24:32 <chimwemwe> djazayeri: which I think exists in the EMR API and not necessarily in the core. This line was not there in version 1.8.x which is working fine without the module
19:25:22 <wluyima> hi dkayiwa
19:25:38 <dkayiwa> wluyima: hi
19:26:36 <chimwemwe> djazayeri: i think i tried searching for it and could not find it in the core but i found it/something similar in EMR API codebase
19:27:05 <wluyima> dkayiwa: for the current tickets you are reviewing please check if the author is me, if the author isn't me chances are that i fixed the code in my follow up commit, so is it not my commit it is good if you viewed the file in github to ensure the problem still exists
19:27:16 *** robbyoconnor has joined #openmrs
19:27:17 *** ChanServ sets mode: +v robbyoconnor
19:27:33 <djazayeri> chimwemwe: also do: select * from global_property where property_value = 'org.openmrs.module.emrapi.adt.EmrApiVisitAssignmentHandler
19:27:33 <djazayeri> ' ?
19:27:50 <dkayiwa> wluyima: ok
19:28:24 <chimwemwe> djazayeri: ok.
19:29:17 *** mccallumg has quit IRC
19:29:31 <chimwemwe> djazayeri: it exists in the database
19:29:41 *** mccallumg has joined #openmrs
19:29:41 *** ChanServ sets mode: +v mccallumg
19:30:11 <wluyima> djazayeri: it seems like jura won't let me create a new iteration because the current one is still ongoing, and it won't let me create another
19:30:12 <chimwemwe> djazayeri: does it mean something if it's in the database?
19:32:15 <chimwemwe> djazayeri: is there another method I can use for visits creation besides that from the module?
19:32:51 *** k-joseph has joined #openmrs
19:32:51 *** robbyoconnor has quit IRC
19:33:47 <djazayeri> chimwemwe: how did you install? Did you install with more modules (e.g. did you install the whole reference application)?
19:38:12 <chimwemwe> djazayeri: I dropped a .war file in tomcat after clearing all modules. when I run without the reporting module, the installation is fast and clean which is not the case when I install the emrapi module and its dependencies like reporting module. So in my case, I'm not interested in the reporting module so I'm having problems when it makes my setup fail to finish. So I ended up clearing all modules and the installation works fine except without the
19:38:12 <chimwemwe> emrapi and it's associated files I can't create encounters but I can create patients
19:41:38 *** robbyoconnor has joined #openmrs
19:41:38 *** ChanServ sets mode: +v robbyoconnor
19:42:30 *** robbyoconnor has quit IRC
20:02:52 <djazayeri> chimwemwe: if you installed the full reference application, this will have set up a global property that tells the system to use the EMR API module's Visit Assignment Handler
20:03:18 <djazayeri> chimwemwe: if you uninstall the EMR API module you then need to reset this global property value to its original value
20:04:00 <djazayeri> chimwemwe: I forget what the original value is, but you can find it in the 1.9.x codebase, under OpenmrsConstants, I think
20:04:41 <chimwemwe> djazayeri: ok. I'll look into it. thanks
20:05:16 *** k-joseph has quit IRC
20:13:52 *** chimwemwe has quit IRC
20:16:26 *** wluyima has quit IRC
20:26:01 *** wluyima has joined #openmrs
20:31:31 *** chimwemwe has joined #openmrs
20:32:43 *** raonyguimaraes has joined #openmrs
20:47:46 *** mccallumg has quit IRC
20:53:02 *** chimwemwe has quit IRC
21:03:39 *** wluyima has quit IRC
21:04:09 *** jkeiper has quit IRC
21:04:10 *** burke has quit IRC
21:05:16 *** raonyguimaraes has quit IRC
21:05:26 *** suranga has quit IRC
21:05:27 *** cospih_ has quit IRC
21:05:28 *** elliott_w has quit IRC
21:05:30 *** suranga___ has quit IRC
21:05:30 *** AdaYeung has quit IRC
21:05:32 *** downey has quit IRC
21:05:33 *** Gareth has quit IRC
21:05:35 *** djazayeri has quit IRC
21:05:38 *** mseaton has quit IRC
21:05:38 *** ojwanganto_ has quit IRC
21:05:40 *** willa has quit IRC
21:05:40 *** cpower___ has quit IRC
21:05:40 *** elly__ has quit IRC
21:05:40 *** ryates has quit IRC
21:05:56 *** djazayeri has joined #openmrs
21:05:56 *** mseaton has joined #openmrs
21:05:56 *** 1JTAAC3U6 has joined #openmrs
21:05:56 *** willa has joined #openmrs
21:05:56 *** cpower___ has joined #openmrs
21:05:56 *** elly__ has joined #openmrs
21:05:56 *** ryates has joined #openmrs
21:05:56 *** leguin.freenode.net sets mode: +ovo djazayeri mseaton ryates
21:06:04 *** suranga has joined #openmrs
21:06:04 *** cospih_ has joined #openmrs
21:06:04 *** elliott_w has joined #openmrs
21:06:04 *** leguin.freenode.net sets mode: +o elliott_w
21:08:00 *** suranga___ has joined #openmrs
21:08:01 *** AdaYeung has joined #openmrs
21:08:01 *** downey has joined #openmrs
21:08:01 *** Gareth has joined #openmrs
21:08:01 *** leguin.freenode.net sets mode: +o downey
21:08:15 *** wluyima has joined #openmrs
21:14:23 *** raonyguimaraes has joined #openmrs
21:14:53 *** jkeiper has joined #openmrs
21:14:53 *** burke has joined #openmrs
21:14:53 *** leguin.freenode.net sets mode: +vo jkeiper burke
21:24:16 *** wluyima has quit IRC
21:32:02 *** cospih__ has joined #openmrs
21:32:05 *** cospih__ has joined #openmrs
21:40:00 *** suranga___ has quit IRC
21:40:00 *** AdaYeung has quit IRC
21:40:02 *** downey has quit IRC
21:40:04 *** Gareth has quit IRC
21:40:38 *** suranga has quit IRC
21:40:38 *** cospih_ has quit IRC
21:40:39 *** elliott_w has quit IRC
21:40:40 *** cospih__ is now known as cospih_
21:41:48 *** mccallumg has joined #openmrs
21:41:48 *** ChanServ sets mode: +v mccallumg
21:44:41 *** elliott_w has joined #openmrs
21:44:41 *** ChanServ sets mode: +o elliott_w
21:44:48 *** suranga_ has joined #openmrs
21:53:07 *** cpower____ has joined #openmrs
21:54:21 *** cospih__ has joined #openmrs
21:58:31 *** aka_007 has joined #openmrs
22:00:15 *** cospih_ has quit IRC
22:00:22 *** cpower__ has quit IRC
22:00:22 *** Tajha has quit IRC
22:00:23 *** lstanisic has quit IRC
22:00:23 *** r0bby has quit IRC
22:00:24 *** nribeka has quit IRC
22:00:24 *** akwatuha has quit IRC
22:00:24 *** tobin_g_ has quit IRC
22:00:25 *** ibewes_ has quit IRC
22:00:28 *** cospih__ is now known as cospih_
22:00:29 *** cpower____ is now known as cpower__
22:01:50 *** Tajha has joined #openmrs
22:02:14 *** akwatuha_____ has joined #openmrs
22:02:48 *** tobin_g_ has joined #openmrs
22:04:00 *** nribeka has joined #openmrs
22:04:00 *** ChanServ sets mode: +v nribeka
22:07:03 *** ibewes_ has joined #openmrs
22:07:03 *** r0bby has joined #openmrs
22:07:03 *** lstanisic has joined #openmrs
22:07:03 *** suranga___ has joined #openmrs
22:07:03 *** AdaYeung has joined #openmrs
22:07:03 *** downey has joined #openmrs
22:07:03 *** Gareth has joined #openmrs
22:07:03 *** leguin.freenode.net sets mode: +o downey
22:08:05 *** r0bby is now known as Guest88769
22:14:15 <aka_007> harsz89, hie....
22:18:56 *** wluyima has joined #openmrs
22:22:13 *** cioan has quit IRC
22:27:03 *** Guest88769 has quit IRC
22:27:04 *** lstanisic has quit IRC
22:29:54 *** wluyima has quit IRC
22:33:08 *** ibewes_ has quit IRC
22:33:10 *** suranga___ has quit IRC
22:33:10 *** AdaYeung has quit IRC
22:33:12 *** downey has quit IRC
22:33:14 *** Gareth has quit IRC
22:36:24 *** ibewes_ has joined #openmrs
22:36:24 *** Guest88769 has joined #openmrs
22:36:24 *** lstanisic has joined #openmrs
22:36:24 *** Gareth has joined #openmrs
22:36:24 *** downey has joined #openmrs
22:36:24 *** AdaYeung has joined #openmrs
22:36:24 *** suranga___ has joined #openmrs
22:36:24 *** leguin.freenode.net sets mode: +o downey
22:46:08 *** ibewes_ has quit IRC
22:46:10 *** suranga___ has quit IRC
22:46:10 *** AdaYeung has quit IRC
22:46:12 *** downey has quit IRC
22:46:14 *** Gareth has quit IRC
22:46:58 *** ibewes_ has joined #openmrs
22:46:58 *** Gareth has joined #openmrs
22:46:58 *** downey has joined #openmrs
22:46:58 *** AdaYeung has joined #openmrs
22:46:58 *** suranga___ has joined #openmrs
22:46:58 *** leguin.freenode.net sets mode: +o downey
22:58:06 *** GitHub197 has joined #openmrs
22:58:06 <GitHub197> [openmrs-core] aka001 opened pull request #656: my first commit consisting bug (master...master) http://git.io/ZRWBbg
22:58:06 *** GitHub197 has left #openmrs
23:21:03 *** wluyima has joined #openmrs
23:30:29 *** mccallumg has quit IRC
23:43:29 *** dkayiwa has quit IRC
23:44:07 *** raonyguimaraes has quit IRC
23:47:13 *** aka_007 has quit IRC