IRC Chat : 2014-02-19 - OpenMRS

00:01:33 <wluyima> djazayeri: i actually figured out what the problem was as to why adding 1.10.* as a supported version to ConceptResource1_10 wasn't working, it is because the artifacts for for 1.9 sub projects weren't added to the in the pom for the 1.10 sub project
00:02:01 <wluyima> djazayeri: so i don't have to add ConceptResource1_10
00:07:12 <djazayeri> wluyima: makes sense
00:08:05 <wluyima> djazayeri: by the way thanks for the response about the PIH question
00:20:15 <OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-90 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-90>
00:26:15 <OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-91 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-91>
00:42:55 *** harsz89 has quit IRC
00:49:56 *** GitHub195 has joined #openmrs
00:49:56 <GitHub195> [openmrs-core] wluyima pushed 1 new commit to 1.10.x: http://git.io/bBSZ4g
00:49:56 <GitHub195> openmrs-core/1.10.x 97dc0ab wyclif: Fixed potential NullPointerException when getting names and descriptions of order frequencies
00:49:56 *** GitHub195 has left #openmrs
00:54:33 *** harsz89 has joined #openmrs
00:54:34 *** ChanServ sets mode: +v harsz89
01:32:04 <wluyima> hi djazayeri
01:32:12 <djazayeri> wluyima: hi
01:32:33 <wluyima> djazayeri: i have commented on several tickets that need review, do you think you can look at them before i close them?
01:33:24 *** jb360 has joined #openmrs
01:33:46 <djazayeri> wluyima: I don't have time to do any code review at the moment, unfortunately
01:33:53 <djazayeri> wluyima: do you need code review or design review?
01:34:33 <OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-92 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-92>
01:36:54 <wluyima> djazayeri: code review
01:37:12 <djazayeri> wluyima: sorry, can't do it right now...
01:37:40 <djazayeri> wluyima: I recommend you send an email to daniel and rafal listing all the ticket that could use it, so they can take a look during their daytime.
01:52:37 <OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-93 has FAILED (1 tests failed) : Manual build by Wyclif Luyima <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-93>
02:02:39 <OpenMRSBot> Recent updates in the world of openmrsci: SON-OPENMRSCOREMASTER-151 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-151>
02:04:23 *** wluyima has quit IRC
02:28:38 *** raonyguimaraes has quit IRC
03:36:42 *** wluyima has joined #openmrs
03:50:56 *** harshadura has joined #openmrs
03:50:56 *** ChanServ sets mode: +v harshadura
04:08:54 *** jb360 has quit IRC
04:41:14 <OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-94 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-94>
04:44:43 *** Shangeetha has joined #openmrs
05:09:18 *** robbyoconnor has joined #openmrs
05:09:18 *** ChanServ sets mode: +v robbyoconnor
05:19:24 *** Shangeetha has quit IRC
05:23:43 *** psbrandt has joined #openmrs
05:23:43 *** ChanServ sets mode: +v psbrandt
05:25:27 *** wluyima has quit IRC
05:35:01 *** harshadura has quit IRC
05:37:15 *** psbrandt has quit IRC
05:44:29 *** akashagarwal has quit IRC
05:51:29 *** Shangeetha has joined #openmrs
05:51:52 <Shangeetha> @djazayeri: Hi
06:07:50 *** akashagarwal has joined #openmrs
06:09:05 *** psbrandt has joined #openmrs
06:09:05 *** ChanServ sets mode: +v psbrandt
06:10:08 *** aka_007 has joined #openmrs
06:12:01 *** LeeBreisacher has left #openmrs
06:12:59 *** harshadura has joined #openmrs
06:12:59 *** ChanServ sets mode: +v harshadura
06:21:31 <aka_007> harsz89, hie...
06:28:00 *** kushal_ has joined #openmrs
06:28:02 *** maurya has joined #openmrs
06:30:44 *** aka_007 has quit IRC
06:30:54 *** ChanServ sets mode: +v maurya
06:34:39 <Shangeetha> mseaton: Hi
06:40:00 *** Shangeetha has quit IRC
06:49:03 *** harshadura has quit IRC
06:55:18 *** pascal` has joined #openmrs
06:55:18 *** ChanServ sets mode: +v pascal`
06:56:29 *** psbrandt has quit IRC
07:00:31 *** jmiranda has quit IRC
07:04:34 *** harshadura has joined #openmrs
07:04:35 *** ChanServ sets mode: +v harshadura
07:07:44 *** kushal_ has quit IRC
07:41:01 *** harshadura_ has joined #openmrs
08:00:08 *** aka_007 has joined #openmrs
08:01:46 <aka_007> rafa, hie
08:09:34 <harsz89> aka_007, hi
08:10:54 <aka_007> harsz89, In that page I am adding a void button so that admin can void the patient and if we go to the same person's page.. an alert will be asked to unvoid the person... Is it right??
08:12:42 <aka_007> harsz89, And also I am in this page http://localhost:8080/openmrs/admin/patients/patient.form?patientId=7 and under patient information beside deleted a false option is written ... Is it suppose to behave in same way... ?? I am sharing a screenthot of it..
08:13:40 <harsz89> thtz fine i think
08:13:54 <harsz89> unvoid thing
08:14:15 <harsz89> aka_007, or if you have any other way you can propose it in dev list
08:14:29 <aka_007> harsz89, please have look at this page http://www.flickr.com/photos/117291223@N02/12630004155/
08:14:33 <OpenMRSBot> <http://ln-s.net/B1Nz> (at www.flickr.com)
08:15:05 <aka_007> beside deleted there is just an option false... and when i try to delete the patient... it shows an error message that the person cannot be deleted. @harsz89
08:19:11 <harsz89> aka_007, is that patient created by you?
08:19:17 <aka_007> harsz89, yes
08:22:54 <aka_007> harsz89, any idea about this..??
08:25:07 <harsz89> aka_007, okey how you get the delete false options there/
08:25:08 <harsz89> ?
08:25:30 <aka_007> harsz89, it was there in the git repo... I cloned it again just before 15 minutes...
08:26:07 <harsz89> aka_007, wait is tht coming from demo data or?
08:26:46 <aka_007> harsz89, local host
08:26:59 <harsz89> aka_007, yeap i mean the patient
08:27:18 <harsz89> aka_007, when you create a new patient is tht patient assign delete false always
08:27:20 <harsz89> ?
08:27:53 <aka_007> harsz89, yaa
08:28:01 <harsz89> not have a much idea about this but seems like that patient cannot be delete when it set delete false
08:28:29 <aka_007> harsz89, utter sorry I have a class from 2pm-3.30pm . I will get back after that...kindly look into it if possible.. thank you.. :)
08:28:31 *** aka_007 has quit IRC
08:38:56 *** akashagarwal has quit IRC
08:39:08 *** kushal_ has joined #openmrs
08:58:39 *** aka_007 has joined #openmrs
08:58:53 <aka_007> harsz89, class cancelled :D
09:02:53 <harsz89> aka_007, oh okey :)
09:03:16 <harsz89> aka_007, i think id delete set false you cant delete tht patient
09:03:32 <harsz89> aka_007, not sure you may needs to ask from other as well
09:03:55 <aka_007> harsz89, ohh okay...
09:04:49 <aka_007> harsz89, when the person is voided the option beside deleted is set to true and if it's not voided it's set to false.... However I am unable to make the person void... I have voided the person manually from mysql...
09:05:15 <aka_007> harsz89, ***However I am unable to make the person void from UI.....
09:06:06 <harsz89> aka_007, in demo servers those things works fine right?
09:06:15 <harsz89> aka_007, i just checked it there
09:06:42 <aka_007> harsz89, yaa I guess... let me check from there...
09:07:50 <aka_007> harsz89, yaa In the demo server it works perfectly fine...
09:08:26 <aka_007> harsz89, which version of openmrs is running in demo server... any idea..??
09:08:31 <harsz89> aka_007, 1.9.7
09:09:06 <aka_007> harsz89, ahh okay... I am integrating those changes in here... because that is the perfect one, I guess... ??
09:09:14 <harsz89> aka_007, yeap
09:09:23 <harsz89> aka_007, and make a comment on d ticket
09:09:32 <harsz89> aka_007, saying the difference
09:09:46 <aka_007> harsz89, okay...
09:10:10 <harsz89> latest version not have a any option to void a patient from UI know?
09:17:57 *** Siv has joined #openmrs
09:18:16 <Siv> Hello
09:18:22 <Siv> Any one out there
09:19:05 <Siv> I have a one doubt on openMrs
09:20:21 <Siv> hiiiiii
09:21:03 *** kushal_ has quit IRC
09:24:59 <harsz89> Siv,
09:25:07 <harsz89> Siv, yes what's the matter
09:26:32 <Siv> I would like to join in open mrs in a development.. could you please tell me what is the process
09:28:38 *** akashagarwal has joined #openmrs
09:29:00 <aka_007> harsz89, yaa there is no option to do so...
09:33:07 *** Shangeetha has joined #openmrs
09:33:23 <harsz89> aka_007, okey mention all the things you observed in the ticket
09:33:23 <Shangeetha> mseaton: Hi
09:33:34 <harsz89> aka_007, so someone will respond it
09:33:37 <Siv> Hi
09:33:41 <aka_007> harsz89, Yaa I have ...
09:33:45 <harsz89> Siv, hi
09:33:52 <Siv> I would like to join in open mrs in a development.. could you please tell me what is the process
09:33:56 <harsz89> Siv, okey did you see
09:34:11 <Siv> what?
09:34:33 <Shangeetha> mseaton, Hi
09:34:36 <harsz89> Siv, https://wiki.openmrs.org/display/docs/Getting+Started+as+a+Developer
09:34:37 <OpenMRSBot> <http://ln-s.net/8bkO> (at wiki.openmrs.org)
09:35:00 <harsz89> Siv, that the step by step process to start the development
09:35:00 <aka_007> harsz89, just a small help which controller does this page use... openmrs-core/webapp/src/main/webapp/WEB-INF/view/admin/person/index.jsp...the problem encountered here is that it searches for all the patients including the voided one even if the voided checkbox is unchecked...
09:35:59 <harsz89> aka_007, should be personController or personSearchController
09:36:16 <aka_007> harsz89, okay... got it...
09:36:24 <harsz89> aka_007, :)
09:39:47 <Siv> harsz89, what is that process
09:40:14 <harsz89> Siv, first you needs to setup your environment
09:40:19 *** k-joseph has joined #openmrs
09:40:40 <Siv> k, what next
09:40:47 <harsz89> Siv, in that wiki page you can see a link for setting up the envionment
09:40:59 <harsz89> Siv, then hitting some introductory tickets
09:40:59 <Siv> k,
09:41:19 <harsz89> Siv, wiki page contains all the details you needs
09:41:27 <harsz89> Siv, buzz me if anything is not clear
09:41:53 <Siv> k.. thank you harsz89
09:50:11 <aka_007> maurya, hie...
09:50:25 *** dkayiwa has joined #openmrs
09:51:24 <aka_007> dkayiwa, hie..
09:54:00 *** Siv has quit IRC
09:59:42 <dkayiwa> aka_007: hi
10:00:31 <aka_007> dkayiwa, in this page http://localhost:8080/openmrs/admin/person/index.htm it searches for all patients including voided ones... is it supposed to behave in this way..??
10:02:30 <dkayiwa> aka_007: there should be a toggle for include voided
10:03:33 <aka_007> dkayiwa, no that's the ticket ... we need to include that in the code... but by default it searches for both voided and unvoided.... in this page openmrs-core/webapp/src/main/webapp/WEB-INF/view/admin/person/index.jsp
10:03:34 <Shangeetha> dkayiwa: Hi
10:04:01 <dkayiwa> Shangeetha: hi
10:04:25 <dkayiwa> aka_007: look at our other search pages and see if they all include a toggle for include voided
10:04:30 <Shangeetha> dkayiwa: We are using sync module and patient_search table is not being synchronized. What might be the reason?
10:04:35 *** akashagarwal has quit IRC
10:04:37 <aka_007> dkayiwa, okay...
10:05:03 <dkayiwa> Shangeetha: I do not know. but you can ask on the mailing list
10:05:14 <Shangeetha> dkayiwa: Ok sure :)
10:23:15 *** aka_007 has quit IRC
10:29:00 *** harshadura__ has joined #openmrs
10:31:59 *** harshadura_ has quit IRC
10:32:33 *** harshadura_ has joined #openmrs
10:32:33 *** harshadura has quit IRC
10:37:48 *** pascal` has quit IRC
10:38:29 *** psbrandt has joined #openmrs
10:38:29 *** ChanServ sets mode: +v psbrandt
10:42:36 *** harsz89 has quit IRC
10:48:42 *** Shangeetha has quit IRC
10:55:23 *** harsz89 has joined #openmrs
10:55:24 *** ChanServ sets mode: +v harsz89
11:07:58 *** dkithmal has joined #openmrs
11:11:35 *** chethiya has joined #openmrs
11:15:33 *** k-joseph has quit IRC
11:16:29 *** maurya has quit IRC
11:41:43 *** Akshika47 has joined #openmrs
11:42:04 <Akshika47> @downey
11:42:18 <Akshika47> are u familiar with "REST"
11:42:22 <Akshika47> I have few issues
11:45:03 *** k-joseph has joined #openmrs
11:45:35 <k-joseph> dkayiwa: am not sure when it involves the taxes, but some time back i inquired from brother John and he says there are delivery groups that may it cheaper, however from the online shops there are comparably cheaper see http://harvestimebooks.com/store/#!/~/product/id=11100069
11:45:39 <OpenMRSBot> <http://ln-s.net/B1Z6> (at harvestimebooks.com)
11:45:47 <k-joseph> sorry
11:45:59 <dkayiwa> k-joseph: :)
11:47:06 <Akshika47> dkayiwa
11:47:22 <Akshika47> I have some issues with REST
11:47:41 <Akshika47> I am still in the initial stage of using it,
11:48:23 <Akshika47> I am still testing, I went through the documentation, But I am unable to produce a correct query which works
11:48:47 <Akshika47> GET /openmrs/ws/rest/v1/Saranee/0141b070-a7b9-4619-889f-c1833719e2d2
11:48:56 <Akshika47> {"Saranee":"0141b070-a7b9-4619-889f-c1833719e2d2"}
11:49:24 <Akshika47> this is what I tried, I think the syntax is wrong, But I am unable to find correct syntax
11:49:34 <Akshika47> dkayiwa:
11:51:53 <dkayiwa> Akshika47: which documentation did you read?
11:52:13 <Akshika47> https://wiki.openmrs.org/display/docs/Adding+a+Web+Service+Step+by+Step+Guide+for+Core+Developers
11:52:21 <Akshika47> https://wiki.openmrs.org/display/docs/REST+Web+Services+API
11:52:22 <OpenMRSBot> <http://ln-s.net/8zTB> (at wiki.openmrs.org)
11:52:51 <Akshika47> dkayiwa: and related stuff on internet
11:53:18 <Akshika47> I am bit confused of what is the correct syntax, because this is the first time I am using REST
11:57:59 <Akshika47> dkayiwa : and also, when I press Help in Admin
11:58:05 <Akshika47> it gives an error
12:19:07 *** shubh has joined #openmrs
12:24:11 *** aka_007 has joined #openmrs
12:24:58 *** k-joseph has quit IRC
12:32:21 *** dkayiwa has quit IRC
12:34:20 *** Akshika47 has quit IRC
12:35:12 *** Shangeetha has joined #openmrs
12:35:42 <Shangeetha> mseaton: Hi
12:36:31 *** aka_007 has quit IRC
12:42:03 *** dkayiwa has joined #openmrs
12:44:17 *** dkithmal_ has joined #openmrs
12:46:29 *** dkithmal has quit IRC
12:54:27 *** dkayiwa has quit IRC
12:57:51 *** dkayiwa has joined #openmrs
13:16:26 *** psbrandt has quit IRC
13:16:59 *** dkithmal_ has quit IRC
13:17:16 *** psbrandt has joined #openmrs
13:17:16 *** ChanServ sets mode: +v psbrandt
13:18:31 *** harshadura__ has quit IRC
13:20:25 *** dkayiwa has quit IRC
13:23:58 *** shubh has quit IRC
13:25:38 *** Shangeetha has quit IRC
13:49:42 *** aka_007 has joined #openmrs
13:51:50 *** psbrandt has quit IRC
13:52:01 *** cioan has joined #openmrs
14:07:40 *** dkithmal has joined #openmrs
14:14:58 *** kushal_ has joined #openmrs
14:17:02 *** dkithmal_ has joined #openmrs
14:17:38 *** dkithmal has quit IRC
14:17:58 *** wluyima has joined #openmrs
14:18:53 *** dkithmal_ has quit IRC
14:21:04 *** kushal_ has quit IRC
14:22:59 *** aka_007 has quit IRC
14:23:20 *** aka_007 has joined #openmrs
14:29:29 <downey> djazayeri: Would you be willing to provide a "pretty" looking screenshot of 2.x for an article on open source health IT?
14:30:01 <downey> djazayeri: whatever you think would be most visually appealing
14:35:54 *** jkeiper_ is now known as jkeiper
14:36:01 *** ChanServ sets mode: +v jkeiper
14:57:41 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1744 has FAILED (1 tests failed) : Manual build by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1744>
15:00:23 *** jmiranda has joined #openmrs
15:07:03 *** harshadura_ has quit IRC
15:10:56 <cpower__> Scrum time!
15:11:02 <cpower__> !scrumon cpower
15:11:02 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
15:11:26 <cpower__> Order: wluyima , djazayeri , rafa
15:13:28 <aka_007> harsz89, hie ... what does this line signify... SessionFactory sessionFactory = (SessionFactory) applicationContext.getBean("sessionFactory");
15:14:50 <cpower__> wluyima: you are up
15:15:10 <wluyima> Tuesday:
15:15:10 <wluyima> - order entry bi weekly call
15:15:12 <wluyima> - Complete RESTWS-405 - Add OrderFrequency resource
15:15:12 <aka_007> harsz89, I am writing unit test for patientsearchcriteria so I need to know this... please help...
15:15:13 <wluyima> - Fix failing builds for REST WS module
15:15:15 <wluyima> - Reviewm merge anc lean up code for RESTWS-409 - Discontinue an order via rest
15:15:16 <wluyima> Wednesday:
15:15:18 <wluyima> - More code refactoring e.g to make Order.startDate not nullable and Order.orderNumber unique in the DB
15:15:19 <wluyima> - design call
15:15:20 <wluyima> - RESTWS-406 - Place a drug order via rest (in 1.10+)
15:15:21 <wluyima> Blockers: None
15:15:38 <cpower__> djazayeri:
15:16:31 <cpower__> wluyima: are we still on track to getting most of this done by the end of the week?
15:16:52 <cpower__> and rafa update when ready
15:17:01 *** akashagarwal has joined #openmrs
15:18:04 <wluyima> cpower__: where this is what? i think i said rest is what i pan to get completed this week
15:18:31 <cpower__> wluyima: right that's what I mean
15:18:44 <wluyima> cpower__: even though it is getting trickier because am working on everything solely right now, did you see the email i sent out
15:19:09 <wluyima> cpower__: but i think i can do it
15:19:13 <cpower__> wluyima: sent to me or to the dev list?
15:19:30 <wluyima> cpower__: several people including you
15:19:54 <cpower__> wluyima: just found it (sorry)
15:20:58 <cpower__> wluyima: when you say you haven't heard from anyone since Thursday, who did you expect to hear from?
15:22:08 <wluyima> cpower__: probably i phrased it badly but i meant to say i haven't actually heard from them and hadn't had any input from them since thursday
15:22:35 <cpower__> wluyima: from Bahmni and KenyaEMR?
15:22:35 *** robbyoconnor has quit IRC
15:22:36 *** cioan1 has joined #openmrs
15:22:36 *** cioan has quit IRC
15:23:19 *** cioan has joined #openmrs
15:23:19 *** cioan1 has quit IRC
15:23:28 <cpower__> !scrumoff
15:23:28 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
15:24:43 <cpower__> wluyima: should be a topic for a PM
15:24:48 <cpower__> call
15:37:50 *** aka_007 has quit IRC
15:42:54 *** cioan1 has joined #openmrs
15:43:01 *** cioan has quit IRC
15:45:17 *** cioan1 has quit IRC
15:45:30 *** cioan has joined #openmrs
15:52:15 *** cioan1 has joined #openmrs
15:52:17 *** cioan has quit IRC
15:53:47 *** shubh has joined #openmrs
15:54:36 *** ashishk has joined #openmrs
15:56:32 *** shubh_ has joined #openmrs
16:02:22 *** k-joseph has joined #openmrs
16:05:58 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1745 has FAILED (4 tests failed) : Manual build by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1745>
16:07:56 *** k-joseph has quit IRC
16:09:22 *** aka_007 has joined #openmrs
16:10:17 *** k-joseph has joined #openmrs
16:12:29 *** cioan has joined #openmrs
16:12:30 *** cioan1 has quit IRC
16:13:14 <wluyima> cpower__: sure
16:15:36 *** k-joseph has quit IRC
16:15:37 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1746 has FAILED (7 tests failed) : Manual build by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1746>
16:15:55 <harsz89> aka_007, oopz i think itz relates to hibernate
16:16:06 <harsz89> aka_007, you needs to have it to access it
16:16:19 <harsz89> aka_007, is it okey now?
16:16:55 <aka_007> harsz89, I didn't get you. You are talkin in which context..??
16:23:12 *** robbyoconnor has joined #openmrs
16:23:12 *** ChanServ sets mode: +v robbyoconnor
16:23:13 *** robbyoconnor has quit IRC
16:23:15 <harsz89> aka_007, you ask about sessionfactory
16:23:46 <aka_007> harsz89, what is the function of this line.. .??
16:24:06 <harsz89> aka_007, mhhh you needs sessionFactory
16:24:30 <aka_007> harsz89, okay... like it's mandatory in a unit test case... ??
16:25:21 <harsz89> aka_007, itz depend on a unit test
16:25:28 <aka_007> harsz89, ohh okay...
16:28:04 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1747 has FAILED (7 tests failed) : Updated by Rafal Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1747>
16:35:17 *** LeeBreisacher has joined #openmrs
16:36:42 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1748 has FAILED (7 tests failed) : Manual build by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1748>
16:39:06 *** dkayiwa has joined #openmrs
16:43:20 *** cioan1 has joined #openmrs
16:43:21 *** cioan has quit IRC
16:43:58 *** shubh has quit IRC
16:44:21 <aka_007> dkayiwa, hie... in this page http://localhost:8080/openmrs/admin/patients/patient.form?patientId=7 I am trying to delete the patient... but it shows an error "This patient cannot be deleted" (without any further error)
16:44:23 *** shubh_ has quit IRC
16:45:09 *** ashishk has quit IRC
16:45:28 <dkayiwa> aka_007: why do you want to delete the patient?
16:46:28 <aka_007> dkayiwa, I am on this ticket.. https://tickets.openmrs.org/browse/TRUNK-3967.. so I am deleting(assuming it's voided) and then I will search in the page "http://localhost:8080/openmrs/admin/person/index.htm"
16:46:49 <dkayiwa> aka_007: voiding is not the same as deleting
16:47:32 <aka_007> dkayiwa, I know that... but in this page does it imply the same....
16:48:00 <dkayiwa> aka_007: does it say you delete the patient?
16:49:46 <aka_007> dkayiwa, no it says ... that we have to search the patient (with including deleted checkbox).... so i need to check whether it does it or not.. I can do it by mysql.. by making the voided attribute of the patient as 1...
16:50:51 <dkayiwa> aka_007: does it really way deleted or voided?
16:52:02 <aka_007> dkayiwa, http://localhost:8080/openmrs/admin/patients/patient.form?patientId=7 I am trying to void a patient in this same page.... but there is no option in this latest version... I confirmed it with harsz89 ... please look into it
16:56:34 *** LeeBreisacher has left #openmrs
16:58:57 <aka_007> dkayiwa, you saw it... ??
17:01:22 <dkayiwa> aka_007: checking
17:01:29 <aka_007> dkayiwa, okay... :)
17:02:48 <dkayiwa> aka_007: just seen it. The Delete Patient option is the one which means Void Patient
17:03:02 <dkayiwa> aka_007: so use that
17:03:30 <aka_007> dkayiwa, okay... are you able to delete a patient from UI... ?? when I try to do that it says "the patient cannot be deleted" .. (in local server)
17:04:09 <dkayiwa> aka_007: yes it says so
17:04:42 <aka_007> dkayiwa, Is it a bug.. ?? because in previous versions like in the demo.openmrs.org it works fine...
17:05:05 <dkayiwa> aka_007: that looks like a bug. it was supposed to void instead of deleting
17:05:22 <dkayiwa> aka_007: create a ticket
17:07:06 <aka_007> dkayiwa, okay... doing it.... in this ticket... https://tickets.openmrs.org/browse/TRUNK-3967 ... I have included the checkbox to include voided people.... (and when one migrates to that page it shows the message that "this person is voided, do you want to restore it"
17:07:34 <aka_007> dkayiwa, however I voided the patient from mysql database and tested it... so do I go for code-review option for this ticket...??
17:08:56 <dkayiwa> aka_007: the ticket should be about restoring it
17:09:22 <dkayiwa> aka_007: as long as you are through with the changes that the ticket requires, you can always request for code review
17:09:42 <aka_007> dkayiwa, but we are able to restore it, if it's voided in the same screen ... an option with "Restore the patient" appears....
17:10:20 <dkayiwa> aka_007: just as it happens on the demo server which is running 1.9.x
17:10:24 <aka_007> dkayiwa, I guess the ticket should be about voiding the patient .. which we are unable to do....
17:10:27 <dkayiwa> 1.9.7
17:10:27 <aka_007> dkayiwa, yaa...
17:10:43 <aka_007> dkayiwa, yaa .. same as demo.openmrs.org(1.9.7)
17:15:58 <aka_007> dkayiwa, so I am reporting about "unable to void/delete the patient in this page as ticket", Shall I go with it??
17:16:24 <dkayiwa> aka_007: that is up to you :)
17:16:57 <aka_007> dkayiwa, okay... :) ..
17:21:56 *** cioan has joined #openmrs
17:21:56 *** cioan1 has quit IRC
17:37:10 *** hybridivy has joined #openmrs
17:37:31 *** hybridivy has left #openmrs
17:47:51 *** cioan1 has joined #openmrs
17:47:55 *** cioan has quit IRC
18:00:27 <OpenMRSBot> Recent updates in the world of openmrsci: EMRAPI-EMRAPI-454 has FAILED (1 tests failed) : Dependant of RESTWS-RESTWS-96 <https://ci-stg.openmrs.org/browse/EMRAPI-EMRAPI-454>
18:04:21 *** cioan1 has quit IRC
18:04:23 *** cioan has joined #openmrs
18:14:58 *** dkayiwa has quit IRC
18:25:36 *** aka_007 has quit IRC
18:26:18 *** aka_007 has joined #openmrs
18:28:17 *** k-joseph has joined #openmrs
18:29:14 *** dkayiwa has joined #openmrs
18:31:15 *** psbrandt has joined #openmrs
18:31:15 *** ChanServ sets mode: +v psbrandt
18:32:45 *** cioan has quit IRC
18:40:49 *** cioan has joined #openmrs
18:57:22 <aka_007> dkayiwa, A small doubt in here... to which file is the search functionality of this file related ... openmrs-core/webapp/src/main/webapp/WEB-INF/view/admin/patients/index.jsp
18:59:07 <aka_007> dkayiwa, if I make the changes in the index.jsp file as is changed in the search functionality of other pages... still the voided data is not included... changes at the controller level has to be done... please help.. :)
19:11:10 <aka_007> harsz89, you there.. ??
19:20:18 *** GitHub182 has joined #openmrs
19:20:18 <GitHub182> [openmrs-core] WolfSchlegel opened pull request #653: Implemented checks for overlapping visits (master...TRUNK-3963) http://git.io/mfMNEQ
19:20:18 *** GitHub182 has left #openmrs
19:23:34 *** dkayiwa has quit IRC
19:23:49 *** dkayiwa has joined #openmrs
19:25:10 <aka_007> dkayiwa, hie...
19:25:38 <dkayiwa> aka_007: hi
19:25:55 <aka_007> dkayiwa, A small doubt in here... to which file is the search functionality of this file related ... openmrs-core/webapp/src/main/webapp/WEB-INF/view/admin/patients/index.jsp
19:26:08 <aka_007> dkayiwa, if I make the changes in the index.jsp file as is changed in the search functionality of other pages... still the voided data is not included... changes at the controller level has to be done... please help.. :)
19:30:33 *** k-joseph has quit IRC
19:33:32 <aka_007> dkayiwa, any idea on it.. :) ??
19:34:24 <dkayiwa> aka_007: i do not seem to understand u
19:35:55 <aka_007> dkayiwa, for the html view we have the file openmrs-core/webapp/src/main/webapp/WEB-INF/view/admin/patients/index.jsp ... for it's search functionality... it calls which controller files.... passing the parameters..??
19:38:33 <aka_007> dkayiwa, did you understand me.. ??
19:38:45 <dkayiwa> aka_007: which ticket are you working on
19:38:58 <aka_007> dkayiwa, https://tickets.openmrs.org/browse/TRUNK-3967
19:39:38 <dkayiwa> !ticket trunk-3967
19:39:39 <OpenMRSBot> dkayiwa: [#TRUNK-3967] Need to have option to unvoid Person on UI - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3967
19:40:21 <dkayiwa> aka_007: have u already added the unvoid button?
19:41:04 <aka_007> dkayiwa, the unvoid button must appear in the patient view page if the patient is voided, right?? yaa I have added that ...
19:41:46 <dkayiwa> aka_007: for an example, look at the unvoid button of other pages
19:42:06 <dkayiwa> unretire
19:43:07 <aka_007> dkayiwa, yaa it matches with the one in demo.openmrs.org page... the link is http://demo.openmrs.org/openmrs/admin/patients/patient.form?patientId=43
19:44:06 <dkayiwa> aka_007: can you show me a screenshot of your unvoid button
19:45:53 <aka_007> dkayiwa, http://www.flickr.com/photos/117291223@N02/12640853543/
19:45:57 <OpenMRSBot> <http://ln-s.net/B20m> (at www.flickr.com)
19:47:31 <aka_007> dkayiwa, this is the one...
19:50:55 *** k-joseph has joined #openmrs
19:51:20 *** k-joseph_ has joined #openmrs
19:54:45 *** psbrandt has quit IRC
19:56:08 <aka_007> dkayiwa, you saw it .... ?? sorry for poking again and again...
19:56:49 *** k-joseph__ has joined #openmrs
19:58:05 *** k-joseph__ has quit IRC
19:58:29 *** k-joseph has quit IRC
19:59:02 *** k-joseph_ is now known as k-joseph
20:03:43 *** dkayiwa has quit IRC
20:13:29 *** aka_007 has quit IRC
20:42:44 *** harsz89 has quit IRC
20:54:07 *** harsz89 has joined #openmrs
20:54:07 *** ChanServ sets mode: +v harsz89
21:03:42 *** suraj has joined #openmrs
21:04:30 <suraj> djazayeri: are you free for a moment
21:04:30 <suraj> ?
21:05:59 <djazayeri> suraj: on a call now, and I have another call after it…
21:07:29 <suraj> djazayeri: kk.I just need 2 min of your time.If you are done with your you can reply me.:)
21:07:59 <suraj> djazayeri: *call
21:08:29 *** k-joseph has quit IRC
21:12:45 <suraj> mseaton: are you free for moment?This is regarding trunk-49 and trunk-3580.I'm working on both of those tickets.
21:15:56 *** v has joined #openmrs
21:19:02 *** aakash has joined #openmrs
21:19:27 *** aakash has quit IRC
21:20:14 *** v has quit IRC
21:20:51 <djazayeri> suraj: what's up?
21:21:44 <suraj> djazayeri: so much thanks djazayeri .I'm working on trunk-3850
21:23:01 <djazayeri> suraj: and?
21:23:33 <suraj> djazayeri: I actually the ticket said that to use ProgramWorkflowService.getProgramByName
21:24:49 <suraj> djazayeri: when i used ProgramWorkflowService.getProgramByName.getProgramByName(p.getname());
21:25:19 <suraj> djazayeri: its returning null value even though there are dupliates
21:25:34 <djazayeri> suraj: in a unit test?
21:26:04 <suraj> djazayeri: no tried it throug debugging
21:26:25 <suraj> djazayeri: *through
21:27:17 <djazayeri> suraj: first off, I suggest a unit test. :-)
21:27:32 <djazayeri> suraj: (which you can combine with debuggin)
21:27:47 <suraj> djazayeri: no,unit tests are failing
21:28:09 <djazayeri> suraj: you're sure that the database has what you expect in it?
21:28:50 <suraj> djazayeri: i dont know for what reason even though without changing any code i just wrote Program program1 = Context.getProgramWorkflowService().getProgramByName(p.getName());
21:29:08 <suraj> djazayeri: those unit tests are failing
21:29:44 <djazayeri> suraj: which is the unit test that starts to fail when you change this?
21:29:45 <suraj> djazayeri: i'm not even using program1
21:30:41 <suraj> djazayeri: public void validate_shouldFailValidationIfDescriptionIsNullOrEmptyOrWhitespace()
21:30:53 <suraj> djazayeri: public void validate_shouldFailValidationIfNameIsNullOrEmptyOrWhitespace()
21:31:14 <djazayeri> And how do they fail?
21:31:54 <suraj> djazayeri: i'm not able to build my war file
21:32:08 <djazayeri> suraj: they give an error message or stack trace
21:33:10 <suraj> djazayeri: in my ticket under comments i pasted all the errors file whicj are failing
21:37:48 <suraj> djazayeri: *which
21:44:06 <djazayeri> suraj: so, the NonUniqueObjectException is tricky
21:44:09 <djazayeri> suraj: https://wiki.openmrs.org/display/docs/Troubleshooting+Hibernate
21:46:01 <suraj> djazayeri: I think this might be the issue.i'll try it .
21:48:58 <suraj> djazayeri: i request you to please check trunk-4021.I unable to replicate this issue
21:49:36 <suraj> djazayeri: there is no chance of adding duplicates it showing error while the time of creating an attribute
21:49:58 <suraj> djazayeri: duplicate attribute
21:50:27 <djazayeri> suraj: hmm; perhaps it used to be allowed, so legacy data my have this issue.
21:52:21 <suraj> djazayeri: kk
21:53:20 <suraj> djazayeri: but legacy data into my sql so that i can try
21:53:49 <suraj> djazayeri: * how can i get legacy data into mysql so that i can try
21:54:42 <djazayeri> suraj: you could manually insert into the database using a mysql admin or command line tool
21:55:41 <suraj> djazayeri: okay
21:56:33 <suraj> djazayeri: thanks djazayeri so much for your help.:)
21:56:44 <djazayeri> suraj: np
21:59:58 <suraj> djazayeri: can i ask you one more question please if you don't mind regarding trunk-49
22:00:53 <djazayeri> suraj: yes?
22:01:00 <suraj> djazayeri: i cannot replicate this issue in openmrs 1.8 but mseaton said there was a problem in 1.7
22:01:27 <djazayeri> suraj: there _may_ be a problem in 1.7
22:02:23 <suraj> djazayeri: but openmrs 1.7 is in svn
22:02:31 <mseaton> djazayeri: ps. i just realized i was running 1.7.2 when i was hitting the issue we skyped about. upgrading to 1.9.7 and the issue is gone :) not sure if this is related to suraj issue or not, but fyi
22:04:02 <djazayeri> suraj: to verify if the issue still exists you would either need to check out 1.7.x from svn, or else just download the 1.7.4 WAR file from sourceforge
22:04:53 <djazayeri> suraj: that said, if that issue has been fixed in 1.8 and 1.9, I think it's fair to just close the TRUNK-49 ticket as having already been fixed
22:04:56 <djazayeri> suraj: gotta run for a bit
22:07:02 <suraj> djazayeri: kk.should i test 1.7 war file?
22:11:01 <suraj> djazayeri: if it requires in 1.7 ,i request mseaton to reply in the ticket comments,so that i'll start working
22:11:44 <mseaton> suraj: this is for trunk-3850?
22:12:00 <suraj> mseaton: no for trunk-49
22:14:04 <mseaton> suraj: it's not super important to me. all implementations i support are moving to 1.9. i noticed the problem 4 years ago and reported it then, but don't have much more to add now. it's possible that it is still a bug in 1.7, but i haven't confirmed or denied that.
22:14:42 <mseaton> suraj: it's certainly an option to close this as having been fixed in 1.8 and 1.9
22:15:26 <suraj> mseaton: thanks mseaton for your response..:)
22:16:31 <suraj> mseaton: i already worked on facility-23.i sended a pull request for the changes i made.
22:16:57 <mseaton> suraj: i saw that - thanks! i'm going to try to review that in the next week.
22:17:07 <suraj> mseaton: but if you need me to send a war file i'll send
22:17:26 <suraj> mseaton: facility data module
22:17:36 <mseaton> suraj: no need, i'll pull down your branch and test it out and let you know how it goes. thanks again!
22:18:01 <suraj> mseaton: thanks so much mseaton .:)
22:23:40 *** cioan has quit IRC
22:26:29 *** suraj has quit IRC
22:34:48 <mseaton> djazayeri: i notice that we don't have any parameters exposed by default on ConvertedPatientDataDefinition
22:35:27 <mseaton> djazayeri: never mind. hang on.
22:36:25 *** shubh has joined #openmrs
23:15:16 *** wluyima has quit IRC
23:48:25 *** ChanServ sets mode: +o jmiranda