IRC Chat : 2014-02-18 - OpenMRS

00:14:32 *** akashagarwal has joined #openmrs
00:14:51 *** akashagarwal has quit IRC
00:15:25 *** akashagarwal has joined #openmrs
00:17:37 *** akashagarwal has joined #openmrs
00:18:31 *** akashagarwal has joined #openmrs
01:01:54 *** wluyima has joined #openmrs
01:12:02 *** harshadura has joined #openmrs
01:12:02 *** ChanServ sets mode: +v harshadura
02:03:03 <OpenMRSBot> Recent updates in the world of openmrsci: SON-OPENMRSCOREMASTER-150 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-150>
02:05:50 *** harshadura_ has joined #openmrs
02:06:20 *** harshadura has quit IRC
02:16:35 *** harshadura__ has joined #openmrs
02:18:42 *** jmiranda has joined #openmrs
02:19:11 *** harshadura has joined #openmrs
02:19:12 *** ChanServ sets mode: +v harshadura
02:19:52 *** harshadura_ has quit IRC
02:21:20 *** harshadura__ has quit IRC
02:33:39 *** ChanServ sets mode: +o jmiranda
03:07:24 *** harshadura_ has joined #openmrs
03:10:38 *** harshadura has quit IRC
03:55:35 *** harshadura_ has quit IRC
04:26:42 *** Shangeetha has joined #openmrs
04:38:05 *** harshadura has joined #openmrs
04:38:05 *** ChanServ sets mode: +v harshadura
04:44:48 *** Shangeetha has quit IRC
04:55:02 *** jmiranda has quit IRC
04:55:03 <OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-86 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-86>
05:03:45 <OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-87 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-87>
05:10:57 *** charith has joined #openmrs
05:24:19 *** k-joseph has joined #openmrs
05:29:18 *** GitHub184 has joined #openmrs
05:29:18 <GitHub184> [openmrs-core] Fahv opened pull request #648: TRUNK 2119: Improve Crash Reporting (master...TRUNK-2119-Non-Format) http://git.io/RwJVHw
05:29:18 *** GitHub184 has left #openmrs
05:36:09 *** wluyima has quit IRC
05:37:56 *** harshadura has quit IRC
05:51:01 *** harshadura has joined #openmrs
05:51:01 *** ChanServ sets mode: +v harshadura
05:53:51 *** psbrandt has joined #openmrs
05:53:51 *** ChanServ sets mode: +v psbrandt
05:58:14 *** psbrandt has quit IRC
05:58:45 *** psbrandt has joined #openmrs
05:58:45 *** ChanServ sets mode: +v psbrandt
06:23:10 *** VaibhavAgarwal has joined #openmrs
06:24:03 *** harshadura has quit IRC
06:38:08 <OpenMRSBot> Recent updates in the world of openmrsci: REFMETA-REFMETA-286 has FAILED (1 tests failed) : Dependant of EMRAPI-EMRAPI-449 <https://ci-stg.openmrs.org/browse/REFMETA-REFMETA-286>
06:40:10 *** aka_007 has joined #openmrs
06:40:32 <aka_007> rafa, hie..
06:55:41 *** isaac has joined #openmrs
07:04:05 *** akashagarwal has quit IRC
07:09:18 *** GitHub43 has joined #openmrs
07:09:18 <GitHub43> [openmrs-core] saikrishna17 opened pull request #649: New changes (master...Trunk-2280.new) http://git.io/pHDgTw
07:09:18 *** GitHub43 has left #openmrs
07:11:20 *** k-joseph has quit IRC
07:15:40 *** djazayeri1 has joined #openmrs
07:17:37 *** djazayeri has quit IRC
07:18:58 *** Sai has joined #openmrs
07:19:36 *** maurya has joined #openmrs
07:20:02 *** ChanServ sets mode: +v maurya
07:29:38 *** psbrandt has quit IRC
07:29:41 *** pascal` has joined #openmrs
07:29:42 *** ChanServ sets mode: +v pascal`
07:34:21 *** isaac has quit IRC
07:34:40 *** isaac has joined #openmrs
07:34:48 *** maurya has quit IRC
07:35:28 *** aka_007 has quit IRC
07:35:38 *** Sai has quit IRC
07:40:38 *** VaibhavAgarwal has quit IRC
07:43:55 *** isaac has quit IRC
07:44:26 *** isaac has joined #openmrs
07:58:36 *** dkayiwa has joined #openmrs
08:03:14 *** dkayiwa has quit IRC
08:34:57 *** VaibhavAgarwal has joined #openmrs
08:46:42 *** k-joseph has joined #openmrs
08:49:21 *** isaac_ has joined #openmrs
08:50:21 *** isaac has quit IRC
08:50:38 *** robbyoconnor has joined #openmrs
08:50:39 *** robbyoconnor has joined #openmrs
08:50:39 *** ChanServ sets mode: +v robbyoconnor
08:52:33 *** dkayiwa has joined #openmrs
08:56:47 *** isaac_ has quit IRC
09:16:36 *** isaac has joined #openmrs
09:44:52 <OpenMRSBot> Recent updates in the world of openmrsci: REFMETA-REFMETA-287 has FAILED (1 tests failed) : Dependant of EMRAPI-EMRAPI-450 <https://ci-stg.openmrs.org/browse/REFMETA-REFMETA-287>
09:44:58 *** k-joseph has quit IRC
09:59:22 *** isaac_ has joined #openmrs
09:59:42 *** isaac has quit IRC
10:00:11 *** GitHub74 has joined #openmrs
10:00:11 <GitHub74> [openmrs-core] aniketha opened pull request #650: trunk-10 (master...trunk-10) http://git.io/-m1Qmw
10:00:11 *** GitHub74 has left #openmrs
10:03:17 *** lgargu has joined #openmrs
10:04:55 *** lgargu has quit IRC
10:05:25 *** isaac_ has quit IRC
10:08:24 *** aka_007 has joined #openmrs
10:09:21 *** pascal` has quit IRC
10:10:05 *** pascal` has joined #openmrs
10:10:05 *** ChanServ sets mode: +v pascal`
10:13:15 <aka_007> dkayiwa, hie
10:14:35 *** harsz89 has joined #openmrs
10:14:35 *** ChanServ sets mode: +v harsz89
10:15:03 <dkayiwa> aka_007: hi
10:20:14 *** akashagarwal has joined #openmrs
10:45:43 *** k-joseph has joined #openmrs
11:05:17 <aka_007> dkayiwa, regarding the last pull request that you clarified ... you told it contained multiple ticket request .. but it actually contained only that tickets request...
11:05:45 <dkayiwa> aka_007: comment on the ticket
11:06:04 <aka_007> dkayiwa, pull request https://github.com/openmrs/openmrs-core/pull/644
11:06:37 <aka_007> dkayiwa, yaa I have commented on that ticket ... I have also created a separate pull request. Kindly verify that so that I can improvise if any errors still exist.
11:06:55 <dkayiwa> aka_007: do you see that the pull request has two commits?
11:07:36 <dkayiwa> aka_007: check under this title: root added some commits 4 days ago
11:08:09 *** VaibhavAgarwal has quit IRC
11:08:20 <aka_007> dkayiwa, the one with the second is the correct one..
11:08:42 <aka_007> dkayiwa, Clarify required fields on management interface
11:09:41 <aka_007> dkayiwa, Also I did the pull request on this link... https://github.com/openmrs/openmrs-core/pull/646
11:09:56 <aka_007> dkayiwa, everytime two branches get created ... however second one is the correct one..
11:10:26 *** dkayiwa has quit IRC
11:10:29 *** k-joseph has quit IRC
11:15:00 *** cioan1 has quit IRC
11:15:26 *** cioan1 has joined #openmrs
11:23:17 <OpenMRSBot> Recent updates in the world of openmrsci: REFMETA-REFMETA-288 has FAILED (1 tests failed) : Updated by Rafal Korytkowski <https://ci-stg.openmrs.org/browse/REFMETA-REFMETA-288>
11:28:37 *** aka_007 has quit IRC
11:29:22 *** charith has quit IRC
11:32:58 *** dkayiwa has joined #openmrs
11:35:19 <OpenMRSBot> Recent updates in the world of openmrsci: REFMETA-REFMETA-289 has FAILED (1 tests failed) : Manual build by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/REFMETA-REFMETA-289>
11:45:51 *** GitHub28 has joined #openmrs
11:45:52 <GitHub28> [openmrs-core] vaibhav-hp opened pull request #651: Trunk 2809 Removing a description from an existing concept and trying to save should give a user friendly error message (master...TRUNK-2809) http://git.io/mauFTA
11:45:52 *** GitHub28 has left #openmrs
11:48:08 *** pascal` has quit IRC
11:48:54 *** pascal` has joined #openmrs
11:48:54 *** ChanServ sets mode: +v pascal`
11:53:25 *** aka_007 has joined #openmrs
12:07:17 *** cioan1 has quit IRC
12:08:06 *** pascal` has quit IRC
12:11:19 *** psbrandt has joined #openmrs
12:11:19 *** ChanServ sets mode: +v psbrandt
12:13:27 <OpenMRSBot> Recent updates in the world of openmrsci: REFMETA-REFMETA-290 has FAILED (1 tests failed) : Manual build by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/REFMETA-REFMETA-290>
12:33:32 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1735 has FAILED (1 tests failed) : Dependant of RDD-RDD-390 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1735>
12:35:35 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1736 has FAILED : Manual build by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1736>
12:39:51 *** k-joseph has joined #openmrs
12:40:33 <k-joseph> dkayiwa: hi
12:40:45 <dkayiwa> k-joseph: hi
12:41:24 *** akwatuha_____ is now known as akwatuha
12:43:34 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1737 has FAILED (1 tests failed) : Updated by Rafal Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1737>
12:44:23 *** harshadura has joined #openmrs
12:44:24 *** ChanServ sets mode: +v harshadura
12:46:15 <k-joseph> dkayiwa: working on TRUNK-4030, i had just writen one test and it is failing with a familiar trace, here http://pastebin.com/cQbVW6wD i have tried debugging but when i step into i get a non expected result, i.e. .../3.2.7.RELEASE/spring-aop-3.2.7RELEASE.jar has no source attachment, any help!!!
12:47:51 <dkayiwa> k-joseph: pastebin the exception
12:59:28 <k-joseph> dkayiwa: http://pastebin.com/QXkmp9n8
13:00:24 <dkayiwa> k-joseph: i mean the failing unit test
13:01:58 <k-joseph> dkayiwa: http://pastebin.com/PJNxcQ1B
13:05:18 *** eli has joined #openmrs
13:05:42 *** eli is now known as Guest63856
13:06:13 *** aka_007 has quit IRC
13:07:39 *** Guest63856 is now known as elizil
13:15:22 <dkayiwa> k-joseph: in which class is that unit test
13:16:09 <k-joseph> dkayiwa: FormServiceTest
13:16:43 <dkayiwa> k-joseph: was it an existing test class?
13:17:07 <k-joseph> dkayiwa: yes it was exisiting
13:19:25 <dkayiwa> k-joseph: which line causes trouble
13:19:57 *** dkayiwa has quit IRC
13:21:32 *** dkayiwa has joined #openmrs
13:22:00 <k-joseph> dkayiwa: line 827, that is: fs.saveForm(form);
13:23:49 <dkayiwa> k-joseph: was it working before your changes?
13:25:14 *** cioan has joined #openmrs
13:25:15 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1738 has FAILED (2 tests failed) : Manual build by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1738>
13:29:27 <k-joseph> dkayiwa: i didn't run the test before, however when i remove my test method and comment out where i invoke my checkIfFormsAreLocked() the testcase fails still
13:30:22 <dkayiwa> k-joseph: before doing any changes, a unit test should fail
13:30:30 <dkayiwa> k-joseph: then the code changes a meant to make it pass
13:30:32 *** cioan has quit IRC
13:30:46 *** cioan has joined #openmrs
13:31:33 *** aka_007 has joined #openmrs
13:32:02 *** VaibhavAgarwal has joined #openmrs
13:34:20 <k-joseph> dkayiwa: forexample when i checkout a new branch after pulling add my code and comment it out, i don't expect any failures!!!
13:35:24 <dkayiwa> k-joseph: a unit test should start by failing (should not pass) before implementing what it is supposed to test. Agree?
13:35:56 *** jmiranda has joined #openmrs
13:40:52 <k-joseph> dkayiwa: i agree
13:41:31 <k-joseph> dkayiwa: now if i remove the test, and what it was supposed to do, i expect all to be working well
13:42:49 <dkayiwa> k-joseph: apart from the unit test, have you made any other changes?
13:45:28 <k-joseph> dkayiwa: yes, i made some other changes, however i expect non of them to result into a failure they are not related to
13:46:26 <dkayiwa> k-joseph: with coding, anything un expected can happpen
13:46:41 <k-joseph> dkayiwa: :)
13:46:50 <dkayiwa> k-joseph: so backup your changes and then remove them. Then check the unit test failure again
13:50:36 *** shubh has joined #openmrs
14:01:54 *** k-joseph has quit IRC
14:02:12 *** LeeBreisacher has joined #openmrs
14:02:38 <aka_007> dkayiwa, I just found a ticket on this page http://demo.openmrs.org/openmrs/admin/patients/index.htm
14:03:55 <dkayiwa> aka_007: ok
14:07:17 *** k-joseph has joined #openmrs
14:14:15 *** psbrandt has quit IRC
14:15:14 *** psbrandt has joined #openmrs
14:15:14 *** ChanServ sets mode: +v psbrandt
14:20:00 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1739 has FAILED (1 tests failed) : Updated by Rafal Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1739>
14:23:01 *** shubh has quit IRC
14:23:40 <k-joseph> dkayiwa: we need to clear this non committed formatter issue, that is
14:23:41 <k-joseph> modified: api/src/main/java/org/openmrs/module/ModuleUtil.java
14:25:17 <dkayiwa> k-joseph: ok
14:28:56 *** shubh has joined #openmrs
14:30:20 <shubh> i want to be assignee for this bug https://tickets.openmrs.org/browse/HTML-520 how to do it?
14:33:16 <aka_007> login and click on "claim issue"
14:33:56 <aka_007> shubh, the bug still needs assessment. Look for the approved tickets...
14:33:56 <harshadura> shubh: seeme like the bug hasnt been confirmed yet. so you may need to contact mgoodrich who is the lead of HFE and get it processed.
14:34:04 <harshadura> ^^
14:34:58 <shubh> aka_007: harshadura ok thanks
14:35:12 <aka_007> shubh, anytime. :)
14:36:12 *** wluyima has joined #openmrs
14:37:41 <aka_007> harshadura, hie
14:37:55 <harshadura> hi aka_007
14:38:38 <aka_007> harshadura, a small doubt in here when we void a patient do we remove him completely from the patient table or we flag it?
14:39:17 <harshadura> aka_007 yeah it just get flagged
14:39:19 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1740 has FAILED (1 tests failed) : Dependant of RDD-RDD-391 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1740>
14:39:39 <k-joseph> dkayiwa: i have removed the changes, and reset the branch then added it again and the same error is re-produced again when i run
14:40:11 <dkayiwa> k-joseph: so you only changes now are the unit test?
14:40:30 *** ashishk_ has joined #openmrs
14:41:22 <k-joseph> dkayiwa: yes, that is all am now having
14:41:28 <aka_007> harshadura, but when I delete a patient from this page http://localhost:8080/openmrs/admin/patients/patient.form?patientId=4 I don't see it in database ??
14:41:46 <dkayiwa> k-joseph: pastebin the unit test
14:42:04 <harshadura> aka_007: lemme check that.
14:42:14 <aka_007> harshadura, okay..
14:42:17 *** harsz89 has quit IRC
14:43:06 <k-joseph> dkayiwa: http://pastebin.com/5ddwY4gG
14:50:02 <harshadura> aka_007: whats your openmrs version ?
14:50:13 <aka_007> harshadura, Version: 1.11.0 SNAPSHOT Build b25df4
14:50:44 <harshadura> aka_007: ok
14:51:28 *** VaibhavAgarwal has quit IRC
14:52:14 <k-joseph> dkayiwa: !!!
14:52:48 <dkayiwa> k-joseph: ok
14:54:21 *** harsz89 has joined #openmrs
14:54:22 *** ChanServ sets mode: +v harsz89
14:54:37 <aka_007> dkayiwa, A little help required on this ticket https://tickets.openmrs.org/browse/TRUNK-2224
14:55:36 <aka_007> dkayiwa, When I go to the page http://demo.openmrs.org/openmrs/admin/patients/patient.form?patientId=7280 I find out the VOIDED option under "PATIENT INFORMATION" is "FALSE" and not checkbox unlike to what is stated in the screenshot.
14:55:37 <dkayiwa> aka_007: ask the question on the ticket
14:55:42 <aka_007> dkayiwa, okay...
15:00:21 *** akashagarwal has quit IRC
15:03:58 <ashishk_> dkayiwa:on this page dropdown of form attribute is empty http://localhost:8080/openmrs/admin/encounters/encounter.form
15:04:40 <ashishk_> dkayiwa:what is the purpose of form field in encounter form??
15:09:24 <aka_007> harshadura, you there..??
15:10:03 <harshadura> hi aka_007, sorry for the delay, i just checked out latest code frm github
15:10:21 <harshadura> aka_007: gimme few secs
15:10:51 <aka_007> harshadura, no problem sir. Got one more small doubt..
15:10:52 <OpenMRSBot> Recent updates in the world of openmrsci: REFMETA-REFMETA-294 has FAILED (1 tests failed) : Updated by Rafal Korytkowski <https://ci-stg.openmrs.org/browse/REFMETA-REFMETA-294>
15:11:18 <harshadura> aka_007: hey im not a sir :P dont call like that
15:11:41 <aka_007> harshadura, ohh that was in impulse.. have got use to that.. sorry for that..
15:11:52 <harshadura> aka_007: ok
15:12:27 <aka_007> harshadura, when I go to the page http://demo.openmrs.org/openmrs/admin/patients/patient.form?patientId=43 and try voiding the person I always get the message "Select a preferred identifier"
15:12:31 <aka_007> harshadura, what does it mean?
15:13:38 <harshadura> aka_007: wait checking
15:13:44 <aka_007> harshadura, okay..
15:14:16 <ashishk_> harshadura:hi, i also have a doubt ,whenever i used to add a visit for a patient ,dropdown for "visit type" field is empty i don't have any choice instead of leaving it blank and whenever i do this i got an error message visit type is necessary . i think it is a bug any comments ??
15:21:12 <harshadura> ashishk_: gimme a sec, im installing latest openmrs in my machine
15:21:59 <ashishk_> harshadura: ok
15:23:04 *** robbyoconnor has quit IRC
15:24:14 *** dkayiwa has quit IRC
15:27:44 *** elizil has quit IRC
15:30:50 *** aka_007 has quit IRC
15:38:30 <harshadura> ashishk_: you need to create visit types first via administration tab> visit > manage visit types
15:39:09 <harshadura> aka_007: pu thr ?
15:39:49 * harshadura seems like aka_007 is gone ..
15:42:54 <ashishk_> harshadura: thanks , i got it :)
15:44:54 <ashishk_> harshadura: btw ,i am working on this issue https://tickets.openmrs.org/browse/HTML-404, where do i need to change to add an attribute in the class any suggestion ??
15:44:59 *** k-joseph has quit IRC
15:45:19 *** aka_007 has joined #openmrs
15:56:29 <harshadura> ashishk_, sorry i hv no mch knowledge on HFE could you please consult mgoodrich or write to dev list.
15:57:04 <aka_007> harshadura, hie you there..??
15:57:19 <harshadura> aka_007: hi
15:57:39 <aka_007> harshadura, you got that.. ?? the patient voiding part..??
16:03:07 <harshadura> aka_007: it works, whats the prob ?
16:03:34 <aka_007> harshadura, I am getting this message while voiding it "Select a preferred identifier"
16:04:45 <harshadura> aka_007: didn't you hv a preferred ID for the patient that you are voiding ?
16:05:05 <aka_007> harshadura, no. okay got it. Doing it.
16:05:15 <harshadura> aka_007: ok
16:06:50 <aka_007> harshadura, when we fill in the data keeping the mysql console open then the data doesn't get entered... while if we close the console and try again then it gets entered... Is it a bug?
16:07:40 <wluyima> hi djazayeri1
16:10:18 <harshadura> aka_007: thats strange, never happened a thing like that
16:10:48 <ashishk_> harshadura: any knowledge where are mds package located in openmrs folder ??
16:11:29 <aka_007> harshadura, happening in my case... when I have my console open and I am trying to create the patient ... when I put in the data in the first form (name, birthdate, and gender) and press enter then it redirects me to a blank page..
16:11:48 <aka_007> harshadura, when I have the console off it shows me the second actual form related to address and all details...
16:12:23 *** akashagarwal has joined #openmrs
16:12:28 *** cioan1 has joined #openmrs
16:13:11 *** cioan has quit IRC
16:13:57 <harshadura> aka_007: hmm i see, it seems to be a problem related to your O/S - not a bug of openmrs apparently
16:14:20 <aka_007> harshadura, okay... got it..
16:14:40 *** djazayeri1 is now known as djazayeri
16:14:40 *** ChanServ sets mode: +o djazayeri
16:15:39 *** robbyoconnor has joined #openmrs
16:15:44 *** robbyoconnor has joined #openmrs
16:15:44 *** ChanServ sets mode: +v robbyoconnor
16:15:44 *** robbyoconnor has quit IRC
16:18:25 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1741 has FAILED (1 tests failed) : Manual build by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1741>
16:21:01 <aka_007> harshadura, I am still getting that error "select a preferred identifier" . I am unable to understand what does it mean..??
16:21:13 <aka_007> harshadura, The patient has a default identifier i.e. 11111
16:21:46 <harshadura> aka_007: can u see the radio button in the right side of the identifier?
16:22:46 <aka_007> harshadura, I am in this page.. http://localhost:8080/openmrs/admin/patients/patient.form?patientId=6 and the only radio button in this is of gender... I guess I am in wrong page... can you please specify the page you are using...??
16:25:34 <aka_007> harshadura, you there..??
16:26:53 <harshadura> aka_007: what you have on the Patient Identifiers field ?
16:27:52 <harshadura> aka_007: can u share me a screenshot of that window
16:28:11 <aka_007> harshadura, preferred, Identifier, Identifier Type(dropdown containing null field, Old Identification number, OpenMRS identification number), Location(Dropdown of unknown location and a null value), created by, deleted(checkbox), Reason for deletion)
16:28:12 <OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-88 has FAILED (1 tests failed) : Manual build by Mark Goodrich <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-88>
16:28:15 <aka_007> harshadura, yaa one minute
16:29:49 *** ashishk_ has quit IRC
16:30:27 <aka_007> harshadura, http://www.flickr.com/photos/117291223@N02/12615831374/
16:30:30 <OpenMRSBot> <http://ln-s.net/B0cR> (at www.flickr.com)
16:30:55 *** fathi has joined #openmrs
16:32:10 *** cioan has joined #openmrs
16:33:02 *** cioan1 has quit IRC
16:40:31 <harshadura> aka_007: can u add a Identification type and retry ?
16:43:35 <aka_007> harshadura, same error.. I am clicking the save patient button ...
16:44:54 <aka_007> harshadura, in identifier type I have chosen "Old Identification Number"
16:45:33 *** fathi has quit IRC
16:48:22 <aka_007> harshadura, I have to go ... I will be back within an hour.
16:50:32 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1742 has FAILED (1 tests failed) : Dependant of DIS-DIS-153 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1742>
16:52:59 *** aka_007 has quit IRC
16:55:29 *** harshadura has quit IRC
17:29:49 *** shubh has quit IRC
17:39:45 *** wluyima has quit IRC
17:50:51 <jkeiper_> hey folks, i know we've covered this before ... any examples of loading an external dependent module into a context sensitive module unit test? e.g. I want to have the other module's service be able to save something, and it can't because the hibernate modules aren't loaded into the context ...
17:51:48 <jkeiper_> s/modules/models
17:57:50 <jkeiper_> djazayeri, rafa, mseaton ^^
18:02:00 <djazayeri> jkeiper_: you have a test-hibernate.cfg.xml file?
18:02:55 <jkeiper_> djazayeri: i have a test-hibernate.cfg.xml file in module A and in module B ... but i want to test a service in B in a test method in A
18:03:20 *** shubh has joined #openmrs
18:03:36 <shubh> harsz89: i am visiting this page http://demo.openmrs.org/openmrs/admin/encounters/encounter.form to add an encounter but the Visit drop down menu is not showing any option
18:03:55 <jkeiper_> djazayeri: like having an implementation-specific reports module test running a report via the reporting module service
18:04:36 <jkeiper_> djazayeri: in my case, it's the amrs reports module trying to run a drughistory service call, and it can't save a domain object because hibernate does not know about the entity
18:04:52 <djazayeri> jkeiper_: see this
18:04:53 <djazayeri> https://github.com/PIH/openmrs-module-mirebalaisreports/blob/master/api/src/test/resources/test-hibernate.cfg.xml
18:05:39 <djazayeri> jkeiper_: i.e. you just mention the names of the hbm.xml files from the other module in the test-hibernate.cfg.xml of the module the test is in.
18:05:53 <jkeiper_> djazayeri: aha! thanks ... i'll do that
18:06:30 <jkeiper_> djazayeri: oO ... IDEA even autocompleted it for me ;-)
18:07:37 <jkeiper_> djazayeri: yay, that worked thanks!
18:07:42 <djazayeri> jkeiper_: np
18:12:23 <harsz89> shubh, okey can't you create a encounter without it?
18:15:06 <shubh> harsz89: i can but whats the use of it then?
18:15:39 <harsz89> shubh, you needs to understand the visits and encounters
18:15:57 <harsz89> shubh, have a look at here http://www.slideshare.net/djazayeri/visits-in-openmrs-19
18:15:58 <OpenMRSBot> <http://ln-s.net/AjLL> (at www.slideshare.net)
18:16:04 *** arambh has joined #openmrs
18:16:28 <shubh> harsz89: ok thanks i'll have a look
18:16:33 <harsz89> shubh, :)
18:18:08 <arambh> shubh: Encounters should work even without no visits.
18:19:06 *** breeze has joined #openmrs
18:48:19 *** aka_007 has joined #openmrs
18:50:43 <arambh> aka_007: I am getting a sql error. Can u help me?
18:50:50 *** arambh has quit IRC
18:53:45 *** psbrandt has quit IRC
18:56:04 *** shubh has quit IRC
18:57:00 *** psbrandt has joined #openmrs
18:57:00 *** ChanServ sets mode: +v psbrandt
19:04:51 *** k-joseph has joined #openmrs
19:05:48 *** wluyima has joined #openmrs
19:11:08 *** aka_007 has quit IRC
19:15:01 *** aka_007 has joined #openmrs
19:15:20 <aka_007> harsz89, hie
19:15:30 <harsz89> aka_007, hi
19:15:58 <aka_007> harsz89, I am in this page... http://localhost:8080/openmrs/admin/patients/patient.form?patientId=6 .. when I try to void a patient I get this message "Please fix all errors and try again.
19:15:58 <aka_007> Select a preferred identifier"
19:16:55 <harsz89> aka_007, mhhhh
19:17:20 <aka_007> harsz89, this is the link of the screenshot.. http://www.flickr.com/photos/117291223@N02/12615831374/
19:17:21 <OpenMRSBot> <http://ln-s.net/B0cR> (at www.flickr.com)
19:17:28 <harsz89> harsz89, did you select a identifier?
19:17:32 <aka_007> harsz89, please have a look.
19:18:10 <harsz89> aka_007, you didnt set a identifier type
19:18:44 <aka_007> harsz89, I also tried by setting the identfier type to "Old Identification Number" still same error..
19:19:05 <harsz89> aka_007, what you trying to do there
19:19:06 <harsz89> ?
19:19:22 <harsz89> aka_007, going to void a patient or create a patient?
19:19:27 <aka_007> harsz89, I am trying to void a person...
19:19:32 <aka_007> harsz89, for this ticket https://tickets.openmrs.org/browse/TRUNK-3967
19:19:48 <aka_007> harsz89, just for testing purpose... I am mostly done with the ticket...
19:24:04 *** aka_007 has quit IRC
19:24:11 <harsz89> aka_007, i tried this with demo server
19:24:24 *** aka_007 has joined #openmrs
19:24:33 <aka_007> harsz89, you there ... ??
19:24:34 <harsz89> aka_007, i tried with this demo server
19:24:43 <aka_007> harsz89, okay.. ??
19:24:48 <aka_007> harsz89, Did it work..??
19:24:48 <harsz89> aka_007, created a patient and voided him
19:24:53 <harsz89> aka_007, yep
19:25:06 <aka_007> harsz89, How did you void him... please give the link of the page...
19:25:30 <harsz89> aka_007, , http://demo.openmrs.org/openmrs/admin/patients/patient.form?patientId=9349
19:25:44 <aka_007> harsz89, just trying it.. 2 minutes..
19:25:48 <harsz89> aka_007, you can see bottom of the profile the void button
19:25:59 <harsz89> aka_007, you can void it from there
19:26:19 <harsz89> aka_007, just now i unvoided it
19:26:34 <harsz89> aka_007, if you need you can void it again
19:26:34 <harsz89> :)
19:26:40 <aka_007> harsz89, okay yaa got it... thanx.. :)
19:27:43 <aka_007> harsz89, Are there any specific dates of code-review, am just getting excited... about this.. https://tickets.openmrs.org/browse/TRUNK-377
19:28:35 *** dkayiwa has joined #openmrs
19:30:06 <harsz89> aka_007, needs to check with dkayiwa :D
19:30:20 <aka_007> harsz89, :D okay...
19:30:48 <aka_007> harsz89, I pulled the latest version of openmrs-core from git... but instead of void patient I see delete patient in my local server
19:31:05 <aka_007> harsz89, and when I use that the data gets completely deleted from database....
19:31:19 <harsz89> aka_007, so you will needs to have both the options
19:31:32 *** dkayiwa has quit IRC
19:31:33 <harsz89> you may void it or delete it completely
19:31:54 <harsz89> aka_007, when you void a patient
19:32:05 <harsz89> aka_007, the patient wont get erased from the database
19:32:18 <aka_007> I don't see a void option.... I just have a save patient option... and I have void checkboxes for patients... when I use that it shows an error message as I described
19:32:37 <aka_007> harsz89, yaa I know that... it stays in the database with the voided attribute being flagged...
19:33:37 <harsz89> aka_007, oopz didnt check with the latest version
19:34:23 <aka_007> harsz89, ohh okay... because in the version that you showed the ticket seemed to have been fixed....
19:36:34 <harsz89> aka_007, itz created in 1.9.3
19:36:44 <harsz89> but i check with demo server itz 1.9.7
19:36:58 <harsz89> harsz89, may tht one fixed
19:37:07 <aka_007> harsz89, sorry didn't get you... this ticket is already fixed.. ??
19:37:08 <harsz89> aka_007, not sure needs to check with latest
19:37:20 <harsz89> aka_007, i dont know actullay
19:37:33 <harsz89> aka_007, but demo server did you got that error?
19:38:03 <harsz89> aka_007, demo server has 1,9,7
19:38:13 <aka_007> harsz89, yaa... as I told you the error was "Select a preferred identifie"
19:38:29 *** k-joseph has quit IRC
19:38:43 <aka_007> harsz89, the lower part of the browser which describes the version of openmrs in my localhost shows... Version: 1.11.0 SNAPSHOT Build b25df4
19:39:02 <harsz89> aka_007, yeap you have the latest
19:39:08 <aka_007> harsz89, I encountered this error while voiding the person...
19:39:15 <harsz89> aka_007, i mean demo server is in 1.9.7
19:39:21 <aka_007> harsz89, it's not there in latest... I checked....
19:39:45 <aka_007> harsz89, please check and tell me how to void a person... Have been stuck on this for today... :(
19:40:03 <harsz89> aka_007, seems like
19:40:16 <harsz89> aka_007, 1,9,7 has that feature
19:40:24 <harsz89> aka_007, and again latest one doesnt
19:40:33 <harsz89> i checked with my latest one
19:40:39 <aka_007> harsz89, ohh okay...
19:40:45 <harsz89> aka_007, didnt see a option to void a patient
19:41:11 <aka_007> harsz89, how can I get other versions of openmrs... so that I can compare the code with them.... and integrate them
19:41:47 <harsz89> aka_007, you can switch branches
19:42:00 <harsz89> first of all you first fetch all branches
19:42:14 <aka_007> harsz89, then.. ?
19:42:15 <harsz89> first do bit google and fetch all branchs
19:42:22 <aka_007> harsz89, okay... on it...
19:42:36 <harsz89> then you will see all branches when you execute
19:42:44 <harsz89> git branch -a
19:42:52 <harsz89> then swtich branches :)
19:42:56 <harsz89> and see
19:43:16 <harsz89> you first post a comment on that ticket
19:43:21 <harsz89> with latest version
19:43:24 <harsz89> screenshot
19:43:33 <harsz89> before going to continue it
19:43:44 <harsz89> you have a delete option with reason
19:49:23 <aka_007> harsz89, okay... also sometimes while creating patient.. when I enter the first 3 attributes of the patient(Name, birthdate, gender) it navigates to an empty page...
19:49:44 <aka_007> harsz89, screenshot of this... http://www.flickr.com/photos/117291223@N02/12618954153/
19:49:48 <OpenMRSBot> <http://ln-s.net/B0oP> (at www.flickr.com)
19:49:51 <harsz89> aka_007, same happen to me
19:50:11 <harsz89> harsz89, needs to update the core again and see
19:50:13 <harsz89> :)
19:50:29 <aka_007> harsz89, Shall I report it in bug... it's a major bug... I have to literally restart the server 2-3 times so that it gets normal again...
19:51:36 <harsz89> mhhh take a up and see again :)
19:51:57 <harsz89> because the behaviour is intermittent
19:52:09 <aka_007> harsz89, yaa doing it...
19:52:19 <aka_007> harsz89, I am running "mvn clean install" again
19:59:36 <aka_007> harsz89, for the previous name which I created in the database... it shows the same wierd behaviour.. while creating patient... but when I am creating a new patient with different name.. it behaves perfectly fine...
20:04:07 *** cioan1 has joined #openmrs
20:04:08 *** cioan has quit IRC
20:20:49 *** GitHub41 has joined #openmrs
20:20:49 <GitHub41> [openmrs-core] wluyima pushed 1 new commit to 1.10.x: http://git.io/ep3wqw
20:20:49 <GitHub41> openmrs-core/1.10.x 0a0de43 wyclif: Added OrderFrequency.getOrderFrequencies(String searchPhrase, boolean includeRetired) - TRUNK-4214...
20:20:49 *** GitHub41 has left #openmrs
20:31:22 <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-ONEPOINTTENX-122 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-122>
20:43:58 *** breeze has quit IRC
20:46:32 *** akashagarwal has quit IRC
20:47:02 *** aka_007 has quit IRC
21:03:10 *** dkayiwa has joined #openmrs
21:13:30 *** cioan has joined #openmrs
21:13:30 *** cioan1 has quit IRC
21:20:01 *** raonyguimaraes has joined #openmrs
21:43:33 *** psbrandt has quit IRC
21:50:01 *** wluyima has quit IRC
21:51:07 *** psbrandt has joined #openmrs
21:51:08 *** ChanServ sets mode: +v psbrandt
21:51:56 *** cioan1 has joined #openmrs
21:51:57 *** cioan has quit IRC
21:56:57 *** psbrandt has quit IRC
22:03:40 *** wluyima has joined #openmrs
22:15:39 <wluyima> hi djazayeri
22:15:49 <djazayeri> wluyima: hi
22:16:07 *** cioan1 has quit IRC
22:17:21 <wluyima> djazayeri: i know we have run into this and i don't understand what the solution was, so jackson complains when you have getters for boolean properties isXXand and getXX e.g isSet for concept, i assumed that was fixed but the current build of rest module fails with the same complaint
22:17:59 <djazayeri> wluyima: the problem happens if some resource is returning a naked OpenMRS object, instead of converting it to a representation
22:18:51 <djazayeri> wluyima: perhaps the problem is that we haven't carried forwards all the resources to 1.10.*?
22:22:41 <wluyima> djazayeri: that is what i assumed and i tried to add 1.10.* to ConceptResource1_10 but i noticed the test fails if i don't also add it to ConceptResource1_8, so am wondering why i have to add it to 1_8 resource too
22:23:37 <wluyima> djazayeri: seems to me like all 1_8 resources need to support 1.9.* and 1.10.*
22:25:02 <djazayeri> wluyima: we should add a ConceptResource1_10 which is patterned after this one: https://github.com/openmrs/openmrs-module-webservices.rest/blob/master/omod-1.9/src/main/java/org/openmrs/module/webservices/rest/web/v1_0/resource/openmrs1_9/ConceptResource1_9.java
22:26:52 <djazayeri> wluyima: gotta run for a bit
22:27:32 <wluyima> djazayeri: am a little confused, i just added 1.10.x to UserResource and it worked and for concept i have ConceptResource1_10?
22:27:42 <wluyima> djazayeri: to be able to support 1_10
22:28:29 <djazayeri> wluyima: the pattern we're following is to create a new resource class for each OpenMRS version, not to just change the existing class by adding a supported version to its annotation
22:29:18 <djazayeri> wluyima: actually, maybe that's not right
22:29:49 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1743 has FAILED (1 tests failed) : Dependant of RDD-RDD-393 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1743>
22:30:00 <djazayeri> wluyima: I guess that any resource that _changes_ or has any of its properties change, needs to be carried forward with a new version
22:30:19 <djazayeri> wluyima: concept mapping changed in 1.9, right?
22:30:50 <djazayeri> wluyima: and that's why ConceptResource is carried forward that way
22:31:55 <djazayeri> wluyima: whereas Obs did not change in 1.9, and its properties do not include any resources that changed, so that just has the new supported version added to the 1_8 resource
22:32:29 <djazayeri> wluyima: so, since Concept does not change in 1.10 (right?) you're correct that we should just add another supportedVersion to ConceptResource1_9
22:36:44 <wluyima> djazayeri: that's exactly what i was saying, i feel like there is a bug in the logic because also when i add 1.10.* to the ConceptResource1_8 resource it works
22:37:06 <djazayeri> wluyima: don't add it to ConceptResource1_8, but to ConceptResource1_9
22:37:29 <djazayeri> wluyima: you have to carry forwards the *most recent* version of all resources that don't change
22:37:49 <djazayeri> wluyima: (and we'll need new 1_10 resources for things like Encounter and Obs that have a property containing Orders)
22:39:51 <OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-89 has FAILED (1 tests failed) : Updated by Darius Jazayeri <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-89>
22:40:11 <wluyima> djazayeri: actually things are working fine without adding those new resources
22:41:23 <djazayeri> wluyima: they _appear_ to work fine, but the meaning is wrong. The point is that the Encounter resource has now _changed_ since 1.9, since it includes something completely different in its orders property. Therefore it needs a new version.
23:15:03 *** akashagarwal has joined #openmrs
23:30:31 <wluyima> djazayeri: ok
23:31:08 <wluyima> djazayeri: allow me to go off topic a little, do you know of any implementation that is partnering with a European organisation
23:32:00 <djazayeri> wluyima: not that I know of
23:41:59 *** dkayiwa has quit IRC
23:43:00 <wluyima> djazayeri: ok, would you say PIH is an American organization based in Rwanda to partnering with locals to run an OpenMRS implementation?
23:47:34 <djazayeri> wluyima: PIH is a Boston-based organization that partners with sister organizations in the countries we work in. Our sister organization in Rwanda is Inshuti Mu Buzima.
23:48:06 <djazayeri> wluyima: so, we're an American organization that partners with a local organization that runs an OpenMRS implementation