IRC Chat : 2014-01-31 - OpenMRS

00:42:58 *** JoelW has quit IRC
00:45:05 *** dkithmal has quit IRC
01:19:28 *** dzuk has joined #openmrs
01:19:56 *** dzuk has quit IRC
01:57:12 *** rday has joined #openmrs
02:02:04 <OpenMRSBot> Recent updates in the world of openmrsci: SON-OPENMRSCOREMASTER-132 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-132>
02:19:20 *** rday has quit IRC
03:02:37 *** rday has joined #openmrs
03:07:12 *** upul has joined #openmrs
03:24:53 *** rday has quit IRC
03:36:58 *** harsz89 has joined #openmrs
03:36:58 *** ChanServ sets mode: +v harsz89
03:43:35 *** GitHub168 has joined #openmrs
03:43:36 <GitHub168> [openmrs-core] wluyima pushed 1 new commit to 1.10.x: http://git.io/NQybLQ
03:43:36 <GitHub168> openmrs-core/1.10.x 02ad3cb wyclif: Choose a drug formulation to order - TRUNK-4151...
03:43:36 *** GitHub168 has left #openmrs
04:18:59 *** harshadura has joined #openmrs
04:18:59 *** ChanServ sets mode: +v harshadura
04:45:23 *** GitHub163 has joined #openmrs
04:45:24 <GitHub163> [openmrs-core] wluyima pushed 1 new commit to 1.10.x: http://git.io/ktNJ0w
04:45:24 <GitHub163> openmrs-core/1.10.x aa0698a wyclif: Added @since annotation to OrderService.getActiveOrders
04:45:24 *** GitHub163 has left #openmrs
04:49:38 *** rday has joined #openmrs
04:54:46 <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-ONEPOINTTENX-90 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-90>
05:01:19 *** rday has quit IRC
05:01:47 *** rday has joined #openmrs
05:08:29 *** rday has quit IRC
05:08:55 *** rday has joined #openmrs
06:25:24 *** rowanseymour has joined #openmrs
06:39:41 *** upul has left #openmrs
06:41:26 *** harsz89 has quit IRC
06:55:08 *** khayam has joined #openmrs
07:03:52 *** rowanseymour has quit IRC
07:10:14 *** robbyoconnor has joined #openmrs
07:10:14 *** ChanServ sets mode: +v robbyoconnor
07:12:23 *** rday has quit IRC
07:12:59 *** harshadura has quit IRC
07:25:48 *** rowanseymour has joined #openmrs
07:45:32 *** dkayiwa has joined #openmrs
07:55:38 *** khayam has quit IRC
09:15:52 *** khayam has joined #openmrs
09:26:28 *** khayam has quit IRC
10:33:50 *** GitHub0 has joined #openmrs
10:33:51 <GitHub0> [openmrs-core] dkayiwa closed pull request #598: Trunk-3569 : Displaying formatDescription when identifier fails regex validation (master...TRUNK-3569) http://git.io/1Usptg
10:33:51 *** GitHub0 has left #openmrs
10:33:51 *** GitHub133 has joined #openmrs
10:33:51 <GitHub133> [openmrs-core] dkayiwa pushed 5 new commits to master: http://git.io/1ZNIMg
10:33:51 <GitHub133> openmrs-core/master ebe7507 madawa-rc: TRUNK-3569: Fixing the error format
10:33:51 <GitHub133> openmrs-core/master fe51727 madawa-rc: TRUNK-3569: Changed the PatientIdentifier.error.invalidFormat message in message.properties file
10:33:51 <GitHub133> openmrs-core/master 5c280d0 madawa-rc: TRUNK-3569: Modified test class
10:33:51 *** GitHub133 has left #openmrs
10:34:20 *** rowanseymour has quit IRC
10:42:08 <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-MASTER-299 has FAILED (1 tests failed) : Updated by dkayiwa , madawa-rc <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-299>
10:44:45 *** travis-ci has joined #openmrs
10:44:45 <travis-ci> [travis-ci] [openmrs/openmrs-core] [2c70794] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/17967857
10:44:45 *** travis-ci has left #openmrs
11:30:37 *** GitHub199 has joined #openmrs
11:30:37 <GitHub199> [openmrs-core] dkayiwa pushed 1 new commit to master: http://git.io/ws2h-A
11:30:37 <GitHub199> openmrs-core/master e62012d dkayiwa: Doing some formatting
11:30:37 *** GitHub199 has left #openmrs
11:34:02 *** dkayiwa has quit IRC
11:42:05 *** travis-ci has joined #openmrs
11:42:05 <travis-ci> [travis-ci] [openmrs/openmrs-core] [e62012d] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/17970679
11:42:05 *** travis-ci has left #openmrs
12:03:10 *** rowanseymour has joined #openmrs
12:06:52 *** dkayiwa has joined #openmrs
12:08:28 <OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-77 has FAILED (1 tests failed) : Updated by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-77>
12:10:48 *** rowanseymour has quit IRC
12:21:31 *** harsz89 has joined #openmrs
12:21:32 *** ChanServ sets mode: +v harsz89
12:23:22 *** rowanseymour has joined #openmrs
12:23:51 *** cioan has joined #openmrs
12:28:52 *** khayam has joined #openmrs
12:30:51 <khayam> dkayiwa: would you please help in unit test for https://tickets.openmrs.org/browse/TRUNK-3876
12:31:17 <dkayiwa> khayam: do you mean teaching you how they write unit tests? :)
12:32:15 *** rowanseymour has quit IRC
12:32:19 *** dkithmal has joined #openmrs
12:33:54 <khayam> dkayiwa: no i am searching for wiki page for unit test
12:35:50 *** rowanseymour has joined #openmrs
12:35:53 <OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-78 has FAILED (1 tests failed) : Manual build by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-78>
12:44:29 *** khayam has quit IRC
12:53:09 *** GitHub4 has joined #openmrs
12:53:10 <GitHub4> [openmrs-core] saikrishna17 opened pull request #599: New trunk 2280 (master...newTrunk-2280) http://git.io/ejDLYw
12:53:10 *** GitHub4 has left #openmrs
12:59:42 *** GitHub128 has joined #openmrs
12:59:42 <GitHub128> [openmrs-core] dkayiwa pushed 1 new commit to master: http://git.io/SXhESg
12:59:42 <GitHub128> openmrs-core/master 8451a17 dkayiwa: Create generic DAO interfaces and abstract classes - TRUNK-3782...
12:59:42 *** GitHub128 has left #openmrs
13:01:41 *** GitHub133 has joined #openmrs
13:01:41 <GitHub133> [openmrs-core] dkayiwa closed pull request #125: TRUNK-3782:Create generic DAO interfaces and abstract classes (master...TRUNK-3782) http://git.io/kEt2JA
13:01:41 *** GitHub133 has left #openmrs
13:26:13 *** dkayiwa has quit IRC
13:28:42 *** dkithmal has quit IRC
13:29:06 *** dkithmal has joined #openmrs
13:31:58 *** rowanseymour has quit IRC
13:32:20 *** rowanseymour has joined #openmrs
13:53:20 *** robbyoconnor has quit IRC
13:54:40 *** robbyoconnor has joined #openmrs
13:54:41 *** ChanServ sets mode: +v robbyoconnor
13:58:54 *** rowanseymour has quit IRC
14:00:15 *** GitHub72 has joined #openmrs
14:00:15 <GitHub72> [openmrs-core] madawa-rc opened pull request #600: TRUNK-3569: Unit tests added (master...TRUNK-3569) http://git.io/HafaUQ
14:00:15 *** GitHub72 has left #openmrs
14:03:02 *** rowanseymour has joined #openmrs
14:03:31 *** rowanseymour has joined #openmrs
14:06:22 *** harsz89 has quit IRC
14:06:45 *** VaibhavAgarwal has joined #openmrs
14:10:29 *** rowanseymour has quit IRC
14:11:48 *** rowanseymour has joined #openmrs
14:16:29 *** rowanseymour has quit IRC
14:16:34 *** rowansey_ has joined #openmrs
14:19:32 *** dkayiwa has joined #openmrs
14:21:15 *** rowansey_ has quit IRC
14:27:24 *** rowanseymour has joined #openmrs
14:28:16 *** GitHub191 has joined #openmrs
14:28:17 <GitHub191> [openmrs-core] wluyima pushed 1 new commit to 1.10.x: http://git.io/rYsLsw
14:28:17 <GitHub191> openmrs-core/1.10.x 3a20ea2 wyclif: Follow up to address review comments - TRUNK-4151
14:28:17 *** GitHub191 has left #openmrs
14:34:27 *** rowanseymour has quit IRC
14:36:18 *** rowanseymour has joined #openmrs
14:45:13 *** rowanseymour has quit IRC
14:51:35 *** dkithmal has quit IRC
14:52:18 *** dkithmal has joined #openmrs
14:55:12 *** rowanseymour has joined #openmrs
14:55:54 *** GitHub140 has joined #openmrs
14:55:54 <GitHub140> [openmrs-core] dkayiwa closed pull request #599: New trunk 2280 (master...newTrunk-2280) http://git.io/ejDLYw
14:55:54 *** GitHub140 has left #openmrs
14:57:21 *** GitHub165 has joined #openmrs
14:57:22 <GitHub165> [openmrs-core] dkayiwa closed pull request #600: TRUNK-3569: Unit tests added (master...TRUNK-3569) http://git.io/HafaUQ
14:57:22 *** GitHub165 has left #openmrs
14:58:55 *** GitHub0 has joined #openmrs
14:58:55 <GitHub0> [openmrs-core] dkayiwa closed pull request #596: Trunk-3972 clean pull request (master...Trunk-3972) http://git.io/KRnZnA
14:58:55 *** GitHub0 has left #openmrs
14:59:06 *** dkithmal has quit IRC
15:00:14 *** GitHub32 has joined #openmrs
15:00:15 <GitHub32> [openmrs-core] dkayiwa closed pull request #588: TRUNK-2448: Add ability to view uuids to most objects (master...TRUNK-2448-New) http://git.io/Y20KIg
15:00:15 *** GitHub32 has left #openmrs
15:01:21 *** GitHub158 has joined #openmrs
15:01:21 <GitHub158> [openmrs-core] dkayiwa closed pull request #584: TRUNK-3840: display retired concepts with strikethrough (master...TRUNK-3840) http://git.io/frbPUg
15:01:21 *** GitHub158 has left #openmrs
15:01:26 *** wluyima has joined #openmrs
15:04:36 *** wluyima has quit IRC
15:04:50 *** GitHub91 has joined #openmrs
15:04:51 <GitHub91> [openmrs-core] dkayiwa closed pull request #521: Trunk 2779 (master...TRUNK-2779) http://git.io/1-4g2A
15:04:51 *** GitHub91 has left #openmrs
15:08:31 *** GitHub14 has joined #openmrs
15:08:32 <GitHub14> [openmrs-core] dkayiwa closed pull request #556: Trunk-2280 added an alert box (master...Trunk-2280) http://git.io/t3mArw
15:08:32 *** GitHub14 has left #openmrs
15:10:22 *** GitHub17 has joined #openmrs
15:10:23 <GitHub17> [openmrs-core] dkayiwa closed pull request #450: TRUNK-4116 (master...master) http://git.io/px-mAg
15:10:23 *** GitHub17 has left #openmrs
15:11:44 *** wluyima has joined #openmrs
15:15:38 *** GitHub190 has joined #openmrs
15:15:39 <GitHub190> [openmrs-core] dkayiwa reopened pull request #588: TRUNK-2448: Add ability to view uuids to most objects (master...TRUNK-2448-New) http://git.io/Y20KIg
15:15:39 *** GitHub190 has left #openmrs
15:16:02 *** robbyoconnor has quit IRC
15:18:47 *** rowanseymour has quit IRC
15:19:39 *** GitHub19 has joined #openmrs
15:19:39 <GitHub19> [openmrs-core] wluyima pushed 1 new commit to 1.10.x: http://git.io/tft_hA
15:19:39 <GitHub19> openmrs-core/1.10.x 39c783d wyclif: Follow up to reject null searchPhrase when searching for drugs - TRUNK-4151
15:19:39 *** GitHub19 has left #openmrs
15:28:47 *** GitHub20 has joined #openmrs
15:28:47 <GitHub20> [openmrs-core] dkayiwa closed pull request #588: TRUNK-2448: Add ability to view uuids to most objects (master...TRUNK-2448-New) http://git.io/Y20KIg
15:28:47 *** GitHub20 has left #openmrs
15:28:47 *** GitHub96 has joined #openmrs
15:28:47 <GitHub96> [openmrs-core] dkayiwa pushed 6 new commits to master: http://git.io/sDG5Vw
15:28:47 <GitHub96> openmrs-core/master fa49537 Sara Fatima: TRUNK-2448: Add ability to view uuids to most objects
15:28:47 <GitHub96> openmrs-core/master d5ea805 Sara Fatima: TRUNK-2448 Change in roleForm.jsp
15:28:47 <GitHub96> openmrs-core/master d1e3c64 Sara Fatima: TRUNK-2448 Moving uuid to last row
15:28:47 *** GitHub96 has left #openmrs
15:30:39 *** dkayiwa has left #openmrs
15:40:48 *** travis-ci has joined #openmrs
15:40:49 <travis-ci> [travis-ci] [openmrs/openmrs-core] [ef61a0c] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/17982593
15:40:49 *** travis-ci has left #openmrs
16:24:26 *** Akshika47 has joined #openmrs
16:27:04 *** dkithmal has joined #openmrs
16:35:14 *** suranga was kicked by downey (suranga)
16:43:03 *** GitHub165 has joined #openmrs
16:43:04 <GitHub165> [openmrs-core] wluyima pushed 3 new commits to 1.10.x: http://git.io/4LDwlA
16:43:04 <GitHub165> openmrs-core/1.10.x 0d8d387 wyclif: Set Order.class as the default type when fetching active orders - TRUNK-4191
16:43:04 <GitHub165> openmrs-core/1.10.x f6a7565 wyclif: Updated OrderService.getOrderHistoryByConcept to require concept and added units tests - TRUNK-4147
16:43:04 <GitHub165> openmrs-core/1.10.x 05b88a9 wyclif: Added a check to reject future discontinue future discontinuation dates - TRUNK-4133
16:43:04 *** GitHub165 has left #openmrs
17:51:05 *** GitHub22 has joined #openmrs
17:51:05 <GitHub22> [openmrs-core] lishar opened pull request #601: TRUNK-3840: display retired concepts with strikethrough at end of list (master...TRUNK-3840) http://git.io/oWzs1w
17:51:05 *** GitHub22 has left #openmrs
18:12:24 *** harsz89 has joined #openmrs
18:12:24 *** ChanServ sets mode: +v harsz89
18:18:04 *** robbyoconnor has joined #openmrs
18:18:04 *** ChanServ sets mode: +v robbyoconnor
18:29:38 <wluyima> hi djazayeri
18:30:40 <djazayeri> hi wluyima
18:30:54 <djazayeri> rafa: hey, did you get a chance to act on my email from last night?
18:32:09 <wluyima> djazayeri: so some of the stories already a have a test in the XXServiceTest class, i would suggest we don't have to write another end to end test to test doing the same exact thing, e.g discontinuing an order
18:33:33 *** dkithmal has quit IRC
18:33:53 <djazayeri> wluyima: the end to end tests are fundamentally different from the unit tests, and we _do_ want to have duplication
18:33:57 *** dkithmal has joined #openmrs
18:34:11 <djazayeri> wluyima: but the end-to-end tests should be covering an entire use case
18:34:26 <djazayeri> wluyima: e.g. it's not just "fetch order by id, then discontinue it"
18:34:53 <djazayeri> wluyima: but rather "get the patient's active orders, and discontinue the one for Ampicillin"
18:34:55 <Akshika47> I am just curious to know, if there is line above the method as @Transactional(Readonly=true). Am I restricted from refactoring that method?
18:35:25 <djazayeri> Akshika47: No. That line does not restrict you from refactoring the method.
18:35:54 <wluyima> djazayeri: hmm...
18:35:55 <djazayeri> wluyima: the end-to-end test should be quite similar to what we'd do with a scripted browser test
18:36:07 <djazayeri> wluyima: except it's easier to write and less brittle, since it's just using the UI
18:36:10 <Tajha> hey there's people here now, yay! Maybe one of you can help me. I'm new and having a rough time getting the SDK installed properly so I can start contributing. Can somebody tell me: when I type omrs-version how does bash know where to look for the version? (I use Ubuntu if that helps)
18:36:32 <djazayeri> wluyima: it's also supposed to illustrate the correct usage of the API, for documentation purposes
18:37:15 <wluyima> djazayeri: ok, but what if we already have a unit test that already does that exact thing, i.e gets active orders and discontinues one of them?
18:37:45 <djazayeri> wluyima: then it's not a good unit test. :-)
18:37:52 <Akshika47> @djazayeri : it seems like Intellij Idea does something like that. I am able to re factor methods which does not have that line. but this. I am unable to do it? is it something to do with the IDE?
18:38:11 <djazayeri> wluyima: a unit test should test exactly one thing...
18:38:17 <wluyima> djazayeri: djazayeri i get that
18:38:36 <wluyima> djazayeri: i was just curious that if it already exists
18:38:57 <djazayeri> wluyima: trust me on this, that it will be helpful to have a set of tests that specifically test the _whole API_ and do so in a way that we can point people to for teaching purposes.
18:39:12 <wluyima> djazayeri: ok..
18:39:14 <djazayeri> wluyima: maybe in the end it won't be so useful and it will be duplicative of unit tests + scripted browser tests of the UI
18:39:20 <djazayeri> wluyima: but for now, let's give it a shot
18:39:27 <wluyima> djazayeri: ok
18:39:37 <djazayeri> Akshika47: does it give you any error message?
18:39:41 <djazayeri> Akshika47: sorry, I've gotta run
18:40:06 <wluyima> djazayeri: it makes sense when you say we want something to point debs to on how to use the API
18:40:22 <wluyima> djazayeri: debs -> devs
18:40:30 <Akshika47> hmmm, nope, just nothing comes up when highlight it and try to change the method signature
18:40:31 <Akshika47> :(
18:46:29 *** dkithmal has quit IRC
18:53:20 *** robbyoconnor has quit IRC
18:58:47 <Akshika47> wluyima
18:59:17 <Akshika47> did u read my question? if so please tell if you have any solutions
19:03:03 <wluyima> Akshika47: can you repost it?
19:03:45 <Akshika47> I am just curious to know, if there is line above the method as @Transactional(Readonly=true). Am I restricted from refactoring that method?,
19:03:55 <Akshika47> then djazayeri
19:04:00 <Akshika47> it is not so
19:04:15 <Akshika47> then i asked
19:04:17 <Akshika47> it seems like Intellij Idea does something like that. I am able to re factor methods which does not have that line. but this. I am unable to do it? is it something to do with the IDE?
19:04:31 <Akshika47> wluyima:
19:07:31 <wluyima> Akshika47: i don't know why that is happening
19:07:39 <Akshika47> hmmmm
19:08:15 <wluyima> Akshika47: though i doubt if that is correct because i have refactored those methods before in the past
19:09:46 <Akshika47> wluyima: yes. I also used to do so. but I am unable to do so. is there a way to refresh the IDE in a manner. this will be okay
19:09:47 <Akshika47> ?
19:10:49 <wluyima> Akshika47: dont know
19:11:19 <Akshika47> okay, I will do something thanks ;)
19:19:15 <wluyima> hi djazayeri
19:20:22 <wluyima> djazayeri: what are supposed to name the discontinue fields because i find reasonCoded and reasonNonCoded quite flat, don't give a clue what they are
19:21:28 <wluyima> djazayeri: ?
19:22:30 <wluyima> 'djazayeri i personally prefer the discontinueReasonCoded and discontinueReasonNonCoded
19:23:58 *** Akshika47 has quit IRC
19:36:11 <djazayeri> wluyima: they aren't just or discontinuing though
19:36:21 <djazayeri> wluyima: we could call them "orderReason"
19:36:42 <djazayeri> wluyima: but I would argue that Order.reason makes sense
19:36:49 <djazayeri> wluyima: it could be reasonPlaced
19:41:30 *** Rony has joined #openmrs
19:44:14 <OpenMRSBot> Recent updates in the world of openmrsci: REPREST-REPREST-113 has FAILED : Dependant of REP-REP-190 <https://ci-stg.openmrs.org/browse/REPREST-REPREST-113>
19:45:42 *** eflo has joined #openmrs
19:47:10 <eflo> I'm new to OpenMRS and while installing the dev environment I ran into this error: java.lang.String Error while trying to update to the latest database version. Any ideas?
19:48:17 <OpenMRSBot> Recent updates in the world of openmrsci: REFMETA-REFMETA-256 has FAILED : Dependant of EMRAPI-EMRAPI-423 <https://ci-stg.openmrs.org/browse/REFMETA-REFMETA-256>
19:56:25 *** eflo has quit IRC
19:58:17 <OpenMRSBot> Recent updates in the world of openmrsci: REPUI-REPUI-445 has FAILED : Dependant of APPUI-APPUI-317 <https://ci-stg.openmrs.org/browse/REPUI-REPUI-445>
19:59:27 <wluyima> djazayeri: ok
19:59:36 <wluyima> djazayeri: one more question
20:00:39 <wluyima> djazayeri: am trying tot edit clone for discontinuing, for drug orders we don't have to set the drug field
20:02:09 *** harsz89 has quit IRC
20:03:09 <wluyima> djazayeri: because in the APi when finding an active drug order to discontinue i want to stop say a a tylenol order instead any acetaminophen order simply because the underlying concept matches
20:04:03 <wluyima> djazayeri: so i was suggesting that a DC order for a drug order should have a drug set if the previous order is not set yet
20:06:07 <wluyima> djazayeri: i mean when am saving a new order and want to ensure there is no existing order for the same orderable
20:13:33 *** VaibhavAgarwal has quit IRC
20:17:17 *** dkithmal has joined #openmrs
20:23:48 *** Rony has quit IRC
20:52:08 *** wluyima has left #openmrs
21:06:15 *** wluyima has joined #openmrs
21:49:18 *** djazayeri has quit IRC
22:32:05 *** dkithmal has quit IRC
22:36:22 *** robbyoconnor has joined #openmrs
22:36:22 *** ChanServ sets mode: +v robbyoconnor
22:39:07 *** robbyoconnor has quit IRC
22:39:54 *** robbyoconnor has joined #openmrs
22:39:54 *** ChanServ sets mode: +v robbyoconnor
22:42:14 *** robbyoconnor has quit IRC
22:42:22 *** robbyoconnor has joined #openmrs
22:42:22 *** ChanServ sets mode: +v robbyoconnor
22:48:53 *** wluyima has quit IRC
22:59:09 *** VaibhavAgarwal has joined #openmrs
23:28:33 *** VaibhavAgarwal has quit IRC
23:30:00 *** wluyima has joined #openmrs
23:33:26 *** dkithmal has joined #openmrs