00:02:02
|
*** ningosi has quit IRC
|
00:05:55
|
*** ningosi has joined #openmrs
|
00:13:46
|
*** ningosi has quit IRC
|
00:17:06
|
*** ningosi has joined #openmrs
|
00:23:03
|
*** ningosi has quit IRC
|
00:25:13
|
<wluyima> cpower: ?
|
00:26:41
|
*** ningosi has joined #openmrs
|
00:32:55
|
*** ningosi has quit IRC
|
00:33:50
|
*** GitHub38 has joined #openmrs
|
00:33:51
|
<GitHub38> [openmrs-core] wluyima pushed 1 new commit to 1.10.x: http://git.io/FmMsXQ
|
00:33:51
|
<GitHub38> openmrs-core/1.10.x 4e98261 Vinay Venu: TRUNK-4133 - Implement discontinueOrder API in OrderService....
|
00:33:51
|
*** GitHub38 has left #openmrs
|
00:37:20
|
*** ningosi has joined #openmrs
|
00:37:38
|
*** GitHub83 has joined #openmrs
|
00:37:38
|
<GitHub83> [openmrs-core] wluyima closed pull request #526: Trunk 4133 (1.10.x...TRUNK-4133) http://git.io/QYjLKQ
|
00:37:38
|
*** GitHub83 has left #openmrs
|
00:42:55
|
*** ningosi has quit IRC
|
00:43:50
|
*** ningosi has joined #openmrs
|
00:49:09
|
*** ningosi has quit IRC
|
00:52:46
|
*** ningosi has joined #openmrs
|
00:58:13
|
*** ningosi has quit IRC
|
01:01:47
|
*** ningosi has joined #openmrs
|
01:04:50
|
*** wluyima has quit IRC
|
01:06:53
|
*** ningosi has quit IRC
|
01:10:33
|
*** ningosi has joined #openmrs
|
01:16:48
|
*** ningosi has quit IRC
|
01:20:42
|
*** ningosi has joined #openmrs
|
01:28:11
|
*** ningosi has quit IRC
|
01:31:25
|
*** ningosi has joined #openmrs
|
01:37:55
|
*** ningosi has quit IRC
|
01:40:17
|
*** ningosi has joined #openmrs
|
01:45:59
|
*** ningosi has quit IRC
|
01:50:22
|
*** ningosi has joined #openmrs
|
01:56:24
|
*** ningosi has quit IRC
|
01:56:56
|
*** ningosi has joined #openmrs
|
02:02:59
|
*** ningosi has quit IRC
|
02:05:08
|
<OpenMRSBot> Recent updates in the world of openmrsci: SON-OPENMRSCOREMASTER-129 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-129>
|
02:06:29
|
*** ningosi has joined #openmrs
|
02:13:26
|
*** ningosi has quit IRC
|
02:16:52
|
*** ningosi has joined #openmrs
|
02:20:38
|
*** uju has quit IRC
|
02:23:03
|
*** ningosi has quit IRC
|
02:26:49
|
*** ningosi has joined #openmrs
|
02:34:22
|
*** ningosi has quit IRC
|
02:38:11
|
*** ningosi has joined #openmrs
|
02:44:38
|
*** ningosi has quit IRC
|
02:47:55
|
*** ningosi has joined #openmrs
|
02:54:53
|
*** ningosi has quit IRC
|
02:57:40
|
*** robbyoconnor has joined #openmrs
|
02:57:40
|
*** ChanServ sets mode: +v robbyoconnor
|
02:57:51
|
*** ningosi has joined #openmrs
|
03:02:54
|
*** ningosi has quit IRC
|
03:04:07
|
*** ningosi has joined #openmrs
|
03:11:47
|
*** ningosi has quit IRC
|
03:17:02
|
*** ningosi has joined #openmrs
|
03:22:33
|
*** ningosi has quit IRC
|
03:26:26
|
*** ningosi has joined #openmrs
|
03:28:49
|
*** robbyoconnor has quit IRC
|
03:32:17
|
*** ningosi has quit IRC
|
03:44:44
|
*** ningosi has joined #openmrs
|
03:50:47
|
*** ningosi has quit IRC
|
03:54:25
|
*** ningosi has joined #openmrs
|
04:00:50
|
*** ningosi has quit IRC
|
04:01:26
|
*** rday has joined #openmrs
|
04:03:33
|
<OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1667 has FAILED (1 tests failed) : Dependant of RA-RA-400 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1667>
|
04:05:03
|
*** ningosi has joined #openmrs
|
04:10:59
|
*** ningosi has quit IRC
|
04:15:05
|
*** ningosi has joined #openmrs
|
04:19:53
|
*** ningosi has quit IRC
|
04:20:42
|
*** ningosi has joined #openmrs
|
04:27:14
|
*** ningosi has quit IRC
|
04:30:43
|
*** ningosi has joined #openmrs
|
04:35:35
|
*** rday has quit IRC
|
04:38:29
|
*** ningosi has quit IRC
|
04:42:04
|
*** ningosi has joined #openmrs
|
04:46:06
|
*** harsz89 has quit IRC
|
04:46:55
|
*** robbyoconnor has joined #openmrs
|
04:46:56
|
*** ChanServ sets mode: +v robbyoconnor
|
04:47:38
|
*** ningosi has quit IRC
|
04:53:33
|
*** ningosi has joined #openmrs
|
04:57:48
|
*** harsz89 has joined #openmrs
|
04:57:48
|
*** ChanServ sets mode: +v harsz89
|
04:59:29
|
*** ningosi has quit IRC
|
05:02:07
|
*** ningosi has joined #openmrs
|
05:05:46
|
*** upul_ has joined #openmrs
|
05:05:57
|
*** upul has quit IRC
|
05:07:29
|
*** ningosi has quit IRC
|
05:10:12
|
*** ningosi has joined #openmrs
|
05:18:23
|
*** ningosi has quit IRC
|
05:22:05
|
*** ningosi has joined #openmrs
|
05:27:51
|
*** ningosi has quit IRC
|
05:31:32
|
*** ningosi has joined #openmrs
|
05:32:37
|
*** rday has joined #openmrs
|
05:34:31
|
*** k-joseph has joined #openmrs
|
05:39:17
|
*** ningosi has quit IRC
|
05:43:03
|
*** ningosi has joined #openmrs
|
05:46:10
|
*** sandaru has joined #openmrs
|
05:47:55
|
*** ningosi has quit IRC
|
05:50:55
|
*** ningosi has joined #openmrs
|
05:57:55
|
*** ningosi has quit IRC
|
06:02:00
|
*** ningosi has joined #openmrs
|
06:07:25
|
*** ningosi has quit IRC
|
06:09:03
|
*** upul_ has quit IRC
|
06:10:47
|
*** ningosi has joined #openmrs
|
06:15:59
|
*** ningosi has quit IRC
|
06:20:17
|
*** ningosi has joined #openmrs
|
06:25:03
|
*** ningosi has quit IRC
|
06:28:43
|
*** ningosi has joined #openmrs
|
06:33:56
|
*** ningosi has quit IRC
|
06:46:11
|
*** ningosi has joined #openmrs
|
06:53:02
|
*** ningosi has quit IRC
|
06:55:58
|
*** ningosi has joined #openmrs
|
07:03:50
|
*** ningosi has quit IRC
|
07:04:30
|
*** wluyima has joined #openmrs
|
07:06:00
|
*** ningosi has joined #openmrs
|
07:06:18
|
*** rday has quit IRC
|
07:08:03
|
*** wluyima has quit IRC
|
07:11:15
|
*** Mkop has quit IRC
|
07:20:05
|
*** Mkop has joined #openmrs
|
07:23:06
|
*** ningosi has quit IRC
|
07:23:30
|
*** ningosi has joined #openmrs
|
07:24:41
|
*** Mkop has quit IRC
|
07:37:29
|
*** k-joseph has quit IRC
|
07:40:31
|
*** ningosi has quit IRC
|
07:42:40
|
*** ningosi has joined #openmrs
|
07:43:51
|
*** robbyoconnor has quit IRC
|
07:49:38
|
*** wluyima has joined #openmrs
|
08:00:58
|
*** dkayiwa has joined #openmrs
|
08:01:21
|
*** VaibhavAgarwal has joined #openmrs
|
08:02:02
|
*** ningosi has quit IRC
|
08:02:04
|
<OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-DEMO-112 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/REFAPP-DEMO-112>
|
08:05:35
|
<VaibhavAgarwal> hi,dkayiwa
|
08:05:49
|
<dkayiwa> VaibhavAgarwal: hi
|
08:06:07
|
<VaibhavAgarwal> can u give me brief description about TODO for ticket TRUNK-3382.
|
08:06:53
|
*** ningosi has joined #openmrs
|
08:09:10
|
*** robbyoconnor has joined #openmrs
|
08:09:10
|
*** ChanServ sets mode: +v robbyoconnor
|
08:10:57
|
*** ningosi has quit IRC
|
08:12:11
|
*** ningosi has joined #openmrs
|
08:17:30
|
*** ningosi has quit IRC
|
08:20:36
|
<dkayiwa> VaibhavAgarwal: hi
|
08:21:06
|
<VaibhavAgarwal> dkayiwa:hi
|
08:21:29
|
<dkayiwa> VaibhavAgarwal: you need to include my name everytime you type
|
08:21:41
|
<dkayiwa> !ticket TRUNK-3382
|
08:21:42
|
<OpenMRSBot> dkayiwa: [#TRUNK-3382] Modify provider.getName() method so that it only looks at provider.person.name - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3382
|
08:21:45
|
<VaibhavAgarwal> <dkayiwa>ok
|
08:21:56
|
*** ningosi has joined #openmrs
|
08:22:26
|
*** wluyima has quit IRC
|
08:22:45
|
<VaibhavAgarwal> dkayiwa:can u give me description about todo in that ticket
|
08:25:45
|
<dkayiwa> VaibhavAgarwal: ok
|
08:26:38
|
<dkayiwa> VaibhavAgarwal: have you read all the ticket comments?
|
08:27:37
|
*** ningosi has quit IRC
|
08:27:38
|
<VaibhavAgarwal> yes i did,should i remove setName() method?
|
08:28:10
|
<VaibhavAgarwal> dkayiwa:yes i did,should i remove setName() method?
|
08:29:04
|
<dkayiwa> VaibhavAgarwal: just do whats on ticket
|
08:29:38
|
<VaibhavAgarwal> dkayiwa:ok
|
08:30:55
|
<VaibhavAgarwal> <dkayiwa>thank you.
|
08:31:21
|
*** ningosi has joined #openmrs
|
08:35:13
|
*** VaibhavAgarwal has quit IRC
|
08:39:22
|
*** ningosi has quit IRC
|
08:40:57
|
*** ningosi has joined #openmrs
|
08:44:52
|
*** VaibhavAgarwal has joined #openmrs
|
08:48:29
|
*** ningosi has quit IRC
|
08:52:50
|
*** ningosi has joined #openmrs
|
08:57:57
|
*** ningosi has quit IRC
|
09:01:52
|
*** ningosi has joined #openmrs
|
09:07:59
|
*** ningosi has quit IRC
|
09:10:25
|
*** ningosi has joined #openmrs
|
09:17:05
|
*** ningosi has quit IRC
|
09:21:17
|
*** ningosi has joined #openmrs
|
09:24:23
|
*** VaibhavAgarwal has quit IRC
|
09:25:58
|
*** ningosi has quit IRC
|
09:28:20
|
*** Ch3ck_ has joined #openmrs
|
09:29:51
|
*** ningosi has joined #openmrs
|
09:36:59
|
*** ningosi has quit IRC
|
09:41:22
|
*** ningosi has joined #openmrs
|
09:53:48
|
*** rafa_ has joined #openmrs
|
09:54:07
|
<rafa> dkayiwa: hey
|
09:54:21
|
<dkayiwa> rafa: hi
|
09:54:33
|
<rafa> dkayiwa: did you have a chance to debug?
|
09:54:47
|
<dkayiwa> rafa: yes. not yet got a solution man. :)
|
09:54:58
|
<rafa> dkayiwa: any way I can help?
|
09:55:05
|
*** Ch3ck__ has joined #openmrs
|
09:55:24
|
<rafa> dkayiwa: do you know what is the problem?
|
09:55:34
|
<dkayiwa> rafa: so i decided to start by first reading all the ticket comments and reviewing the entire commits for the ticket to get a background of what this is all about :)
|
09:56:21
|
<rafa> dkayiwa: do you need more insight from me?
|
09:56:36
|
<dkayiwa> rafa: that will be helpful too
|
09:57:47
|
*** Ch3ck_ has quit IRC
|
09:57:54
|
<rafa> dkayiwa: I added @OpenmrsProfile annotation, which can be used to annotate Spring beans and specify OpenMRS version or modules that are required by a bean and only if all conditions are met Spring will create such a bean
|
09:58:22
|
<dkayiwa> rafa: ok
|
09:58:46
|
<rafa> dkayiwa: e.g. @OpenmrsProfile(openmrsVersion="1.10") means that a bean should be created only when running OpenMRS 1.10 and later
|
09:59:06
|
<dkayiwa> rafa: that makes perfect sense!
|
10:00:09
|
<rafa> dkayiwa: great
|
10:00:43
|
<rafa> dkayiwa: OpenmrsProfileExclusionFilter is a class that is used by Spring to determine if a bean should be created or not
|
10:00:59
|
<dkayiwa> rafa: oh i see!!!
|
10:01:36
|
<rafa> dkayiwa: just try to debug that to see why it behaves exactly opposite to how it should
|
10:02:01
|
<dkayiwa> rafa: ok
|
10:02:48
|
<rafa> dkayiwa: I suspect OpenmrsConstants.OPENMRS_VERSION_SHORT may have a strange value
|
10:03:25
|
<dkayiwa> rafa: ok let me check that
|
10:04:48
|
*** Ch3ck__ is now known as Ch3ck_
|
10:09:08
|
<dkayiwa> rafa: OpenmrsConstants.OPENMRS_VERSION_SHORT = 1.6
|
10:09:23
|
<rafa> dkayiwa: that's really odd!
|
10:09:48
|
<rafa> dkayiwa: could you debug getVersion in OpenmrsConstants?
|
10:09:56
|
<dkayiwa> rafa: ok
|
10:19:44
|
<dkayiwa> rafa: returns the correct 1.10.0-SNAPSHOT
|
10:20:00
|
<rafa> dkayiwa: any clue why it's 1.6 then?
|
10:20:09
|
<dkayiwa> rafa: problem is getBuildVersionShort() which is not null and hence getVersion is not called
|
10:20:18
|
<rafa> dkayiwa: ahh
|
10:20:19
|
<dkayiwa> rafa: getBuildVersionShort returns 1.6
|
10:20:33
|
<dkayiwa> rafa: String OPENMRS_VERSION_SHORT = THIS_PACKAGE.getSpecificationVersion() != null ? THIS_PACKAGE
|
10:20:33
|
<dkayiwa> .getSpecificationVersion() : (getBuildVersionShort() != null ? getBuildVersionShort() : getVersion());
|
10:20:36
|
<rafa> dkayiwa: is it broken? :)
|
10:21:06
|
<dkayiwa> rafa: caused by my META-INF/MANIFEST.MF having these contents
|
10:21:10
|
<dkayiwa> {Manifest-Version=1.0, Implementation-Title=Java Runtime for Mac OS X, Implementation-Vendor=Apple Computer, Inc., Specification-Version=1.6, Specification-Title=Java Platform API Specification, Name=javax/swing/JOptionPane.class, Created-By=1.6.0_51 (Apple Inc.), Java-Bean=True, Specification-Vendor=Sun Microsystems, Inc., Implementation-Version=1.6.0_51}
|
10:21:28
|
<dkayiwa> rafa: and hence Specification-Version=1.6
|
10:21:48
|
<rafa> dkayiwa: so Specification-Version is Java version?
|
10:21:54
|
<dkayiwa> rafa: if i force getSpecificationVersion to return null, then all tests pass
|
10:21:55
|
<dkayiwa> rafa: yes
|
10:22:29
|
<rafa> dkayiwa: so we can't read version from that file
|
10:22:41
|
<dkayiwa> rafa: atleast not the openmrs version :)
|
10:22:52
|
<rafa> dkayiwa: :)
|
10:23:46
|
<rafa> dkayiwa: interestingly it's correct on Windows
|
10:24:00
|
<dkayiwa> rafa: yikes!!! :)
|
10:24:50
|
<rafa> dkayiwa: looking at our pom.xml these values should be set by maven-jar-plugin
|
10:25:00
|
<dkayiwa> rafa: correct
|
10:26:12
|
<rafa> dkayiwa: can you check if it helps to upgrade plugin verison to 2.4?
|
10:26:23
|
<rafa> dkayiwa: (it's the latest)
|
10:26:33
|
<dkayiwa> rafa: ok
|
10:27:43
|
<dkayiwa> rafa: i think the plugin is doing things correctly
|
10:27:55
|
<dkayiwa> rafa: it is just that the code is reading the wrong MANIFEST.MF :)
|
10:28:13
|
<dkayiwa> rafa: Specification-Version: 1.10.0.${revisionNumber}
|
10:28:28
|
<rafa> dkayiwa: ohhh
|
10:28:55
|
<dkayiwa> rafa: http://pastebin.com/mRXB9A3W
|
10:29:27
|
<dkayiwa> rafa: that is under openmrs/api/target/classes/META-INF
|
10:30:16
|
<rafa> dkayiwa: ok
|
10:30:24
|
<dkayiwa> rafa: so here is the class loader issue: OpenmrsConstants.class.getClassLoader().getResource("META-INF/MANIFEST.MF")
|
10:37:54
|
<rafa> dkayiwa: ok
|
10:37:58
|
<rafa> dkayiwa: how to fix that?
|
10:38:05
|
<dkayiwa> rafa: am looking into it now
|
10:39:03
|
<rafa> dkayiwa: would it be right to say "/META-INF/MANIFEST.MF"?
|
10:39:32
|
<dkayiwa> rafa: does it work?
|
10:40:26
|
*** ningosi has quit IRC
|
10:43:09
|
<rafa> dkayiwa: nope
|
10:43:27
|
<rafa> dkayiwa: I think the correct fix is just to read versions from openmrs.properties I created
|
10:43:51
|
<dkayiwa> rafa: will it work at runtime?
|
10:43:58
|
<rafa> dkayiwa: yes
|
10:44:04
|
<dkayiwa> rafa: ok
|
10:44:16
|
<rafa> dkayiwa: it's basically the same as MANIFEST.MF but the name is unique thus easier to access
|
10:44:27
|
<dkayiwa> rafa: ok
|
10:49:07
|
<dkayiwa> rafa: anything else you need from me? :)
|
10:49:20
|
<rafa> dkayiwa: nope, thanks a lot!
|
10:49:28
|
<dkayiwa> rafa: ok
|
11:14:02
|
*** GitHub134 has joined #openmrs
|
11:14:03
|
<GitHub134> [openmrs-core] dkayiwa pushed 2 new commits to master: http://git.io/yDsVlQ
|
11:14:03
|
<GitHub134> openmrs-core/master 2f17196 Chelsea H. Komlo: Refactor AuditableInterceptor to improve readibility.
|
11:14:03
|
<GitHub134> openmrs-core/master 799b71a dkayiwa: Merge pull request #589 from chelseakomlo/refactor_interceptor...
|
11:14:03
|
*** GitHub134 has left #openmrs
|
11:14:04
|
*** GitHub118 has joined #openmrs
|
11:14:05
|
<GitHub118> [openmrs-core] dkayiwa closed pull request #589: Refactor AuditableInterceptor to improve readibility. (master...refactor_interceptor) http://git.io/Mhywgw
|
11:14:05
|
*** GitHub118 has left #openmrs
|
11:17:10
|
<OpenMRSBot> Recent updates in the world of openmrsci: SON-OPENMRSCOREMASTER-130 has FAILED : Manual build by RafaÅ Korytkowski <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-130>
|
11:24:47
|
*** travis-ci has joined #openmrs
|
11:24:47
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [799b71a] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/17829545
|
11:24:47
|
*** travis-ci has left #openmrs
|
11:39:14
|
*** dkayiwa has quit IRC
|
11:56:53
|
*** sandaru has quit IRC
|
11:57:38
|
*** GitHub135 has joined #openmrs
|
11:57:38
|
<GitHub135> [openmrs-core] dszafranek opened pull request #590: TRUNK-4226: Performance - Method concatenates strings using + in a loop (master...TRUNK-4226) http://git.io/qRVwfw
|
11:57:38
|
*** GitHub135 has left #openmrs
|
12:06:12
|
*** dkayiwa has joined #openmrs
|
12:06:49
|
*** martin_____ has joined #openmrs
|
12:10:27
|
*** martin_____ is now known as martinw
|
12:18:39
|
*** GitHub153 has joined #openmrs
|
12:18:40
|
<GitHub153> [openmrs-core] rkorytkowski pushed 2 new commits to 1.10.x: http://git.io/dndoow
|
12:18:40
|
<GitHub153> openmrs-core/1.10.x 298c65d Rafal Korytkowski: TRUNK-3644 Fixed getting OpenMRS version
|
12:18:40
|
<GitHub153> openmrs-core/1.10.x cf7b09e Rafal Korytkowski: TRUNK-4183 Fixing formatting and ignoring blocking test
|
12:18:40
|
*** GitHub153 has left #openmrs
|
12:37:29
|
<OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-MASTER-292 has FAILED (234 tests failed) : Updated by dkayiwa <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-292>
|
12:39:29
|
<OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-ONEPOINTTENX-85 has FAILED : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-85>
|
12:55:08
|
*** k-joseph has joined #openmrs
|
13:01:38
|
*** Tal__ has joined #openmrs
|
13:01:46
|
<Tal__> dkayiwa: Hi Daniel
|
13:01:55
|
<Tal__> dkayiwa: are you here?
|
13:02:12
|
<dkayiwa> Tal__: good. u?
|
13:02:50
|
<Tal__> dkayiwa: Great, in the last month i worked on the standalone version of the reference application
|
13:03:25
|
<Tal__> dkayiwa: now i need to work with eclipse, so i cloned the openmrs core and installed already
|
13:03:59
|
<Tal__> dkayiwa: i looked at this link https://wiki.openmrs.org/display/docs/Reference+Application+dev+environment+setup
|
13:05:07
|
<Tal__> dkayiwa: and i just wanted to ask you - i need to clone these projects (openmrs-distro-referenceapplication, openmrs-module-appframework, openmrs-module-uiframework)
|
13:05:21
|
<Tal__> dkayiwa: and install them and that's all?
|
13:06:57
|
*** GitHub145 has joined #openmrs
|
13:06:57
|
<GitHub145> [openmrs-core] mszukalski opened pull request #591: TRUNK-4242: SonarQube - Return statements should not occur in finally bl... (master...TRUNK-4242) http://git.io/C2coFg
|
13:06:57
|
*** GitHub145 has left #openmrs
|
13:07:22
|
<dkayiwa> Tal__: what do you want to do at the end of it all? :)
|
13:08:04
|
<Tal__> dkayiwa: run the reference app from eclispe
|
13:08:48
|
<dkayiwa> Tal__: you need the 1.9.x branch
|
13:09:01
|
<Tal__> dkayiwa: ok i have it worked already
|
13:09:17
|
<dkayiwa> Tal__: then build the distro
|
13:09:30
|
<Tal__> dkayiwa: ok
|
13:10:03
|
<Tal__> dkayiwa: by clone - mvn clean install - and install via the module manager in the admin panel?
|
13:10:56
|
<dkayiwa> Tal__: have you built the distro?
|
13:12:37
|
<Tal__> dkayiwa: 1 min, building
|
13:17:35
|
<Tal__> dkayiwa: sorry, it takes a while..
|
13:21:10
|
<Tal__> dkayiwa: ok i built the distro
|
13:23:47
|
<dkayiwa> Tal__: do you see the modules in its target folder
|
13:26:01
|
<Tal__> dkayiwa: in package/taget/distro
|
13:26:17
|
<Tal__> dkayiwa: yes there's a lot of omods
|
13:26:42
|
<dkayiwa> Tal__: now look for you appdata folder
|
13:28:04
|
<Tal__> dkayiwa: where it's located?
|
13:28:20
|
<dkayiwa> Tal__: where your runtime properties file is
|
13:28:38
|
<dkayiwa> Tal__: you will see a modules folder ther
|
13:29:27
|
<Tal__> dkayiwa: i dont have appdata here , have a look:
|
13:29:29
|
<Tal__> dkayiwa: h-MacBook-Pro-sl-tl:openmrs-core tallevi$ ls api build.xml liquibase.build.xml openmrs.iml properties.xml test web build.properties license.txt metadata pom.xml readme.txt tools webapp
|
13:29:51
|
<dkayiwa> Tal__: https://wiki.openmrs.org/display/docs/Overriding+OpenMRS+Default+Runtime+Properties
|
13:29:52
|
<OpenMRSBot> <http://ln-s.net/8c91> (at wiki.openmrs.org)
|
13:31:34
|
<martinw> hi all. has anyone experience with the HL7 format? I sent a sample message to the REST module but the message is not processed because of a missing patient identifier in PID segment.
|
13:32:03
|
<martinw> this is my segment: PID|||7280^^^L^PI||Shavola^John^Mamwa||
|
13:32:07
|
<Tal__> dkayiwa: it says In Windows 7+ this is C:\Users\currentuserrunningtomcat\AppData\Roaming\OpenMRS. In Windows XP and below this is C:\Docs and Settings\currentuserrunningtomcat\Application Data\
|
13:32:15
|
<Tal__> dkayiwa: what about mac ?
|
13:33:35
|
<dkayiwa> Tal__: unix
|
13:34:02
|
<cpower> martinw: have you gotten an answer?
|
13:34:13
|
<Tal__> dkayiwa: it's says nothing about unix ...
|
13:34:34
|
<martinw> cpower ,not yet
|
13:34:47
|
<Tal__> dkayiwa: oh
|
13:34:59
|
<Tal__> dkayiwa: found it, im there
|
13:35:27
|
<Tal__> dkayiwa: i see the modules folder - grab all the omod files to there?
|
13:35:53
|
<dkayiwa> Tal__: replace them by those from distro
|
13:36:08
|
<cpower> martinw: if anyone else can help you go for it, but I'll take a walk around the room with it here at RI and see if an answer comes up
|
13:36:16
|
<martinw> I tried the person_id as given in the mysql tables as well as the omrs patient id given at the patient's dashboard.
|
13:36:24
|
<Tal__> dkayiwa: ok
|
13:37:25
|
<martinw> thx
|
13:37:38
|
<Tal__> dkayiwa: same thing with appframework, and uifreamework?
|
13:38:19
|
<dkayiwa> Tal__: distro has all of them
|
13:38:42
|
<Tal__> dkayiwa: so i just need to run it now?
|
13:38:49
|
*** GitHub41 has joined #openmrs
|
13:38:49
|
<GitHub41> [openmrs-core] dszafranek opened pull request #592: TRUNK-4243: Redundant nullcheck of value known to be non-null (master...TRUNK-4243) http://git.io/qYuk5g
|
13:38:49
|
*** GitHub41 has left #openmrs
|
13:38:55
|
<dkayiwa> Tal__: ok
|
13:39:15
|
<Tal__> dkayiwa: thanks a lot Daniel
|
13:39:17
|
<Tal__> dkayiwa: :)
|
13:51:48
|
<cpower> martinw: I'll first start by saying I learned HL7 in an hour class about a year ago, so don't hold too much weight behind my answer. I also checked with Shaun Grannis and group here for help. Your HL7 is missing a section, there is a missing segment or ^ in the string you put up. The questions that were asked to help you troubleshoot is if Gender should
|
13:51:48
|
<cpower> be in this string? Where is the Medical Record number and is it formatted correctly? And to also look into CWE-6
|
13:52:59
|
<cpower> martinw: Hope this helps. You are definitely missing a segment though
|
13:53:58
|
*** Tal__ has quit IRC
|
13:54:33
|
<martinw> cpower, thank you very much for your help. I changed the full PID segment from the ORUR01 example for my needs. It seems that the checkdigit section caused a problem
|
13:55:35
|
<martinw> where does this check digit normally come from?
|
13:57:51
|
<martinw> respectively, is it a good idea at all to simply delete it (PID|||7280^^^^|| ... compared to PID|||1MT^0^M10|| ... in the wiki)
|
13:59:30
|
<cpower> martinw: not sure, looking for some of the GHI indy team to assist
|
14:01:09
|
<martinw> cwe stands for "coded with exceptions" ?
|
14:06:40
|
<cpower> martinw: Not sure suranga and jkeiper should be in the office in about 30 mins and I'll pass along the question and have them reach out to you
|
14:07:05
|
<martinw> thank you very much
|
14:07:15
|
*** dkithmal has joined #openmrs
|
14:09:08
|
*** tal__ has joined #openmrs
|
14:10:10
|
<tal__> dkayiwa: Daniel, still here?
|
14:10:51
|
<tal__> dkayiwa: after I copied the omod files and run openmrs im getting the following error:
|
14:10:52
|
<tal__> dkayiwa: Error occurred while trying to get the updates needed for the database. Unable to get a connection to the database. Please check your openmrs runtime properties file and make sure you have the correct connection.username and connection.password
|
14:15:04
|
*** Mkop has joined #openmrs
|
14:17:21
|
*** wluyima has joined #openmrs
|
14:19:42
|
<tal__> dkayiwa: daniel?
|
14:29:59
|
*** k-joseph has quit IRC
|
14:34:43
|
<jkeiper> martinw: hi
|
14:34:47
|
* jkeiper is a hl7 guy
|
14:34:57
|
<jkeiper> martinw: what's the problem?
|
14:37:13
|
<martinw> hi
|
14:39:21
|
<martinw> i wondered about the patient identifier segment. especially the checkdigit section was a problem for me. in the wiki it displays (PID|||1MT^0^M10 ...) but for me only the form of (PID|||7279MP-4^^^^ ...) worked
|
14:39:50
|
*** k-joseph has joined #openmrs
|
14:40:24
|
*** GitHub87 has joined #openmrs
|
14:40:25
|
<GitHub87> [openmrs-core] aniketha closed pull request #571: Trunk 3972 Invalid date message is display (master...Trunk-3972) http://git.io/bM4bCA
|
14:40:25
|
*** GitHub87 has left #openmrs
|
14:40:30
|
<martinw> so my question is when is this check digit cosnidered and where does this check section come from. In our case there is already a patient databse from which we transfer data to openmrs.
|
14:41:16
|
<jkeiper> martinw: in the default ORU^R01 processor, the check digit is actually not considered
|
14:41:25
|
<jkeiper> martinw: but adding it to the PID segment should not cause a problem
|
14:41:49
|
<jkeiper> martinw: the important thing is that hte identifier must be the whole identifier, including the checkdigit
|
14:42:07
|
<jkeiper> martinw: so, PID|||7279MP-4^4^M10^ would have worked
|
14:42:23
|
<jkeiper> martinw: I don't know if that's the normal use of the PID segment but that's how we do it :-D
|
14:42:40
|
<martinw> ah ok
|
14:43:46
|
<martinw> the dash sparated number in the openmrs identifier is a check digit or is it just coincidental that it would be a 4 now?
|
14:44:33
|
<jkeiper> martinw: yes, the format for an identifier is [several digits and/or letters]-[checkdigit]
|
14:44:50
|
<jkeiper> martinw: that's the style for any Luhn validated identifier
|
14:45:25
|
*** harsz89 has quit IRC
|
14:45:42
|
<jkeiper> martinw: it is possible to have an identifier that does not match this pattern, and that is set in the Patient Identifier Type settings
|
14:47:04
|
<martinw> ok thank you. do you have time for another question? it seems that my obs is not assigned to a patient.
|
14:49:00
|
<dkayiwa> tal__: hi
|
14:49:33
|
<tal__> dkayiwa: after I copied the omod files and run openmrs im getting the following error: Error occurred while trying to get the updates needed for the database. Unable to get a connection to the database. Please check your openmrs runtime properties file and make sure you have the correct connection.username and connection.password
|
14:49:52
|
<dkayiwa> tal__: delete the runtime properties file and database, then run again
|
14:50:44
|
<tal__> dkayiwa: openmrs-runtime.properties this file?
|
14:51:01
|
<dkayiwa> tal__: check the wiki page i gave u
|
14:51:08
|
<tal__> dkayiwa: ok
|
14:51:21
|
<downey> wluyima: Who is currently using devtest01? Someone from the public asked me for the login credentials for the webapp, but I don't want to give them out if someone in there messing around could cause problems. :)
|
14:55:38
|
*** tal__ has quit IRC
|
14:55:57
|
<martinw> jkeiper, in case you still have a moment: I send this http://pastebin.com/ctTX9Cx7 HL7 message to the REST module. What I expected to see is a change of the patient's weight (should be 85) but it is not visible. I think I do not understand what happens with an obs segement after the HL/7 message was processed.
|
14:56:33
|
<jkeiper> martinw: have you verified that the HL7 was processed through the queues?
|
14:57:18
|
*** dkithmal_ has joined #openmrs
|
14:57:29
|
*** harsz89 has joined #openmrs
|
14:57:30
|
*** ChanServ sets mode: +v harsz89
|
14:58:36
|
<martinw> hm at least they did not appear on the HL7 error list but on the HL7 archive. but maybe all messages (also the erroneous) appear there. how can I verify that exactly?
|
14:59:49
|
*** dkithmal has quit IRC
|
15:00:50
|
*** Ch3ck_ has quit IRC
|
15:01:24
|
<martinw> jkeiper, it seems that the obx segment is cut off.... on the archive list everything up to the obr segment is displayed :(
|
15:06:35
|
<cpower> ok...it's time to scrum!
|
15:06:41
|
<cpower> !scrumon cpower
|
15:06:41
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
15:07:21
|
<cpower> Order: dkayiwa , wluyima , rafa , djazayeri , and anyone else who would like to give an update on what they are doing in the land of OpenMRS!
|
15:09:09
|
<cpower> don't be shy dkayiwa go ahead and get us started!
|
15:09:27
|
<jkeiper> martinw: we typically separate HL7 lines with \r ... is that your separator?
|
15:09:42
|
<dkayiwa> Reviewing tickets, merging, etc
|
15:09:42
|
<dkayiwa> Doing some ticket administration
|
15:09:43
|
<dkayiwa> No Blockers
|
15:09:54
|
<cpower> wluyima: you are up
|
15:10:15
|
<wluyima> just a sec
|
15:10:36
|
<cpower> ok rafa if your ready...
|
15:10:45
|
<rafa> Today:
|
15:10:45
|
<rafa> * Fixed 1.10.x branch on CI with the help from Daniel
|
15:10:45
|
<rafa> * OpenMRS University
|
15:10:45
|
<rafa> * Releasing 2.0...
|
15:10:45
|
<rafa> * PM Call
|
15:10:46
|
<rafa> * Design Call
|
15:10:46
|
<rafa> No blockers.
|
15:11:14
|
<cpower> How's 2.0 going rafa ?
|
15:11:43
|
<rafa> cpower: have to deal with CI issues which slows me down :(
|
15:12:03
|
<rafa> cpower: apparently CI is being migrated
|
15:12:14
|
<wluyima> Tuesday:
|
15:12:15
|
<wluyima> - Order entry bi weekly call
|
15:12:16
|
<wluyima> - review and merge code
|
15:12:18
|
<wluyima> - Paired with nicholas on TRUNK-4144 - Add api methods to fetch drugs by reference mappings
|
15:12:19
|
<wluyima> - complete TRUNK-4151 - Choose a drug formulation to order
|
15:12:21
|
<wluyima> Wednesday:
|
15:12:22
|
<wluyima> - PM call
|
15:12:24
|
<wluyima> - design call
|
15:12:25
|
<wluyima> - code review and merge code
|
15:12:26
|
<wluyima> - Improve code in OrderService.saveOrder
|
15:12:27
|
<wluyima> Blockers: None
|
15:12:46
|
<cpower> rafa: great tiing for a migration
|
15:12:50
|
<cpower> timing
|
15:12:57
|
<cpower> djazayeri: you are up
|
15:14:54
|
<cpower> ok thanks!
|
15:14:58
|
<cpower> !scrumoff
|
15:14:58
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
15:14:59
|
*** dkithmal_ has quit IRC
|
15:19:23
|
*** robbyoconnor has quit IRC
|
15:19:43
|
*** dkithmal has joined #openmrs
|
15:23:07
|
<k-joseph> wluyima: hi
|
15:24:34
|
<wluyima> hi k-joseph
|
15:26:42
|
<jkeiper> djazayeri, wluyima, rafa, dkayiwa ... has anyone tried to add OAuth, LDAP, or other kind of authentication to OpenMRS?
|
15:27:03
|
<jkeiper> i see OAuth referenced in a SMART Module ticket
|
15:27:15
|
<k-joseph> wluyima: i have seen your comment, and my response is i addressed them already and i think i can again commit so that you look at them again, meanwhile i rememeber you had commented on the first commit that i later deleted
|
15:28:55
|
<cpower> wluyima: hi
|
15:31:03
|
*** GitHub119 has joined #openmrs
|
15:31:03
|
<GitHub119> [openmrs-core] sachethgupta opened pull request #594: TRUNK - 3984 The concept page has no extension point that gives you the conceptId (master...TRUNK-3984) http://git.io/Yna_ow
|
15:31:03
|
*** GitHub119 has left #openmrs
|
15:48:42
|
*** GitHub52 has joined #openmrs
|
15:48:43
|
<GitHub52> [openmrs-core] dkayiwa pushed 2 new commits to master: http://git.io/p-wGjQ
|
15:48:43
|
<GitHub52> openmrs-core/master c648131 Damian Szafranek: TRUNK-4226: Performance - Method concatenates strings using + in a loop
|
15:48:43
|
<GitHub52> openmrs-core/master 73bcb65 dkayiwa: Merge pull request #590 from dszafranek/TRUNK-4226...
|
15:48:43
|
*** GitHub52 has left #openmrs
|
15:48:43
|
*** GitHub50 has joined #openmrs
|
15:48:43
|
<GitHub50> [openmrs-core] dkayiwa closed pull request #590: TRUNK-4226: Performance - Method concatenates strings using + in a loop (master...TRUNK-4226) http://git.io/qRVwfw
|
15:48:43
|
*** GitHub50 has left #openmrs
|
15:50:13
|
*** GitHub153 has joined #openmrs
|
15:50:14
|
<GitHub153> [openmrs-core] wluyima pushed 1 new commit to 1.10.x: http://git.io/d3dy1w
|
15:50:14
|
<GitHub153> openmrs-core/1.10.x 45de13c wyclif: Removed unused imports in OrderServiceTest
|
15:50:14
|
*** GitHub153 has left #openmrs
|
15:55:28
|
*** GitHub183 has joined #openmrs
|
15:55:29
|
<GitHub183> [openmrs-core] dkayiwa pushed 2 new commits to master: http://git.io/StboBA
|
15:55:29
|
<GitHub183> openmrs-core/master 0a08e06 Marek Szukalski: TRUNK-4242: SonarQube - Return statements should not occur in finally blocks
|
15:55:29
|
<GitHub183> openmrs-core/master 1a9f304 dkayiwa: Merge pull request #591 from mszukalski/TRUNK-4242...
|
15:55:29
|
*** GitHub183 has left #openmrs
|
15:55:32
|
*** GitHub51 has joined #openmrs
|
15:55:33
|
<GitHub51> [openmrs-core] dkayiwa closed pull request #591: TRUNK-4242: SonarQube - Return statements should not occur in finally bl... (master...TRUNK-4242) http://git.io/C2coFg
|
15:55:33
|
*** GitHub51 has left #openmrs
|
15:58:38
|
*** GitHub155 has joined #openmrs
|
15:58:38
|
<GitHub155> [openmrs-core] dkayiwa pushed 2 new commits to master: http://git.io/2qLtfw
|
15:58:38
|
<GitHub155> openmrs-core/master db7eb06 Damian Szafranek: TRUNK-4245: Method uses the same code for two branches
|
15:58:38
|
<GitHub155> openmrs-core/master 1ba5504 dkayiwa: Merge pull request #593 from dszafranek/TRUNK-4245...
|
15:58:38
|
*** GitHub155 has left #openmrs
|
15:58:39
|
*** GitHub121 has joined #openmrs
|
15:58:39
|
<GitHub121> [openmrs-core] dkayiwa closed pull request #593: TRUNK-4245: Method uses the same code for two branches (master...TRUNK-4245) http://git.io/hgeCLA
|
15:58:39
|
*** GitHub121 has left #openmrs
|
16:00:06
|
<wluyima> hi k-joseph
|
16:00:24
|
<wluyima> k-joseph: which is the new pull request?
|
16:04:20
|
*** travis-ci has joined #openmrs
|
16:04:20
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [73bcb65] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/17844204
|
16:04:20
|
*** travis-ci has left #openmrs
|
16:05:29
|
*** GitHub43 has joined #openmrs
|
16:05:30
|
<GitHub43> [openmrs-core] dkayiwa closed pull request #592: TRUNK-4243: Redundant nullcheck of value known to be non-null (master...TRUNK-4243) http://git.io/qYuk5g
|
16:05:30
|
*** GitHub43 has left #openmrs
|
16:05:30
|
*** GitHub18 has joined #openmrs
|
16:05:30
|
<GitHub18> [openmrs-core] dkayiwa pushed 2 new commits to master: http://git.io/FQCurg
|
16:05:30
|
<GitHub18> openmrs-core/master 39463eb Damian Szafranek: TRUNK-4243: Redundant nullcheck of value known to be non-null
|
16:05:30
|
<GitHub18> openmrs-core/master 9793fce dkayiwa: Merge pull request #592 from dszafranek/TRUNK-4243...
|
16:05:30
|
*** GitHub18 has left #openmrs
|
16:06:45
|
*** k-joseph_ has joined #openmrs
|
16:06:59
|
*** k-joseph has quit IRC
|
16:07:26
|
*** dkayiwa has quit IRC
|
16:09:33
|
*** travis-ci has joined #openmrs
|
16:09:33
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [1a9f304] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/17844630
|
16:09:33
|
*** travis-ci has left #openmrs
|
16:09:50
|
<wluyima> k-joseph_: ?
|
16:10:21
|
<k-joseph_> wluyima: https://github.com/openmrs/openmrs-core/pull/563 was the second pull request that i last added on the ticket which you las slightly commented had locally addressed your comments before i made that comment
|
16:11:06
|
<wluyima> k-joseph_: cool, can you please add it to the ticket
|
16:12:04
|
<wluyima> k-joseph_: and as i mentioned, you need to use the same pull request when addressing review comments except if the original was already merged into master
|
16:13:03
|
<k-joseph_> wluyima: that's fine, will always try to do that, meanwhile i remember i had added it to the ticket, checking to confirm
|
16:13:12
|
*** travis-ci has joined #openmrs
|
16:13:13
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [1ba5504] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/17844844
|
16:13:13
|
*** travis-ci has left #openmrs
|
16:13:41
|
<wluyima> k-joseph_: i actually commented on that new PR
|
16:14:31
|
<wluyima> k-joseph_: so you are saying the unit tests fail when you run the change sets?
|
16:15:11
|
<k-joseph_> wluyima: that's right, and i had addressed your comments, though that seamed not to help pass the test as well
|
16:15:28
|
*** robbyoconnor has joined #openmrs
|
16:15:28
|
*** ChanServ sets mode: +v robbyoconnor
|
16:15:29
|
<wluyima> k-joseph_: it means the change sets are incorrect
|
16:15:31
|
*** robbyoconnor has quit IRC
|
16:16:04
|
<wluyima> k-joseph_: they are not doing the right thing, is that PR updated? If yes, that query still looks incorrect to me and that is why the tests are failing
|
16:16:05
|
<k-joseph_> wluyima: yes it does, whether with or without the two changesets, or one at a time
|
16:17:04
|
<wluyima> k-joseph_: the tests of course are supposed to fail without the change set, afterwards they should pass, so it means the queries are incorrect, you need to fix them
|
16:17:46
|
<wluyima> k-joseph_: i added some comments that i see you have not yet addresses because the code hasn't changed yet
|
16:19:23
|
*** dkayiwa has joined #openmrs
|
16:19:59
|
<k-joseph_> wluyima: that's fine, do you mind if we go over them with you so that i take less time fixing them, since i had addressed your comments according to the way i perceived what you meant
|
16:20:14
|
<wluyima> sure, hangout?
|
16:20:23
|
<wluyima> k-joseph_: sure, hangout?
|
16:20:41
|
*** GitHub103 has joined #openmrs
|
16:20:41
|
<GitHub103> [openmrs-core] mszukalski opened pull request #595: TRUNK-4244: SonarQube - Method may fail to clean up stream or resource o... (master...TRUNK-4244) http://git.io/RMwQ0Q
|
16:20:41
|
*** GitHub103 has left #openmrs
|
16:20:43
|
<k-joseph_> wluyima: ok, what time, since am now going offline
|
16:21:57
|
*** travis-ci has joined #openmrs
|
16:21:58
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [9793fce] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/17845465
|
16:21:58
|
*** travis-ci has left #openmrs
|
16:22:03
|
<wluyima> k-joseph_: now
|
16:22:46
|
<k-joseph_> wluyima: was going offline, is there any other time you prefer from now
|
16:23:13
|
<wluyima> then it is up to you to pick a time as long as it is not from 1m-3pm EST
|
16:23:26
|
<wluyima> k-joseph_: : then it is up to you to pick a time as long as it is not from 1m-3pm EST
|
16:23:46
|
<wluyima> k-joseph_: so it has to be now or after 11pm ugandan time
|
16:24:21
|
<wluyima> k-joseph_: some quick notes
|
16:24:48
|
<wluyima> k-joseph_: don't do the select(select(â¦)), it should just be one select(..)
|
16:24:52
|
<k-joseph_> wluyima: that's fine, will be back before two hours from now else it can be after 11pm ug time
|
16:26:31
|
*** Ch3ck_ has joined #openmrs
|
16:28:16
|
<wluyima> k-joseph_: also your where clause seems incorrect when inserting providers
|
16:28:31
|
<wluyima> k-joseph_: and that is why that assertion is failing in the unit test
|
16:29:15
|
<wluyima> k-joseph_: ok see you at 11 UG time
|
16:30:29
|
*** k-joseph_ has quit IRC
|
16:33:18
|
*** GitHub162 has joined #openmrs
|
16:33:19
|
<GitHub162> [openmrs-core] dkayiwa closed pull request #595: TRUNK-4244: SonarQube - Method may fail to clean up stream or resource o... (master...TRUNK-4244) http://git.io/RMwQ0Q
|
16:33:19
|
*** GitHub162 has left #openmrs
|
16:33:19
|
*** GitHub34 has joined #openmrs
|
16:33:20
|
<GitHub34> [openmrs-core] dkayiwa pushed 2 new commits to master: http://git.io/tL_NBw
|
16:33:20
|
<GitHub34> openmrs-core/master 667c5ff Marek Szukalski: TRUNK-4244: SonarQube - Method may fail to clean up stream or resource on checked exception
|
16:33:20
|
<GitHub34> openmrs-core/master 8a59c24 dkayiwa: Merge pull request #595 from mszukalski/TRUNK-4244...
|
16:33:20
|
*** GitHub34 has left #openmrs
|
16:37:29
|
*** Ch3ck_ has quit IRC
|
16:39:32
|
*** martinw has quit IRC
|
16:45:27
|
*** dkayiwa has quit IRC
|
16:53:16
|
*** travis-ci has joined #openmrs
|
16:53:16
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [8a59c24] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/17847676
|
16:53:16
|
*** travis-ci has left #openmrs
|
17:15:42
|
<downey> Bamboo is currently restarting :)
|
17:22:39
|
<OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-ONEPOINTTENX-85 has FAILED : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-85> || TRUNK-MASTER-292 has FAILED (234 tests failed) : Updated by dkayiwa <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-292> || SON-OPENMRSCOREMASTER-130 has FAILED : Manual build by RafaÅ Korytkowski <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-130> || REFAPP-DEMO-112 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/REFAPP-DEMO-112> || REFAPP-OMODDISTRO-1667 has FAILED (1 tests failed) : Dependant of RA-RA-400 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1667> || SON-OPENMRSCOREMASTER-129 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-129> || REFAPP-OMODDISTRO-1666 has FAILED (2 tests failed) : Dependant of RDD-RDD-336 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1666> || CA-CA-644 has FAILED : Manual build by RafaÅ Korytkowski <https://ci-stg.openmrs.org/browse/CA-CA-644> || CA-CA-643 has FAILED : Updated by Rafal Korytkowski <https://ci-stg.openmrs.org/browse/CA-CA-643> || APPUI-APPUI-309 has FAILED : Dependant of EMRAPI-EMRAPI-417 <https://ci-stg.openmrs.org/browse/APPUI-APPUI-309> || CA-CA-642 has FAILED : Dependant of EMRAPI-EMRAPI-417 <https://ci-stg.openmrs.org/browse/CA-CA-642> || REFMETA-REFMETA-250 has FAILED : Dependant of EMRAPI-EMRAPI-417 <https://ci-stg.openmrs.org/browse/REFMETA-REFMETA-250> || REFAPP-DEMO-111 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/REFAPP-DEMO-111> || TRUNK-ONEPOINTTENX-84 has FAILED (2 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-84> || TRUNK-ONEPOINTTENX-83 has FAILED (2 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-83> || SON-OPENMRSCOREMASTER-128 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-128> || REFAPP-STAND-341 has FAILED : Dependant of REFAPP-OMODDISTRO-1662 <https://ci-stg.openmrs.org/browse/REFAPP-STAND-341> || REFAPP-OMODDISTRO-1660 has FAILED : Dependant of CA-CA-634 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1660> || REFAPP-DEMO-110 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/REFAPP-DEMO-110> || NIGHTLY-TRUNK-12 has FAILED : Manual build by Ryan Yates <https://ci-stg.openmrs.org/browse/NIGHTLY-TRUNK-12> || SON-OPENMRSCOREMASTER-127 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-127> || REFAPP-DEMO-109 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/REFAPP-DEMO-109> || SON-OPENMRSCOREMASTER-126 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-126> || REFAPP-DEMO-108 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/REFAPP-DEMO-108> || SON-OPENMRSCOREMASTER-125 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-125> || TRUNK-ONEPOINTTENX-82 has FAILED (2 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-82> || EMRAPI-EMRAPI-408 has FAILED (59 tests failed) : Dependant of REP-REP-181 <https://ci-stg.openmrs.org/browse/EMRAPI-EMRAPI-408> || SON-OPENMRSCOREMASTER-124 has FAILED (1 tests failed) : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-124> || REP-REP-179 has FAILED (2 tests failed) : Dependant of CONTRIB-TESTUTILS-7 <https://ci-stg.openmrs.org/browse/REP-REP-179> || REP-REP-178 has FAILED : Updated by Darius Jazayeri <https://ci-stg.openmrs.org/browse/REP-REP-178>
|
17:56:00
|
*** Akshika47 has joined #openmrs
|
17:56:23
|
<Akshika47> +suranga
|
17:56:34
|
<Akshika47> what are Xforms?
|
17:59:09
|
<Akshika47> @downey
|
17:59:24
|
<Akshika47> I want to know about Xforms
|
17:59:59
|
<downey> Akshika47: What would you like to know? http://en.wikipedia.org/wiki/XForms
|
18:00:59
|
<Akshika47> @downey : I came across some ticekts, they were related to Xforms. I will read the link, Thank you very much
|
18:00:59
|
<Akshika47> :D
|
18:15:04
|
*** k-joseph has joined #openmrs
|
18:16:33
|
*** k-joseph has joined #openmrs
|
18:30:25
|
<wluyima> hi dkithmal
|
18:30:30
|
<wluyima> sorry dkithmal
|
18:34:53
|
<OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1668 has FAILED (2 tests failed) : Manual build by Ryan Yates <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1668>
|
18:37:13
|
*** wluyima has quit IRC
|
18:41:56
|
*** dkithmal has quit IRC
|
18:42:44
|
*** dkithmal has joined #openmrs
|
18:43:43
|
*** jblaya has joined #openmrs
|
18:44:14
|
<jblaya> nribeka, do you have a sec for a groovy question?
|
18:44:38
|
<nribeka> jblaya: i can try to answer that but i'm definitely no expert in groovy :)
|
18:45:59
|
<jblaya> nribeka, I have a feeling it's something simple that I'm not seeing
|
18:46:25
|
<jblaya> nribeka, this is the code Integer attId= new Integer(8);
|
18:46:25
|
<jblaya> pa.setPersonAttributeTypeId(attId);
|
18:46:45
|
<jblaya> nribeka, and this is the error I'm getting when I run it groovy.lang.MissingMethodException: No signature of method: org.openmrs.PersonAttribute.setPersonAttributeTypeId() is applicable for argument types: (java.lang.Integer) values: [8]
|
18:46:45
|
<jblaya> Possible solutions: setPersonAttributeId(java.lang.Integer)
|
18:46:45
|
<jblaya> at Script1$_run_closure1.doCall(Script1.groovy:51)
|
18:46:56
|
<jblaya> where line 51 is the setPersonAttributeTypeId
|
18:47:20
|
<jblaya> nribeka, up top I've done an import java.lang.Integer;
|
18:49:54
|
<nribeka> just doing pa.setPersonAttributeId(8), doesn't work jblaya?
|
18:50:15
|
<jblaya> nribeka, nop, I get the same error
|
18:50:25
|
<nribeka> how about pa.setId()
|
18:50:32
|
*** wluyima has joined #openmrs
|
18:50:42
|
<nribeka> pa.setId(8)
|
18:52:28
|
<jblaya> nribeka, yep, that worked :D
|
18:52:46
|
<jblaya> nribeka, one other question, how do I get those values to actually commit to the database
|
18:52:47
|
<nribeka> it's calling the same jblaya
|
18:52:52
|
<nribeka> according to this one: https://github.com/openmrs/openmrs-core/blob/master/api/src/main/java/org/openmrs/PersonAttribute.java#L336
|
18:53:06
|
<jblaya> nribeka, hilarious...
|
18:53:24
|
<jblaya> nribeka, what's the analog of obsService.saveObs for a person attribute?
|
18:54:04
|
<nribeka> you can save them by calling personService.savePerson i think
|
18:54:11
|
<nribeka> that should cascade the saving
|
18:56:07
|
*** uju has joined #openmrs
|
18:57:38
|
<jblaya> nribeka, awesome, will try, thanks
|
19:03:00
|
<OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-LATEST-133 has FAILED (1 tests failed) : Manual build by Ryan Yates <https://ci-stg.openmrs.org/browse/TRUNK-LATEST-133>
|
19:05:21
|
<nribeka> cool jblaya
|
19:24:23
|
*** Akshika47 has quit IRC
|
19:32:08
|
*** zmccurdy has joined #openmrs
|
19:35:28
|
*** jblaya has quit IRC
|
19:41:30
|
*** zmccurdy has quit IRC
|
19:46:38
|
*** dkithmal has quit IRC
|
19:53:01
|
*** deep has joined #openmrs
|
19:57:18
|
*** deep has quit IRC
|
20:03:35
|
*** dkithmal has joined #openmrs
|
20:13:19
|
*** deep has joined #openmrs
|
20:14:29
|
*** dkithmal has quit IRC
|
20:16:35
|
*** dkayiwa has joined #openmrs
|
20:28:01
|
<deep> Hi, I would like to contribute to OpenMRS. Can somebody please help me how to get started
|
20:36:10
|
<dkayiwa> deep: have you looked at this? https://wiki.openmrs.org/display/docs/Getting+Started+as+a+Developer
|
20:36:11
|
<OpenMRSBot> <http://ln-s.net/8bkO> (at wiki.openmrs.org)
|
20:42:22
|
<deep> Yeah
|
20:42:33
|
*** akshata has joined #openmrs
|
20:42:47
|
<deep> When I create OpenMRS id its giving some error
|
20:42:50
|
*** jblaya has joined #openmrs
|
20:43:54
|
*** jblaya_ has joined #openmrs
|
20:47:49
|
<downey> deep: what is the error?
|
20:48:05
|
<downey> +cc elliott_w
|
20:49:03
|
*** RoonyH has joined #openmrs
|
20:49:51
|
*** akshata has quit IRC
|
20:50:18
|
<elliott_w> deep: I just saw that your IP address was being blocked by our anti-spam system. I added you to the whitelist, try creating your ID again
|
20:52:53
|
<k-joseph> wluyima: hi
|
20:55:21
|
<jblaya_> nribeka, can I bug you with one more error?
|
20:55:58
|
<jblaya_> nribeka, never mind, darius just answered it... I'll see if his responde works
|
20:59:02
|
*** k-joseph has quit IRC
|
21:06:01
|
*** hinojosa has joined #openmrs
|
21:10:19
|
<deep> elliott_w: I have succesfully created my ID
|
21:17:13
|
*** jblaya_ has quit IRC
|
21:17:14
|
*** jblaya has quit IRC
|
21:27:29
|
<hinojosa> Hi djazayeri - I'm interested to know if OpenMRS has a commercial support?
|
21:29:08
|
<djazayeri> hinojosa: OpenMRS itself does not provide any commercial support. There are groups that can/will provide commercial support. None of them are "official"
|
21:29:21
|
<downey> hinojosa: Many organizations that implement OpenMRS also provide support for their customers ... however, we don't currently maintain a list of any "official" providers of such at the OpenMRS project level. Our implementers mailing list subscribers could certainly provide leads. http://go.openmrs.org/lists
|
21:29:42
|
<hinojosa> ok - thank you. Cheers.
|
21:30:27
|
<djazayeri> downey: I like that we both put "official" in quotes. Also, your answer is better. :-)
|
21:30:41
|
<downey> djazayeri: time to merge :)
|
21:54:33
|
*** hinojosa has left #openmrs
|
22:08:45
|
*** RoonyH has quit IRC
|
22:10:13
|
*** uju has quit IRC
|
22:16:23
|
*** uju has joined #openmrs
|
22:20:02
|
*** uju has left #openmrs
|
22:22:26
|
*** deep has quit IRC
|
22:28:10
|
*** wluyima_ has joined #openmrs
|
22:30:59
|
*** wluyima has quit IRC
|
22:33:54
|
*** wluyima_ has quit IRC
|
23:30:38
|
*** dkayiwa has quit IRC
|
23:37:27
|
*** ddesimone has quit IRC
|
23:40:18
|
*** ddesimone has joined #openmrs
|