| 00:23:30 | <OpenMRSBot> Recent updates in the world of openmrsci: HFEUI-HFEUI-289 has FAILED (1 tests failed) : Dependant of APPUI-APPUI-297 <https://ci-stg.openmrs.org/browse/HFEUI-HFEUI-289> |
| 00:39:34 | <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1644 has FAILED (2 tests failed) : Dependant of CA-CA-619 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1644> |
| 01:01:12 | *** wluyima has joined #openmrs |
| 01:17:15 | *** VaibhavAgarwal has quit IRC |
| 02:04:49 | *** Chris_Oelmueller has joined #openmrs |
| 02:08:32 | *** ChrisOelmueller has quit IRC |
| 02:09:49 | *** harshadura has joined #openmrs |
| 02:09:50 | *** ChanServ sets mode: +v harshadura |
| 02:38:02 | <OpenMRSBot> Recent updates in the world of openmrsci: SON-OPENMRSCOREMASTER-122 has FAILED (234 tests failed) : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-122> |
| 05:02:29 | *** wluyima has quit IRC |
| 05:11:02 | *** cioan1 has quit IRC |
| 05:20:26 | *** LeeBreisacher has joined #openmrs |
| 05:20:50 | <LeeBreisacher> djazayeri: yt? |
| 05:56:52 | <djazayeri> LeeBreisacher: I am now |
| 06:06:16 | <LeeBreisacher> djazayeri: hi |
| 06:06:27 | <LeeBreisacher> djazayeri: about the failing ref app tests... |
| 06:06:59 | <djazayeri> LeeBreisacher: ah yes. i haven't looked back at them... |
| 06:07:04 | <LeeBreisacher> djazayeri: there's some serious problems on devtest01. |
| 06:07:20 | <LeeBreisacher> djazayeri: try just logging in and click Find Patient |
| 06:07:27 | <LeeBreisacher> djazayeri: you get NPE |
| 06:07:42 | <djazayeri> LeeBreisacher: same on o2? |
| 06:07:49 | <LeeBreisacher> djazayeri: no |
| 06:08:31 | <LeeBreisacher> djazayeri: because 01 gets the latest build, 02 doesn't get updated unless the tests all pass. |
| 06:08:51 | <djazayeri> LeeBreisacher: must be data error then. unfortunately the stack trace is pretty opaque |
| 06:09:08 | <LeeBreisacher> djazayeri: I don't think it's a data problem |
| 06:09:47 | <LeeBreisacher> djazayeri: there were several updates -- that's when tests started failing. |
| 06:10:42 | <djazayeri> LeeBreisacher: oh, right, it won't update devtest02 if 01 doesn't pass... |
| 06:10:51 | <LeeBreisacher> djazayeri: iow, the tests are working -- they point to bugs! |
| 06:11:05 | <djazayeri> LeeBreisacher: great! sort of :-) |
| 06:11:42 | <djazayeri> LeeBreisacher: maybe something about the coreapps module is broken since we released new versions of uiframework, appframework, appui, etc |
| 06:12:35 | <LeeBreisacher> djazayeri: yes, somewhere in all those new module versions... |
| 06:13:18 | <djazayeri> LeeBreisacher: I haven't managed to get a vagrant setup working unfortunately (haven't tried since failing because I already have mysql install) so I didn't get to test this further |
| 06:16:38 | <LeeBreisacher> djazayeri: another example: if you try to register a new patient, you get this when you click "confirm": java.lang.NoSuchMethodError: org.openmrs.module.appframework.service.AppFrameworkService.getExtensionsForCurrentUser(Ljava/lang/String;Ljavax/script/Bindings;)Ljava/util/List; |
| 06:17:03 | <djazayeri> LeeBreisacher: ah, it's a real bug then, which hopefully rafa will be able to pick up... |
| 06:19:27 | <djazayeri> LeeBreisacher: that one is because we did change a method signature in |
| 06:19:30 | <djazayeri> AppFrameowrk |
| 06:20:39 | <LeeBreisacher> djazayeri: shouldn't that have caused a compile error? |
| 06:21:12 | <djazayeri> LeeBreisacher: it's legal in the version of AppFramework that coreapps was compiled against |
| 06:21:21 | <djazayeri> LeeBreisacher: it's no longer legal against the latest released version |
| 06:21:48 | <LeeBreisacher> djazayeri: like I said, there should be a compile error somewhere.. |
| 06:21:53 | <djazayeri> LeeBreisacher: presumably if we update the dependency version in coreapps to be appframework-2.1, then there will be a compile error |
| 06:22:17 | <djazayeri> LeeBreisacher: i.e. I suspect we're not compiling coreapps against the same appframework version that's in the distro |
| 06:22:22 | <LeeBreisacher> djazayeri: ah, so it's a dependencies-not-updated problem |
| 06:22:30 | <djazayeri> LeeBreisacher: that's my guess |
| 06:22:50 | <LeeBreisacher> djazayeri: hopefully that will fix other problems too |
| 06:53:52 | *** harshadura_ has joined #openmrs |
| 06:57:31 | *** harshadura has quit IRC |
| 07:11:59 | *** upul has quit IRC |
| 07:22:21 | *** LeeBreisacher has left #openmrs |
| 07:47:02 | *** dkayiwa has joined #openmrs |
| 09:17:26 | *** djazayeri1 has joined #openmrs |
| 09:18:06 | *** djazayeri has quit IRC |
| 09:24:39 | *** VaibhavAgarwal has joined #openmrs |
| 09:37:15 | *** sai has joined #openmrs |
| 09:42:01 | *** sai has quit IRC |
| 09:42:01 | *** VaibhavAgarwal has quit IRC |
| 10:31:57 | *** dkayiwa has quit IRC |
| 10:55:19 | *** maninc has quit IRC |
| 10:56:14 | *** maninc has joined #openmrs |
| 10:59:51 | *** wluyima has joined #openmrs |
| 11:12:18 | *** wluyima has quit IRC |
| 11:18:02 | <OpenMRSBot> Recent updates in the world of openmrsci: SON-OPENMRSCOREMASTER-123 has FAILED : Manual build by RafaÅ Korytkowski <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-123> |
| 11:28:06 | <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1645 has FAILED (7 tests failed) : Updated by Rafal Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1645> |
| 11:33:52 | *** k-joseph has joined #openmrs |
| 11:38:02 | *** Chris_Oelmueller is now known as ChrisOelmueller |
| 12:24:18 | <OpenMRSBot> Recent updates in the world of openmrsci: EMRAPI-EMRAPI-403 has FAILED (77 tests failed) : Updated by arathyjan <https://ci-stg.openmrs.org/browse/EMRAPI-EMRAPI-403> |
| 12:30:19 | <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1645 has FAILED (2 tests failed) : Rebuilt 1 times <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1645> |
| 12:40:21 | <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1646 has FAILED (7 tests failed) : Manual build by RafaÅ Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1646> |
| 12:50:24 | <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1648 has FAILED : Updated by Rafal Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1648> || REFAPP-OMODDISTRO-1647 has FAILED : Manual build by RafaÅ Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1647> |
| 13:08:02 | *** cioan has joined #openmrs |
| 13:57:24 | *** dkayiwa has joined #openmrs |
| 14:10:27 | *** wluyima has joined #openmrs |
| 14:23:07 | *** GitHub175 has joined #openmrs |
| 14:23:07 | <GitHub175> [openmrs-core] dkayiwa closed pull request #564: changes for trunk3987 (1.8.x...Trunk-3987(1.8.x)) http://git.io/Z3PQdA |
| 14:23:07 | *** GitHub175 has left #openmrs |
| 14:31:51 | *** dkayiwa has quit IRC |
| 14:32:08 | *** dkayiwa has joined #openmrs |
| 14:44:21 | *** dkayiwa has quit IRC |
| 14:51:51 | *** dkayiwa has joined #openmrs |
| 14:55:24 | *** GitHub115 has joined #openmrs |
| 14:55:24 | <GitHub115> [openmrs-core] dkayiwa closed pull request #518: TRUNK-3826 Bug in PersonAttribute.compareTo (1.9.x...TRUNK-3826) http://git.io/nJjf_A |
| 14:55:24 | *** GitHub115 has left #openmrs |
| 14:58:41 | *** GitHub26 has joined #openmrs |
| 14:58:41 | <GitHub26> [openmrs-core] dkayiwa closed pull request #464: TRUNK-4140 Substitute deprecated method call in HibernateContextDAO (master...TRUNK-4140) http://git.io/xIGZYA |
| 14:58:41 | *** GitHub26 has left #openmrs |
| 15:01:26 | *** GitHub142 has joined #openmrs |
| 15:01:26 | <GitHub142> [openmrs-core] dkayiwa closed pull request #493: TRUNK-3195 QueryException arising when trying to add FormField to ContainingAnyForm... (master...TRUNK-3195) http://git.io/C5ClEA |
| 15:01:27 | *** GitHub142 has left #openmrs |
| 15:03:36 | *** dkayiwa_ has joined #openmrs |
| 15:06:19 | *** dkayiwa has quit IRC |
| 15:06:19 | *** dkayiwa_ is now known as dkayiwa |
| 15:06:27 | *** GitHub88 has joined #openmrs |
| 15:06:28 | <GitHub88> [openmrs-core] dkayiwa closed pull request #496: TRUNK-3283 - Add observation to an encounter: the field person can be overwritten, an... (master...master) http://git.io/NWXFxQ |
| 15:06:28 | *** GitHub88 has left #openmrs |
| 15:11:43 | *** AdaYeung_ is now known as AdaYeung |
| 15:27:36 | *** dkayiwa_ has joined #openmrs |
| 15:29:43 | *** dkayiwa has quit IRC |
| 15:29:43 | *** dkayiwa_ is now known as dkayiwa |
| 15:31:00 | <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-ONEPOINTTENX-78 has FAILED : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-78> |
| 16:09:26 | *** GitHub4 has joined #openmrs |
| 16:09:26 | <GitHub4> [openmrs-core] dkayiwa closed pull request #509: TRUNK-3283 Add observation to an encounter: the field person can be over... (master...TRUNK-3283) http://git.io/GU5Y_A |
| 16:09:26 | *** GitHub4 has left #openmrs |
| 16:13:13 | *** dkithmal has joined #openmrs |
| 16:19:50 | *** nhutuan has joined #openmrs |
| 16:20:35 | *** GitHub162 has joined #openmrs |
| 16:20:35 | <GitHub162> [openmrs-core] dkayiwa closed pull request #441: TRUNK-4032 locking mechanism for person_attribute_type (master...TRUNK-4032) http://git.io/UwAMxA |
| 16:20:35 | *** GitHub162 has left #openmrs |
| 16:21:45 | *** GitHub108 has joined #openmrs |
| 16:21:45 | <GitHub108> [openmrs-core] dkayiwa closed pull request #306: "After changes made" (master...T-3094) http://git.io/Aign5Q |
| 16:21:45 | *** GitHub108 has left #openmrs |
| 16:22:50 | *** GitHub21 has joined #openmrs |
| 16:22:50 | <GitHub21> [openmrs-core] dkayiwa closed pull request #291: TRUNK-3175 add javadoc to the ActiveListItem class (master...TRUNK-3175) http://git.io/XX71kA |
| 16:22:50 | *** GitHub21 has left #openmrs |
| 16:24:24 | *** dkithmal has quit IRC |
| 16:24:28 | *** GitHub109 has joined #openmrs |
| 16:24:28 | <GitHub109> [openmrs-core] dkayiwa closed pull request #285: trunk3010 : Redirect the use to findpatients page with a message 'There is no patient with id' (master...trunk3010_3) http://git.io/wHmEAQ |
| 16:24:28 | *** GitHub109 has left #openmrs |
| 16:24:57 | *** nhutuan has left #openmrs |
| 16:25:28 | *** dkithmal has joined #openmrs |
| 16:27:56 | *** dkithmal has quit IRC |
| 16:28:18 | *** dkithmal has joined #openmrs |
| 16:30:15 | *** sgithens has joined #openmrs |
| 16:32:04 | *** dkithmal has quit IRC |
| 16:32:30 | *** dkithmal has joined #openmrs |
| 16:40:17 | *** GitHub142 has joined #openmrs |
| 16:40:17 | <GitHub142> [openmrs-core] dkayiwa closed pull request #328: OPENMRS-40: The list of locales cache used in the footer and options form dropdown needs to be updated (master...master) http://git.io/qjv_0Q |
| 16:40:18 | *** GitHub142 has left #openmrs |
| 16:41:29 | *** GitHub80 has joined #openmrs |
| 16:41:29 | <GitHub80> [openmrs-core] dkayiwa closed pull request #414: TRUNK-4004 Module should be able to say it needs to start before ... (master...TRUNK-4004-simple) http://git.io/CMXRPQ |
| 16:41:29 | *** GitHub80 has left #openmrs |
| 16:43:00 | *** GitHub13 has joined #openmrs |
| 16:43:01 | <GitHub13> [openmrs-core] dkayiwa closed pull request #410: TRUNK-3876 (master...TRUNK-3876) http://git.io/fxwWbw |
| 16:43:01 | *** GitHub13 has left #openmrs |
| 16:43:36 | *** wluyima has quit IRC |
| 16:44:02 | *** GitHub28 has joined #openmrs |
| 16:44:02 | <GitHub28> [openmrs-core] dkayiwa closed pull request #405: TRUNK-4031 (master...TRUNK-4031) http://git.io/E2D6FQ |
| 16:44:02 | *** GitHub28 has left #openmrs |
| 16:46:07 | *** GitHub123 has joined #openmrs |
| 16:46:07 | <GitHub123> [openmrs-core] dkayiwa closed pull request #403: TRUNK 2119: Improve Crash Reporting (master...TRUNK-2119) http://git.io/2cqm4Q |
| 16:46:07 | *** GitHub123 has left #openmrs |
| 16:46:52 | *** GitHub144 has joined #openmrs |
| 16:46:52 | <GitHub144> [openmrs-core] dkayiwa closed pull request #400: TRUNK-3889. Pickup module resources from module api (master...TRUNK-3889) http://git.io/TBfqEA |
| 16:46:52 | *** GitHub144 has left #openmrs |
| 16:47:42 | *** harshadura_ has quit IRC |
| 16:48:50 | *** dkayiwa_ has joined #openmrs |
| 16:49:27 | *** GitHub196 has joined #openmrs |
| 16:49:27 | <GitHub196> [openmrs-core] dkayiwa closed pull request #399: Trunk 3499 (master...TRUNK-3499) http://git.io/0C0ACA |
| 16:49:27 | *** GitHub196 has left #openmrs |
| 16:50:51 | *** GitHub71 has joined #openmrs |
| 16:50:52 | <GitHub71> [openmrs-core] dkayiwa closed pull request #394: TRUNK-4029: Hibernate config in parent pom.xml is outdated (master...TRUNK-4029) http://git.io/YAZWJg |
| 16:50:52 | *** GitHub71 has left #openmrs |
| 16:51:41 | *** GitHub76 has joined #openmrs |
| 16:51:41 | <GitHub76> [openmrs-core] dkayiwa closed pull request #391: TRUNK-4030 (master...TRUNK-4030) http://git.io/ICTUvw |
| 16:51:41 | *** GitHub76 has left #openmrs |
| 16:51:48 | *** dkayiwa has quit IRC |
| 16:51:48 | *** dkayiwa_ is now known as dkayiwa |
| 17:00:47 | *** dkithmal has quit IRC |
| 17:01:24 | *** dkithmal has joined #openmrs |
| 17:03:37 | *** dkayiwa has quit IRC |
| 17:05:28 | <OpenMRSBot> Recent updates in the world of openmrsci: HFEUI-HFEUI-291 has FAILED (1 tests failed) : Dependant of APPUI-APPUI-298 <https://ci-stg.openmrs.org/browse/HFEUI-HFEUI-291> |
| 17:10:01 | *** dkayiwa has joined #openmrs |
| 17:12:16 | *** VaibhavAgarwal has joined #openmrs |
| 17:17:22 | *** dkayiwa_ has joined #openmrs |
| 17:20:34 | *** dkayiwa has quit IRC |
| 17:20:34 | *** dkayiwa_ is now known as dkayiwa |
| 17:21:05 | *** GitHub128 has joined #openmrs |
| 17:21:05 | <GitHub128> [openmrs-core] dkayiwa closed pull request #388: TRUNK-4031 Adding PatientIdentifierTypeLockedException (master...TRUNK-4031) http://git.io/Q1DTig |
| 17:21:05 | *** GitHub128 has left #openmrs |
| 17:21:49 | *** harshadura has joined #openmrs |
| 17:21:49 | *** ChanServ sets mode: +v harshadura |
| 17:22:05 | *** GitHub132 has joined #openmrs |
| 17:22:05 | <GitHub132> [openmrs-core] dkayiwa closed pull request #377: TRUNK-4005 don't show retired encountertypes on form edit admin page (master...TRUNK-4005) http://git.io/sEj8BQ |
| 17:22:06 | *** GitHub132 has left #openmrs |
| 17:22:52 | *** GitHub164 has joined #openmrs |
| 17:22:52 | <GitHub164> [openmrs-core] dkayiwa closed pull request #375: TRUNK-3986 (master...TRUNK-3986) http://git.io/suS39A |
| 17:22:53 | *** GitHub164 has left #openmrs |
| 17:23:17 | *** GitHub191 has joined #openmrs |
| 17:23:18 | <GitHub191> [openmrs-core] dkayiwa closed pull request #371: TRUNK-3623 (master...TRUNK-3623) http://git.io/PseHrA |
| 17:23:18 | *** GitHub191 has left #openmrs |
| 17:23:47 | *** GitHub47 has joined #openmrs |
| 17:23:48 | <GitHub47> [openmrs-core] dkayiwa closed pull request #370: TRUNK-3624 (master...TRUNK-3624) http://git.io/5UPjGQ |
| 17:23:48 | *** GitHub47 has left #openmrs |
| 17:24:18 | *** GitHub137 has joined #openmrs |
| 17:24:18 | <GitHub137> [openmrs-core] dkayiwa closed pull request #369: TRUNK-3621 (master...TRUNK-3621) http://git.io/902E0w |
| 17:24:18 | *** GitHub137 has left #openmrs |
| 17:25:06 | *** GitHub159 has joined #openmrs |
| 17:25:07 | <GitHub159> [openmrs-core] dkayiwa closed pull request #346: TRUNK-3383 HandlerUtil.getPreferredHandler(Class<H> handlerType, Class<T... (master...TRUNK-3383) http://git.io/KD2IOg |
| 17:25:07 | *** GitHub159 has left #openmrs |
| 17:25:53 | *** GitHub174 has joined #openmrs |
| 17:25:53 | <GitHub174> [openmrs-core] dkayiwa closed pull request #342: TRUNK-3903 Resolved and tested. (master...TRUNK-3903) http://git.io/6gu0ew |
| 17:25:53 | *** GitHub174 has left #openmrs |
| 17:26:58 | *** GitHub141 has joined #openmrs |
| 17:26:58 | <GitHub141> [openmrs-core] dkayiwa closed pull request #339: Complex Observations are not handled if it is inside Observation Group (master...rest_complex_obs_save) http://git.io/vidqlQ |
| 17:26:58 | *** GitHub141 has left #openmrs |
| 17:27:28 | *** GitHub110 has joined #openmrs |
| 17:27:28 | <GitHub110> [openmrs-core] dkayiwa closed pull request #335: Enabled deletion of an obs and all it's related information (master...TRUNK-3267) http://git.io/zen24Q |
| 17:27:28 | *** GitHub110 has left #openmrs |
| 17:28:36 | *** GitHub179 has joined #openmrs |
| 17:28:37 | <GitHub179> [openmrs-core] dkayiwa closed pull request #314: TRUNK-257 Add Feature to enable moving Encounter Data to a different pat... (master...TRUNK-257) http://git.io/3ZinHQ |
| 17:28:37 | *** GitHub179 has left #openmrs |
| 17:29:49 | *** GitHub186 has joined #openmrs |
| 17:29:50 | <GitHub186> [openmrs-core] dkayiwa closed pull request #294: TRUNK-3974 fix ConceptNumerix(concept) inncorrectly copies collecitions (master...TRUNK-3974) http://git.io/sIePTA |
| 17:29:50 | *** GitHub186 has left #openmrs |
| 17:31:21 | *** GitHub1 has joined #openmrs |
| 17:31:22 | <GitHub1> [openmrs-core] dkayiwa closed pull request #40: Trunk 3142 (master...TRUNK-3142) http://git.io/YibeOg |
| 17:31:22 | *** GitHub1 has left #openmrs |
| 17:36:17 | *** GitHub119 has joined #openmrs |
| 17:36:17 | <GitHub119> [openmrs-core] dkayiwa closed pull request #217: Cleaned up Context.java (master...master) http://git.io/Kp2nEQ |
| 17:36:17 | *** GitHub119 has left #openmrs |
| 17:38:35 | *** GitHub191 has joined #openmrs |
| 17:38:35 | <GitHub191> [openmrs-core] dkayiwa closed pull request #241: Validate field lengths of domain objects in management pages (master...TRUNK-2660) http://git.io/uKah6w |
| 17:38:35 | *** GitHub191 has left #openmrs |
| 17:39:55 | *** GitHub181 has joined #openmrs |
| 17:39:55 | <GitHub181> [openmrs-core] dkayiwa closed pull request #250: I added new file HibernateFormDAOTest and wrote the test case. (master...TRUNK-3195) http://git.io/ObTXjw |
| 17:39:55 | *** GitHub181 has left #openmrs |
| 17:40:30 | *** GitHub121 has joined #openmrs |
| 17:40:30 | <GitHub121> [openmrs-core] dkayiwa closed pull request #251: Fixing the cause for: failing unit test against 1.9.1:shouldFindUuidsOnConcepts(org.openmrs.module.sync.SyncORUR01HandlerTest) - SYNC-284 (master...SYNC-284) http://git.io/8wynNw |
| 17:40:30 | *** GitHub121 has left #openmrs |
| 17:43:08 | *** GitHub42 has joined #openmrs |
| 17:43:09 | <GitHub42> [openmrs-core] dkayiwa closed pull request #262: Fill javadoc for class org.openmrs.activelist.Problem (master...master) http://git.io/yGwJzw |
| 17:43:09 | *** GitHub42 has left #openmrs |
| 17:45:13 | *** GitHub115 has joined #openmrs |
| 17:45:13 | <GitHub115> [openmrs-core] dkayiwa closed pull request #273: TRUNK-3933: added list of fake security question to confuse the cracker (1.9.x...TRUNK-3933) http://git.io/2N3PXw |
| 17:45:13 | *** GitHub115 has left #openmrs |
| 17:46:00 | *** GitHub13 has joined #openmrs |
| 17:46:01 | <GitHub13> [openmrs-core] dkayiwa closed pull request #427: TRUNK-3902 (master...TRUNK-3902) http://git.io/O1wkqw |
| 17:46:01 | *** GitHub13 has left #openmrs |
| 17:47:24 | *** GitHub84 has joined #openmrs |
| 17:47:24 | <GitHub84> [openmrs-core] dkayiwa closed pull request #429: TRUNK-13: Move business logic for authentication into service layer (master...TRUNK-13) http://git.io/Mg1CFw |
| 17:47:24 | *** GitHub84 has left #openmrs |
| 17:48:25 | *** GitHub96 has joined #openmrs |
| 17:48:26 | <GitHub96> [openmrs-core] dkayiwa closed pull request #470: trynk-4170 (master...TRUNK-4170) https://github.com/openmrs/openmrs-core/pull/470 |
| 17:48:26 | *** GitHub96 has left #openmrs |
| 17:49:46 | *** GitHub18 has joined #openmrs |
| 17:49:47 | <GitHub18> [openmrs-core] dkayiwa closed pull request #418: TRUNK-4016: Service implementations should not be top-level beans (master...TRUNK-4016) http://git.io/Kf0PIw |
| 17:49:47 | *** GitHub18 has left #openmrs |
| 17:52:45 | *** GitHub24 has joined #openmrs |
| 17:52:45 | <GitHub24> [openmrs-core] dkayiwa closed pull request #171: Fix ugly error on patient screen when invalid birthday submitted - TRUNK-3721 (master...TRUNK-3721) http://git.io/2UmvYw |
| 17:52:45 | *** GitHub24 has left #openmrs |
| 17:54:33 | *** GitHub1 has joined #openmrs |
| 17:54:33 | <GitHub1> [openmrs-core] dkayiwa closed pull request #469: Create openMRS_core (master...patch-1) http://git.io/KiudaQ |
| 17:54:33 | *** GitHub1 has left #openmrs |
| 17:55:36 | *** GitHub153 has joined #openmrs |
| 17:55:36 | <GitHub153> [openmrs-core] dkayiwa closed pull request #504: TRUNK -3267 : Delete any related objects here before deleting the obs (master...TRUNK-3267) http://git.io/6AuPzQ |
| 17:55:36 | *** GitHub153 has left #openmrs |
| 18:12:01 | *** dkayiwa has quit IRC |
| 18:24:43 | *** harshadura has quit IRC |
| 18:26:40 | *** dkayiwa has joined #openmrs |
| 18:44:04 | *** dkithmal has quit IRC |
| 18:44:30 | *** dkayiwa_ has joined #openmrs |
| 18:45:08 | *** dkayiwa has quit IRC |
| 18:45:09 | *** dkayiwa_ is now known as dkayiwa |
| 18:45:55 | *** dkithmal has joined #openmrs |
| 18:49:55 | *** GitHub60 has joined #openmrs |
| 18:49:56 | <GitHub60> [openmrs-core] chelseakomlo closed pull request #533: Move code that sets Person auditable fields to AuditableInterceptor (master...refactor_person_save_handler) http://git.io/lqyDGw |
| 18:49:56 | *** GitHub60 has left #openmrs |
| 18:50:31 | *** GitHub20 has joined #openmrs |
| 18:50:31 | <GitHub20> [openmrs-core] chelseakomlo reopened pull request #533: Move code that sets Person auditable fields to AuditableInterceptor (master...refactor_person_save_handler) http://git.io/lqyDGw |
| 18:50:31 | *** GitHub20 has left #openmrs |
| 18:55:11 | *** wluyima has joined #openmrs |
| 18:55:26 | *** GitHub89 has joined #openmrs |
| 18:55:26 | <GitHub89> [openmrs-core] chelseakomlo closed pull request #533: Move code that sets Person auditable fields to AuditableInterceptor (master...refactor_person_save_handler) http://git.io/lqyDGw |
| 18:55:26 | *** GitHub89 has left #openmrs |
| 18:55:39 | *** GitHub123 has joined #openmrs |
| 18:55:40 | <GitHub123> [openmrs-core] chelseakomlo opened pull request #578: Move code that sets Person auditable fields to AuditableInterceptor (master...person_save_handler_changes) http://git.io/vQd8MA |
| 18:55:40 | *** GitHub123 has left #openmrs |
| 19:36:40 | *** dkithmal has quit IRC |
| 19:52:30 | <jkeiper_> dkayiwa is a busy beaver |
| 19:52:45 | <dkayiwa> jkeiper_: hahaahaha :) |
| 19:52:45 | <jkeiper_> click happy |
| 19:52:50 | <jkeiper_> ;-) |
| 20:00:43 | <downey> djazayeri1 & burke - ryates just got the keys to 2 new bamboo build vm's |
| 20:01:02 | *** djazayeri1 is now known as djazayeri |
| 20:01:03 | *** ChanServ sets mode: +o djazayeri |
| 20:02:16 | <k-joseph> dkayiwa: hi |
| 20:02:26 | <dkayiwa> k-joseph: hi |
| 20:02:53 | <k-joseph> dkayiwa: i haven't before written unit tests for databases which in this case is what we have in our dataset files, is there anything i should know about this before attempting to write one!!! |
| 20:03:19 | *** VaibhavAgarwal has quit IRC |
| 20:04:15 | <dkayiwa> k-joseph: we recently started doing unit tests for our changesets |
| 20:07:44 | <k-joseph> dkayiwa: that is but abit abit different from what i was having in mind, checking that out TRUNK-4052 |
| 20:13:20 | <cpower> Scrum time? |
| 20:13:28 | <cpower> !scrumon cpower |
| 20:13:28 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 20:14:13 | <cpower> Order: djazayeri , rafa , dkayiwa , wluyima |
| 20:15:36 | <djazayeri> Working on some reporting bugs |
| 20:15:40 | <djazayeri> No blockers. |
| 20:19:27 | <wluyima> ? |
| 20:20:10 | <wluyima> rafa: ? |
| 20:20:35 | <wluyima> dkayiwa: ? |
| 20:20:48 | <dkayiwa> Done some ticket administration |
| 20:20:49 | <dkayiwa> Reviewing, merging and closing pull requests |
| 20:20:49 | <dkayiwa> No Blockers |
| 20:20:56 | <wluyima> Wednesday: |
| 20:20:57 | <wluyima> - PM call |
| 20:20:59 | <wluyima> - design call |
| 20:21:00 | <wluyima> - code review |
| 20:21:02 | <wluyima> - TRUNK-4191 - Add service methods for fetching active orders and order history by order number for a patient |
| 20:21:03 | <wluyima> Thursday: |
| 20:21:05 | <wluyima> - developer call |
| 20:21:06 | <wluyima> - code review |
| 20:21:07 | <wluyima> - complete TRUNK-4191 - Add service methods for fetching active orders and order history by order number for a patient |
| 20:21:07 | <wluyima> Blockers: None |
| 20:27:17 | <cpower> rafa: how about you? |
| 20:38:12 | <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-ONEPOINTTENX-79 has FAILED : Updated by Rafal Korytkowski , RafaÅ Korytkowski, Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-79> |
| 20:58:18 | <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-ONEPOINTTENX-80 has FAILED (3 tests failed) : Manual build by RafaÅ Korytkowski <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-80> |
| 20:59:59 | *** k-joseph has quit IRC |
| 21:01:43 | *** robbyoconnor has quit IRC |
| 21:09:14 | *** dkayiwa has quit IRC |
| 21:10:53 | *** upul has joined #openmrs |
| 21:13:21 | *** GitHub173 has joined #openmrs |
| 21:13:21 | <GitHub173> [openmrs-core] rkorytkowski pushed 1 new commit to 1.10.x: http://git.io/oiLzfw |
| 21:13:21 | <GitHub173> openmrs-core/1.10.x 68d9064 Rafal Korytkowski: TRUNK-3644 Corrected getting OpenMRS version |
| 21:13:21 | *** GitHub173 has left #openmrs |
| 21:13:48 | <wluyima> hi djazayeri |
| 21:15:28 | *** dkayiwa has joined #openmrs |
| 21:18:41 | <djazayeri> hi wluyima |
| 21:18:50 | <djazayeri> I just replied to your email about startDate, if that's what you're asking |
| 21:18:58 | <djazayeri> It doesn't sound like it should be required, to me. |
| 21:19:09 | <djazayeri> wluyima: I don't know if burke has some odd use case where it wouldn't be. |
| 21:20:15 | <rafa> wluyima: does OpenmrsProfileExclusionFilterTest fail for you locally? |
| 21:20:35 | <rafa> wluyima: It works for me and i don't know what's the issue on CI... |
| 21:20:55 | <wluyima> rafa: i does fail for me locally |
| 21:21:20 | <rafa> wluyima: when running mvn clean install? |
| 21:21:53 | <wluyima> djazayeri: if it is nullable, then that poses a challenge, it means if i save an order with a null start date, it is considered inactive and how do you activate if orders are immutable? |
| 21:22:10 | <wluyima> rafa: yes |
| 21:22:19 | <rafa> wluyima: hmm |
| 21:22:22 | <djazayeri> wluyima: anyway, I agree that we should make it required. |
| 21:23:03 | <rafa> wluyima: could you check what's in openmrs\api\target\classes\openmrs.properties ? |
| 21:23:03 | <wluyima> rafa: djazayeri because it will bring in the issue of status, meaning an order needs to be manually start by someone which we don't want |
| 21:23:41 | <wluyima> rafa: openmrs.version.short=1.10.0.17c17f-SNAPSHOT |
| 21:24:00 | <rafa> wluyima: that seems correct |
| 21:24:35 | <rafa> wluyima: apparently I can't think clear that late |
| 21:24:42 | <rafa> wluyima: I'll have another look when I wake up |
| 21:25:15 | <wluyima> rafa: cool |
| 21:25:17 | <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-ONEPOINTTENX-81 has FAILED (1442 tests failed) : Updated by Rafal Korytkowski <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-81> |
| 21:25:44 | <wluyima> rafa: must be that you have a stale copy somewhere which CI and i dont |
| 21:37:41 | *** dkayiwa has quit IRC |
| 21:50:30 | <OpenMRSBot> Recent updates in the world of openmrsci: EMRAPI-EMRAPI-405 has FAILED (59 tests failed) : Dependant of REP-REP-177 <https://ci-stg.openmrs.org/browse/EMRAPI-EMRAPI-405> |
| 22:23:01 | *** cioan has quit IRC |
| 22:30:43 | *** wluyima has quit IRC |
| 22:46:43 | <OpenMRSBot> Recent updates in the world of openmrsci: RDD-RDD-325 has FAILED (3 tests failed) : Dependant of EMRAPI-EMRAPI-406 <https://ci-stg.openmrs.org/browse/RDD-RDD-325> |
| 22:51:14 | *** sgithens has quit IRC |
| 22:54:45 | <OpenMRSBot> Recent updates in the world of openmrsci: RDD-RDD-326 has FAILED (3 tests failed) : Dependant of REFMETA-REFMETA-240 <https://ci-stg.openmrs.org/browse/RDD-RDD-326> |
| 22:55:14 | *** ChrisOelmueller has left #openmrs |
| 23:00:47 | <OpenMRSBot> Recent updates in the world of openmrsci: HFEUI-HFEUI-292 has FAILED (1 tests failed) : Dependant of APPUI-APPUI-299 <https://ci-stg.openmrs.org/browse/HFEUI-HFEUI-292> |
| 23:26:07 | *** wluyima has joined #openmrs |
| 23:27:21 | <wluyima> hi djazayeri |
| 23:27:54 | <wluyima> djazayeri: i think getActiveOrders can take in an optional asOfDate, right? |
| 23:28:19 | <djazayeri> wluyima: yeah. what's the full signature? |
| 23:29:10 | <wluyima> OrderService.getActiveOrders(Patient, Class orderClass, CareSetting) |
| 23:29:18 | <wluyima> djazayeri: OrderService.getActiveOrders(Patient, Class orderClass, CareSetting) |
| 23:29:43 | <wluyima> djazayeri: and am suggesting to make it OrderService.getActiveOrders(Patient, Class orderClass, CareSetting, Date asOfDate) |
| 23:29:48 | <wluyima> djazayeri: or to over load it |
| 23:30:19 | <djazayeri> wluyima: let's start with just a single method for now (and yes, add the asOfDate) |
| 23:31:05 | <djazayeri> wluyima: make a ticket for, closer to release, reviewing and deciding which additional getOrders methods we want to cover the most common use cases |
| 23:54:59 | <OpenMRSBot> Recent updates in the world of openmrsci: REP-REP-178 has FAILED : Updated by Darius Jazayeri <https://ci-stg.openmrs.org/browse/REP-REP-178> |
| 23:56:01 | <djazayeri> ^^ I know about this, I accidentally pushed changes to the reporting module before the testutils library :-( |