| 00:14:51 | *** sgithens has quit IRC |
| 00:27:38 | *** sgithens has joined #openmrs |
| 00:44:33 | *** wluyima has quit IRC |
| 01:09:46 | *** cioan1 has quit IRC |
| 01:26:49 | *** harshadura__ has joined #openmrs |
| 01:27:13 | *** Mkop has quit IRC |
| 01:29:09 | *** harshadura has quit IRC |
| 01:29:41 | *** harshadura_ has quit IRC |
| 01:29:45 | *** harshadura has joined #openmrs |
| 01:29:45 | *** ChanServ sets mode: +v harshadura |
| 03:36:37 | *** bmanth60 has quit IRC |
| 05:02:34 | <OpenMRSBot> Recent updates in the world of openmrsci: JAVADOC-BRANCH19X-1 has FAILED : Manual build by Ryan Yates <https://ci-stg.openmrs.org/browse/JAVADOC-BRANCH19X-1> || REPUI-REPUI-418 has FAILED (1 tests failed) : Updated by Darius Jazayeri <https://ci-stg.openmrs.org/browse/REPUI-REPUI-418> || SON-OPENMRSCOREMASTER-115 has FAILED (234 tests failed) : Manual build by RafaÅ Korytkowski <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-115> || TRUNK-MASTER-268 has FAILED (1 tests failed) : Updated by RafaÅ Korytkowski <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-268> || NIGHTLY-TRUNK-1 has FAILED : Manual build by Ryan Yates <https://ci-stg.openmrs.org/browse/NIGHTLY-TRUNK-1> || HFEUI-HFEUI-279 has FAILED (1 tests failed) : Dependant of APPUI-APPUI-287 <https://ci-stg.openmrs.org/browse/HFEUI-HFEUI-279> || HFEUI-HFEUI-277 has FAILED (9 tests failed) : Dependant of UICM-UICOMMONS-316 <https://ci-stg.openmrs.org/browse/HFEUI-HFEUI-277> || EMRAPI-EMRAPI-393 has FAILED (1 tests failed) : Dependant of REP-REP-168 <https://ci-stg.openmrs.org/browse/EMRAPI-EMRAPI-393> || TRUNK-MASTER-261 has FAILED (235 tests failed) : Updated by dkayiwa <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-261> || REFMETA-REFMETA-229 has FAILED (2 tests failed) : Dependant of EMRAPI-EMRAPI-392 <https://ci-stg.openmrs.org/browse/REFMETA-REFMETA-229> || TRUNK-MASTER-260 has FAILED (234 tests failed) : Rebuilt 1 times <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-260> || TRUNK-ONEPOINTTENX-74 has FAILED (1429 tests failed) : Updated by dkayiwa <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-74> || REFAPP-OMODDISTRO-1623 has FAILED : Dependant of CA-CA-594 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1623> || HFEUI-HFEUI-272 has FAILED (9 tests failed) : Dependant of APPUI-APPUI-278 <https://ci-stg.openmrs.org/browse/HFEUI-HFEUI-272> || CA-CA-593 has FAILED (6 tests failed) : Dependant of EMRAPI-EMRAPI-391 <https://ci-stg.openmrs.org/browse/CA-CA-593> || RDD-RDD-306 has FAILED (3 tests failed) : Dependant of EMRAPI-EMRAPI-391 <https://ci-stg.openmrs.org/browse/RDD-RDD-306> || REFAPP-DEMO-98 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/REFAPP-DEMO-98> || TRUNK-ONEPOINTTENX-72 has FAILED : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-72> || TRUNK-ONEPOINTTENX-71 has FAILED : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-71> || TRUNK-ONEPOINTTENX-70 has FAILED : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-70> || REPUI-REPUI-407 has FAILED (2 tests failed) : Updated by Glauber Ramos <https://ci-stg.openmrs.org/browse/REPUI-REPUI-407> || REPUI-REPUI-406 has FAILED (2 tests failed) : Updated by Darius Jazayeri <https://ci-stg.openmrs.org/browse/REPUI-REPUI-406> || REPUI-REPUI-405 has FAILED (1 tests failed) : Updated by Darius Jazayeri <https://ci-stg.openmrs.org/browse/REPUI-REPUI-405> || REPUI-REPUI-404 has FAILED (1 tests failed) : Updated by Glauber Ramos <https://ci-stg.openmrs.org/browse/REPUI-REPUI-404> || TRUNK-ONEPOINTTENX-68 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-68> || TRUNK-ONEPOINTTENX-67 has FAILED (1 tests failed) : Updated by Rafal Korytkowski <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-67> || TRUNK-ONEPOINTTENX-66 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-66> || TRUNK-ONEPOINTTENX-65 has FAILED (2 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-65> || TRUNK-ONEPOINTTENX-64 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-64> || TRUNK-ONEPOINTTENX-63 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-63> |
| 05:02:43 | *** sgithens has quit IRC |
| 05:18:05 | *** sgithens has joined #openmrs |
| 07:59:36 | *** harshadura has quit IRC |
| 07:59:36 | *** harshadura__ has quit IRC |
| 08:02:29 | *** GitHub164 has joined #openmrs |
| 08:02:29 | <GitHub164> [openmrs-core] saikrishna17 opened pull request #556: Trunk-2280 added an alert box (master...Trunk-2280) http://git.io/t3mArw |
| 08:02:29 | *** GitHub164 has left #openmrs |
| 08:42:25 | *** GitHub26 has joined #openmrs |
| 08:42:25 | <GitHub26> [openmrs-core] vaibhav-hp opened pull request #557: TRUNK-4046 hide start visit button for dead patients (master...TRUNK-4046) http://git.io/fPKrWw |
| 08:42:25 | *** GitHub26 has left #openmrs |
| 08:45:48 | *** VaibhavAgarwal has joined #openmrs |
| 08:57:57 | *** VaibhavAgarwal has quit IRC |
| 09:34:12 | *** ayuk has joined #openmrs |
| 09:36:17 | <ayuk> have this prob when testing Openmrs 1.9.7,after installation,cannot login with installation credentials |
| 10:17:05 | <ayuk> can someone help with an idea how to solve this problem |
| 11:08:25 | *** ayuk has quit IRC |
| 13:20:27 | *** bmanth60 has joined #openmrs |
| 13:58:20 | *** VaibhavAgarwal has joined #openmrs |
| 14:04:55 | *** kushal_ has joined #openmrs |
| 14:47:33 | *** kushal_ has quit IRC |
| 15:09:05 | *** VaibhavAgarwal has quit IRC |
| 15:46:34 | *** sgithens has quit IRC |
| 16:14:10 | *** dkithmal has joined #openmrs |
| 16:59:04 | *** dkayiwa has joined #openmrs |
| 17:20:21 | *** harshadura has joined #openmrs |
| 17:20:22 | *** ChanServ sets mode: +v harshadura |
| 17:20:23 | *** harshadura_ has joined #openmrs |
| 17:25:09 | *** harshadura_ has quit IRC |
| 17:25:31 | *** harshadura has quit IRC |
| 17:33:33 | *** rday has joined #openmrs |
| 17:34:33 | <dkithmal> dkiyiwa:hi |
| 17:34:53 | <dkayiwa> dkithmal: hi |
| 17:36:20 | <dkithmal> dkayiwa: TRUNK-4146 comment in git gub little bit confiused me is that mean that unit test fail? |
| 17:37:33 | <dkayiwa> dkithmal: so the ticket start by stating that the problem with the method is that it does not return distinct records. correct? |
| 17:38:00 | <dkithmal> dkayiwa: yes |
| 17:38:01 | <dkayiwa> dkithmal: in other wards, it returns more than one instead of just one. correct? |
| 17:38:18 | <dkithmal> dkayiwa: yes |
| 17:38:50 | <dkayiwa> dkithmal: and am assuming that you are farmiliar with TDD. correct? |
| 17:40:13 | <dkithmal> dkayiwa: im not much farmiliar with TDD |
| 17:40:42 | <dkayiwa> dkithmal: ever read something like this? http://en.wikipedia.org/wiki/Test-driven_development |
| 17:40:44 | <OpenMRSBot> <http://ln-s.net/6YIP> (at en.wikipedia.org) |
| 17:42:32 | <dkithmal> dkithmal: NO but i can learn it |
| 17:43:09 | <dkithmal> dkayiwa: NO but i can learn it |
| 17:43:38 | <dkayiwa> dkithmal: so that means the method, before improvement, returns more than one drug of the same name (not distinct). correct? |
| 17:46:12 | <dkithmal> dkayiwa: yes befor it retrun drug multiple times if a drug has multiple names that match the search parameter |
| 17:48:02 | <dkayiwa> dkithmal: so in your unit test, before any fix, is the return number of records more than 1? |
| 17:50:57 | <dkithmal> dkayiwa: in my unit test i tryied to prove after my fix it retrun distinct drug only in this unit test i didnt consider about the befor fix |
| 17:52:31 | <dkayiwa> dkithmal: if in your unit test, you can not first ensure that the method returns more than 1 record, then you are not solving any problem as the ticket requirements |
| 17:53:23 | <dkayiwa> dkithmal: the ticket clearly states that the problem is not returning distinct drugs. So if you cannot prove so, then there is no problem that you are solving |
| 17:56:58 | <dkithmal> dkayiwa: but my unit test consider about the after my fix but i think it prove it after my fix it return distinct drugs only |
| 17:57:35 | <dkithmal> dkayiwa: do you think i didnt solve the bug or my unit test is wrong? |
| 17:57:41 | <dkayiwa> dkithmal: unit tests (TDD) first start by proving the problem, and then code is written to fix the problem |
| 17:58:02 | <dkayiwa> dkithmal: so if you cannot prove the problem in your unit test, then there is nothing you are solving |
| 17:58:44 | <dkayiwa> dkithmal: so in this case, if in your unit test you cannot problem that actually multiple drugs are returned, then you cannot claim to solve any problem |
| 17:59:00 | <dkayiwa> cannot problem = cannot prove |
| 17:59:21 | <dkayiwa> dkithmal: how can you claim to solve what you cannot reproduce???? |
| 18:08:12 | <dkithmal> dkayiwa: im sorry i will unassin the bug but i will try to add unit test to prove that because after my fix it retrun distinct drugs only |
| 18:09:10 | <dkayiwa> dkithmal: if you cannot prove the problem (that it returns multiple drugs), then you are not fixing anything |
| 18:11:31 | <dkithmal> dkayiwa: i will try to prove that |
| 18:11:38 | <dkayiwa> dkithmal: if you are not satisfied, just read that wiki page i gave you again :) |
| 18:12:29 | <dkithmal> dkayiwa: sure i will |
| 18:13:24 | <dkithmal> dkayiwa: thank you very much for the helping me |
| 18:13:58 | <dkayiwa> dkithmal: you are welcome. thanks too for your patience. but does what i have said above make sense to you? :) |
| 18:15:45 | <dkithmal> dkayiwa: yes and thank you so much for helping i will try to do that :) |
| 18:15:58 | <dkayiwa> dkithmal: thanks :) |
| 18:20:12 | *** SKC has joined #openmrs |
| 18:23:51 | *** SKC has quit IRC |
| 18:24:54 | *** SaiKrishna has joined #openmrs |
| 18:27:34 | *** SaiKrishna_ has joined #openmrs |
| 18:27:50 | *** SaiKrishna_ has quit IRC |
| 18:27:50 | *** SaiKrishna_ has joined #openmrs |
| 18:47:35 | *** SaiKrishna_ has quit IRC |
| 18:47:35 | *** SaiKrishna has quit IRC |
| 19:10:17 | *** dkithmal has quit IRC |
| 21:20:07 | *** rday has quit IRC |
| 21:20:37 | *** rday has joined #openmrs |
| 21:28:09 | *** robbyoconnor has quit IRC |
| 21:55:03 | *** robbyoconnor has joined #openmrs |
| 21:55:03 | *** ChanServ sets mode: +v robbyoconnor |
| 22:00:14 | *** bmanth60 has quit IRC |
| 22:46:16 | *** rday has quit IRC |
| 22:46:40 | *** rday has joined #openmrs |
| 23:11:17 | *** dkayiwa has quit IRC |