| 00:03:27 | *** yanosz has quit IRC |
| 00:04:45 | *** yanosz has joined #openmrs |
| 00:05:51 | *** VaibhavAgarwal has quit IRC |
| 00:10:50 | *** yanosz has quit IRC |
| 00:13:25 | *** bmanth60 has quit IRC |
| 00:31:22 | *** yanosz has joined #openmrs |
| 01:07:26 | *** howardf_ has quit IRC |
| 01:45:59 | <OpenMRSBot> Recent updates in the world of openmrsci: SON-REPORTING-105 has FAILED (8 tests failed) : Scheduled build <https://ci-stg.openmrs.org/browse/SON-REPORTING-105> |
| 02:09:59 | <OpenMRSBot> Recent updates in the world of openmrsci: SON-REPORTINGUI-100 has FAILED (1 tests failed) : Scheduled build <https://ci-stg.openmrs.org/browse/SON-REPORTINGUI-100> |
| 02:38:06 | <OpenMRSBot> Recent updates in the world of openmrsci: EMRAPI-EMRAPI-384 has FAILED (11 tests failed) : Dependant of PMM-PMM-57 <https://ci-stg.openmrs.org/browse/EMRAPI-EMRAPI-384> |
| 03:04:00 | *** harsz89 has joined #openmrs |
| 03:04:00 | *** ChanServ sets mode: +v harsz89 |
| 03:05:05 | *** yanokwa has joined #openmrs |
| 03:11:03 | *** bmanth60 has joined #openmrs |
| 03:15:26 | *** bmanth60 has quit IRC |
| 03:38:22 | <OpenMRSBot> Recent updates in the world of openmrsci: SON-OPENMRSCOREMASTER-112 has FAILED (233 tests failed) : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-112> |
| 03:43:32 | *** harsz89 has quit IRC |
| 04:10:38 | *** vinayv has joined #openmrs |
| 05:25:26 | *** LeeBreisacher has joined #openmrs |
| 05:25:59 | *** LeeBreisacher has left #openmrs |
| 05:40:00 | *** mshaikh has joined #openmrs |
| 05:40:55 | *** sandaru has joined #openmrs |
| 06:05:48 | *** upul has quit IRC |
| 07:02:06 | *** wluyima has joined #openmrs |
| 07:04:29 | *** sandaru has quit IRC |
| 07:10:57 | *** wluyima has quit IRC |
| 07:11:43 | *** sgithens has quit IRC |
| 07:19:37 | *** harshadura has joined #openmrs |
| 07:19:37 | *** ChanServ sets mode: +v harshadura |
| 07:23:21 | *** dkayiwa has joined #openmrs |
| 07:24:05 | *** harshadura has quit IRC |
| 07:26:27 | *** sgithens has joined #openmrs |
| 08:31:04 | *** GitHub165 has joined #openmrs |
| 08:31:04 | <GitHub165> [openmrs-core] dkayiwa pushed 1 new commit to 1.10.x: http://git.io/BgZeXQ |
| 08:31:04 | <GitHub165> openmrs-core/1.10.x 5a228e0 dkayiwa: Sonar blocker: obj could be null and is guaranteed to be dereferenced in... |
| 08:31:04 | *** GitHub165 has left #openmrs |
| 08:34:11 | *** mshaikh has quit IRC |
| 08:41:27 | <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-ONEPOINTTENX-48 has FAILED (1 tests failed) : Updated by dkayiwa <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-48> |
| 08:49:20 | *** mshaikh has joined #openmrs |
| 08:55:12 | *** GitHub92 has joined #openmrs |
| 08:55:12 | <GitHub92> [openmrs-core] dkayiwa pushed 1 new commit to 1.9.x: http://git.io/ykU7oQ |
| 08:55:12 | <GitHub92> openmrs-core/1.9.x 26d67b4 dkayiwa: Sonar blocker: obj could be null and is guaranteed to be dereferenced in... |
| 08:55:12 | *** GitHub92 has left #openmrs |
| 09:01:19 | *** GitHub128 has joined #openmrs |
| 09:01:19 | <GitHub128> [openmrs-core] dkayiwa pushed 1 new commit to 1.9.x: http://git.io/0midGw |
| 09:01:19 | <GitHub128> openmrs-core/1.9.x daec784 dkayiwa: Formatting the SourceMySqldiffFile.java |
| 09:01:19 | *** GitHub128 has left #openmrs |
| 09:17:23 | *** harshadura has joined #openmrs |
| 09:17:24 | *** ChanServ sets mode: +v harshadura |
| 09:17:29 | *** harshadura has quit IRC |
| 09:26:11 | *** GitHub118 has joined #openmrs |
| 09:26:12 | <GitHub118> [openmrs-core] dkayiwa pushed 1 new commit to master: http://git.io/Es4Ggg |
| 09:26:12 | <GitHub118> openmrs-core/master 5993bd4 dkayiwa: Adding unit test for: Sonar blocker: obj could be null and is guaranteed... |
| 09:26:12 | *** GitHub118 has left #openmrs |
| 10:17:12 | *** k-joseph has joined #openmrs |
| 10:18:38 | *** sgithens_ has joined #openmrs |
| 10:22:31 | *** sgithens has quit IRC |
| 10:47:43 | *** k-joseph has quit IRC |
| 10:48:23 | *** k-joseph has joined #openmrs |
| 10:49:58 | <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-MASTER-246 has FAILED (191 tests failed) : Updated by dkayiwa <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-246> |
| 10:51:43 | <k-joseph> dkayiwa: hi |
| 10:52:15 | <dkayiwa> k-joseph: hi |
| 10:53:37 | <k-joseph> dkayiwa: what are provider accounts? are they just the same as saying provider!!!! |
| 10:54:13 | <dkayiwa> k-joseph: which ticket |
| 10:54:43 | <k-joseph> !ticket TRUNK-4202 |
| 10:54:44 | <OpenMRSBot> k-joseph: [#TRUNK-4202] Convert Order.orderer to be a Provider - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-4202 |
| 10:55:19 | <k-joseph> dkayiwa: TRUNK-4202 |
| 10:58:16 | <dkayiwa> k-joseph: provider are accounts are those in the provider table |
| 10:58:48 | <k-joseph> dkayiwa: ok, thanks for clarifying that |
| 11:34:09 | <OpenMRSBot> Recent updates in the world of openmrsci: REPUI-REPUI-384 has FAILED (1 tests failed) : Dependant of APPUI-APPUI-269 <https://ci-stg.openmrs.org/browse/REPUI-REPUI-384> |
| 11:40:39 | *** k-joseph has quit IRC |
| 11:42:17 | *** k-joseph has joined #openmrs |
| 12:14:58 | *** mareias has joined #openmrs |
| 12:38:25 | <OpenMRSBot> Recent updates in the world of openmrsci: DIS-DIS-122 has FAILED (2 tests failed) : Dependant of PMM-PMM-60 <https://ci-stg.openmrs.org/browse/DIS-DIS-122> |
| 12:45:25 | *** vinayv has quit IRC |
| 12:47:24 | *** howardf_ has joined #openmrs |
| 12:48:34 | *** GitHub132 has joined #openmrs |
| 12:48:34 | <GitHub132> [openmrs-core] dkayiwa pushed 1 new commit to 1.10.x: http://git.io/R6ZKUA |
| 12:48:34 | <GitHub132> openmrs-core/1.10.x 7ab4014 dkayiwa: Setting order numbers in the api needs to be safe in a clustered... |
| 12:48:35 | *** GitHub132 has left #openmrs |
| 12:51:19 | <k-joseph> dkayiwa: hi |
| 12:51:24 | <dkayiwa> k-joseph: hi |
| 12:52:18 | <k-joseph> dkayiwa: do you mind if i again ask you some part am getting well in TRUNK-4202's description |
| 12:52:20 | <k-joseph> !!! |
| 12:52:21 | <OpenMRSBot> k-joseph: Error: "!!" is not a valid command. |
| 12:52:47 | <dkayiwa> k-joseph: ok |
| 12:53:03 | <k-joseph> dkayiwa: there is a the second part of the description that is abit confusing, it says |
| 12:53:09 | <k-joseph> dkayiwa: Migrate data in orders.orderer column to be provider_ids instead of user_ids |
| 12:54:20 | *** mshaikh has quit IRC |
| 12:55:05 | <k-joseph> dkayiwa: to which table does the "to be provider_ids instead of user_ids" refer to!!! |
| 12:55:26 | <dkayiwa> k-joseph: are you done with the other parts of that ticket? |
| 12:55:47 | <k-joseph> dkayiwa: yes am through with the first oart |
| 12:57:20 | <dkayiwa> k-joseph: requires making a liquibase changeset where for each existing user_id value in orderer, you change it to the corresponding provider_id |
| 12:59:14 | <k-joseph> dkayiwa: that sounds much better and undersatandable, thanks |
| 13:07:15 | *** sgithens_ has quit IRC |
| 13:10:18 | *** mareias has quit IRC |
| 13:12:50 | *** robbyoconnor has quit IRC |
| 13:12:51 | *** r0bby_ has joined #openmrs |
| 13:12:51 | *** ChanServ sets mode: +v r0bby_ |
| 13:17:18 | *** wluyima has joined #openmrs |
| 13:19:22 | *** bmanth60 has joined #openmrs |
| 13:29:56 | *** wluyima has quit IRC |
| 13:34:11 | *** wluyima has joined #openmrs |
| 13:37:39 | *** dkayiwa has quit IRC |
| 13:54:33 | *** Shangeetha has joined #openmrs |
| 13:59:32 | *** r0bby_ is now known as robbyoconnor |
| 14:04:08 | *** mshaikh has joined #openmrs |
| 14:05:43 | *** suranga___ is now known as suranga |
| 14:10:37 | <rafa> downey: Hey, I can't connect the audio bridge for openmrs university. It says a configuration error occurred, but no more details are given. |
| 14:14:20 | <downey> Hmm, my guess is the tubes are frozen at IU :-) |
| 14:14:24 | *** GitHub185 has joined #openmrs |
| 14:14:25 | <GitHub185> [openmrs-core] rkorytkowski opened pull request #511: TRUNK-4135 Modify DrugOrder.frequency and TRUNK-4052 Add a way to test liquibase changesets (1.10.x...TRUNK-4135) http://git.io/ayzEIg |
| 14:14:25 | *** GitHub185 has left #openmrs |
| 14:24:40 | *** dkayiwa has joined #openmrs |
| 14:28:44 | *** Mkop has joined #openmrs |
| 14:40:21 | *** dkayiwa has quit IRC |
| 14:40:34 | *** sgithens_ has joined #openmrs |
| 14:40:52 | *** mshaikh has left #openmrs |
| 14:43:04 | *** dkayiwa has joined #openmrs |
| 14:43:38 | *** wluyima_ has joined #openmrs |
| 14:43:55 | *** wluyima has quit IRC |
| 14:43:55 | *** wluyima_ is now known as wluyima |
| 14:48:54 | <OpenMRSBot> Recent updates in the world of openmrsci: RDD-RDD-296 has FAILED (3 tests failed) : Dependant of EMRAPI-EMRAPI-386 <https://ci-stg.openmrs.org/browse/RDD-RDD-296> |
| 14:54:02 | *** elliott_w has joined #openmrs |
| 14:54:03 | *** ChanServ sets mode: +o elliott_w |
| 15:05:38 | *** harsz89 has joined #openmrs |
| 15:05:38 | *** ChanServ sets mode: +v harsz89 |
| 15:06:58 | <OpenMRSBot> Recent updates in the world of openmrsci: EMRAPI-EMRAPI-374 has FAILED (59 tests failed) : Dependant of REP-REP-151 <https://ci-stg.openmrs.org/browse/EMRAPI-EMRAPI-374> |
| 15:13:02 | <cpower> Hello everyone, who's ready to scrum? |
| 15:13:21 | <cpower> !scrumon cpower |
| 15:13:21 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 15:13:58 | <cpower> Order: dkayiwa , rafa , wluyima , and anyone else wanting to join in on giving an update |
| 15:14:57 | *** dkithmal has joined #openmrs |
| 15:16:47 | <dkayiwa> Reviewed, merged and ported: Obs.getValueAsString(Locale locale) should localize name if Obs is valueCoded - TRUNK-4164 |
| 15:16:47 | <dkayiwa> Reviewed, made a followup commit, and back ported: Sonar blocker: obj could be null and is guaranteed to be dereferenced in org.openmrs.validator.UserValidator.validate - TRUNK-4199 |
| 15:16:47 | <rafa> Today: |
| 15:16:48 | <rafa> * Committed |
| 15:16:48 | <rafa> + TRUNK-4135 Modify DrugOrder.frequency |
| 15:16:48 | <rafa> https://tickets.openmrs.org/browse/TRUNK-4135 |
| 15:16:48 | <rafa> + TRUNK-4052 |
| 15:16:48 | <dkayiwa> Made a followup commit for: Setting order numbers in the api needs to be safe in a clustered environment - TRUNK-4183 |
| 15:16:48 | <cpower> come on don't be shy |
| 15:16:48 | <dkayiwa> Now working on: Add service methods for fetching active orders and order history by order number for a patient - TRUNK-4191 |
| 15:16:48 | <dkayiwa> No Blockers |
| 15:16:48 | <rafa> Add a way to test liquibase changesets |
| 15:16:48 | <rafa> https://tickets.openmrs.org/browse/TRUNK-4052 |
| 15:16:49 | <rafa> No blockers. |
| 15:17:02 | <cpower> wluyima: you are up |
| 15:17:10 | <cpower> sorry I have terrible lag again |
| 15:17:19 | <wluyima> Tuesday: |
| 15:17:19 | <rafa> dkayiwa: sorry for interrupting :) |
| 15:17:19 | <wluyima> - bi weekly call |
| 15:17:21 | <wluyima> - code reviews and merging code |
| 15:17:22 | <wluyima> - fix failing test in OrderServiceTest |
| 15:17:24 | <wluyima> Wednesay: |
| 15:17:25 | <wluyima> - reviewing and merging code |
| 15:17:27 | <wluyima> - design call |
| 15:17:28 | <wluyima> - Improve code for testing liquibase changesets as per review comment |
| 15:17:29 | <dkayiwa> rafa: i was slow :) |
| 15:17:29 | <wluyima> |
| 15:17:30 | <wluyima> Blockers: None |
| 15:18:14 | <cpower> Ok design call this afternoon! Project Management call today as well! It's a full day |
| 15:18:18 | <cpower> !scrumoff |
| 15:18:18 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:21:26 | *** mareias has joined #openmrs |
| 15:28:52 | *** dkithmal has quit IRC |
| 15:29:52 | *** dkithmal has joined #openmrs |
| 15:34:54 | *** mareias_ has joined #openmrs |
| 15:35:32 | *** mareias has quit IRC |
| 15:35:32 | *** mareias_ is now known as mareias |
| 15:40:53 | *** HoangVu has joined #openmrs |
| 15:41:23 | <HoangVu> hey everybody |
| 15:41:27 | <HoangVu> I need a help ~_~ |
| 15:43:37 | <Shangeetha> HoangVu: Hi |
| 15:43:52 | *** Shangeetha has quit IRC |
| 15:44:02 | <HoangVu> I got a fails at github >_< |
| 15:44:14 | <HoangVu> Failed to sync this branch |
| 15:44:43 | <HoangVu> Shangeetha can you help ? |
| 15:55:21 | *** dkithmal_ has joined #openmrs |
| 15:57:12 | *** dkithmal has quit IRC |
| 16:04:33 | *** dkithmal has joined #openmrs |
| 16:06:56 | *** dkithmal__ has joined #openmrs |
| 16:08:25 | *** dkithmal_ has quit IRC |
| 16:10:36 | *** dkithmal has quit IRC |
| 16:12:08 | *** GitHub103 has joined #openmrs |
| 16:12:09 | <GitHub103> [openmrs-core] dkithmal closed pull request #503: TRUNK-3919:Added changed_by and date_changed to the location and locatio... (master...TRUNK-3919) http://git.io/IytAmw |
| 16:12:09 | *** GitHub103 has left #openmrs |
| 16:15:14 | *** Ch3ck_ has joined #openmrs |
| 16:18:46 | *** dkithmal_ has joined #openmrs |
| 16:19:18 | *** GitHub39 has joined #openmrs |
| 16:19:19 | <GitHub39> [openmrs-core] dkithmal opened pull request #512: Trunk 3919 (master...TRUNK-3919) http://git.io/gCudRg |
| 16:19:19 | *** GitHub39 has left #openmrs |
| 16:21:23 | *** dkithmal__ has quit IRC |
| 16:22:51 | *** dkithmal__ has joined #openmrs |
| 16:25:22 | *** dkithmal_ has quit IRC |
| 16:25:29 | <harsz89> hi HoangVu |
| 16:25:36 | <harsz89> harsz89, whatz d matter? :) |
| 16:25:36 | <HoangVu> hi |
| 16:25:53 | <HoangVu> Failed to sync this branch |
| 16:26:00 | <harsz89> mhhhhh |
| 16:26:02 | <HoangVu> when i use github ~_~ |
| 16:26:06 | <harsz89> what u exactly do |
| 16:26:07 | <harsz89> ? |
| 16:26:22 | <harsz89> created a new branch and do some fix thr or |
| 16:26:34 | <HoangVu> do some fix in oppointment module |
| 16:26:42 | <harsz89> HoangVu, okey |
| 16:27:08 | <harsz89> i think you need to push d branch to ur remote |
| 16:27:35 | *** djazayeri has joined #openmrs |
| 16:27:36 | *** ChanServ sets mode: +o djazayeri |
| 16:27:50 | <HoangVu> ??? |
| 16:28:03 | <HoangVu> harsz89: can u explain more pls |
| 16:28:15 | <HoangVu> harsz89: i just a new user of it ~_~ |
| 16:28:19 | <harsz89> just execute git status |
| 16:28:26 | <harsz89> and see whatz on there :) |
| 16:28:39 | <HoangVu> already seen ~_~ |
| 16:29:53 | <harsz89> HoangVu, okey did you try |
| 16:30:04 | <HoangVu> here these information: Your branch is ahead of 'origin/master' by 1 commit' |
| 16:30:08 | <harsz89> git push origin yourbranchname |
| 16:30:14 | <harsz89> execute |
| 16:30:17 | <HoangVu> how ? |
| 16:30:22 | <harsz89> git branch -a |
| 16:30:33 | <harsz89> and see whatz your current branch |
| 16:30:37 | *** djazayeri has left #openmrs |
| 16:30:43 | *** djazayeri has joined #openmrs |
| 16:30:43 | *** ChanServ sets mode: +o djazayeri |
| 16:30:58 | *** mareias has quit IRC |
| 16:31:14 | <HoangVu> a green word is master |
| 16:31:31 | *** djazayeri has left #openmrs |
| 16:31:34 | *** djazayeri has joined #openmrs |
| 16:31:34 | *** ChanServ sets mode: +o djazayeri |
| 16:31:42 | <HoangVu> and 'remote/origin/HEAD -> origin/master' |
| 16:31:48 | <harsz89> mhhh |
| 16:31:52 | <HoangVu> what is my branch ? |
| 16:31:59 | <harsz89> you said that you have created a branch right? |
| 16:32:16 | <harsz89> HoangVu, yeas thatz wht um asking frm you |
| 16:32:42 | <HoangVu> so my branch is origin/master ? |
| 16:33:04 | <harsz89> HoangVu, seems like you didnt created a branch |
| 16:33:20 | <harsz89> so did you try to push it by executing |
| 16:33:27 | <harsz89> git push origin master |
| 16:33:27 | <harsz89> ? |
| 16:34:00 | <harsz89> did you fork and clone tht module to ur space or |
| 16:34:10 | <harsz89> directly clone from appointment module? |
| 16:34:12 | <HoangVu> yeah |
| 16:34:25 | <HoangVu> I clone that module to my space |
| 16:34:33 | <harsz89> in ur github and |
| 16:34:38 | <harsz89> then to ur space or |
| 16:34:45 | <harsz89> direct clone |
| 16:34:50 | <HoangVu> direct clone |
| 16:34:53 | <harsz89> oh |
| 16:35:23 | <harsz89> execute |
| 16:35:28 | <harsz89> git remote -v |
| 16:35:33 | <harsz89> and paste d output |
| 16:35:39 | *** dkithmal__ has quit IRC |
| 16:36:16 | <HoangVu> here |
| 16:36:32 | <HoangVu> i send to u my cmd command |
| 16:37:32 | <harsz89> this seems like not working |
| 16:37:36 | <harsz89> just paste |
| 16:37:40 | <harsz89> d lines |
| 16:37:41 | <harsz89> :) |
| 16:37:48 | <HoangVu> ??? |
| 16:37:55 | <harsz89> git remote -v |
| 16:38:02 | <harsz89> paste d output here |
| 16:38:07 | <harsz89> itz should be two lines |
| 16:38:34 | <HoangVu> ??? |
| 16:39:21 | <HoangVu> yeah |
| 16:39:25 | <HoangVu> it have two lines |
| 16:40:01 | <HoangVu> origin https://github.com/openmrs/openmrs-module-appointment.git (fetch) |
| 16:40:02 | <OpenMRSBot> <http://ln-s.net/+wdl> (at github.com) |
| 16:40:06 | <harsz89> okey |
| 16:40:08 | <HoangVu> origin https://github.com/openmrs/openmrs-module-appointment.git (push) |
| 16:40:15 | <harsz89> HoangVu, you first need to fork |
| 16:40:19 | <harsz89> it to your github |
| 16:40:23 | <HoangVu> how ? |
| 16:40:27 | <harsz89> in appointment module |
| 16:40:30 | <harsz89> you see |
| 16:40:45 | <harsz89> fork this button in right top |
| 16:40:53 | <HoangVu> yeah |
| 16:40:54 | <HoangVu> i see |
| 16:41:03 | <harsz89> then it fill fork to your github space |
| 16:41:20 | <harsz89> now what you have done is you directly clone it from openmrs |
| 16:41:36 | <harsz89> but u dont hv priviledges to do modifications |
| 16:41:43 | <harsz89> so you need to fork it first |
| 16:41:48 | <harsz89> then create a branch |
| 16:41:51 | <harsz89> work on a fix |
| 16:41:54 | <harsz89> then push it |
| 16:42:03 | <harsz89> then u can do a pull request |
| 16:42:14 | <HoangVu> now first |
| 16:42:15 | <harsz89> :) |
| 16:42:23 | <HoangVu> I click on Fork button |
| 16:42:34 | <HoangVu> after that |
| 16:42:45 | <HoangVu> I clone it |
| 16:45:11 | *** Ch3ck_ has quit IRC |
| 16:49:05 | *** Ch3ck_ has joined #openmrs |
| 16:49:53 | <HoangVu> harsz89: are u here ? |
| 16:50:04 | <harsz89> HoangVu, okey |
| 16:50:15 | <harsz89> HoangVu, now created a branch for ur fix |
| 16:50:16 | <harsz89> :) |
| 16:50:22 | <HoangVu> ok |
| 16:50:23 | <harsz89> branch may be ticket number |
| 16:50:30 | <HoangVu> ~_~ |
| 16:50:31 | <HoangVu> sr |
| 16:50:42 | <HoangVu> I create another name _~ |
| 16:51:10 | <HoangVu> but I saw that in the raw module link |
| 16:51:16 | <HoangVu> there nothing change |
| 16:51:24 | <HoangVu> there wait for master check ? |
| 16:53:04 | <HoangVu> and then when master submit |
| 16:53:17 | <HoangVu> he will merge my code to that module ? |
| 16:53:23 | <HoangVu> is that right ? |
| 16:54:54 | <harsz89> HoangVu, mhhh |
| 16:55:05 | <harsz89> okey now did u create a branch |
| 16:55:06 | <harsz89> ? |
| 16:55:10 | <HoangVu> yeah |
| 16:55:14 | <harsz89> okey |
| 16:55:26 | <harsz89> so do the fix thr and push that to ur space |
| 16:55:36 | <HoangVu> ok |
| 16:55:41 | <HoangVu> already done |
| 16:55:54 | <harsz89> pull request is the way to give ur changes to d place whr u originally clone |
| 16:56:07 | <harsz89> it can be done through github ui |
| 16:56:12 | <harsz89> go to ur branch and |
| 16:56:24 | <harsz89> u see a option to open a pull request |
| 16:56:27 | <harsz89> :) |
| 16:56:45 | <harsz89> right hand side you will see that option |
| 16:56:46 | <harsz89> :) |
| 16:57:17 | *** davidpardz has joined #openmrs |
| 16:57:17 | *** ChanServ sets mode: +v davidpardz |
| 16:57:29 | *** Ckomlo has joined #openmrs |
| 16:59:27 | <HoangVu> https://github.com/openmrs/openmrs-module-appointment/pull/3 |
| 16:59:30 | <HoangVu> is this right ? |
| 17:00:22 | <harsz89> mhh |
| 17:00:50 | <harsz89> https://github.com/openmrs/openmrs-module-appointment/pull/3/files |
| 17:00:52 | <harsz89> here |
| 17:00:59 | <harsz89> is this shows ur changes |
| 17:01:04 | <harsz89> thn thtz it :) |
| 17:02:32 | <HoangVu> yeah |
| 17:02:36 | <HoangVu> there is it |
| 17:02:57 | <harsz89> cool :) |
| 17:03:09 | <HoangVu> so is that ok :)))) |
| 17:03:26 | <harsz89> yeap |
| 17:03:35 | <harsz89> some one need to review it and commit |
| 17:03:38 | <harsz89> :) |
| 17:03:55 | <HoangVu> ok |
| 17:03:57 | <harsz89> mention that you done a pull request in d ticket |
| 17:03:58 | <harsz89> :) |
| 17:03:59 | <HoangVu> I know it :) |
| 17:04:03 | <harsz89> and ask to review it |
| 17:04:04 | <harsz89> :) |
| 17:04:19 | <harsz89> and change d status of the jira ricket to send to code review |
| 17:04:21 | <harsz89> :) |
| 17:04:42 | <HoangVu> Code Review (Post-Commit) |
| 17:04:47 | <HoangVu> already done ) |
| 17:04:50 | <HoangVu> already done :) |
| 17:04:54 | <harsz89> good :) |
| 17:05:08 | <HoangVu> ok :)))) |
| 17:05:21 | <HoangVu> now I get more familiar with this ~_~ |
| 17:05:56 | <harsz89> :) |
| 17:06:04 | <harsz89> whn u doing more |
| 17:06:11 | <harsz89> more you will understand :) |
| 17:06:20 | <harsz89> now you know d procedure :) |
| 17:06:37 | <HoangVu> :) |
| 17:06:45 | <HoangVu> I will =))) |
| 17:07:26 | <HoangVu> ok now I have to go sleep. At my country there is midnight >_< |
| 17:07:44 | <harsz89> okey :D |
| 17:07:50 | *** HoangVu has quit IRC |
| 17:07:53 | <harsz89> hav a good night then :) |
| 17:09:20 | *** ChanServ sets mode: +o burke |
| 17:44:56 | <djazayeri> burke: hey, I recall you keep saying something about line breaks, and setting them in git |
| 17:45:04 | <djazayeri> burke: have a quick pointer or a googleable phrase for this? |
| 17:59:59 | *** Ckomlo has quit IRC |
| 18:06:18 | *** Ch3ck_ has quit IRC |
| 18:11:29 | *** Ch3ck_ has joined #openmrs |
| 18:18:40 | *** Ch3ck_ has quit IRC |
| 18:22:46 | *** VaibhavAgarwal has joined #openmrs |
| 18:45:50 | *** dkayiwa has quit IRC |
| 18:47:33 | *** Ch3ck has quit IRC |
| 18:49:33 | <burke> djazayeri: I have an over-year-old thread in my email where I started working on this. I should get it into a blog or wiki page. |
| 18:50:01 | <djazayeri> burke: okay. It came up on the appointment scheduling module between mark and mario today |
| 18:50:10 | <djazayeri> (neither of them are on this IRC I see) |
| 18:50:33 | <burke> djazayeri: there's a utility called dos2unix that can help with conversion. the .gitattributes should have "* text=auto". I have a longer list of things that can be forced to be text or binary by extension. |
| 18:51:16 | *** dkayiwa has joined #openmrs |
| 18:51:31 | <burke> djazayeri: I was planning on tackling line endings in the same pass as updating the license headers. still (slowly) working through that. |
| 18:52:10 | <djazayeri> burke: but particularly, adding a .gitattributes file to the root of the project (with "* text=auto") should help things? |
| 18:53:32 | <burke> yes. "* text=auto" will tell git to convert to linux-style line endings in the repo while using client-specific line endings for editing client side. |
| 18:54:37 | <burke> e.g., it should store \n in the repo and then express the file as \n or \r\n for *nix and windoze users, respectively. |
| 19:13:15 | *** harsz89 has quit IRC |
| 19:33:16 | *** GitHub115 has joined #openmrs |
| 19:33:16 | <GitHub115> [openmrs-core] k-joseph opened pull request #513: TRUNK-4202 Convert Order.orderer to be a Provider (1.10.x...TRUNK-4202) http://git.io/MdF55A |
| 19:33:16 | *** GitHub115 has left #openmrs |
| 19:46:30 | <k-joseph> dkayiwa: TRUNK-4202 is now ready for review, please check it if you can get some time!!! |
| 20:09:31 | <jkeiper> does anyone know where to find an example of using the DrugEditor in a controller + JSP? All I get is org.openmrs.Drug@2, etc when I use it |
| 20:11:35 | <dkayiwa> jkeiper: did you look at? ObsFormController |
| 20:16:34 | <jkeiper> dkayiwa: ah, i'll look at that! |
| 20:28:32 | <jkeiper> dkayiwa: what i hope is to actually pick more than one drug for this object ... |
| 20:29:10 | <dkayiwa> jkeiper: is the command object having a List<Drug> |
| 20:29:16 | <jkeiper> dkayiwa: looking for a way to make a multi select ... yes. |
| 20:30:39 | <jkeiper> dkayiwa: think i might need some magic from the concept edit form |
| 20:30:51 | <dkayiwa> jkeiper: oh yes :) |
| 21:01:38 | *** k-joseph has quit IRC |
| 21:08:27 | *** GitHub45 has joined #openmrs |
| 21:08:27 | <GitHub45> [openmrs-core] wluyima pushed 1 new commit to 1.10.x: http://git.io/YPFvQw |
| 21:08:27 | <GitHub45> openmrs-core/1.10.x 3863412 Vinay Venu: Add careSetting property to Order class - TRUNK-4156... |
| 21:08:27 | *** GitHub45 has left #openmrs |
| 21:12:45 | *** GitHub178 has joined #openmrs |
| 21:12:46 | <GitHub178> [openmrs-core] wluyima closed pull request #501: Trunk 4156 redesigned (1.10.x...TRUNK-4156-redesigned) http://git.io/BR7W5A |
| 21:12:46 | *** GitHub178 has left #openmrs |
| 21:15:27 | *** k-joseph has joined #openmrs |
| 21:18:27 | <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-ONEPOINTTENX-50 has FAILED (1 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-50> |
| 21:24:27 | *** sgithens_ has quit IRC |
| 21:26:59 | *** ddesimone has joined #openmrs |
| 21:36:35 | *** VaibhavAgarwal has quit IRC |
| 22:20:57 | *** howardf_ has quit IRC |
| 22:42:30 | *** howardf_ has joined #openmrs |
| 22:55:30 | *** wluyima has quit IRC |
| 23:21:21 | *** wluyima has joined #openmrs |
| 23:38:57 | *** k-joseph has quit IRC |
| 23:38:59 | *** Shangeetha has joined #openmrs |
| 23:39:12 | <Shangeetha> dkayiwa: Hi |
| 23:39:21 | <dkayiwa> Shangeetha: hi |
| 23:39:46 | <Shangeetha> dkayiwa: We need your idea |
| 23:40:17 | <Shangeetha> dkayiwa: We have radiology tab attached to standard patient dashboard view |
| 23:40:53 | <Shangeetha> dkayiwa: But HISPIndia uses separate patient dashboard view via patient dashboard module |
| 23:41:27 | <Shangeetha> dkayiwa: We want to synchronize both patient dashboard views to one patient dashboard view |
| 23:41:41 | <Shangeetha> dkayiwa: How can we do that? Thanks :) |
| 23:42:13 | <dkayiwa> Shangeetha: have your forked both modules? |
| 23:42:20 | <dkayiwa> Shangeetha: have you? |
| 23:44:48 | <Shangeetha> dkayiwa: This is hispindia module to get different patient dashboard view, https://github.com/hispindia/patient-dashboard |
| 23:45:49 | <Shangeetha> dkayiwa: This is the radiology module we are using, https://github.com/Shangeetha12/radiology, where radiology tab is attached to standard openmrs patient dashboard view |
| 23:46:16 | <dkayiwa> Shangeetha: if you are going to make changes to the modules, you need to start by forking them |
| 23:47:13 | <Shangeetha> dkayiwa: Yeah but i failed forking, and what i did was i cloned from hispindia site and using IntelliJ i did changes to code and again did maven built |
| 23:47:47 | <dkayiwa> Shangeetha: how did you do the forking which failed? |
| 23:49:35 | <Shangeetha> dkayiwa: This is where radiology tab of the module comes, pasted here http://snag.gy/VmsqD.jpg |
| 23:50:00 | <Shangeetha> dkayiwa: This is the patient dashboard module's view http://snag.gy/Wdurz.jpg |
| 23:50:06 | <dkayiwa> Shangeetha: are you trying to answer my question? |
| 23:50:34 | <Shangeetha> dkayiwa: Yeah forking i did by going to folder of a particular module |
| 23:50:56 | <Shangeetha> dkayiwa: then, give me some time, i will give you exact command i gave |
| 23:51:17 | <dkayiwa> Shangeetha: and also a link of where you got those forking instructions |
| 23:53:50 | <Shangeetha> dkayiwa: https://help.github.com/articles/fork-a-repo is the link |
| 23:59:33 | <Shangeetha> dkayiwa: the order i used was git clone https://github.com/hispindia/patient-dashboard, cd patient-dashboard, |
| 23:59:51 | <Shangeetha> dkayiwa: git remote add upstream https://github.com/hispindia/patient-dashboard |
