| 00:44:22 | *** harsha89 has joined #openmrs |
| 00:45:42 | *** harsz89 has quit IRC |
| 01:00:07 | *** dkithmal has joined #openmrs |
| 01:06:59 | *** harshadura has joined #openmrs |
| 01:07:00 | *** ChanServ sets mode: +v harshadura |
| 02:43:40 | *** mareias has joined #openmrs |
| 02:54:02 | *** mareias has quit IRC |
| 02:55:51 | *** Shangeetha has joined #openmrs |
| 02:56:16 | <Shangeetha> harsz89: Hi |
| 02:56:32 | *** mareias has joined #openmrs |
| 02:57:22 | <harsha89> Shangeetha, HI |
| 02:57:59 | <Shangeetha> harsz89: Here i have pasted an error in http://snag.gy/6pc5M.jpg |
| 02:58:37 | <Shangeetha> harsz89: Module built successfully. After loading the module only, this error came, what might have gone wrong? |
| 03:02:57 | <harsha89> mhhhh |
| 03:04:01 | <harsha89> Shangeetha, smething wring with |
| 03:04:07 | <Shangeetha> harsha89: yeah |
| 03:04:08 | <harsha89> module application context |
| 03:05:28 | <Shangeetha> harsha89: xmlns:p="http://www.springframework.org/schema/p" this line is in red |
| 03:05:42 | <Shangeetha> harsha89: In moduleapplicationcontext.xm |
| 03:05:47 | <harsha89> Shangeetha, mhh |
| 03:06:00 | <harsha89> can you check with some other module application context |
| 03:06:08 | <harsha89> u can easily find whtz went wrong |
| 03:06:08 | <harsha89> :) |
| 03:06:28 | <harsha89> seems like itz a small change which need to be fix |
| 03:07:22 | <Shangeetha> harsha89: Ok sure thanks :) |
| 03:11:45 | <harsha89> Shangeetha, :) |
| 03:11:51 | *** harsha89 is now known as harsz89 |
| 03:23:01 | *** djazayeri has joined #openmrs |
| 03:23:01 | *** ChanServ sets mode: +o djazayeri |
| 03:31:35 | <Shangeetha> harsz89: Hi |
| 03:31:45 | <harsz89> Shangeetha, yes |
| 03:31:53 | <Shangeetha> harsz89: xmlns:p="http://www.springframework.org/schema/p" |
| 03:32:23 | <Shangeetha> harsz89: what this tag is for? |
| 03:32:47 | <harsz89> Shangeetha, those are schemas |
| 03:33:06 | <harsz89> Shangeetha, is tht still in red |
| 03:33:07 | <harsz89> ? |
| 03:33:17 | <Shangeetha> harsz89: That tag fails because The requested URL /schema/p" was not found on this server. |
| 03:33:41 | <Shangeetha> harsz89: Yeah it is in red, saying URI is not registered |
| 03:33:55 | <harsz89> Shangeetha, pastebin ur module application context |
| 03:34:13 | <harsz89> Shangeetha, or do a google |
| 03:34:23 | <harsz89> it will give u correct one |
| 03:34:25 | <harsz89> :) |
| 03:35:22 | <Shangeetha> harsz:Ok sure :) |
| 04:08:33 | *** Shangeetha has quit IRC |
| 04:09:37 | *** mareias has quit IRC |
| 04:35:39 | *** harsha89 has joined #openmrs |
| 04:35:41 | *** dkithmal_ has joined #openmrs |
| 04:38:12 | *** dkithmal has quit IRC |
| 04:38:46 | *** harsz89 has quit IRC |
| 04:56:17 | *** robbyoconnor has quit IRC |
| 05:01:26 | *** robbyoconnor has joined #openmrs |
| 05:01:27 | *** ChanServ sets mode: +v robbyoconnor |
| 06:47:07 | *** dkayiwa has joined #openmrs |
| 06:49:33 | *** djazayeri has quit IRC |
| 07:04:06 | *** davidpardz has left #openmrs |
| 07:39:48 | <dkithmal_> dkayiwa: hi |
| 07:39:54 | <dkayiwa> dkithmal_: hi |
| 07:40:08 | <dkithmal_> dkayiwa:i added comment on your question in TRUNK-4145 in couple of days ago in git hub |
| 07:40:21 | <dkithmal_> dkayiwa: please when you get free time please check it and tell me where to improve |
| 07:41:55 | <dkayiwa> !ticket TRUNK-4145 |
| 07:41:56 | <OpenMRSBot> dkayiwa: [#TRUNK-4145] HibernateConceptDAO.getDrugs(String drugName, Concept concept, boolean searchOnPhrase, boolean searchDrugConceptNames, boolean includeRetired, Integer start, Integer length) should return distinct drugs - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-4145 |
| 07:43:43 | <dkithmal_> dkayiwa: yes TRUNK-4145 i added unit test also to that bug if need another unit test i will include more |
| 07:46:16 | <dkayiwa> dkithmal_: hi |
| 07:46:26 | <dkithmal_> dkayiwa: hi |
| 07:46:52 | <dkayiwa> dkithmal_: so where did you put the searchCriteria.add(Restrictions.eq("drug.concept", concept)); |
| 07:48:41 | <dkithmal_> dkayiwa: i think do not need drug_concept ristriction because drug name search can be in either durg_name or concept name |
| 07:50:18 | <dkayiwa> dkithmal_: what happens when you leave it as it was? |
| 07:53:05 | <dkayiwa> dkithmal_: does it stop working correctly? |
| 07:56:31 | *** harshadura has quit IRC |
| 07:56:43 | *** harsha89 has quit IRC |
| 07:56:59 | *** dkithmal_ has quit IRC |
| 08:01:05 | *** dkithmal has joined #openmrs |
| 08:01:20 | <dkithmal> dkayiwa: hi |
| 08:01:58 | <dkayiwa> dkithmal: hi |
| 08:02:02 | <dkithmal> dyaiwa: then it retrun only both concept_name and drug_name maching drugs only in TRUNK4146 says it need to retrun either drug_name matching or concept_name matching drugs need to return |
| 08:02:23 | <dkayiwa> dkithmal: so would any unit test fail? |
| 08:02:31 | *** harsha89 has joined #openmrs |
| 08:03:02 | <dkithmal> dkayiwa: no i added 5 unit test and all passed |
| 08:03:35 | <dkayiwa> dkithmal: so if you left that concept criteria line as it was, would any unit test fail? |
| 08:08:23 | <dkithmal> dkayiwa: give me minit i will check |
| 08:19:33 | <dkithmal> dkwyiwa: yes unit test fail |
| 08:19:43 | <dkayiwa> dkithmal: which one? |
| 08:21:39 | <dkithmal> dkwyiwa: getDrugs_shouldReturnDrugIf_eitherDrugNameOrConceptNameMatchesThePhaseNotBoth() |
| 08:22:17 | <dkayiwa> dkithmal: include my name whenever you type |
| 08:22:53 | <dkithmal> dkayiwa: im sry miss spell |
| 08:23:50 | <dkayiwa> dkithmal: is that a new unit test you have just added or an existsing one? |
| 08:24:16 | <dkithmal> dkayiwa: its in my pull request not new one |
| 08:24:31 | <dkayiwa> dkithmal: ok |
| 08:25:00 | <dkayiwa> dkithmal: can you add this comment on the ticket, and then make the ticket ready for code review? |
| 08:26:27 | <dkithmal> dkayiwa: sure i will add |
| 08:37:42 | *** GitHub98 has joined #openmrs |
| 08:37:43 | <GitHub98> [openmrs-core] dkayiwa closed pull request #494: TRUNK-4145: change and restrictions to or restrictions and retun distinc... (master...TRUNK-4145) http://git.io/93xZbA |
| 08:37:43 | *** GitHub98 has left #openmrs |
| 08:37:44 | *** GitHub90 has joined #openmrs |
| 08:37:45 | <GitHub90> [openmrs-core] dkayiwa pushed 4 new commits to master: http://git.io/ZuLvwA |
| 08:37:45 | <GitHub90> openmrs-core/master 2bbd26a damitha kithmal: TRUNK-4145: change and restrictions to or restrictions and retun distinct tuples |
| 08:37:45 | <GitHub90> openmrs-core/master ca627b5 damitha kithmal: TRUNK-4145: remove drug.concept restriction and add some unit tests |
| 08:37:45 | <GitHub90> openmrs-core/master 04f8aa7 damitha kithmal: TRUNK-4145: verify unit test with maven clean install and create unit test with conventions |
| 08:37:45 | *** GitHub90 has left #openmrs |
| 08:38:41 | <dkayiwa> dkithmal: just merged it. thanks :) |
| 08:40:17 | <dkithmal> dkayiwa: you welcome dkayiwa,and thank you very much for helping me |
| 08:41:19 | <dkayiwa> dkithmal: thank you more for writing code to save lives :) |
| 08:42:24 | <dkithmal> dkayiwa: you welcome i like a lot to contribute to openmrs :) |
| 08:42:54 | <dkayiwa> dkithmal: please keep up the great wonderful work!!! :) |
| 08:43:27 | <dkithmal> dkayiwa: sure i will :) |
| 08:43:28 | <OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-MASTER-241 has FAILED (1 tests failed) : Updated by Kithmal H.M.D, dkayiwa <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-241> |
| 08:43:44 | <dkayiwa> dkithmal: thanks man!!! :) |
| 08:44:53 | <OpenMRSBot> Recent updates in the world of openmrsci: SON-OPENMRSCOREMASTER-100 has FAILED (4 tests failed) : Manual build by RafaÅ Korytkowski <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-100> |
| 08:47:28 | *** travis-ci has joined #openmrs |
| 08:47:28 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [351620d] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/16403840 |
| 08:47:28 | *** travis-ci has left #openmrs |
| 09:13:07 | *** enthu has joined #openmrs |
| 10:00:57 | *** sgithens_ has quit IRC |
| 10:28:26 | *** dkithmal has quit IRC |
| 10:40:29 | *** enthu has quit IRC |
| 10:45:44 | *** dkithmal has joined #openmrs |
| 11:25:52 | *** enthu has joined #openmrs |
| 11:35:38 | *** dkayiwa has quit IRC |
| 11:38:39 | *** harsha89 has quit IRC |
| 12:29:58 | *** dkayiwa has joined #openmrs |
| 12:41:41 | *** harshadura has joined #openmrs |
| 12:41:41 | *** ChanServ sets mode: +v harshadura |
| 12:44:21 | *** dkayiwa has quit IRC |
| 12:54:45 | *** enthu has quit IRC |
| 13:14:31 | *** madawa_rc has joined #openmrs |
| 13:25:21 | <madawa_rc> hello |
| 13:25:39 | *** madawa_rc has quit IRC |
| 13:31:23 | *** akwatuha____ has quit IRC |
| 13:31:23 | *** jt48 has quit IRC |
| 13:31:23 | *** ryates has quit IRC |
| 13:31:23 | *** burke has quit IRC |
| 13:32:09 | *** jt48 has joined #openmrs |
| 13:32:43 | *** ryates has joined #openmrs |
| 13:32:43 | *** ChanServ sets mode: +o ryates |
| 13:33:03 | *** akwatuha____ has joined #openmrs |
| 13:33:36 | *** burke has joined #openmrs |
| 13:44:04 | *** GitHub92 has joined #openmrs |
| 13:44:04 | <GitHub92> [openmrs-core] sachethgupta opened pull request #504: TRUNK -3267 : Delete any related objects here before deleting the obs (master...TRUNK-3267) http://git.io/6AuPzQ |
| 13:44:04 | *** GitHub92 has left #openmrs |
| 14:07:31 | *** khayam has joined #openmrs |
| 14:08:50 | *** dkayiwa has joined #openmrs |
| 14:10:09 | <khayam> dkayiwa: Hi |
| 14:16:14 | <khayam> dkayiwa: (Add delete/purge for program states in the workflow ) Trunk-3087 can I assigned to myself? |
| 14:26:48 | *** aniketha has joined #openmrs |
| 15:42:41 | *** harshadura has quit IRC |
| 16:00:51 | *** OpenMRSBot has joined #openmrs |
| 16:00:51 | *** ChanServ sets mode: +o OpenMRSBot |
| 16:04:26 | <khayam> dkayiwa: Is that same ticket? |
| 16:08:29 | *** Shangeetha has joined #openmrs |
| 16:08:39 | *** harsha89 has joined #openmrs |
| 16:09:32 | *** dkithmal has quit IRC |
| 16:11:32 | *** dkithmal_ has joined #openmrs |
| 16:28:11 | *** Shangeetha has quit IRC |
| 16:31:55 | *** dkithmal_ has quit IRC |
| 16:32:22 | *** mareias has joined #openmrs |
| 16:34:32 | *** dkithmal has joined #openmrs |
| 16:43:53 | *** davidpardz has joined #openmrs |
| 16:43:53 | *** ChanServ sets mode: +v davidpardz |
| 16:44:49 | *** wluyima has joined #openmrs |
| 16:53:31 | *** aniketha has quit IRC |
| 17:05:27 | *** dkithmal has quit IRC |
| 17:52:06 | *** khayam has quit IRC |
| 17:55:29 | *** dkayiwa has quit IRC |
| 18:09:24 | *** wluyima has quit IRC |
| 18:29:07 | *** dkithmal has joined #openmrs |
| 18:54:28 | *** dkayiwa has joined #openmrs |
| 19:09:27 | *** dkayiwa has quit IRC |
| 19:12:15 | *** dkayiwa has joined #openmrs |
| 19:22:24 | *** dkayiwa has quit IRC |
| 19:29:32 | *** AdaYeung_ has joined #openmrs |
| 19:29:50 | *** wluyima has joined #openmrs |
| 19:30:26 | *** AdaYeung has quit IRC |
| 19:30:26 | *** AdaYeung_ is now known as AdaYeung |
| 19:30:47 | *** dkayiwa has joined #openmrs |
| 19:42:33 | *** wluyima has quit IRC |
| 19:43:57 | *** dkithmal has quit IRC |
| 19:53:29 | *** ryates has quit IRC |
| 19:53:30 | *** jkeiper has quit IRC |
| 19:53:30 | *** downey has quit IRC |
| 19:53:30 | *** cospih has quit IRC |
| 19:53:31 | *** ibewes has quit IRC |
| 20:04:29 | *** mareias has quit IRC |
| 20:06:30 | *** harsha__ has joined #openmrs |
| 20:08:22 | *** harsha89 has quit IRC |
| 20:09:55 | *** dkayiwa_ has joined #openmrs |
| 20:13:25 | *** dkayiwa has quit IRC |
| 20:13:27 | *** dkayiwa_ is now known as dkayiwa |
| 20:26:05 | *** harsha__ has quit IRC |
| 20:26:12 | *** harsz89 has joined #openmrs |
| 20:26:12 | *** ChanServ sets mode: +v harsz89 |
| 20:33:48 | *** TheKinG_ has joined #openmrs |
| 20:35:18 | <TheKinG_> hi |
| 20:36:48 | *** davidpardz has quit IRC |
| 20:37:38 | <TheKinG_> i have installed openMRS SDK but when i issue "omrs -version" command on the terminal it didn't work |
| 20:37:49 | <TheKinG_> can anyone help me |
| 20:38:14 | <TheKinG_> please |
| 20:38:41 | *** davidpardz has joined #openmrs |
| 20:38:41 | *** leguin.freenode.net sets mode: +v davidpardz |
| 20:38:48 | *** downey has joined #openmrs |
| 20:38:48 | *** ChanServ sets mode: +o downey |
| 20:55:55 | *** robbyoconnor has quit IRC |
| 20:56:52 | *** robbyoconnor has joined #openmrs |
| 20:56:52 | *** ChanServ sets mode: +v robbyoconnor |
| 21:04:28 | *** TheKinG_ has quit IRC |
| 22:10:09 | *** dkayiwa has quit IRC |
| 22:17:51 | *** howardf_ has joined #openmrs |
| 22:49:47 | *** Shangeetha has joined #openmrs |
| 23:17:17 | <Shangeetha> harsz89: Hi |
| 23:18:06 | <Shangeetha> @downey: Hi |
| 23:30:32 | *** Shangeetha has quit IRC |
