00:03:13
|
<jblaya> djazayeri, ok, that actually was it, tomorrow or monday you should have a pull request, though I don't see where to put a code review in the ticket
|
00:03:48
|
<djazayeri> jblaya: you just paste a link to it as a ticket comment, and you say Request Code Review on the ticket
|
00:03:58
|
<djazayeri> (i.e. that's the status button you click)
|
00:04:19
|
<jblaya> djazayeri, sounds good
|
00:09:16
|
*** GitHub33 has joined #openmrs
|
00:09:16
|
<GitHub33> [openmrs-core] djazayeri pushed 1 new commit to 1.9.x: http://git.io/0ahSlA
|
00:09:16
|
<GitHub33> openmrs-core/1.9.x 72bbfe0 Rafal Korytkowski: TRUNK-2694 Fix Performance hog: Maps and sets of URLs...
|
00:09:16
|
*** GitHub33 has left #openmrs
|
00:09:30
|
*** jblaya has quit IRC
|
00:12:31
|
*** mseaton_ has quit IRC
|
00:12:32
|
*** akwatuha___ has quit IRC
|
00:12:33
|
*** ibewes has quit IRC
|
00:12:48
|
*** AdaYeung has quit IRC
|
00:12:49
|
*** Guest4031 has quit IRC
|
00:12:55
|
*** mseaton_ has joined #openmrs
|
00:12:58
|
*** akwatuha____ has joined #openmrs
|
00:13:04
|
*** ibewes has joined #openmrs
|
00:13:12
|
*** lnball has quit IRC
|
00:15:05
|
*** lnball has joined #openmrs
|
00:16:08
|
*** AdaYeung_ has joined #openmrs
|
00:32:40
|
*** wluyima has quit IRC
|
00:33:16
|
*** wluyima has joined #openmrs
|
00:36:12
|
*** cpower_ has quit IRC
|
00:36:56
|
*** cpower_ has joined #openmrs
|
00:42:04
|
<OpenMRSBot> Recent updates in the world of openmrsci: CA-CA-562 has FAILED (4 tests failed) : Dependant of TRUNK-LATEST-120 <https://ci-stg.openmrs.org/browse/CA-CA-562>
|
00:55:06
|
*** dkithmal has joined #openmrs
|
00:58:34
|
*** ChanServ sets mode: +o burke
|
01:11:49
|
*** howardf has joined #openmrs
|
01:12:42
|
*** aniketh has joined #openmrs
|
01:13:15
|
*** howardf has quit IRC
|
01:13:53
|
*** howardf_ has quit IRC
|
01:15:43
|
*** howardf_ has joined #openmrs
|
01:44:21
|
<OpenMRSBot> Recent updates in the world of openmrsci: SON-REPORTING-100 has FAILED (8 tests failed) : Scheduled build <https://ci-stg.openmrs.org/browse/SON-REPORTING-100>
|
01:49:02
|
*** harshadura has joined #openmrs
|
01:49:03
|
*** ChanServ sets mode: +v harshadura
|
01:53:00
|
*** Shangeetha has joined #openmrs
|
02:12:00
|
*** howardf_ has quit IRC
|
02:25:27
|
*** Shangeetha has quit IRC
|
02:44:32
|
<OpenMRSBot> Recent updates in the world of openmrsci: EMRAPI-EMRAPI-378 has FAILED (11 tests failed) : Dependant of REP-REP-154 <https://ci-stg.openmrs.org/browse/EMRAPI-EMRAPI-378>
|
03:04:05
|
*** aniketh has quit IRC
|
03:50:49
|
<OpenMRSBot> Recent updates in the world of openmrsci: SON-OPENMRSCOREMASTER-107 has FAILED (233 tests failed) : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-107>
|
04:39:37
|
*** ctw has joined #openmrs
|
04:40:14
|
<ctw> Mkop : hello
|
04:42:02
|
<ctw> ibewes: hi
|
04:46:01
|
<ctw> yanosz : hi
|
05:24:14
|
*** harshadura has quit IRC
|
05:24:59
|
*** wluyima has quit IRC
|
05:55:14
|
*** robbyoconnor has quit IRC
|
05:57:02
|
*** robbyoconnor has joined #openmrs
|
05:57:03
|
*** ChanServ sets mode: +v robbyoconnor
|
05:58:24
|
*** djazayeri has quit IRC
|
06:15:40
|
*** gihanchanuka has joined #openmrs
|
06:24:32
|
*** gihanchanuka has quit IRC
|
06:55:19
|
*** GitHub106 has joined #openmrs
|
06:55:19
|
<GitHub106> [openmrs-core] vinayvenu opened pull request #501: Trunk 4156 redesigned (1.10.x...TRUNK-4156-redesigned) http://git.io/BR7W5A
|
06:55:19
|
*** GitHub106 has left #openmrs
|
07:02:25
|
*** dkayiwa has joined #openmrs
|
08:24:21
|
*** vinayv has joined #openmrs
|
09:53:51
|
*** sgithens_ has quit IRC
|
09:54:17
|
*** sgithens_ has joined #openmrs
|
10:04:30
|
*** dkayiwa has quit IRC
|
10:58:46
|
*** dkayiwa has joined #openmrs
|
11:00:03
|
*** cospih has joined #openmrs
|
11:16:39
|
*** rkielty has joined #openmrs
|
11:24:47
|
*** Shangeetha has joined #openmrs
|
11:35:51
|
<Shangeetha> dkayiwa: Hi
|
11:36:24
|
<dkayiwa> Shangeetha: hi
|
11:36:27
|
*** ctw has quit IRC
|
11:37:02
|
<Shangeetha> dkayiwa: DMS module in HISPIndia is not being built successfully
|
11:37:10
|
<Shangeetha> dkayiwa: Url is https://github.com/hispindia/dms
|
11:38:16
|
<Shangeetha> dkayiwa: Error is [ERROR] Failed to execute goal on project dms-api: Could not resolve dependencies for project org.openmrs.module:dms-api:jar:0.0.1-SNAPSHOT: Failure to find org.openmrs.module:hospitalcore-api:jar:1.4.10.12-SNAPSHOT in http://mavenrepo.openmrs.org/nexus/content/repositories/public was cached in the local repository, resolution will not be reattempted until the update interval of openmrs-repo has elapsed or upda
|
11:38:17
|
<OpenMRSBot> <http://ln-s.net/8-2X> (at mavenrepo.openmrs.org)
|
11:55:23
|
*** harsz89 has joined #openmrs
|
11:55:23
|
*** ChanServ sets mode: +v harsz89
|
12:11:55
|
*** rkielty has quit IRC
|
12:12:05
|
<Shangeetha> dkayiwa: Hi
|
12:12:10
|
<dkayiwa> Shangeetha: hi
|
12:12:25
|
<Shangeetha> dkayiwa: hope u read messages above
|
12:12:55
|
<dkayiwa> Shangeetha: what version of that module did you compile and install?
|
12:13:50
|
<Shangeetha> dkayiwa: https://github.com/hispindia/dms this is not getting built
|
12:14:20
|
<dkayiwa> Shangeetha: what version of the hospitalcore module did you compile and install?
|
12:14:49
|
<Shangeetha> dkayiwa: 1.5.0
|
12:15:24
|
<dkayiwa> Shangeetha: change the pom of the dms module to reference that exact version
|
12:16:58
|
<Shangeetha> dkayiwa: Ok we will try that
|
12:26:54
|
<Shangeetha> dkayiwa: Changed pom.xml, still it is giving 43 errors
|
12:27:30
|
<Shangeetha> dkayiwa: One is java: cannot find symbol symbol : class DmsOpdUnit location: interface org.openmrs.module.dms.DmsService
|
12:28:32
|
<dkayiwa> Shangeetha: does it exist?
|
12:31:48
|
<Shangeetha> dkayiwa: Yeah it is there,it fails importing import org.openmrs.module.hospitalcore.model.DmsOpdUnit;
|
12:32:42
|
<dkayiwa> Shangeetha: does mvn clean install succeed?
|
12:34:05
|
<Shangeetha> dkayiwa: No, it fails
|
12:34:16
|
<dkayiwa> Shangeetha: same error msg?
|
12:35:16
|
<Shangeetha> dkayiwa: Yeah same cannot find symbol symbol errors
|
12:35:33
|
<dkayiwa> Shangeetha: show me that class on github
|
12:40:10
|
<Shangeetha> dkayiwa: class DmsOpdUnit is not there in the module, but there are other classes referrring this java class
|
12:40:29
|
<Shangeetha> dkayiwa: For example https://github.com/hispindia/dms/blob/BD/api/src/main/java/org/openmrs/module/dms/db/hibernate/HibernateDmsDAO.java
|
12:40:38
|
<dkayiwa> Shangeetha: so where is it?
|
12:41:07
|
<Shangeetha> dkayiwa: It is hospitalcore module 1.4.10.12 version. I think so, i also do not know where is it
|
12:41:59
|
<dkayiwa> Shangeetha: you need to first locate where the source of that class is.
|
12:42:15
|
*** vinayv has quit IRC
|
12:46:53
|
<Shangeetha> it isss inside either dms module or hospitalcore 1.5.0 module. Thatsy it is failing. What shall we do for it?
|
12:47:06
|
<Shangeetha> it is not inside either dms module or hospitalcore 1.5.0 module. Thatsy it is failing. What shall we do for it?
|
12:49:15
|
<dkayiwa> Shangeetha: show me the class on github
|
12:50:06
|
<Shangeetha> dkayiwa: Which class?
|
12:50:22
|
<dkayiwa> Shangeetha: the one in the error message
|
12:53:29
|
<Shangeetha> dkayiwa: The class DMSOpdUnit itself is not there anywhere. But there exist many other classes which use objects of DMSOpdUnit
|
12:54:23
|
<dkayiwa> Shangeetha: so you need to ask the module developers where that class is :)
|
12:55:19
|
*** howardf_ has joined #openmrs
|
12:56:55
|
<Shangeetha> dkayiwa: Ok sure :)
|
12:58:58
|
*** GitHub3 has joined #openmrs
|
12:58:58
|
<GitHub3> [openmrs-core] dkayiwa pushed 1 new commit to 1.10.x: http://git.io/ubmc8A
|
12:58:58
|
<GitHub3> openmrs-core/1.10.x a9502a3 dkayiwa: Add service methods for fetching active orders and order history by...
|
12:58:58
|
*** GitHub3 has left #openmrs
|
13:00:01
|
<Shangeetha> dkayiwa: https://tickets.openmrs.org/browse/TRUNK-3153 ticket is solved in 1.8.4
|
13:01:00
|
<Shangeetha> dkayiwa: We want to know is there any database model changes between 1.8.3 and 1.8.4
|
13:01:24
|
<Shangeetha> dkayiwa: We checked with release notes. But we wanted to get it confirmed by you
|
13:16:58
|
<OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-ONEPOINTTENX-40 has FAILED (1 tests failed) : Updated by dkayiwa <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-40>
|
13:18:07
|
<dkayiwa> Shangeetha: look at the release notes
|
13:21:37
|
<Shangeetha> dkayiwa: yeah
|
13:36:16
|
<Shangeetha> dkayiwa: Found DMSOpdUnit.java class and added to hospitalcore
|
13:36:40
|
<Shangeetha> dkayiwa: But still dms module says same error while doing maven build
|
13:37:45
|
<dkayiwa> Shangeetha: after adding it to hospitalcore, did you mvn clean install hospitalcore?
|
13:38:32
|
<Shangeetha> dkayiwa: Yeah did and it was successful
|
13:38:54
|
<dkayiwa> Shangeetha: which version of hospitalcore did you build?
|
13:39:24
|
<Shangeetha> dkayiwa: 1.5.0
|
13:39:43
|
<Shangeetha> dkayiwa: And changed pom.xml of dms to 1.5.0
|
13:40:01
|
<dkayiwa> Shangeetha: is that the same exact version you are referencing in the pom of the module you are trying to build?
|
13:40:11
|
<Shangeetha> dkayiwa: Yeah same
|
13:40:20
|
<dkayiwa> Shangeetha: show me on github
|
13:40:36
|
<Shangeetha> dkayiwa: ok sure give me some time, till i upload
|
13:49:18
|
<Shangeetha> dkayiwa: It says error: Failed connect to github.com:3128; No route to host while accessing https://github.com/hispindia/hospitalcore/info/refs fatal: HTTP request failed
|
13:49:41
|
<Shangeetha> dkayiwa: What shall i do for that?
|
13:50:52
|
<dkayiwa> Shangeetha: when does it do that?
|
13:51:58
|
<Shangeetha> dkayiwa: While uploading hospitalcore module to my git hub
|
13:52:46
|
<dkayiwa> Shangeetha: which git command did you use?
|
13:52:56
|
<Shangeetha> dkayiwa: git push origin master
|
13:53:57
|
<dkayiwa> Shangeetha: have you ever successfully used it before
|
13:56:08
|
<Shangeetha> dkayiwa: Yeah i did upload radiology module, i have never uploaded any of hispindia modules, after changing source code
|
13:56:30
|
<Shangeetha> dkayiwa: Shall i pastebin ?
|
13:56:58
|
<dkayiwa> Shangeetha: ok
|
13:58:27
|
<Shangeetha> dkayiwa: added this http://pastebin.com/DZV3DTLN in hospitalcore module 1.5.0 under org.openmrs.module.hospitalcore.model
|
13:58:50
|
<dkayiwa> Shangeetha: i mean the pom
|
14:01:34
|
<Shangeetha> dkayiwa: Ok sorry. This is pom.xml of dms-api, http://pastebin.com/Fde2m0F6
|
14:02:59
|
<Shangeetha> dkayiwa: pom.xml of dms-omod http://pastebin.com/zQHnpEKY
|
14:03:18
|
<dkayiwa> Shangeetha: and the pom for hospitalcore
|
14:05:16
|
<Shangeetha> dkayiwa: http://pastebin.com/xugyW7av
|
14:06:17
|
<dkayiwa> Shangeetha: and what is the current error message
|
14:08:10
|
<Shangeetha> dkayiwa: Cannot find symbol
|
14:08:14
|
<Shangeetha> dkayiwa: symbol : class DmsOpdUnit [ERROR] location: package org.openmrs.module.hospitalcore.model
|
14:09:56
|
<dkayiwa> Shangeetha: now i would need to have all your changes on github
|
14:13:39
|
<Shangeetha> dkayiwa: Ok i will try to upload entire code module somehow, just give me time
|
14:14:37
|
*** downey has joined #openmrs
|
14:14:37
|
*** ChanServ sets mode: +o downey
|
14:20:52
|
*** vinayv has joined #openmrs
|
14:27:49
|
<Shangeetha> dkayiwa: Uploading in github fails, http://snag.gy/aq8lM.jpg is the change in hospitalcore
|
14:28:20
|
<dkayiwa> Shangeetha: can you fork it
|
14:28:23
|
<Shangeetha> dkayiwa: Other changes are only in pom.xml of dms module. thats all i changed
|
14:35:12
|
*** GitHub71 has joined #openmrs
|
14:35:12
|
<GitHub71> [openmrs-core] wluyima pushed 1 new commit to 1.10.x: http://git.io/dh82NA
|
14:35:12
|
<GitHub71> openmrs-core/1.10.x d12abfe wyclif: Follow up to fix faulty changeset - TRUNK-4138
|
14:35:12
|
*** GitHub71 has left #openmrs
|
14:42:23
|
*** rafa has joined #openmrs
|
14:42:23
|
*** ChanServ sets mode: +v rafa
|
14:44:55
|
*** jkeiper has joined #openmrs
|
14:44:55
|
*** ChanServ sets mode: +v jkeiper
|
14:52:10
|
*** dkithmal has joined #openmrs
|
14:58:05
|
<Shangeetha> dkayiwa: We will get back to u once we uploaded the code to github.
|
14:58:34
|
*** Shangeetha has quit IRC
|
15:00:18
|
*** GitHub34 has joined #openmrs
|
15:00:19
|
<GitHub34> [openmrs-core] dkayiwa pushed 1 new commit to 1.10.x: http://git.io/zqjuFA
|
15:00:19
|
<GitHub34> openmrs-core/1.10.x 0dea614 dkayiwa: Add service methods for fetching active orders and order history by...
|
15:00:19
|
*** GitHub34 has left #openmrs
|
15:02:01
|
*** AdaYeung_ is now known as AdaYeung
|
15:02:52
|
<dkayiwa> AdaYeung: are you here for real? :)
|
15:03:05
|
<AdaYeung> hahahaha
|
15:03:10
|
<AdaYeung> hi, dkayiwa
|
15:03:17
|
<dkayiwa> AdaYeung: lollllll hi :)
|
15:07:26
|
*** sgithens_ has quit IRC
|
15:12:32
|
*** wluyima has joined #openmrs
|
15:13:09
|
<wluyima> !scrumon wyclif
|
15:13:09
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster wyclif- you may begin when ready.
|
15:14:28
|
<wluyima> order: dkayiwa , rafa , vinayv , wluyima
|
15:15:01
|
*** djazayeri has joined #openmrs
|
15:15:01
|
*** ChanServ sets mode: +o djazayeri
|
15:15:07
|
<wluyima> dkayiwa: ?
|
15:16:01
|
<wluyima> dkayiwa: are you there?
|
15:16:20
|
<wluyima> ok, rafa your update?
|
15:17:32
|
<wluyima> vinayv: any updates?
|
15:17:48
|
<vinayv> Completed TRUNK-4156. Waiting for code review. Pull request https://github.com/openmrs/openmrs-core/pull/501
|
15:18:14
|
<vinayv> not sure what to pick up next. will decide monday. no blockers.
|
15:18:22
|
<wluyima> vinayv: ok, i will review it, i made a follow up to fix the change set that drops the foreign key
|
15:18:42
|
<vinayv> oh.. Its fixed. part of a commit in the pull request.
|
15:19:14
|
<wluyima> vinayv: yeah i refixed it
|
15:19:24
|
<wluyima> you can update your code
|
15:19:28
|
<vinayv> ok
|
15:20:00
|
<wluyima> vinayv: you can pick up https://tickets.openmrs.org/browse/TRUNK-4202
|
15:20:05
|
<vinayv> ok
|
15:21:20
|
<wluyima> my update:
|
15:21:32
|
<wluyima> Thursday:
|
15:21:33
|
<wluyima> - Fix failing changeset for TRUNK-4138
|
15:21:34
|
<wluyima> - Dev call
|
15:21:36
|
<wluyima> - Order entry bi weekly call
|
15:21:37
|
<wluyima> - Call with Anushya
|
15:21:39
|
<wluyima> - Created and curated more order entry tickets for upgrade module and converting orderers to be providers
|
15:21:40
|
<wluyima> Friday
|
15:21:42
|
<wluyima> - Code review
|
15:21:43
|
<wluyima> - TRUNK-4187 - Add a liquibase changeset that checks that all text units are mapped to concepts
|
15:21:44
|
<wluyima>
|
15:21:45
|
<wluyima> Blockers: None
|
15:22:08
|
<wluyima> looks like there is no one else to give an update
|
15:22:16
|
<wluyima> !scrumoff
|
15:22:16
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
15:23:04
|
<rafa> wluyima: sorry I missed the scrum
|
15:23:15
|
<rafa> wluyima: I'm working on TRUNK-4135
|
15:23:29
|
<rafa> wluyima: I left a comment on it
|
15:23:32
|
<dkayiwa> Reviewed: ProgramWorkflowService.retireProgram always throws Exception - TRUNK-4160
|
15:23:32
|
<dkayiwa> Committed: Add service methods for fetching active orders and order history by order number for a patient - TRUNK-4191
|
15:23:33
|
<dkayiwa> Now going to choose another ticket
|
15:23:33
|
<dkayiwa> No Blockers
|
15:23:48
|
<rafa> wluyima: basically I think we need to have some tests for migration changesets
|
15:24:26
|
<wluyima> rafa: that is correct, i already created a ticket a while back to do that, let me look it up just a sec
|
15:24:36
|
<rafa> wluyima: we don't have any tests for liquibase so I'm trying to come up with a good way to write them
|
15:25:01
|
<wluyima> https://tickets.openmrs.org/browse/TRUNK-4052
|
15:25:09
|
*** dkayiwa has left #openmrs
|
15:25:25
|
<rafa> wluyima: cool
|
15:25:30
|
<rafa> wluyima: I'll claim that as well
|
15:25:32
|
<wluyima> rafa: that says writing tests for custom change sets but it can be for any changeset
|
15:25:39
|
<rafa> wluyima: TRUNK-4135 will be a proof of concept
|
15:25:53
|
<djazayeri> rafa: one idea is to start with a (small) known database run the liquibase, and verify the output carefully in a test.
|
15:26:30
|
<rafa> djazayeri: yeah, that's what I decided to try first
|
15:27:09
|
<rafa> djazayeri: we do have liquibaserunner setup on the old ci for testing a large migration on mysql
|
15:27:30
|
<rafa> djazayeri: but I think in core we need something small that runs on h2
|
15:28:02
|
<djazayeri> rafa: alternately, mseaton_ has been working on an approach that (using maven) loads a mariadb database
|
15:28:45
|
<djazayeri> rafa: he has it working on linux (but not yet osx or windows, I thnk), and this is more realistic and reliable than h2.
|
15:28:55
|
*** Shangeetha has joined #openmrs
|
15:28:57
|
<rafa> djazayeri: mseaton_ do you have any example of that?
|
15:30:18
|
<wluyima> rafa: djazayeri i think this might be fairly complex task, i didn't want it to take up much of the time, i would say rafa you should spike on it as a side task
|
15:30:48
|
<wluyima> and still devote most of your time to sprint specific tickets
|
15:30:59
|
<djazayeri> rafa: search the dev list for mariadb4j, and reply to mseaton_ and ask him for his current example usage there.
|
15:31:22
|
<mseaton_> rafa: the PIH/openmrs-module-rwandareports module has some POC usage
|
15:31:32
|
<rafa> mseaton_: thanks
|
15:31:54
|
<rafa> wluyima: I understand
|
15:32:00
|
<wluyima> rafa: cool
|
15:32:13
|
<rafa> wluyima: I won't spend too much time on that now
|
15:32:58
|
<rafa> wluyima: I'll test manually if it happens to be more work than a day
|
15:33:22
|
*** mseaton_ is now known as mseaton
|
15:33:49
|
*** ChanServ sets mode: +v mseaton
|
15:34:39
|
<rafa> wluyima: testing it well manually feels like a few hours with installation wizard :/
|
15:35:05
|
<wluyima> rafa: ok
|
15:57:36
|
*** vinayv has quit IRC
|
16:01:22
|
*** Shangeetha has quit IRC
|
16:03:18
|
*** GitHub40 has joined #openmrs
|
16:03:18
|
<GitHub40> [openmrs-core] pawelskij opened pull request #502: TRUNK-4164 Obs.getValueAsString(Locale locale) should localize name if O... (1.9.x...1.9.x) http://git.io/rjkMig
|
16:03:19
|
*** GitHub40 has left #openmrs
|
16:05:07
|
*** shangeetha has joined #openmrs
|
16:16:05
|
<shangeetha> @downey: Hi
|
16:18:23
|
*** sgithens_ has joined #openmrs
|
16:29:26
|
<shangeetha> @djazayeri: Hi
|
16:42:06
|
*** jatin has joined #openmrs
|
16:46:43
|
*** shangeetha has quit IRC
|
16:50:44
|
<jatin> can i contribute for google summer of code 2014???
|
16:54:55
|
*** dkithmal has quit IRC
|
17:01:59
|
*** Shangeetha has joined #openmrs
|
17:03:51
|
<downey> jatin: Google Summer of Code hasn't announced participating organization yet :)
|
17:04:58
|
<Shangeetha> @downey: Hi
|
17:05:51
|
*** Shangeetha has quit IRC
|
17:07:12
|
*** jatin has quit IRC
|
17:36:29
|
<wluyima> hi rafa
|
17:51:37
|
*** dkithmal has joined #openmrs
|
17:58:31
|
*** dkithmal has quit IRC
|
18:57:33
|
*** mareias has joined #openmrs
|
19:28:42
|
*** harsz89 has quit IRC
|
19:36:12
|
*** Ch3ck has joined #openmrs
|
20:02:51
|
*** Ch3ck has quit IRC
|
20:04:38
|
*** Ch3ck has joined #openmrs
|
20:23:19
|
*** tal has joined #openmrs
|
20:23:42
|
<tal> rafa: Hi Rafal, are you here?
|
20:36:41
|
<djazayeri> tal: hi
|
20:37:15
|
<tal> djazayeri: Hi Darius
|
20:37:57
|
<tal> djazayeri: did you see the last mail I just sent ?
|
20:38:35
|
<djazayeri> tal: Yes. What IDE are you using.
|
20:38:54
|
<tal> djazayeri: eclipse
|
20:39:23
|
<djazayeri> tal: are you in UI Framework Development Mode for that module?
|
20:39:25
|
<OpenMRSBot> Recent updates in the world of openmrsci: SON-PAPERRECORD-101 has FAILED (47 tests failed) : Scheduled build <https://ci-stg.openmrs.org/browse/SON-PAPERRECORD-101>
|
20:39:46
|
<djazayeri> tal: And are you running in the standalone, or through jetty?
|
20:40:10
|
<tal> djazayeri: yes, and
|
20:40:51
|
<tal> djazayeri: Darius, sorry for the typo
|
20:41:07
|
<tal> djazayeri: what do you mean by UI Framework Development Mode?
|
20:41:18
|
<tal> djazayeri: and im using the standalone version
|
20:42:00
|
<djazayeri> tal: is there a reason you aren't using jetty?
|
20:42:38
|
<djazayeri> tal: i.e. git clone openmrs-core, git checkout 1.9.x, mvn jetty:run
|
20:43:11
|
<tal> djazayeri: I am developing a module, and it is more comfortable to run it like that
|
20:43:51
|
<djazayeri> tal: https://wiki.openmrs.org/display/docs/Using+the+UI+Framework+in+Your+Module#UsingtheUIFrameworkinYourModule-Developmentmode
|
20:44:31
|
<tal> djazayeri: yes i did that
|
20:45:45
|
<djazayeri> tal: I assume that will only work if you're running in Jetty, but I guess maybe it works in the standalone too
|
20:45:57
|
<djazayeri> tal: see wyclif's response to your email
|
20:46:08
|
<djazayeri> tal: i.e. does your omod's config.xml mention uiframework as a required module?
|
20:46:59
|
<tal> djazayeri: yes. and i will check
|
20:48:39
|
*** Ch3ck has quit IRC
|
20:56:43
|
<OpenMRSBot> Recent updates in the world of openmrsci: HFEUI-HFEUI-260 has FAILED (1 tests failed) : Dependant of APPUI-APPUI-251 <https://ci-stg.openmrs.org/browse/HFEUI-HFEUI-260>
|
21:00:27
|
<tal> djazayeri: darius thanks, i think it solved
|
21:00:38
|
<djazayeri> tal: what was the solution?
|
21:00:41
|
<tal> djazayeri: but now i have - java.lang.NoClassDefFoundError: org/openmrs/module/appui/UiSessionContext
|
21:01:50
|
<tal> djazayeri: dont know yet, trying some stuff..
|
21:03:39
|
<djazayeri> tal: I would start off by turning off the Development Mode, and make sure it works normally
|
21:12:19
|
<tal> djazayeri: thanks darius but im working on the standalone version and as from my understanding there is no ui development mode for the standalone version
|
21:13:05
|
<djazayeri> tal, okay, I misunderstood your earlier comment "yes I did that"
|
21:13:24
|
<djazayeri> tal: I strongly suggest that you do development using jetty
|
21:13:52
|
<djazayeri> tal: it's "what everyone does" so you're much less likely to run into obscure issues
|
21:14:04
|
<tal> djazayeri: i think you are right, i will, thanks.
|
21:14:11
|
<djazayeri> tal: and it allows you to run under the debugger, which is infinitely helpful
|
21:16:35
|
*** mareias has quit IRC
|
21:49:05
|
*** tal has quit IRC
|
21:55:24
|
*** cosmin1 has joined #openmrs
|
21:56:11
|
*** sgithens_ has quit IRC
|
22:07:16
|
*** dkithmal has joined #openmrs
|
22:10:58
|
*** Shangeetha has joined #openmrs
|
22:11:23
|
<Shangeetha> @downey: Hi
|
22:11:33
|
*** dkithmal has quit IRC
|
22:11:48
|
<downey> Shangeetha: Hi
|
22:12:18
|
<Shangeetha> @downey: We have a module, it is not getting compiled
|
22:12:31
|
<downey> Shangeetha: sorry to hear that
|
22:12:54
|
<Shangeetha> @downey: Module git url is https://github.com/Shangeetha12/DMS
|
22:12:57
|
*** kithmal has joined #openmrs
|
22:15:53
|
<downey> Shangeetha: that kind of looks like a fork, but not really
|
22:16:05
|
<downey> Shangeetha: are you forking HISP india's module?
|
22:16:55
|
<Shangeetha> @downey: Yeah forking HISPIndia, with changes
|
22:17:35
|
<downey> Shangeetha: i was confused. it just looks like you copied the code and made a new repo, not forked it
|
22:17:57
|
<Shangeetha> @downey: When mavn build is given it says cannot find symbol DMSOpdUnit.java
|
22:18:22
|
<downey> Shangeetha: did you try the resources at http://hispindia.org/index.php/tech-support ? This is the #OpenMRS channel, not the hisp india channel :)
|
22:18:55
|
<Shangeetha> @downey: What we did was, cloned their module, did changes in pom.xml and added DMSOpdUnit.java in hospitalcore as well
|
22:20:04
|
<Shangeetha> @downey: We have not tried that tech support
|
22:20:13
|
<downey> Shangeetha: seems like an odd way to start a repo, how do you plan to merge & stay up with their changes to the module over time?
|
22:21:16
|
<Shangeetha> @downey: No, our project ends by end of this month
|
22:21:38
|
*** GitHub156 has joined #openmrs
|
22:21:38
|
<GitHub156> [openmrs-core] wluyima pushed 1 new commit to 1.10.x: http://git.io/wiYMqQ
|
22:21:38
|
<GitHub156> openmrs-core/1.10.x 7253a87 wyclif: Moved @Transactional annotations to the service impl...
|
22:21:39
|
*** GitHub156 has left #openmrs
|
22:21:39
|
<Shangeetha> @downey: We have a SLHMS system, based on OpenMRS 1.8 series
|
22:22:11
|
<downey> Shangeetha: Here's the right way to fork a repo: https://help.github.com/articles/fork-a-repo
|
22:22:12
|
<Shangeetha> @downey: Current Issue is DMS is not getting successful maven build
|
22:22:30
|
<Shangeetha> @downey: Thanks :)
|
22:23:02
|
<downey> Shangeetha: good luck :) we probably won't be able to help you with a 3rd-party openmrs module here, unless there happen to be some HISP india people in the channel (and I don't think there are)
|
22:24:07
|
<Shangeetha> @downey: Ok thank you :) We will try to get a contact of HISP india developers
|
22:35:05
|
<OpenMRSBot> Recent updates in the world of openmrsci: TRUNK-ONEPOINTTENX-43 has FAILED (2 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/TRUNK-ONEPOINTTENX-43>
|
22:40:36
|
<Shangeetha> @downey: A doubt, can an java object be made for a module, where java class of that particular object is in another module?
|
22:41:05
|
<Shangeetha> @downey: Assuming, it has dependencies correctly set for the outside module
|
22:44:50
|
*** mareias has joined #openmrs
|
23:03:36
|
*** sgithens_ has joined #openmrs
|
23:10:13
|
*** wluyima has quit IRC
|
23:11:40
|
<howardf_> hi all... new dev here... doing a build for the first time and maven is telling me it can't find javac in C:\Program Files\Java\jre7\..\lib\tools.jar
|
23:12:04
|
<howardf_> i'm guessing i've missed a configuration setting somewhere, but I don't know what it is... any suggestions?
|
23:52:11
|
<howardf_> (I have JAVA_HOME set correctly... and I don't know why it's looking in the jre folder for it)
|
23:53:40
|
*** wluyima has joined #openmrs
|