IRC Chat : 2013-12-09 - OpenMRS

00:00:16 *** robbyoconnor has quit IRC
00:04:15 *** mukherjeerohit93 has joined #openmrs
00:23:49 *** mukherjeerohit93 has quit IRC
00:58:03 *** robbyoconnor has joined #openmrs
00:58:03 *** ChanServ sets mode: +v robbyoconnor
01:35:39 <OpenMRSBot> Recent updates in the world of openmrsci: SON-RESTWEBSERV-76 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-RESTWEBSERV-76>
01:38:07 *** bmanth60 has joined #openmrs
01:39:01 *** djazayeri has quit IRC
02:01:13 *** robbyoconnor has quit IRC
02:08:23 *** maninc has quit IRC
02:08:37 *** maninc has joined #openmrs
02:24:48 *** djazayeri has joined #openmrs
02:24:48 *** ChanServ sets mode: +o djazayeri
02:54:35 *** robbyoconnor has joined #openmrs
02:54:35 *** ChanServ sets mode: +v robbyoconnor
03:45:21 *** dedunumax has joined #openmrs
03:45:43 *** wluyima has joined #openmrs
03:45:47 *** Shangeetha has joined #openmrs
03:47:06 <Shangeetha> djazayeri: Hi
03:56:10 <Shangeetha> Hi
03:56:14 <Shangeetha> Hi all
03:56:40 <Shangeetha> Is there anyone who is using database backup module in their system? Thanks.
03:58:18 <dedunumax> Shangeetha: What do you want to know?
03:59:30 <Shangeetha> dedunumax: Hi
03:59:46 <Shangeetha> dedunumax: https://wiki.openmrs.org/display/docs/Database+Backup+Module
04:00:01 <dedunumax> Shangeetha: Hi
04:00:09 <Shangeetha> dedunumax: it says backup process can be automated using Quartz scheduler
04:00:29 <Shangeetha> dedunumax: I contacted with Elyse who wrote database backup module
04:00:42 <Shangeetha> dedunumax: I could not get a response
04:01:12 <Shangeetha> dedunumax: Basically i want to automate backup process, scheduled every mid night
04:01:18 <Shangeetha> dedunumax: in our server
04:01:58 <dedunumax> Shangeetha: I have to go out for a urgent matter, I'll try to help you on this
04:02:00 <dedunumax> :)
04:02:52 <Shangeetha> dedunumax: Ok thanks :)
04:28:04 *** bmanth60 has quit IRC
04:32:41 <dedunumax> Shangeetha: Did you look at this? - https://wiki.openmrs.org/display/docs/Quartz+Scheduler+User+Guide
04:37:27 *** djazayeri has quit IRC
04:42:07 *** harshadura has joined #openmrs
04:42:08 *** ChanServ sets mode: +v harshadura
04:43:37 <Shangeetha> dedunumax: Yeah i have tried with several links during last week. One of our requirements is to backup server everyday midnight
04:44:19 <Shangeetha> dedunumax: Our previous design was to write mysql script , having mysqldump command and then to invoke that script via cron job
04:45:04 <Shangeetha> dedunumax: While browsing we came across this database backup module. Though it works fine, command has to be given manually
04:45:24 <Shangeetha> dedunumax: Do u have any idea for this requirement :)
04:48:40 <dedunumax> Shangeetha: I'll search and let you know
04:49:02 <Shangeetha> dedunumax: Ok sure
04:49:06 <dedunumax> Shangeetha: I don't have a idea. :(
04:51:27 <Shangeetha> dedunumax: It is ok. thanks :)
04:58:41 <dedunumax> Shangeetha: This image shows that you can create Scheduled tasks - https://wiki.openmrs.org/download/attachments/11993866/Image022.jpg?version=1&modificationDate=1293437689000&api=v2
05:05:58 <Shangeetha> dedunumax: Yeah this is using quartz scheduler module. Where shall i find omod of this module?
05:06:34 <dedunumax> Shangeetha: Can you explain omod?
05:06:39 <dedunumax> Shangeetha: I didnt get you
05:07:35 <Shangeetha> dedunumax: ok got it
05:08:06 <Shangeetha> dedunumax: omod file is the file you get after doing mvn clean install of a module
05:08:20 <Shangeetha> dedunumax: https://modules.openmrs.org/modules/view.jsp?module=schedulerquartz
05:10:42 <dedunumax> Shangeetha: Old source code is available at http://svn.openmrs.org/openmrs-modules/schedulerquartz/branch/schedulerquartz_OpenMRSV1.7/ But yet I couldn't find github repo
05:12:40 <Shangeetha> dedunumax: yeah here too same. only svn checkout is possible
05:13:43 <Shangeetha> dedunumax: still we cannot do svn checkout
05:14:06 <Shangeetha> dedunumax: it says svn: E175002: Unable to connect to a repository at URL 'http://svn.openmrs.org/openmrs-modules/schedulerquartz/branch/schedulerquartz_OpenMRSV1.7' svn: E175002: OPTIONS of 'http://svn.openmrs.org/openmrs-modules/schedulerquartz/branch/schedulerquartz_OpenMRSV1.7': could not connect to server (http://svn.openmrs.org)
05:15:19 <Shangeetha> dedunumax: There is one another problem, that we are using openmrs 1.9.3, but this scheduler module is compatible with OMRS 1.6 and 1.7
05:15:42 <dedunumax> Shangeetha: This command worked on ubuntu for me - svn checkout http://svn.openmrs.org/openmrs-modules/schedulerquartz/branch/schedulerquartz_OpenMRSV1.7/
05:16:01 <dedunumax> Shangeetha: Yeah there is a problem with that
05:16:07 *** wluyima has quit IRC
05:18:07 <dedunumax> Shangeetha: and this is not a maven project
05:21:55 <dedunumax> Shangeetha: I think we need to start a mail thread for this.
05:22:21 <dedunumax> Shangeetha: I'll start a one are you subscribed to dev@openmrs.org
05:22:22 <dedunumax> ?
05:23:55 *** Shangeetha has quit IRC
05:33:13 *** tika has joined #openmrs
05:33:59 <tika> hi does anyone know how to write an sql from the csv downloaded from a concept dictionary from a openmrs implementation?
05:34:10 <tika> the columns are not matching exactly
05:34:17 <tika> to the concept table
05:39:04 *** Shangeetha has joined #openmrs
05:39:26 <Shangeetha> dedunumax: hi sorry my internet connection was interrupted
05:40:43 <dedunumax> Shangeetha: I think we need to start a mail
05:40:56 <dedunumax> Shangeetha: thread on dev@openmrs.org
05:41:07 <dedunumax> Shangeetha: This module should get updated.
05:41:17 <dedunumax> Shangeetha: Shall I start a mail tth
05:41:30 <dedunumax> Shangeetha: I'll add you as well
05:42:05 <dedunumax> tika: Can you explain little bit more?
05:42:51 <tika> there are few question and answer concepts that i need to add to my implementation of openmrs
05:42:59 <Shangeetha> dedunumax: it is ok. we Have written databasebackup.sh and now we can schedule it using cron job
05:43:36 <tika> i have got them from another implementation, as a csv export from the cpncepts
05:43:41 <tika> openmrs frontend
05:43:52 <dedunumax> Shangeetha: I'll start a mail thread. If we got this fixed I'll send you information
05:45:45 <Shangeetha> dedunumax: Ok thanks :) I will try to find the way to invoke this databasebackup.sh as a cron job. Thanks :) Bye :)
05:46:27 <dedunumax> Shangeetha: You're welcome! Bye! :)
05:46:34 <tika> dedunumax: i need to insert them into my openmrs concept table, but the column headings are diferent in csv file and sql file .
05:48:06 <dedunumax> tika: Do you want to do this through a Web UI or Can you access mysql console?
05:48:26 <tika> no no i can acces mysql console
05:48:36 <tika> if i can write a sql file that will do :)
05:48:43 <tika> using those concepts in the csv
05:49:12 <dedunumax> Can you send me a sample CSV? Make sure that user data is not there. :)
05:49:21 <dedunumax> Use pastebin
05:49:44 <tika> sure can i have your email addrees?
05:49:55 <tika> i will share the google document with you
05:50:01 <tika> the data are not that sensitive
05:50:12 <tika> few questions and answers
05:55:37 <tika> Dedunumax: i have shared it with you
06:12:44 *** dkayiwa has joined #openmrs
06:32:08 *** Shangeetha has quit IRC
06:42:06 *** GitHub121 has joined #openmrs
06:42:07 <GitHub121> [openmrs-core] dkayiwa pushed 1 new commit to 1.9.x: http://git.io/hVUxtA
06:42:07 <GitHub121> openmrs-core/1.9.x 02c57a9 Crazzykid: TRUNK-3335: In ProviderFormController the method providerAttributeTypes...
06:42:07 *** GitHub121 has left #openmrs
06:43:41 *** upul has quit IRC
06:45:23 *** tika has quit IRC
06:50:44 *** djazayeri has joined #openmrs
06:50:45 *** ChanServ sets mode: +o djazayeri
07:05:35 *** GitHub107 has joined #openmrs
07:05:36 <GitHub107> [openmrs-core] dkayiwa pushed 2 new commits to 1.9.x: http://git.io/_l25LQ
07:05:36 <GitHub107> openmrs-core/1.9.x 6003ef8 Dedunu Dhananjaya: TRUNK-4113 Modify the ObsValidator to allow the storage of obs text larger than 50 chars(cherry picked from commit e6b5558f86bb2c870322bb64981dcc0b521d7949)
07:05:36 <GitHub107> openmrs-core/1.9.x d2e5094 Dedunu Dhananjaya: TRUNK-4113 Modify the ObsValidator to allow the storage of obs text larger than 50 chars(cherry picked from commit 8d8e5e1ab3095ad404b2412471056a635761cf26)
07:05:36 *** GitHub107 has left #openmrs
07:06:56 <OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-56 has FAILED (1 tests failed) : Dependant of TRUNK-LATEST-116 <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-56>
07:13:24 *** GitHub134 has joined #openmrs
07:13:25 <GitHub134> [openmrs-core] dkayiwa pushed 1 new commit to 1.9.x: http://git.io/gYVrYg
07:13:25 <GitHub134> openmrs-core/1.9.x c6943c2 Lukasz Plotnicki: @lplotni/@jthoenes: TRUNK-4037 Retired location tags are being displayed with the class="retired" if they are selected on the location. If they are not selected, they will be not presented....
07:13:25 *** GitHub134 has left #openmrs
07:24:18 *** bmanth60 has joined #openmrs
07:28:36 *** bmanth60 has quit IRC
07:48:07 *** GitHub61 has joined #openmrs
07:48:07 <GitHub61> [openmrs-core] dkayiwa pushed 1 new commit to 1.9.x: http://git.io/nXynzw
07:48:07 <GitHub61> openmrs-core/1.9.x 48fd9b5 dkayiwa: Back porting to 1.9.7: PatientService.savePatientIdentifier still...
07:48:07 *** GitHub61 has left #openmrs
07:54:16 *** GitHub8 has joined #openmrs
07:54:16 <GitHub8> [openmrs-core] dkayiwa pushed 1 new commit to master: http://git.io/Qs7IoQ
07:54:16 <GitHub8> openmrs-core/master 6c5b120 dkayiwa: Fixing forgotten assignment bug for:...
07:54:16 *** GitHub8 has left #openmrs
08:00:25 *** GitHub109 has joined #openmrs
08:00:25 <GitHub109> [openmrs-core] dkayiwa pushed 1 new commit to 1.9.x: http://git.io/91ETAQ
08:00:25 <GitHub109> openmrs-core/1.9.x f466d3a dkayiwa: Changing comment for: PatientService.savePatientIdentifier still...
08:00:25 *** GitHub109 has left #openmrs
08:04:23 *** travis-ci has joined #openmrs
08:04:24 <travis-ci> [travis-ci] [openmrs/openmrs-core] [6c5b120] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/15155172
08:04:24 *** travis-ci has left #openmrs
08:11:06 *** harshadura_ has joined #openmrs
08:13:33 *** harshadura has quit IRC
08:29:13 <OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-57 has FAILED (1 tests failed) : Dependant of TRUNK-LATEST-117 <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-57>
08:41:00 *** djazayeri has quit IRC
09:13:23 <OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-58 has FAILED (1 tests failed) : Dependant of TRUNK-LATEST-118 <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-58>
09:14:26 *** dkayiwa_ has joined #openmrs
09:16:40 *** dkayiwa has quit IRC
09:16:40 *** dkayiwa_ is now known as dkayiwa
09:22:13 *** dkayiwa has left #openmrs
09:26:20 *** wluyima has joined #openmrs
09:29:03 *** dkayiwa has joined #openmrs
09:47:32 <OpenMRSBot> Recent updates in the world of openmrsci: EMRAPI-EMRAPI-316 has FAILED (1 tests failed) : Dependant of EVNT-LATEST-41 <https://ci-stg.openmrs.org/browse/EMRAPI-EMRAPI-316>
09:48:58 *** magoo has joined #openmrs
10:07:40 *** dkayiwa_ has joined #openmrs
10:09:05 *** dkayiwa has quit IRC
10:09:06 *** dkayiwa_ is now known as dkayiwa
10:12:07 *** Mkop has quit IRC
10:12:36 *** raonyguimaraes has joined #openmrs
10:20:12 *** Mkop has joined #openmrs
10:26:20 <magoo> dkayiwa i have sent an email
10:26:35 <dkayiwa> magoo: ok
10:27:18 <dkayiwa> magoo: you could put this on the ticket as a comment
10:27:44 <magoo> dkayiwa okay
11:02:19 *** GitHub89 has joined #openmrs
11:02:19 <GitHub89> [openmrs-core] dkayiwa pushed 1 new commit to 1.9.x: http://git.io/kCEeBQ
11:02:19 <GitHub89> openmrs-core/1.9.x 60bd9bc dkayiwa: [maven-release-plugin] prepare release 1.9.7
11:02:19 *** GitHub89 has left #openmrs
11:02:19 *** GitHub140 has joined #openmrs
11:02:19 <GitHub140> [openmrs-core] dkayiwa tagged 1.9.7 at b3a9a0f: http://git.io/rfNfJw
11:02:19 *** GitHub140 has left #openmrs
11:02:24 *** GitHub10 has joined #openmrs
11:02:24 <GitHub10> [openmrs-core] dkayiwa pushed 1 new commit to 1.9.x: http://git.io/MznTrw
11:02:24 <GitHub10> openmrs-core/1.9.x 7e4fca2 dkayiwa: [maven-release-plugin] prepare for next development iteration
11:02:24 *** GitHub10 has left #openmrs
11:05:13 *** dedunumax has quit IRC
11:14:15 *** wluyima has quit IRC
12:08:58 *** dedunumax has joined #openmrs
12:18:12 *** dkayiwa_ has joined #openmrs
12:20:16 *** dkayiwa has quit IRC
12:20:16 *** dkayiwa_ is now known as dkayiwa
12:21:48 <akwatuha__> hi dkayiwa
12:21:54 <dkayiwa> akwatuha__: hi
12:22:27 <akwatuha__> dkayiwa: Lauren filed a ticket concerning skip logic on my behalf. Did you get a chance to look at it?
12:22:43 <dkayiwa> akwatuha__: yes i saw it
12:23:49 <akwatuha__> dkayiwa: what are your thoughts on it?
12:26:18 <dkayiwa> akwatuha__: i have not yet got some spare time for it
12:28:51 <akwatuha__> dkayiwa: okay. i hope you will find some time soon to take a look at it. Thanks
12:29:00 <dkayiwa> akwatuha__: sure
12:36:23 *** mukherjeerohit93 has joined #openmrs
12:36:54 *** dedunumax has left #openmrs
13:03:09 *** GitHub18 has joined #openmrs
13:03:09 <GitHub18> [openmrs-core] dkayiwa deleted latest at af6e5e0: http://git.io/LwnAkA
13:03:09 *** GitHub18 has left #openmrs
13:14:46 *** GitHub104 has joined #openmrs
13:14:46 <GitHub104> [openmrs-core] dkayiwa tagged latest at 07ee73c: http://git.io/dIYYog
13:14:46 *** GitHub104 has left #openmrs
13:23:02 *** lh has joined #openmrs
13:23:02 *** rowanseymour has joined #openmrs
13:23:02 *** lh has quit IRC
13:23:02 *** lh has joined #openmrs
13:23:26 *** lh_ has quit IRC
13:24:38 <rowanseymour> Is there a publicly accessible demo server for the EMR 2.0 stuff ? I need to have a look at it but would rather not go through the process of installing it locally if I don't have to
13:24:55 <magoo> dkayiwa when i try to download m2e into eclipse i get the following error http://pastebin.com/WN8CDzpL
13:32:39 *** raonyguimaraes has quit IRC
13:43:05 <dkayiwa> rowanseymour: http://devtest01.openmrs.org:8080/openmrs/login.htm
13:43:21 <dkayiwa> rowanseymour: and http://devtest02.openmrs.org:8080/openmrs/login.htm
13:44:42 <rowanseymour> dkayiwa thanks - login creds ?
13:45:01 <dkayiwa> rowanseymour: admin/Admin123
13:57:17 *** harsz89 has joined #openmrs
13:57:18 *** ChanServ sets mode: +v harsz89
14:07:57 *** wluyima has joined #openmrs
14:09:52 *** dkayiwa has left #openmrs
14:21:19 *** smuriu has joined #openmrs
14:35:40 <cpower> rafa: wake up :-) join the standup https://plus.google.com/hangouts/_/event/crnuketcgse0rc6ono0nad4fta0?authuser=0&hl=en
14:35:41 <OpenMRSBot> <http://ln-s.net/:sqf> (at plus.google.com)
15:00:15 *** rowanseymour has quit IRC
15:01:16 <cpower> Ok quick scrum for the record
15:01:21 <cpower> !scrumon cpowr
15:01:21 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpowr- you may begin when ready.
15:01:56 <cpower> Order: wluyima , rafa
15:02:25 <cpower> Daniel's update
15:02:28 <cpower> Reviewed 1.9.7 tickets, closed, back ported, and bumped where necessary.
15:02:28 <cpower> Did some basic manual testing
15:02:28 <cpower> Tagged 1.9.7
15:02:28 <cpower> Created release notes page
15:02:28 <cpower> Deployed maven artifacts to nexus
15:02:29 <cpower> Uploaded war and readme files to sourceforge
15:02:29 <cpower> Now working on the remaining steps as on our release process page.
15:02:30 <cpower> No Blockers
15:02:54 <cpower> wluyima: you are up
15:03:00 <wluyima> Friday:
15:03:00 <wluyima> - curate more order entry tickets
15:03:02 <wluyima> - call with Burke, Darius, Chris
15:03:03 <wluyima> - Paired with order entry call with Anushya
15:03:05 <wluyima> Tuesday:
15:03:06 <wluyima> - design call
15:03:08 <wluyima> - Update order entry tickets as per design discussions
15:03:09 <wluyima>
15:03:09 <wluyima> Blockers: None
15:03:15 <rafa> Today:
15:03:15 <rafa> * Continued working on REPORT-531
15:03:15 <rafa> Need easy way to run reports for "all locations that are tagged with X"
15:03:15 <rafa> https://tickets.openmrs.org/browse/REPORT-531
15:03:15 <rafa> * Design call
15:03:15 <rafa> No blockers.
15:03:44 <cpower> Awesome, Design call in an hour, lots of Order Entry to talk about. Looking for discussion points for Wednesday!
15:03:57 <cpower> !scrumoff
15:03:57 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
15:07:57 *** djazayeri has joined #openmrs
15:07:57 *** ChanServ sets mode: +o djazayeri
15:09:01 *** robbyoconnor has quit IRC
15:28:59 *** bmanth60 has joined #openmrs
15:31:10 *** smuriu has quit IRC
15:39:30 *** Ch3ck_ has joined #openmrs
16:04:09 <djazayeri> wluyima: design call?
16:04:19 *** Ch3ck_ has quit IRC
16:07:32 <burke> downey: help! we can't mute people on uberconference and are getting killed by feedback
16:08:27 <burke> downey: they finally muted themselves. i'll file an ITSM ticket to get mute rights for uberconference for several people.
16:11:16 *** mukherjeerohit93 has quit IRC
16:11:45 *** magoo has quit IRC
16:15:59 *** robbyoconnor has joined #openmrs
16:15:59 *** ChanServ sets mode: +v robbyoconnor
16:37:33 *** robbyoconnor has quit IRC
16:38:15 *** robbyoconnor has joined #openmrs
16:38:16 *** ChanServ sets mode: +v robbyoconnor
16:45:56 *** djazayeri has quit IRC
16:46:00 *** djazayeri1 has joined #openmrs
16:54:51 *** robbyoconnor has quit IRC
17:16:05 *** djazayeri has joined #openmrs
17:16:06 *** ChanServ sets mode: +o djazayeri
17:17:06 *** tal has joined #openmrs
17:19:50 *** djazayeri1 has quit IRC
17:21:31 *** tal has quit IRC
17:57:25 <OpenMRSBot> Recent updates in the world of openmrsci: RESTWS-RESTWS-59 has FAILED (1 tests failed) : Updated by Daniel Shorten, Rafał Korytkowski <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-59>
18:10:19 *** harshadura__ has joined #openmrs
18:13:36 *** harshadura_ has quit IRC
18:26:49 *** dkayiwa has joined #openmrs
18:39:35 <OpenMRSBot> Recent updates in the world of openmrsci: EMRAPI-EMRAPI-319 has FAILED (1 tests failed) : Dependant of REP-REP-125 <https://ci-stg.openmrs.org/browse/EMRAPI-EMRAPI-319>
18:55:31 <wluyima> ho djazayeri
18:55:35 <wluyima> hi djazayeri
18:55:48 <wluyima> can you join me and Anushya briefly at https://plus.google.com/hangouts/_/7ecpjdaa0vd8vmqi5lhvq482k0?hl=en?
18:55:50 <OpenMRSBot> <http://ln-s.net/:vu9> (at plus.google.com)
19:11:44 <OpenMRSBot> Recent updates in the world of openmrsci: EMRAPI-EMRAPI-320 has FAILED (1 tests failed) : Dependant of REP-REP-126 <https://ci-stg.openmrs.org/browse/EMRAPI-EMRAPI-320>
19:20:00 *** Mkop has quit IRC
19:20:20 *** Mkop has joined #openmrs
19:50:57 *** MonkeyCat has joined #openmrs
19:52:36 <MonkeyCat> Hi Folks. I think I may be a bit in over my head... I was looking to use OpenMRS for a small clinic in Nigeria to register patient, record vital signs, and a basic SBAR or SOAP. I can't even get to the point of recording vital signs. Do you have any recommendations or advice? Thank you in advance for your help.
19:59:41 *** MonkeyCat has quit IRC
20:04:40 *** MonkeyCat has joined #openmrs
20:05:08 <MonkeyCat> I'm sorry, I was disconnected from the server. If someone responded, can they respond again. Sorry...
20:06:10 <MonkeyCat> I have to leave, if someone is able to provide me with some assistance via email I would greatly appreciate it. My email address is monkeycat@r4t5.com Thank you
20:10:31 *** MonkeyCat has quit IRC
20:53:23 <wluyima> hi djazayeri
20:53:45 <wluyima> djazayeri: it sounds to me like for now Order class should be abstract
20:54:17 <djazayeri> wluyima: because everything should be a subclass?
20:54:28 <wluyima> djazayeri: right
20:54:54 <wluyima> djazayeri: i don't want people to create Order that we don't know what they are
20:55:23 <djazayeri> wluyima: I don't think so…a DC order is just a plain Order
21:00:47 <wluyima> djazayeri: burke doesn't agree wit that
21:01:05 <wluyima> djazayeri: burke says the dc order should be of the same type as the original
21:01:31 <wluyima> djazayeri: but that is what i thought all long myself, that a DC order is a plain Order
21:01:40 <djazayeri> wluyima, burke: that's a surprise to me.
21:01:59 <wluyima> djazayeri: can you ask him on Skype?
21:02:40 <wluyima> djazayeri: and the other question i have is how do you tell a discontinued order in the new design
21:03:02 <djazayeri> wluyima: I don't see him. I can live with that, it makes some sense that "discontinue Ampicillin" is a DrugOrder
21:03:10 <burke> the Java object used for the D/C order needs to communicate the order being discontinued unambiguously. For drugs, a DrugOrder object is required to supply the drug ID; for all other orders, an Order object could suffice. But there's no harm if someone creates a TestOrder with action of D/C.
21:03:12 <djazayeri> wluyima: it means that validation needs an extra if statement
21:03:40 <djazayeri> burke: makes sense
21:04:08 <djazayeri> wluyima: an order is discontinued if date_discontinued is not null
21:04:25 <wluyima> djazayeri: burke suggests that we have something on the lined of order.cloneForDiscontinuing just like revising, makes agree?
21:04:43 <burke> In the 99% use case, someone would use the existing, active order object and issue the discontinue method to get a D/C order and save that OR they would pass the active order to the API's discontinue method. In either of these cases, the client needn't worry about creating the order type.
21:05:22 <djazayeri> wluyima: fine by me (about cloneForDiscontinuing); just that's going to copy very few properties
21:05:44 <burke> In the exceptions (creating a D/C order from scratch), the client can use the Order object for other types, but will be forced to use a DrugOrder object for drugs, since the drug ID (not present on the base class) is required to specify the formulation being discontintued.
21:05:54 <wluyima> djazayeri: that means discontinued we are not moving discontinued_date to the generated DC orders
21:06:57 <wluyima> djazayeri: main reason is we don't users to have to fields like action and previous order
21:07:15 <wluyima> jazayeri: main reason is we don't want users to have to set fields like action and previous order
21:07:43 <wluyima> djazayeri: burke so Order class should really be abstract for now
21:07:54 *** raonyguimaraes has joined #openmrs
21:09:13 <burke> The Order class could suffice for many types of orders that do not need additional metadata – e.g., referrals, diet, activity, call orders, patient handouts, nursing orders, etc. So, I would not make it abstract and force a new Java class for every type of order.
21:11:28 <wluyima> burke: ok
21:11:32 <burke> The order.getOrderType() and order.isOrderType(orderType) methods should encapsulate the business of determine order type from the order. I suppose we might need an Order orderService.createNewOrder(Concept) to future-proof subclasses provided by modules.
21:15:20 <wluyima> djazayeri: so that means for TRUNK-4138, we should not move discontinued_date from the original orders to the auto generated DC orders, meaning DC orders also should always have a null discontinuedDate, in any case you won't discontinue a DC order
21:18:08 <djazayeri> wluyima: the orders table should have a discontinued_date column
21:18:34 <djazayeri> wluyima: when migrating existing orders, any that is discontinued should become two orders, one NEW and one DISCONTINUE
21:19:02 <wluyima> djazayeri: correct, but what am saying we should not copy discontinued_date values from the NEW to the DISCONTINUE one
21:19:56 <djazayeri> wluyima: correct. discontinueReason, discontinueReasonNonCoded and discontinuedBy move to the new DC order
21:20:10 <djazayeri> wluyima: date_discontinued stays on the original
21:20:26 <wluyima> djazayeri: cool, that what i was clarifying
21:20:43 <wluyima> djazayeri: cool, that is what i was clarifying
21:22:07 *** upul has joined #openmrs
21:26:16 <djazayeri> wluyima: of course, date_discontinues gets _renamed_ to date_stopped
21:28:09 <wluyima> djazayeri: right, does it also mean that the dateCreated fields for the generated DC orders on upgrade should be the discontinue_date values of the original discontinued orders?
21:28:17 <djazayeri> wluyima: yes
21:28:27 <wluyima> djazayeri: cool thanks
21:49:25 *** Mkop has quit IRC
21:49:26 *** Mkop1 has joined #openmrs
22:18:24 *** wluyima has quit IRC
22:20:10 *** wluyima has joined #openmrs
22:32:45 *** wluyima has quit IRC
23:54:15 *** harsz89 has quit IRC