IRC Chat : 2013-11-14 - OpenMRS

00:12:20 *** jkeiper has quit IRC
01:06:18 *** djazayeri has joined #openmrs
01:06:19 *** ChanServ sets mode: +o djazayeri
02:16:49 *** raonyguimaraes has quit IRC
02:26:55 *** djazayeri has quit IRC
04:31:47 *** shruthd has joined #openmrs
05:03:46 *** wluyima has quit IRC
05:13:44 <OpenMRSBot> Recent updates in the world of openmrsci: SON-EMRAPI-54 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-EMRAPI-54>
05:39:10 *** upul has joined #openmrs
05:58:42 *** upul has quit IRC
06:06:16 *** pascal` has joined #openmrs
06:06:20 *** ChanServ sets mode: +v pascal`
06:55:52 *** dkayiwa has joined #openmrs
07:16:34 *** shruthd has quit IRC
08:03:26 *** harsz89 has quit IRC
08:12:23 *** shruthd has joined #openmrs
08:16:02 *** harsz89 has joined #openmrs
08:16:02 *** ChanServ sets mode: +v harsz89
08:44:00 *** Eli__ has joined #openmrs
08:45:15 <Eli__> dkayiwa: Hi, are you here?
08:45:21 *** Eli__ has quit IRC
08:45:21 *** Eli__ has joined #openmrs
08:45:49 *** sgithens has quit IRC
08:45:50 *** janmajeed has quit IRC
08:45:51 *** burke has quit IRC
08:46:49 *** janmajeed has joined #openmrs
08:46:49 *** burke has joined #openmrs
08:48:12 <Eli__> dkayiwa: Hi, are you here?
08:48:17 <dkayiwa> Eli__: can you give me like 30 mins? :)
08:48:41 <Eli__> dkayiwa: sure ,no problems, we are waiting for you :)
08:52:06 *** sgithens has joined #openmrs
09:27:08 <Eli__> dkayiwa: are you here?
09:27:40 <dkayiwa> Eli__: setting up shortly
09:28:22 <Eli__> dkayiwa: great, send me a message when you are ready
09:28:36 <dkayiwa> Eli__: cool
09:44:45 *** endeepak has joined #openmrs
09:51:10 <endeepak> Hi, few times all the openmrs modules end up in stopped stated after restarting the tomcat. We'll have to start each module one by one in the order. Is there a way start all modules at once?
09:55:11 *** raonyguimaraes has joined #openmrs
09:58:02 *** Shangeetha has joined #openmrs
09:59:10 <Eli__> dkayiwa: if its not comfortable for you, maybe you can suggest an other time?
09:59:40 <Eli__> dkayiwa: we are available up until 16:00
09:59:56 <dkayiwa> Eli__: are you doing something in the meantime or just seated waiting for me?
10:00:08 <Shangeetha> dkayiwa: Hi
10:00:40 <Shangeetha> dkayiwa: I am following steps mentioned in this https://wiki.openmrs.org/display/docs/Adding+a+Gutter+extension+point
10:01:11 <Shangeetha> dkayiwa: They have mentioned over there to add add new class into OMOD/src/main/java/org.openmrs.module.MODULE_NAME.extension.html/
10:01:22 <Eli__> dkayiwa: we were waiting for you
10:02:14 <Shangeetha> dkayiwa: I cannot find OMOD/src/java folder inside loaded module to do that action
10:02:45 <Shangeetha> dkayiwa: Can you please suggest how to overcome? If u r busy right now , can you suggest another time to catch you?
10:06:54 <dkayiwa> Eli__: what time is it there now?
10:07:08 <Eli__> dkayiwa: it's 12:07
10:07:31 <dkayiwa> Eli__: so you have 4hrs?
10:07:42 <Eli__> dkayiwa: yes
10:08:23 <dkayiwa> Shangeetha: are you trying to do that in your module?
10:14:33 <Shangeetha> dkayiwa: yeah
10:15:12 <Shangeetha> dkayiwa: Yet i have not received any mail from author . So i thought of doing myself
10:15:26 <dkayiwa> Shangeetha: are you getting problems with this line? Add a gutter extension point in your OMOD/src/main/resources/config.xml file
10:16:00 <dkayiwa> Eli__: by the way am available. the only challenge is having voice where iam right now. but i can use text before i can connect audio
10:16:10 <Shangeetha> dkayiwa: i have added those lines. Next part only i do not know how to add. Actually, we are doing this for radiology module
10:16:29 <Shangeetha> dkayiwa: which has been maintained by Akhil Ravindran
10:16:51 <Eli__> dkayiwa: okay, so do you want to chat in google+?
10:17:21 <Shangeetha> dkayiwa: Give me some time. Sorry. I will get back to you :)
10:17:23 <dkayiwa> Eli__: i can chat before i connect voice. i should be able to do voice in 15mins
10:17:43 <dkayiwa> Shangeetha: ok
10:17:54 *** shruthd has quit IRC
10:18:04 <Eli__> okay, so I guess we'll wait for 15 mins and get on air
10:20:33 <dkayiwa> Eli__: am ready now
10:20:51 <dkayiwa> Eli__: ready for voice
10:21:44 <dkayiwa> Eli__: what is the hangout url?
10:26:30 *** shruthd has joined #openmrs
10:35:22 <dkayiwa> Eli__: my connection was lost
10:35:55 <Shangeetha> dkayiwa: i pasted config.xml for you http://pastebin.com/9Tp90S5R
10:36:18 <dkayiwa> Eli__: i would like to run away for some lunch which should take me not more than 45 mins
10:36:35 <Shangeetha> dkayiwa: I did first part as shown in above link , in pastebin
10:37:04 <Shangeetha> dkayiwa: It seems you are going for lunch . I will get back to you after ur lunch :) Bye
10:37:18 <dkayiwa> Eli__: so can you use the 45 mins to install maven up to a stage where you can do: mvn -version
10:37:18 <dkayiwa> Eli__: then i can start from there
10:37:18 <dkayiwa> Eli__: feel free to try out as many links as you can find
10:37:18 <dkayiwa> Eli__: deal?
10:37:37 <Eli__> dkayiwa: sure
10:46:54 *** dkayiwa has quit IRC
10:50:55 *** Shangeetha has quit IRC
10:53:43 *** dkayiwa has joined #openmrs
11:01:06 <OpenMRSBot> Recent updates in the world of openmrsci: SON-EMRAPI-54 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-EMRAPI-54> || SON-IDGEN-57 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-IDGEN-57> || TRUNK-MASTER-195 has FAILED (4 tests failed) : Updated by dkayiwa <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-195> || REP-REP-67 has FAILED (1 tests failed) : Updated by djazayeri <https://ci-stg.openmrs.org/browse/REP-REP-67> || REP-REP-66 has FAILED (1 tests failed) : Updated by djazayeri <https://ci-stg.openmrs.org/browse/REP-REP-66> || REP-REP-65 has FAILED : Updated by djazayeri <https://ci-stg.openmrs.org/browse/REP-REP-65> || SON-IDGEN-55 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-IDGEN-55> || RESTWS-RESTWS-42 has FAILED (1 tests failed) : Updated by arathy jan, Darius Jazayeri <https://ci-stg.openmrs.org/browse/RESTWS-RESTWS-42> || REFAPP-OMODDISTRO-1499 has FAILED : Dependant of RA-RA-275 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1499> || SON-IDGEN-54 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-IDGEN-54> || SON-EMRAPI-50 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-EMRAPI-50> || TRUNK-MASTER-185 has FAILED (3 tests failed) : Updated by dkayiwa <https://ci-stg.openmrs.org/browse/TRUNK-MASTER-185> || PRM-PAPER-43 has FAILED : Manual build by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/PRM-PAPER-43> || PRM-PAPER-42 has FAILED (1 tests failed) : Rebuilt by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/PRM-PAPER-42> || SON-IDGEN-50 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-IDGEN-50> || SON-EMRAPI-47 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-EMRAPI-47>
11:14:13 *** shruthd has quit IRC
11:14:27 *** Eli__ has quit IRC
11:36:09 *** Eli__ has joined #openmrs
12:30:06 *** shruthd has joined #openmrs
12:43:21 *** endeepak has quit IRC
12:55:10 *** shruthd has quit IRC
13:01:20 *** robbyoconnor has joined #openmrs
13:06:28 *** shruthd has joined #openmrs
13:31:39 *** jkeiper has joined #openmrs
13:31:39 *** ChanServ sets mode: +v jkeiper
13:49:55 *** raonyguimaraes has quit IRC
14:07:18 *** djazayeri has joined #openmrs
14:07:18 *** ChanServ sets mode: +o djazayeri
14:31:28 *** wluyima has joined #openmrs
14:33:17 <dkayiwa> https://plus.google.com/hangouts/_/72cpjaate0ljunae4132mo82ns?hl=en
14:33:19 *** cpower has joined #openmrs
14:33:19 <OpenMRSBot> <http://ln-s.net/:bOa> (at plus.google.com)
14:33:19 *** ChanServ sets mode: +v cpower
14:33:30 <djazayeri> wluyima, cpower, rafa: ^^
14:33:32 <wluyima> djazayeri: url?
14:33:53 <djazayeri> wluyima: https://plus.google.com/hangouts/_/72cpjaate0ljunae4132mo82ns?hl=en
14:33:54 <OpenMRSBot> <http://ln-s.net/:bOa> (at plus.google.com)
14:35:40 *** endeepak has joined #openmrs
14:36:47 <dkayiwa> djazayeri: https://tickets.openmrs.org/browse/TRUNK-4134
14:47:14 <djazayeri> dkayiwa: can you please ensure that your tests for TRUNK-4134 are verifying that dependent modules are stopped in the correct order also?
14:47:27 <dkayiwa> djazayeri: ok
14:47:33 <djazayeri> dkayiwa: i.e. if B depends on A, startup order should be AB, and stop order should be BA.
14:47:39 <djazayeri> dkayiwa: cool, thanks, gotta run now
14:47:46 <dkayiwa> djazayeri: ok.
14:48:20 <dkayiwa> djazayeri: cool
14:52:11 *** sgithens has quit IRC
14:59:12 *** djazayeri has quit IRC
15:02:40 *** djazayeri has joined #openmrs
15:02:41 *** ChanServ sets mode: +o djazayeri
15:06:10 *** dkayiwa has quit IRC
15:12:49 *** dkayiwa has joined #openmrs
15:16:15 *** dkayiwa_ has joined #openmrs
15:17:07 *** Eli__ has quit IRC
15:19:23 *** dkayiwa has quit IRC
15:19:24 *** dkayiwa_ is now known as dkayiwa
15:20:41 *** pascal` has quit IRC
15:37:03 *** sgithens has joined #openmrs
15:38:55 *** endeepak has quit IRC
16:04:03 <OpenMRSBot> Recent updates in the world of openmrsci: SON-IDGEN-58 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-IDGEN-58>
16:18:02 *** wluyima has quit IRC
16:18:49 *** wluyima has joined #openmrs
16:20:05 *** endeepak has joined #openmrs
16:20:51 *** dkayiwa has quit IRC
16:28:13 <tobin_g> hi elly_
16:31:50 *** dkayiwa has joined #openmrs
16:31:56 *** endeepak has quit IRC
16:47:42 *** dkayiwa has quit IRC
16:56:19 *** dkayiwa has joined #openmrs
17:08:25 *** pascal` has joined #openmrs
17:08:25 *** ChanServ sets mode: +v pascal`
17:13:18 <tobin_g> hi dkayiwa sorry i could not join you guys last night, I needed to sleep!
17:21:31 *** pascal` has quit IRC
17:32:20 *** wluyima has joined #openmrs
17:35:46 *** djazayeri has quit IRC
17:37:52 *** raonyguimaraes has joined #openmrs
17:39:11 *** Shangeetha has joined #openmrs
17:39:18 <Shangeetha> dkayiwa: Hi
17:40:25 <Shangeetha> dkayiwa: How can we check whether one module is overriding spring binding framework? Is it by checking for java class implementing Validator interface?
17:47:00 *** dkayiwa has quit IRC
17:51:38 <harsz89> Shangeetha, did u ask something frm me bfr or?
17:53:21 <Shangeetha> Harsha, yeah sorry but forgot what i asked.
17:53:40 <Shangeetha> Harsha, we have another issue. How can we check whether one module is overriding spring binding framework? Is it by checking for java class implementing Validator interface?
17:54:16 *** vagrant00 has joined #openmrs
17:55:26 <harsz89> Shangeetha, mhhhh i saw tht one thing u can do is
17:55:41 <harsz89> not having any module in ur setup and
17:55:52 <harsz89> test it whether itz working or not
17:56:01 <harsz89> thn u can add one by one
17:56:38 *** dkayiwa has joined #openmrs
17:58:43 <Shangeetha> harsha, yeah that way also possible. Is there anyway to check from code itself?
17:58:44 *** vagrant00 has quit IRC
17:59:23 *** vagrant00 has joined #openmrs
18:01:26 *** vagrant00 has quit IRC
18:02:16 *** vagrant00 has joined #openmrs
18:02:47 <vagrant00> hello, could someone help me :)
18:02:47 <Shangeetha> harsha, how can we overcome this issue, because we have found out radiology module is overriding spring binding framework. So how can we overcome?
18:03:33 *** harsz89 has quit IRC
18:04:52 *** Shangeetha has quit IRC
18:05:18 *** vagrant00 has quit IRC
18:06:12 *** vagrant00 has joined #openmrs
18:08:55 *** vagrant00 has joined #openmrs
18:09:11 <vagrant00> somebody, anybody?
18:11:17 *** vagrant00 has quit IRC
18:15:07 *** harsz89 has joined #openmrs
18:15:07 *** ChanServ sets mode: +v harsz89
18:17:12 *** endeepak has joined #openmrs
18:21:37 *** endeepak has quit IRC
18:22:32 *** dkayiwa has quit IRC
18:39:42 *** shruthd has quit IRC
18:42:42 *** shruthd has joined #openmrs
18:58:10 *** djazayeri has joined #openmrs
18:58:10 *** ChanServ sets mode: +o djazayeri
19:14:14 *** djazayeri1 has joined #openmrs
19:14:14 *** djazayeri has quit IRC
19:23:25 *** dkayiwa has joined #openmrs
19:43:36 *** djazayeri has joined #openmrs
19:43:37 *** ChanServ sets mode: +o djazayeri
19:44:03 *** djazayeri1 has quit IRC
19:45:25 *** djazayeri1 has joined #openmrs
19:45:25 *** djazayeri has quit IRC
19:47:59 <wluyima> hi dkayiwa
19:47:59 *** djazayeri1 has quit IRC
19:48:13 *** djazayeri has joined #openmrs
19:48:13 *** ChanServ sets mode: +o djazayeri
19:48:58 <dkayiwa> wluyima: hi
19:50:02 <wluyima> dkayiwa: sorry i had many comments on the module life cycle commits, i have just realized that TextClassLoader was added by you, i thought it was spring class, ignore some of the comments related to application context and context loader except for why did you switch to WebXmlApplicationContext?
19:50:46 *** maro has joined #openmrs
19:52:35 <dkayiwa> wluyima: because of WebModuleUtil.refreshWAC()
19:55:40 <wluyima> dkayiwa: what code is calling WebModuleUtil.refreshWAC() ?
19:56:26 <dkayiwa> wluyima: WebModuleUtil.stopModule
19:56:42 <wluyima> dkayiwa: what is calling WebModuleUtil.stopModule?
19:57:12 <dkayiwa> wluyima: ModuleListController
19:57:43 <wluyima> dkayiwa: are you using the IDE to find references?
19:58:00 <dkayiwa> wluyima: also Listener.performWebStartOfModules() calls WebModuleUtil.refreshWAC
19:58:10 <dkayiwa> wluyima: yes. why?
19:58:15 <wluyima> dkayiwa: because it is not what you should be doing, i guess why am asking this is your test code should not be calling it
19:58:34 <wluyima> dkayiwa: it means you have code that is testing the web layer
19:58:50 <wluyima> but these tests are not really testing the web layer
19:58:59 <wluyima> they testing module life cycle in the api
19:59:01 <dkayiwa> wluyima: i have both
19:59:20 <wluyima> dkayiwa: so you do have test code for the web layer, right? If yes then that is fine
20:00:08 <dkayiwa> wluyima: some are in web layer WebModuleActivatorTest and others are in api ModuleActivatorTest
20:00:41 <wluyima> dkayiwa: then you need probably want to change your test code in WebModuleActivator test to be calling methods in ModuleUtil
20:00:44 <dkayiwa> wluyima: the ones that need refreshing of the spring application context are all in the web layer
20:00:51 <wluyima> dkayiwa: sorry in webModuleUtil and not ModuleUtil
20:01:39 <dkayiwa> wluyima: ok
20:01:42 <wluyima> dkayiwa: you should also be able to have those that need refreshing that ae not in the web layer because spring can be used without the web
20:01:57 <wluyima> dkayiwa: does this make sense?
20:03:04 <dkayiwa> wluyima: i tried having them in the api layer (those that refresh the web context) but failed because when the modules were being refreshed, they had classes that reference the web layer
20:03:33 <dkayiwa> wluyima: do you have any solution to that?
20:04:09 <wluyima> dkayiwa: like which classes were getting referenced?
20:04:26 <dkayiwa> wluyima: to see that, just move any test method from WebModuleActivator to ModuleActivator
20:05:16 <dkayiwa> wluyima: as an example, move WebModuleActivatorTest.shouldCallWillRefreshContextAndContextRefreshedOnRefresh() to api test class and see the error
20:06:27 *** djazayeri1 has joined #openmrs
20:06:27 *** djazayeri has quit IRC
20:06:34 <wluyima> dkayiwa: i get what you are saying, but the reason why you get those errors is very clear, it is because you are extending BaseContextSensitiveTest which adds openmrs-servlet.xml as a location and that is what has beans of types in the web layer so in your ModuleActivatorTest, you need to override that annotation and exclude openmrs-servlet.xml , makes sense?
20:07:36 *** GitHub81 has joined #openmrs
20:07:36 <GitHub81> [openmrs-core] pamcdm opened pull request #450: TRUNK-4116 (master...master) http://git.io/px-mAg
20:07:36 *** GitHub81 has left #openmrs
20:08:57 <wluyima> dkayiwa: i think BaseContextSensitiveTest should not include it, and then fix BaseWebContextSensitiveTest to add it
20:09:14 *** shruthd has quit IRC
20:10:03 <dkayiwa> wluyima: i tried those series of combinations and still got errors until when i gave up that approach because i was taking too long :)
20:11:04 *** djazayeri1 has quit IRC
20:11:15 <wluyima> dkayiwa: it should be able to work otherwise where are the web classes coming from, running away from something just masks a bug somewhere which we need to fix
20:11:42 <dkayiwa> wluyima: thats where i want another dev to come in and help me because it did not work for me :)
20:12:06 <wluyima> dkayiwa: i can pair with you and we try to fix it because it sounds like a bug somewhere, ModuleUtil and ModuleFactory should not be referencing web classes
20:12:35 <dkayiwa> wluyima: the module web classes were the complaint
20:12:49 <dkayiwa> wluyima: that is on refreshing spring application context
20:13:13 <wluyima> so FYI some tests in WebModuleActivatortest fail for me, is it the same for you
20:13:20 <wluyima> dkayiwa: i have pulled all your commmits
20:13:41 <dkayiwa> wluyima: are you running from eclipse or maven?
20:14:01 <wluyima> dkayiwa: dkayiwa in eclipse
20:14:14 <dkayiwa> wluyima: now that was another interesting one :)
20:14:31 <dkayiwa> wluyima: tests failing in eclipse but working in maven command line :)
20:14:51 <dkayiwa> wluyima: i faced it too
20:16:02 <wluyima> dkayiwa: i think i might know the cause of this
20:16:43 <dkayiwa> wluyima: that will be very helpful
20:19:07 <wluyima> dkayiwa: look in the logs, it tries to create and load module message.properties files
20:20:34 <dkayiwa> wluyima: yes i got that. and i wondered why it passed from maven command line :)
20:23:49 <wluyima> dkayiwa: they actually fail for me too on the commandline
20:24:13 <dkayiwa> wluyima: are you doing mvn clean install from the openmrs root folder?
20:26:59 <wluyima> dkayiwa: i don't think that matters, the cause is: in web environment, you expect to have /WEB-INF dir at the root which doesn't exist in our test environment see, so you might want to create it before and delete it at the end, see WebModuleUtil.insertIntoModuleMessagePropertiesFile, it assumes this path /WEB-INF/module_messages@LANG@.properties
20:27:33 <wluyima> dkayiwa: and yes i have run the test with mvm clean and it still fails
20:28:01 <dkayiwa> wluyima: from the openmrs root folder?
20:28:11 <wluyima> dkayiwa: yes i did that
20:28:30 <wluyima> dkayiwa: have you seen my reason above for what might be causing it
20:28:41 <dkayiwa> wluyima: now that is even more strange because it does not fail for me and co
20:28:46 <dkayiwa> co = CI
20:29:25 <wluyima> dkayiwa: i have seen such things before where tests fail in different places, but why it is failing is logical to me
20:29:40 <dkayiwa> wluyima: so is the solution as simple as creating the /WEB-INF folder?
20:33:51 <wluyima> dkayiwa: i have even tested it, when i create that WEB-INF folder under web/test-classes and run the test both on command line and eclipse, the test passes and during the test execution watch that folder after test runs, you will notice the messages.properties files get created, so the fix is to create the folder in before and after methods
20:34:17 <wluyima> dkayiwa: i tested by creating the folder manually
20:34:18 <dkayiwa> wluyima: ok
20:34:29 <dkayiwa> wluyima: let me create and commit
20:36:14 <wluyima> dkayiwa: and this should be a signal that even the other tests that are failing in a none web environment when they shouldn't can be fixed
20:37:14 <dkayiwa> wluyima: i just do not know how to fix them :)
20:37:30 <wluyima> we can pair, when do you tho to bed?
20:37:41 <wluyima> dkayiwa: when do you go to bed
20:37:42 <dkayiwa> wluyima: in other wards i did run out of ideas. so i cannot be of help :)
20:38:08 <dkayiwa> wluyima: am not sure. but am still on :)
20:41:45 <wluyima> dkayiwa: ok do you use hangout?
20:42:53 <dkayiwa> wluyima: yes
20:48:24 <wluyima> dkayiwa: i sent you an invite
20:48:46 <dkayiwa> wluyima: not yet seen it
20:49:57 <wluyima> dkayiwa: how about now?
20:50:14 <dkayiwa> wluyima: still not yet
20:55:24 <wluyima> dkayiwa: and now?
21:04:37 *** djazayeri has joined #openmrs
21:04:37 *** ChanServ sets mode: +o djazayeri
21:05:13 <dkayiwa> wluyima: i think am now heading for bed :)
21:05:38 <wluyima> ok
21:38:30 *** djazayeri has quit IRC
21:50:44 *** sgithens has quit IRC
21:50:46 *** maro has quit IRC
22:35:41 *** djazayeri has joined #openmrs
22:35:42 *** ChanServ sets mode: +o djazayeri
22:37:01 *** dkayiwa has quit IRC
23:15:41 *** janmajeed has quit IRC
23:19:53 *** wluyima has quit IRC