00:49:48
|
*** djazayeri has joined #openmrs
|
00:49:48
|
*** ChanServ sets mode: +o djazayeri
|
00:54:11
|
*** GitHub175 has joined #openmrs
|
00:54:12
|
<GitHub175> [openmrs-core] dadepo opened pull request #433: Trunk 3257: Add junit test for searching on voided patient names (master...TRUNK-3257) http://git.io/R6eSGA
|
00:54:12
|
*** GitHub175 has left #openmrs
|
01:24:21
|
*** LeeBreisacher1 has joined #openmrs
|
01:26:19
|
*** harsz89 has joined #openmrs
|
01:26:19
|
*** ChanServ sets mode: +v harsz89
|
01:47:55
|
*** djazayeri has quit IRC
|
01:54:03
|
*** raonyguimaraes has quit IRC
|
01:57:08
|
*** djazayeri has joined #openmrs
|
01:57:08
|
*** ChanServ sets mode: +o djazayeri
|
01:57:31
|
*** dahde has quit IRC
|
01:59:24
|
*** LeeBreisacher1 has left #openmrs
|
02:04:25
|
*** djazayeri has quit IRC
|
02:20:59
|
*** djazayeri has joined #openmrs
|
02:21:00
|
*** ChanServ sets mode: +o djazayeri
|
02:47:09
|
*** raonyguimaraes has joined #openmrs
|
03:14:56
|
*** djazayeri has quit IRC
|
03:48:35
|
*** raonyguimaraes has quit IRC
|
03:51:58
|
*** shruthd has joined #openmrs
|
04:01:51
|
*** shruthd has quit IRC
|
04:03:34
|
*** shruthd has joined #openmrs
|
04:32:06
|
*** shruthd has quit IRC
|
05:10:26
|
*** harshadura__ has quit IRC
|
06:19:29
|
*** LeeBreisacher1 has joined #openmrs
|
06:21:30
|
<OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1468 has FAILED : Dependant of UITF-UITF-12 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1468>
|
06:40:38
|
*** shruthd has joined #openmrs
|
06:54:32
|
*** shruthd has quit IRC
|
07:04:43
|
*** mukherjeerohit93 has joined #openmrs
|
07:06:33
|
*** shruthd has joined #openmrs
|
07:11:03
|
*** harsz89 has quit IRC
|
07:22:45
|
*** harsz89 has joined #openmrs
|
07:22:45
|
*** ChanServ sets mode: +v harsz89
|
07:28:16
|
*** shruthd has quit IRC
|
07:54:55
|
*** dkayiwa has joined #openmrs
|
08:01:18
|
*** shruthd has joined #openmrs
|
08:01:21
|
<OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-DEMO-20 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/REFAPP-DEMO-20>
|
08:36:52
|
*** shruthd has quit IRC
|
08:47:31
|
*** shruthd has joined #openmrs
|
08:51:18
|
*** shruthd has quit IRC
|
08:55:41
|
*** dkayiwa has quit IRC
|
09:19:37
|
*** dkayiwa has joined #openmrs
|
09:25:27
|
*** harsz89 has quit IRC
|
09:29:54
|
*** mukherjeerohit93 has quit IRC
|
10:03:51
|
*** shruthd has joined #openmrs
|
10:15:53
|
*** shruthd has quit IRC
|
10:47:38
|
*** dkayiwa has quit IRC
|
10:49:44
|
*** k-joseph has joined #openmrs
|
11:04:15
|
*** shruthd has joined #openmrs
|
11:05:25
|
*** dkayiwa has joined #openmrs
|
11:20:05
|
*** dkayiwa has quit IRC
|
11:30:37
|
*** raonyguimaraes has joined #openmrs
|
11:32:38
|
*** dkayiwa has joined #openmrs
|
11:35:27
|
*** k-joseph has quit IRC
|
11:36:58
|
*** k-joseph has joined #openmrs
|
11:46:48
|
*** dkayiwa has quit IRC
|
11:49:27
|
*** dkayiwa has joined #openmrs
|
11:52:10
|
*** dkayiwa_ has joined #openmrs
|
11:53:56
|
*** dkayiwa has quit IRC
|
11:53:56
|
*** dkayiwa_ is now known as dkayiwa
|
12:01:37
|
*** harshadura has joined #openmrs
|
12:01:37
|
*** ChanServ sets mode: +v harshadura
|
12:06:29
|
*** dkayiwa has quit IRC
|
12:22:59
|
*** shruthd has quit IRC
|
12:24:07
|
*** dkayiwa has joined #openmrs
|
12:36:32
|
*** shruthd has joined #openmrs
|
12:47:01
|
*** rfriedman has joined #openmrs
|
12:47:43
|
<rfriedman> !beer me
|
12:47:43
|
* OpenMRSBot slides me a pint
|
12:48:18
|
*** rfriedman has quit IRC
|
12:48:40
|
*** rfriedman has joined #openmrs
|
12:49:05
|
*** rfriedman has quit IRC
|
12:49:30
|
*** rfriedman has joined #openmrs
|
12:49:59
|
*** rfriedman is now known as rfriedman_away
|
13:01:28
|
*** dahde has joined #openmrs
|
13:01:53
|
<dahde> Hoi dkayiwa
|
13:04:08
|
*** shruthd has quit IRC
|
13:22:52
|
*** shruthd has joined #openmrs
|
13:38:21
|
*** GitHub101 has joined #openmrs
|
13:38:21
|
<GitHub101> [openmrs-core] tonybeing opened pull request #434: Fix for TRUNK-3818 (master...master) http://git.io/krnzZw
|
13:38:21
|
*** GitHub101 has left #openmrs
|
13:49:46
|
*** shruthd has quit IRC
|
13:52:54
|
*** shruthd has joined #openmrs
|
13:53:34
|
*** shruthd has quit IRC
|
14:02:17
|
*** dkayiwa has left #openmrs
|
14:10:33
|
*** dahde has quit IRC
|
14:19:59
|
*** Shangeetha has joined #openmrs
|
14:24:00
|
*** k-joseph has quit IRC
|
14:25:42
|
*** k-joseph has joined #openmrs
|
15:01:01
|
*** Shangeetha has quit IRC
|
15:20:33
|
*** harshadura_ has joined #openmrs
|
15:23:55
|
*** harshadura has quit IRC
|
15:53:06
|
*** k-joseph has quit IRC
|
16:07:24
|
*** raonyguimaraes has quit IRC
|
16:28:45
|
*** shruthd has joined #openmrs
|
16:47:12
|
*** k-joseph has joined #openmrs
|
17:23:46
|
*** harshadura_ has quit IRC
|
17:33:05
|
*** shruthd has quit IRC
|
17:39:10
|
*** shruthd has joined #openmrs
|
17:58:46
|
*** k-joseph has quit IRC
|
18:10:00
|
*** k-joseph has joined #openmrs
|
18:34:14
|
*** dahde has joined #openmrs
|
18:45:56
|
*** LeeBreisacher1 has left #openmrs
|
18:57:32
|
*** k-joseph has quit IRC
|
19:00:09
|
*** shruthd has quit IRC
|
19:04:02
|
*** dkayiwa has joined #openmrs
|
19:04:57
|
*** k-joseph has joined #openmrs
|
19:34:28
|
*** k-joseph has quit IRC
|
19:41:13
|
*** k-joseph has joined #openmrs
|
19:41:16
|
*** djazayeri has joined #openmrs
|
19:41:17
|
*** ChanServ sets mode: +o djazayeri
|
19:44:18
|
*** k-joseph has quit IRC
|
20:03:30
|
*** djazayeri has quit IRC
|
20:24:10
|
*** raonyguimaraes has joined #openmrs
|
20:26:09
|
<dkayiwa> dahde: hi
|
20:27:39
|
<dahde> dkayiwa: Hey!
|
20:27:55
|
<dkayiwa> dahde: did u see my comment? :)
|
20:28:02
|
<dahde> dkayiwa: was hoping you were here before I made the last commit
|
20:28:37
|
<dahde> dkayiwa: you just made another one? or the one about voiding existing names instead of clearing and adding another one?
|
20:29:57
|
<dkayiwa> dahde: the one about Do you notice that Travis is failing?
|
20:31:06
|
<dahde> dkayiwa: that's def a new one...lemme go check
|
20:31:33
|
<dahde> dkayiwa: Now I dont even know what Travis is :)
|
20:31:55
|
<dkayiwa> dahde: Just talk nicely to Mr Google :)
|
20:32:18
|
<dahde> dkayiwa: hahaha...already doing that
|
20:32:19
|
<OpenMRSBot> Recent updates in the world of openmrsci: SON-PAPERRECORD-41 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-PAPERRECORD-41>
|
20:34:27
|
<dkayiwa> dahde: but even if you do not know what it is, the link i gave on the ticket is enough to show you the error log :0
|
20:34:29
|
<dahde> dkayiwa: compilation error? hmmm...let see
|
20:34:46
|
<dkayiwa> dahde: oh yes
|
20:35:36
|
<dahde> dkayiwa: Interesting I did not get it on my local copy...lemme check whats up
|
20:36:35
|
<dkayiwa> dahde: ok
|
20:40:37
|
<dahde> dkayiwa: first all, this is a build failure not a TEST failure...do you think the changes in the test is responsible? My first thought would be no
|
20:40:49
|
<dahde> dkayiwa: building my local copy now, let's see
|
20:41:07
|
<dkayiwa> dahde: do you have any uncommitted changes?
|
20:48:19
|
*** GitHub181 has joined #openmrs
|
20:48:19
|
<GitHub181> [openmrs-core] dkayiwa pushed 1 new commit to master: http://git.io/a7rJvg
|
20:48:19
|
<GitHub181> openmrs-core/master 69e6611 dkayiwa: Doing some code formatting
|
20:48:19
|
*** GitHub181 has left #openmrs
|
20:50:48
|
<dahde> dkayiwa: yes I had...missing import...added and pushed...but still does not explain the error I now get when I build
|
20:51:38
|
<dkayiwa> dahde: do you get the error locally?
|
20:52:02
|
<dahde> dkayiwa: I get "org.openmrs.api.APIException: contextDAO is null"
|
20:52:27
|
<dkayiwa> dahde: is that when you do an mvn clean install?
|
20:53:16
|
<dahde> dkayiwa: no...when I try to start the app in Jetty
|
20:54:13
|
<dkayiwa> dahde: first do
|
20:54:25
|
<dkayiwa> mvn clean install
|
20:54:34
|
<dahde> dkayiwa: okidoki!
|
20:57:38
|
*** travis-ci has joined #openmrs
|
20:57:38
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [69e6611] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/13445772
|
20:57:38
|
*** travis-ci has left #openmrs
|
20:57:42
|
<OpenMRSBot> <http://ln-s.net/:Sir> (at travis-ci.org)
|
21:06:20
|
<dahde> dkayiwa: build was successful
|
21:06:35
|
<dkayiwa> dahde: ok
|
21:06:58
|
<dkayiwa> dahde: no local changes?
|
21:07:08
|
<dahde> dkayiwa: And I see a message from travis-ci too saying build passed
|
21:07:39
|
<dkayiwa> dahde: that is different from your pull request because it has not yet been merged :)
|
21:08:02
|
<dahde> dkayiwa: One...a missing import...Still fighting with my the new Import settings :|
|
21:08:24
|
<dahde> dkayiwa: with my* new import settings :|
|
21:09:00
|
<dahde> dkayiwa: I already pushed the changes...what next now?
|
21:09:27
|
<dkayiwa> dahde: did you fix the error reported by travis?
|
21:11:19
|
<dahde> dahde: yes it would fix it...the travis error log is about the missing Set import
|
21:11:37
|
<dkayiwa> dahde: yes
|
21:11:58
|
<dahde> dkayiwa: see line 1614 of the log
|
21:12:38
|
<dkayiwa> dahde: now can you see that Travis is happy on your pull request? :)
|
21:14:46
|
<dahde> dkayiwa: hmmm interesting...this is quite cool
|
21:14:59
|
<dkayiwa> dahde: infact hot :)
|
21:15:00
|
<dahde> dkayiwa: looing at the travis-ci dashboard now
|
21:15:30
|
<dahde> dkayiwa: and yest I could see that with the lastest pull request the build is green...nice :)
|
21:16:30
|
*** GitHub36 has joined #openmrs
|
21:16:30
|
<GitHub36> [openmrs-core] dkayiwa closed pull request #433: Trunk 3257: Add junit test for searching on voided patient names (master...TRUNK-3257) http://git.io/R6eSGA
|
21:16:30
|
*** GitHub36 has left #openmrs
|
21:16:30
|
*** GitHub109 has joined #openmrs
|
21:16:30
|
<GitHub109> [openmrs-core] dkayiwa pushed 7 new commits to master: http://git.io/YHeJVw
|
21:16:30
|
<GitHub109> openmrs-core/master eceb981 lc-daderemi: Updated comments and javadocs for HibernatePatient#getPatients method and test
|
21:16:30
|
<GitHub109> openmrs-core/master 8a98beb lc-daderemi: TRUNK-3257 Added Junit test for searching on voided patient names
|
21:16:30
|
<GitHub109> openmrs-core/master f7590e2 lc-daderemi: Cleaned up Javadoc typo and Imports statements to adhere more to projetcs guideline
|
21:16:30
|
*** GitHub109 has left #openmrs
|
21:16:37
|
<dahde> dkayiwa: Now I know to always check travis ;)
|
21:16:44
|
<dkayiwa> dahde: oh yes :)
|
21:17:41
|
*** djazayeri has joined #openmrs
|
21:17:41
|
*** ChanServ sets mode: +o djazayeri
|
21:17:52
|
<dahde> dkayiwa: Thanks man for the pointers...getting to see how things fits together little by little
|
21:18:08
|
<dkayiwa> dahde: thats how we all start :)
|
21:19:21
|
<dahde> dkayiwa: :) Just also downloaded the book you guys just released "Contributing to OpenMRS: Getting Started as a Developer" would give it a read next weekend!
|
21:20:00
|
<dkayiwa> dahde: that will be Gold for you man!!! :)
|
21:20:21
|
<dkayiwa> dahde: fill us with lots of feedback on how to improve it :)
|
21:20:45
|
<dahde> dkayiwa: okidoki! would def do that!
|
21:26:55
|
<dkayiwa> dahde: did you just forget to hit the request cide review button?
|
21:27:05
|
<dkayiwa> cide = code :)
|
21:27:12
|
*** travis-ci has joined #openmrs
|
21:27:13
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [c5b7701] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/13446676
|
21:27:13
|
*** travis-ci has left #openmrs
|
21:27:16
|
<OpenMRSBot> <http://ln-s.net/:SkH> (at travis-ci.org)
|
21:27:47
|
<dkayiwa> dahde: now the above is the travis for a merge of your pull request :)
|
21:32:03
|
*** dahde has quit IRC
|
21:43:33
|
*** dahde has joined #openmrs
|
21:43:54
|
<dahde> dkayiwa: stepped away for a bit..
|
21:44:02
|
<dkayiwa> dahde: ok
|
21:44:51
|
<dahde> dkayiwa: hmmm...cant seem to see the code review button!
|
21:45:02
|
<dkayiwa> dahde: i did it for u
|
21:45:29
|
<dahde> dkayiwa: yes...just notice the status is already that
|
21:46:16
|
<dahde> dkayiwa: what happens next? should'nt the ticket be resolved/closed? Resolution still says unresolved :|
|
21:46:39
|
<dkayiwa> dahde: waiting for one more reviewer
|
21:46:57
|
<dkayiwa> dahde: just go for another ticket
|
21:47:22
|
<dahde> dkayiwa: oh cool...then my work on that is done...assuming nothing else is recommended!
|
21:47:43
|
<dkayiwa> dahde: yes :)
|
21:48:17
|
<dahde> dkayiwa: sure would do...need to call it a day now...back to work tomorrow...would hunt around for another ticket next weekend :)
|
21:48:40
|
<dkayiwa> dahde: thanks man!!!
|
21:49:17
|
<dahde> dkayiwa: you welcome!
|
22:16:27
|
*** djazayeri has quit IRC
|
22:30:12
|
*** dkayiwa has left #openmrs
|
23:15:09
|
*** djazayeri has joined #openmrs
|
23:15:10
|
*** ChanServ sets mode: +o djazayeri
|
23:38:44
|
*** robbyoconnor has quit IRC
|
23:38:48
|
*** r0bby_ has joined #openmrs
|
23:38:48
|
*** ChanServ sets mode: +v r0bby_
|
23:48:22
|
*** r0bby_ has quit IRC
|
23:48:49
|
*** r0bby_ has joined #openmrs
|
23:48:49
|
*** ChanServ sets mode: +v r0bby_
|