IRC Chat : 2013-11-02 - OpenMRS

00:34:30 *** LeeBreisacher has joined #openmrs
00:42:51 *** djazayeri has quit IRC
01:02:47 *** djazayeri has joined #openmrs
01:02:57 *** ChanServ sets mode: +o djazayeri
01:19:32 *** harshadura has joined #openmrs
01:19:32 *** ChanServ sets mode: +v harshadura
01:42:49 *** djazayeri has quit IRC
01:54:28 *** harshadura_ has joined #openmrs
01:57:16 *** harshadura has quit IRC
01:57:46 *** harsz89 has quit IRC
02:09:41 *** harsz89 has joined #openmrs
02:09:42 *** ChanServ sets mode: +v harsz89
02:23:50 *** cospih_ has quit IRC
02:41:23 *** shruthd has joined #openmrs
02:46:50 *** LeeBreisacher has left #openmrs
03:00:56 *** harshadura has joined #openmrs
03:00:56 *** ChanServ sets mode: +v harshadura
03:01:48 *** harshadura_ has quit IRC
03:45:19 *** shruthd has joined #openmrs
03:48:54 *** shruthd has quit IRC
04:03:36 <OpenMRSBot> Recent updates in the world of openmrsci: SON-REPORTINGUI-39 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-REPORTINGUI-39> || SON-REGISCORE-46 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-REGISCORE-46> || SON-REGISCORE-44 has FAILED : Manual build by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/SON-REGISCORE-44> || SON-IDGEN-39 has FAILED : Manual build by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/SON-IDGEN-39> || SON-IDGEN-38 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-IDGEN-38> || SON-DISPENSING-37 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-DISPENSING-37> || SON-REGISCORE-43 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-REGISCORE-43> || SON-IDGEN-36 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-IDGEN-36> || REFAPP-DEMO-13 has FAILED : Manual build by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-DEMO-13> || REFAPP-DEMO-12 has FAILED : Rebuilt by Rafał Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-DEMO-12> || REFAPP-DEMO-11 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/REFAPP-DEMO-11> || CA-CA-399 has FAILED : Dependant of EMRAPI-EMRAPI-226 <https://ci-stg.openmrs.org/browse/CA-CA-399> || EMRAPI-EMRAPI-224 has FAILED (1 tests failed) : Triggered by child REFMETA-REFMETA <https://ci-stg.openmrs.org/browse/EMRAPI-EMRAPI-224> || REFAPP-DEMO-9 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/REFAPP-DEMO-9> || RC-RC-47 has FAILED (1 tests failed) : Dependant of TRUNK-LATEST-107 <https://ci-stg.openmrs.org/browse/RC-RC-47> || HFEUI-HFEUI-127 has FAILED (1 tests failed) : Dependant of APPUI-APPUI-102 <https://ci-stg.openmrs.org/browse/HFEUI-HFEUI-127> || REFAPP-DEMO-8 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/REFAPP-DEMO-8> || REFAPP-DEMO-7 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/REFAPP-DEMO-7> || SON-REGISCORE-39 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-REGISCORE-39> || REFAPP-DEMO-6 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/REFAPP-DEMO-6>
04:13:36 <OpenMRSBot> Recent updates in the world of openmrsci: SON-EMRAPI-42 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-EMRAPI-42>
05:35:38 *** shruthd has joined #openmrs
05:42:55 *** harsz89 has quit IRC
05:53:51 *** harsz89 has joined #openmrs
05:53:51 *** ChanServ sets mode: +v harsz89
06:10:04 *** shruthd has quit IRC
06:15:23 *** shruthd has joined #openmrs
07:11:41 *** shruthd has quit IRC
09:06:05 *** shruthd has joined #openmrs
09:43:06 *** shruthd has quit IRC
10:14:30 *** shruthd has joined #openmrs
10:14:58 *** shruthd has quit IRC
10:30:27 *** shruthd has joined #openmrs
10:33:45 *** harsha89 has joined #openmrs
10:35:58 *** harsz89 has quit IRC
10:39:15 *** harsha89 has quit IRC
10:47:41 *** shruthd has quit IRC
11:10:39 *** harsz89 has joined #openmrs
11:10:40 *** ChanServ sets mode: +v harsz89
13:02:49 *** harshadura_ has joined #openmrs
13:05:01 *** harshadura has quit IRC
14:04:46 *** raonyguimaraes has joined #openmrs
14:22:56 *** DraggonZ has quit IRC
14:22:57 *** lstanisic has quit IRC
14:22:57 *** downey has quit IRC
14:22:57 *** akwatuha__ has quit IRC
14:22:57 *** nribeka has quit IRC
14:22:57 *** h3llborn has quit IRC
14:22:57 *** djazayeri_may_be has quit IRC
14:22:57 *** jkeiper has quit IRC
14:22:57 *** ibewes has quit IRC
14:47:31 *** downey has joined #openmrs
14:47:31 *** ChanServ sets mode: +o downey
14:47:33 *** nribeka has joined #openmrs
14:47:34 *** ChanServ sets mode: +v nribeka
14:47:34 *** jkeiper has joined #openmrs
14:47:34 *** ChanServ sets mode: +v jkeiper
14:47:42 *** djazayeri_may_be has joined #openmrs
14:48:02 *** akwatuha__ has joined #openmrs
14:48:46 *** lstanisic has joined #openmrs
14:49:21 *** DraggonZ has joined #openmrs
14:49:21 *** h3llborn has joined #openmrs
14:49:21 *** ChanServ sets mode: +v DraggonZ
14:49:21 *** ChanServ sets mode: +v h3llborn
14:55:16 *** ibewes has joined #openmrs
15:01:17 *** akwatuha__ has quit IRC
15:02:04 *** akwatuha__ has joined #openmrs
15:18:47 *** raonyguimaraes has quit IRC
15:19:29 *** nribeka has quit IRC
15:19:52 *** nribeka has joined #openmrs
15:19:52 *** ChanServ sets mode: +v nribeka
15:31:16 *** raonyguimaraes has joined #openmrs
15:34:21 *** shruthd has joined #openmrs
15:39:58 *** dahde has joined #openmrs
15:47:32 <dahde> Hoi people...got a rookie question regarding how TEST works in Junit...
15:47:40 <dahde> anybody here who could help?
16:29:09 <dahde> In the TESTS, I see values being used for the tests conditions...like "dead-papa", "voided-bravo", "papa" etc
16:30:13 <dahde> How does this values come to be? Tried looking at the respective tables but seems am looking wrongly :|
16:30:43 <dahde> Anyone who can provide a guided clarification on this? Dank
16:34:23 *** wluyima has joined #openmrs
16:41:20 *** shruthd has quit IRC
17:05:36 *** dahde has quit IRC
17:23:44 *** djazayeri has joined #openmrs
17:23:44 *** ChanServ sets mode: +o djazayeri
17:34:37 *** dkayiwa has joined #openmrs
17:39:13 *** dkayiwa_ has joined #openmrs
17:41:09 *** dkayiwa has quit IRC
17:41:10 *** dkayiwa_ is now known as dkayiwa
17:47:51 *** wluyima has quit IRC
17:48:09 *** djazayeri1 has joined #openmrs
17:50:21 *** raonyguimaraes has quit IRC
17:50:25 *** djazayeri has quit IRC
17:56:49 *** djazayeri1 has quit IRC
18:01:13 *** djazayeri has joined #openmrs
18:01:13 *** ChanServ sets mode: +o djazayeri
18:28:27 *** k-joseph has joined #openmrs
19:07:23 *** isaac has joined #openmrs
19:15:35 *** isaac_ has joined #openmrs
19:15:36 *** isaac has quit IRC
19:19:51 *** isaac_ has quit IRC
19:23:06 *** dkayiwa has quit IRC
19:28:48 *** isaac has joined #openmrs
19:31:17 *** dkayiwa has joined #openmrs
19:36:13 *** isaac has quit IRC
19:38:13 *** harsz89 has quit IRC
19:39:29 *** robbyoconnor has joined #openmrs
19:39:29 *** ChanServ sets mode: +v robbyoconnor
19:50:24 *** shruthd has joined #openmrs
20:17:02 *** dahde has joined #openmrs
20:17:48 <dahde> Ha...found this https://github.com/openmrs/openmrs-core/blob/master/api/src/test/resources/org/openmrs/include/standardTestDataset.xml and the doc on Jira...Guess I can now sort myself out now!
20:17:51 <OpenMRSBot> <http://ln-s.net/:Rvz> (at github.com)
20:50:05 *** raonyguimaraes has joined #openmrs
20:51:58 *** shruthd has quit IRC
20:51:58 *** k-joseph has quit IRC
21:13:16 *** k-joseph has joined #openmrs
21:13:40 *** djazayeri has quit IRC
21:14:13 <k-joseph> dkayiwa: hi
21:30:09 <dkayiwa> k-joseph: hi
21:32:05 <dahde> Hoi dkayiwa
21:32:12 <dkayiwa> dahde: hi
21:32:50 <dahde> dkayiwa: got a clarification question regarding https://tickets.openmrs.org/browse/TRUNK-3257
21:33:27 <dkayiwa> dahde: ok
21:33:48 <dahde> dkayiwa: should we have a private chat, or talk here, or move the question to the comments thread?
21:35:20 <dkayiwa> dahde: private chat if you do not want anyone else here to help you :)
21:37:02 <dahde> dkayiwa: hahaha! more like not bothering the good people here with petty bug fixing things! :p I buzz you now
21:37:45 <dkayiwa> dahde: i do not know everything. and am not a bad person :)
21:38:34 <dkayiwa> dahde: if you do not ask publicly, you will not get help from others :)
21:39:10 <dkayiwa> dahde: and i do not know everything. besides it is only the private chats that are logged for others to search for past solutions
21:39:31 <dkayiwa> i meant public chats are the only ones logged
21:39:47 <dahde> dadhe:okidoki...the question is actually specific to what you said in the comments
21:40:10 <dahde> dkayiwa:okidoki...the question is actually specific to what you said in the comments
21:40:20 <dahde> dkayiwa: You said the "commit is about voided patients instead of patient names."
21:40:31 <dkayiwa> dahde: another disadvantage of private chats is that, i may go away from my computer and you here me not for hours. but since you asked publicly, anyone else can take over :) I gues syou are now convinced :)
21:41:22 <dahde> dkayiwa: Testing for voided patients made sense...but your comment about testing for voided names is not explicit...is it Testing the method when search is made for Patient object whose name has been voided?
21:42:13 <dahde> dkayiwa: Yeah...Am now convinced. :p
21:43:40 <dkayiwa> dahde: looks like the ticket description does not match the TODO
21:43:40 *** k-joseph has quit IRC
21:44:24 <dahde> dkayiwa: Yeah...it is sort of ambiguous
21:48:01 <dkayiwa> dahde: let me just close the ticket. thanks :)
21:48:42 <dkayiwa> dahde: oh wait
21:48:55 <dkayiwa> dahde: the TODO was for patient names. it was just changed
21:49:12 <dkayiwa> dahde: as you can see here: https://github.com/openmrs/openmrs-core/commit/ed03fefbfb8a428d634ab77017f47f584d23656b
21:49:16 <OpenMRSBot> <http://ln-s.net/:RzO> (at github.com)
21:49:28 <dahde> Yes...I saw that too
21:49:57 <dkayiwa> dahde: so add a test for names
21:50:38 <dahde> dkayiwa: which was the clarification question...test if voided names is searched?
21:50:57 <dkayiwa> dahde: yes
21:52:17 <dahde> dkayiwa: but the question then is, what assurance does such a test give? The Method itself cant be called without specifying a String which is the name
21:52:38 <dahde> dkayiwa: is not then testing for such reduntant?
21:54:38 <dkayiwa> dahde: i was thinking that the method to test is getPatients() when given a voided name
21:55:13 <dahde> dkayiwa: I could write a test that assets nothing is returned when no name is given
21:55:40 <dahde> dkayiwa: yeah exactly...
21:55:48 <dkayiwa> dahde: a test which a asserts that nothing is returning when an existing voided name is passed in
21:56:05 <dkayiwa> dahde: but which returns results when the same name is not voided
21:56:26 <dahde> dkayiwa: cool! that's what I thought it should be
21:57:35 <dahde> dkayiwa: Thanks! It's a Rookie question I know...just wanted to make sure :p you would recieve my pull request soon
21:58:48 <dkayiwa> dahde: oh yes will review it immediately :)
22:28:03 *** dkayiwa has left #openmrs
22:59:16 *** shruthd has joined #openmrs
23:01:25 *** harshadura__ has joined #openmrs
23:04:36 *** harshadura_ has quit IRC