02:17:03
|
*** jb360 has joined #openmrs
|
02:17:18
|
*** jeffblack360 has joined #openmrs
|
02:17:34
|
*** breeze has joined #openmrs
|
02:18:33
|
*** breeze has quit IRC
|
02:21:34
|
*** shruthd has joined #openmrs
|
03:04:27
|
*** djazayeri has quit IRC
|
03:19:40
|
*** djazayeri has joined #openmrs
|
03:19:40
|
*** ChanServ sets mode: +o djazayeri
|
03:30:53
|
*** djazayeri has quit IRC
|
03:34:10
|
*** jeffblack360 has quit IRC
|
03:34:55
|
*** jb360 has quit IRC
|
03:46:49
|
*** shruthd has quit IRC
|
04:21:33
|
*** LeeBreisacher has left #openmrs
|
04:23:03
|
*** shruthd has joined #openmrs
|
04:36:03
|
*** robbyoconnor has joined #openmrs
|
04:36:03
|
*** ChanServ sets mode: +v robbyoconnor
|
04:37:17
|
*** shruthd has joined #openmrs
|
05:49:28
|
*** shruthd has quit IRC
|
05:50:57
|
*** shruthd has joined #openmrs
|
05:55:18
|
*** shruthd has quit IRC
|
06:07:14
|
*** shruthd has joined #openmrs
|
06:37:37
|
*** shruthd has quit IRC
|
06:49:42
|
*** shruthd has joined #openmrs
|
07:04:23
|
*** shruthd has quit IRC
|
07:29:22
|
*** dkayiwa has joined #openmrs
|
07:32:11
|
*** dkayiwa_ has joined #openmrs
|
07:33:45
|
*** dkayiwa has quit IRC
|
07:33:46
|
*** dkayiwa_ is now known as dkayiwa
|
09:01:20
|
*** shruthd has joined #openmrs
|
09:06:09
|
*** shruthd has quit IRC
|
09:16:29
|
*** k-joseph has joined #openmrs
|
09:20:59
|
*** dkayiwa has quit IRC
|
09:21:07
|
*** shruthd has joined #openmrs
|
09:32:27
|
*** shruthd has quit IRC
|
09:34:01
|
*** k-joseph has quit IRC
|
10:01:40
|
*** shruthd has joined #openmrs
|
10:29:53
|
*** raonyguimaraes has joined #openmrs
|
10:41:53
|
*** k-joseph has joined #openmrs
|
10:43:07
|
*** raonyguimaraes has quit IRC
|
11:11:50
|
*** k-joseph has quit IRC
|
11:21:40
|
*** k-joseph has joined #openmrs
|
11:25:16
|
*** shruthd has quit IRC
|
11:25:43
|
*** isaac___ has joined #openmrs
|
11:27:01
|
*** k-joseph has quit IRC
|
12:12:20
|
<OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1426 has FAILED : Updated by Rafal Korytkowski <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1426>
|
12:15:21
|
*** harshadura has joined #openmrs
|
12:15:21
|
*** ChanServ sets mode: +v harshadura
|
12:47:43
|
*** isaac___ has quit IRC
|
12:53:14
|
*** davidpardz has joined #openmrs
|
12:53:44
|
*** ChanServ sets mode: +v davidpardz
|
13:09:20
|
*** robbyoconnor has quit IRC
|
13:26:45
|
*** djazayeri has joined #openmrs
|
13:26:45
|
*** ChanServ sets mode: +o djazayeri
|
13:34:07
|
<djazayeri> rafa: you there?
|
13:34:14
|
*** LeeBreisacher has joined #openmrs
|
13:34:16
|
<rafa> djazayeri: on the univ call
|
13:34:22
|
<djazayeri> oh right
|
13:34:50
|
*** rfriedman has joined #openmrs
|
13:40:43
|
*** downey changes topic to "OpenMRS: open source medical record systems for the developing world - http://openmrs.org/ - IRC info & logs: http://go.openmrs.org/irc - Can't find the answer here? Try http://answers.openmrs.org/"
|
13:48:17
|
*** harshadura_ has joined #openmrs
|
13:50:02
|
<rfriedman> rafa, got a minute?
|
13:51:25
|
*** rfriedman is now known as djazayeri_wanna_
|
13:51:26
|
*** harshadura has quit IRC
|
13:51:48
|
*** djazayeri_wanna_ is now known as djazayeriwannabe
|
13:53:23
|
<djazayeriwannabe> jkeiper, got a minute?
|
13:54:13
|
<jkeiper> djazayeriwannabe: yes
|
13:54:43
|
<djazayeriwannabe> jkeiper, i need to do a modal dialog, i'm having trouble using openmrs:portlet
|
13:55:04
|
<djazayeriwannabe> jkeiper, is there a good example i can follow, or should I go with the jquery jqModal?
|
13:55:22
|
* djazayeri looks curiously at the users on this channel...
|
13:55:57
|
<jkeiper> djazayeriwannabe: you want to use a portlet in your dialog?
|
13:56:10
|
<djazayeriwannabe> djazayeri, if this is pinging you, i'll change :)
|
13:56:25
|
<djazayeriwannabe> jkeiper, use a portlet to implement the modal dialog
|
13:56:35
|
<djazayeri> djazayeriwannabe: surprisingly it doesn't
|
13:56:47
|
<jkeiper> djazayeriwannabe: so, put all the code for a modal dialog in the portlet itself?
|
13:56:56
|
<djazayeriwannabe> jkeiper, yes
|
13:57:12
|
<jkeiper> djazayeriwannabe: do you have it somewhere i can see it?
|
13:57:45
|
<djazayeriwannabe> jkeiper, could put it at github
|
14:00:17
|
<jkeiper> djazayeriwannabe: well, what's not working?
|
14:01:28
|
<djazayeriwannabe> jkeiper, github.com/r-friedman/openmrs-module-integration/api1
|
14:01:32
|
*** Mkop has quit IRC
|
14:02:07
|
<jkeiper> djazayeriwannabe: i get a 404 on that
|
14:03:17
|
<djazayeriwannabe> api1 is the branch
|
14:03:49
|
<djazayeriwannabe> jkeiper, api1 is the branch, dhisApi is the portlet
|
14:04:50
|
<djazayeriwannabe> jkeiper, i've never done this before, i have been thrashing around with this for days, it seems like it ought to be easy
|
14:05:07
|
*** djazayeriwannabe is now known as rfriedman
|
14:06:04
|
<jkeiper> rfriedman: ok, lemme see ...
|
14:06:31
|
<cpower> djazayeri: Sorry I missed RA standup having (still am) PC issues
|
14:06:42
|
<cpower> and now for Scrum!
|
14:06:48
|
<cpower> !scrumon cpower
|
14:06:48
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
14:08:53
|
<cpower> I want to take a moment and ask the question if the current 10am scrum is serving as a benefit to anyone? We need to have standups and communicate, but if this format (IRC), time, etc isn't working for you. Let me know, happy to see what we can do to get you more involved. An email with the same question will be sent out later today.
|
14:09:39
|
<cpower> Going back to the orginal format for a quick scrum
|
14:10:18
|
<cpower> Order: djazayeri , rafa , h3llborn , and anyone who has anything they would like to discuss about OpenMRS
|
14:11:05
|
<djazayeri> Testing out the standalone candidate that Rafal put together
|
14:11:12
|
<djazayeri> Otherwise working on reports for Mirebalais
|
14:11:34
|
<djazayeri> Need to rewrite the "Download" page on OpenMRS.org for when we release this later this week.
|
14:11:36
|
<djazayeri> no blockers
|
14:12:24
|
<cpower> rafa: you are up
|
14:12:50
|
<rafa> Today:
|
14:12:51
|
<rafa> * Fixed RA-262
|
14:12:51
|
<rafa> Should not display basic authentication dialog when session times out in coreapps
|
14:12:51
|
<rafa> https://tickets.openmrs.org/browse/RA-262
|
14:12:51
|
<rafa> * Prepared EMR 2.0 standalone
|
14:12:51
|
<rafa> * Design call
|
14:12:51
|
<rafa> No blockers.
|
14:18:14
|
<LeeBreisacher> djazayeri, rafa: I get the same problem with standalone Vitals
|
14:18:27
|
<cpower> sorry h3llborn you there?
|
14:18:39
|
<cpower> if not, announcements
|
14:19:15
|
*** robbyoconnor has joined #openmrs
|
14:19:15
|
*** ChanServ sets mode: +v robbyoconnor
|
14:20:48
|
<cpower> PM call this afternoon will be about Order Entry sprint planning, Volunteers and interaction, A better Sprint Backlog page, Documentation (if we have time), and open discussion. Design call following it: More Design time on Order Entry and I'm still awaiting a response back from James Arbaugh or Tobin if they want time to discuss their upcomming sprints.
|
14:20:53
|
<cpower> !scrumoff
|
14:20:53
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:21:20
|
<rfriedman> cpower, what upcoming sprints?
|
14:22:49
|
<cpower> rfriedman: James Arbaugh has some Form Entry work, Tobin has some improvements to a scheduler, and two others I can't recall off the top of my head
|
14:23:22
|
<LeeBreisacher> djazayeri, rafa: the line of code that sets the form is this:
|
14:23:22
|
<LeeBreisacher> encounter.setForm(Context.getFormService().getForm("Vitals"));
|
14:23:27
|
<rfriedman> cpower, is there a wiki page? is tobin's scheduler the appointment scheduler or the openmrs scheduler?
|
14:23:53
|
<LeeBreisacher> djazayeri, rafa: Is it possible there is no form named "Vitals"?
|
14:24:48
|
<cpower> Not yet, this is all things that came out of the conference that I'm still collecting and building some format for. We are in the process of getting our community communication back together again after a long Reference Application focus.
|
14:25:09
|
<cpower> rfriedman: in short stay tuned, it's comming
|
14:25:30
|
<djazayeri> LeeBreisacher, rafa: I think the problem is that the Vitals form doesn't actually exist yet the first time you run things. It gets created by the referenceapplication module
|
14:25:33
|
<rfriedman> cpower, comming is something else
|
14:25:40
|
<LeeBreisacher> djazayeri, rafa: hm, checked Admin/ManageForms, it's there
|
14:25:51
|
<djazayeri> rfriedman: it's followup work on the appointment module
|
14:26:02
|
<LeeBreisacher> djazayeri: ah! that would explain it. startup order again?
|
14:26:04
|
<rfriedman> djazayeri, tks
|
14:26:41
|
<djazayeri> LeeBreisacher, rafa: A possible fix is to create a form with the correct name and UUID in the reference demo data module
|
14:26:52
|
<djazayeri> LeeBreisacher: so that the referenceapplication module can just pick that up.
|
14:26:55
|
<LeeBreisacher> djazayeri, rafa: can we arrange it so the demo data is that last thing done?
|
14:27:48
|
<djazayeri> LeeBreisacher: we could do that too â instead of creating the demo patients in the activator, we could have it schedule a process to create them "later".
|
14:28:01
|
<LeeBreisacher> djazayeri: why didn't I run into this problem when I tested it locally?
|
14:28:13
|
<djazayeri> LeeBreisacher: alternately, perhaps we could change things around in the referenceapplication module so that it creates the Vitals form earlier?
|
14:29:14
|
<djazayeri> LeeBreisacher: were you installing it clean?
|
14:29:29
|
<LeeBreisacher> djazayeri: hm. probably not..
|
14:29:50
|
<rfriedman> jkeiper, i have a short meeting at 10:30, back in 15 mins at most
|
14:29:56
|
<LeeBreisacher> djazayeri: I see. so there was a Vitals form in my local db. darn. sorry...
|
14:29:59
|
*** rfriedman is now known as rfriedman_away
|
14:30:17
|
<jkeiper> rfriedman_away: oh yeah, i think it's because you used $( instead of $j(
|
14:30:21
|
<djazayeri> LeeBreisacher: do you refer to any other forms?
|
14:31:01
|
<LeeBreisacher> djazayeri: yes..Visit Note
|
14:31:14
|
<rfriedman_away> jkeiper, ok, tks, I had already gotten pointed in that direction, but I reverted and lost my changes ... will do it
|
14:32:34
|
<djazayeri> LeeBreisacher: Visit Note seems to behave fine with form == null though, which makes sense since we're not relying on its specific styling and layout
|
14:32:35
|
<LeeBreisacher> djazayeri: which seems to be ok.
|
14:32:47
|
<LeeBreisacher> djazayeri: ah
|
14:32:51
|
*** robbyoconnor has quit IRC
|
14:37:05
|
*** robbyoconnor has joined #openmrs
|
14:37:05
|
*** ChanServ sets mode: +v robbyoconnor
|
14:38:26
|
<djazayeri> LeeBreisacher: I wrote my preferred fix at https://tickets.openmrs.org/browse/RA-264
|
14:38:43
|
<djazayeri> LeeBreisacher: will you have time to fix that at some point today?
|
14:39:52
|
<LeeBreisacher> djazayeri: yes, I have time, but not sure what to do. there's just an API for "create form" ?
|
14:41:17
|
*** davidpardz has left #openmrs
|
14:41:42
|
<djazayeri> LeeBreisacher: new Form(); â¦setName("Vitals); ⦠Context.getFormService().saveForm(form);
|
14:42:26
|
<LeeBreisacher> djazayeri: ok, I'll give it a shot. I assume you'll be around for questions...
|
14:42:45
|
<djazayeri> LeeBreisacher: I have lots of calls today, but I'll be at the computer at least
|
14:43:09
|
<LeeBreisacher> djazayeri: ok, it'll be an hour or so..
|
14:45:37
|
*** harshadura_ has quit IRC
|
15:06:53
|
<LeeBreisacher> djazayeri: code is written, not committed, not tested. do you want to code-review first, or should I just go for it?
|
15:07:16
|
<djazayeri> LeeBreisacher: if you want to send it with pastebin or gist, I'll look
|
15:08:01
|
<LeeBreisacher> djazayeri: how about an ordinary pull request?
|
15:08:07
|
<djazayeri> LeeBreisacher: sure
|
15:08:56
|
*** robbyoconnor has quit IRC
|
15:12:19
|
<LeeBreisacher> djazayeri: https://github.com/openmrs/openmrs-module-referencedemodata/pull/1
|
15:12:23
|
<OpenMRSBot> <http://ln-s.net/:J8R> (at github.com)
|
15:13:48
|
<djazayeri> LeeBreisacher: looks good, merged it
|
15:14:30
|
<LeeBreisacher> djazayeri: have you seen emails about how long it takes to create all this data? seems we should fix that..
|
15:15:23
|
<djazayeri> LeeBreisacher: I've seen them. I agree that it's non-ideal. I don't think it's a blocker for the 2.0 release though. We should address it in 2.1
|
15:15:52
|
<LeeBreisacher> djazayeri: we could reduce the quantity though. 50? 25?
|
15:16:45
|
<djazayeri> LeeBreisacher: Yeah, we could do that. And I guess it doesn't require tagging/releasing anything to change that value in the standalone scripts
|
15:19:44
|
<LeeBreisacher> djazayeri: yes. one setting in liquibase-demo-data.xml
|
15:27:26
|
<djazayeri> LeeBreisacher: tell burke what the names of demo patients are
|
15:32:30
|
<LeeBreisacher> burke: the demo patient names are chosen from some random first and last names. I'll send email..
|
15:57:53
|
<LeeBreisacher> djazayeri: hm, that didn't seem to fix it.
|
15:58:16
|
<djazayeri> LeeBreisacher: hmm, that's annoying. You're sure it went all the way through the build before testing?
|
15:58:19
|
<LeeBreisacher> djazayeri: I just downloaded latest standalone, Vitals are still not showing
|
15:58:38
|
<LeeBreisacher> djazayeri: pretty sure, going by the bamboo builds.
|
16:00:08
|
<djazayeri> LeeBreisacher: same error?
|
16:00:50
|
<LeeBreisacher> djazayeri: I have not actually seen an error. is there something in the log?
|
16:01:02
|
<LeeBreisacher> djazayeri: I just see no Vitals
|
16:01:41
|
<LeeBreisacher> djazayeri: ah, I do see errs in the log
|
16:01:42
|
<djazayeri> LeeBreisacher: maybe js console will tell you
|
16:05:05
|
<LeeBreisacher> djazayeri: to properly diagnose this will require a local clean build, etc. I don't really have time to do that. maybe tonight..
|
16:05:15
|
<djazayeri> LeeBreisacher: okay
|
16:05:26
|
<djazayeri> LeeBreisacher: in theory I can redownload the standalone, unzip, and run again, right?
|
16:05:41
|
<LeeBreisacher> djazayeri: yes
|
16:06:17
|
<djazayeri> LeeBreisacher: I'll try to do this in the background today
|
16:22:52
|
*** harsz89 has joined #openmrs
|
16:22:53
|
*** ChanServ sets mode: +v harsz89
|
16:35:41
|
*** isaac___ has joined #openmrs
|
16:55:53
|
*** shruthd has joined #openmrs
|
16:58:19
|
*** djazayeri has quit IRC
|
16:59:19
|
*** harsz89 has quit IRC
|
17:00:27
|
*** robbyoconnor has joined #openmrs
|
17:00:27
|
*** ChanServ sets mode: +v robbyoconnor
|
17:01:42
|
*** k-joseph has joined #openmrs
|
17:07:31
|
*** djazayeri has joined #openmrs
|
17:07:31
|
*** ChanServ sets mode: +o djazayeri
|
17:15:42
|
*** isaac___ has quit IRC
|
17:15:59
|
*** isaac___ has joined #openmrs
|
17:17:14
|
*** harsz89 has joined #openmrs
|
17:17:14
|
*** ChanServ sets mode: +v harsz89
|
17:29:36
|
*** k-joseph has quit IRC
|
17:30:44
|
*** k-joseph has joined #openmrs
|
17:35:20
|
<djazayeri> rfriedman_away: (will you be on the design call today?)
|
17:35:35
|
<rfriedman_away> djazayeri, yep
|
17:35:39
|
<djazayeri> cool
|
17:35:45
|
*** rfriedman_away is now known as rfriedman
|
17:53:49
|
*** robbyoconnor has quit IRC
|
17:55:16
|
<LeeBreisacher> djazayeri, rafa: I've got a few minutes to look at the Vitals form standalone problem. first question: I want to look at the mysql db, but I cannot figure out the password
|
17:55:40
|
<djazayeri> LeeBreisacher: btw, probably the reason your commit didn't fix things is that I'm guessing that openmrs-distro-referenceapplication isn't pointing to a snapshot of demodata.
|
17:56:08
|
<LeeBreisacher> djazayeri: oh. ok. that's easy to fix?
|
17:56:42
|
<djazayeri> LeeBreisacher: to test it, make a one-line fix to openmrs-distro-referenceapplication's pom.xml, pointing to the latest snapshot
|
17:57:04
|
<djazayeri> LeeBreisacher: if that works, then we need to do a new release of the demodata module, and change the distro to use that new released verion
|
17:57:07
|
<djazayeri> (version)
|
17:57:35
|
<LeeBreisacher> djazayeri: you mean make that pom change locally? or on github?
|
17:57:56
|
<LeeBreisacher> djazayeri: (I'm not really setup for "full" local test)
|
17:58:17
|
<djazayeri> LeeBreisacher: so in that case change it on github, wait for the full build to happen on bamboo, download the standalone from there, and test it
|
17:58:33
|
<LeeBreisacher> djazayeri: that I can do. thanks.
|
18:25:57
|
*** k-joseph has quit IRC
|
18:26:07
|
*** k-joseph has joined #openmrs
|
18:45:11
|
*** isaac___ has quit IRC
|
18:51:04
|
*** k-joseph has quit IRC
|
18:54:03
|
*** harsz89 has quit IRC
|
18:56:01
|
*** isaac___ has joined #openmrs
|
18:58:29
|
*** isaac___ has quit IRC
|
19:00:56
|
<LeeBreisacher> djazayeri: yay, using 1.1-SNAPSHOT of demodata fixed the Vitals problem
|
19:01:09
|
<djazayeri> LeeBreisacher: great!
|
19:01:19
|
<djazayeri> LeeBreisacher: time for another release
|
19:01:27
|
<LeeBreisacher> djazayeri: do we have someone that can do the release?
|
19:01:42
|
<djazayeri> LeeBreisacher: though, before we do that, do you know if the demo data module is the one setting the password for the "admin" user?
|
19:01:50
|
<LeeBreisacher> djazayeri: I've not done that much
|
19:02:15
|
<djazayeri> LeeBreisacher: I noticed that when I chose demo data the login was admin/test instead of admin/Admin123
|
19:02:41
|
<LeeBreisacher> djazayeri: yeah, I've noticed that too. not sure where that is...
|
19:03:00
|
<djazayeri> LeeBreisacher: if you have the demodata code checked out and open, can you search for "test"?
|
19:03:50
|
*** k-joseph has joined #openmrs
|
19:09:15
|
<LeeBreisacher> djazayeri: I cannot find it anywhere. I cannot even find where Admin123 is defined.
|
19:09:30
|
<djazayeri> LeeBreisacher: hmm, it must be in the standalone
|
19:18:36
|
*** shruthd has quit IRC
|
19:22:26
|
<djazayeri> burke: if you have a chance later, can you stop the recording on the design call? :-)
|
19:37:25
|
*** k-joseph has quit IRC
|
19:40:40
|
*** dkayiwa has joined #openmrs
|
19:42:45
|
*** djazayeri has quit IRC
|
19:48:52
|
*** djazayeri has joined #openmrs
|
19:48:52
|
*** ChanServ sets mode: +o djazayeri
|
19:55:18
|
*** k-joseph has joined #openmrs
|
20:04:55
|
<cpower> djazayeri: you have a sec?
|
20:08:56
|
<cpower> Hello all, who can I talk to about cohort builder and custom drug regimens?
|
20:10:40
|
*** shruthd has joined #openmrs
|
20:15:31
|
*** shruthd has quit IRC
|
20:15:51
|
*** shruthd has joined #openmrs
|
20:16:29
|
<djazayeri> cpower: hi
|
20:21:46
|
*** shruthd has quit IRC
|
20:26:32
|
*** rfriedman has quit IRC
|
20:34:30
|
*** wyclif has joined #openmrs
|
21:46:42
|
*** k-joseph has quit IRC
|
22:09:39
|
*** k-joseph has joined #openmrs
|
22:17:33
|
*** robbyoconnor has joined #openmrs
|
22:17:33
|
*** ChanServ sets mode: +v robbyoconnor
|
22:22:03
|
*** wyclif has quit IRC
|
22:23:31
|
*** k-joseph_ has joined #openmrs
|
22:24:18
|
*** k-joseph has quit IRC
|
22:40:55
|
<k-joseph_> :) :)
|
22:40:56
|
*** k-joseph_ is now known as k-joseph
|
22:41:06
|
<k-joseph> :)
|
22:44:12
|
*** shruthd has joined #openmrs
|
22:51:47
|
*** shruthd has quit IRC
|
22:56:21
|
<k-joseph> dkayiwa: hi
|
22:56:44
|
<dkayiwa> k-joseph: hi
|
22:57:50
|
<k-joseph> am solving TRUNK-3903, and am adding a new field wherein i can pick a value for displayPrecision from the UI, and am limited in my understanding currently with the spring:bind,
|
22:58:23
|
<k-joseph> dkayiwa: i want some thing like, <spring:bindpath="command.displayPrecision"> but am not sure what am supposed to enter in as path
|
22:59:56
|
<k-joseph> dkayiwa: i kindly request for assistance about this path value, what is it?
|
23:01:08
|
<dkayiwa> k-joseph: did you have a chance to look at the existing jsp pages that use spring:bind?
|
23:02:14
|
<k-joseph> dkayiwa: yes, i have had that chance, and they use some thing like that forexample, <spring:bindpath="command.precise">
|
23:02:51
|
<dkayiwa> k-joseph: did you try out the same pattern?
|
23:03:20
|
<k-joseph> dkayiwa: i was thinking that because precise in this case is an attribute for ConceptNumeric, then it works
|
23:03:51
|
<dkayiwa> k-joseph: is that an answer to my question? :)
|
23:04:44
|
<k-joseph> dkayiwa: yes, i added the displayPrecision to the same class and used <spring:bindpath="command.displayPrecision"> but it did not show in the UI
|
23:05:26
|
<dkayiwa> k-joseph: what is that class of the object you are passing to the model that is to be displayed in the jsp?
|
23:06:10
|
<k-joseph> dkayiwa: it is ConceptNumeric
|
23:06:28
|
<dkayiwa> k-joseph: does that class have the displayPrecision property?
|
23:07:14
|
<k-joseph> dkayiwa: yes, i added it already
|
23:08:06
|
<dkayiwa> k-joseph: can you copy and paste here the line that declares it in that class
|
23:09:31
|
<k-joseph> dkayiwa: private Integer displayPrecision;
|
23:09:32
|
<k-joseph> dkayiwa: o, sorry,
|
23:09:41
|
<k-joseph> dkayiwa: changed Integer to int,
|
23:09:49
|
<k-joseph> now it is
|
23:09:52
|
<k-joseph> dkayiwa: private int displayPrecision;
|
23:12:01
|
<dkayiwa> k-joseph: why that change?
|
23:18:45
|
<k-joseph> dkayiwa: since displayPrecision is of type int, which is a primitive type from the ticket, but that still does not solve the issue
|
23:18:46
|
<k-joseph> dkayiwa: i still doubt my reason when i concider other properties like private Double lowAbsolute; i therefore still stick on to my previous code i.e. private Integer displayPrecision; trying now to discouver the difference between the two usages
|
23:19:25
|
<dkayiwa> k-joseph: can you make a commit and i review it all round?
|
23:21:33
|
<k-joseph> dkayiwa: ok, doing that now
|
23:33:08
|
<k-joseph> dkayiwa: am commiting currently, still when i have run it again, now i have received a stack trace in the UI where i expected the field to be, the trace is at http://pastebin.com/iTC9qyjW
|
23:33:55
|
<dkayiwa> k-joseph: do you have a getter for it?
|
23:34:39
|
<k-joseph> dkayiwa, yes i do have it, re-confirming again
|
23:34:55
|
<dkayiwa> k-joseph: what is its signature?
|
23:35:10
|
<k-joseph> dkayiwa: yes i do, i have confirmed
|
23:37:46
|
<k-joseph> dkayiwa: not familiar currently with signature, however it is as
|
23:37:47
|
<k-joseph> public Integer getDisplayPrecision() {
|
23:37:47
|
<k-joseph> return displayPrecision;
|
23:37:47
|
<k-joseph> }
|
23:38:40
|
<dkayiwa> k-joseph: can you pastebin the entite class as it is now?
|
23:39:31
|
<dkayiwa> k-joseph: you do not have to
|
23:39:51
|
<dkayiwa> k-joseph: the error message seems to suggest that you need that property also in the ConceptFormBackingObject
|
23:40:07
|
<k-joseph> dkayiwa: ok
|
23:40:14
|
<dkayiwa> k-joseph: can you check what precise looks like in ConceptFormBackingObject?
|
23:41:01
|
<k-joseph> dkayiwa: am not having ConceptFormBackingObject in my openmrs-core local base
|
23:43:42
|
<dkayiwa> k-joseph: can you check in the ConceptFormController class?
|
23:43:49
|
<k-joseph> dkayiwa: finnaly seen it,
|
23:50:55
|
<k-joseph> dkayiwa: great, thanks a lot, that solved the issue
|
23:50:58
|
<k-joseph> :)
|
23:51:12
|
<dkayiwa> k-joseph: ok good!
|
23:51:20
|
<dkayiwa> :)
|
23:59:25
|
*** dkayiwa_ has joined #openmrs
|