| 00:08:48 | *** ciaron has quit IRC |
| 01:13:27 | *** djazayeri has quit IRC |
| 01:16:07 | *** robbyoconnor has joined #openmrs |
| 01:16:07 | *** robbyoconnor has joined #openmrs |
| 01:16:07 | *** ChanServ sets mode: +v robbyoconnor |
| 01:35:52 | *** robbyoconnor has quit IRC |
| 01:44:43 | *** djazayeri has joined #openmrs |
| 01:44:43 | *** ChanServ sets mode: +o djazayeri |
| 01:56:33 | *** shruthd has joined #openmrs |
| 01:58:24 | <shruthd> djazayeri: Hi Darius, thanks for your comments on sql search api |
| 01:58:45 | <shruthd> djazayeri: Is it something that can go to emr-api? |
| 02:00:52 | <shruthd> djazayeri: Sorry, I just read your other mail where you said its fine to add it in emrapi. |
| 02:00:57 | <shruthd> djazayeri: thanks |
| 02:23:10 | *** shruthd has quit IRC |
| 02:46:13 | *** djazayeri has quit IRC |
| 02:57:05 | *** robbyoconnor has joined #openmrs |
| 02:57:05 | *** ChanServ sets mode: +v robbyoconnor |
| 02:59:50 | *** harshadura has joined #openmrs |
| 02:59:50 | *** ChanServ sets mode: +v harshadura |
| 03:04:34 | *** LeeBreisacher has left #openmrs |
| 03:05:46 | *** harshadura has quit IRC |
| 03:18:51 | *** maninc has joined #openmrs |
| 03:31:21 | *** djazayeri has joined #openmrs |
| 03:31:21 | *** ChanServ sets mode: +o djazayeri |
| 03:31:25 | *** djazayeri has quit IRC |
| 03:31:32 | *** djazayeri has joined #openmrs |
| 03:31:33 | *** ChanServ sets mode: +o djazayeri |
| 03:51:14 | *** LeeBreisacher has joined #openmrs |
| 04:13:53 | *** maninc has quit IRC |
| 04:38:11 | *** djazayeri has quit IRC |
| 04:54:40 | *** LeeBreisacher has left #openmrs |
| 04:56:31 | *** k-joseph has joined #openmrs |
| 05:04:12 | *** maninc has joined #openmrs |
| 05:40:23 | *** shruthd has joined #openmrs |
| 05:43:58 | *** LeeBreisacher has joined #openmrs |
| 05:44:13 | *** LeeBreisacher has left #openmrs |
| 05:54:43 | *** k-joseph has quit IRC |
| 05:55:37 | *** k-joseph has joined #openmrs |
| 06:04:54 | *** k-joseph has quit IRC |
| 06:12:33 | *** dan has joined #openmrs |
| 06:13:25 | *** k-joseph has joined #openmrs |
| 06:15:49 | *** djazayeri has joined #openmrs |
| 06:15:49 | *** ChanServ sets mode: +o djazayeri |
| 06:16:12 | *** djazayeri has quit IRC |
| 06:28:06 | *** harsz89 has joined #openmrs |
| 06:28:06 | *** ChanServ sets mode: +v harsz89 |
| 06:29:27 | *** djazayeri has joined #openmrs |
| 06:29:27 | *** ChanServ sets mode: +o djazayeri |
| 06:29:45 | *** djazayeri1 has joined #openmrs |
| 06:29:45 | *** djazayeri has quit IRC |
| 06:45:33 | *** k-joseph has quit IRC |
| 06:46:26 | *** k-joseph has joined #openmrs |
| 07:03:33 | *** pascal` has joined #openmrs |
| 07:03:33 | *** ChanServ sets mode: +v pascal` |
| 07:09:19 | *** djazayeri1 has quit IRC |
| 07:19:32 | *** k-joseph has quit IRC |
| 07:20:02 | *** dan has quit IRC |
| 07:23:22 | *** k-joseph has joined #openmrs |
| 07:28:53 | *** maninc has quit IRC |
| 07:29:43 | *** dan has joined #openmrs |
| 07:31:32 | *** maninc has joined #openmrs |
| 07:41:23 | *** k-joseph has quit IRC |
| 08:33:40 | *** dkayiwa has joined #openmrs |
| 09:05:41 | *** dmulindwa has joined #openmrs |
| 09:06:43 | *** dan has quit IRC |
| 09:08:23 | *** shruthd has joined #openmrs |
| 09:26:13 | *** shruthd has quit IRC |
| 09:26:17 | <OpenMRSBot> Recent updates in the world of openmrsci: SON-REGISCORE-6 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-REGISCORE-6> |
| 09:38:03 | *** cospih_ has joined #openmrs |
| 09:42:05 | *** dmulindwa has quit IRC |
| 09:42:22 | *** dan has joined #openmrs |
| 09:43:04 | *** pascal` has quit IRC |
| 09:45:01 | <OpenMRSBot> Recent updates in the world of openmrsci: SON-APPUI-3 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-APPUI-3> |
| 09:55:17 | *** dan has quit IRC |
| 09:55:40 | *** dan has joined #openmrs |
| 09:56:20 | *** maninc has quit IRC |
| 10:15:10 | <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-STAND-8 has FAILED : Manual build by Daniel Kayiwa <https://ci-stg.openmrs.org/browse/REFAPP-STAND-8> || SON-REPORTINGUI-2 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-REPORTINGUI-2> || SON-RESTWEBSERV-2 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-RESTWEBSERV-2> || SON-IDGEN-2 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-IDGEN-2> || SON-METAMAPPING-2 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-METAMAPPING-2> || SON-OPENMRSCOREMASTER-2 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-2> || SON-HTMLFORMENTRY-2 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-HTMLFORMENTRY-2> || SON-HTMLFORM19EXT-2 has FAILED : Scheduled build <https://ci-stg.openmrs.org/browse/SON-HTMLFORM19EXT-2> |
| 10:17:41 | *** dkayiwa has quit IRC |
| 10:21:27 | *** novocain has quit IRC |
| 10:21:52 | *** dkayiwa has joined #openmrs |
| 10:23:36 | *** gtownfunk has joined #openmrs |
| 10:24:03 | *** maninc has joined #openmrs |
| 10:26:21 | *** dkayiwa_ has joined #openmrs |
| 10:27:50 | *** dkayiwa has quit IRC |
| 10:27:50 | *** dkayiwa_ is now known as dkayiwa |
| 10:31:12 | <OpenMRSBot> Recent updates in the world of openmrsci: SON-HTMLFORM19EXT-3 has FAILED : Manual build by RafaÅ Korytkowski <https://ci-stg.openmrs.org/browse/SON-HTMLFORM19EXT-3> |
| 11:04:58 | *** ciaron has joined #openmrs |
| 11:11:40 | *** k-joseph has joined #openmrs |
| 11:23:25 | <OpenMRSBot> Recent updates in the world of openmrsci: SON-OPENMRSCOREMASTER-3 has FAILED : Manual build by RafaÅ Korytkowski <https://ci-stg.openmrs.org/browse/SON-OPENMRSCOREMASTER-3> || SON-UILIBRARY-3 has FAILED : Manual build by RafaÅ Korytkowski <https://ci-stg.openmrs.org/browse/SON-UILIBRARY-3> |
| 11:23:58 | *** isaac____ has joined #openmrs |
| 11:31:25 | <OpenMRSBot> Recent updates in the world of openmrsci: SON-REGISCORE-7 has FAILED : Manual build by RafaÅ Korytkowski <https://ci-stg.openmrs.org/browse/SON-REGISCORE-7> |
| 11:53:42 | *** maninc has quit IRC |
| 12:19:18 | *** robbyoconnor has quit IRC |
| 12:36:23 | *** k-joseph has quit IRC |
| 12:37:13 | *** harsz89 has quit IRC |
| 12:49:36 | *** harsz89 has joined #openmrs |
| 12:49:36 | *** ChanServ sets mode: +v harsz89 |
| 12:49:39 | *** isaac____ has quit IRC |
| 12:54:04 | *** wyclif_ has joined #openmrs |
| 13:00:59 | *** LeeBreisacher has joined #openmrs |
| 13:03:45 | <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-STAND-12 has FAILED : Manual build by Daniel Kayiwa <https://ci-stg.openmrs.org/browse/REFAPP-STAND-12> || REFAPP-STAND-11 has FAILED : Manual build by Daniel Kayiwa <https://ci-stg.openmrs.org/browse/REFAPP-STAND-11> |
| 13:07:49 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: KenyaUI 1.12.8 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=kenyaui&version=&1.12.8> |
| 13:12:06 | *** ciaron has quit IRC |
| 13:33:53 | <OpenMRSBot> Recent updates in the world of openmrsci: RDD-RDD-36 has FAILED (2 tests failed) : Updated by Wyclif Luyima <https://ci-stg.openmrs.org/browse/RDD-RDD-36> |
| 13:37:08 | *** sgithens has quit IRC |
| 13:43:45 | *** djazayeri has joined #openmrs |
| 13:43:45 | *** ChanServ sets mode: +o djazayeri |
| 13:50:20 | *** _dmn has joined #openmrs |
| 13:52:17 | *** dkayiwa_ has joined #openmrs |
| 13:54:19 | *** dkayiwa has quit IRC |
| 13:54:23 | *** dkayiwa_ is now known as dkayiwa |
| 13:54:49 | <LeeBreisacher> djazayeri: I can create demo patients with one visit, so far. I haven't tried it in a "real" server setup yet, that's next. should I commit work-in-progress (before I have the encounters and such)? |
| 13:57:08 | *** _dmn has quit IRC |
| 14:01:41 | *** dan has quit IRC |
| 14:05:31 | *** dan has joined #openmrs |
| 14:07:21 | <djazayeri> LeeBreisacher: if you have partial progress that doesn't break anything, yes you can commit it |
| 14:07:39 | <djazayeri> LeeBreisacher: it works based on the GP already? |
| 14:07:48 | <djazayeri> LeeBreisacher: i.e. it isn't triggered at any time it's not supposed to be? |
| 14:09:10 | <cpower> Good morning/afternoon/evening! |
| 14:09:25 | <cpower> Let us place our fingers on the keyboard.....and scrum |
| 14:09:31 | <cpower> !scrumon cpower |
| 14:09:31 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:10:15 | <cpower> Order: djazayeri , wyclif_ , rafa , dkayiwa , h3llborn , and anyone else I may have missed |
| 14:10:45 | <djazayeri> Recently & Today |
| 14:10:45 | <djazayeri> * Code review and design review of TW India/JSS work |
| 14:10:45 | <djazayeri> * Released App Framework 2.0 |
| 14:10:45 | <djazayeri> * Need to finish minor i18n cleanup of the reporting module |
| 14:10:54 | <djazayeri> no blockers |
| 14:11:40 | <cpower> wyclif_: you are up |
| 14:12:41 | <wyclif_> Thursday: |
| 14:12:41 | <wyclif_> - Fixing ref app bugs |
| 14:12:43 | <wyclif_> - dev call |
| 14:12:44 | <wyclif_> - More fixes to the patient search widget and RA-250 - Estimated birthdates should be marked in patient search results |
| 14:12:46 | <wyclif_> Friday |
| 14:12:47 | <wyclif_> -Update developer documentation |
| 14:12:48 | <wyclif_> -more bug fixes |
| 14:12:49 | <wyclif_> Blockers: None |
| 14:13:19 | <cpower> rafa: |
| 14:14:56 | <cpower> oook |
| 14:14:57 | <cpower> dkayiwa: |
| 14:15:09 | <dkayiwa> Made a followup commit for: https://tickets.openmrs.org/browse/RA-231 - RA-231 |
| 14:15:09 | <dkayiwa> Finished: https://tickets.openmrs.org/browse/RA-235 - RA-235 |
| 14:15:09 | <dkayiwa> Configured CI plan for refapp standalone - RA-221 |
| 14:15:10 | <dkayiwa> I have just started on: UX issue with HTML Form Entry and the ADT form - RA-206 |
| 14:15:10 | <dkayiwa> No Blockers |
| 14:15:57 | <cpower> h3llborn: |
| 14:16:02 | <h3llborn> Yesterday: |
| 14:16:02 | <h3llborn> -RE-made my video, due to some changes to the code, making it easier to use the sdk |
| 14:16:02 | <h3llborn> Today: |
| 14:16:02 | <h3llborn> -Edit Video and Publish |
| 14:16:02 | <h3llborn> -Create installers and upload |
| 14:16:02 | <h3llborn> -Add any more necessary documentation |
| 14:16:02 | <h3llborn> -Keep translating the german ticket...ugh its soooo long! |
| 14:18:16 | <cpower> OOK! A week to go before I get to see some of you people in person... Let's give one last good push for developement |
| 14:19:00 | <cpower> I need need someone to RA-227 if this ticket has not already been taken |
| 14:19:16 | <cpower> Some good testing of RA-156 and 182 |
| 14:19:35 | <djazayeri> RA-227 is fixed and tested |
| 14:19:43 | <cpower> yeah! |
| 14:19:47 | <LeeBreisacher> djazayeri: sorry, was in daily scrum. yes, it looks at GP now (using the property name mentioned in the ticket). |
| 14:20:08 | <cpower> And on that note have a good weekend everyone |
| 14:20:11 | <cpower> !scrumoff |
| 14:20:11 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:20:16 | <djazayeri> LeeBreisacher, dkayiwa, wyclif_, rafa: sorry for missing standup. I'm available now, if anyone wants to discuss anything. |
| 14:21:02 | <djazayeri> LeeBreisacher: in that case I'd say to commit it, and comment on the ticket like "partial progress commited in (commit hash)" |
| 14:21:43 | <LeeBreisacher> djazayeri: ok. hopefully later today..then I should be able to finish up this weekend |
| 14:23:35 | <wyclif_> LeeBreisacher: i have made a couple of changes, can you test the standalone again with demo data |
| 14:24:08 | <LeeBreisacher> wyclif: ok. will probably be later today.. |
| 14:24:47 | <wyclif_> i update several modules, you might want o update them |
| 14:25:13 | <djazayeri> wyclif_: the patient dashboard on devtest02 is broken |
| 14:25:17 | <djazayeri> wyclif_: see http://devtest02.openmrs.org:8080/openmrs/coreapps/clinicianfacing/patient.page?patientId=13 |
| 14:25:49 | <djazayeri> wyclif_: perhaps due to your fix around emr vs emrapi for concept mappings |
| 14:26:13 | <djazayeri> wyclif_: it works on devtest01, so maybe it's that bamboo hasn't pushed yet? |
| 14:26:23 | <djazayeri> wyclif_: but I noticed this last night, and it's still the case |
| 14:26:26 | <LeeBreisacher> djazayeri: a build is running right now.. |
| 14:26:35 | <LeeBreisacher> djazayeri: oh |
| 14:27:37 | <LeeBreisacher> djazayeri: was there a change made that sortof invalidates any data that was created in the last few days? |
| 14:28:25 | <wyclif_> djazayeri: i haven't committed any code to it |
| 14:28:36 | <wyclif_> djazayeri: but i can look into it |
| 14:29:20 | <djazayeri> wyclif_: actually, never mind, it's a single patient that has the problem... |
| 14:29:22 | <wyclif_> djazayeri: i think mark broke it because i see he just committed code about obs builder to core apps module |
| 14:29:49 | <djazayeri> wyclif_: it's not about your fix at all |
| 14:29:55 | <wyclif_> djazayeri: ok |
| 14:30:34 | <wyclif_> djazayeri: ooops i was looking at a different module, so it is not mark |
| 14:30:58 | *** sgithens has joined #openmrs |
| 14:33:49 | *** harshadura has joined #openmrs |
| 14:33:49 | *** ChanServ sets mode: +v harshadura |
| 14:36:02 | *** sgithens has quit IRC |
| 14:39:51 | *** dkayiwa has left #openmrs |
| 14:43:07 | <djazayeri> wyclif_: Do *NOT* change the uuid of the concept source for emrapi in its code |
| 14:43:36 | <djazayeri> wyclif_: (per your comment on RA-221) |
| 14:44:00 | <djazayeri> wyclif_: remember that most of the reference application code is live in production in Mirebalais (and soon JSS) |
| 14:44:30 | <djazayeri> wyclif_: we probably need to change the UUID of the concept source in our mdsbuilder server and recreate the MDS packages |
| 14:44:33 | <OpenMRSBot> Recent updates in the world of openmrsci: RDD-RDD-38 has FAILED (1 tests failed) : Dependant of EMRAPI-EMRAPI-146 <https://ci-stg.openmrs.org/browse/RDD-RDD-38> |
| 14:44:47 | <djazayeri> wyclif_: we may need to wipe our devtest databases to make this work |
| 14:45:47 | <djazayeri> wyclif_: I see you did this already... |
| 14:49:22 | *** sgithens has joined #openmrs |
| 15:00:03 | <wyclif_> djazayeri: sorry i was away |
| 15:04:12 | <wyclif_> djazayeri: ok i will fix it |
| 15:06:38 | <djazayeri> wyclif_: wait, don't revert yet |
| 15:07:09 | <djazayeri> wyclif_: or rather, if you were to revert this, what would be the alternative solution? |
| 15:08:01 | <djazayeri> wyclif_: refapp (because of CIEL) and Mirebalais have different uuids for their emrapi concept sources |
| 15:08:21 | <djazayeri> wyclif_: and these can't really be changed (mirebalais because it's in production, and refapp because of CIEL) |
| 15:08:22 | <wyclif_> djazayeri: already reverted it |
| 15:08:53 | <djazayeri> wyclif_: can we address this in MDS, i.e. make sure that MDS is matching concept sources by name? |
| 15:08:57 | <wyclif_> djazayeri: the alternative is to update it on mdsbuileer server and drop the old concept package |
| 15:09:35 | <djazayeri> wyclif_: but the concept* tables on the mdsbuilder server came from CIEL, so we can't really change any UUIDS |
| 15:10:42 | <wyclif_> djazayeri: but the name already matches on mdsbuilder |
| 15:11:10 | <djazayeri> wyclif_: I mean, is there a change we can make to MDS (or our configuration of it) to match by name? |
| 15:11:30 | <wyclif_> djazayeri: i used to assume MDS has this matcher by name to detect duplicates but it never seems to work |
| 15:11:54 | <wyclif_> djazayeri: i think rafa would no best but i can look at the code |
| 15:12:43 | <djazayeri> wyclif_: let's try to catch rafa before he goes on holiday⦠:-) |
| 15:20:17 | <OpenMRSBot> Recent updates in the world of openmrsci: CA-CA-286 has FAILED (4 tests failed) : Dependant of EMRAPI-EMRAPI-148 <https://ci-stg.openmrs.org/browse/CA-CA-286> |
| 15:29:31 | <wyclif_> djazayeri: ok |
| 15:29:34 | <wyclif_> hi rafa |
| 15:31:31 | *** dan has quit IRC |
| 15:38:24 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: KenyaCore 0.13.3 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=kenyacore&version=&0.13.3> |
| 15:38:26 | *** harsz89 has quit IRC |
| 15:39:30 | *** dan has joined #openmrs |
| 16:01:42 | <wyclif_> djazayeri: so if you look at the demo data activator, that's pretty much what the admin has to configure , i assumed we just had to document that |
| 16:20:08 | *** sgithens has quit IRC |
| 16:38:29 | *** dan has quit IRC |
| 17:04:39 | *** sgithens has joined #openmrs |
| 17:13:40 | *** harsz89 has joined #openmrs |
| 17:13:40 | *** ChanServ sets mode: +v harsz89 |
| 17:35:13 | <djazayeri> wyclif_: can you add that documentation to the implementers documentation that Rafal has been working on? |
| 17:35:32 | *** harshadura has quit IRC |
| 17:41:50 | <wyclif_> djazayeri: ok |
| 18:14:54 | <wyclif_> hi djazayeri |
| 18:15:01 | <djazayeri> hi wyclif_ |
| 18:15:20 | <wyclif_> djazayeri: seems to me there are ways to add an extension |
| 18:15:53 | <wyclif_> djazayeri: via a *_app.json file or *_extension.json file, right? |
| 18:16:09 | <wyclif_> djazayeri: if yes, was that intentional? |
| 18:16:47 | <djazayeri> wyclif_: it's intentional, but confusing. If you look there's an App Framework ticket about this |
| 18:17:12 | <djazayeri> wyclif_: an app can define extensions (and these would be enabled/disabled along with the app) |
| 18:17:17 | <djazayeri> wyclif_: and there can be free-standing extensions |
| 18:17:19 | <wyclif_> djazayeri: i just wanted to be sure as i was documenting how to add an app to the home page |
| 18:17:52 | <djazayeri> wyclif_: If you are writing the app, you should include the extension within the app's json |
| 18:18:17 | <wyclif_> ok |
| 19:01:39 | *** sgithens has quit IRC |
| 19:43:28 | *** harsz89 has quit IRC |
| 20:22:32 | <LeeBreisacher> wyclif_, djazayeri: anyone available for a simple git question? |
| 20:23:00 | <wyclif_> LeeBreisacher: sure |
| 20:24:05 | <LeeBreisacher> wyclif_: thanks. I'm working on refdemodata. I've been editing code in master. there are changes upstream that I need to incorporate into my sources. what's the recommended way to do that? |
| 20:24:17 | <LeeBreisacher> wyclif_: should I be working in a branch instead of master? |
| 20:24:36 | <wyclif_> LeeBreisacher: have committed your local changes yet or not? |
| 20:24:45 | <LeeBreisacher> wyclif_: not yet |
| 20:24:52 | <wyclif_> try this: |
| 20:24:55 | <wyclif_> git stash |
| 20:24:56 | <LeeBreisacher> wyclif_: I did the "add", but not the commit |
| 20:25:15 | <wyclif_> git pull --rebase origin master |
| 20:25:17 | <LeeBreisacher> wyclif_: oh right. I know how to use stash |
| 20:25:47 | <wyclif_> git stash apply |
| 20:25:48 | <djazayeri> LeeBreisacher: IntelliJ does this automatically |
| 20:26:23 | <LeeBreisacher> djazayeri: yeah, I'm not gonna change to IJ now..been using e for years. |
| 20:26:41 | <LeeBreisacher> djazayeri: (he said, stuck in his ways...) |
| 20:26:42 | <djazayeri> LeeBreisacher: okay, I don't know if eclipse can do this too |
| 20:27:31 | <LeeBreisacher> djazayeri: I've just been using eclipse for development and test. no git or maven. just command line. just havent' bothered to learn.. |
| 20:28:27 | <LeeBreisacher> djazayeri, wyclif_: but in general, if I'm going to be working on something that other people are also likely to be working on, it's better to create a git branch for my work, right? |
| 20:28:58 | <djazayeri> LeeBreisacher: if you're going to be breaking things, do it in a branch |
| 20:29:15 | <djazayeri> LeeBreisacher: it's fine to make incremental commits in the master branch as long as they're "toggled off" in some way |
| 20:30:40 | <mseaton> djazayeri: rafa: i was trying to run the latest standalone and cannot seem to find a way to get it to install for me with no demo data and no concept dictionary. |
| 20:31:50 | <djazayeri> mseaton: I believe that the "starter implementation" currently fails to install right |
| 20:32:16 | <djazayeri> mseaton: due to a different in uuid for the o.o.m.emrapi concept source between mirebalais and refapp |
| 20:32:23 | <mseaton> djazayeri: the issue seems to be that the standalone gives 3 options: demo/test, mvp, advanced. so i have to pick advanced here |
| 20:32:25 | <djazayeri> mseaton: which requires some looking into MDS to work out |
| 20:32:33 | <djazayeri> mseaton: sorry is this the 1.9.4 standalone? |
| 20:32:42 | <mseaton> djazayeri: then, once i pick advanced, there are 3 options: simple, advanced, testing |
| 20:33:01 | <mseaton> djazayeri: simple has demo data, testing requires a production system to connect to and grab data from, so that leaves advanced |
| 20:33:04 | <djazayeri> mseaton: not the unreleased refapp one |
| 20:33:09 | <mseaton> djazayeri: yes |
| 20:33:14 | <LeeBreisacher> mseaton: how did you build standalone? |
| 20:33:23 | <mseaton> LeeBreisacher: i downloaded it :) |
| 20:33:34 | <LeeBreisacher> mseaton: from ? |
| 20:33:53 | <wyclif_> LeeBreisacher: yes |
| 20:34:02 | <wyclif_> LeeBreisacher: sorry for the late response |
| 20:34:06 | <mseaton> djazayeri: if i go to advanced, this requires either i give it a known database to connect to, or that i create one, and have to supply the root user and password for the db, which i don't know, since it is an embedded mysql db |
| 20:34:28 | <LeeBreisacher> mseaton: that does not sound like the refapp standalone. it has just two options. |
| 20:34:40 | <mseaton> LeeBreisacher: i realize that :) |
| 20:34:52 | <djazayeri> LeeBreisacher: not the refapp standalone, this is the prior one |
| 20:34:54 | <mseaton> LeeBreisacher: it's not. it's the standard openmrs one. http://openmrs.org/download/ |
| 20:35:10 | <djazayeri> mseaton: I believe those are "well-known" in some sense |
| 20:35:10 | <LeeBreisacher> mseaton. oh. sorry. nm. |
| 20:35:16 | <djazayeri> mseaton: maybe not _that_ well-known. :-) |
| 20:35:26 | <wyclif_> LeeBreisacher: but at this point in the development phase of the ref app, you can work directly on master and push your commit because we don't expect you to be working on something very big that would require a branch |
| 20:35:35 | <djazayeri> mseaton: thoughâ¦I thought they were pre-filled in some way |
| 20:35:38 | <mseaton> djazayeri: anyway, probably either intended or not a realistic use case, but oh well |
| 20:36:12 | <LeeBreisacher> djazayeri: how many demo patients would you like, as the default? |
| 20:36:24 | <djazayeri> LeeBreisacher: 100? |
| 20:41:17 | <djazayeri> mseaton: I'm pretty sure that if you choose advanced it's supposed to prefill the connection url, username, password in some way |
| 20:42:19 | <djazayeri> mseaton: but I don't really recall |
| 20:43:51 | <LeeBreisacher> djazayeri: do you know how Daniel left the bamboo standalone build? It looks like he figured out how to get the final zip into the Artifacts area, but... |
| 20:44:05 | <djazayeri> LeeBreisacher: I haven't looked at all |
| 20:44:25 | <LeeBreisacher> djazayeri: build 18 has the zip, but build 19 does not. strange. |
| 20:44:46 | <LeeBreisacher> djazayeri: and I don't seem to have permissions to look at (or change) the plan |
| 20:49:10 | <LeeBreisacher> djazayeri: different topic: I'm doing a completely fresh build of refapp and I got another dependency problem: Could not resolve dependencies for project org.openmrs.distro:referenceapplication:pom:1.0-SNAPSHOT: Could not find artifact org.openmrs.module:reporting-omod:jar:0.8-SNAPSHOT |
| 20:49:38 | *** ciaron has joined #openmrs |
| 20:50:05 | <djazayeri> LeeBreisacher: I don't seem to have permission either |
| 20:51:26 | <djazayeri> LeeBreisacher: Mike just released 0.8 of that module, so I guess we need to update our poms and/or build scripts |
| 20:51:43 | <LeeBreisacher> djazayeri: I'll update distro pom |
| 20:52:42 | <djazayeri> LeeBreisacher: I'll fix the ci build |
| 20:53:45 | <djazayeri> LeeBreisacher: not not force reporting to a snapshot |
| 20:53:57 | <LeeBreisacher> djazayeri: ? |
| 20:54:20 | <LeeBreisacher> djazayeri: I just pushed new pom.xml with "0.8" for reporting. right? |
| 20:54:52 | <djazayeri> LeeBreisacher: yeah, the maven versions plugin on bamboo will force the version up to 0.8.1-SNAPSHOT or whatever before building |
| 20:55:35 | <djazayeri> LeeBreisacher: so your push will make the build work locally, and my config change on ci-stg will have bamboo build with the same version we're using locally |
| 21:07:35 | <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1281 has FAILED : Updated by Lee Breisacher <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1281> |
| 21:22:38 | *** wyclif_ has quit IRC |
| 21:23:01 | <djazayeri> LeeBreisacher: hmm, bamboo doesn't think that your push fixed things. :-) |
| 21:23:31 | <djazayeri> LeeBreisacher: ah, nm, just took to long to start up |
| 21:23:52 | <LeeBreisacher> djazayeri: that keeps happening.. |
| 21:37:27 | <LeeBreisacher> djazayeri: is there a way to show all the patients (want to see that 100 were created...)? |
| 21:37:45 | <djazayeri> LeeBreisacher: sql? select count(*) from patient? :-) |
| 21:37:57 | <djazayeri> LeeBreisacher: the search widget intentionally doesn't do this |
| 21:38:01 | <LeeBreisacher> djazayeri: well duh. I mean using the system itself |
| 21:38:18 | <djazayeri> LeeBreisacher: nothing in refapp does this |
| 21:38:28 | <djazayeri> LeeBreisacher: probably if you go to advanced administration and Reporting |
| 21:38:33 | <djazayeri> LeeBreisacher: then Administer Reports |
| 21:38:49 | <djazayeri> LeeBreisacher: you can create a CohortDefinition that gets everyone |
| 21:39:22 | <LeeBreisacher> djazayeri: I'll just use sql |
| 21:39:25 | <djazayeri> LeeBreisacher: yeah. :-) |
| 21:44:02 | <LeeBreisacher> djazayeri: hm, using Find Patient Record, the same patient showed up twice (yes, really the exact same patient). but now I cannot reproduce it. |
| 21:46:27 | <LeeBreisacher> djazayeri: actually, Find Patient Record does not work very well. there are 4 Smith's, but only one shows up. |
| 21:49:51 | <LeeBreisacher> djazayeri: hm. the other Smith's were not auto-created by my code. shrug. |
| 21:57:57 | *** jkeiper has quit IRC |
| 22:14:39 | *** LeeBreisacher1 has joined #openmrs |
| 22:18:31 | *** LeeBreisacher has quit IRC |
| 22:56:21 | *** GitHub168 has joined #openmrs |
| 22:56:21 | <GitHub168> [openmrs-core] lluismf opened pull request #412: TRUNK-3935:Stored XSS via Custom Form Fields (master...TRUNK-3935) http://git.io/8ZZNCw |
| 22:56:21 | *** GitHub168 has left #openmrs |
| 23:08:53 | *** robbyoconnor has joined #openmrs |
| 23:08:53 | *** ChanServ sets mode: +v robbyoconnor |
| 23:12:08 | <LeeBreisacher1> djazayeri: yt? I still sometimes get Reference Demo Data Not Started. in the log, I see a NPE on User.getAllRoles. |
| 23:12:31 | <djazayeri> LeeBreisacher1: hmmâ¦I wonder if this has to do with module startup order |
| 23:12:36 | <djazayeri> LeeBreisacher1: which we sadly don't quite control... |
| 23:12:58 | <djazayeri> LeeBreisacher1: though, wasn't that a recently "fixed" bug? |
| 23:12:59 | <LeeBreisacher1> djazayeri: right, that's what I was wondering |
| 23:13:08 | <LeeBreisacher1> djazayeri: not sure |
| 23:14:17 | <djazayeri> LeeBreisacher1: it's sporadic, and it happens after you've already got your db set up? |
| 23:15:02 | <LeeBreisacher1> djazayeri: well, it happened during a "vagrant up" after doing "vagrant destroy". |
| 23:15:17 | <LeeBreisacher1> djazayeri: so should be fresh-everything |
| 23:15:28 | <djazayeri> LeeBreisacher1: okay, but it doesn't happen every time? |
| 23:15:37 | <djazayeri> LeeBreisacher1: do you have the whole stack trace? |
| 23:16:05 | <LeeBreisacher1> djazayeri: correct. it worked fine an hour ago. yes, it's failing doing a saveUser creating the "clerk" user. |
| 23:16:27 | <djazayeri> LeeBreisacher1: presumably that's the first user it tries to create? |
| 23:16:33 | <LeeBreisacher1> djazayeri: yes |
| 23:17:32 | <LeeBreisacher1> djazayeri: saveUser calls checkPrivileges(user) |
| 23:17:56 | <djazayeri> LeeBreisacher1: I suspect the problem is that because of the bug TRUNK-3922 sometimes the demo data module's started() method is called before the metadata module's started() method |
| 23:17:58 | <djazayeri> https://tickets.openmrs.org/browse/TRUNK-3922 |
| 23:18:01 | <LeeBreisacher1> djazayeri: which calls user.getAllRoles |
| 23:18:19 | <djazayeri> LeeBreisacher1: hmm, actually, if it's an NPE in User/UserService maybe I'm wrong here. |
| 23:18:43 | <LeeBreisacher1> djazayeri: I should be able to see each module being started in the log, right? |
| 23:19:41 | <djazayeri> LeeBreisacher1: presumably yes, each one should log something |
| 23:20:02 | <LeeBreisacher1> djazayeri: looking...lots of logging.. |
| 23:20:07 | <djazayeri> LeeBreisacher1: where exactly is the NPE? |
| 23:20:52 | <djazayeri> LeeBreisacher1: is it possible that because you have openmrs-core forked to your own github repo, then the openmrs version is actually your "upstream", not your "origin" and you've inadvertently not updated to the latest code? |
| 23:22:35 | <LeeBreisacher1> djazayeri: but (1) it worked an hour ago. all I've changed since then is a few lines of code in the create-demo-patients. (2) I started this process by deleting openmrs from my maven local cache (to avoid the kind of thing you're talking about) |
| 23:22:54 | <djazayeri> LeeBreisacher1: what is the exact line of the NPE? |
| 23:23:27 | <LeeBreisacher1> djazayeri: User.java, line 216 |
| 23:24:26 | <LeeBreisacher1> djazayeri: so either totalRoles or "r" is null |
| 23:24:53 | <djazayeri> LeeBreisacher1: very strange. |
| 23:25:03 | <djazayeri> LeeBreisacher1: because both of those sets are initialized locally |
| 23:25:35 | <djazayeri> LeeBreisacher1: and it's unclear how getRoles() could return a collections with a null entry. |
| 23:27:12 | <djazayeri> LeeBreisacher1: you can't set a breakpoint for this and run under the debugger right? (Because this is in the VM, not your real machine...) |
| 23:27:38 | <LeeBreisacher1> djazayeri: right. could this be a case where a db transaction is not done? |
| 23:27:57 | <djazayeri> LeeBreisacher1: I don't see how that could lead to a *null* entry in a list though |
| 23:29:47 | <LeeBreisacher1> djazayeri: the two lines of code in refdemodata startup are these: |
| 23:29:47 | <LeeBreisacher1> Role clerkRole = userService.getRoleByUuid(ReferenceDemoDataConstants.CLERK_ROLE_UUID); |
| 23:29:47 | <LeeBreisacher1> setupUser(ReferenceDemoDataConstants.CLERK_USER_UUID, "clerk", clerkPerson, "Clerk123", clerkRole); |
| 23:30:50 | <djazayeri> LeeBreisacher1: hmm, okay, yeah, so if clerkRole is null, that seems like it would be a problem |
| 23:31:02 | <djazayeri> LeeBreisacher1: probably caused by incorrect startup order (and this is random) |
| 23:31:13 | <djazayeri> LeeBreisacher1: so it probably _is_ the ticket I sent a link to above |
| 23:31:57 | <LeeBreisacher1> djazayeri: hm. where is the code/whatever that creates the clerk role in the db? |
| 23:32:57 | <djazayeri> LeeBreisacher1: Presumably that's part of the referencemetadata module's MDS packages |
| 23:33:49 | *** GitHub56 has joined #openmrs |
| 23:33:49 | <GitHub56> [openmrs-core] lluismf opened pull request #413: TRUNK-4098:Replace deprecated method "Expression" with "Restrictions" (master...TRUNK-4098) http://git.io/lI1j7w |
| 23:33:49 | *** GitHub56 has left #openmrs |
| 23:40:31 | <LeeBreisacher1> djazayeri: I don't see where the clerk role is created. confusing. frustrating. I just want to write this code and test it... |
| 23:41:03 | <djazayeri> LeeBreisacher1: the hack workarounds in this case are either of two things |
| 23:41:14 | <djazayeri> LeeBreisacher1: actually just one: |
| 23:41:32 | <djazayeri> LeeBreisacher1: log in to the webapp in the vm, and manually start the referencemetadata module |
| 23:41:38 | <djazayeri> LeeBreisacher1: then restart tomcat |
| 23:41:57 | <djazayeri> LeeBreisacher1: as long as the referencemetadata module has started once, and created this stuff, then the module startup order shouldn't matter |
| 23:42:26 | <LeeBreisacher1> djazayeri: thanks. that's easy enough... |
| 23:44:12 | <djazayeri> LeeBreisacher1: hopefully it works |
| 23:48:11 | *** jkeiper has joined #openmrs |
| 23:48:11 | *** ChanServ sets mode: +v jkeiper |
| 23:51:54 | <LeeBreisacher1> djazayeri: sigh. now I get java.lang.NoClassDefFoundError: org/openmrs/ui/framework/page/PageRequest |
| 23:51:58 | <djazayeri> LeeBreisacher1: I'm stepping out for ~45 minutes, but will likely be quite bored on this errand and checking email compulsively, so email me if this doesn't work... |
| 23:52:54 | *** wyclif has joined #openmrs |
| 23:59:34 | <wyclif> hi djazayeri |