IRC Chat : 2013-09-13 - OpenMRS

00:25:30 <wyclif> hi djazayeri
00:25:38 <djazayeri> hi wyclif
00:26:32 <wyclif> djazayeri: thanks for looking the code, i think we might need to discuss somethings before i can change certain things
00:26:46 <djazayeri> wyclif: okay, you want to discuss now?
00:26:59 <wyclif> djazayeri: sure
00:27:02 <wyclif> djazayeri: Skype?
00:29:41 <djazayeri> sure
00:30:33 <djazayeri> wyclif: give me 4 minutes
00:34:28 <wyclif> djazayeri:
00:34:31 <wyclif> djazayeri: ok
00:35:52 <djazayeri> wyclif: ready, but don't see you on skype
00:40:44 <wyclif> djazayeri: let start it
00:40:49 <wyclif> djazayeri: sorry about that
01:51:15 *** sgithens has quit IRC
02:07:27 *** breeze has quit IRC
02:19:34 *** breeze has joined #openmrs
02:44:11 *** sgithens has joined #openmrs
02:51:42 *** sgithens has quit IRC
03:04:35 *** sgithens has joined #openmrs
03:13:21 *** robbyoconnor has joined #openmrs
03:13:21 *** ChanServ sets mode: +v robbyoconnor
04:19:46 *** downey has quit IRC
04:23:55 *** upul has joined #openmrs
04:47:05 *** mareias has joined #openmrs
04:55:37 *** djazayeri has quit IRC
05:28:46 *** harshadura has joined #openmrs
05:28:54 *** ChanServ sets mode: +v harshadura
05:41:43 *** maninc has joined #openmrs
05:53:10 *** NameFILIP has joined #openmrs
05:53:10 *** ChanServ sets mode: +v NameFILIP
05:57:33 *** NameFILIP has quit IRC
06:17:33 *** downey has joined #openmrs
06:17:33 *** ChanServ sets mode: +o downey
06:17:33 *** OpenMRSBot sets mode: +o downey
06:29:04 *** k-joseph has joined #openmrs
06:49:51 *** rcrichton has joined #openmrs
06:52:14 *** k-joseph has quit IRC
06:55:03 *** upul has quit IRC
07:08:00 *** NameFILIP has joined #openmrs
07:08:00 *** ChanServ sets mode: +v NameFILIP
07:08:37 *** wyclif has quit IRC
07:12:31 *** NameFILIP has quit IRC
07:29:53 *** dkayiwa has joined #openmrs
07:47:34 *** dkayiwa has quit IRC
08:09:44 *** downey has quit IRC
09:17:10 <harshadura> hi rafa, can i get a min
09:48:39 *** rcrichton has quit IRC
09:52:03 *** rcrichton has joined #openmrs
09:54:38 *** harshadura has quit IRC
09:55:43 *** NameFILIP has joined #openmrs
09:55:43 *** ChanServ sets mode: +v NameFILIP
10:10:09 *** downey has joined #openmrs
10:10:09 *** ChanServ sets mode: +o downey
10:10:09 *** OpenMRSBot sets mode: +o downey
10:29:30 *** rcrichton has quit IRC
10:45:53 *** k-joseph has joined #openmrs
10:46:01 *** harshadura has joined #openmrs
10:46:01 *** ChanServ sets mode: +v harshadura
10:52:43 *** harshadura_ has joined #openmrs
10:54:33 *** harshadura_ has joined #openmrs
10:55:27 *** harshadura has quit IRC
11:02:14 *** harshadura_ is now known as harshadura
11:03:13 *** harshadura has joined #openmrs
11:03:13 *** ChanServ sets mode: +v harshadura
11:03:21 *** rcrichton has joined #openmrs
11:03:33 <harshadura> hi rafa
11:34:07 *** k-joseph has quit IRC
11:49:39 *** k-joseph has joined #openmrs
11:53:30 *** sgithens has quit IRC
12:09:11 *** sgithens has joined #openmrs
12:22:59 *** rcrichton has quit IRC
12:46:27 *** harshadura has quit IRC
12:58:47 *** harshadura has joined #openmrs
12:58:55 *** ChanServ sets mode: +v harshadura
13:07:17 *** cospih has joined #openmrs
13:07:40 *** k-joseph has quit IRC
13:08:17 *** k-joseph has joined #openmrs
13:25:21 *** LeeBreisacher1 has left #openmrs
13:28:35 *** LeeBreisacher2 has joined #openmrs
13:29:02 *** wyclif has joined #openmrs
13:32:13 <LeeBreisacher2> breeze, wyclif: yt? I'm getting "This party is over" trying to sign in to the ds hangout...
13:32:28 <wyclif> LeeBreisacher2: me too
13:32:37 <wyclif> LeeBreisacher2: i think the url was changed
13:33:46 *** djazayeri has joined #openmrs
13:33:56 *** ChanServ sets mode: +o djazayeri
13:34:02 *** cospih_ has joined #openmrs
13:34:45 *** cospih has quit IRC
13:35:26 <djazayeri> rafa, wyclif, LeeBreisacher2, dkayiwa, cpower: apparently the hangout url expired,so let's use this one today:
13:35:27 <djazayeri> https://plus.google.com/hangouts/_/dd4e9deb46f10bb5db7104a4603b652ad0942dc2?authuser=0&hl=en
13:35:29 <OpenMRSBot> <http://ln-s.net/-xy$> (at plus.google.com)
13:36:49 <djazayeri> breeze: ^^
13:37:32 <djazayeri> rafa: ^^
13:41:34 <LeeBreisacher2> breeze: I rebuild the refapp and now it runs ok. shrug. but the DbUnit/JDBC connection fails with this: java.sql.SQLException: Access denied for user 'openmrs_user'@'10.0.2.2' (using password: YES)
13:43:07 *** maninc has quit IRC
13:44:30 <LeeBreisacher2> djazayeri: see above to breeze re SQLException
13:45:02 <LeeBreisacher2> djazayeri: any idea where that 10.02.2 is coming from? something goofy about my network settings?
13:45:03 <djazayeri> LeeBreisacher2: that doesn't necessarily surprise me
13:45:18 <LeeBreisacher2> djazayeri: oh?
13:45:25 <djazayeri> LeeBreisacher2: i.e. with mysql you may have to explicitly setup a way for the user to connect from a different url
13:45:40 <djazayeri> LeeBreisacher2: gotta do my other standup now, can try to comment further in 15m
13:45:59 <LeeBreisacher2> djazayeri: I have my work ds at 7a
13:46:38 <djazayeri> LeeBreisacher2: okay, anyway I think that 10.10.2.2 is the url that virtualbox exposes your host as to the client
13:46:57 <djazayeri> LeeBreisacher2: and so you might need to grant some access in mysql. I forget exactly how
13:47:12 <djazayeri> LeeBreisacher2: are you _sure_ you were able to connect with a mysql client with the same user and pass?
13:48:02 <LeeBreisacher2> djazayeri: pretty sure...
13:58:40 *** mareias has quit IRC
14:01:47 *** maninc has joined #openmrs
14:06:32 <cpower> Scrum time!
14:06:41 <cpower> !scrumon cpower
14:06:41 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
14:07:15 <cpower> Order: djazayeri , h3llborn , rafa , wyclif
14:07:43 *** k-joseph has quit IRC
14:08:18 <djazayeri> oops let me go last
14:09:55 <djazayeri> never mind, I'll go first
14:09:57 <djazayeri> Recently & Today
14:09:58 <djazayeri> * Reviewed work by Wyclif and Rafal
14:09:58 <djazayeri> * Started working on a spreadsheet import for a drug formulary (probably Mirebalais-specific)
14:09:58 <djazayeri> * Calls
14:09:58 <djazayeri> * Working on some small HTML Form Entry improvements PIH needs for the consult note
14:09:59 <djazayeri> no blockers
14:11:04 <cpower> h3llborn: you are up
14:13:08 *** harsha89 has joined #openmrs
14:14:55 <cpower> ok how about rafa
14:15:29 <cpower> and now wyclif
14:15:59 <rafa> Today:
14:15:59 <rafa> * Initial commits for RA-156
14:15:59 <rafa> Make CFPD the default patient view
14:15:59 <rafa> https://tickets.openmrs.org/browse/RA-156
14:15:59 <rafa> * Working on RA-217
14:16:00 <rafa> Fix caching issue for JS and CSS files
14:16:00 <rafa> https://tickets.openmrs.org/browse/RA-217
14:16:01 <rafa> No blockers.
14:16:11 <wyclif> Thursday:
14:16:12 <wyclif> - design call
14:16:13 <wyclif> - RA-213 - Hide unimplemented functionality in CFPD
14:16:15 <wyclif> - Chat with Darius about the design of patient search widget and RA-213 - Hide unimplemented functionality in CFPD
14:16:16 <wyclif> - GSoC code review
14:16:18 <wyclif> Friday:
14:16:19 <wyclif> - RA-200 - Patient Lookup widget should show recently-accessed patients
14:16:20 <wyclif> - Address review TODOs for RA-199 - Improve UI/UX of Patient Lookup
14:16:21 <wyclif> - Weekly chat with Ishara
14:16:22 <wyclif> Blockers: None
14:16:40 <cpower> Ok thanks everyone and have a good weekend
14:16:44 <cpower> !scrumoff
14:16:44 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
14:17:22 <djazayeri> rafa: anything to discuss about making CFPD the primary view?
14:18:02 <rafa> djazayeri: I left comments on the ticket
14:18:19 <djazayeri> rafa: I skimmed them. I have a lot of links to click. :-)
14:19:07 <djazayeri> rafa: just to check, we don't need to toggle this in general because there are very few in Mirebalais that we're chaning?
14:20:19 <rafa> djazayeri: we don't toggle this, because without a returnUrl pages behave the old way and return to DEPD
14:20:44 <djazayeri> rafa: okay. is the only question around Registration?
14:20:50 <rafa> djazayeri: yes
14:21:08 <djazayeri> rafa: Mirebalais isn't using that, so I think you should just change the URL.
14:21:14 <rafa> djazayeri: ok
14:21:31 <djazayeri> rafa: that said, it's probably correct to change things so it goes to the afterCreatedUrl.
14:21:55 <rafa> djazayeri: ok, so reuse that config param?
14:21:56 <djazayeri> rafa: but to be efficient with time, it's fine to just change the url to the CFPD
14:22:04 <djazayeri> rafa: unless it's trivial to reuse the config param
14:22:14 <rafa> djazayeri: ok
14:25:08 <cpower> djazayeri: You think your on track for us to start testing on Monday still?
14:25:45 <djazayeri> cpower: Yes. Though we should probably make sure to have an appropriate non-admin user
14:25:51 <djazayeri> cpower: which might be non-trivial
14:26:06 <cpower> djazayeri: who do we need to do that?
14:26:18 <LeeBreisacher2> breeze: yt?
14:26:42 <djazayeri> cpower: maybe I can do it over the weekend, but don't block things on it
14:27:14 <djazayeri> wyclif, rafa, LeeBreisacher2: by the way, we're going to be asking people broadly to start looking at the app, testing it, and reporting bugs. This will start on Monday
14:27:26 <djazayeri> so…try not to break anything. :-)
14:27:38 <LeeBreisacher2> djazayeri: I'm back. I verified that I can connect to the vagrant mysql from "outside" (Windows).
14:27:51 <cpower> djazayeri: Was wanting to start sending out a "rallying the testers" email to the lists today and get details out Monday
14:27:53 <wyclif> djazayeri: ok
14:27:59 <LeeBreisacher2> djazayeri: using MySQL Workbench
14:28:31 <breeze> LeeBreisacher2: hey
14:28:52 <LeeBreisacher2> breeze: ah, did you see the 10.0.0.2 error I'm seeing?
14:29:09 <breeze> LeeBreisacher2: no....what was it?
14:29:48 <breeze> LeeBreisacher2: I see now....
14:30:46 <LeeBreisacher2> breeze: something strange about virtualbox and 10.0.0.2?
14:32:02 <breeze> LeeBreisacher2: maybe try to use root instead of the openmrs_user user to see what happens
14:32:23 <LeeBreisacher2> breeze: same pwd?
14:33:31 <breeze> LeeBreisacher2: i wasn't actually sure which user you'd be using for this connection
14:33:57 <LeeBreisacher2> breeze: root worked!
14:35:05 <breeze> LeeBreisacher2: ok....yeah, was scrolling back at the convo, and djazayeri is right. I set the root user to be able to connect from anywhere, but the openmrs_user only from localhost
14:36:31 <breeze> LeeBreisacher2: btw, how did you fix the demo data module problem?
14:37:30 <LeeBreisacher2> breeze: so I should use root for the tests?
14:37:48 <LeeBreisacher2> breeze: I just rebuilt refapp, but without the -U param this time. shrug.
14:39:52 *** mareias has joined #openmrs
14:40:58 <breeze> LeeBreisacher2: I'm mulling over using root or not on the tests...
14:42:31 <breeze> LeeBreisacher2: actually, let's use root for now, and once you push your changes I can play around with switching it back
14:43:32 <LeeBreisacher2> breeze: these settings are easy to tweak with -D command line.
14:43:49 <breeze> LeeBreisacher2: right, I figured that
14:44:02 <LeeBreisacher2> breeze: but we're still waiting for the firewall change. I dont' want to commit until that's done
14:44:20 <breeze> LeeBreisacher2: oh yeah
14:44:22 *** harshadura has quit IRC
14:45:05 <LeeBreisacher2> breeze: I think djazayeri was going to check on it...
14:45:21 <breeze> LeeBreisacher2: does the dbunit / jdbc connection seem slow at all?
14:45:25 *** NameFILIP has quit IRC
14:46:19 <LeeBreisacher2> breeze: um...no, but it's executing a tiny bit of code at the moment. just deleting a row from a few tables.
14:50:00 <breeze> LeeBreisacher2: yeah, figured that, but thought I'd ask since when I try the liquibase stuff over a remote jdbc connection it takes a long time, but there are lots more things going on with that
14:50:31 <breeze> LeeBreisacher2: lots more sql transactions that is
14:58:41 <LeeBreisacher2> djazayeri: re socket port, firewall: I was thinking of suggesting that I try using the openmrs API instead of DbUnit, but that will also require the firewall to be open?
14:58:50 <djazayeri> LeeBreisacher2: yes.
14:59:01 <djazayeri> LeeBreisacher2: the only thing that would bypass the firewall port would be REST
14:59:36 <breeze> LeeBreisacher2: djazayeri why would using the api require the firewall to be open? should just be 8080
14:59:42 <LeeBreisacher2> djazayeri: I looked into REST briefly, but it didn't look promising
15:00:20 <djazayeri> breeze: the API also hits the DB, just the sql is generated by hibernate
15:01:17 <breeze> djazayeri: which still makes me think that it come in through the app if hibernate was involved
15:01:45 <djazayeri> breeze: no, hibernate just generates sql queries
15:04:00 <breeze> djazayeri: ok, but what I'm trying to say is hibernate isn't sitting underneath mysql server port 3306, it's sitting as a lib under tomcat, port 8080, or am I missing something
15:04:54 <djazayeri> breeze: I mean that if we have a test make a call to the OpenMRS API running in the JVM on ci-stg, it's going to then need to make a SQL call to $connection.url
15:05:16 <djazayeri> breeze: it's not a remote API, it's a plain java API that we'd be running in the same place as the tests run.
15:05:30 <breeze> djazayeri: ahhh..ok that's the part I'm missing
15:05:40 *** harshadura has joined #openmrs
15:05:40 *** ChanServ sets mode: +v harshadura
15:06:01 <LeeBreisacher2> breeze: did you see the latest suggestion on ITSM-3655? put a bamboo agent on devtest01?
15:06:35 <breeze> LeeBreisacher2: I didn't but that is a good idea
15:07:15 <breeze> LeeBreisacher2: actually let me think about that for a min
15:07:20 <LeeBreisacher2> breeze: won't that mean some tweaks to the bamboo plan?
15:07:31 *** cospih has joined #openmrs
15:08:00 <breeze> LeeBreisacher2: let me look at the ticket, but I don't think that will work
15:08:05 <djazayeri> breeze, LeeBreisacher2, ryates: I would be surprised if a bamboo agent will work things that are triggered by dbunit in a jvm (that just happens to have been run by bamboo)
15:08:14 *** cospih_ has quit IRC
15:08:31 <breeze> LeeBreisacher2: yes, what djazayeri said :)
15:08:52 <LeeBreisacher2> breeze: I don't understand, but I believe you...
15:09:13 <LeeBreisacher2> breeze, djazayeri: wouldn't bamboo be talking to mysql using just localhost?
15:10:04 <breeze> LeeBreisacher2: that is if we ran the db jvm local to the app server
15:10:16 <breeze> LeeBreisacher2: dbunit jvm that is
15:10:28 *** sgithens has quit IRC
15:10:42 <djazayeri> breeze: the point is for dbunit to be part of the test suite, hence it has to run on ci-stg
15:10:45 <LeeBreisacher2> breeze: yes, I thought that's what the suggestion was
15:12:00 <LeeBreisacher2> djazayeri: we sortof want the *test* to run separate/remote, but the setup/teardown (dbunit) to run local.
15:12:09 <djazayeri> LeeBreisacher2, breeze: maybe dbunit has some existing mechanism for doing its work remotely, but I'd be surprised.
15:12:13 <breeze> djazayeri: i think what ryates is getting at is that if we make devtest01 a bamboo agent the test suite will run on that agent and therefore not have to go over the wire and make tcp connection
15:12:28 <djazayeri> breeze: ah, interesting
15:12:59 <djazayeri> breeze: so the whole test actually runs on devtest01 (and we somehow set the connection.url to be localhost)...
15:13:22 <breeze> djazayeri: yeah....though that is setting off my spidey sense...want to think on that one for a min
15:13:38 <djazayeri> breeze, ryates: that does sound like it would work, but I have to imagine that setting up and configuring a remote bamboo agent is going to take longer than waiting for a single firewall port to be opened...
15:15:14 <djazayeri> ryates, downey: can you be more specific than "a while"? Does that mean days? weeks?
15:15:32 <downey> djazayeri: it depends how offended they are :)
15:15:40 <LeeBreisacher2> djazayeri, breeze: I'm a little concerned that such a setup would not be a "real" test.
15:16:05 <breeze> LeeBreisacher2: yes, that is what is setting off my spidey sense
15:17:29 <djazayeri> LeeBreisacher2: I tend to think that if we want to work on something in parallel while waiting for the port, that should be setting up test data with web services
15:18:21 <LeeBreisacher2> djazayeri: I'm more concerned with deleting test data
15:18:24 <djazayeri> LeeBreisacher2: presumably by having a few utility methods along the lines of createPatient(givenName, familyName, birthdate, gender) returns patient Uuid
15:19:13 <djazayeri> LeeBreisacher2: so for that we _could_ implement a "completely delete a patient, recursively", perhaps with extra special privileges
15:19:22 <djazayeri> LeeBreisacher2: this seems useful to have anyway
15:19:39 <djazayeri> LeeBreisacher2: and expose this as a web service (or via a regular http post)
15:20:37 <LeeBreisacher2> djazayeri: another thing I didn't understand (after looking at REST briefly) was how to identify a patient-to-delete. it seems to use uuid's, but the test code just has the patient database-id.
15:22:10 <downey> breeze: will be interested in hearing more from your spidey sense ;-)
15:22:31 <djazayeri> LeeBreisacher2: we don't actually have to use REST for this
15:23:50 <breeze> downey: right now the most specific I can get is that there's a pumpkin bomb nearby :)
15:24:10 <djazayeri> LeeBreisacher2: we could just expose a regular controller that lets you delete a patient (+recursively) given a patientId and a secret token
15:25:16 <LeeBreisacher2> djazayeri: I don't understand what "a regular controller" is. how would the tests invoke it?
15:25:46 <djazayeri> LeeBreisacher2: by doing a post to http://(whatever)/testutil/deletePatient.form?patientId=1234
15:26:38 <LeeBreisacher2> djazayeri: side question: the Mirebalais smoke tests must be doing the same thing we're trying to do. so there must be an open mysql port there. right? how is this different?
15:26:41 <breeze> LeeBreisacher2: djazayeri downey: but I generally like the idea to keep test runner and application under test separate, mostly because the test runner usually involves lots of devs tools, mvn and dbunit in this case, which in turn makes your test server less production like
15:27:25 <djazayeri> LeeBreisacher2: we just opened the db port, it wasn't a big deal
15:28:15 <LeeBreisacher2> djazayeri: "we"? why is this port different? (obviously, I don't understand the infrastructures)
15:29:12 <djazayeri> LeeBreisacher2: Mirebalais is a Partner In Health project. So it's using PIH's infrastructure. RefApp is OpenMRS and we're using Indiana University's infrastructure
15:29:26 <LeeBreisacher2> djazayeri: ah
15:30:19 <LeeBreisacher2> djazayeri: so back to your /testutil/ idea... isn't that sortof a security problem?
15:30:34 <downey> breeze: is dbunit what's running the db updates i assume?
15:30:41 <djazayeri> LeeBreisacher2: yes, it's a security issue
15:31:00 <djazayeri> LeeBreisacher2: we might want to implement it in a special test-support module that nobody should ever install on a production server
15:31:01 <LeeBreisacher2> downey: yes, DbUnit uses JDBC to do the updates
15:31:33 <downey> LeeBreisacher2: OK, and mvn fires off the dbunit task, and bamboo tells mvn to do so - am i following correctly?
15:31:36 <LeeBreisacher2> djazayeri: ah. that's a nice idea...
15:32:30 <LeeBreisacher2> downey: well, mvn fires off the UI tests which use DbUnit to do setup/teardown. and yes bamboo tells mvn
15:32:55 <LeeBreisacher2> downey: I updated ITSM-3655 with this info. https://tickets.openmrs.org/browse/ITSM-3655?focusedCommentId=201370&page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel#comment-201370
15:33:09 <downey> LeeBreisacher2: gotcha
15:33:18 <breeze> docpaul: dbunit is being used to insert and delete test data
15:33:56 <LeeBreisacher2> djazayeri: I like the idea of a "test setup/teardown" module.
15:34:18 <breeze> docpaul: sorry meant downey
15:34:44 <LeeBreisacher2> djazayeri: that cleanly separates the tests from the prep/cleanup
15:35:29 <djazayeri> LeeBreisacher2: well, I'm assuming that the setup/teardown are still part of the test, just that we expose a server url (through a uitesthelper module) with some cleanup utilities
15:35:31 <LeeBreisacher2> djazayeri: and this test setup module could use the API instead of DbUnit. much easier/cleaner.
15:35:47 <djazayeri> LeeBreisacher2: I don't think we're talking about the same thing
15:36:06 <djazayeri> LeeBreisacher2: (sorry, gotta run for a bit)
15:36:12 <LeeBreisacher2> djazayeri: maybe not, I think I'm sortof extending your idea
15:36:38 <djazayeri> LeeBreisacher2: I don't see how what (I think) you are describing is conceptually different from just having the test make web service calls to setup data
15:36:38 <LeeBreisacher2> djazayeri: ok, I'm gonna be gone from 945 until 1 or so..
15:36:52 <downey> i'll see what i can do in the mean time to grease the wheels
15:37:44 <LeeBreisacher2> downey: thanks. the easiest thing would be to open that one port to that one bamboo server. because we have code already written and working for that
15:37:48 <djazayeri> downey: thanks! would be helpful to have a clearer upper bound on the time estimate for the port
15:37:58 <downey> djazayeri: upper bound is infinite :)
15:38:11 <downey> but you might need to plan for a couple days
15:38:15 <djazayeri> downey: 95% confidence interval
15:38:36 *** wyclif has quit IRC
15:40:17 *** breeze has quit IRC
15:42:30 *** wyclif has joined #openmrs
15:44:45 *** wyclif has quit IRC
15:56:26 *** smuriu has joined #openmrs
15:56:56 *** smuriu has left #openmrs
16:01:12 *** sgithens has joined #openmrs
16:08:20 *** NameFILIP has joined #openmrs
16:08:20 *** ChanServ sets mode: +v NameFILIP
16:12:51 *** NameFILIP has quit IRC
16:30:50 *** maninc has quit IRC
16:41:33 *** breeze has joined #openmrs
16:41:42 *** wyclif has joined #openmrs
16:44:55 *** sgithens has quit IRC
16:51:34 *** breeze has quit IRC
16:53:43 *** maninc has joined #openmrs
16:58:54 <djazayeri> lstanisic: will you be able to use firebug or chrome to see if there are any javascript errors happening?
17:01:24 <lstanisic> Hey djazayeri, I'm trying that now
17:02:10 <lstanisic> Ah, the console has 3 error messages listed
17:03:12 <djazayeri> lstanisic: can we skype or google hangout so you can show me the screen?
17:03:35 <djazayeri> lstanisic: alternately we can have several rounds of back and forth with attaching screenshots :-)
17:03:44 <lstanisic> haha :)
17:03:53 <lstanisic> Let's use google hangout, my username=laurenstanisic
17:08:52 *** NameFILIP has joined #openmrs
17:08:56 <lstanisic> thanks djazayeri!
17:09:00 *** ChanServ sets mode: +v NameFILIP
17:10:34 *** sgithens has joined #openmrs
17:13:04 <djazayeri> lstanisic: one more thing: can you look on the Preview section of the page where you're editing the form html, and see if the widget works there?
17:13:15 *** NameFILIP has quit IRC
17:16:59 *** sgithens has quit IRC
17:30:49 *** sgithens has joined #openmrs
17:31:22 <lstanisic> Sure
17:32:04 <lstanisic> djazayeri: it doesn't
17:32:37 <djazayeri> lstanisic: can you attach a screenshot to the ticket of the javascript console's error message?
17:32:47 <djazayeri> lstanisic: (on the edit page)
17:33:58 <lstanisic> djazayeri: sure! adding it now.
17:37:18 *** sgithens has quit IRC
17:47:26 <djazayeri> lstanisic: just to check, is the screenshot you attached is on the Design Form screen or from the Enter Form screen?
17:48:00 <lstanisic> Enter Form
17:48:25 <lstanisic> djazayeri: want me to attach the same from the design form section?
17:48:32 <djazayeri> lstanisic: yes please!
17:48:43 <lstanisic> djazayeri: k, doing now
17:49:10 <mareias> djazayeri: thanks for the e-mail. Do we have support for those classes in the web services rest module? Like if I extend Test Order and use web service rest modules to get orders from an encounter, is it possible to know which order is a test orders or a radiology order?
17:49:20 <mareias> djazayeri: or a custom type of order
17:50:08 <djazayeri> mareias: I'm not sure — we have a mechanism for resources that have subtypes, but I haven't tested it with test orders
17:51:37 <mareias> djazayeri: ok, we'll take a look on that. If web service doesn't allow that, it should be fine add this feature to it? Or it is better wait you guys finish the new order api?
17:52:00 <djazayeri> mareias: best to fix it now. it shoudl work though, let us know if it doesn't
17:57:22 <mareias> djazayeri: ok, i'll tell you when we test. But I didn't remember any property in the json exposing this information. The only one that I remember is the orderType. Anyway, I'll check next week :)
17:58:10 <djazayeri> mareias: it depends on hibernate loading the right class
17:58:55 <mareias> djazayeri: cool. I'll check
18:09:21 *** NameFILIP has joined #openmrs
18:09:21 *** ChanServ sets mode: +v NameFILIP
18:09:49 <djazayeri> mareias: actually, now that I think about it you might actually need to implement a SubtypeHandler (or something like that, I forget the name) for each specific subtype you want exposed in RESTWS.
18:10:01 <djazayeri> mareias: these should be quick to implement.
18:11:05 *** sgithens has joined #openmrs
18:11:56 <mareias> djazayeri: that is what I thought. It would be quick, however, it shouldn't be the ideal solution. If we create 5 subtypes we need to create 5 handlers or whatever is the name.
18:12:13 <djazayeri> mareias: yes, but that's not really a problem...
18:12:58 <mareias> djazayeri: it is if we put this on web service rest. Imagine each implementation adding a handler for a custom type. It is not good, isn't it?
18:14:07 *** NameFILIP has quit IRC
18:14:10 <djazayeri> mareias: the handler doesn't have to be in the webservices.rest module, IIRC. For example if we introduced a MicrobiologyTestOrder (or something) in emrapi, we could also put the REST subtype handler in emrapi
18:14:44 <djazayeri> mareias: one point I meant to make in the email is that if you're about to build custom implementation-specific order *datatypes* then you're doing something wrong
18:15:11 <djazayeri> mareias: the class hierarchy of different order datatypes should be pretty consistent across the world
18:15:57 <mareias> djazayeri: got it
18:16:09 <djazayeri> mareias: perhaps we can discuss on the monday call? do you have a list of order types (in the business sense) that you want/need to cover?
18:16:23 <djazayeri> mareias: if you had that list and could share it on the list, it'd be helpful
18:16:49 <mareias> djazayeri: I don't have it yet. But I can talk with our BA's and see if they do.
18:17:17 <mareias> djazayeri: if we have enough information, I'll try to join the call :)
18:21:03 *** k-joseph has joined #openmrs
18:22:34 *** mareias has quit IRC
18:30:42 *** k-joseph has quit IRC
18:42:42 <downey> djazayeri / LeeBreisacher2: Your rule is granted. ;-)
18:43:07 <djazayeri> downey: our port is open? send on the bits?
18:45:13 <downey> djazayeri: send 'em on
18:45:23 <downey> i did a basic test and it seems to work
18:45:33 <downey> at least at the network level
18:46:38 <djazayeri> downey: thanks for moving that forward fast!
18:49:28 <downey> djazayeri: no problem, had some chips to cash in
18:57:03 *** breeze has joined #openmrs
19:03:04 *** sgithens has quit IRC
19:09:51 *** NameFILIP has joined #openmrs
19:09:51 *** ChanServ sets mode: +v NameFILIP
19:14:14 *** NameFILIP has quit IRC
19:30:34 *** NameFILIP has joined #openmrs
19:30:34 *** ChanServ sets mode: +v NameFILIP
19:34:02 <LeeBreisacher2> downey: thanks!
19:34:24 <LeeBreisacher2> djazayeri: I'll try to get something committed this afternoon..expect the build to break a few times while I get things ironed out
19:35:09 <djazayeri> LeeBreisacher2: I'll set phasers to "ignore"
19:51:34 <breeze> LeeBreisacher2: hi....I missed the info from downey did the port get opened up?
19:51:42 <downey> breeze: yes. ;-)
19:52:07 <breeze> downey: LeeBreisacher2 ok. I need to change the config for mysql still. doing that now
19:53:39 <LeeBreisacher2> breeze: what user id should I use for devtest01 mysql?
19:54:29 <breeze> LeeBreisacher2: stick with root, about to apply that change to devtest01 in about 45 secs....
19:57:26 <breeze> LeeBreisacher2: ok. looks good. I tested the connection from bamboo too and it's working
19:57:37 <LeeBreisacher2> breeze: tnx
20:14:46 *** robbyoconnor has quit IRC
20:19:43 *** maninc has quit IRC
20:26:40 *** harsha89 has quit IRC
20:28:04 <LeeBreisacher2> djazayeri: question... while I'm getting the bugs ironed out, there are likely to be leftover database entries..I assume that's not a big deal..
20:28:32 <djazayeri> LeeBreisacher2: not a problem
20:42:06 *** harshadura has quit IRC
20:48:27 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1171 has FAILED (3 tests failed) : Updated by Lee Breisacher <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1171>
20:49:54 <LeeBreisacher2> djazayeri, breeze: hm, I committed ui-tests, and the build failed. but it looks like it has nothing to do with the tests
20:50:11 <breeze> LeeBreisacher2: looking at the logs now....
20:50:27 <LeeBreisacher2> djazayeri: looks like two modules did not start: HTML Form Entry UI Framework Integration, and Ref App Module
20:51:00 <breeze> LeeBreisacher2: registerAPatient(org.openmrs.reference.RegistrationAppTest): Access denied for user 'root'@'localhost' (using password: YES)
20:51:22 <breeze> LeeBreisacher2: looks like a problem
20:51:24 <djazayeri> LeeBreisacher2: I just made a commit to HFEUI, so maybe that's me
20:51:29 <breeze> LeeBreisacher2: a mysql connection problrm I mean
20:51:56 <djazayeri> breeze, LeeBreisacher2: Mark mentioned that a Mirebalais test just broke because of a mysql access denied error, and he wasn't sure why
20:52:01 <LeeBreisacher2> djazayeri, breeze: hm, so we might have more than one problem
20:53:46 <breeze> djazayeri: LeeBreisacher2 well devtest01 did not start up correctly for one thing
20:53:47 <OpenMRSBot> Recent updates in the world of openmrsci: CA-CA-230 has FAILED (2 tests failed) : Updated by Darius Jazayeri <https://ci-stg.openmrs.org/browse/CA-CA-230>
20:54:03 <breeze> djazayeri: LeeBreisacher2 the refapp module and the html form entry mod failed to start
20:54:11 <LeeBreisacher2> djazayeri: I don't see your HFEUI commit rippling through to distro
20:56:01 <LeeBreisacher2> djazayeri, breeze: let's get the CA problems fixed first. I see "patientdashboard" in the failure messages. didn't that change to "clinicianfacing"?
20:56:32 <djazayeri> LeeBreisacher2: I just merged a pull request from rafa in CA, but after the other breakages
20:57:20 <djazayeri> LeeBreisacher2: one problem is that I forgot to increment the version of HTML Form Entry we're using in the distro pom
20:57:32 <djazayeri> LeeBreisacher2: that's why modules didn't start up right
20:57:50 <LeeBreisacher2> djazayeri: oh good. so that's an easy fix.
20:58:49 <djazayeri> LeeBreisacher2: committed that, will look back in a couple mintues
21:00:38 *** cospih has quit IRC
21:08:31 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1172 has FAILED (1 tests failed) : Updated by Darius Jazayeri <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1172>
21:13:32 *** LeeBreisacher has joined #openmrs
21:14:07 <breeze> LeeBreisacher2: now looks like we just have this error registerAPatient(org.openmrs.reference.RegistrationAppTest): Communications link failure(..)
21:14:07 <breeze> LeeBreisacher2: but other problems are cleared up
21:14:07 *** jkeiper has quit IRC
21:14:08 <LeeBreisacher2> breeze: ok, now we're getting "expected" problems
21:14:08 <LeeBreisacher2> breeze: my goof..fixing..
21:14:08 <LeeBreisacher2> breeze: yep
21:14:11 <breeze> LeeBreisacher2: ok...cool.
21:15:13 <breeze> LeeBreisacher2: what was the prob? some connection param not set correctly?
21:15:44 *** LeeBreisacher2 has quit IRC
21:16:26 *** akwatuha has quit IRC
21:16:27 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1172 has FAILED (1 tests failed) : Rebuilt 1 times <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1172>
21:16:35 <LeeBreisacher> breeze: yes, I forgot the ".openmrs.org" on the devtest01. but now we're getting "SQLException: Access denied for user 'root'@'gw78.iu.xsede.org' "
21:16:40 *** akwatuha__ has joined #openmrs
21:16:40 <LeeBreisacher> breeze: what's that mean?
21:18:11 *** mareias has joined #openmrs
21:19:11 <LeeBreisacher> breeze: is ci-stg not the "real" name of the server? gw78.iu.xsede.org ?
21:21:15 <breeze> LeeBreisacher: yep that looks like more in my realm looking into it now
21:21:44 <LeeBreisacher> breeze: tnx
21:22:24 <breeze> LeeBreisacher: but correct, the name its complaining about is the real name of the ci server
21:22:39 <LeeBreisacher> breeze: so ci-stg is a vm?
21:22:47 <breeze> LeeBreisacher: no. an alias
21:23:20 <LeeBreisacher> breeze: when I ping both of them, I get different IPs
21:23:42 <breeze> LeeBreisacher: hmm...maybe ryates can explain that one then....
21:24:10 <LeeBreisacher> breeze: but this is way out of my area ("How many programmers does it take to screw in a lightbulb? None, that's a hardware problem")
21:24:38 <breeze> LeeBreisacher: :)
21:24:57 <breeze> LeeBreisacher: and hence "devops" was born
21:25:06 <breeze> LeeBreisacher: or thus
21:26:10 <breeze> LeeBreisacher: argh...reran the build and same prob. gotta go a bit deeper on this one. might take a while....
21:26:11 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1172 has FAILED (1 tests failed) : Rebuilt 2 times <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1172>
21:26:27 <ryates> breeze: the vms have multiple ips so the firewall probably just needs a minor adjustment
21:26:46 <LeeBreisacher> downey, ryates: can you help us figure out this error: "SQLException: Access denied for user 'root'@'gw78.iu.xsede.org' "
21:27:33 <LeeBreisacher> ryates: sorry, didn't see your note to breeze. thanks!
21:28:31 <LeeBreisacher> ryates: should I update/re-open ITSM-3655?
21:28:48 <breeze> LeeBreisacher: ok..looks like my change within the mysql server didn't stick....
21:29:20 <downey> LeeBreisacher: FYI, you'd specific permissions from the source IP for the given MySQL user that you're connecting as
21:31:42 *** NameFILI_ has joined #openmrs
21:31:42 *** NameFILIP has quit IRC
21:32:35 <breeze> downey: hmm.. got a min to help, and how are your mysql server admin skills?
21:33:24 <downey> breeze: whatcha need?
21:34:04 <breeze> downey: so I'm looking at th privs on the mysql server for devtest01
21:34:10 <breeze> downey: and this is there GRANT ALL PRIVILEGES ON `openmrs`.* TO 'root'@'%'
21:34:23 <breeze> downey: which tells me we should not be seeing the error we're seeing
21:35:29 <downey> yikes, i hope that's not in there
21:35:39 <downey> let me take a look
21:37:44 <downey> breeze: hmm, i don't seem to have the mysql root user for that box in our password db. did you set it up?
21:38:05 <breeze> downey: let me give it to you more privately
21:38:11 <downey> thanks. :)
21:38:22 <downey> you could put it in /tmp if you like
21:40:40 *** NameFILI_ has quit IRC
21:51:57 <breeze> LeeBreisacher: I think we have a fix....rerunning now
21:52:11 <downey> fingers crossed
21:52:11 <LeeBreisacher> breeze: cool. yeah, watching bamboo...
21:52:30 <LeeBreisacher> breeze: maybe you can tell me privately what you did...
21:52:37 <downey> LeeBreisacher: I think mysql needed to be told that specific host name was OK to connect from
21:53:00 <LeeBreisacher> downey: sounds reasonable
21:53:07 <breeze> LeeBreisacher: yeah, what downey said :)
21:53:15 <breeze> LeeBreisacher: didnt know that one myself
21:56:56 <downey> breeze: gotta run but if you have further problems please open a ticket :)
21:57:07 <breeze> downey: ok...thanks for the help
21:57:19 <downey> good luck! :)
21:58:09 <downey> breeze & LeeBreisacher - Too bad we couldn't get you both out to Kenya next month, will have to try harder for the next one maybe? :)
21:58:33 <breeze> downey: I wanted to go, and I think TW wanted me too, but my wife had other thoughts :)
21:58:41 <downey> breeze: Happy wife, happy life :)
21:58:51 <breeze> downey: :)
21:59:14 <LeeBreisacher> downey, breeze: bummer, same error...
21:59:15 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1172 has FAILED (1 tests failed) : Rebuilt 4 times <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1172>
21:59:24 <breeze> LeeBreisacher: yeah....
22:00:39 <breeze> LeeBreisacher: one more idea that I'll need your help on...give me a min to get a plan together
22:04:54 <breeze> LeeBreisacher: ok...any chance we can change the user from root back to openmrs_user?
22:05:06 <LeeBreisacher> breeze: trivial..moment..
22:07:34 <LeeBreisacher> breeze: rebuilding...
22:09:46 <breeze> LeeBreisacher: cool...where are you changing that btw?
22:10:09 <LeeBreisacher> just the mvn command line in bamboo
22:10:25 <breeze> LeeBreisacher: yeah...so I'm confused.....where is that change?
22:10:26 <LeeBreisacher> breeze: -D...
22:11:08 <breeze> LeeBreisacher: ah
22:11:19 <LeeBreisacher> breeze: not sure if this url will work: https://ci-stg.openmrs.org/build/admin/edit/editBuildTasks.action?buildKey=REFAPP-OMODDISTRO-INTTESTS
22:11:21 <breeze> LeeBreisacher: sorry...forgot that convo
22:11:40 <LeeBreisacher> breeze: *you* set this up initially!
22:12:05 <breeze> LeeBreisacher: remind me, what is using that URL?
22:12:18 <LeeBreisacher> breeze: looks like it failed again..
22:12:19 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1172 has FAILED (1 tests failed) : Rebuilt 5 times <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1172>
22:12:42 <LeeBreisacher> breeze: same error but with different user id
22:13:37 <LeeBreisacher> breeze: not sure what you mean by "using that URL". that's just pointing to where I'm changing the mvn command line.
22:14:43 <breeze> LeeBreisacher: oh, you wanted me to actually browse to that link :) I thought you were talking about some config somewhere
22:14:46 *** robbyoconnor has joined #openmrs
22:14:47 *** ChanServ sets mode: +v robbyoconnor
22:14:56 <LeeBreisacher> breeze: I click "actions/configure plan", then select the Run Tests job and then "tasks", then ...yeah...
22:15:20 <LeeBreisacher> breeze: you restarted it again?
22:15:34 <breeze> LeeBreisacher: yes. so that pw on that command string?
22:16:01 <LeeBreisacher> breeze: uh...yeah...D and I discussed it and decided it was ok there... ?
22:16:27 <LeeBreisacher> breeze: but I'm open to other ideas of course...
22:16:29 <breeze> LeeBreisacher: going to google since we're about to talk pws
22:20:12 <breeze> LeeBreisacher: ugh now my bamboo connection decided to slow to a crawl
22:20:26 <LeeBreisacher> breeze: want me to change it?
22:20:31 *** robbyoconnor has quit IRC
22:20:54 <breeze> LeeBreisacher: maybe...I clicked save on the change and it's been spinning for about a min now
22:21:18 <LeeBreisacher> breeze: looks like your change "took"
22:21:39 <LeeBreisacher> breeze: so re-run after this one fails..
22:22:04 <breeze> LeeBreisacher: ok...I think it's a sign of firday, I was watching the build spinner and thought it was the browser spinner
22:22:19 <LeeBreisacher> breeze: :-D
22:22:20 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1173 has FAILED (1 tests failed) : Manual build by Chris Briesemeister <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1173>
22:22:49 <LeeBreisacher> breeze: are you restarting? should be able to just do the failed job
22:23:19 <breeze> LeeBreisacher: I know....just did it for kicks
22:24:15 <breeze> LeeBreisacher: ok...one more time.....
22:31:18 <LeeBreisacher> breeze: I see you changed the db username back too...
22:31:48 <LeeBreisacher> breeze: it passed!
22:32:00 <breeze> LeeBreisacher: woohoo
22:32:09 <breeze> LeeBreisacher: was watching on the server side
22:36:51 <LeeBreisacher> djazayeri: so, we've got green build again. thanks to breeze and downey.
22:36:53 <OpenMRSBot> Recent updates in the world of openmrsci: CA-CA-231 has FAILED (2 tests failed) : Updated by djazayeri <https://ci-stg.openmrs.org/browse/CA-CA-231>
22:36:59 <djazayeri> breeze++
22:37:01 <djazayeri> downey++
22:37:07 <djazayeri> LeeBreisacher++
22:37:32 <LeeBreisacher> djazayeri: but I'd like to step back and re-discuss database setup/teardown again...
22:38:06 <LeeBreisacher> djazayeri: I'll send email over the weekend...
22:38:25 <djazayeri> LeeBreisacher: okay, cool
22:38:30 <djazayeri> LeeBreisacher: I'll fix the CA build
22:38:54 *** breeze has quit IRC
22:40:31 <downey> Cool. ;)
22:41:04 *** NameFILIP has joined #openmrs
22:41:04 *** ChanServ sets mode: +v NameFILIP
22:45:30 *** NameFILIP has quit IRC
22:48:41 <LeeBreisacher> djazayeri: sigh...spoke too soon? refapp build failed, but due to start-openmrs taking too long
22:48:42 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1174 has FAILED : Dependant of RA-RA-142 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1174>
22:48:50 <LeeBreisacher> djazayeri: "Waited for 5 minutes and Tomcat has not started."
22:50:13 <LeeBreisacher> djazayeri: but it seems to have (eventually) started ok..
22:50:33 <djazayeri> LeeBreisacher: hmm, did we do anything different?
22:50:41 <LeeBreisacher> djazayeri: no
22:51:01 <LeeBreisacher> djazayeri: but sometimes it does seem to take extra long to start openmrs
22:51:37 <LeeBreisacher> djazayeri: I assume the actual underlying hardware is doing lots of different things?
22:51:46 <djazayeri> LeeBreisacher: I also assume that.
22:52:41 <LeeBreisacher> djazayeri: there's a 5 minute timeout. it usually takes about 3 minutes. I suppose we could increase the timeout, but we might be masking an actual perf problem
22:53:06 <djazayeri> LeeBreisacher: "might"?
22:53:29 <djazayeri> LeeBreisacher: so, recently my Mirebalais setup has been taking a very long time to start up, but my refapp setup has be breezy
22:53:52 <LeeBreisacher> djazayeri: sigh. seems like all these things should be (much) faster...
22:54:17 <LeeBreisacher> djazayeri: but I assume doing serious perf investigation is not high on anyone's list..
22:54:46 <djazayeri> LeeBreisacher: not in the next 3 weeks unfortunately
22:54:52 <LeeBreisacher> djazayeri: IRL, these servers are not started very often, right?
22:56:00 <djazayeri> LeeBreisacher: nope
22:56:04 *** sgithens has joined #openmrs
22:56:38 <LeeBreisacher> djazayeri: oh, different topic: there are still two annoying UI bugs that I'm aware of on register-patient. (1) if you click "Female" with the mouse, you get the red "Required" warning. (2) the Month drop-down is still not keyboard-controllable.
23:06:02 <LeeBreisacher> djazayeri: started in 158 seconds this time.. shrug..
23:09:17 *** jkeiper has joined #openmrs
23:09:17 *** ChanServ sets mode: +v jkeiper
23:19:26 *** wyclif has quit IRC
23:30:19 <djazayeri> LeeBreisacher: the month dropdown is keyboard-controllable for me
23:41:39 *** NameFILIP has joined #openmrs
23:41:40 *** ChanServ sets mode: +v NameFILIP
23:46:20 *** NameFILIP has quit IRC
23:51:56 <LeeBreisacher> djazayeri: what OS and browser?
23:54:07 <LeeBreisacher> djazayeri: ok, firefox works much better than chrome. but still not perfect. Windows of course.
23:55:30 *** cospih has joined #openmrs
23:58:39 <LeeBreisacher> djazayeri: chrome is awful.