| 00:30:12 | *** NameFILIP has joined #openmrs |
| 00:30:12 | *** ChanServ sets mode: +v NameFILIP |
| 00:34:43 | *** NameFILIP has quit IRC |
| 00:49:36 | *** wyclif has joined #openmrs |
| 00:55:50 | *** wyclif has quit IRC |
| 01:30:41 | *** NameFILIP has joined #openmrs |
| 01:30:41 | *** ChanServ sets mode: +v NameFILIP |
| 01:35:38 | *** NameFILIP has quit IRC |
| 01:48:31 | *** upul has joined #openmrs |
| 02:18:29 | *** akwatuha__ has quit IRC |
| 02:20:50 | *** sashrika has joined #openmrs |
| 02:31:12 | *** NameFILIP has joined #openmrs |
| 02:31:12 | *** ChanServ sets mode: +v NameFILIP |
| 02:32:24 | *** wyclif has joined #openmrs |
| 02:36:12 | *** NameFILIP has quit IRC |
| 02:51:23 | *** sashrika has quit IRC |
| 03:07:16 | *** harsz89 has joined #openmrs |
| 03:07:17 | *** ChanServ sets mode: +v harsz89 |
| 03:20:07 | *** k-joseph has joined #openmrs |
| 03:30:12 | *** sashrika has joined #openmrs |
| 03:31:41 | *** NameFILIP has joined #openmrs |
| 03:31:41 | *** ChanServ sets mode: +v NameFILIP |
| 03:35:36 | *** davidpardz has quit IRC |
| 03:35:58 | *** NameFILIP has quit IRC |
| 04:15:33 | *** k-joseph has quit IRC |
| 04:28:53 | *** wyclif has quit IRC |
| 04:32:11 | *** NameFILIP has joined #openmrs |
| 04:32:11 | *** ChanServ sets mode: +v NameFILIP |
| 04:36:46 | *** NameFILIP has quit IRC |
| 04:39:25 | *** k-joseph has joined #openmrs |
| 04:41:02 | *** djazayeri has quit IRC |
| 05:32:41 | *** NameFILIP has joined #openmrs |
| 05:32:41 | *** ChanServ sets mode: +v NameFILIP |
| 05:37:09 | *** NameFILIP has quit IRC |
| 06:24:35 | *** k-joseph has quit IRC |
| 06:42:31 | *** isaac___ has joined #openmrs |
| 06:43:22 | *** k-joseph has joined #openmrs |
| 07:01:53 | *** dmulindwa has joined #openmrs |
| 07:03:13 | *** NameFILIP has joined #openmrs |
| 07:03:13 | *** ChanServ sets mode: +v NameFILIP |
| 07:05:53 | *** dmulindwa_ has joined #openmrs |
| 07:06:05 | *** dmulindwa has quit IRC |
| 07:06:16 | *** Mkop has quit IRC |
| 07:06:40 | *** Mkop has joined #openmrs |
| 07:07:38 | *** NameFILIP has quit IRC |
| 07:08:46 | *** dkayiwa has joined #openmrs |
| 07:08:47 | *** isaac___ has quit IRC |
| 07:13:41 | *** mareias has joined #openmrs |
| 07:17:47 | *** isaac___ has joined #openmrs |
| 07:29:42 | *** rcrichton has joined #openmrs |
| 07:33:03 | *** k-joseph has quit IRC |
| 07:33:29 | *** sashrika has quit IRC |
| 07:34:38 | *** k-joseph has joined #openmrs |
| 07:47:38 | *** dmulindwa_ has quit IRC |
| 07:51:09 | *** dmulindwa has joined #openmrs |
| 07:55:08 | *** k-joseph has quit IRC |
| 07:58:09 | *** upul has quit IRC |
| 08:00:37 | *** k-joseph has joined #openmrs |
| 08:03:43 | *** NameFILIP has joined #openmrs |
| 08:03:43 | *** ChanServ sets mode: +v NameFILIP |
| 08:07:43 | *** isaac___ has quit IRC |
| 08:07:56 | *** NameFILIP has quit IRC |
| 08:30:33 | *** k-joseph has quit IRC |
| 09:04:12 | *** NameFILIP has joined #openmrs |
| 09:04:12 | *** ChanServ sets mode: +v NameFILIP |
| 09:04:40 | *** k-joseph has joined #openmrs |
| 09:04:53 | *** NameFILIP has quit IRC |
| 09:05:14 | *** NameFILIP has joined #openmrs |
| 09:05:14 | *** ChanServ sets mode: +v NameFILIP |
| 10:09:18 | *** k-joseph has quit IRC |
| 10:35:16 | *** k-joseph has joined #openmrs |
| 10:36:08 | <k-joseph> away |
| 11:07:33 | *** k-joseph has quit IRC |
| 11:28:10 | *** mareias has quit IRC |
| 11:29:42 | *** mareias has joined #openmrs |
| 11:31:34 | *** dmulindwa has quit IRC |
| 11:55:27 | *** dmulindwa has joined #openmrs |
| 12:13:16 | *** GitHub174 has joined #openmrs |
| 12:13:16 | <GitHub174> [openmrs-core] dkayiwa pushed 1 new commit to 1.9.x: http://git.io/uJLQgg |
| 12:13:16 | <GitHub174> openmrs-core/1.9.x c022c55 dkayiwa: Backporting to 1.9.x: In context-sensitive tests, @SkipBaseSetup... |
| 12:13:16 | *** GitHub174 has left #openmrs |
| 12:20:20 | *** GitHub176 has joined #openmrs |
| 12:20:21 | <GitHub176> [openmrs-core] dkayiwa pushed 1 new commit to 1.8.x: http://git.io/EJOHnw |
| 12:20:21 | <GitHub176> openmrs-core/1.8.x 9637ec5 dkayiwa: Backporting to 1.8.x: In context-sensitive tests, @SkipBaseSetup... |
| 12:20:21 | *** GitHub176 has left #openmrs |
| 12:41:24 | *** k-joseph has joined #openmrs |
| 12:41:35 | *** robbyoconnor has quit IRC |
| 12:45:00 | *** k-joseph has quit IRC |
| 12:45:00 | *** k-joseph has joined #openmrs |
| 12:48:49 | *** wyclif has joined #openmrs |
| 12:56:57 | *** harsz89 has quit IRC |
| 13:00:34 | *** cospih has joined #openmrs |
| 13:03:11 | *** LeeBreisacher1 has left #openmrs |
| 13:04:22 | *** NameFILIP has quit IRC |
| 13:07:51 | *** harsz89 has joined #openmrs |
| 13:07:51 | *** ChanServ sets mode: +v harsz89 |
| 13:25:06 | *** djazayeri has joined #openmrs |
| 13:25:07 | *** ChanServ sets mode: +o djazayeri |
| 13:28:10 | *** wyclif has quit IRC |
| 13:28:23 | *** wyclif has joined #openmrs |
| 13:31:52 | <djazayeri> wyclif, rafa, (dkayiwa if around), cpower: standup |
| 13:35:08 | *** akwatuha__ has joined #openmrs |
| 13:36:33 | *** akwatuha__ has quit IRC |
| 13:36:33 | *** akwatuha__ has joined #openmrs |
| 13:58:40 | <cpower> Hello everyone and welcome to Monday for most! |
| 13:59:56 | <h3llborn> hahah |
| 14:00:21 | <h3llborn> cpower: the scary thing is, my university classes start as of today :( |
| 14:00:53 | <cpower> h3llborn: wow I'm 3 weeks in |
| 14:00:53 | *** k-joseph has quit IRC |
| 14:01:44 | <cpower> h3llborn: and all I have to show for it is a working tomcat instance, loaded the latest Java SDK and installed TextPad |
| 14:02:01 | <cpower> Now on to things with a bit more fun |
| 14:02:06 | <cpower> SCRUM! |
| 14:02:13 | <h3llborn> cpower: ahah damn |
| 14:02:13 | <cpower> !scrumon cpower |
| 14:02:13 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:03:12 | <cpower> Order: h3llborn , rafa , dkayiwa , djazayeri , wyclif , and anyone else that would like to update or has questions on what they are working on in OpenMRS |
| 14:03:42 | <h3llborn> -Weekend |
| 14:03:42 | <h3llborn> - Got ready for school, which starts today |
| 14:03:42 | <h3llborn> - Looked at the new SDK-Tickets |
| 14:03:42 | <h3llborn> - Spent $300 on books for 2 classes |
| 14:03:42 | <h3llborn> Today |
| 14:03:43 | <h3llborn> - work on tickets, that were recently added over the weekend during my 3hr break and then later during the day |
| 14:04:43 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: KenyaCore 0.9.1 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=kenyacore&version=&0.9.1> |
| 14:04:47 | *** NameFILIP has joined #openmrs |
| 14:04:47 | *** ChanServ sets mode: +v NameFILIP |
| 14:05:14 | <dkayiwa> Made a followup commit for: Issues with estimated birthdates - RA-181 |
| 14:05:15 | <dkayiwa> Did some ticket administration |
| 14:05:15 | <dkayiwa> Back ported to 1.9.x and 1.8.x : In context-sensitive tests, @SkipBaseSetup annotation is not inherited from superclasses - TRUNK-4051 |
| 14:05:15 | <dkayiwa> Now going for remaining issues for: Create a cyclical Capture Vital Signs App - RA-173 |
| 14:05:15 | <dkayiwa> No Blockers |
| 14:05:35 | <rafa> Over the weekend worked on GSoC |
| 14:05:35 | <rafa> Today: |
| 14:05:35 | <rafa> * Committed RA-146 |
| 14:05:35 | <rafa> Include diagnoses on the patient dashboard |
| 14:05:35 | <rafa> https://tickets.openmrs.org/browse/RA-146 |
| 14:05:35 | <rafa> * Working on RA-197 |
| 14:05:35 | <rafa> Set up and test the DEPD |
| 14:05:36 | <rafa> https://tickets.openmrs.org/browse/RA-197 |
| 14:05:36 | <rafa> No blockers. |
| 14:06:56 | <djazayeri> Recently |
| 14:06:56 | <djazayeri> * Review lots of work by Wyclif, Daniel, and Rafal |
| 14:06:56 | <djazayeri> * Paired with cvortmann on Dispensing |
| 14:06:56 | <djazayeri> * Committed HTML-114 - Support creation of observations with a drug as a value |
| 14:06:56 | <djazayeri> * Committed RA-147 CSS fix (Include vitals on the CFPD) |
| 14:07:02 | <djazayeri> was on vacation on Friday |
| 14:07:04 | <djazayeri> no blockers |
| 14:07:11 | <wyclif> Friday: |
| 14:07:12 | <wyclif> - Completed RA-151 - Allow actions from the CFPD |
| 14:07:13 | <wyclif> - Fixed failing smoke tests |
| 14:07:15 | <wyclif> - weekly GSoC chat with Ishara |
| 14:07:16 | <wyclif> - RA-187 - DEPD issues |
| 14:07:18 | <wyclif> Monday: |
| 14:07:19 | <wyclif> - RA-199 - Improve UI/UX of Patient Lookup |
| 14:07:20 | <wyclif> |
| 14:07:21 | <wyclif> Blockers: None |
| 14:09:45 | *** NameFILIP has quit IRC |
| 14:09:47 | <cpower> great! Still working on what the design call should look like today (Help djazayeri) and on Wednesday. Working on setting up a conversation about Community Development soon (this/next week) feel free to comment and join. |
| 14:09:59 | <cpower> !scrumoff |
| 14:09:59 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:10:13 | <djazayeri> cpower: TW India is going to bring some design questions |
| 14:10:50 | *** NameFILIP has joined #openmrs |
| 14:10:50 | *** ChanServ sets mode: +v NameFILIP |
| 14:11:23 | *** rcrichton has quit IRC |
| 14:22:23 | *** LeeBreisacher has joined #openmrs |
| 14:32:56 | <cpower> djazayeri: excellent! |
| 14:38:20 | *** Mkop has quit IRC |
| 14:47:52 | <djazayeri> dkayiwa: hey, you were only supposed to do *one* of those two numbered items on the code review comment |
| 14:47:53 | <djazayeri> :-) |
| 14:48:07 | <djazayeri> dkayiwa: I'll comment on the commit |
| 14:48:29 | <dkayiwa> djazayeri: will wait for the comment :) |
| 14:49:30 | <djazayeri> dkayiwa: commented |
| 15:08:54 | <OpenMRSBot> Recent updates in the world of openmrsci: CA-CA-215 has FAILED (1 tests failed) : Updated by Rafal Korytkowski <https://ci-stg.openmrs.org/browse/CA-CA-215> |
| 15:09:19 | *** mareias has quit IRC |
| 15:10:51 | *** dmulindwa has quit IRC |
| 15:30:43 | *** smuriu has joined #openmrs |
| 15:46:07 | <dkayiwa> smuriu: hi |
| 15:46:42 | *** mareias has joined #openmrs |
| 15:51:20 | *** smuriu_ has joined #openmrs |
| 15:51:38 | *** smuriu has quit IRC |
| 15:52:29 | <dkayiwa> smuriu_: hi |
| 15:53:15 | *** Ozge has joined #openmrs |
| 15:56:47 | <smuriu_> hi daniel |
| 15:57:24 | <dkayiwa> smuriu_: can you use my irc name as it appears here? that way my irc client will alert me to attend to you :) |
| 15:58:04 | <smuriu_> cool dkayiwa |
| 15:58:34 | <smuriu_> am very new to IRC. can you tell? |
| 15:59:14 | *** robbyoconnor has joined #openmrs |
| 15:59:14 | *** ChanServ sets mode: +v robbyoconnor |
| 16:00:04 | <Ozge> Hi, will there be a design forum today? |
| 16:01:57 | <dkayiwa> smuriu_: you need to type my irc name for each line you send :) |
| 16:02:32 | <smuriu_> dkayiwa ok :) |
| 16:02:34 | <dkayiwa> smuriu_: and you need to ask what you need such that every one in here can be of help :) |
| 16:02:53 | <smuriu_> dkayiwa: do I also have to put the colon after your username? |
| 16:02:59 | <dkayiwa> smuriu_: no |
| 16:03:07 | <djazayeri> Ozge: yes, calling in now |
| 16:04:28 | <djazayeri> downey, burke, jkeiper, someone with the power, can you start the design forum Connect room? |
| 16:05:06 | <dkayiwa> cpower: even your name has the power :) |
| 16:05:23 | <djazayeri> cpower, rafa, dkayiwa, wyclif: one of you can do this. :-) |
| 16:05:26 | <djazayeri> ^^ |
| 16:05:36 | <jkeiper> djazayeri: done |
| 16:05:46 | <dkayiwa> jkeiper: you are de man :) |
| 16:05:59 | <djazayeri> thanks jkeiper |
| 16:06:01 | <jkeiper> np |
| 16:06:30 | <wyclif> djazayeri: i don't think i can |
| 16:06:37 | <smuriu_> dkayiwa: using the HL7Query Module on both OpenMRS 1.9.3 and 1.8.2. When I make a request, I get a stack trace as shown on http://pastebin.com/PfEL60jm |
| 16:06:52 | <dkayiwa> smuriu_: looking at it |
| 16:07:15 | <dkayiwa> suranga: are you on? |
| 16:07:35 | <dkayiwa> suranga__: ping |
| 16:08:07 | <smuriu_> dkayiwa: the query completes fine and the ORUR01 msg is returned. the stack trace is only on the server side |
| 16:08:18 | <djazayeri> burke: can you join the design forum? |
| 16:08:27 | <dkayiwa> suranga__: then in that case you are done :) |
| 16:10:50 | <dkayiwa> smuriu_: then in that case you are done. not so? :) |
| 16:12:38 | *** NameFILIP has quit IRC |
| 16:13:29 | <smuriu_> dkayiwa: just wondering why the stack is generated. Seems like some concept is not being parsed correctly. Though I can't tell what it is yet |
| 16:13:45 | <dkayiwa> smuriu_: can you also pastebin what you are sending? |
| 16:19:05 | <smuriu_> dkayiwa: see http://pastebin.com/4g7j4cLq |
| 16:20:46 | *** davidpardz has joined #openmrs |
| 16:20:46 | *** ChanServ sets mode: +v davidpardz |
| 16:24:11 | <dkayiwa> smuriu_: can you give me some background regarding what you are trying to do? :) |
| 16:25:47 | <mareias> wyclif: can you mute yourself in the design call? :) |
| 16:27:25 | <dkayiwa> :) |
| 16:30:28 | <smuriu_> dkayiwa: I intend to extract data from an OpenMRS instance and present it to an authorised person together with some data I will also extract from a dcm4che instance |
| 16:31:41 | *** Ozge has quit IRC |
| 16:31:54 | <smuriu_> dkayiwa: so essentially it shouldn't matter whether or not there's a stack trace after the call but it'd be nice to know why it's there |
| 16:32:09 | <dkayiwa> smuriu_: i agree |
| 16:32:43 | <dkayiwa> smuriu_: does it happen for all submissions? or just some? |
| 16:35:08 | <smuriu_> dkayiwa: seems to happen for all requests |
| 16:37:50 | *** robbyoconnor has quit IRC |
| 16:39:30 | <dkayiwa> smuriu_: with different data? |
| 16:40:36 | <smuriu_> dkayiwa: I've tried with different patientId's only. Same idTypeUuid. Haven't tried with any other parameters |
| 16:46:50 | *** robbyoconnor has joined #openmrs |
| 16:46:50 | *** ChanServ sets mode: +v robbyoconnor |
| 16:47:03 | <dkayiwa> smuriu_: how many concepts are you trying to pass in? |
| 16:47:15 | <dkayiwa> smuriu_: as in how many obs? |
| 16:52:16 | *** robbyoconnor has quit IRC |
| 16:55:51 | <smuriu_> dkayiwa: quite a number. Running this on the data in the demo database. I assume each of the patients in the database has several encounters and obs |
| 16:56:41 | <dkayiwa> smuriu_: can you do a submission with just one obs? |
| 16:58:50 | <dkayiwa> smuriu_: do you know how to? |
| 17:01:22 | <smuriu_> dkayiwa: nope. I've added an encounterUuid parameter to restrict the number of results (still throws that exception ...). How else would I do it? |
| 17:02:18 | <dkayiwa> smuriu_: create a new patient. then enter just one obs for him (.eg WEIGHT). Finally test with the new patientId :) |
| 17:13:00 | *** NameFILIP has joined #openmrs |
| 17:13:00 | *** ChanServ sets mode: +v NameFILIP |
| 17:17:48 | *** NameFILIP has quit IRC |
| 17:29:21 | <smuriu_> dkayiwa: no error with just one obs |
| 17:29:59 | <dkayiwa> smuriu_: so i suspect there could be an obs whose concept is not well defined |
| 17:30:24 | <dkayiwa> smuriu_: the trick is how to go through them one by one and get the culprit :) |
| 17:30:39 | <smuriu_> dkayiwa: that would be an error in the demo database? |
| 17:30:50 | <dkayiwa> smuriu_: probably |
| 17:46:16 | <smuriu_> dkayiwa: I'll have to try find that some other time. thanks for all the help today :) |
| 17:46:46 | <dkayiwa> smuriu_: 8) |
| 17:48:13 | *** smuriu_ has left #openmrs |
| 17:48:59 | <LeeBreisacher> djazayeri: hi Darius. reminder: devtest01 mysql id/pwd... |
| 17:52:55 | *** breeze has joined #openmrs |
| 17:53:10 | <djazayeri> LeeBreisacher: a necessary reminder |
| 17:53:21 | <djazayeri> LeeBreisacher: is the question "what's the password"? |
| 17:53:30 | <djazayeri> LeeBreisacher: or is it "where should we store it"? |
| 17:53:42 | <LeeBreisacher> djazayeri: both (also, "what's the userid?") |
| 17:55:15 | <djazayeri> LeeBreisacher: connection.username=openmrs_user |
| 17:55:29 | <djazayeri> LeeBreisacher: the password is something clearly autogenerated |
| 17:56:15 | <LeeBreisacher> djazayeri: where are you looking? |
| 17:56:37 | <djazayeri> LeeBreisacher: I sshd to the machine and looked at /usr/share/tomcat7/.OpenMRS |
| 18:00:26 | *** NameFILIP has joined #openmrs |
| 18:00:26 | *** ChanServ sets mode: +v NameFILIP |
| 18:06:25 | *** rcrichton has joined #openmrs |
| 18:10:42 | *** dkayiwa_ has joined #openmrs |
| 18:13:19 | *** dkayiwa has quit IRC |
| 18:13:19 | *** dkayiwa_ is now known as dkayiwa |
| 18:21:23 | *** davidpardz has quit IRC |
| 18:30:50 | *** cospih has quit IRC |
| 18:33:03 | *** cospih has joined #openmrs |
| 18:40:56 | *** robbyoconnor has joined #openmrs |
| 18:40:56 | *** ChanServ sets mode: +v robbyoconnor |
| 18:43:11 | *** r0bby_ has joined #openmrs |
| 18:43:11 | *** ChanServ sets mode: +v r0bby_ |
| 18:47:19 | *** robbyoconnor has quit IRC |
| 18:50:38 | *** r0bby_ has quit IRC |
| 18:57:31 | *** Mkop has joined #openmrs |
| 19:03:26 | *** harsz89 has quit IRC |
| 19:09:48 | <LeeBreisacher> I cannot connect to https://ci-stg.openmrs.org/ -- is it just me? |
| 19:11:48 | *** rcrichton has quit IRC |
| 19:14:15 | *** k-joseph has joined #openmrs |
| 19:14:49 | *** rcrichton has joined #openmrs |
| 19:17:46 | *** rcrichton has quit IRC |
| 19:34:10 | *** NameFILIP has quit IRC |
| 19:36:34 | *** Ozge has joined #openmrs |
| 19:38:27 | *** r0bby_ has joined #openmrs |
| 19:38:27 | *** ChanServ sets mode: +v r0bby_ |
| 19:38:57 | *** robbyoconnor has joined #openmrs |
| 19:38:57 | *** ChanServ sets mode: +v robbyoconnor |
| 19:43:03 | *** r0bby_ has quit IRC |
| 19:47:58 | <LeeBreisacher> djazayeri, breeze, wyclif: I cannot connect to https://ci-stg.openmrs.org/ -- is it just me? |
| 19:49:24 | *** NameFILIP has joined #openmrs |
| 19:49:24 | *** ChanServ sets mode: +v NameFILIP |
| 20:00:37 | <wyclif> as in the page doesn't load? |
| 20:00:47 | <wyclif> LeeBreisacher: as in the page doesn't load? |
| 20:00:53 | <wyclif> LeeBreisacher: i have just loaded the page |
| 20:01:17 | <wyclif> LeeBreisacher: at times that server is very slow |
| 20:01:48 | <LeeBreisacher> wyclif: I know. but now I'm not getting to it at all. maybe I'll try clearing browser cache.. |
| 20:03:24 | <LeeBreisacher> wyclif: still not working. well, thanks for checking. must be something on my end... |
| 20:06:21 | *** lbeier has joined #openmrs |
| 20:06:56 | <wyclif> LeeBreisacher: works for me |
| 20:13:03 | *** robbyoconnor has quit IRC |
| 20:27:44 | *** rday has joined #openmrs |
| 20:29:35 | *** Ozge has quit IRC |
| 20:40:46 | *** lbeier has left #openmrs |
| 21:06:23 | *** k-joseph has quit IRC |
| 21:29:09 | *** wyclif has quit IRC |
| 21:46:49 | *** davidpardz has joined #openmrs |
| 21:46:50 | *** ChanServ sets mode: +v davidpardz |
| 21:48:30 | *** k-joseph has joined #openmrs |
| 22:09:50 | *** k-joseph has quit IRC |
| 22:28:25 | *** NameFILIP has quit IRC |
| 23:10:16 | *** elliott_w has quit IRC |
| 23:10:16 | *** jt48 has quit IRC |
| 23:23:26 | *** robbyoconnor has joined #openmrs |
| 23:23:26 | *** ChanServ sets mode: +v robbyoconnor |
| 23:28:50 | *** NameFILIP has joined #openmrs |
| 23:28:50 | *** ChanServ sets mode: +v NameFILIP |
| 23:33:30 | *** jet__ has joined #openmrs |
| 23:33:57 | *** NameFILIP has quit IRC |
| 23:40:48 | *** wyclif has joined #openmrs |
| 23:42:32 | <djazayeri> wyclif: you there? |
| 23:43:24 | <wyclif> djazayeri: yeah |
| 23:44:31 | <djazayeri> wyclif: some questions about the paper record refactoring (around the include extension point) |
| 23:45:50 | <djazayeri> wyclif: is it possible to move the logic into the extension.gsp (fragment) so it isn't duplicated? |
| 23:47:39 | <djazayeri> wyclif: (and should I leave the ticket open for you to do that?) |
| 23:50:06 | <wyclif> djazayeri: i thought it is in a gap? |
| 23:50:58 | <wyclif> djazayeri gap -> gap |
| 23:51:22 | <djazayeri> wyclif: also, how is it that in this commit you have the includes_extension.json use provider and fragment ( https://github.com/openmrs/openmrs-module-coreapps/commit/ec605a6632401557e25667594717284911a17b2b ), but in this other commit I see resource and fragment? ( https://github.com/openmrs/openmrs-module-coreapps/commit/6ac047bf48f18b02014598b8ec761c3dfa23f2ba ) |
| 23:51:26 | <OpenMRSBot> <http://ln-s.net/-wQk> (at github.com) |
| 23:52:57 | <djazayeri> wyclif: I mean to say: instead of explicitly handling the include on both the gsps (for CFPD and DEPD) can you instead have those include the uicommons/extension fragment? |
| 23:53:41 | <djazayeri> wyclif: because I'm sure there's common logic there we'll want to get right and reuse |
| 23:54:50 | <wyclif> djazayeri: know of an example using the extension stuff? |
| 23:57:39 | <djazayeri> wyclif: I can't find any, so maybe it isn't actually being used |
| 23:58:14 | <djazayeri> wyclif: it would basically be: ui.includeFragment("uicommons", "extension", [ extension: ext ]) |
| 23:58:25 | <djazayeri> wyclif: I'm more interested in my other question: about resource vs provider |
| 23:59:42 | <wyclif> resource is a mistake, will fix it |
| 23:59:57 | <wyclif> i will try to do what you suggested tomorrow |