IRC Chat : 2013-08-31 - OpenMRS

00:10:45 *** Mkop has quit IRC
00:23:52 *** mogoodrich has joined #openmrs
00:26:47 *** mogoodrich__ has quit IRC
00:42:06 *** cospih has quit IRC
00:45:09 *** NameFILIP has joined #openmrs
00:45:09 *** ChanServ sets mode: +v NameFILIP
00:49:54 *** NameFILIP has quit IRC
00:55:10 *** mogoodrich has quit IRC
01:45:39 *** NameFILIP has joined #openmrs
01:45:39 *** ChanServ sets mode: +v NameFILIP
01:49:50 *** NameFILIP has quit IRC
02:05:39 *** wyclif has joined #openmrs
02:29:08 *** LeeBreisacher has left #openmrs
02:39:55 *** wyclif has quit IRC
02:40:02 *** sgithens has joined #openmrs
02:46:09 *** NameFILIP has joined #openmrs
02:46:10 *** ChanServ sets mode: +v NameFILIP
02:50:32 *** NameFILIP has quit IRC
03:36:00 *** bhashitha has joined #openmrs
03:46:39 *** NameFILIP has joined #openmrs
03:46:39 *** ChanServ sets mode: +v NameFILIP
03:51:23 *** NameFILIP has quit IRC
04:06:53 *** rday has joined #openmrs
04:47:09 *** NameFILIP has joined #openmrs
04:47:09 *** ChanServ sets mode: +v NameFILIP
04:51:40 *** NameFILIP has quit IRC
05:17:42 *** harshadura has joined #openmrs
05:17:43 *** ChanServ sets mode: +v harshadura
05:21:41 *** rday has quit IRC
05:39:47 *** rday has joined #openmrs
05:44:35 *** rday has quit IRC
05:47:40 *** NameFILIP has joined #openmrs
05:47:40 *** ChanServ sets mode: +v NameFILIP
05:52:15 *** NameFILIP has quit IRC
05:58:18 *** rday has joined #openmrs
06:32:23 *** maurya has joined #openmrs
07:03:47 *** suranga_ has joined #openmrs
07:06:23 *** mseaton_ has joined #openmrs
07:11:26 *** suranga has quit IRC
07:11:26 *** mseaton has quit IRC
07:11:27 *** mseaton_ is now known as mseaton
07:11:36 *** suranga_ is now known as suranga
07:17:53 *** NameFILIP has joined #openmrs
07:17:53 *** ChanServ sets mode: +v NameFILIP
07:22:43 *** NameFILIP has quit IRC
07:29:56 *** rday has quit IRC
08:07:35 *** maurya has quit IRC
08:48:04 *** NameFILIP has joined #openmrs
08:48:04 *** ChanServ sets mode: +v NameFILIP
08:48:37 *** harshadura has quit IRC
09:05:36 <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-1066 has FAILED : Dependant of CA-CA-182 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-1066>
09:19:30 *** mareias has joined #openmrs
09:30:26 *** cospih has joined #openmrs
09:47:13 *** mareias has quit IRC
10:37:31 *** bhashitha has quit IRC
12:42:44 *** rfriedman has joined #openmrs
14:39:33 <rfriedman> rafa, i don't expect for a minute that you're here, but if you are, could i have a word?
14:46:38 *** bhashitha has joined #openmrs
14:49:41 *** wyclif has joined #openmrs
14:53:09 <rfriedman> wyclif, you there? got a minute?
15:46:41 *** NameFILIP has quit IRC
15:51:26 *** wyclif has quit IRC
16:00:01 *** wyclif has joined #openmrs
16:30:06 <rfriedman> wyclif, you there? got a minute?
16:36:00 *** rfriedman has quit IRC
16:45:09 *** rfriedman has joined #openmrs
16:47:03 *** NameFILIP has joined #openmrs
16:47:03 *** ChanServ sets mode: +v NameFILIP
16:51:23 *** NameFILIP has quit IRC
17:07:59 *** dkayiwa has joined #openmrs
17:13:53 *** k-joseph has joined #openmrs
17:20:44 *** wyclif has quit IRC
17:30:43 <bhashitha> dkayiwa : Hi
17:30:47 <dkayiwa> bhashitha: hi
17:32:27 <bhashitha> dkayiwa : I'm trying to add custom controller to a portlet following https://wiki.openmrs.org/display/docs/Module+Portlets
17:33:16 <dkayiwa> bhashitha: ok
17:34:15 <bhashitha> dkayiwa : at the top of my portlet I added <prop key="**/datacomparisonmodulesportlet.portlet">datacomparisonmodulesportletController</prop>
17:34:29 <dkayiwa> bhashitha: can i see the full commit?
17:35:07 <bhashitha> dkayiwa : I didn't commit it since it's not working. Is it okay to commit it ?
17:35:17 <dkayiwa> bhashitha: yes commit
17:35:43 <bhashitha> dkayiwa : okay, give me couple of minutes
17:35:59 <dkayiwa> bhashitha: sure]
17:39:50 *** mareias has joined #openmrs
17:47:39 *** NameFILIP has joined #openmrs
17:47:39 *** ChanServ sets mode: +v NameFILIP
17:51:33 <bhashitha> dkayiwa : I just commited the code. Please refer https://github.com/openmrs/openmrs-module-datacomparison/commit/1668d854d18a117fc84ce9094de02e7958e9aa1b and https://github.com/bhashitha/openmrs-module-metadatasharing/commit/2dbf75bc18aad1732a4b542785362db4fbfc9770
17:51:37 <OpenMRSBot> <http://ln-s.net/-sXq> (at github.com)
17:52:07 *** NameFILIP has quit IRC
17:52:15 <dkayiwa> bhashitha: ok
18:05:11 <dkayiwa> bhashitha: so what is the problem?
18:06:05 <bhashitha> dkayiwa : The portlet doesn't mapped to the controller correctly
18:07:10 <bhashitha> dkayiwa : When I go to assess item page I can see "datacomparisonmodulesportletController" phrase instead of the comparison view
18:07:33 <dkayiwa> bhashitha: ok
18:08:03 <dkayiwa> bhashitha: what url is that?
18:09:44 <bhashitha> dkayiwa : go through /openmrs/module/metadatasharing/import/list.form
18:10:13 <dkayiwa> bhashitha: did you follow all the steps at? https://wiki.openmrs.org/display/docs/Module+Portlets
18:10:46 <bhashitha> dkayiwa : yes
18:11:18 <dkayiwa> bhashitha: can you mention them in summary form one by one in the same order as they are on that page?
18:12:24 <bhashitha> dkayiwa : Sure
18:12:29 *** wyclif has joined #openmrs
18:12:57 <bhashitha> dkayiwa : 1. Add following line to assessItem.jsp file in order to embedd DC comparison view to assess item page. <openmrs:portleturl="comparisonView"id="comparisonView"moduleId="datacomparison"/>
18:13:22 <dkayiwa> bhashitha: ok. next???
18:13:28 <bhashitha> dkayiwa : 2. Add following line at the top of omod/src/main/webapp/portlets/comparisonView.jsp in order to point the relevant controller <prop key="**/datacomparisonmodulesportlet.portlet">datacomparisonmodulesportletController</prop>
18:13:55 <dkayiwa> bhashitha: where did you read that?
18:14:23 <bhashitha> dkayiwa : 3. Add the following bean definition to omod/src/main/resources/webModuleApplicationContext.xml <bean id="datacomparisonmodulesportletController" class="org.openmrs.module.datacomparison.web.controller.DataComparisonModuleController"> </bean>
18:14:43 <bhashitha> dkayiwa : Sorry I didn't get you
18:14:43 <dkayiwa> bhashitha: can you first answer question?
18:14:57 <dkayiwa> bhashitha: where did you read step 2 from?
18:16:13 <bhashitha> dkayiwa : From that wiki page
18:16:45 <dkayiwa> bhashitha: can you paste it as it appears on the wiki?
18:18:32 <bhashitha> dkayiwa : If you want a custom controller, then in the basicUrlMapping bean in moduleApplicationContext, add a property for the portlet, pointing to the portlet's controller:
18:18:49 <dkayiwa> bhashitha: is that what you did?
18:18:57 <bhashitha> dkayiwa : Ahaaa, seems I have missed something
18:19:03 <dkayiwa> bhashitha: :)
18:21:17 *** dmulindwa has quit IRC
18:21:34 *** dmulindwa has joined #openmrs
18:22:13 *** k-joseph has quit IRC
18:25:09 <bhashitha> dkayiwa : I have an ambiguity on the adding it into the moduleApplicationContext.xml
18:25:19 <dkayiwa> bhashitha: which one
18:26:07 <bhashitha> dkayiwa : Both 2nd and 3rd step I mentioned after correction
18:26:25 <bhashitha> dkayiwa : Because moduleApplicationContext.xml is in api
18:26:51 <bhashitha> dkayiwa : But the web related things like controllers are in omod
18:27:15 <bhashitha> dkayiwa : But omod has webModuleApplicationContext.xml
18:27:53 <bhashitha> dkayiwa : Did you get my point ?
18:28:10 *** k-joseph has joined #openmrs
18:30:06 <dkayiwa> bhashitha: good catch. it should be webModuleApplicationContext.xml. Can you edit that on the wiki?
18:31:34 <bhashitha> dkayiwa : If so, I'll do that
18:33:50 <bhashitha> dkayiwa : btw, the <prop> tag is giving compile error in JSP file. http://pastebin.com/gT9rw3eV
18:36:38 <bhashitha> dkayiwa : *correction - in webModuleApplicationContext.xml file. (not in JSP )
18:37:35 <dkayiwa> bhashitha: you can look at other existing web application context in other modules to see the format :)
18:40:32 <bhashitha> dkayiwa : Okay, I'll give a try ;)
18:48:09 *** NameFILIP has joined #openmrs
18:48:09 *** ChanServ sets mode: +v NameFILIP
18:52:47 *** NameFILIP has quit IRC
18:57:14 *** NameFILIP has joined #openmrs
18:57:14 *** ChanServ sets mode: +v NameFILIP
18:59:35 *** k-joseph has quit IRC
19:05:47 *** k-joseph has joined #openmrs
19:06:31 *** sgithens has quit IRC
19:40:48 <bhashitha> dkayiwa : I could get it work :)
19:41:04 <dkayiwa> bhashitha: excellent :)
19:41:21 <bhashitha> dkayiwa : I updated the file name in that wiki page as well
19:41:35 <dkayiwa> bhashitha: thats so sweet!!! :)
19:43:51 <bhashitha> dkayiwa : Then, I'll try to pass parameters (which objects need to compare) from MDS module to custom controller :-O
19:44:06 <dkayiwa> bhashitha: ok
19:53:18 *** davidpardz has joined #openmrs
19:53:18 *** ChanServ sets mode: +v davidpardz
19:57:50 <k-joseph> dkayiwa: hi
19:58:01 <dkayiwa> k-joseph: hi
19:59:19 <k-joseph> wyclif: hi
20:00:10 <k-joseph> dkayiwa, wyclif: am looking at wyclif's comment at https://github.com/openmrs/openmrs-core/pull/375#discussion_r6070805 and i need to hear from you all whether we can make description a requirement or not for validating conceptname tag
20:00:14 <OpenMRSBot> <http://ln-s.net/-s__> (at github.com)
20:01:08 <dkayiwa> k-joseph: what did he say?
20:01:23 <dkayiwa> k-joseph: did he tell you to make it required?
20:02:03 <k-joseph> dkayiwa: wclif's comment reads I think we try not to require description for most metadata
20:02:09 <k-joseph> "I think we try not to require description for most metadata"
20:04:27 <dkayiwa> k-joseph: since he reviewed the ticket, go with what he says
20:05:05 <k-joseph> dkayiwa: ok, am going to remove the code that validates description :(
20:07:29 *** bhashitha has quit IRC
20:25:41 *** k-joseph_ has joined #openmrs
20:25:58 *** k-joseph has quit IRC
20:28:28 *** davidpardz has quit IRC
20:59:09 *** dmulindwa has quit IRC
20:59:18 *** k-joseph_ has quit IRC
20:59:42 *** dmulindwa has joined #openmrs
21:58:11 *** mareias has quit IRC
22:32:34 *** Echidna has quit IRC
22:42:06 *** dkayiwa has quit IRC
23:07:55 *** dkayiwa has joined #openmrs
23:15:38 *** dkayiwa_ has joined #openmrs
23:17:45 *** robbyoconnor has joined #openmrs
23:17:45 *** ChanServ sets mode: +v robbyoconnor
23:18:03 *** dkayiwa has quit IRC
23:18:04 *** dkayiwa_ is now known as dkayiwa
23:20:29 *** davidpardz has joined #openmrs
23:20:37 *** ChanServ sets mode: +v davidpardz