00:00:01
|
*** evmw has quit IRC
|
00:00:32
|
*** davidpardz has joined #openmrs
|
00:00:32
|
*** ChanServ sets mode: +v davidpardz
|
00:27:35
|
*** evmw has joined #openmrs
|
00:27:35
|
*** ChanServ sets mode: +v evmw
|
00:36:35
|
*** evmw has quit IRC
|
00:42:31
|
*** NameFILIP has joined #openmrs
|
00:42:31
|
*** ChanServ sets mode: +v NameFILIP
|
00:47:16
|
*** NameFILIP has quit IRC
|
00:56:35
|
*** evmw has joined #openmrs
|
00:56:35
|
*** ChanServ sets mode: +v evmw
|
01:42:29
|
*** bhashitha has joined #openmrs
|
01:43:03
|
*** NameFILIP has joined #openmrs
|
01:43:03
|
*** ChanServ sets mode: +v NameFILIP
|
01:48:13
|
*** NameFILIP has quit IRC
|
01:57:16
|
*** evmw has quit IRC
|
02:06:49
|
*** achint has quit IRC
|
02:43:32
|
*** NameFILIP has joined #openmrs
|
02:43:32
|
*** ChanServ sets mode: +v NameFILIP
|
02:48:09
|
*** NameFILIP has quit IRC
|
03:38:17
|
*** bhashitha has quit IRC
|
03:42:56
|
*** rday has quit IRC
|
03:43:21
|
*** maninc has joined #openmrs
|
03:44:01
|
*** NameFILIP has joined #openmrs
|
03:44:01
|
*** ChanServ sets mode: +v NameFILIP
|
03:48:28
|
*** NameFILIP has quit IRC
|
03:49:19
|
*** harshadura has joined #openmrs
|
04:13:47
|
*** kavuri has joined #openmrs
|
04:13:57
|
*** kavuri has left #openmrs
|
04:23:37
|
*** rday has joined #openmrs
|
04:27:13
|
*** maurya has joined #openmrs
|
04:27:43
|
*** ChanServ sets mode: +v maurya
|
04:37:03
|
*** Maurya_ has joined #openmrs
|
04:39:01
|
*** maurya has quit IRC
|
04:44:32
|
*** NameFILIP has joined #openmrs
|
04:44:32
|
*** ChanServ sets mode: +v NameFILIP
|
04:45:02
|
*** harshadura has quit IRC
|
04:49:21
|
*** NameFILIP has quit IRC
|
04:57:39
|
*** harshadura has joined #openmrs
|
05:45:01
|
*** NameFILIP has joined #openmrs
|
05:45:01
|
*** ChanServ sets mode: +v NameFILIP
|
05:49:32
|
*** NameFILIP has quit IRC
|
05:55:43
|
*** maninc has quit IRC
|
05:57:08
|
*** pucuk has quit IRC
|
06:08:49
|
*** dkayiwa has joined #openmrs
|
06:12:08
|
*** NameFILIP has joined #openmrs
|
06:12:09
|
*** ChanServ sets mode: +v NameFILIP
|
06:16:21
|
*** maninc has joined #openmrs
|
06:52:15
|
*** rcrichton has joined #openmrs
|
07:02:48
|
*** rcrichton has quit IRC
|
07:03:48
|
*** rcrichton has joined #openmrs
|
07:08:21
|
*** dmulindwa has joined #openmrs
|
08:17:34
|
*** rcrichton has quit IRC
|
08:21:17
|
*** rcrichton has joined #openmrs
|
08:40:50
|
*** dkayiwa_ has joined #openmrs
|
08:41:16
|
*** dkayiwa has quit IRC
|
08:41:16
|
*** dkayiwa_ is now known as dkayiwa
|
08:50:16
|
*** Maurya_ has quit IRC
|
08:54:05
|
*** rday has quit IRC
|
09:00:40
|
*** maurya has joined #openmrs
|
09:16:54
|
*** dkayiwa has quit IRC
|
09:16:55
|
*** dkayiwa_ has joined #openmrs
|
11:08:50
|
*** dkayiwa_ has quit IRC
|
11:25:18
|
*** maurya has quit IRC
|
11:34:56
|
*** maurya has joined #openmrs
|
11:45:32
|
*** mogoodrich has joined #openmrs
|
11:47:12
|
*** mogoodrich has quit IRC
|
11:47:16
|
*** Maurya_ has joined #openmrs
|
11:50:52
|
*** maurya has quit IRC
|
12:06:34
|
*** Maurya_ has quit IRC
|
12:06:57
|
*** Maurya_ has joined #openmrs
|
12:23:50
|
*** Maurya_ has quit IRC
|
12:25:29
|
*** evmw has joined #openmrs
|
12:25:29
|
*** ChanServ sets mode: +v evmw
|
12:31:12
|
*** evmw has quit IRC
|
12:48:36
|
*** Maurya_ has joined #openmrs
|
12:59:59
|
*** mogoodrich has joined #openmrs
|
13:06:22
|
*** evmw has joined #openmrs
|
13:06:22
|
*** ChanServ sets mode: +v evmw
|
13:07:17
|
*** LeeBreisacher has joined #openmrs
|
13:14:42
|
*** evmw has quit IRC
|
13:24:03
|
*** achint has joined #openmrs
|
13:25:28
|
*** davidpardz has left #openmrs
|
13:25:45
|
*** breeze has joined #openmrs
|
13:27:52
|
*** jordank has joined #openmrs
|
13:37:04
|
*** djazayeri has joined #openmrs
|
13:37:04
|
*** ChanServ sets mode: +o djazayeri
|
13:38:42
|
*** dkayiwa has joined #openmrs
|
13:40:08
|
*** pushkar has joined #openmrs
|
13:40:41
|
*** maurya has joined #openmrs
|
13:42:24
|
*** Maurya_ has quit IRC
|
13:51:15
|
<LeeBreisacher> djazayeri, breeze: my question about "latest version" was about whether maven has that feature built in. e.g. can I say something like <version>latest</version> in my pom?
|
13:52:35
|
<LeeBreisacher> djazayeri, breeze: we use Ivy in my day job and it has a notion of "latest-integration" or "latest-stable" (in addition to specific x.y.z versions of course)
|
13:53:22
|
<djazayeri> LeeBreisacher: Unfortunately Maven doesn't have a good way of doing this. There's a maven plugin that will go through your pom and update the version numbers to the latest available
|
13:54:03
|
<LeeBreisacher> djazayeri, breeze: yeah. not the same. I'm surprised. seems like a common thing to want.
|
13:54:04
|
<djazayeri> LeeBreisacher: but (1) it has no understanding of anything like "latest stable", and (2) it can't run in the regular build process, because it actually modifies the pom
|
13:54:32
|
<LeeBreisacher> djazayeri, breeze: right, I understand.
|
13:54:48
|
<djazayeri> breeze, LeeBreisacher: one option could be to have a "latest-that-passed-tests" tag (or something like that) and have our CI set that maven tag on success of every build...
|
13:58:06
|
*** evmw has joined #openmrs
|
13:58:06
|
*** ChanServ sets mode: +v evmw
|
13:59:30
|
<breeze> djazayeri: that sounds good. I'm not familiar with maven tagging functionality though...is it relatively straight forward?
|
14:00:54
|
*** wyclif has joined #openmrs
|
14:01:25
|
<cpower> Hello everyone!
|
14:01:36
|
<cpower> Are we ready to do that thing we do so well?
|
14:02:17
|
<cpower> !scrumon cpower
|
14:02:17
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
14:03:04
|
<cpower> Order: djazayeri , jkeiper , breeze , mogoodrich , wyclif
|
14:03:12
|
<djazayeri> don't make me first
|
14:03:25
|
<cpower> ok I'll add dkayiwa and make him first!
|
14:04:30
|
<cpower> dkayiwa: ....
|
14:04:35
|
<dkayiwa> cpower:
|
14:04:40
|
* cpower realizes it's monday...
|
14:05:14
|
<cpower> dkayiwa: go ahead and give us an update
|
14:05:29
|
<dkayiwa> cpower: ok
|
14:06:06
|
<dkayiwa> Made a followup commit for: Include Relationship Widget in XForms Designer - XFRM-16
|
14:06:06
|
<dkayiwa> Reviewed and merged: Stop ProcessFormEntryQueueTask on shutdown - FORM-138
|
14:06:07
|
<dkayiwa> Reviewed: Make Max Number of Encounters on Dashboard Configurable - TRUNK-2449
|
14:06:07
|
<dkayiwa> Reviewed: Receive data integrity error when trying to delete a form - TRUNK-3956
|
14:06:07
|
<dkayiwa> Reviewed: Improve wording of Program Search in Cohort Builder to be more intuitive - RCM-17
|
14:06:07
|
<dkayiwa> Reviewed: Automated Error Reportjava.lang.NullPointerException - RCM-73
|
14:06:08
|
<dkayiwa> Reviewed and merged: Formentry Proposed Concept in concept.jsp taskpane widget should not allow empty text - FORM-55
|
14:06:08
|
<dkayiwa> Reviewed and merged: "Manage Form Entry Error Queue" and "Form Entry Information" visible to all users under Administration - FORM-65
|
14:06:08
|
<dkayiwa> Reviewed, merged and closed: translate error messages - XFRM-133
|
14:06:09
|
<dkayiwa> Reviewed: Add voidNote() method to NoteDAO - TRUNK-3258
|
14:06:09
|
<dkayiwa> No Blockers
|
14:06:37
|
<cpower> jkeiper: you around?
|
14:06:51
|
*** evmw has quit IRC
|
14:07:26
|
<jkeiper> hi guyszzzzzzzZZZ
|
14:07:30
|
<jkeiper> today: get back into it
|
14:07:32
|
<jkeiper> the end
|
14:07:36
|
<cpower> lol
|
14:07:40
|
<cpower> fair enough
|
14:07:48
|
<breeze> Yesterday
|
14:07:48
|
<breeze> - Bamboo UI Framework tweaks
|
14:07:48
|
<breeze> - TW Code Jam
|
14:07:48
|
<breeze> Today
|
14:07:48
|
<breeze> - Update pom.xml for reference application for new versions of reporting and uiframework modules
|
14:07:49
|
<breeze> - RA-142
|
14:07:51
|
<breeze> No Blockers
|
14:08:11
|
<cpower> mogoodrich: Any blockers or questions coming up?
|
14:08:23
|
<djazayeri> he's on a call now. I'll sneak in
|
14:08:26
|
<djazayeri> Recently
|
14:08:26
|
<djazayeri> * Working on capturing encounter diagnoses from an HTML form (I'm close!)
|
14:08:26
|
<djazayeri> * Reviewing LeeBreisacher's pull requests about adding dom ids to ref app modules (need to do more)
|
14:08:26
|
<djazayeri> * Worked on RefApp application roles, so I can test Rafal's first dispensing story (still haven't made it work)
|
14:08:27
|
<djazayeri> No blockers
|
14:08:39
|
<cpower> aaaaaand wyclif!
|
14:08:48
|
<wyclif> Monday:
|
14:08:49
|
<wyclif> -Emails
|
14:08:49
|
<wyclif> -pick up a sprint ticket
|
14:08:50
|
<wyclif> Blockers: None
|
14:09:03
|
<cpower> Awesome
|
14:09:13
|
<djazayeri> mogoodrich said: nothing off the top of his head
|
14:09:37
|
<cpower> Who's going to be community Dev Starting Thursday? (looking at Wyclif or the missing Rafal)
|
14:09:54
|
<wyclif> it is rafa
|
14:10:11
|
<cpower> wyclif: ok just so we know
|
14:12:03
|
<cpower> Myself: Working on getting Design and PM call Agenda's out today. Taking a deeper dive into how to get rid of old tickets, or at least get our tickets prioritized.
|
14:12:20
|
<cpower> !scrumoff
|
14:12:20
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:13:13
|
<breeze> cpower: did you have any specific topics for the CD part of the design call you wanted me to touch on?
|
14:15:47
|
<cpower> breeze: Maybe you should ask the Dev list this question, might be a good launching off point
|
14:15:59
|
<breeze> cpower: ok
|
14:16:32
|
*** breeze has quit IRC
|
14:23:01
|
*** evmw has joined #openmrs
|
14:23:01
|
*** ChanServ sets mode: +v evmw
|
14:32:35
|
*** breeze has joined #openmrs
|
14:39:59
|
<wyclif> achint: which ticket is of higher priority among those in waiting for dev?
|
14:40:24
|
<achint> wyclif: they are in order in dev queue
|
14:41:30
|
<wyclif> achint: what do you by they are in order?
|
14:41:46
|
<wyclif> achint: sorry! what what order do you mean?
|
14:42:10
|
<achint> wyclif: I mean you can pick from the top of the queue
|
14:42:24
|
<achint> wyclif: waiting for dev queue
|
14:42:35
|
<achint> djazayeri: are you thinking of including the address autocomplete in a different story? RA-159?
|
14:42:41
|
<wyclif> achint: that means they are not in any order,
|
14:44:04
|
<achint> wyclif: what do you mean?
|
14:46:00
|
*** Mkop has joined #openmrs
|
14:51:39
|
<breeze> downey: hi
|
14:53:49
|
*** harsz89 has joined #openmrs
|
14:53:49
|
*** ChanServ sets mode: +v harsz89
|
14:55:17
|
*** jordank has left #openmrs
|
14:55:37
|
*** harshadura has joined #openmrs
|
14:55:37
|
*** ChanServ sets mode: +v harshadura
|
15:05:15
|
*** rcrichton has quit IRC
|
15:07:29
|
*** dkayiwa has quit IRC
|
15:08:58
|
*** harshadura has quit IRC
|
15:09:43
|
*** harshadura has joined #openmrs
|
15:12:23
|
*** dkayiwa has joined #openmrs
|
15:13:50
|
<breeze> LeeBreisacher: djazayeri you there?
|
15:15:11
|
<LeeBreisacher> breeze: I am here
|
15:15:45
|
<breeze> LeeBreisacher: so...I don't want to bother you too much with this, just need to bounce something off someone..
|
15:15:57
|
<LeeBreisacher> breeze: np
|
15:16:25
|
<breeze> LeeBreisacher: about the issue with updated versions of dependent modules....this maven command is a nice easy way to see that mvn versions:display-dependency-updates -DallowSnapshots=true
|
15:17:05
|
<breeze> LeeBreisacher: I'm thinking about having a Bamboo plan that will run that to display the info, so people are aware that the poms may need to updated
|
15:17:11
|
<jkeiper> mseaton: does reporting module track how long it takes to run each column in a dataset, perhaps store it in some metadata? if not, would you be opposed to that happening?
|
15:17:55
|
<breeze> LeeBreisacher: but at the moment I can't think of a way to make it more noticeable, ie just another in a long list of bamboo plans that one may or may not be interested in
|
15:18:24
|
<LeeBreisacher> breeze: can we make the plan fail if something needs to be updated?
|
15:18:37
|
<LeeBreisacher> breeze: I guess that doesn't really work.
|
15:18:50
|
<breeze> LeeBreisacher: yeah, that's what I was wondering....
|
15:19:17
|
<breeze> LeeBreisacher: yeah, it's more like a "hey, here's something to look at" kind of message
|
15:19:41
|
<LeeBreisacher> breeze: and then the human decides to update or not
|
15:19:47
|
<breeze> LeeBreisacher: look at and ponder whether you want to update or not
|
15:19:50
|
<breeze> LeeBreisacher: yeah
|
15:20:12
|
<LeeBreisacher> breeze: and if not, then the plan should not fail again. sounds like you need something clever.
|
15:20:36
|
<breeze> LeeBreisacher: yeah...which I'm not coming up with yet
|
15:20:47
|
<LeeBreisacher> breeze: what's puzzling to me is that this is surely a common problem. surely someone else has solved it.
|
15:21:08
|
<breeze> LeeBreisacher: I did a brieg bit of googling, but I'll do some more
|
15:24:00
|
<LeeBreisacher> breeze: is this helpful: http://stackoverflow.com/questions/10209686/maven-dynamic-specification-of-dependencies
|
15:24:04
|
<OpenMRSBot> <http://ln-s.net/-b9R> (at stackoverflow.com)
|
15:26:26
|
<breeze> LeeBreisacher: hmm...not quite....it looks like that is something that is in place already....Bamboo will look for and use the latest. I didn't see anything about human intervention on that post
|
15:26:29
|
<djazayeri> achint: I was thinking that we don't need autocomplete for address fields besides what is already in the address hierarchy module. i.e. the address hierarchy module already solves this general problem, so we don't need another solution.
|
15:27:23
|
<breeze> LeeBreisacher: which I guess maybe leads to another question
|
15:27:58
|
<breeze> LeeBreisacher: if bamboo is updating itself, why not let it update the pom accordingly, given it succeeds?
|
15:28:16
|
<breeze> LeeBreisacher: I mean rather, push the update to github
|
15:29:19
|
<LeeBreisacher> breeze: I guess I don't understand what the real problem is. It seems like we have two kinds of dependencies. "fixed" ones (specific version), and "latest snapshot". Is there more to it than that?
|
15:33:08
|
<breeze> LeeBreisacher: well, I guess I'm coming at it from a different angle
|
15:33:46
|
*** dmulindwa has quit IRC
|
15:34:19
|
<breeze> LeeBreisacher: I "simply" would like to alert people that there are new versions available that are not currently in use, then do some analysis whether or not to push the updated versions out to everyone
|
15:34:29
|
*** bhashitha has joined #openmrs
|
15:36:59
|
<breeze> LeeBreisacher: so it's a matter or bubbling information up for someone to act on, or not
|
15:37:00
|
<LeeBreisacher> breeze: ok, I think I get it. so, "if bamboo is updating itself, why not let it update the pom accordingly, given it succeeds?"
|
15:37:14
|
<breeze> LeeBreisacher: yes, or that
|
15:37:28
|
<LeeBreisacher> breeze: what if you create a pull request for the change?
|
15:37:51
|
<breeze> LeeBreisacher: eureka....I think that's it
|
15:37:55
|
<LeeBreisacher> breeze: then that pull request would sortof "get in someone's face" to be dealt with?
|
15:38:26
|
*** sashrika has joined #openmrs
|
15:38:40
|
<breeze> LeeBreisacher: I like it. Thanks!
|
15:38:49
|
<LeeBreisacher> breeze: cool. yw.
|
15:39:01
|
*** ChanServ sets mode: +v sashrika
|
15:39:44
|
<h3llborn> cpower: any idea where rafal is?
|
15:43:22
|
<wyclif> achint: it is the dispensing tickets we are working on right?
|
15:46:36
|
<achint> djazayeri: ah, gotcha.. I thought you were thinking there's another card for it and there weren't any so I wanted to make sure. I'll test and move this card then.
|
15:47:14
|
<wyclif> achint: ?
|
15:47:59
|
<achint> wyclif: no, dispensing has been de-priortized unless the dispensing ticket has a dependency for Patient Summary tickets
|
15:48:37
|
<achint> wyclif: So there's still at least 1 dispensing ticket in our queue but it's not at the top
|
15:48:40
|
<wyclif> achint: what is the link to the jura dashboard for the current iteration
|
15:48:45
|
*** maninc has quit IRC
|
15:48:58
|
<achint> wyclif: https://tickets.openmrs.org/secure/RapidBoard.jspa?rapidView=33
|
15:50:32
|
<wyclif> achint: djazayeri for RA-148, are the visits already shown on the patient dashboard?
|
15:55:19
|
<djazayeri> wyclif: visits are shown on the current patient dashboard. RA-148 is about creating a new clinician-facing patient summary
|
15:56:32
|
<wyclif> djazayeri: thanks! the summary and description don't suggest that though, they need to be edited
|
15:58:03
|
<suranga__> ruwanego___: hi
|
15:58:21
|
*** maurya has quit IRC
|
15:58:28
|
<djazayeri> achint: wyclif makes a good point that JIRA doesn't actually show you any useful summary of the Epic that a story is part of. (It's just a link.)
|
15:59:07
|
<djazayeri> achint: so we should probably include a one-line section in our story template answering "what general feature is this about, and where does the code go"
|
15:59:26
|
*** harshadura has joined #openmrs
|
16:03:34
|
<achint> djazayeri: It may be specific to this epic since we have the 2 different dashboards (old and new). Otherwise, JIRA shows the Epic link on top. We could add more details to the epic if that's helpful. I like you idea of where the code should go, that also should be part of 'tech / dev notes' on the epic itself.. ?
|
16:04:22
|
<djazayeri> achint: can we rename the "Patient Dashboard" epic to "Clinician-facing Patient Summary"?
|
16:04:43
|
<achint> djazayeri: Yes, doing it now
|
16:05:14
|
*** cospih has joined #openmrs
|
16:12:42
|
*** NameFILIP has quit IRC
|
16:13:26
|
*** NameFILIP has joined #openmrs
|
16:13:26
|
*** ChanServ sets mode: +v NameFILIP
|
16:15:08
|
<djazayeri> wyclif: are you actually working on RA-150?
|
16:15:35
|
<djazayeri> wyclif, achint: that's "include medication on the patient dashboard"⦠is that really ready-for-work?
|
16:17:43
|
<achint> djazayeri: As I mentioned we should be picking off the top of the queue. 150 might be missing a few details. wyclif, can you work on 163 or 162 ?
|
16:24:19
|
*** NameFILIP has quit IRC
|
16:28:31
|
*** maurya has joined #openmrs
|
16:30:36
|
<suranga__> hi jkeiper , are you around, by any chance ?
|
16:31:13
|
<jkeiper> heyya suranga__
|
16:31:13
|
<jkeiper> :-)
|
16:32:25
|
<suranga__> jkeiper: good to have you guys back from OSCON :)
|
16:32:39
|
<jkeiper> suranga__: yes, trying to catch back up
|
16:32:45
|
<jkeiper> time gets ahead of us!
|
16:33:04
|
<suranga__> jkeiper: deadline in 2 days, and i'm wrapping up the document....
|
16:33:23
|
<suranga__> jkeiper: based on the effort taken to complete it, they'd better give us something :P
|
16:34:58
|
*** jordank has joined #openmrs
|
16:36:03
|
<suranga__> jkeiper: however, I *may* have gone a bit overboard designing wireframes. there's quite a number
|
16:36:43
|
<jkeiper> suranga__: haha, i will review what you have sent ... and i have full trust in your abilities!
|
16:37:33
|
<suranga__> jkeiper: i will probably try to send you an updated version by EOD today :)
|
16:37:46
|
<jkeiper> suranga__: cool
|
16:37:49
|
*** mogoodrich has quit IRC
|
16:41:44
|
*** mogoodrich has joined #openmrs
|
16:48:15
|
*** pushkar has quit IRC
|
17:07:00
|
*** wyclif has quit IRC
|
17:09:29
|
*** wyclif has joined #openmrs
|
17:24:42
|
*** NameFILIP has joined #openmrs
|
17:24:42
|
*** ChanServ sets mode: +v NameFILIP
|
17:28:15
|
*** NameFILI_ has joined #openmrs
|
17:29:09
|
*** NameFILIP has quit IRC
|
17:31:06
|
*** breeze has quit IRC
|
17:32:21
|
*** Seganfredo63 has joined #openmrs
|
17:55:28
|
*** lnball has quit IRC
|
17:58:28
|
*** GitHub72 has joined #openmrs
|
17:58:28
|
<GitHub72> [openmrs-core] dkayiwa closed pull request #338: TRUNK-3267 Delete any related objects here before deleting the obs (master...9a6514f3d325245d46cde6b0230b36cd2fc24d83) http://git.io/gRXyaA
|
17:58:28
|
*** GitHub72 has left #openmrs
|
18:00:54
|
*** Mkop has quit IRC
|
18:01:13
|
*** Mkop has joined #openmrs
|
18:17:40
|
*** maurya has quit IRC
|
18:18:02
|
*** maurya has joined #openmrs
|
18:21:34
|
<sashrika> dkayiwa: Hi..
|
18:21:35
|
<LeeBreisacher> djazayeri: Hi Darius. Just a gentle reminder that this pull request is also part of the "add id attributes" work: https://github.com/openmrs/openmrs-module-registrationapp/pull/2
|
18:21:39
|
<OpenMRSBot> <http://ln-s.net/-bAC> (at github.com)
|
18:22:05
|
<dkayiwa> sashrika: hi
|
18:22:36
|
<sashrika> dkayiwa: Hi Daniel...I want you to get some work done :)
|
18:22:45
|
<dkayiwa> sashrika: loll :)
|
18:23:13
|
<sashrika> can you make this ready fro work?
|
18:23:14
|
<sashrika> https://tickets.openmrs.org/browse/REPORT-524
|
18:23:40
|
<dkayiwa> sashrika: done
|
18:23:49
|
<sashrika> dkayiwa: not only that :)
|
18:23:57
|
<sashrika> dkayiwa: 524-530
|
18:23:58
|
<dkayiwa> sashrika: but also.... :)
|
18:24:36
|
<sashrika> dkayiwa: not only that, but also 10 tickets :)
|
18:25:44
|
<sashrika> dkayiwa: 7
|
18:26:52
|
<dkayiwa> sashrika: did i leave out any? :)
|
18:26:56
|
<sashrika> dkayiwa: All done.. thank u
|
18:27:08
|
<sashrika> dkayiwa: No.. perfect..
|
18:27:22
|
<dkayiwa> sashrika: .. = t
|
18:27:26
|
<dkayiwa> :)
|
18:28:31
|
<sashrika> dkayiwa: Daniel.. can u give me a help for writing tests for the REST module?
|
18:28:58
|
<dkayiwa> sashrika: we can pair up tomorrow :)
|
18:29:52
|
<sashrika> dkayiwa:Oh.. thats good...! At which time usually come online?
|
18:30:08
|
<sashrika> dkayiwa: I think usually 9 hrs before...
|
18:30:22
|
<dkayiwa> sashrika: around that :)
|
18:31:23
|
<sashrika> dkayiwa: Ok.. then i'll try to contact u tmrw...
|
18:31:48
|
<dkayiwa> sashrika: sure
|
18:31:52
|
<sashrika> dkayiwa: have a nice day....
|
18:32:04
|
<dkayiwa> sashrika: have a good night too :)
|
18:32:37
|
<sashrika> dkayiwa: U too.. but u may stay 2,3 hrs more noh?
|
18:32:48
|
<dkayiwa> sashrika: oh yes :)
|
18:32:57
|
<sashrika> dkayiwa: :) see
|
18:33:31
|
<djazayeri> LeeBreisacher: I notice that in that pull request you only added id to Question, and not Section. Was it already in section?
|
18:34:12
|
<LeeBreisacher> djazayeri: looking...
|
18:35:33
|
<djazayeri> LeeBreisacher: looking a line up, I see that it must have been there already.
|
18:35:37
|
<djazayeri> LeeBreisacher: okay, I'll merge it.
|
18:36:16
|
<LeeBreisacher> djazayeri: yeah, I don't remember now. I'd have to look closer. This stuff is twisty. Thanks.
|
18:37:24
|
*** rday has joined #openmrs
|
18:41:14
|
*** harshadura has quit IRC
|
18:46:39
|
<LeeBreisacher> djazayeri: oops, there's one more: https://github.com/openmrs/openmrs-module-referenceapplication/pull/4
|
18:46:44
|
<OpenMRSBot> <http://ln-s.net/-bAo> (at github.com)
|
18:47:04
|
<LeeBreisacher> djazayeri: quite trivial
|
18:47:14
|
<djazayeri> LeeBreisacher: I remembered there being one more, but figured you could self-approve that one, since it's not "frameworky"
|
18:47:24
|
<djazayeri> LeeBreisacher: I can press the button now if you want though
|
18:47:35
|
<LeeBreisacher> djazayeri: ok. sure. thanks.
|
18:47:41
|
*** evmw has quit IRC
|
18:48:12
|
<LeeBreisacher> djazayeri: and I'll go ahead do them myself for these simple non-framework ones in the future.
|
18:48:30
|
<djazayeri> LeeBreisacher: done. In general if all that a pull request does is add id attributes to things, feel free to commit directly, or merge yourself
|
18:48:34
|
<djazayeri> LeeBreisacher: exactly
|
18:48:40
|
<djazayeri> LeeBreisacher: keep up the strong work though!
|
18:49:36
|
*** evmw has joined #openmrs
|
18:49:36
|
*** ChanServ sets mode: +v evmw
|
18:52:03
|
*** Mkop has quit IRC
|
18:54:12
|
*** Mkop has joined #openmrs
|
19:00:24
|
*** mogoodrich has quit IRC
|
19:00:50
|
*** mogoodrich has joined #openmrs
|
19:00:52
|
*** Seganfredo63 has quit IRC
|
19:18:35
|
<wyclif> hi djazayeri
|
19:18:50
|
<djazayeri> wyclif: hi
|
19:19:00
|
<wyclif> djazayeri: am working on https://tickets.openmrs.org/browse/RA-150
|
19:20:01
|
<djazayeri> wyclif: per the conversation earlier on irc, you should not work on this ticket yet
|
19:20:33
|
<wyclif> djazayeri: are you aware of the css classes to use so that the page is rendered the way it is in the mock up
|
19:20:34
|
<djazayeri> wyclif: you should pick one from the top of the list of ready-for-dev tickets
|
19:21:27
|
*** mogoodrich_ has joined #openmrs
|
19:21:28
|
*** mogoodrich has quit IRC
|
19:21:52
|
<djazayeri> wyclif: I'm assuming that the comment under assumptions points to a page that includes the css that glauber initially put together
|
19:21:55
|
<djazayeri> wyclif: I haven't looked yet.
|
19:22:04
|
<djazayeri> wyclif: but do one of those other tickets first, e.g. the session location one
|
19:25:03
|
<wyclif> djazayeri: i added a ticket to the session location one
|
19:25:18
|
<wyclif> djazayeri: sorry meant to say i added a comment
|
19:28:09
|
*** bhashitha has quit IRC
|
19:28:09
|
<wyclif> djazayeri: ?
|
19:30:49
|
*** Maurya_ has joined #openmrs
|
19:32:21
|
<djazayeri> wyclif: I commented back. I don't know why I didn't get an email for yours
|
19:32:42
|
*** maurya has quit IRC
|
19:33:08
|
*** jkeiper has quit IRC
|
19:33:09
|
*** jkeiper has joined #openmrs
|
19:33:09
|
*** jkeiper has joined #openmrs
|
19:33:10
|
*** ChanServ sets mode: +v jkeiper
|
19:33:12
|
<wyclif> djazayeri: ok thanks
|
19:33:53
|
*** rday has quit IRC
|
19:36:40
|
*** rday has joined #openmrs
|
19:48:57
|
*** sashrika has quit IRC
|
19:50:17
|
*** rcrichton has joined #openmrs
|
19:54:54
|
*** rday has quit IRC
|
20:02:40
|
*** mogoodrich_ has quit IRC
|
20:04:56
|
*** mogoodrich_ has joined #openmrs
|
20:05:38
|
<djazayeri> downey: what's the best way for me to request changes to the RefApp ticket workflow
|
20:06:45
|
<djazayeri> downey: e.g. I think we generally want to be able to move tickets backwards also, e.g RA-150 is currently "Waiting for Development" but I want to put it back to "Waiting for Analysis"
|
20:12:55
|
*** Maurya_ has quit IRC
|
20:19:16
|
<downey> djazayeri: yeah we can look into that. http://go.openmrs.org/helpdesk
|
20:23:57
|
*** rcrichton has quit IRC
|
20:37:30
|
*** dkayiwa has quit IRC
|
20:43:44
|
*** mogoodrich_ has quit IRC
|
20:47:35
|
*** mogoodrich_ has joined #openmrs
|
20:49:13
|
*** NameFILI_ has quit IRC
|
21:02:31
|
<wyclif> ji dh
|
21:02:34
|
<wyclif> hi djazayeri
|
21:02:47
|
<djazayeri> hi wyclif (just finishing a call)
|
21:02:51
|
<wyclif> djazayeri: is there an EmrApiService
|
21:02:55
|
<wyclif> djazayeri: ok
|
21:03:21
|
<djazayeri> wyclif: no, I don't think so â we want to have specific services for specific functional areas, not a generic EmrApi service
|
21:03:29
|
<djazayeri> wyclif: what feature do you want to add in.
|
21:03:57
|
<wyclif> djazayeri: i guess i will do it from the controller, fetching lgin locations
|
21:04:03
|
<wyclif> djazayeri: login
|
21:04:27
|
*** Christiam has joined #openmrs
|
21:04:57
|
<Christiam> hi friends of OpenMRS
|
21:06:18
|
<djazayeri> wyclif: I think that might exist already
|
21:06:30
|
<djazayeri> wyclif: have you looked at Mirebalais's LoginPageController?
|
21:06:30
|
<Christiam> my name is Christiam and write from Spain
|
21:07:19
|
*** NameFILIP has joined #openmrs
|
21:07:20
|
*** ChanServ sets mode: +v NameFILIP
|
21:09:20
|
<djazayeri> wyclif: actually, there's a method in EmrService, which should probably be moved to EmrApiService
|
21:09:33
|
<djazayeri> wyclif: actually, I already moved it
|
21:09:38
|
<djazayeri> wyclif: see AppFrameworkService
|
21:09:52
|
<djazayeri> wyclif: it has getLoginLocations()
|
21:17:06
|
*** rday has joined #openmrs
|
21:19:36
|
<wyclif> djazayeri: ok thanks
|
21:24:02
|
*** jordank has quit IRC
|
21:31:46
|
*** NameFILIP has quit IRC
|
21:46:07
|
*** rday has quit IRC
|
22:11:22
|
*** wyclif has quit IRC
|
22:24:21
|
*** mogoodrich_ has quit IRC
|
22:24:51
|
*** mogoodrich_ has joined #openmrs
|
22:27:20
|
*** rday has joined #openmrs
|
22:31:26
|
*** mogoodrich_ has quit IRC
|
22:32:30
|
*** NameFILIP has joined #openmrs
|
22:32:34
|
*** ChanServ sets mode: +v NameFILIP
|
22:37:31
|
*** NameFILIP has quit IRC
|
22:38:56
|
*** Christiam has quit IRC
|
22:59:43
|
*** wyclif has joined #openmrs
|
23:32:19
|
*** rday has quit IRC
|
23:33:00
|
*** NameFILIP has joined #openmrs
|
23:33:00
|
*** ChanServ sets mode: +v NameFILIP
|
23:33:25
|
*** LeeBreisacher1 has joined #openmrs
|
23:36:28
|
*** LeeBreisacher has quit IRC
|
23:37:57
|
*** NameFILIP has quit IRC
|
23:47:30
|
*** rday has joined #openmrs
|