| 00:04:03 | *** fouad has joined #openmrs |
| 00:07:39 | *** fouad has quit IRC |
| 00:07:39 | *** fouad has joined #openmrs |
| 00:08:24 | *** NameFILIP has joined #openmrs |
| 00:08:25 | *** ChanServ sets mode: +v NameFILIP |
| 00:12:38 | *** NameFILIP has quit IRC |
| 00:19:55 | <fouad> what do you guys think about having a DICOM module ? |
| 00:20:52 | <fouad> or maybe it's not in the scope of OpenMRS |
| 00:27:31 | *** akwatuha__ has joined #openmrs |
| 00:43:58 | *** cospih has quit IRC |
| 01:05:02 | *** shruthd has joined #openmrs |
| 01:08:57 | *** NameFILIP has joined #openmrs |
| 01:08:57 | *** ChanServ sets mode: +v NameFILIP |
| 01:13:29 | *** NameFILIP has quit IRC |
| 01:17:01 | *** Mkop has quit IRC |
| 01:17:20 | *** Mkop has joined #openmrs |
| 01:27:58 | <djazayeri> rafa: I don't suppose you're there now? |
| 01:28:22 | <djazayeri> alternately, does anybody know how I can set the hibernate flush mode in a unit test? |
| 01:50:07 | *** bhashitha has joined #openmrs |
| 01:55:37 | *** djazayeri1 has joined #openmrs |
| 01:58:31 | *** djazayeri has quit IRC |
| 02:04:24 | *** harshadura has quit IRC |
| 02:05:56 | *** harsz89 has quit IRC |
| 02:09:23 | *** NameFILIP has joined #openmrs |
| 02:09:23 | *** ChanServ sets mode: +v NameFILIP |
| 02:14:07 | *** NameFILIP has quit IRC |
| 02:16:22 | *** rday has joined #openmrs |
| 02:18:08 | *** harsz89 has joined #openmrs |
| 02:18:08 | *** ChanServ sets mode: +v harsz89 |
| 02:18:19 | *** harshadura has joined #openmrs |
| 02:41:35 | *** shruthd has quit IRC |
| 02:54:18 | *** djazayeri1 has quit IRC |
| 03:09:53 | *** NameFILIP has joined #openmrs |
| 03:09:53 | *** ChanServ sets mode: +v NameFILIP |
| 03:14:13 | *** NameFILIP has quit IRC |
| 03:14:24 | *** harsz89 has quit IRC |
| 03:21:29 | *** bhashitha has quit IRC |
| 03:35:28 | *** djazayeri has joined #openmrs |
| 03:35:28 | *** ChanServ sets mode: +o djazayeri |
| 03:47:33 | *** fouad has quit IRC |
| 04:03:17 | *** shruthd has joined #openmrs |
| 04:10:24 | *** NameFILIP has joined #openmrs |
| 04:10:25 | *** ChanServ sets mode: +v NameFILIP |
| 04:14:24 | *** fouad has joined #openmrs |
| 04:15:09 | *** NameFILIP has quit IRC |
| 04:57:45 | *** maninc has joined #openmrs |
| 05:10:53 | *** NameFILIP has joined #openmrs |
| 05:10:53 | *** ChanServ sets mode: +v NameFILIP |
| 05:42:30 | *** NameFILIP has quit IRC |
| 05:48:10 | *** harshadura has quit IRC |
| 05:49:27 | *** LeeBreisacher1 has left #openmrs |
| 05:56:49 | *** shruthd has joined #openmrs |
| 06:22:18 | *** rday has quit IRC |
| 06:23:20 | *** maninc has quit IRC |
| 06:25:07 | *** rcrichton has joined #openmrs |
| 06:36:26 | *** maninc has joined #openmrs |
| 06:47:56 | *** fouad has quit IRC |
| 06:53:03 | *** dmulindwa has joined #openmrs |
| 07:00:30 | <ojwanganto> hi |
| 07:00:37 | <ojwanganto> is anyone here? |
| 07:01:24 | <ojwanganto> i want to use a custom tld file in a module but i am still not sure where it should be placed |
| 07:02:12 | <ojwanganto> normally it should be placed in WEB-INF but i think that is not the case with modules. |
| 07:02:23 | <ojwanganto> Any help will be appreciated |
| 07:03:21 | *** shruthd has quit IRC |
| 07:03:57 | *** dmulindwa has quit IRC |
| 07:04:16 | *** dmulindwa has joined #openmrs |
| 07:05:53 | *** shruthd has joined #openmrs |
| 07:13:24 | *** NameFILIP has joined #openmrs |
| 07:13:24 | *** ChanServ sets mode: +v NameFILIP |
| 07:18:06 | *** NameFILIP has quit IRC |
| 07:18:25 | *** harshadura has joined #openmrs |
| 07:28:28 | *** shruthd has quit IRC |
| 07:53:17 | *** shruthd has joined #openmrs |
| 07:55:04 | *** NameFILIP has joined #openmrs |
| 07:55:04 | *** ChanServ sets mode: +v NameFILIP |
| 07:57:08 | *** harshadura has quit IRC |
| 08:03:00 | *** b0b has quit IRC |
| 08:04:50 | *** shruthd has quit IRC |
| 08:05:21 | *** b0b has joined #openmrs |
| 08:06:43 | *** harshadura has joined #openmrs |
| 08:09:28 | *** dkayiwa has joined #openmrs |
| 08:16:55 | *** harshadura_ has joined #openmrs |
| 08:50:00 | *** shruthd has joined #openmrs |
| 09:00:10 | *** GitHub0 has joined #openmrs |
| 09:00:11 | <GitHub0> [openmrs-core] dkayiwa pushed 2 new commits to master: http://git.io/l0ztqA |
| 09:00:11 | <GitHub0> openmrs-core/master c7559a9 k-joseph: [TRUNK-4017] changed one <display-name /> tag to <description /> |
| 09:00:11 | <GitHub0> openmrs-core/master 07bc040 dkayiwa: Merge pull request #367 from k-joseph/TRUNK-4017... |
| 09:00:11 | *** GitHub0 has left #openmrs |
| 09:00:13 | *** GitHub110 has joined #openmrs |
| 09:00:13 | <GitHub110> [openmrs-core] dkayiwa closed pull request #367: fix for TRUNK-4017 (master...TRUNK-4017) http://git.io/HF5QnA |
| 09:00:13 | *** GitHub110 has left #openmrs |
| 09:03:24 | *** davidpardz has joined #openmrs |
| 09:03:24 | *** ChanServ sets mode: +v davidpardz |
| 09:05:56 | *** shruthd has quit IRC |
| 09:14:03 | *** travis-ci has joined #openmrs |
| 09:14:03 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [07bc040] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/9508462 |
| 09:14:03 | *** travis-ci has left #openmrs |
| 09:14:07 | <OpenMRSBot> <http://ln-s.net/-_eg> (at travis-ci.org) |
| 09:16:13 | *** shruthd has joined #openmrs |
| 09:16:54 | *** harshadura has quit IRC |
| 09:16:56 | *** harshadura_ has quit IRC |
| 09:18:00 | *** djazayeri has quit IRC |
| 09:25:41 | *** maninc has quit IRC |
| 09:28:22 | *** harshadura has joined #openmrs |
| 09:39:51 | *** harshadura has quit IRC |
| 09:50:45 | *** dkayiwa has quit IRC |
| 09:53:07 | *** harshadura has joined #openmrs |
| 10:17:39 | *** GitHub80 has joined #openmrs |
| 10:17:39 | <GitHub80> [openmrs-core] isha-tripathi synchronize pull request #356: modified Provider.toString() to return provider id with name (master...TRUNK-3736) http://git.io/ZwlRPQ |
| 10:17:39 | *** GitHub80 has left #openmrs |
| 10:44:50 | *** shruthd has quit IRC |
| 10:47:09 | *** shruthd has joined #openmrs |
| 11:08:01 | <harshadura> hi dkayiwa |
| 11:16:46 | *** shruthd has quit IRC |
| 11:35:14 | *** dkayiwa has joined #openmrs |
| 11:39:16 | *** shruthd has joined #openmrs |
| 11:39:20 | *** isaac has joined #openmrs |
| 11:42:20 | *** k-joseph has joined #openmrs |
| 11:43:43 | *** isaac has quit IRC |
| 11:49:54 | *** maninc has joined #openmrs |
| 11:53:21 | <davidpardz> mseaton: hi |
| 11:54:46 | *** cospih has joined #openmrs |
| 12:12:21 | *** NameFILIP has quit IRC |
| 12:30:51 | <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-772 has FAILED (1 tests failed) : Dependant of UICM-UICOMMONS-185 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-772> |
| 12:34:33 | *** shruthd has quit IRC |
| 12:38:38 | <k-joseph> dkayiwa: hi |
| 12:38:45 | <dkayiwa> k-joseph: hi |
| 12:38:59 | <dkayiwa> k-joseph: the unit tests are failing for the Note ticket |
| 12:40:18 | <k-joseph> dkayiwa: thanks for responding on my commit at https://github.com/k-joseph/openmrs-core/commit/206b5cffb9e2dcbcbe69b423fa71741812a77298#commitcomment-3724938, am checking that out, for i had tested before, but had not at last when i made the commit, i have also seen your comment at that url and responded, am waiting again for your response, thanks |
| 12:40:22 | <OpenMRSBot> <http://ln-s.net/-_k2> (at github.com) |
| 12:41:09 | <dkayiwa> k-joseph: can you fix the note ticket first? |
| 12:41:16 | <dkayiwa> k-joseph: it is long over due |
| 12:41:33 | <k-joseph> dkayiwa: yes it is the one am on, and that is the commit |
| 12:41:41 | <dkayiwa> k-joseph: ok |
| 12:47:01 | <k-joseph> dkayiwa: waiting upon you response at that commit, i guess that is the reason for test class failing!! |
| 12:47:07 | *** dkayiwa has quit IRC |
| 13:00:30 | *** dkayiwa has joined #openmrs |
| 13:03:28 | *** harsz89 has joined #openmrs |
| 13:03:28 | *** ChanServ sets mode: +v harsz89 |
| 13:10:18 | <k-joseph> dkayiwa: hi |
| 13:10:25 | <dkayiwa> k-joseph: hi |
| 13:11:35 | <k-joseph> dkayiwa: kayiwa: waiting upon you response at that commit as am working upon the error |
| 13:11:49 | <dkayiwa> k-joseph: which one? |
| 13:12:07 | <k-joseph> dkayiwa: at https://github.com/k-joseph/openmrs-core/commit/206b5cffb9e2dcbcbe69b423fa71741812a77298#commitcomment-3724938 |
| 13:12:11 | <OpenMRSBot> <http://ln-s.net/-_l8> (at github.com) |
| 13:12:19 | <dkayiwa> k-joseph: about the duplicate? |
| 13:12:44 | *** NameFILIP has joined #openmrs |
| 13:12:44 | *** ChanServ sets mode: +v NameFILIP |
| 13:12:55 | <k-joseph> dkayiwa: yes, reset my local branch and deleted it, i plan to remove the line |
| 13:13:10 | <dkayiwa> k-joseph: i responded already |
| 13:13:11 | <k-joseph> 17 + <property name="noteId" type="java.lang.Integer" length="11" |
| 13:13:28 | <k-joseph> dkayiwa: ok, checking |
| 13:17:24 | *** GitHub26 has joined #openmrs |
| 13:17:24 | <GitHub26> [openmrs-core] dkayiwa closed pull request #354: TRUNK-3983: API support for purgeConceptNameTag method (master...TRUNK-3983) http://git.io/xXHJAg |
| 13:17:24 | *** GitHub26 has left #openmrs |
| 13:17:25 | *** GitHub105 has joined #openmrs |
| 13:17:25 | <GitHub105> [openmrs-core] dkayiwa pushed 3 new commits to master: http://git.io/OaOGiw |
| 13:17:25 | <GitHub105> openmrs-core/master 06309fa Robert Day: TRUNK-3983: Added purgeConceptNameTag method... |
| 13:17:25 | <GitHub105> openmrs-core/master 32ad9b4 Robert Day: TRUNK:3983: Corrected errors |
| 13:17:25 | <GitHub105> openmrs-core/master a567f6d dkayiwa: Merge pull request #354 from Fahv/TRUNK-3983... |
| 13:17:25 | *** GitHub105 has left #openmrs |
| 13:17:33 | *** NameFILIP has quit IRC |
| 13:20:15 | <harshadura> hi dkayiwa |
| 13:20:21 | <dkayiwa> harshadura: hi |
| 13:21:48 | <ojwanganto> hi dkayiwa |
| 13:21:56 | <dkayiwa> ojwanganto: hi |
| 13:22:12 | <ojwanganto> i am stuck with a problem |
| 13:22:24 | <ojwanganto> i want to use a custom tld in my module |
| 13:22:38 | <ojwanganto> but i am not sure of where i should place it |
| 13:23:11 | <ojwanganto> i understand all tld files should be in WEB-INF |
| 13:23:33 | <ojwanganto> any help? |
| 13:23:53 | <dkayiwa> ojwanganto: i replied on the dev list |
| 13:24:22 | *** davidpardz has left #openmrs |
| 13:24:40 | <ojwanganto> oh okay |
| 13:24:47 | <ojwanganto> thanks so much |
| 13:24:57 | <ojwanganto> let me have a look at it |
| 13:25:38 | <harshadura> dkayiwa: is there a way to prevent xforms module adding "patientId=X" to the end of the "afterSubmitUrlSuffix" (just after a successful form submission) |
| 13:26:27 | <harshadura> dkayiwa: i dont want to show the patient dashboard after the form submission thats why |
| 13:27:39 | <ojwanganto> dkayiwa: unfortunately, your reply will reach me tomorrow |
| 13:28:13 | <ojwanganto> dkayiwa: i get dev mails once a day |
| 13:28:24 | <dkayiwa> ojwanganto: why |
| 13:28:52 | <ojwanganto> dkayiwa: they are bundled and sent on daily basis |
| 13:29:05 | <ojwanganto> i think that is how i configured it |
| 13:29:11 | <harshadura> ojwanganto: change the settings :) |
| 13:29:12 | <ojwanganto> dkayiwa: i think that is how i configured it |
| 13:29:47 | <harshadura> ojwanganto: you are allowed to change the google groups settings at anytime |
| 13:30:08 | <dkayiwa> ojwanganto: can you change it? |
| 13:30:34 | <dkayiwa> ojwanganto: ofcourse the choice is yours. if you do not want to get responses immediately, then leave it that way :) |
| 13:31:00 | <ojwanganto> i will have to change it dkayiwa and harshadura |
| 13:31:18 | <harshadura> ojwanganto: you can browse dev list through web even |
| 13:31:43 | <dkayiwa> harshadura: just set a value for the afterSubmitUrlSuffix div |
| 13:31:55 | <harshadura> ojwanganto: https://groups.google.com/a/openmrs.org/forum/#!forum/dev |
| 13:31:56 | <OpenMRSBot> <http://ln-s.net/$Kdi> (at groups.google.com) |
| 13:32:49 | <dkayiwa> ojwanganto: but anyway, the answer is here for an example of where you should put it: https://github.com/openmrs/openmrs-module-reporting/blob/master/omod/src/main/webapp/resources/reporting.tld |
| 13:32:53 | <OpenMRSBot> <http://ln-s.net/-_lf> (at github.com) |
| 13:33:53 | *** travis-ci has joined #openmrs |
| 13:33:53 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [a567f6d] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/9516340 |
| 13:33:53 | *** travis-ci has left #openmrs |
| 13:33:55 | <OpenMRSBot> <http://ln-s.net/-_lh> (at travis-ci.org) |
| 13:33:56 | <ojwanganto> thanks so much dkayiwa and harshadura |
| 13:34:09 | *** djazayeri has joined #openmrs |
| 13:34:09 | *** ChanServ sets mode: +o djazayeri |
| 13:34:44 | <harshadura> dkayiwa: i have already done that, but it suffix extra parameter called "patientId=X" |
| 13:35:09 | <harshadura> dkayiwa: this is the full line: model.put("afterSubmitUrlSuffix", "module/patientnarratives/patientNarrativesForm.form"); |
| 13:35:09 | <harshadura> |
| 13:35:16 | <dkayiwa> harshadura: does it cause any problems? |
| 13:36:51 | *** jordank has joined #openmrs |
| 13:37:21 | <harshadura> yes dkayiwa: since the URL is incorrect it doesnt show the right page: http://localhost:8088/openmrs22/module/patientnarratives/patientNarrativesForm.formpatientId=2 |
| 13:37:39 | <harshadura> dkayiwa ^^ is the resulting URL |
| 13:37:43 | *** GitHub79 has joined #openmrs |
| 13:37:44 | <GitHub79> [openmrs-core] dkayiwa closed pull request #353: Trunk 3970 (master...TRUNK-3970) http://git.io/C79bFQ |
| 13:37:44 | *** GitHub79 has left #openmrs |
| 13:37:44 | <dkayiwa> harshadura: can you add a ? |
| 13:37:45 | *** GitHub180 has joined #openmrs |
| 13:37:45 | <GitHub180> [openmrs-core] dkayiwa pushed 3 new commits to master: http://git.io/INjRBA |
| 13:37:45 | <GitHub180> openmrs-core/master a7289b4 Lee Breisacher: move unit test to separate class to get away from @Before failure |
| 13:37:45 | <GitHub180> openmrs-core/master 2c321f9 Lee Breisacher: move unit test to separate class to get away from @Before failure |
| 13:37:45 | <GitHub180> openmrs-core/master 00a079a dkayiwa: Merge pull request #353 from LeeBreisacher/TRUNK-3970... |
| 13:37:45 | *** GitHub180 has left #openmrs |
| 13:37:57 | <harshadura> dkayiwa: ah! |
| 13:38:03 | <dkayiwa> harshadura: and do: model.put("afterSubmitUrlSuffix", "module/patientnarratives/patientNarrativesForm.form?"); |
| 13:38:56 | *** mogoodrich has joined #openmrs |
| 13:40:17 | <harshadura> thank you dkayiwa: that fixed :) |
| 13:40:46 | <dkayiwa> harshadura: phew!!! :) |
| 13:41:03 | <harshadura> :) |
| 13:46:54 | *** LeeBreisacher1 has joined #openmrs |
| 13:47:54 | *** NameFILIP has joined #openmrs |
| 13:47:55 | *** ChanServ sets mode: +v NameFILIP |
| 13:52:00 | <k-joseph> dkayiwa: hi |
| 13:52:06 | <dkayiwa> k-joseph: hi |
| 13:52:38 | *** dmulindwa has quit IRC |
| 13:53:33 | *** dmulindwa has joined #openmrs |
| 13:54:13 | <k-joseph> dkayiwa: i have just again created the branch and re-editted my code into it, i have also fixed the duplication issue, as according to my last comment on the commit, however the failure is still insisting, here it is http://pastebin.com/WjUPCnTa, beg for some help!!! |
| 13:55:02 | *** b0b has quit IRC |
| 13:55:21 | <dkayiwa> k-joseph: can you look at your Note.hbm.xml for the mapping of the patient property and confirm you did it well? |
| 13:55:42 | *** travis-ci has joined #openmrs |
| 13:55:42 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [00a079a] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/9517098 |
| 13:55:42 | *** travis-ci has left #openmrs |
| 13:55:45 | <OpenMRSBot> <http://ln-s.net/-_mL> (at travis-ci.org) |
| 13:57:52 | <k-joseph> dkayiwa: incase there is any thing wrong or missing, willl be glad if pointed out to it, here is my current Note.hbm.xml filehttp://pastebin.com/Biwb0dhX |
| 13:58:14 | <dkayiwa> k-joseph: can you look at your Note.hbm.xml for the mapping of the patient property and confirm you did it well? |
| 13:58:27 | <dkayiwa> k-joseph: did you do the above? |
| 14:03:25 | *** harsha89 has joined #openmrs |
| 14:04:04 | <cpower> Hello everyone! |
| 14:04:22 | <cpower> And at least here in the States TGIF |
| 14:04:46 | <cpower> Let's scrum |
| 14:04:53 | <cpower> !scrumon cpower |
| 14:04:53 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:05:52 | <cpower> Order: rafa, dkayiwa , mogoodrich , and anyone else that has something to update. Always happy to hear |
| 14:05:57 | *** harsz89 has quit IRC |
| 14:07:59 | <cpower> rafa: you are up! |
| 14:09:12 | <cpower> ok, dkayiwa welcome back how about you? |
| 14:09:32 | <dkayiwa> cpower: thanks :) |
| 14:09:33 | <dkayiwa> Reviewed and merged: webapp's web.xml has two <display-name> tags - TRUNK-4017 |
| 14:09:33 | <dkayiwa> Reviewed: Provider.toString() implementation should return the id as well as provider names - TRUNK-3736 |
| 14:09:33 | <dkayiwa> Reviewed: Add voidNote() method to NoteDAO - TRUNK-3258 |
| 14:09:34 | <dkayiwa> Reviewed: API support for purgeConceptNameTag method - TRUNK-3983 |
| 14:09:34 | <dkayiwa> Reviewed and merged: Error when adding a task in version 1.9.3 - Trunk-3970 |
| 14:09:34 | <dkayiwa> Reviewed: Create a custom data type and its associated handler for providers - TRUNK-3623 |
| 14:09:35 | <dkayiwa> Reviewed: Create a custom data type and its associated handler for concepts - TRUNK-3621 |
| 14:09:35 | <dkayiwa> Doing more code reviews |
| 14:09:35 | <dkayiwa> No Blockers |
| 14:10:06 | <cpower> mogoodrich: any needs or questions? |
| 14:10:43 | <cpower> OOOK! |
| 14:11:33 | <djazayeri> My report |
| 14:11:33 | <djazayeri> * Worked on RefApp application roles, so I can test Rafal's first dispensing story |
| 14:11:33 | <djazayeri> * Working on capturing encounter diagnoses from an HTML form |
| 14:11:33 | <djazayeri> * Reviewing LeeBreisacher's pull requests |
| 14:11:37 | <djazayeri> no blockers |
| 14:11:58 | <djazayeri> mogoodrich has nothing to report (I'm on hangout with him) |
| 14:12:12 | <cpower> Announcements: Please comment on the changes to Community Swimlane discussion on the mailing list if you have interest, keep design meeting topics coming, let me know if you want to get more involved with our CD/CI work! |
| 14:12:39 | <cpower> djazayeri: thanks for the update and info, you sneaked in on me ;-) |
| 14:12:51 | <cpower> !scrumoff |
| 14:12:51 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:14:40 | <h3llborn> Rafa you around? |
| 14:16:06 | *** shruthd has joined #openmrs |
| 14:16:55 | <h3llborn> I guess not |
| 14:17:00 | *** dmulindwa has quit IRC |
| 14:17:16 | *** dmulindwa has joined #openmrs |
| 14:18:27 | <djazayeri> h3llborn: yesterday he mentioned to me that he wouldn't be able to work late today |
| 14:18:57 | <h3llborn> djazayeri: OK thanks :-) |
| 14:19:33 | <h3llborn> djazayeri: I'll just email him |
| 14:23:27 | *** dmulindwa has quit IRC |
| 14:23:29 | *** dmulindwa_ has joined #openmrs |
| 14:23:42 | <LeeBreisacher1> djazayeri: "Can you escape this? Or maybe do something like jQuery("").attr("id", ...)... just to be a bit safer?" |
| 14:24:13 | <djazayeri> LeeBreisacher1: not sure where it got eaten, but that was supposed to read jQuery('<span/>').attr(... |
| 14:24:23 | <LeeBreisacher1> djazayeri: I don't understand (but mostly because I don't have much experience with js) |
| 14:24:57 | <LeeBreisacher1> djazayeri: what does the jQuery() do? sorry, newbie questions... |
| 14:26:01 | <djazayeri> LeeBreisacher1: let me google the relevant like for what I was trying to suggest |
| 14:27:22 | <djazayeri> LeeBreisacher1: http://api.jquery.com/jQuery/#jQuery-html-attributes |
| 14:27:26 | <OpenMRSBot> <http://ln-s.net/-_nF> (at api.jquery.com) |
| 14:28:19 | <djazayeri> LeeBreisacher1: the idea is that $('<span></span>') will create a span dom element (detached at the moment) |
| 14:28:33 | <djazayeri> LeeBreisacher1: then .attr("id", "something") will set its id attribute |
| 14:28:47 | <djazayeri> LeeBreisacher1: and .html("content") will set its inner html |
| 14:28:55 | <LeeBreisacher1> djazayeri: nice. much cleaner. |
| 14:29:15 | <LeeBreisacher1> djazayeri: why is it named jQuery? seems odd to me. |
| 14:29:27 | <djazayeri> LeeBreisacher1: what I don't remember offhand is how to then get the full html for it, to append to the string you were already working with |
| 14:29:53 | <djazayeri> LeeBreisacher1: jQuery is the library. $ is the shorthand function it defines (and you can use safely, if you're in a js file) |
| 14:31:04 | <djazayeri> LeeBreisacher1: normally you'd do $('#id-of-some-element') or $('.some-class') or something like that |
| 14:31:24 | <djazayeri> LeeBreisacher1: but it happens to be overloaded to allow you to construct detached dom elements on the fly |
| 14:31:51 | <djazayeri> LeeBreisacher1: so you can do something like $('<span>hello</span>').appendTo('.some-class'); |
| 14:32:57 | <LeeBreisacher1> djazayeri: you lost me |
| 14:34:46 | <LeeBreisacher1> djazayeri: the proposed code allows for the id to be optional |
| 14:35:50 | <LeeBreisacher1> djazayeri: back in a few minutes.. |
| 14:35:54 | *** LeeBreisacher1 has left #openmrs |
| 14:42:25 | *** breeze has joined #openmrs |
| 14:47:48 | *** shruthd has quit IRC |
| 14:48:38 | *** GitHub134 has joined #openmrs |
| 14:48:38 | <GitHub134> [openmrs-core] k-joseph closed pull request #365: TRUNK-3258 [Add voidNote() method to NoteDAO] (master...TRUNK-3258) http://git.io/80TyFw |
| 14:48:38 | *** GitHub134 has left #openmrs |
| 14:51:19 | *** jordank has quit IRC |
| 14:51:40 | *** LeeBreisacher has joined #openmrs |
| 14:52:04 | <LeeBreisacher> djazayeri: I'm back |
| 14:52:38 | <LeeBreisacher> djazayeri: looking at code more carefully now |
| 14:54:15 | *** GitHub59 has joined #openmrs |
| 14:54:15 | <GitHub59> [openmrs-core] k-joseph opened pull request #368: TRUNK-3258 (master...TRUNK-3258) http://git.io/fLYzYw |
| 14:54:15 | *** GitHub59 has left #openmrs |
| 14:56:36 | *** jordank has joined #openmrs |
| 14:57:44 | <LeeBreisacher> breeze: did you see build 772 failed, but there's no screenshots |
| 14:58:15 | <LeeBreisacher> breeze: is it possible that the next build (773, green) wiped out the screenshots from 772? |
| 15:00:03 | *** k-joseph has quit IRC |
| 15:06:27 | <breeze> LeeBreisacher: hey, yes, saw your comment. working on adding the chrome logs as another artifact now |
| 15:08:11 | *** Mkop1 has joined #openmrs |
| 15:08:17 | <breeze> LeeBreisacher: but to answer your question. the pngs for 772 should have been archived outside of the working dir beforfe 773 wiped them out |
| 15:10:00 | *** Mkop has quit IRC |
| 15:11:33 | *** rcrichton has quit IRC |
| 15:13:13 | *** Mkop1 has quit IRC |
| 15:13:15 | <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-774 has FAILED : Manual build by Chris Briesemeister <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-774> |
| 15:13:37 | *** Mkop1 has joined #openmrs |
| 15:18:20 | *** dmulindwa_ has quit IRC |
| 15:25:29 | <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-775 has FAILED : Manual build by Chris Briesemeister <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-775> |
| 15:29:49 | *** dkayiwa has left #openmrs |
| 15:33:48 | *** rfriedman has joined #openmrs |
| 15:34:12 | <rfriedman> cpower, are you there? |
| 15:34:52 | <rfriedman> harshadura, are you there? |
| 15:35:07 | <harshadura> hi rfriedman |
| 15:35:20 | <rfriedman> hi harshadura, can you access jira? |
| 15:36:08 | <harshadura> rfriedman: its not working |
| 15:36:21 | <rfriedman> harshadura, just like me! |
| 15:36:32 | <harshadura> rfriedman: loading long time :) |
| 15:40:24 | *** LeeBreisacher1 has joined #openmrs |
| 15:44:16 | *** LeeBreisacher has quit IRC |
| 15:50:05 | *** bhashitha has joined #openmrs |
| 15:55:34 | *** harsha__ has joined #openmrs |
| 15:56:22 | *** harsha89 has quit IRC |
| 16:09:27 | *** LeeBreisacher1 has left #openmrs |
| 16:09:40 | *** LeeBreisacher1 has joined #openmrs |
| 16:15:21 | <h3llborn> anyone else having problems accessing tickets.openmrs.org |
| 16:15:22 | <h3llborn> ? |
| 16:15:43 | <LeeBreisacher1> h3llborn: yes |
| 16:16:05 | <h3llborn> LeeBreisacher1: are they doing maintenance? |
| 16:16:31 | <LeeBreisacher1> h3llborn: idk |
| 16:17:20 | <h3llborn> maybe downey knows whats up? :P |
| 16:18:05 | *** harshadura has quit IRC |
| 16:20:43 | <downey> h3llborn: i'll check with the IT on-call team |
| 16:20:51 | <h3llborn> downey: thanks :) |
| 16:22:53 | *** LeeBreisacher has joined #openmrs |
| 16:25:03 | <downey> h3llborn: should be back in a moment |
| 16:25:14 | <h3llborn> downey: aha thanks :) |
| 16:26:30 | <h3llborn> downey: is the mavenrepo down too? |
| 16:26:43 | <h3llborn> downey: http://pastebin.com/e4N1iR43 |
| 16:26:57 | <downey> h3llborn: no |
| 16:27:07 | *** LeeBreisacher1 has quit IRC |
| 16:27:13 | <h3llborn> downey: hmm thats weird ahha |
| 16:27:37 | <h3llborn> downey: now it works, that was weird |
| 16:31:22 | *** harsha__ has quit IRC |
| 16:33:23 | *** harsha__ has joined #openmrs |
| 16:34:47 | *** harsha__ is now known as harsz89 |
| 16:48:18 | *** mogoodrich has quit IRC |
| 16:48:59 | <LeeBreisacher> djazayeri: yt? I looked at js a bit more.. |
| 16:49:05 | <djazayeri> LeeBreisacher: hi |
| 16:49:07 | <djazayeri> yes, I'm back now |
| 16:49:19 | <LeeBreisacher> djazayeri: I have a lot to learn.. |
| 16:49:52 | <LeeBreisacher> djazayeri: for now, I think I understand the two-param variant of $(), but I'm not sure how it can work here... |
| 16:50:05 | <djazayeri> LeeBreisacher: there's definitely a lot to learn about js. I would recommend not learning all of it. :-) |
| 16:50:23 | <djazayeri> LeeBreisacher: incidentally, a great book (though several years old) is "Javascript: The Good Parts". |
| 16:50:27 | <LeeBreisacher> djazayeri: ha. yeah, so far I've managed to avoid learning any of it |
| 16:50:39 | <LeeBreisacher> djazayeri: for my day job |
| 16:51:03 | <djazayeri> LeeBreisacher: remind me what file we're looking at again? |
| 16:51:19 | <LeeBreisacher> djazayeri: navigatorModels.js |
| 16:51:28 | <LeeBreisacher> djazayeri: line 282, e.g |
| 16:52:40 | <LeeBreisacher> djazayeri: I can maybe see how to construct a <span> with an id attr, but then I don't know how to set the text content of that span element |
| 16:53:13 | <LeeBreisacher> djazayeri: although even for constructing the span element, I don't see how to make the id attr optional |
| 16:53:21 | <djazayeri> LeeBreisacher: that should be $('<span></span>').html('this goes inside'); |
| 16:53:57 | <LeeBreisacher> djazayeri: ah. ok. got that (experimenting in a js console) |
| 16:54:09 | <LeeBreisacher> djazayeri: so now how to make the id optional |
| 16:54:15 | <djazayeri> LeeBreisacher: if you're not aware of jsfiddle.net, you should be |
| 16:54:53 | <LeeBreisacher> djazayeri: nice. what version of jquery do we use? |
| 16:55:27 | <djazayeri> LeeBreisacher: offhand I forget, but maybe it's 1.8 or 1.9 |
| 16:55:43 | <djazayeri> LeeBreisacher: probably 1.8. (Seems like it's time to upgrade) |
| 16:55:58 | <djazayeri> LeeBreisacher: but the semantics of these core functions won't have changed |
| 16:57:53 | <djazayeri> LeeBreisacher: something like this: http://jsfiddle.net/qGkKn/ |
| 17:00:01 | *** mogoodrich has joined #openmrs |
| 17:00:23 | <LeeBreisacher> djazayeri: I feel like a dummy. |
| 17:01:25 | <LeeBreisacher> djazayeri: is the HTML quadrant the "output" of the js? |
| 17:01:48 | <LeeBreisacher> djazayeri: or is the HTML quadrant the *input* to the js? |
| 17:02:19 | <djazayeri> LeeBreisacher: HTML, Javascript, and CSS are all inputs. Result is the output |
| 17:02:37 | <LeeBreisacher> djazayeri: but I want to see the "raw" html output |
| 17:02:57 | <djazayeri> LeeBreisacher: Inspect Element? |
| 17:03:14 | <LeeBreisacher> djazayeri: right, using browser dev tools.. |
| 17:03:24 | <djazayeri> LeeBreisacher: yeah |
| 17:03:30 | <LeeBreisacher> djazayeri: I just assumed jsfiddle would show the raw output |
| 17:04:34 | <djazayeri> LeeBreisacher: PS- nobody should feel dumb for not instantly being up to speed with javascript |
| 17:05:08 | <LeeBreisacher> djazayeri: I suppose. I just usually pick up new languages quickly (and I'm impatient). |
| 17:05:44 | <LeeBreisacher> djazayeri: and, as usual with most languages, it's not the language that takes time to learn, it's all the supporting api's and such |
| 17:05:50 | <LeeBreisacher> djazayeri: like jquery |
| 17:06:07 | <LeeBreisacher> djazayeri: an aside, if you have time... |
| 17:06:59 | <djazayeri> LeeBreisacher: I have (some) time |
| 17:07:00 | <LeeBreisacher> djazayeri: looking at the openmrs code for all this webapp side of things (non-java), it seems awfully complicated. |
| 17:07:21 | <LeeBreisacher> djazayeri: what with js, gsp, json, etc |
| 17:07:42 | <LeeBreisacher> djazayeri: do we really need all these different languages/facilities? |
| 17:08:15 | <LeeBreisacher> djazayeri: trying to follow the path of a single <span> element from it's original source code through various gsp's and js's... |
| 17:10:45 | <djazayeri> LeeBreisacher: We definitely have a lot of technologies, and they're tied together in ways that aren't very intuitive |
| 17:11:04 | <djazayeri> LeeBreisacher: the idea is that you can actually do a lot without needing to ever trace through all the technologies. |
| 17:11:09 | <LeeBreisacher> djazayeri: just seems like it makes it difficult to maintain (and learn!) |
| 17:11:20 | <LeeBreisacher> djazayeri: true, except when you do ;-) |
| 17:12:26 | <djazayeri> LeeBreisacher: the general philosophy is that it's okay for frameworky code to be complicated and in the purview of the few, as long as it lets less-experienced devs do stuff easily without noticing it. |
| 17:12:31 | <djazayeri> LeeBreisacher: we're definitely not there yet. |
| 17:12:37 | <LeeBreisacher> djazayeri: anyway, back to details. it appears that jquery treats $('<span>') the same as $('<span></span>'). seems slightly better to me. yes? |
| 17:13:03 | <djazayeri> LeeBreisacher: as an aside, I _really_ wish I had known about AngularJS earlier. That would have simplified some things. |
| 17:13:23 | <djazayeri> LeeBreisacher: How about $('<span/>') |
| 17:13:43 | <djazayeri> LeeBreisacher: for whatever reason I prefer to see it as well-formed HTML, though I guess there's no real need for that if jquery takes care of it. |
| 17:14:23 | <LeeBreisacher> djazayeri: that works too. I slightly prefer just <span> in this case |
| 17:14:44 | <LeeBreisacher> djazayeri: one more detail question: what is $('#testing') ? |
| 17:15:27 | <djazayeri> LeeBreisacher: i don't have strong feelings about this. I vaguely recall seeing something in the docs I sent you a link to, saying that behavior may be unspecified for non-well-formed html (e.g. <span>) but I'm not sure |
| 17:15:49 | <djazayeri> LeeBreisacher: That was just because I wanted to output it somewhere on the screen |
| 17:16:15 | <LeeBreisacher> djazayeri: no, I mean what does the # syntax mean? |
| 17:16:17 | <djazayeri> LeeBreisacher: i.e. I named the div element "testing" in the html, and this just appends whatever we had built up there |
| 17:16:26 | <djazayeri> LeeBreisacher: oh, it means select a dom element by id. |
| 17:16:33 | <LeeBreisacher> ah, of course |
| 17:16:44 | <LeeBreisacher> djazayeri: so, thanks for the mini js-lesson. I'll go hack on that navigatorModel and update the pull request |
| 17:18:02 | <LeeBreisacher> djazayeri: oh, one more comment on the "lots of technologies"... |
| 17:19:17 | <LeeBreisacher> djazayeri: isn't it true that there are new technologies coming out every week? it seems like a good approach is to try to not get too attached to any one of them - be able to switch technologies if a new one looks good. |
| 17:19:25 | <LeeBreisacher> djazayeri: easier said than done of course |
| 17:20:02 | *** jordank has quit IRC |
| 17:20:13 | <djazayeri> LeeBreisacher: I spent a very long time trying to stay detached from specific technologies, but ultimately we had to actually build something. :-) |
| 17:20:32 | <LeeBreisacher> djazayeri: yeah.. |
| 17:20:36 | <djazayeri> LeeBreisacher: We have generally tried to be defensive about things like that |
| 17:20:43 | <LeeBreisacher> djazayeri: good good |
| 17:21:10 | <djazayeri> LeeBreisacher: i.e. the appframework actually does let you write apps using any technology (either our UI Framework, standard Spring MVC, or else plain html) |
| 17:21:43 | <LeeBreisacher> djazayeri: ok |
| 17:22:05 | <djazayeri> LeeBreisacher: Unfortunately specific fragments we've implemented in the UI Framework have gotten pretty specific. (KnockoutJS is particularly bad for this reason.) |
| 17:22:35 | <LeeBreisacher> djazayeri: somewhat related question: that Birthday Month drop-down thing is still not working right via the keyboard |
| 17:22:51 | <djazayeri> LeeBreisacher: hmm, I felt like it worked for me last time I tried, but I didn't look closely. |
| 17:22:58 | <djazayeri> LeeBreisacher: what's the current behavior? |
| 17:23:34 | <LeeBreisacher> djazayeri: same as ever. I can type one letter and it goes to that month, but then no additional typing has any affect. letters nor arrow keys. |
| 17:23:47 | <LeeBreisacher> djazayeri: let me double check.. |
| 17:23:53 | <jkeiper> mseaton: for some reason, i'm not seeing reporting liquibase changes in the liquibase table ... is there something magic done for reporting? also, it looks like onFail=MARK_RAN is not working ... |
| 17:24:57 | <LeeBreisacher> djazayeri: yeah, still misbehaves. in fact, the arrow keys now seem to go to the outer browser which scrolls. ew. |
| 17:25:54 | <djazayeri> LeeBreisacher: you're right, I still see that on devtest01. |
| 17:26:01 | *** rday has joined #openmrs |
| 17:26:01 | <LeeBreisacher> djazayeri: what I don't understand is that there are plenty of standard js libraries out there that provide working drop-down widgets. right? why is this even an issue? |
| 17:26:51 | <jkeiper> LeeBreisacher: might be an onChange event |
| 17:26:54 | <LeeBreisacher> djazayeri: e.g. the web-side folks at my company are using qooxdoo, I think |
| 17:27:16 | <jkeiper> LeeBreisacher: we have to be sure the license is okay to meet our standards :-/ |
| 17:27:28 | <jkeiper> LeeBreisacher: see if you can audit events on that control |
| 17:27:50 | <djazayeri> LeeBreisacher: do you know offhand where that widget lives? |
| 17:27:59 | <djazayeri> LeeBreisacher: I haven't looked at its code at all. |
| 17:28:11 | <LeeBreisacher> jkeiper: sorry, I don't have time to dig into at the moment, but yeah.. |
| 17:28:28 | <LeeBreisacher> djazayeri: I do not. I haven't looked closely either. |
| 17:28:42 | <LeeBreisacher> djazayeri: but my question wasn't specifically about that widget |
| 17:28:45 | <djazayeri> LeeBreisacher: found it: uicommons module, field/multipleInputDate |
| 17:28:54 | <LeeBreisacher> djazayeri: but more generally about standard widget libraries |
| 17:29:03 | <djazayeri> LeeBreisacher: the idea is that this isn't even a widget at all, it's just a plain <select>... |
| 17:29:34 | <djazayeri> LeeBreisacher: I actually _want_ to use an autocomplete, but our UX guy has been pushing back, and saying we should stick to standard html controls. |
| 17:29:37 | <rfriedman> downey, you there? |
| 17:30:23 | <LeeBreisacher> djazayeri: our UX guy? who is that? and why would he care about the implementation details? |
| 17:30:41 | <djazayeri> LeeBreisacher: it's Glauber, who is on vacation at the moment... |
| 17:32:53 | <LeeBreisacher> djazayeri: oh, I just thought of another (somewhat related) question I keep meaning to ask: are these openmrs apps we're working on supposed to work on mobile devices? |
| 17:33:28 | <djazayeri> LeeBreisacher: I'll ultimately overrule him on that. It's good advice for websites with casual users, but not for something with heavy users who use the system as part of their job |
| 17:33:33 | <LeeBreisacher> djazayeri: iow, all this html is supposed to look and run ok on phones |
| 17:33:37 | <djazayeri> LeeBreisacher: we have made no effort to make them work on mobiles |
| 17:34:25 | <LeeBreisacher> djazayeri: has mobile been a requested feature? |
| 17:35:03 | <djazayeri> LeeBreisacher: "mobile" is definitely a requested feature, but more in the sense of having custom mobile apps, not "the regular web UI should work on a phone" |
| 17:35:14 | <LeeBreisacher> djazayeri: ah |
| 17:35:52 | <LeeBreisacher> djazayeri: but aren't there technologies that make it so you can write-once/run-anywhere? phonegap? |
| 17:36:02 | <rfriedman> djazayeri, is jira working for you? |
| 17:36:14 | <djazayeri> rfriedman: it is now |
| 17:36:16 | <LeeBreisacher> djazayeri: (just tell me to go away if I'm asking too many questions...) |
| 17:36:21 | <rfriedman> djazayeri, ok tks |
| 17:36:50 | <djazayeri> LeeBreisacher: I haven't looked at the specific technologies, but generally they lead to a least-common-denominator interface |
| 17:36:53 | *** rfriedman has quit IRC |
| 17:37:36 | <djazayeri> LeeBreisacher: I think we want to be strategic about which specific parts of the system we optimize for mobile use, and do it well. |
| 17:37:49 | <djazayeri> LeeBreisacher: while other things can be optimized for their relevant workflows |
| 17:37:49 | *** jordank has joined #openmrs |
| 17:38:07 | <LeeBreisacher> djazayeri: ok. but you're working with limited resources, I assume.. |
| 17:38:47 | <djazayeri> LeeBreisacher: e.g. the registration app is supposed to be optimized for a high-volume front desk clerk, who is going to be recording names, and it's not even worth doing that function without a physical keyboard |
| 17:39:07 | <LeeBreisacher> djazayeri: ah. makes sense. |
| 17:39:18 | <djazayeri> LeeBreisacher: I _do_ need to get back to some code now. :-) |
| 17:39:22 | <LeeBreisacher> djazayeri: me too |
| 17:39:25 | <LeeBreisacher> djazayeri: thanks |
| 17:39:38 | <LeeBreisacher> djazayeri: I still want that big-picture lesson some other time... |
| 17:39:52 | <djazayeri> LeeBreisacher: sure |
| 17:40:43 | *** rday has quit IRC |
| 17:42:03 | <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-777 has FAILED (1 tests failed) : Dependant of CA-CA-92 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-777> |
| 17:45:12 | <LeeBreisacher> breeze: yt? still no screenshot on failed test... |
| 17:45:28 | <breeze> LeeBreisacher: I'm here....just a sec |
| 17:47:28 | <jkeiper> mseaton: seems like reporting 0.7.8 upgrade is failing across multiple instances (for me) ... |
| 17:49:33 | <breeze> LeeBreisacher: Hmm, actually it looks like the driver version was updated again |
| 17:50:02 | <breeze> LeeBreisacher: nevermind..... |
| 17:50:32 | <breeze> LeeBreisacher: I was looking at the version of Chrome itself |
| 17:51:38 | *** NameFILIP has quit IRC |
| 17:53:53 | <breeze> LeeBreisacher: argh. looks like the reason the chromedriver log is not helpful is that each test overwrites the previous output |
| 17:54:06 | <LeeBreisacher> breeze: yep |
| 17:54:23 | <LeeBreisacher> breeze: not sure how helpful it would be anyway |
| 17:54:54 | <LeeBreisacher> so there's an actual modal dialog popping up...at the time we're trying to enter a value in the FamilyName field. |
| 17:54:56 | <breeze> LeeBreisacher: it's something, unless you have other suggestions |
| 17:55:22 | <LeeBreisacher> breeze: could be an auto-suggest thing popping up? |
| 17:55:56 | <LeeBreisacher> breeze: I actually saw this exact problem locally yesterday, but the dialog was visible for just a brief moment and I didn't see it. |
| 17:55:57 | <breeze> LeeBreisacher: that would be occurring on local runs then too, right? |
| 17:56:13 | <LeeBreisacher> breeze: and of course I never saw it happen again |
| 17:56:39 | <breeze> LeeBreisacher: hmm |
| 17:57:53 | <LeeBreisacher> breeze: here's another idea: |
| 17:58:28 | <LeeBreisacher> breeze: the exception is UnhandledAlertException, which has a "getAlert()" api. |
| 17:59:01 | <LeeBreisacher> breeze: so I could try explicitly catching that exception, call getAlert() and dump out the info on sysout or syserr |
| 17:59:15 | <breeze> LeeBreisacher: ok |
| 18:00:03 | <breeze> LeeBreisacher: I'm up for that.....that's what I was hoping the chromedriver log might have, but....well getting the right info from those should be done anyway |
| 18:00:26 | <breeze> LeeBreisacher: and by right, all I mean is complete |
| 18:04:50 | <LeeBreisacher> breeze: hm, now I'm not sure this is gonna help. I suspect the bamboo log already has the info, "An open modal dialog blocked the operation" |
| 18:04:57 | <LeeBreisacher> breeze: but I'll try it anyway |
| 18:05:52 | <breeze> LeeBreisacher: well, I wonder why it is less flaky locally than on bamboo |
| 18:06:46 | <breeze> LeeBreisacher: because I would suggest to keep the change you're talking about local, and try to reproduce it on your machine |
| 18:09:52 | <jkeiper> mseaton: not sure if this is a known bug, but i just filed a ticket (and can patch it if you want): |
| 18:09:58 | <jkeiper> !ticket REPORT-520 |
| 18:09:59 | <OpenMRSBot> jkeiper: [#REPORT-520] ForeignKeyTableName error in liquibase changeset - OpenMRS JIRA - https://tickets.openmrs.org/browse/REPORT-520 |
| 18:11:19 | <LeeBreisacher> breeze: ok, I'll try locally. in the meantime, maybe we should quarantine that test? |
| 18:11:32 | <breeze> LeeBreisacher: ok....will do that now |
| 18:34:48 | <breeze> LeeBreisacher: yt? |
| 18:38:08 | <LeeBreisacher> breeze: yes |
| 18:38:35 | <LeeBreisacher> breeze: I gotta get a better IRC client. one that makes noise when someone pings me... |
| 18:40:05 | <harsz89> LeeBreisacher, actually try using xchat, it's having options to notify you :D |
| 18:40:25 | *** jordank has quit IRC |
| 18:40:35 | <breeze> LeeBreisacher: yeah, that's what I use, but on Windows you need to buy a license |
| 18:40:39 | *** achint has quit IRC |
| 18:41:08 | <breeze> LeeBreisacher: but anyway, when you were able to recreate this locally, were you on your VM, or host box? |
| 18:42:08 | <LeeBreisacher> breeze: server running in my vagrant VM. client running in Windows. |
| 18:42:52 | <LeeBreisacher> breeze: when I try to reproduce this (probably later today or the weekend), I'll try linux client too. |
| 18:43:37 | <LeeBreisacher> breeze: and I'll try hitting devtest01/02 also. |
| 18:47:03 | <LeeBreisacher> djazayeri: when you have a minute, take a look at new and improved pull request on uicommons |
| 18:47:08 | <LeeBreisacher> https://github.com/openmrs/openmrs-module-uicommons/pull/3 |
| 18:47:12 | <OpenMRSBot> <http://ln-s.net/-_tJ> (at github.com) |
| 18:48:31 | <breeze> LeeBreisacher: ok...the reason I was asking is I had another wild theory that general machine performance maybe is a factor |
| 18:49:11 | <breeze> LeeBreisacher: I am testing locally basically the same as you except with linux host as well as server |
| 18:50:42 | <LeeBreisacher> breeze: yes, I think perf may be a factor. |
| 18:51:36 | <LeeBreisacher> breeze: I think the one time I saw it yesterday was the first time I had run any openmrs in quite a while, so things were going slow getting cached and such. |
| 18:51:47 | <LeeBreisacher> breeze: I'll have a look at Sn timeout settings and similar.. |
| 18:51:53 | <breeze> LeeBreisacher: I'm throttling down the RAM on my vagrant box and running everything on there to see if I have better luck reproducing it |
| 18:52:01 | *** NameFILIP has joined #openmrs |
| 18:52:10 | *** ChanServ sets mode: +v NameFILIP |
| 18:57:03 | *** bhashitha has quit IRC |
| 18:57:16 | *** NameFILIP has quit IRC |
| 19:08:47 | *** NameFILIP has joined #openmrs |
| 19:08:48 | *** ChanServ sets mode: +v NameFILIP |
| 19:26:28 | <OpenMRSBot> Recent updates in the world of openmrsci: REFAPP-OMODDISTRO-779 has FAILED (2 tests failed) : Dependant of UICM-UICOMMONS-187 <https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-779> |
| 19:28:52 | <LeeBreisacher> breeze: we got screenshots this time |
| 19:29:18 | <LeeBreisacher> breeze: but not very informative. invalid logins. |
| 19:29:49 | <LeeBreisacher> breeze: and indeed I cannot login by hand to devtest01 |
| 19:31:09 | <LeeBreisacher> breeze: can you (or someone) see what's going on with devtest01 at the moment? |
| 19:36:43 | *** rcrichton has joined #openmrs |
| 19:52:47 | <cpower> docpaul: You around? |
| 19:53:24 | <breeze> LeeBreisacher: sorry you there? |
| 19:53:32 | <LeeBreisacher> breeze: yes |
| 19:53:42 | <LeeBreisacher> breeze: but now devtest01 is back to normal |
| 19:53:51 | <breeze> LeeBreisacher: ok....wound up in a very long conversation |
| 19:54:06 | <breeze> LeeBreisacher: yeah, it resets itself after about 5 mins...the user lockout that is |
| 19:54:24 | <LeeBreisacher> breeze: do we have any clue about why its getting locked? |
| 19:55:03 | <djazayeri> LeeBreisacher, breeze: seems like it would be worthwhile to put a log.info statement in the core code when a login attempt fails. |
| 19:55:06 | <breeze> LeeBreisacher: just a clue, but haven't follow up on it yet...the scheduled task using incorrect credentials |
| 19:55:13 | <LeeBreisacher> breeze: I've asked this before I think, but never heard an answer: are there logs of some kind that we can look at? |
| 19:56:06 | <LeeBreisacher> breeze: would the tomcat log have anything useful in it? |
| 19:56:13 | <breeze> LeeBreisacher: yes, It's been in my queue to make the tomcayt logs available, but haven't yet |
| 19:57:08 | <LeeBreisacher> breeze: is devtest01 used for anything else besides these ui tests? |
| 19:57:16 | <breeze> LeeBreisacher: it should not be |
| 19:57:53 | <LeeBreisacher> breeze: is it possible that some (non UI) unit tests are hitting it? |
| 19:58:09 | <breeze> LeeBreisacher: sorry, I mean it should not be sued for anything else, but some people occassionally poke around in there manually |
| 19:58:41 | <breeze> LeeBreisacher: I don't think so...the mysql access is only local to that box |
| 19:58:46 | <LeeBreisacher> breeze: right. it seems like too much of a coincidence that these login lockouts seem to always happen right after a refapp build |
| 19:59:25 | <LeeBreisacher> breeze: um..right after a refapp build that was triggered by a dependent build |
| 19:59:48 | *** achint has joined #openmrs |
| 19:59:56 | <breeze> LeeBreisacher: yeah...give me a min...I'm going to pick up a log example of what Im'm thinking of |
| 20:02:53 | <breeze> LeeBreisacher: WARN - AuthenticatedTask.authenticate(74) |2013-07-21 07:22:19,965| Not authenticating to avoid locking account. Please ensure you scheduler username and password are configured correctly in your global properties |
| 20:03:21 | <LeeBreisacher> breeze: nice. where's that coming from? |
| 20:03:21 | <breeze> LeeBreisacher: so that would be the root cause....or rather the zillion other occurences of that same message |
| 20:03:33 | <breeze> LeeBreisacher: the tomcat log on devtest01 |
| 20:07:12 | *** mogoodrich has quit IRC |
| 20:08:07 | <LeeBreisacher> breeze: are there any log entries that start with "Error authenticating..." ? |
| 20:08:42 | <breeze> LeeBreisacher: searching..... |
| 20:09:44 | <breeze> LeeBreisacher: WARN - AuthenticatedTask.authenticate(85) |2013-07-21 06:57:20,154| Error authenticating 'admin' use |
| 20:09:44 | <breeze> r. Please ensure you scheduler username and password are configured correctly in your global propert |
| 20:09:44 | <breeze> ies |
| 20:10:24 | <LeeBreisacher> breeze: right. so my reading of the auth code looks like ONE incorrect attempt locks it for 5 minutes. |
| 20:12:26 | <breeze> LeeBreisacher: hmm...ok...well I found the fix on the UI, but it needs to be put in place permanently http://devtest01.openmrs.org:8080/openmrs/admin/maintenance/settings.list?show=Scheduler |
| 20:13:05 | <LeeBreisacher> breeze: although this code does not appear to be the code that authenticates human users |
| 20:13:19 | <breeze> LeeBreisacher: interesting.... |
| 20:13:28 | <LeeBreisacher> breeze: right...what is this Scheduler thing? |
| 20:14:02 | <breeze> LeeBreisacher: I don't know much about it |
| 20:15:20 | <LeeBreisacher> breeze: nor I (obviously). but it sorta looks like those error msgs in the log are unrelated to the problem we're seeing |
| 20:16:08 | <breeze> LeeBreisacher: hmm...I think it is related... |
| 20:16:10 | <djazayeri> breeze, LeeBreisacher: I think the problem may be that there are two modules that have scheduled processes which try to authenticate this way (reporting and idgen), and both are smart enough to not try too many times to avoid locking out, but they're unaware of _each other_ so with both of them running, we may get lockouts. |
| 20:16:43 | <breeze> LeeBreisacher: it's an invalid login attempt that is, presumably what is locking human users out |
| 20:17:02 | <djazayeri> breeze, LeeBreisacher: one fix would be to create a different account (e.g. with username "scheduler") and set the global properties for scheduler.username and scheduler.password to point to this user. |
| 20:18:02 | <djazayeri> breeze, LeeBreisacher: I believe we have agreement from all required parties to upgrade the idgen and reporting modules to require OpenMRS 1.7 (they're currently against 1.6) and this will allow them to use the Daemon API, and not have to do this hacky thing that ends up locking the system sometimes. |
| 20:18:36 | <djazayeri> breeze, LeeBreisacher: we should probably write tickets for that, and do it as part of the reference application work. |
| 20:18:40 | <djazayeri> off to lunch â will be off for 30-60 mins |
| 20:19:53 | <breeze> djazayeri: thanks....for the info.... |
| 20:20:24 | <breeze> LeeBreisacher: so what does that mean for the here and now? I did manually update that property in the ui for now |
| 20:20:50 | <breeze> LeeBreisacher: that fix should persist until someone muchs with that db |
| 20:21:23 | <LeeBreisacher> breeze: I didn't follow everything D said. not sure where that leaves us. |
| 20:21:50 | <breeze> LeeBreisacher: basically, I think i have it fixed temporarily |
| 20:21:54 | <LeeBreisacher> breeze: so the name/pwd properties you found -- they were set wrong? |
| 20:22:00 | <breeze> LeeBreisacher: yes |
| 20:22:08 | <LeeBreisacher> breeze: what were they? and what are they now? |
| 20:22:58 | <breeze> LeeBreisacher: the setting for the scheduler was set at 'test' which is incorrect in the case of devtest01 |
| 20:23:21 | <LeeBreisacher> breeze: ah. (I was seeing the right pwd, but you had probably already changed it) |
| 20:23:48 | <breeze> LeeBreisacher: yes |
| 20:23:54 | <LeeBreisacher> breeze: so cool, maybe that particular problem will go away, at least for a while |
| 20:24:22 | <LeeBreisacher> breeze: I'm gonna get some lunch too.. |
| 20:32:33 | *** David has joined #openmrs |
| 20:32:57 | *** David is now known as Guest30824 |
| 20:35:55 | *** mogoodrich has joined #openmrs |
| 21:03:18 | *** breeze has quit IRC |
| 21:04:35 | *** breeze has joined #openmrs |
| 21:08:16 | *** rcrichton has quit IRC |
| 21:33:03 | *** NameFILIP has quit IRC |
| 21:54:59 | <LeeBreisacher> djazayeri: did you see I updated the pull request for uicommons as per our js discussion... |
| 21:55:18 | <djazayeri> LeeBreisacher: I saw it but haven't clicked on it yet. Is it blocking you? |
| 21:55:44 | <djazayeri> LeeBreisacher: do you have a link offhand? |
| 21:58:06 | <LeeBreisacher> djazayeri: https://github.com/LeeBreisacher/openmrs-module-uicommons/commit/e09620be5b1e8d0ffdcead267d2e3c6880f22e05 |
| 21:58:10 | <OpenMRSBot> <http://ln-s.net/-_x$> (at github.com) |
| 21:58:59 | <LeeBreisacher> djazayeri: it's not blocking me. it's just that I have some UI test changes pending. but I can hold on to them. |
| 21:59:21 | <djazayeri> LeeBreisacher: I notice that there's still my "same comment here" comment around line 332 |
| 22:00:31 | <LeeBreisacher> djazayeri: darn. yep, missed that one. thanks. |
| 22:01:54 | <djazayeri> LeeBreisacher: just to check, the things that you're taking the id off of, to put it on the label spanâ¦that dom element disappears? |
| 22:02:02 | <djazayeri> LeeBreisacher: i.e. we don't end up with the same id on two elements do we? |
| 22:02:44 | <LeeBreisacher> djazayeri: correct |
| 22:03:01 | <LeeBreisacher> djazayeri: but that's just based on my observations, not a thorough knowledge of the code. |
| 22:03:27 | <LeeBreisacher> djazayeri: I look at the resulting html and compare it to "view source". |
| 22:03:29 | <djazayeri> LeeBreisacher: okay, well, it's probably enough to view source after loading the page |
| 22:03:59 | <djazayeri> LeeBreisacher: the alternative would be to do something like <⦠data-label-id="id-to-use-on-label"> |
| 22:04:12 | <djazayeri> LeeBreisacher: but if the element is being removed, I think what you've done is fine. |
| 22:04:55 | <LeeBreisacher> djazayeri: what happens if two elements end up with the same id? does the browser complain? |
| 22:06:17 | <LeeBreisacher> djazayeri: pull request updated ... |
| 22:06:42 | *** mogoodrich has quit IRC |
| 22:06:45 | <djazayeri> LeeBreisacher: the browser doesn't complain, just that javascript behavior might be undefined |
| 22:22:50 | *** breeze has quit IRC |
| 22:27:29 | *** b0b has joined #openmrs |
| 22:28:12 | *** b0b has left #openmrs |
| 22:33:25 | *** NameFILIP has joined #openmrs |
| 22:33:25 | *** ChanServ sets mode: +v NameFILIP |
| 22:37:56 | *** NameFILIP has quit IRC |
| 23:33:26 | *** LeeBreisacher has quit IRC |
| 23:34:00 | *** NameFILIP has joined #openmrs |
| 23:34:00 | *** ChanServ sets mode: +v NameFILIP |
| 23:35:09 | *** LeeBreisacher has joined #openmrs |
| 23:36:21 | *** LeeBreisacher has left #openmrs |
| 23:36:32 | *** LeeBreisacher has joined #openmrs |
| 23:38:14 | *** NameFILIP has quit IRC |
| 23:54:56 | *** cospih_ has joined #openmrs |
| 23:56:33 | *** cospih has quit IRC |