00:04:58
|
*** sgithens has joined #openmrs
|
00:11:56
|
*** wyclif has quit IRC
|
00:14:34
|
*** shrewduh has joined #openmrs
|
00:15:01
|
*** nano has quit IRC
|
00:25:42
|
*** shrewduh has quit IRC
|
00:36:29
|
*** NameFILIP has joined #openmrs
|
00:36:30
|
*** ChanServ sets mode: +v NameFILIP
|
00:40:57
|
*** NameFILIP has quit IRC
|
01:15:53
|
*** robbyoconnor has joined #openmrs
|
01:15:58
|
*** ChanServ sets mode: +v robbyoconnor
|
01:36:59
|
*** NameFILIP has joined #openmrs
|
01:37:00
|
*** ChanServ sets mode: +v NameFILIP
|
01:41:16
|
*** NameFILIP has quit IRC
|
01:51:49
|
*** bhashitha has joined #openmrs
|
01:58:02
|
*** mogoodrich has joined #openmrs
|
02:04:02
|
*** harshadura has quit IRC
|
02:05:29
|
*** nano1 has joined #openmrs
|
02:08:21
|
*** djazayeri has joined #openmrs
|
02:08:21
|
*** ChanServ sets mode: +o djazayeri
|
02:09:04
|
*** rday has joined #openmrs
|
02:17:36
|
*** harshadura has joined #openmrs
|
02:37:29
|
*** NameFILIP has joined #openmrs
|
02:37:30
|
*** ChanServ sets mode: +v NameFILIP
|
02:42:09
|
*** NameFILIP has quit IRC
|
03:05:02
|
*** mogoodrich has quit IRC
|
03:10:30
|
*** djazayeri1 has joined #openmrs
|
03:10:30
|
*** djazayeri has quit IRC
|
03:13:21
|
*** bhashitha has quit IRC
|
03:26:33
|
*** djazayeri1 has quit IRC
|
03:26:41
|
*** djazayeri has joined #openmrs
|
03:26:41
|
*** ChanServ sets mode: +o djazayeri
|
03:38:02
|
*** NameFILIP has joined #openmrs
|
03:38:02
|
*** ChanServ sets mode: +v NameFILIP
|
03:42:48
|
*** NameFILIP has quit IRC
|
03:42:57
|
*** shrewduh has joined #openmrs
|
03:43:51
|
*** harshadura has quit IRC
|
03:44:08
|
*** harshadura has joined #openmrs
|
03:47:11
|
*** shrewduh has quit IRC
|
04:06:14
|
*** k-joseph has quit IRC
|
04:38:12
|
*** djazayeri has quit IRC
|
04:38:29
|
*** NameFILIP has joined #openmrs
|
04:38:29
|
*** ChanServ sets mode: +v NameFILIP
|
04:39:27
|
*** rnjn has joined #openmrs
|
04:43:14
|
*** NameFILIP has quit IRC
|
04:45:21
|
*** cospih has quit IRC
|
04:45:41
|
*** cospih has joined #openmrs
|
05:05:14
|
*** shrewduh has joined #openmrs
|
05:19:34
|
*** ArcTanSusan has joined #openmrs
|
05:21:14
|
*** maninc has joined #openmrs
|
05:38:57
|
*** NameFILIP has joined #openmrs
|
05:38:57
|
*** ChanServ sets mode: +v NameFILIP
|
05:43:08
|
*** NameFILIP has quit IRC
|
05:49:23
|
*** ArcTanSusan has quit IRC
|
05:59:05
|
*** maninc has quit IRC
|
06:14:19
|
*** ArcTanSusan has joined #openmrs
|
06:26:53
|
*** NameFILIP has joined #openmrs
|
06:26:53
|
*** ChanServ sets mode: +v NameFILIP
|
06:39:51
|
*** sgithens has quit IRC
|
06:51:39
|
*** rcrichton has joined #openmrs
|
06:55:06
|
*** k-joseph has joined #openmrs
|
06:59:09
|
*** rday has quit IRC
|
07:02:38
|
*** harshadura has quit IRC
|
07:10:43
|
*** harshadura has joined #openmrs
|
07:11:23
|
*** davidpardz has joined #openmrs
|
07:11:23
|
*** ChanServ sets mode: +v davidpardz
|
07:14:09
|
*** ruwanego has quit IRC
|
07:16:24
|
*** ArcTanSusan has quit IRC
|
07:17:11
|
*** rday has joined #openmrs
|
07:18:19
|
*** k-joseph has left #openmrs
|
07:21:09
|
*** harshadura has quit IRC
|
07:31:53
|
*** k-joseph has joined #openmrs
|
07:33:23
|
*** shrewduh has quit IRC
|
07:50:03
|
*** shrewduh has joined #openmrs
|
07:56:21
|
*** drsayem007 has joined #openmrs
|
08:02:41
|
*** drsayem007 has quit IRC
|
08:02:54
|
*** maninc has joined #openmrs
|
08:04:21
|
*** b0b has quit IRC
|
08:05:04
|
*** b0b has joined #openmrs
|
08:12:05
|
*** r0bby has joined #openmrs
|
08:12:05
|
*** ChanServ sets mode: +v r0bby
|
08:15:23
|
*** robbyoconnor has quit IRC
|
08:23:50
|
*** GitHub155 has joined #openmrs
|
08:23:50
|
<GitHub155> [openmrs-core] k-joseph opened pull request #364: TRUNK-3624 (master...TRUNK-3624) http://git.io/VsClVA
|
08:23:50
|
*** GitHub155 has left #openmrs
|
08:39:40
|
*** shrewduh has quit IRC
|
08:46:37
|
*** dkayiwa has joined #openmrs
|
08:47:57
|
*** akwatuha__ has quit IRC
|
08:56:05
|
*** harshadura has joined #openmrs
|
08:56:05
|
*** ChanServ sets mode: +v harshadura
|
08:56:28
|
*** harshadura has quit IRC
|
09:03:29
|
*** r0bby is now known as robbyoconnor
|
09:04:06
|
*** ruwanego__ has joined #openmrs
|
09:07:17
|
*** harshadura has joined #openmrs
|
09:07:57
|
<harshadura> hi dkayiwa
|
09:08:03
|
<dkayiwa> harshadura: hi
|
09:09:52
|
<harshadura> dkayiwa: i developed the AOP adviser and added it inside <advice> tag of config.xml -- but it doesnt work, could pls review my code ?
|
09:10:14
|
<dkayiwa> harshadura: for which service?
|
09:10:28
|
<harshadura> dkayiwa: EncounterService
|
09:10:39
|
<dkayiwa> harshadura: let me look at the commit
|
09:10:48
|
<harshadura> ok dkayiwa
|
09:10:58
|
<harshadura> i will commit the code now
|
09:16:15
|
<harshadura> dkayiwa: here is the commit : https://github.com/harshadura/openmrs-module-patientnarratives/commit/d3c88f70452d5625e7ef33c5632bd1f7a7392c59
|
09:16:23
|
<OpenMRSBot> <http://ln-s.net/-V51> (at github.com)
|
09:16:25
|
*** k-joseph has quit IRC
|
09:16:28
|
<dkayiwa> harshadura: ok
|
09:18:00
|
<harshadura> dkayiwa: currently the problem is when i run the code it doesn't bypass the creator field as expected. (seems like the Adviser doesnt start)
|
09:18:25
|
<dkayiwa> harshadura: does it even execute your AOP code?
|
09:18:50
|
<harshadura> no dkayiwa: i added a log but it doesnt show that even
|
09:19:38
|
<dkayiwa> harshadura: did you try run in debug mode?
|
09:20:03
|
<harshadura> no dkayiwa
|
09:20:24
|
<dkayiwa> harshadura: can you run in debug mode and see if before() is being called?
|
09:20:45
|
<harshadura> ok dkayiwa
|
09:21:46
|
<harshadura> dkayiwa: do i need to mention the adviser in application context xml? the example i followed didn had mentioned there though
|
09:22:37
|
<dkayiwa> harshadura: do only what the wiki says
|
09:22:49
|
<harshadura> ok dkayiwa
|
09:45:24
|
*** shrewduh has joined #openmrs
|
10:08:43
|
*** rafa has joined #openmrs
|
10:08:43
|
*** ChanServ sets mode: +v rafa
|
10:31:36
|
<harshadura> dkayiwa: do i need to write unit test case to debug a openmrs module ?
|
10:32:30
|
<dkayiwa> harshadura: it is always easier to debug a unit test. But you do not have to :)
|
10:33:07
|
<harshadura> dkayiwa: whats the IDE you use ?
|
10:33:09
|
*** dkayiwa has quit IRC
|
10:34:14
|
<harshadura> hi rafa
|
10:34:39
|
<harshadura> rafa: do you use intellij remote debugging?
|
10:40:31
|
*** dkayiwa has joined #openmrs
|
10:40:43
|
<dkayiwa> harshadura: i use eclipse
|
10:41:04
|
<dkayiwa> harshadura: it is very easy to debug a module in openmrs :)
|
10:41:30
|
<harshadura> dkayiwa: can you teach me, i have been searching long time.
|
10:42:02
|
<dkayiwa> harshadura: which IDE are you using?
|
10:42:13
|
<harshadura> dkayiwa: i use Intellij
|
10:42:24
|
<harshadura> but i have eclipse also
|
10:42:33
|
<dkayiwa> harshadura: and which version of openmrs you running?
|
10:42:53
|
<harshadura> dkayiwa: 1.9.3
|
10:43:10
|
*** akwatuha__ has joined #openmrs
|
10:43:31
|
<dkayiwa> harshadura: is that the standalone version?
|
10:43:42
|
<harshadura> no dkayiwa, the war
|
10:44:07
|
<dkayiwa> harshadura: can you first of all run openmrs from the IDE?
|
10:44:25
|
<harshadura> you mean the openmrs core dkayiwa ?
|
10:44:35
|
<dkayiwa> harshadura: any version you want
|
10:45:07
|
<harshadura> dkayiwa: i mean do i need to run openmrs core repo through a IDE ?
|
10:45:21
|
<dkayiwa> harshadura: any version of openmts
|
10:45:33
|
<harshadura> dkayiwa: i have already did that, its running now
|
10:45:40
|
<dkayiwa> harshadura: which version
|
10:45:42
|
<harshadura> remote debugging tomcat server with intellig
|
10:45:47
|
<harshadura> sorry intelliJ
|
10:45:56
|
<harshadura> 1.9.3 dkayiwa
|
10:46:17
|
<dkayiwa> harshadura: does your IDE have a Debug As option?
|
10:46:24
|
<harshadura> yes dkayiwa
|
10:46:42
|
<harshadura> dkayiwa: shall i switch to eclipse ?
|
10:47:01
|
<dkayiwa> harshadura: just use whichever IDE you can use debugging
|
10:47:21
|
<harshadura> ok dkayiwa: i can use this
|
10:47:59
|
<harshadura> dkayiwa: what should i do next
|
10:48:37
|
<dkayiwa> harshadura: put a break point anywhere and see if you can hit it
|
10:49:35
|
<harshadura> dkayiwa: you mean in module project dkayiwa
|
10:50:15
|
<dkayiwa> harshadura: start right in openmrs
|
10:51:37
|
*** wyclif has joined #openmrs
|
11:16:17
|
*** dkayiwa_ has joined #openmrs
|
11:16:38
|
*** dkayiwa has quit IRC
|
11:16:39
|
*** dkayiwa_ is now known as dkayiwa
|
11:21:46
|
*** k-joseph has joined #openmrs
|
11:22:27
|
*** wyclif has quit IRC
|
11:43:21
|
*** nano1 has quit IRC
|
11:43:26
|
*** nano has joined #openmrs
|
12:03:26
|
*** harshadura has quit IRC
|
12:16:11
|
*** harshadura has joined #openmrs
|
12:18:06
|
*** harshadura has quit IRC
|
12:18:18
|
*** harshadura has joined #openmrs
|
12:19:17
|
*** akwatuha__ is now known as akwatuha
|
12:20:46
|
*** evmw has quit IRC
|
12:33:09
|
*** maninc has quit IRC
|
12:35:31
|
*** nano has quit IRC
|
12:39:17
|
*** evmw has joined #openmrs
|
12:39:17
|
*** ChanServ sets mode: +v evmw
|
12:42:03
|
<harshadura> hi dkayiwa: i was able to remote debug openmrs core :)
|
12:42:13
|
<harshadura> dkayiwa: can you tell me how to debug my module now
|
12:42:13
|
<dkayiwa> harshadura: oh cool :)
|
12:42:25
|
<dkayiwa> just put a break point in the module :0
|
12:42:26
|
<dkayiwa> :)
|
12:42:48
|
<harshadura> but dkayiwa: thats a separate project nah
|
12:42:51
|
<dkayiwa> harshadura: am assuming you are using jetty:run
|
12:42:56
|
<harshadura> yes dkayiwa
|
12:43:04
|
<harshadura> i use jetty now
|
12:43:13
|
<dkayiwa> harshadura: just put a break point in your module and debug
|
12:43:28
|
<harshadura> ok dkayiwa
|
12:46:26
|
<harshadura> dkayiwa: thanks lot, it works :)
|
12:46:59
|
<dkayiwa> harshadura: good :)
|
12:49:05
|
<harshadura> dkayiwa: before method is not getting called, i debugged :)
|
12:49:33
|
* harshadura back to the right track xD
|
12:52:07
|
<dkayiwa> harshadura: are you sure you are using the right module?
|
12:52:24
|
<harshadura> yes dkayiwa
|
12:53:38
|
<dkayiwa> harshadura: which version of openmrs
|
12:53:48
|
<harshadura> dkayiwa: 1.9.3
|
12:54:17
|
<dkayiwa> harshadura: send me the module
|
12:55:10
|
<harshadura> dkayiwa: sorry it got hit now
|
12:56:24
|
<dkayiwa> harshadura: i knew :D
|
12:57:03
|
<harshadura> dkayiwa: it says args[0] = java.lang.IndexOutOfBoundsException : Invalid array range: 0 to 0
|
12:57:15
|
<harshadura> but saveEncounter method has 1 arg
|
12:58:43
|
*** achint has joined #openmrs
|
12:59:05
|
*** nano has joined #openmrs
|
12:59:49
|
<harshadura> dkayiwa: something like this: Context.getEncounterService().saveEncounter(encounter);
|
13:01:46
|
<dkayiwa> harshadura: check again to confirm
|
13:12:57
|
<harshadura> dkayiwa: i checked, but still the same problem
|
13:13:09
|
<dkayiwa> harshadura: of?
|
13:13:18
|
<harshadura> dkayiwa: java.lang.IndexOutOfBoundsException : Invalid array range: 0 to 0
|
13:13:19
|
<dkayiwa> harshadura: which problem?
|
13:13:51
|
*** mogoodrich has joined #openmrs
|
13:14:20
|
<harshadura> dkayiwa: java.lang.IndexOutOfBoundsException : Invalid array range: 0 to 0
|
13:15:51
|
<dkayiwa> harshadura: can you try using? implements MethodInterceptor
|
13:16:17
|
<harshadura> ok dkayiwa
|
13:17:11
|
*** djazayeri has joined #openmrs
|
13:17:11
|
*** ChanServ sets mode: +o djazayeri
|
13:20:53
|
<rafa> djazayeri: how to enable a feature in ref app?
|
13:21:18
|
<rafa> djazayeri: I need to enable noActiveVisitView.
|
13:21:23
|
<harshadura> dkayiwa: did you mean, should i use a Around AOP ?
|
13:21:26
|
<djazayeri> rafa: ah, right
|
13:21:59
|
<djazayeri> rafa: https://minglehosting.thoughtworks.com/unicef/projects/pih_mirebalais/wiki/How_to_use_Feature_Toggles_as_a_developer
|
13:22:04
|
<OpenMRSBot> <http://ln-s.net/-V$x> (at minglehosting.thoughtworks.com)
|
13:22:18
|
<djazayeri> rafa: can you copy the relevant parts of the info from there to an OpenMRS wiki page?
|
13:22:22
|
<dkayiwa> harshadura: yes if the other one gives you trouble
|
13:22:28
|
<rafa> djazayeri: ok
|
13:22:31
|
<harshadura> ok dkayiwa
|
13:22:32
|
<djazayeri> rafa: in this particular case, I think we should be removing that feature toggle, since things are broken when it's off.
|
13:22:32
|
<rafa> djazayeri: thanks
|
13:22:42
|
<rafa> djazayeri: I agree
|
13:22:55
|
<djazayeri> rafa: but I wanted to show you the docs anyway...
|
13:23:24
|
<djazayeri> rafa: if you want to remove it, that's cool
|
13:23:47
|
*** nano has quit IRC
|
13:23:52
|
<rafa> djazayeri: Yes, I'll remove it and add a wiki
|
13:24:16
|
*** cospih has quit IRC
|
13:24:55
|
*** harsz89 has joined #openmrs
|
13:24:55
|
*** ChanServ sets mode: +v harsz89
|
13:25:46
|
*** cospih has joined #openmrs
|
13:26:24
|
*** wyclif has joined #openmrs
|
13:26:35
|
<djazayeri> rafa, achint: I have a meeting now in Boston. I'm going to miss standup. My report is that I have done nothing, but will have a few comments about the registration app, and at PIH we want to get that finished off an into production.
|
13:27:14
|
<achint> djazayeri: Is it validations or autosuggest?
|
13:27:17
|
*** djazayeri has quit IRC
|
13:29:54
|
*** nano has joined #openmrs
|
13:30:47
|
*** mogoodrich has quit IRC
|
13:32:36
|
<achint> wyclif: standup
|
13:46:59
|
*** shrewduh has quit IRC
|
13:47:45
|
*** k-joseph has quit IRC
|
13:48:08
|
*** k-joseph has joined #openmrs
|
13:48:22
|
*** jordank has joined #openmrs
|
14:01:14
|
<jkeiper> btw ppl, great job on curating tickets. only two in the queue this week!
|
14:03:12
|
<cpower> And now let us scrum!
|
14:03:16
|
<cpower> !scrumon cpower
|
14:03:16
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
14:03:57
|
<cpower> Order: jkeiper , dkayiwa , wyclif and anyone else
|
14:04:32
|
*** mogoodrich has joined #openmrs
|
14:04:50
|
<mogoodrich> sorry, did i miss scrum?
|
14:05:36
|
<dkayiwa> jkeiper: are you sure two not one??? :)
|
14:06:29
|
<mogoodrich> dkayiwa: jkeiper sorry, if the was a question for me, i missed it...
|
14:07:02
|
<cpower> mogoodrich: nope justs starting
|
14:07:10
|
<cpower> jkeiper: you are up
|
14:07:13
|
<mogoodrich> cpower: cool, thanks!
|
14:08:41
|
<cpower> ok while we wait for jkeiper
|
14:08:44
|
<cpower> dkayiwa:
|
14:09:01
|
<dkayiwa> Committed: Non-Javascript solution to apply validations between answers of two or more questions - XFRM-72
|
14:09:02
|
<dkayiwa> Now working on: Include Relationship Widget in XForms Designer - XFRM-16
|
14:09:02
|
<dkayiwa> No Blockers
|
14:09:12
|
<wyclif> Tuesday:
|
14:09:12
|
<wyclif> -Review TODO for RA-82 - Registration screen navigation bar re-ordered
|
14:09:14
|
<wyclif> -RA-129 - Find Patient Record app
|
14:09:15
|
<wyclif> Wednesday:
|
14:09:17
|
<wyclif> -TODOs for reviewed tickets
|
14:09:18
|
<wyclif> -design call
|
14:09:19
|
<wyclif> -Pick up a new a ticket possibly RA-101
|
14:09:20
|
<wyclif> Blockers: None
|
14:09:56
|
<cpower> wyclif: How's the REST bamboo failures?
|
14:10:03
|
<jkeiper> HTML-50 (still) ... hopefully more when I get that straightened out
|
14:10:05
|
<jkeiper> the end.
|
14:10:16
|
<cpower> wyclif: saw a lot of failed tests last night
|
14:10:27
|
<cpower> jkeiper: thanks ;-)
|
14:10:48
|
*** jordank has quit IRC
|
14:10:53
|
<rafa> Today:
|
14:10:53
|
<rafa> * Continued working on RA-76
|
14:10:53
|
<rafa> Issues still seen with Registration (Customized by RefApp)
|
14:10:53
|
<rafa> https://tickets.openmrs.org/browse/RA-76
|
14:10:53
|
<rafa> * University Call
|
14:10:53
|
<rafa> * Will pick another ticket
|
14:10:53
|
<rafa> * Design Call
|
14:10:54
|
<wyclif> cpower: seems like there is a missing library on bamboo
|
14:10:54
|
<rafa> No blockers.
|
14:11:08
|
<mogoodrich> jkeiper: is it as big a mess as i feared? :)
|
14:11:31
|
<cpower> wyclif: is that something breeze needs to fix or one of us?
|
14:11:46
|
<wyclif> i was hoping to talk to breeze
|
14:11:53
|
<cpower> wyclif: ok
|
14:13:25
|
<achint> wyclif: I can't get through the phone number screen anymore on devtest01. I was able to 30 mins back
|
14:13:28
|
<cpower> Ok big day for meetings. PM Call today, Design Call Today (still looking for topics for future work) keep it up
|
14:13:43
|
<cpower> !scrumoff
|
14:13:43
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:14:05
|
<downey> wyclif or cpower: where can i read about this "REST bamboo failure"?
|
14:14:38
|
<cpower> downey: bamboo email I'll forward it to you
|
14:15:22
|
<downey> cpower: ah ok that one
|
14:15:28
|
*** nano has quit IRC
|
14:15:33
|
*** djazayeri has joined #openmrs
|
14:15:33
|
*** ChanServ sets mode: +o djazayeri
|
14:15:45
|
*** nano has joined #openmrs
|
14:17:19
|
*** nano has quit IRC
|
14:18:04
|
*** nano has joined #openmrs
|
14:18:14
|
*** jordank has joined #openmrs
|
14:18:45
|
<wyclif> achint: am able to
|
14:20:46
|
<wyclif> achint: ?
|
14:22:25
|
<djazayeri> achint: I didn't see your question earlier about validations vs autosuggest, but I also don't know what it means?
|
14:23:56
|
<achint> wyclif: I'll check again
|
14:24:43
|
<achint> djazayeri: You mentioned you have some comments about registration - I was asking if they are about autosuggest and validations ?
|
14:25:05
|
<djazayeri> achint: generally we noticed some issues about registration
|
14:26:15
|
<djazayeri> achint: the name fields still show "Auto Suggest" as a placeholder which is wrong behavior in general, and even more wrong if nothing is configured to autosuggest.
|
14:27:57
|
<djazayeri> achint: on birthdate, the month dropdown doesn't really behave that well with the keyboard navigation (at least not in chrome on osx) as far as pressing a couple of keys then enter
|
14:28:19
|
<djazayeri> achint: (some of these are probably existing tickets)
|
14:28:45
|
<djazayeri> achint: the the radio button for choosing gender is ugly. We either need to make it look nicer (and work better with keyboard nav), or else just change it to <select>
|
14:29:03
|
<djazayeri> achint: address still needs to not have latitude/longitude/start date/end date
|
14:29:10
|
<achint> djazayeri: yes, you are right.
|
14:29:46
|
<achint> djazayeri: I have not noticed the birthdate in chrome, will check it out now.. I was able to go through the birth date just fine, maybe it was safari then
|
14:30:03
|
<djazayeri> achint: on the "Confirm Submission" page the Yes/No options should be in the other order (i.e. elsewhere, and in the style guide, we should have the confirm/submit on the right)
|
14:30:36
|
<achint> djazayeri: Did we change Address validations to be required for any 1 of the address fields ?
|
14:31:07
|
<djazayeri> achint: it seems like someone implemented that. I'm undecided about whether it's the correct behavior, but it seems intentional, so I'm fine with it for now.
|
14:31:19
|
<achint> djazayeri: ok
|
14:33:37
|
*** rnjn has quit IRC
|
14:37:51
|
*** NameFILIP has quit IRC
|
14:39:15
|
<wyclif> hi djazayeri
|
14:41:19
|
<djazayeri> wyclif: hi
|
14:44:49
|
*** rafa has quit IRC
|
14:44:51
|
<wyclif> djazayeri: i picked up https://tickets.openmrs.org/browse/RA-88
|
14:45:21
|
<harshadura> hi dkayiwa
|
14:45:30
|
<wyclif> djazayeri: for the pharmacist role, i plan to add these privileges View Orders,Edit Orders,Add Orders
|
14:45:37
|
<dkayiwa> harshadura: hi
|
14:45:45
|
<wyclif> djazayeri: anything else you may know?
|
14:46:31
|
<djazayeri> wyclif: actually I think we need to be granting all of the API level privileges, and only a single Application-level privilege for the dispensing app
|
14:47:04
|
<harshadura> dkayiwa: the around AOP work pretty good. but seems like the encounter.setCreator(user); line is not getting saved to the argument before the
|
14:47:27
|
<djazayeri> wyclif: somewhere in the mirebalais code (and hopefully this has been moved to the emrapi module) there's a mechanism that creates/updates a role with all API-level privileges
|
14:47:56
|
<djazayeri> wyclif: actually, the Provider role would only have application-level privileges, in this case just one.
|
14:48:16
|
<harshadura> dkayiwa: when debug i can see the encounter: creator field is bypassed with my new value
|
14:48:44
|
<dkayiwa> harshadura: but you said its null
|
14:48:56
|
<harshadura> dkayiwa: but the error still exist: In method EncounterService.saveEncounter. Arguments: Encounter=Encounter
|
14:49:05
|
<djazayeri> wyclif: do you have access to the new server?
|
14:49:16
|
<wyclif> djazayeri: do you are saying the role will have all API levels for the OrderService or all services?
|
14:49:19
|
<djazayeri> wyclif: and actually are you saying that all the registration stories are complete?
|
14:49:32
|
<dkayiwa> harshadura: can i look at your AOP class?
|
14:49:39
|
<harshadura> dkayiwa: yes it was with the "before AOP" now it works
|
14:49:41
|
<djazayeri> wyclif: recall that the overarching goal is to get registration completely done
|
14:49:46
|
*** harsz89 has quit IRC
|
14:49:48
|
<djazayeri> wyclif: and _then_ move on
|
14:49:52
|
<djazayeri> wyclif: to dispensing
|
14:50:30
|
<djazayeri> wyclif: can you pick a registration ticket first?
|
14:51:57
|
<harshadura> dkayiwa: http://pastebin.com/zm98u5dd
|
14:52:14
|
<dkayiwa> harshadura: but you said it works
|
14:52:42
|
<harshadura> dkayiwa: didn got you ?
|
14:53:04
|
<wyclif> dkayiwa: can you review https://tickets.openmrs.org/browse/TRUNK-2472
|
14:53:10
|
<dkayiwa> harshadura: what you just typed above
|
14:53:22
|
<dkayiwa> wyclif: ok
|
14:53:39
|
<wyclif> dkayiwa: you had commented that i was going to review it but am not in the dev swim lane yet
|
14:54:31
|
<dkayiwa> wyclif: ok
|
14:56:30
|
<harshadura> dkayiwa: the previous problem was with "before AOP" method argument 1 --saveEncounter(enc) << was null -- i mean with "Around AOP" the argument null problem went away , now the AOP problem is solved but the creator field isnt getting set to encounter even after the invocation.proceed
|
14:57:27
|
<harshadura> sorry for the confusion dkayiwa :)
|
14:59:32
|
<dkayiwa> harshadura: ok
|
14:59:55
|
<dkayiwa> harshadura: i will be right back
|
15:00:10
|
<harshadura> ok dkayiwa
|
15:01:26
|
*** harsz89 has joined #openmrs
|
15:01:26
|
*** ChanServ sets mode: +v harsz89
|
15:05:28
|
*** rafa has joined #openmrs
|
15:05:28
|
*** ChanServ sets mode: +v rafa
|
15:05:55
|
*** rcrichton has quit IRC
|
15:06:14
|
*** dkayiwa has quit IRC
|
15:10:22
|
*** jordank has quit IRC
|
15:10:23
|
*** cospih has quit IRC
|
15:11:40
|
*** shrewduh has joined #openmrs
|
15:13:15
|
*** cospih has joined #openmrs
|
15:16:23
|
*** NameFILIP has joined #openmrs
|
15:16:24
|
*** ChanServ sets mode: +v NameFILIP
|
15:20:57
|
*** jordank has joined #openmrs
|
15:21:54
|
<wyclif> hi achint
|
15:22:22
|
<wyclif> achint: i wanted to work on RA-133 so that RA-69 can get closed
|
15:22:36
|
<wyclif> djazayeri: do you agree with RA-133?
|
15:23:40
|
<wyclif> achint: i know it is not yet marked as ready for dev
|
15:24:52
|
*** NameFILIP has quit IRC
|
15:25:17
|
<achint> wyclif: RA-77 is also not test successful. Can you work on that?
|
15:25:29
|
<achint> There is no autosuggest for our fields
|
15:30:18
|
<jkeiper> hah, i posted mine then went away
|
15:30:19
|
<jkeiper> sry
|
15:30:30
|
<jkeiper> mogoodrich: i'm back, and i just didn't get through all the code and comments yet
|
15:30:35
|
* jkeiper is bad at split-brain
|
15:32:06
|
<harsz89> hi jkeiper
|
15:32:16
|
<harsz89> quick question :)
|
15:32:56
|
<harsz89> harsz89, can I hv few mins?
|
15:33:25
|
<harsz89> jkeiper, oopz msg redirect to me :D can I hv few mins?
|
15:34:02
|
<jkeiper> harsz89: sure
|
15:34:26
|
<harsz89> jkeiper, in check summary tab
|
15:34:55
|
<harsz89> jkeiper, i'm going to add assignee vise record allocations and
|
15:35:07
|
<harsz89> jkeiper, stage base record summary
|
15:35:30
|
<harsz89> jkeiper, do you hav any additional options to add in the summary view?
|
15:35:47
|
<jkeiper> not at this time, perhaps after seeing it
|
15:35:47
|
<jkeiper> :-)
|
15:36:44
|
<harsz89> jkeiper, okey jkeiper
|
15:37:05
|
<jkeiper> harsz89: how do you like the work you are doing?
|
15:37:05
|
<harsz89> jkeiper, i did the changes according to your feedback
|
15:37:06
|
<jkeiper> ;-)
|
15:37:46
|
<harsz89> jkeiper, once I finish I'll let you know with the screenshots :)
|
15:37:54
|
<harsz89> jkeiper, then we can improve it :D
|
15:38:06
|
<harshadura> hi wyclif
|
15:38:10
|
<jkeiper> haha ok
|
15:38:20
|
* jkeiper needs a food truck to come through his subdivision
|
15:38:21
|
<wyclif> hi harshadura
|
15:38:28
|
<harsz89> jkeiper, :D
|
15:39:01
|
<harshadura> wyclif: is it possible to overwrite an argument of a method using Spring AOP ?
|
15:39:31
|
<harshadura> wyclif: i checked a lot but didn found
|
15:40:17
|
<harsz89> jkeiper, starving? food truck is too much let's share it equally :D
|
15:40:31
|
<jkeiper> harshadura: that's exactly what BeforeAdvice is for
|
15:40:42
|
<jkeiper> harsz89: here, a food truck is a restaurant on wheels
|
15:41:01
|
<jkeiper> harsz89: i would only buy a single meal ;-)
|
15:41:04
|
<jkeiper> (perhaps)
|
15:41:12
|
<harsz89> jkeiper, haha
|
15:41:48
|
<harsz89> jkeiper, we also having such food trucks
|
15:41:50
|
*** djazayeri has quit IRC
|
15:41:56
|
<wyclif> harshadura: i haven't done that before
|
15:42:10
|
<wyclif> harshadura why would want to do that
|
15:42:28
|
<harshadura> wyclif: something similar to this in Aspectj: but i want to do it with our openmrs aop classes: http://stackoverflow.com/questions/4312224/aspectj-overwrite-an-argument-of-a-method
|
15:42:31
|
<OpenMRSBot> <http://ln-s.net/-VAE> (at stackoverflow.com)
|
15:42:50
|
<harshadura> wyclif: i tried before and around aops
|
15:43:11
|
<wyclif> harshadura: why would you want to override it
|
15:43:57
|
<harshadura> dkayiwa: in my module i need to bypass "authenticated user" fields in anonymous mode
|
15:44:04
|
<harshadura> sorry wyclif
|
15:44:14
|
<harshadura> wyclif: in my module i need to bypass "authenticated user" fields in anonymous mode
|
15:44:50
|
<harsz89> jkeiper, actually those walking restaurants passing trough my home early in d morning and dont let me sleep :D
|
15:45:42
|
<harshadura> wyclif: so for that i have AOPed around "encounter service", To overwrite the "creator" field i need to do this
|
15:45:51
|
*** mogoodrich has quit IRC
|
15:47:03
|
<wyclif> harshadura: what exactly are you trying to do, because there could be better ways to handle it
|
15:49:57
|
<harshadura> wyclif: can you have a look at this code: http://pastebin.com/bRAeBca0
|
15:51:26
|
<harshadura> wyclif: in line number 83 method is getting called but its not without the changes done within line 80, 81
|
15:52:57
|
<wyclif> harshadura: i mean what are you trying to achieve in theory/wording
|
15:55:28
|
<harshadura> wyclif: i have embedded HTML form into my module, so within the module users can fill and submit html forms. even for anonymous users. (the openmrs will be hosted publicly), the problem is the module works fine with authenticated users, but for anonymous ones (who have not logged in) gives some errors
|
15:56:18
|
<harshadura> wyclif: this is the log : http://pastebin.com/gT57AQUS
|
15:57:03
|
<harshadura> wyclif: kind of a long story thats why i didn told :)
|
15:57:21
|
<harshadura> dkayiwa adviced me to do in this way
|
15:58:09
|
<harshadura> to hijack the encounter service class using around aop :)
|
15:58:16
|
*** rcrichton has joined #openmrs
|
15:58:24
|
<wyclif> harshadura: so you want to set the creator field, right?
|
15:58:32
|
<harshadura> yes wyclif
|
15:58:44
|
*** rcrichton has quit IRC
|
15:59:02
|
<wyclif> harshadura: and what do you want to set the creator to?
|
15:59:41
|
<harshadura> wyclif: for some actual value: lets say : userid = 1
|
16:00:21
|
<wyclif> harshadura: can't just use the setter?
|
16:02:51
|
<wyclif> harshadura: why use AOP when you can call encounter.setCreatedBy(Context.getUserService().getUser(1))
|
16:05:07
|
<harshadura> wyclif: how to access the setter, i m not handling the HTML forms, im just passing it to html form entry module
|
16:08:13
|
<wyclif> harshadura: well that is the bit i don't understand
|
16:08:23
|
<wyclif> harshadura: who is creating the encounter?
|
16:09:09
|
<harshadura> wyclif: html form entry module does that
|
16:09:31
|
<wyclif> harshadura: whoever is creating the encounter in a non authenticated thread, is responsible to set the creator
|
16:10:11
|
<harshadura> yes wyclif
|
16:10:30
|
*** isaac_ has joined #openmrs
|
16:10:55
|
<wyclif> harshadura: so the problem is that you are doing stuff in a none authenticated thread, right?
|
16:11:07
|
<harshadura> exactly wyclif
|
16:11:12
|
<harshadura> thats the main problem
|
16:11:14
|
<wyclif> harshadura: then that is the porblem
|
16:11:44
|
<harshadura> i have given all the privileges to the anonymous just for now
|
16:11:46
|
<wyclif> harshadura such things have to be done in a Daemon thread
|
16:12:14
|
<harshadura> wyclif: sounds interesting :)
|
16:12:18
|
<wyclif> harshadura: which is the minimum version if opemrs you will be supporting
|
16:12:56
|
<harshadura> wyclif: may be 1.8
|
16:13:16
|
<harshadura> wyclif: no that kind of requirement actually
|
16:14:43
|
<wyclif> harshadura: you need to know because DaemonThread is not available in all versions
|
16:15:16
|
<harshadura> its ok wyclif
|
16:15:20
|
<wyclif> harshadura: might have been added in 1.7
|
16:15:30
|
<wyclif> harshadura: the point is that use that instead
|
16:16:05
|
<harshadura> wyclif: do you have any sample implementation which uses that
|
16:16:11
|
<wyclif> harshadura: so in the creator will be Daemon instead is user with id 1 which is even better
|
16:17:23
|
<wyclif> harshadura: this is why i need to know the required openers version
|
16:17:31
|
<harshadura> got it wyclif
|
16:17:34
|
<wyclif> harshadura: are you writing a module?
|
16:17:39
|
<harshadura> yes wyclif
|
16:17:51
|
<wyclif> what is the required openers version?
|
16:17:53
|
*** isaac_ has quit IRC
|
16:18:36
|
<harshadura> wyclif: let say 1.9.3
|
16:18:50
|
*** breeze has joined #openmrs
|
16:19:38
|
<wyclif> harshadura: you meant you don't know?
|
16:20:14
|
<wyclif> harshadura: it is something you have to define in your config.xml file as as must
|
16:21:22
|
*** NameFILIP has joined #openmrs
|
16:21:22
|
*** ChanServ sets mode: +v NameFILIP
|
16:21:33
|
<harshadura> wyclif: sorry. i mean, i dont have a min supported version yet: 1.9.3 is the one which is defined in config.xml
|
16:21:35
|
<wyclif> harshadura: anyways just find DaemonThread in core openers and find references to DaemonThread
|
16:21:50
|
<breeze> rafa: hi
|
16:22:15
|
<harshadura> ok wyclif, thank you for the help
|
16:22:19
|
<wyclif> harshadura: probably the Listener in the web layer is using it
|
16:23:18
|
<harshadura> ok wyclif, i will try that
|
16:23:21
|
<wyclif> harshadura: or you could use the old Context.addProxyprivilege and Context.removeProxyPrivilege calls around your code
|
16:24:27
|
*** wyclif has quit IRC
|
16:24:28
|
<rafa> breeze: hi
|
16:24:43
|
<harshadura> wyclif, i have given all the privileges to the anonymous, so that does the same right?
|
16:25:15
|
<harshadura> wyclif: i mean using the openmrs admin panel > roles section
|
16:25:43
|
* harshadura wyclif quit ;)
|
16:26:14
|
*** NameFILIP has quit IRC
|
16:27:54
|
<breeze> rafa: you were right about that column being missing from the orders table. I will rerun the db setup at some point today
|
16:28:06
|
<breeze> rafa: but are you blocked or anything by that right now?
|
16:29:11
|
*** mogoodrich has joined #openmrs
|
16:29:17
|
<rafa> breeze: no
|
16:29:40
|
<rafa> breeze: not right now
|
16:29:52
|
<breeze> rafa: ok good. I want to enable remote access so I'll do that first.
|
16:30:45
|
*** rday has quit IRC
|
16:30:52
|
*** jordank has quit IRC
|
16:33:26
|
*** djazayeri has joined #openmrs
|
16:33:27
|
*** ChanServ sets mode: +o djazayeri
|
16:33:34
|
*** isaac_ has joined #openmrs
|
16:33:56
|
*** isaac_ has joined #openmrs
|
16:35:35
|
*** djazayeri1 has joined #openmrs
|
16:35:35
|
*** djazayeri has quit IRC
|
16:35:49
|
*** mogoodrich has quit IRC
|
16:36:52
|
*** cospih_ has joined #openmrs
|
16:37:21
|
*** achint has left #openmrs
|
16:37:49
|
*** isaac_ has quit IRC
|
16:37:50
|
*** djazayeri1 has quit IRC
|
16:37:52
|
*** cospih has quit IRC
|
16:39:12
|
*** djazayeri1 has joined #openmrs
|
16:43:50
|
*** bhashitha has joined #openmrs
|
16:43:53
|
*** jordank has joined #openmrs
|
16:46:42
|
*** djazayeri has joined #openmrs
|
16:46:42
|
*** ChanServ sets mode: +o djazayeri
|
16:47:56
|
*** wyclif has joined #openmrs
|
16:48:13
|
*** djazayeri1 has quit IRC
|
16:48:32
|
*** harshadura has quit IRC
|
16:58:38
|
*** mogoodrich has joined #openmrs
|
17:03:42
|
*** cospih has joined #openmrs
|
17:04:44
|
*** mogoodrich has quit IRC
|
17:05:29
|
*** cospih_ has quit IRC
|
17:11:03
|
*** achint has joined #openmrs
|
17:14:13
|
*** nano has quit IRC
|
17:14:27
|
<achint> cpower: https://wiki.openmrs.org/display/projects/Reference+Application+Road+Map . the soft line is drawn at vital signs capture
|
17:14:37
|
*** nano has joined #openmrs
|
17:15:25
|
*** rday has joined #openmrs
|
17:20:13
|
*** shrewduh has quit IRC
|
17:21:52
|
*** NameFILIP has joined #openmrs
|
17:21:52
|
*** ChanServ sets mode: +v NameFILIP
|
17:25:35
|
*** rafa has quit IRC
|
17:26:14
|
*** NameFILIP has quit IRC
|
17:30:08
|
*** jordank has quit IRC
|
17:32:31
|
*** jordank has joined #openmrs
|
17:42:16
|
*** NameFILIP has joined #openmrs
|
17:42:16
|
*** ChanServ sets mode: +v NameFILIP
|
17:52:20
|
*** harshadura has joined #openmrs
|
17:52:20
|
*** ChanServ sets mode: +v harshadura
|
17:52:48
|
*** mogoodrich has joined #openmrs
|
17:53:08
|
*** harshadura has quit IRC
|
17:59:29
|
*** rafa has joined #openmrs
|
17:59:29
|
*** ChanServ sets mode: +v rafa
|
17:59:38
|
*** nano has quit IRC
|
17:59:55
|
*** jordank has quit IRC
|
18:00:28
|
*** nano has joined #openmrs
|
18:02:52
|
*** dkayiwa has joined #openmrs
|
18:08:11
|
*** rday has quit IRC
|
18:09:32
|
*** nano has quit IRC
|
18:09:33
|
*** nano1 has joined #openmrs
|
18:12:24
|
*** dkayiwa_ has joined #openmrs
|
18:15:19
|
*** dkayiwa has quit IRC
|
18:15:19
|
*** dkayiwa_ is now known as dkayiwa
|
18:17:33
|
*** davidpardz has left #openmrs
|
18:20:33
|
*** harshadura has joined #openmrs
|
18:20:33
|
*** ChanServ sets mode: +v harshadura
|
18:20:42
|
*** harshadura has quit IRC
|
18:21:34
|
*** jordank has joined #openmrs
|
18:24:17
|
*** harshadura has joined #openmrs
|
18:24:38
|
<harshadura> hi dkayiwa
|
18:25:08
|
<dkayiwa> harshadura: hi
|
18:26:53
|
<harshadura> dkayiwa: i found the issue, seems like the AOP isn't overwrite the method argument
|
18:28:19
|
*** rday has joined #openmrs
|
18:31:06
|
*** harshadura has quit IRC
|
18:32:51
|
*** sgithens has joined #openmrs
|
18:32:59
|
<k-joseph> dkayiwa: hi
|
18:33:29
|
<dkayiwa> k-joseph: hi
|
18:34:06
|
<k-joseph> dkayiwa: working on TRUNK-3850, and i request for some few secs from you to assist me a bit
|
18:34:21
|
*** Mkop1 has joined #openmrs
|
18:34:44
|
*** cospih_ has joined #openmrs
|
18:35:35
|
*** cospih has quit IRC
|
18:36:02
|
<dkayiwa> !ticket TRUNK-3850
|
18:36:03
|
<OpenMRSBot> dkayiwa: [#TRUNK-3850] Program validator is inefficient when checking for duplicates - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3850
|
18:36:08
|
*** harshadura has joined #openmrs
|
18:44:33
|
*** harshadura has quit IRC
|
18:45:42
|
<k-joseph> dkayiwa: hi
|
18:45:50
|
<dkayiwa> k-joseph: hi
|
18:46:32
|
<k-joseph> dkayiwa: i had made some changes in the validate() as can be seen at http://pastebin.com/2rZb2EL9, please have a look at that, however, that resulted into an exception in programvalidatortest.validate_ methods, here is the failure trace, http://pastebin.com/TytK5vGZ, i guess the issue is in my code!!!
|
18:47:31
|
<dkayiwa> k-joseph: do an mvn clean install
|
18:48:24
|
<dkayiwa> k-joseph: do you have any compiler errors?
|
18:49:05
|
<dkayiwa> k-joseph: before you do an mvn clean install
|
18:49:12
|
<k-joseph> dkayiwa: it is the testcases that are failing so far
|
18:49:13
|
<dkayiwa> k-joseph: do you have any compiler errors?
|
18:49:34
|
*** shrewduh has joined #openmrs
|
18:49:40
|
<dkayiwa> k-joseph: do you?
|
18:50:16
|
<dkayiwa> k-joseph: are you there?
|
18:50:26
|
<k-joseph> dkayiwa: i don't think i have them
|
18:51:08
|
<dkayiwa> k-joseph: what parameter does getProgramByName take?
|
18:51:44
|
<k-joseph> dkayiwa: String
|
18:52:19
|
<dkayiwa> k-joseph: so why are you creating a new program object?
|
18:55:50
|
<k-joseph> dkayiwa: i think i need to pass in a string, i have changed that
|
19:06:00
|
*** harshadura has joined #openmrs
|
19:11:28
|
<harshadura> dkayiwa: can you gimme a min ?
|
19:14:15
|
*** dkayiwa has quit IRC
|
19:21:39
|
*** dkayiwa has joined #openmrs
|
19:26:48
|
<harshadura> hi dkayiwa
|
19:26:55
|
<dkayiwa> harshadura: hi
|
19:28:55
|
<harshadura> dkayiwa: i think in my code the method argument (which is the encounter <--we changed enc creator) doesnt actually getting overwrited:
|
19:29:06
|
<harshadura> dkayiwa: can you just review it : http://pastebin.com/7dm373HG
|
19:29:54
|
<dkayiwa> harshadura: can you first clean up that class
|
19:30:31
|
<harshadura> dkayiwa: object = invocation.proceed(); doesnt get effected by the encounter change.
|
19:30:33
|
<harshadura> ok dkayiwa
|
19:33:02
|
<harshadura> dkayiwa: http://pastebin.com/n5AG6Qvs
|
19:40:23
|
<breeze> if anyone is testing on devtest01 it will be down down for a few mins while I rebuild the database for it
|
19:40:32
|
<harshadura> dkayiwa: i checked a lot, in aspectJ they can do something like this,
|
19:40:33
|
<harshadura> Object[] args = pjp.getArgs();
|
19:40:33
|
<harshadura> for (int i = 0; i < args.length; i++) {
|
19:40:33
|
<harshadura> if (args[i] instanceof String && ((String) args[i]).isEmpty()) {
|
19:40:33
|
<harshadura> args[i] = null;
|
19:40:33
|
<harshadura> }
|
19:40:34
|
<harshadura> }
|
19:40:36
|
<harshadura> pjp.proceed(args);
|
19:40:47
|
*** evmw has quit IRC
|
19:40:59
|
<harshadura> dkayiwa: but i am wondering whether thrs such a way in spring aop ? :(
|
19:42:23
|
<harshadura> dkayiwa: i just do: invocation.proceed(); but I dont pass any new args , so i think in that way same old args getting executed
|
19:42:36
|
*** evmw has joined #openmrs
|
19:42:36
|
*** ChanServ sets mode: +v evmw
|
19:43:05
|
*** shrewduh has quit IRC
|
19:44:37
|
*** rday has quit IRC
|
19:44:38
|
<dkayiwa> harshadura: is encounter.setCreator(user); getting called?
|
19:44:52
|
<harshadura> yes dkayiwa
|
19:45:06
|
<dkayiwa> harshadura: what stack trace do you get?
|
19:45:30
|
<harshadura> the same one i got earlier dkayiwa
|
19:45:55
|
<dkayiwa> harshadura: what happens when you comment out: object = invocation.proceed();
|
20:02:06
|
<achint> all: I'm heading out to my doctor's appointment soon. wyclif, rafa, djazayeri: need anything from me before I leave ?
|
20:02:20
|
*** djazayeri has quit IRC
|
20:03:08
|
<wyclif> achint: nope, good luck with the doc
|
20:03:28
|
<achint> wyclif : thanks
|
20:09:31
|
<breeze> devtest01 is back up everyone, rafa the column, discontinued_reason_non_coded now exists in the orders table
|
20:11:36
|
<wyclif> cool thanks breeze !
|
20:14:26
|
<wyclif> breeze: do you know why this CI plan fails https://ci-stg.openmrs.org/browse/RESTWS-RESTWS, seem like there are some missing libraries because i get a NoClassDefFoundError but not on my local machine
|
20:18:53
|
<jkeiper> i'm looking for some docs on writing a handler for module types used in person attributes ... is that just a custom datatype handler?
|
20:18:57
|
<jkeiper> (in 1.8.x)
|
20:33:46
|
*** cospih_ has quit IRC
|
20:36:25
|
<harshadura> hi dkayiwa
|
20:36:31
|
<dkayiwa> harshadura: hi
|
20:36:55
|
*** achint has quit IRC
|
20:37:31
|
<harshadura> dkayiwa: when i comment out object = invocation.proceed(); it gives a jsp exception
|
20:37:49
|
<breeze> wyclif: not sure. let me try it locally
|
20:38:15
|
<harshadura> dkayiwa: javax.servlet.jsp.JspException: java.lang.NullPointerException, Parameter mismatch parsing signatures section in dwr.xml on line: DWREncounterService.findBatchOfEncounters(String phrase, Integer patientId, boolean includeVoided, Integer start, Integer length)
|
20:39:13
|
*** achint has joined #openmrs
|
20:41:05
|
<dkayiwa> harshadura: oh i see
|
20:41:20
|
<dkayiwa> harshadura: now change it back
|
20:42:13
|
<harshadura> dkayiwa: right ? but still the old error
|
20:43:11
|
<dkayiwa> harshadura: have you done it and confirmed so?
|
20:43:16
|
*** achint has quit IRC
|
20:43:22
|
<harshadura> yes dkayiwa
|
20:43:28
|
<dkayiwa> harshadura: i mean now
|
20:45:41
|
<harshadura> dkayiwa: still it has the error
|
20:45:53
|
<dkayiwa> harshadura: can i look at the stack trace
|
20:46:27
|
<harshadura> dkayiwa: http://pastebin.com/YYUJpZqG
|
20:46:56
|
<dkayiwa> harshadura: but that is different from the earlier one
|
20:47:41
|
<harshadura> dkayiwa: yes the one before that earlier one :)
|
20:48:03
|
<dkayiwa> harshadura: fix it the same way as you did for the earlier one
|
20:48:11
|
<harshadura> lol
|
20:48:36
|
<dkayiwa> harshadura: am sure you now know how to. not so?
|
20:51:01
|
<harshadura> dkayiwa: my issue is why this isnt still not overwriting the saveEncounter
|
20:51:17
|
<harshadura> dkayiwa: i have tried lots of ways but no luck yet
|
20:51:38
|
<dkayiwa> harshadura: i think you are just not properly looking at the difference in the error messages :)
|
20:52:05
|
<dkayiwa> harshadura: this message has a similar clue that we used for the earlier one :)
|
20:53:05
|
<dkayiwa> harshadura: if you want to compare, just comment out the code which sets the creator and look at the old error again. then compare with this one :)
|
20:53:37
|
<harshadura> ok dkayiwa, i will try again
|
20:57:36
|
<harshadura> dkayiwa: do you think whether i can get rid of this "Creator" chain ? :)
|
20:57:55
|
<harshadura> dkayiwa: i see now, last time it was encounter creator , now obs creator
|
20:58:00
|
<harshadura> :/
|
20:58:15
|
<dkayiwa> harshadura: is it because you do not know how to fix that?
|
20:58:56
|
<harshadura> no i just asked, i will try now dkayiwa
|
20:59:36
|
<dkayiwa> harshadura: thats what you pay when you try doing something in a way different from what it was intended for :)
|
21:00:30
|
<harshadura> yes dkayiwa :)
|
21:00:33
|
<dkayiwa> harshadura: you would need to mess up the database by making the column allow nulls :)
|
21:00:45
|
<harshadura> lol
|
21:01:34
|
<dkayiwa> harshadura: but atleast you have a workaround :)
|
21:01:41
|
*** wyclif has quit IRC
|
21:01:58
|
<dkayiwa> harshadura: but also your module is a bit dangerous to use :D
|
21:02:48
|
<harshadura> dkayiwa: all privileges for the anonymous users xD
|
21:02:58
|
<harshadura> dkayiwa: they can even change the admin pass lol
|
21:03:10
|
*** evmw has quit IRC
|
21:03:48
|
<dkayiwa> harshadura: more than that
|
21:04:23
|
<dkayiwa> harshadura: you AOP code means that even valid logins will have their creator value overwritten :)
|
21:04:30
|
<dkayiwa> you = your
|
21:04:58
|
*** k-joseph has quit IRC
|
21:05:37
|
<harshadura> i understand dkayiwa, need to talk about this issue with saptarshi
|
21:05:57
|
<dkayiwa> harshadura: no. you just need to fix the code :)
|
21:06:42
|
<harshadura> ok dkayiwa :)
|
21:06:56
|
<dkayiwa> harshadura: and i guess you know how :)
|
21:08:48
|
<harshadura> dkayiwa: next im gonna create AOP around ObsService :)
|
21:09:16
|
* harshadura is wondering what would be the next AOP around service
|
21:09:18
|
<dkayiwa> harshadura: thats correct . but i mean for overwritting valid creator logins
|
21:10:20
|
<dkayiwa> harshadura: your code assumes everyone who tries to create encounter, obs is anonymous. which is not correct
|
21:11:26
|
<harshadura> dkayiwa: i will use a flag to check whether the user is authenticated or not, if the user is authenticated can i get rid of the AOP ?
|
21:11:52
|
<dkayiwa> harshadura: how
|
21:12:05
|
<harshadura> dkayiwa: i think i dont know really.
|
21:12:44
|
<dkayiwa> harshadura: do you have to change the value for creator field for all invocations???
|
21:13:00
|
<harshadura> no dkayiwa
|
21:13:15
|
<dkayiwa> harshadura: that is all i mean
|
21:13:22
|
<dkayiwa> harshadura: you code is doing it for all
|
21:14:05
|
<harshadura> yes dkayiwa
|
21:14:17
|
<dkayiwa> harshadura: which is not correct
|
21:14:29
|
<harshadura> yes thats wrong.
|
21:15:01
|
*** jordank has quit IRC
|
21:15:18
|
*** NameFILIP has quit IRC
|
21:18:54
|
<harshadura> dkayiwa: can you just tell what should i do in that point ?
|
21:22:31
|
*** dkayiwa has quit IRC
|
21:25:06
|
*** dkayiwa has joined #openmrs
|
21:25:37
|
*** achint has joined #openmrs
|
21:26:05
|
*** bhashitha has quit IRC
|
21:30:15
|
*** achint has quit IRC
|
21:39:23
|
*** cospih has joined #openmrs
|
21:43:19
|
*** achint has joined #openmrs
|
21:45:41
|
*** NameFILIP has joined #openmrs
|
21:45:42
|
*** ChanServ sets mode: +v NameFILIP
|
21:47:45
|
*** achint has quit IRC
|
21:54:01
|
*** NameFILIP has quit IRC
|
21:56:24
|
*** mogoodrich_ has joined #openmrs
|
21:56:41
|
*** evmw has joined #openmrs
|
21:56:41
|
*** ChanServ sets mode: +v evmw
|
21:58:03
|
*** evmw has quit IRC
|
21:58:16
|
*** mogoodrich has quit IRC
|
21:59:14
|
*** evmw has joined #openmrs
|
21:59:14
|
*** ChanServ sets mode: +v evmw
|
22:00:10
|
*** mogoodrich_ has quit IRC
|
22:03:02
|
*** evmw has quit IRC
|
22:03:23
|
*** harshadura has quit IRC
|
22:08:58
|
*** wyclif has joined #openmrs
|
22:17:23
|
*** harshadura has joined #openmrs
|
22:43:29
|
*** rday has joined #openmrs
|
22:44:56
|
*** nano1 has quit IRC
|
22:45:11
|
*** breeze has quit IRC
|
22:50:46
|
*** NameFILIP has joined #openmrs
|
22:50:46
|
*** ChanServ sets mode: +v NameFILIP
|
22:54:54
|
*** NameFILIP has quit IRC
|
23:05:40
|
*** rafa has quit IRC
|
23:10:04
|
*** harsz89 has quit IRC
|
23:10:41
|
*** wyclif has quit IRC
|
23:19:38
|
*** wyclif has joined #openmrs
|
23:27:25
|
*** rday has quit IRC
|
23:29:42
|
*** achint has joined #openmrs
|
23:34:23
|
*** achint has quit IRC
|
23:51:15
|
*** NameFILIP has joined #openmrs
|
23:51:20
|
*** ChanServ sets mode: +v NameFILIP
|
23:56:24
|
*** NameFILIP has quit IRC
|