| 00:38:09 | *** NameFILIP has joined #openmrs |
| 00:38:10 | *** ChanServ sets mode: +v NameFILIP |
| 00:42:45 | *** NameFILIP has quit IRC |
| 00:43:49 | *** harshadura has quit IRC |
| 00:48:18 | *** wyclif has quit IRC |
| 00:48:40 | *** didymo has quit IRC |
| 00:48:57 | *** didymo has joined #openmrs |
| 00:48:58 | *** wyclif has joined #openmrs |
| 00:57:29 | *** harshadura has joined #openmrs |
| 01:05:43 | *** evmw has quit IRC |
| 01:12:47 | *** elliott_w has joined #openmrs |
| 01:12:47 | *** ChanServ sets mode: +o elliott_w |
| 01:27:16 | *** elliott_w has quit IRC |
| 01:28:36 | *** evmw has joined #openmrs |
| 01:28:36 | *** ChanServ sets mode: +v evmw |
| 01:38:39 | *** NameFILIP has joined #openmrs |
| 01:38:40 | *** ChanServ sets mode: +v NameFILIP |
| 01:43:07 | *** NameFILIP has quit IRC |
| 02:20:52 | *** evmw has quit IRC |
| 02:21:34 | *** harshadura_ has joined #openmrs |
| 02:39:09 | *** NameFILIP has joined #openmrs |
| 02:39:09 | *** ChanServ sets mode: +v NameFILIP |
| 02:44:22 | *** NameFILIP has quit IRC |
| 02:44:46 | *** evmw has joined #openmrs |
| 02:44:47 | *** ChanServ sets mode: +v evmw |
| 02:49:45 | *** evmw has quit IRC |
| 03:16:25 | *** evmw has joined #openmrs |
| 03:16:26 | *** ChanServ sets mode: +v evmw |
| 03:38:14 | *** upul has joined #openmrs |
| 03:39:40 | *** NameFILIP has joined #openmrs |
| 03:39:40 | *** ChanServ sets mode: +v NameFILIP |
| 03:40:48 | *** evmw has quit IRC |
| 03:44:30 | *** NameFILIP has quit IRC |
| 03:51:56 | *** evmw has joined #openmrs |
| 03:51:56 | *** ChanServ sets mode: +v evmw |
| 04:04:19 | *** harshadura_ has quit IRC |
| 04:29:28 | *** evmw has quit IRC |
| 04:40:10 | *** NameFILIP has joined #openmrs |
| 04:40:10 | *** ChanServ sets mode: +v NameFILIP |
| 04:44:21 | *** NameFILIP has quit IRC |
| 04:55:38 | *** maninc has joined #openmrs |
| 05:04:07 | *** maninc has quit IRC |
| 05:14:40 | *** NameFILIP has joined #openmrs |
| 05:14:40 | *** ChanServ sets mode: +v NameFILIP |
| 05:28:08 | *** davidpardz has quit IRC |
| 05:28:51 | *** wyclif has quit IRC |
| 05:39:05 | *** kavuri_ has joined #openmrs |
| 05:39:24 | *** kavuri_ has left #openmrs |
| 05:53:48 | *** davidpardz has joined #openmrs |
| 05:53:48 | *** ChanServ sets mode: +v davidpardz |
| 06:15:37 | *** achint has quit IRC |
| 06:39:46 | *** kavuri_ has joined #openmrs |
| 06:42:57 | *** rday has joined #openmrs |
| 06:44:02 | *** NameFILIP has quit IRC |
| 06:50:03 | *** Mkop has quit IRC |
| 06:50:20 | *** Mkop has joined #openmrs |
| 06:51:24 | *** kavuri_ has quit IRC |
| 07:11:00 | *** upul has quit IRC |
| 07:11:03 | *** kavuri has joined #openmrs |
| 07:13:56 | *** geekgugi has joined #openmrs |
| 07:36:00 | *** dkayiwa has joined #openmrs |
| 07:44:43 | *** NameFILIP has joined #openmrs |
| 07:44:43 | *** ChanServ sets mode: +v NameFILIP |
| 07:46:56 | *** geekgugi has quit IRC |
| 07:49:43 | *** NameFILIP has quit IRC |
| 07:54:29 | *** kavuri has quit IRC |
| 07:56:55 | *** rafa has joined #openmrs |
| 07:56:55 | *** ChanServ sets mode: +v rafa |
| 07:59:27 | *** geekgugi has joined #openmrs |
| 08:03:12 | *** KC9YYQ has quit IRC |
| 08:04:55 | *** KC9YYQ has joined #openmrs |
| 08:06:06 | *** kavuri has joined #openmrs |
| 08:25:54 | *** dkayiwa has quit IRC |
| 08:26:50 | *** dkayiwa has joined #openmrs |
| 08:38:53 | *** geekgugi has quit IRC |
| 08:39:02 | <suranga> HI dkayiwa .. Good morninggg |
| 08:39:18 | <dkayiwa> suranga: morning |
| 08:39:59 | <suranga> dkayiwa: im sorry I kinda vanished yesterday. it seems that i had fallen asleep over my machine :D |
| 08:40:01 | <suranga> dkayiwa: |
| 08:40:13 | <dkayiwa> suranga: lolllllll :) |
| 08:41:09 | <suranga> dkayiwa: i was wondering, were you able to find out why my problem was occuring ? :) |
| 08:41:56 | <dkayiwa> suranga: you vanished and i lost track. so you need to do it all over again |
| 08:42:50 | <suranga> dkayiwa: no worries, I will find a comfy place and re-contact you |
| 08:43:40 | *** dkayiwa_ has joined #openmrs |
| 08:46:23 | *** dkayiwa has quit IRC |
| 08:46:24 | *** dkayiwa_ is now known as dkayiwa |
| 08:46:42 | *** r0bby has joined #openmrs |
| 08:46:42 | *** ChanServ sets mode: +v r0bby |
| 08:47:07 | *** robbyoconnor has quit IRC |
| 09:02:39 | *** k-joseph has joined #openmrs |
| 09:20:29 | *** NameFILIP has joined #openmrs |
| 09:20:29 | *** ChanServ sets mode: +v NameFILIP |
| 09:20:29 | *** shangxiao has joined #openmrs |
| 09:22:40 | <shangxiao> rafa: We're almost done setting up the concept metadata |
| 09:22:45 | <shangxiao> We have numeric setup |
| 09:23:07 | <shangxiao> but we have "Coded" and "Complex" datatypes that have some metadata and we're not sure what they are |
| 09:34:51 | <shangxiao> oh actually we've found a potential issue |
| 09:35:03 | <shangxiao> with concept_answer there's a mapping between concepts |
| 09:35:43 | <shangxiao> the concept being proposed could either link to an existing one in the dictionary or a new one |
| 09:37:10 | <suranga> hi dkayiwa um.. Im back, can I re-ask ? :) |
| 09:37:17 | <dkayiwa> suranga: ok |
| 09:38:54 | <suranga> dkayiwa: I assume that you have the two files I sent you ? |
| 09:39:06 | <dkayiwa> suranga: no |
| 09:39:24 | <suranga> so basically, what im doing is displaying a new jquery confirmation box when an user decides to shut down a module. |
| 09:39:44 | <suranga> the dialog box is displayed only if shutting down one module results in others being shut down. |
| 09:40:28 | <suranga> dkayiwa: now the problem is, ive noticed that my javascript method exists with 'false' before the user actually picks either 'yes' or 'no' from the dialog box |
| 09:41:02 | <suranga> dkayiwa: the two files are, |
| 09:41:06 | <suranga> http://pastebin.com/gD86KiYM (modulelist.jsp |
| 09:41:22 | <suranga> modulemanagementcontroller http://pastebin.com/FJuzJ9LH (newly introduced) |
| 09:42:29 | <dkayiwa> suranga: what is the line number of the exit line you are talking of? |
| 09:43:29 | <suranga> dkayiwa: its like this, ive put in some alerts to show me the flow of control, so I see that the alert given on line 58 (just about to exit) is displayed at the same time as the dialog box is displayed |
| 09:43:59 | <suranga> because of this, the method alllway returns false (the default value i assigned in line 18 |
| 09:44:14 | <suranga> dkayiwa: it never returns with the value i pick using the dialog box |
| 09:44:59 | <dkayiwa> suranga: what do you use the return value for? |
| 09:45:38 | <suranga> dkayiwa: if its true, the value gets propogated to the form on line no |
| 09:46:24 | <suranga> 231, and the module is shut down |
| 09:46:41 | <suranga> if it returns false, the value goes back to the same line, and the module is not shut down :) |
| 09:46:53 | <suranga> dkayiwa: frankly, im quite stuck as to why this doesnt happen :( |
| 09:48:12 | <dkayiwa> suranga: are you talking of line numbers in controller or jsp? |
| 09:48:21 | <suranga> dkayiwa: in the jsp |
| 09:49:19 | <dkayiwa> suranga: on which line is the dialog box |
| 09:49:54 | <suranga> dkayiwa: its starts on line 22 (the ajax call) |
| 09:50:27 | <suranga> dkayiwa: exact section is 34-49 |
| 09:51:55 | <dkayiwa> suranga: and on what line number is the alert you were talking of? |
| 09:52:30 | <suranga> dkayiwa: the div id is on line 136 |
| 09:52:43 | <suranga> it gets triggerd and populated with data on line 34 |
| 09:53:12 | <suranga> umm.... dkayiwa: maybe it would be easier to understand if you try executing it ? |
| 09:53:54 | <dkayiwa> suranga: did you understand my question? |
| 09:53:56 | <dkayiwa> :) |
| 09:54:34 | <suranga> dkayiwa: ok sorry, you mean the alert that shows that my method is getting completed prematurely ? |
| 09:54:54 | <dkayiwa> suranga: yes |
| 09:55:19 | <suranga> line 58 ( alert('exiting' + result)) |
| 09:55:38 | <suranga> dkayiwa: when i execute it, this alert, and the confirmation, are displayed at the same time... |
| 09:59:08 | <dkayiwa> suranga: does the .ajax({ call block? |
| 09:59:38 | <suranga> dkayiwa: um.. no, it works fine. both buttons are clickable, and the close action works |
| 10:00:13 | <suranga> dkayiwa: when you say 'does the ajax call block, I hope thats what you meant... |
| 10:00:57 | <dkayiwa> suranga: i mean that, will the validateDependencies wait for the return value of the ajax call before it can return? |
| 10:01:27 | <suranga> dkayiwa: oh, nopz, I think thats the cause of the problem :( |
| 10:02:03 | <suranga> dkayiwa: since the method exists before, I guess that it doesnt wait for the ajax call... |
| 10:04:25 | <dkayiwa> suranga: ok |
| 10:04:37 | <suranga> dkayiwa: hope that this makes sense to you :( :( |
| 10:04:48 | <dkayiwa> suranga: yup |
| 10:06:39 | <suranga> dkayiwa: yay ! that means that you probably have a solution as well ? :) |
| 10:07:17 | <dkayiwa> suranga: what is the validate method supposed to do? |
| 10:07:43 | <suranga> dkayiwa: it takes the id of the module that we want to shut down, and sends it to my new controller |
| 10:08:01 | <suranga> the controller checks if other modules depend on the module to be shut down |
| 10:08:18 | <suranga> dkayiwa: if so, these modules are identified, and their names returned to the jsp |
| 10:08:43 | <suranga> now, we display a confirmation message stating that shutting down module A will also shut down module B, and ask the users permission to do so |
| 10:08:54 | <suranga> dkayiwa: this is basically what the module does :) |
| 10:08:58 | <dkayiwa> suranga: let me put it a different way. what javadoc would you put for validateDependencies() |
| 10:09:22 | <dkayiwa> suranga: i do not want internal implementation details for now :) |
| 10:09:41 | <suranga> dkayiwa: //retrives a list of modules which depend on module A, and asks user to confirm that they wish to shut down these modules |
| 10:09:43 | <dkayiwa> suranga: i attack complexity by internalizing small parts one at a time |
| 10:09:53 | <suranga> dkayiwa: :) |
| 10:10:40 | <dkayiwa> suranga: so return value for validateDependencies is a list? |
| 10:11:02 | <suranga> dkayiwa: the ajax call to the controller returns just a string of names |
| 10:11:16 | <suranga> the validatedependencies method returns a boolean value (yes, no) |
| 10:11:19 | <dkayiwa> suranga: did you understand my question? |
| 10:11:50 | <dkayiwa> suranga: for now am not interested in the implementation details for validateDependencies |
| 10:12:02 | <dkayiwa> suranga: all i want is its contract |
| 10:12:12 | <dkayiwa> suranga: the javadoc you would give it |
| 10:12:35 | <dkayiwa> suranga: i do care, for now, whether it calls, ajax, surangax, or what :) |
| 10:12:46 | <suranga> dkayiwa: :D |
| 10:13:01 | <dkayiwa> suranga: giving me more details than am asking for is also confusing me :) |
| 10:13:15 | <suranga> dkayiwa: the validatedependencies method returns a true/false, which is used to shutdown the module.. |
| 10:13:34 | <dkayiwa> suranga: so now i ask again, what javadoc would you give validateDependencies? |
| 10:14:21 | <suranga> umm.... dkayiwa: //returns a true/false value on wether or not to shut down a module selected by the user ? |
| 10:15:20 | <dkayiwa> suranga: which user? |
| 10:15:51 | <suranga> dkayiwa: whoever is trying to shutdown the module via the modulelist.jsp page |
| 10:16:03 | <dkayiwa> suranga: is the user a parameter to validateDependencies? |
| 10:16:21 | <suranga> dkayiwa: yes, just the module Id which is being considered for shutdown |
| 10:16:53 | <dkayiwa> suranga: i do not see a user parameter to validateDependencies |
| 10:16:59 | <dkayiwa> suranga: am i just blind? :) |
| 10:17:24 | <suranga> dkayiwa: oh, im sorry, I misread your question... |
| 10:17:34 | *** kavuri has quit IRC |
| 10:17:42 | *** kavuri has joined #openmrs |
| 10:17:43 | <suranga> dkayiwa: sorry sorry, the user is NOT a parameter. the only parameter is module id |
| 10:17:50 | *** kavuri has left #openmrs |
| 10:17:58 | <dkayiwa> suranga: so why is the javadoc talking about a user? |
| 10:18:30 | <suranga> dkayiwa: um... thats my mistake, I was talking about who would want to do the action:( |
| 10:19:25 | <dkayiwa> suranga: looks like you still want to include internal implementation details :) |
| 10:19:39 | <dkayiwa> suranga: so can you write the javadoc again without such? :) |
| 10:19:40 | <suranga> dkayiwa: bad habits die hard :-( |
| 10:21:23 | <suranga> dkayiwa: umm... //returns an boolean response used to shutdown a pre-selected module ? |
| 10:22:17 | <dkayiwa> suranga: so you want the javadoc to dictate what the caller should use the return value of validateDependencies for? :) |
| 10:22:43 | <suranga> dkayiwa: umm.. isnt that a good idea ? |
| 10:23:18 | <dkayiwa> suranga: is that got anything to do with what the method does? |
| 10:25:16 | <suranga> dkayiwa: um... basically, the module is supposed to return a boolean response as to wether or not to shut down the module. thats why its got the confirmation box for, isnt it ? |
| 10:26:06 | <dkayiwa> suranga: what if i decide to use the return value for something else? |
| 10:26:33 | <suranga> dkayiwa: umm.. in that case, it wont really be the 'validateDependencies' method, right ? |
| 10:27:09 | <dkayiwa> suranga: if you for instance have a method called calculatePatientAge(Patient) does the javadoc have to dictate what is should use the returned calculated age for? |
| 10:28:15 | <dkayiwa> suranga: if i want to use it for enrolling patient in a certain program, and then somebody else wants to use the age for something totally different, can't they also use the method? |
| 10:28:49 | <suranga> dkayiwa: aaaaaaaaaaaaah, ok, now i think I get it. so we should say //returns a boolean response on selected module ? |
| 10:29:21 | <dkayiwa> suranga: in otherwards, the contract of the method should simply state what the method accomplishes. |
| 10:29:46 | <dkayiwa> suranga: not its internal implementation details, or what one should use the return value for :) |
| 10:30:32 | <dkayiwa> suranga: so in light of the above, what should the javadoc be for validateDependencies? |
| 10:31:39 | <suranga> dkayiwa: //returns users response to a module dependency validation ? |
| 10:32:03 | *** shangxiao has quit IRC |
| 10:32:20 | <dkayiwa> suranga: which user? |
| 10:32:30 | *** didymo has quit IRC |
| 10:32:41 | <suranga> dkayiwa: administrator, i belive |
| 10:33:01 | <dkayiwa> suranga: is that a parameter to the method? |
| 10:33:21 | <suranga> dkayiwa: not really, its not required for the task |
| 10:33:33 | <dkayiwa> suranga: so why in the javadoc? |
| 10:34:02 | <suranga> dkayiwa: umm..so //returns response to a module dependency validation ? |
| 10:34:58 | <dkayiwa> suranga: response like Patient? |
| 10:35:52 | <suranga> dkayiwa: ooops, looks like that section got left off. its // returns boolean response to a module dependency validation ? |
| 10:36:28 | <k-joseph> dkayiwa: hi, |
| 10:36:33 | <dkayiwa> k-joseph: hi |
| 10:36:51 | <dkayiwa> suranga: so what does true and false mean in that regard? |
| 10:37:37 | <k-joseph> dkayiwa: i have mailed you, the pastebin link for that also at http://pastebin.com/9vq6at6y |
| 10:37:40 | <suranga> dkayiwa: true --> response to shut down a module, and false --> response not to shut down a module |
| 10:38:05 | <dkayiwa> k-joseph: use github for code reviews |
| 10:38:26 | <dkayiwa> suranga: did you intentionally leave that out of the javadoc? |
| 10:39:04 | <suranga> dkayiwa: im afraid I hadnt really thought of writing proper javadocs at the moment. I was going to put that in pre-commit :( |
| 10:39:22 | <dkayiwa> suranga: i do not mean that you write one |
| 10:39:58 | <dkayiwa> suranga: i simply mean that before i even look at what the implementation is for that method, what is it to be used for |
| 10:40:38 | <suranga> dkayiwa: ah , i think I get it :) |
| 10:41:28 | <dkayiwa> suranga: what has validateDependencies javadoc got to do with shutdown modules |
| 10:42:17 | <suranga> dkayiwa: im sorry, Im not understanding you :( |
| 10:42:19 | <dkayiwa> suranga: do you mean that when one calls it, it shuts down modules? |
| 10:42:46 | <suranga> dkayiwa: ah, yes, based on the administrators boolean decision, it does so |
| 10:43:29 | <dkayiwa> suranga: for now am concentrating on just one thing, then validateDependencies |
| 10:43:41 | <dkayiwa> suranga: i do not care about what the caller may want to use it for |
| 10:43:49 | *** harshadura has quit IRC |
| 10:44:06 | <dkayiwa> suranga: so give me information concerning only about what this method accomplishes |
| 10:44:19 | <dkayiwa> suranga: does this make sense? |
| 10:44:28 | <suranga> dkayiwa: yeps, sorry |
| 10:44:44 | <dkayiwa> suranga: so can you now give me a javadoc for it |
| 10:52:29 | *** geekgugi has joined #openmrs |
| 10:55:25 | <k-joseph> dkayiwa: i have added the commit, at https://github.com/k-joseph/openmrs-core/commit/TRUNK-3986 |
| 10:55:29 | <OpenMRSBot> <http://ln-s.net/-LKq> (at github.com) |
| 10:55:36 | *** harshadura has joined #openmrs |
| 10:55:45 | <dkayiwa> k-joseph: does the ticket reflect it? |
| 10:56:22 | <k-joseph> dkayiwa: yes, it is already added on the ticket page |
| 10:56:36 | <dkayiwa> k-joseph: ok will review |
| 11:01:39 | *** harsz89 has quit IRC |
| 11:02:45 | <dkayiwa> k-joseph: hi |
| 11:02:54 | <k-joseph> dkayiwa: hi |
| 11:03:49 | <dkayiwa> k-joseph: have you looked at any existing unit tests that call methods on service layer interfaces? |
| 11:11:29 | <k-joseph> dkayiwa: yes, i have looked at some before looked at some, |
| 11:12:33 | <dkayiwa> k-joseph: how do they access the service layer? |
| 11:16:18 | <k-joseph> dkayiwa: i think that is by using the Context get__Service() methods, !!, |
| 11:16:46 | <dkayiwa> k-joseph: any reason why you are not using the same in your tests? |
| 11:17:57 | *** harshadura has quit IRC |
| 11:18:10 | <k-joseph> dkayiwa: i think i had a poor thought in doing that, for i had asked that same question to myself before, that is why i was creating an object for that, am correcting that |
| 11:18:23 | <dkayiwa> k-joseph: ok |
| 11:19:17 | <dkayiwa> k-joseph: when you dirrectly use the interface implementing class (those that end with ...Impl) you by pass all AOP functionality |
| 11:20:04 | <k-joseph> dkayiwa: AOP == meaning!!! |
| 11:20:51 | <dkayiwa> k-joseph: https://wiki.openmrs.org/display/docs/OpenMRS+AOP |
| 11:20:51 | <OpenMRSBot> <http://ln-s.net/8gLx> (at wiki.openmrs.org) |
| 11:21:40 | <k-joseph> dkayiwa: thank for that link, very soon will read it |
| 11:27:59 | <dkayiwa> k-joseph: hi |
| 11:28:10 | <k-joseph> dkayiwa: hi |
| 11:28:23 | <dkayiwa> k-joseph: did you include the ticket number in your commit message? |
| 11:29:15 | <dkayiwa> k-joseph: secondly, i also do not see this commit url on the ticket |
| 11:29:46 | <k-joseph> dkayiwa: checking to respond |
| 11:34:51 | <k-joseph> dkayiwa: i had not included the commit number in my commit message, i have added a comment on the ticket page |
| 11:35:31 | <dkayiwa> k-joseph: please remember to always include it in every commit |
| 11:36:02 | <k-joseph> dkayiwa: ok please, will be doing that always when commiting |
| 11:37:20 | *** elliott_w has joined #openmrs |
| 11:37:20 | *** ChanServ sets mode: +o elliott_w |
| 11:42:11 | *** shangxiao has joined #openmrs |
| 11:43:16 | *** shangxiao has quit IRC |
| 11:55:59 | *** geekgugi has quit IRC |
| 12:08:53 | *** achint has joined #openmrs |
| 12:38:20 | *** cospih has joined #openmrs |
| 12:40:00 | *** cospih_ has quit IRC |
| 12:41:02 | *** evmw has joined #openmrs |
| 12:41:03 | *** ChanServ sets mode: +v evmw |
| 12:42:26 | *** wyclif has joined #openmrs |
| 12:44:31 | *** shangxiao has joined #openmrs |
| 12:45:19 | *** evmw has quit IRC |
| 12:56:15 | *** harsz89 has joined #openmrs |
| 12:56:15 | *** ChanServ sets mode: +v harsz89 |
| 13:03:24 | *** garima has joined #openmrs |
| 13:04:08 | <garima> rafa: hi |
| 13:06:38 | <garima> rafa: as i commented on the pull request ( https://github.com/openmrs/openmrs-module-webservices.rest/pull/49 ), returning object instead of simple objects results in many test failures |
| 13:06:44 | <OpenMRSBot> <http://ln-s.net/-LMO> (at github.com) |
| 13:06:51 | <rafa> garima: hi |
| 13:07:01 | <rafa> garima: thanks for testing! |
| 13:07:20 | <rafa> garima: I guess something is not working correctly... I'll have a look. |
| 13:07:42 | <garima> rafa: meanwhile should i write a test for the simple object version? |
| 13:07:59 | <rafa> garima: yes, it would be perfect |
| 13:08:19 | <garima> rafa: i am on it :) |
| 13:15:05 | *** garima has quit IRC |
| 13:16:43 | *** shangxiao has quit IRC |
| 13:21:04 | *** evmw has joined #openmrs |
| 13:21:04 | *** ChanServ sets mode: +v evmw |
| 13:26:50 | *** [0nribeka] is now known as nribeka |
| 13:57:38 | *** maurya has joined #openmrs |
| 13:57:51 | <nribeka> hi guys, quick question. is there a support gzip for the webservice currently or no? :) |
| 13:58:00 | *** ChanServ sets mode: +v maurya |
| 13:59:26 | <maurya> nribeka: hi, do you have a moment? |
| 13:59:37 | <nribeka> hi maurya |
| 13:59:38 | <nribeka> sure |
| 14:00:30 | <maurya> nribeka: i just wanted to find out if there is any documentation on amrs repor module |
| 14:02:19 | <nribeka> maurya: what particular are you looking for? i think there are some documentation for the each column in the ampath wiki. the amrs report is being used to generate report for MoH in Kenya. |
| 14:02:26 | <maurya> nribeka: technical documentation to be exact, as i'm trying to understand the amrs report module's running a report functionality |
| 14:04:28 | <nribeka> i don't think there's much technical documentation. i think that module extends the reporting framework by adding some ampath specific data definition |
| 14:04:45 | <nribeka> i think you should look into the reporting framework documentations |
| 14:04:57 | <nribeka> if you're interested in creating reports that is |
| 14:06:09 | <maurya> nribeka: yes, i'm trying to create reports and trying to run them in a periodic manner, and send the results to a specified email(example) |
| 14:07:54 | <nribeka> i think reporting have a scheduler maurya |
| 14:07:55 | *** dkayiwa has quit IRC |
| 14:07:56 | *** dkayiwa_ has joined #openmrs |
| 14:09:20 | <nribeka> and you definitely can write your own task (and then schedule it) to evaluate a definition in the reporting framework and then in this task you can write your mechanism to send email |
| 14:10:17 | <mseaton> maurya: reporting module has built in ability to schedule reports and email results after the report has been processed |
| 14:10:23 | *** harsz89 has quit IRC |
| 14:10:45 | <nribeka> there you go. mseaton is the best person to ask about reporting maurya :) |
| 14:11:14 | <maurya> nribeka:haha, just another question, task meaning a general term or is is any of the reporting term? |
| 14:12:26 | <nribeka> per mseaton answer: reporting module has built in ability to schedule reports and email results after the report has been processed :) |
| 14:12:34 | <nribeka> see above answer from mseaton |
| 14:14:17 | <maurya> mseaton: i'm trying to create a module that would create and run reports , would it be better if i try to use the reporting module's methods by keeping it as a dependency(i'm working on acheiving this0 or is it better to invoke through the web api(i've not worked on this , just an assumption we can) |
| 14:14:18 | <nribeka> and task = an element in openmrs world. you can schedule it to run at specific time / interval. write this if you have very complicated or very specific set of instructions |
| 14:15:49 | <mseaton> maurya: i would recommend that you use the reporting module api, and either run the report via code or via the web, per your requirements |
| 14:16:27 | <maurya> nribeka: Thank you very much, you've been very prompt :) |
| 14:16:37 | <rafa> cpower: there? |
| 14:16:43 | <rafa> cpower: no scrum? |
| 14:17:51 | <h3llborn> rafa: good late afternoon :P |
| 14:18:00 | <rafa> h3llborn: hey |
| 14:18:06 | <rafa> h3llborn: good morning to you! |
| 14:18:11 | <h3llborn> rafa: thanks :) |
| 14:18:31 | <h3llborn> rafa: so yesterday I tried out a bunch of installers for windows...god I didn't know there were that many haha |
| 14:19:03 | <h3llborn> rafa: I belive the best one is http://wixtoolset.org/ and its also free |
| 14:19:38 | <rafa> h3llborn: ok |
| 14:19:38 | <h3llborn> rafa: for mac there are basically only paid options, but I did email 2 companies regarding a free license for opensource organizations |
| 14:19:55 | <h3llborn> rafa: see: http://www.mindvision.com/macvise.asp & http://www.stuffit.com/developers/im.html |
| 14:20:49 | <h3llborn> rafa: today will consist of either following up with those companeis or looking into the best way to get this to work under ubuntu. probably create a .deb or something :P |
| 14:20:57 | *** maurya has quit IRC |
| 14:21:01 | <cpower> Hello sorry for delay |
| 14:21:06 | <cpower> !scrumon cpower |
| 14:21:06 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:21:29 | <cpower> Order: rafa , wyclif , dkayiwa_ |
| 14:22:27 | <rafa> Today: |
| 14:22:27 | <rafa> * Committed RA-91 Build a Dispensing App |
| 14:22:27 | <rafa> https://tickets.openmrs.org/browse/RA-91 |
| 14:22:27 | <rafa> * Working on RA-92 Build dispensing form with details |
| 14:22:27 | <rafa> https://tickets.openmrs.org/browse/RA-92 |
| 14:22:27 | <rafa> * Testing TRUNK-4012 Support H2 database |
| 14:22:27 | <rafa> https://tickets.openmrs.org/browse/TRUNK-4012 |
| 14:22:28 | <rafa> No blockers. |
| 14:23:11 | <wyclif> Monday: |
| 14:23:12 | <wyclif> -Add feature toggle for displaying edit buttons on patient dashboard |
| 14:23:13 | <wyclif> -Fixed some javascript errors, one with datepicker when locale is en and the spinner for in the header |
| 14:23:15 | <wyclif> -Fix issues to do with RA-69- Validation of registration |
| 14:23:16 | <wyclif> Tuesday: |
| 14:23:17 | <wyclif> -Complete validation issues with registration RA-69 |
| 14:23:18 | <wyclif> -pick another sprint ticket |
| 14:23:19 | <wyclif> Blockers: None |
| 14:23:39 | <dkayiwa_> Looked at: Introduce API performance tests - TRUNK-3843 |
| 14:23:40 | <dkayiwa_> Reviewed: Add ConceptNameTagValidator to Core API - TRUNK-3986 |
| 14:23:40 | <dkayiwa_> Reviewed and closed: Test in WebModuleUtilTest fails on Windows - TRUNK-4002 |
| 14:23:40 | <dkayiwa_> Committed: Allow Visualization of Form without editing - XFRM-121 |
| 14:23:40 | <dkayiwa_> Did some JIRA ticket administration |
| 14:23:41 | <dkayiwa_> Going to do more code reviews and ticket administration tasks |
| 14:23:41 | <dkayiwa_> No Blockers |
| 14:23:54 | *** davidpardz has left #openmrs |
| 14:25:50 | <rafa> cpower: wrap up :) |
| 14:26:02 | <cpower> !scrumoff |
| 14:26:02 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:26:11 | <rafa> cpower: thanks! |
| 14:26:12 | <cpower> dkayiwa_: Can you make the design call tomorrow? |
| 14:26:24 | <rafa> h3llborn: So the only thing installer needs to do for us is to extract scripts and add a path of an install dir to the system PATH variable |
| 14:26:35 | <cpower> dkayiwa_: We want to talk about xforms and you seem to be the guy in the know. |
| 14:26:39 | <dkayiwa_> cpower: why not :) |
| 14:26:44 | <h3llborn> rafa: for all os's? |
| 14:26:48 | <rafa> h3llborn: yes |
| 14:26:52 | <dkayiwa_> cpower: i always make it :) |
| 14:27:07 | <cpower> dkayiwa_: Just making sure ;-) |
| 14:27:12 | <cpower> dkayiwa_: Thanks |
| 14:27:23 | <dkayiwa_> cpower: :D |
| 14:27:29 | <rafa> h3llborn: do these installers make it easy? |
| 14:27:32 | <h3llborn> rafa: ok sounds good, well for linux I suppose a script itself would probably be fine but I'll see if I can find a packaging software |
| 14:27:47 | <h3llborn> rafa: ya most of them support a LOT of options... |
| 14:29:04 | <rafa> h3llborn: have you seen this http://en.wikipedia.org/wiki/List_of_installation_software ? |
| 14:29:05 | *** dkayiwa_ has quit IRC |
| 14:29:07 | <OpenMRSBot> <http://ln-s.net/-LNk> (at en.wikipedia.org) |
| 14:29:14 | <rafa> h3llborn: there are some that support almost all platforms |
| 14:29:35 | <h3llborn> rafa: Havent seen it ahah, never considered really lookin into wikipedia :P |
| 14:29:49 | <h3llborn> rafa: but thanks, I'll surely have a look there :) |
| 14:30:11 | <rafa> h3llborn: this one looks interesting http://izpack.org/ |
| 14:31:03 | <h3llborn> rafa: yes it does! thanks for the link :) I'll give it a try in a few. I just have to eat some breakfast ahah |
| 14:31:28 | *** harshadura has joined #openmrs |
| 14:31:33 | *** dkayiwa has joined #openmrs |
| 14:32:06 | *** maurya has joined #openmrs |
| 14:32:17 | *** ChanServ sets mode: +v maurya |
| 14:32:31 | <h3llborn> rafa: btw did you get a chance to look into Trunk 4012? |
| 14:32:49 | <rafa> h3llborn: yes, I've reviewed the code and testing right now |
| 14:32:58 | <h3llborn> rafa: ok sounds good :) |
| 14:33:29 | <h3llborn> rafa: I'll also will see how atlassian does their install, just to see what the best practices are |
| 14:33:54 | <rafa> h3llborn: you can check Atlassian, NetBeans, anything... |
| 14:34:18 | <h3llborn> rafa: thanks :) got anything else to discuss? |
| 14:34:42 | <rafa> h3llborn: that's all from me unless you have something that troubles you |
| 14:34:45 | *** dkayiwa has quit IRC |
| 14:35:16 | <rafa> h3llborn: https://installer.netbeans.org/ |
| 14:37:20 | <h3llborn> rafa: nope, but thanks for the link :) I'll check it out ! |
| 14:43:17 | <rafa> h3llborn: I just asked, atlassian uses http://installbuilder.bitrock.com/ |
| 14:43:27 | <h3llborn> rafa: thanks :) |
| 14:43:29 | *** maurya has quit IRC |
| 14:43:52 | <rafa> h3llborn: maybe it's worth to e-mail them about free licence for open source |
| 14:44:07 | <h3llborn> rafa: ok for sure I'll fire off an email to them :) |
| 14:44:35 | <rafa> h3llborn: http://installbuilder.bitrock.com/open-source-licenses.html |
| 14:44:36 | <OpenMRSBot> <http://ln-s.net/4boB> (at installbuilder.bitrock.com) |
| 14:44:48 | <rafa> h3llborn: just make sure that it satisfies our needs |
| 14:44:55 | <rafa> h3llborn: before sending a request |
| 14:45:02 | <h3llborn> rafa: yessir! I'll get on that :) |
| 14:45:06 | <rafa> h3llborn: they should have a trial |
| 14:45:21 | <h3llborn> rafa: most def. ahaha I'll give it a nice run through |
| 14:49:06 | <rafa> h3llborn: actually I think the way to go is to ask Michael to request a license for OpenMRS once we confirm we want to use the app |
| 14:49:20 | <rafa> h3llborn: so just go with a trial |
| 14:49:32 | <h3llborn> rafa: sure, less work for me hahah |
| 15:00:36 | *** rafa has quit IRC |
| 15:34:29 | *** harsz89 has joined #openmrs |
| 15:34:30 | *** ChanServ sets mode: +v harsz89 |
| 15:36:57 | *** r0bby has quit IRC |
| 15:37:06 | *** r0bby has joined #openmrs |
| 15:37:06 | *** ChanServ sets mode: +v r0bby |
| 15:53:48 | *** NameFILIP has quit IRC |
| 16:11:13 | *** breeze has joined #openmrs |
| 16:21:39 | *** harshadura has quit IRC |
| 16:24:36 | *** NameFILIP has joined #openmrs |
| 16:24:37 | *** ChanServ sets mode: +v NameFILIP |
| 16:32:56 | *** NameFILIP has quit IRC |
| 16:51:34 | <h3llborn> downey: you around by any chance? :P |
| 17:21:35 | *** davidpardz has joined #openmrs |
| 17:21:35 | *** ChanServ sets mode: +v davidpardz |
| 17:23:52 | <h3llborn> downey: if you get a chance take a look at !ticket ITSM-3514 |
| 17:23:58 | <h3llborn> !ticket ITSM-3514 |
| 17:23:59 | <OpenMRSBot> h3llborn: Log in - OpenMRS JIRA - https://tickets.openmrs.org/browse/ITSM-3514 |
| 17:29:50 | *** NameFILIP has joined #openmrs |
| 17:29:50 | *** ChanServ sets mode: +v NameFILIP |
| 17:31:50 | *** r0bby is now known as robbyoconnor |
| 17:34:43 | *** NameFILIP has quit IRC |
| 17:35:43 | *** NameFILIP has joined #openmrs |
| 17:35:44 | *** ChanServ sets mode: +v NameFILIP |
| 18:54:14 | *** Mkop has quit IRC |
| 18:54:22 | *** Mkop has joined #openmrs |
| 18:59:00 | <breeze> cpower: hey |
| 19:19:53 | *** dkayiwa has joined #openmrs |
| 19:21:15 | *** davidpardz has quit IRC |
| 19:41:35 | *** harsz89 has quit IRC |
| 20:35:53 | *** NameFILIP has quit IRC |
| 20:36:03 | *** dkayiwa has quit IRC |
| 20:36:58 | *** dkayiwa has joined #openmrs |
| 20:39:21 | *** dkayiwa_ has joined #openmrs |
| 20:41:40 | *** dkayiwa has quit IRC |
| 20:41:41 | *** dkayiwa_ is now known as dkayiwa |
| 20:58:49 | *** k-joseph has quit IRC |
| 21:17:18 | *** jblaya has joined #openmrs |
| 21:19:46 | *** cospih has quit IRC |
| 21:23:48 | *** robbyoconnor has quit IRC |
| 21:24:30 | *** robbyoconnor has joined #openmrs |
| 21:24:30 | *** ChanServ sets mode: +v robbyoconnor |
| 21:24:47 | *** achint has quit IRC |
| 21:36:26 | *** davidpardz has joined #openmrs |
| 21:36:26 | *** ChanServ sets mode: +v davidpardz |
| 21:36:36 | *** NameFILIP has joined #openmrs |
| 21:36:37 | *** ChanServ sets mode: +v NameFILIP |
| 21:39:49 | *** robbyoconnor has quit IRC |
| 21:40:53 | *** NameFILIP has quit IRC |
| 21:53:28 | *** dkayiwa has quit IRC |
| 22:24:37 | *** breeze has quit IRC |
| 22:37:09 | *** NameFILIP has joined #openmrs |
| 22:37:09 | *** ChanServ sets mode: +v NameFILIP |
| 22:41:41 | *** NameFILIP has quit IRC |
| 22:48:17 | <jblaya> sunbiz, you around? |
| 23:26:16 | <jblaya> nribeka, jkeiper, hi guys, sorry, newbie maven question, but I have a module that is writing out a modulename-omod-0.5.omod i.e. it puts the omod in the filename |
| 23:26:33 | <jblaya> and then I get this error when it tries to run on openmrs Error while trying to start module |
| 23:26:33 | <jblaya> Unable to load/find moduleActivator: 'org.openmrs.module.spreadsheetimport-omod.SpreadsheetImportModuleActivator' Module: Spreadsheet Import Module |
| 23:26:54 | <jblaya> how do I get the omod out of there? |
| 23:37:36 | *** NameFILIP has joined #openmrs |
| 23:37:37 | *** ChanServ sets mode: +v NameFILIP |
| 23:41:57 | *** NameFILIP has quit IRC |
| 23:44:44 | <nribeka> the filename is in the pom file for the omod jblaya |
| 23:45:06 | <nribeka> I think there's a tag for it |
| 23:45:22 | <jblaya> nribeka, thanks, yeah, I mentioned that because I thought they would be related and I put the fileName tag in there so now it outputs the filename correct |
| 23:45:34 | <jblaya> but I still get the error for the module activator |
| 23:45:48 | <nribeka> for that fail to load, look at the config.xml |
| 23:45:50 | <jblaya> I'm guessing it shouldn't be org.openmrs.module.spreadsheetimport-omod.SpreadsheetImportModuleActivator |
| 23:46:04 | <jblaya> but rather org.openmrs.module.spreadsheetimport.SpreadsheetImportModuleActivator, without the omod, right? |
| 23:46:15 | <nribeka> see if it's doing correct string substitution |
| 23:47:08 | <jblaya> ok |
| 23:47:13 | <jblaya> nribeka, thanks will look into it |
| 23:47:27 | <nribeka> yeah, see the config file. I think the activator line refer to the omod artifact id |
| 23:47:52 | <nribeka> it should refer to artifact id of the parent pom file |
| 23:48:18 | <jblaya> yep, that's the problem |
| 23:48:27 | <jblaya> omod/pom.xml: <MODULE_PACKAGE>${project.parent.groupId}.${project.artifactId}</MODULE_PACKAGE> |
| 23:48:34 | <jblaya> let me change it and see what happens |
| 23:51:55 | <jblaya> nribeka, that was it. Thanks so much |
| 23:56:08 | <nribeka> cool |