00:02:38
|
*** dkayiwa has joined #openmrs
|
00:07:48
|
*** elliott_w has quit IRC
|
00:13:42
|
*** NameFILIP has joined #openmrs
|
00:13:42
|
*** ChanServ sets mode: +v NameFILIP
|
00:18:47
|
*** NameFILIP has quit IRC
|
00:20:57
|
*** elliott_w has joined #openmrs
|
00:20:57
|
*** ChanServ sets mode: +o elliott_w
|
00:20:58
|
*** ArcTanSusan has joined #openmrs
|
00:32:00
|
*** evmw has joined #openmrs
|
00:32:00
|
*** ChanServ sets mode: +v evmw
|
00:46:01
|
*** elliott_w has quit IRC
|
01:14:10
|
*** NameFILIP has joined #openmrs
|
01:14:11
|
*** ChanServ sets mode: +v NameFILIP
|
01:17:07
|
*** dkayiwa has quit IRC
|
01:18:31
|
*** NameFILIP has quit IRC
|
02:13:27
|
*** didymo has joined #openmrs
|
02:14:43
|
*** NameFILIP has joined #openmrs
|
02:14:44
|
*** ChanServ sets mode: +v NameFILIP
|
02:19:20
|
*** NameFILIP has quit IRC
|
02:21:21
|
*** mani_nc has joined #openmrs
|
02:21:33
|
*** mani_nc is now known as maninc
|
02:36:56
|
*** davidpardz has quit IRC
|
02:49:39
|
*** wyclif has joined #openmrs
|
02:56:39
|
*** harshadura has joined #openmrs
|
03:05:38
|
*** harshadura has quit IRC
|
03:15:15
|
*** NameFILIP has joined #openmrs
|
03:15:16
|
*** ChanServ sets mode: +v NameFILIP
|
03:19:26
|
*** NameFILIP has quit IRC
|
03:35:03
|
*** evmw has quit IRC
|
03:53:34
|
*** evmw has joined #openmrs
|
03:53:35
|
*** ChanServ sets mode: +v evmw
|
04:00:11
|
*** kavuri has joined #openmrs
|
04:00:19
|
*** kavuri has left #openmrs
|
04:15:42
|
*** NameFILIP has joined #openmrs
|
04:15:43
|
*** ChanServ sets mode: +v NameFILIP
|
04:20:32
|
*** NameFILIP has quit IRC
|
04:58:58
|
*** harshadura has joined #openmrs
|
05:03:28
|
*** davidpardz has joined #openmrs
|
05:03:42
|
*** ChanServ sets mode: +v davidpardz
|
05:03:51
|
*** davidpardz has left #openmrs
|
05:03:56
|
*** davidpardz has joined #openmrs
|
05:03:56
|
*** ChanServ sets mode: +v davidpardz
|
05:16:11
|
*** NameFILIP has joined #openmrs
|
05:16:11
|
*** ChanServ sets mode: +v NameFILIP
|
05:20:57
|
*** NameFILIP has quit IRC
|
05:21:33
|
*** wyclif has quit IRC
|
05:29:59
|
*** rnjn has joined #openmrs
|
05:57:11
|
*** NameFILIP has joined #openmrs
|
05:57:11
|
*** ChanServ sets mode: +v NameFILIP
|
06:18:35
|
*** rday has quit IRC
|
06:19:22
|
*** maninc has quit IRC
|
06:22:48
|
*** r0bby is now known as robbyoconnor
|
06:31:39
|
*** maninc has joined #openmrs
|
06:34:49
|
*** maninc has quit IRC
|
06:53:20
|
*** rnjn1 has joined #openmrs
|
06:53:20
|
*** rnjn has quit IRC
|
06:56:27
|
*** maninc has joined #openmrs
|
06:58:24
|
*** harshadura_ has joined #openmrs
|
07:03:34
|
*** rday has joined #openmrs
|
07:19:20
|
*** harshadura_ has quit IRC
|
07:20:34
|
*** NameFILIP has quit IRC
|
07:29:01
|
*** harshadura_ has joined #openmrs
|
07:30:45
|
*** maninc has quit IRC
|
07:35:19
|
*** ArcTanSusan has quit IRC
|
07:43:39
|
*** maninc has joined #openmrs
|
07:58:57
|
*** maninc has quit IRC
|
08:04:17
|
*** KC9YYQ has quit IRC
|
08:05:31
|
*** KC9YYQ has joined #openmrs
|
08:20:25
|
*** maninc has joined #openmrs
|
08:29:56
|
*** Mkop has quit IRC
|
08:30:16
|
*** Mkop has joined #openmrs
|
08:31:00
|
*** dkayiwa has joined #openmrs
|
08:41:24
|
*** rafa has joined #openmrs
|
08:41:24
|
*** ChanServ sets mode: +v rafa
|
09:00:28
|
<harshadura_> hi dkayiwa
|
09:00:34
|
<dkayiwa> harshadura_: hi
|
09:02:56
|
<harshadura_> dkayiwa: i get an error saying "(TypeError): xtb is null" from my embedded xform
|
09:03:15
|
<harshadura_> dkayiwa: when i fill the birthdate it says like that
|
09:04:29
|
<dkayiwa> harshadura_: while in the form designer, do a file save as and pastebin the contents
|
09:04:55
|
<harshadura_> ok dkayiwa
|
09:07:19
|
<harshadura_> dkayiwa: http://pastebin.com/TyVsWZEW
|
09:08:49
|
<dkayiwa> harshadura_: are you sure this is the form?
|
09:09:34
|
<harshadura_> dkayiwa: yes dkayiwa, this is just a test form for my work
|
09:09:55
|
<dkayiwa> harshadura_: what changes did you make for it to start erring?
|
09:10:40
|
<harshadura_> dkayiwa: i didn't changed the form dkayiwa
|
09:11:16
|
<dkayiwa> harshadura_: which browser?
|
09:11:26
|
<harshadura_> mozilla dkayiwa
|
09:11:39
|
<dkayiwa> harshadura_: can you try another and see?
|
09:11:47
|
<harshadura_> ok dkayiwa
|
09:16:53
|
<harshadura_> dkayiwa, Can I set a default provider, default patient and Default encounter type (lets say patient-narratives) for a single X-form, And gather all the encounters which are submitted under that encounter type ?
|
09:17:15
|
<dkayiwa> harshadura_: yes
|
09:17:25
|
<harshadura_> dkayiwa: awesome :)
|
09:19:28
|
<harshadura_> dkayiwa: i use Chrome now, when i fill the birthdate now it pops out and say "(TypeError): Cannot read property 'b' of null"
|
09:20:57
|
*** NameFILIP has joined #openmrs
|
09:20:57
|
*** ChanServ sets mode: +v NameFILIP
|
09:21:08
|
<dkayiwa> harshadura_: do you get the same error when you try fill this form for a patient under the formentry tab?
|
09:25:06
|
*** NameFILIP has quit IRC
|
09:28:37
|
<harshadura_> dkayiwa: yes dkayiwa, since this is a test form i deleted birthdate field and the err got vanished now
|
09:29:01
|
<harshadura_> dkayiwa: now when i press submit it says like "Invalid date "'today()'". Non-numeric component"
|
09:31:18
|
<harshadura_> sorry for bothering dkayiwa: this part is a bottleneck for me since i havent worked with xforms much before :)
|
09:31:48
|
*** rafa has quit IRC
|
09:32:52
|
<dkayiwa> harshadura_: do a save as and pastebin your current form
|
09:35:31
|
*** didymo has quit IRC
|
09:36:07
|
*** NameFILIP has joined #openmrs
|
09:36:07
|
*** ChanServ sets mode: +v NameFILIP
|
09:38:04
|
<harshadura_> dkayiwa: http://pastebin.com/RhrNvFSa
|
09:40:16
|
<dkayiwa> harshadura_: do you get the same error using the formentry tab on patient dashboard?
|
09:41:56
|
<harshadura_> dkayiwa: i tried it on formentry tab now: it says: ca.uhn.hl7v2.HL7Exception: Could not resolve provider with provider Id:TestProvider
|
09:42:11
|
<harshadura_> dkayiwa: but the TestProvider already exist on the Providers
|
09:42:17
|
<dkayiwa> harshadura_: you need the id not name
|
09:42:27
|
<harshadura_> ok dkayiwa
|
09:45:04
|
*** rafa has joined #openmrs
|
09:45:04
|
*** ChanServ sets mode: +v rafa
|
09:48:15
|
<harshadura_> dkayiwa: i changed both locationID, providerID. now it says "could not insert: [org.openmrs.Encounter]" when i press submit
|
09:48:48
|
<dkayiwa> harshadura_: pastebin the stack trace
|
09:49:20
|
<harshadura_> dkayiwa: http://pastebin.com/wZh6P7rb
|
09:50:48
|
<dkayiwa> harshadura_: is that under the formentry tab?
|
09:50:59
|
<harshadura_> yes dkayiwa
|
09:51:10
|
<dkayiwa> harshadura_: pastebin the form again
|
09:51:59
|
<dkayiwa> harshadura_: and what encounter type has the form got on the form schema screen?
|
09:52:18
|
<harshadura_> dkayiwa: http://pastebin.com/vhMB4sKZ
|
09:54:08
|
<harshadura_> encounter type called "dfg" dkayiwa
|
09:54:35
|
<dkayiwa> harshadura_: can you send me a screen shot of the formschema screen for this form?
|
09:55:54
|
<harshadura_> dkayiwa: http://awesomescreenshot.com/0fb1gei12b
|
09:56:54
|
<dkayiwa> harshadura_: how many encounter types do you have in your system?
|
09:57:26
|
<harshadura_> only 1 dkayiwa
|
09:57:47
|
<dkayiwa> harshadura_: and which version of the xforms module?
|
09:58:08
|
<harshadura_> dkayiwa: xforms 4.2.1.0
|
09:59:01
|
<dkayiwa> harshadura_: so you have no demo data in your database. correct?
|
09:59:22
|
<harshadura_> yes dkayiwa: i have no demo data
|
09:59:34
|
<dkayiwa> harshadura_: ok
|
10:01:03
|
<dkayiwa> harshadura_: and which version of openmrs?
|
10:01:34
|
<harshadura_> dkayiwa: Version: 1.9.3
|
10:02:18
|
*** rday has quit IRC
|
10:02:46
|
<dkayiwa> harshadura_: whats the uuid of this form?
|
10:03:18
|
<harshadura_> dkayiwa: 19a1a60a-bca9-46b8-8404-2dd1e25b1736
|
10:04:38
|
<dkayiwa> harshadura_: where are you getting it from?
|
10:05:04
|
<harshadura_> from the form dkayiwa: <formxmlns:openmrs="formentry.infopath_server_urlcannotbeempty/moduleServlet/formentry/forms/schema/1-1"xmlns:xd="http://schemas.microsoft.com/office/infopath/2003"id="1"name="Test"version="1"uuid="19a1a60a-bca9-46b8-8404-2dd1e25b1736">
|
10:05:31
|
<dkayiwa> harshadura_: the on i was is for the actual openmrs form
|
10:07:28
|
<harshadura_> dkayiwa: sorry, how can i get that ?
|
10:07:37
|
<dkayiwa> harshadura_: in the form table
|
10:09:04
|
<harshadura_> hmm sorry dkayiwa: did u meant. admin -> Forms -> Manage forms ?
|
10:09:49
|
<dkayiwa> harshadura_: the form table
|
10:13:39
|
<harshadura_> dkayiwa: sorry, where is the form table ?
|
10:14:00
|
<dkayiwa> harshadura_: where is the concept table? :)
|
10:14:33
|
<harshadura_> :(
|
10:15:00
|
<harshadura_> dkayiwa: did u meant the mysql table
|
10:15:19
|
<dkayiwa> harshadura_: what do you think? :)
|
10:17:53
|
<harshadura_> dkayiwa: sorry, no idea :( here is the UUID of this form taken from mysql form table: 19a1a60a-bca9-46b8-8404-2dd1e25b1736
|
10:18:16
|
<dkayiwa> harshadura_: thats all i wanted :)
|
10:18:44
|
<harshadura_> dkayiwa: the question was confusing xD
|
10:18:56
|
<dkayiwa> harshadura_: what the value of the encounter_type feld for this form in that table?
|
10:19:17
|
<harshadura_> if you have told something like db table it wont happen xD
|
10:20:47
|
<harshadura_> dkayiwa: encounter type is NULL
|
10:21:21
|
<dkayiwa> harshadura_: when creating this form, did you select an encounter type?
|
10:21:47
|
<harshadura_> dkayiwa: hmm i think dkayiwa
|
10:22:10
|
<harshadura_> dkayiwa: i think i have selected
|
10:22:16
|
<dkayiwa> harshadura_: you either forgot or openmrs is buggy :)
|
10:22:28
|
<harshadura_> xD
|
10:22:43
|
<harshadura_> dkayiwa: shall i update it via DB now ?
|
10:22:54
|
<dkayiwa> harshadura_: no. the user interface
|
10:24:06
|
<harshadura_> dkayiwa: in user interface (admin -> Forms -> Manage forms )its already assigned to a encounter type
|
10:24:27
|
<dkayiwa> harshadura_: can you save again?
|
10:24:38
|
<dkayiwa> harshadura_: on the form schema
|
10:24:49
|
<dkayiwa> harshadura_: then check the database again to see if its saved
|
10:26:37
|
<harshadura_> dkayiwa: not it got saved in Database
|
10:26:47
|
<harshadura_> dkayiwa: now*
|
10:26:49
|
<harshadura_> sorry
|
10:26:59
|
<dkayiwa> harshadura_: submit the form again
|
10:27:05
|
<dkayiwa> harshadura_: the xform
|
10:27:10
|
<harshadura_> ok dkayiwa
|
10:28:36
|
<harshadura_> it got saved in formentry tab dkayiwa :)
|
10:28:46
|
<harshadura_> but not in my embedded form
|
10:29:11
|
<dkayiwa> harshadura_: what error do you get in the embedded form?
|
10:29:29
|
<harshadura_> dkayiwa: in the embedded form it says "Invalid date "'today()'". Non-numeric component"
|
10:30:11
|
<harshadura_> dkayiwa: error log: http://pastebin.com/ANAcg7N5
|
10:41:33
|
<dkayiwa> harshadura_: did you supply the data div values in your jsp?
|
10:42:07
|
<dkayiwa> harshadura_: date div values
|
10:43:07
|
<harshadura_> dkayiwa: do i need to supply them on java controller ?
|
10:43:26
|
<dkayiwa> harshadura_: do what the xforms module does
|
10:47:25
|
<harshadura_> dkayiwa: yes i need to pass them in controller i will check that :)
|
10:57:22
|
<harshadura_> thank you very much dkayiwa, now the embedded form creates a new encounter :)
|
11:01:56
|
<dkayiwa> harshadura_: excellent :)
|
11:22:25
|
<harshadura_> dkayiwa: lil issue, when i click on a saved encounter via encounter interface it just shows a blank screen
|
11:22:42
|
<harshadura_> something like this URL: http://localhost:8088/openmrs/admin/encounters/encounterDisplay.list?encounterId=5
|
11:23:14
|
<dkayiwa> harshadura_: because you do not have a single OBS on your form
|
11:28:23
|
*** dkayiwa_ has joined #openmrs
|
11:29:07
|
*** dkayiwa has quit IRC
|
11:29:08
|
*** dkayiwa_ is now known as dkayiwa
|
11:37:10
|
*** k-joseph has joined #openmrs
|
11:38:48
|
<harshadura_> dkayiwa: lil issue, my embedded xform gets saved, but it gets saved with the default values which i have entered in form designer and it doesn;t include my changes to text fields when i display the encounter
|
11:39:17
|
<dkayiwa> harshadura_: which text field
|
11:39:33
|
<harshadura_> all fields dkayiwa
|
11:39:43
|
<dkayiwa> harshadura_: like which
|
11:39:56
|
<harshadura_> dkayiwa: like FAMILY NAME
|
11:40:22
|
<dkayiwa> harshadura_: that is not an observation
|
11:40:47
|
<dkayiwa> harshadura_: observation go under the OBS section on the form schema screen
|
11:41:27
|
<suranga> rafa: mm.. helllooo
|
11:41:44
|
<harshadura_> dkayiwa: do i have to mention it on the schema -> OBS section
|
11:41:48
|
<rafa> suranga: hey
|
11:41:52
|
<suranga> rafa: I was wondering if you had found any clue as to my moduleList problem :(
|
11:42:13
|
<rafa> suranga: yes, I replied to you right after
|
11:42:17
|
<suranga> rafa: im rather clueless :(
|
11:42:19
|
<rafa> suranga: I think you went away
|
11:42:25
|
<suranga> oh, you did ?
|
11:42:27
|
<suranga> ooops
|
11:42:37
|
<rafa> suranga: yes, just look up the irc history
|
11:42:50
|
<dkayiwa> harshadura_: https://wiki.openmrs.org/display/docs/XForms+Module+User+Guide
|
11:42:51
|
<OpenMRSBot> <http://ln-s.net/8afL> (at wiki.openmrs.org)
|
11:43:04
|
<suranga> rafa: wooops /me goes back
|
11:43:54
|
*** k-joseph has quit IRC
|
11:44:19
|
*** k-joseph has joined #openmrs
|
11:48:50
|
*** k-joseph has quit IRC
|
11:54:55
|
*** k-joseph has joined #openmrs
|
11:58:20
|
*** GitHub141 has joined #openmrs
|
11:58:20
|
<GitHub141> [openmrs-core] dkayiwa pushed 1 new commit to master: http://git.io/bir8pw
|
11:58:20
|
<GitHub141> openmrs-core/master ea4e844 dkayiwa: Cannot find concept by id in concept auto complete - TRUNK-3893
|
11:58:20
|
*** GitHub141 has left #openmrs
|
12:01:47
|
*** k-joseph has quit IRC
|
12:02:34
|
*** GitHub153 has joined #openmrs
|
12:02:34
|
<GitHub153> [openmrs-core] dkayiwa pushed 1 new commit to 1.9.x: http://git.io/VboJQg
|
12:02:34
|
<GitHub153> openmrs-core/1.9.x 46d1bfb dkayiwa: Cannot find concept by id in concept auto complete - TRUNK-3893(cherry picked from commit ea4e8449dac09f670d580eaabda2c5b756f2fdb3)
|
12:02:34
|
*** GitHub153 has left #openmrs
|
12:06:24
|
*** GitHub183 has joined #openmrs
|
12:06:24
|
<GitHub183> [openmrs-core] dkayiwa pushed 1 new commit to 1.8.x: http://git.io/xKKkAw
|
12:06:24
|
<GitHub183> openmrs-core/1.8.x ef821ed dkayiwa: Cannot find concept by id in concept auto complete - TRUNK-3893(cherry picked from commit ea4e8449dac09f670d580eaabda2c5b756f2fdb3)
|
12:06:24
|
*** GitHub183 has left #openmrs
|
12:10:49
|
*** travis-ci has joined #openmrs
|
12:10:49
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [ea4e844] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/8618389
|
12:10:49
|
*** travis-ci has left #openmrs
|
12:10:53
|
<OpenMRSBot> <http://ln-s.net/-L$O> (at travis-ci.org)
|
12:17:31
|
*** k-joseph has joined #openmrs
|
12:21:31
|
*** elliott_w has joined #openmrs
|
12:21:31
|
*** ChanServ sets mode: +o elliott_w
|
12:41:40
|
*** cospih has joined #openmrs
|
12:49:46
|
*** wyclif has joined #openmrs
|
12:57:37
|
*** ryates has joined #openmrs
|
12:57:37
|
*** ChanServ sets mode: +o ryates
|
13:32:42
|
*** breeze has joined #openmrs
|
14:02:30
|
<cpower> Hello everyone, welcome to the week where we blow everything up here in America.
|
14:02:47
|
<cpower> Are we ready to Scrum?
|
14:03:27
|
<cpower> Silence is golden
|
14:03:41
|
<cpower> !scrumon Uncle Sam
|
14:03:41
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster Uncle Sam- you may begin when ready.
|
14:03:46
|
<dkayiwa> cpower: no it is diamond :)
|
14:04:20
|
<cpower> dkayiwa: at this point you are probably right
|
14:04:31
|
<dkayiwa> cpower: :)
|
14:04:52
|
<cpower> Order: rafa , wyclif , dkayiwa , breeze , and anyone who would like to update including GSOC students.
|
14:05:16
|
<rafa> Today:
|
14:05:17
|
<rafa> * Working on RA-91 Build a Dispensing App
|
14:05:17
|
<rafa> https://tickets.openmrs.org/browse/RA-91
|
14:05:17
|
<rafa> * Working on RA-92 Build dispensing form with details
|
14:05:17
|
<rafa> https://tickets.openmrs.org/browse/RA-92
|
14:05:17
|
<rafa> No blockers.
|
14:06:03
|
<wyclif> Friday:
|
14:06:04
|
<wyclif> -Revisit tickets back in dev and fix birthdate not getting saved when registering a patient
|
14:06:06
|
<wyclif> -Updated uicommons, coreapps and reference application modules to support editing patient data
|
14:06:07
|
<wyclif> -Weekly chat with Ishara on validation module
|
14:06:09
|
<wyclif> Monday:
|
14:06:10
|
<wyclif> -Add feature toggle for displaying edit buttons on patient dashboard
|
14:06:11
|
<wyclif> -Fix issues to do with RA-69- Validation of registration
|
14:06:12
|
<wyclif> -pick another task
|
14:06:13
|
<wyclif> Blockers: None
|
14:06:25
|
<dkayiwa> Committed: Cannot find concept by id in concept auto complete - TRUNK-3893
|
14:06:25
|
<dkayiwa> Curated more tickets
|
14:06:25
|
<dkayiwa> Going to do some code reviews
|
14:06:25
|
<dkayiwa> No blockers
|
14:06:53
|
*** harsz89 has joined #openmrs
|
14:06:53
|
*** ChanServ sets mode: +v harsz89
|
14:08:06
|
<cpower> breeze: you are up
|
14:09:44
|
*** rnjn1 has quit IRC
|
14:10:16
|
<cpower> ok and that's that
|
14:11:02
|
<cpower> Annoucements: Design call will be more on Dispensing I'm sure, and we also need to go into a discussion on testing.
|
14:11:28
|
<cpower> Please let me know if there are any other topics out there
|
14:11:32
|
<cpower> !scrumoff
|
14:11:32
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:12:33
|
<dkayiwa> cpower: there are a series of tickets that are in Needs Design stage. May be we can drop in one at a time whenever the agenda is not fat :)
|
14:13:21
|
<cpower> dkayiwa: Are these intro tickets, bug tickets?
|
14:13:40
|
<dkayiwa> cpower: bugs and new features
|
14:14:00
|
<dkayiwa> cpower: normally intro tickets are too simple to need design :)
|
14:14:28
|
<h3llborn> rafa: good morning :P
|
14:14:33
|
<h3llborn> rafa: or evening haha
|
14:14:35
|
<cpower> dkayiwa: Is there a list of these tickets somewhere?
|
14:14:43
|
<rafa> h3llborn: or just hey! ;)
|
14:14:50
|
<h3llborn> rafa: or that :P
|
14:15:11
|
<rafa> h3llborn: how is the research going?
|
14:16:00
|
<h3llborn> rafa: good! Im testing 2 windows installers today, then gonna test whats the easiest for mac and lastly something for ubuntu
|
14:16:04
|
<h3llborn> rafa: hbu?
|
14:16:21
|
<dkayiwa> cpower: just a jira query like this: project = TRUNK and status=Design
|
14:16:36
|
<rafa> h3llborn: have you checked what atlassian uses?
|
14:16:58
|
<h3llborn> rafa: for mac? or windows?
|
14:17:12
|
<rafa> h3llborn: for both
|
14:17:59
|
<h3llborn> rafa: I'm not sure but I will take a look, thanks for the heads up there :)
|
14:18:39
|
<rafa> h3llborn: cool, if you don't find it easily I can ask my friend at atlassian
|
14:19:55
|
<h3llborn> rafa: alright sounds good! I'm sure I can figure it out, but if not then I'll just message you. btw did you get a chance to take a look at my updated commit for trunk-4012?
|
14:20:07
|
<rafa> h3llborn: not yet
|
14:20:19
|
<rafa> h3llborn: I reserved time for tomorrow morning
|
14:21:12
|
<h3llborn> rafa: ok sounds good! well I'm gonna go a head and switch computers now for mac installer :P
|
14:21:32
|
<h3llborn> rafa: if I don't figure out what atlassian uses I will email/msg you depending if you are on irc or not
|
14:21:40
|
*** harshadura_ has quit IRC
|
14:22:25
|
<rafa> h3llborn: cool, ttyl, have a productive day :)
|
14:22:33
|
<h3llborn> rafa: thanks! you too :)
|
14:22:51
|
<rafa> h3llborn: thanks!
|
14:44:27
|
*** harshadura has quit IRC
|
14:49:56
|
*** dkayiwa has left #openmrs
|
14:53:10
|
*** dkayiwa has joined #openmrs
|
14:56:17
|
*** harshadura has joined #openmrs
|
14:56:34
|
*** rafa has quit IRC
|
14:57:33
|
*** davidpardz has left #openmrs
|
14:58:53
|
*** rnjn has joined #openmrs
|
15:07:52
|
*** cospih has quit IRC
|
15:08:43
|
*** cospih has joined #openmrs
|
15:28:47
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Kenya UI Library 1.3.17 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=kenyaui&version=&1.3.17>
|
15:35:57
|
*** rnjn has quit IRC
|
15:36:54
|
*** cospih_ has joined #openmrs
|
15:37:43
|
*** cospih has quit IRC
|
15:50:48
|
*** rnjn has joined #openmrs
|
16:30:13
|
*** maninc has quit IRC
|
16:45:10
|
*** dkayiwa has quit IRC
|
16:54:46
|
*** dkayiwa has joined #openmrs
|
17:02:01
|
*** NameFILIP has quit IRC
|
17:04:54
|
*** breeze has quit IRC
|
17:09:14
|
*** davidpardz has joined #openmrs
|
17:09:15
|
*** ChanServ sets mode: +v davidpardz
|
17:12:41
|
*** dkayiwa has quit IRC
|
17:18:00
|
*** bhashitha has joined #openmrs
|
17:26:02
|
*** dkayiwa has joined #openmrs
|
17:28:40
|
*** dkayiwa has quit IRC
|
17:31:16
|
*** sashrika has joined #openmrs
|
17:33:07
|
*** NameFILIP has joined #openmrs
|
17:33:10
|
*** ChanServ sets mode: +v NameFILIP
|
17:41:34
|
*** NameFILIP has quit IRC
|
17:43:44
|
<harsz89> hi jkeiper
|
17:43:55
|
<jkeiper> hi harsz89
|
17:44:13
|
*** sashrika has quit IRC
|
17:44:20
|
<harsz89> i have put d manager view ui in the page
|
17:44:27
|
<harsz89> have any comments?
|
17:44:52
|
<harsz89> https://wiki.openmrs.org/display/projects/Data+Integrity+Workflow+Module
|
17:46:49
|
*** dkayiwa has joined #openmrs
|
17:49:31
|
<jkeiper> harsz89: yes, one moment
|
17:49:44
|
<harsz89> jkeiper, yeas sure :D
|
17:50:16
|
<harsz89> jkeiper, just want to know is it's okey with you
|
17:50:32
|
<jkeiper> harsz89: for the record id ... i agree, it's confusing. ultimately it would be nice for it to mimic what we see in JIRA but let's not add too much work.
|
17:50:50
|
<harsz89> jkeiper, there are toggle divs for assign and remove assignees
|
17:51:41
|
<jkeiper> harsz89: 1) i would make the user picker an autocomplete not a dropdown (easier)
|
17:51:55
|
<jkeiper> harsz89: 2) i would put the assignment into a modal dialog
|
17:52:29
|
<harsz89> jkeiper, thanks jkeiper i'll do them
|
17:52:33
|
<jkeiper> harsz89: 3) I would call "Remove Assignees" --> "Unassign"
|
17:54:23
|
<harsz89> jkeiper, sure i'll do the changes
|
17:54:34
|
<jkeiper> ok
|
17:54:34
|
<jkeiper> :-)
|
17:55:00
|
<harsz89> jkeiper, for a whole check summary view, is it okey to have tab view or just a link for another page?
|
17:55:15
|
<downey> harsz89 / jkeiper - I wouldn't rely on the OpenMRS JIRA workflow as a standard. Just use what makes sense. :)
|
17:55:21
|
<jkeiper> harsz89: you tell me ;-)
|
17:55:38
|
<jkeiper> downey: it's not the workflow, it's the naming of an issue ... like DINT-3
|
17:56:00
|
<downey> !ticket DINT-3
|
17:56:01
|
<OpenMRSBot> downey: [#DINT-3] Option of marking that patient record not to show up on next data integrity run - OpenMRS JIRA - https://tickets.openmrs.org/browse/DINT-3
|
17:56:06
|
<harsz89> jkeiper, tab view is better i'll work on it too
|
17:56:15
|
<jkeiper> i think we will just start with the record id for now and render names for them later
|
17:56:31
|
<jkeiper> downey: DINT-3 as an example of an issue name (key)
|
17:58:21
|
<harsz89> jkeiper, okey let's figure it out later wht's better to display as the record id :)
|
17:58:34
|
<harsz89> jkeiper, i'll do the necessary changes
|
17:58:49
|
<harsz89> jkeiper, thanks a lot for the feedback jkeiper :)
|
17:59:01
|
<jkeiper> harsz89: np
|
17:59:35
|
<suranga> um... hi dkayiwa
|
17:59:43
|
<dkayiwa> suranga: hi
|
17:59:45
|
<suranga> dkayiwa: can I ask a question ? :)
|
17:59:51
|
<dkayiwa> suranga: ok
|
18:03:12
|
<suranga> dkayiwa: thanks :-)
|
18:03:15
|
<suranga> dkayiwa: im having a jquery dialog to confirm a decision.
|
18:03:15
|
<suranga> When the jquery is called, it is supposed to display the confirmation box, and allow users to make a desicion.
|
18:03:15
|
<suranga> the code for this confirmation box can be seen at
|
18:03:20
|
<suranga> http://pastebin.com/UG7yk5q5
|
18:03:28
|
<suranga> dkayiwa:
|
18:03:28
|
<suranga> now the problem is, the js function doesnt seem to be synchornous.
|
18:03:28
|
<suranga> for example, it will enter the js method on line 1, and exit at line 41 before the confirmation box is diplayed. therefore, the users decison (ok, cancel) is not really being enforced...
|
18:04:08
|
<dkayiwa> suranga: can i come back after an hour and start from exactly there? :)
|
18:04:23
|
<suranga> dkayiwa: oh, sure. dinner time ?
|
18:04:44
|
<dkayiwa> suranga: hahaha. rushing somewhere :)
|
18:05:10
|
<suranga> dkayiwa: not a problem. I will stay online and stalk :P
|
18:12:57
|
*** harsz89 has quit IRC
|
18:14:55
|
*** dkayiwa has quit IRC
|
18:17:03
|
*** harsz89 has joined #openmrs
|
18:27:37
|
*** davidpardz has quit IRC
|
18:33:30
|
*** bhashitha has quit IRC
|
18:36:26
|
*** k-joseph_ has joined #openmrs
|
18:36:42
|
*** k-joseph has quit IRC
|
18:38:01
|
*** NameFILIP has joined #openmrs
|
18:38:05
|
*** ChanServ sets mode: +v NameFILIP
|
18:42:13
|
*** NameFILIP has quit IRC
|
18:43:32
|
*** k-joseph_ has quit IRC
|
18:55:15
|
*** k-joseph has joined #openmrs
|
19:09:58
|
*** rday has joined #openmrs
|
19:11:16
|
*** dkayiwa has joined #openmrs
|
19:15:37
|
<suranga> um.. hi dkayiwa ...
|
19:15:44
|
<dkayiwa> suranga: hi
|
19:15:45
|
<k-joseph> dkayiwa: hi
|
19:16:11
|
<suranga> dkayiwa: not enough dkayiwa 's to go around :)
|
19:17:19
|
<dkayiwa> k-joseph: hi
|
19:20:21
|
<k-joseph> dkayiwa: i have some issue with one of your posted comments on TRUNK-3986,
|
19:20:36
|
<dkayiwa> !ticket TRUNK-3986
|
19:20:39
|
<k-joseph> that is, i have not added a test to do some thing as that according to your comment, that says; Do you think you can also add a test to confirm the service layer will not save a ConceptNameTag without this validation?
|
19:20:39
|
<OpenMRSBot> dkayiwa: [#TRUNK-3986] Add ConceptNameTagValidator to Core API - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3986
|
19:21:08
|
<k-joseph> is it possible for you to make it further clear for me here? thanks
|
19:21:26
|
<dkayiwa> k-joseph: do you know how i can save a ConceptNameTag?
|
19:21:26
|
*** davidpardz has joined #openmrs
|
19:21:26
|
*** ChanServ sets mode: +v davidpardz
|
19:21:51
|
<k-joseph> dkayiwa: am not sure about that
|
19:22:27
|
<dkayiwa> k-joseph: can you try check for like 10 mins
|
19:22:37
|
<dkayiwa> k-joseph: then tell me if you fail to find it out
|
19:22:49
|
<k-joseph> dkayiwa: ok, checking it out
|
19:22:55
|
<dkayiwa> suranga: did you fix your thing? :)
|
19:23:16
|
<suranga> dkayiwa: im afraid not. did you have a chance to look at it yet ?
|
19:23:54
|
<suranga> dkayiwa: i suspect this is breaking because im using an ajax call to obtain data. I did try setting async: false in the ajax, call, but that doesnt change anything :
|
19:24:25
|
<dkayiwa> suranga: is this a module that you are working on?
|
19:25:00
|
<suranga> dkayiwa: um.. oh no, this is https://tickets.openmrs.org/browse/TRUNK-4011
|
19:26:21
|
<dkayiwa> suranga: looking at your pastebin link now....
|
19:26:38
|
<suranga> dkayiwa: :) :) :)
|
19:27:28
|
<dkayiwa> suranga: on which line do you want it to block?
|
19:28:10
|
<suranga> dkayiwa: what happens is that the fuction returns false (at the very end)
|
19:28:28
|
<suranga> witout waiting for the ser to select an option from the jquery dialog box
|
19:28:56
|
<suranga> dkayiwa: I want it to sync to the dialogbox and return the result of the users choice there...
|
19:29:36
|
<dkayiwa> suranga: does it display the dialog box?
|
19:30:16
|
<suranga> dkayiwa: yes, but it has returned from the method before that, so selecting 'yes' or 'no' just shuts down the dialog box :(
|
19:30:38
|
<k-joseph> dkayiwa: hi
|
19:31:18
|
<dkayiwa> k-joseph: hi
|
19:31:52
|
<dkayiwa> suranga: did you expect select yes or no to leave the dialog box open?
|
19:32:08
|
<k-joseph> dkayiwa: i think i can save a conceptnametag by implementing the public ConceptNameTag saveConceptNameTag(ConceptNameTag nameTag); of the ConceptService interface!!!
|
19:32:28
|
<suranga> dkayiwa: nopz, it should close the box, and them return. I trief multiple approaches, but nothing seems to work :(
|
19:33:13
|
<dkayiwa> k-joseph: isnt there already a method for saving it?
|
19:33:30
|
<dkayiwa> suranga: so it does not close it?
|
19:33:44
|
<k-joseph> dkayiwa: let me check again
|
19:34:31
|
<suranga> dkayiwa: im sorry, the pastie may be ambiguous because only the cancel has a return parameter
|
19:34:51
|
<suranga> dkayiwa: the dialog box does close, but the return function doesnt seem to have any effect
|
19:35:46
|
<suranga> dkayiwa: thanks to the alerts ive added, I can see that the methods returns its default value at the same time the dialog box is displayed...
|
19:35:56
|
<k-joseph> dkayiwa: i think it is there in conceptserviceimpl
|
19:36:37
|
<dkayiwa> k-joseph: so can you create a unit test which confirms that a faulty conceptNameTag will not save?
|
19:37:05
|
<dkayiwa> suranga: ok
|
19:37:59
|
<suranga> dkayiwa: hope that makes sense. i tried adding async: false, but no errect :)
|
19:38:05
|
<suranga> *effect, sorry
|
19:38:33
|
*** NameFILIP has joined #openmrs
|
19:38:33
|
*** ChanServ sets mode: +v NameFILIP
|
19:38:37
|
<dkayiwa> suranga: i think am now lost. i do not seem to understand what problem you are facing :)
|
19:38:58
|
<suranga> dkayiwa: im sorry, let me try to explain again
|
19:39:17
|
<suranga> basically, the dialog box is used to confirm wether to shut down a module or not
|
19:39:31
|
<suranga> this is adjuged via the true / false value it returns
|
19:40:16
|
<suranga> the problem is that the dialog box is displayed, but the function returns early, so the response is always set to the default 'false'
|
19:42:30
|
*** dkayiwa_ has joined #openmrs
|
19:42:47
|
<dkayiwa_> suranga: sorry i got disconnected
|
19:42:47
|
*** dkayiwa has quit IRC
|
19:42:48
|
*** dkayiwa_ is now known as dkayiwa
|
19:43:49
|
*** NameFILIP has quit IRC
|
19:44:44
|
<dkayiwa> suranga: can i see a pastebin with your current changes?
|
19:45:24
|
<suranga> dkayiwa: you mean the entire class, and not just the js method ?
|
19:45:48
|
<dkayiwa> suranga: is that in a jsp?
|
19:46:48
|
<suranga> dkayiwa: theres also a controller being introduced, im afraid
|
19:47:18
|
<dkayiwa> suranga: two pastebin links do not hurt :)
|
19:47:48
|
<suranga> dkayiwa: this is the modulelist.jsp file http://pastebin.com/gD86KiYM
|
19:47:56
|
<suranga> dkayiwa: ive introduced the validateDependencies() method
|
19:49:03
|
<dkayiwa> suranga: ok
|
19:50:23
|
<suranga> dkayiwa: and my new controller class
|
19:50:59
|
<dkayiwa> suranga: so is your problem that alert('exiting' + result); is displayed before the dialog box?
|
20:04:35
|
<suranga> dkayiwa: im sorry, it seems my second message was dropped
|
20:04:52
|
<suranga> the controller class is http://pastebin.com/FJuzJ9LH
|
20:05:31
|
<dkayiwa> member:suranga: so is your problem that alert('exiting' + result); is displayed before the dialog box?
|
20:08:47
|
*** suranga__ has joined #openmrs
|
20:08:58
|
<suranga__> dkayiwa, im sorry, my connection failed
|
20:09:10
|
<suranga__> did you get the link to the controller pastie ? http://pastebin.com/FJuzJ9LH
|
20:11:27
|
<dkayiwa> suranga__: yes
|
20:11:29
|
<dkayiwa> member:suranga: so is your problem that alert('exiting' + result); is displayed before the dialog box?
|
20:12:42
|
<suranga__> dkayiwa, yes, and its always set to false, which is the default value
|
20:12:57
|
<suranga__> it never gets set to true event when the user selects it
|
20:13:03
|
*** rday has quit IRC
|
20:18:39
|
*** breeze has joined #openmrs
|
20:24:37
|
*** suranga__ has quit IRC
|
20:26:12
|
*** elliott_w has quit IRC
|
20:39:02
|
*** NameFILIP has joined #openmrs
|
20:39:02
|
*** ChanServ sets mode: +v NameFILIP
|
20:43:21
|
*** NameFILIP has quit IRC
|
20:55:08
|
*** dkayiwa_ has joined #openmrs
|
20:56:37
|
*** dkayiwa has quit IRC
|
20:56:38
|
*** dkayiwa_ is now known as dkayiwa
|
21:01:02
|
*** k-joseph has quit IRC
|
21:01:30
|
*** wyclif has quit IRC
|
21:20:28
|
*** dkayiwa_ has joined #openmrs
|
21:23:19
|
*** dkayiwa has quit IRC
|
21:23:19
|
*** dkayiwa_ is now known as dkayiwa
|
21:26:13
|
*** NameFILIP has joined #openmrs
|
21:26:13
|
*** ChanServ sets mode: +v NameFILIP
|
21:28:27
|
*** breeze has quit IRC
|
21:36:28
|
*** NameFILIP has quit IRC
|
21:38:45
|
*** wyclif has joined #openmrs
|
21:52:48
|
*** didymo has joined #openmrs
|
22:37:10
|
*** NameFILIP has joined #openmrs
|
22:37:10
|
*** ChanServ sets mode: +v NameFILIP
|
22:41:54
|
*** NameFILIP has quit IRC
|
23:00:30
|
*** dkayiwa has quit IRC
|
23:37:40
|
*** NameFILIP has joined #openmrs
|
23:37:40
|
*** ChanServ sets mode: +v NameFILIP
|
23:42:31
|
*** NameFILIP has quit IRC
|