IRC Chat : 2013-05-22 - OpenMRS

00:01:23 *** dkayiwa has quit IRC
00:08:50 *** cospih has quit IRC
00:13:55 *** ajwath has joined #openmrs
00:15:55 *** ajwath has quit IRC
00:18:42 *** Mkop has quit IRC
00:30:17 *** gihanchanuka has joined #openmrs
00:39:33 *** Ajwath has joined #openmrs
00:47:10 *** h3llborn has joined #openmrs
01:00:06 *** wyclif has joined #openmrs
01:07:18 *** robbyoconnor has quit IRC
01:07:49 *** robbyoconnor has joined #openmrs
01:07:49 *** ChanServ sets mode: +v robbyoconnor
01:14:29 *** h3llborn has quit IRC
01:36:20 *** davidpardz has quit IRC
01:38:26 *** wyclif has quit IRC
01:50:51 *** Ajwath has quit IRC
02:02:32 *** rday has joined #openmrs
02:26:19 *** rday has quit IRC
02:26:38 *** rday has joined #openmrs
02:32:05 *** harshadura has joined #openmrs
02:54:57 *** NameFILIP has joined #openmrs
03:20:35 *** ruwanego has quit IRC
03:21:32 *** ruwanego has joined #openmrs
03:28:37 *** NameFILI_ has joined #openmrs
03:31:20 *** NameFILIP has quit IRC
04:21:17 *** h3llborn has joined #openmrs
04:27:29 *** k-joseph has joined #openmrs
04:45:21 *** h3llborn has quit IRC
04:50:22 *** kavuri has joined #openmrs
04:52:08 *** k-joseph has quit IRC
05:41:27 *** harshadura_ has joined #openmrs
05:41:33 *** harshadura has quit IRC
05:51:12 <akwatuha_> hi dkayiwa
05:55:52 *** gihanchanuka has quit IRC
06:09:31 *** DraggonZ has joined #openmrs
06:34:59 *** rcrichton has joined #openmrs
06:46:09 *** sagar has joined #openmrs
06:47:32 *** sagar has quit IRC
06:48:11 *** geekgugi has joined #openmrs
07:04:35 *** ibewes has joined #openmrs
07:27:36 *** ibewes has quit IRC
07:39:44 *** ibewes has joined #openmrs
07:45:28 *** ibewes has quit IRC
07:45:55 *** ibewes has joined #openmrs
08:03:54 *** KC9YYQ has quit IRC
08:04:40 *** KC9YYQ has joined #openmrs
08:25:43 *** Sateesh has joined #openmrs
08:28:49 *** kavuri has quit IRC
08:38:20 *** Ajwath has joined #openmrs
08:39:13 *** Ajwath has quit IRC
09:03:54 *** dkayiwa has joined #openmrs
09:19:40 *** Sateesh has quit IRC
09:33:01 *** geekgugi has quit IRC
09:41:40 *** Sateesh has joined #openmrs
09:42:25 *** jennparise has joined #openmrs
10:15:06 *** GitHub178 has joined #openmrs
10:15:06 <GitHub178> [openmrs-core] dkayiwa pushed 1 new commit to 1.9.x: http://git.io/vHm6NA
10:15:06 <GitHub178> openmrs-core/1.9.x 3d2266e suranga: fixes to trunk 3991...
10:15:06 *** GitHub178 has left #openmrs
10:18:30 <akwatuha_> hi dkayiwa
10:18:40 <dkayiwa> akwatuha_: hi
10:20:10 <akwatuha_> dkayiwa: we had a discussion with Jeremy and realized we need the fix for https://tickets.openmrs.org/browse/XFRM-120 committed
10:20:29 <dkayiwa> akwatuha_: i committed it :)
10:21:59 <akwatuha_> dkayiwa: okay, thanks. led me download the latest Xforms and test.
10:22:22 <dkayiwa> akwatuha_: its not release. so you need to build from source
10:23:46 <akwatuha_> okay
11:10:34 *** NameFILI_ has quit IRC
11:25:32 *** GitHub145 has joined #openmrs
11:25:33 <GitHub145> [openmrs-core] dkayiwa pushed 2 new commits to master: http://git.io/U1PxTg
11:25:33 <GitHub145> openmrs-core/master 9add0e2 Bhashitha: TRUNK-3980: Add back button support for patient search page
11:25:33 <GitHub145> openmrs-core/master 76d93ba dkayiwa: Merge pull request #315 from bhashitha/TRUNK-3980...
11:25:33 *** GitHub145 has left #openmrs
12:00:22 *** harshadura has joined #openmrs
12:03:16 *** harshadura_ has quit IRC
12:29:50 *** Sateesh has quit IRC
12:31:28 *** harshadura_ has joined #openmrs
12:32:10 *** gauravsaini03 has joined #openmrs
12:33:09 *** harshadura has quit IRC
12:35:45 *** cospih has joined #openmrs
12:39:16 *** harshadura_ has quit IRC
12:39:30 *** k-joseph has joined #openmrs
13:01:12 *** DraggonZ has quit IRC
13:03:18 *** DraggonZ has joined #openmrs
13:09:36 *** gauravsaini03 has quit IRC
13:09:51 *** gauravsaini03 has joined #openmrs
13:23:31 *** Ajwath has joined #openmrs
13:37:59 <gauravsaini03> dkayiwa: I have completed all changes, you have mentioned in git comments
13:38:15 <dkayiwa> gauravsaini03: i need you to do the testing
13:38:26 <dkayiwa> gauravsaini03: am insisting because i have tested myself here
13:42:54 <gauravsaini03> dkayiwa: I have tested it once again and everything is working perfect. :)
13:42:55 <gauravsaini03> dkayiwa: Also I have clear all my cache and also tested it in safe browsing.
13:43:13 <dkayiwa> gauravsaini03: working without that line?
13:50:03 *** gauravsaini03 has quit IRC
13:57:20 *** DraggonZ has quit IRC
14:02:08 *** NameFILIP has joined #openmrs
14:04:50 *** h3llborn has joined #openmrs
14:05:47 <djazayeri1> Hi everyone
14:05:53 *** djazayeri1 is now known as djazayeri
14:06:16 *** ChanServ sets mode: +o djazayeri
14:06:21 <djazayeri> Shall we scrum?
14:06:25 <djazayeri> !scrumon djazayeri
14:06:25 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster djazayeri- you may begin when ready.
14:06:48 <djazayeri> today's order: dkayiwa, djazayeri, anybody else
14:07:14 <dkayiwa> Reviewed and merged: Update Default XSLT for complex observations - XFRM-120
14:07:15 <dkayiwa> Reviewed: Test method HibernatePatientDAO.getPatientIdentifierTypes - TRUNK-3206
14:07:15 <dkayiwa> Reviewed: Add voidNote() method to NoteDAO - TRUNK-3258
14:07:15 <dkayiwa> Back ported and closed: Change user instructions displayed on the 'find duplicate patients' page - TRUNK-3991
14:07:16 <dkayiwa> Reviewed and tested: Auto highlight on coded answer and active Add button in dictionary - TRUNK-3221
14:07:16 <dkayiwa> Reviewed, tested and merged: Add support for back button on patient search page - TRUNK-3980
14:07:16 <dkayiwa> Reviewed: Change calendar.js to support future dates. - TRUNK-3829
14:07:17 <dkayiwa> Reviewed and closed: Add JSR-303 validation jars to OpenMRS core - TRUNK-3947
14:07:17 <dkayiwa> Looked into: https://tickets.openmrs.org/browse/TRUNK-3567, TRUNK-3683,
14:07:17 <dkayiwa> Now reviewing: Spring ApplicationContext is not able to be refreshed properly through the API - TRUNK-204
14:07:17 <dkayiwa> No Blockers
14:08:22 <djazayeri> Yesterday:
14:08:23 <djazayeri> * Finished Dispositions for Mirebalais/RefApp
14:08:23 <djazayeri> * Enabled editing forms for Mirebalais/RefApp
14:08:24 <djazayeri> Today
14:08:28 <djazayeri> * calls
14:08:34 <djazayeri> No blockers
14:08:42 <djazayeri> does anybody else want to give a report?
14:10:10 <djazayeri> I guess not...
14:10:13 <djazayeri> !scrumoff
14:10:13 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
14:10:28 *** gauravsaini03 has joined #openmrs
14:15:25 *** gauravsaini03 has quit IRC
14:18:41 *** ibewes has quit IRC
14:21:15 *** harsz89 has joined #openmrs
14:30:26 *** ibewes has joined #openmrs
14:32:57 *** gauravsaini03 has joined #openmrs
14:34:21 *** breeze has joined #openmrs
14:38:00 *** k-joseph has quit IRC
14:40:17 *** wyclif has joined #openmrs
14:40:58 <wyclif> hi djazayeri
14:41:15 <djazayeri> hi wyclif
14:41:31 <djazayeri> wyclif: on call with cosmin
14:41:45 *** k-joseph has joined #openmrs
14:43:06 *** ibewes has quit IRC
14:47:06 *** gauravsaini03 has quit IRC
14:57:45 <wyclif> hi dkayiwa
14:59:05 <dkayiwa> wyclif: hi
15:09:54 *** rday has quit IRC
15:19:34 *** GitHub107 has joined #openmrs
15:19:34 <GitHub107> [openmrs-core] gauravsaini03 opened pull request #320: Auto highlight on coded answer and active Add button in dictionary - TRUNK-3221 (master...TRUNK-3221) http://git.io/GooPCg
15:19:34 *** GitHub107 has left #openmrs
15:19:41 *** gauravsaini03 has joined #openmrs
15:20:09 *** Ajwath has quit IRC
15:21:55 <gauravsaini03> dkayiwa: Done the necessary changes, https://github.com/gauravsaini03/openmrs-core/commit/b94765c6936f74d7ab771ff5ec5c07963f8e107d
15:21:58 <OpenMRSBot> <http://ln-s.net/-:AM> (at github.com)
15:23:03 <dkayiwa> gauravsaini03: ok
15:25:42 *** Caber has joined #openmrs
15:27:49 <Caber> Hi all - I was looking into the posibilty to use OpenMRS for an non-profit mobile health center - I was wondering or it would make sense to wait for OpenMRS 2.0 to get to alpha/beta before starting to imlement
15:28:29 <Caber> what would you suggest and why? and when is OpenMRS 2.0 to be expected?
15:29:15 *** AndroUser has joined #openmrs
15:29:35 *** Sateesh has joined #openmrs
15:29:51 <gauravsaini03> dkayiwa: Are you reviewing it ?
15:29:52 *** jennparise has quit IRC
15:29:56 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Kenya EMR UI Library 1.3.8 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=kenyaui&ampversion=&amp1.3.8>
15:30:07 <dkayiwa> gauravsaini03: will review it some time today :)
15:30:22 <gauravsaini03> dkayiwa: Thanks :)
15:30:27 *** jennparise has joined #openmrs
15:31:06 *** rcrichton has quit IRC
15:37:06 *** gauravsaini03 has quit IRC
15:38:21 *** AndroUser has quit IRC
15:38:31 *** AndroUser has joined #openmrs
15:39:13 *** lh has joined #openmrs
15:39:13 *** lh has joined #openmrs
15:47:45 *** portablejim has quit IRC
15:50:29 *** Sateesh has quit IRC
15:50:44 *** gauravsaini03 has joined #openmrs
15:53:56 *** k-joseph has quit IRC
15:54:05 *** k-joseph_ has joined #openmrs
15:54:47 *** rday has joined #openmrs
15:54:54 *** harsz89 has quit IRC
15:56:09 *** NameFILIP has quit IRC
15:59:45 *** h3llborn has quit IRC
16:00:30 *** Sateesh has joined #openmrs
16:13:53 *** k-joseph_ has quit IRC
16:14:55 *** harsz89 has joined #openmrs
16:17:37 *** harshadura has joined #openmrs
16:18:00 *** AndroUser has quit IRC
16:18:08 *** AndroUser has joined #openmrs
16:22:15 *** Sateesh has quit IRC
16:22:59 <djazayeri> breeze: I assume the failing test email is because you're working on something?
16:23:14 <breeze> djazayeri: oh, yes, sorry...:)
16:23:34 <djazayeri> breeze: np, just checking
16:23:41 *** AndroUser has quit IRC
16:24:11 <breeze> djazayeri: FYI working on adding another deployment stage so was re-arranging the order of operations on that plan
16:32:31 *** AndroUser has joined #openmrs
16:33:24 *** wyclif has left #openmrs
16:54:27 *** rday has quit IRC
16:57:43 *** rday has joined #openmrs
16:59:07 <djazayeri> jkeiper: can we move https://tickets.openmrs.org/browse/TRUNK-3143 to the FORM project, since the relevant code changes are in formentry?
16:59:42 <jkeiper> djazayeri: as long as you're convinced it's not something we need to update in core ... not sure if core should be adjusted to find formularies when searching for concepts?
17:00:10 *** nwilkie has joined #openmrs
17:01:19 <djazayeri> jkeiper: I haven't looked at the code at all. My understanding purely based on looking at your ticket comments is that this requires work on the page in the formentry module that the taskpane navigates to
17:01:53 <jkeiper> djazayeri: yeah, i think that's right ... we can always move it back to TRUNK or create a new one if we find that it's a core problem
17:02:03 <djazayeri> jkeiper: it's surely possible you want to propose a change to core to better support this, but that won't be available to the module for a while.
17:02:14 <jkeiper> djazayeri: exacrtly
17:02:38 <djazayeri> jkeiper: and as far as I know there is no core API method at all that will search for a concept _or_ drug by fuzzy name.
17:15:16 *** k-joseph has joined #openmrs
17:25:06 <jkeiper> mseaton: can you give me a hint where the reporting service keeps its cache of already-run data definitions, so i can troubleshoot why mine is running data definitions multiple times for the same report?
17:29:25 *** gauravsaini03 has quit IRC
17:31:47 *** harshadura has quit IRC
17:34:25 *** rday has quit IRC
17:41:47 *** gauravsaini03 has joined #openmrs
17:42:27 *** k-joseph has quit IRC
17:45:26 *** k-joseph has joined #openmrs
17:46:40 <jkeiper> mseaton: i see what's going on now with the caching ... if a definition has @Caching annotation, it is cached, and there are defaults like in BaseDataDefinition
17:51:56 *** rday has joined #openmrs
17:55:00 <harsz89> hi jkeiper
17:59:10 *** muthumini has joined #openmrs
18:10:48 *** k-joseph has quit IRC
18:12:37 *** gauravsaini03 has quit IRC
18:12:54 *** k-joseph has joined #openmrs
18:14:37 *** wyclif has joined #openmrs
18:19:18 *** k-joseph has quit IRC
18:19:19 <mseaton> jkeiper: yep. the cache is in the evaluationcontext
18:19:44 <jkeiper> harsz89: hiya
18:19:59 <jkeiper> mseaton: i'm going to debug and see if i can figure out why mine doesn't seem to cache ...
18:20:16 <harsz89> jkeiper, :D :)
18:20:25 <harsz89> jkeiper, small question
18:20:36 <jkeiper> harsz89: go for it
18:20:39 <harsz89> jkeiper, in data integrity workflow module
18:20:42 *** k-joseph has joined #openmrs
18:21:12 <harsz89> jkeiper, one record will assign to a one person or is it possible to assign multiple people?
18:21:43 <jkeiper> harsz89: 1-n records : 1 person
18:21:57 <jkeiper> harsz89: not the opposite
18:22:12 <jkeiper> harsz89: record --> [0,1] person
18:22:22 <jkeiper> harsz89: person --> 0..n records
18:22:25 <jkeiper> make sense?
18:22:48 <harsz89> jkeiper, yeap understand :D
18:22:54 <harsz89> jkeiper, thanks a lot jkeiper :)
18:22:57 *** rday has quit IRC
18:23:17 <jkeiper> harsz89: np
18:23:23 <harsz89> jkeiper, :)
18:27:16 *** rday has joined #openmrs
18:29:31 *** k-joseph has quit IRC
18:36:23 *** harshadura has joined #openmrs
18:37:35 *** k-joseph has joined #openmrs
18:45:21 *** AndroUser has quit IRC
18:59:39 *** muthumini has quit IRC
19:04:04 <jkeiper> mseaton: so, i added a line to the BaseDefinitionService.evaluate() method right at the beginning, and it reports that the context.getCache().size() is always zero at the beginning of the method call ... at the end, after adding to the cache, it exists but upon the next call it is gone. is Reporting copying the context before calling evaluate()?
19:05:02 <mseaton> jkeiper: possibly, but it shouldn't be. what are you evaluating at the top level?
19:05:31 <jkeiper> report definition with a single data set definition and inside that, multiple data definitions
19:05:35 <jkeiper> mseaton: --^
19:06:04 <jkeiper> mseaton: for each time BaseDataDefinition.evaluate() is called, the cache is empty
19:06:09 *** rday has quit IRC
19:06:29 <mseaton> jkeiper: what about when the first DataSetDefinition is evaluated, is it empty then?
19:06:45 <mseaton> jkeiper: actually, i guess it probably would be
19:07:28 <jkeiper> mseaton: if there are nested evaluations, the cache grows each time execute() exits
19:07:53 <jkeiper> mseaton: but it seems to not be persisted within the data set definition as it is iterating through data definitions
19:08:27 <mseaton> jkeiper: is this a PatientDataSetDefinition?
19:08:32 <jkeiper> mseaton: so, AgeAtOther... definition will cache the other def, so the cache grows to 1, but after the parent data definition is finished the cache is gone
19:08:34 <jkeiper> mseaton: yes
19:09:28 *** harshadura has quit IRC
19:11:19 <mseaton> jkeiper: can you run through debugger and try to figure out where the cache is getting cleared?
19:11:35 <jkeiper> mseaton: yep, looking for the right service ... :-D
19:12:38 <mseaton> jkeiper: look in PatientDataSetEvaluator, and put some logging in the iteration of the column definitions
19:12:51 <jkeiper> mseaton: aha, that's what i was looking for, thx
19:28:05 *** robbyoconnor has quit IRC
19:33:32 *** k-joseph has quit IRC
19:34:03 *** k-joseph has joined #openmrs
19:42:45 *** djazayeri_may_be has quit IRC
19:45:04 *** harsz89 has quit IRC
19:45:11 <jkeiper> mseaton: http://pastebin.com/QAZvPfCn
19:47:52 <mseaton> jkeiper: what is Moh361ACohortDefinition ?
19:48:09 <jkeiper> mseaton: ".." = PatientDataSetEvaluator, "--" = BaseDefinitionService
19:48:16 <mseaton> jkeiper: does it have it's own custom evaluator?
19:48:20 <jkeiper> mseaton: a custom cohort definition running SQL
19:48:23 <jkeiper> mseaton: yep
19:48:35 <mseaton> jkeiper: is that evaluator creating a new evaluation context?
19:49:30 <jkeiper> mseaton: the returned EvaluatedCohort contains the original context
19:49:39 <jkeiper> mseaton: no new context is created
19:50:06 <jkeiper> mseaton: https://github.com/AMPATH/openmrs-module-amrsreports/blob/master/api/src/main/java/org/openmrs/module/amrsreports/reporting/cohort/definition/evaluator/Moh361ACohortDefinitionEvaluator.java
19:50:08 <mseaton> jkeiper: can you point me to the code for Moh361ACohortDefinitionEvaluator?
19:50:10 <OpenMRSBot> <http://ln-s.net/-:Fb> (at github.com)
19:51:04 <mseaton> ok thanks
19:52:24 <jkeiper> mseaton: idk if this is affecting it: https://github.com/openmrs/openmrs-module-reporting/blob/master/api/src/main/java/org/openmrs/module/reporting/definition/service/BaseDefinitionService.java#L211
19:52:27 <OpenMRSBot> <http://ln-s.net/-:Ff> (at github.com)
19:53:03 <mseaton> jkeiper: it shouldn't be
19:53:46 <jkeiper> mseaton: looks like each time it goes into the BaseDefinitionService method, cache is blank ... then gets populated and remains in that state until the next time it's called
19:54:59 <jkeiper> mseaton: think the "super" part is doing something to the context?
19:56:36 <mseaton> jkeiper: maybe put some logging in the EvaluationContext constructor(s) to identify when a new one is getting created, as well as any mutator for the cache?
19:56:57 <jkeiper> mseaton: ok
20:12:18 <jkeiper> mseaton: http://pastebin.com/NftiSCwN
20:12:30 <jkeiper> looks like new evaluation contexts are made, but as copies ...
20:15:16 <jkeiper> mseaton: ahhh, no it is creating all new contexts
20:15:23 <jkeiper> mseaton: need to see what is doing that :|
20:15:49 *** h3llborn has joined #openmrs
20:30:18 <jkeiper> mseaton: perhaps having @Transactional(readOnly = true) on PatientDataServiceImpl.evaluate() is resetting it ... because when I get to that line, the context is already empty
20:30:23 <jkeiper> er, the cache at least
20:31:39 <breeze> djazayeri, question for you
20:36:49 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: HTML Form Entry 2.1.1 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=htmlformentry&ampversion=&amp2.1.1>
20:36:54 <jkeiper> mseaton: it appears that "ec" at this service method call has data in it: https://github.com/openmrs/openmrs-module-reporting/blob/master/api/src/main/java/org/openmrs/module/reporting/dataset/definition/evaluator/PatientDataSetEvaluator.java#L87
20:36:57 <OpenMRSBot> <http://ln-s.net/-:GZ> (at github.com)
20:37:12 <jkeiper> mseaton: but when i put a breakpoint in PatientDatServiceImpl, the context cache is empty
20:37:17 <jkeiper> mseaton: no clue how that's happening
20:37:21 <jkeiper> mseaton: gotta run
20:37:27 <jkeiper> mseaton: but ... think this is the crux of the issue
20:42:03 <djazayeri> breeze: hi
20:42:24 <breeze> djazayeri: Under the admin/maintenance/systemInfo.htm URL ther's this entry
20:42:24 <breeze> OpenMRS Version 1.9.4 SNAPSHOT Build eb7281
20:42:24 <breeze> is that info coming from a db entry or from something on the filesystem?
20:42:52 <breeze> djazayeri: if you happen to know off the top of your head
20:43:04 <djazayeri> breeze: I think it's in the OpenmrsConstants class (possibly set via maven build?)
20:43:40 <djazayeri> breeze: actually, I guess it's in MANIFEST.MF
20:44:15 <djazayeri> breeze: logic is in O?penmrsConstants.getBuildVersion()
20:44:28 <breeze> djazayeri: ok...well that adds to the mystery. I'm trying to figure out some deployment inconsistencies across envs
20:46:40 <breeze> djazayeri: ok...so the same war being deployed to multiple envs should have the same version info..which they don't at the moment...so there's an issue with deploying right now that I'm investigating
20:47:44 <breeze> djazayeri: but another mystery you might be able to help me with....the css for the home screen on devtest01 is the only place where it is "new" other envs still show the same old legacy home screen
20:53:50 *** GitHub193 has joined #openmrs
20:53:50 <GitHub193> [openmrs-core] k-joseph opened pull request #321: TRUNK-3258 (master...TRUNK-3258) http://git.io/GCrriQ
20:53:50 *** GitHub193 has left #openmrs
20:55:50 *** dkayiwa_ has joined #openmrs
20:58:00 *** dkayiwa has quit IRC
20:58:01 *** dkayiwa_ is now known as dkayiwa
21:01:15 *** k-joseph has quit IRC
21:05:06 *** robbyoconnor has joined #openmrs
21:05:06 *** ChanServ sets mode: +v robbyoconnor
21:06:55 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: HTML Form Entry Extensions for OpenMRS 1.9 Module 1.2 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=htmlformentry19ext&ampversion=&amp1.2>
21:18:52 *** h3llborn has quit IRC
21:23:44 *** cospih has quit IRC
21:29:57 *** k-joseph has joined #openmrs
21:30:41 *** sunbiz has left #openmrs
21:42:08 *** djazayeri_may_be has joined #openmrs
21:49:00 *** r0bby has joined #openmrs
21:49:00 *** ChanServ sets mode: +v r0bby
21:50:29 *** robbyoconnor has quit IRC
21:50:53 <k-joseph> dkayiwa: hi
21:51:18 <dkayiwa> k-joseph: hi
21:51:32 <k-joseph> dkayiwa, had you seen wyclif's comment on github where we wanted to have your ider, whether am supposed to return the universally unique id for the typedValue object in the serialize method or return the conceptId(), if possible, i kindly request you to address it from here, am currently using getUuid() and am conviced that this is ok !!!
21:51:57 *** r0bby_ has joined #openmrs
21:51:58 *** ChanServ sets mode: +v r0bby_
21:52:10 <dkayiwa> k-joseph: yes i agree with uuid
21:52:12 <k-joseph> dkayiwa: the discussion is at https://github.com/openmrs/openmrs-core/pull/233#discussion_r3213606
21:52:13 <OpenMRSBot> <http://ln-s.net/+keW> (at github.com)
21:52:20 <k-joseph> dkayiwa: ok
21:52:43 <mseaton> jkeiper: you back online?
21:55:13 *** r0bby has quit IRC
22:02:13 *** GitHub100 has joined #openmrs
22:02:13 <GitHub100> [openmrs-core] mogoodrich pushed 1 new commit to master: http://git.io/LwNsDA
22:02:13 <GitHub100> openmrs-core/master 8bf5387 mogoodrich: TRUNK-3992: PersonByNameComparator should be case-insensitive
22:02:13 *** GitHub100 has left #openmrs
22:02:56 *** k-joseph has quit IRC
22:05:58 *** k-joseph has joined #openmrs
22:08:14 *** dkayiwa has quit IRC
22:13:21 *** r0bby_ has quit IRC
22:15:50 *** travis-ci has joined #openmrs
22:15:50 <travis-ci> [travis-ci] [openmrs/openmrs-core] [8bf5387] [mogoodrich] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/7408429
22:15:50 *** travis-ci has left #openmrs
22:15:53 <OpenMRSBot> <http://ln-s.net/-:ID> (at travis-ci.org)
22:38:43 *** dkayiwa has joined #openmrs
22:51:39 *** lh has quit IRC
22:53:16 *** lh has joined #openmrs
22:53:17 *** lh has joined #openmrs
23:00:23 *** r0bby_ has joined #openmrs
23:00:23 *** ChanServ sets mode: +v r0bby_
23:00:53 *** lh has quit IRC
23:06:53 *** wyclif has quit IRC
23:08:27 *** k-joseph has quit IRC
23:08:52 *** dkayiwa has quit IRC
23:29:37 *** Caber has quit IRC