IRC Chat : 2013-05-19 - OpenMRS

00:44:44 *** harsz89 has quit IRC
01:00:52 *** wyclif has joined #openmrs
01:09:42 *** portablejim has quit IRC
01:24:10 *** rday has quit IRC
01:58:40 *** portablejim has joined #openmrs
01:58:40 *** portablejim has joined #openmrs
02:58:10 *** harshadura has joined #openmrs
03:25:36 *** harshadura_ has joined #openmrs
03:27:56 *** harshadura has quit IRC
03:47:16 *** NameFILIP has joined #openmrs
03:54:04 *** harshadura has joined #openmrs
03:57:01 *** harshadura_ has quit IRC
04:01:27 *** djazayeri1 has joined #openmrs
04:04:29 *** wyclif has quit IRC
04:04:54 *** djazayeri has quit IRC
04:22:51 *** muthumini has joined #openmrs
04:49:38 *** harsz89 has joined #openmrs
05:05:53 <muthumini> AdaYeung: Hi Yeung! I'm Muthumini, an applicant of OPW summer 2013. I'm very interested in Reporting Module Documentation.
05:20:59 *** harsz89 has quit IRC
06:07:33 *** muthumini has quit IRC
06:38:28 *** pulasthi7 has joined #openmrs
06:53:37 *** kkthecoder has joined #openmrs
07:34:38 *** rday has joined #openmrs
07:39:06 *** kkthecoder has quit IRC
08:03:49 *** KC9YYQ has quit IRC
08:05:26 *** KC9YYQ has joined #openmrs
08:23:41 *** maurya has joined #openmrs
08:27:52 *** sagar has joined #openmrs
08:39:06 *** pulasthi7 has quit IRC
08:45:28 *** dkayiwa has joined #openmrs
08:56:16 *** pulasthi7 has joined #openmrs
09:02:32 *** NameFILIP has quit IRC
09:11:53 *** sagar has quit IRC
09:14:44 *** pulasthi7 has quit IRC
09:36:22 *** hybridivy has joined #openmrs
09:36:29 *** hybridivy has left #openmrs
09:41:37 *** maurya has quit IRC
10:19:57 *** NameFILIP has joined #openmrs
10:51:29 *** dkayiwa has quit IRC
10:55:03 *** dkayiwa has joined #openmrs
11:06:59 *** dkayiwa has quit IRC
11:10:13 *** NameFILI_ has joined #openmrs
11:10:14 *** NameFILIP has quit IRC
11:11:09 *** NameFILIP has joined #openmrs
11:14:27 *** NameFIL__ has joined #openmrs
11:14:28 *** NameFILIP has quit IRC
11:14:39 *** NameFILI_ has quit IRC
11:15:12 *** NameFILIP has joined #openmrs
11:15:15 *** NameFIL__ has quit IRC
11:46:40 *** harshadura_ has joined #openmrs
11:48:48 *** djazayeri1 has quit IRC
11:49:13 *** harshadura__ has joined #openmrs
11:49:26 *** harshadura has quit IRC
11:51:08 *** harshadura_ has quit IRC
11:53:14 *** harshadura_ has joined #openmrs
11:54:13 *** kkthecoder has joined #openmrs
11:55:58 *** harshadura has joined #openmrs
11:56:48 *** harshadura__ has quit IRC
11:57:42 *** harshadura__ has joined #openmrs
11:57:56 *** harshadura_ has quit IRC
12:01:22 *** harshadura has quit IRC
12:04:02 *** k-joseph has joined #openmrs
12:10:42 *** harshadura_ has joined #openmrs
12:13:05 *** harshadura has joined #openmrs
12:13:48 *** harshadura__ has quit IRC
12:14:37 *** kkthecoder has quit IRC
12:15:12 *** kkthecoder has joined #openmrs
12:16:04 *** harshadura_ has quit IRC
12:19:20 *** kkthecoder has quit IRC
12:19:53 *** kkthecoder has joined #openmrs
12:31:36 *** sashrika has joined #openmrs
12:31:56 <sashrika> harshadura: ado..
12:32:53 <harshadura> sashrika: hi mchan
12:33:46 <sashrika> harshadura: machan umba dannawada pantahointergration ekata application dapu kawruwath?
12:34:02 <sashrika> harshadura: pantaho intergration
12:34:40 <harshadura> sashrika: ado haryatama note na mchan
12:35:22 <sashrika> harshadura: hm..! ok... mokada me dawas wala karanne? nikan innawa?
12:36:09 <harshadura> xD ohe inawa ban uba mokada karanne
12:37:02 <sashrika> harshadura: apita exam thiyenawa. ok machan cu later...
12:38:31 <harshadura> sashrika: ela mchn
12:39:19 *** harshadura has quit IRC
12:41:08 *** k-joseph has quit IRC
13:08:26 *** kkthecoder has quit IRC
13:15:28 <sashrika> djazayeri_may_be: Darius... are u there?
13:18:10 <sashrika> downey: Hi....
13:26:48 *** harsz89 has joined #openmrs
13:27:09 *** wyclif has joined #openmrs
13:29:07 *** sashrika has quit IRC
13:41:48 *** k-joseph has joined #openmrs
13:50:25 *** sashrika has joined #openmrs
13:55:34 *** muthumini has joined #openmrs
14:02:07 *** muthumini_ has joined #openmrs
14:04:13 *** muthumini has quit IRC
14:06:23 *** muthumini_ has quit IRC
14:09:23 *** muthumini has joined #openmrs
14:20:41 *** sashrika has quit IRC
14:25:07 *** NameFILIP has quit IRC
14:26:39 *** NameFILIP has joined #openmrs
14:43:49 *** DraggonZ has joined #openmrs
15:05:15 *** portablejim has quit IRC
15:11:58 *** k-joseph has joined #openmrs
15:15:50 *** NameFILIP has quit IRC
15:18:45 *** muthumini has quit IRC
15:25:36 *** NameFILIP has joined #openmrs
15:36:53 *** wyclif has quit IRC
15:43:45 *** wyclif has joined #openmrs
15:47:49 *** NameFILIP has quit IRC
15:49:05 *** NameFILIP has joined #openmrs
16:22:52 *** dkayiwa has joined #openmrs
16:37:54 *** k-joseph has quit IRC
16:38:16 *** k-joseph has joined #openmrs
16:44:04 <k-joseph> wyclif: hi
16:45:10 *** kk has joined #openmrs
16:49:35 <k-joseph> dkayiwa: hi, i have a few issues i kindly ask you to address them for me in case wyclif is perhaps bussy :)
16:49:52 <dkayiwa> k-joseph: ok feel free to ask me
16:50:13 <dkayiwa> k-joseph: but as you wait for his response, you can always choose another ticket. you do not have to wait
16:52:33 <k-joseph> dkayiwa: ok, i will be doing that, one is how can i use Context.getDateFormat() in Fomat.format() to format what i had previously done, and another is how again can i update birthDate and deathDate in PersonListItem file for i thought it was fine that way, the comments are at https://github.com/k-joseph/openmrs-core/commit/TRUNK-3765_1
16:52:37 <OpenMRSBot> <http://ln-s.net/--Ai> (at github.com)
16:53:36 <dkayiwa> k-joseph: can you ask me again after like one hour? finishing up something first :)
16:53:54 <k-joseph> dkayiwa: ok
17:08:28 *** NameFILIP has quit IRC
17:20:03 <k-joseph> dkayiwa: i think you had forgotten to review https://github.com/k-joseph/openmrs-core/commit/TRUNK-3258, i thought of reminding you, i had changed the ticket's status to code review and it seems no dev has reviewed it until now
17:20:37 <dkayiwa> k-joseph: ok will review it too before i sleep
17:28:23 *** gauravsaini03 has joined #openmrs
17:28:45 <gauravsaini03> Hi
17:30:30 <gauravsaini03> I have yesterday submit a patch for the TRUNK-3221, today I get another issue and now I have solved it. So do I have to submit another patch ?
17:30:39 <gauravsaini03> or correct the last one
17:31:54 <dkayiwa> gauravsaini03: do you mean patch or pull request
17:32:31 <gauravsaini03> I bit confused, can you tell me difference between both
17:32:31 <gauravsaini03> ?
17:33:02 <gauravsaini03> This is what I get, [openmrs-core] gauravsaini03 opened pull request #317: Auto highlight on coded answer and active Add button in dictionary - TRUNK-3221 (master...TRUNK-3221) http://git.io/niI2bQ
17:33:16 <gauravsaini03> So what should I do now ?
17:33:51 *** k-joseph has quit IRC
17:34:23 <dkayiwa> gauravsaini03: for the same ticket?
17:34:30 <gauravsaini03> Yes same ticket
17:35:19 <dkayiwa> gauravsaini03: just commit and give the commit url on the ticket
17:36:00 *** k-joseph has joined #openmrs
17:36:44 <gauravsaini03> I checked git status it shows the file in which I have change, do I have to add it ?
17:37:10 <dkayiwa> gauravsaini03: is it a new file?
17:37:34 <gauravsaini03> no
17:37:38 <gauravsaini03> the same file
17:37:50 <dkayiwa> gauravsaini03: just commit
17:37:55 <gauravsaini03> do I simply do git - commit ?
17:37:59 <gauravsaini03> ok. thanks
17:38:54 <gauravsaini03> Also next I have to push it ? I am right ?
17:39:20 <dkayiwa> gauravsaini03: yes
17:41:54 <gauravsaini03> Do I have to pull request by going to github account, like I did previously ?
17:42:14 *** dkayiwa has quit IRC
17:43:07 *** wyclif has quit IRC
17:43:27 *** dkayiwa has joined #openmrs
17:43:42 <gauravsaini03> It says there's already a pull request !
17:43:49 <gauravsaini03> So its done ?
17:44:12 <dkayiwa> gauravsaini03: include commit url on the ticket
17:44:41 <gauravsaini03> ok. will do it, anything else from this ?
17:45:07 <dkayiwa> gauravsaini03: did you include commit url on the ticket
17:47:26 *** k-joseph_ has joined #openmrs
17:47:34 <gauravsaini03> Do I have to add comment and add commit url in it
17:47:39 <gauravsaini03> Or any other way ?
17:47:46 *** k-joseph has quit IRC
18:00:02 <gauravsaini03> Done. Thanks :)
18:11:18 <gauravsaini03> How much time it will take to someone to review my code which I committed ?
18:11:33 <k-joseph_> dkayiwa: hi, is it ok to ask you again now?
18:11:40 *** k-joseph_ is now known as k-joseph
18:11:45 <dkayiwa> k-joseph_: ok
18:12:02 <dkayiwa> gauravsaini03: when do you want me review it?
18:13:14 <gauravsaini03> You can review it now, I am done with it. I have tested it. It will be great achievement for me if I successfully completed this ticket.
18:13:17 <gauravsaini03> :)
18:13:51 <dkayiwa> gauravsaini03: which ticket number?
18:14:19 <gauravsaini03> TRUNK-3221
18:16:56 <k-joseph> dkayiwa: wyclif actually proposed the use of Context.getDateFormat() in Format.format(Date date, Locale locale, FORMAT_TYPE type), i tried it and it did not solve the ticket, so i insisted on my previous implemetation of that same method, still how again can i update birthDate and deathDate in PersonListItem file for i thought it was fine that way, the comments are at https://github.com/k-joseph/openmrs-core/commit/TRUNK-3765_1
18:16:56 <OpenMRSBot> <http://ln-s.net/--Ai> (at github.com)
18:18:47 <dkayiwa> k-joseph: there are many comments and its not easy for me to tell which one you are asking. Can you ask on github on the exact comments?
18:19:07 <dkayiwa> k-joseph: that way even wyclif will know what you are asking
18:19:19 <dkayiwa> !ticket TRUNK-3221
18:19:21 <OpenMRSBot> dkayiwa: [#TRUNK-3221] Auto highlight on coded answer and active Add button in dictionary - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3221
18:20:20 <dkayiwa> gauravsaini03: hi
18:20:25 <gauravsaini03> hi
18:21:05 <dkayiwa> gauravsaini03: i you do not include my name in any response you type on IRC, i may even take hours without knowing you are waiting for me
18:21:11 <dkayiwa> if
18:21:48 <gauravsaini03> dkayiwa: sorry will take care next time
18:22:06 <dkayiwa> gauravsaini03: have you actually tested this out in the browser?
18:22:47 <gauravsaini03> dkayiwa: Yes, I tested it in browser and also attached the screenshot also.
18:23:11 <dkayiwa> gauravsaini03: oh good. reviewing it now
18:23:57 <gauravsaini03> dkayiwa: Thanks :)
18:27:49 <dkayiwa> gauravsaini03: any reason for removing selectFirst and autoFocus in the last commit?
18:29:13 <gauravsaini03> dkayiwa: Yes, Actually it was supposed to be in autocomplete, I mistakenly placed this is dialog.
18:29:40 <gauravsaini03> dkayiwa: autoFocus is attribute of autocomplete.
18:29:43 <dkayiwa> gauravsaini03: what is the use of the script block you added?
18:30:35 <gauravsaini03> dkayiwa: Actually only due to that I was able to use selectFirst.
18:31:00 <gauravsaini03> In the project we are having jquery-ui verion 1.8.2
18:31:18 <gauravsaini03> which did not support that, it came after 1.8.23
18:31:25 <dkayiwa> gauravsaini03: can you comment on that script block and say what it exactly does?
18:31:43 <gauravsaini03> yes I will add a comment over it.
18:31:51 <gauravsaini03> Anything else I have to do ?
18:32:02 <dkayiwa> gauravsaini03: am waiting for that to continue :)
18:32:13 <gauravsaini03> ok. give me 2 mins
18:35:27 <gauravsaini03> dkayiwa: Added comment over the script part.
18:35:55 <dkayiwa> gauravsaini03: did you add a ticket comment about it?
18:36:17 <gauravsaini03> dkayiwa: will do it now
18:36:45 <dkayiwa> gauravsaini03: every time you commit, do the needful on the ticket :)
18:38:02 <gauravsaini03> dkayiwa: will take care from now, DONE.
18:38:32 <dkayiwa> gauravsaini03: ok let me review
18:40:56 *** k-joseph_ has joined #openmrs
18:41:09 <k-joseph_> dkayiwa: added what i had asked you on the commit https://github.com/k-joseph/openmrs-core/commit/TRUNK-3765_1
18:41:09 <OpenMRSBot> <http://ln-s.net/--Ai> (at github.com)
18:42:32 *** k-joseph has quit IRC
18:44:18 *** gaurav__ has joined #openmrs
18:44:58 *** gaurav__ has joined #openmrs
18:46:05 *** gaurav__ has quit IRC
18:46:30 *** gauravsaini03 has quit IRC
18:47:09 *** djazayeri has joined #openmrs
18:47:09 *** ChanServ sets mode: +o djazayeri
18:47:21 *** gauravsaini03 has joined #openmrs
18:48:00 *** kk has quit IRC
18:48:06 <gauravsaini03> dkayiwa: Are you done with reviewing ticket TRUNK-3221 ?
19:01:23 *** gaurav__ has joined #openmrs
19:01:37 *** gaurav__ has left #openmrs
19:04:05 *** gauravsaini03 has quit IRC
19:53:56 *** dkayiwa has quit IRC
20:09:34 *** DraggonZ has quit IRC
20:11:54 *** rcrichton has joined #openmrs
20:14:00 *** rcrichton has quit IRC
20:17:04 *** davidpardz has joined #openmrs
20:17:10 *** rday has quit IRC
20:20:24 *** k-joseph_ is now known as k-joseph
20:49:16 *** harsz89 has quit IRC
21:42:56 *** sashrika has joined #openmrs
21:45:01 <sashrika> djazayeri: Darius Hi...
22:31:23 <sashrika> djazayeri: Darius.. I have some problems regarding gsc application
22:41:03 *** h3llborn has quit IRC
22:49:27 <djazayeri> hi sashrika
23:20:44 <sashrika> djazayeri: darius.. downey has commented on my proposal. did u see that?