| 00:00:54 | *** tcalder has quit IRC |
| 00:02:25 | *** elefone has quit IRC |
| 00:06:23 | *** tcalder has joined #openmrs |
| 00:16:43 | *** jblaya has quit IRC |
| 00:19:40 | *** downey_ has joined #openmrs |
| 00:19:40 | *** ChanServ sets mode: +o downey_ |
| 00:20:24 | *** ryates_ has joined #openmrs |
| 00:20:56 | *** downey has quit IRC |
| 00:20:57 | *** ryates has quit IRC |
| 00:21:38 | *** downey_ is now known as downey |
| 00:22:38 | *** ryates_ is now known as ryates |
| 00:29:53 | *** tcalder has quit IRC |
| 00:44:49 | <djazayeri> breeze: hey, you there? |
| 00:45:03 | <djazayeri> do you know why ci-stg and devtest01 both seem down? |
| 00:45:12 | <djazayeri> downey: ^^ you also might know. |
| 01:12:00 | *** tcalder has joined #openmrs |
| 01:15:30 | *** NameFILIP has joined #openmrs |
| 01:24:47 | *** wyclif has quit IRC |
| 02:04:13 | *** rday has joined #openmrs |
| 02:07:16 | *** NameFILI_ has joined #openmrs |
| 02:10:00 | *** NameFILIP has quit IRC |
| 02:16:07 | *** tcalder has quit IRC |
| 02:19:20 | *** tcalder has joined #openmrs |
| 02:23:22 | *** robbyoconnor has joined #openmrs |
| 02:23:22 | *** ChanServ sets mode: +v robbyoconnor |
| 02:23:40 | *** Hasintha_i has joined #openmrs |
| 02:32:08 | *** tcalder has quit IRC |
| 02:51:31 | *** NameFILI_ has quit IRC |
| 03:12:21 | *** NameFILIP has joined #openmrs |
| 03:13:43 | *** kavuri has joined #openmrs |
| 03:17:44 | *** Anuruddha has joined #openmrs |
| 03:20:45 | *** ruwanego has joined #openmrs |
| 03:29:59 | *** Mkop has quit IRC |
| 03:36:00 | *** Mkop has joined #openmrs |
| 03:36:00 | *** ChanServ sets mode: +v Mkop |
| 03:44:08 | *** jennparise has quit IRC |
| 03:44:42 | *** djazayeri has quit IRC |
| 04:01:37 | *** Anuruddha has quit IRC |
| 04:12:00 | *** tcalder has joined #openmrs |
| 04:14:36 | *** Mkop has quit IRC |
| 04:14:37 | *** Anuruddha has joined #openmrs |
| 04:21:19 | *** ArcTanSusan has joined #openmrs |
| 04:22:37 | *** Mkop has joined #openmrs |
| 04:22:37 | *** ChanServ sets mode: +v Mkop |
| 04:23:21 | *** Ajwath has joined #openmrs |
| 04:27:10 | *** Anuruddha_ has joined #openmrs |
| 04:30:29 | *** Anuruddha has quit IRC |
| 04:36:18 | *** ArcTanSusan has quit IRC |
| 04:52:56 | *** Mkop has quit IRC |
| 04:53:57 | <Ajwath> could not access the wiki any body have idea |
| 04:54:31 | <kavuri> Ajwath: there was a mail in the mailing list that there are issues with the IT infra of openmrs and it is being worked on.. |
| 04:54:59 | *** harshadura has joined #openmrs |
| 04:55:38 | <Ajwath> kavuri: thanks lets wait |
| 05:01:45 | *** Mkop has joined #openmrs |
| 05:01:45 | *** ChanServ sets mode: +v Mkop |
| 05:02:57 | *** harshadura has quit IRC |
| 05:03:06 | *** harshadura has joined #openmrs |
| 05:03:06 | *** ChanServ sets mode: +v harshadura |
| 05:03:31 | *** harshadura has quit IRC |
| 05:03:37 | *** ArcTanSusan has joined #openmrs |
| 05:30:14 | *** that_noob has joined #openmrs |
| 05:30:21 | *** that_noob is now known as elefone |
| 05:30:42 | <elefone> does anyone know when approx. when the wiki should be back up? i really need to read up! |
| 05:36:37 | *** tcalder has quit IRC |
| 05:36:46 | *** harshadura has joined #openmrs |
| 05:36:46 | *** ChanServ sets mode: +v harshadura |
| 05:43:07 | *** Mkop1 has joined #openmrs |
| 05:43:07 | *** ChanServ sets mode: +v Mkop1 |
| 05:43:48 | *** Hasintha_i has quit IRC |
| 05:45:03 | *** Mkop has quit IRC |
| 05:48:41 | <rday> elefone: I don't know either but I need it for my GSoC application |
| 05:51:46 | <elefone> @rday i really hope it comes back soon :( |
| 05:52:26 | *** elefone has quit IRC |
| 05:58:02 | *** ArcTanSusan has quit IRC |
| 05:58:31 | *** ArcTanSusan has joined #openmrs |
| 06:13:05 | <ArcTanSusan> any1 here? i have a bug in the way I'm using mvn. "mvm compile" command removes all the changes I've made |
| 06:13:25 | *** Ajwath has quit IRC |
| 06:13:57 | *** Ajwath has joined #openmrs |
| 06:15:50 | <ArcTanSusan> I'm working on a git branch, making a tiny change to the header line of a jsp file |
| 06:16:04 | *** ruwanego has quit IRC |
| 06:16:43 | *** Ajwath has quit IRC |
| 06:16:47 | <NameFILIP> ArcTanSusan: are you sure you have saved your changes before running "mvn compile"? the code is getting formatted during compiling, so if you have unsaved changes there is no guarantee they will not be removed |
| 06:17:12 | <ArcTanSusan> yes, i save all my changes i make |
| 06:18:52 | <NameFILIP> which file exactly are you trying to modify? |
| 06:19:02 | <ArcTanSusan> NameFILIP: even when i do "mvm install", the changes are removed. Im doing |
| 06:19:15 | <ArcTanSusan> adinga new line to conceptForm.jsp |
| 06:19:42 | *** k-joseph has joined #openmrs |
| 06:19:50 | <ArcTanSusan> <c:otherwise> |
| 06:19:51 | <ArcTanSusan> <h2><openmrs:messagecode="Concept.creatingNewConcept"/></h2> |
| 06:19:52 | <ArcTanSusan> <h2>hellooo world</h2> <--- my new change in line 95 |
| 06:19:52 | <ArcTanSusan> </c:otherwise> |
| 06:20:41 | <NameFILIP> let me try to repeat your trick |
| 06:20:51 | <ArcTanSusan> I'm using sublime text2 and running mvm on my command terminal on macOS |
| 06:21:14 | <ArcTanSusan> also, I'm making changes on a branch |
| 06:22:50 | <ArcTanSusan> this error (having my changes all removed) happens even if I do mvn compile or mvm install |
| 06:25:45 | <NameFILIP> what is the path to your conceptForm.jsp? |
| 06:25:49 | <NameFILIP> ArcTanSusan |
| 06:26:05 | <NameFILIP> starting from openmrs/ |
| 06:26:40 | <ArcTanSusan> webapp/release-test/target/1.10.0-SNAPSHOT/webapp/WEB-INF/view/dictionary/conceptForm.jsp |
| 06:26:58 | *** cospih has joined #openmrs |
| 06:27:09 | <NameFILIP> yep, you should not modify anything in the target directory |
| 06:27:15 | <NameFILIP> it is auto-generated |
| 06:27:18 | <ArcTanSusan> gah. ahhh |
| 06:27:29 | <ArcTanSusan> war should i modify instead? was there docs warning about this? |
| 06:27:40 | *** rcrichton has joined #openmrs |
| 06:27:58 | <ArcTanSusan> NameFILIP: I'm very new to eclipse, mvn, java |
| 06:28:24 | <NameFILIP> try openmrs/webapp/src/webapp/WEB-INF/view/dictionary/conceptForm.jsp |
| 06:28:30 | <ArcTanSusan> ahahaa |
| 06:28:31 | <ArcTanSusan> ! |
| 06:29:26 | *** cospih_ has quit IRC |
| 06:30:34 | <NameFILIP> this is how maven works. http://maven.apache.org/guides/introduction/introduction-to-the-standard-directory-layout.html (below the table it says about target directory) |
| 06:30:36 | <OpenMRSBot> <http://ln-s.net/3OBv> (at maven.apache.org) |
| 06:34:33 | <ArcTanSusan> moral: i should make changes only to src/main/webapp and |
| 06:35:49 | <ArcTanSusan> also, after I do mvm compile, the jsp change remains (yay!), but the change didn't show up when running on my server :( |
| 06:36:05 | <NameFILIP> I would say only to src/ |
| 06:37:22 | <ArcTanSusan> got it! |
| 06:38:36 | <NameFILIP> have you run "mvn clean install" from openmrs-core and then "mvn jetty:run" from the openmrs-core/webapp? |
| 06:39:42 | <ArcTanSusan> NameFILIP: i did mvm compile. as for the mvm jetty:run, I leave a terminal tab open that's always running jetty:run in background |
| 06:40:08 | <ArcTanSusan> NameFILIP: OMG! it works! finally. |
| 06:40:22 | <NameFILIP> :) |
| 06:40:23 | <ArcTanSusan> NameFILIP: now I can finally start real work on this intro java ticket. |
| 06:40:33 | <ArcTanSusan> I'm working on TRUNK-3818 |
| 06:40:42 | <ArcTanSusan> ticket #. do you have advice for working on this ticket? |
| 06:41:09 | *** rowanseymour has joined #openmrs |
| 06:42:02 | *** tcalder has joined #openmrs |
| 06:42:45 | *** rowanseymour has quit IRC |
| 06:43:30 | <NameFILIP> my advice is: try to understand what you have to do, and then do it |
| 06:43:33 | *** rowanseymour has joined #openmrs |
| 06:43:35 | <NameFILIP> ;) |
| 06:47:10 | <ArcTanSusan> thnx! |
| 06:51:32 | *** ruwanego has joined #openmrs |
| 06:53:23 | *** portablejim has joined #openmrs |
| 06:53:23 | *** portablejim has joined #openmrs |
| 06:57:03 | *** dkayiwa has joined #openmrs |
| 07:15:38 | *** dkayiwa has quit IRC |
| 07:16:21 | *** dkayiwa has joined #openmrs |
| 07:17:30 | <ArcTanSusan> another qusteion |
| 07:17:47 | <ArcTanSusan> war is the path file to the java files to modify? i want to find the controller for conceptForm.jsp |
| 07:18:38 | *** ruwanego has quit IRC |
| 07:19:02 | <ArcTanSusan> **wat |
| 07:20:05 | <NameFILIP> controllers are in the openmrs/web/src/main/... |
| 07:20:50 | <NameFILIP> you can do a search for "conceptForm" string in all the files |
| 07:22:06 | <NameFILIP> something like 'grep -r "conceptForm" .' |
| 07:22:26 | *** jennparise has joined #openmrs |
| 07:22:45 | <NameFILIP> or just look for a ConceptFormController.java |
| 07:27:40 | *** harshadura has quit IRC |
| 07:27:53 | *** harshadura has joined #openmrs |
| 07:27:53 | *** ChanServ sets mode: +v harshadura |
| 07:34:11 | <rday> The university call is still on for today right? |
| 07:39:54 | *** ArcTanSusan has quit IRC |
| 07:41:51 | *** k-joseph has quit IRC |
| 07:42:15 | *** tcalder has quit IRC |
| 07:42:24 | *** k-joseph has joined #openmrs |
| 07:43:47 | *** Anuruddha_ has left #openmrs |
| 07:47:10 | *** ruwanego has joined #openmrs |
| 07:58:09 | <harshadura> rday: yeah |
| 08:04:21 | *** b0b has quit IRC |
| 08:05:32 | *** b0b has joined #openmrs |
| 08:08:19 | <rday> harshadura: glad to hear it. Wasn't 100% sure because of the wiki |
| 08:09:19 | *** Hasintha_i has joined #openmrs |
| 08:13:28 | <harshadura> rday: :) i am not exactly sure wats the time though |
| 08:13:32 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Backbone Forms Module 1.0.0 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=openhmis.backboneforms&version=&1.0.0> || OpenMRS Modules: OpenHMIS Commons 1.5.0.0 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=openhmis.commons&version=&1.5.0.0> || OpenMRS Modules: Kenya EMR UI Library 1.3.5 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=kenyaui&version=&1.3.5> |
| 08:17:53 | <rday> harshadura: I believe 9-10 eastern |
| 08:42:13 | *** dkayiwa_ has joined #openmrs |
| 08:42:14 | *** dkayiwa has quit IRC |
| 08:42:15 | *** dkayiwa_ is now known as dkayiwa |
| 08:43:59 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: OpenHMIS Backbone Forms 1.0.0 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=openhmis.backboneforms&version=&1.0.0> || OpenMRS Modules: OpenHMIS Cashier Module 1.5.0 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=openhmis.cashier&version=&1.5.0> |
| 09:07:43 | *** lhawthor_ has joined #openmrs |
| 09:13:05 | <suranga> hi ruwanego |
| 09:13:12 | <ruwanego> hey |
| 09:13:13 | <suranga> ruwanego: hows it going ? :) |
| 09:13:20 | <ruwanego> suranga |
| 09:13:29 | <ruwanego> suranga |
| 09:13:36 | *** ruwanego has quit IRC |
| 09:13:50 | <suranga> um... I see to have frightened him off :( |
| 09:14:09 | *** ruwanego has joined #openmrs |
| 09:14:35 | <ruwanego> suranga, not bad |
| 09:14:58 | *** lh has quit IRC |
| 09:14:58 | *** nribeka has quit IRC |
| 09:15:29 | <suranga> ruwanego: happy bug fixing times ? did you have a chance to work on anything yet |
| 09:17:04 | <ruwanego> suranga, working on it.. |
| 09:38:04 | *** ruwanego has quit IRC |
| 09:38:29 | *** ruwanego has joined #openmrs |
| 09:41:23 | *** sara_ has joined #openmrs |
| 09:41:41 | *** Ajwath has joined #openmrs |
| 09:41:53 | <suranga> ruwanego: are you trying out intro bugs ? from the core, isnt it ? |
| 09:42:07 | <suranga> I guess thats a quick way to get used to github |
| 09:42:16 | <ruwanego> suranga, yeah |
| 09:42:26 | <suranga> ruwanego: or 'gitbug' as I used to call it some time back :) |
| 09:42:47 | <ruwanego> suranga, :) |
| 09:43:00 | *** rday has quit IRC |
| 09:44:08 | *** ruwanego has quit IRC |
| 09:44:36 | *** ruwanego has joined #openmrs |
| 09:46:26 | *** kraluk has joined #openmrs |
| 09:52:09 | *** lhawthor_ has quit IRC |
| 09:53:09 | *** lh has joined #openmrs |
| 09:53:09 | *** lh has joined #openmrs |
| 09:55:55 | *** ruwanego_ has joined #openmrs |
| 09:56:31 | *** Ajwath has quit IRC |
| 09:57:23 | *** Ajwath has joined #openmrs |
| 09:59:28 | *** ruwanego has quit IRC |
| 10:15:01 | *** k-joseph has quit IRC |
| 10:19:18 | *** k-joseph has joined #openmrs |
| 10:21:35 | *** rowanseymour has quit IRC |
| 10:21:36 | *** ruwanego_ has quit IRC |
| 10:22:03 | *** ruwanego_ has joined #openmrs |
| 10:23:22 | *** rkorytkowski has joined #openmrs |
| 10:23:22 | *** rkorytkowski is now known as rafa |
| 10:23:22 | *** ChanServ sets mode: +v rafa |
| 10:23:27 | *** ruwanego_ is now known as ruwanego |
| 10:25:13 | <akwatuha> hi dkayiwa |
| 10:25:14 | *** ruwanego has quit IRC |
| 10:26:12 | *** ruwanego has joined #openmrs |
| 10:29:12 | <akwatuha> I experience an Xform error when i try to fill out a patient form, the fields does not show up. I have tried this on both OpenMRS 1.10 as well as 1.93. I am running xforms 4.1.0.5. I guess i am missing out a step when creating the form. Not sure which one. Any ideas? |
| 10:30:07 | <akwatuha> dkayiwa: I experience an Xform error when i try to fill out a patient form, the fields does not show up. I have tried this on both OpenMRS 1.10 as well as 1.93. I am running xforms 4.1.0.5. I guess i am missing out a step when creating the form. Not sure which one. Any ideas? |
| 10:32:33 | *** Ajwath has quit IRC |
| 10:35:06 | <akwatuha> dkayiwa: i have realized the XForms 4.1.0.2 works fine following the same steps. It appears then the version 4.1.0.5 that i downloaded sometime needs to be investigated. I will attempt obtaining a newer version |
| 10:39:46 | *** k-joseph has quit IRC |
| 10:40:09 | *** k-joseph has joined #openmrs |
| 10:52:36 | *** sashrika has joined #openmrs |
| 11:08:58 | *** breeze has quit IRC |
| 11:15:21 | *** snoppy has joined #openmrs |
| 11:16:33 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Backbone Forms Module 1.0.0 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=openhmis.backboneforms&version=&1.0.0> || OpenMRS Modules: OpenHMIS Commons 1.5.0 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=openhmis.commons&version=&1.5.0> |
| 11:18:46 | *** nribeka has joined #openmrs |
| 11:18:46 | *** ChanServ sets mode: +v nribeka |
| 11:28:10 | <dkayiwa> akwatuha: hi |
| 11:29:33 | <dkayiwa> akwatuha: if newest works, thats possibly because it was released as a bug fix for the old one :) |
| 11:35:10 | <akwatuha> dkayiwa: thanks for your response. I am still trying to obtain the latest, my connectivity is not so good today. |
| 11:36:29 | *** NameFILIP has quit IRC |
| 11:41:35 | *** Anuruddha has joined #openmrs |
| 11:51:51 | *** kavuri has quit IRC |
| 12:00:26 | *** that_noob has joined #openmrs |
| 12:02:09 | *** ruwanego has quit IRC |
| 12:03:17 | *** k-joseph has quit IRC |
| 12:05:53 | *** k-joseph has joined #openmrs |
| 12:07:53 | *** that_noob has quit IRC |
| 12:10:34 | *** that_noob has joined #openmrs |
| 12:14:38 | *** ChanServ sets mode: +o ryates |
| 12:17:35 | *** harshadura_ has joined #openmrs |
| 12:18:25 | *** k-joseph has quit IRC |
| 12:19:21 | *** harshadura_ has quit IRC |
| 12:19:30 | *** harshadura_ has joined #openmrs |
| 12:20:47 | *** harshadura has quit IRC |
| 12:21:05 | *** harshadura has joined #openmrs |
| 12:24:50 | *** that_noob has quit IRC |
| 12:26:25 | *** that_noob has joined #openmrs |
| 12:27:37 | *** rowanseymour has joined #openmrs |
| 12:32:27 | *** k-joseph has joined #openmrs |
| 12:40:35 | *** harsz89 has joined #openmrs |
| 12:47:24 | *** rowanseymour has quit IRC |
| 12:48:42 | *** NameFILIP has joined #openmrs |
| 12:59:00 | *** wyclif has joined #openmrs |
| 13:03:19 | *** rowanseymour has joined #openmrs |
| 13:05:13 | <rafa> Please join the university forum to learn about liquibase: https://connect.iu.edu/omrsu/ |
| 13:09:49 | *** rowanseymour has quit IRC |
| 13:15:27 | *** Anuruddha has quit IRC |
| 13:22:01 | *** rowanseymour has joined #openmrs |
| 13:29:08 | *** jblaya has joined #openmrs |
| 13:32:13 | *** that_noob has quit IRC |
| 13:38:30 | *** harshadura__ has joined #openmrs |
| 13:40:53 | *** harshadura_ has quit IRC |
| 13:41:37 | *** harshadura has quit IRC |
| 13:47:14 | *** ishara-p has joined #openmrs |
| 13:50:38 | *** djazayeri has joined #openmrs |
| 13:50:38 | *** ChanServ sets mode: +o djazayeri |
| 13:53:18 | *** harshadura has joined #openmrs |
| 13:54:53 | *** elefone has joined #openmrs |
| 13:56:34 | *** rowanseymour has quit IRC |
| 14:03:07 | <cpower> Hello everyone |
| 14:03:12 | <cpower> Ready to scrum? |
| 14:03:19 | <cpower> !scrumon cpower |
| 14:03:19 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:04:01 | <cpower> Order: rafa , wyclif , dkayiwa , djazayeri , and anyone else |
| 14:04:52 | <rafa> Today: |
| 14:04:52 | <rafa> * OpenMRS University |
| 14:04:52 | <rafa> * Looked at #530 Registering an address (when address hierarchy is enabled) |
| 14:04:52 | <rafa> but will not continue right now |
| 14:04:52 | <rafa> * Picked #579 Investigate how two active visits can be opened at the same time |
| 14:04:52 | <rafa> No blockers. |
| 14:05:28 | <wyclif> Tuesday: |
| 14:05:29 | <wyclif> -Work on TRUNK-2850 - OpenMRS crashes irrecoverably if particular errors occur during module loading |
| 14:05:30 | <wyclif> -Reviewed TRUNK-1589 |
| 14:05:32 | <wyclif> Wednesday: |
| 14:05:33 | <wyclif> -Push several of my old pull requests to master |
| 14:05:35 | <wyclif> -More reviews and applying them |
| 14:05:36 | <wyclif> -design call |
| 14:05:37 | <wyclif> |
| 14:05:38 | <wyclif> Blockers: None |
| 14:05:52 | *** masindeandrew has joined #openmrs |
| 14:06:13 | <dkayiwa> Made a commit for a problem i was getting while working on #531 (Registering an address (when address hierarchy is not enabled) |
| 14:06:14 | <dkayiwa> Continuing to work on #531 after a meeting with Cosmin to forge the way forward. |
| 14:06:14 | <dkayiwa> No Blockers |
| 14:08:50 | <cpower> djazayeri: you are up |
| 14:09:08 | <cpower> which is most likely just catching up |
| 14:09:11 | <cpower> ;-) |
| 14:09:51 | <djazayeri> Recently: |
| 14:09:51 | <djazayeri> * Vacation |
| 14:09:51 | <djazayeri> Today: |
| 14:09:51 | <djazayeri> * Finish off Mirebalais Metadata module |
| 14:09:52 | <djazayeri> * Review Rafal's work on custom encounter displays on ref app patient dashboard |
| 14:09:53 | <djazayeri> * calls |
| 14:09:54 | <djazayeri> no blocker |
| 14:13:21 | *** Mkop1 has quit IRC |
| 14:13:57 | *** Mkop1 has joined #openmrs |
| 14:13:57 | *** ChanServ sets mode: +v Mkop1 |
| 14:15:02 | *** masindeandrew has quit IRC |
| 14:18:28 | *** harshadura has quit IRC |
| 14:18:45 | *** harshadura__ has quit IRC |
| 14:19:12 | *** kavuri has joined #openmrs |
| 14:41:14 | *** portablejim has quit IRC |
| 14:45:28 | *** kavuri has quit IRC |
| 14:47:47 | *** tcalder has joined #openmrs |
| 14:52:08 | *** ishara-p has quit IRC |
| 15:00:21 | *** tcalder has quit IRC |
| 15:05:41 | *** rcrichton has quit IRC |
| 15:06:13 | *** tcalder has joined #openmrs |
| 15:19:14 | *** tcalder has quit IRC |
| 15:28:54 | *** tcalder has joined #openmrs |
| 15:30:56 | *** wyclif has quit IRC |
| 15:33:47 | *** ruwanego has joined #openmrs |
| 15:33:54 | *** rowanseymour has joined #openmrs |
| 15:36:08 | *** rafa has quit IRC |
| 15:36:32 | *** annarm has joined #openmrs |
| 15:38:57 | <jblaya> dkayiwa, can I ask you some clarification about your github comments for core, Here https://github.com/ehsdev/openmrs-core/commit/3ce07cffc9868caaac0f42b9d3f45053d8295ceb |
| 15:39:06 | <OpenMRSBot> <http://ln-s.net/-8hV> (at github.com) |
| 15:39:09 | <dkayiwa> jblaya: ok |
| 15:39:40 | <jblaya> dkayiwa, I have to admit that I don't know what you mean by this comment "Instead of concatenating this, can you instead use the getMessage() overload that takes an array of parameters?" |
| 15:39:45 | *** wyclif has joined #openmrs |
| 15:39:52 | <jblaya> dkayiwa, could you provide an example? |
| 15:40:14 | <jblaya> specifically it refers to this code |
| 15:40:15 | <jblaya> + + hl7ConceptId + Context.getMessageSourceService().getMessage("error.ORUR01.invalidConceptID2HL7") |
| 15:40:15 | <jblaya> + + uid); |
| 15:40:15 | <jblaya> } |
| 15:40:15 | <jblaya> } else { |
| 15:40:16 | <jblaya> // the concept is not local, look it up in our mapping |
| 15:40:18 | <jblaya> Concept concept = Context.getConceptService().getConceptByMapping(hl7ConceptId, codingSystem); |
| 15:40:20 | <jblaya> if (concept == null) |
| 15:40:22 | <jblaya> - log.error("Unable to find concept with code: " + hl7ConceptId + " and mapping: " + codingSystem |
| 15:40:24 | <jblaya> - + " in hl7 message with uid: " + uid); |
| 15:40:26 | <jblaya> + log.error(Context.getMessageSourceService().getMessage("error.ORUR01.unableToFindConcept1") + hl7ConceptId |
| 15:40:51 | <dkayiwa> jblaya: here is an example |
| 15:41:21 | *** pulasthi7 has joined #openmrs |
| 15:42:43 | <dkayiwa> getMessage("My last name is {0} and my first name is {1} I live in {2} and some other params {3} stoping here", joaquin, blaya, child, param3) |
| 15:43:10 | <dkayiwa> child = chile :) |
| 15:43:17 | <dkayiwa> jblaya: does the above make sense? |
| 15:43:41 | <jblaya> dkayiwa, perfect |
| 15:44:01 | <jblaya> where {0} gets filled by joaquin, {1} by blaya, and so on |
| 15:44:09 | <dkayiwa> jblaya: excellent!!! |
| 15:44:24 | <jblaya> dkayiwa, ok, will make that revision and update the pull request |
| 15:44:35 | <dkayiwa> jblaya: sure thanks |
| 15:46:42 | *** rowanseymour has quit IRC |
| 15:47:27 | *** ArcTanSusan has joined #openmrs |
| 15:48:48 | *** ArcTanSusan has quit IRC |
| 15:49:45 | *** djazayeri has quit IRC |
| 15:53:04 | *** harshadura has joined #openmrs |
| 15:53:59 | *** djazayeri has joined #openmrs |
| 15:53:59 | *** ChanServ sets mode: +o djazayeri |
| 15:55:19 | *** h3llborn has joined #openmrs |
| 15:55:58 | *** NameFILIP has quit IRC |
| 15:57:32 | *** sashrika has quit IRC |
| 15:57:34 | *** sashrika_ has joined #openmrs |
| 15:58:24 | <sashrika_> wyclif: hi... |
| 15:59:04 | *** elefone has quit IRC |
| 15:59:55 | *** elefone has joined #openmrs |
| 16:00:40 | *** wyclif has quit IRC |
| 16:03:27 | *** wyclif has joined #openmrs |
| 16:17:27 | <jblaya> dkayiwa, just want to check that I"m doing this right, so I should this line log.error(Context.getMessageSourceService().getMessage("error.ORUR01.errorProcessingLocation") + messageControlId, e); |
| 16:17:28 | <jblaya> to this log.error(Context.getMessageSourceService().getMessage({0} {1}, "error.ORUR01.errorProcessingLocation", messageControlId), e); |
| 16:19:56 | <dkayiwa> jblaya: was thinking that the message for the code "error.ORUR01.errorProcessingLocation" in the messages.properties is the one which would have the {0} {1} |
| 16:20:38 | <dkayiwa> jblaya: you will see a number of such messages in messages.properties |
| 16:26:56 | <jblaya> dkayiwa, ah, ok, so I would change the message.properties file entry error.ORUR01.errorProcessingLocation to include the {0} and then in the java page it should look like this |
| 16:27:09 | <jblaya> log.error(Context.getMessageSourceService().getMessage("error.ORUR01.errorProcessingLocation", messageControlId), e); |
| 16:27:25 | <dkayiwa> jblaya: perfect :) |
| 16:27:39 | <jblaya> dkayiwa, ok, learning little by little |
| 16:27:51 | <dkayiwa> jblaya: we all do that way :) |
| 16:37:18 | *** elefone has quit IRC |
| 16:44:37 | *** supun has joined #openmrs |
| 16:45:19 | *** supun has left #openmrs |
| 16:48:58 | *** elefone has joined #openmrs |
| 16:52:51 | *** Hasintha_i has quit IRC |
| 16:57:08 | *** tcalder has quit IRC |
| 16:59:38 | <sashrika_> wyclif: Hi... wyclif . I commited to TRUNK-3176. but i didn't get any notification on it after that. can u check it later? |
| 17:00:02 | <wyclif> sashrika_: did you send a pull request |
| 17:00:24 | <sashrika_> wyclif: yes. https://github.com/openmrs/openmrs-core/pull/292 |
| 17:00:26 | <OpenMRSBot> <http://ln-s.net/-4n9> (at github.com) |
| 17:01:15 | <djazayeri> jkeiper: is ampath using registrationcore now? |
| 17:01:57 | <wyclif> sashrika_: ok |
| 17:02:18 | *** elefone has quit IRC |
| 17:02:19 | <sashrika_> wyclif: Dkayiwa review it once... |
| 17:02:59 | <dkayiwa> sashrika_: its wyclif :) |
| 17:04:04 | <sashrika_> dkayiwa: Yeah...! I don't know that i am making the pull req correctly. |
| 17:04:33 | <dkayiwa> sashrika_: mention it on the ticket |
| 17:05:49 | <sashrika_> dkayiwa: hm...! i think i did that. but now it is on Code Review (Initial) |
| 17:06:01 | <dkayiwa> sashrika_: ok |
| 17:06:08 | <sashrika_> dkayiwa: :) |
| 17:06:27 | *** harshadura has quit IRC |
| 17:08:48 | <sashrika_> dkayiwa: what does mean by Code Review (Post-Commit)? |
| 17:09:24 | <dkayiwa> sashrika_: pull request merged |
| 17:09:39 | *** elefone has joined #openmrs |
| 17:10:11 | <sashrika_> dkayiwa: so why don't it mentioned as ticket closed? what does that mean? |
| 17:10:50 | <dkayiwa> sashrika_: means awaiting review from another dev :) |
| 17:12:27 | <sashrika_> dkayiwa: :) ok...! so can't i take it as i fixed that ticket :P ? |
| 17:12:47 | <dkayiwa> sashrika_: not until closed |
| 17:13:13 | <dkayiwa> sashrika_: another dev could make further requests :) |
| 17:15:22 | <sashrika_> dkayiwa: ok. but my last commit marked as that. but i didn't get any notofication. I thought work is over. seems i have to wait futher more :) |
| 17:16:06 | <jkeiper> djazayeri: not yet |
| 17:16:25 | <sashrika_> dkayiwa: any way thanks... |
| 17:17:17 | <dkayiwa> sashrika_: its up to when another dev reviews it. But if the first reviewer feels confident enough to close (e.g for small tickets) they can always close :) |
| 17:18:20 | <dkayiwa> sashrika_: generally, unless the ticket is complicated, or the first reviewer forgot something, most times the other reviewer may not make any further request for changes :) |
| 17:20:42 | <sashrika_> dkayiwa: aha....! my last commit was merged by u. but i didn't get any notifications on it after that. So all that i can do is wait and see. isn't it? |
| 17:21:02 | <sashrika_> dkayiwa: some may review it later no |
| 17:21:35 | <dkayiwa> sashrika_: just move on until when someone else tells you to do something about it |
| 17:22:45 | <sashrika_> dkayiwa: ok...! fine...! there is another silly question :D |
| 17:24:54 | *** k-joseph has quit IRC |
| 17:26:11 | *** k-joseph has joined #openmrs |
| 17:27:42 | *** rday has joined #openmrs |
| 17:32:02 | *** hybridivy has joined #openmrs |
| 17:33:00 | *** hybridivy has left #openmrs |
| 17:33:39 | *** robbyoconnor has quit IRC |
| 17:38:59 | *** k-joseph has quit IRC |
| 17:43:45 | *** pulasthi7 has quit IRC |
| 17:46:07 | *** rday has quit IRC |
| 17:48:29 | *** k-joseph has joined #openmrs |
| 18:17:30 | *** davidpardz has joined #openmrs |
| 18:19:37 | *** rday has joined #openmrs |
| 18:25:41 | *** rday has quit IRC |
| 18:29:36 | *** rday has joined #openmrs |
| 18:40:40 | *** ruwanego has quit IRC |
| 18:49:01 | *** rowanseymour has joined #openmrs |
| 18:51:08 | *** tcalder has joined #openmrs |
| 19:02:03 | *** rowanseymour has quit IRC |
| 19:03:45 | *** k-joseph has quit IRC |
| 19:07:30 | *** elefone has quit IRC |
| 19:08:42 | *** h3llborn has quit IRC |
| 19:08:53 | *** rday has quit IRC |
| 19:09:37 | *** sashrika_ has quit IRC |
| 19:10:52 | *** rday has joined #openmrs |
| 19:11:58 | *** davidpardz has left #openmrs |
| 19:14:40 | *** breeze has joined #openmrs |
| 19:25:09 | *** rowanseymour has joined #openmrs |
| 19:27:18 | <jblaya> dkayiwa, translated all, you made a comment "Can we choose a key whose name is enough to tell us the error message it represents? :)" |
| 19:27:46 | <dkayiwa> jblaya: yes a more meaningful name :) |
| 19:28:12 | <jblaya> but the keys already tell the error message for example error.ORUR01.couldNotResolveProvider=Could not resolve provider {0} : {1} |
| 19:28:12 | <jblaya> error.ORUR01.noUniqueIDProvider=No unique identifier was found for the provider |
| 19:28:33 | <jblaya> how should I make them more explicit |
| 19:28:35 | <jblaya> ? |
| 19:34:12 | <jblaya> dkayiwa, can you give me an example of the two above how I should make it more meaningful? |
| 19:34:41 | <dkayiwa> jblaya: like for which text? |
| 19:35:07 | <jblaya> dkayiwa, error.ORUR01.invalidConceptIDHL7=Invalid concept ID '{0}' in hl7 message with uid: {1} |
| 19:35:26 | <dkayiwa> jblaya: that looks good |
| 19:35:48 | <jblaya> dkayiwa, ok, because all of them are like that that's why I thought your comment was strange :) |
| 19:35:53 | <dkayiwa> jblaya: the majority were good. but you had some few like ...1, ...2, ...3 etc :) |
| 19:36:09 | *** sashrika has joined #openmrs |
| 19:36:10 | <jblaya> dkayiwa, ah! yes, I fixed those with these changes I made |
| 19:36:42 | <dkayiwa> jblaya: those are the ones i was referring to. looking at their names, there was no way you could tell what they were for :) |
| 19:40:27 | *** sashrika has quit IRC |
| 19:41:21 | *** rcrichton has joined #openmrs |
| 19:43:33 | *** tcalder has quit IRC |
| 19:43:57 | *** tcalder has joined #openmrs |
| 19:48:38 | <jblaya> dkayiwa, done, unto another ticket. For this one https://tickets.openmrs.org/browse/TRUNK-1820 you asked me to make a pull request, which file do I need to modify to submit the pull request? |
| 19:48:59 | <dkayiwa> jblaya: commit and push |
| 19:49:07 | *** rday has quit IRC |
| 19:49:18 | <burke> breeze: hey breeze! r u there? |
| 19:51:28 | *** k-joseph has joined #openmrs |
| 19:53:31 | *** djazayeri1 has joined #openmrs |
| 19:53:41 | *** rowanseymour has quit IRC |
| 19:54:16 | <jblaya> dkayiwa, yep, committed and pushed the code |
| 19:54:28 | <jblaya> dkayiwa, the update pull reuqest should be there |
| 19:54:38 | *** djazayeri has quit IRC |
| 19:54:59 | <dkayiwa> jblaya: put the commit url on the ticket and request for code review |
| 19:57:00 | *** tcalder has quit IRC |
| 19:57:25 | <jblaya> dkayiwa, done, my questions was now for the Chile Address format. On trunk-1820, I submit a txt file with the address, so if I was to submit a pull request, which file would I have to change for this address format? |
| 19:58:18 | <dkayiwa> jblaya: you would just commit, push and then create a pull request |
| 19:58:27 | <dkayiwa> jblaya: https://wiki.openmrs.org/display/docs/Using+Git |
| 19:59:09 | <jblaya> dkayiwa, sorry, I think my question is even more simple than that, I don't knwo which file in openmrs-core to change in order to update the address format |
| 19:59:50 | <dkayiwa> jblaya: first step would be to ask on the ticket |
| 20:01:00 | *** rowanseymour has joined #openmrs |
| 20:02:07 | *** rday has joined #openmrs |
| 20:02:58 | *** rowanseymour has quit IRC |
| 20:03:52 | *** elefone has joined #openmrs |
| 20:23:53 | *** k-joseph has quit IRC |
| 20:24:29 | *** k-joseph_ has joined #openmrs |
| 20:30:09 | *** breeze has quit IRC |
| 20:37:39 | *** snoppy has quit IRC |
| 20:44:47 | <djazayeri1> jkeiper: your answer to https://groups.google.com/a/openmrs.org/d/msg/dev/sJifMi12CBI/OXclaQ0A14MJ most welcome. :-) |
| 20:44:52 | <OpenMRSBot> <http://ln-s.net/-8p5> (at groups.google.com) |
| 20:53:44 | *** garima has joined #openmrs |
| 20:57:17 | *** k-joseph_ is now known as k-joseph |
| 20:59:47 | *** rday has quit IRC |
| 21:03:14 | *** djazayeri1 is now known as djazayeri |
| 21:03:28 | *** ChanServ sets mode: +o djazayeri |
| 21:06:42 | *** rcrichton has quit IRC |
| 21:08:13 | *** tcalder has joined #openmrs |
| 21:14:47 | *** tcalder has quit IRC |
| 21:43:38 | *** GitHub19 has joined #openmrs |
| 21:43:38 | <GitHub19> [openmrs-core] wluyima opened pull request #311: OpenMRS crashes irrecoverably if particular errors occur during module loading - TRUNK-2850 (master...TRUNK-2850) http://git.io/-ZDc9g |
| 21:43:38 | *** GitHub19 has left #openmrs |
| 21:44:18 | *** k-joseph has quit IRC |
| 21:53:15 | *** wyclif has quit IRC |
| 22:06:39 | *** dkayiwa has quit IRC |
| 22:12:04 | *** tcalder has joined #openmrs |
| 22:14:56 | *** harsz89 has quit IRC |
| 22:24:24 | *** elefone has quit IRC |
| 22:25:08 | *** elefone has joined #openmrs |
| 22:32:58 | *** wyclif has joined #openmrs |
| 22:36:54 | *** elefone has quit IRC |
| 23:10:07 | *** tcalder has quit IRC |
| 23:15:42 | *** tcalder has joined #openmrs |
| 23:27:58 | *** tcalder has quit IRC |
| 23:27:59 | *** jblaya has quit IRC |
| 23:40:49 | *** GitHub143 has joined #openmrs |
| 23:40:49 | <GitHub143> [openmrs-core] wluyima pushed 1 new commit to master: http://git.io/nb3mAg |
| 23:40:49 | <GitHub143> openmrs-core/master 3c4427b unknown: Fill javadoc for class org.openmrs.activelist.ActiveListType - TRUNK-3176... |
| 23:40:49 | *** GitHub143 has left #openmrs |
| 23:48:02 | <wyclif> hi djazayeri |
| 23:48:09 | <djazayeri> hi wyclif |
| 23:48:14 | <wyclif> djazayeri: what happened to the authors.txt file |
| 23:48:25 | <wyclif> djazayeri: i can't seem to find it on the wiki |
| 23:48:49 | <djazayeri> wyclif: no idea; I haven't seen it or searched for it in a year at least |
| 23:50:30 | <wyclif> djazayeri: figure out the problem, if you are not logged in you can't actually access it, once i logged in i accessed it |
| 23:50:42 | *** travis-ci has joined #openmrs |
| 23:50:42 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [3c4427b] [unknown] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/7005696 |
| 23:50:42 | *** travis-ci has left #openmrs |
| 23:50:48 | <OpenMRSBot> <http://ln-s.net/-8tH> (at travis-ci.org) |
| 23:50:58 | *** that_noob has joined #openmrs |
| 23:51:01 | <djazayeri> wyclif: cool |
| 23:56:54 | *** rday has joined #openmrs |