| 00:16:00 | *** ArcTanSusan has joined #openmrs |
| 00:34:02 | *** ArcTanSusan has quit IRC |
| 00:35:09 | *** ArcTanSusan has joined #openmrs |
| 00:35:12 | *** Anuruddha has joined #openmrs |
| 00:40:48 | *** Anuruddha has quit IRC |
| 01:14:28 | *** sunbiz has joined #openmrs |
| 01:14:28 | *** ChanServ sets mode: +v sunbiz |
| 01:17:54 | *** rday has joined #openmrs |
| 01:25:52 | *** ArcTanSusan has quit IRC |
| 02:41:48 | *** breeze has joined #openmrs |
| 03:20:13 | *** ruwanego has joined #openmrs |
| 03:25:29 | *** harshadura has joined #openmrs |
| 03:26:15 | *** jblaya has joined #openmrs |
| 03:26:54 | <jblaya> mseaton, you around by any chance? I had a quick question about reporting compatibility |
| 03:30:48 | <jblaya> nribeka, don't know if the IV is still going and if you've played around with the reporting compatibility module? I need to figure out what function replaced the deprecated evaluate function |
| 03:30:50 | <jblaya> cohortService.evaluate(c.getCohortDefinition(), null); |
| 03:30:59 | <jblaya> is giving me an error in my code |
| 03:32:23 | <nribeka> i'm almost gone |
| 03:32:43 | <nribeka> cohortService.evaluate --> this one from reporting right? |
| 03:32:51 | <jblaya> reporting compatibility |
| 03:33:26 | <jblaya> I'm still using reporting compatibility because of the cohort builder which is so pretty :D |
| 03:34:16 | <nribeka> hmmm |
| 03:34:41 | <nribeka> can you pastebin your code jblaya ? |
| 03:35:22 | <jblaya> nribeka, yep, let me get it |
| 03:37:22 | *** Duc_ has joined #openmrs |
| 03:39:54 | <jblaya> nribeka, here it is |
| 03:39:56 | <jblaya> /** |
| 03:39:56 | <jblaya> * Returns list of all the patients inside the given cohort. |
| 03:39:56 | <jblaya> * @param CohortDefinitionItemHolder |
| 03:39:56 | <jblaya> * @returns List<Patient> |
| 03:39:56 | <jblaya> */ |
| 03:39:58 | <jblaya> @Override |
| 03:40:00 | <jblaya> public List<Patient> getPatientsInCohort(CohortDefinitionItemHolder c) throws PatientIdentifierException { |
| 03:40:03 | <jblaya> List<Patient> patients = new LinkedList<Patient>(); |
| 03:40:07 | <jblaya> try { |
| 03:40:09 | <jblaya> Cohort cohort = cohortService.evaluate(c.getCohortDefinition(), null); |
| 03:40:11 | <jblaya> Set<Integer> memberIds = cohort.getMemberIds(); |
| 03:40:13 | <jblaya> for (Integer i : memberIds) { |
| 03:40:15 | <jblaya> patients.add(Context.getPatientService().getPatient(i)); |
| 03:40:17 | <jblaya> } |
| 03:40:19 | <jblaya> } |
| 03:40:20 | *** harshadura has quit IRC |
| 03:40:21 | <jblaya> catch (PatientIdentifierException e) { |
| 03:40:23 | <jblaya> log.error(e); |
| 03:40:25 | <jblaya> } |
| 03:40:27 | <jblaya> return patients; |
| 03:40:29 | <jblaya> } |
| 03:40:31 | <jblaya> sorry, forgot the pastebin, will give you the full java page now |
| 03:41:04 | <jblaya> nribeka, here it is http://pastebin.com/T4djtwNu , line 90 is the cause of the problem |
| 03:43:57 | <jblaya> Duc_, whose doing the programming isn't able to find the javadocs for the module or what function replaced the evaluate function since it's deprecated |
| 03:48:47 | <nribeka> what is the exception jblaya? |
| 03:50:30 | <jblaya> let me get it |
| 03:50:33 | <nribeka> the api is calling only core code (deprecated one) |
| 03:51:14 | <jblaya> ERROR - errorhandler_jsp._jspService(91) |2013-05-05 23:50:24,072| Error on page /midoctor/WEB-INF/view/module/midoctorpanel/portlets/midoctorHome.jsp |
| 03:51:14 | <jblaya> javax.servlet.jsp.JspException: java.lang.IllegalArgumentException: search must be saved, composition, or must have a class specified |
| 03:52:00 | <jblaya> nribeka, the error occurs when we call a sql filter saved patient search |
| 03:52:11 | <jblaya> the other types of filters work |
| 03:52:16 | <jblaya> so it's something specific to the sql filter |
| 03:52:27 | <jblaya> sunbiz, mentioend that it seems it's not creating a class |
| 03:59:06 | <nribeka> this class seems to be the one throwing the exception: PatientSearchCohortDefinitionProvider |
| 03:59:22 | <nribeka> line 57 |
| 03:59:34 | <nribeka> so that cohortService.evaluate delegating it to this class |
| 04:01:52 | <Duc_> this class in which module? |
| 04:01:55 | <jblaya> nribeka, what line is that? because it's not 57 in the pastebin |
| 04:02:43 | <nribeka> in your pastebin, the one that throw exception is cohortService.evaluate ... |
| 04:03:12 | <nribeka> the cohortService.evaluate delegating the evaluation to PatientSearchCohortDefinitionProvider.evaluate |
| 04:03:37 | <nribeka> can you do: (in your module, before line 90) |
| 04:04:10 | <nribeka> CohortDefinition cd = c.getCohortDefinition(); |
| 04:04:39 | <nribeka> if (cd instanceof PatientSearch) { |
| 04:04:57 | <nribeka> PatientSearch ps = (PatientSearch) cd; |
| 04:05:40 | <nribeka> System.out.println("PatientSearch: " + ps.toString()); |
| 04:05:42 | <nribeka> } |
| 04:06:03 | <nribeka> could be your cohort definition is the problem jblaya hehehe ... |
| 04:06:43 | <jblaya> I have a feeling that the programmer who did the sql filter (who worked for me) didn't do something completelyl right |
| 04:06:58 | <jblaya> because the saved patient search does give a result in the cohort builder |
| 04:07:27 | <nribeka> better use reporting jblaya :) |
| 04:08:09 | <jblaya> nribeka, :D yeah, when we get a cohort builder that users like |
| 04:08:24 | <jblaya> so the code should look like this? |
| 04:08:44 | <jblaya> if (cd instanceof PatientSearch) { |
| 04:08:44 | <jblaya> PatientSearch ps = (PatientSearch) cd; |
| 04:08:44 | <jblaya> System.out.println("PatientSearch: " + ps.toString()); |
| 04:08:44 | <jblaya> } |
| 04:08:44 | <jblaya> |
| 04:08:45 | <jblaya> try { |
| 04:08:46 | <jblaya> Cohort cohort = cohortService.evaluate(c.getCohortDefinition(), null); |
| 04:08:48 | <jblaya> Set<Integer> memberIds = cohort.getMemberIds(); |
| 04:08:51 | <jblaya> for (Integer i : memberIds) { |
| 04:08:53 | <jblaya> patients.add(Context.getPatientService().getPatient(i)); |
| 04:08:55 | <jblaya> } |
| 04:08:56 | <jblaya> } |
| 04:09:02 | <nribeka> yeah |
| 04:09:21 | <nribeka> something like that. |
| 04:09:30 | <jblaya> Duc_, I don't know if you understand the code, but I certainly don't |
| 04:10:12 | <nribeka> CohortDefinition cd = c.getCohortDefinition(); |
| 04:10:18 | <nribeka> missing that line? |
| 04:10:27 | <jblaya> yeah, I saw it and placed it in |
| 04:11:12 | <jblaya> hmm, in the compilation it gives me this error: cannot find symbol |
| 04:11:21 | <Duc_> let's me try |
| 04:11:38 | <nribeka> basically the exception will happen (according to the code in core) when you don't set the filterClass in the PatientSearch class |
| 04:11:56 | <nribeka> so the stack trace for that one started from here jblaya |
| 04:12:32 | <nribeka> CohortService.evaluate |
| 04:12:58 | <nribeka> PatientSearchCohortDefinitionProvider.evaluate |
| 04:13:22 | <nribeka> OpenmrsUtil.toPatientFilter |
| 04:13:40 | <jblaya> so ti still gives the same error |
| 04:13:49 | <nribeka> this is the line where the exception started: |
| 04:13:51 | <nribeka> Class clz = search.getFilterClass(); |
| 04:13:51 | <nribeka> if (clz == null) |
| 04:13:51 | <nribeka> throw new IllegalArgumentException("search must be saved, composition, or must have a class specified"); |
| 04:14:17 | <nribeka> is it printing out the content of the cohort definition or no? |
| 04:14:40 | <jblaya> yep, here it is |
| 04:14:41 | <jblaya> PatientSearch: PatientSearch parsedComposition= |
| 04:14:41 | <jblaya> [PatientSearch filterClass=class org.openmrs.reporting.ObsPatientFilter (class org.openmrs.api.PatientSetService$TimeModifier)timeModifier=LAST (class org.openmrs.Concept)question=75 (class org.openmrs.api.PatientSetService$Modifier)modifier=EQUAL (class org.openmrs.Concept)value=146, AND, PatientSearch filterClass=class org.openmrs.reporting.ObsPatientFilter (class org.openmrs.api.PatientSetService$TimeModifier)timeModifier=LAST (class org.openmrs.Concep |
| 04:14:41 | <jblaya> t)question=7 (class org.openmrs.api.PatientSetService$Modifier)modifier=EQUAL (class org.openmrs.Concept)value=9] |
| 04:14:43 | <jblaya> NOT |
| 04:14:45 | <jblaya> PatientSearch |
| 04:18:09 | <nribeka> the last two part of it? |
| 04:18:35 | <jblaya> yeah, don't know why |
| 04:18:42 | <jblaya> actually |
| 04:18:46 | <jblaya> that's the problem there |
| 04:18:55 | <nribeka> yeah |
| 04:19:00 | *** Hasintha_i has joined #openmrs |
| 04:19:00 | <jblaya> after the NOT there is the sql statement for that filter and it's not being written |
| 04:19:09 | <nribeka> the first clause seems to be correct |
| 04:19:28 | <nribeka> the PatientSearch only is not correct i think |
| 04:20:24 | *** h3llborn has joined #openmrs |
| 04:20:43 | <jblaya> yep, here's the full definition of the patient search from the admin page |
| 04:20:44 | <jblaya> http://pastebin.com/h1d5UaPH |
| 04:21:31 | <jblaya> so for some reason the query in lines 172 on is not being placed into the patient search |
| 04:22:08 | <jblaya> funny ting is that the search does work in the cohort builder |
| 04:22:54 | <nribeka> hmmm the xml seems to be not getting deserialized correctly |
| 04:23:05 | <nribeka> how do you create the cohort definition jblaya? |
| 04:23:14 | <nribeka> reading xml file like this? |
| 04:23:39 | <jblaya> nop, I created a couple of obs searches, and then a sql search |
| 04:23:47 | <jblaya> then I composed them with composition |
| 04:23:52 | <jblaya> and the composition one I saved |
| 04:23:55 | <jblaya> the others I didn't |
| 04:24:03 | <nribeka> <void property="filterClass"><class>org.openmrs.module.reportingcompatibility.reporting.PatientSqlFilter</class></void> |
| 04:24:07 | <jblaya> the obs, sql searches that are the components |
| 04:24:20 | <jblaya> right |
| 04:24:23 | <nribeka> in the xml it is saved, but it's not in the class i think |
| 04:24:50 | <nribeka> that's why it's throwing the filterClass exception |
| 04:25:30 | <nribeka> this could be a bug |
| 04:25:32 | <nribeka> :D |
| 04:25:38 | <jblaya> yeah, it probably is |
| 04:26:00 | <nribeka> and they will ask you to switch to reporting hehehe ... |
| 04:26:20 | <nribeka> probably ask the dev list that way |
| 04:26:20 | <jblaya> well, the idea is that Duc_ will fix this bug and submit it |
| 04:26:36 | <nribeka> hahahahaha ... well that's good then :D |
| 04:26:39 | <jblaya> that's why I asked him to come onto the chat |
| 04:26:59 | <jblaya> yep, basically this was to help Duc_ figure out where the problem is so that he can fix it (hopefully tonight) |
| 04:27:21 | <jblaya> Duc_, don't know if you have any other questions about how to fix this? |
| 04:27:43 | <jblaya> nribeka, so this needs to be fixed in the reporting compatibility module, right? and not in our module |
| 04:28:06 | <nribeka> where did you get that xml jblaya? |
| 04:28:21 | <nribeka> the one that read and write that xml probably need to get fixed |
| 04:28:40 | <nribeka> report object table? |
| 04:29:21 | <jblaya> from the Manage Patient Searches in the administration page |
| 04:30:04 | <jblaya> http://localhost:8080/openmrsr/admin/reports/patientSearch.form?patientSearchIdLookup=21 |
| 04:30:44 | <jblaya> In the admin page, its Reports -> Manage Patient Searches |
| 04:31:31 | <nribeka> i don't think it's your module jblaya |
| 04:31:37 | <nribeka> probably in core |
| 04:32:10 | <jblaya> nribeka, core or the reporting compatibility module? |
| 04:32:40 | <nribeka> i think it's going to core |
| 04:32:48 | <nribeka> nothing in the reporting compatibility module |
| 04:33:30 | <jblaya> any tips as to where, so that Duc_ can work on it? |
| 04:35:12 | <nribeka> jblaya: first find where that xml is stored (report_object) table |
| 04:35:29 | <nribeka> find how report_object table is being saved and retrieved as PatientSearch |
| 04:35:38 | <nribeka> update that patient search |
| 04:36:39 | <jblaya> ok, great, thanks, Duc_ do you have any more questions? |
| 04:38:43 | <jblaya> guess not, thanks nribeka, I think I've probably bugged you enough during this weekend |
| 04:38:51 | <Duc_> so now I will work on reporting compatibility |
| 04:39:50 | <jblaya> Duc_, actually what nribeka mentions is that you will probably have to work on the core code of openmrs https://github.com/openmrs/openmrs-core/ |
| 04:40:21 | <Duc_> ok |
| 04:40:42 | *** annarm has quit IRC |
| 04:40:58 | <Duc_> I will follow nribeka suggestions |
| 04:42:43 | <nribeka> jblaya: i don't see anything in this module: https://github.com/openmrs/openmrs-module-reportingcompatibility |
| 04:42:52 | <OpenMRSBot> <http://ln-s.net/-7gg> (at github.com) |
| 04:45:09 | <jblaya> nribeka, ok, great, it's actually better for us if it's in core because I've made some customization to hard coded translations in the rep comp |
| 04:46:52 | *** h3llborn has quit IRC |
| 04:48:15 | <jblaya> nribeka, Duc_ , this looks promising api/src/test/java/org/openmrs/report/ReportSchemaXmlTest.java: xml2.append(" <cohort class=\"org.openmrs.reporting.PatientSearch\">\n"); |
| 04:49:01 | *** ruwanego_ has joined #openmrs |
| 04:49:36 | *** ruwanego has quit IRC |
| 04:50:04 | *** ruwanego_ has quit IRC |
| 04:50:45 | <jblaya> and these two api/src/test/java/org/openmrs/report/PatientSearchParameterTest.java: protected static final String INITIAL_REPORT_OBJECTS_XML = "org/openmrs/report/include/PatientSearchParameterTest.xml"; |
| 04:50:45 | <jblaya> api/src/test/java/org/openmrs/report/PatientSearchParameterTest.java: * Tests {@link PatientSearch#getParameters()} to see if parameter names evaluate to a value |
| 04:52:52 | <jblaya> thanks nribeka for all of the help, I (and hopefully you) am going to sleep |
| 04:53:33 | <nribeka> yeah, look at the set and get for filterClass in the PatientSearch.java Duc_ |
| 04:54:10 | <nribeka> try to put some debug message around that method. i think that method is throwing exception because the PatienSqlFilter is not available |
| 04:54:24 | <nribeka> i could be wrong and you could ask mseaton tomorrow morning :) |
| 04:54:45 | <Duc_> ok. thanks |
| 04:55:08 | <nribeka> @Attribute(required = false) |
| 04:55:08 | <nribeka> public Class getFilterClass() |
| 04:55:39 | <nribeka> using simpleframework api to read and write the xml :) |
| 04:56:01 | <nribeka> i'm out :) cya all tomorrow. |
| 04:56:36 | *** kavuri has joined #openmrs |
| 04:59:19 | *** jblaya has quit IRC |
| 05:01:21 | *** jblaya has joined #openmrs |
| 05:11:11 | *** harshadura has joined #openmrs |
| 05:16:12 | *** jblaya has quit IRC |
| 05:28:03 | *** jb360 has quit IRC |
| 06:05:05 | *** rcrichton has joined #openmrs |
| 07:11:28 | *** k-joseph_ has joined #openmrs |
| 07:13:54 | *** harshadura has joined #openmrs |
| 07:15:11 | *** rday has quit IRC |
| 07:16:05 | *** harshadura_ has joined #openmrs |
| 07:16:49 | *** Lucy_Marie has joined #openmrs |
| 07:17:31 | <Lucy_Marie> hi hi hi |
| 07:19:04 | *** harshadura has quit IRC |
| 07:19:55 | *** k-joseph_ has quit IRC |
| 07:27:34 | <Lucy_Marie> ne1 here |
| 07:30:19 | *** harshadura has joined #openmrs |
| 07:31:24 | <harshadura> hi Lucy_Marie |
| 07:31:41 | *** harshadura_ has quit IRC |
| 07:31:43 | <Lucy_Marie> hi Hasintha_i |
| 07:31:50 | <Lucy_Marie> hi harshadura |
| 07:31:58 | *** k-joseph has joined #openmrs |
| 07:32:00 | <Lucy_Marie> how are you today |
| 07:32:11 | <Lucy_Marie> hi k-joseph |
| 07:32:28 | *** harshadura_ has joined #openmrs |
| 07:32:33 | *** harshadura has quit IRC |
| 07:34:27 | *** harshadura_ is now known as harshadura |
| 07:35:25 | <k-joseph> Lucy_Marie: hi |
| 07:35:29 | *** harshadura has quit IRC |
| 07:36:29 | <Lucy_Marie> how are you k-joseph |
| 07:38:09 | <k-joseph> Lucy_Marie: ok, and how about you? |
| 07:38:30 | <Lucy_Marie> ok ish bit nervous but ok |
| 07:43:08 | *** k-joseph has quit IRC |
| 07:44:49 | *** rday has joined #openmrs |
| 07:46:10 | <Lucy_Marie> hi rday |
| 07:47:36 | <rday> Lucy_Marie: Hello |
| 07:49:53 | <Lucy_Marie> how are you rday |
| 07:50:42 | <rday> Lucy_Marie: I am alright, yourself? |
| 07:54:12 | <Lucy_Marie> i am ok a little nervous but ok |
| 07:59:52 | *** k-joseph has joined #openmrs |
| 08:00:00 | *** ruwanego has joined #openmrs |
| 08:00:37 | *** Lucy_Marie has quit IRC |
| 08:01:56 | *** k-joseph has left #openmrs |
| 08:02:39 | *** b0b has quit IRC |
| 08:03:43 | *** k-joseph has joined #openmrs |
| 08:05:08 | *** b0b has joined #openmrs |
| 08:16:51 | *** k-joseph_ has joined #openmrs |
| 08:18:31 | *** breeze has quit IRC |
| 08:19:15 | *** k-joseph has quit IRC |
| 08:22:20 | *** k-joseph_ has quit IRC |
| 08:22:42 | *** k-joseph has joined #openmrs |
| 08:53:15 | *** NameFILIP has joined #openmrs |
| 09:08:23 | *** rowanseymour has joined #openmrs |
| 09:11:29 | *** lh has joined #openmrs |
| 09:18:20 | *** NameFILIP has quit IRC |
| 09:24:31 | *** harshadura has joined #openmrs |
| 09:24:49 | *** rowanseymour has quit IRC |
| 09:36:56 | *** rowanseymour has joined #openmrs |
| 09:41:04 | *** ruwanego has quit IRC |
| 09:41:49 | *** ruwanego has joined #openmrs |
| 09:49:31 | *** ruwanego has quit IRC |
| 09:50:04 | *** harshadura_ has joined #openmrs |
| 09:52:50 | *** dkayiwa has joined #openmrs |
| 09:53:14 | *** harshadura has quit IRC |
| 10:02:05 | *** Sateesh has joined #openmrs |
| 10:02:05 | *** kavuri has quit IRC |
| 10:06:42 | *** harshadura_ has quit IRC |
| 10:11:16 | *** ruwanego has joined #openmrs |
| 10:12:09 | *** ruwanego has joined #openmrs |
| 10:26:31 | *** NameFILIP has joined #openmrs |
| 10:26:58 | *** rowanseymour has quit IRC |
| 10:29:16 | <Hasintha_i> suranga, hi |
| 10:35:20 | *** NameFILIP has quit IRC |
| 10:36:48 | *** rday has quit IRC |
| 10:37:14 | *** ruwanego_ has joined #openmrs |
| 10:41:44 | *** ruwanego has quit IRC |
| 10:45:48 | *** harshadura has joined #openmrs |
| 10:45:48 | *** ChanServ sets mode: +v harshadura |
| 10:49:07 | *** ruwanego_ has quit IRC |
| 10:51:30 | <suranga> Hasintha_i: howdy ! |
| 10:52:04 | <Hasintha_i> suranga, done with your exams ? :-) |
| 10:52:27 | <suranga> Hasintha_i: well, most of them :P |
| 10:52:27 | <suranga> not all :) |
| 10:52:42 | <suranga> Hasintha_i: hows your schedule like ? |
| 10:52:52 | *** ruwanego has joined #openmrs |
| 10:54:02 | <Hasintha_i> suranga, schedule is totally packed with work :D , btw when will be the deadline to resolve a ticket ? |
| 10:54:37 | <suranga> Hasintha_i: um, the sooner the better, actually :) |
| 10:57:52 | <suranga> Hasintha_i: I need to pop out for a while, be back soon (have to meet my supervisor :) |
| 10:58:42 | <Hasintha_i> suranga, ok , cu :) |
| 11:00:12 | *** harshadura has quit IRC |
| 11:12:37 | <dkayiwa> #hum-team |
| 11:13:41 | *** harshadura has joined #openmrs |
| 11:13:41 | *** ChanServ sets mode: +v harshadura |
| 11:15:56 | *** robbyoconnor has quit IRC |
| 11:19:07 | *** ruwanego_ has joined #openmrs |
| 11:19:09 | *** k-joseph_ has joined #openmrs |
| 11:20:22 | *** k-joseph has quit IRC |
| 11:21:24 | *** k-joseph_ is now known as k-joseph |
| 11:22:16 | *** ruwanego has quit IRC |
| 11:23:23 | *** rkorytkowski has joined #openmrs |
| 11:23:23 | *** rkorytkowski is now known as rafa |
| 11:23:23 | *** ChanServ sets mode: +v rafa |
| 11:24:16 | *** sashrika has joined #openmrs |
| 11:26:25 | *** rowanseymour has joined #openmrs |
| 11:33:10 | *** ruwanego_ has quit IRC |
| 11:33:35 | *** ruwanego_ has joined #openmrs |
| 11:35:31 | <dkayiwa> hi rafa |
| 11:35:44 | <dkayiwa> rafa: Am hoping you had a nice weekend :) |
| 11:35:52 | <rafa> dkayiwa: hi |
| 11:36:05 | <rafa> dkayiwa: it was perfect thanks! |
| 11:36:18 | <rafa> dkayiwa: how was yours? |
| 11:36:26 | <dkayiwa> rafa: it was good too :) |
| 11:37:06 | <dkayiwa> rafa: do you think you will have some time today for some pair programming on #527 |
| 11:37:17 | <dkayiwa> rafa: am too much a newbie in mirebalais :) |
| 11:37:23 | <rafa> dkayiwa: absolutely! |
| 11:37:38 | <dkayiwa> rafa: ok just tell me whenever you will be ready :) |
| 11:37:41 | <rafa> dkayiwa: will you have time in 20 minutes? |
| 11:37:48 | <dkayiwa> rafa: oh yes |
| 11:38:10 | <rafa> dkayiwa: I need to respond to a few e-mails |
| 11:38:18 | <rafa> dkayiwa: great |
| 11:38:18 | <dkayiwa> rafa: cool!!! |
| 11:48:52 | *** k-joseph has quit IRC |
| 11:49:12 | *** Duc_ has quit IRC |
| 11:50:00 | *** Hasintha_i has quit IRC |
| 11:56:23 | *** NameFILIP has joined #openmrs |
| 11:57:30 | <rafa> dkayiwa: I'm ready :) |
| 11:57:38 | *** Sateesh has quit IRC |
| 11:58:21 | *** dkayiwa_ has joined #openmrs |
| 11:58:28 | *** dkayiwa has quit IRC |
| 11:58:29 | *** dkayiwa_ is now known as dkayiwa |
| 11:58:32 | <dkayiwa> rafa: sorry i stepped on my modem :) |
| 11:58:44 | <dkayiwa> rafa: sure am ready too |
| 11:59:05 | <dkayiwa> rafa: did your team viewer also expire? |
| 11:59:18 | <rafa> dkayiwa: it works just fine |
| 11:59:26 | <rafa> dkayiwa: I use a free version |
| 11:59:33 | <dkayiwa> rafa: let me check mine |
| 11:59:51 | <rafa> dkayiwa: one that doesn't need an installation on Windows |
| 12:00:00 | <dkayiwa> rafa: oh :) |
| 12:00:24 | <rafa> dkayiwa: are you on skype? |
| 12:00:45 | <dkayiwa> rafa: i can get there too :) |
| 12:00:56 | <rafa> dkayiwa: great |
| 12:04:16 | <dkayiwa> rafa: i have TeamViewer running |
| 12:04:59 | <rafa> dkayiwa: I sent connection details on skype |
| 12:05:08 | <dkayiwa> rafa: ok |
| 12:06:06 | *** ruwanego_ has quit IRC |
| 12:09:42 | *** Hasintha_i has joined #openmrs |
| 12:14:59 | *** NameFILIP has quit IRC |
| 12:16:51 | *** harshadura has quit IRC |
| 12:19:37 | *** rowanseymour has quit IRC |
| 12:22:57 | *** tcalder has joined #openmrs |
| 12:23:02 | *** jblaya has joined #openmrs |
| 12:27:32 | *** cospih has joined #openmrs |
| 12:29:56 | *** harshadura has joined #openmrs |
| 12:29:56 | *** ChanServ sets mode: +v harshadura |
| 12:35:02 | *** sashrika has quit IRC |
| 12:44:50 | *** NameFILIP has joined #openmrs |
| 12:46:40 | *** rowanseymour has joined #openmrs |
| 12:47:17 | *** sashrika has joined #openmrs |
| 12:55:54 | *** harshadura has quit IRC |
| 13:07:44 | *** harshadura has joined #openmrs |
| 13:07:44 | *** ChanServ sets mode: +v harshadura |
| 13:08:45 | *** NameFILIP has quit IRC |
| 13:09:06 | *** wyclif has joined #openmrs |
| 13:09:48 | *** annarm has joined #openmrs |
| 13:23:52 | *** k-joseph has joined #openmrs |
| 13:32:42 | *** jblaya has quit IRC |
| 13:34:23 | *** breeze has joined #openmrs |
| 13:35:57 | *** jennparise has joined #openmrs |
| 13:48:21 | *** harshadura has quit IRC |
| 13:55:52 | *** sashrika has quit IRC |
| 14:01:52 | <rafa> dkayiwa: let me know how things are going |
| 14:02:03 | <dkayiwa> rafa: still building :) |
| 14:02:07 | *** harshadura has joined #openmrs |
| 14:02:07 | *** ChanServ sets mode: +v harshadura |
| 14:03:08 | <dkayiwa> rafa: too many saveConceptReferenceTerm going on in the logs :) |
| 14:04:39 | *** harsz89 has joined #openmrs |
| 14:04:39 | *** tcalder has quit IRC |
| 14:10:31 | *** harsha89 has joined #openmrs |
| 14:11:22 | *** harshadura has quit IRC |
| 14:11:49 | *** harsz89 has quit IRC |
| 14:12:06 | <cpower> Morning everyone ready to scrum |
| 14:12:07 | <cpower> ? |
| 14:12:18 | <cpower> Silence is golden |
| 14:12:24 | <cpower> !scrumon cpower |
| 14:12:24 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:13:10 | <cpower> Order: mseaton , rafa , breeze , dkayiwa , wyclif |
| 14:13:38 | <mseaton> nothing of note to report here. |
| 14:15:03 | <cpower> ok rafa: you are up |
| 14:15:18 | <rafa> Today: |
| 14:15:18 | <rafa> * Paired with Daniel on mirebalais setup |
| 14:15:18 | <rafa> * Worked on improving #524 Spike on refactoring custom displays for different encounter types |
| 14:15:18 | <rafa> No blockers. |
| 14:17:58 | <wyclif> ? |
| 14:18:02 | <cpower> breeze: any updates? |
| 14:18:02 | <dkayiwa> Paired with Rafal on getting my mirebalais setup |
| 14:18:03 | <dkayiwa> Now running mirebalais again with all the modules (It is taking too long though :) |
| 14:18:03 | <dkayiwa> No Blockers |
| 14:18:22 | *** rowanseymour has quit IRC |
| 14:18:55 | <wyclif> dkayiwa: to make it faster you need to comment out the code in the started and contextRefreshed methods of the activators of emr and mirebalais modules |
| 14:19:09 | <wyclif> dkayiwa: it is what slows it down |
| 14:19:16 | <dkayiwa> wyclif: ok thanks wyclif :) |
| 14:19:33 | <cpower> ok wyclif |
| 14:19:36 | <cpower> go |
| 14:19:41 | <wyclif> Thursday: |
| 14:19:42 | <wyclif> -dev call |
| 14:19:43 | <wyclif> -review and apply pull requests for TRUNK-2436, TRUNK-2651, TRUNK-2768 |
| 14:19:45 | <wyclif> -Went through relatively old pull request to ping devs assigned to them |
| 14:19:46 | <wyclif> Friday: |
| 14:19:48 | <wyclif> -Had no internet connection in the morning-mid morning, had to go IU to be able to reset passphrase to be able to use UI secure |
| 14:19:49 | <wyclif> -Reviewed TRUNK-3979, Trunk 2873 |
| 14:19:51 | <wyclif> -Reviewed and applied TRUNK-3567 |
| 14:19:52 | <wyclif> Monday: |
| 14:19:54 | <wyclif> -More reviews |
| 14:19:55 | <wyclif> -Pick up a ticket |
| 14:19:56 | <wyclif> |
| 14:19:57 | <wyclif> Blockers: None |
| 14:22:01 | <dkayiwa> wyclif: and how do we change this language to English? :) |
| 14:22:15 | *** rowanseymour has joined #openmrs |
| 14:23:07 | <wyclif> dkayiwa: choose the legacy OpenMRS app and choose it from the footer |
| 14:23:29 | <wyclif> dkayiwa: there might be a GP too |
| 14:24:20 | <dkayiwa> wyclif: ok thanks |
| 14:28:18 | *** harshadura has joined #openmrs |
| 14:28:18 | *** ChanServ sets mode: +v harshadura |
| 14:29:33 | <cpower> !scrumoff |
| 14:29:33 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:33:07 | *** Anuruddha has joined #openmrs |
| 14:33:14 | *** rowanseymour has quit IRC |
| 14:35:35 | *** jennparise has quit IRC |
| 14:36:25 | *** rowanseymour has joined #openmrs |
| 14:45:14 | *** sashrika has joined #openmrs |
| 14:51:48 | *** jennparise has joined #openmrs |
| 15:02:03 | *** harshadura_ has joined #openmrs |
| 15:02:55 | *** k-joseph has quit IRC |
| 15:03:24 | *** k-joseph has joined #openmrs |
| 15:03:29 | *** harshadura has quit IRC |
| 15:15:55 | *** harsha89 has quit IRC |
| 15:17:07 | *** harshadura has joined #openmrs |
| 15:17:07 | *** ChanServ sets mode: +v harshadura |
| 15:22:20 | *** harshadura_ has quit IRC |
| 15:23:00 | *** harshadura has quit IRC |
| 15:35:03 | *** rafa has quit IRC |
| 15:40:45 | *** k-joseph has quit IRC |
| 15:41:03 | *** rowanseymour has quit IRC |
| 15:42:26 | *** k-joseph has joined #openmrs |
| 15:43:23 | *** ruwanego has joined #openmrs |
| 15:45:19 | *** harsha89 has joined #openmrs |
| 15:48:51 | *** harshadura has joined #openmrs |
| 16:00:37 | *** rcrichton has quit IRC |
| 16:03:28 | *** k-joseph has quit IRC |
| 16:04:14 | *** breeze has quit IRC |
| 16:04:43 | *** harshadura has quit IRC |
| 16:13:53 | *** DraggonZ has joined #openmrs |
| 16:18:12 | *** Anuruddha has quit IRC |
| 16:19:04 | *** jblaya has joined #openmrs |
| 16:21:50 | *** Hasintha_i has quit IRC |
| 16:35:02 | *** breeze has joined #openmrs |
| 16:52:06 | *** wyclif has quit IRC |
| 16:58:00 | *** k-joseph has joined #openmrs |
| 16:58:33 | *** Hasintha_i has joined #openmrs |
| 17:06:45 | *** wyclif has joined #openmrs |
| 17:22:05 | *** evmw has quit IRC |
| 17:23:56 | *** DraggonZ has quit IRC |
| 17:26:31 | *** dkayiwa has quit IRC |
| 17:30:51 | *** jblaya has quit IRC |
| 17:34:23 | <jkeiper> mseaton: have you ever had to create a column in a report that was just an incrementing value starting at 1? |
| 17:34:35 | <jkeiper> mseaton: like, the number of the row in a spreadsheet ... |
| 17:34:57 | *** dkayiwa has joined #openmrs |
| 17:35:02 | <jkeiper> mseaton: i'm not sure if that's even worth doing in the report but it's a requirement in the MOH register |
| 17:40:55 | *** GitHub153 has joined #openmrs |
| 17:40:55 | <GitHub153> [openmrs-core] wluyima pushed 1 new commit to master: http://git.io/pXPHgw |
| 17:40:55 | <GitHub153> openmrs-core/master 6c26027 Robert Day: Location hierarchy should not allow loops, description should not be required - TRUNK-2707... |
| 17:40:55 | *** GitHub153 has left #openmrs |
| 17:42:13 | *** evmw has joined #openmrs |
| 17:46:54 | *** GitHub99 has joined #openmrs |
| 17:46:54 | <GitHub99> [openmrs-core] wluyima pushed 1 new commit to 1.9.x: http://git.io/Ys6XJQ |
| 17:46:54 | <GitHub99> openmrs-core/1.9.x eb72811 Robert Day: Location hierarchy should not allow loops, description should not be required - TRUNK-2707... |
| 17:46:54 | *** GitHub99 has left #openmrs |
| 17:47:08 | *** dkayiwa has quit IRC |
| 17:52:25 | *** GitHub57 has joined #openmrs |
| 17:52:25 | <GitHub57> [openmrs-core] wluyima pushed 1 new commit to 1.8.x: http://git.io/rK-YBQ |
| 17:52:25 | <GitHub57> openmrs-core/1.8.x 2983879 Robert Day: Location hierarchy should not allow loops, description should not be required - TRUNK-2707... |
| 17:52:25 | *** GitHub57 has left #openmrs |
| 17:53:15 | *** travis-ci has joined #openmrs |
| 17:53:15 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [6c26027] [Robert Day] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/6930375 |
| 17:53:15 | *** travis-ci has left #openmrs |
| 17:53:18 | <OpenMRSBot> <http://ln-s.net/-7sP> (at travis-ci.org) |
| 17:57:05 | *** rcrichton has joined #openmrs |
| 18:15:21 | *** jblaya has joined #openmrs |
| 18:19:37 | *** jblaya has quit IRC |
| 18:22:14 | *** dkayiwa has joined #openmrs |
| 18:33:41 | *** Hasintha_i has quit IRC |
| 18:38:13 | *** jennparise has quit IRC |
| 18:41:14 | *** jblaya has joined #openmrs |
| 18:42:30 | *** rowanseymour has joined #openmrs |
| 18:46:34 | *** dkayiwa_ has joined #openmrs |
| 18:48:48 | *** dkayiwa has quit IRC |
| 18:48:49 | *** dkayiwa_ is now known as dkayiwa |
| 18:52:16 | *** Hasintha_i has joined #openmrs |
| 19:00:49 | *** jennparise has joined #openmrs |
| 19:02:05 | *** jennparise has joined #openmrs |
| 19:03:45 | *** jennparise_ has joined #openmrs |
| 19:03:45 | *** jennparise has quit IRC |
| 19:04:20 | *** h3llborn has joined #openmrs |
| 19:05:09 | *** jennparise has joined #openmrs |
| 19:05:09 | *** jennparise_ has quit IRC |
| 19:14:49 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: HTML Form Flowsheet 1.2.6 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=htmlformflowsheet&version=&1.2.6> |
| 19:15:39 | *** GitHub59 has joined #openmrs |
| 19:15:39 | <GitHub59> [openmrs-core] wluyima pushed 1 new commit to 1.7.x: http://git.io/NqCXLg |
| 19:15:39 | <GitHub59> openmrs-core/1.7.x aec1701 Robert Day: Location hierarchy should not allow loops, description should not be required - TRUNK-2707 |
| 19:15:39 | *** GitHub59 has left #openmrs |
| 19:30:15 | *** rowanseymour has quit IRC |
| 19:35:35 | *** robbyoconnor has joined #openmrs |
| 19:35:35 | *** ChanServ sets mode: +v robbyoconnor |
| 20:04:13 | *** tcalder has joined #openmrs |
| 20:06:23 | *** tcalder has quit IRC |
| 20:08:13 | *** jblaya has quit IRC |
| 20:12:28 | *** robbyoconnor has quit IRC |
| 20:12:31 | *** r0bby has joined #openmrs |
| 20:12:31 | *** ChanServ sets mode: +v r0bby |
| 20:26:44 | *** rcrichton has quit IRC |
| 20:27:52 | *** Hasintha_i has quit IRC |
| 20:37:30 | *** evmw has quit IRC |
| 20:43:55 | *** evmw has joined #openmrs |
| 20:47:19 | *** ruwanego has quit IRC |
| 20:57:50 | *** wyclif has quit IRC |
| 20:59:18 | *** k-joseph has quit IRC |
| 21:05:02 | *** jblaya has joined #openmrs |
| 21:16:30 | *** r0bby has quit IRC |
| 21:16:56 | *** r0bby has joined #openmrs |
| 21:16:56 | *** ChanServ sets mode: +v r0bby |
| 21:19:16 | *** r0bby has quit IRC |
| 21:19:51 | *** r0bby has joined #openmrs |
| 21:19:51 | *** ChanServ sets mode: +v r0bby |
| 21:28:28 | *** r0bby has quit IRC |
| 21:37:12 | *** h3llborn has quit IRC |
| 21:56:00 | *** harsha89 has quit IRC |
| 22:01:14 | *** wyclif has joined #openmrs |
| 22:12:42 | *** harsha89 has joined #openmrs |
| 22:21:03 | *** rday has joined #openmrs |
| 22:21:50 | <rday> wyclif: Hi |
| 22:28:07 | <wyclif> rday: hi |
| 22:28:40 | *** garima has joined #openmrs |
| 22:29:25 | <rday> wyclif: TRUNK-2119 is done and committed |
| 22:36:14 | *** garima has quit IRC |
| 22:36:41 | *** breeze has quit IRC |
| 22:45:18 | *** garima has joined #openmrs |
| 22:46:43 | *** harsha89 has quit IRC |
| 22:48:22 | *** sashrika has quit IRC |
| 22:53:47 | *** garima has quit IRC |
| 22:57:12 | *** dkayiwa has left #openmrs |
| 23:03:02 | *** upul has joined #openmrs |
| 23:03:02 | *** ChanServ sets mode: +v upul |
| 23:03:04 | *** NameFILIP has joined #openmrs |
| 23:14:40 | *** sashrika has joined #openmrs |
| 23:37:58 | *** jennparise has quit IRC |
| 23:51:46 | <wyclif> rday: cool, i have added a comment with a request, where are you committing the code? |
| 23:53:27 | <rday> wyclif: Pull request is here https://github.com/openmrs/openmrs-core/pull/302 |
| 23:53:28 | <OpenMRSBot> <http://ln-s.net/-6QC> (at github.com) |
| 23:54:09 | <wyclif> rday: how may pull requests did you make? |
| 23:54:20 | <rday> wyclif: just the original one |
| 23:54:42 | <wyclif> rday: i see 295, 305 and now 302 |
| 23:55:42 | <rday> wyclif: I had issues with Git including other peoples commits so that is what 295 was. It is closed, |
| 23:56:19 | <rday> wyclif: where do you see 305 from? |
| 23:56:28 | <wyclif> rday: so there was someone else who worked on it right? |
| 23:57:17 | <rday> wyclif: Yes Gurpeet Luthra did the original work I just changed all the text to include localization |