| 00:25:28 | *** dkayiwa has quit IRC |
| 00:38:28 | *** harshadura_ has joined #openmrs |
| 00:41:33 | *** harshadura has quit IRC |
| 00:53:33 | *** harshadura_ has quit IRC |
| 00:55:27 | *** davwise has joined #openmrs |
| 01:20:34 | *** r0bby_ has joined #openmrs |
| 01:20:34 | *** ChanServ sets mode: +v r0bby_ |
| 01:22:55 | *** cospih_ has quit IRC |
| 01:25:11 | *** r0bby_ is now known as robbyoconnor |
| 01:25:21 | <robbyoconnor> hi all |
| 01:30:10 | *** davidpardz has joined #openmrs |
| 01:30:21 | *** davidpardz has left #openmrs |
| 01:31:12 | *** davidpardz has joined #openmrs |
| 01:33:21 | *** davidpardz has quit IRC |
| 01:35:36 | *** davidpardz has joined #openmrs |
| 01:40:02 | *** robbyoconnor has quit IRC |
| 01:43:27 | *** NameFILIP has joined #openmrs |
| 01:46:37 | *** harshadura has joined #openmrs |
| 01:59:34 | *** Anuruddha has joined #openmrs |
| 02:12:32 | *** wyclif has joined #openmrs |
| 02:16:33 | *** harshadura has quit IRC |
| 02:17:55 | *** harshadura has joined #openmrs |
| 03:03:32 | *** annarm has left #openmrs |
| 03:11:17 | *** harsz89 has joined #openmrs |
| 03:19:47 | *** DraggonZ has joined #openmrs |
| 03:48:46 | *** robbyoconnor has joined #openmrs |
| 03:48:46 | *** ChanServ sets mode: +v robbyoconnor |
| 04:11:35 | *** Anuruddha has quit IRC |
| 04:14:07 | *** h3llborn has joined #openmrs |
| 04:32:23 | *** GitHub133 has joined #openmrs |
| 04:32:23 | <GitHub133> [openmrs-core] wluyima opened pull request #274: Concept search results sometimes link to incorrect concepts - TRUNK-3961 (master...TRUNK-3961) http://git.io/vJsNCg |
| 04:32:23 | *** GitHub133 has left #openmrs |
| 04:39:32 | *** djazayeri1 has quit IRC |
| 04:40:19 | *** h3llborn has quit IRC |
| 04:50:40 | *** kavuri has joined #openmrs |
| 05:05:56 | *** harshadura has quit IRC |
| 05:26:26 | *** davidpardz has left #openmrs |
| 05:28:05 | *** NameFILIP has quit IRC |
| 05:28:13 | *** harshadura has joined #openmrs |
| 05:50:47 | *** portablejim has joined #openmrs |
| 05:50:47 | *** portablejim has joined #openmrs |
| 06:03:42 | *** kavuri has quit IRC |
| 06:24:55 | *** harshadura_ has joined #openmrs |
| 06:27:17 | *** harshadura has quit IRC |
| 06:28:43 | *** NameFILIP has joined #openmrs |
| 06:49:06 | *** rcrichton has joined #openmrs |
| 06:50:47 | *** nimby has quit IRC |
| 07:14:35 | *** davwise has quit IRC |
| 07:24:34 | *** kavuri has joined #openmrs |
| 07:29:35 | *** nimby has joined #openmrs |
| 07:38:27 | *** harsz89 has quit IRC |
| 07:38:50 | *** harsz89 has joined #openmrs |
| 07:53:53 | *** kavuri has quit IRC |
| 07:54:31 | *** harsha89 has joined #openmrs |
| 07:55:16 | *** harsz89 has quit IRC |
| 08:02:26 | *** kavuri has joined #openmrs |
| 08:16:48 | *** davwise has joined #openmrs |
| 08:25:06 | *** k-joseph has joined #openmrs |
| 08:26:30 | *** NameFILIP has quit IRC |
| 08:33:53 | *** nimby has quit IRC |
| 08:44:19 | *** dkayiwa has joined #openmrs |
| 08:50:44 | *** joeseff has joined #openmrs |
| 08:50:58 | <joeseff> dkayiwa: Hi |
| 08:51:04 | <dkayiwa> joeseff: hi |
| 08:51:16 | <joeseff> dkayiwa: How are you today? |
| 08:51:24 | <dkayiwa> joeseff: good and u |
| 08:51:40 | *** garima_ has joined #openmrs |
| 08:51:40 | *** davwise has quit IRC |
| 08:52:02 | <joeseff> dkayiwa: not so good. I have small problem I'm hoping you could help me solve. It has to do with using an xform for patient registration |
| 08:52:16 | <dkayiwa> joeseff: i can try :) |
| 08:52:25 | <joeseff> dkayiwa: thanks |
| 08:53:10 | *** shortend has joined #openmrs |
| 08:56:40 | <joeseff> dkayiwa: I created a patient registration form and saved the xform. I then went to the patient xform design, deleted the existing schema and opened the form that I had created. The problem is the form I created initially has a form id of 28, but when I open the form in the XForm editor from the Patient xform design, it adopts a form id of 0. This brings this error when I try to submit - http://pastebin.com/hAuzg8Bt. Can you help me |
| 09:02:01 | <k-joseph> dkayiwa: hi |
| 09:02:45 | <dkayiwa> joeseff: hi |
| 09:03:10 | <joeseff> dkayiwa: Hello :) Did u get my message? |
| 09:03:28 | <dkayiwa> joeseff: yes. what value does your global property for it have right now? |
| 09:03:59 | <joeseff> dkayiwa: Bear with me for a moment. I don't know which global property that is |
| 09:05:03 | <dkayiwa> how do you enter data in the patient registration form? |
| 09:06:36 | <joeseff> dkayiwa: I go to the Find/Create patient page, fill in the required details, then I click on the Create Person button. The form appears after which I enter the details. If you are talking about this attribute: xforms.newPatientFormId - its blank |
| 09:07:07 | <dkayiwa> joeseff: do a file save as and send me a pastebin link of the form |
| 09:07:38 | <joeseff> dkayiwa: Ok |
| 09:13:21 | <joeseff> dkayiwa: Here is the link. http://pastebin.com/a8w4JdCG |
| 09:16:42 | <dkayiwa> joeseff: how did you create this form? |
| 09:18:01 | <joeseff> dkayiwa: I duplicated the basic form, edited the schema, clicked on Design Xform. I developed it there |
| 09:18:26 | <dkayiwa> joeseff: have you read this? https://wiki.openmrs.org/display/docs/XForms+Module+Patient+Registration |
| 09:18:27 | <OpenMRSBot> <http://ln-s.net/8a:K> (at wiki.openmrs.org) |
| 09:19:28 | <joeseff> dkayiwa: Yes, I found it when I was looking for a way to test the xform. Are you suggesting that I try that method instead? |
| 09:20:01 | <dkayiwa> joeseff: what alternative method do you have apart from that which is documented? :) |
| 09:20:54 | <joeseff> dkayiwa: I was hoping there was a loophole somewhere. Alas! Thanks, at least I explored my options :) |
| 09:21:06 | <dkayiwa> joeseff: :) |
| 09:21:20 | <dkayiwa> joeseff: you always start with the official way before hacking :) |
| 09:22:01 | <dkayiwa> joeseff: though if you have plenty of time to play, then hacking is cool :) |
| 09:22:28 | <joeseff> dkayiwa: Right, I'll keep that in mind. thanks again! |
| 09:24:50 | <joeseff> dkayiwa: being new in openmrs, I didn't know that the patient registration form is designed differently from the rest. But I'm sure I'll get better at finding out things before jumping in head first, as time goes by. With a friend like you, I know that won't be too long |
| 09:25:34 | *** dkayiwa has quit IRC |
| 09:26:16 | *** kavuri has quit IRC |
| 09:26:40 | *** kavuri has joined #openmrs |
| 09:26:54 | *** dkayiwa has joined #openmrs |
| 09:27:13 | <k-joseph> dkayiwa: hi |
| 09:27:21 | <dkayiwa> k-joseph: hi |
| 09:29:10 | <k-joseph> dkayiwa: i have created one already before, with Note note = new Note(); yet didn't help clear up |
| 09:29:29 | <dkayiwa> k-joseph: do you get the same error? |
| 09:29:49 | <k-joseph> dkayiwa: yes |
| 09:30:07 | <dkayiwa> k-joseph: are you sure? |
| 09:30:55 | <k-joseph> dkayiwa, yes am sure also added a constuctor that takes in an integer as a parameter and tried Note note = new Note(1); |
| 09:31:12 | <k-joseph> and still didnt help |
| 09:31:14 | <dkayiwa> k-joseph: can you pastebin the two errors? |
| 09:31:17 | *** joeseff has quit IRC |
| 09:31:36 | <dkayiwa> k-joseph: the one you had before and that after instantiating a note object |
| 09:31:56 | <dkayiwa> k-joseph: i want to confirm if what you are telling me (that you get the same error) is correct |
| 09:32:41 | <k-joseph> getting the two error logs |
| 09:41:19 | <k-joseph> dkayiwa before instantiation it is http://pastebin.com/eU91ezEd and after http://pastebin.com/Bh4zyZdq |
| 09:42:11 | <dkayiwa> k-joseph: on which line and in which class is the null pointer exception? |
| 09:42:57 | <k-joseph> dkayiwa: in the test class |
| 09:43:09 | <dkayiwa> dkayiwa: k-joseph: on which line and in which class is the null pointer exception? |
| 09:46:03 | <k-joseph> dkayiwa: am debugging the code to check where that is |
| 09:46:32 | <dkayiwa> k-joseph: before you even debug, doesn't the error log tell it? |
| 09:50:41 | <k-joseph> dkayiwa: the the error log points lots ot at, and am not sure where now and how to fix yet |
| 09:51:55 | <dkayiwa> k-joseph: when analyzing an error log, you start by looking at any classes mentioned that your wrote |
| 09:52:16 | <dkayiwa> k-joseph: for most likely the bug is not in the other classes but the ones you write |
| 09:52:20 | <dkayiwa> k-joseph: does this make sense? |
| 09:52:40 | <k-joseph> dkayiwa: fully makes sence |
| 09:53:02 | <dkayiwa> k-joseph: so from just the long alone, at what line and in what class is the exception? |
| 09:53:18 | <dkayiwa> long = error log |
| 09:53:55 | <k-joseph> dkayiwa: at org.openmrs.api.NoteServiceTest.voidNote_shouldVoidTheNoteAndSetTheVoidReason(NoteServiceTest.java:28) |
| 09:54:20 | <dkayiwa> dkayiwa: k-joseph: so from just the long alone, at what line and in what class is the exception? |
| 09:55:27 | <k-joseph> dkayiwa in NoteServiceTest at line 28!!! |
| 09:56:48 | <dkayiwa> k-joseph: can you look there and tell what you think is null? |
| 09:57:49 | <k-joseph> dkayiwa: nothing |
| 09:58:07 | <k-joseph> dkayiwa: am checking now via the debugger |
| 09:58:10 | <dkayiwa> k-joseph: now can you debug and tell which variable is null? |
| 09:58:21 | <k-joseph> ok |
| 10:03:50 | <k-joseph> dkayiwa: confirmed that at line 28, note is null |
| 10:04:18 | <dkayiwa> k-joseph: but you told me that you instantiated it. were you telling me false information? |
| 10:09:43 | <k-joseph> dkayiwa, i think that was beecause of line 27, i have commented at it and no longer a nullpointer exception now but a classCastException |
| 10:10:05 | <dkayiwa> k-joseph: can you fix it? |
| 10:10:37 | <k-joseph> dkayiwa: still trying |
| 10:10:45 | <dkayiwa> k-joseph: ok |
| 10:30:19 | *** NameFILIP has joined #openmrs |
| 10:38:44 | *** harshadura__ has joined #openmrs |
| 10:42:12 | *** harshadura_ has quit IRC |
| 10:46:58 | *** harsha89 has quit IRC |
| 11:00:53 | *** harshadura__ has quit IRC |
| 11:04:27 | *** harshadura has joined #openmrs |
| 11:15:31 | *** k-joseph has quit IRC |
| 11:20:36 | *** Anuruddha has joined #openmrs |
| 11:23:47 | *** garima_ has quit IRC |
| 11:36:07 | *** effysam has joined #openmrs |
| 11:40:27 | *** effysam has quit IRC |
| 11:46:15 | *** k-joseph has joined #openmrs |
| 11:47:24 | *** harshadura_ has joined #openmrs |
| 11:49:36 | *** harshadura has quit IRC |
| 11:50:06 | *** garima has joined #openmrs |
| 11:50:58 | <garima> dkayiwa: hi, i got your comment, i would change the message today and get back to you |
| 11:51:10 | <dkayiwa> garima: ok thanks |
| 11:56:34 | <dkayiwa> k-joseph: can you pastebin the log |
| 11:57:32 | *** garima has quit IRC |
| 12:02:51 | <k-joseph> dkayiwa: http://pastebin.com/2EFEfGiw |
| 12:04:06 | <k-joseph> dkayiwa: http://pastebin.com/2EFEfGiw |
| 12:05:01 | <dkayiwa> k-joseph: do you know the line and class where it happens? |
| 12:05:21 | <k-joseph> dkayiwa: yes i do |
| 12:05:34 | <dkayiwa> k-joseph: have you looked at it? |
| 12:05:49 | <k-joseph> dkayiwa: yes i have |
| 12:06:21 | <dkayiwa> k-joseph: paste that one line here |
| 12:07:24 | <k-joseph> return dao.voidNote(note, reason); |
| 12:07:48 | <k-joseph> dkayiwa: that is the one in at org.openmrs.notification.impl.NoteServiceImpl.voidNote(NoteServiceImpl.java:119 |
| 12:08:11 | <dkayiwa> k-joseph: you have now confused me |
| 12:08:16 | <dkayiwa> dkayiwa: k-joseph: do you know the line and class where it happens? |
| 12:08:24 | <dkayiwa> am asking again as above |
| 12:09:02 | <k-joseph> yes, i do, there are two classes where it happens |
| 12:09:34 | <k-joseph> dkayiwa: according to the failure trace |
| 12:09:34 | <dkayiwa> k-joseph: you always start investigation using the closest class in the stack trace |
| 12:09:56 | <k-joseph> dkayiwa: ok, that is return (Note) sessionFactory.getCurrentSession().save(note); |
| 12:09:59 | <dkayiwa> k-joseph: for instance if A call B and calls C and calls D, then you start with the innermost |
| 12:10:29 | <dkayiwa> k-joseph: what is the return type for getCurrentSession().save() |
| 12:11:24 | <k-joseph> dkayiwa: SessionFactory |
| 12:11:59 | <dkayiwa> k-joseph: is that the return type for? getCurrentSession().save() |
| 12:13:27 | <k-joseph> dkayiwa: am confused what the return type of getCurrentSession() is, |
| 12:13:54 | <dkayiwa> k-joseph: do you read what is type? |
| 12:14:32 | *** rcrichton_ has joined #openmrs |
| 12:14:39 | <k-joseph> dkayiwa: yes i do am replying what is the return type for getCurrentSession().save( |
| 12:14:53 | <dkayiwa> k-joseph: is it the same as this? |
| 12:14:54 | <dkayiwa> k-joseph: dkayiwa: am confused what the return type of getCurrentSession() is, |
| 12:15:32 | *** rcrichton has quit IRC |
| 12:15:53 | <k-joseph> dkayiwa: i thought to answer that it requires me to know the return type for what is the return type for getCurrentSession() |
| 12:16:30 | <dkayiwa> k-joseph: there is a difference between return type for getCurrentSession() and getCurrentSession().save() |
| 12:16:48 | <k-joseph> dkayiwa |
| 12:16:56 | <k-joseph> dkayiwa: you are right |
| 12:17:09 | <dkayiwa> k-joseph: so what is the return type for getCurrentSession().save() |
| 12:19:27 | <k-joseph> dkayiwa: am i right to say that it returns the object passed into save |
| 12:19:40 | <k-joseph> ? |
| 12:19:58 | <dkayiwa> k-joseph: don't you know how to check for a return type of a method? |
| 12:20:09 | <dkayiwa> k-joseph: are you just guessing? |
| 12:21:41 | <k-joseph> dkayiwa: the return type of a method is the type defined for that method in the method header |
| 12:21:58 | <dkayiwa> k-joseph: so what is it? |
| 12:23:13 | <k-joseph> dkayiwa: that is the type of save() |
| 12:23:21 | <dkayiwa> k-joseph: yes |
| 12:23:38 | <dkayiwa> k-joseph: not type, it is return type |
| 12:36:53 | *** cospih has joined #openmrs |
| 12:37:45 | *** moin92 has joined #openmrs |
| 12:38:45 | <k-joseph> dkayiwa: i have ressolved that statement into two and that has solved that error |
| 12:39:17 | <dkayiwa> k-joseph: what change did you do? |
| 12:40:01 | <k-joseph> dkayiwa: sessionFactory.getCurrentSession().save(note); |
| 12:40:01 | <k-joseph> return note; |
| 12:40:24 | <dkayiwa> k-joseph: ok |
| 12:40:35 | <k-joseph> dkayiwa: i changed return (Note) sessionFactory.getCurrentSession().save(note); to that above |
| 12:40:59 | <dkayiwa> k-joseph: but you have not yet answered my question |
| 12:41:34 | <dkayiwa> k-joseph: am not simply interested in your making it work, but also understanding things. so can you answer my pending question? |
| 12:42:45 | <k-joseph> dkayiwa: can you please pardon for me which quesstion among all others |
| 12:43:36 | <dkayiwa> dkayiwa: k-joseph: what is the return type for getCurrentSession().save() |
| 12:44:06 | *** evmw has joined #openmrs |
| 12:44:39 | <k-joseph> dkayiwa: the return type for that is the return type for the last method invoked, in this case it is the return type of save() |
| 12:44:59 | <dkayiwa> k-joseph: so what is it? |
| 12:50:45 | <k-joseph> dkayiwa: dkayiwa: that took me some quick googling, the return type for that is nothing, it is void |
| 12:51:39 | <dkayiwa> k-joseph: can you show me where you have seen that? |
| 12:52:15 | <k-joseph> dkayiwa: http://www.dil.univ-mrs.fr/~massat/docs/hibernate-3.1/api/org/hibernate/classic/Session.html#save%28java.lang.Object,%20java.io.Serializable%29 |
| 12:52:19 | <OpenMRSBot> <http://ln-s.net/-1:U> (at www.dil.univ-mrs.fr) |
| 12:52:32 | *** moin92 has quit IRC |
| 12:52:43 | *** nyoman has joined #openmrs |
| 12:53:04 | <dkayiwa> k-joseph: ok good |
| 12:53:12 | <dkayiwa> k-joseph: so can you now proceed? |
| 13:03:15 | <k-joseph> dkayiwa: actually assertTrue(note.isVoided()); is failing with the trace http://pastebin.com/T5SKeFeN ignoring it passes the test |
| 13:04:15 | <dkayiwa> k-joseph: can you also pastebin the test |
| 13:13:29 | <k-joseph> dkayiwa: the test case is here http://pastebin.com/iuqFBXEb |
| 13:18:49 | <dkayiwa> k-joseph: which of these lines fails? |
| 13:19:35 | <k-joseph> dkayiwa: line 34, when i commented it out, it was successful |
| 13:19:53 | <dkayiwa> k-joseph: what is your base class for Note? |
| 13:20:24 | <k-joseph> dkayiwa: BaseOpenmrsData |
| 13:20:37 | <k-joseph> dkayiwa: then also implements Serializable |
| 13:20:58 | <dkayiwa> k-joseph: can you pastebin the Note class? |
| 13:21:09 | <dkayiwa> k-joseph: oh sorry i have it here |
| 13:21:20 | *** kavuri has quit IRC |
| 13:21:36 | *** NameFILIP has quit IRC |
| 13:22:03 | <dkayiwa> k-joseph: do a commit and i have a review of all that you have |
| 13:22:06 | *** DraggonZ has quit IRC |
| 13:22:38 | <k-joseph> dkayiwa: ok, so i should remove the assert i had commented? |
| 13:22:59 | <dkayiwa> k-joseph: why do you want to remove it? |
| 13:23:28 | <k-joseph> dkayiwa: since it is testing nothing when commented out |
| 13:23:32 | <dkayiwa> k-joseph: i just want to review such that i tell you where the problem is |
| 13:23:46 | <k-joseph> dkayiwa: ok |
| 13:23:48 | <dkayiwa> k-joseph: why do you comment it out |
| 13:24:30 | <dkayiwa> k-joseph: it is like throwing away your car because you do not have fuel :) |
| 13:24:43 | *** ankujarora has joined #openmrs |
| 13:24:47 | <k-joseph> dkayiwa: it fails the testcase when un commented out, i think i should not comment it out but seek to make it pass instead, |
| 13:25:00 | <dkayiwa> k-joseph: exactly |
| 13:29:08 | *** evmw has quit IRC |
| 13:30:26 | *** evmw has joined #openmrs |
| 13:36:17 | *** evmw has quit IRC |
| 13:38:20 | *** DraggonZ has joined #openmrs |
| 13:52:50 | *** wyclif has quit IRC |
| 13:55:20 | <jkeiper> dkayiwa: nice analogy ;-) |
| 13:55:41 | <dkayiwa> jkeiper: lollllllll. Did not know you are awake :D |
| 13:55:59 | <jkeiper> dkayiwa: haha, it is nearly 10:00am here |
| 13:56:18 | <dkayiwa> jkeiper: ah i see!!! :) |
| 13:56:34 | <dkayiwa> jkeiper: you know am not used to waking up that early :) |
| 13:56:59 | <jkeiper> dkayiwa: remember, I have little girls ... 7:30am is the latest they will wake me, and I usually have to be up by 6:45am to get to work by 8:00 |
| 13:57:17 | <dkayiwa> jkeiper: oh now i remember!!! :) |
| 13:57:24 | <jkeiper> dkayiwa: so 7:30am is sleeping in hahaha |
| 13:57:40 | <dkayiwa> jkeiper: hahahah. sleeping as early as birds :) |
| 13:58:02 | <jkeiper> dkayiwa: my wife, on the other hand ... she can sleep for an entire day if given the time |
| 13:58:17 | *** isharapremadasa has joined #openmrs |
| 13:58:24 | <dkayiwa> jkeiper: OOOOOOOOOOHHHHHHHHHHH :D |
| 13:58:44 | *** isharapremadasa is now known as isha |
| 13:59:00 | *** wyclif has joined #openmrs |
| 13:59:02 | <jkeiper> ahahha |
| 13:59:13 | *** isha is now known as ishara-p |
| 13:59:28 | *** wyclif has joined #openmrs |
| 14:02:33 | <cpower> Good morning! |
| 14:02:48 | <cpower> We ready to scrum? |
| 14:03:11 | <cpower> silence is golden |
| 14:03:16 | <cpower> !scrumon cpower |
| 14:03:16 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:05:13 | <cpower> Order: mseaton , djazayeri_may_be , dkayiwa , wyclif , Andrea (maybe), |
| 14:05:42 | *** k-joseph has quit IRC |
| 14:06:46 | <cpower> djazayeri_may_be: are you there? |
| 14:07:03 | <cpower> okay, dkayiwa you are up |
| 14:07:46 | <dkayiwa> Working on: Investigate possible memory leak in 1.9.0 or one of its bundled modules. - TRUNK-3440 |
| 14:07:46 | <dkayiwa> Installed and setup Yourkit. |
| 14:07:46 | <dkayiwa> Installed and setup tomcat 7 which has a memory leak detector. |
| 14:07:47 | <dkayiwa> Started by removing the logic module to see that i have no module at all and see if i can get memory leaks after the application is stopped |
| 14:07:47 | <dkayiwa> Now testing to see if |
| 14:08:03 | <dkayiwa> i get any memory leak on stopping openmrs |
| 14:08:03 | <dkayiwa> No Blockers |
| 14:08:52 | *** k-joseph has joined #openmrs |
| 14:09:04 | <cpower> wyclif: |
| 14:09:17 | <wyclif> Monday: |
| 14:09:17 | <wyclif> -Emails |
| 14:09:17 | <wyclif> -Created and curated TRUNK-3965, TRUNK-3964 |
| 14:09:17 | <wyclif> -TRUNK-3961 - Concept search results sometimes link to incorrect concepts |
| 14:09:17 | <wyclif> Tuesday: |
| 14:09:18 | <wyclif> -Review pull requests |
| 14:09:20 | <wyclif> -Pick a ticket in core or bundled module |
| 14:09:22 | <wyclif> |
| 14:09:24 | <wyclif> Blockers: None |
| 14:11:30 | <cpower> Okay anyone else have an update to give? |
| 14:12:22 | <cpower> Ok thank you everyone |
| 14:12:26 | <cpower> !scrumoff |
| 14:12:26 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:13:24 | *** k-joseph has quit IRC |
| 14:16:44 | <wyclif> dkayiwa, are you in the community dev swimlane this week? |
| 14:17:30 | *** bhashitha has joined #openmrs |
| 14:17:36 | <wyclif> dkayiwa, ? |
| 14:18:46 | <dkayiwa> wyclif: yes |
| 14:19:08 | *** k-joseph has joined #openmrs |
| 14:19:21 | <wyclif> dkayiwa, i see alot of un reviewed pull requests especially mine, do you mind reviewing them |
| 14:19:44 | <dkayiwa> wyclif: sure |
| 14:19:56 | <wyclif> dkayiwa, i personally have a bunch of them and it will get harder to merge them if they stay for long unreviewed |
| 14:20:00 | <wyclif> dkayiwa, thanks |
| 14:20:26 | <dkayiwa> wyclif: rafal recommends that you merge immediately. Unless you are very very unsure of it :) |
| 14:21:21 | *** garima has joined #openmrs |
| 14:21:30 | <wyclif> dkayiwa, ok |
| 14:21:35 | <dkayiwa> wyclif: am now also getting into the habit of merging immediately because am tire of conflicts which keep wasting my time :) |
| 14:21:49 | <dkayiwa> wyclif: after all we can always fix it later even if you merged it :) |
| 14:21:50 | *** breeze has joined #openmrs |
| 14:22:07 | <wyclif> dkayiwa, then i guess i will pushing direct to the master repo |
| 14:22:19 | <dkayiwa> wyclif: yes thats even better |
| 14:22:47 | <wyclif> dkayiwa, merging is a pain to backport |
| 14:22:55 | <dkayiwa> wyclif: the process should make our lives easier instead of giving us more unnecessary work :) |
| 14:23:11 | <dkayiwa> wyclif: oh yes |
| 14:23:21 | <wyclif> dkayiwa, i.e if you use the github merge button, it becomes hard to cherry-pick the merge commit |
| 14:23:34 | <dkayiwa> wyclif: oh i see!!! |
| 14:24:06 | <dkayiwa> wyclif: i cherry pick the original (non merged) commit in such cases :) |
| 14:24:19 | <wyclif> dkayiwa, hmm.. |
| 14:25:01 | <wyclif> dkayiwa, the only issue with pushing to master is that tracking code to review becomes tricky |
| 14:25:24 | <dkayiwa> wyclif: even when you include the commit url on the ticket? |
| 14:25:31 | <wyclif> dkayiwa, because currently i depend on pull requests to find what needs to be reviewed |
| 14:25:55 | <dkayiwa> wyclif: me i use this: https://tickets.openmrs.org/secure/Dashboard.jspa?selectPageId=11753 |
| 14:26:04 | <dkayiwa> wyclif: and look for the Needs review tickets |
| 14:26:30 | <dkayiwa> wyclif: so i get the to review urls from the tickets themselves |
| 14:27:32 | *** ishara-p has quit IRC |
| 14:27:57 | *** bhashitha has quit IRC |
| 14:28:12 | <wyclif> dkayiwa, ok |
| 14:29:40 | *** bhashitha has joined #openmrs |
| 14:31:17 | *** lh has joined #openmrs |
| 14:31:17 | *** lh has joined #openmrs |
| 14:33:47 | *** garima has quit IRC |
| 14:37:06 | *** breeze has quit IRC |
| 14:37:57 | *** ankujarora has quit IRC |
| 14:45:17 | <k-joseph> dkayiwa: hi |
| 14:45:52 | <dkayiwa> k-joseph: hi |
| 14:46:19 | <k-joseph> dkayiwa: hi |
| 14:46:46 | <k-joseph> dkayiwa: here is the commit https://github.com/k-joseph/openmrs-core/commit/TRUNK-3258 |
| 14:46:47 | <OpenMRSBot> <http://ln-s.net/+t57> (at github.com) |
| 14:47:12 | <dkayiwa> k-joseph: ok will review it today and give you the response on github comments |
| 14:47:14 | <dkayiwa> k-joseph: thanks |
| 14:49:56 | <k-joseph> dkayiwa: ok |
| 14:49:57 | *** DraggonZ has quit IRC |
| 14:51:18 | *** bhashitha has quit IRC |
| 14:52:56 | <k-joseph> dkayiwa: now about what i previously mailed you about, |
| 14:52:59 | *** breeze has joined #openmrs |
| 14:53:11 | <k-joseph> what iss the cause of having openmrs failing to run successsfully via eclipse to the browser, even when mvn clean install succeeds running at command line? |
| 14:53:17 | <dkayiwa> k-joseph: will respond by tonight |
| 14:53:42 | *** kishoreyekkanti has joined #openmrs |
| 14:53:49 | <k-joseph> dkayiwa: ok please, thanks a lot too |
| 14:54:50 | *** dkayiwa has quit IRC |
| 15:00:58 | *** k-joseph has quit IRC |
| 15:04:54 | *** ishara-p has joined #openmrs |
| 15:09:29 | *** portablejim has quit IRC |
| 15:16:44 | *** harshadura_ has quit IRC |
| 15:16:57 | *** harshadura has joined #openmrs |
| 15:18:03 | *** harshadura has quit IRC |
| 15:19:31 | *** rcrichton_ has quit IRC |
| 15:25:48 | *** shortend has quit IRC |
| 15:27:10 | *** Anuruddha_ has joined #openmrs |
| 15:27:24 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Kenya EMR UI Library 1.3.2 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=kenyaui&version=&1.3.2> |
| 15:28:47 | *** Anuruddha has quit IRC |
| 15:35:09 | *** djazayeri has joined #openmrs |
| 15:35:09 | *** ChanServ sets mode: +o djazayeri |
| 15:35:40 | *** Anuruddha_ is now known as Anuruddha |
| 15:38:29 | *** mogoodrich has joined #openmrs |
| 15:38:41 | <mogoodrich> hey wyclif, are you there? |
| 15:40:26 | <djazayeri> hi breeze |
| 15:47:15 | <mogoodrich> anybody know how we configure Hibernate Interceptors in modules? I'm looking at the Sync and Event modules and don't see any specific configuration besides creating the bean... I feel like I've seen this before, but don't remember where... |
| 15:50:21 | *** bhashitha has joined #openmrs |
| 15:51:37 | *** NameFILIP has joined #openmrs |
| 15:52:07 | <mogoodrich> ah... looks like they are autowired to HibernateSessionFactoryBean... |
| 15:53:22 | *** evmw has joined #openmrs |
| 15:57:52 | <ishara-p> Hi i am getting this weird error when trying to do some module operations in openmrs 1.10, when i try to use html form entry module, it shows that, |
| 15:58:05 | <ishara-p> The page "/openmrs/admin/module/htmlformentry/htmlForms.list" cannot be found. Check the link and try again. |
| 15:58:32 | <ishara-p> this just happend one day back and i have used the module without any trouble before that |
| 15:58:50 | <ishara-p> can someone help me pls> |
| 15:59:32 | <ishara-p> tested with few more modules and all are same |
| 15:59:32 | <breeze> djazayeri: hi |
| 15:59:57 | <djazayeri> breeze: hope all went well yesterday |
| 16:00:30 | <breeze> djazayeri: ok...I have to wait for the insurance companies to fight it out |
| 16:00:52 | <djazayeri> breeze: meh, well, hope that isn't too painful |
| 16:01:32 | <breeze> djazayeri: nah, my car is still driveable just needs some body work |
| 16:01:46 | <djazayeri> breeze: I was looking at https://ci-stg.openmrs.org/allPlans.action and noticing that now we have two builds failing due to the maven 2 / maven 3 issue (about not being able to run that ruby gem) |
| 16:02:14 | <breeze> djazayeri: I'll take a look |
| 16:02:23 | <djazayeri> breeze: are you working on something now, or can you google around and see if there are any comments about us being able to run that under maven 2? |
| 16:02:34 | <breeze> djazayeri: can you give me a link to a log with the specific error? |
| 16:02:38 | <djazayeri> breeze: and if not, work with downey to upgrade the maven version on the bamboo server to 3 |
| 16:02:56 | <djazayeri> breeze: https://ci-stg.openmrs.org/browse/UICM-UICOMMONS/latest |
| 16:03:27 | <breeze> djazayeri: thanks. I think the maven version on there was installed with jpackage...so if needs be we can do a manual install |
| 16:03:52 | <djazayeri> breeze: meaning that won't be too hard, since it's not the ubuntu-provided one? |
| 16:04:49 | <breeze> djazayeri: not sure I totally understand you, but regardless, it will not be too hard |
| 16:05:16 | <djazayeri> breeze: okay, in that case don't spend _too_ long exploring how to make it work in maven 2. :-) |
| 16:05:40 | <breeze> djazayeri: ok |
| 16:05:52 | *** ishara-p has quit IRC |
| 16:06:13 | <breeze> djazayeri: is there any news on stuff you brought up last week on combining refapp and PIH work? |
| 16:07:03 | <breeze> djazayeri: the reason I ask is there are at least 2 other TWers who'd like to help out part time |
| 16:07:30 | <djazayeri> breeze: working on details—I'll send an email later today. |
| 16:07:37 | <breeze> djazayeri: ok |
| 16:07:37 | <djazayeri> breeze: these are DevOps / CD types? |
| 16:08:25 | <breeze> djazayeri: devs who want to get some devops experience as well |
| 16:08:44 | <breeze> djazayeri: and one BA/QA if needed as well |
| 16:09:25 | <djazayeri> breeze: okay, so I'd say that for the immediate future can you manage the two devops-interested ones yourself, i.e. you can point them to tickets, but make them transparent to the broader group until things have gotten more stable? |
| 16:09:46 | <breeze> djazayeri: np |
| 16:12:32 | *** kishoreyekkanti has quit IRC |
| 16:15:45 | <mogoodrich> djazayeri: don't suppose you have any idea how in OpenMRS we'd go about wiring a hibernate inteceptor to the HibernateTransactionManager instead of the HibernateSessionFactory? |
| 16:20:07 | *** harsha89 has joined #openmrs |
| 16:23:43 | *** NameFILIP has quit IRC |
| 16:29:33 | *** nimby has joined #openmrs |
| 16:35:51 | *** annarm has joined #openmrs |
| 16:41:55 | <annarm> Hi. I got here via the Outreach Program for Women internship listings. Would be interested in learning more about documentation opportunities, particulary the implementation profiles project you mention on the wiki. |
| 16:47:46 | *** DraggonZ has joined #openmrs |
| 16:49:41 | *** lh has quit IRC |
| 17:09:28 | *** bhashitha_ has joined #openmrs |
| 17:09:37 | *** bhashitha has quit IRC |
| 17:09:40 | <downey> annarm: Hi! Would be happy to talk with you more about it. Could you drop me a line at michael at OpenMRS dot org? I'm away from the computer today though so may take a bit of time to respond. |
| 17:10:43 | *** Mr_Alpha has joined #openmrs |
| 17:11:59 | *** Anuruddha has quit IRC |
| 17:12:48 | <Mr_Alpha> Hey all,I was trying to build my first module in openmrs.I was trying to create a module using https://wiki.openmrs.org/display/docs/Using+the+Module+Maven+Archetype link and got the following error while building module |
| 17:12:49 | <OpenMRSBot> <http://ln-s.net/9$wo> (at wiki.openmrs.org) |
| 17:12:49 | <Mr_Alpha> https://wiki.openmrs.org/display/docs/Using+the+Module+Maven+Archetype |
| 17:13:04 | <Mr_Alpha> [ERROR] Failed to execute goal org.openmrs.maven.plugins:module-wizard-plugin:1. 1.1:generate (default-cli) on project standalone-pom: null: MojoFailureException : NullPointerException -> [Help 1] |
| 17:13:10 | <Mr_Alpha> please help |
| 17:13:18 | <Mr_Alpha> I am using a stanalone openmrs |
| 17:13:24 | <annarm> downey: thanks, will do! |
| 17:13:54 | *** nyoman has quit IRC |
| 17:14:08 | <djazayeri> Mr_Alpha: please use pastebin or gist to show the complete error message, and to show what values you had put into the wizard |
| 17:15:02 | <Mr_Alpha> ok.Thanks. |
| 17:18:12 | <Mr_Alpha> http://pastebin.com/sasAKqG5 |
| 17:18:22 | <Mr_Alpha> This is the error I am getting |
| 17:19:50 | <djazayeri> Mr_Alpha: can you try going through again from scratch? |
| 17:20:11 | <djazayeri> Mr_Alpha: I ran into a problem in the past where if you say No to are the above values correct, then things don't work right |
| 17:20:22 | <Mr_Alpha> as in installing maven agai? |
| 17:20:46 | <Mr_Alpha> *again |
| 17:20:58 | <djazayeri> Mr_Alpha: no, just the command like "mvn module-wizard:generate" (or whatever that is) |
| 17:21:14 | <Mr_Alpha> ok..will try and get back to tou |
| 17:21:15 | <Mr_Alpha> thanks |
| 17:21:35 | <Mr_Alpha> should I say yes to everything? |
| 17:21:58 | *** djazayeri has left #openmrs |
| 17:22:20 | *** k-joseph has joined #openmrs |
| 17:23:36 | *** djazayeri has joined #openmrs |
| 17:23:36 | *** ChanServ sets mode: +o djazayeri |
| 17:23:55 | <djazayeri> Mr_Alpha: it depends what you're trying to do... |
| 17:24:10 | <djazayeri> Mr_Alpha: the questions are meaningful... |
| 17:24:15 | <djazayeri> brb |
| 17:26:00 | <Mr_Alpha> its ot working.Yeah I know the qustion are meaningful. |
| 17:26:02 | <Mr_Alpha> http://pastebin.com/fGvh9CSR |
| 17:26:10 | <Mr_Alpha> its not working. |
| 17:27:58 | <Mr_Alpha> From where I can find a basic mvn project so that I can start working.Maven not working in my pc |
| 17:28:12 | <Mr_Alpha> *maven |
| 17:28:43 | *** bhashitha_ has quit IRC |
| 17:30:05 | <harsha89> hi Mr_Alpha |
| 17:30:29 | *** harsha89 has quit IRC |
| 17:30:44 | *** harsha89 has joined #openmrs |
| 17:31:13 | *** harsz89 has joined #openmrs |
| 17:31:22 | <harsz89> hi Mr_Alpha |
| 17:31:43 | <harsz89> harsz89, there is basic module structure available in https://github.com/openmrs/openmrs-module-basicmodule |
| 17:31:47 | <OpenMRSBot> <http://ln-s.net/-1FC> (at github.com) |
| 17:31:55 | <harsz89> harsz89, you may try that |
| 17:31:58 | <harsz89> harsz89, :) |
| 17:32:05 | <Mr_Alpha> thanks man |
| 17:32:17 | <harsz89> harsz89, :) |
| 17:33:58 | *** mogoodrich has quit IRC |
| 17:34:34 | <Mr_Alpha> harsz89:http://pastebin.com/fGvh9CSR Do you know what th prolem may be? I guess something with the plugin |
| 17:36:42 | <harsz89> Mr_Alpha, wait i'll have a look |
| 17:38:41 | <harsz89> Mr_Alpha, this is relates to create module from maven architype right? |
| 17:39:26 | <harsz89> Mr_Alpha, you can simple use basic module structure to create your module |
| 17:40:10 | <harsz89> Mr_Alpha, i'll have a look at building module from maven architype since I not tried it recently :) |
| 17:41:51 | *** mogoodrich has joined #openmrs |
| 17:42:03 | *** annarm has quit IRC |
| 17:42:50 | <DraggonZ> hi, Mr_Alpha! Is there is no pom files in your workspace directory? |
| 17:45:52 | *** Mr_Alpha has quit IRC |
| 17:47:07 | <sunbiz> Mr_Alpha: look here https://github.com/openmrs/openmrs-contrib-maven-archetype-basicmodule-creation/blob/master/pom.xml |
| 17:47:12 | <OpenMRSBot> <http://ln-s.net/-1FW> (at github.com) |
| 17:47:14 | <sunbiz> you seem to be using an old version |
| 17:47:24 | <sunbiz> oops... he's gone :P |
| 17:47:50 | *** lh has joined #openmrs |
| 17:47:50 | *** lh has joined #openmrs |
| 17:48:33 | <DraggonZ> but old version still should work, i guess :) |
| 17:50:26 | <breeze> djazayeri: installing maven3 on the bamboo box fixed the build problem for uicommons, but introduced a deploy problem for all plans, even if they're still set to use maven 2. looking into it, but might need downey's help |
| 17:50:48 | <djazayeri> breeze: hmm, okay |
| 17:51:03 | <djazayeri> breeze: I don't know anything about this topic, but I can look at the error message if you think it's helpful |
| 17:51:14 | <djazayeri> breeze: could it be that we created all the other build plans as maven2 ? |
| 17:52:37 | <breeze> djazayeri: we probably did, but not sure why that is effecting deploy...to nexus I mean, not tomcat |
| 17:52:44 | <breeze> https://ci-stg.openmrs.org/browse/UICM-UICOMMONS-28/log |
| 17:52:49 | <breeze> as an example |
| 17:53:25 | <djazayeri> breeze: is it looking in a different place for its config/settings? |
| 17:53:35 | <breeze> djazayeri: unautorized seems simple enough of a cause, but not sure why maven3 intrdocued this prob |
| 17:53:36 | <djazayeri> breeze: e.g. not ~/.m2/settings.xml |
| 17:53:46 | <djazayeri> breeze: maybe being run by a different user? |
| 17:54:18 | <breeze> djazayeri: let me check bamboo's settings |
| 18:00:04 | *** kishoreyekkanti has joined #openmrs |
| 18:02:14 | <breeze> djazayeri: looks like that did it. thanks for the extra set of eyes |
| 18:02:31 | <breeze> djazayeri: the settings.xml that is |
| 18:04:19 | <DraggonZ> is hithub working now? |
| 18:04:26 | <DraggonZ> github, sorry |
| 18:04:36 | <breeze> djazayeri: maven3 installed it's global settings.xml in a different location than maven2 |
| 18:04:39 | *** kishoreyekkanti has left #openmrs |
| 18:08:32 | *** djazayeri1 has joined #openmrs |
| 18:10:53 | *** djazayeri has quit IRC |
| 18:29:33 | *** lh has quit IRC |
| 18:33:57 | *** evmw has quit IRC |
| 18:34:34 | *** evmw has joined #openmrs |
| 18:43:37 | *** jb360 has joined #openmrs |
| 18:55:09 | *** djazayeri1 is now known as djazayeri |
| 18:55:09 | *** ChanServ sets mode: +o djazayeri |
| 19:03:46 | *** k-joseph has quit IRC |
| 19:05:22 | <djazayeri> breeze: regarding https://tickets.openmrs.org/browse/RA-28, we're no longer doing what it says in the title right? (build WAR with all relevant modules in the bundledModules folger)? |
| 19:14:33 | *** prabhat has joined #openmrs |
| 19:15:47 | *** cospih_ has joined #openmrs |
| 19:16:41 | *** cospih has quit IRC |
| 19:17:23 | *** k-joseph has joined #openmrs |
| 19:36:42 | *** DraggonZ has quit IRC |
| 19:36:56 | *** DraggonZ has joined #openmrs |
| 19:43:51 | <wyclif> mogoodrich, djazayeri mseaton am sorry for my cross postings |
| 19:45:16 | <mogoodrich> wyclif: sure, no worries.. |
| 19:45:19 | <wyclif> mogoodrich, djazayeri mseaton first i hadnt really looked at the code closely, secondly i kept on commeting on ticket/commit and replyin to emails back and forth, but i think its is clear to me with just one issue which Mark is going to fix |
| 19:47:05 | <wyclif> mogoodrich, solution looks elegant otherwise, i will test the scenario was bringing up and create a new ticket for it in case am able to reproduce it after applying yoru commit |
| 19:52:03 | <mogoodrich> wyclif: sure, thanks... i will add the lines to clear out the thread local (probably not to tomorrow) |
| 19:52:22 | <mogoodrich> wyclif: any problem if I do a point release tomorrow? we want to get this rolled out in mirebalais... |
| 19:53:03 | <wyclif> mogoodrich, keep in mind clearing those thread locals is what is going to cause the bug i was trying to explain |
| 19:53:37 | <wyclif> mogoodrich, does this make sense? |
| 19:54:32 | <mogoodrich> wyclif: not exactly... i have to read your response in more detail... |
| 19:54:32 | <wyclif> mogoodrich, however not clearing them will avoid the NPE but won't make event module catch those operations in case another interceptor in the chain performs any of them |
| 19:54:39 | *** monicaaa has joined #openmrs |
| 19:55:50 | <wyclif> mogoodrich, today am pretty open work on anything since we have no current sprint, i will be more than glad to try reproduce the problem, create a ticket and fix since i already have an idea of how to solve it |
| 19:56:17 | <wyclif> mogoodrich, would be nice to include it in the release |
| 19:57:01 | <wyclif> mogoodrich, i can have it fixed probably end of today |
| 19:57:14 | *** dkayiwa has joined #openmrs |
| 19:57:54 | <wyclif> mogoodrich, am going to write a test interceptor that does an insert and try to reproduce the problem in a unit test |
| 20:00:07 | *** mogoodrich has quit IRC |
| 20:01:33 | <DraggonZ> what's wrong with rest module repository? cannot open it on github, 500 internal server error |
| 20:01:48 | <DraggonZ> https://github.com/openmrs/openmrs-module-webservices.rest |
| 20:01:49 | <OpenMRSBot> <http://ln-s.net/+lGa> (at github.com) |
| 20:04:31 | <k-joseph> dkayiwa: hi |
| 20:04:36 | <dkayiwa> k-joseph: hi |
| 20:05:05 | <k-joseph> dkayiwa: is it ok for us to proceed now |
| 20:05:08 | <k-joseph> !! |
| 20:05:09 | <OpenMRSBot> k-joseph: Error: "!" is not a valid command. |
| 20:06:01 | <dkayiwa> k-joseph: i have not yet reviewed the commit. (planning to review it like 30 mins from now) but we can proceed :) |
| 20:07:21 | <k-joseph> dkayiwa: ok, now on the issue of mvn clean install succeeding and openmrs fails to run from eclipse, what is the pottential cause for that? |
| 20:07:32 | *** mogoodrich has joined #openmrs |
| 20:07:53 | <dkayiwa> k-joseph: can you pastebin the log? |
| 20:08:53 | *** garima has joined #openmrs |
| 20:09:05 | <harsz89> DraggonZ, looks like something wrong with github |
| 20:10:27 | <harsz89> it's looks like github bit going crazy :D |
| 20:10:42 | <harsz89> having 500 status |
| 20:14:00 | <dkayiwa> harsz89: i thought github was such a good boy to behave like that. :) |
| 20:15:09 | <harsz89> dkayiwa, :D :D |
| 20:15:53 | <harsz89> dkayiwa, still getting 500 status code :( can't even access to my profile |
| 20:16:04 | <harsz89> dkayiwa, did you experience it? :) |
| 20:16:15 | <DraggonZ> harsz89, first time see server errors on github ) |
| 20:16:36 | <harsz89> DraggonZ, same here |
| 20:16:37 | <DraggonZ> harsz89, some repositories works fine |
| 20:16:39 | <dkayiwa> harsz89: not practically. just by hearsay :) |
| 20:17:00 | <harsz89> dkayiwa, :) |
| 20:17:06 | <harsz89> DraggonZ, yeah same here |
| 20:18:29 | <DraggonZ> wait and believe :) |
| 20:18:57 | <k-joseph> dkayiwa: here is the failure trace when i run openmrs under eclipse http://pastebin.com/h0sEahFJ |
| 20:20:03 | <dkayiwa> k-joseph: do you have any application running on port 8080? |
| 20:21:35 | <k-joseph> dkayiwa: i dont think i do have any |
| 20:22:42 | <dkayiwa> k-joseph: can you make jetty run on another port? e.g 8081? |
| 20:24:25 | <k-joseph> dkayiwa: i think i need to do a little research on doing that |
| 20:25:52 | *** monicaaa has quit IRC |
| 20:30:23 | <dkayiwa> k-joseph: hi |
| 20:30:35 | <k-joseph> dkayiwa: hi |
| 20:31:02 | <dkayiwa> k-joseph: you can use something like this: -Djetty.port=8081 in the run configurations |
| 20:31:43 | <dkayiwa> k-joseph: that is under the JRE tab in the VM arguments textaera |
| 20:31:50 | <dkayiwa> k-joseph: does that make sense? |
| 20:33:50 | *** rday has joined #openmrs |
| 20:34:02 | <k-joseph> dkayiwa: it does, still does that replace the initial statement i had there i. e -Xmx1024M -Xms1024M -XX:PermSize=256m -XX:MaxPermSize=256m -XX:NewSize=128m |
| 20:34:57 | <dkayiwa> k-joseph: no |
| 20:35:07 | <dkayiwa> k-joseph: you just add it there after space |
| 20:35:38 | <k-joseph> dkayiwa:done that and now running |
| 20:35:56 | <dkayiwa> k-joseph: are you able to login? |
| 20:36:17 | <dkayiwa> k-joseph: or atleast see the openmrs page? |
| 20:36:33 | <k-joseph> dkayiwa: still running |
| 20:39:45 | <garima> dkayiwa: hi |
| 20:39:50 | <dkayiwa> garima: hi |
| 20:40:33 | <garima> dkayiwa: i have changed the error message to clearly define the valid combinations |
| 20:40:44 | <dkayiwa> garima: ok good |
| 20:40:45 | <garima> dkayiwa: kindly review |
| 20:40:51 | <dkayiwa> garima: ok |
| 20:42:25 | <k-joseph> dkayiwa: it fails with error log http://pastebin.com/jAdwrSC7 |
| 20:47:25 | <dkayiwa> k-joseph: where did you put what i told you? |
| 20:49:55 | <k-joseph> dkayiwa: exactly where you said, may be because i first before placed the enter key between the previous statement and the one you gave me |
| 20:50:14 | <wyclif> mogoodrich, did you see my last msg to you? |
| 20:50:21 | <dkayiwa> k-joseph: what did you place there? |
| 20:51:15 | <mogoodrich> wyclif: yes... i am in a meeting now... but will follow up later... |
| 20:51:26 | <k-joseph> dkayiwa: Djetty.port=8081 |
| 20:51:32 | <wyclif> mogoodrich, basically wait to release |
| 20:52:15 | <dkayiwa> k-joseph: is that what i told you to put? |
| 20:52:17 | <mogoodrich> wyclif: okay, i will get back to you in a bit... |
| 20:52:23 | *** breeze has quit IRC |
| 20:52:55 | <k-joseph> dkayiwa: k-joseph: you can use something like this: -Djetty.port=8081 in the run configurations |
| 20:52:58 | *** annarm has joined #openmrs |
| 20:53:08 | <dkayiwa> k-joseph: is that the same as yours? |
| 20:53:11 | <k-joseph> dkayiwa: that is where i picked it from |
| 20:53:22 | <dkayiwa> k-joseph: are you sure its the same? |
| 20:53:26 | <mogoodrich> wyclif: what else do you think i need to do (besides clearing out the thread locals) before it is releasable? |
| 20:53:59 | <wyclif> mogoodrich, that is fine, am saying fixing the issue i was bringing up |
| 20:54:40 | <wyclif> mogoodrich, am writing a unit test, if it fails i will let you know so that we can included a fix for it before you release |
| 20:54:50 | <mogoodrich> wyclif: okay, great... |
| 20:54:53 | <k-joseph> dkayiwa: it is the same |
| 20:55:25 | <dkayiwa> k-joseph: can you just copy and paste it instead of typing? |
| 20:55:36 | <mogoodrich> wyclif: if it fails, can you commit it into a branch (it may help me understand the bug you are trying to explain to me... :) |
| 20:58:47 | *** DraggonZ has quit IRC |
| 21:00:56 | *** k-joseph has quit IRC |
| 21:04:10 | *** annarm has quit IRC |
| 21:04:34 | *** annarm has joined #openmrs |
| 21:08:44 | *** mogoodrich has quit IRC |
| 21:08:58 | *** mogoodrich has joined #openmrs |
| 21:17:29 | <wyclif> mogoodrich, it would be good if you had included a unit test with a nested transaction |
| 21:18:11 | <mogoodrich> wyclif: yeah, i was thinking of that... any idea of how to go about that? it seems really hard to test transactions within a unit test... |
| 21:18:24 | <mogoodrich> wyclif: (i don't think it picks up @Transactional ?) |
| 21:18:30 | <mogoodrich> wyclif: i can try tomorrow... |
| 21:19:33 | <wyclif> mogoodrich, you need to add a test service with 2 transactional methods where one has propagation required new which gets called by the other |
| 21:20:14 | <mogoodrich> wyclif: yeah, fair enough... i can work on that tomorrow... i guess it is easy enough to create a test service... |
| 21:20:21 | <wyclif> mogoodrich, you will need to add some log to see if actually transactions gets created as expected |
| 21:20:46 | <wyclif> mogoodrich, i guess :) |
| 21:24:06 | <mogoodrich> wyclif: cool, i will probably work on it tomorrow morning, so if you do anything tonight that i should look at, send me an email to keep me posted... |
| 21:24:31 | <wyclif> mogoodrich, sure i will |
| 21:25:18 | *** rday has quit IRC |
| 21:35:03 | *** k-joseph has joined #openmrs |
| 21:36:52 | <k-joseph> dkayiwa: i had actually left out (-) character, ran well and am now installing it for the first time, thanks |
| 21:41:12 | *** rday has joined #openmrs |
| 21:47:29 | <dkayiwa> k-joseph: yes thats exactly what i wanted you to see for yourelf :) |
| 21:47:33 | <dkayiwa> s |
| 21:47:53 | <k-joseph> dkayiwa :) |
| 21:48:04 | <dkayiwa> k-joseph: how did you see it? :) |
| 21:49:00 | <k-joseph> dkayiwa: that was after made some little googling on Resolving port conflicts on Jetty |
| 21:49:09 | <k-joseph> :) |
| 21:49:12 | <dkayiwa> k-joseph: ok :) |
| 21:53:15 | *** jblaya has joined #openmrs |
| 21:53:38 | <jblaya> sunbiz, hey, you around? |
| 21:55:39 | <sunbiz> jblaya: yes, Im here |
| 21:56:14 | <jblaya> sunbiz, I'm getting an error in the panel and I can't figure out why, do you mind if I ask you? |
| 21:56:19 | <sunbiz> cooking, so might be slow to respond... but please ask |
| 21:56:30 | *** rday has quit IRC |
| 21:57:24 | <jblaya> sunbiz, I've created a new server and put the panel there, and then I've placed the id of one saved patient search, however, when I go to find/create patient I get the following error |
| 21:57:29 | <jblaya> sunbiz, SEVERE: Error on page /midoctor/WEB-INF/view/module/midoctorpanel/portlets/midoctorHome.jsp |
| 21:57:29 | <jblaya> javax.servlet.jsp.JspException: java.lang.IllegalArgumentException: search must be saved, composition, or must have a class specified |
| 21:57:43 | <sunbiz> cooking and EMR go quite well I understand ;-) (that paper reference)!! |
| 21:58:01 | <sunbiz> can you pastebin the full stacktrace? |
| 21:58:02 | <jblaya> sunbiz, :-D if only hamish were here |
| 21:58:06 | <jblaya> sure |
| 21:58:47 | <jblaya> sunbiz, http://pastebin.com/SvPpUTiw |
| 21:58:48 | <sunbiz> has he ever been in the IRC |
| 21:58:54 | <jblaya> sunbiz, I don't think so |
| 21:58:54 | <sunbiz> !seen hfrazer |
| 21:58:54 | <OpenMRSBot> sunbiz: I have not seen hfrazer. |
| 21:59:01 | <sunbiz> !seen hamishf |
| 21:59:01 | <OpenMRSBot> sunbiz: I have not seen hamishf. |
| 21:59:11 | <sunbiz> nope... the bot hasnt seen him :D |
| 21:59:18 | <sunbiz> !seen bmamline |
| 21:59:18 | <OpenMRSBot> sunbiz: I have not seen bmamline. |
| 21:59:20 | <sunbiz> !seen bmamlin |
| 21:59:20 | <OpenMRSBot> sunbiz: I have not seen bmamlin. |
| 21:59:26 | <sunbiz> !seen burke |
| 21:59:26 | <OpenMRSBot> sunbiz: burke was last seen in #openmrs 1 day, 4 hours, and 14 seconds ago: <burke> I mean... sure is! |
| 21:59:46 | <sunbiz> sorry... lemme see that stacktrace... this OpenMRSBot is distracting me ;-) |
| 22:00:44 | <sunbiz> jblaya: it seems to be coming from PatientSearchCohortDefinitionProvider.evaluate |
| 22:00:45 | <jblaya> sunbiz, your hilarious, and all this while you're cooking |
| 22:00:50 | <sunbiz> hmm... it looks odd |
| 22:00:57 | <jblaya> sunbiz, yeah, it's funny because other patient searches do work |
| 22:01:00 | <sunbiz> mostly why I burn my dishes! |
| 22:01:09 | <jblaya> sunbiz, if instead of putting 22 I put 1,2 it works |
| 22:02:17 | <sunbiz> looks like that saved search doesnt have a class... or isnt saved |
| 22:02:18 | <sunbiz> search must be saved, composition, or must have a class specified |
| 22:02:28 | <sunbiz> but if it isnt saved... u could not hadd it to the GP |
| 22:02:47 | <sunbiz> *add |
| 22:03:10 | <jblaya> sunbiz, could it be because it doesn't have any patients? the ones that don't give me errors have patients |
| 22:03:32 | <sunbiz> jblaya: nope, that seems unlikely |
| 22:03:48 | *** annarm has quit IRC |
| 22:03:52 | <jblaya> sunbiz, ok, because it's actually almost all of the saved patient searches I have |
| 22:03:58 | *** annarm has joined #openmrs |
| 22:04:32 | <sunbiz> lemme check the reporting compatibility code... |
| 22:04:35 | <jblaya> sunbiz, your right it's not that, there's one with a patient and it still gives me that error |
| 22:04:50 | *** mogoodrich has quit IRC |
| 22:05:02 | <jblaya> sunbiz, I created them with 1.5.8, but when I started seeing these errors, I changed back to 1.5.7, but still getting them |
| 22:05:42 | <sunbiz> its coming from here - Class clz = search.getFilterClass(); |
| 22:05:42 | <sunbiz> if (clz == null) |
| 22:05:42 | <sunbiz> throw new IllegalArgumentException("search must be saved, composition, or must have a class specified"); |
| 22:06:50 | *** cospih_ has quit IRC |
| 22:08:02 | <sunbiz> jblaya: Could u describe the cohort?? |
| 22:08:16 | <sunbiz> like whats it searching? |
| 22:08:25 | <jblaya> would you like to get into our system sunbiz, it's completely empty for now |
| 22:08:42 | *** annarm has quit IRC |
| 22:08:50 | <jblaya> sunbiz, it's all in spanish, but I could translate :-D |
| 22:08:57 | <sunbiz> jblaya: I could get into... but if u could describe it to me |
| 22:09:02 | <sunbiz> exactly... might be easy |
| 22:09:03 | *** cospih has joined #openmrs |
| 22:09:12 | *** garima has quit IRC |
| 22:10:01 | <jblaya> sunbiz, one for example that gives me problems is a sql query finding patients who have more than 3 of a specific observation |
| 22:10:09 | <jblaya> sunbiz, here's the sql code select o1.person_id |
| 22:10:09 | <jblaya> from obs o1, obs o2 |
| 22:10:09 | <jblaya> where o1.concept_id = 113 #formulario de llamada |
| 22:10:09 | <jblaya> and o2.concept_id = 112 #resultado |
| 22:10:09 | <jblaya> and o1.obs_group_id = o2.obs_group_id |
| 22:10:10 | <jblaya> and o2.value_text in ('failed','no-answer') |
| 22:10:11 | <jblaya> and o1.voided=0 |
| 22:10:13 | <jblaya> and o2.voided=0 |
| 22:10:15 | <jblaya> group by o2.person_id, o1.value_text |
| 22:10:17 | <jblaya> having count(o1.person_id) >= 3; |
| 22:10:20 | <jblaya> sunbiz, maybe the problem is the sql query |
| 22:12:26 | <sunbiz> jblaya: could u add just a gender property... all |
| 22:12:42 | <sunbiz> and try making it a composition and try that? |
| 22:12:53 | <jblaya> sunbiz, ok |
| 22:14:02 | <jblaya> sunbiz, that one works |
| 22:14:22 | <sunbiz> hmm... to the same one |
| 22:14:28 | *** wyclif_ has joined #openmrs |
| 22:14:29 | *** annarm has joined #openmrs |
| 22:14:38 | <sunbiz> u did a composition... right?? |
| 22:14:41 | *** wyclif has quit IRC |
| 22:15:03 | <sunbiz> so the results are the same as SQL... |
| 22:15:04 | <jblaya> sunbiz, yep, I did the age (saved it), then a concept look up, composition (saved that one) |
| 22:15:07 | <jblaya> sunbiz, and both work |
| 22:15:17 | <jblaya> let me try a simple sql one |
| 22:16:03 | <k-joseph> dkayiwa: hi |
| 22:16:08 | <dkayiwa> k-joseph: hi |
| 22:16:09 | <jblaya> sunbiz, yep, there it gave the problem |
| 22:16:21 | <jblaya> sunbiz, and it was just select patient_id from patient; |
| 22:18:26 | <sunbiz> hmm... |
| 22:18:42 | <sunbiz> so the prob is with SQL-only searches |
| 22:19:07 | <jblaya> sunbiz, let me try a composition with sql |
| 22:19:28 | <sunbiz> but if u pair SQL-search with another... using composition it works? |
| 22:20:17 | <jblaya> sunbiz, with composition it also does not work |
| 22:20:29 | <jblaya> sunbiz, ie a sql-search with a non-sql search |
| 22:20:51 | <sunbiz> hmm... will need to investigate deeper |
| 22:21:06 | <sunbiz> why that core method is not getting a class |
| 22:21:18 | <jblaya> sunbiz, any way in the short term to fix it? |
| 22:21:27 | <jblaya> sunbiz, ie that i can fix it |
| 22:21:38 | <sunbiz> probably circumvent through the module |
| 22:22:04 | <jblaya> what does that mean? |
| 22:22:38 | <sunbiz> write some code in the module |
| 22:23:00 | <sunbiz> to bypass using that method if its a SQL |
| 22:23:28 | <jblaya> sunbiz, but the better fix is for those searches to get a class right? |
| 22:23:58 | <sunbiz> yes, OpenmrsUtil has this method |
| 22:24:01 | <sunbiz> its part of core |
| 22:25:21 | <jblaya> sunbiz, could you give me a brief outline of what a programmer would have to do to fix it, that way I can send it to our programmer |
| 22:27:41 | *** k-joseph has quit IRC |
| 22:31:47 | <sunbiz> jblaya: thinking... |
| 22:32:02 | <jblaya> sunbiz, ok :-D |
| 22:52:18 | *** harsz89 has quit IRC |
| 22:53:05 | *** annarm has quit IRC |
| 23:08:56 | <jblaya> sunbiz, could you email me that? |
| 23:15:42 | *** NameFILIP has joined #openmrs |
| 23:21:40 | <sunbiz> jblaya: sorry... yup will email |
| 23:22:40 | <jblaya> sunbiz, thanks! |
| 23:24:34 | *** dkayiwa has left #openmrs |
| 23:25:45 | <sunbiz> downey: or anyone else... have u heard about OpenScrum?? the one that pentaho want to use, but hasnt worked very well?? |
| 23:26:08 | <sunbiz> http://wiki.pentaho.com/display/OpenScrum/07.+Open+Scrum |
| 23:26:12 | <OpenMRSBot> <http://ln-s.net/-1Lf> (at wiki.pentaho.com) |
| 23:26:44 | <sunbiz> burke, djazayeri cpower ... might be interest to know, what didnt work |
| 23:32:23 | *** portablejim has joined #openmrs |
| 23:47:16 | *** NameFILIP has quit IRC |
| 23:54:53 | *** jblaya has quit IRC |