| 00:34:44 | *** wyclif_ has joined #openmrs |
| 00:34:44 | *** wyclif has quit IRC |
| 00:36:05 | *** Anuruddha has joined #openmrs |
| 00:48:11 | *** anne has joined #openmrs |
| 00:56:39 | *** harsz89 has quit IRC |
| 00:59:38 | *** r0bby is now known as robbyoconnor |
| 01:02:57 | *** anne has quit IRC |
| 01:07:21 | *** rajith has joined #openmrs |
| 01:07:55 | *** rajith has quit IRC |
| 01:09:06 | *** harsz89 has joined #openmrs |
| 01:36:43 | *** mwu227 has joined #openmrs |
| 01:37:31 | *** jb360 has joined #openmrs |
| 01:56:15 | *** mwu227 has quit IRC |
| 02:10:45 | *** jenn_ has quit IRC |
| 02:12:56 | *** lh has quit IRC |
| 02:13:49 | *** lh has joined #openmrs |
| 02:19:23 | *** andrea_p has quit IRC |
| 02:20:30 | *** jproft has joined #openmrs |
| 02:21:43 | *** andreap has quit IRC |
| 02:23:01 | *** h3llborn has quit IRC |
| 02:26:31 | *** jproft has left #openmrs |
| 02:26:51 | *** harsz89 has quit IRC |
| 02:31:42 | *** djazayeri has quit IRC |
| 02:40:22 | *** lh has quit IRC |
| 02:41:05 | *** lh has joined #openmrs |
| 03:01:52 | *** harsz89 has joined #openmrs |
| 03:02:36 | *** lh has quit IRC |
| 03:22:57 | *** harsz89 has quit IRC |
| 03:31:35 | *** GitHub197 has joined #openmrs |
| 03:31:35 | <GitHub197> [openmrs-core] harshadura opened pull request #273: TRUNK-3933: added list of fake security question to confuse the cracker (1.9.x...TRUNK-3933) http://git.io/2N3PXw |
| 03:31:35 | *** GitHub197 has left #openmrs |
| 03:34:32 | *** mario_ has quit IRC |
| 03:39:00 | *** mario_ has joined #openmrs |
| 03:39:32 | *** harsz89 has joined #openmrs |
| 03:39:37 | *** harshadura has quit IRC |
| 03:53:56 | *** Hifsa has quit IRC |
| 03:56:56 | *** mario_ has quit IRC |
| 04:17:58 | *** h3llborn has joined #openmrs |
| 04:20:15 | *** kavuri has joined #openmrs |
| 04:43:29 | *** sach has joined #openmrs |
| 04:46:24 | *** kavuri has quit IRC |
| 04:46:44 | *** kavuri has joined #openmrs |
| 04:50:47 | *** h3llborn has quit IRC |
| 05:09:23 | *** jenn_ has joined #openmrs |
| 05:10:40 | *** harsha89 has joined #openmrs |
| 05:12:26 | *** harsz89 has quit IRC |
| 05:24:42 | *** kavuri has quit IRC |
| 05:25:58 | *** davidpardz has left #openmrs |
| 05:29:12 | *** sach has quit IRC |
| 05:36:30 | *** cpower_ has quit IRC |
| 05:37:21 | *** kavuri has joined #openmrs |
| 05:51:54 | *** shortend has joined #openmrs |
| 06:02:00 | *** harsha89 has quit IRC |
| 06:08:58 | *** harsha89 has joined #openmrs |
| 06:13:09 | <jenn_> Hi, I am just bringing up the system to have a look and see how it works. I noticed that Italian is one of the language choices. I am currently living in Italy however, I am a U.S. citizen. I am just curious, how are you doing the translation? Are yo working with people in Italy or do you have a translator there? |
| 06:21:33 | *** harshadura has joined #openmrs |
| 06:22:30 | *** Anuruddha has quit IRC |
| 06:27:29 | *** Anuruddha has joined #openmrs |
| 06:39:23 | *** ibewes has joined #openmrs |
| 06:47:45 | *** rcrichton has joined #openmrs |
| 07:19:38 | *** garima has joined #openmrs |
| 07:21:10 | <garima> jkeiper: hi |
| 07:22:26 | *** sach has joined #openmrs |
| 07:37:07 | *** nimby has quit IRC |
| 07:40:15 | <garima> wyclif_ : hi |
| 07:41:07 | <garima> wyclif_ : is this issue already fixed: https://tickets.openmrs.org/browse/RESTWS-304 ? |
| 07:49:22 | <garima> djazayeri_may_be : hi |
| 07:50:03 | <garima> djazayeri_may_be: please review my PR on TRUNK-2883 |
| 07:59:01 | *** kavuri has quit IRC |
| 07:59:49 | *** kavuri has joined #openmrs |
| 08:07:24 | *** shortend has quit IRC |
| 08:12:32 | *** sach has quit IRC |
| 08:35:52 | *** garima has quit IRC |
| 08:45:24 | *** dkayiwa has joined #openmrs |
| 08:46:54 | *** shortend has joined #openmrs |
| 08:53:00 | *** shortend has quit IRC |
| 08:58:39 | *** sashrika has joined #openmrs |
| 09:02:39 | *** NameFILIP has joined #openmrs |
| 09:06:50 | *** harshadura has quit IRC |
| 09:16:33 | *** shortend has joined #openmrs |
| 09:23:44 | *** shortend has quit IRC |
| 09:24:12 | *** sashrika has quit IRC |
| 10:01:10 | *** jenn_ has quit IRC |
| 10:07:35 | *** Sateesh has joined #openmrs |
| 10:09:25 | *** kavuri has quit IRC |
| 10:17:51 | *** harshadura has joined #openmrs |
| 10:21:48 | *** DraggonZ has joined #openmrs |
| 10:29:41 | *** garima has joined #openmrs |
| 10:36:27 | *** harshadura_ has joined #openmrs |
| 10:37:57 | *** garima has quit IRC |
| 10:42:00 | *** atul2512 has joined #openmrs |
| 10:42:46 | <atul2512> Hey i am usng openmrs but m not able to find sms option..Is it not implemented?if yes.plz share the location |
| 10:43:43 | <atul2512> ne1 der? |
| 10:51:46 | *** rkorytkowski has joined #openmrs |
| 10:51:46 | *** ChanServ sets mode: +v rkorytkowski |
| 10:51:46 | *** rkorytkowski is now known as rafa |
| 10:54:30 | *** Anuruddha has quit IRC |
| 10:54:59 | <DraggonZ> hi, rafa! can you look to my comment https://tickets.openmrs.org/browse/RESTWS-375 ? |
| 10:55:15 | <rafa> DraggonZ: hi, absolutely! |
| 10:56:13 | <rafa> DraggonZ: responded, thanks for looking into that! |
| 10:57:47 | <DraggonZ> ok :) how requests like user?q=personname&username=testuser should be handled? |
| 10:58:22 | <rafa> DraggonZ: it's a bad request |
| 10:58:58 | <DraggonZ> rafa, just return empty result? |
| 10:58:59 | <rafa> DraggonZ: it should be either q or username |
| 10:59:26 | <rafa> DraggonZ: no just implement a search handler for username |
| 10:59:46 | <rafa> DraggonZ: the framework will send a bad request response if you query by q and username |
| 10:59:47 | *** garima has joined #openmrs |
| 11:00:24 | <DraggonZ> i think, to implement this i should rewrite doSearch method |
| 11:00:50 | <DraggonZ> and there look at incoming parameters |
| 11:01:01 | <rafa> DraggonZ: the q search is implemented in doSearch so just leave it as it is |
| 11:01:11 | <rafa> DraggonZ: but create SearchHandler for username |
| 11:01:23 | <rafa> DraggonZ: the framework should do the right thing |
| 11:02:02 | <DraggonZ> rafa, thanks! |
| 11:02:19 | <rafa> DraggonZ: no problem! |
| 11:02:55 | <DraggonZ> it means i did wrong RESTWS-293, i handled both q and user parameters in doSearch method |
| 11:02:59 | <garima> rafa, hi! |
| 11:03:16 | <rafa> garima: hi |
| 11:03:21 | <rafa> !ticket RESTWS-293 |
| 11:03:22 | <OpenMRSBot> rafa: [#RESTWS-293] Add Provider lookup based on User uuid - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-293 |
| 11:04:14 | <garima> rafa, is RESTWS-376 ready for work? |
| 11:04:24 | <DraggonZ> wow, irc is great stuff :) |
| 11:04:36 | <rafa> DraggonZ: yes, it's unnecessary to do q search |
| 11:04:47 | <rafa> !ticket RESTWS-376 |
| 11:04:48 | <OpenMRSBot> rafa: [#RESTWS-376] Add ability to search by id - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-376 |
| 11:05:32 | <rafa> garima: I'm just not sure how to best implement this |
| 11:05:51 | <rafa> garima: I don't want us to implement a search handler for every resource |
| 11:06:05 | <rafa> garima: let me look at the code |
| 11:06:41 | <garima> rafa: okay! are you planning to implement a common search handler for all the resource ? |
| 11:06:50 | <rafa> garima: it would be best |
| 11:07:06 | <garima> rafa: and it can be done? |
| 11:07:12 | <rafa> garima: but there's also a question of privilege checks |
| 11:07:17 | <rafa> garima: I'm not sure yet :) |
| 11:07:54 | <garima> rafa: okay, i would like to do the implementation once you figure out the best way to implement :) |
| 11:08:12 | <rafa> garima: thanks! I'll comment on the ticket :) |
| 11:08:24 | <rafa> garima: I may need to consult with Darius |
| 11:08:40 | <rafa> garima: although he's offline for the next 3 days |
| 11:08:50 | <garima> rafa: sure! I will wait for your comment :) |
| 11:09:26 | <garima> rafa, would you review my work on TRUNK-2883, only change is an error message, shouldn't take long |
| 11:09:38 | *** Anuruddha has joined #openmrs |
| 11:09:40 | <rafa> !ticket TRUNK-2883 |
| 11:09:41 | <OpenMRSBot> rafa: [#TRUNK-2883] Undefined personType/viewType combo: / - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2883 |
| 11:10:16 | <rafa> garima: I see some that you committed some log files |
| 11:10:22 | <rafa> garima: could you please clean it up? |
| 11:10:33 | <rafa> garima: https://github.com/openmrs/openmrs-core/pull/265/files |
| 11:10:38 | <OpenMRSBot> <http://ln-s.net/+zqt> (at github.com) |
| 11:10:51 | <garima> rafa: sure |
| 11:11:03 | <garima> rafa: let me get back to u on this in a few minutes |
| 11:12:28 | <rafa> garima: sure |
| 11:15:17 | *** robbyoconnor has quit IRC |
| 11:16:57 | <garima> rafa: done :) |
| 11:17:06 | <rafa> garima: great thatnks! |
| 11:18:58 | <garima> rafa: :) |
| 11:19:15 | <DraggonZ> rafa, so i need to implement Searchhandler for provider resource too? |
| 11:19:44 | <DraggonZ> rafa, questions attack :) |
| 11:19:53 | <rafa> DraggonZ: it would be best to do it with a search handler |
| 11:26:43 | *** cospih has joined #openmrs |
| 11:28:17 | <harsha89> hi rafa |
| 11:28:27 | <rafa> harsha89: hi :) |
| 11:28:37 | <harsha89> rafa, i have provided a pull request to https://tickets.openmrs.org/browse/RESTWS-253 |
| 11:28:47 | *** atul2512 has quit IRC |
| 11:28:53 | <rafa> harsha89: yes, I saw it |
| 11:28:54 | <harsha89> rafa, if you have a time please have a look :) |
| 11:28:59 | <harsha89> rafa, okey :D |
| 11:29:10 | <harsha89> rafa, thank you :) |
| 11:29:19 | <rafa> harsha89: please remember to click request code review |
| 11:29:48 | <harsha89> rafa, oopz i forgot it next time sure :) |
| 11:40:44 | *** mario_ has joined #openmrs |
| 11:51:43 | *** Sateesh has quit IRC |
| 12:07:21 | *** kavuri has joined #openmrs |
| 12:28:03 | *** kavuri has quit IRC |
| 12:35:39 | *** mythul has joined #openmrs |
| 12:37:05 | *** wyclif_ has quit IRC |
| 12:46:47 | *** NameFILIP has quit IRC |
| 12:49:43 | *** DraggonZ has quit IRC |
| 12:50:28 | *** mythul has quit IRC |
| 12:58:34 | *** NameFILIP has joined #openmrs |
| 13:05:33 | <downey> hey rafa we now have a "designated committer" :) |
| 13:06:57 | <jkeiper> downey: designated for what? |
| 13:07:23 | <downey> jkeiper: designated for merging/committing/etc |
| 13:07:50 | <dkayiwa> downey: all of us are designated :) |
| 13:07:51 | <jkeiper> ah |
| 13:07:57 | <jkeiper> i'm designated to be awesome |
| 13:08:02 | <downey> dkayiwa: designated vs. authorized :) |
| 13:08:06 | *** Anuruddha has quit IRC |
| 13:08:17 | * jkeiper is authorized to be awesome too |
| 13:08:21 | *** Anuruddha has joined #openmrs |
| 13:08:42 | <dkayiwa> downey: we are both :) |
| 13:09:36 | <rafa> downey: yes, I've seen it. Thanks a lot! Any chance to have it in all projects? |
| 13:09:50 | <downey> rafa: it should be |
| 13:10:27 | <rafa> downey: it's only in trunk from what I see |
| 13:10:48 | *** shortend has joined #openmrs |
| 13:11:21 | <rafa> dkayiwa: the idea is that if you review some code you can add yourself as a designated committer |
| 13:11:31 | *** harsz89 has joined #openmrs |
| 13:11:41 | <dkayiwa> rafa: never heard of that :) |
| 13:11:42 | <rafa> dkayiwa: this way I'll know that you're handling it |
| 13:12:13 | <rafa> dkayiwa: it's new :) |
| 13:12:36 | <rafa> dkayiwa: you can have a query to keep track of tickets you |
| 13:12:40 | <rafa> dkayiwa: |
| 13:12:44 | <rafa> dkayiwa: are revieing |
| 13:12:49 | <dkayiwa> rafa: i thought when one reviews and does not commit, they leave comments why they have not committed. Then after those comments are addressed, any other dev is free to take if from there and commit. Am i correct? |
| 13:12:50 | <rafa> dkayiwa: *reviewing |
| 13:13:11 | *** harsz89 has quit IRC |
| 13:13:25 | *** harsha89 has quit IRC |
| 13:13:42 | *** harsz89 has joined #openmrs |
| 13:13:43 | <rafa> dkayiwa: it's a waste of resources, because you already know the context and you will do the second review much faster |
| 13:13:59 | <dkayiwa> rafa: oh i see!!! Now i understand :) |
| 13:14:34 | <rafa> dkayiwa: but you are always welcome to step in and leave your comments regardless who is a designated committer |
| 13:14:53 | <dkayiwa> rafa: correct :) |
| 13:16:08 | <harsz89> rafa, hi |
| 13:16:18 | <harsz89> rafa, i'm thinking of looking https://tickets.openmrs.org/browse/RESTWS-281 |
| 13:16:20 | <rafa> harsz89: hi |
| 13:16:56 | <rafa> harsz89: it'll be great if you pick it up |
| 13:17:09 | <harsz89> rafa, okey i'll |
| 13:17:28 | <harsz89> rafa, i may need bit of time to cover the background |
| 13:17:42 | <harsz89> rafa, once i covered i'll start coding |
| 13:17:43 | <rafa> harsz89: no hurry :) |
| 13:17:45 | <harsz89> rafa, :) |
| 13:17:54 | <harsz89> rafa, okey rafa thank you :) |
| 13:21:23 | *** mario__ has joined #openmrs |
| 13:25:00 | *** mario_ has quit IRC |
| 13:33:18 | *** wyclif_ has joined #openmrs |
| 13:36:42 | <downey> rafa: you can edit any openmrs ticket to add a designated committer :) |
| 13:39:38 | <rafa> downey: ohh ok, it's just not displayed by default, I had to click edit and configure fields |
| 13:39:47 | <rafa> downey: thanks! |
| 13:39:51 | <downey> rafa: yep if null, it doesn't appear |
| 13:40:34 | *** ibewes has quit IRC |
| 13:41:55 | <rafa> downey: Shall we e-mail the dev list to advertise it a bit? :) |
| 13:43:58 | *** DraggonZ has joined #openmrs |
| 13:53:48 | *** garima has quit IRC |
| 13:55:13 | <downey> rafa: i think you may be able to think up the scenarios/usage better than i can, but if you'd like me to help in writing i'm happy to :) |
| 13:57:48 | <rafa> downey: thanks! I'll be happy to write it :) |
| 14:01:12 | *** andrea_ has joined #openmrs |
| 14:01:55 | <rafa> andrea_: good morning :) |
| 14:02:16 | <andrea_> rafa, hi - ticket fixed |
| 14:02:30 | <rafa> andrea_: awesome! |
| 14:02:45 | <rafa> andrea_: congrats! :) |
| 14:03:08 | <andrea_> rafa, thank you - this one was hard! |
| 14:03:43 | <andrea_> rafa, need one more commit after scrum - clean up comments |
| 14:05:11 | <rafa> andrea_: very well |
| 14:05:15 | <rafa> cpower: are you around? |
| 14:06:17 | <rafa> okay, let's start anyway |
| 14:06:22 | <rafa> !scrumon rafa |
| 14:06:22 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster rafa- you may begin when ready. |
| 14:07:10 | <rafa> today's order: andrea_, rafa, dkayiwa, wyclif_, harsz89, DraggonZ and anyone else who wants to share something :) |
| 14:07:59 | <andrea_> Thursday |
| 14:07:59 | <andrea_> Ticket TRUNK-3751 |
| 14:07:59 | <andrea_> Saying that a module requires OpenMRS 1.9.2-SNAPSHOT fails |
| 14:07:59 | <andrea_> Fixed problem causing it to fail |
| 14:07:59 | <andrea_> Alkso added new method: checkForAlphaVersion to handle any alpha version not |
| 14:07:59 | <andrea_> just SNAPSHOT |
| 14:08:01 | <andrea_> Friday |
| 14:08:03 | <andrea_> Merck meeting |
| 14:08:05 | <andrea_> Ticket TRUNK-3751 |
| 14:08:07 | <andrea_> Clean up, commit and push |
| 14:08:09 | <andrea_> No Blockers |
| 14:08:13 | <rafa> Today: |
| 14:08:14 | <rafa> * A bunch of reviews and merges |
| 14:08:14 | <rafa> * Some IRC and e-mail support |
| 14:08:14 | <rafa> * Started with RA-18: Determine compass/sass configuration for letting one module extend the css of another one |
| 14:08:14 | <rafa> https://tickets.openmrs.org/browse/RA-18 |
| 14:08:14 | <rafa> No blockers. |
| 14:08:32 | <dkayiwa> Committed: In create patient, if get an error when submitting it still creates the patient without a form and then doesn't let you enter the form again - XFRM-135 |
| 14:08:33 | <dkayiwa> Reviewed: Saying that a module requires OpenMRS 1.9.2-SNAPSHOT fails - TRUNK-3751 |
| 14:08:33 | <dkayiwa> Reviewed and closed: Concept Editing UI: if you have a validation error, changes are still flushed to database *and* concept names aren't properly voided - TRUNK-3949 |
| 14:08:33 | <dkayiwa> Closed: TRUNK-1852, XFRM-139 |
| 14:08:33 | <dkayiwa> Now reviewing: Change calendar.js to support future dates. - TRUNK-3829 |
| 14:08:33 | <dkayiwa> No Blockers |
| 14:09:06 | <wyclif_> Thursday: |
| 14:09:06 | <wyclif_> - Dev call |
| 14:09:06 | <wyclif_> - Fixed tests, dependencies and bamboo build plan for emr module |
| 14:09:06 | <wyclif_> - Added a redirect to login page when a user requests for the home page |
| 14:09:06 | <wyclif_> - Added a redirect to previously requested page when a user is prompted to login |
| 14:09:07 | <wyclif_> Friday: |
| 14:09:09 | <wyclif_> - RG quarterly staff meeting |
| 14:09:11 | <wyclif_> - Need to work with Michael to make sure emr module starts on devtest01 server |
| 14:09:13 | <wyclif_> - Pick another sprint task/ticket |
| 14:09:15 | <wyclif_> |
| 14:09:17 | <wyclif_> Blockers: None |
| 14:09:48 | <rafa> harsz89: do you want to share what you've been working on? |
| 14:10:56 | <rafa> DraggonZ: same for you :) |
| 14:11:15 | *** NameFILIP has quit IRC |
| 14:11:42 | <rafa> okay, then let's wrap up |
| 14:11:56 | <rafa> no blockers, no discussion points, have a nice day and weekend! |
| 14:12:04 | <rafa> !scrumoff |
| 14:12:04 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:12:04 | <andrea_> rafa, would like to make a comment |
| 14:12:26 | <rafa> andrea_: go ahead :) |
| 14:12:29 | * jkeiper listens |
| 14:12:33 | <rafa> andrea_: though we're off the record |
| 14:13:06 | <andrea_> today is my last day with Merck, Going to send an email to dev list - will miss you all |
| 14:13:13 | <jkeiper> !!!!!!!!!!!!111111!!111!!!11!!!1 |
| 14:13:14 | <OpenMRSBot> jkeiper: Error: "!!!!!!!!!!!111111!!111!!!11!!!1" is not a valid command. |
| 14:13:20 | <jkeiper> andrea_: ! |
| 14:13:27 | <rafa> andrea_: :( |
| 14:13:38 | *** garima has joined #openmrs |
| 14:13:39 | <andrea_> also, would like to contine contributing to openmrs |
| 14:13:51 | <andrea_> if you'll have me |
| 14:14:07 | <jkeiper> of course |
| 14:14:17 | *** nyoman has joined #openmrs |
| 14:14:22 | <rafa> andrea_: definitely, stay around! It's great to have you! |
| 14:14:40 | <andrea_> jkeiper, rafa, great - thanks! |
| 14:15:08 | <wyclif_> andrea_, was nice having you |
| 14:15:29 | <downey> andrea_: best of luck in your transitions ... as you know we always welcome volunteer efforts! :-) |
| 14:15:40 | <DraggonZ> rafa, sorry, wasn't here at scrum time :( |
| 14:15:49 | <andrea_> wyclif, was great working with you too - all of you |
| 14:15:53 | <wyclif_> andrea_, looking forward to your continued contibutions to openmrs |
| 14:15:57 | <rafa> DraggonZ: no worries, we're here for you :) |
| 14:16:02 | <cpower> same here, company wide meeting through off my morning routine |
| 14:16:10 | <andrea_> hi downry, thanks! |
| 14:16:32 | <andrea_> whoops, that's hi downey |
| 14:16:55 | <cpower> andrea_: You are always a part of this team |
| 14:17:15 | <andrea_> cpower: thank you!! |
| 14:17:47 | <andrea_> rafa, got to do this last commit |
| 14:19:29 | *** nimby has joined #openmrs |
| 14:22:44 | <cpower> Some announcements the I wish Darius was here to back up. Iteration 0 work is continuing for another day or so. Then we will be moving on to our first work phase on the Reference Application: Registration. Figure Tues/Wed. Some OpenMRS developers will be working closely with PIH to get some items done on the Registration module and continue to learn CI. |
| 14:22:44 | <cpower> WE NEED THOSE INDIVIDUALS TO COME TO OUR DAILY SCRUMS AND REPORT ON WHAT THEY HAVE BEEN WORKING ON AND WHAT THEY HAVE LEARNED. so we can all benefit from this experience. The OpenMRS dev's that are not on this will be working on community swimlane, and I will be talking to with as many implementers as I can to see what other work we can do as well with a |
| 14:22:44 | <cpower> mostly volunteer effort. |
| 14:23:30 | <jkeiper> OMG KTHXBYE |
| 14:23:44 | <cpower> huh? |
| 14:23:51 | *** djazayeri has joined #openmrs |
| 14:23:51 | *** ChanServ sets mode: +o djazayeri |
| 14:23:56 | <jkeiper> default all-caps words |
| 14:24:54 | <jkeiper> but srsly, it would be nice if PIH devs could participate with omrs scrums |
| 14:25:04 | <jkeiper> i assume that's what you mean cpower? |
| 14:25:53 | *** lh has joined #openmrs |
| 14:25:53 | *** lh has joined #openmrs |
| 14:25:59 | <cpower> We will get Darius from PIH, I wouldn't predict anyone else |
| 14:26:46 | <djazayeri> hi |
| 14:26:51 | <cpower> but bonus if they do |
| 14:26:58 | <cpower> hey it's djazayeri ! |
| 14:26:59 | <downey> our scrums are welcome to all :-) |
| 14:27:10 | <cpower> downey: exactly |
| 14:28:18 | <djazayeri> sorry, just passing through on my way to the airport—I'm off today. |
| 14:28:34 | <djazayeri> Will email more broadly about Ref App sprint status on Monday |
| 14:31:15 | *** sre1 has joined #openmrs |
| 14:34:20 | <andrea_> rafa, you still here? |
| 14:35:27 | *** sre1 has quit IRC |
| 14:39:57 | <garima> rafa, hi |
| 14:40:47 | *** wyclif_ has quit IRC |
| 14:40:51 | *** wyclif has joined #openmrs |
| 14:46:01 | *** rcrichton has quit IRC |
| 14:47:11 | <harsz89> hi rafa |
| 14:47:28 | <harsz89> rafa, i'm sorry i'm away that movement |
| 14:47:48 | <harsz89> rafa, just got back at pc :) |
| 14:48:33 | <harsz89> rafa, thanks a lot for inviting :) really appreciate :) |
| 14:48:43 | <harsz89> rafa, next time i won't miss :) |
| 14:52:24 | <DraggonZ> rafa, can i ask about RESTWS-375? |
| 14:53:05 | <DraggonZ> SearchHandler's search method returns PageableResult |
| 14:53:38 | <DraggonZ> User has unique username, so finding by username will return only one User |
| 14:54:33 | <DraggonZ> But may be u should get all users, whose usernames contains search username? |
| 14:54:38 | *** garima has quit IRC |
| 14:54:44 | <DraggonZ> *i should ) |
| 14:55:12 | <rafa> DraggonZ: no, we want just a unique result |
| 14:55:21 | <rafa> DraggonZ: the q search can do partial search |
| 14:55:36 | <rafa> harsz89: happy to hear, you're always welcome to join our scrum :) |
| 14:55:57 | <rafa> andrea_: I'm back |
| 14:56:17 | <DraggonZ> rafa, so search method will return collection with only one element? |
| 14:56:24 | <rafa> DraggonZ: correct |
| 14:56:32 | <harsz89> rafa, :) :) |
| 14:56:40 | <DraggonZ> rafa, thank you! |
| 14:56:54 | <rafa> DraggonZ: np |
| 14:58:21 | <rafa> I'm signing off for today... see you tomorrow! |
| 14:59:00 | *** rafa has quit IRC |
| 15:04:40 | *** dkayiwa has left #openmrs |
| 15:04:52 | *** breeze has joined #openmrs |
| 15:05:03 | *** Mkop has quit IRC |
| 15:06:47 | *** Mkop has joined #openmrs |
| 15:06:47 | *** ChanServ sets mode: +v Mkop |
| 15:07:50 | *** harshadura has quit IRC |
| 15:07:57 | *** harshadura_ has quit IRC |
| 15:09:18 | *** shortend has quit IRC |
| 15:20:54 | *** harshadura_ has joined #openmrs |
| 15:23:21 | *** breeze has joined #openmrs |
| 15:25:56 | *** nimby has quit IRC |
| 15:26:23 | <DraggonZ> i'm in some troubles with git, who can help? |
| 15:27:03 | <DraggonZ> i created branch for ticket, after i started to work on another one |
| 15:27:28 | <DraggonZ> created second branch, but didn't checkout to master before |
| 15:27:52 | <DraggonZ> so hierachy was like this: master -> branch1 -> branch2 |
| 15:28:08 | <DraggonZ> i pushed changes to origin |
| 15:28:35 | <DraggonZ> and now can see changes commits from branch1 on branch2 |
| 15:29:30 | <DraggonZ> did git rebase --onto master branch1 to set parent branch to master |
| 15:30:40 | <DraggonZ> but after that i cannot push to origin |
| 15:30:46 | <DraggonZ> git: Updates were rejected because the tip of your current branch is behind |
| 15:30:47 | <DraggonZ> its remote counterpart. Merge the remote changes (e.g. 'git pull') |
| 15:49:20 | *** harsz89 has quit IRC |
| 15:57:06 | *** DraggonZ has quit IRC |
| 16:02:39 | *** djazayeri1 has joined #openmrs |
| 16:06:03 | *** djazayeri has quit IRC |
| 16:06:06 | *** Anuruddha has quit IRC |
| 16:07:33 | *** lh has quit IRC |
| 16:07:40 | *** djazayeri1 has quit IRC |
| 16:08:07 | *** Anuruddha has joined #openmrs |
| 16:09:20 | *** lh has joined #openmrs |
| 16:14:13 | *** lh has quit IRC |
| 16:18:03 | *** lh has joined #openmrs |
| 16:18:03 | *** lh has joined #openmrs |
| 16:44:32 | *** andrea_ has quit IRC |
| 16:53:41 | *** wyclif_ has joined #openmrs |
| 16:54:15 | *** wyclif has quit IRC |
| 17:16:51 | *** jenn_ has joined #openmrs |
| 17:51:12 | *** Anuruddha has quit IRC |
| 17:51:43 | *** Anuruddha has joined #openmrs |
| 17:52:18 | *** lh has quit IRC |
| 17:53:59 | *** lh has joined #openmrs |
| 18:00:47 | <downey> breeze: did you happen to set module.allow_web_admin=false specifically in openmrs-runtime.properties on devtest01? /cc wyclif_ |
| 18:17:43 | *** Anuruddha has quit IRC |
| 18:21:36 | <jenn_> I am not sure if this is too general of a question but, I am interested in working on a ticket and I am having trouble finding one that I know is not being worked on. Does anyone have any suggestions on a ticket I can work on that is good for getting started learning the code? |
| 18:22:13 | *** andreapat has joined #openmrs |
| 18:22:25 | <downey> jenn_: The ones listed at https://wiki.openmrs.org/display/docs/Getting+Started+as+a+Developer are generally available for work :) |
| 18:22:26 | <OpenMRSBot> <http://ln-s.net/8bkO> (at wiki.openmrs.org) |
| 18:23:05 | <andreapat> wyclif_, rafa, dkayiwa - anyone here? |
| 18:25:12 | <jenn_> I have noticed in the comments on several of them that someone has started working on them, or it appears someone is working on them. Is there a way to know for sure if the ticket is free to be worked on? |
| 18:25:36 | <wyclif_> hi andreapat |
| 18:26:30 | <andreapat> wyclif_: hi your're right I do need another unit test - actually 2 |
| 18:26:33 | <downey> jenn_: if you see a status of "Ready for Work" and "Assignee: Unassigned", then you can click the "Claim Issue" button to mark that you're going to work on it |
| 18:27:10 | <downey> jenn_: but if you have questions about a specific one, just paste the URL or ticket number here and we can let you konw |
| 18:27:16 | <downey> *know |
| 18:27:51 | <andreapat> wyclif_, how do I test that checkRequiredVersion does NOT throw a module exception? |
| 18:28:44 | <jenn_> Ok. Thank you, downey, for your help. |
| 18:28:51 | <downey> jenn_: sure, no problem! |
| 18:31:36 | <andreapat> wyclif_? |
| 18:37:47 | <wyclif_> hi dn |
| 18:37:50 | <wyclif_> hi andreapat |
| 18:38:04 | <downey> andreapat: i think he was stuck in a trance but i broke though to him :) |
| 18:38:20 | <downey> or at least listening to it :) |
| 18:38:32 | <andreapat> wyclif, hi |
| 18:38:39 | <andreapat> downry thanks |
| 18:38:57 | <andreapat> wyclif_, how do I test that checkRequiredVersion does NOT throw a module exception? |
| 18:39:01 | <wyclif_> andreapat, when is the exception thrown |
| 18:39:17 | <wyclif_> why do you need to test that? |
| 18:40:04 | <andreapat> wyclif, that is what I fixed in checkRequiredVersion see TRUNK-3751 |
| 18:40:12 | <wyclif_> andreapat, just call the method in your test method and make sure it returns successfully |
| 18:41:01 | <andreapat> wyclif, there is no return code from checkRequiredVersion |
| 18:41:56 | <wyclif_> andreapat, just call the method in your test method and make sure it returns successfully |
| 18:42:44 | <andreapat> wyclif, that's what I don't get how to make sure it returns successfully |
| 18:42:44 | <wyclif_> returning successfully doesnt mean it has to return a value, it just means the method gets executed successfully till the end |
| 18:43:06 | <andreapat> wyclif, I never did junit tests before openmrs |
| 18:43:11 | <wyclif_> andreapat, am confused also |
| 18:44:04 | <wyclif_> andreapat, i meant just call the method in your test and pass to it the param values that were failing before you adedd your code |
| 18:44:31 | <wyclif_> andreapat, if an exception is not thrown that is it, if it is of course you need to fix it |
| 18:44:46 | <andreapat> wyclif, and don't check for anything? |
| 18:45:08 | <andreapat> wyclif, let me try it - so short on time today |
| 18:45:37 | <wyclif_> andreapat, yeah dont check anything, just call it and that is all |
| 18:45:52 | <wyclif_> andreapat, assuming it was failing before |
| 18:45:56 | <andreapat> wyclif_, ok thanks! |
| 18:46:14 | <wyclif_> andreapat, so call it and make sure the exception is thrown before you add your code changes |
| 18:48:28 | <wyclif_> andreapat, and then add your code and make sure this time it doesnt, that is the principal of writing unit tests, they should fail before you add your code and pass after you apply it |
| 18:50:19 | <andreapat> wyclif_, I did failing test already |
| 18:50:37 | <wyclif_> andreapat, sorry i didnt get that |
| 18:50:45 | <wyclif_> andreapat, can you rephrase it? |
| 18:51:20 | <andreapat> wyclif_, Have already done test to make sure the exception is thrown |
| 18:53:33 | <andreapat> wyclif_, new test works if I've understood you correctly - no module exception |
| 18:56:46 | <andreapat> wyclif_: very cool 2 new tests - 1 to check alpha version in config file works, other to test alpha openmrs-version and alpha version in config file |
| 18:57:25 | <andreapat> wyclif_ the Merck folks are taking me to lunch - will commit when I get back |
| 18:57:31 | <wyclif_> andreapat, ok |
| 19:19:52 | <downey> sunbiz: finally read your shout or leave post - good stuff :) |
| 20:07:58 | *** nimby has joined #openmrs |
| 20:22:53 | <downey> http://starlogs.net/#openmrs/openmrs-core |
| 20:25:02 | *** ryates has left #openmrs |
| 20:25:10 | *** ryates has joined #openmrs |
| 20:25:10 | *** ChanServ sets mode: +o ryates |
| 20:25:36 | <andreapat> wyclif_, I'm back |
| 20:27:20 | *** andreap has joined #openmrs |
| 20:27:42 | <sunbiz> downey: thanks! |
| 20:28:35 | <andreap> wyclif_, just switched to regular irc - xchat is connected to merck network and builds take forever on it |
| 20:28:42 | <sunbiz> downey: the concept of cool companies making... cool contributions is poisonous to a community |
| 20:29:07 | *** andreapat has quit IRC |
| 20:29:08 | <downey> sunbiz: definitely |
| 20:29:13 | <sunbiz> or so I've been trying to highlight from some interviews I've been doing with different open-source developers |
| 20:30:07 | <sunbiz> downey: I should use ur connections better :) |
| 20:30:35 | <downey> sunbiz: OSI might be willing to help |
| 20:30:47 | <downey> sunbiz: i could put up a flyer for you at OSCON ;-) |
| 20:31:16 | <sunbiz> downey: that'd be really cool... |
| 20:31:32 | <downey> sunbiz: remind me, or better yet you should apply for a scholarship :) |
| 20:31:36 | <sunbiz> downey: who else going with u?? |
| 20:31:57 | <downey> sunbiz: i believe i docpaul, burke, jkeiper at a minimum |
| 20:32:00 | <downey> maybe more |
| 20:32:02 | <sunbiz> downey: Im traveling for some implementations at that time |
| 20:32:05 | <sunbiz> :( |
| 20:32:16 | <sunbiz> downey: okkk... thats quite some ppl... cool |
| 20:32:57 | *** andreap has quit IRC |
| 20:39:11 | *** andreap has joined #openmrs |
| 20:40:14 | <nyoman> !help alias |
| 20:40:14 | <OpenMRSBot> nyoman: Error: There is no command "alias". |
| 20:40:20 | <nyoman> !alias help |
| 20:40:21 | <OpenMRSBot> nyoman: Error: The "Alias" plugin is loaded, but there is no command named "help" in it. Try "list Alias" to see the commands in the "Alias" plugin. |
| 20:40:41 | <nyoman> !learn |
| 20:40:41 | <OpenMRSBot> nyoman: Invalid arguments for learn. |
| 20:40:46 | <nyoman> !learn list |
| 20:40:46 | <OpenMRSBot> nyoman: Invalid arguments for learn. |
| 20:41:48 | <nyoman> !alias add sql-joins https://lh6.googleusercontent.com/-yCF8ozFNypQ/UWawXy7vg3I/AAAAAAAAAkM/tXcV3HupLFE/s966/BHVicYICMAAdHGv.jpg |
| 20:41:48 | <OpenMRSBot> nyoman: The operation succeeded. |
| 20:41:56 | <nyoman> !sql-joins |
| 20:41:57 | <OpenMRSBot> nyoman: Error: "https://lh6.googleusercontent.com/-yCF8ozFNypQ/UWawXy7vg3I/AAAAAAAAAkM/tXcV3HupLFE/s966/BHVicYICMAAdHGv.jpg" is not a valid command. |
| 20:42:46 | <nyoman> !alias remove sql-joins |
| 20:42:46 | <OpenMRSBot> nyoman: The operation succeeded. |
| 20:52:17 | *** nyoman has quit IRC |
| 20:55:14 | *** breeze has quit IRC |
| 21:09:11 | <sunbiz> wasnt there a global property that allowed ppl to set the OpenMRS home directory?? |
| 21:11:12 | *** andreapat has joined #openmrs |
| 21:11:22 | <sunbiz> by default its this .OpenMRS folder... and %APPDATA%\OpenMRS on windows |
| 21:11:32 | <sunbiz> can someone remember the global property name?? |
| 21:11:34 | <andreapat> wyclif_, you here? |
| 21:11:45 | <sunbiz> !openmrs_home |
| 21:11:45 | <OpenMRSBot> sunbiz: Error: "openmrs_home" is not a valid command. |
| 21:11:50 | <wyclif_> andreap, yeah |
| 21:12:01 | <andreapat> wyclif_, committed and pushed - comment on ticket TRUNK-3751 |
| 21:12:16 | <sunbiz> sorry... the env var |
| 21:12:48 | <andreapat> wyclif_: was just hoping you could check it out quickly - have to give Merck computer with openmrs on it back today |
| 21:13:28 | <sunbiz> nevermind.. found it... its only for {WEBAPP NAME}_RUNTIME_PROPERTIES_FILE |
| 21:18:40 | *** nimby has quit IRC |
| 21:36:16 | *** wyclif_ has quit IRC |
| 22:18:45 | *** cospih has quit IRC |
| 22:27:16 | *** wyclif_ has joined #openmrs |
| 22:32:18 | *** NameFILIP has joined #openmrs |
| 22:40:25 | *** davidpardz has joined #openmrs |
| 22:41:15 | <sunbiz> jkeiper: have u looked at whats taking the CPU to peak?? |
| 22:41:37 | <sunbiz> that u mentioned on the thing at AMPATH having CPU load?? |
| 22:42:48 | <sunbiz> jkeiper: simultaneous write bug... that had its patch available, but not released by Oracle?? Only in MySQL 5.6 they released it |
| 23:01:40 | *** andreapat has quit IRC |
| 23:04:21 | *** nimby has joined #openmrs |
| 23:07:07 | *** andreap has quit IRC |
| 23:08:13 | *** jenn_ has quit IRC |
| 23:24:43 | *** NameFILIP has quit IRC |
