00:21:08
|
*** wyclif_ has joined #openmrs
|
00:21:08
|
*** wyclif has quit IRC
|
00:37:21
|
*** wyclif has joined #openmrs
|
00:37:21
|
*** wyclif_ has quit IRC
|
00:45:24
|
*** wyclif_ has joined #openmrs
|
00:45:24
|
*** wyclif has quit IRC
|
00:45:35
|
*** wyclif_ has quit IRC
|
01:28:28
|
*** Upeksha has joined #openmrs
|
01:30:32
|
*** r0bby has quit IRC
|
01:31:23
|
*** r0bby has joined #openmrs
|
01:31:23
|
*** ChanServ sets mode: +v r0bby
|
01:52:04
|
*** djazayeri has joined #openmrs
|
01:52:04
|
*** ChanServ sets mode: +o djazayeri
|
02:01:43
|
*** harshadura has joined #openmrs
|
02:05:24
|
*** harsz89 has quit IRC
|
02:17:43
|
*** harsz89 has joined #openmrs
|
02:22:53
|
*** harshadura has quit IRC
|
02:37:04
|
*** rajith has joined #openmrs
|
02:38:05
|
*** harshadura has joined #openmrs
|
02:44:21
|
*** harshadura has quit IRC
|
02:44:33
|
*** harshadura has joined #openmrs
|
03:08:40
|
*** djazayeri has quit IRC
|
03:16:43
|
*** marleau has quit IRC
|
03:44:10
|
*** rajith has quit IRC
|
03:45:34
|
*** garima has joined #openmrs
|
03:46:10
|
*** Anuruddha has joined #openmrs
|
04:14:27
|
*** marleau has joined #openmrs
|
04:19:12
|
*** r0bby has quit IRC
|
04:31:01
|
*** harshadura has quit IRC
|
06:03:31
|
*** bhashitha has joined #openmrs
|
06:09:33
|
*** draggonz has joined #openmrs
|
06:15:34
|
*** Anuruddha has quit IRC
|
06:18:22
|
*** bhashitha has quit IRC
|
06:36:43
|
*** bhashitha has joined #openmrs
|
07:03:24
|
*** Upeksha has quit IRC
|
07:27:26
|
*** arachchi has joined #openmrs
|
07:37:33
|
*** arachchi has quit IRC
|
07:41:38
|
*** rajith has joined #openmrs
|
07:47:33
|
*** garima has quit IRC
|
07:48:48
|
*** bhashitha has quit IRC
|
07:57:20
|
*** robbyoconnor has joined #openmrs
|
07:57:20
|
*** ChanServ sets mode: +v robbyoconnor
|
07:59:03
|
*** dkayiwa has joined #openmrs
|
08:03:44
|
*** Anuruddha has joined #openmrs
|
08:34:38
|
*** shangxiao has joined #openmrs
|
08:47:38
|
<shangxiao> downey do you know if there is a standard for error messages & notifications when you're doing some stuff in UI with JavaScript?
|
08:49:01
|
<dkayiwa> shangxiao: do you mean something like an alternative to alert?
|
08:49:40
|
<shangxiao> yep
|
08:50:00
|
<shangxiao> there heaps of little libraries out there that can implement something
|
08:50:01
|
<dkayiwa> shangxiao: am not aware of any
|
08:50:15
|
<dkayiwa> shangxiao: you need to localize the message though
|
08:50:19
|
<shangxiao> but I would like to stick to the "openmrs standard"
|
08:50:27
|
<dkayiwa> shangxiao: sure
|
08:50:38
|
<dkayiwa> shangxiao: send an email to dev list
|
08:51:03
|
<shangxiao> !powerup dkayiwa
|
08:51:03
|
* OpenMRSBot slides dkayiwa a Jack and Coke
|
08:51:05
|
<shangxiao> :)
|
08:51:16
|
<dkayiwa> shangxiao: :D
|
09:23:41
|
*** garima has joined #openmrs
|
09:26:08
|
*** Anuruddha_ has joined #openmrs
|
09:29:13
|
*** dkayiwa has quit IRC
|
09:29:19
|
*** Anuruddha has quit IRC
|
09:30:52
|
*** garima has quit IRC
|
09:39:11
|
*** lh has quit IRC
|
09:42:37
|
*** lh has joined #openmrs
|
09:42:37
|
*** lh has joined #openmrs
|
10:09:11
|
*** rajith has quit IRC
|
10:41:22
|
<Anuruddha_> sunbiz: hi!
|
10:42:08
|
<Anuruddha_> sunbiz: Are there any additional resources on "Patient Narrative Uploads" idea
|
11:07:34
|
*** dkayiwa has joined #openmrs
|
11:21:25
|
*** dkayiwa_ has joined #openmrs
|
11:22:12
|
*** dkayiwa has quit IRC
|
11:22:13
|
*** dkayiwa_ is now known as dkayiwa
|
11:24:37
|
*** rajith has joined #openmrs
|
11:37:14
|
*** Dimuthu_Upeksha has joined #openmrs
|
12:05:53
|
*** harsz89 has quit IRC
|
12:10:15
|
*** Dimuthu123 has joined #openmrs
|
12:14:41
|
*** Dimuthu_Upeksha has quit IRC
|
12:16:42
|
*** Dimuthu123 has quit IRC
|
12:18:01
|
*** harsz89 has joined #openmrs
|
12:20:16
|
*** dkayiwa has quit IRC
|
12:22:04
|
*** khayamuddin31 has joined #openmrs
|
12:27:54
|
*** dkayiwa has joined #openmrs
|
12:31:18
|
*** khayamuddin31 has quit IRC
|
12:42:57
|
*** shangxiao has quit IRC
|
12:43:30
|
*** shangxiao has joined #openmrs
|
12:44:06
|
*** shangxiao has quit IRC
|
12:54:39
|
*** k-joseph has joined #openmrs
|
13:09:52
|
*** Anuruddha__ has joined #openmrs
|
13:13:00
|
*** Anuruddha_ has quit IRC
|
13:14:07
|
*** k-joseph has quit IRC
|
13:14:48
|
*** bhashitha has joined #openmrs
|
13:26:27
|
*** k-joseph has joined #openmrs
|
15:05:02
|
*** draggonz has quit IRC
|
15:08:30
|
<k-joseph> dkayiwa: hi
|
15:08:43
|
<dkayiwa> k-joseph: hi
|
15:12:24
|
*** 66MAAIE5D has joined #openmrs
|
15:16:07
|
*** dkayiwa has quit IRC
|
15:16:22
|
*** lh has quit IRC
|
15:17:13
|
*** dkayiwa has joined #openmrs
|
15:18:34
|
*** lh has joined #openmrs
|
15:18:34
|
*** lh has joined #openmrs
|
15:21:01
|
*** shangxiao has joined #openmrs
|
16:41:10
|
*** draggonz has joined #openmrs
|
16:47:02
|
*** dkayiwa has quit IRC
|
16:47:39
|
*** djazayeri has joined #openmrs
|
16:47:39
|
*** ChanServ sets mode: +o djazayeri
|
16:50:54
|
*** dkayiwa has joined #openmrs
|
17:15:42
|
*** rajith has quit IRC
|
17:23:17
|
*** Anuruddha__ has quit IRC
|
17:24:46
|
*** bhashitha has quit IRC
|
17:28:00
|
*** shangxiao has quit IRC
|
17:28:44
|
*** k-joseph has quit IRC
|
17:49:52
|
*** dkayiwa has quit IRC
|
17:52:19
|
*** k-joseph has joined #openmrs
|
18:05:10
|
*** harsz89 has quit IRC
|
18:09:12
|
*** h3llborn has joined #openmrs
|
18:12:32
|
<h3llborn> djazayeri: hey
|
18:17:15
|
*** marleau has quit IRC
|
18:27:41
|
*** harsz89 has joined #openmrs
|
18:28:48
|
*** draggonz has quit IRC
|
18:32:15
|
*** garima has joined #openmrs
|
18:34:20
|
<k-joseph> :)
|
18:44:12
|
*** k-joseph has quit IRC
|
18:47:47
|
*** k-joseph has joined #openmrs
|
18:49:49
|
*** yony258 has joined #openmrs
|
18:50:58
|
<yony258> Hi, Can a team release a module that is undergoing development as v0.2
|
18:51:00
|
<yony258> (?
|
18:51:26
|
<yony258> * The module is planned to be fully completed in under 2 months (v1.0)
|
18:52:59
|
*** k-joseph has quit IRC
|
18:55:13
|
<h3llborn> yony258: did you develop it?
|
18:55:39
|
<yony258> h3llborn: Yes
|
18:56:20
|
<h3llborn> youd have to ask djazayeri or burke
|
18:56:24
|
<h3llborn> they would know more tbh
|
18:57:01
|
<yony258> h3llborn: Thanks
|
18:57:14
|
<djazayeri> yony258: hey, you're talking about the appointments module?
|
18:57:24
|
<yony258> djazayeri: Yea
|
18:57:56
|
<djazayeri> yony258: Generally speaking we're happy to see you all do releases as frequently as you feel comfortable with.
|
18:58:35
|
<djazayeri> yony258: And generally speaking, lots of incremental releases are better for the "customer" than infrequent major ones that require more work to deploy.
|
18:59:13
|
*** garima has quit IRC
|
18:59:40
|
<yony258> djazayeri: Great, we are still trying to figure out how exactly a release is done (been reading on the wiki).
|
19:00:03
|
<yony258> djazayeri: Hopefully we will release v0.2 soon, Thanks
|
19:00:45
|
<djazayeri> yony258: I don't know if we have any good wiki pages like a HOWTO for releasing modules. If you wanted to create one (or improve an existing one) that'd be cool
|
19:01:31
|
<djazayeri> yony258: generally, though, it's (1) release to maven, typically using mvn release:prepare, mvn release:perform, (2) release to the OpenMRS module repository, (3) describe the release on a wiki page, (4) email the lists.
|
19:01:38
|
<yony258> djazayeri: Is that (https://wiki.openmrs.org/display/docs/Module+Tagging+and+Releasing) considered outdated?
|
19:02:49
|
*** k-joseph has joined #openmrs
|
19:10:16
|
*** k-joseph has quit IRC
|
19:15:54
|
*** dkayiwa has joined #openmrs
|
19:17:00
|
*** harsz89 has quit IRC
|
19:17:34
|
*** k-joseph has joined #openmrs
|
19:23:01
|
<yony258> dkayiwa: Hi!
|
19:23:08
|
<dkayiwa> yony258: hi
|
19:23:18
|
*** k-joseph has quit IRC
|
19:23:21
|
<yony258> dkayiwa: How are you? it's been a long time :)
|
19:23:47
|
<dkayiwa> yony258: doing great
|
19:23:50
|
<dkayiwa> yes long time
|
19:23:55
|
<dkayiwa> yony258: wazup :)
|
19:24:00
|
<djazayeri> yony258: oh, yes, that page should still be good
|
19:24:13
|
<yony258> djazayeri: Great thanks :)
|
19:24:38
|
<yony258> dkayiwa: Good Good, been planning on releasing current version to the community
|
19:24:55
|
<dkayiwa> yony258: that will be great!!!
|
19:25:13
|
<yony258> dkayiwa: Its been working pretty good in an implementation (here in Tel-Aviv, Israel) for the last couple of months
|
19:26:22
|
<yony258> dkayiwa: I wanted to ask if you are still willing to do code-reviews or are you overloaded with work and we should ask someone else?
|
19:26:27
|
*** nimby has joined #openmrs
|
19:26:57
|
<dkayiwa> like how many code reviews?
|
19:27:01
|
<dkayiwa> yony258:
|
19:28:28
|
<yony258> dkayiwa: Hmm right now there are 2, potentially 4 (really small code parts) but for the next 2 months (until releasing 1.0) we are planning to add 2 more features (Visualization & Privileges)
|
19:29:17
|
<yony258> dkayiwa: By "Visualization" I mean like generation a printable report of Appointment-Blocks that will be easier to handle in comparison to the tables.
|
19:29:27
|
<yony258> *generating
|
19:30:36
|
<yony258> dkayiwa: Right now we have 2 tickets (v0.2) that are pending for review (AM-57 and AM-65)
|
19:30:41
|
<yony258> !ticket AM-57
|
19:30:43
|
<OpenMRSBot> yony258: [#AM-57] Deleting a block cancels appointments that have already happened - OpenMRS JIRA - https://tickets.openmrs.org/browse/AM-57
|
19:30:49
|
<yony258> !ticket AM-65
|
19:30:51
|
<OpenMRSBot> yony258: [#AM-65] Appointment types in widget on Add Block form should be alphabetized - OpenMRS JIRA - https://tickets.openmrs.org/browse/AM-65
|
19:30:59
|
<dkayiwa> yony258: and when is the deadline?
|
19:31:23
|
<yony258> dkayiwa: We want to release v0.2 during next week
|
19:32:16
|
<yony258> dkayiwa: AM-65 is like 15~25 lines of code
|
19:32:28
|
<dkayiwa> yony258: and the other one?
|
19:32:47
|
<yony258> dkayiwa: Im not sure, Adam was working on it.
|
19:32:53
|
*** k-joseph has joined #openmrs
|
19:33:18
|
<yony258> dkayiwa: 120~
|
19:33:36
|
<dkayiwa> yony258: oh thats huge
|
19:33:53
|
<yony258> dkayiwa: :)
|
19:34:08
|
<yony258> dkayiwa: Well feel free to say you are too occupied, you
|
19:34:21
|
<yony258> dkayiwa: you've been contributing plenty to our project :D
|
19:35:22
|
<dkayiwa> yony258: you guys did all the coding :)
|
19:39:54
|
<yony258> dkayiwa: So do you think you'll be able to review our work or do you recommend that we will ask someone else? :)
|
19:40:44
|
<dkayiwa> yony258: you can ask some one in the meantime. but if you fail to get any, you can fall back on me :)
|
19:41:45
|
<yony258> dkayiwa: Great ;) Thank you!, if you find some spare time feel free to review AM-65 (the 15~20 lines) ;)
|
19:41:51
|
<yony258> dkayiwa: And again, thanks for your help.
|
19:41:57
|
<dkayiwa> yony258: 8)
|
19:42:58
|
<k-joseph> dkayiwa: hi, this is smy testcase http://pastebin.com/3yiwWfcV
|
19:43:14
|
<dkayiwa> k-joseph: does it pass?
|
19:44:04
|
<k-joseph> it does
|
19:44:07
|
<k-joseph> dkayiwa: it does
|
19:44:28
|
<dkayiwa> k-joseph: why do you have try catch handlers there?
|
19:46:01
|
<k-joseph> dkayiwa: i have used that way to go around nullpointerexception, else
|
19:46:21
|
<dkayiwa> k-joseph: then that means you test is not passing
|
19:46:33
|
<dkayiwa> k-joseph: you should not have those try catch handlers
|
19:46:59
|
<dkayiwa> k-joseph: you need to fix the null pointer exception
|
19:48:27
|
<k-joseph> dkayiwa: was adopting error handling, you mean it is not appricable when writting a unittest ?
|
19:48:47
|
<k-joseph> appricable == applicable
|
19:49:11
|
<dkayiwa> k-joseph: you need to fix the null pointer exception instead of hiding it in a try catch handlers
|
19:49:25
|
<dkayiwa> k-joseph: do you see them in other existing unit tests?
|
19:52:34
|
*** dkayiwa_ has joined #openmrs
|
19:52:37
|
*** yony258 has quit IRC
|
19:55:32
|
*** k-joseph has quit IRC
|
19:56:07
|
*** k-joseph has joined #openmrs
|
19:56:09
|
*** dkayiwa has quit IRC
|
19:56:10
|
*** dkayiwa_ is now known as dkayiwa
|
20:00:26
|
*** robbyoconnor has quit IRC
|
20:01:15
|
*** k-joseph has quit IRC
|
20:18:55
|
*** robbyoconnor has joined #openmrs
|
20:18:55
|
*** ChanServ sets mode: +v robbyoconnor
|
20:38:48
|
*** h3llborn has quit IRC
|
20:43:12
|
*** dkayiwa has quit IRC
|
20:50:33
|
*** dkayiwa has joined #openmrs
|
21:42:31
|
*** dkayiwa has quit IRC
|
22:53:54
|
*** lh has quit IRC
|
23:06:31
|
*** lh has joined #openmrs
|
23:08:44
|
*** 66MAAIE5D has quit IRC
|
23:15:20
|
*** djazayeri has quit IRC
|
23:21:05
|
*** djazayeri has joined #openmrs
|
23:21:05
|
*** ChanServ sets mode: +o djazayeri
|