| 00:35:56 | *** lh has quit IRC |
| 00:38:25 | *** cospih has quit IRC |
| 00:45:27 | *** lh has joined #openmrs |
| 00:45:27 | *** lh has joined #openmrs |
| 00:50:48 | *** Upeksha has joined #openmrs |
| 01:02:21 | *** Upeksha has quit IRC |
| 01:39:43 | *** jb360 has joined #openmrs |
| 01:42:55 | *** rajith has joined #openmrs |
| 01:52:32 | *** harsz89 has quit IRC |
| 01:54:43 | *** rajith has quit IRC |
| 02:14:43 | *** mario_ has quit IRC |
| 02:26:29 | *** r0bby has joined #openmrs |
| 02:26:29 | *** ChanServ sets mode: +v r0bby |
| 03:06:17 | *** djazayeri has joined #openmrs |
| 03:06:17 | *** ChanServ sets mode: +o djazayeri |
| 03:06:53 | *** nyoman has joined #openmrs |
| 03:08:36 | *** h3llborn has joined #openmrs |
| 03:17:17 | *** h3llborn has quit IRC |
| 03:18:11 | *** djazayeri1 has joined #openmrs |
| 03:19:18 | *** r0bby has quit IRC |
| 03:19:36 | *** jb360 has quit IRC |
| 03:19:38 | *** h3llborn has joined #openmrs |
| 03:20:53 | *** djazayeri has quit IRC |
| 03:47:28 | *** khayamuddin31 has joined #openmrs |
| 03:49:14 | *** khayamuddin31 is now known as khayam |
| 03:50:13 | *** shangxiao has joined #openmrs |
| 03:53:07 | <khayam> hi all can anyone tells whether i have implemented correctly or not at introductory ticket https://tickets.openmrs.org/browse/TRUNK-3094 thanks! |
| 03:53:43 | *** harsz89 has joined #openmrs |
| 04:00:52 | *** khayam has quit IRC |
| 04:08:55 | *** 64MACX7KU has joined #openmrs |
| 04:09:33 | *** h3llborn has quit IRC |
| 04:10:10 | *** r0bby has joined #openmrs |
| 04:10:10 | *** ChanServ sets mode: +v r0bby |
| 04:12:02 | *** kavuri has joined #openmrs |
| 04:12:59 | *** djazayeri has joined #openmrs |
| 04:12:59 | *** ChanServ sets mode: +o djazayeri |
| 04:14:18 | *** r0bby_ has joined #openmrs |
| 04:14:18 | *** ChanServ sets mode: +v r0bby_ |
| 04:14:30 | *** djazayeri1 has quit IRC |
| 04:16:31 | *** h3llborn has joined #openmrs |
| 04:16:32 | *** r0bby has quit IRC |
| 04:27:06 | *** djazayeri has quit IRC |
| 04:30:06 | *** h3llborn has quit IRC |
| 04:34:41 | *** 64MACX7KU has quit IRC |
| 04:57:34 | *** joeseff has joined #openmrs |
| 04:57:39 | *** draggonz has joined #openmrs |
| 05:00:18 | *** shangxiao has quit IRC |
| 05:00:36 | *** harshadura has joined #openmrs |
| 05:30:01 | *** lh has quit IRC |
| 05:30:22 | *** djazayeri has joined #openmrs |
| 05:30:22 | *** ChanServ sets mode: +o djazayeri |
| 05:41:46 | *** rajith has joined #openmrs |
| 05:54:43 | *** Hasintha_i has joined #openmrs |
| 06:03:23 | *** draggonz has quit IRC |
| 06:04:21 | *** harshadura has quit IRC |
| 06:35:29 | *** jordank has joined #openmrs |
| 06:44:07 | *** jordank has quit IRC |
| 06:47:12 | *** nimby has quit IRC |
| 06:53:00 | *** Dimuthu_Upeksha has joined #openmrs |
| 07:04:34 | *** Hasintha_i has quit IRC |
| 07:20:21 | *** sagar has joined #openmrs |
| 07:21:42 | <sagar> djazayeri: hi |
| 07:36:23 | *** rkorytkowski has joined #openmrs |
| 07:36:23 | *** rkorytkowski is now known as rafa |
| 07:36:23 | *** ChanServ sets mode: +v rafa |
| 07:52:57 | *** rajith has quit IRC |
| 08:04:49 | *** dkayiwa has joined #openmrs |
| 08:05:33 | <joeseff> dkayiwa: hi |
| 08:05:42 | <dkayiwa> joeseff: hi |
| 08:07:40 | <joeseff> dkayiwa: You were right, changing the class of the grouping concepts back to "Question" did not affect the forms, the data was still saved properly when the form was submitted. I am quite puzzled as to why they originally did not function as required |
| 08:09:47 | <dkayiwa> joeseff: i knew!!! :) |
| 08:10:07 | <joeseff> dkayiwa: :) I continue to learn... |
| 08:19:05 | *** djazayeri has quit IRC |
| 08:29:54 | *** joeseff has quit IRC |
| 08:55:02 | *** harsz89 has quit IRC |
| 09:03:12 | *** dkayiwa has quit IRC |
| 09:03:53 | *** harshadura has joined #openmrs |
| 09:06:34 | *** dkayiwa has joined #openmrs |
| 09:11:11 | *** rajith has joined #openmrs |
| 09:23:17 | *** rajith has quit IRC |
| 09:25:41 | *** Dimuthu_Upeksha has quit IRC |
| 09:28:33 | *** test__ has joined #openmrs |
| 09:32:12 | *** test__ has quit IRC |
| 09:40:16 | *** rajith has joined #openmrs |
| 10:23:09 | *** rajith has quit IRC |
| 10:35:25 | *** dkayiwa has quit IRC |
| 10:36:40 | *** dammina_ has joined #openmrs |
| 11:13:08 | *** dkayiwa has joined #openmrs |
| 11:29:44 | *** harsz89 has joined #openmrs |
| 11:36:12 | *** harshadura_ has joined #openmrs |
| 11:39:11 | *** harshadura has quit IRC |
| 11:51:47 | *** davidpardz has joined #openmrs |
| 12:08:17 | *** nyoman has quit IRC |
| 12:08:23 | *** kavuri has quit IRC |
| 12:10:57 | *** r0bby_ has quit IRC |
| 12:13:20 | *** sagar has quit IRC |
| 12:29:49 | *** wyclif has quit IRC |
| 12:38:18 | <dkayiwa> hi rafa |
| 12:40:03 | <rafa> dkayiwa: hi |
| 12:40:16 | *** shangxiao has joined #openmrs |
| 12:40:32 | <dkayiwa> rafa: do you know how i can change the repository that this points to without deleting and creating a new one? https://ci-stg.openmrs.org/browse/UICM-UICOMMONS |
| 12:40:52 | <rafa> yes |
| 12:41:03 | <shangxiao> hi rafa |
| 12:41:08 | <dkayiwa> rafa: do you mind sharing? :) |
| 12:41:10 | <shangxiao> thanks for your bug reports ;) |
| 12:41:31 | <rafa> go to actions -> configure plan -> source repositories -> git |
| 12:41:41 | <dkayiwa> rafa: ok |
| 12:42:02 | <rafa> shangxiao: It's my pleasure :) |
| 12:42:40 | <shangxiao> rafa: Were you able to actually get a proposal to be submitted in the end? |
| 12:42:48 | <rafa> shangxiao: yes |
| 12:42:55 | <shangxiao> I mainly just wanted to see if the workflow and screens were correct |
| 12:42:56 | <rafa> shangxiao: but couldn't preview it on the server side |
| 12:43:16 | <shangxiao> there are quite a few bugs that we know about but wanted to confirm the requirements first |
| 12:43:21 | *** cospih has joined #openmrs |
| 12:43:33 | <rafa> shangxiao: I mean the server where it was sent |
| 12:43:33 | *** Dimuthu_Upeksha has joined #openmrs |
| 12:44:16 | <shangxiao> did you try just submitting to localhost? |
| 12:44:40 | <rafa> shangxiao: yes, I think it made it through to the central server |
| 12:44:50 | <rafa> shangxiao: I just can't display it there |
| 12:44:55 | <rafa> shangxiao: because of NPE |
| 12:45:06 | <rafa> shangxiao: but on the sending side it says submitted |
| 12:45:28 | <rafa> shangxiao: and I saw some action in logs that it made it through to the central server |
| 12:46:15 | <shangxiao> hm that's funny because I tried it out before I added the module to the repository and I wasn't getting an NPE :( |
| 12:47:00 | <rafa> shangxiao: I haven't filled up all fields on the concept proposal form, just the required ones... |
| 12:47:45 | <rafa> shangxiao: maybe I tried to send a too complex concept... |
| 12:47:56 | <rafa> shangxiao: there can be many reasons I guess :) |
| 12:48:01 | *** jkeiper_ has joined #openmrs |
| 12:48:17 | <rafa> shangxiao: I haven't had a chance to look at code yet |
| 12:48:37 | <rafa> shangxiao: but NPEs are usually easy to fix :) |
| 12:48:40 | <shangxiao> ah yes one of the guys submitted a pull request for an NPE related to description |
| 12:48:50 | <shangxiao> description must be filled out |
| 12:49:13 | <rafa> shangxiao: ok, then I can try again :) |
| 12:49:41 | <shangxiao> rafa: so the million dollar question is whether we are on the right track with the required functionality |
| 12:50:48 | <rafa> shangxiao: You definitely are on the right track |
| 12:51:04 | <shangxiao> awesome |
| 12:51:27 | <rafa> shangxiao: I need to look under the hood yet |
| 12:51:39 | <rafa> shangxiao: see how you transfer and store proposed concepts |
| 12:52:30 | <shangxiao> according to Darius' mockups he was indicating that central will need to create them manually for now |
| 12:53:29 | <rafa> shangxiao: yeah I need to see that part of the workflow :) |
| 12:53:34 | *** nyoman has joined #openmrs |
| 12:55:58 | <shangxiao> so we don't actually create a concept - the proposal is marked as created then you would select the concept that was created |
| 12:59:34 | <shangxiao> ok I see where you're getting the NPE - if there are no names in a concept |
| 13:00:32 | <shangxiao> same for descriptions - I'm iterating directly over a field that looks like it's null |
| 13:02:33 | *** harshadura_ is now known as harshadura |
| 13:03:01 | *** ChanServ sets mode: +v harshadura |
| 13:04:06 | *** djazayeri has joined #openmrs |
| 13:04:06 | *** ChanServ sets mode: +o djazayeri |
| 13:09:53 | *** rajiths has joined #openmrs |
| 13:10:08 | *** portablejim has joined #openmrs |
| 13:10:08 | *** portablejim has joined #openmrs |
| 13:11:25 | *** wyclif has joined #openmrs |
| 13:11:39 | *** rajiths has quit IRC |
| 13:12:01 | *** rajiths has joined #openmrs |
| 13:15:18 | <shangxiao> It's really annoying having to check if an ArrayList is null before iterating over it - what is a common design pattern that Java developers use to get around doing this all the time? |
| 13:15:58 | *** mogoodrich has joined #openmrs |
| 13:16:26 | <mogoodrich> dkayiwa: did you see that it looks like your commit to the emr api module broke the emr module build? |
| 13:16:41 | <dkayiwa> mogoodrich: checking |
| 13:16:56 | <mogoodrich> dkayiwa: cool, no worries, just wanted to make sure you knew... |
| 13:17:13 | <dkayiwa> mogoodrich: thanks for i did not know :) |
| 13:18:11 | <mogoodrich> dkayiwa: cool... is the emr module built anywhere in the general openmrs ci? (if not, bamboo.pih-emr.org:8085 is a good place keep an eye on... |
| 13:18:23 | *** pponakala has joined #openmrs |
| 13:19:24 | <shangxiao> does anyone use Google Guava ? |
| 13:19:56 | <dkayiwa> mogoodrich: ok |
| 13:21:12 | <mogoodrich> rafa: still no ideas on that pesky META-329 bug? |
| 13:27:39 | *** sgithens has quit IRC |
| 13:29:29 | <portablejim> Is there any documentation available on how modules are installed or uninstalled? |
| 13:34:41 | <portablejim> Specifically if a liquibase rollback is done for uninstallation? |
| 13:37:07 | *** downey has joined #openmrs |
| 13:37:07 | *** ChanServ sets mode: +o downey |
| 13:39:21 | *** tbharath has joined #openmrs |
| 13:42:57 | <tbharath> can anyone provide a link on how to use openmrs REST api , especially how to update patient's details? |
| 13:43:35 | <downey> tbharath: Have you seen https://wiki.openmrs.org/display/docs/REST+Web+Services+API ? |
| 13:43:36 | <OpenMRSBot> <http://ln-s.net/8zTB> (at wiki.openmrs.org) |
| 13:46:39 | <tbharath> downey, I want to edit patient details , so according to the link provided by you it should be in this format /ws/rest/v1/allergy/{uuid} |
| 13:47:32 | *** pponakala has quit IRC |
| 13:47:46 | <tbharath> downey, but I got this error "Unable to convert object into response content" |
| 13:51:58 | <tbharath> downey, can you help me regarding this issue? |
| 13:53:54 | <djazayeri> tbharath: can you clarify what REST call you are making? |
| 13:56:00 | <nyoman> portablejim, the liquibase changelog will not get rolled back during uninstall |
| 13:56:10 | <harsz89> tbharath, you also can get a idea by looking at tests of rest module specially you may look at patient controller test :) |
| 13:57:15 | <tbharath> djazayeri, http://imagebin.org/252890 |
| 13:57:33 | <tbharath> djazayeri, I have used Postman chrome app to send POST request |
| 13:58:28 | <tbharath> harsz89, where can I find that test |
| 13:59:32 | *** rafa has quit IRC |
| 14:00:15 | <harsz89> tbharath, it's in under rest module test classes.just search through your IDE :) |
| 14:02:06 | *** davidpardz has quit IRC |
| 14:03:23 | *** andreapat has joined #openmrs |
| 14:04:22 | <harsz89> hi djazayeri |
| 14:04:38 | <djazayeri> tbharath: the error is contained there as "detail": Content type 'multipart/form-data;boundary==---" is not supported |
| 14:04:39 | <harsz89> i'm making a curl request to create a person |
| 14:04:54 | <harsz89> djazayeri, curl -v -u admin:test -H "Accept: application/json" -H "Content-type: application/json" -H -X POST -d '{ "names": [{ "givenName":"Helen", "familyName":"of Troy" }, {"givenName":"Leda", "familyName":"Nemesis"} ], "birthdate":"2003-01-01", "gender":"F" }' http://localhost:8081/openmrs/ws/rest/v1/person |
| 14:04:59 | <djazayeri> tbharath: I don't know if Postman is doing something wrong, or our request parsing is wrong... |
| 14:05:12 | <harsz89> djazayeri, but it return with bad request.:( |
| 14:05:24 | <harsz89> djazayeri, is something missing in my above request |
| 14:05:29 | <harsz89> djazayeri, :) |
| 14:05:36 | *** Anuruddha has joined #openmrs |
| 14:05:44 | <djazayeri> harsz89: what's the complete error message? |
| 14:06:18 | *** cpower_ has joined #openmrs |
| 14:06:53 | <cpower_> good morning! Scrum time started? |
| 14:06:58 | <tbharath> djazayeri, I didn't get you |
| 14:07:06 | <djazayeri> cpower: we were waiting for you |
| 14:07:10 | <cpower_> !scrumon cpower |
| 14:07:10 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 14:08:05 | <cpower_> Order: djazayeri, mseaton, andreapat, dkayiwa, wyclif, and anyone else who wants to talk about what tickets they've worked on in the past 24hrs |
| 14:08:18 | <djazayeri> * Spent most of my time on calls for the last 2 days |
| 14:08:18 | <djazayeri> * Working on RA-36 (Refactoring PIH's EMR module into a new OpenMRS EMR API module)...this is a huge ticket, and has been snowballing. :-( |
| 14:08:19 | <djazayeri> no blockers |
| 14:08:33 | <djazayeri> (today: more of RA-36, less calls) |
| 14:08:44 | *** Dimuthu123 has joined #openmrs |
| 14:09:03 | *** Dimuthu_Upeksha has quit IRC |
| 14:09:13 | *** sgithens has joined #openmrs |
| 14:10:18 | <djazayeri> next: mseaton |
| 14:10:31 | <mseaton> pass. no blockers. |
| 14:10:41 | <andreapat> Thursday afternoon |
| 14:10:41 | <andreapat> Ticket TRUNK-3751 |
| 14:10:41 | <andreapat> Saying that a module requires OpenMRS 1.9.2-SNAPSHOT fails |
| 14:10:41 | <andreapat> Copied Version.java and VersionTest.java from MDS module to core |
| 14:10:41 | <andreapat> Replaced code in compareVersion to call new code |
| 14:10:43 | <andreapat> Friday |
| 14:10:45 | <andreapat> Ticket TRUNK-3751 |
| 14:10:47 | <andreapat> Still not parsing SNAPSHOT correctly and not handling ranges correctly |
| 14:10:49 | <andreapat> Put code in ModuleUtil.checkRequiredVersion to do this |
| 14:10:51 | <andreapat> Fix Failing 9 tests |
| 14:10:53 | <andreapat> Pick new ticket |
| 14:10:55 | <andreapat> No Blockers |
| 14:10:57 | <andreapat> but maybe Discussion re above |
| 14:11:27 | <dkayiwa> Committed: Create a reusable module containing utility functions - RA-22 |
| 14:11:28 | <dkayiwa> Responded to review comments for: Set up CI plan for logic module - RA-32 |
| 14:11:28 | <dkayiwa> Responded to review comments for: Set up CI plan for uicommons module - RA-26 |
| 14:11:28 | <dkayiwa> No Blockers |
| 14:12:21 | <wyclif> .dashboard |
| 14:12:31 | <wyclif> sorry |
| 14:12:32 | <wyclif> Thursday: |
| 14:12:32 | <wyclif> -dev call |
| 14:12:32 | <wyclif> -Google hangout with sprinters |
| 14:12:32 | <wyclif> -RA-37 - Create core apps module including a CI plan for it |
| 14:12:32 | <wyclif> Friday: |
| 14:12:34 | <wyclif> -Google hangout with sprinters |
| 14:12:36 | <wyclif> -Continue with RA-37 - Spike on refactoring Mirebalais codebase to use new App Framework module |
| 14:12:38 | <wyclif> |
| 14:12:40 | <wyclif> Blockers: None |
| 14:18:08 | *** dkayiwa_ has joined #openmrs |
| 14:18:09 | *** dkayiwa has quit IRC |
| 14:18:10 | *** dkayiwa_ is now known as dkayiwa |
| 14:19:37 | <cpower_> Good deal! |
| 14:19:49 | <cpower_> No blockers |
| 14:20:28 | <cpower_> Discussion points: 9 failing tests, and not parsing the snapshot with andreapat |
| 14:20:41 | <andreapat> cpower, yes |
| 14:20:42 | <djazayeri> dkayiwa: hey, also, the mirebalais EMR build is still broekn |
| 14:21:06 | <djazayeri> dkayiwa: errors are like http://bamboo.pih-emr.org:8085/browse/MIREBALAIS-EMR-JOB1-709/test/case/15826975 |
| 14:21:09 | <OpenMRSBot> <http://ln-s.net/+xPV> (at bamboo.pih-emr.org:8085) |
| 14:21:23 | <andreapat> wyclif, djazayeri did you see my email? Does the new code handle ranges of versions? |
| 14:21:50 | <djazayeri> andreapat: if you look at that code, you'll see that it just handles a single version, and comparing it to other versions |
| 14:22:08 | <djazayeri> andreapat: so I guess my offhand comment yesterday about new Version(a).compareTo(new Version(b)) is not sufficient |
| 14:22:22 | <djazayeri> andreapat: you have to preserve the existing behavior as described by those unit tests, and the javadoc |
| 14:22:37 | <djazayeri> i.e. requireVersion can say "1.8.0-1.8.2" or things like that. |
| 14:23:06 | <andreapat> djazayeri, yes needs to parse ranges and standalone differently - |
| 14:23:39 | <dkayiwa> djazayeri: looks like am going to change in the emrapi from <scope>provided</scope> for metadatasharing-api |
| 14:23:50 | <andreapat> djazayeri, that's in checkRequiredVersion |
| 14:24:17 | <djazayeri> dkayiwa: I think the fix is to add ImportedPackage to test-hibernate.cfg.xml in the emr module |
| 14:24:31 | <dkayiwa> djazayeri: ok |
| 14:24:32 | <djazayeri> dkayiwa: can check out the emr module (github/PIH/openmrs-module-emr) make that change, and see if it builds then? |
| 14:24:42 | <dkayiwa> djazayeri: ok |
| 14:25:14 | <andreapat> djazayeri, should I remove the MDS code? |
| 14:25:22 | *** skyler has joined #openmrs |
| 14:26:21 | <andreapat> djazayeri, seems like my original code was on the right track - to handle parsing SNAPSHOT |
| 14:26:39 | *** skyler has quit IRC |
| 14:27:00 | <djazayeri> andreapat: it looks like, since checkRequiredVersions is already splitting on "-", you need to deal with the case that it might conceivably say "1.8.0-1.8.3-SNAPSHOT |
| 14:27:48 | <djazayeri> andreapat: I would think that the MDS code might still be useful, but you first need to figure out how to fix checkRequiredVersion across all the multiple possible uses of "-" |
| 14:28:52 | <andreapat> djazayeri, yes - didn't realize SNAPSHOT could be a range too |
| 14:29:05 | <djazayeri> andreapat: well, -SNAPSHOT isn't a range. |
| 14:30:00 | <andreapat> djazayeri: but you are saying "1.8.0-1.8.3-SNAPSHOT" is possible, correct? |
| 14:30:04 | <djazayeri> andreapat: maybe you can assume that if it's a dash followed by an alphabetic character, that means it's part of the version number |
| 14:30:06 | <djazayeri> andreapat: yes |
| 14:30:18 | <djazayeri> !scrumoff |
| 14:30:18 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:30:44 | <djazayeri> harsz89: I don't know what's wrong with that request offhand, sorry. |
| 14:30:57 | <andreapat> djazayeri, good idea |
| 14:31:44 | <djazayeri> harsz89: if it's possible for you to run the server under the debugger, and put a breakpoint to see what happening, that's what I'd do |
| 14:32:00 | <harsz89> djazayeri, thank you djazayeri |
| 14:32:16 | <harsz89> djazayeri, i'll do that way :) |
| 14:32:27 | <portablejim> Is there any way to have code run that hooks into the api that is run once when a module is installed? |
| 14:32:47 | <andreapat> djazayeri, should I remove MDS code and just fix parsing problem? |
| 14:33:45 | <djazayeri> tbharath: the error message says HttpMediaTypeNotSupportedException: Content type 'multipart/form-data;boundary=âWebKitFormBoundaryâ¦' not supported |
| 14:33:47 | *** breeze has joined #openmrs |
| 14:34:28 | <djazayeri> tbharath: my guess is that whatever chrome plugin you're using is sending some strange non-standard content-type, and our code doesn't handle it |
| 14:35:16 | <djazayeri> tbharath: I suggest trying a different client first, e.g. just curl at the command line, and see if you can get that to work first. |
| 14:35:37 | *** nyoman has quit IRC |
| 14:35:40 | <djazayeri> portablejim: https://wiki.openmrs.org/x/VQ8z |
| 14:35:45 | <djazayeri> portablejim: ModuleActivator |
| 14:37:27 | <djazayeri> andreapat: I think that first you need to fix ModuleUtil.checkRequiredVersion so it doesn't blindly split on "-", but so it instead (possibly using a regular expression) checks for a dash that doesn't have an alpha char after it. |
| 14:37:37 | <tbharath> djazayeri, I have tried this curl -X POST http://raxa.io:8080/openmrs/ws/rest/v1/patient/e73b715a-17bc-4a7a-b25f-c1598aeed398 --header "Content-Type:application/json" |
| 14:37:43 | <OpenMRSBot> <http://ln-s.net/+xPw> (at raxa.io:8080) |
| 14:37:46 | <tbharath> djazayeri, same error |
| 14:38:08 | <portablejim> djazayeri, Is there something for install. I was just looking in there and there were startup hooks. So I will need to have an "install checks,etc done" value in the database that I check each startup? |
| 14:38:23 | <harsz89> hi djazayeri it work with apache tomcat :D |
| 14:38:26 | <andreapat> djazayeri, will do that |
| 14:38:37 | *** nyoman has joined #openmrs |
| 14:38:38 | <djazayeri> andreapat: once you have the version, or version range, you might still want to use the MDS version of version comparison |
| 14:38:42 | <harsz89> djazayeri, but in standalone server not work |
| 14:38:49 | <harsz89> djazayeri, thanks for the help :) |
| 14:38:51 | <andreapat> djazayeri: my original code: if ((value.indexOf("*") > 0 || value.indexOf(separator) > 0) |
| 14:38:52 | <andreapat> && (!StringUtils.containsIgnoreCase(value, snapshot))) { |
| 14:40:13 | <djazayeri> portablejim: not exactly what you're looking for but how about https://wiki.openmrs.org/x/6RAz (you can put a liquibase.xml file in your module) |
| 14:40:17 | <andreapat> djazayeri, won't work if a range - but seems with MDS code it is not working for any range |
| 14:40:35 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Concept Proposal Module 1.0.0-alpha-2-SHA1-92b6146 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=cpm&version=&1.0.0-alpha-2-SHA1-92b6146> |
| 14:40:44 | <andreapat> djazayeri, said that wrong |
| 14:41:22 | <andreapat> djazayeri, seems MDS code is not working for any range - thhta's what failing test are about |
| 14:42:00 | <djazayeri> andreapat: if you look at the MDS code it _obviously_ will not work for a range. It is specifically concerned with parsing and comparing single version numbers. |
| 14:42:53 | <djazayeri> andreapat: what I'm saying is that you may still want to use that MDS code *after* you have split the string into the left side and right side of the range. |
| 14:42:59 | <djazayeri> tbharath: hmm, that's odd |
| 14:43:15 | <andreapat> djazayeri, yes I see that - will try using it for a single version but think that was already handled in original code - just not SNAPSHOT versions |
| 14:44:08 | <djazayeri> tbharath: if you POST via curl, you get an error saying something about --webkit ? That seems unlikely. |
| 14:44:18 | <tbharath> djazayeri, now I changed to "curl -v -H "Accept: application/json" -H "Content-type: application/json" -X POST -d "{'gender':'Male'}" http://raxa.io:8080/openmrs/ws/rest/v1/patient/e73b715a-17bc-4a7a-b25f-c1598aeed398" |
| 14:44:22 | <OpenMRSBot> <http://ln-s.net/+xQ9> (at raxa.io:8080) |
| 14:44:27 | <andreapat> djazayeri, got ya - need to go to office - may ping you later if that's ok |
| 14:44:31 | <tbharath> djazayeri, now it says "user is not logged in" |
| 14:45:06 | <djazayeri> tbharath: scroll up a bit and look at harsz89's example where he passes admin:test to a curl command. |
| 14:47:25 | <tbharath> djazayeri, but same error |
| 14:47:32 | *** shangxiao has quit IRC |
| 14:49:41 | <tbharath> djazayeri, I used curl -v -u admin:test -H "Accept: application/json" -H "Content-type: application/json" -X POST -d "{'gender':'Male'}" http://raxa.io:8080/openmrs/ws/rest/v1/patient/e73b715a-17bc-4a7a-b25f-c1598aeed398 |
| 14:49:42 | <OpenMRSBot> <http://ln-s.net/+xPw> (at raxa.io:8080) |
| 14:52:56 | *** shangxiao has joined #openmrs |
| 14:58:58 | <djazayeri> tbharath: that's assuming that admin/test are legal credentials on your server. |
| 14:59:17 | *** goutham has joined #openmrs |
| 14:59:22 | <tbharath> djazayeri, I changed my credentials there |
| 15:00:05 | <djazayeri> tbharath: and the error is user not logged in? |
| 15:00:12 | <tbharath> djazayeri, yes |
| 15:01:28 | <harsz89> tbharath, try with Admin123 as a password |
| 15:01:53 | <harsz89> tbharath, if you are not using standalone version :) |
| 15:02:16 | *** portablejim has quit IRC |
| 15:02:55 | *** dkayiwa has quit IRC |
| 15:03:23 | <tbharath> djazayeri, harsz89 now I got this error http://pastie.org/7328637 |
| 15:03:31 | *** dkayiwa has joined #openmrs |
| 15:04:02 | <jkeiper_> suranga: you said that PTM has recommendations built in already |
| 15:04:05 | <wyclif> hi andreapat |
| 15:04:27 | <wyclif> what method are editing in module util? |
| 15:04:32 | <jkeiper_> suranga: is that based on just a few calculations, or are all field metrics (statistics) rendered and stored somewhere? |
| 15:04:50 | *** jkeiper_ has quit IRC |
| 15:05:38 | <djazayeri> tbharath: that error message tells you exactly what the problem is⦠you have put ' instead of " |
| 15:05:42 | <wyclif> andreapat, checkReuquiredVersion is the one that does range comparisons, compareVersions is what you need to edit since for it it just compares just 2 versions that are not ranges |
| 15:07:55 | <tbharath> djazayeri, for which one? |
| 15:08:48 | <djazayeri> tbharath: what you're posting is invalid json |
| 15:09:21 | <tbharath> djazayeri, ok now I changed to '{"gender":"Male"}' |
| 15:10:24 | <tbharath> djazayeri, now I get Some properties are not allowed to be set: gender\n\tat org.openmrs.module.webservices.rest.web.resource.impl.BaseDelegatingResource.setConvertedProperties |
| 15:10:57 | *** dkayiwa has quit IRC |
| 15:11:33 | <wyclif> andreapat, djazayeri is correct in away, you should be able to use Version.java but wisely, i think you might be misusing it, checkRequiredVersion delagates to compareVersions somewhere, print some logs and see what it passes to compareVersions, i highly doubt they are ranges still, since it already handles splitting them up |
| 15:13:05 | <tbharath> djazayeri, even I tried name instead of gender |
| 15:14:13 | *** Dimuthu123 has quit IRC |
| 15:14:20 | *** mario_ has joined #openmrs |
| 15:14:30 | <mario_> djazayeri, are we gonna use emr module on the ref app? |
| 15:24:21 | *** cpower_ has quit IRC |
| 15:24:47 | <breeze> wyclif: is there an issue in the referenceapplication module related to checkRequiredVersion right now? |
| 15:25:13 | *** wyclif has quit IRC |
| 15:26:02 | *** 45PAADCIN has joined #openmrs |
| 15:26:09 | <mario_> breeze, yes, there is. There is a ticket to fix that. Also, there is a workaround |
| 15:26:09 | *** goutham has quit IRC |
| 15:26:32 | <breeze> mario_: is the workaround in the ticket? |
| 15:26:45 | <mario_> breeze, i don't know. Let me see |
| 15:28:21 | <mario_> breeze, the ticket is https://tickets.openmrs.org/browse/TRUNK-3751 |
| 15:29:07 | <mario_> breeze, what I did was put this && !value.contains("SNAPSHOT")) on the line 282 of the ModuleUtil |
| 15:29:35 | *** jordank has joined #openmrs |
| 15:29:56 | <breeze> mario_: did you push that change to github, or do you mean just locally? |
| 15:32:52 | *** cpower_ has joined #openmrs |
| 15:33:44 | *** lh has joined #openmrs |
| 15:33:44 | *** lh has joined #openmrs |
| 15:34:17 | *** h3llborn has joined #openmrs |
| 15:34:21 | *** wyclif has joined #openmrs |
| 15:38:09 | <djazayeri> mario_, breeze, wyclif: is there some reason that we can't just change the config.xml file of the referenceapplication module so that instead of saying <requireVersion>${openMRSversion}</requireVersion> |
| 15:38:20 | <djazayeri> instead we say <requireVersion>1.9.3</requireVersion> |
| 15:38:29 | <djazayeri> mario_, breeze, wyclif: ^^ ? |
| 15:39:00 | *** rajiths has quit IRC |
| 15:39:04 | <breeze> djazayeri: I don't see why not |
| 15:39:18 | <tbharath> djazayeri, now I get Some properties are not allowed to be set: gender\n\tat |
| 15:39:22 | *** rajiths has joined #openmrs |
| 15:39:28 | <wyclif> djazayeri, it is fine in development |
| 15:39:41 | <djazayeri> mario_, breeze, wyclif: this would avoid needing a workaround in core code |
| 15:39:47 | *** rajiths has quit IRC |
| 15:40:09 | *** shangxiao has quit IRC |
| 15:40:12 | <wyclif> djazayeri, though that wont solve mario's issue from yesterday |
| 15:40:13 | *** rajiths has joined #openmrs |
| 15:40:14 | <djazayeri> wyclif: I think it's fine in production tooâ¦is there some reason why that module actually needs to require 1.9.4-SNAPSHOT of core anyway? why not just change the required openmrs version to 1.9.3? |
| 15:40:37 | <wyclif> djazayeri, it depends on what you are solving |
| 15:40:57 | <wyclif> djazayeri, if you are trying to get around mario's issue, it doesnt help |
| 15:41:04 | <downey> suranga |
| 15:41:11 | <djazayeri> wyclif: are you sure about that? |
| 15:41:50 | <djazayeri> wyclif: isn't the problem that modules aren't allowed to require a snapshot version of openmrs-core? Therefore the fix is to change the module to require 1.9.3 |
| 15:42:25 | <wyclif> djazayeri, 100% because unless you also change the opemrs version in the pom to 1.9.3 because core will still compare the required version to the current version you are running against which might contain the SNAPSHOT test |
| 15:43:03 | <djazayeri> wyclif: I'm pretty sure that core is successfully able to compare 1.9.3 vs 1.9.4-SNAPSHOT |
| 15:43:06 | <tbharath> djazayeri, which properties I can change? |
| 15:43:10 | <djazayeri> wyclif: we do this all the time |
| 15:43:24 | <djazayeri> tbharath: you should be able to change anything listed here: https://wiki.openmrs.org/display/docs/REST+Web+Service+Resources+in+OpenMRS+1.9#RESTWebServiceResourcesinOpenMRS1.9-Person |
| 15:44:15 | <djazayeri> tbharath: can you make sure things are written and formatted right? |
| 15:44:54 | <wyclif> djazayeri, you can try it |
| 15:45:07 | <wyclif> djazayeri, may be am wrong |
| 15:45:43 | <djazayeri> wyclif: I have been running 1.9.4-SNAPSHOT, with a bunch of Mirebalais modules that require 1.9.3, and that works fine. |
| 15:53:17 | *** h3llborn has quit IRC |
| 15:53:39 | <djazayeri> breeze: is this blocking you now? |
| 15:54:13 | <breeze> djazayeri: yes, but I have other modules I can work with now |
| 15:55:04 | <djazayeri> breeze: I didn't see the original question/comment. Is it just that the referenceapplication module won't start (and complains about version)? |
| 15:56:31 | <breeze> djazayeri: yes, that's the first one I asked about, but I think I'm going to come across issues with other modules as well...testing them out now |
| 16:03:32 | <tbharath> djazayeri, I used this command |
| 16:03:34 | <tbharath> djazayeri, curl -v -u bharath:Hello123 -H "Accept: application/json" -H "Content-type: application/json" -X POST -d '{"gender":"Male"}' http://raxa.io:8080/openmrs/ws/rest/v1/patient/e73b715a-17bc-4a7a-b25f-c1598aeed398 |
| 16:03:35 | <OpenMRSBot> <http://ln-s.net/+xPw> (at raxa.io:8080) |
| 16:06:16 | <breeze> can someone help with with a stack trace I'm getting while trying to start the registrationcore module? |
| 16:07:16 | <breeze> does it have a dependency on the idgen module maybe? |
| 16:07:17 | <breeze> Initialization of bean failed; nested exception is java.lang.NoClassDefFoundError: Lorg/openmrs/module/idgen/IdentifierSource; |
| 16:12:46 | <andreapat> wyclif, you still here? |
| 16:13:18 | <djazayeri> breeze: do you have the idgen module started already? |
| 16:13:43 | <wyclif> andreapat, yeah |
| 16:14:01 | <andreapat> hey wyclif: |
| 16:14:02 | <breeze> djazayeri: no. but tyring that now |
| 16:14:16 | <andreapat> wyclif, stepped away after scrum |
| 16:14:27 | *** suranga__ has joined #openmrs |
| 16:15:21 | <djazayeri> breeze: looks like you've uncovered a bug, that registrationcore is supposed to require idgen, but it doesn't declare this dependency |
| 16:15:34 | <breeze> ok |
| 16:15:55 | <andreapat> wyclif, yes |
| 16:15:55 | <andreapat> checkReuquiredVersion is the one that does range comparisons - |
| 16:16:27 | *** jordank has quit IRC |
| 16:16:29 | <djazayeri> breeze: can you create a ticket for that? (I don't know what the registration core project is called in JIRA unfortunately) |
| 16:16:37 | <djazayeri> jkeiper: probably knows though ^^ |
| 16:16:45 | <breeze> djazayeri: which leads me to my next question. Are we expecting all the modules for the ref app to automatically started ? as opposed to going into the UI to start them as I am now? |
| 16:16:52 | <breeze> djazayeri: sure |
| 16:16:56 | <djazayeri> breeze: yes, we'd expect them to start automatically |
| 16:17:20 | <djazayeri> breeze: usually all modules *do* start automatically, unless you've explicitly stopped one. |
| 16:17:22 | <andreapat> wyclif, think best way to handle ranes and snapshot is to check for snapshot immediately in checkReuquiredVersion |
| 16:17:56 | <djazayeri> breeze: if it starts up and shows all modules stopped, that probably means you can see an error in the logs at startup |
| 16:17:59 | <breeze> djazayeri: ok. they're not for me... |
| 16:18:17 | <andreapat> wyclif, if ther pull "-SNAPSHOT" out of it and let checkRequiredVersion do it's thing |
| 16:18:17 | <djazayeri> breeze: typically it'd refer to a missing bean definition or something like that. |
| 16:18:20 | <breeze> djazayeri: I'll check that out |
| 16:18:28 | *** Anuruddha has quit IRC |
| 16:18:49 | <djazayeri> gotta run for a bit |
| 16:19:04 | <andreapat> wyclif, easier to send email - will do that |
| 16:20:28 | *** GarimaAhuja has joined #openmrs |
| 16:21:01 | *** 45PAADCIN has quit IRC |
| 16:21:47 | <jkeiper> breeze: REGCORE i think |
| 16:30:41 | *** h3llborn has joined #openmrs |
| 16:30:52 | *** GarimaAhuja has quit IRC |
| 16:33:10 | <andreapat> wyclif, djazayeri, just sent you email - let me know what you thimk |
| 16:35:55 | *** cpower_ has quit IRC |
| 16:38:06 | <andreapat> wyclif, did you see my mail? |
| 16:41:20 | <h3llborn> djazayeri: did i manage to fix the javadoc properly? |
| 16:42:49 | *** cpower_ has joined #openmrs |
| 16:43:03 | *** khayamuddin31 has joined #openmrs |
| 16:44:45 | *** khayamuddin31 is now known as khayam |
| 16:47:32 | <breeze> looks like I'm missing some basic stuff with deploying the ref app to tomcat....first problem is INFO - HibernateContextDAO.authenticate(181) |2013-04-05 05:51:58,786| Failed login attempt (login=ad |
| 16:47:32 | <breeze> min) - Invalid username and/or password: admin |
| 16:47:43 | *** Dimuthu_Upeksha has joined #openmrs |
| 16:47:51 | <breeze> is there property I'm not setting? |
| 16:50:21 | <khayam> hi wyclif: can you tell whether i have implemented this ticket correct or not https://tickets.openmrs.org/browse/TRUNK-3094 |
| 16:55:26 | *** suranga__ has quit IRC |
| 16:59:46 | <djazayeri> breeze: did you try admin/test and admin/Admin123 ? |
| 17:02:11 | <andreapat> djazayeri, I just sent you and Wyclif an email - please take a look - think I have best way to handle snapshot and range |
| 17:08:30 | <djazayeri> andreapat: I replied saying how I would approach it. |
| 17:08:48 | <djazayeri> wyclif: you there? |
| 17:09:01 | <djazayeri> Can we pair for 20 minutes? (I'm talking to Burke then, but would be good to start beforeâ¦) |
| 17:09:17 | <andreapat> djazayeri, will look |
| 17:09:59 | *** mansi has joined #openmrs |
| 17:10:53 | <andreapat> djazayeri, looks good thanks! |
| 17:19:25 | *** rajiths has quit IRC |
| 17:20:03 | *** sgithens has quit IRC |
| 17:20:40 | *** tbharath has quit IRC |
| 17:36:33 | *** Vader has joined #openmrs |
| 17:36:33 | *** mansi has quit IRC |
| 17:37:45 | *** GarimaAhuja has joined #openmrs |
| 17:40:22 | *** GarimaAhuja has joined #openmrs |
| 17:43:28 | *** harshadura has quit IRC |
| 17:44:37 | *** GarimaAhuja has quit IRC |
| 17:49:39 | <mario_> djazayeri, wyclif I'm having some problems to start the registration core module. Did you guys have any problem on this module? |
| 17:52:12 | *** davidpardz has joined #openmrs |
| 17:52:51 | <djazayeri> mario_: I haven't tried starting it |
| 17:53:25 | *** mogoodrich has quit IRC |
| 17:53:30 | <mario_> djazayeri, but we do need this module on our local environment right? |
| 17:53:48 | <djazayeri> mario_: could this be what breeze just ran into, that it's supposed to have a dependency on idgen, but it doesn't declare this in its config.xml? |
| 17:54:21 | <davidpardz> hi mseaton, hoper you are doing good. I commited a solution for the following bugs REPORT-419 and HTMLWIDGETS-13 I will be in touch for any changes |
| 17:54:34 | <mario_> djazayeri, huuum, yeah I have some errors about the classpath, let me see if this fix it |
| 17:58:49 | *** davidpardz has left #openmrs |
| 18:07:38 | <wyclif> mario_, djazayeri andreapat, khayam sorry i was away for lunch and didnt change my status |
| 18:09:30 | <khayam> wyclif-can you tell how do i contact Daniel Kayiwa? |
| 18:09:59 | <djazayeri> wyclif: okay, I'm on a call with burke now, and I have another call after. |
| 18:10:01 | *** mogoodrich has joined #openmrs |
| 18:10:10 | <wyclif> khayam, i have commented on the ticket and pinged daniel |
| 18:10:22 | <wyclif> he will see your ticket comment |
| 18:10:27 | <wyclif> djazayeri, ok |
| 18:10:40 | <wyclif> mario_, still having issues with reg core? |
| 18:10:46 | *** thranasingha has joined #openmrs |
| 18:11:06 | *** ChanServ sets mode: +v wyclif |
| 18:11:22 | <burke> wyclif: welcome to "voice"! :-) |
| 18:11:38 | <mario_> wyclif, Darius, told me that there missing some configuration on the confix.xml on this module. I'm trying to put those configurations and see if it will gonna fix it :) |
| 18:13:55 | <khayam> wyclif-i want to know the details of data comparison module, can you help me? |
| 18:15:28 | <andreapat> wyclif, hi - djazayeri replied to my mail - wil go his route with checkRequirdeVersion |
| 18:16:12 | <andreapat> wyckif, looks like you're a little swamped - will ping you later if further question |
| 18:21:58 | *** khayam has quit IRC |
| 18:24:42 | *** h3llborn has quit IRC |
| 18:26:37 | *** jordank has joined #openmrs |
| 18:36:26 | *** jordank has quit IRC |
| 18:36:26 | *** Vader has quit IRC |
| 18:42:41 | <wyclif> andreapat, i dont seem to get what the problem is, you might need to iron out the code in checkRequiredVersion to do the right thing and only call compareVersions with actual version string and not ranges |
| 18:43:15 | <wyclif> andreapat, because i think it is calling it with ranges |
| 18:55:39 | <djazayeri> wyclif: 30 minutes of pairing, in 5 minutes? |
| 18:59:40 | <wyclif> djazayeri, |
| 19:03:02 | <djazayeri> wyclif: hi |
| 19:03:55 | <wyclif> hi djazayeri |
| 19:05:12 | <djazayeri> wyclif: hi. Can we pair now, on that ticket? Do you have team viewer? |
| 19:05:57 | <wyclif> djazayeri, my license expired |
| 19:06:27 | <wyclif> cant we use the google hangout? |
| 19:07:07 | *** thranasingha has quit IRC |
| 19:07:24 | <djazayeri> wyclif: it doesn't have as good visual quality, and we can't remote control, but fine for now. That said, teamviewer doesn't need a license for personal use... |
| 19:07:33 | <djazayeri> call me on hangout |
| 19:08:11 | *** cpower_ has quit IRC |
| 19:08:44 | <djazayeri> wyclif: ^^ |
| 19:09:36 | <wyclif> djazayeri, |
| 19:09:48 | <wyclif> let me start one |
| 19:10:40 | *** r0bby_ has joined #openmrs |
| 19:10:40 | *** ChanServ sets mode: +v r0bby_ |
| 19:13:40 | *** Mkop has joined #openmrs |
| 19:13:40 | *** ChanServ sets mode: +v Mkop |
| 19:14:30 | *** andrea_ has joined #openmrs |
| 19:15:14 | *** cpower_ has joined #openmrs |
| 19:15:39 | *** h3llborn has joined #openmrs |
| 19:22:10 | *** andreapat has quit IRC |
| 19:22:21 | *** andrea_ has quit IRC |
| 19:23:58 | *** andrea_ has joined #openmrs |
| 19:24:10 | *** andrea_ is now known as andreap_ |
| 19:32:01 | *** harsz89 has quit IRC |
| 19:38:30 | *** h3llborn has quit IRC |
| 19:46:33 | *** wyclif_ has joined #openmrs |
| 19:46:33 | *** wyclif has quit IRC |
| 19:48:22 | *** Dimuthu_Upeksha has quit IRC |
| 20:13:06 | *** mogoodrich has quit IRC |
| 20:26:57 | *** jordank has joined #openmrs |
| 21:06:12 | *** lh has quit IRC |
| 21:07:16 | *** nyoman has quit IRC |
| 21:12:29 | *** r0bby_ has quit IRC |
| 21:18:15 | *** cospih has quit IRC |
| 21:19:07 | *** wyclif_ has quit IRC |
| 21:26:41 | *** cpower_ has quit IRC |
| 21:27:44 | *** cpower_ has joined #openmrs |
| 21:29:37 | *** breeze has quit IRC |
| 22:33:05 | *** wyclif_ has joined #openmrs |
| 22:54:27 | *** jordank has quit IRC |
| 23:17:48 | *** applecool has joined #openmrs |
| 23:17:48 | *** ChanServ sets mode: +v applecool |
| 23:19:03 | *** downey_ has joined #openmrs |
| 23:19:03 | *** ChanServ sets mode: +o downey_ |
| 23:19:16 | *** sunbiz has quit IRC |
| 23:19:17 | *** mario_ has quit IRC |
| 23:19:17 | *** djazayeri has quit IRC |
| 23:19:17 | *** downey has quit IRC |
| 23:20:03 | *** downey_ is now known as downey |
| 23:54:45 | *** applecool has quit IRC |