| 00:06:09 | *** nheck has quit IRC |
| 00:09:36 | *** Anuruddha has joined #openmrs |
| 00:10:46 | *** nheck has joined #openmrs |
| 00:19:18 | *** nheck has quit IRC |
| 00:48:46 | *** cospih has quit IRC |
| 00:57:44 | *** mario_ has quit IRC |
| 01:00:42 | *** ryates has joined #openmrs |
| 01:04:46 | *** nribeka has joined #openmrs |
| 01:04:46 | *** ChanServ sets mode: +v nribeka |
| 01:19:40 | *** djazayeri has quit IRC |
| 01:27:29 | *** nyoman has joined #openmrs |
| 01:31:30 | *** h3llborn has quit IRC |
| 01:44:17 | *** h3llborn has joined #openmrs |
| 01:56:56 | *** Upeksha has joined #openmrs |
| 02:37:34 | *** jordank has joined #openmrs |
| 02:50:10 | *** jordank has quit IRC |
| 02:50:30 | *** jordank has joined #openmrs |
| 02:54:51 | <nyoman> !list |
| 02:54:51 | <OpenMRSBot> nyoman: Admin, Alias, AutoMode, Channel, ChannelLogger, ChannelStats, Config, Factoids, Herald, Karma, Misc, NickCapture, Owner, RSS, Reply, Seen, Services, ShrinkUrl, Status, User, and Web |
| 02:57:10 | *** robbyoconnor has joined #openmrs |
| 02:57:10 | *** ChanServ sets mode: +v robbyoconnor |
| 02:57:55 | <nyoman> !beerme |
| 02:57:55 | <OpenMRSBot> nyoman: (beerme <an alias, 1 argument>) -- Alias for "action slides $1 a pint". |
| 02:58:12 | <nyoman> !beerme robbyoconnor |
| 02:58:12 | * OpenMRSBot slides robbyoconnor a pint |
| 03:01:21 | <robbyoconnor> hey nyoman |
| 03:01:33 | <robbyoconnor> jus got home |
| 03:05:03 | <nyoman> hi robbyoconnor :) |
| 03:05:36 | *** downey has quit IRC |
| 03:16:29 | <nyoman> !list alias |
| 03:16:29 | <OpenMRSBot> nyoman: add, beer, beer2, beerme, changeset, codereview, cokeme, cr, cs, dcme, define, facts, google, googledefine, jira, lock, mailinglist, powerup, refer, remove, requestsvnspace, review, scrumoff, scrumon, test, test2, ticket, and unlock |
| 03:17:03 | <jkeiper> !help ticket |
| 03:17:03 | <OpenMRSBot> jkeiper: (ticket <an alias, 1 argument>) -- Alias for "reply [web title https://tickets.openmrs.org/browse/$1] - https://tickets.openmrs.org/browse/$1". |
| 03:25:44 | *** mario_ has joined #openmrs |
| 03:44:37 | *** jordank has quit IRC |
| 04:06:37 | *** jordank has joined #openmrs |
| 04:18:01 | *** kavuri has joined #openmrs |
| 04:23:09 | *** h3llborn has quit IRC |
| 04:23:39 | *** shangxiao has joined #openmrs |
| 04:28:58 | *** shangxiao has quit IRC |
| 04:29:43 | *** shangxiao has joined #openmrs |
| 04:30:54 | *** shangxiao has quit IRC |
| 04:50:46 | *** lh has quit IRC |
| 04:53:57 | *** Upeksha has quit IRC |
| 04:54:42 | *** wyclif_ has quit IRC |
| 04:57:06 | *** wyclif has joined #openmrs |
| 04:58:01 | *** wyclif has joined #openmrs |
| 05:03:12 | *** downey has joined #openmrs |
| 05:03:12 | *** ChanServ sets mode: +o downey |
| 05:10:11 | *** joeseff has joined #openmrs |
| 05:22:23 | *** Dimuthu_Upeksha has joined #openmrs |
| 05:26:34 | *** djazayeri has joined #openmrs |
| 05:26:34 | *** ChanServ sets mode: +o djazayeri |
| 05:33:24 | *** ibewes has joined #openmrs |
| 05:43:28 | *** mansi has joined #openmrs |
| 06:05:40 | *** sagar has joined #openmrs |
| 06:08:23 | <sagar> Hello |
| 06:09:04 | <sagar> I am trying to use Hibernate interceptor |
| 06:14:20 | *** jordank has quit IRC |
| 06:14:51 | <sagar> I am using event-module to catch triggers upon patient registration (insert to database) from curl request |
| 06:15:46 | <sagar> but the after database transaction chaining interceptor in not being invoked |
| 06:16:06 | *** khayamuddin31 has joined #openmrs |
| 06:16:33 | *** khayamuddin31 is now known as khayam |
| 06:19:11 | <sagar> I am trying to get notification using event module upon patient registration. I get notification when I register patient from openmrs web UI, but iam not getting notification when I create patient using curl request |
| 06:19:51 | <sagar> using web services module |
| 06:23:06 | <khayam> can any help me to solve spring exceptions-cascase |
| 06:23:52 | <ibewes> sagar: doesn't the event module provide a built-in way to do that without creating an interceptor? |
| 06:32:11 | <sagar> ibewes, I am using event module which already uses an interceptor |
| 06:32:42 | <sagar> ibewes, HibernateEventInterceptor.java |
| 06:34:37 | <ibewes> sagar: you're using the HibernateEventInterceptor.java directly? |
| 06:38:21 | <ibewes> sagar: regardless, you might want to look at the REST module to see how it is registering a patient... perhaps it is doing it in a way that the interceptor cannot "see"? |
| 06:41:56 | *** Darthy has joined #openmrs |
| 06:41:56 | *** mansi has quit IRC |
| 06:42:54 | <sagar> ibewes: No I am not using HibernateEventInterceptor directly , I am using event module which uses hibernate interceptor |
| 06:43:01 | <sagar> to catch DB transactions |
| 06:43:11 | <ibewes> sagar: gotcha, just making sure :) |
| 06:44:38 | *** Dimuthu_Upeksha has quit IRC |
| 06:45:58 | *** robin_ has joined #openmrs |
| 06:47:49 | <robin_> i want to know the openmrs starting page sourcecode |
| 07:02:53 | *** robin_ has quit IRC |
| 07:05:28 | *** khayam has quit IRC |
| 07:10:10 | *** robbyoconnor has quit IRC |
| 07:10:34 | *** robbyoconnor has joined #openmrs |
| 07:10:34 | *** ChanServ sets mode: +v robbyoconnor |
| 07:20:31 | *** dkayiwa has joined #openmrs |
| 07:22:38 | *** rajith has joined #openmrs |
| 07:40:31 | *** Anuruddha has quit IRC |
| 07:40:36 | *** Darthy has quit IRC |
| 07:41:02 | *** Darthy has joined #openmrs |
| 07:43:24 | *** sunbiz has quit IRC |
| 07:57:48 | *** djazayeri has quit IRC |
| 08:15:43 | <sagar> ibewes: got it |
| 08:15:56 | <ibewes> sagar: what was the problem? |
| 08:16:20 | <sagar> ibewes: hibernateinterceptor triggers update event |
| 08:16:40 | <ibewes> sagar: ahhh... good to know! |
| 08:16:49 | <sagar> when patient is registered from curl |
| 08:17:05 | <sagar> request |
| 08:18:29 | *** rel has joined #openmrs |
| 08:20:24 | *** Guest____ has joined #openmrs |
| 08:22:58 | *** harsz89 has quit IRC |
| 08:25:09 | *** Guest____ has quit IRC |
| 08:39:47 | *** harsz89 has joined #openmrs |
| 08:39:47 | *** Darthy has quit IRC |
| 08:40:05 | *** Darthy has joined #openmrs |
| 08:45:06 | <joeseff> dkayiwa: Hi |
| 08:45:14 | <dkayiwa> joeseff: hi |
| 08:47:11 | <joeseff> dkayiwa: There was something we discussed last time that I need help with. I saw that someone else had the same problem - https://answers.openmrs.org/questions/753/xforms-help-with-muliple-select-answers. The solution you gave did not work for me. The form submits all the fields you've checked but the observations table only records one coded value. Any ideas how I can get past this problem? Or could you point me to a sample form h |
| 08:56:27 | <dkayiwa> joeseff: can you do a file save as and pastebin the form? |
| 08:57:56 | <joeseff> dkayiwa: Ok |
| 08:58:04 | <joeseff> dkayiwa: thanks |
| 09:00:23 | *** ibewes has quit IRC |
| 09:04:40 | *** rel is now known as nimby |
| 09:06:39 | <joeseff> dkayiwa: Sorry, the network is very slow for the moment. Could you give me about 15 minutes? |
| 09:10:20 | <dkayiwa> joeseff: take as long as you want :) |
| 09:12:57 | *** joeseff has quit IRC |
| 09:13:57 | *** joeseff has joined #openmrs |
| 09:14:17 | <joeseff> dkayiwa: Here it is - http://pastebin.com/KfE0TARx |
| 09:14:17 | *** nimby has quit IRC |
| 09:14:50 | *** rel has joined #openmrs |
| 09:14:54 | *** rel is now known as nimby |
| 09:15:40 | <dkayiwa> joeseff: and which field is it? |
| 09:16:17 | *** Upeksha has joined #openmrs |
| 09:17:39 | <joeseff> dkayiwa: There are several, HEENT EXAM FINDINGS, NECK EXAM, CHEST EXAM FINDINGS, CARDIAC EXAM FINDINGS, ABDOMINAL EXAM FINDINGS - does this help? |
| 09:18:05 | <dkayiwa> joeseff: lets deal with on one |
| 09:18:18 | <dkayiwa> joeseff: solving it will give you a way of solving others |
| 09:18:18 | <joeseff> dkayiwa: ok |
| 09:18:29 | <joeseff> dkayiwa: I agree |
| 09:19:00 | <dkayiwa> joeseff: can you pastebin model xml after you have filled any mutiple select? |
| 09:19:34 | *** ibewes has joined #openmrs |
| 09:20:40 | <joeseff> dkayiwa: Ok, but if it helps...I had looked at the model xml tab and it looks like the form submits the data but the database saves only one value but let me do it just now |
| 09:24:06 | <dkayiwa> joeseff: do all widgets in the same groupbox have the same value for Binding under widget properties? |
| 09:24:28 | <dkayiwa> joeseff: oh sorry they do not have to :) |
| 09:25:40 | *** harsha89 has joined #openmrs |
| 09:26:47 | *** harsz89 has quit IRC |
| 09:27:08 | *** joeseff has quit IRC |
| 09:28:54 | <sagar> dkayiwa: I am working with Event Module , I am observing two different behaviour 1) When I create patient from openmrs web UI, create is triggered by hibernate interceptor 2) When I create patient using curl request , update is triggered by hibernate interceptor |
| 09:32:29 | *** joeseff has joined #openmrs |
| 09:34:10 | <joeseff> dkayiwa: Sorry...for the constant network interruptions. Did you get my pastebin? |
| 09:38:42 | *** Vader has joined #openmrs |
| 09:38:43 | *** Darthy has quit IRC |
| 09:38:53 | *** sunbiz has joined #openmrs |
| 09:38:53 | *** ChanServ sets mode: +v sunbiz |
| 09:40:03 | <sagar> dkayiwa: hi |
| 09:41:40 | <dkayiwa> sagar: hi |
| 09:41:55 | <dkayiwa> joeseff: no. resend |
| 09:42:20 | <joeseff> dkayiwa: Here - http://pastebin.com/ADsr8CPt |
| 09:43:09 | <sagar> dkayiwa:I am working with Event Module , I am observing two different behaviour 1) When I create patient from openmrs web UI, create is triggered by hibernate interceptor 2) When I create patient using curl request , update is triggered by hibernate interceptor |
| 09:43:48 | <dkayiwa> sagar: ok |
| 09:44:25 | <sagar> dkayiwa: from webservices instead of create update is being invoked |
| 09:44:37 | <dkayiwa> joeseff: did you enter any values for? HEENT EXAM FINDINGS |
| 09:45:16 | <joeseff> dkayiwa: No, sorry, I only entered values for CHEST EXAM FINDINGS... |
| 09:45:41 | <dkayiwa> joeseff: ok |
| 09:46:56 | <dkayiwa> joeseff: submit a real form with chest exact findings. and then tell me what happens |
| 09:47:26 | <dkayiwa> sagar: ok |
| 09:47:50 | <joeseff> dkayiwa: By a real form, you mean that I should select a patient and fill out their data using this form? |
| 09:47:57 | *** rajith has quit IRC |
| 09:48:12 | <dkayiwa> joeseff: yes. and tick all chest exam findings options |
| 09:48:26 | <joeseff> dkayiwa: ok |
| 09:48:44 | <sagar> dkayiwa: can I know where the problem might be and possible cause for dual behaviour ? |
| 09:51:52 | <joeseff> dkayiwa: I submitted the form successfully |
| 09:52:21 | <dkayiwa> joeseff: how many chest exam findings options did you tick? |
| 09:52:36 | <dkayiwa> sagar: can you create a ticket for it? |
| 09:52:56 | <joeseff> dkayiwa: Seven |
| 09:53:23 | <dkayiwa> joeseff: do they show to have submitted? |
| 09:54:26 | <joeseff> dkayiwa: To show how? When I view the encounter, all I see is "Accessory muscle use" but when I click Edit encounter - it shows that all the fields for chest exam findings are checked |
| 09:54:40 | *** nimby has quit IRC |
| 09:55:19 | <dkayiwa> joeseff: so where is the problem with chest exam findings? |
| 09:56:08 | <joeseff> dkayiwa: The problem is, it is supposed to record all the values that you've checked, but its only recording one. |
| 09:59:06 | <joeseff> dkayiwa: Or am I wrong? |
| 10:03:10 | <sagar> dkayiwa: ok |
| 10:04:11 | <dkayiwa> joeseff: after clicking edit encounter, you said it shows all the ones you ticket as checked |
| 10:04:27 | <dkayiwa> joeseff: and thats the correct behavior. not so? |
| 10:06:36 | <joeseff> dkayiwa: Sorry, I've just discovered something. Chest Exam Findings is an inbuilt grouping concept. The inbuilt grouping concepts seem to be doing fine but the grouping concepts I created, are behaving as I described earlier. I'm sorry, I had not noted this earlier, let me find out the difference between the two. Thank you for your time |
| 10:07:01 | <dkayiwa> joeseff: ok |
| 10:12:53 | *** Vader has quit IRC |
| 10:18:07 | <joeseff> dkayiwa: You are a genius. The difference was, my grouping concepts had class ConvSet, LabSet, Question etc. The inbuilt grouping concepts are of class Finding. Thank you very much! |
| 10:19:09 | <dkayiwa> joeseff: what did you change to make it work? |
| 10:23:55 | <joeseff> dkayiwa: The class of the grouping concept. The correct class to put in a grouping concept to enable it to save multiple values is "Finding" |
| 10:24:33 | <joeseff> dkayiwa: Thanks |
| 10:29:59 | <dkayiwa> joeseff: though i do not think thats the fix :) |
| 10:30:54 | <joeseff> dkayiwa: It worked on one form, now I'm trying it on the other forms. I hope that's the fix, the forms are already overdue |
| 10:48:30 | *** rajith has joined #openmrs |
| 10:51:56 | *** jb360 has quit IRC |
| 11:07:14 | *** cospih has joined #openmrs |
| 11:07:27 | *** robbyoconnor has quit IRC |
| 11:11:32 | <joeseff> dkayiwa: I've tested all the forms, Changing the class of the Grouping concept to Finding solved the issue. Thanks a lot! :) |
| 11:12:05 | <dkayiwa> joeseff: any other class would work too :) |
| 11:13:53 | <joeseff> dkayiwa: I used ConvSet, LabSet and Question for the grouping classes but all of them only allowed me to save one value to the database. Maybe its because of the version of openmrs I'm using (standalone v1.9.2). Thankfully, this worked! Thanks again! |
| 11:14:49 | *** draggonz has joined #openmrs |
| 11:15:08 | <dkayiwa> joeseff: the openmrs version is fine. Am sure if you again changed only class from finding to another it will work |
| 11:15:42 | <joeseff> dkayiwa: ok, I will try that |
| 11:16:53 | *** Upeksha has quit IRC |
| 11:21:19 | *** GitHub64 has joined #openmrs |
| 11:21:19 | <GitHub64> [openmrs-core] rkorytkowski pushed 2 new commits to master: http://git.io/FrPzhQ |
| 11:21:19 | <GitHub64> openmrs-core/master 652ca74 guilhermejccavalcanti: TRUNK-3904 - Added the "this()" reference in the integer constructor of... |
| 11:21:19 | <GitHub64> openmrs-core/master a19e732 Rafal Korytkowski: Merge pull request #263 from guilhermejccavalcanti/TRUNK-3904... |
| 11:21:19 | *** GitHub64 has left #openmrs |
| 11:25:27 | *** draggonz has quit IRC |
| 11:28:34 | *** rkorytkowski has joined #openmrs |
| 11:28:34 | *** rkorytkowski is now known as rafa |
| 11:28:34 | *** ChanServ sets mode: +v rafa |
| 11:35:26 | *** travis-ci has joined #openmrs |
| 11:35:26 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [a19e732] [Rafal Korytkowski] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/6047573 |
| 11:35:26 | *** travis-ci has left #openmrs |
| 11:35:29 | <OpenMRSBot> <http://ln-s.net/+x0-> (at travis-ci.org) |
| 11:38:43 | *** GitHub108 has joined #openmrs |
| 11:38:43 | <GitHub108> [openmrs-core] rkorytkowski pushed 1 new commit to 1.9.x: http://git.io/PMZEXg |
| 11:38:43 | <GitHub108> openmrs-core/1.9.x 3e493ca rkorytkowski: TRUNK-3904: Concept(Integer) constructer doesn't call this() |
| 11:38:43 | *** GitHub108 has left #openmrs |
| 11:42:29 | *** GitHub131 has joined #openmrs |
| 11:42:29 | <GitHub131> [openmrs-core] rkorytkowski pushed 5 new commits to master: http://git.io/ESPTvA |
| 11:42:29 | <GitHub131> openmrs-core/master a3959ec Sara Fatima: TRUNK-3811: On successful save of Concept one should go to View Concept Screen |
| 11:42:29 | <GitHub131> openmrs-core/master b6312e4 Sara Fatima: TRUNK-3811: On successful save of Concept one should go to View Concept Screen |
| 11:42:29 | <GitHub131> openmrs-core/master 85129fe Sara Fatima: TRUNK-3811: On successful save of Concept one should go to View Concept Screen |
| 11:42:29 | *** GitHub131 has left #openmrs |
| 11:51:05 | *** travis-ci has joined #openmrs |
| 11:51:05 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [a8ab9aa] [Rafal Korytkowski] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/6047895 |
| 11:51:05 | *** travis-ci has left #openmrs |
| 11:51:10 | <OpenMRSBot> <http://ln-s.net/+x0W> (at travis-ci.org) |
| 11:52:13 | *** ibewes has quit IRC |
| 11:58:56 | <harsha89> hi rafa |
| 11:59:01 | <rafa> harsha89: hi |
| 11:59:12 | <harsha89> i'm thinking of looking at https://tickets.openmrs.org/browse/RESTWS-367 |
| 11:59:27 | <harsha89> can I have bit more info about it |
| 11:59:28 | <harsha89> :) |
| 12:05:44 | *** shangxiao has joined #openmrs |
| 12:14:13 | <dkayiwa> harsha89: can you ask axactly what more info you are looking for? (and on the ticket too) :) |
| 12:15:00 | *** garima has joined #openmrs |
| 12:15:38 | <harsha89> dkayiwa, hi |
| 12:15:53 | <dkayiwa> harsha89: hi |
| 12:16:08 | <harsha89> dkayiwa, it says A response to update request is empty. It needs to return an updated object similarly to a create request. |
| 12:16:37 | <dkayiwa> harsha89: can you say it all on the ticket? :) |
| 12:16:52 | <harsha89> dkayiwa, :) |
| 12:17:07 | <harsha89> dkayiwa, i'll comment out of the ticket |
| 12:17:09 | <harsha89> dkayiwa, :) |
| 12:17:21 | <dkayiwa> :) |
| 12:17:21 | *** sagar has quit IRC |
| 12:24:08 | *** kavuri has quit IRC |
| 12:27:04 | *** sach has joined #openmrs |
| 12:27:06 | *** nyoman has quit IRC |
| 12:28:27 | *** h3llborn has joined #openmrs |
| 12:34:06 | *** davidpardz has joined #openmrs |
| 12:37:26 | <shangxiao> rafa here? |
| 12:37:33 | *** garima has quit IRC |
| 12:37:52 | <rafa> shangxiao: yes |
| 12:38:44 | <shangxiao> rafa: I'm about to send an email to the dev list wrt getting some feedback for our concept proposal module (We've been told that you're our primary point of contact now?) |
| 12:39:21 | <shangxiao> Would attaching the omod be appropriate? |
| 12:39:48 | <rafa> shangxiao: How big is the omod? |
| 12:40:08 | *** wyclif has quit IRC |
| 12:40:25 | <shangxiao> 3.5M |
| 12:42:15 | <rafa> shangxiao: Do not attach such a big file directly, but link it :) |
| 12:42:39 | <dkayiwa> shangxiao: how about uploading to module repository and point people there :) |
| 12:42:41 | <shangxiao> Any ideas where to host it? |
| 12:42:47 | <shangxiao> oh |
| 12:42:54 | <shangxiao> the openmrs repository? |
| 12:43:02 | <dkayiwa> shangxiao: yup |
| 12:43:15 | <shangxiao> I was going to put it on GitHub but found out they cancelled file uploads a few months ago |
| 12:43:23 | <shangxiao> ok will try to put it up there |
| 12:43:29 | <rafa> shangxiao: https://modules.openmrs.org/ |
| 12:44:20 | <shangxiao> leaving the version as the maven default (0.1-snapshot or something) is ok? |
| 12:44:35 | <shangxiao> or should I make it an alpha release |
| 12:44:51 | <rafa> shangxiao: I would advise to make it an alpha release |
| 12:45:04 | <shangxiao> ok |
| 12:45:10 | <shangxiao> will do ;) |
| 12:46:16 | <rafa> harsha89: I added a comment to the ticket |
| 12:54:27 | <harsha89> rafa, thanks a lot rafa |
| 12:54:31 | <harsha89> rafa, :) :) |
| 12:57:22 | *** nyoman has joined #openmrs |
| 13:04:32 | *** djazayeri has joined #openmrs |
| 13:04:32 | *** ChanServ sets mode: +o djazayeri |
| 13:04:57 | *** wyclif has joined #openmrs |
| 13:05:24 | *** wyclif has joined #openmrs |
| 13:09:42 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Concept Proposal Module 1.0.0-alpha-1-SHA1-118e7be uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=cpm&version=&1.0.0-alpha-1-SHA1-118e7be> |
| 13:12:23 | *** harsha89 has quit IRC |
| 13:14:13 | <djazayeri> dkayiwa: joining? |
| 13:15:09 | <dkayiwa> djazayeri: yes |
| 13:18:32 | <djazayeri> wyclif: joining? |
| 13:20:58 | *** breeze has joined #openmrs |
| 13:29:47 | *** harsha89 has joined #openmrs |
| 13:32:22 | <shangxiao> big email done & dusted |
| 13:32:46 | <shangxiao> !powerup shangxiao |
| 13:32:46 | * OpenMRSBot slides shangxiao a Jack and Coke |
| 13:32:59 | <downey> shangxiao++ |
| 13:33:23 | <h3llborn> shah thats sweet, shangxiao is there a wiki page for bot commands? |
| 13:34:17 | <downey> h3llborn: /msg OpenMRSBot list alias |
| 13:35:12 | <shangxiao> ;) |
| 13:35:44 | <shangxiao> I think there is but I don't know the url :) |
| 13:36:09 | <shangxiao> !cc shangxiao |
| 13:36:10 | <OpenMRSBot> shangxiao: Error: "cc" is not a valid command. |
| 13:36:17 | <shangxiao> !dc shangxiao |
| 13:36:17 | <OpenMRSBot> shangxiao: Error: "dc" is not a valid command. |
| 13:36:31 | <shangxiao> !commands |
| 13:36:31 | <OpenMRSBot> shangxiao: action, add, alert, announce, any, apropos, ban add, ban list, ban remove, beer, beer2, beerme, capabilities, capability add, capability list, capability remove, capability set, capability setdefault, capability unset, change, changename, changeset, channel, channels, channelstats, clear, cmd, codereview, cokeme, commands, config, cpu, cr, cs, cycle, dcme, default, defaultcapability, defaultplugin, (3 more messages) |
| 13:36:44 | <shangxiao> !cokeme h3llborn |
| 13:36:44 | * OpenMRSBot Drugs are bad |
| 13:36:53 | <shangxiao> lol |
| 13:37:07 | <shangxiao> !dcme h3llborn |
| 13:37:07 | * OpenMRSBot slides h3llborn a litre of coke light |
| 13:37:19 | <downey> cokelight++ |
| 13:37:49 | <shangxiao> !commands |
| 13:37:49 | <OpenMRSBot> shangxiao: action, add, alert, announce, any, apropos, ban add, ban list, ban remove, beer, beer2, beerme, capabilities, capability add, capability list, capability remove, capability set, capability setdefault, capability unset, change, changename, changeset, channel, channels, channelstats, clear, cmd, codereview, cokeme, commands, config, cpu, cr, cs, cycle, dcme, default, defaultcapability, defaultplugin, (3 more messages) |
| 13:37:51 | <shangxiao> !commands |
| 13:37:51 | <OpenMRSBot> shangxiao: action, add, alert, announce, any, apropos, ban add, ban list, ban remove, beer, beer2, beerme, capabilities, capability add, capability list, capability remove, capability set, capability setdefault, capability unset, change, changename, changeset, channel, channels, channelstats, clear, cmd, codereview, cokeme, commands, config, cpu, cr, cs, cycle, dcme, default, defaultcapability, defaultplugin, (3 more messages) |
| 13:37:58 | <h3llborn> oh perfect |
| 13:38:00 | <h3llborn> thanks :) |
| 13:38:03 | <shangxiao> how to go to next page of commands? |
| 13:38:09 | <downey> you don't :D |
| 13:38:20 | <shangxiao> but it says 3 more messages :) |
| 13:38:33 | <h3llborn> downey: bug in code? |
| 13:39:36 | <h3llborn> !beer2 |
| 13:39:49 | <downey> you'd do /msg OpenMRSBot more |
| 13:40:13 | <h3llborn> well that sucks, no beer2 for me :P |
| 13:44:31 | *** suranga__ has joined #openmrs |
| 13:46:48 | <nyoman> !list alias |
| 13:46:48 | <OpenMRSBot> nyoman: add, beer, beer2, beerme, changeset, codereview, cokeme, cr, cs, dcme, define, facts, google, googledefine, jira, lock, mailinglist, powerup, refer, remove, requestsvnspace, review, scrumoff, scrumon, test, test2, ticket, and unlock |
| 13:47:40 | <h3llborn> shangxiao: did you use balsamic mockups for the sketches? |
| 13:50:23 | *** h3llborn has quit IRC |
| 13:54:13 | *** shangxiao has quit IRC |
| 13:59:06 | *** joeseff has quit IRC |
| 14:01:28 | <suranga__> hi guys, dev forum starts in 1/2 an hour, right ? |
| 14:02:00 | <nyoman> now suranga__ |
| 14:02:38 | <downey> suranga__: no, now :) |
| 14:02:44 | <downey> !devmtg |
| 14:02:45 | <OpenMRSBot> downey: "devmtg" --- Reminder: Developer Forum Thursday at 10:00 AM Eastern Time - https://wiki.openmrs.org/display/RES/Developers+Forum |
| 14:02:55 | <suranga__> nyoman, downey gahh... i miscalculated again :( |
| 14:03:39 | *** vishal1tiwari has joined #openmrs |
| 14:03:42 | <nyoman> 30 mins tz different ftl! |
| 14:03:48 | *** wyclif has quit IRC |
| 14:18:55 | *** suranga__ has quit IRC |
| 14:19:01 | *** wyclif has joined #openmrs |
| 14:19:18 | *** suranga__ has joined #openmrs |
| 14:20:40 | <downey> timeZones-- |
| 14:33:11 | *** h3llborn has joined #openmrs |
| 14:34:00 | *** shangxiao has joined #openmrs |
| 14:35:49 | *** kavuri has joined #openmrs |
| 14:36:46 | <downey> suranga: suranga_ suranga__ ... we need to figure out why you have so many nicks in here :) |
| 14:51:59 | *** shangxiao has quit IRC |
| 14:54:51 | *** Hasintha_i has joined #openmrs |
| 14:55:27 | *** sach has quit IRC |
| 14:59:32 | *** Hasintha_i has quit IRC |
| 14:59:57 | *** Hasintha_i has joined #openmrs |
| 15:03:56 | *** khayamuddin31 has joined #openmrs |
| 15:04:38 | *** khayamuddin31 is now known as khayam |
| 15:04:45 | *** shangxiao has joined #openmrs |
| 15:05:47 | <khayam> Daniel Kayiwa:are you their? |
| 15:20:04 | <djazayeri> rafa: you there now, and have a moment to hang out? |
| 15:20:18 | <djazayeri> rafa: about the concept numeric blocker bug? |
| 15:20:29 | *** h3llborn has quit IRC |
| 15:21:15 | <djazayeri> rafa: never mind, we have a different conversation now. |
| 15:24:12 | *** draggonz has joined #openmrs |
| 15:24:58 | *** rowanseymour has joined #openmrs |
| 15:25:01 | *** wyclif has quit IRC |
| 15:26:49 | *** jordank has joined #openmrs |
| 15:26:54 | *** h3llborn has joined #openmrs |
| 15:26:57 | *** kavuri has quit IRC |
| 15:28:05 | <h3llborn> djazayeri: did you get a chance to take a look at my updated ticket/commit? |
| 15:28:18 | <djazayeri> h3llborn: not yet, been in calls all day, still in one |
| 15:28:31 | *** jordank has quit IRC |
| 15:33:11 | *** h3llborn has quit IRC |
| 15:35:32 | *** shangxiao has quit IRC |
| 15:38:55 | *** wyclif has joined #openmrs |
| 15:39:21 | *** lh has joined #openmrs |
| 15:40:33 | *** jordank has joined #openmrs |
| 15:43:22 | *** khayam has quit IRC |
| 15:46:56 | *** h3llborn has joined #openmrs |
| 15:49:12 | *** vishal1tiwari has quit IRC |
| 15:53:51 | *** robbyoconnor has joined #openmrs |
| 15:53:51 | *** ChanServ sets mode: +v robbyoconnor |
| 16:01:12 | *** harsha89 has quit IRC |
| 16:08:24 | *** harsz89 has joined #openmrs |
| 16:18:50 | *** h3llborn has quit IRC |
| 16:28:20 | *** jordank has quit IRC |
| 16:30:11 | *** robbyoconnor has quit IRC |
| 16:30:37 | *** robbyoconnor has joined #openmrs |
| 16:30:37 | *** ChanServ sets mode: +v robbyoconnor |
| 16:33:54 | *** robbyoconnor has quit IRC |
| 16:34:18 | *** robbyoconnor has joined #openmrs |
| 16:34:18 | *** ChanServ sets mode: +v robbyoconnor |
| 16:46:48 | *** shangxiao has joined #openmrs |
| 17:05:51 | *** k-joseph has joined #openmrs |
| 17:06:13 | *** robbyoconnor has quit IRC |
| 17:06:37 | *** robbyoconnor has joined #openmrs |
| 17:06:37 | *** ChanServ sets mode: +v robbyoconnor |
| 17:07:23 | *** suranga__ has quit IRC |
| 17:07:50 | *** suranga__ has joined #openmrs |
| 17:08:58 | *** h3llborn has joined #openmrs |
| 17:11:15 | *** robbyoconnor has quit IRC |
| 17:11:34 | *** robbyoconnor has joined #openmrs |
| 17:11:34 | *** ChanServ sets mode: +v robbyoconnor |
| 17:21:32 | <h3llborn> hey guys whats up? |
| 17:30:45 | *** downey_ has joined #openmrs |
| 17:30:45 | *** ChanServ sets mode: +o downey_ |
| 17:30:51 | *** downey has quit IRC |
| 17:30:52 | *** downey_ is now known as downey |
| 17:37:43 | *** robbyoconnor has quit IRC |
| 17:38:09 | *** robbyoconnor has joined #openmrs |
| 17:38:09 | *** ChanServ sets mode: +v robbyoconnor |
| 17:44:59 | <wyclif> hi djazayeri |
| 17:45:15 | <djazayeri> wyclif: hey |
| 17:45:29 | <wyclif> djazayeri, i think am ready to work on the sprint |
| 17:45:47 | <wyclif> djazayeri, so you say i work on RA-37 |
| 17:46:42 | *** k-joseph has quit IRC |
| 17:46:56 | <djazayeri> wyclif: let's do voice. hangout actually |
| 17:52:10 | <dkayiwa> djazayeri: i have put a question on RA-22 |
| 17:52:13 | <dkayiwa> !ticket RA-22 |
| 17:52:15 | <OpenMRSBot> dkayiwa: [#RA-22] Create a reusable module containing utility functions - OpenMRS JIRA - https://tickets.openmrs.org/browse/RA-22 |
| 17:54:55 | <djazayeri> wyclif: create a new "coreapps" module |
| 17:55:16 | <djazayeri> wyclif: this will have a "find a patient" app and a "patient dashboard" app |
| 17:57:10 | *** robbyoconnor has quit IRC |
| 17:57:25 | *** djazayeri1 has joined #openmrs |
| 17:57:46 | <djazayeri1> dkayiwa: whoops, network glitch, if you asked the question already, please re-ask. :-) |
| 17:57:59 | <dkayiwa> djazayeri1: i asked on the ticket :) |
| 17:58:20 | <dkayiwa> djazayeri1: If this module is going to load MDS packages at start up, does it mean it should reference the metadata sharing API? If yes, isn't this making the module too heavy for simple reuse? |
| 17:58:29 | <djazayeri1> dkayiwa: hah, I didn't get the email notification yet. :-) |
| 17:58:45 | <dkayiwa> djazayeri1: ok asked ^^^ |
| 17:58:45 | <djazayeri1> dkayiwa: yes, we want to reference MDS. Even though that makes it heavy... |
| 17:58:53 | <dkayiwa> djazayeri1: ok |
| 17:59:31 | <djazayeri1> dkayiwa: if there turns out to be a real need to have this in a lighter module, we can address that later. |
| 17:59:33 | *** djazayeri has quit IRC |
| 17:59:46 | <dkayiwa> djazayeri1: so the package will have one item: VisitType |
| 17:59:49 | <dkayiwa> djazayeri1: correct? |
| 18:00:13 | *** rowanseymour has quit IRC |
| 18:00:51 | <djazayeri1> dkayiwa: actually…how about you just put that one-item package under /test |
| 18:00:57 | <djazayeri1> dkayiwa: it's a placeholder. |
| 18:01:26 | *** robbyoconnor has joined #openmrs |
| 18:01:26 | *** ChanServ sets mode: +v robbyoconnor |
| 18:02:24 | <dkayiwa> djazayeri1: so the activate only loads package.xml if it finds it. right? |
| 18:02:30 | <dkayiwa> activator |
| 18:02:35 | <djazayeri1> dkayiwa: yes |
| 18:03:54 | <dkayiwa> djazayeri1: do you have a sample of how such a visit type package looks like. I will have to look at the metadatasharing package source to get the expected xml format? |
| 18:05:23 | *** rajith has quit IRC |
| 18:11:14 | <djazayeri1> dkayiwa: just install the MDS moduleand create this. :-) |
| 18:11:25 | <djazayeri1> dkayiwa: through the UI |
| 18:11:28 | <dkayiwa> djazayeri1: ok :) |
| 18:14:39 | <mario_> djazayeri1, Darius, I'm receiving this exception when trying to start my local server |
| 18:14:41 | <mario_> djazayeri1, http://pastebin.com/MffzbVsa |
| 18:14:44 | *** sara has joined #openmrs |
| 18:16:13 | <mario_> djazayeri1, do you know why? |
| 18:16:56 | <djazayeri1> mario_: do you have the serialization.xstream module? |
| 18:17:03 | <mario_> djazayeri1, yes, I do |
| 18:17:39 | <djazayeri1> mario_: I wonder if some module is including that without saying scope=provided |
| 18:18:17 | <mario_> djazayeri1, also this is not a common error when a module is missing, I cannot see the login page. It show me a page with this stack trace |
| 18:18:18 | <djazayeri1> mario_: alternately, try deleting that tmp/openmrs-lib-cache folder, and restarting? |
| 18:18:37 | <mario_> djazayeri1, I'll try |
| 18:18:45 | *** r0bby has joined #openmrs |
| 18:18:45 | *** ChanServ sets mode: +v r0bby |
| 18:18:47 | *** sara has quit IRC |
| 18:20:53 | *** robbyoconnor has quit IRC |
| 18:21:24 | <mario_> djazayeri1, where this folder lives? I couldn't find this folder |
| 18:22:48 | <djazayeri1> mario_: hmm, maybe it's a temp file. is it possible that there was an error at startup which is more meaningful but you have to look back to the logs at startup? |
| 18:25:21 | <mario_> djazayeri1, there is this error as well "Caused by: java.lang.NoClassDefFoundError: Lorg/openmrs/module/idgen/IdentifierSource;" |
| 18:25:28 | <mario_> djazayeri1, but I also have idgen module |
| 18:25:41 | <mario_> djazayeri1, the version is 2.5-SNAPSHOT |
| 18:26:40 | <mario_> djazayeri1, and a error about the report module, trying to do an alter table. I think I saw this error on Mirebalais too |
| 18:30:21 | <mario_> djazayeri1, and also this error "WARN - ModuleFactory.startModuleInternal(605) |2013-04-04 14:17:43,917| Error while trying to start module: referenceapplication |
| 18:30:21 | <mario_> org.openmrs.module.ModuleException: Module requires version between 1.9.4 and , Current code version is 1.9.4.3e493c" |
| 18:31:08 | <djazayeri1> mario_: hmm, looks like there's a bug in OpenMRS core here... |
| 18:31:39 | <mario_> djazayeri1, really? Should I open a ticket? |
| 18:31:42 | <djazayeri1> mario_: sorry, on a call now |
| 18:31:47 | *** k-joseph has joined #openmrs |
| 18:31:49 | <mario_> djazayeri1, sorry, no problem |
| 18:31:58 | <djazayeri1> wyclif or dkayiwa: do you know the answer to the above from mario? |
| 18:33:22 | <wyclif> djazayeri1, that is the problem i ran into the othe rday |
| 18:33:35 | <djazayeri1> wyclif: tell mario_ :-) |
| 18:33:37 | <wyclif> djazayeri1, mario_there might be a ticket for it already |
| 18:33:44 | <wyclif> djazayeri1, mario_ let me look |
| 18:33:47 | <djazayeri1> (also, what's the workaround) |
| 18:34:00 | <mario_> wyclif, thanks dude :) |
| 18:36:02 | <wyclif> mario_, i had to tweak the code in ModuleFactory.requiredModulesStarted to always return true |
| 18:36:16 | <wyclif> mario_, just to get unblocke |
| 18:36:19 | <wyclif> mario_, just to get unblocked |
| 18:36:44 | <mario_> wyclif, makes sense. I'll try to do the same. Thanks dude |
| 18:36:48 | <djazayeri1> wyclif, mario_: what thing (was it core, or a module) just had a build number added? |
| 18:36:56 | <djazayeri1> and can we remove that build number? |
| 18:37:24 | *** Hasintha_i has quit IRC |
| 18:37:31 | <mario_> djazayeri1, probably is a module, otherwise it would gonna break Mirebalais as well, right? |
| 18:38:22 | <mario_> djazayeri1, WARN - ModuleFactory.startModuleInternal(605) |2013-04-04 14:17:43,917| Error while trying to start module: referenceapplication |
| 18:38:31 | <mario_> wyclif, ^^ |
| 18:38:51 | *** ningosi has joined #openmrs |
| 18:39:11 | *** r0bby has quit IRC |
| 18:39:16 | <wyclif> djazayeri1, as Darius said, you could remove the revisionNumber in the root pom of openmrs 1.9.x branch |
| 18:39:31 | <wyclif> mario_, , as Darius said, you could remove the revisionNumber in the root pom of openmrs 1.9.x branch |
| 18:40:28 | *** ningosi is now known as Ojwanganto |
| 18:40:59 | *** davidpardz has left #openmrs |
| 18:41:19 | <wyclif> mario_, might be related to this ticket https://tickets.openmrs.org/browse/TRUNK-3751 |
| 18:43:53 | <mario_> wyclif, yeah. I'm taking a look to identify exaclty what is happening |
| 18:51:03 | <mario_> wyclif, djazayeri1 I got the error. The other modules do not have this error because they are not based on a snapshot version. |
| 18:51:34 | <mario_> wyclif, djazayeri1 however, the referenceapplication module is a snapshot version |
| 18:51:47 | <wyclif> mario_, there is something in MDS module that rafal used that performs version comparisons better |
| 18:52:02 | <mario_> wyclif, djazayeri1 so it breaks the application. It is related to that ticket as you said Wyclif |
| 18:52:07 | <wyclif> mario_, it is what we need to use in core, let me get you the link in the module |
| 18:52:31 | <djazayeri1> wyclif: can we actually fix the core bug and backport to 1.9.x now? |
| 18:52:50 | <djazayeri1> (sorry, only paying 5% attention) |
| 18:53:23 | <wyclif> mario_, https://github.com/openmrs/openmrs-module-metadatasharing/blob/master/api-common/src/main/java/org/openmrs/module/metadatasharing/util/Version.java |
| 18:53:31 | <OpenMRSBot> <http://ln-s.net/+x$I> (at github.com) |
| 18:54:29 | <wyclif> djazayeri1, mario_ see the link above, that does better version comparison and it is what we need to use in ModuleUtil.compareVersions |
| 18:55:22 | <mario_> wyclif, djazayeri1 but this in the metadatasharing module right? It would be easy move this class to core? |
| 18:55:54 | <wyclif> mario_, am suggesting we copy that class to core and use in ModuleUtil.compareVersions |
| 18:56:37 | *** shangxiao has quit IRC |
| 18:57:16 | <mario_> wyclif, but in this case we would have duplicate code. Is it hard to move? Also we would need to change module class to return a Version class instead of a String |
| 18:57:52 | <mario_> wyclif, maybe we could fix it now only to accept snapshot version and create a ticket to move this class. What do you think? |
| 18:57:55 | <wyclif> mario_, yes we will have to have duplicate code, there is nothing we can do about it to get into core |
| 18:58:47 | <mario_> wyclif, but if we have in core, we don't need to have on metadasharing, right? |
| 18:58:57 | <wyclif> mario_, moving specific code from a module to core will definitely cause duplication probably, in any case no everyone runs mds |
| 18:59:10 | <wyclif> mario_, not everyone runs medatasharing |
| 18:59:35 | *** andreapat has joined #openmrs |
| 18:59:38 | <mario_> wyclif, exactly. But that's my suggestion, remove this class from metadasharing module and create the same on core |
| 19:00:14 | <wyclif> mario_, we are just 'borrowing' that code we cant remove it from mds otherwise you will have to change things and required version in mds |
| 19:00:16 | *** rowanseymour has joined #openmrs |
| 19:01:04 | <wyclif> mario_, may be creating a ticket to remove it from mds in a late |
| 19:01:11 | <wyclif> mario_, may be creating a ticket to remove it from mds later |
| 19:01:51 | <mario_> wyclif, I agree with that. So my suggestion it would be to have a quick fix for accept snapshopt versions and we can create a ticket where the story is about to move this class to core and remove from metadatasharing. Does that makes sense? |
| 19:02:20 | <mario_> wyclif, we can do this ticket later on and do a quick fix now :-D |
| 19:02:34 | <cpower> hello everyone are we ready to scrum? |
| 19:02:56 | <andreapat> cpower, hello |
| 19:03:00 | <cpower> Silence is golden... |
| 19:03:06 | <cpower> !scrumon cpower |
| 19:03:06 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 19:05:33 | <cpower> Order: mseaton , rafa , andreapat , djazayeri_, dkayiwa, wyclif, Vishal Tiwari,Harsha Kumara, Arkadiusz Kołodziejski, Chris Niesel,Garima Ahuja,Mohd Khayam Uddin |
| 19:05:37 | <wyclif> mario_, removing it from metadatasharing is not straightforward as you might think because MDS might be run on an openmrs version where the class doesnt exist, mds supports a bunch of old versions of openmrs, and it would mean you have to make release mds |
| 19:06:06 | <cpower> Sara Fatima, Guilherme Cavalcanti, and Lluis! |
| 19:06:13 | <wyclif> mario_, rafa as the mds lead developer, can take care of that |
| 19:06:23 | <wyclif> mario_, as long as you leave behind a ticket |
| 19:06:41 | <cpower> mseaton: you are up |
| 19:06:54 | <mseaton> no update. no blockers. |
| 19:07:07 | <cpower> ok... rafa |
| 19:07:11 | <rafa> Today: |
| 19:07:11 | <rafa> * Merged/reviewed pull requests |
| 19:07:11 | <rafa> * Fixed MDS build |
| 19:07:11 | <rafa> * Experimented with git submodules |
| 19:07:11 | <rafa> * Worked on META-329: Concept Numerics don't import properly |
| 19:07:11 | <rafa> https://tickets.openmrs.org/browse/META-329 (still unsure what is causing it, playing further with a debugger right now) |
| 19:07:11 | <rafa> * Dev Forum |
| 19:07:12 | <rafa> No blockers. |
| 19:07:23 | <andreapat> Wednesday/Thursday morning |
| 19:07:23 | <andreapat> Design call |
| 19:07:23 | <andreapat> Dev call |
| 19:07:23 | <andreapat> Merck stuff |
| 19:07:23 | <andreapat> Ticket TRUNK-3751 |
| 19:07:23 | <andreapat> Saying that a module requires OpenMRS 1.9.2-SNAPSHOT fails |
| 19:07:25 | <andreapat> Wrote Unit test to recreate bug |
| 19:07:27 | <andreapat> Added new test for SNAPSHOT in ModuleUtil.checkRequiredVersion() |
| 19:07:29 | <andreapat> |
| 19:07:31 | <andreapat> Thursday afternoon |
| 19:07:32 | *** draggonz has quit IRC |
| 19:07:33 | <andreapat> Finish work on Ticket TRUNK-3751 |
| 19:07:35 | <andreapat> Pick new ticket |
| 19:07:37 | <andreapat> No Blockers |
| 19:07:39 | <andreapat> Discussion - would like to test in UI - how do I do this? |
| 19:07:41 | *** h3llborn has quit IRC |
| 19:07:41 | <andreapat> Getting error starting openmrs: |
| 19:07:43 | <andreapat> Error occurred while trying to get the updates needed for the database. |
| 19:08:06 | <cpower> djazayeri |
| 19:08:27 | <djazayeri1> * Working on RA-36 (Refactoring PIH's EMR module into a new OpenMRS EMR API module)...this is a huge ticket |
| 19:08:27 | <djazayeri1> * Calls |
| 19:08:27 | <djazayeri1> * Calls |
| 19:08:27 | <djazayeri1> * More calls |
| 19:08:34 | <djazayeri1> * (Still on one) |
| 19:08:49 | <cpower> dkayiwa: you are up |
| 19:09:00 | <dkayiwa> Responded to review comments for: Set up CI plan for uicommons module - RA-26 |
| 19:09:01 | <dkayiwa> Set up CI plan for logic module - RA-32 |
| 19:09:01 | <dkayiwa> Dev Call |
| 19:09:01 | <dkayiwa> Now: Create a reusable module containing utility functions - RA-22 |
| 19:09:01 | <dkayiwa> No Blockers |
| 19:09:26 | <cpower> wyclif: you are up |
| 19:09:28 | <wyclif> Wednesday: |
| 19:09:29 | <wyclif> -Create CI plan for referenceapplication module |
| 19:09:29 | <wyclif> -Make AppFrameWorkService a top-level bean - AF-13 |
| 19:09:29 | <wyclif> -Design call |
| 19:09:29 | <wyclif> -Attended RG Work In Progress |
| 19:09:29 | <wyclif> -Completed and committed RA-7 - Reference Application login pages |
| 19:09:33 | <wyclif> Thursday: |
| 19:09:35 | <wyclif> -dev call |
| 19:09:37 | <wyclif> -Google hangout with sprinters |
| 19:09:39 | <wyclif> -RA-37 - Create core apps module including a CI plan for it |
| 19:09:41 | <wyclif> |
| 19:09:43 | <wyclif> Blockers: None |
| 19:10:54 | <cpower> I listed all the others who have been working on tickets the past 24hrs in a list after the sprinters. If any of you would like to give an update, this is your chance to tell us the good work you've done and ask questions if necessary. |
| 19:12:28 | <cpower> Discussion point: Where is a wiki or place to andreapat how to test |
| 19:13:42 | <cpower> Does anyone have some help for andreapat on how to test UI? |
| 19:13:46 | *** jblaya has joined #openmrs |
| 19:13:47 | <andreapat> cpower: just got error - Error occurred while trying to get the updates needed for the database. Validation Failed: 2 change sets check sum liquibase-update-to-latest.xml::3-increase-privilege-col-size-pers |
| 19:14:24 | <rafa> andreapat: you need to cleanup the liquibasechangelog table |
| 19:14:28 | <djazayeri1> andreapat: per that error, I believe it's related to the email thread that Wyclif, Daniel, and Lluis just had |
| 19:14:38 | <rafa> andreapat: see a thread on the dev list started by Lluis |
| 19:15:07 | <andreapat> rafa, djazayeri, ok thanks |
| 19:15:12 | <cpower> On that note, thank you all! |
| 19:15:15 | <djazayeri1> andreapat: if that thread doesn't have sufficiently clear instructions, then please clarify here, and reply to the thread with those specific instructions for future people who run into it |
| 19:15:15 | <cpower> !scrumoff |
| 19:15:15 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 19:15:27 | <djazayeri1> andreapat: I don't understand the question about "how to test in ui"? |
| 19:16:17 | <mario_> wyclif, I don't get why is so complicated. The olders version of mds should support the olders version of OpenMRS core, right? |
| 19:16:18 | <andreapat> djazayeri, make the version SNAPSHOT-1.9.2 |
| 19:16:48 | <mario_> wyclif, so I don't see why this is so complicated. I agree that we would have to release a new version of mds, but other than that, it should be simple |
| 19:16:50 | <wyclif> mario_, i understand what you are saying , let me try to summarize what the run in will be |
| 19:17:03 | <andreapat> djazayeri, actually - 1.9.2-SNAPSHOT |
| 19:18:14 | <djazayeri1> andreapat: Is your question "How do I test out in the UI whether my fix actually solves TRUNK-3751?" |
| 19:19:26 | <djazayeri1> andreapat: if so… (1) create a new module, or check out an existing one, and in its config.xml set its openmrs require version to be 1.9.4-SNAPSHOT. (2) Run OpenMRS 1.9.x, and try uploading that module through the UI |
| 19:19:30 | <wyclif> mario_, mds supports openmrs versions back up to 1.6.6, if you removed the class, it would mean mds wont run on all other supported versions e.f 1.7.1, 1.7.3,1.8.3 |
| 19:19:43 | <djazayeri1> andreapat: (you could substitute 1.10-SNAPSHOT instead.) |
| 19:19:50 | <djazayeri1> andreapat: (and run trunk) |
| 19:19:56 | <djazayeri1> andreapat: (I mean: and run master) |
| 19:20:23 | <wyclif> mario_, it would mean mds would have to require 1.9.4+ which we dont want to do |
| 19:20:38 | <wyclif> mario_, because we need to support older versions |
| 19:21:28 | <andreapat> djazayeri, yes that was my question - thanks but looking at thread in dev list - looks like it is still a problem |
| 19:21:34 | <burke> mseaton: is it possible for a data definition (column) depend on another column and see that other column's value when doing its calculation? |
| 19:21:37 | <wyclif> mario_, otherwise we will have to backport the change to all their respective maintenance branches, FYI some reached EOL |
| 19:22:13 | <wyclif> mario_, meaning you technically dont want to backport to them |
| 19:22:17 | <djazayeri1> wyclif, mario_: is the actual problem in MDS? Why do we think that? |
| 19:22:25 | <andreapat> djazayeri, think there is a work around - will try |
| 19:22:28 | <mario_> wyclif, got it. Will we always gonna have to support those versions on the latest version of mds? |
| 19:22:37 | <burke> mseaton: we need to suprress a "date elegible" if it's after another date in the report. |
| 19:22:48 | <wyclif> mario_, for now until i dont know when |
| 19:23:07 | <mario_> djazayeri1, wyclif it is not there. The error is because the reference application has a snapshot version |
| 19:23:28 | <djazayeri1> mario_: is the error that the reference application requires openmrs 1.9.4-SNAPSHOT? |
| 19:23:46 | <mario_> djazayeri1, wyclif and the code of OpenMRS core doesn't not support to compare snapshot version. So wyclif said that there is a better comparator on mds |
| 19:23:50 | <djazayeri1> mario_: could you instead (as the workaround) change it to require 1.9.3 instead (in config.xml)? |
| 19:24:04 | <wyclif> djazayeri1, actually mds has nothing to do with this, we are just trying to say that we should copy some class from mds that does version comparisons in a much smater way |
| 19:24:11 | <wyclif> djazayeri1, smarter |
| 19:24:38 | <mseaton> burke: yes it is certainly possible, but there is nothing generic to handle it. there is one built-in instance where this is done: |
| 19:24:41 | <mseaton> burke: https://github.com/openmrs/openmrs-module-reporting/blob/master/api/src/main/java/org/openmrs/module/reporting/data/person/definition/AgeAtDateOfOtherDataDefinition.java |
| 19:24:44 | <OpenMRSBot> <http://ln-s.net/+x+G> (at github.com) |
| 19:25:26 | <burke> mseaton: cule. thx. |
| 19:25:28 | <wyclif> djazayeri1, mario_ revision numbers and SNAPSHOT should be ignored when comparing versions basically as mds Version comparison works |
| 19:25:30 | <djazayeri1> mseaton, burke: I assume you're not literally looking at the value in the other column, but rather you're re-running the data definition again (but it's presumably cahced) |
| 19:25:42 | <mario_> djazayeri1, yeah, but how many developer will gonna face this problem? All of them would need to have to do this workaround. |
| 19:25:51 | <mario_> developers* |
| 19:26:03 | <djazayeri1> mario_: andreapat is currently fixing this exact bug |
| 19:26:08 | <mseaton> djazayeri1: burke : yes, this is designed such that you are "evaluating" the other definition again, but it will use the cached value |
| 19:26:16 | <mario_> djazayeri1, awesome :) |
| 19:26:18 | <djazayeri1> mario_: that's why you should just do the workaround. :-) |
| 19:26:31 | <djazayeri1> wyclif: (this is the same bug as the ticket that andreapat is working on, right?) |
| 19:26:32 | <mario_> djazayeri1, makes sense. I'll do |
| 19:27:38 | <wyclif> djazayeri1, correct and am suggestiogn she uses the mds Version class by copying it over to core, it does a great job in comparing versions |
| 19:27:40 | <mario_> djazayeri1, wyclif I have a meeting now, I gotta go |
| 19:27:45 | <wyclif> mario_, cool |
| 19:28:03 | <wyclif> djazayeri1, does it make sense to you? |
| 19:28:18 | <mario_> wyclif, thanks for the explanation, btw |
| 19:28:25 | <wyclif> mario_, bo problem |
| 19:28:30 | <djazayeri1> andreapat: did you already know that? (About copying the MDS compare Versions function, mentioned above?) ^^ |
| 19:28:30 | <wyclif> mario_, no problem |
| 19:28:33 | *** harsz89 has quit IRC |
| 19:29:21 | <andreapat> djazayeri1, no didn't know |
| 19:29:55 | <djazayeri1> wyclif: I agree in principle (though I haven't looked at the MDS code), so could you please comment on andreapat's ticket pointing to it? |
| 19:30:20 | <andreapat> djazayeri, wyclif, yes please do |
| 19:31:35 | <djazayeri1> gotta get lunch now |
| 19:32:36 | <wyclif> djazayeri1, andreapat am going to add the link to the ticket, it is at https://github.com/openmrs/openmrs-module-metadatasharing/blob/master/api-common/src/main/java/org/openmrs/module/metadatasharing/util/Version.java |
| 19:32:36 | <OpenMRSBot> <http://ln-s.net/+x$I> (at github.com) |
| 19:34:23 | *** rowanseymour has quit IRC |
| 19:37:31 | *** h3llborn has joined #openmrs |
| 19:38:14 | *** rowanseymour has joined #openmrs |
| 19:39:12 | *** k-joseph has quit IRC |
| 19:41:02 | <wyclif> andreapat, i have added the links to the classes you need to copy to core from MDS to the ticket, seems like a quick fix now |
| 19:41:35 | *** harsz89 has joined #openmrs |
| 19:42:52 | <andreapat> wyclif, ok will look at it - how do I get core code to call new code instead of checkRequiredVersion? |
| 19:45:12 | *** k-joseph has joined #openmrs |
| 19:50:23 | <jblaya> guys, I'm having a problem with mvn, for the same module which builds on one computer, get's a can't find jar error in another computer, even after I copied the .m2/repository folder from the computer where it works to the other one |
| 19:50:29 | <jblaya> anyone have an idea how to fix this? |
| 19:54:54 | *** rowanseymour has quit IRC |
| 19:55:15 | <h3llborn> whats the error jblaya ? |
| 19:56:16 | <jblaya> plugin org.apache.maven.plugins:maven-surefire-plugin:2.10 or one of its dependencies could not be resolved |
| 19:57:32 | <jblaya> h3llborn, I'm seeing on google that I should de a mvn dependency::tree... |
| 19:57:54 | <h3llborn> hmm sounds ike you're just missing something |
| 19:59:08 | <jblaya> h3llborn, which is weird because the code compiles on another repo, but I found on google to add the repository forplay.googlecode.com/svn/mavenrepo |
| 19:59:23 | <h3llborn> what os are you on? |
| 19:59:32 | <jblaya> ubuntu 12.04 |
| 19:59:50 | <h3llborn> thats really odds, what ide do you have? |
| 20:00:36 | <jblaya> eclipse |
| 20:00:41 | <jblaya> latest verion, I think juno |
| 20:00:53 | <jblaya> indigo actually |
| 20:00:59 | <h3llborn> same |
| 20:01:13 | <h3llborn> thats really weird, how was it installed? |
| 20:03:27 | *** Ojwanganto has quit IRC |
| 20:04:14 | <andreapat> wyclif, sent you an email re Version.java |
| 20:04:49 | <jblaya> installed through ubuntu software |
| 20:04:58 | <jblaya> then put the eclipse-openmrs dropins |
| 20:05:14 | <jblaya> and started eclipse, downloaded the code, tried to compile and wham |
| 20:05:23 | <jblaya> I'm installing maven independently now |
| 20:05:36 | <jblaya> and will try adding that repository |
| 20:06:16 | <h3llborn> did java install on its own or not? |
| 20:06:31 | <wyclif> andreapat, just get rid of the code in ModuleUtil.compareVersions and use the Version class to compare them |
| 20:07:12 | <jblaya> it came with ubuntu and it's 1.6.0_27 |
| 20:07:18 | <jblaya> I'll try updating to 7 |
| 20:07:21 | <h3llborn> kk |
| 20:08:40 | <breeze> I have a question about bundled modules if any one can help |
| 20:08:51 | <jkeiper> breeze: shoot |
| 20:09:20 | <h3llborn> pow pow |
| 20:09:48 | <breeze> jkeiper: so if I want to "preinstall" a module should the omod file be placed in |
| 20:09:48 | <breeze> /usr/share/tomcat6/.OpenMRS/modules/ or {tomcat.home}/webapps/openmrs/WEB-INF/bundledModules |
| 20:09:49 | * jkeiper leans back waving arms dramatically |
| 20:10:03 | <jkeiper> o |
| 20:10:33 | <h3llborn> !beerme |
| 20:10:33 | <OpenMRSBot> h3llborn: (beerme <an alias, 1 argument>) -- Alias for "action slides $1 a pint". |
| 20:10:55 | <h3llborn> !cokeme |
| 20:10:55 | * OpenMRSBot Drugs are bad |
| 20:10:59 | <jkeiper> breeze: placing the module there will clue openmrs into starting it, unless there is a global property indicating it should not be started |
| 20:11:12 | <breeze> which dir? |
| 20:11:20 | <jkeiper> breeze: and i would say the .OpenMRS/modules/ folder |
| 20:11:36 | <downey> the tomcat6 user's home directory is used for only user-installed modules |
| 20:11:55 | <downey> modules which ship with a "distribution" of openmrs only appear in the bundledModules dir |
| 20:12:03 | <jkeiper> breeze: if you want it included in the war file, you'd compile it in and i think they go somewhere in the webapp module |
| 20:12:23 | <jkeiper> breeze: wyclif might know exactly where |
| 20:12:25 | <breeze> jkeiper: the tomcat home dir I gave you meant to be under the webapp dir of tomcat |
| 20:12:49 | <jkeiper> breeze: yes, but that folder might be overwritten if you redeploy a newer version of openmrs |
| 20:12:52 | <breeze> but looks like the .OpenMRS/modules dir is giving me better luck |
| 20:12:53 | <jkeiper> i think ... |
| 20:13:34 | <downey> "Some releases of OpenMRS come with modules already prepackaged into them. These modules are packaged into the war file when it is being built if the omods are in the /webapp/src/main/webapp/WEB-INF/bundledModules folder." -- bwolfe |
| 20:13:37 | <breeze> jkeiper: ok...good point, but I think with the reference app the idea is to update webapp and modules together |
| 20:13:55 | <breeze> downey: thanks |
| 20:14:12 | <downey> bundledModules can still be uninstalled by the user though |
| 20:14:15 | <downey> see https://wiki.openmrs.org/display/docs/Bundling+Modules for details |
| 20:14:57 | <jkeiper> breeze: yes, i think it would essentially follow the bundled module model ... |
| 20:15:11 | <jkeiper> breeze: but djazayeri1 might have already thought this through? |
| 20:16:26 | <djazayeri1> breeze, jkeiper: I am of two minds about this |
| 20:16:28 | <breeze> jkeiper: hmm...well let me explain what I was hoping would work.....drop an omod file in the /WEB-INF/bundledModules after the war has been deployed to tomcat, then restart tomcat and module is installed |
| 20:16:46 | <djazayeri1> one option is that we merely copy omod files into the openmrs appdata directory (not the one under WEB-INF) |
| 20:17:06 | <djazayeri1> another option is that we put in bundledmodules, building a custom war |
| 20:17:09 | <jkeiper> breeze: yeah, i think the .OpenMRS/modules/ folder is more along the lines of what you're saying ... it wouldn't be "bundled" then |
| 20:17:18 | <breeze> ok |
| 20:17:20 | <wyclif> hi breeze |
| 20:17:50 | <breeze> jkeiper: yeah that seems to look more promsing with my approach |
| 20:17:54 | <breeze> hi wyclif |
| 20:18:08 | <downey> 99.9% of times openmrs server installations don't install without errors complaining about permissions to the tomcat user's home directory |
| 20:18:34 | <jkeiper> wyclif: i was just saying you might know better where to put a bundled module, but downey found a link for us |
| 20:19:29 | <jblaya> h3llborn, wyclif, djazayeri1, I'm getting the following error in the module Failed to execute goal on project programmablealerts-api: Could not resolve dependencies for project org.openmrs.module:programmablealerts-api:jar:1.0.2: Could not find artifact org.openmrs.test:openmrs-test:jar:1.9.1 in openmrs-repo (http://mavenrepo.openmrs.org/nexus/content/repositories/public) |
| 20:19:30 | <OpenMRSBot> <http://ln-s.net/8-2X> (at mavenrepo.openmrs.org) |
| 20:19:37 | *** k-joseph has quit IRC |
| 20:19:55 | <wyclif> by default bundled modules are located under WEB-INF/bundledModules folder, but even if you placed them in .OpenMRS/modules, they would still be found |
| 20:20:01 | <jblaya> h3llborn, wyclif, djazayeri1, any ideas because that module builds fine in the other computer |
| 20:20:04 | <breeze> downey: this is the snippet of a post install script to give you an idea of where I was going |
| 20:20:05 | <breeze> cp ${OmodTmpDir}/** ${BundledModulesDir} |
| 20:20:05 | <breeze> chown -R tomcat6:tomcat6 ${BundledModulesDir} |
| 20:20:29 | <djazayeri1> breeze: yeah, following that approach I'd put them in the openmrs appdata directory |
| 20:21:07 | <wyclif> jblaya, it might be that the test jar were not deployed into nexus for 1.9.1 let me check and get back to you |
| 20:21:11 | <djazayeri1> wyclif: nope |
| 20:21:12 | <downey> breeze: yeah i think that approach would work. the problem is you can't even normally install openmrs without first changing permissions on that users home dir so .OpenMRS can even be created during the initial setup |
| 20:21:16 | <djazayeri1> wyclif: I just looked. They are there |
| 20:21:52 | <jblaya> wyclif, I checked on the site, and this is what I find http://mavenrepo.openmrs.org/nexus/content/repositories/public/org/openmrs/test/openmrs-test/1.9.1/ |
| 20:21:59 | <djazayeri1> breeze, downey: I think the point would be to use the puppet script or dpkg to create the directory, instead of having OpenMRS create it during startup |
| 20:22:05 | <wyclif> djazayeri1, then one of the pom files might be missing the dependency |
| 20:22:15 | <wyclif> jblaya, , then one of the pom files might be missing the dependency |
| 20:22:19 | <jblaya> wyclif, and when I build it for the same openmrs version in another computer it works |
| 20:22:24 | <breeze> downey: that part hasn't been a problem so far. I am doing this via a deb package btw |
| 20:22:35 | <breeze> which needs a sudo to work already |
| 20:22:43 | <jblaya> wyclif, and it also didn't work for 1.6.2 or 1.9.2.... sorry this is such a mess... |
| 20:22:51 | <jblaya> wyclif, should I try another version? |
| 20:23:04 | <wyclif> jblaya, probably not |
| 20:23:29 | <downey> wyclif: that reminds me, any news about https://tickets.openmrs.org/browse/TRUNK-3492 ? |
| 20:23:39 | <wyclif> jblaya, when you look under your maven repo, do you actually have that jar file? |
| 20:23:58 | <jblaya> in .m2/repository? |
| 20:24:06 | <jblaya> wyclif, in .m2/repository? |
| 20:24:32 | <wyclif> jblaya, yeah, on the computer where is it failing |
| 20:25:12 | <wyclif> jblaya, yeah, on the computer where it is failing |
| 20:25:23 | <andreapat> wyclif, compareVersion takes 2 args, version and value (from config.xml) - version(version) takes only version |
| 20:25:30 | <breeze> djazayeri1, downey: if you've got an ubuntu installation handy with tomcat installed and want to see: https://ci-stg.openmrs.org/browse/REFAPP-OMODDISTRO-20/artifact/shared/Reference-Application-DEB-package/openmrs-1.9.20.deb |
| 20:25:37 | <jblaya> wyclif, I have openmrs-test-1.x.x.pom and .jar.lastUpdated, but not the .jar file |
| 20:25:54 | <jblaya> wait for 1.6.2 i do thave the openmrs-test-1.6.2.jar |
| 20:26:05 | <djazayeri1> andreapat: you'd do something like: return new Version(arg1).compareTo(new Version(arg2); |
| 20:26:30 | <wyclif> jblaya, that is the problem, but it should be able to load from the remote nexus repo still |
| 20:27:19 | <jblaya> wyclif, agreed, so what can I do to fix this? |
| 20:28:04 | <wyclif> maven should be able to pull the jar file from nexus, so i dont understand why it is isnt doing so |
| 20:28:23 | <jblaya> wyclif, actually just did a force on 1.6.2 and it worked |
| 20:28:44 | <djazayeri1> jblaya: is there a proxy server you're behind, or some funky firewall? |
| 20:29:32 | <jblaya> djazayeri1, our firewall doesn't permit some output traffic, but everything over http and https |
| 20:29:36 | <jblaya> djazayeri1, no proxy |
| 20:29:53 | <jblaya> djazayeri1, but it is weird that it works now on 1.6.2, but not on 1.9.1 or 1.8.2 |
| 20:30:06 | <andreapat> djazayeri1, good plan! thanks |
| 20:30:31 | <wyclif> djazayeri1, jblaya the problem is that there is no jar file actually at http://mavenrepo.openmrs.org/nexus/content/repositories/public/org/openmrs/test/openmrs-test/1.9.1/ |
| 20:31:05 | <wyclif> jblaya, do you have openmr-core checked out? |
| 20:31:23 | <jblaya> wyclif, djazayeri1, ah ok, well, I have my module working, but I'm guessing that should be fixed, and no I don't have openmrs-core on the computer where it's not working |
| 20:31:39 | <jblaya> wyclif, djazayeri1 but I do have it on the one that is |
| 20:31:55 | <jblaya> wyclif, djazayeri1, so I will check it out to not have this problem anymore, thanks! |
| 20:32:45 | <wyclif> jblaya, do you mind creating a ticket to deploy the 1.9.1 test jar to nexus? |
| 20:33:07 | <jblaya> wyclif, no problem, should that be under the jira project core? |
| 20:33:46 | <wyclif> jblaya, i think in the oast i have had to switch to 1.9.1 tag, run mvn package to have the artifacts created in my local repo |
| 20:34:29 | <djazayeri1> wyclif: if you ever find yourself doing something like that, please raise the JIRA ticket yourself so we can solve the issue! |
| 20:34:38 | <wyclif> jblaya, or someone just need to deply the artifact to nexus |
| 20:34:56 | <jblaya> wyclif, if I knew how to do it I would :D |
| 20:35:10 | <wyclif> jblaya, i will deploy it later today |
| 20:35:25 | <jblaya> wyclif, I will create the jira ticket, shoudl I do it on the project core in Jira? |
| 20:35:53 | <wyclif> jblaya, yes |
| 20:36:27 | <wyclif> jblaya, actually i can do it tomorrow |
| 20:36:48 | <jblaya> wyclif, no problem, now that I solved this, it's not an emergency |
| 20:39:19 | <jblaya> wyclif, done, here it is https://tickets.openmrs.org/browse/TRUNK-3953 |
| 20:39:33 | <wyclif> jblaya, thanks |
| 20:40:45 | <andreapat> djazayeri1, wyclif - so back to question - where in core do I copy Version.java to? |
| 20:42:22 | *** downey has quit IRC |
| 20:43:16 | <andreapat> djazayeri1, wyclif? Where is proper place to put Version.java so ModuleUtil can use it? |
| 20:43:29 | <djazayeri1> andreapat: in the util package |
| 20:43:41 | *** rafa has quit IRC |
| 20:44:03 | <andreapat> djazayeri, that was my guess but thanks for verifying |
| 20:48:46 | *** sgithens has joined #openmrs |
| 20:48:48 | *** h3llborn has quit IRC |
| 21:00:13 | *** r0bby has joined #openmrs |
| 21:00:13 | *** ChanServ sets mode: +v r0bby |
| 21:04:42 | *** andreapat has quit IRC |
| 21:12:37 | *** wyclif has quit IRC |
| 21:12:46 | *** jblaya has quit IRC |
| 21:17:51 | *** andreapat has joined #openmrs |
| 21:26:22 | *** breeze has quit IRC |
| 21:30:54 | *** dkayiwa has quit IRC |
| 21:38:16 | *** andreapat has quit IRC |
| 21:40:24 | *** sgithens has quit IRC |
| 21:46:27 | *** suranga__ has quit IRC |
| 22:02:45 | *** nyoman has quit IRC |
| 22:36:14 | *** wyclif has joined #openmrs |
| 22:54:30 | *** rel has joined #openmrs |
| 22:54:32 | *** rel is now known as nimby |
| 23:03:30 | *** djazayeri1 has quit IRC |
| 23:44:56 | *** andreapat has joined #openmrs |
| 23:45:17 | <andreapat> djazayeri1, you here? |
| 23:50:02 | *** r0bby has quit IRC |
| 23:52:15 | *** sgithens has joined #openmrs |
| 23:52:52 | *** andreapat has quit IRC |