00:00:47
|
*** robbyoconnor has joined #openmrs
|
00:00:47
|
*** ChanServ sets mode: +v robbyoconnor
|
00:04:48
|
*** robbyoconnor has quit IRC
|
00:08:47
|
*** robbyoconnor has joined #openmrs
|
00:08:47
|
*** ChanServ sets mode: +v robbyoconnor
|
00:25:18
|
*** h3llborn has quit IRC
|
00:40:01
|
*** mseaton has joined #openmrs
|
00:40:01
|
*** ChanServ sets mode: +v mseaton
|
00:40:13
|
*** rajiths has joined #openmrs
|
00:44:58
|
*** davidpardz has joined #openmrs
|
00:45:42
|
*** breeze has quit IRC
|
00:48:16
|
*** nheck has joined #openmrs
|
00:49:41
|
*** rajiths has quit IRC
|
01:04:52
|
*** ojwangantony_ has joined #openmrs
|
01:23:51
|
*** Upeksha has joined #openmrs
|
01:34:57
|
*** Upeksha has quit IRC
|
01:40:14
|
*** harshadura has quit IRC
|
01:40:29
|
*** mseaton has left #openmrs
|
01:42:04
|
*** Guest71777 is now known as mseaton
|
01:48:55
|
*** h3llborn has joined #openmrs
|
01:52:41
|
*** harshadura has joined #openmrs
|
01:52:41
|
*** ChanServ sets mode: +v harshadura
|
02:02:03
|
*** nheck has quit IRC
|
02:06:07
|
*** portablejim has joined #openmrs
|
02:09:27
|
*** h3llborn has quit IRC
|
02:30:28
|
*** djazayeri1 has quit IRC
|
02:40:57
|
*** harshadura has quit IRC
|
03:12:10
|
*** harsz89 has joined #openmrs
|
03:25:01
|
*** Upeksha has joined #openmrs
|
04:06:56
|
*** Anuruddha has joined #openmrs
|
04:22:10
|
*** kavuri has joined #openmrs
|
04:27:32
|
*** jkeiper_ has quit IRC
|
04:31:53
|
*** suranga_ has quit IRC
|
04:40:41
|
*** dammina_ has joined #openmrs
|
04:49:54
|
*** lh has quit IRC
|
05:08:18
|
*** jb360 has quit IRC
|
05:11:04
|
*** jb360 has joined #openmrs
|
05:16:17
|
*** dammina_ has quit IRC
|
05:47:05
|
*** joeseff has joined #openmrs
|
05:56:04
|
*** shortend has joined #openmrs
|
05:59:07
|
*** Anuruddha has quit IRC
|
06:22:33
|
*** h3llborn has joined #openmrs
|
06:23:32
|
*** ibewes has joined #openmrs
|
06:27:50
|
*** suranga_ has joined #openmrs
|
06:34:12
|
*** h3llborn has quit IRC
|
07:46:07
|
*** Dimuthu_Upeksha has joined #openmrs
|
07:49:18
|
*** Upeksha has quit IRC
|
07:53:42
|
*** Dimuthu_Upeksha has quit IRC
|
07:54:01
|
*** Dimuthu_Upeksha has joined #openmrs
|
08:15:51
|
*** dkayiwa has joined #openmrs
|
08:59:26
|
*** khayam has joined #openmrs
|
09:00:37
|
<khayam> how to solve org.springframework.dao.InvalidDataAccessApiUsageException when we are deleting a record in db
|
09:01:50
|
<dkayiwa> khayam: how can one reproduce it? what are the steps?
|
09:05:36
|
<khayam> i'm calling sessionFactory.getCurrentSession().delete(state) from hibernate class
|
09:07:28
|
<dkayiwa> khayam: is your code hosted anywhere in some repository that is publicly accessible?
|
09:08:38
|
<khayam> no i'm just solving my tickets
|
09:09:53
|
<dkayiwa> khayam: can you include my name when you respond to me? that was my irc client will alert me
|
09:14:23
|
<dkayiwa> khayam: which ticket is that you are working on?
|
09:22:32
|
*** khayam has quit IRC
|
09:26:42
|
*** khayam has joined #openmrs
|
09:31:11
|
<khayam> this ticket i'm solving https://tickets.openmrs.org/browse/TRUNK-3094
|
09:31:38
|
<dkayiwa> khayam: can you include my name as you type?
|
09:32:31
|
<khayam> this ticket i'm solving https://tickets.openmrs.org/browse/TRUNK-3094 dkayiwa
|
09:32:33
|
*** mansi has joined #openmrs
|
09:32:47
|
<dkayiwa> khayam: can you also pastebin the changes you have made for me to look at?
|
09:37:36
|
<dkayiwa> khayam: use pastebin.com
|
09:39:20
|
<khayam> An Internal Error has Occurred org.springframework.dao.InvalidDataAccessApiUsageException deleted object would be re-saved by cascade (remove deleted object from associations): [org.openmrs.ProgramWorkflowState#3]; nested exception is org.hibernate.ObjectDeletedException: deleted object would be re-saved by cascade (remove deleted object from associations): [org.openmrs.ProgramWorkflowState#3] Consult the help document. Contact y
|
09:40:31
|
<dkayiwa> khayam: use pastebin.com
|
09:42:33
|
<khayam> here it is http://pastebin.com/LX3RC5pr
|
09:48:43
|
<dkayiwa> khayam: when you do not include my name, i can even take hours before knowing that you are waiting for me
|
09:49:27
|
<dkayiwa> khayam: can you also pastebin the code changes that you have made?
|
09:50:24
|
*** Darthy has joined #openmrs
|
09:50:24
|
*** mansi has quit IRC
|
09:51:26
|
<khayam> i have changes three or more classes dkayiwa
|
09:52:00
|
<dkayiwa> khayam: ok can you commit and i have a look?
|
09:54:22
|
*** GitHub44 has joined #openmrs
|
09:54:22
|
<GitHub44> [openmrs-core] akmad opened pull request #264: Fix to allow openmrs:require tag attribute value expressions. (master...master) http://git.io/DcwGYQ
|
09:54:22
|
*** GitHub44 has left #openmrs
|
09:55:28
|
<khayam> did you want me to commit on github dkayiwa
|
09:55:37
|
<dkayiwa> khayam: yes
|
09:56:09
|
<dkayiwa> khayam: documentation is here: https://wiki.openmrs.org/display/docs/Using+Git
|
09:56:36
|
<khayam> i know procedure but it takes nearly half an hour dkayiwa
|
09:56:57
|
<dkayiwa> khayam: do you have a slow internect connection?
|
09:57:56
|
<khayam> no i'm thinking that the work is not completed for commit the code dkayiwa
|
10:00:05
|
*** GitHub62 has joined #openmrs
|
10:00:05
|
<GitHub62> [openmrs-core] rkorytkowski pushed 2 new commits to master: http://git.io/kFausw
|
10:00:05
|
<GitHub62> openmrs-core/master 86d872e Wes Brown: Fix to allow openmrs:require tag attribute value expressions.
|
10:00:05
|
<GitHub62> openmrs-core/master 24b866c Rafal Korytkowski: Merge pull request #264 from OpenHMIS/master...
|
10:00:05
|
*** GitHub62 has left #openmrs
|
10:02:55
|
*** rkorytkowski has joined #openmrs
|
10:02:55
|
*** ChanServ sets mode: +v rkorytkowski
|
10:03:15
|
*** pulasthi7 has joined #openmrs
|
10:04:04
|
<dkayiwa> khayam: you can commit as many times as you want
|
10:04:19
|
<dkayiwa> khayam: you do not need to have it finished before you can commit
|
10:04:37
|
<dkayiwa> khayam: you can make multiple commits for the same ticket :)
|
10:05:40
|
<dkayiwa> khayam: at the end of it all, you can squash all the commits into one
|
10:05:47
|
*** GitHub164 has joined #openmrs
|
10:05:47
|
<GitHub164> [openmrs-core] rkorytkowski pushed 1 new commit to 1.9.x: http://git.io/yfSsHg
|
10:05:47
|
<GitHub164> openmrs-core/1.9.x 2427210 Wes Brown: TRUNK-3952: Enable openmrs:require tag attribute value expressions...
|
10:05:47
|
*** GitHub164 has left #openmrs
|
10:05:52
|
<dkayiwa> khayam: just google about that using this: git squash all commits
|
10:13:24
|
<khayam> i'm try to commit in the mean time just see this four classes i have changed Programworkflowservice.java http://pastebin.com/vBnFycdC PRogramworkflowserviceimpl.java http://pastebin.com/H21HYjWs programworkflowdao.java http://pastebin.com/DTK9f4VB Workflowformcontroller.java http://pastebin.com/ErcHJLdD dkayiwa
|
10:14:50
|
<dkayiwa> khayam: can you commit? That way i will spend as little time as possible looking only at the changes
|
10:15:11
|
<khayam> ok i'm trying dkayiwa
|
10:18:03
|
<Darthy> hello, im trying to install openmrs. when i point to http://localhost:8080/manager/html i get a 404 status saying :: description The requested resource (/manager/html) is not available.
|
10:20:49
|
<Darthy> any help, please
|
10:21:23
|
<kavuri> Darthy: were you successful in installing openmrs? And are you using the enterprise version or the standalone version?
|
10:22:25
|
<Darthy> standalone version . hmm , i didnt install, i will point tomcat to the directory to deploy
|
10:23:03
|
<kavuri> Darthy: when you click "start", you will see logs in the same window. Do you see any message that tomcat has started?
|
10:23:20
|
<kavuri> Darthy: and once the server starts, a browser instance will be launched automatically
|
10:24:27
|
<Darthy> kavuri: not happening. im getting the tomcat error 404 : some manager settings need to be changed
|
10:24:52
|
<kavuri> Darthy: can you pastebin the log
|
10:25:00
|
<Darthy> kavuri: i know tomcat has started : 8080 gives me the welcome to tomcat
|
10:25:34
|
<kavuri> Darthy: the url to openmrs is http://localhost:8080/openmrs
|
10:25:40
|
<kavuri> the default url that is
|
10:26:11
|
<Darthy> yes, but i havent loaded it using tomcat. i need tomcat to load it right
|
10:26:21
|
<Darthy> or should i put it in the webapps?
|
10:26:28
|
<Darthy> how does it work?
|
10:26:50
|
<kavuri> Darthy: in standalone version, you do not have to do anything. Just launch the exe or the script to launch openmrs gui
|
10:26:54
|
<kavuri> from there, just click "Start"
|
10:27:00
|
<Darthy> http://pastebin.com/xb1JZXFu
|
10:27:04
|
<kavuri> Darthy: you do not need a separate instance of tomcat
|
10:27:52
|
<kavuri> Darthy: your pastebin does not help
|
10:28:02
|
<kavuri> Darthy: you need to paste the tomcat logs
|
10:28:27
|
<kavuri> Darthy: from here: http://openmrs.org/download/, which version are you using?
|
10:28:45
|
<Darthy> kavuri: im sorry , yeh the enterprise version . really sorry
|
10:29:28
|
<kavuri> Darthy: ok, then check your tomcat logs (catalina.out) and see what the problem might be
|
10:30:02
|
<Darthy> i havent put tomcat
|
10:30:04
|
<Darthy> sorry
|
10:30:10
|
<Darthy> ignore prev
|
10:31:19
|
<Darthy> http://stackoverflow.com/questions/3535078/tomcat-manager-html-is-not-available : i am having this problem. but what setting i need to change, im not clear
|
10:31:20
|
<Darthy> :(
|
10:31:23
|
<OpenMRSBot> <http://ln-s.net/+wbd> (at stackoverflow.com)
|
10:31:43
|
<kavuri> Darthy: did you install tomcat?
|
10:31:51
|
<Darthy> kavuri: yes, i did
|
10:32:02
|
<kavuri> Darthy: is your machine windows/linux (ubuntu/kubuntu/..)
|
10:32:15
|
<Darthy> kavuri: its linux mint
|
10:32:29
|
<kavuri> Darthy: did you deploy openmrs into tomcat?
|
10:33:03
|
<Darthy> no, i cant right. because this link gives an error ><
|
10:33:47
|
*** harsz89 has quit IRC
|
10:33:48
|
<kavuri> Darthy: did you install tomcat-admin package?
|
10:34:31
|
<Darthy> it does not say anything like that
|
10:34:40
|
<Darthy> in the openmrs: installation guide
|
10:34:58
|
<kavuri> Darthy: openmrs does not talk about the container that you will have to install in
|
10:35:08
|
<kavuri> Darthy: one can use Jetty/tomcat/jboss/...
|
10:35:26
|
<kavuri> Darthy: you will have to read the documentation of tomcat to know how to install apps in tomcat
|
10:36:15
|
<Darthy> kavuri: well, it does not say i need to dwnld tomcat-admin package in the implementers documentation
|
10:36:18
|
<kavuri> Darthy: pls. read the necessary literature before jumping in. Will help you a lot as you go along..
|
10:39:42
|
*** shangxiao has joined #openmrs
|
10:44:44
|
*** Dimuthu_Upeksha has quit IRC
|
10:47:07
|
*** khayam has quit IRC
|
10:49:30
|
*** Vader has joined #openmrs
|
10:49:30
|
*** Darthy has quit IRC
|
10:49:55
|
<Vader> kavuri: i got tomcat-admin. though the page opens and i can put in my log in credentials, it does not move beyond. i have changed the conf/tomcat-users.xml.
|
10:53:06
|
<kavuri> Vader: the war file is big and so it might take sometime
|
10:53:23
|
<kavuri> Vader: the other option is to just copy the war file to the deployment dir of tomcat
|
10:53:45
|
<Vader> kavuri : yeah +1 for the second option. i will do that :D
|
11:01:22
|
*** Vader has quit IRC
|
11:23:19
|
*** kavuri has quit IRC
|
11:24:40
|
*** GitHub37 has joined #openmrs
|
11:24:40
|
<GitHub37> [openmrs-core] rkorytkowski pushed 2 new commits to master: https://github.com/openmrs/openmrs-core/compare/24b866ce98d8...41822c859935
|
11:24:40
|
<GitHub37> openmrs-core/master 6d2df20 DraggonZ: Program state change displays wrong date in IE8 TRUNK-3482
|
11:24:40
|
<GitHub37> openmrs-core/master 41822c8 Rafal Korytkowski: Merge pull request #229 from DraggonZ/TRUNK-3482...
|
11:24:40
|
*** GitHub37 has left #openmrs
|
11:24:45
|
<OpenMRSBot> <http://ln-s.net/+wcF> (at github.com)
|
11:25:53
|
*** GitHub98 has joined #openmrs
|
11:25:53
|
<GitHub98> [openmrs-core] rkorytkowski pushed 1 new commit to 1.9.x: http://git.io/WmiZpw
|
11:25:53
|
<GitHub98> openmrs-core/1.9.x 63d880b DraggonZ: Program state change displays wrong date in IE8 TRUNK-3482...
|
11:25:53
|
*** GitHub98 has left #openmrs
|
11:32:24
|
*** rajiths has joined #openmrs
|
11:34:47
|
*** travis-ci has joined #openmrs
|
11:34:47
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [41822c8] [Rafal Korytkowski] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/6013731
|
11:34:47
|
*** travis-ci has left #openmrs
|
11:34:51
|
<OpenMRSBot> <http://ln-s.net/+wcX> (at travis-ci.org)
|
11:36:00
|
*** khayam has joined #openmrs
|
11:36:13
|
<khayam> did you their dkayiwa
|
11:36:26
|
<dkayiwa> khayam:
|
11:36:44
|
<khayam> i'm unable to commit my changes
|
11:37:24
|
<khayam> i'm facing problems to pushing to github dkayiwa
|
11:37:38
|
<dkayiwa> khayam: ok
|
11:38:19
|
<khayam> can you know how to add branch go github dkayiwa
|
11:40:19
|
*** kavuri has joined #openmrs
|
11:41:35
|
<dkayiwa> khayam: yes
|
11:42:13
|
<khayam> tell me how to add branch from github website dkayiwa
|
11:42:51
|
<dkayiwa> khayam: here https://wiki.openmrs.org/display/docs/Using+Git
|
11:46:14
|
*** pulasthi7 has quit IRC
|
11:47:49
|
<ibewes> dkayiwa: do you know if Java easily supports mixins or other ways to emulate multiple inheritance?
|
11:49:07
|
<dkayiwa> ibewes: it does not support class multiple inheritance
|
11:49:24
|
<dkayiwa> ibewes: it only supports interface multiple inheritance
|
11:49:48
|
<dkayiwa> ibewes: and that is by design
|
11:51:02
|
<ibewes> dkayiwa: yeah, I know that Java doesn't support MI, but I didn't know if there are any tricks to get end up with something functionally similar
|
11:51:28
|
<dkayiwa> ibewes: did you by composition?
|
11:51:39
|
<ibewes> dkayiwa: interface MI still leaves me having to duplicate the implementation code and delegation doesn't really help much either
|
11:51:58
|
<ibewes> dkayiwa: thanks for the input though :)
|
11:52:15
|
<dkayiwa> ibewes: thats one of the moments that makes me miss my c++ :)
|
11:53:24
|
<ibewes> dkayiwa: back when I was doing c++ I didn't grok OO design enough to think about it, now that I do (at least somewhat better) I can't use it!
|
11:54:20
|
<dkayiwa> ibewes: :D
|
12:02:44
|
*** kavuri has quit IRC
|
12:18:49
|
*** Guest94472 has joined #openmrs
|
12:19:55
|
*** Guest94472 has quit IRC
|
12:21:57
|
*** Upeksha has joined #openmrs
|
12:21:59
|
*** garima has joined #openmrs
|
12:22:14
|
<garima> hi
|
12:22:25
|
<garima> i am trying to add this new feature
|
12:22:27
|
<garima> https://tickets.openmrs.org/browse/RESTWS-368
|
12:22:40
|
<garima> can some one guide where the related files are
|
12:22:44
|
<garima> ?
|
12:23:00
|
<garima> i cloned openmrs-core code into my local machine
|
12:29:46
|
<khayam> dkayiwa i'm getting errors like
|
12:30:27
|
<khayam> dkayiwa fatal:'origin' does not appear to be a git repository
|
12:30:30
|
<shangxiao> garima: what are you having trouble with?
|
12:31:10
|
<khayam> dkayiwa fatal:could not read from remote repository
|
12:31:25
|
<garima> i can't find the ConceptSearchHandler1_8
|
12:32:31
|
<shangxiao> try looking for the ConceptService class
|
12:33:06
|
*** wyclif has quit IRC
|
12:34:37
|
<shangxiao> garima: ah I see now this isn't part of the core code
|
12:34:51
|
<shangxiao> it's part of the WebServices.REST module
|
12:35:02
|
<garima> where can I find it?
|
12:35:10
|
<shangxiao> see https://github.com/openmrs/openmrs-module-webservices.rest
|
12:35:11
|
<OpenMRSBot> <http://ln-s.net/+lGa> (at github.com)
|
12:35:27
|
<garima> thankyou sir :)
|
12:35:37
|
<shangxiao> np ;)
|
12:36:30
|
<dkayiwa> khayam: from which folder are you doing that?
|
12:37:13
|
*** harsz89 has joined #openmrs
|
12:37:18
|
<khayam> dkayiwa the folder which contains api,test,web....
|
12:38:42
|
<dkayiwa> khayam: using which command?
|
12:39:16
|
<khayam> dkayiwa git push origin TRUNK-3094
|
12:40:39
|
<dkayiwa> khayam: did you do the git remote add step?
|
12:41:58
|
<khayam> dkayiwa-yes git remote add upstream https://www.github.com/khayamuddin31/openmrs-core.git
|
12:42:07
|
<OpenMRSBot> <http://ln-s.net/+wdW> (at www.github.com)
|
12:43:17
|
<dkayiwa> khayam: can you use the upstream value on the wiki page?
|
12:46:31
|
<khayam> dkayiwa-i don't know
|
12:46:32
|
*** Upeksha has quit IRC
|
12:47:12
|
<dkayiwa> khayam: do you see the line am referring to on the wiki page?
|
12:50:00
|
*** k-joseph has joined #openmrs
|
12:50:47
|
<khayam> dkayiwa-did you talking about this line git pull --rebase upstream master
|
12:51:28
|
<dkayiwa> khayam: the one having remote add
|
12:54:30
|
<khayam> dkayiwa we have to do this cmd git remote add origin https://github.com/openmrs/openmrs-module-appointment.git ?
|
12:54:40
|
<OpenMRSBot> <http://ln-s.net/+wdl> (at github.com)
|
12:54:51
|
*** k-joseph_ has joined #openmrs
|
12:55:27
|
<dkayiwa> khayam: which wiki page are you looking at?
|
12:55:58
|
<khayam> dkayiwa https://wiki.openmrs.org/display/docs/Using+Git#UsingGit-Createtopicbranchforyourtask
|
12:57:01
|
*** sara_ has joined #openmrs
|
12:57:31
|
<rajiths> mseaton, hi
|
12:57:40
|
<mseaton> hi rajiths
|
12:58:31
|
<dkayiwa> khayam: i do not see the remote add value you are referring to above
|
12:59:06
|
<dkayiwa> khayam: on seen it
|
12:59:28
|
<dkayiwa> khayam: that one is under : Creating your own module on github
|
12:59:44
|
<dkayiwa> khayam: in this case you are not dealing with a module. you are instead working on core
|
13:00:05
|
<dkayiwa> khayam: so instead use the instructions above on the wiki page
|
13:01:08
|
<rajiths> mseaton: can you check the issue https://tickets.openmrs.org/browse/REPORT-432 and change the status into "redy for work". and can you review the REPORT - 480 pull request and update me. :)
|
13:01:34
|
<khayam> dkayiwa ok
|
13:02:45
|
*** djazayeri1 has joined #openmrs
|
13:04:55
|
<k-joseph> :)
|
13:05:52
|
*** khayam has quit IRC
|
13:08:03
|
<rajiths> mseaton, can you check the issue https://tickets.openmrs.org/browse/REPORT-432 and change the status into "ready for work". and can you review the REPORT - 480 pull request and update me. :) sry for the trouble
|
13:08:20
|
*** k-joseph has quit IRC
|
13:08:35
|
*** k-joseph has joined #openmrs
|
13:09:36
|
<mseaton> rajiths: sure, i will curate it today
|
13:09:51
|
<rajiths> mseaton, thanks :)
|
13:17:23
|
*** k-joseph_ has joined #openmrs
|
13:19:12
|
*** k-joseph_ has quit IRC
|
13:19:45
|
*** wyclif has joined #openmrs
|
13:20:42
|
<downey> wiki will be back momentarily
|
13:20:52
|
*** lh has joined #openmrs
|
13:20:52
|
*** lh has joined #openmrs
|
13:23:46
|
*** shangxiao has quit IRC
|
13:27:47
|
*** joeseff_ has joined #openmrs
|
13:28:28
|
*** jb360 has quit IRC
|
13:28:47
|
*** joeseff has quit IRC
|
13:29:19
|
*** jb360 has joined #openmrs
|
13:29:55
|
*** nheck has joined #openmrs
|
13:37:43
|
*** dkayiwa has quit IRC
|
13:38:00
|
*** dkayiwa has joined #openmrs
|
13:38:01
|
<davidpardz> hi mseaton, morning. In order for me to solve this bug https://tickets.openmrs.org/browse/REPORT-419 I needed to solve this one https://tickets.openmrs.org/browse/REPORT-431 which happens to be closed. I am about to reopen it because I am able to reproduce it and I already fixed it. But the main problem it is not in the reporting module but in the htmlwidgets module and I don't know if I should reopen the bug or create a new
|
13:38:03
|
<davidpardz> one under the correct module.
|
13:39:35
|
<jkeiper> davidpardz: make a new one under html widgets
|
13:39:43
|
<jkeiper> davidpardz: and link to this one from REPORT-419
|
13:39:44
|
<mseaton> davidpardz: let's make a new one under htmlwidgets
|
13:40:51
|
<davidpardz> jkeiper: thank you
|
13:40:55
|
<davidpardz> mseaton: thank you
|
13:45:28
|
<garima> hi
|
13:45:38
|
<garima> when i try to compile openMRS code
|
13:45:48
|
<garima> using "maven clean install"
|
13:45:54
|
<garima> its giving me this error:
|
13:45:55
|
<garima> POM 'org.apache.maven.plugins:maven-clean-plugin' not found in repository: Unable to download the artifact from any repository
|
13:46:09
|
<garima> how can i fix this?
|
13:50:13
|
<harsz89> hi garima
|
13:50:27
|
*** garima has quit IRC
|
13:50:28
|
<djazayeri1> dkayiwa: you there?
|
13:51:17
|
*** joeseff_ has quit IRC
|
13:52:03
|
*** garima has joined #openmrs
|
13:53:22
|
*** sara_ has quit IRC
|
13:53:39
|
* cpower getting in the habit again of getting here early
|
13:55:29
|
<harsz89> hi garima
|
13:55:48
|
<harsz89> garima, did you fix the issue
|
13:55:57
|
<garima> yes sir
|
13:56:11
|
<harsz89> garima, cool!
|
13:56:12
|
<garima> it seems like i had not set proxy in maven's settings.xml
|
13:56:19
|
<garima> which was causing the problem
|
13:57:09
|
<harsz89> :)
|
13:57:30
|
<garima> :)
|
13:58:48
|
*** andrea_ has joined #openmrs
|
13:59:12
|
*** k-joseph has quit IRC
|
14:00:32
|
<andrea_> cpower, you there?
|
14:01:42
|
*** garima has quit IRC
|
14:02:12
|
*** Anuruddha has joined #openmrs
|
14:05:44
|
<andrea_> cpower, anyone?
|
14:05:53
|
<cpower> yep let's go
|
14:05:58
|
<cpower> !scrumon cpower
|
14:05:58
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
14:06:26
|
<andrea_> cpower, at&t fixed line - I have internet - yay!
|
14:06:30
|
<cpower> Order: mseaton , rafal, andrea_ , djazayeri1 , dkayiwa , wyclif
|
14:07:05
|
<mseaton> no updates other than trying to inch my way to tying off sync sprint stuff
|
14:07:11
|
<mseaton> no blockers
|
14:08:10
|
<djazayeri1> rafal isn't online, so andrea_ ?
|
14:08:13
|
<rkorytkowski> Today:
|
14:08:13
|
<rkorytkowski> * Reviewed and merged pull requests:
|
14:08:13
|
<rkorytkowski> + TRUNK-3952: Enable openmrs:require tag attribute value expressions
|
14:08:13
|
<rkorytkowski> https://tickets.openmrs.org/browse/TRUNK-3952
|
14:08:13
|
<rkorytkowski> + EMMA-32: Create a top-level bean for the service
|
14:08:13
|
<rkorytkowski> https://tickets.openmrs.org/browse/EMMA-32
|
14:08:13
|
<rkorytkowski> + TRUNK-3482: Program state change displays wrong date in IE8
|
14:08:14
|
<rkorytkowski> https://tickets.openmrs.org/browse/TRUNK-3482
|
14:08:14
|
<rkorytkowski> * Reviewd TRUNK-3811: On successful save of Concept one should go to View Concept Screen
|
14:08:15
|
<rkorytkowski> https://tickets.openmrs.org/browse/TRUNK-3811
|
14:08:15
|
<rkorytkowski> * Working on META-329: Concept Numerics don't import properly
|
14:08:16
|
<rkorytkowski> https://tickets.openmrs.org/browse/META-329
|
14:08:16
|
<rkorytkowski> * Univ Call
|
14:08:17
|
<rkorytkowski> No blockers.
|
14:08:25
|
<andrea_> Tuesday
|
14:08:25
|
<andrea_> Merck meetings
|
14:08:25
|
<andrea_> Merck stuff
|
14:08:25
|
<andrea_> Ticket TRUNK-3751
|
14:08:25
|
<andrea_> Saying that a module requires OpenMRS 1.9.2-SNAPSHOT fails
|
14:08:26
|
<andrea_> Wednesday
|
14:08:28
|
*** rkorytkowski is now known as rafa
|
14:08:30
|
<andrea_> Design call
|
14:08:32
|
<andrea_> Ticket TRUNK-3751
|
14:08:34
|
<andrea_> Write Unit test
|
14:08:36
|
<andrea_> Fix problem
|
14:08:38
|
<andrea_> No Blockers
|
14:10:00
|
<cpower> djazayeri1: you are up
|
14:10:29
|
<cpower> NEXT!
|
14:10:41
|
<djazayeri1> * Worked on setting up new bamboo server
|
14:10:41
|
<djazayeri1> * Working on RA-36 (Refactoring PIH's EMR module into a new OpenMRS EMR API module)…this is a huge ticket
|
14:10:41
|
<djazayeri1> * Created more Reference Application tickets
|
14:10:42
|
<djazayeri1> no blockers
|
14:10:50
|
<dkayiwa> Been working on AMPATH forms team blocker bug: "Unexpected Error" when opening form - XFRM-142
|
14:10:51
|
<dkayiwa> Will then resume with: Create a reusable module containing utility functions - RA-22
|
14:10:51
|
<dkayiwa> No Blockers
|
14:11:55
|
<wyclif> Tuesday:
|
14:11:55
|
<wyclif> -Continued with RA-6 and RA-7 - Reference Application home and login pages
|
14:11:55
|
<wyclif> -Call with Alfayo about amrs ticket for proof of concept for complex obs
|
14:11:55
|
<wyclif> Wednesday:
|
14:11:55
|
<wyclif> -Create CI plan for referenceapplication module
|
14:11:56
|
<wyclif> -Fix bugs in Appframework module
|
14:11:58
|
<wyclif> -Design call
|
14:12:00
|
<wyclif> -pick a new ticket
|
14:12:02
|
<wyclif>
|
14:12:04
|
<wyclif> Blockers: None
|
14:12:12
|
*** garima has joined #openmrs
|
14:12:48
|
<cpower> No blockers or Discussion points
|
14:13:41
|
<djazayeri1> dkayiwa: if you're blocked from working on your sprint ticket, please tell me that at the time, not after...
|
14:13:52
|
<dkayiwa> djazayeri1: ok
|
14:13:55
|
<cpower> Annoucements: Design Call today, still looking for topics! Next Sprint up: Reaping our benefits from this sprint and moving forward on the Reference Application!
|
14:14:26
|
<cpower> Beyond that, have a great day!
|
14:14:29
|
<cpower> !scrumoff
|
14:14:29
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:14:42
|
<djazayeri1> dkayiwa: also, please, if you're not going to join the hangout, let me know that too. :-)
|
14:14:58
|
<dkayiwa> djazayeri1: sure :)
|
14:15:25
|
*** wyclif has quit IRC
|
14:15:27
|
*** k-joseph has joined #openmrs
|
14:15:34
|
*** wyclif has joined #openmrs
|
14:15:45
|
<k-joseph> dkayiwa hi
|
14:15:52
|
<dkayiwa> k-joseph: hi
|
14:16:41
|
<djazayeri1> rafa: how is your research on the git super-projects goign?
|
14:17:01
|
<djazayeri1> rafa: I'd like to create a placeholder "how to set up your dev environment" page.
|
14:17:13
|
<k-joseph> dkayiwa: am not upto date shall we not have the openmrs university meeting, today!!]
|
14:17:20
|
<rafa> djazayeri1: not started with that yet
|
14:17:35
|
<rafa> djazayeri1: I'm working on META blocker right now
|
14:17:40
|
<dkayiwa> k-joseph: it now starts an hour earlier because of day light savings changes :)
|
14:17:53
|
<djazayeri1> rafa: okay, I'm going to create a placeholder page, at least to start documenting run configurations and stuff like that.
|
14:18:23
|
<k-joseph> dkayiwa: o, sorry i really wanted wanted to attend it today
|
14:18:24
|
<rafa> djazayeri1: cool, I'll get to that tomorrow
|
14:18:40
|
<dkayiwa> k-joseph: but you can always watch the recording if you miss it
|
14:19:15
|
*** garima has quit IRC
|
14:19:26
|
<k-joseph> dkayiwa: upto when will today's recorded video be out and what site can i download that from
|
14:19:39
|
*** garima has joined #openmrs
|
14:19:49
|
<dkayiwa> k-joseph: you can ask rafa
|
14:20:04
|
<k-joseph> rafa, hi
|
14:20:34
|
<rafa> djazayeri1: Has the hangout finished? I'm sorry I forgot I had a univ call...
|
14:20:40
|
<k-joseph> rafa, upto when willtoday's recorded video be out and what site can i download that from
|
14:20:57
|
<djazayeri1> rafa: I remembered that you had the university call, so I wasn't expecting you till late
|
14:21:03
|
<djazayeri1> rafa: I'm the only one on hangout now.
|
14:21:15
|
<k-joseph> i mean the openmrs univrsity recorded video for today
|
14:21:26
|
<rafa> k-joseph: no recording today
|
14:21:37
|
<rafa> k-joseph: it was a questions and answers session
|
14:21:37
|
<k-joseph> rafa, ok
|
14:21:39
|
*** davidpardz has quit IRC
|
14:22:11
|
<rafa> k-joseph: for other recorded sessions you can always go to https://wiki.openmrs.org/display/RES/OpenMRS+University
|
14:22:12
|
<OpenMRSBot> <http://ln-s.net/98-d> (at wiki.openmrs.org)
|
14:22:22
|
<rafa> k-joseph: and open up etherpads
|
14:23:02
|
<rafa> k-joseph: you can find links to recordings there
|
14:23:29
|
<k-joseph> rafa, ok please thanks a lot for that
|
14:27:13
|
*** andrea__ has joined #openmrs
|
14:27:59
|
*** k-joseph has quit IRC
|
14:28:06
|
*** kavuri has joined #openmrs
|
14:29:54
|
*** andrea_ has quit IRC
|
14:31:12
|
*** k-joseph has joined #openmrs
|
14:32:40
|
*** h3llborn has joined #openmrs
|
14:33:11
|
<h3llborn> mornin' everyone
|
14:34:20
|
*** sach has joined #openmrs
|
14:39:18
|
<downey> wiki will be back momentarily :D
|
14:39:29
|
<h3llborn> updates downey ?
|
14:40:26
|
*** k-joseph has quit IRC
|
14:40:50
|
<downey> h3llborn: little clean-up before its upcoming maintenance
|
14:41:13
|
<h3llborn> right on, i was actually gonna join the university forum today, but i think i missed it, due to class :(
|
14:42:32
|
*** garima has quit IRC
|
14:43:05
|
<downey> h3llborn: no worries, that no schedule is perfect :)
|
14:43:37
|
<h3llborn> happens i guess, next time, btw when does google get back about gsoc?
|
14:44:47
|
*** Upeksha has joined #openmrs
|
14:46:42
|
*** sach has quit IRC
|
14:48:51
|
*** k-joseph has joined #openmrs
|
14:53:02
|
* downey checks the timeline at http://www.google-melange.com/gsoc/events/google/gsoc2013
|
14:53:05
|
<OpenMRSBot> <http://ln-s.net/+wg4> (at www.google-melange.com)
|
14:53:17
|
<downey> h3llborn: 8 april :)
|
14:53:24
|
<h3llborn> ok sweet ;0
|
14:53:26
|
<h3llborn> :)
|
14:56:09
|
*** k-joseph_ has joined #openmrs
|
14:57:07
|
*** kavuri has quit IRC
|
14:57:38
|
*** k-joseph has quit IRC
|
14:58:26
|
*** rafa has quit IRC
|
15:05:09
|
*** portablejim has quit IRC
|
15:05:27
|
*** nheck has quit IRC
|
15:12:37
|
<wyclif> hi djazayeri
|
15:12:57
|
<wyclif> hi djazayeri 1
|
15:14:55
|
<djazayeri1> wyclif: hi
|
15:15:02
|
<djazayeri1> wyclif: (I'm on a call) what's up?
|
15:17:04
|
*** harsz89 has quit IRC
|
15:19:29
|
*** harsz89 has joined #openmrs
|
15:21:10
|
<k-joseph_> dkayiwa: hi
|
15:21:13
|
*** k-joseph_ is now known as k-joseph
|
15:21:27
|
<dkayiwa> k-joseph: hi
|
15:23:28
|
<k-joseph> dkayiwa: seen my mail?
|
15:23:36
|
<dkayiwa> k-joseph: and responded
|
15:24:01
|
<k-joseph> dkayiwa: checking
|
15:31:39
|
*** chapmara has joined #openmrs
|
15:33:13
|
*** chapmara has quit IRC
|
15:35:33
|
*** breeze has joined #openmrs
|
15:36:05
|
<k-joseph> dkayiwa: hi
|
15:36:09
|
<k-joseph> dkayiwa: it does not throw the exception any more , the test passes,
|
15:36:29
|
<dkayiwa> k-joseph: what is that assert testing?
|
15:37:48
|
<k-joseph> dkayiwa: am using that for testing the code,
|
15:38:21
|
<dkayiwa> k-joseph: yes i see that all is code. but what exactly are you testing for in that assert?
|
15:39:35
|
<k-joseph> dkayiwa: that is voidNote() in NoteDAO.java
|
15:40:02
|
<dkayiwa> k-joseph: what does it test about voidNote()
|
15:41:01
|
*** jkeiper is now known as heynow
|
15:41:24
|
*** heynow is now known as jkeiper
|
15:41:24
|
<k-joseph> dkayiwa: voidNote() is at http://pastebin.com/reBMhfKU, else what exactly was i supposed to write the test for beside that function
|
15:41:25
|
<k-joseph> ?
|
15:41:32
|
*** ChanServ sets mode: +v jkeiper
|
15:42:01
|
<dkayiwa> k-joseph: in otherwards, does it test that voidNote returns 2 or returns 5, or what?
|
15:42:13
|
*** ChanServ sets mode: -v jkeiper
|
15:42:31
|
*** ibewes has quit IRC
|
15:42:54
|
*** jkeiper is now known as chopin
|
15:43:03
|
*** chopin is now known as jkeiper
|
15:43:13
|
<k-joseph> dkayiwa: it test return, is dao
|
15:43:25
|
<k-joseph> dkayiwa, or the notedao object
|
15:44:10
|
<dkayiwa> k-joseph: may be this will help you. do you have the @should annotation?
|
15:44:41
|
<k-joseph> dkayiwa: no, i dont hava that
|
15:45:02
|
*** h3llborn has quit IRC
|
15:45:43
|
<dkayiwa> k-joseph: the sentence you will put in that annotation will give you an answer for what am asking for. The you will look at your assert and ask yourself if it is actually testing for what is in the annotation
|
15:45:48
|
*** Hasintha_i has joined #openmrs
|
15:47:25
|
*** mansi has joined #openmrs
|
15:49:47
|
*** andrea__ has quit IRC
|
15:51:20
|
*** dkayiwa_ has joined #openmrs
|
15:51:40
|
*** dkayiwa has quit IRC
|
15:51:41
|
*** dkayiwa_ is now known as dkayiwa
|
15:53:56
|
<jkeiper> downey: i changed my irc nick to be jkeiper (with an alias of chopin) instead of the other way around ... think you might need to change my +V
|
15:54:47
|
<downey> jkeiper: did you use the same actual account with nickserv or create a new one?
|
15:54:55
|
<jkeiper> dropped and added
|
15:55:07
|
<downey> jkeiper: ok will fix you up
|
15:55:19
|
<jkeiper> vielen dank
|
15:56:01
|
*** ChanServ sets mode: +v jkeiper
|
15:56:06
|
*** ChanServ sets mode: +v jkeiper
|
15:56:19
|
*** suranga__ has joined #openmrs
|
15:57:11
|
<jkeiper> yayz
|
15:59:30
|
*** cpower_ has quit IRC
|
16:01:15
|
*** dkayiwa has quit IRC
|
16:01:42
|
*** dkayiwa has joined #openmrs
|
16:05:18
|
*** vishal1tiwari has joined #openmrs
|
16:18:59
|
*** h3llborn has joined #openmrs
|
16:23:22
|
*** h3llborn has quit IRC
|
16:25:33
|
*** djazayeri is now known as djazayeri_may_be
|
16:25:42
|
*** djazayeri1 is now known as djazayeri
|
16:25:43
|
*** ChanServ sets mode: +o djazayeri
|
16:26:42
|
<djazayeri> wyclif: is the simple homepage checked in and ready to review now?
|
16:26:52
|
<wyclif> djazayeri, yes
|
16:27:14
|
<djazayeri> wyclif: cool, I'll look
|
16:27:57
|
<wyclif> djazayeri, let me create a ticket for the app framework module to fix the service bean in the application context file
|
16:28:32
|
*** h3llborn has joined #openmrs
|
16:30:55
|
<djazayeri> wyclif: yes, do that
|
16:31:53
|
<djazayeri> wyclif: also, please add the build to CI.
|
16:32:12
|
<wyclif> djazayeri, am doing that
|
16:32:40
|
<djazayeri> downey (and maybe burke): so, on the rapid board I am able to do _some_ workflow transitions by dragging a card between columns.
|
16:33:05
|
<downey> djazayeri: do they behave as expected?
|
16:33:07
|
<djazayeri> downey (and maybe burke): but I can't move something from In Review back to In Progress that way
|
16:33:25
|
<downey> hm
|
16:33:33
|
<djazayeri> downey (and maybe burke): which should be allowed
|
16:33:49
|
<downey> djazayeri: i assume you can do it through the standard UI for the issue in question, right?
|
16:33:53
|
*** mansi has quit IRC
|
16:34:02
|
<djazayeri> downey (and maybe burke): yes, I can do it through the standard UI.
|
16:34:24
|
*** mansi has joined #openmrs
|
16:34:38
|
<djazayeri> downey (and maybe burke): I _can_ drag-and-drop in the board to move something from To Do to In Progress (and it asks me whether to Assign or Claim it, which is nice)
|
16:35:09
|
<djazayeri> downey (and maybe burke): any idea what controls the dragging and dropping, or if there's something that might be wrong about our workflow setup? Or alternately, does the dragging and dropping bypass workflows?
|
16:35:39
|
<vishal1tiwari> Hey, this is Vishal, and i am trying to fix this bug: https://tickets.openmrs.org/browse/STAND-34?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel, but i am not able to locate the corresponding repository on git hub, can someone help?
|
16:36:55
|
<downey> djazayeri: my hunch is probably that your "in review" column represents too many states
|
16:37:11
|
<djazayeri> downey: it represents all the states we have. :-)
|
16:37:29
|
<djazayeri> downey: perhaps we could simplify down to a single review state?
|
16:38:25
|
<downey> djazayeri: we have pre-commit, initial, and post-commit ... and the former 2 have unique transitions (181 and 201, respectively) back to In Progress. so perhaps jira doesn't know which to fire. if the column changed to be only one of the states, it might work :)
|
16:38:56
|
<djazayeri> downey: I don't know why we have both initial and pre-commit in any case.
|
16:39:14
|
<djazayeri> downey: perhaps removing one of those from the column will randomly fix things.
|
16:39:15
|
<downey> djazayeri: that was a bwolfe thing :)
|
16:39:41
|
<djazayeri> downey: do you know which workflow transitions lead to Pre-Commit vs Initial?
|
16:40:02
|
<downey> djazayeri: it was initially called "spot check" for people who had a patch they wanted some feedback on before a full code review (often synchronous/live back in the day)
|
16:40:11
|
<downey> djazayeri: i do
|
16:40:50
|
<djazayeri> downey: which one was called Spot Check? was that Initial? Or Pre-commit?
|
16:41:05
|
<downey> initial was formerly spot check
|
16:41:24
|
<downey> so right now it goes in progress -> initial -> pre-commit -> committing
|
16:41:56
|
<downey> e.g., the only thing that leads to a pre-commit review is an initial review
|
16:42:19
|
<jkeiper> vishal1tiwari: unfortunately it is still in subversion: http://svn.openmrs.org/openmrs-contrib/standalone/
|
16:42:28
|
<jkeiper> dkayiwa: is it okay to migrate this to github? --^
|
16:42:35
|
<jkeiper> dkayiwa: i can migrate it
|
16:42:42
|
<dkayiwa> jkeiper: oh thanks alot!!!!!!!!
|
16:43:01
|
<jkeiper> dkayiwa: ok i will, vishal1tiwari: one moment please
|
16:43:01
|
*** mansi has quit IRC
|
16:43:14
|
<djazayeri> downey: hmm. We should change that around. For any code that's in git, it is helpful to have two states, one for pull-request, and the other for committed-to-master.
|
16:43:21
|
*** mansi has joined #openmrs
|
16:43:46
|
<downey> djazayeri: agreed. we should get some folks around a virtual whiteboard and revamp now that (most) everything is in git
|
16:44:00
|
<jkeiper> djazayeri: quick decision ... openmrs-contrib-standalone for openmrs standalone?
|
16:44:14
|
<djazayeri> jkeiper: I guess.
|
16:44:29
|
<jkeiper> djazayeri: haha ... what else would it be?
|
16:44:57
|
<djazayeri> jkeiper: conceivably just openmrs-standalone (i.e. it's its own new top-level thing)
|
16:45:25
|
<djazayeri> jkeiper: make it openmrs-contrib-standalone for now, and email code saying you did that.
|
16:45:43
|
<jkeiper> ok
|
16:48:48
|
*** nheck has joined #openmrs
|
16:51:34
|
<djazayeri> breeze: how is progress on packaging and deployment to tomcat?
|
16:54:52
|
*** rajiths has quit IRC
|
16:55:20
|
*** rajiths has joined #openmrs
|
16:57:47
|
<vishal1tiwari> thanks, and wanted ask if i fix it, where should i commit it?
|
17:03:23
|
<jkeiper> mseaton: did you ever use "michael" as your svn username?
|
17:03:31
|
<mseaton> no
|
17:03:39
|
<jkeiper> dkayiwa: do you know who "michael" would be as a committer to openmrs-standalone?
|
17:03:47
|
<jkeiper> mseaton: ok
|
17:03:54
|
<downey> me
|
17:04:10
|
<jkeiper> downey: !!! somehow you're not in my git authors text file
|
17:04:13
|
<downey> jkeiper: convert to downeym
|
17:04:14
|
* jkeiper adds you
|
17:05:09
|
<jkeiper> downey: which email address is linked to downeym?
|
17:05:21
|
<downey> jkeiper: michael@o.o
|
17:05:28
|
<jkeiper> mmk
|
17:06:18
|
*** khayamuddin31 has joined #openmrs
|
17:06:42
|
*** khayamuddin31 is now known as khayam
|
17:06:54
|
<harsz89> hi mseaton
|
17:08:29
|
*** davidpardz has joined #openmrs
|
17:08:34
|
<mseaton> hi harsz89
|
17:09:19
|
<davidpardz> hi mseaton I created https://tickets.openmrs.org/browse/HTMLWIDGETS-13 this issue based on this one https://tickets.openmrs.org/browse/REPORT-431
|
17:09:58
|
*** k-joseph is now known as k-joseph_
|
17:09:58
|
<harsz89> mseaton, i have made a pull request for sync 272 and if you a have a time please look at it and give me a feedback
|
17:10:12
|
*** k-joseph_ is now known as k-joseph
|
17:10:17
|
<harsz89> mseaton, and i'm currently at the edge of sync-293
|
17:10:22
|
*** k-joseph is now known as k-joseph_
|
17:10:49
|
<harsz89> mseaton, i have made some comments under that ticket the way i approacing
|
17:11:03
|
*** rajiths has quit IRC
|
17:11:14
|
<mseaton> harsz89: yes, sorry. it's on my list but something i will do later this week most likely
|
17:11:49
|
*** k-joseph_ is now known as k-joseph
|
17:11:59
|
<harsz89> mseaton, if something wrong in my approach please let me know
|
17:12:13
|
<harsz89> mseaton, thanks mseaton :)
|
17:12:49
|
<harsz89> harsz89, i have done most of the part of sync-293
|
17:12:53
|
<harsz89> mseaton, :)
|
17:13:10
|
<harsz89> mseaton, i'll provide a pull request when I done and test it
|
17:13:13
|
<harsz89> mseaton, :)
|
17:13:15
|
<mseaton> harsz89: thanks for all of the work on these. i'll do my best to feedback on them soon
|
17:13:53
|
<harsz89> harsz89, it's really interesting to work with sync :D and good learning experience too
|
17:13:54
|
<harsz89> :)
|
17:14:02
|
<harsz89> mseaton, thanks again mseaton :)
|
17:15:03
|
<khayam> hi all may i know code review status of https://tickets.openmrs.org/browse/FRMTOPGM-2 , https://tickets.openmrs.org/browse/TRUNK-2660, https://tickets.openmrs.org/browse/TRUNK-2660 i'm waiting for the reply
|
17:17:43
|
*** davidpardz has left #openmrs
|
17:17:45
|
<khayam> dkayiwa-sorry i'm unable to commit correctly https://github.com/khayamuddin31/openmrs-core/commit/07710f8270e6864871e2dff282a8f78035d0e95d due to technical reasons.
|
17:17:54
|
<OpenMRSBot> <http://ln-s.net/+wip> (at github.com)
|
17:20:49
|
<k-joseph> :)
|
17:21:08
|
*** h3llborn has quit IRC
|
17:21:16
|
<dkayiwa> khayam: did you include the commit url on the ticket?
|
17:22:26
|
*** burke has quit IRC
|
17:23:54
|
<khayam> dkayiwa-no i have created this for you only.
|
17:27:27
|
*** shortend has quit IRC
|
17:30:31
|
<khayam> dkayiwa-did i do commit?
|
17:32:28
|
<dkayiwa> khayam: how did you get that url
|
17:33:14
|
<khayam> dkayiwa-i have just committed on github
|
17:33:15
|
*** mansi has quit IRC
|
17:33:25
|
*** mansi has joined #openmrs
|
17:36:42
|
*** vishal1tiwari has quit IRC
|
17:36:48
|
*** k-joseph has quit IRC
|
17:42:26
|
*** Darthy has joined #openmrs
|
17:42:26
|
*** mansi has quit IRC
|
17:42:57
|
*** khayam has quit IRC
|
17:47:35
|
*** h3llborn has joined #openmrs
|
17:53:07
|
<djazayeri> wyclif: the compilation error you're seeing may be due to not importing the dependency in omod. (I personally have shifted to _not_ having a <dependencyManagement> in the root pom, but rather having the <dependencies> there directly, so they automatically get included in both in api and omod.
|
17:53:18
|
*** k-joseph has joined #openmrs
|
17:55:02
|
<wyclif> djazayeri, but i included the dependency in the omod pom
|
17:55:16
|
<djazayeri> wyclif: hmm, okay, not sure what's up then.
|
17:55:23
|
*** h3llborn has quit IRC
|
17:55:35
|
<wyclif> djazayeri, it was worked before and other modules are set up this way
|
17:55:42
|
<wyclif> djazayeri, not sure what is going in
|
17:55:48
|
<djazayeri> wyclif: does it compile locally?
|
17:55:54
|
<wyclif> djazayeri, yes
|
17:56:45
|
<djazayeri> wyclif: fails for me locally
|
17:56:55
|
<wyclif> djazayeri, hmm
|
17:57:04
|
<djazayeri> wyclif: change "api" to "service"
|
17:57:06
|
<djazayeri> wyclif: in the import
|
17:57:20
|
<djazayeri> wyclif: looks like pulkit renamed the package...
|
17:58:52
|
<wyclif> djazayeri, ah that might be the problem, let me update my appframework module and fix it
|
17:59:12
|
<wyclif> djazayeri, thanks might have saved me time
|
17:59:47
|
<djazayeri> wyclif: don't forget to try doing the mvn build at the command line, since it isn't confused by other modules on your IDE classpath. :-)
|
18:00:24
|
<k-joseph> :)
|
18:00:30
|
<wyclif> djazayeri, sure
|
18:05:44
|
*** burke has joined #openmrs
|
18:05:44
|
*** ChanServ sets mode: +o burke
|
18:09:55
|
*** robbyoconnor has quit IRC
|
18:11:18
|
*** Darthy has quit IRC
|
18:14:35
|
*** Anuruddha has quit IRC
|
18:15:20
|
*** wyclif has quit IRC
|
18:15:25
|
*** wyclif_ has joined #openmrs
|
18:17:51
|
*** shortend has joined #openmrs
|
18:18:57
|
*** GarimaAhuja has joined #openmrs
|
18:19:06
|
<GarimaAhuja> hi
|
18:19:19
|
<GarimaAhuja> i need some information on trunk 3194
|
18:19:26
|
<downey> !ticket TRUNK-3194
|
18:19:28
|
<OpenMRSBot> downey: [#TRUNK-3194] Make concept word search constants into settings - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3194
|
18:20:09
|
<GarimaAhuja> i just want to know if i comprehend the problem right
|
18:20:19
|
<GarimaAhuja> before starting to work on it
|
18:20:31
|
<GarimaAhuja> is here someone who can help me out?
|
18:21:04
|
*** Hasintha_i has quit IRC
|
18:21:13
|
<downey> perhaps wyclif_ or djazayeri can ... otherwise if not, i'd recommend writing to our dev@openmrs mailing list with your thoughts for some discussion
|
18:21:56
|
<GarimaAhuja> thanks, i will message them :)
|
18:22:29
|
<wyclif_> hi GarimaAhuja
|
18:22:45
|
<GarimaAhuja> hello sir
|
18:23:09
|
<GarimaAhuja> i just wanted to confirm what i comprehend is right
|
18:23:38
|
<GarimaAhuja> the page says that the constants have to be converted to global properties user can tweek
|
18:24:06
|
<GarimaAhuja> what would be the interface user would use to tweek the properties?
|
18:26:04
|
<GarimaAhuja> would the user input through a form?
|
18:26:18
|
<GarimaAhuja> or change the value in the database through a query?
|
18:26:27
|
<GarimaAhuja> or change the source code itself?
|
18:26:34
|
<wyclif_> GarimaAhuja, doesn't need to be done since we are moving away from using the concept word table, i will go ahead and close it
|
18:26:53
|
<wyclif_> GarimaAhuja, you can pick another ticket
|
18:27:16
|
<GarimaAhuja> okay, thanks for the information :)
|
18:28:52
|
<GarimaAhuja> how about this one RESTWS-368 ?
|
18:29:00
|
*** shortend has quit IRC
|
18:29:11
|
<GarimaAhuja> this is open, right?
|
18:34:30
|
*** hasna555 has joined #openmrs
|
18:42:07
|
<k-joseph> dkayiwa: hi
|
18:42:22
|
<dkayiwa> k-joseph: hi
|
18:46:16
|
<sunbiz> !ticket RESTWS-368
|
18:46:17
|
*** suranga__ has quit IRC
|
18:46:20
|
<OpenMRSBot> sunbiz: [#RESTWS-368] Add search by term to ConceptResource1_9 - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-368
|
18:49:37
|
<k-joseph> dkayiwa, besides my code that am writting how what is is the actual code for voiding a note, in this case
|
18:49:37
|
<k-joseph> ?
|
18:49:38
|
<dkayiwa> k-joseph: i thought you are the one implementing a method to void a note
|
19:04:57
|
*** robbyoconnor has joined #openmrs
|
19:04:57
|
*** ChanServ sets mode: +v robbyoconnor
|
19:09:51
|
*** r0bby has joined #openmrs
|
19:09:51
|
*** ChanServ sets mode: +v r0bby
|
19:10:48
|
*** h3llborn has joined #openmrs
|
19:12:01
|
*** r0bby_ has joined #openmrs
|
19:12:01
|
*** ChanServ sets mode: +v r0bby_
|
19:14:48
|
*** robbyoconnor has quit IRC
|
19:15:49
|
*** r0bby has quit IRC
|
19:20:01
|
*** sunbiz has quit IRC
|
19:20:36
|
*** burke has quit IRC
|
19:20:51
|
*** suranga_ has quit IRC
|
19:27:40
|
*** andreapat has joined #openmrs
|
19:30:12
|
*** robbyoconnor has joined #openmrs
|
19:30:12
|
*** ChanServ sets mode: +v robbyoconnor
|
19:30:43
|
*** r0bby_ has quit IRC
|
19:32:09
|
*** suranga_ has joined #openmrs
|
19:33:42
|
*** burke has joined #openmrs
|
19:33:42
|
*** ChanServ sets mode: +o burke
|
19:33:45
|
*** sunbiz has joined #openmrs
|
19:33:45
|
*** ChanServ sets mode: +v sunbiz
|
19:43:59
|
*** nheck has quit IRC
|
19:44:57
|
<djazayeri> burke: you actually there?
|
19:47:05
|
<djazayeri> burke: tell me about alfred.
|
19:49:09
|
*** nheck has joined #openmrs
|
19:52:17
|
*** robbyoconnor has quit IRC
|
19:52:32
|
*** GarimaAhuja has quit IRC
|
19:55:50
|
*** burke is now known as ekrub
|
19:56:03
|
*** ekrub is now known as burke
|
20:00:17
|
<cpower> burke has a martial arts, criminologist, and master of historical knowledge butler?
|
20:02:37
|
*** k-joseph has quit IRC
|
20:03:13
|
<burke> alfred is here: http://www.alfredapp.com/
|
20:03:23
|
<burke> djazayeri: powerpack is a must-have
|
20:03:27
|
<downey> alfred++
|
20:04:06
|
<djazayeri> burke: I downloaded alfred. I was wondering if there was some fancy way of doing what you're describing without powerpack
|
20:04:23
|
<djazayeri> burke: I'll get the powerpack
|
20:04:47
|
<burke> I have about 24 workflows defined, some of which you might be interested in (e.g., smart openmrs ticket search, volume controls, smart IRC Cloud launcher)
|
20:06:12
|
<downey> oh wait i take back my alfred-- i was thinking of QuickSilver++
|
20:07:45
|
<djazayeri> burke: an example of the "open existing (or new) browser tab" would be nice. Unless it's obvious
|
20:11:29
|
*** wyclif has joined #openmrs
|
20:11:29
|
*** wyclif_ has quit IRC
|
20:14:32
|
*** k-joseph has joined #openmrs
|
20:14:53
|
<burke> It uses an applescript. Try downloading from here: http://maml.in/12hX0yY
|
20:19:05
|
<burke> djazayeri: did that download work for you?
|
20:19:22
|
<djazayeri> burke: yes.
|
20:19:30
|
<djazayeri> burke: thanks. pairing now will look later
|
20:20:14
|
<burke> ok. here's another for typing arrow characters: http://maml.in/14F5OD0
|
20:25:27
|
<burke> djazayeri: and here is my OpenMRS Alfred 2 workflow including convenient shortcuts to OpenMRS tickets like "ot tb-1" to open TB-1 in JIRA: http://maml.in/12hZLjy
|
20:30:09
|
*** andreapat has quit IRC
|
20:36:57
|
*** wyclif has quit IRC
|
20:38:54
|
*** nheck has quit IRC
|
20:40:14
|
*** wyclif has joined #openmrs
|
20:45:09
|
*** nheck has joined #openmrs
|
20:48:36
|
*** nheck has quit IRC
|
20:49:53
|
*** nheck has joined #openmrs
|
20:58:37
|
*** wyclif_ has joined #openmrs
|
20:58:37
|
*** wyclif has quit IRC
|
21:01:36
|
<h3llborn> hey guys
|
21:01:43
|
<h3llborn> i just worked on my ticket
|
21:01:50
|
<h3llborn> i think i got everything right however
|
21:01:52
|
<h3llborn> Failed tests:
|
21:01:53
|
<h3llborn> shouldSerialize(org.openmrs.report.RowPerObsDatasetTest)
|
21:01:53
|
<h3llborn> Tests run: 2282, Failures: 1, Errors: 0, Skipped: 27
|
21:02:07
|
*** nheck has quit IRC
|
21:02:12
|
<h3llborn> weird thing is, never touched that
|
21:02:14
|
<h3llborn> :s
|
21:04:23
|
<h3llborn> btw this was my ticket
|
21:04:41
|
<h3llborn> !trunk 2303
|
21:04:42
|
<OpenMRSBot> h3llborn: Error: "trunk" is not a valid command.
|
21:04:55
|
<h3llborn> !ticket 2303
|
21:04:56
|
<OpenMRSBot> h3llborn: HTTP Error 404: Not Found - https://tickets.openmrs.org/browse/2303
|
21:05:08
|
*** k-joseph has quit IRC
|
21:05:18
|
<h3llborn> !ticket TRUNK-2303
|
21:05:20
|
<OpenMRSBot> h3llborn: [#TRUNK-2303] Obs.getValueAsString() should not display numbers in scientific notation - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-2303
|
21:06:24
|
*** nheck has joined #openmrs
|
21:08:34
|
<h3llborn> downey any ideas? :P
|
21:10:10
|
<djazayeri> h3llborn: what is the test failure?
|
21:10:21
|
<djazayeri> h3llborn: i.e. does some comparison fail?
|
21:10:26
|
<h3llborn> um lemme check
|
21:12:24
|
<h3llborn> org.junit.ComparisonFailure: expected:<...HT (KG)"
|
21:21:15
|
<h3llborn> http://pastie.org/7305579
|
21:23:12
|
<djazayeri> h3llborn: if you look closely you'll see that the difference it's highlighting is [.0] vs []
|
21:23:37
|
<h3llborn> mhhm , i may have an idea
|
21:23:38
|
<djazayeri> h3llborn: i.e. you have changed the value that some method is returning
|
21:24:21
|
<djazayeri> h3llborn: it's possible that's the whole point of your ticket, and you need to change the other test to expect a different result. But it's also possible that we don't want to change this behavior.
|
21:25:02
|
<h3llborn> ill try my hunch quick
|
21:26:27
|
<djazayeri> h3llborn: by the way, if you want someone to notice a comment, mention their nick. (I don't usually have this window in the foreground.)
|
21:26:42
|
<h3llborn> ok :P
|
21:26:48
|
<h3llborn> thanks :)
|
21:30:50
|
<h3llborn> djazayeri: in my ticket it says anything up to 6 decimal places must be shown as a regular number does that mean i do not include decimal places?
|
21:32:16
|
*** breeze has quit IRC
|
21:33:02
|
<djazayeri> h3llborn: you can ask this on the ticket, but I assume the point of that bullet is that 0.0000000001 would be acceptable to still show in scientific notation
|
21:33:28
|
<djazayeri> h3llborn: hmm, I created that ticket. I don't recall writing that description. :-)
|
21:33:51
|
<h3llborn> lool ok
|
21:33:56
|
<h3llborn> well back to the drawing board
|
21:33:59
|
<h3llborn> gahhh
|
21:34:18
|
<h3llborn> so much for being an easy fix :P
|
21:34:31
|
<djazayeri> h3llborn: this is a good place to use test-driven-development practices.
|
21:34:54
|
<h3llborn> is there a link for that on the wiki?
|
21:35:24
|
<djazayeri> h3llborn: you can google for the general topic of test-driven development or behavior-driven development
|
21:35:32
|
<djazayeri> h3llborn: actually, can I screenshare with you now?
|
21:35:42
|
<h3llborn> sure, what did u wanna use?
|
21:41:35
|
<OpenMRSBot> Recent updates in the world of openmrs: Burke Mamlin: Alfred Workflows <http://blog.burkeware.com/2013/04/alfred-workflows/>
|
21:41:41
|
*** cospih has quit IRC
|
21:42:43
|
*** nheck has quit IRC
|
21:43:04
|
*** Upeksha has quit IRC
|
21:49:10
|
*** GitHub11 has joined #openmrs
|
21:49:10
|
<GitHub11> [openmrs-core] GarimaAhuja opened pull request #265: TRUNK-2883: Fixed things (master...TRUNK-2883) http://git.io/cA2jUw
|
21:49:10
|
*** GitHub11 has left #openmrs
|
22:00:01
|
*** wyclif_ has quit IRC
|
22:00:32
|
*** nheck has joined #openmrs
|
22:02:02
|
<h3llborn> djazayeri: i think i got it, all tests passed :)
|
22:02:16
|
<djazayeri> h3llborn: cool! Don't forget to write some new ones too. :-)
|
22:02:22
|
<h3llborn> ya for sure
|
22:02:28
|
<h3llborn> it was just the decimal hahah
|
22:02:38
|
<h3llborn> stupid me forgetting to put a .0 in the formatter :P
|
22:04:37
|
<h3llborn> great success http://pastebin.com/qd9Twb6s !
|
22:12:50
|
*** dkayiwa has quit IRC
|
22:26:56
|
*** harsz89 has quit IRC
|
22:31:56
|
*** GitHub60 has joined #openmrs
|
22:31:56
|
<GitHub60> [openmrs-core] h3llborn opened pull request #266: Trunk 2303 (master...TRUNK-2303) http://git.io/gvVByQ
|
22:31:56
|
*** GitHub60 has left #openmrs
|
22:39:22
|
*** harsz89 has joined #openmrs
|
22:41:37
|
*** wyclif_ has joined #openmrs
|
22:52:52
|
*** GitHub122 has joined #openmrs
|
22:52:52
|
<GitHub122> [openmrs-core] h3llborn opened pull request #267: TRUNK-2303: Fixed return of long decimal numbers to not use scientific n... (master...TRUNK-2303) http://git.io/G_jbbA
|
22:52:52
|
*** GitHub122 has left #openmrs
|
23:02:59
|
<h3llborn> djazayeri: thanks currently reviewing your notes
|
23:03:08
|
<djazayeri> np
|
23:03:25
|
*** ryates has quit IRC
|
23:04:25
|
*** nribeka has quit IRC
|
23:10:32
|
*** hasna555 has quit IRC
|
23:16:23
|
<h3llborn> djazayeri: is the plugin suppose to automatically create test case method?
|
23:16:36
|
<djazayeri> h3llborn: yes.
|
23:16:46
|
<djazayeri> h3llborn: you have to right click and say Generate Test Cases.
|
23:17:09
|
<djazayeri> h3llborn: you probably have to do some minor configuration in the project first. (That's a right-click on the project, and Properties, IIRC)
|
23:17:32
|
<h3llborn> ok thanks :)
|
23:27:37
|
*** nheck has quit IRC
|
23:28:10
|
*** cospih has joined #openmrs
|
23:49:38
|
*** nheck has joined #openmrs
|
23:49:54
|
<h3llborn> djazayeri: just pushed new commit
|
23:51:19
|
<djazayeri> h3llborn: cool. I won't be able to look at this again today
|
23:51:56
|
<h3llborn> kk, just letting ya know :)
|