00:00:39
|
*** lh has joined #openmrs
|
00:33:50
|
*** portablejim has joined #openmrs
|
00:39:01
|
*** lh has quit IRC
|
00:41:45
|
*** lh has joined #openmrs
|
00:41:45
|
*** lh has joined #openmrs
|
00:48:05
|
*** lh has quit IRC
|
00:53:45
|
*** Hasintha_i has quit IRC
|
01:19:30
|
*** lh has joined #openmrs
|
01:28:44
|
*** lh has quit IRC
|
01:29:32
|
*** lh has joined #openmrs
|
01:37:04
|
*** lh has quit IRC
|
01:37:41
|
<portablejim> Is it preferable to use a pull request or create a patch when submitting changes? I am thinking that github's pull request system has replaced the method of manually creating patches. Is this correct?
|
01:37:52
|
*** lh has joined #openmrs
|
01:38:11
|
<djazayeri> portablejim: correct. Do you see documentation on our wiki that says to use patches? (If so we should update it.)
|
01:39:29
|
<portablejim> How about here: https://wiki.openmrs.org/display/docs/Patches
|
01:40:18
|
<djazayeri> portablejim: good point. :-) did you end up at that page due to a search, or because a different developer how-to sent you there?
|
01:42:53
|
*** lh has quit IRC
|
01:43:21
|
<portablejim> I was searching for it. (short story: researching how to commit code of high standard to OpenMRS for a university subject (as a student) before actually writing code for openmrs)
|
01:44:22
|
<djazayeri> portablejim: Thanks for pointing this out. I added a note to the page. Can you let me know if the wording is sufficient for someone who lands there from a search like you did?
|
01:45:16
|
<portablejim> It is also in the menu of the wiki (Documentation/Developer Guide/Patches).
|
01:47:41
|
<djazayeri> portablejim: I don't think I can control that, since that's just due to page structure
|
01:48:22
|
<djazayeri> downey: how do we deprecate a no-longer-up-to-date page on the wiki properly? I.e. the Patches page a few messages up from here.)
|
02:21:55
|
*** harshadura has joined #openmrs
|
02:36:31
|
*** harshadura has quit IRC
|
02:58:43
|
*** lh has joined #openmrs
|
02:58:43
|
*** lh has joined #openmrs
|
03:28:10
|
*** davidpardz has quit IRC
|
03:30:16
|
*** harshadura has joined #openmrs
|
03:38:00
|
*** lh has quit IRC
|
03:42:05
|
*** lh has joined #openmrs
|
04:09:31
|
<downey> djazayeri: Delete it? Post a notice at the top? Depends on the specific issues I suppose.
|
04:18:29
|
*** tbharath has joined #openmrs
|
04:19:06
|
*** zednet has quit IRC
|
04:22:53
|
*** kavuri has joined #openmrs
|
05:14:16
|
<djazayeri> downey: yeah, I put a notice up top. I was wondering if there was a label we use for this, or something like that.
|
05:19:09
|
*** robbyoconnor has joined #openmrs
|
05:19:09
|
*** ChanServ sets mode: +v robbyoconnor
|
05:23:25
|
*** robbyoconnor has quit IRC
|
05:24:02
|
*** robbyoconnor has joined #openmrs
|
05:24:02
|
*** ChanServ sets mode: +v robbyoconnor
|
05:35:26
|
*** robbyoconnor has quit IRC
|
05:35:40
|
*** r0bby has joined #openmrs
|
05:35:40
|
*** ChanServ sets mode: +v r0bby
|
05:41:32
|
*** joeseff has joined #openmrs
|
05:50:47
|
*** r0bby has quit IRC
|
05:52:52
|
*** robbyoconnor has joined #openmrs
|
05:52:52
|
*** ChanServ sets mode: +v robbyoconnor
|
05:55:06
|
*** GitHub60 has joined #openmrs
|
05:55:06
|
<GitHub60> [openmrs-core] djazayeri pushed 2 new commits to master: http://git.io/cXKnag
|
05:55:06
|
<GitHub60> openmrs-core/master 2142a96 Pulkit: Plugging in dependency on javax.validation api JSR-303 definition.
|
05:55:06
|
<GitHub60> openmrs-core/master 6bec7a3 Darius Jazayeri: Merge pull request #257 from nutsiepully/master...
|
05:55:06
|
*** GitHub60 has left #openmrs
|
05:55:39
|
*** GitHub140 has joined #openmrs
|
05:55:39
|
<GitHub140> [openmrs-core] djazayeri pushed 2 new commits to 1.9.x: http://git.io/7OM-Lw
|
05:55:39
|
<GitHub140> openmrs-core/1.9.x 914c3c3 Pulkit: Plugging in dependency on javax.validation api JSR-303 definition.
|
05:55:39
|
<GitHub140> openmrs-core/1.9.x 323cf78 Darius Jazayeri: Merge pull request #258 from nutsiepully/1.9.x...
|
05:55:39
|
*** GitHub140 has left #openmrs
|
06:04:33
|
*** lh has quit IRC
|
06:05:07
|
*** travis-ci has joined #openmrs
|
06:05:07
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [6bec7a3] [Darius Jazayeri] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/5831417
|
06:05:07
|
*** travis-ci has left #openmrs
|
06:05:11
|
<OpenMRSBot> <http://ln-s.net/+u3I> (at travis-ci.org)
|
06:11:56
|
*** GitHub121 has joined #openmrs
|
06:11:56
|
<GitHub121> [openmrs-core] djazayeri pushed 1 new commit to 1.9.x: http://git.io/ZGPRTw
|
06:11:56
|
<GitHub121> openmrs-core/1.9.x 1fa7ebd djazayeri: formatting
|
06:11:56
|
*** GitHub121 has left #openmrs
|
06:19:14
|
*** shortend has joined #openmrs
|
06:21:12
|
*** harshadura has quit IRC
|
06:22:07
|
*** tbharath has quit IRC
|
06:23:47
|
*** ekow has quit IRC
|
06:24:34
|
*** shortend has quit IRC
|
06:33:32
|
*** shortend has joined #openmrs
|
06:43:32
|
*** upul has quit IRC
|
06:48:36
|
*** harshadura has joined #openmrs
|
07:09:40
|
*** ibewes has joined #openmrs
|
07:42:35
|
*** dkayiwa has joined #openmrs
|
08:01:33
|
*** kavuri has quit IRC
|
08:03:45
|
*** kavuri has joined #openmrs
|
08:04:46
|
*** shortend has quit IRC
|
08:07:27
|
*** shortend has joined #openmrs
|
09:00:51
|
*** harshadura_ has joined #openmrs
|
09:03:31
|
*** harshadura has quit IRC
|
09:23:47
|
*** rkorytkowski has joined #openmrs
|
09:23:47
|
*** ChanServ sets mode: +v rkorytkowski
|
09:39:23
|
*** harshadura_ has quit IRC
|
10:43:55
|
<dkayiwa> joeseff: feel free to ask from here :)
|
10:44:09
|
<dkayiwa> joeseff: that way others will help me when i fail :)
|
10:46:05
|
<joeseff> dkayiwa: Ok, but I seriously doubt that you will fail. Your advice has been good so far :) What I would like to know, is there anyway you can limit the choices in a combobox to a particular source?
|
10:46:42
|
<dkayiwa> joeseff: can you give an example?
|
10:46:42
|
*** ekow has joined #openmrs
|
10:46:55
|
<joeseff> dkayiwa: For example, I would like to have a combobox where someone can choose a diagnosis based on ICD10 choices
|
10:47:12
|
*** rkorytkowski is now known as rafa
|
10:47:59
|
<dkayiwa> joeseff: which property of a diagnosis do i use to tell if one is an ICD10 choice or not?
|
10:48:23
|
<dkayiwa> ekow: hi :)
|
10:49:03
|
<ekow> Hi Everyone. Form submission error. We have creater a provider but on submitting forms we get this error..."No provider with personId 7
|
10:49:13
|
<ekow> Hi Danieeeellllllll
|
10:49:27
|
<dkayiwa> ekow: hey
|
10:49:32
|
<joeseff> dkayiwa: I have no clue
|
10:50:01
|
<joeseff> dkayiwa: Maybe the mappings? Though I'm not exactly sure that is a property
|
10:50:16
|
<dkayiwa> joeseff: ok can you tell by just looking at them?
|
10:51:03
|
<joeseff> dkayiwa: Yes, In the mappings sections, they are mapped to concepts from different sources - is that what you meant?
|
10:51:06
|
<dkayiwa> ekow: can you pastebin the form?
|
10:51:09
|
<ekow> <daniel> how are you doing? Did Paul update you on the the request?
|
10:51:12
|
*** ruwanego has joined #openmrs
|
10:51:24
|
<dkayiwa> ekow: oh yes he did :)
|
10:51:56
|
<dkayiwa> joeseff: are you familiar with sql?
|
10:51:58
|
<ekow> <daniel> I think the issue with the settings on the provider and probably attributes
|
10:52:29
|
<joeseff> dkayiwa: yes indeed
|
10:53:21
|
<dkayiwa> joeseff: are you able to write an sql statement which will return you only such diagnoses?
|
10:53:30
|
<ekow> <daniel, whilst on the sql subject. Is there a module in OpenMRS that lets the MySQl talk to sql (windows)
|
10:54:27
|
<dkayiwa> ekow: you do not need an openmrs module. all you need is a mysql gui
|
10:54:37
|
<dkayiwa> ekow: navicat, ems, etc
|
10:54:47
|
<joeseff> dkayiwa: Yes of course, but if I did, wouldn't that mean that the form would be interacting with the database directly?
|
10:55:28
|
<dkayiwa> joeseff: do you see any disadvantages for that?
|
10:55:29
|
<ekow> <daniel>so if OpenMRS is on windows, all you need is gui for it to connect and extract info from sql
|
10:56:20
|
<joeseff> dkayiwa: Not at the moment, in which tables are the concept mappings stored?
|
10:57:17
|
<dkayiwa> ekow: yes
|
10:57:46
|
<joeseff> dkayiwa: Found it, thanks
|
10:59:02
|
<ojwangantony> dkayiwa: hi
|
10:59:11
|
<dkayiwa> ojwangantony: hi
|
10:59:55
|
<ekow> <daniel> thanks a l ot . as usual, you are a star. Also migration of data from sql into OpenMRs, feasible?
|
11:00:22
|
<dkayiwa> ekow: do you mean sql server?
|
11:00:47
|
<ojwangantony> dkayiwa: i found i way to add openmrs search widget though i had to stick to the dojo way
|
11:01:07
|
<dkayiwa> ojwangantony: oh great. atleast you have something that works :)
|
11:01:32
|
<ojwangantony> dkayiwa: i could not replicate the same dynamically using javascript
|
11:01:44
|
<dkayiwa> ojwangantony: ok
|
11:02:00
|
<ojwangantony> dkayiwa: thanks so much
|
11:02:13
|
<dkayiwa> ojwangantony: you did it yourself :)
|
11:03:02
|
<ekow> <daniel>, yes patients data captured in sql
|
11:03:18
|
<ekow> <daniel> -serb
|
11:03:21
|
<dkayiwa> ekow: not automatically :)
|
11:04:00
|
<ekow> <daniel> I thought so. But we have to write mysql script or somethin right?
|
11:04:22
|
<ojwangantony> dkayiwa: you were there for me when i needed help
|
11:04:32
|
<dkayiwa> ekow: something like that
|
11:04:53
|
<dkayiwa> ojwangantony: hahaha. you are so generous with your comments :D
|
11:06:06
|
<ojwangantony> dkayiwa: yes man, it is the best thing to do.
|
11:06:17
|
<dkayiwa> hahaha :)
|
11:16:12
|
<joeseff> dkayiwa: I'm stuck again. The sources are stored in the concept_reference_source table while the class diagnosis is stored in the concept_class table. I've searched with no success for a table that connects the two but I can't find it. Might you be knowing how the two tables are related in openmrs?
|
11:18:15
|
<dkayiwa> joeseff: i think lets use sql only as a last resort. so you could try ask on the list if people have had experiences doing that in any form entry module
|
11:18:46
|
<joeseff> dkayiwa: Ok, thanks
|
11:19:14
|
<dkayiwa> joeseff: if it turns out that they have done it in any module, then i will then direct you on how to do the same with the xforms module
|
11:20:30
|
<portablejim> I found another reference to the 'Patch' page. Step 6 in "How to working on an OpenMRS Ticket, in 5 minutes" https://wiki.openmrs.org/display/docs/Tickets
|
11:21:00
|
<joeseff> dkayiwa: I'll ask them right away thanks!
|
11:21:57
|
<joeseff> rafa: djazayeri: mseaton: Might you be knowing how to cause a combobox to display values from a given concept source of a particular class e.g a combobox that displays ICD10 choices for Diagnoses?
|
11:22:16
|
<ekow> Guys where is the link on documentation to EncounterProvider settings on HTML forms
|
11:23:49
|
<rafa> ekow: have you seen this https://wiki.openmrs.org/display/docs/HTML+Form+Entry+Module+HTML+Reference ?
|
11:24:54
|
<ekow> <rafa> Thanks Rafa, I think thats what I was looking for.
|
11:25:04
|
<rafa> ekow: np
|
11:26:02
|
*** bharath has joined #openmrs
|
11:26:38
|
<rafa> joeseff: I'm sorry I don't know that
|
11:27:36
|
<rafa> joeseff: maybe e-mail the dev list
|
11:27:41
|
<joeseff> rafa: No problem, its just a possibility I'm exploring for building a form, but thanks for trying :)
|
11:28:17
|
<joeseff> rafa: I'll definitely do that
|
11:45:44
|
<ekow> Hi guys ...again form submission error. Could not insert !!
|
11:46:09
|
<dkayiwa> joeseff: if all you want is filter concepts by class, then thats already available
|
11:47:16
|
<dkayiwa> ekow: can you create a brand new html form (the default) and only change the encounterProvider tag to that which includes role. Try submit a form and tell us what happens
|
11:49:02
|
<ekow> <hi daniel> Could you just send me a form with just the three or four stuff that captures Encounter provider. Or I can send it to you for you to okay it.\provider
|
11:50:07
|
<joeseff> dkayiwa: Do you mean by using the external source property?
|
11:51:24
|
<dkayiwa> joeseff: yes if all you are doing is filtering by concept class
|
11:52:00
|
<dkayiwa> joeseff: assuming you are aware that concept source and concept class are not the same :)
|
11:53:35
|
<joeseff> dkayiwa: Thanks. I'm working with Dr. Steve Letchford, so I'll run the idea past him and see what he says about it. I do know the difference thanks :-D
|
11:54:00
|
<dkayiwa> :)
|
11:59:30
|
<dkayiwa> ekow: hi
|
12:00:07
|
<dkayiwa> ekow: can you use my name as it appears in irc? that way i will be immediately alerted when you mention it :)
|
12:02:42
|
*** ekow_ has joined #openmrs
|
12:05:10
|
<akwatuha> dkayiwa hi
|
12:05:21
|
<dkayiwa> akwatuha: hi
|
12:09:18
|
<akwatuha> I realized some code/classes in the current openmrs-core 1.10 on github has some classes that i would need in building my complex obs handler. Given that the current version in our production environment lacks some of the classes how would i ensure the module runs well in our environment? Does it mean if i use the core in github i need to change the version
|
12:09:18
|
<akwatuha> in production? or i will just need to add a dependency in my module and install a current jar in my m2?
|
12:10:30
|
*** downey sets mode: +o burke_
|
12:10:30
|
*** ChanServ sets mode: -o burke_
|
12:10:35
|
*** downey sets mode: +o djazayeri
|
12:10:35
|
*** ChanServ sets mode: -o djazayeri
|
12:14:46
|
<dkayiwa> akwatuha: which ticket is that?
|
12:14:48
|
<akwatuha> dkayiwa I realized some code/classes in the current openmrs-core 1.10 on github has some classes that i would need in building my complex obs handler. Given that the current version in our production environment lacks some of the classes how would i ensure the module runs well in our environment? Does it mean if i use the core in github i need to change the
|
12:14:48
|
<akwatuha> version in production? or i will just need to add a dependency in my module and install a current jar in my m2?
|
12:17:45
|
*** ruwanego has quit IRC
|
12:20:23
|
*** k-joseph has joined #openmrs
|
12:23:10
|
*** k-joseph_ has joined #openmrs
|
12:23:54
|
<akwatuha> dkayiwa working on https://jira.ampath.or.ke/browse/AMRS-180
|
12:24:53
|
<dkayiwa> akwatuha: like which class are you looking at?
|
12:25:09
|
*** k-joseph has quit IRC
|
12:26:02
|
<akwatuha> dkayiwa : CustomDatatype which is in openmrs-core 1.10 but not available in my source code for openmrs 1.8.2
|
12:28:45
|
<dkayiwa> akwatuha: if it was introduced in 1.9 like i assume, then i think you would need to upgrade to atleast 1.9 to take advantage of it
|
12:29:45
|
*** harsz89 has joined #openmrs
|
12:33:41
|
*** k-joseph_ has quit IRC
|
12:38:44
|
<downey> djazayeri, burke_, mcwere, wyclif__ ... if you're using IRCcloud don't forget to add your nickserv password in the freenode server settings so it will automatically authenticate you to services
|
12:40:15
|
<akwatuha> dkayiwa: okay thanks
|
12:43:46
|
*** kavuri has quit IRC
|
12:44:53
|
*** wyclif_ has quit IRC
|
12:45:23
|
*** bwolfe has joined #openmrs
|
12:48:17
|
*** shangxiao has joined #openmrs
|
13:01:10
|
*** k-joseph has joined #openmrs
|
13:01:30
|
*** rajith has joined #openmrs
|
13:02:46
|
<shangxiao> anyone need paid work done with OpenMRS ? :D
|
13:03:03
|
<shangxiao> <-- awesome developer who's worked with OpenMRS for a year now ;)
|
13:10:49
|
*** k-joseph has quit IRC
|
13:11:32
|
<downey> shangxiao: the only opening i know of at the moment is in kenya :) http://icchange.ca/media/31363/software_developer_position__kenya__final_.pdf
|
13:11:36
|
<OpenMRSBot> <http://ln-s.net/+u$D> (at icchange.ca)
|
13:13:18
|
<ibewes> shangxiao: I think there was someone in somaliland looking for OpenMRS devs. Don't remember any details though
|
13:17:26
|
*** shangxiao has quit IRC
|
13:18:45
|
*** shangxiao has joined #openmrs
|
13:31:12
|
*** suranga_ has joined #openmrs
|
13:32:17
|
*** suranga_ has joined #openmrs
|
13:32:47
|
<suranga_> howdy guys, hope you can still remember me :)
|
13:33:59
|
<downey> hey suranga_ :)
|
13:34:00
|
*** bwolfe has quit IRC
|
13:34:26
|
*** wyclif_ has joined #openmrs
|
13:34:31
|
<suranga_> downey: howdy, im enjoying the benifits of irccloud
|
13:34:38
|
<suranga_> nice to see you're back :)
|
13:35:25
|
<shangxiao> hey suranga
|
13:35:34
|
*** wyclif__ has quit IRC
|
13:36:01
|
<downey> suranga_: cool
|
13:36:14
|
<shangxiao> downey - I'm located in Australia so only remote work ;)
|
13:36:26
|
*** wyclif_ has quit IRC
|
13:36:33
|
<downey> shangxiao: have you been involved with the hack nights for humanity there?
|
13:36:53
|
<shangxiao> yep
|
13:37:01
|
<downey> excellent :)
|
13:37:09
|
<shangxiao> I've been designated as the (unofficial) tech lead ;)
|
13:37:15
|
<downey> haha, cool
|
13:37:16
|
*** wyclif has joined #openmrs
|
13:37:25
|
<downey> i think those are our longest-running openmrs event ever
|
13:37:30
|
<shangxiao> lol
|
13:37:48
|
<suranga_> howdy shangxiao
|
13:37:48
|
<shangxiao> yes since june last year
|
13:37:53
|
<shangxiao> we've had people come and go
|
13:38:06
|
<shangxiao> and there are a few remaining original people ;)
|
13:38:22
|
<suranga_> hmm... shangxiao , I thought that you were American... in fact, I thought you worked for RG ... :)
|
13:38:35
|
<shangxiao> but I don't know what RG is :)
|
13:38:43
|
<shangxiao> Regenstrief?
|
13:38:46
|
<downey> suranga_: you might be thinking of hui xiao
|
13:39:16
|
<shangxiao> "Shang Xiao" means colonel
|
13:39:26
|
<shangxiao> ala Colonel Sanders (KFC)
|
13:39:36
|
<shangxiao> aka David Sanders ;)
|
13:39:39
|
<downey> shangxiao: the first year is always the most challenging ... i've heard if a group can last the first year they probably will stick around for a long time
|
13:39:43
|
<suranga_> ooooh, im really, sorry, my mistake :)
|
13:40:04
|
* downey arranges a KFC visit for suranga_ this fall
|
13:40:21
|
<suranga> :D
|
13:40:45
|
<suranga> we're all awaiting fall with much eagerness these days, for certain reasons :P
|
13:40:58
|
<shangxiao> downey - yeah we had a big learning curve bringing ourselves up to pace with OpenMRS code and how modules actually work
|
13:41:22
|
<shangxiao> I'm lucky because I've worked with Java/Spring/Hibernate before but there are people who even struggle with Maven, Git, Java, Spring, etc, etc
|
13:42:11
|
<shangxiao> Once we're done I'm going to write an article on how to write an OpenMRS - with AngularJS & Hibernate annotations
|
13:42:19
|
<shangxiao> +module
|
13:42:37
|
<downey> shangxiao: btw, if you all ever need any guidance or support from the rest of the community, just let us know how we can be of service :)
|
13:42:56
|
<shangxiao> oh yeah I ask questions on here all the time ;)
|
13:43:04
|
<shangxiao> and on the mailing list
|
13:43:09
|
<downey> yep yep
|
13:43:10
|
<shangxiao> everyone is very patient and helpful
|
13:45:04
|
*** portablejim has quit IRC
|
13:49:03
|
*** rajith has quit IRC
|
13:50:20
|
*** joeseff has quit IRC
|
13:58:22
|
*** andrea_ has joined #openmrs
|
13:58:49
|
*** ibewes has left #openmrs
|
14:00:16
|
*** bwolfe has joined #openmrs
|
14:01:49
|
*** ChanServ sets mode: +o bwolfe
|
14:03:56
|
<andrea_> cpower, are we scrumming?
|
14:06:07
|
<mseaton> !scrumon
|
14:06:07
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster - you may begin when ready.
|
14:06:22
|
<andrea_> cpower, anyone here?
|
14:06:48
|
<mseaton> order: andrea_ , wyclif , dkayiwa, rafa, mseaton, others
|
14:06:51
|
<mseaton> andrea_: you're up
|
14:07:04
|
<andrea_> Tuesday
|
14:07:04
|
<andrea_> Dental emergency - had to go to dentist and take rest of day off
|
14:07:04
|
<andrea_> Wednesday
|
14:07:04
|
<andrea_> Design call
|
14:07:06
|
<andrea_> Pick new ticket from swim lane
|
14:07:08
|
<andrea_> Work on new ticket
|
14:07:10
|
<andrea_> No Blockers
|
14:08:28
|
<mseaton> wyclif: ?
|
14:08:32
|
<wyclif> Tuesday:
|
14:08:32
|
<wyclif> -SYNC-294 - Ensure outgoing sync error details are properly logged and available to the administrator
|
14:08:32
|
<wyclif> -Worked on syncing cohort members for SYNC-307 - Sync fails to save collections of non-openmrs objects if the owning object has no updates
|
14:08:32
|
<wyclif> Wednesday:
|
14:08:32
|
<wyclif> -Design call
|
14:08:34
|
<wyclif> -Review swimlane tickets
|
14:08:38
|
<wyclif> -Pick another sprint ticket
|
14:08:40
|
<wyclif>
|
14:08:42
|
<wyclif> Blockers: None
|
14:08:53
|
<dkayiwa> Committed: Cannot download database from parent during child server setup - SYNC-285
|
14:08:53
|
<dkayiwa> Working on: Add Javascript Refresh to Overview page in Sync Module - SYNC-54
|
14:08:53
|
<dkayiwa> No Blockers
|
14:09:16
|
<mseaton> rafa: anything to share?
|
14:09:17
|
<rafa> Today:
|
14:09:17
|
<rafa> * Committed META-324: Names should not be purged but voided
|
14:09:17
|
<rafa> https://tickets.openmrs.org/browse/META-324
|
14:09:17
|
<rafa> * Committed TRUNK-3944: Incorrect mockito, hamcrest and junit dependencies
|
14:09:17
|
<rafa> https://tickets.openmrs.org/browse/TRUNK-3944
|
14:09:18
|
<rafa> * Reworking TRUNK-3944 (need to fix tests when running with junit 4.11)
|
14:09:18
|
<rafa> * University Forum
|
14:09:19
|
<rafa> No blockers.
|
14:09:43
|
<mseaton> i'm mostly doing code review
|
14:09:57
|
<mseaton> i think i might have to punt SYNC-295 until after the sprint :(
|
14:10:56
|
<mseaton> at this stage, with only 1+ days left on the sprint, i think our priorities should be tying off anything in the in-progress column and either punting them (if no or little work has started), or working together to finish them
|
14:11:19
|
<mseaton> that should be the priority over picking new tickets to start
|
14:11:51
|
<andrea_> mseaton, is there anything I can do to help?
|
14:12:01
|
<mseaton> dkayiwa: and wyclif , of the tickets currently in progress, what do we think we can get done by the end of hte sprint?
|
14:12:48
|
<mseaton> eg. dkayiwa maybe punt SYNC-54 unless you have made significant progress
|
14:12:59
|
<dkayiwa> mseaton: ok
|
14:13:01
|
<mseaton> dkayiwa: since there are other tickets marked as rework needed, etc
|
14:13:11
|
<dkayiwa> mseaton: ok
|
14:13:50
|
<mseaton> dkayiwa: and if you finish your tickets, start reviewing my or wyclif's tickets, and do a little testing, would be great
|
14:14:06
|
<dkayiwa> mseaton: ok
|
14:14:21
|
<wyclif> mseaton, i will done with all my tickets
|
14:14:23
|
* cpower apologies I'm having a lot of drive by people at my desk this morning.
|
14:14:27
|
<wyclif> mseaton, i will be done with all my tickets
|
14:15:10
|
<mseaton> wyclif: great. remember, they will all need time to go through code review and possible minor rework, so please allow for that.
|
14:15:26
|
<wyclif> mseaton, ok
|
14:16:13
|
<cpower> Will there be someone to take on SYNC-291 and 292 and be able to complete by tomorrow?
|
14:16:44
|
<mseaton> wyclif: and dkayiwa if we finish all the tickets that are currently in the "in progress" column early, i'd love to pair with you guys on sync-295 a little more to get the design right, since it is still a high priority for me and i'll likely do it after the sprint is over.
|
14:17:10
|
<dkayiwa> mseaton: ok
|
14:17:42
|
<mseaton> thanks. any other comments / updates from anyone?
|
14:17:50
|
<cpower> Will there be someone to take on SYNC-291 and 292 and be able to complete by tomorrow?
|
14:18:20
|
<mseaton> cpower: what are those?
|
14:18:28
|
<mseaton> !ticket SYNC-291
|
14:18:31
|
<OpenMRSBot> mseaton: [#SYNC-291] Better handling of re-sending sync packages after failures - OpenMRS JIRA - https://tickets.openmrs.org/browse/SYNC-291
|
14:18:32
|
<mseaton> !ticket SYNC_292
|
14:18:33
|
<OpenMRSBot> mseaton: HTTP Error 404: Not Found - https://tickets.openmrs.org/browse/SYNC_292
|
14:18:33
|
*** rajith has joined #openmrs
|
14:18:37
|
<mseaton> !ticket SYNC-292
|
14:18:38
|
<OpenMRSBot> mseaton: [#SYNC-292] Provide more granular filtering on the history of changes page - OpenMRS JIRA - https://tickets.openmrs.org/browse/SYNC-292
|
14:18:40
|
<cpower> Two "Should have" tickets still left in To Do
|
14:19:16
|
<mseaton> cpower: well, given that one "Absolutely must have" (which was assigned to me the entire sprint) is likely not to get done, that's more my prioirty
|
14:19:35
|
<cpower> of course, I was looking at anyone else
|
14:19:49
|
<mseaton> cpower: i'm happy for these 2 to get worked on, but i don't want them left hanging tomorrow when everyone rolls off
|
14:20:03
|
<mseaton> cpower: and currently there are still lots of tickets in progress
|
14:20:42
|
<cpower> mseaton: Good point, we just need to do a better job next time around of getting to the tickets that were given priority over the others.
|
14:21:09
|
<cpower> mseaton: But agreed we should get what we have in progress done
|
14:21:13
|
<mseaton> cpower: yes. if you are referring to priority put on the sprint wiki page, thta prioirty was superceded by the agile board once the sprint started.
|
14:21:45
|
<mseaton> !scrumoff
|
14:21:45
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:25:03
|
<andrea_> wyclif, sorry to disappear on you yesterday
|
14:26:11
|
*** k-joseph has joined #openmrs
|
14:42:12
|
*** shortend has quit IRC
|
14:45:09
|
*** kavuri has joined #openmrs
|
14:53:19
|
*** k-joseph has quit IRC
|
14:55:29
|
*** lh has joined #openmrs
|
15:01:02
|
<downey> welcome lh :)
|
15:03:01
|
*** kavuri has quit IRC
|
15:12:32
|
*** kavuri has joined #openmrs
|
15:12:57
|
*** harshadura has joined #openmrs
|
15:17:13
|
*** k-joseph has joined #openmrs
|
15:34:01
|
<lh> downey, good to see you. :)
|
15:35:22
|
*** rafa has quit IRC
|
15:36:55
|
*** shangxiao has quit IRC
|
15:39:09
|
*** kavuri has quit IRC
|
15:40:30
|
*** suranga__ has joined #openmrs
|
15:40:43
|
<jkeiper> mseaton: (when you are back) ... will I mess up any inner workings if I use the reporting services to cache report data that I generated from my own service? I kinda want it to be permanently cached (e.g. persisted to the filesystem or db) so I can manually remove them as needed.
|
15:40:49
|
*** k-joseph has quit IRC
|
15:40:55
|
*** jblaya has joined #openmrs
|
15:41:43
|
<mseaton> jkeiper: example?
|
15:42:19
|
<jblaya> dkayiwa, suranga, quick question, in openmrs 1.9 where do you see and download the xslt for a form? I'm trying to follow the instructions for xforms, but can't find the xslt for a form
|
15:42:46
|
<mseaton> jkeiper: i doubt it will be a problem. the services are there to be used. if you want to save every report you generate, the module will allow you to do that.
|
15:44:59
|
<jkeiper> mseaton: i use my own report runner task instead of the Report Request mechanism ... just want to store the report data in a common fashion (to what you are already doing) instead of writing it out as a CSV and reading it back in
|
15:45:28
|
<jkeiper> mseaton: might not be an issue once I have rendered it out as HTML and Excel ... I suppose I won't need access to the report data again after that
|
15:45:46
|
<jkeiper> mseaton: i assume that's the approach you took?
|
15:46:14
|
<mseaton> jkeiper: the reporting framework stores and retrieves data based on uuid, so you should be able to use the same directories without conflict
|
15:46:35
|
<jblaya> suranga_, suranga__, wyclif, quick question, in openmrs 1.9 where do you see and download the xslt for a form? I'm trying to follow the instructions for xforms, but can't find the xslt for a form
|
15:47:16
|
<jkeiper> mseaton: excellent, thanks ... just want to do "the right thing" but keep some element of control over the processing; I have other tasks building tables that several columns point at
|
15:47:33
|
<jkeiper> mseaton: so i have to lock running the reports if the enrollment table is being rebuilt
|
15:47:38
|
<suranga__> jblaya, howdy :)
|
15:47:59
|
<jkeiper> mseaton: so i won't be using the actual Report Requests ... although I've mimicked them pretty hard core (without knowing that they even existed ... until yesterday).
|
15:48:06
|
<jblaya> suranga__, hey
|
15:48:06
|
<suranga__> jblaya, unfortunately, thats one subject I know very little about. Maybe we can bug dkayiwa about it ? :)
|
15:48:34
|
<jblaya> suranga__, I didn't know which handle to use for you :-) ok, I will
|
15:48:35
|
<mseaton> jkeiper: i see, makes sense. would be interesting to look at how they don't meet your needs, and whether it would make sense to adapt them to enable you to use them.
|
15:48:57
|
<suranga__> jblaya, sorry about that, Im afraid i;ve never actually used xforms before :(
|
15:49:13
|
<jblaya> suranga__, no worries :-)
|
15:49:18
|
<jkeiper> mseaton: number one thought is that i use code to build the report definition ... not sure if i can serialize it after i've designed it and have it loaded / run properly by a reporting
|
15:49:54
|
<jkeiper> mseaton: but where there's a will, there's a way
|
15:50:22
|
<mseaton> jkeiper: right.
|
15:50:26
|
<jkeiper> mseaton: so ... perhaps after the *!&#!storm is over on delivering these reports, I can come back and make my solution more elegant
|
15:55:17
|
*** bwolfe has quit IRC
|
16:04:50
|
*** Hasintha_i has joined #openmrs
|
16:07:06
|
<dkayiwa> jblaya: hi
|
16:10:05
|
*** andrea_ has quit IRC
|
16:21:04
|
*** bharath has quit IRC
|
16:28:34
|
*** k-joseph has joined #openmrs
|
16:36:36
|
<k-joseph> :)
|
16:57:29
|
<djazayeri> downey: trying to set up invite for hangout tomorrow. It isn't giving me the on-air option. any idea why?
|
17:02:10
|
*** rajith has quit IRC
|
17:02:33
|
*** rajith has joined #openmrs
|
17:07:07
|
*** k-joseph has quit IRC
|
17:09:17
|
<djazayeri> dkayiwa: to clarify you were saying that either of the two time options works for you?
|
17:09:29
|
<dkayiwa> djazayeri: yes :)
|
17:09:44
|
<djazayeri> dkayiwa: cool
|
17:13:03
|
*** dkayiwa_ has joined #openmrs
|
17:15:12
|
*** dkayiwa has quit IRC
|
17:15:13
|
*** dkayiwa_ is now known as dkayiwa
|
17:15:52
|
*** kavuri has joined #openmrs
|
17:24:59
|
*** Hasintha_i has quit IRC
|
17:25:00
|
*** harsz89 has quit IRC
|
17:28:44
|
*** k-joseph has joined #openmrs
|
17:31:14
|
*** jblaya has quit IRC
|
17:42:52
|
*** andreapat has joined #openmrs
|
17:49:57
|
*** rkorytkowski has joined #openmrs
|
17:49:57
|
*** rkorytkowski is now known as rafa
|
17:49:57
|
*** ChanServ sets mode: +v rafa
|
18:04:37
|
*** k-joseph has quit IRC
|
18:06:35
|
<djazayeri> mseaton, wyclif, design call?
|
18:06:42
|
<djazayeri> rafa: you too, if you're around
|
18:06:56
|
<djazayeri> and anybody else interested. :-)
|
18:07:06
|
<rafa> djazayeri: it says the meeting has not yet started...
|
18:07:17
|
<djazayeri> try again
|
18:07:21
|
<djazayeri> I started it.
|
18:07:38
|
<rafa> djazayeri: ok :)
|
18:15:02
|
*** kavuri has quit IRC
|
18:22:13
|
*** rafa has quit IRC
|
18:31:07
|
<nribeka> djazayeri, is it possible for you to talk about kenya ehr tomorrow too for the dev call :D
|
18:31:22
|
<nribeka> or have rowan to talk about it :)
|
18:32:10
|
*** rkorytkowski has joined #openmrs
|
18:32:10
|
*** rkorytkowski is now known as rafa
|
18:32:10
|
*** ChanServ sets mode: +v rafa
|
18:33:37
|
*** r0bby has joined #openmrs
|
18:33:37
|
*** ChanServ sets mode: +v r0bby
|
18:36:12
|
*** robbyoconnor has quit IRC
|
18:39:38
|
*** ekow_ has quit IRC
|
18:40:28
|
*** ekow has quit IRC
|
18:57:38
|
*** rajith has quit IRC
|
19:05:45
|
*** rafa has quit IRC
|
19:07:42
|
<djazayeri> nribeka: you should email Rowan. :-)
|
19:08:17
|
<djazayeri> nribeka: I think it would be great for him, or better, Steven Wanyee, to talk about it.
|
19:17:43
|
<nribeka> thanks djazayeri. i will email email Rowan and Steven Wanyee about it :)
|
19:21:20
|
*** r0bby_ has joined #openmrs
|
19:21:20
|
*** ChanServ sets mode: +v r0bby_
|
19:22:25
|
<dkayiwa> hi wyclif
|
19:22:47
|
<wyclif> hi dkayiwa
|
19:23:07
|
<dkayiwa> wyclif: i also noted that on 1.10, @NotTransactional causes tests to fail
|
19:23:46
|
<wyclif> dkayiwa, in sync
|
19:23:52
|
<dkayiwa> wyclif: yes
|
19:23:59
|
<dkayiwa> wyclif: with: org.hibernate.HibernateException: connnection proxy not usable after transaction completion
|
19:24:18
|
<dkayiwa> wyclif: removing it makes the test run
|
19:24:24
|
<wyclif> dkayiwa, is that in a unit test?
|
19:24:35
|
*** r0bby has quit IRC
|
19:24:39
|
<dkayiwa> wyclif: yes all of the unit tests in sync
|
19:25:03
|
<wyclif> dkayiwa, the opposite should be true, in sync removing the annotation should cause the tests to fail
|
19:25:18
|
<wyclif> dkayiwa, that annotation is required
|
19:25:41
|
<dkayiwa> wyclif: the same annotation causes the same exact sync tests to fail on 1.10
|
19:25:50
|
<wyclif> dkayiwa, on which line?
|
19:25:59
|
<dkayiwa> wyclif: all sync unit tests
|
19:26:03
|
<wyclif> dkayiwa, that is strange
|
19:26:15
|
<wyclif> dkayiwa, i recall running them and it worked
|
19:26:27
|
<dkayiwa> wyclif: not for 1.10
|
19:26:29
|
<wyclif> dkayiwa, i will look at it
|
19:27:32
|
<dkayiwa> wyclif: the only work with the annotation if you remove connection.commit() from BaseContextSensitiveTest in core
|
19:32:14
|
<wyclif> dkayiwa, actually the issue that forced me to call SessionFactoryUtils.getSession(factory, createNew) as i mentioned on the design call today was because that BaseContestSensitiveTest class calls deleteAllData() which was bombing
|
19:32:48
|
<wyclif> dkayiwa, but i will have to test it to ensure that my changed aren't the ones causing it
|
19:33:02
|
<dkayiwa> wyclif: ok
|
19:33:42
|
<dkayiwa> wyclif: which version of openmrs were you testing with?
|
19:34:06
|
<wyclif> just the one we are coding against, i.e 1.9.3
|
19:34:18
|
<wyclif> dkayiwa, but Mike did test against all
|
19:34:38
|
<dkayiwa> wyclif: the unit tests?
|
19:34:47
|
<wyclif> dkayiwa, yes
|
19:35:02
|
<dkayiwa> wyclif: you mean sync tests are now passing for 1.10???
|
19:49:00
|
*** wyclif_ has joined #openmrs
|
19:49:00
|
*** wyclif has quit IRC
|
19:49:10
|
*** suranga__ has quit IRC
|
19:49:43
|
<wyclif_> dkayiwa, i mean Mike tested them for multiple versions a while ago
|
19:50:17
|
<dkayiwa> wyclif_: am sure not for 1.10 because all unit tests fail for 1.10
|
19:50:26
|
*** cospih has joined #openmrs
|
19:56:08
|
*** r0bby_ is now known as robbyoconnor
|
20:04:31
|
*** bwolfe has joined #openmrs
|
20:04:37
|
*** burke_ has quit IRC
|
20:04:54
|
*** mcwere has quit IRC
|
20:04:54
|
*** akwatuha has quit IRC
|
20:04:54
|
*** docpaul has quit IRC
|
20:04:54
|
*** mseaton has quit IRC
|
20:05:26
|
*** cpower has quit IRC
|
20:06:35
|
*** volodymyr has quit IRC
|
20:07:07
|
*** sunbiz has quit IRC
|
20:42:26
|
*** wyclif_ has quit IRC
|
20:42:42
|
*** wyclif has joined #openmrs
|
20:51:09
|
*** dkayiwa_ has joined #openmrs
|
20:53:03
|
*** dkayiwa has quit IRC
|
20:53:03
|
*** dkayiwa_ is now known as dkayiwa
|
20:55:45
|
*** cospih_ has joined #openmrs
|
20:56:34
|
<wyclif> hi djazayeri
|
20:56:37
|
<wyclif> hi dkayiwa
|
20:56:44
|
<wyclif> sorry djazayeri
|
20:56:44
|
<dkayiwa> wyclif: hi
|
20:56:52
|
<dkayiwa> wyclif: :D
|
20:57:46
|
<wyclif> look at the history of BaseContextSensitiveTest in core, rafa removed some logic that closed a session after every test method and i think that is what breaks things in 1.10
|
20:58:13
|
<wyclif> dkayiwa, if you out it back they might pass
|
20:58:24
|
*** cospih has quit IRC
|
20:58:30
|
<dkayiwa> wyclif: ok
|
20:58:33
|
<wyclif> dkayiwa, so we might need to revisit that
|
20:58:40
|
<dkayiwa> wyclif: ok
|
21:05:12
|
*** downey has quit IRC
|
21:05:13
|
*** suranga_ has quit IRC
|
21:05:13
|
*** djazayeri has quit IRC
|
21:05:13
|
*** suranga has quit IRC
|
21:05:13
|
*** ryates has quit IRC
|
21:05:13
|
*** ojwangantony has quit IRC
|
21:05:13
|
*** nribeka has quit IRC
|
21:05:13
|
*** jkeiper has quit IRC
|
21:07:44
|
*** jblaya has joined #openmrs
|
21:19:28
|
*** bwolfe has quit IRC
|
21:26:16
|
*** jblaya has quit IRC
|
21:31:32
|
*** h3llborn has joined #openmrs
|
21:38:03
|
<h3llborn> wow where's everyone?
|
21:39:01
|
*** wyclif_ has joined #openmrs
|
21:39:16
|
*** volodymyr has joined #openmrs
|
21:39:19
|
*** wyclif has quit IRC
|
21:39:22
|
<dkayiwa> fishing :)
|
21:49:07
|
<h3llborn> ahaha too cold up here in canada for that :P
|
21:53:40
|
<dkayiwa> must be the same in most parts of the US
|
21:57:46
|
<h3llborn> well it all depends on where you are
|
21:57:50
|
<h3llborn> florida is always warm :P
|
21:58:33
|
*** wyclif_ has quit IRC
|
22:15:10
|
*** dkayiwa has quit IRC
|
22:15:15
|
*** zednet has joined #openmrs
|
22:49:26
|
<h3llborn> for anyone who wants a good laugh
|
22:49:27
|
<h3llborn> https://www.youtube.com/watch?v=2nXpVl9l43A
|
22:49:31
|
<h3llborn> sfw
|
22:49:58
|
*** downey has joined #openmrs
|
22:49:58
|
*** ChanServ sets mode: +o downey
|
22:53:58
|
*** jkeiper has joined #openmrs
|
22:53:58
|
*** ChanServ sets mode: +v jkeiper
|
22:54:08
|
*** docpaul has joined #openmrs
|
22:54:08
|
*** ChanServ sets mode: +o docpaul
|
22:54:23
|
*** nribeka has joined #openmrs
|
22:54:23
|
*** ChanServ sets mode: +v nribeka
|
22:58:58
|
*** burke_ has joined #openmrs
|
22:59:09
|
*** cpower has joined #openmrs
|
22:59:09
|
*** ChanServ sets mode: +v cpower
|
23:07:07
|
*** djazayeri has joined #openmrs
|
23:10:17
|
*** carloshpf has joined #openmrs
|
23:12:17
|
*** carloshpf has quit IRC
|
23:23:43
|
<h3llborn> looks like we got some more company
|
23:29:40
|
*** mseaton has joined #openmrs
|
23:29:40
|
*** ChanServ sets mode: +v mseaton
|
23:40:54
|
*** andreapat has quit IRC
|
23:42:14
|
*** wyclif_ has joined #openmrs
|
23:50:22
|
<h3llborn> anyone gonna watch the new gatsby movie?
|
23:53:15
|
*** ojwangantony has joined #openmrs
|
23:56:43
|
*** cospih_ has quit IRC
|