| 00:00:08 | *** wyclif_ has joined #openmrs |
| 00:03:45 | *** djazayeri has joined #openmrs |
| 00:04:09 | *** wyclif_ is now known as wyclif__ |
| 00:04:18 | <robbyoconnor> hey sandeephukku |
| 00:05:34 | <sandeephukku> robbyoconnor:Hello robbyoconnor |
| 00:06:09 | <robbyoconnor> sandeephukku: no need to address me twice! |
| 00:06:26 | <sandeephukku> robbyoconnor:Sir can you please help me out with the problem statement |
| 00:07:17 | <sandeephukku> robbyoconnor:Sorry for addressing you twice. |
| 00:08:49 | <robbyoconnor> sure link? |
| 00:09:21 | <sandeephukku> robbyoconnor:https://wiki.openmrs.org/display/projects/Appointment+Module |
| 00:16:04 | <robbyoconnor> It's early yet -- if you're interested one can be assigned yet...what you can do: 1) send a message to the developers list with questions 2) come back around tomorrow sometime |
| 00:16:14 | <robbyoconnor> the devlopers list will be your best bet however! |
| 00:16:26 | <robbyoconnor> introduce yourself to the community :) |
| 00:17:41 | <robbyoconnor> all people involved in that are on the mailing list (but may not lurk on IRC) |
| 00:17:48 | <robbyoconnor> good luck |
| 00:18:12 | <sandeephukku> Thank You sir. |
| 00:18:37 | <robbyoconnor> No problem :) |
| 00:18:40 | <robbyoconnor> good luck! |
| 00:19:05 | <robbyoconnor> Read this: https://wiki.openmrs.org/download/attachments/37290157/User+Stories+v3.pdf?version=1&modificationDate=1353406112000 |
| 00:19:08 | *** sandeephukku has quit IRC |
| 00:19:09 | <robbyoconnor> if that helps you |
| 00:29:26 | *** wluyima has quit IRC |
| 00:29:48 | *** wluyima has joined #openmrs |
| 00:47:19 | *** burke_ has joined #openmrs |
| 00:51:07 | *** burke has quit IRC |
| 00:59:00 | *** r0bby has joined #openmrs |
| 00:59:00 | *** ChanServ sets mode: +v r0bby |
| 01:02:26 | *** robbyoconnor has quit IRC |
| 01:07:07 | *** r0bby has quit IRC |
| 01:08:21 | *** r0bby_ has joined #openmrs |
| 01:08:21 | *** r0bby_ has joined #openmrs |
| 01:08:21 | *** ChanServ sets mode: +v r0bby_ |
| 01:12:39 | *** robbyoconnor has joined #openmrs |
| 01:12:39 | *** ChanServ sets mode: +v robbyoconnor |
| 01:15:44 | *** r0bby_ has quit IRC |
| 01:28:01 | *** djazayeri has quit IRC |
| 01:48:21 | *** wluyima has left #openmrs |
| 01:55:56 | *** rajith has joined #openmrs |
| 02:12:11 | *** rajith has quit IRC |
| 02:32:33 | *** jb360 has joined #openmrs |
| 02:35:54 | *** harsz89 has joined #openmrs |
| 03:27:35 | *** djazayeri has joined #openmrs |
| 03:30:19 | *** harsz89 has quit IRC |
| 03:48:16 | <downey> robbyoconnor: thanks |
| 04:24:41 | *** upul has joined #openmrs |
| 04:24:41 | *** ChanServ sets mode: +v upul |
| 04:33:53 | *** upul has quit IRC |
| 04:34:28 | *** upul has joined #openmrs |
| 04:34:28 | *** ChanServ sets mode: +v upul |
| 04:44:00 | *** kavuri has joined #openmrs |
| 05:52:33 | *** joeseff has joined #openmrs |
| 06:01:55 | <robbyoconnor> downey: no problem:) |
| 06:32:42 | *** shortend has joined #openmrs |
| 06:34:00 | *** ibewes has joined #openmrs |
| 06:46:58 | *** upul has quit IRC |
| 07:08:20 | *** magoo has joined #openmrs |
| 07:09:05 | *** magoo has quit IRC |
| 08:39:57 | *** kavuri has quit IRC |
| 08:41:04 | *** kavuri has joined #openmrs |
| 09:11:12 | *** rkorytkowski has joined #openmrs |
| 09:11:12 | *** ChanServ sets mode: +v rkorytkowski |
| 09:11:12 | *** rkorytkowski is now known as rafa |
| 09:33:30 | *** dkayiwa has joined #openmrs |
| 09:50:22 | <ibewes> Is there a specific reason that the OpenmrsMetadata and OpenmrsData interfaces don't include the same properties as their BaseOpenmrs counterparts? (ie, BaseOpenmrsMetadata and BaseOpenmrsData) |
| 09:55:42 | <rafa> dkayiwa: hey! |
| 09:55:55 | <rafa> dkayiwa: how are you? |
| 09:56:02 | <dkayiwa> rafa: welcome back :) |
| 09:56:10 | <rafa> dkayiwa: thanks :D |
| 09:56:18 | <dkayiwa> rafa: doing fine though we were missing you :) |
| 09:56:32 | <rafa> dkayiwa: could you brief me in what we are doing this week? :) |
| 09:56:47 | <dkayiwa> rafa: doing the sync sprint :) |
| 09:57:00 | <rafa> dkayiwa: when does it end? |
| 09:57:16 | <dkayiwa> rafa: i think wednesday this week |
| 09:57:23 | <rafa> dkayiwa: okay, thanks |
| 09:58:16 | <rafa> ibewes: what properties are not included? |
| 09:59:41 | <ibewes> rafa: OpenmrsMetadata only has name and description, it is missing the creation, update, and retire stuff in BaseOpenmrsMetadata |
| 10:00:15 | <rafa> ibewes: it inherits the other properties from Auditable, Retireable and OpenmrsObject interfaces |
| 10:00:48 | <ibewes> rafa: ah... thanks! |
| 10:01:28 | <ibewes> rafa: I was looking specifically as BaseOpenmrsMetadata.getRetired |
| 10:01:50 | <ibewes> rafa: which isn't on the Retireable interface (only isRetired) |
| 10:02:11 | <rafa> ibewes: I think getRetired has been forgotten in Auditable |
| 10:02:11 | <ibewes> rafa: should have looked closer before bothering you all :) |
| 10:02:31 | <rafa> ibewes: we couldn't change the interface so it was only added to the abstract class |
| 10:02:59 | <ibewes> rafa: right, no big deal there... I just update my code (isRetired reads much better anyway) |
| 10:03:24 | <rafa> ibewes: cool |
| 10:04:37 | *** joeseff has quit IRC |
| 10:13:32 | *** rafa has quit IRC |
| 10:18:29 | *** k-joseph has joined #openmrs |
| 10:26:03 | *** rkorytkowski has joined #openmrs |
| 10:26:03 | *** ChanServ sets mode: +v rkorytkowski |
| 10:26:03 | *** rkorytkowski is now known as rafa |
| 10:41:27 | *** kavuri has quit IRC |
| 10:42:02 | *** kavuri has joined #openmrs |
| 10:53:01 | *** joeseff has joined #openmrs |
| 10:57:48 | *** kavuri has quit IRC |
| 11:10:03 | *** k-joseph has quit IRC |
| 11:13:11 | *** kavuri has joined #openmrs |
| 11:16:01 | *** k-joseph has joined #openmrs |
| 11:23:14 | *** rajith has joined #openmrs |
| 11:37:58 | *** k-joseph has quit IRC |
| 11:44:56 | *** wyclif has joined #openmrs |
| 11:45:26 | *** wyclif has joined #openmrs |
| 11:57:31 | *** sunbiz has joined #openmrs |
| 11:57:31 | *** ChanServ sets mode: +v sunbiz |
| 12:03:31 | *** kavuri has quit IRC |
| 12:40:31 | *** rajith has quit IRC |
| 12:57:07 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Rest Web Services 2.0.efeaee uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=webservices.rest&version=&2.0.efeaee> |
| 12:57:27 | *** k-joseph has joined #openmrs |
| 12:58:36 | *** harshadura has joined #openmrs |
| 13:00:54 | *** harsz89 has joined #openmrs |
| 13:10:19 | *** rajith has joined #openmrs |
| 13:15:07 | <harsz89> hi mseaton |
| 13:24:04 | <k-joseph> :) |
| 13:28:14 | *** GitHub25 has joined #openmrs |
| 13:28:14 | <GitHub25> [openmrs-core] rkorytkowski pushed 2 new commits to master: http://git.io/fLmT1w |
| 13:28:14 | <GitHub25> openmrs-core/master ffdc062 Areo: TRUNK-3204 : Add JUnit test for getting by null/true/false isPreferred in HibernatePatientDAO.getPatientIdentifiers... |
| 13:28:14 | <GitHub25> openmrs-core/master 2252d65 Rafal Korytkowski: Merge pull request #231 from akolodziejski/TRUNK-3204... |
| 13:28:14 | *** GitHub25 has left #openmrs |
| 13:35:16 | <mseaton> harsz89: hey |
| 13:35:17 | <jkeiper> mseaton: when i add a sort criterion to a patient data set definition, in what order are they applied? it seems the sorting worked on the first column but when that is blank, i hoped it would sort on the second criterion i provided ... and it didn't. see |
| 13:35:17 | <jkeiper> https://github.com/jlkeiper/openmrs-module-amrsreports/blob/master/api/src/main/java/org/openmrs/module/amrsreports/reporting/provider/MOH361AReportProvider.java#L68 |
| 13:35:21 | <OpenMRSBot> <http://ln-s.net/+tLT> (at github.com) |
| 13:36:34 | <harsz89> mseaton, i hav out a comment on sync 293 ticket |
| 13:36:54 | <harsz89> mseaton, if i can hav a feedback i can implement it and send a pull request |
| 13:39:10 | <harsz89> mseaton, :) |
| 13:39:52 | *** travis-ci has joined #openmrs |
| 13:39:52 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [2252d65] [Rafal Korytkowski] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/5779264 |
| 13:39:52 | *** travis-ci has left #openmrs |
| 13:39:55 | <OpenMRSBot> <http://ln-s.net/+tL_> (at travis-ci.org) |
| 13:41:23 | <mseaton> harsz89: yep, i just saw it (monday morning here, still catching up) |
| 13:42:12 | <harsz89> mseaton, oopz sowi |
| 13:42:23 | <harsz89> mseaton, oopz sorry |
| 13:42:43 | <harsz89> mseaton, i forgot d time zone |
| 13:42:47 | <harsz89> mseaton, :( |
| 13:43:05 | <mseaton> harsz89: not a problem. the prodding helps :) |
| 13:43:15 | <harsz89> mseaton, :) |
| 13:43:31 | <harsz89> mseaton, thank you mseaton :) |
| 13:54:00 | *** harshadura has quit IRC |
| 13:56:56 | <cpower> Hello everyone |
| 13:57:14 | *** joeseff has left #openmrs |
| 13:57:40 | *** dkayiwa has quit IRC |
| 13:59:08 | <jkeiper> hhhheyyyy |
| 14:01:48 | <rafa> hello :) |
| 14:02:17 | *** shortend has quit IRC |
| 14:03:33 | *** ibewes has quit IRC |
| 14:05:14 | *** andrea_ has joined #openmrs |
| 14:05:16 | <rafa> is it scrum time? |
| 14:05:40 | <andrea_> rafa, hi welcome back |
| 14:05:47 | <rafa> andrea_: hi, thanks! :) |
| 14:07:11 | <mseaton> yes it is |
| 14:07:20 | <mseaton> !scrumon |
| 14:07:20 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster - you may begin when ready. |
| 14:08:07 | * cpower thanks mike for starting |
| 14:08:09 | <mseaton> order: me, jkeiper rafa, wyclif, andrea_, others as desired |
| 14:08:23 | <mseaton> * Finished up and committed SYNC-277 for lluis |
| 14:08:23 | <mseaton> * Reviewed and closed SYNC-247. Made a bunch of changes in order to resolve unit test data model issues |
| 14:08:23 | <mseaton> * Investigated and commented on SYNC-294, to reproduce situation for Wyclif |
| 14:08:23 | <mseaton> * Started investigating: SYNC-295, ended up running into and documentating a host of new issues |
| 14:08:23 | <mseaton> ** SYNC-308 - History of changes page does not correctly use configured setting for number of records per page (fixed this) |
| 14:08:24 | <mseaton> ** SYNC-309 - Sync Record Status on parent is not accurate if sync is fully successful (question sent to list) |
| 14:08:24 | <mseaton> ** SYNC-310 - SyncIngestService does not successfully save a sync import record if there is an exception thrown during processing (need feedback from others) |
| 14:08:25 | <mseaton> * Today hope to continue with SYNC-295 and hope to not continue discovering more issues |
| 14:08:25 | <mseaton> * Interested in seeing if we need to discuss SYNC-194 wyclif |
| 14:09:08 | * jkeiper is doing a LOT of reporting work for AMPATH ... the end. |
| 14:09:24 | <rafa> Today: |
| 14:09:24 | <rafa> * Cleaned up my e-mail queue |
| 14:09:24 | <rafa> * Released Webservices REST 2.0 |
| 14:09:24 | <rafa> * Reviewed some pull requests |
| 14:09:24 | <rafa> * Created and working on TRUNK-3944: Incorrect mockito, hamcrest and junit dependencies (after fighting with that in the MDS module) |
| 14:09:25 | <rafa> Discussion point: Need an update from djazayeri on META-326: In MIRROR import mode, adding existing privileges to a role doesn't work |
| 14:09:25 | <rafa> No blockers. |
| 14:10:32 | <cpower> wyclif__: you are up |
| 14:10:47 | <wyclif> Friday: |
| 14:10:47 | <wyclif> -REPORT-485 - Reporting module sqldiff fails if database is not utf8 |
| 14:10:47 | <wyclif> -Had irc chat in hibernate channel for work around for SYNC-287 - Sync module should prevent OpenMRS Core from persisting changes if no sync record is created |
| 14:10:47 | <wyclif> -Started on SYNC-307 - Sync fails to save collections of non-openmrs objects if the owning object has no updates |
| 14:10:48 | <wyclif> Monday: |
| 14:10:50 | <wyclif> -Continue with SYNC-307 - Sync fails to save collections of non-openmrs objects if the owning object has no updates |
| 14:10:53 | <wyclif> -Review swimlane tickets |
| 14:10:57 | <wyclif> |
| 14:10:59 | <wyclif> Blockers: None |
| 14:11:36 | <andrea_> Friday |
| 14:11:37 | <andrea_> TRUNK-3289 |
| 14:11:37 | <andrea_> Research whether Criteria needed for Query |
| 14:11:37 | <andrea_> Wiki documentation on debug in Eclipse |
| 14:11:37 | <andrea_> Commit code |
| 14:11:37 | <andrea_> Review swimlane ticket |
| 14:11:39 | <andrea_> Monday |
| 14:11:41 | <andrea_> TRUNK-3289 |
| 14:11:43 | <andrea_> Commit code |
| 14:11:47 | <andrea_> Pick new ticket |
| 14:11:49 | <andrea_> No blockers |
| 14:12:57 | <mseaton> wyclif: sync-287, what are the next steps? |
| 14:13:32 | <mseaton> !ticket SYNC-287 |
| 14:13:33 | <OpenMRSBot> mseaton: [#SYNC-287] Sync module should prevent OpenMRS Core from persisting changes if no sync record is created - OpenMRS JIRA - https://tickets.openmrs.org/browse/SYNC-287 |
| 14:14:10 | <wyclif> mseaton, to move the code to a BeforeTransactionCompletion process from processTransactionCompletion method |
| 14:14:33 | <wyclif> mseaton, did you see the comment i added after taking to one of the hibernate devs |
| 14:15:32 | <mseaton> wyclif: yes, i did. is it clear to you how to do it and are you planning to do it this week? |
| 14:15:34 | <rafa> djazayeri: are you around? |
| 14:16:30 | <wyclif> mseaton, it is clear to me, but i need to figure out when is the right time to register the process but with this solution it means we will be able to rethrow the exception but not handle it |
| 14:17:01 | <wyclif> mseaton, may be sync will register an error handler for the exception and display to the user a more informative page |
| 14:17:30 | <mseaton> wyclif: ok, let's keep this on our radar. talk more about it later on |
| 14:17:31 | <wyclif> mseaton, sure i will |
| 14:17:39 | <wyclif> mseaton, ok |
| 14:17:43 | <mseaton> ok, anyone with other updates to share? |
| 14:18:28 | <rafa> mseaton: any tickets in the sprint doable in the remaining time for me? |
| 14:19:05 | <mseaton> rafa: definitely. let's chat. |
| 14:19:08 | <mseaton> !scrumoff |
| 14:19:08 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 14:19:21 | <rafa> mseaton: ok |
| 14:19:59 | <mseaton> rafa: i know djazayeri was looking at mds fixes over the weekend, did you see that? |
| 14:20:20 | <rafa> mseaton: yes, trying to reach out to him |
| 14:20:25 | <rafa> mseaton: check what's the status |
| 14:21:42 | <mseaton> rafa: ok. he was having issues with junit compatibility. he got past them, but i'm curious if that's related to the ticket you mentioned above. |
| 14:22:47 | <rafa> mseaton: I see, thanks I'll wait for him, he's probably still sleeping |
| 14:26:42 | *** k-joseph has quit IRC |
| 14:44:50 | <jkeiper> rafa: welcome back |
| 14:45:46 | <jkeiper> mseaton: did you see my earlier question about sorting? seems like sorting by first criterion works but second does not ... |
| 14:46:19 | <mseaton> jkeiper: no, didn't see... |
| 14:46:25 | <mseaton> jkeiper: where is your question? |
| 14:46:47 | <jkeiper> mseaton: this is how i'm setting it up: https://github.com/jlkeiper/openmrs-module-amrsreports/blob/master/api/src/main/java/org/openmrs/module/amrsreports/reporting/provider/MOH361AReportProvider.java#L68 |
| 14:46:48 | <OpenMRSBot> <http://ln-s.net/+tLT> (at github.com) |
| 14:47:14 | <jkeiper> mseaton: basically .... oh wait, i think that's coming out as a string. is it sorted post-conversion? |
| 14:47:38 | <mseaton> jkeiper: what does commondateconverter do? |
| 14:47:52 | <mseaton> jkeiper: i would think i designed it to sort post-conversion |
| 14:48:02 | <jkeiper> mseaton: formats date to dd/MM/yyyy |
| 14:48:04 | <mseaton> jkeiper: as taht is what the user sees |
| 14:48:13 | <mseaton> jkeiper: that's probably the issue |
| 14:48:35 | <jkeiper> mseaton: aha ... so if i want something sorted by date i have to either leave it as a date (unformatted) or make it XML-style (yyyy-MM-dd) |
| 14:48:56 | <mseaton> jkeiper: i guess that's true as currently designed. none of this is set in stone though |
| 14:49:14 | <jkeiper> mseaton: haha ... i was hoping to add a custom comparator to compare two rows |
| 14:49:22 | <jkeiper> mseaton: but i understand just using a column |
| 14:49:40 | <mseaton> jkeiper: makes sense, if you are using the api, for this to be available. but wouldn't work for UI users |
| 14:49:45 | <jkeiper> mseaton: biggest concern is that MOH requires date to be in en_gb format |
| 14:49:56 | <mseaton> jkeiper: if you can find a way to add this feature seamlessly to the api, would be good |
| 14:50:28 | <jkeiper> mseaton: i'll ponder it ... registers are due today though, so i'll probably just hack it by adding columns indicating sort order :-D |
| 14:50:28 | <mseaton> jkeiper: well, you can always apply formatting at the rendering stage |
| 14:50:45 | <jkeiper> mseaton: ah, true ... hrm.... |
| 14:51:02 | <mseaton> jkeiper: the DataConverters are a convenience, but you c ould just leave it as a date, and then when rendering, add the format string as a part of the renderer |
| 14:51:19 | <mseaton> jkeiper: the ExcelTemplateRenderer, for example, allows you to include a format |
| 14:51:30 | <mseaton> jkeiper: as #columnName|dd/MMM/yyyy# |
| 14:51:36 | <jkeiper> mseaton: i'll consider that too ... would much rather just use dates as dates ... oooh, that sounds awesome |
| 14:51:45 | <jkeiper> mseaton: we used XLS renderer but not that one |
| 14:51:53 | <jkeiper> mseaton: my guys would LOVE to have it formatted too |
| 14:52:00 | <jkeiper> mseaton: with all the extras that come in the template |
| 14:52:04 | <jkeiper> mseaton: thanks! |
| 14:52:24 | <mseaton> jkeiper: good luck |
| 14:53:56 | <jkeiper> mseaton: hahaha thanks ... it's been a whirlwind getting the registers out, but I think we finally got rid of all logic definitions and have everything running through custom datadefinitions |
| 14:54:05 | <jkeiper> mseaton: so ... much ... faster, not sure why hql is so fast |
| 14:54:09 | <jkeiper> mseaton: but happy it is |
| 14:55:05 | <mseaton> jkeiper: bravo! this is going to be great for expanding data definition usage. |
| 14:55:53 | <jkeiper> mseaton: definitely ... hoping to generic-ize a multi-question-and-answer definition |
| 14:56:22 | *** h3llborn has joined #openmrs |
| 14:56:49 | <jkeiper> mseaton: haha yep, i didn't realize it was sorting by the date column alphabetically because it is actually a string |
| 15:03:28 | *** kavuri has joined #openmrs |
| 15:14:14 | *** h3llborn has quit IRC |
| 15:14:33 | *** h3llborn has joined #openmrs |
| 15:20:30 | *** h3llborn has quit IRC |
| 15:23:52 | <djazayeri> rafa: hey, you there? |
| 15:25:30 | *** h3llborn has joined #openmrs |
| 15:33:35 | *** k-joseph has joined #openmrs |
| 15:38:18 | *** rafa has quit IRC |
| 15:41:01 | *** k_joseph has joined #openmrs |
| 15:41:48 | *** k-joseph has quit IRC |
| 15:54:59 | *** kavuri has quit IRC |
| 15:59:53 | *** bwolfe has joined #openmrs |
| 15:59:53 | *** ChanServ sets mode: +o bwolfe |
| 16:00:06 | <bwolfe> helloooooooooo |
| 16:02:55 | *** andrea_ has quit IRC |
| 16:03:06 | <bwolfe> hmm, pretty quiet here. |
| 16:03:11 | <bwolfe> and now I need lunch. bbl |
| 16:03:18 | <djazayeri> bwolfe: welcome (back)! |
| 16:03:24 | <djazayeri> bwolfe: on a pair programming session |
| 16:03:37 | <bwolfe> pair irc chatting then? |
| 16:04:46 | <djazayeri> bwolfe: not my screen that's primary. :-) |
| 16:07:38 | *** k_joseph has quit IRC |
| 16:08:11 | *** bwolfe has quit IRC |
| 16:34:00 | *** kavuri has joined #openmrs |
| 16:39:55 | *** dkayiwa has joined #openmrs |
| 16:43:18 | *** Hasintha_i has joined #openmrs |
| 16:45:16 | *** harshadura has joined #openmrs |
| 16:56:02 | *** h3llborn has quit IRC |
| 17:00:31 | *** k-joseph has joined #openmrs |
| 17:01:39 | *** bwolfe has joined #openmrs |
| 17:01:47 | *** ChanServ sets mode: +o bwolfe |
| 17:02:04 | <bwolfe> when did docpaul start hanging out in here again? |
| 17:02:44 | <bwolfe> and burke_ too? now thats just craziness |
| 17:09:26 | *** k_joseph has joined #openmrs |
| 17:10:51 | *** k-joseph has quit IRC |
| 17:19:09 | *** k_joseph has quit IRC |
| 17:19:34 | *** kavuri has quit IRC |
| 17:20:18 | *** k-joseph has joined #openmrs |
| 17:20:23 | <sunbiz> bwolfe: welcome back!! |
| 17:20:31 | <sunbiz> bwolfe++ |
| 17:20:47 | <sunbiz> !karma bwolfe |
| 17:20:47 | <OpenMRSBot> sunbiz: Karma for "bwolfe" has been increased 135 times and decreased 29 times for a total karma of 106. |
| 17:20:54 | <sunbiz> wow !boom |
| 17:20:58 | <sunbiz> !boom |
| 17:20:59 | <OpenMRSBot> sunbiz: "boom" --- BOOOOOOOMMMMMMMMM!!!!!!!!!!!! |
| 17:23:46 | <bwolfe> :-) |
| 17:28:37 | <sunbiz> bwolfe: wassup?? howdy? |
| 17:28:54 | <sunbiz> yes, docpaul is seen at times lurking |
| 17:29:03 | <sunbiz> !seen docpaul |
| 17:29:03 | <OpenMRSBot> sunbiz: docpaul was last seen in #openmrs 4 days, 3 hours, 20 minutes, and 28 seconds ago: <docpaul> dkayiwa: hi! |
| 17:29:34 | <sunbiz> nay... not really says the OpenMRSBot... I guess hez just using IRCCloud |
| 17:30:30 | <sunbiz> downey: sorry for declining earlier... can I get an invite to irccloud :P |
| 17:30:50 | <sunbiz> downey: I want to be a bot as well :) |
| 17:31:03 | <bwolfe> irccloud failed on my chromebook, so I left it alone. you can have my invite sunbiz :-p |
| 17:34:59 | *** rkorytkowski has joined #openmrs |
| 17:34:59 | *** rkorytkowski is now known as rafa |
| 17:34:59 | *** ChanServ sets mode: +v rafa |
| 17:35:48 | <rafa> djazayeri: hi, are you there? |
| 17:36:22 | <djazayeri> rafa: hi, yes |
| 17:36:37 | <rafa> djazayeri: I wanted to ask about META-326 |
| 17:36:42 | <rafa> djazayeri: do you have a minute? |
| 17:36:44 | <djazayeri> rafa: I'm very happy that you're back from vacation today. (Sorry, I know you're probably less happy than me.) |
| 17:37:00 | <rafa> djazayeri: I'm very happy :D |
| 17:37:04 | <djazayeri> rafa: yes, are you in a position to do voice + TV? |
| 17:37:22 | <djazayeri> well, I don't know if screensharing is necessary |
| 17:37:23 | <rafa> djazayeri: I can do voice in 2 hours |
| 17:37:42 | <djazayeri> rafa: okay, I can type a bit now, and we can touch base later? |
| 17:37:45 | <rafa> djazayeri: now I'm in a rather loud place |
| 17:37:55 | <rafa> djazayeri: ok |
| 17:38:03 | <djazayeri> rafa: basically META-326 is still a problem |
| 17:38:15 | <djazayeri> rafa: my fix has a bug |
| 17:38:37 | <djazayeri> rafa: I understand what's going on, but I'm not 100% clear on how to address it. |
| 17:39:25 | <rafa> djazayeri: I see |
| 17:39:44 | <djazayeri> rafa: so, did you see the change I made? And did you understand why? |
| 17:40:02 | <rafa> djazayeri: yes |
| 17:40:17 | *** dkayiwa has joined #openmrs |
| 17:40:57 | <rafa> djazayeri: I'm not sure where is the problem now though |
| 17:40:59 | *** andreap has joined #openmrs |
| 17:41:10 | <djazayeri> rafa: okay, so in my fix, one thing I did was (in findAndRemoveMatchingElement) |
| 17:41:12 | <djazayeri> rafa: if (incomingElement.equals(existingElement) || comparisonEngine.equal(incomingElement, existingElement, incomingToExisting)) { |
| 17:41:28 | <djazayeri> rafa: the problem is taht comparisonEngine.equal is too loose for this specific |
| 17:41:29 | <djazayeri> case |
| 17:42:16 | <djazayeri> rafa: the specific case here is that we (and this is bad) in Mirebalais have two MDS packages, one with an old version of a concept, and one with a newer version |
| 17:42:32 | <djazayeri> rafa: the changes made to that concept involved changing its name |
| 17:42:55 | <djazayeri> rafa: so, if I do a from-scratch setup, I end up with a concept with 13 voided names (and no non-voided names) |
| 17:43:07 | <djazayeri> rafa: because comparisonEngine.equal doesn't check for voided-ness. |
| 17:43:19 | <rafa> djazayeri: right... |
| 17:43:36 | <djazayeri> rafa: so it's partly a data problem on our end (since we're importing two versions of the same concept in MIRROR mode) |
| 17:43:43 | <djazayeri> rafa: but it's also an underlying problem |
| 17:44:00 | <djazayeri> rafa: I only finally figured this out last night after midnight, so I havne't processed it all yet |
| 17:44:15 | *** Hasintha_i has quit IRC |
| 17:44:51 | <djazayeri> rafa: but the question is, what *should* happen when I import a concept in mirror mode, and it has a name that matches an existing voided name. |
| 17:45:02 | <djazayeri> rafa: should we unvoid that name, or should we create a new one? |
| 17:45:46 | <rafa> djazayeri: I think it should unvoid the name only if it has the same uuid |
| 17:45:53 | <rafa> djazayeri: otherwise create a new one |
| 17:46:00 | <djazayeri> rafa: makes sense |
| 17:46:23 | <djazayeri> rafa: so maybe I should just not use comparisonEngine.equal in that spot? |
| 17:47:15 | <rafa> djazayeri: well you mean not to use it for concept names? |
| 17:48:24 | *** Hasintha_i has joined #openmrs |
| 17:49:53 | <rafa> djazayeri: actually if it is only in the MIRROR mode then it's probably correct not to use comparisonEngine |
| 17:50:04 | <djazayeri> rafa: well, in general the logic about how ObjectHandler.merge should overwrite collections in MIRROR mode |
| 17:50:48 | <rafa> djazayeri: right, I agree |
| 17:51:09 | <djazayeri> rafa: a question about the incomingToExisting map |
| 17:51:10 | *** AlexB_ has joined #openmrs |
| 17:51:18 | <djazayeri> rafa: will this include mappings for new child dependencies? |
| 17:51:26 | <djazayeri> rafa: that are *about to be saved*? |
| 17:51:36 | <djazayeri> rafa: (actually, this question is probably irrelevant) |
| 17:52:44 | <rafa> djazayeri: it's being populated only at the beginning based on all incoming items found in a package |
| 17:53:10 | <rafa> djazayeri: (not sure if it answers your question) |
| 17:53:19 | <AlexB_> mseaton: Hey Mike, I'm looking to generate a report that I can export to excel and consists of patient demographic data, as well as observations from an encounter within a particular date. After watching the screencast and reading the documentation, I'm not sure which type of report is best for this. Can you point me in the right direction? |
| 17:54:24 | <djazayeri> rafa: basically the logic should be: |
| 17:54:24 | <djazayeri> foreach (element in existingCollection) |
| 17:54:24 | <djazayeri> look at each element in incomingCollection (possibly mapping to existing) |
| 17:54:24 | <djazayeri> if it has the same uuid, use this |
| 17:54:25 | <djazayeri> if we didn't find it, remove/void the existing element |
| 17:54:25 | <djazayeri> at the end, add any remaining incomings (possibly mapping to existing) |
| 17:55:04 | <rafa> djazayeri: right |
| 17:56:04 | <djazayeri> rafa: so, currently the code does: |
| 17:56:04 | <djazayeri> if (incomingElement.equals(existingElement) || comparisonEngine.equal(incomingElement, existingElement, incomingToExisting)) { |
| 17:56:14 | <djazayeri> rafa: I should get rid of the comparisonEngine.equal clause |
| 17:56:35 | <djazayeri> rafa: and should I be more explicit about incomingElement.getUuid().equals(exisitngElement.getUuid()) ? |
| 17:56:40 | <rafa> I don't think we can rely on equals to check uuid |
| 17:56:46 | <rafa> djazayeri: correct |
| 17:56:52 | <djazayeri> rafa: right, in 1.9 it works that way, but before it didn't. |
| 17:56:52 | <rafa> djazayeri: we need to be explicit here |
| 17:58:50 | <djazayeri> rafa: okay, I'll try making that changes, and let you know what happens. |
| 17:59:12 | <rafa> djazayeri: cool |
| 18:00:34 | *** bwolfe has quit IRC |
| 18:00:44 | *** bwolfe has joined #openmrs |
| 18:01:06 | *** ChanServ sets mode: +o bwolfe |
| 18:02:40 | *** dkayiwa_ has joined #openmrs |
| 18:04:13 | *** sunbiz has left #openmrs |
| 18:04:34 | *** rafa has quit IRC |
| 18:04:47 | *** dkayiwa has quit IRC |
| 18:04:47 | *** dkayiwa_ is now known as dkayiwa |
| 18:05:20 | *** sunbiz has joined #openmrs |
| 18:06:17 | <sunbiz> bwolfe: thanks!! am I going to be connected by default?? |
| 18:06:56 | *** lh has joined #openmrs |
| 18:07:00 | *** lh has joined #openmrs |
| 18:07:17 | *** ChanServ sets mode: +v sunbiz |
| 18:08:24 | <djazayeri> sunbiz: yeah, irccloud leaves you connected by default, but it does show you as away if you're not actively logged in |
| 18:08:51 | <sunbiz> djazayeri: ok, thanks... looks interesting |
| 18:11:04 | <bwolfe> I'm in a talk about Disciplined Agile Delivery right now. its a super set agile method of scrum/kanban/lean agile |
| 18:11:19 | <bwolfe> they use a BA as the product owner for each iteration (scrum) |
| 18:12:32 | <dkayiwa> bwolfe: did you also talk with the Undisciplined Agile Delivery? :) |
| 18:13:02 | <bwolfe> thats what everyone else does ;-) |
| 18:13:05 | <sunbiz> bwolfe: nice... would b good to have a release at the end of a scrum |
| 18:13:29 | <djazayeri> sunbiz: bwolfe: /s/scrum/sprint |
| 18:13:30 | <sunbiz> in whatever state the module is in... |
| 18:13:44 | <sunbiz> djazayeri: sorry, meant sprint |
| 18:13:47 | <dkayiwa> oh |
| 18:13:48 | <djazayeri> sunbiz: even better, a release after every commit. :-) CD! |
| 18:13:50 | <bwolfe> 15 minute standup --> release! |
| 18:14:16 | <sunbiz> djazayeri: its not practical although theoretically true |
| 18:20:28 | *** AlexB_ has quit IRC |
| 18:20:52 | <sunbiz> djazayeri: you might find this useful - http://ieeexplore.ieee.org/stamp/stamp.jsp?tp=&arnumber=6328180 ... Useful suggestions/next steps |
| 18:30:34 | *** andreapat has joined #openmrs |
| 18:35:36 | *** rajith has quit IRC |
| 18:36:22 | <downey> !beerme bwolfe |
| 18:36:22 | * OpenMRSBot slides bwolfe a pint |
| 18:38:31 | <mseaton> bwolfe: would love your input into some of the sync questions we have been encountering of late, if you have any recollection into the specifics. |
| 18:39:45 | <bwolfe> mseaton: I read the parent server thread, and I think Bailey is right, the status is used for the upstream server. |
| 18:40:11 | <k-joseph> dkayiwa: hi |
| 18:40:18 | <bwolfe> mseaton: might need to not reuse the status like that. perhaps a status for that change to the downstream and that change to the upstream? |
| 18:40:36 | <mseaton> bwolfe: i saw that too. but if a server has no parent, then why not set it to some other final status, rather than leaving it as new? |
| 18:40:41 | <dkayiwa> k-joseph: hi |
| 18:40:53 | <bwolfe> mseaton: if no parent, then yes, seems like you can do that. |
| 18:41:44 | <mseaton> bwolfe: is there any reason why we don't use the sync_server_record table for recording child->parent transmissions? |
| 18:42:05 | <mseaton> bwolfe: as far as i can tell, only parent->child transmission results are stored here, but child->parent are not |
| 18:42:24 | <k-joseph> dkayiwa: please tell me after you have gone through that, whether i can commit, reprove me, when you get time, thnks |
| 18:42:42 | <dkayiwa> k-joseph: do you have a unit test for that commit? |
| 18:43:18 | <mseaton> bwolfe: so there is really nothing that is capable of storing any error_message details on the child for a failed sync up to the parent |
| 18:43:20 | <bwolfe> mseaton: I'd have to go back and read the docs and/or code to remember why. I wasn't on the panel that designed that part of it (remember I came on a few years into the process) |
| 18:43:33 | <bwolfe> mseaton: that is correct, I remember that much. |
| 18:43:34 | <mseaton> bwolfe: i know, but you're the closest thing i have right now :) |
| 18:43:44 | <bwolfe> ha |
| 18:43:45 | <k-joseph> dkayiwa: i dont, actually i think it requiered no unit test, |
| 18:44:08 | <bwolfe> or christian on wednesday if he comes out. ;-) ...although his memories would be older than mine |
| 18:44:46 | <k-joseph> !ticket TRUNK-3258 |
| 18:44:47 | <OpenMRSBot> k-joseph: [#TRUNK-3258] Add voidNote() method to NoteDAO - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3258 |
| 18:45:04 | <dkayiwa> k-joseph: is it adding any functionality? |
| 18:45:19 | <k-joseph> dkayiwa: yes, it does |
| 18:45:19 | <mseaton> bwolfe: i'm sure everyone wants to spend the whole night talking about sync |
| 18:45:39 | <dkayiwa> k-joseph: and then you say that it requires no unit test? |
| 18:47:45 | <bwolfe> mseaton: justin is back in town? |
| 18:47:56 | <dkayiwa> k-joseph: looks like you may need to do some reading on the purpose of unit tests :) |
| 18:47:57 | <mseaton> yep |
| 18:48:40 | <bwolfe> permanent, or just temporary until he moves onto the next random locale? |
| 18:49:44 | <k-joseph> dkayiwa: i know what you that means, it should be done for almost all code written to test its functionality, any way am writing that one, |
| 18:50:23 | <dkayiwa> k-joseph: may be i did not give you a chance to try convince me why you thought it does not require a unit test. can you try? :) |
| 18:51:51 | <k-joseph> dkayiwa: that is a vague reason any way, i thought it so small to be tested, since the previous code in the same class was not |
| 18:51:54 | <k-joseph> :) |
| 18:57:35 | *** andreapat has quit IRC |
| 19:01:23 | *** k-joseph has quit IRC |
| 19:26:30 | *** harsz89 has quit IRC |
| 19:44:30 | *** h3llborn has joined #openmrs |
| 20:08:13 | *** bwolfe has quit IRC |
| 21:28:33 | *** Alxander has joined #openmrs |
| 21:48:26 | *** upul has joined #openmrs |
| 21:48:26 | *** ChanServ sets mode: +v upul |
| 21:50:26 | *** davidpardz has joined #openmrs |
| 22:24:52 | *** h3llborn has quit IRC |
| 22:27:19 | <wyclif> hi mseaton |
| 22:32:01 | <wyclif> hi mseaton |
| 22:34:14 | *** Alvaro has joined #openmrs |
| 22:35:26 | <Alvaro> Hello!!!! |
| 22:35:46 | <Alvaro> Could you tell me the steps to contact you |
| 22:35:48 | <Alvaro> ??? |
| 22:35:55 | *** h3llborn has joined #openmrs |
| 22:37:32 | *** Alxander has quit IRC |
| 22:39:36 | *** Alvaro has quit IRC |
| 22:45:59 | *** h3llborn has quit IRC |
| 22:49:04 | <mseaton> hi wyclif |
| 22:49:46 | <wyclif> mseaton, in sync when your remove all collection elements, do the other servers get updated for you? |
| 22:50:01 | <wyclif> mseaton, i.e clear the collection |
| 22:50:14 | <wyclif> mseaton, seems like a bug a ran into |
| 22:51:49 | <mseaton> wyclif: not sure, i would assume so |
| 22:52:36 | <mseaton> wyclif: what does it do in the interceptor? |
| 23:03:19 | <wyclif> mseaton, looks to me like it doesnt |
| 23:04:04 | <mseaton> wyclif: what steps could i do to reproduce what you see? |
| 23:05:01 | <mseaton> wyclif: can you create a unit test that shows the issue? |
| 23:05:06 | <wyclif> mseaton, i wrote a unit test where i removed all members and it failed |
| 23:05:24 | <mseaton> wyclif: for what type of object? |
| 23:05:27 | <wyclif> mseaton, not may be it would pass in case i edited anotheer field |
| 23:05:38 | <wyclif> mseaton, still cohort |
| 23:06:17 | <mseaton> wyclif: well, don't we know that non openmrs-object set member changes are not captured? isn't that the ticket? |
| 23:06:21 | <wyclif> mseaton, i will test with removing all tags from a location |
| 23:07:06 | <wyclif> mseaton, i fixed that but noticed didnt work when i removed all instead meaning might be apply to openrms objects |
| 23:07:29 | <wyclif> mseaton, but i have fixed it for non openmrs object, i will test with openmrs objects just to be sure |
| 23:08:03 | <mseaton> wyclif: sounds good. |
| 23:22:05 | *** dkayiwa has quit IRC |