IRC Chat : 2013-03-19 - OpenMRS

00:14:30 *** Echidna has quit IRC
00:14:41 *** Echidna has joined #openmrs
00:14:41 *** ChanServ sets mode: +v Echidna
00:16:48 *** andreapat has quit IRC
00:49:28 *** dmulindwa has quit IRC
01:06:44 *** lh has quit IRC
01:15:24 *** h3llborn has joined #openmrs
01:16:59 *** docpaul has joined #openmrs
01:16:59 *** ChanServ sets mode: +o docpaul
01:18:42 <docpaul> anyone around?
01:19:18 <mseaton> what's up?
01:20:33 *** volodymyr has quit IRC
01:20:51 *** volodymyr has joined #openmrs
01:20:58 <docpaul> irccloud is fascinating
01:21:12 <docpaul> the fact that it keeps track of your entire history while logged in is wild
01:29:32 <mseaton> yep, massive improvement.
01:51:17 <jkeiper> i just wish other IM services (like Jabber) were available too
02:17:35 <docpaul> hey jer, just saw your email
02:17:46 <docpaul> if wife wasn't sleeping on my shoulder, i would call you
02:18:12 <docpaul> but i can talk to you tomorrow after work if you want? the best circumstance would be if you, me, shaun, and burke all talk together about it
02:18:16 <docpaul> as it involves them as well
02:28:36 *** h3llborn has quit IRC
03:11:34 <jkeiper> docpaul: that works for me, thanks :-)
03:12:20 <docpaul> jer: did you hear from shaun or holly?
03:16:01 <burke> docpaul: go to bed!
03:16:17 *** RussellG has quit IRC
03:27:01 *** r0bby has joined #openmrs
03:27:01 *** ChanServ sets mode: +v r0bby
03:28:41 *** r0bby is now known as robbyoconnor
04:00:54 <jkeiper> haha
04:00:58 <jkeiper> docpaul: not yet :-)
04:02:14 *** ruwanego has joined #openmrs
04:04:08 *** ruwanego has quit IRC
04:04:33 *** ruwanego has joined #openmrs
04:10:36 *** DraggonZ has joined #openmrs
04:15:01 *** kavuri has joined #openmrs
04:16:07 *** ruwanego has quit IRC
04:18:29 *** ruwanego has joined #openmrs
04:22:09 *** ruwanego has quit IRC
04:24:29 *** ruwanego has joined #openmrs
04:25:08 *** shortend has joined #openmrs
04:29:06 *** Anuruddha has quit IRC
04:34:24 *** ruwanego has quit IRC
04:39:12 *** sara has joined #openmrs
04:40:02 *** ruwanego has joined #openmrs
04:40:15 *** kishoreyekkanti has joined #openmrs
04:42:07 <sara> hi how are data pages different from metadata pages in openmrs?
04:48:53 *** ruwanego has quit IRC
04:49:50 *** ruwanego has joined #openmrs
04:52:07 *** ruwanego has quit IRC
04:52:55 *** ruwanego has joined #openmrs
04:55:09 *** ruwanego has quit IRC
04:56:02 *** ruwanego has joined #openmrs
05:02:03 *** ruwanego has left #openmrs
05:05:17 *** harshadura has quit IRC
05:05:33 *** DraggonZ has quit IRC
05:06:19 *** DraggonZ has joined #openmrs
05:08:22 *** sara has quit IRC
05:21:52 *** Hasintha_i has joined #openmrs
05:28:49 *** maninc has quit IRC
05:29:03 *** dmulindwa has joined #openmrs
05:36:20 *** shortend has quit IRC
05:55:16 *** khayamuddin31 has joined #openmrs
05:59:37 *** khayamuddin31 has quit IRC
06:16:21 *** dmulindwa has quit IRC
06:28:52 *** shortend has joined #openmrs
06:43:47 *** dmulindwa has joined #openmrs
06:44:15 *** volodymyr has quit IRC
06:44:34 *** volodymyr has joined #openmrs
06:49:36 *** dmulindwa_ has joined #openmrs
06:55:21 *** dmulindwa has quit IRC
06:55:23 *** tuwei has joined #openmrs
07:00:59 *** ruwanego has joined #openmrs
07:13:28 *** shortend has quit IRC
07:18:22 *** tuwei has quit IRC
07:20:01 *** krstn has joined #openmrs
07:20:25 <krstn> :)
07:29:38 *** shortend has joined #openmrs
07:31:42 *** krstn has quit IRC
07:39:39 *** DraggonZ has quit IRC
07:41:09 *** ibewes has joined #openmrs
07:50:29 *** Hasintha_i has quit IRC
07:50:40 *** dkayiwa has joined #openmrs
08:04:22 *** ThreeToes has joined #openmrs
08:16:27 *** tbharath has joined #openmrs
08:20:03 <tbharath> I set JAVA_HOME and M2_HOME variables but when I ran mvn I got this error
08:20:20 <tbharath> Error occurred during initialization of VM Could not reserve enough space for object heap Could not create the Java virtual machine.
08:21:12 <tbharath> I set my MAVEN_OPTS =-Xmx2048m -XX:MaxPermSize=1024m
08:22:00 *** Hasintha_i has joined #openmrs
08:22:04 <tbharath> can anyone help me out?
08:23:11 <ibewes> tbharath: what mvn command are you trying to run?
08:23:32 <tbharath> ibewes: I just typed "mvn"
08:24:13 *** khayamuddin31 has joined #openmrs
08:24:18 <ibewes> tbharath: ok, well what are you trying to do?
08:24:25 <tbharath> ibewes: I just followed instructions from http://connect.iu.edu/p92tlhh3513/
08:25:13 <tbharath> ibewes: trying to run openmrs
08:25:16 <khayamuddin31> i want to add form2program module in the openmrs project into eclipse
08:26:56 <ibewes> tbharath: ok, well I'm not sure exactly how you want to run OpenMRS... but if you're trying to run it from the code for testing purposes you can go to the webapp dir and then execute: mvn jetty:run
08:27:13 <ibewes> khayamuddin31: have you already downloaded the code?
08:28:16 <khayamuddin31> yes i have the code
08:28:57 <ibewes> khayamuddin31: I think you just open the project from Eclipse and point it to the pom.xml file
08:29:51 <tbharath> ibewes: I haven't downloaded the code yet
08:30:02 <tbharath> and I am just setting the environment
08:30:13 <tbharath> ibewes: ok I got it
08:30:29 <tbharath> ibewes: I changed the MAVEN_OPTS=-Xms256m -Xmx1024m
08:30:46 <tbharath> ibewes: now it works
08:31:19 <ibewes> tbharath: excellent!
08:32:37 <khayamuddin31> can you elaboroate
08:33:51 *** shangxiao has joined #openmrs
08:34:19 <shangxiao> hey guys
08:34:33 <shangxiao> !powerup dkayiwa
08:34:33 * OpenMRSBot slides dkayiwa a Jack and Coke
08:35:21 <shangxiao> huahaha ThreeToes
08:36:42 *** dmulindwa_ has quit IRC
08:37:07 *** ruwanego has quit IRC
08:37:39 *** kavuri has quit IRC
08:39:38 *** ruwanego has joined #openmrs
08:43:23 *** tbharath has quit IRC
08:47:38 <ThreeToes> shangxiao, hmm?
08:50:08 *** ruwanego has quit IRC
08:50:32 <dkayiwa> shangxiao: :)
08:50:43 <dkayiwa> shangxiao: coke is not good for my health :D
08:51:05 *** ruwanego has joined #openmrs
08:51:10 <ibewes> dkayiwa: Jack, on the hand, is just dandy
08:51:30 <ThreeToes> ibewes, Jack and tobasco sauce
08:51:44 <ibewes> khayamuddin31: Are you following this guide? https://wiki.openmrs.org/display/docs/Step+by+Step+Installation+for+Developers
08:51:45 <OpenMRSBot> <http://ln-s.net/8_PW> (at wiki.openmrs.org)
08:52:07 <ibewes> ThreeToes: <anything> and tobasco :)
08:54:07 <ThreeToes> Is it possible to save queries on Jira?
08:54:29 <ThreeToes> Ah, never mind
08:54:31 <ThreeToes> Found the button
08:56:54 *** tuwei has joined #openmrs
08:58:03 *** kavuri has joined #openmrs
09:01:59 *** shangxiao has quit IRC
09:03:05 <tuwei> hey dan their was changes that you did to xform 4.1.0.2 for ampath
09:03:29 <tuwei> it now just works for IE9
09:03:58 <tuwei> @dkayiwa is it possible to make some magic to work on IE8
09:04:18 <dkayiwa> tuwei: what error do you get for IE8?
09:05:04 <tuwei> @dkayiwa form template cannot be found
09:06:00 <dkayiwa> tuwei: can you show me a screenshot on how the error looks like?
09:06:08 <ThreeToes> Ok, I'm looking for a simple-ish bug that's more work to help familiarise me with the codebase. What modules should I be looking at?
09:06:19 <dkayiwa> tuwei: put it here: http://snag.gy/
09:06:30 <tuwei> ok
09:08:04 *** ruwanego has quit IRC
09:09:25 <tuwei> @dkayiwa Its done
09:09:31 *** ruwanego has joined #openmrs
09:09:58 <dkayiwa> tuwei: i need the url for the screenshot :)
09:12:32 *** khayamuddin31 has quit IRC
09:20:08 *** ruwanego has quit IRC
09:20:55 *** ruwanego has joined #openmrs
09:34:21 *** ruwanego has quit IRC
09:35:17 *** ruwanego has joined #openmrs
09:36:48 *** ibewes has quit IRC
09:37:02 *** shortend has quit IRC
09:40:02 *** shortend has joined #openmrs
09:40:04 *** ibewes has joined #openmrs
09:40:04 <tuwei> @DKayiwa this is the url for the error http://snag.gy/YS3GL.jpg
09:40:53 <dkayiwa> tuwei: is this the xforms or formentry module :)
09:42:54 <tuwei> Its affecting formentry
09:43:12 <dkayiwa> tuwei: what is affecting formentry?
09:43:26 <tuwei> what happens is that after the xform was upgraded this error came up
09:44:02 <tuwei> and what we discovered was that if one uses windos 7 and IE9 this error does not comeup
09:44:41 <dkayiwa> tuwei: does it happen after you stop the xforms module?
09:45:07 <tuwei> @dkayiwa No
09:45:30 <tuwei> @dkayiwa It just started when the module was loaded
09:45:46 <dkayiwa> tuwei: can you stop the xforms module now?
09:47:11 <tuwei> @dkayiwa stopped
09:47:24 <dkayiwa> tuwei: now try access the form
09:47:52 <tuwei> same error
09:48:20 <tuwei> @dkayiwa same errorr
09:48:43 <dkayiwa> tuwei: so that means that cause is not the xforms module :)
09:50:10 <tuwei> but Xform module was the last changes done on the server before these error occured
09:50:18 <tuwei> @dkayiwa but Xform module was the last changes done on the server before these error occured
09:51:21 <dkayiwa> tuwei: that does not neccesarily mean its the cause. If the hard disk crashes when the last change was installing the xforms module, it does not mean the module is the cause of the crash :)
09:52:10 *** robbyoconnor has quit IRC
09:52:35 *** robbyoconnor has joined #openmrs
09:52:35 *** ChanServ sets mode: +v robbyoconnor
09:53:32 <dkayiwa> tuwei: did you ask jeremy about this? he is the formentry module expert :)
09:54:21 *** ThreeToes has quit IRC
10:05:36 *** ruwanego has quit IRC
10:06:33 *** ruwanego has joined #openmrs
10:17:32 *** tuwei has quit IRC
10:19:49 *** ruwanego has quit IRC
10:21:53 *** ruwanego has joined #openmrs
10:30:08 *** Hasintha_i has quit IRC
10:47:07 *** Hasintha_i has joined #openmrs
10:52:36 *** Hasintha_i has quit IRC
11:00:41 *** shangxiao has joined #openmrs
11:25:33 *** rajiths has joined #openmrs
11:35:59 *** ruwanego has quit IRC
11:37:04 *** ruwanego has joined #openmrs
12:00:31 *** Akwatuha has joined #openmrs
12:11:54 <Akwatuha> Handling complex observations:-
12:12:06 *** shangxiao has quit IRC
12:12:45 <Akwatuha> I would like to create a complex obs handler as described in ticket https://jira.ampath.or.ke/browse/AMRS-180
12:14:56 <Akwatuha> Wyclif, I would like to discuss this with you as I understand you had a discussion with Jeremy on this ticket.
12:24:02 *** GitHub101 has joined #openmrs
12:24:02 <GitHub101> [openmrs-core] ehsdev opened pull request #252: translate the ORUR01Handler which had text hard coded TRUNK-3926 (master...master) http://git.io/CCNtXQ
12:24:02 *** GitHub101 has left #openmrs
12:25:33 *** ruwanego has quit IRC
12:26:06 *** h3llborn has joined #openmrs
12:46:03 *** Akwatuha has quit IRC
12:50:51 *** harsz89 has joined #openmrs
12:58:12 *** harshadura has joined #openmrs
12:58:48 *** harshadura has quit IRC
12:59:03 *** harshadura has joined #openmrs
13:03:45 *** shangxiao has joined #openmrs
13:16:03 *** sunbiz has joined #openmrs
13:16:06 *** ChanServ sets mode: +v sunbiz
13:19:43 *** kavuri has quit IRC
13:19:44 *** GitHub50 has joined #openmrs
13:19:45 <GitHub50> [openmrs-core] dkayiwa pushed 1 new commit to master: http://git.io/28gPew
13:19:45 <GitHub50> openmrs-core/master b147433 dkayiwa: Database constraints should be turned off when executing datasets in...
13:19:45 *** GitHub50 has left #openmrs
13:29:47 *** travis-ci has joined #openmrs
13:29:47 <travis-ci> [travis-ci] [openmrs/openmrs-core] [b147433] [dkayiwa] The build was broken. - http://travis-ci.org/openmrs/openmrs-core/builds/5624849
13:29:47 *** travis-ci has left #openmrs
13:29:51 <OpenMRSBot> <http://ln-s.net/+r6l> (at travis-ci.org)
13:37:20 *** harsz89 has quit IRC
13:38:34 *** GitHub20 has joined #openmrs
13:38:34 <GitHub20> [openmrs-core] dkayiwa pushed 1 new commit to master: http://git.io/KRgbqg
13:38:34 <GitHub20> openmrs-core/master 4bb3df3 dkayiwa: Fixing unit test failures after: Database constraints should be turned...
13:38:34 *** GitHub20 has left #openmrs
13:40:00 *** h3llborn has quit IRC
13:41:31 *** harsz89 has joined #openmrs
13:46:25 *** dkayiwa_ has joined #openmrs
13:46:26 *** dkayiwa has quit IRC
13:46:27 *** dkayiwa_ is now known as dkayiwa
13:48:03 *** travis-ci has joined #openmrs
13:48:03 <travis-ci> [travis-ci] [openmrs/openmrs-core] [4bb3df3] [dkayiwa] The build is still failing. - http://travis-ci.org/openmrs/openmrs-core/builds/5625257
13:48:03 *** travis-ci has left #openmrs
13:48:06 <OpenMRSBot> <http://ln-s.net/+r71> (at travis-ci.org)
13:51:13 *** GitHub21 has joined #openmrs
13:51:13 <GitHub21> [openmrs-core] dkayiwa pushed 1 new commit to master: http://git.io/18osAQ
13:51:13 <GitHub21> openmrs-core/master c758e5e dkayiwa: Reverting my changes to fix failing unit tests - - TRUNK-3928
13:51:13 *** GitHub21 has left #openmrs
13:51:31 <docpaul> I'm not familiar with Travis. Can anyone explain it's purpose?
13:52:16 *** shortend has quit IRC
13:53:15 <dkayiwa> docpaul: here is the thread: https://groups.google.com/a/openmrs.org/forum/?fromgroups=#!msg/dev/9aCO11qmJF8/JSC7xvNEiFMJ
13:53:20 <OpenMRSBot> <http://ln-s.net/+r76> (at groups.google.com)
13:53:56 <ibewes> docpaul: This is a good article on CI: http://www.martinfowler.com/articles/continuousIntegration.html
13:53:58 <OpenMRSBot> <http://ln-s.net/+r78> (at www.martinfowler.com)
13:54:38 <docpaul> well aware of CI (as we have our own CI infrastructure in OpenMRS)... just wanted to know what the hosted Travis service added for us
13:54:44 <docpaul> thanks daniel. :)
13:55:39 <docpaul> ah, very nice.
13:55:50 <docpaul> for some reason, i missed that thread...
13:56:07 <docpaul> thx ibewes for the pointer, and welcome to the community! :)
13:56:10 <dkayiwa> docpaul: you have billions of mails to read :)
13:56:46 <docpaul> daniel: unfortunately. :( tell me, have you heard about people wanting to implement Vista within hospitals in Uganda
13:56:47 <docpaul> ?
13:56:55 <docpaul> this is the current rumor going about
13:57:04 <dkayiwa> docpaul: i have not heard of any one
13:57:06 <docpaul> poor uganda needs strong ehealth leadership
13:57:15 <ibewes> docpaul: thanks! I've been here a while (I am Wes Brown, I met you in Nairobi)... just took me a bit to figure out who you are :)
13:57:19 <docpaul> at some point, i want to come visit you all
13:57:20 <dkayiwa> docpaul: oh too too much in need of that!!!
13:57:24 <docpaul> oh hi wes!
13:57:38 <dkayiwa> too much politics here :)
13:57:55 <docpaul> daniel: it makes me sad... people need efficient health delivery, not politics
13:58:10 <dkayiwa> docpaul: very very true!!!
13:58:19 <docpaul> wes, how are things? really proud to see your work with OpenHMIS... we are flattered we could serve as a basis of support for your work
13:58:39 <dkayiwa> docpaul: making unit tests fail :D
13:58:46 <docpaul> haha
13:58:53 <mseaton> dkayiwa: is there an easy way for me to increase the amount of log history contained in the standalone console?
13:58:59 <ibewes> docpaul: we're doing well... very busy but in a good way. Thanks for the kind words, we're flattered to be a small part of the OpenMRS community
13:59:22 <docpaul> wes, i would pay very close attention to the work of mirebalais hospital and jss hospital
13:59:39 <dkayiwa> mseaton: we hard coded that unfortunately. are you able to look at the log file itself?
13:59:43 <docpaul> both have significant development input/involvement from thoughtworks
13:59:58 <mseaton> dkayiwa: yes, that's no problem. just wondering....and hoping :)
14:00:00 <docpaul> which is the home of the person who created the link you sent me about CI: martin fowler
14:00:05 <dkayiwa> docpaul: did you mean OpenHMIS or OpenMRS? :)
14:00:21 <docpaul> in fact, martin was at a meeting in boston in support of the mirebalais implementation
14:00:24 <docpaul> he's a good guy
14:00:35 <dkayiwa> mseaton: we can have a ticket to make that configurable. it is like a 5mins coding time :)
14:00:44 <docpaul> daniel: openhmis should pay close attention to the work of mirebalais and jss
14:00:53 <mseaton> dkayiwa: cool, i'll create a ticket
14:01:14 <docpaul> i have to say, irc cloud is killer
14:01:15 <ibewes> docpaul: that's awesome... I've been following Martin since I read patterns of enterprise Arch at the start of my programming career... thoughtworks seems like an awesome place to work
14:01:16 <dkayiwa> docpaul: oh sure!!!
14:01:33 <docpaul> wes: they are very big supporters of OpenMRS
14:01:58 *** travis-ci has joined #openmrs
14:01:58 <travis-ci> [travis-ci] [openmrs/openmrs-core] [c758e5e] [dkayiwa] The build was fixed. - http://travis-ci.org/openmrs/openmrs-core/builds/5625536
14:01:58 *** travis-ci has left #openmrs
14:02:00 *** andrea__ has joined #openmrs
14:02:01 <OpenMRSBot> <http://ln-s.net/+r7G> (at travis-ci.org)
14:02:02 <docpaul> in fact, we have quite close relationships with all of their leadership
14:02:22 <docpaul> so travis comes in and out based upon need eh?
14:02:27 <docpaul> very nicely done
14:02:28 <ibewes> docpaul: sweet, good people to have in your corner
14:02:39 <docpaul> wes: my corner = your corner. :)
14:03:19 <docpaul> ibewes: the work of Mirebalais / JSS will serve as the basis for the new reference application
14:03:30 <docpaul> which i'm certain you'll want for OpenHMIS
14:03:33 <mseaton> dkayiwa: https://tickets.openmrs.org/browse/STAND-68
14:03:43 <ibewes> docpaul: indeed, how much of that work/design is public?
14:03:50 <dkayiwa> mseaton: that was fast!!! :D
14:03:57 <docpaul> within 1-2 weeks, it should all be public
14:04:03 <mseaton> dkayiwa: not suggesting you do this, just as an fyi
14:04:15 <dkayiwa> mseaton: oh yes :)
14:04:19 <docpaul> at least that's my hope... mseaton should be poked on this
14:04:20 <docpaul> hehe
14:04:27 <ibewes> docpaul: great, I'll check it out once it up
14:04:27 <docpaul> mike is involved with mirebalais
14:04:33 <ibewes> mseaton: <poke>
14:04:40 <mseaton> ibewes: ow!
14:04:46 <ibewes> mseaton: :)
14:06:05 <mseaton> ibewes: docpaul: there is likely little on the wiki, but a lot in github. so, the code is all available and for public consumption (and mostly built on existing modules in the ecosystem), but we need to expose (write) more documentation
14:06:42 <ibewes> mseaton: openmrs-module-mirebalais?
14:07:04 <docpaul> mseaton: can you point him in the right direction? you realize ibewes has created the OpenHMIS project which is trying to accomplish the same goal as darius?
14:08:12 <mseaton> docpaul: yes, i'm aware. better to liase with djazayeri when he pops up.
14:08:58 <mseaton> ibewes: yes - that one is in the pih organization in github (as are a few others)
14:09:13 <mseaton> cpower: are we scrumming?
14:09:20 <ibewes> mseaton: thanks, I'll check that out
14:09:50 <docpaul> cpower will likely be here in a second
14:09:57 <docpaul> he's skype chatting me
14:10:22 <cpower> hello!
14:10:27 <cpower> sorry got side tracked
14:10:29 <docpaul> boom, magic
14:10:30 <cpower> ready to scrum
14:10:41 <cpower> !scrumon cpower
14:10:41 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
14:11:28 <cpower> Order: djazayeri , mseaton , andrea__ , dkayiwa , wyclif_ , and anyone else who would like to provide an update
14:11:39 *** ibewes has quit IRC
14:11:54 <cpower> djazayeri: you there?
14:12:25 <cpower> NEXT!
14:12:55 <mseaton> * was mostly off yesterday
14:12:55 <mseaton> * did some code reviewing tickets
14:12:55 <mseaton> * did some answering questions on irc
14:12:55 <mseaton> * today will work on a ticket.
14:12:58 <mseaton> no blockers
14:13:45 <cpower> andrea__: you are up
14:13:57 <andrea__> Monday
14:13:57 <andrea__> Merck stuff
14:13:57 <andrea__> TRUNK-3289
14:13:57 <andrea__> Ran with -DskipTests - tried to debug in UI
14:13:57 <andrea__> but no orders - tried to add orders
14:13:58 <andrea__> Chatted with Wyclif re one failing test
14:14:00 <andrea__> Rewrote test - still failing
14:14:02 <andrea__> Tuesday
14:14:04 <andrea__> TRUNK-3289
14:14:06 <andrea__> Fix failing test
14:14:08 <andrea__> Pick new ticket
14:14:10 <andrea__>
14:14:12 <andrea__> Blocker stilll one failing test - think I found problem
14:14:14 <andrea__> Will ping someone if not
14:14:45 <dkayiwa> Did some more research on: If multiple save user operations are performed in the same transaction, only changes in the first save are synchronized. - SYNC-306 (Only have a very hacky solution for now :)
14:14:46 <dkayiwa> Committed: Database constraints should be turned off when executing datasets in unit tests - TRUNK-3928
14:14:46 <dkayiwa> Setup SyncCreateTest-openmrs-1.10.xml for failing test on 1.10
14:14:46 <dkayiwa> Now fixing: failing unit test against 1.10.0-SNAPSHOT: shouldNotSendPersonAttributeType(org.openmrs.module.sync.SyncServerClassTest) - SYNC-259
14:14:46 <dkayiwa> No Blockers
14:14:59 <wyclif_> Monday:
14:14:59 <wyclif_> Revisted and tested SYNC-287 to address Review TODOs - Sync module should prevent OpenMRS Core from persisting changes if no sync record is created
14:14:59 <wyclif_> Investigated SYNC-245
14:14:59 <wyclif_> Helped Andrea debug some blockers
14:14:59 <wyclif_> Tuesday:
14:15:00 <wyclif_> Complete SYNC-245 - From History of Changes page
14:15:02 <wyclif_> SYNC-247 - Configure sync poms to allow testing against multiple versions of Openmrs
14:15:06 <wyclif_> Code review of tickets in community dev smimlane
14:15:08 <wyclif_> probably pick another sprint ticket
14:15:10 <wyclif_>
14:15:12 <wyclif_> Blockers: None
14:16:27 <cpower> No blockers, and no discussion points beyond helping Andrea if requested
14:16:39 <cpower> !scrumoff
14:16:39 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
14:16:51 <shangxiao> !powerup cpower
14:16:51 * OpenMRSBot slides cpower a Jack and Coke
14:17:17 <sunbiz> cpower: I had some updates
14:17:22 <cpower> shangxiao: found my secret bar did you..
14:17:23 <sunbiz> :( scrum end
14:17:33 <dkayiwa> shangxiao: Coke is not good for your health :)
14:17:46 <cpower> sunbiz: go for it sunbiz we always like hearing updates
14:17:48 <sunbiz> * SYNC-274
14:17:48 <sunbiz> * SYNC-279 and followup
14:17:48 <sunbiz> * Playing with the vagrant-OpenMRS
14:17:48 <sunbiz> * Installing and trying Zamboni for app store (mayb OpenMRS module home someday)
14:17:48 <sunbiz> * No blockers
14:17:48 <sunbiz> * (mayb finding time for OpenMRS coding)! :D
14:18:13 <shangxiao> :D
14:18:16 <cpower> sunbiz: +1
14:18:21 <docpaul> sunbiz!
14:18:29 <docpaul> how are you?
14:18:40 <sunbiz> hey docpaul, good to see u here... Im fine
14:18:42 <docpaul> i notice you mention zamboni?
14:18:43 <sunbiz> how are u?
14:18:56 <sunbiz> yes... the mozilla addons and marketplace home
14:19:14 <sunbiz> docpaul: its nice... CMS and comment, voting features
14:19:17 <docpaul> there was an attempt to customize it... i know zamboni well, as i spoke to the lead authors when i went to mozilla last year
14:19:30 <docpaul> let me see if i can send you the thread about this
14:19:33 <sunbiz> docpaul: oh... cool
14:20:41 <sunbiz> docpaul: no1 seemed to have views on the MPL 2.0 move??
14:21:04 <docpaul> there were quite a few affirmations from what i saw?
14:21:09 <docpaul> no real dissent
14:21:14 <sunbiz> nor did anyone answer my question of why not APL2 or MIT or BSD...
14:21:19 <docpaul> it's a positive move from all directions
14:21:22 <sunbiz> like more permissive license
14:22:00 <sunbiz> docpaul: yes... it is definitely... in terms of compatibility... my question was beyond compatibility, shouldn't this be a good opportunity to be more permissive??
14:22:02 <docpaul> i'm not sure we're ready to completely rethink our license at this point... i think the goal was to get to OSI compliance... and MPL 2.0 was the fastest way there...
14:22:07 <sunbiz> or clarify that position of MPL
14:22:33 <docpaul> mpl is fairly permissive
14:23:09 <docpaul> thread forwarded saptarshi
14:23:15 <docpaul> about zamboni
14:23:26 <sunbiz> docpaul: not really... modifications have to remain open-source. Not as permissive as APL2.0 or MIT or BSD
14:23:30 <sunbiz> docpaul: thanks!!
14:23:59 <docpaul> there's a github repo out there with a modified zamboni done by a guy named allen machary
14:23:59 <sunbiz> docpaul: will be good to hear about JSS as well... heard very little from Sundeep... but how is Thoughtworks doing??
14:24:29 <docpaul> very well... i think sundeep still has concerns about who's involved... let me write you privately on this
14:26:29 <sunbiz> docpaul: will be good to see them - https://wiki.openmrs.org/display/projects/Implementation+Projects
14:29:15 <mseaton> dkayiwa: ping. looking at your pull request here: https://github.com/openmrs/openmrs-core/pull/251/files
14:29:20 <OpenMRSBot> <http://ln-s.net/+r7s> (at github.com)
14:29:22 *** h3llborn has joined #openmrs
14:29:39 <jkeiper> adding a patient identifier with the same identifier (string) as a previous one that was voided fails ... is this expected behavior?
14:29:49 <mseaton> dkayiwa: for SYNC-284
14:29:54 <dkayiwa> mseaton: aha
14:30:10 <dkayiwa> !ticket SYNC-284
14:30:11 <mseaton> jkeiper: who are you asking :)
14:30:11 <OpenMRSBot> dkayiwa: [#SYNC-284] failing unit test against 1.9.1: shouldFindUuidsOnConcepts(org.openmrs.module.sync.SyncORUR01HandlerTest) - OpenMRS JIRA - https://tickets.openmrs.org/browse/SYNC-284
14:30:20 <jkeiper> mseaton: anyone who cares ;-)
14:30:44 <mseaton> dkayiwa: it seems to me that we want to make this fix in core, agree?
14:30:52 <dkayiwa> mseaton: yes
14:31:02 <mseaton> dkayiwa: didn't this come up recently in another ticket?
14:31:15 <mseaton> dkayiwa: i think jkeiper was involved. jkeiper ?
14:31:26 <dkayiwa> mseaton: it did for another openmrs object
14:31:39 <dkayiwa> mseaton: jkeiper was concerning about performance implications
14:31:52 <mseaton> dkayiwa: yes. not sure why this was coded that way back in the day, but it's clearly not right and something that should be fixed throughout.
14:31:54 <dkayiwa> mseaton: so jkeiper created another ticket to do some catching
14:32:05 <jkeiper> hrm?
14:32:18 <dkayiwa> mseaton: i was told it was done that way only for peformance reasons :)
14:32:40 <mseaton> dkayiwa: jkeiper is performance really a concern in hl7 handling?
14:32:54 <jkeiper> dkayiwa: talking about ORUR01Handler short-cutting concepts by using just IDs?
14:33:02 <dkayiwa> jkeiper: exactly
14:33:33 <mseaton> jkeiper: that might have worked via a magic hibernate trick back in the day, but seems like very bad practice.
14:33:46 <mseaton> jkeiper: and something we just want to do away with generally in that method. no?
14:33:53 <jkeiper> mseaton: ask burke ... he's the one that initially wrote the shortcuts. I think we might be in the clear with hibernate caches now, but it's a good idea to do some stress testing since HL7 consumption is one of our primary means of data input
14:34:16 <dkayiwa> Iticket TRUNK-3896
14:34:24 <jkeiper> dkayiwa: s/l/!
14:34:31 <mseaton> jkeiper: but isn't it asynchronous?
14:34:49 <dkayiwa> !ticket TRUNK-3896
14:34:50 <OpenMRSBot> dkayiwa: [#TRUNK-3896] ORUR01Handler should load an encounters location from the database - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3896
14:34:54 <jkeiper> mseaton: yes, just drags on and on if concepts are loaded from the context over and over again ... if they're cached, it's faster
14:34:57 <jkeiper> (obviously)
14:35:11 <jkeiper> mseaton: we get loads of forms at a time from remote sites
14:35:18 <mseaton> jkeiper: i have no issue with caching, but this is what ehcache and other hibernate caches or for too, right?
14:35:19 <dkayiwa> and !ticket TRUNK-3897
14:35:19 <jkeiper> mseaton: and the server load goes up for that kind of work
14:35:24 <mseaton> jkeiper: not hacky shortcuts in code
14:35:26 <mseaton> :)
14:35:39 <jkeiper> mseaton: totally ... i think TRUNK-3897 is where it's at
14:35:54 <dkayiwa> !ticket TRUNK-3897
14:35:55 * jkeiper wouldn't have written the ticket if he thought otherwise
14:35:55 <OpenMRSBot> dkayiwa: [#TRUNK-3897] Add caching in ORUR01Handler or Context for repeatedly used domain objects - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3897
14:37:26 <mseaton> dkayiwa: for SYNC-284, is the solution is to fix core in 1.10 and backport to 1.9. perhaps then run the sync unit tests (from pom configuration) off of the 1.9-snapshot (but depend on 1.9 in config.xml)?
14:37:54 <dkayiwa> mseaton: yes
14:40:02 *** kishoreyekkanti has quit IRC
14:42:20 *** k-joseph has joined #openmrs
14:44:50 <mseaton> dkayiwa: is there a ticket for trunk to associate this with?
14:47:16 <dkayiwa> mseaton: no
15:04:39 *** khayamuddin31 has joined #openmrs
15:05:46 <khayamuddin31> hi want to remove dependency problem in form2program module
15:06:14 *** dkayiwa has quit IRC
15:09:39 *** harshadura has quit IRC
15:14:42 *** Iome_ has joined #openmrs
15:18:48 *** k-joseph has quit IRC
15:19:06 *** harshadura has joined #openmrs
15:19:42 *** kavuri has joined #openmrs
15:21:40 *** shangxiao has quit IRC
15:21:40 *** Iome has quit IRC
15:22:08 *** shangxiao has joined #openmrs
15:56:06 *** suranga has joined #openmrs
15:56:06 *** ChanServ sets mode: +v suranga
16:04:08 *** andrea__ has quit IRC
16:06:50 *** Anuruddha has joined #openmrs
16:18:41 *** h3llborn has quit IRC
16:33:01 <OpenMRSBot> Recent updates in the world of openmrs: Burke Mamlin: Preach Open Source; when necessary, mention code. <http://blog.burkeware.com/2013/03/preach-open-source-when-necessary-mention-code/> || OpenMRS Modules: Kenya EMR UI Library 1.2 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=kenyaui&ampversion=&amp1.2>
16:34:36 *** shangxiao has quit IRC
16:42:02 *** khayamuddin31 has quit IRC
17:02:36 *** mcwere has quit IRC
17:09:37 *** h3llborn has joined #openmrs
17:17:55 *** robbyoconnor has quit IRC
17:18:10 *** robbyoconnor has joined #openmrs
17:18:10 *** ChanServ sets mode: +v robbyoconnor
17:26:39 *** hybridivy has joined #openmrs
17:44:28 *** Anuruddha has quit IRC
17:47:18 *** sara has joined #openmrs
17:53:25 *** shangxiao has joined #openmrs
17:59:09 *** rajiths has quit IRC
18:22:08 *** kavuri has quit IRC
18:25:58 *** sara has quit IRC
19:18:29 *** hybridivy has quit IRC
19:21:56 *** shangxiao has quit IRC
19:29:44 *** andreap has joined #openmrs
19:33:47 *** andreap has quit IRC
19:35:29 *** andreapat has joined #openmrs
20:02:34 <andreapat> wyclif_: hi - Tried everything - can't get rid of assert error
20:05:44 *** mohammedi has joined #openmrs
20:05:51 *** k-joseph has joined #openmrs
20:06:57 <wyclif_> hi andreapat , can you hold a sec or in the meantime create some pastebin links to share your code in the test and dao method
20:08:32 <andreapat> wyclif_: sure
20:08:51 <mohammedi> i'm getting errors while importing a module into eclipse
20:09:15 *** mohammedi is now known as mohammed
20:09:45 *** mohammed is now known as Guest41531
20:11:04 *** khayamuddin31 has joined #openmrs
20:11:36 <khayamuddin31> unable to import a module into eclipse
20:17:41 *** dkayiwa has joined #openmrs
20:18:37 *** khayamuddin31 has quit IRC
20:28:17 <andreapat> wyclif: http://pastebin.com/4F16gE0v
20:28:17 <andreapat> OrderServiceTest
20:28:18 <andreapat> test purgeOrder_shouldDeleteObsThatReference()
20:28:45 <andreapat> wyclif: http://pastebin.com/nPnfa1je
20:28:45 <andreapat> HibernateOrderDAO - deleteObsThatReference(Order order)
20:29:18 <andreapat> wyclif: put notes at the top of both also
20:35:22 <wyclif_> andreapat, i will get back to you, still finshing up something
20:36:03 <andreapat> wyclif_: ok
20:38:45 <mseaton> andreapat: what are you trying to accomplish with String.valueOf(Order)?
20:40:10 <mseaton> andreapat: you get a NumberFormatException trying to take the result of that and parse it into an int. not very surprising to me, though i have no idea what String.valueOf(Order) would actually produce.
20:40:24 <mseaton> andreapat: what is the value of "s" before you try to parse it?
21:02:23 <wyclif_> andreapat, where are the links?
21:05:19 *** k-joseph has quit IRC
21:05:19 <andreapat> wyclif: http://pastebin.com/4F16gE0v
21:05:20 <andreapat> OrderServiceTest
21:05:20 <andreapat> test purgeOrder_shouldDeleteObsThatReference()
21:05:20 <andreapat> http://pastebin.com/nPnfa1je
21:05:20 <andreapat> HibernateOrderDAO - deleteObsThatReference(Order order)
21:05:20 <andreapat>
21:05:44 <andreapat> mseaton: you still here?
21:05:50 <mseaton> andreapat: yes
21:06:21 <andreapat> mseaton: sorry had to step away for a minute
21:07:09 <andreapat> mseaton: re String.valueOf(Order) - tryuing to convert Order (object) to an int - for comparison
21:07:23 <mseaton> andreapat: what kind of int? how do you expect that to work?
21:08:33 <andreapat> mseaton: int obsOrd = Integer.parseInt(s); converts a string to an int
21:08:54 <mseaton> andreapat: have you stepped through the unit test with a debugger? seen what actually is produced by String.valueOf(Order), before you try to parse it?
21:09:17 *** h3llborn has quit IRC
21:09:31 <mseaton> andreapat: i know what that method does. what i don't know is why you expect String.valueOf(Order) to produce a String that can be later parsed into an int?
21:10:11 <andreapat> mseaton: will do - Tried to debug in UI but unable to add orders
21:11:37 <andreapat> mseaton: google re convert object to int
21:12:03 <andreapat> mseaton - used to be String s = obsOrder.toString();
21:12:38 <andreapat> mseaton: how would you convert a java object to an int
21:12:41 <mseaton> andreapat: you should debug in your IDE. it is very fast and easy to debug unit tests in an IDE
21:13:15 <mseaton> andreapat: well, what does the Order.toString() method do? i'm guessing it doesn't produce something that can be converted to an int
21:13:27 <mseaton> andreapat: _why_ do you want to convert a java object to an int?
21:13:47 <mseaton> how about calling hashcode? not sure why your objective is here
21:14:25 <andreapat> mseaton: to ensure that actually
21:14:25 <andreapat> the obs and order are associated
21:15:17 <wyclif_> andreapat, some comments, try to be consistent with the way you are looking up the order, is it by uuid or id, choose one
21:16:04 <mseaton> andreapat: ok. can you explain how this accomplishes that goal?
21:16:51 <andreapat> mseaton: I can compare 2 ints fro being =
21:17:41 <wyclif_> andreapat, also try to store the uuid or id in a local variable for reuse. i dont understand why you are using valueOf, why cant you just call getOrderId, you are also mixinf up those ids i think
21:18:31 <wyclif_> andreapat, can you please clean it up and not make many un necessary calls, also are you sure that your logic in the DAO is getting executed as expected
21:18:35 <mseaton> andreapat: why don't you just compare by orderId, or uuid, or just use the order.equals(order) method?
21:19:20 <andreapat> wyclif: mseaton: hard to answer both of you
21:19:33 <mseaton> andreapat: clocking out.
21:20:28 <andreapat> wyclif, no not sure logic in the DAO is getting executed as expected - think it may be problem
21:22:18 <andreapat> wyclif - thought I need valueOf for obs order - got error when I tried just that
21:24:13 <wyclif_> andreapat, and am saying shy dont u call getOrderId
21:24:55 <wyclif_> andreapat, or as mike says just assertEquals that will use the equals method
21:26:11 <wyclif_> andreapat, probably that is what is causing problems, you are running away from the error by using valueOf
21:26:41 <andreapat> wyclif: ok will try these things
21:26:44 <wyclif_> andreapat, i think you need to find out why there is an error when you call getOrderId
21:27:16 <wyclif_> andreapat, do you have skype and can we use the any of connect rooms
21:27:46 <andreapat> wyclif_: yes I have skype - think cpower has to setup connect room
21:27:48 <wyclif_> andreapat, i see as if you are close but your code needs cleaning up to make it pass
21:28:09 <andreapat> wyclif, yes
21:29:01 <andreapat> wyclif, can we skype or meet - do you now if Chris Power is still there?
21:29:23 <wyclif_> andreapat, try cleaning it up, you should have only 2 calls to getObsByUuid OR getObs and not both
21:29:42 <wyclif_> andreapat, one before you purge and the other after tou purge
21:30:03 <andreapat> wyclif - ok thanks will try
21:30:07 <wyclif_> and one should assertNitNull and the other assertNull
21:31:01 <andreapat> wyclif_: yes I am doing that already - I understand
21:31:31 <andreapat> wyclif: also tried to look at test for HibernateConceptDAO.deleteConceptWord
21:32:05 <andreapat> wyclif: should be in ConceptServiceTest, right?
22:01:49 <wyclif_> probably, but could be ConceptDaoTest
22:03:10 *** r0bby has joined #openmrs
22:03:10 *** ChanServ sets mode: +v r0bby
22:04:09 *** robbyoconnor has quit IRC
22:18:27 *** r0bby is now known as robbyoconnor
22:41:40 *** sunbiz has quit IRC
22:47:39 *** h3llborn has joined #openmrs
22:54:55 *** harsz89 has quit IRC
22:55:56 *** suranga has quit IRC
22:57:53 *** dkayiwa has quit IRC
23:06:46 *** harsz89 has joined #openmrs
23:13:12 *** andreapat has quit IRC
23:26:45 *** sunbiz has joined #openmrs
23:26:45 *** ChanServ sets mode: +v sunbiz