03:52:29
|
*** h3llborn has joined #openmrs
|
03:57:12
|
*** harshadura has quit IRC
|
04:37:41
|
*** h3llborn has quit IRC
|
04:45:49
|
*** kavuri has joined #openmrs
|
04:47:08
|
*** sk has joined #openmrs
|
05:00:54
|
*** kishoreyekkanti has joined #openmrs
|
05:17:22
|
*** maninc has joined #openmrs
|
05:22:37
|
*** ruwanego has joined #openmrs
|
06:14:44
|
*** shortend has joined #openmrs
|
06:29:09
|
*** shortend has quit IRC
|
06:32:00
|
*** shortend has joined #openmrs
|
06:44:19
|
*** ruwanego has quit IRC
|
06:47:45
|
*** ibewes has joined #openmrs
|
06:48:28
|
*** ruwanego has joined #openmrs
|
06:51:19
|
*** ruwanego has quit IRC
|
06:54:38
|
*** ruwanego has joined #openmrs
|
07:27:34
|
*** dkayiwa has joined #openmrs
|
07:49:10
|
*** harshadura has joined #openmrs
|
08:29:18
|
*** ruwanego has quit IRC
|
08:29:42
|
*** ruwanego has joined #openmrs
|
08:45:01
|
*** kavuri has quit IRC
|
08:45:02
|
*** ruwanego has quit IRC
|
08:45:42
|
*** ruwanego has joined #openmrs
|
08:52:57
|
*** maninc has quit IRC
|
08:59:33
|
*** kavuri has joined #openmrs
|
09:14:37
|
*** maninc has joined #openmrs
|
09:29:48
|
*** portablejim has quit IRC
|
09:32:53
|
*** portablejim has joined #openmrs
|
09:46:39
|
*** kavuri has quit IRC
|
09:47:08
|
*** kavuri has joined #openmrs
|
09:49:50
|
*** ruwanego has quit IRC
|
09:50:19
|
*** ruwanego has joined #openmrs
|
09:58:57
|
*** Anuruddha has joined #openmrs
|
10:05:26
|
*** Anuruddha_ has joined #openmrs
|
10:06:52
|
*** Anuruddha has quit IRC
|
10:13:12
|
*** Anuruddha_ is now known as Anuruddha
|
10:34:11
|
*** shangxiao has joined #openmrs
|
10:46:05
|
*** ibewes has quit IRC
|
10:46:05
|
*** ruwanego has quit IRC
|
10:47:41
|
*** ruwanego has joined #openmrs
|
10:55:23
|
*** dmulindwa has joined #openmrs
|
10:59:29
|
*** ibewes has joined #openmrs
|
11:05:55
|
*** dmulindwa has quit IRC
|
11:05:56
|
*** ruwanego has quit IRC
|
11:07:06
|
*** DraggonZ has joined #openmrs
|
11:07:41
|
*** ruwanego has joined #openmrs
|
11:10:57
|
*** r0bby has joined #openmrs
|
11:10:57
|
*** ChanServ sets mode: +v r0bby
|
11:13:00
|
*** DraggonZ1 has joined #openmrs
|
11:13:05
|
*** robbyoconnor has quit IRC
|
11:15:06
|
*** DraggonZ has quit IRC
|
11:16:48
|
*** r0bby has quit IRC
|
11:26:55
|
*** maninc has quit IRC
|
11:33:18
|
*** ruwanego has quit IRC
|
11:33:42
|
*** ruwanego has joined #openmrs
|
11:39:52
|
*** Anuruddha has quit IRC
|
11:40:25
|
*** elliott_w has joined #openmrs
|
11:40:25
|
*** ChanServ sets mode: +o elliott_w
|
11:45:42
|
*** maninc has joined #openmrs
|
11:51:55
|
*** kavuri has quit IRC
|
11:58:06
|
*** wyclif_ has quit IRC
|
11:58:26
|
*** wyclif_ has joined #openmrs
|
11:58:38
|
*** wyclif_ has joined #openmrs
|
12:02:23
|
*** wyclif_ has quit IRC
|
12:02:31
|
<dkayiwa> wyclif: hi
|
12:03:08
|
*** wyclif_ has joined #openmrs
|
12:21:38
|
*** harsz89 has joined #openmrs
|
12:22:04
|
*** kavuri has joined #openmrs
|
12:31:23
|
*** elliott_w has quit IRC
|
12:31:33
|
*** wyclif_ has quit IRC
|
12:43:13
|
<harsz89> hi dkayiwa
|
12:43:23
|
<dkayiwa> harsz89: hi
|
12:43:50
|
<harsz89> dkayiwa, are you familiar with a sync setup of parent and child
|
12:44:16
|
<harsz89> dkayiwa, i encountrd some problems need to check with someone else whether i'm doing wrong
|
12:44:21
|
<dkayiwa> harsz89: no :)
|
12:44:45
|
<harsz89> dkayiwa, okey dkayiwa
|
12:45:15
|
<harsz89> dkayiwa,thank you :)
|
12:45:37
|
<dkayiwa> harsz89: for nothing :)
|
12:45:49
|
<harsz89> dkayiwa, :D :D
|
12:45:57
|
<harsz89> dkayiwa, just :)
|
12:46:08
|
<harsz89> dkayiwa, i'm stick with some point fr days
|
12:46:18
|
<harsz89> dkayiwa, :(
|
12:46:39
|
<dkayiwa> harsz89: did you ask on the dev list?
|
12:46:54
|
<harsz89> dkayiwa, yeap i drop a mail
|
12:47:14
|
<harsz89> dkayiwa, :)
|
12:48:10
|
<dkayiwa> harsz89: any responses?
|
12:49:41
|
<harsz89> dkayiwa, still did'nt have response
|
12:50:18
|
<harsz89> dkayiwa, topic is Need to have some clarifications about Sync module setup
|
12:50:22
|
<harsz89> dkayiwa, :)
|
12:50:39
|
<dkayiwa> harsz89: ok
|
12:51:54
|
<harsz89> dkayiwa, :)
|
12:53:12
|
*** kavuri has quit IRC
|
12:53:23
|
*** kavuri has joined #openmrs
|
13:05:40
|
*** DraggonZ1 has quit IRC
|
13:06:02
|
*** DraggonZ has joined #openmrs
|
13:13:54
|
*** wyclif_ has joined #openmrs
|
13:27:04
|
*** DraggonZ has left #openmrs
|
13:39:57
|
*** kavuri has quit IRC
|
13:41:47
|
<mseaton> harsz89:
|
13:42:03
|
<mseaton> harsz89: you need help with sync setup?
|
13:43:03
|
*** sara_ has joined #openmrs
|
13:45:10
|
<harsz89> hi mseaton
|
13:45:34
|
<harsz89> mseaton, yeah i need some help
|
13:45:49
|
<mseaton> harsz89: so the issue is that you are trying to clone the parent to set up the child, and it isn't working?
|
13:45:57
|
<harsz89> mseaton, yes
|
13:46:12
|
<harsz89> mseaton, and i try to do it from database backup
|
13:46:31
|
<harsz89> mseaton, in adding child server page but i got a error
|
13:46:41
|
<mseaton> harsz89: i have never done this. i did notice however that there are several tickets in jira (browse the open tickets in the sync module and have a look) that talk about issues doing this - where the server just hangs, etc
|
13:46:54
|
*** elliott_w has joined #openmrs
|
13:46:54
|
*** ChanServ sets mode: +o elliott_w
|
13:46:55
|
<mseaton> harsz89: so have a look over those and see if they match your problem
|
13:47:06
|
<mseaton> harsz89: if they do, please comment on them and give information there as to how to reproduce
|
13:47:23
|
<mseaton> harsz89: otherwise, maybe we need to create a new ticket to either fix that bug, or update the documentation with instructions that work
|
13:47:31
|
<mseaton> harsz89: what is the error you are seeing?
|
13:47:36
|
<harsz89> mseaton, okey mseaton i'll do that way
|
13:48:17
|
<harsz89> mseaton, i drop a mail to dev topic is Need to have some clarifications about Sync module setup
|
13:48:35
|
<harsz89> mseaton, that contains all the things wait i'll check it
|
13:48:51
|
<mseaton> harsz89: are you setting up from a new empty instance? or are you trying to set up from an existing implementation that has lots of data in it?
|
13:49:23
|
*** shangxiao has quit IRC
|
13:49:36
|
<harsz89> mseaton, i just try to do it from fresh standalone server
|
13:49:51
|
<harsz89> mseaton, two standalone servers running in two ports
|
13:50:04
|
<harsz89> mseaton, one parent and a child
|
13:50:10
|
<mseaton> harsz89: in that case, just set up 2 new instances and configure one as the parent, and one as the child. there is no need to create a child off of the parent in this case.
|
13:50:32
|
<mseaton> harsz89: though i _am_ interested if there is an issue in doing this, so it is worth reporting if it is truly a bug
|
13:50:58
|
<harsz89> mseaton, yes that how i done it
|
13:51:09
|
<harsz89> in parent i add a child server
|
13:51:26
|
*** h3llborn has joined #openmrs
|
13:51:27
|
<harsz89> mseaton, and then go to chile and configure the parent
|
13:51:43
|
<mseaton> harsz89: ok. and what happens?
|
13:51:43
|
<harsz89> mseaton, parent connection apper to be success
|
13:52:01
|
<harsz89> mseaton,
|
13:52:04
|
<harsz89> mseaton, http://imagebin.org/250559
|
13:52:15
|
*** kavuri has joined #openmrs
|
13:52:28
|
<harsz89> mseaton, backend http://imagebin.org/250560
|
13:53:04
|
<harsz89> mseaton, i use 1.0.6 sync module version with standalone 1.9.3
|
13:53:07
|
<mseaton> harsz89: i have seen this error before. there is a ticket for it already i believe. and there is an easy workaround too.
|
13:53:12
|
<mseaton> harsz89: let me dig it up
|
13:53:44
|
<harsz89> mseaton, ah okey mseaton actually i forgot to went through issues
|
13:54:09
|
<harsz89> mseaton, i just try to set up a child and a parent to get familiar how sync works
|
13:54:13
|
<mseaton> harsz89: look here: https://tickets.openmrs.org/browse/SYNC-285
|
13:54:36
|
<mseaton> harsz89: let me know if this matches your issue, and if fixing your connection url in your runtime properties file fixes the issue
|
13:55:06
|
<harsz89> mseaton, thank you soo much mseaton i'll follow it
|
13:55:33
|
<harsz89> mseaton, :)
|
13:59:31
|
<mseaton> good luck
|
14:00:12
|
<cpower> good morning everyone!
|
14:00:24
|
<cpower> ready to scrum?
|
14:00:29
|
<mseaton> yep
|
14:00:42
|
<cpower> !scrumon cpower
|
14:00:42
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
14:01:23
|
<cpower> Order: djazayeri ,mseaton , dkayiwa , wyclif_
|
14:01:32
|
<cpower> and andrea when she arrive
|
14:02:35
|
<mseaton> i'll start
|
14:02:37
|
<mseaton> * Mostly working on code review, applying pull requests, commenting on tickets, etc
|
14:02:37
|
<mseaton> * Haven't started working on my in progress tickets yet, but plan to
|
14:02:37
|
<mseaton> * Unfortunately off today due to sick kids, so will not be as responsive over IRC and email as normal. Will do the best I can Back to full strength tomorrow.
|
14:02:48
|
<mseaton> no blockers
|
14:03:03
|
<dkayiwa> Investigated: failing unit test against 1.9.1: shouldSyncUserPropertyRemove(org.openmrs.module.sync.SyncUserTest) - SYNC-256
|
14:03:03
|
<dkayiwa> Now working on: failing unit test against 1.10.0-SNAPSHOT: shouldCreateProgram(org.openmrs.module.sync.SyncAdminTest) - SYNC-261
|
14:03:03
|
<dkayiwa> No Blockers
|
14:03:29
|
<wyclif_> Friday:
|
14:03:29
|
<wyclif_> Continue with SYNC-287 - Sync module should prevent OpenMRS Core from persisting changes if no sync record is created
|
14:03:29
|
<wyclif_> Started on SYNC-245 - From History of Changes page, unable to reset a record as a new sync record if any of the child server records are in the "waiting to synchronize" state
|
14:03:29
|
<wyclif_> Monday:
|
14:03:30
|
<wyclif_> Complete SYNC-245
|
14:03:32
|
<wyclif_> SYNC-247 - Configure sync poms to allow testing against multiple versions of Openmrs
|
14:03:34
|
<wyclif_> Review TODOs for SYNC-287 - Sync module should prevent OpenMRS Core from persisting changes if no sync record is created
|
14:03:39
|
<wyclif_>
|
14:03:41
|
<wyclif_> Blockers: None
|
14:04:33
|
<cpower> Ok anyone else?
|
14:04:33
|
<mseaton> thanks all for great participation so far. got pull requests from saptarshi, lluis, wyclif_ and dkayiwa so far!
|
14:04:41
|
<wyclif_> is it worth the effort to work on tickets against an unreleased openmrs version
|
14:04:53
|
<mseaton> wyclif_: what do you mean?
|
14:05:14
|
*** dmulindwa has joined #openmrs
|
14:05:36
|
<mseaton> wyclif_: you mean in the swimlane, whether it is worth doing tickets in TRUNK that are only for 1.10?
|
14:05:49
|
<wyclif_> like working on a ticket to fix a problem run into when running a module against say 1.10.0-snapahot
|
14:06:15
|
<wyclif_> 1.10.0 is not yet out yet, i would say fix those issues when it comes out
|
14:06:23
|
*** andreapat has joined #openmrs
|
14:06:36
|
<cpower> andreapat: you are up
|
14:07:08
|
<andreapat> TRUNK-3289
|
14:07:11
|
<mseaton> wyclif_: oh, i see. well, generally i would agree with you. those tickets exist now though, and i don't want to just delete them, so it would be nice to resolve them. but if they take too long or are testing something in 1.10 that might not actually make it into 1.10 then i agree.
|
14:07:19
|
*** Hasintha_i has joined #openmrs
|
14:07:41
|
<wyclif_> probably they should be of the lowest priority
|
14:08:05
|
<andreapat> Friday
|
14:08:05
|
<andreapat> TRUNK-3289 Fixed IllegalArgumentException
|
14:08:05
|
<andreapat> Palo Alto trip to meet Merck people and give presentation on OPenMRS to them
|
14:08:05
|
<andreapat> Went well - they are very intersted in OpenMrs
|
14:08:05
|
<andreapat> Monday
|
14:08:06
|
<andreapat> Fix failing test
|
14:08:07
|
<andreapat> New ticket
|
14:08:09
|
<andreapat> Blocker TRUNK-3289 still failing one test
|
14:08:40
|
<mseaton> wyclif_: good point.
|
14:09:15
|
<dkayiwa> though i like them for gently introducing us to the sync module :)
|
14:09:25
|
<mseaton> dkayiwa: yes, me too.
|
14:09:59
|
*** dmulindwa has quit IRC
|
14:10:01
|
<mseaton> andreapat: is your blocker something we should discuss here? do you need help with it?
|
14:10:44
|
<andreapat> mseaton, wyclif wanted me to share code - will do if he still has time
|
14:11:07
|
<andreapat> mseaton, then would like small ticket on synch module
|
14:11:15
|
<mseaton> dkayiwa: i think this issue around hibernate onFlushDirty not being called with collection property changes should be investigated with high priority.
|
14:11:28
|
<dkayiwa> mseaton: oh i see!!!
|
14:11:42
|
<mseaton> dkayiwa: at least it seems significant!
|
14:12:05
|
<mseaton> dkayiwa: could be a major source of issues in the past that we had never figured out.
|
14:12:16
|
<dkayiwa> mseaton: ok
|
14:12:32
|
<mseaton> dkayiwa: do you feel well-positioned to look into it and propose some solutions?
|
14:12:59
|
*** k-joseph has joined #openmrs
|
14:13:23
|
<mseaton> dkayiwa: the fact that you figured that out makes me want you working on it, since you clearly understand the issues there.
|
14:13:38
|
<dkayiwa> mseaton: lollllllll :)
|
14:13:56
|
<mseaton> dkayiwa: is too modest
|
14:14:09
|
<mseaton> ok, that's all from me.
|
14:14:47
|
*** dmulindwa has joined #openmrs
|
14:15:54
|
<andreapat> wyclif, will you have any time later if I need some help on failing test?
|
14:19:08
|
*** kavuri has quit IRC
|
14:19:16
|
*** nribeka has quit IRC
|
14:19:16
|
<cpower> !scrumoff
|
14:19:16
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
14:19:51
|
<mseaton> dkayiwa: i just moved that ticket into the sprint with high priority.
|
14:19:59
|
<dkayiwa> mseaton: ok
|
14:24:41
|
<harsz89> hi mseaton
|
14:24:48
|
<harsz89> i look at the property file
|
14:25:14
|
<harsz89> mseaton, jdbc:mysql:mxj://127.0.0.1:3317/openmrs?autoReconnect=true&sessionVariables=storage_engine=InnoDB&useUnicode=true&characterEncoding=UTF-8&zeroDateTimeBehavior=convertToNull&server.initialize-user=true&createDatabaseIfNotExist=true&server.basedir=database&server.datadir=database/data&server.collation-server=utf8_general_ci&server.character-set-server=utf8&server.max_allowed_packet=96M
|
14:25:33
|
<harsz89> mseaton, i already have that properties mention in the ticket
|
14:25:35
|
<harsz89> :
|
14:25:37
|
<harsz89> :)
|
14:26:07
|
<harsz89> mseaton, it* already have that properties mention in the ticket
|
14:27:43
|
*** shangxiao has joined #openmrs
|
14:29:14
|
*** kishoreyekkanti has quit IRC
|
14:33:09
|
*** elliott_w has quit IRC
|
14:33:26
|
*** lh has joined #openmrs
|
14:33:26
|
*** lh has joined #openmrs
|
14:36:29
|
<mseaton> harsz89: probably the extra mxj: is the problem. please comment on the ticket and mention that your URL also causes problems. and this needs to be fixed. thanks!
|
14:37:46
|
<harsz89> mseaton, thank you mseaton
|
14:38:12
|
<harsz89> mseaton, can i change the connection url and test it
|
14:38:33
|
<harsz89> mseaton, i'll try that way
|
14:38:45
|
*** dmulindwa has quit IRC
|
14:39:16
|
<harsz89> mseaton, and finally when fixing a ticket it need to be tested so can use sprint sync build in standalone 1.9.3 to test?
|
14:39:24
|
<harsz89> mseaton, :)
|
14:39:24
|
<mseaton> harsz89: yes
|
14:39:30
|
<harsz89> mseaton, oki cool
|
14:39:41
|
<harsz89> maninc, :) thank you mseaton
|
14:39:48
|
<harsz89> sorry maninc
|
14:39:56
|
<harsz89> mseaton, thank you :)
|
14:46:14
|
*** portablejim has quit IRC
|
14:49:22
|
*** h3llborn has quit IRC
|
14:52:10
|
<k-joseph> dkayiwa: hi
|
14:52:32
|
<dkayiwa> k-joseph: hi
|
14:53:01
|
<k-joseph> dkayiwa: i would like you to help me, i have a challage of stopping ProcessFormEntryQueueTask at shutdown,
|
14:53:18
|
<dkayiwa> k-joseph: ok
|
15:04:58
|
*** lh has quit IRC
|
15:11:12
|
*** DraggonZ has joined #openmrs
|
15:24:09
|
*** h3llborn has joined #openmrs
|
15:26:25
|
<k-joseph> dkayiwa: hi
|
15:26:33
|
<dkayiwa> k-joseph: hi
|
15:30:16
|
<harsz89> hi dkayiwa
|
15:30:41
|
<dkayiwa> harsz89: hi
|
15:31:03
|
<harsz89> dkayiwa, is there a util class in openmrs to get the currant time of openmrs or can i do it using java functions
|
15:31:07
|
<harsz89> dkayiwa, :)
|
15:31:29
|
<dkayiwa> harsz89: use java functions :)
|
15:31:43
|
<harsz89> dkayiwa, okey..:) :D
|
15:31:53
|
<harsz89> dkayiwa, thank you, :D :)
|
15:32:02
|
<dkayiwa> :D
|
15:32:51
|
<k-joseph> dkayiwa: can i get any docs to help me understand what methods i need to stop ProcessFormEntryQueueTask
|
15:33:21
|
<k-joseph> dkayiwa: i have tried goolge but up to now still in vain
|
15:34:42
|
<dkayiwa> k-joseph: task = Context.getSchedulerService().getTaskByName("");
|
15:34:43
|
<dkayiwa> Context.getSchedulerService().shutdownTask(task);
|
15:34:48
|
<dkayiwa> k-joseph: is that of help?
|
15:35:11
|
<k-joseph> yes it is
|
15:50:49
|
*** k-joseph has quit IRC
|
15:52:41
|
*** andreapat has quit IRC
|
15:55:03
|
*** lh has joined #openmrs
|
15:55:03
|
*** lh has joined #openmrs
|
16:03:10
|
*** kavuri has joined #openmrs
|
16:09:43
|
*** ibewes has quit IRC
|
16:10:58
|
*** dmulindwa has joined #openmrs
|
16:15:06
|
*** nribeka has joined #openmrs
|
16:15:06
|
*** ChanServ sets mode: +v nribeka
|
16:26:04
|
*** Anuruddha has joined #openmrs
|
16:32:39
|
*** shangxiao has quit IRC
|
17:09:11
|
*** h3llborn has quit IRC
|
17:10:24
|
*** shangxiao has joined #openmrs
|
17:17:46
|
<wyclif_> hi djazayeri mseaton
|
17:19:37
|
<wyclif_> mseaton, djazayeri a quick question: if sync is to fail an api call, then don't we need make it verbose and bubble out of the API so that the user doesnt get the wrong idea that the operation was successful
|
17:21:03
|
<wyclif_> djazayeri, mseaton but the problem is that spring swallows all exceptions generated when calling interceptor methods
|
17:22:02
|
<djazayeri> wyclif_: yes, if a save fails due to spring, and the transaction is rolled back, we do want to show this to the user.
|
17:22:18
|
<djazayeri> wyclif_: I don't know how you'd do this
|
17:22:55
|
<wyclif_> djazayeri, yeah am having trouble figuring it out, thought you guys had some ideas
|
17:25:28
|
<wyclif_> djazayeri, the only thing i can imagine now is to create an alert to the logged in user and admin
|
17:32:01
|
*** k-joseph has joined #openmrs
|
17:33:51
|
<djazayeri> wyclif_: I don't have any ideas. That's as good as anything. You sure you can't get it into the regular UI?
|
17:35:48
|
<wyclif_> outside the interceptor, you can't know about the exception since spring swallows it
|
17:35:51
|
<wyclif_> djazayeri, outside the interceptor, you can't know about the exception since spring swallows it
|
17:38:34
|
*** sara_ has quit IRC
|
17:40:07
|
*** DraggonZ has quit IRC
|
17:46:16
|
*** sunbiz has joined #openmrs
|
17:46:16
|
*** ChanServ sets mode: +v sunbiz
|
17:48:37
|
<k-joseph> dkayiwa: hi
|
17:48:43
|
<dkayiwa> k-joseph: hi
|
17:48:56
|
<k-joseph> dkayiwa: please interview this commit https://github.com/k-joseph/openmrs-module-formentry/commit/FORM-138
|
17:49:49
|
<dkayiwa> k-joseph: do you know what this method does? getTaskByName()
|
17:50:36
|
<k-joseph> dkayiwa: i think it is supposed to fetch a task by its name
|
17:51:06
|
<dkayiwa> k-joseph: so does your code make sense regarding that?
|
17:54:12
|
<k-joseph> dkayiwa: ressolved that to ......getTaskByName("ProcessFormEntryQueue");
|
17:55:04
|
<dkayiwa> k-joseph: load the formentry module, then go to the admin page, click manage scheduler, you will see the name for it
|
17:55:24
|
<sunbiz> downey: hey Michael!! u there??
|
17:55:30
|
<k-joseph> dkayiwa: checking that out
|
18:05:25
|
<k-joseph> dkayiwa: ok that is; "Process Form Entry Queue"!!!
|
18:06:03
|
<dkayiwa> k-joseph: i do not have it loaded here. but just copy and paste the exact name from there
|
18:06:28
|
*** kavuri has quit IRC
|
18:07:00
|
<k-joseph> dkayiwa: is the name under th ecolumn Task / Class
|
18:07:06
|
<k-joseph> ?
|
18:08:34
|
<k-joseph> dkayiwa: seen that,
|
18:08:48
|
*** shangxiao has quit IRC
|
18:18:59
|
*** jblaya has joined #openmrs
|
18:29:12
|
*** dmulindwa has quit IRC
|
18:30:12
|
*** Axay has joined #openmrs
|
18:33:11
|
*** Hasintha_i has quit IRC
|
18:35:42
|
*** Axay has quit IRC
|
18:36:01
|
<k-joseph> dkayiwa: is that commit with the name added ok to be committed and having a pull request for it?:-)
|
18:37:55
|
<dkayiwa> k-joseph: ok
|
19:11:11
|
*** andrea has joined #openmrs
|
19:11:30
|
*** andrea is now known as andreap
|
19:15:27
|
*** k-joseph has quit IRC
|
19:17:57
|
*** andreap has quit IRC
|
19:27:39
|
*** k-joseph has joined #openmrs
|
19:53:25
|
*** sunbiz has quit IRC
|
19:54:51
|
*** k-joseph has quit IRC
|
20:12:42
|
*** dmulindwa has joined #openmrs
|
20:16:52
|
*** mcwere has joined #openmrs
|
20:19:50
|
*** shortend has quit IRC
|
20:20:03
|
*** h3llborn has joined #openmrs
|
20:24:44
|
*** dmulindwa has quit IRC
|
20:40:59
|
*** andreapat has joined #openmrs
|
20:41:50
|
<andreapat> wyclif_, are you around ?
|
20:41:57
|
<wyclif_> andreapat, yeah
|
20:42:25
|
<andreapat> wyclif_, great - just sent you an email - di you see it?
|
20:43:11
|
*** dmulindwa has joined #openmrs
|
20:44:15
|
<wyclif_> andreapat, let me check
|
20:49:15
|
<wyclif_> andreapat, i have seen it but i cant seem to get your question well
|
20:50:31
|
*** dmulindwa has quit IRC
|
20:50:39
|
<andreapat> wyclif_: wondering if you have time to look at code. It looks good to me yet still failing my unit test
|
20:51:16
|
*** harsz89 has quit IRC
|
20:52:20
|
<andreapat> wyclif_: put some debug staements in code to test in UI but can't seem to add order - doesn't like Patient ofr concept id
|
20:53:40
|
<wyclif_> andreapat, is the assertion just failing or you get an exception?
|
20:54:00
|
<andreapat> wyclif_ assertion is failing
|
20:54:47
|
<wyclif_> andreapat, can you send a pastebin link of your DAO method?
|
20:56:36
|
<andreapat> wyclif_: http://pastebin.com/751V1WM2
|
20:59:39
|
<wyclif_> andreapat, hold on as i look at it
|
20:59:55
|
<andreapat> wyclif_: sure
|
21:00:18
|
<wyclif_> andreapat, can you also send a link of your test code
|
21:01:53
|
<andreapat> wyclif_: test code - http://pastebin.com/H2m5N2Gj
|
21:04:28
|
*** h3llborn has quit IRC
|
21:05:45
|
<andreapat> wyclif_: also test dataset - http://pastebin.com/spt3Sv0b
|
21:06:09
|
<wyclif_> andreapat, your test code needs improvement
|
21:06:57
|
<andreapat> wyclif_: ok , what needs to be improved?
|
21:07:17
|
<wyclif_> andreapat, and the assertion is wrong, you want to test that when you reload that obs by its uuid, that it is null
|
21:07:32
|
<wyclif_> andreapat, and not the previously loaded one
|
21:08:15
|
<wyclif_> andreapat, also you want to add an assertion at the beginning to ensure that actually the obs and order are associated
|
21:08:20
|
*** lh has quit IRC
|
21:08:35
|
<wyclif_> andreapat, i.e obs.getOrder and the order and the same
|
21:08:52
|
<andreapat> wyclif: will change it
|
21:10:25
|
<wyclif_> andreapat, does everything seems clear now?
|
21:11:08
|
<andreapat> wyclif, yes - very -thanks
|
21:12:15
|
<wyclif_> andreapat, i meant when reload it by id, thought uuid would still be fine
|
21:12:21
|
*** h3llborn has joined #openmrs
|
21:14:35
|
<andreapat> wyclif_: shouldn't obs be null when reloaded since purgeOrder has been called and should delete Obs?
|
21:15:13
|
<wyclif_> andreapat, that is what i meant
|
21:15:30
|
<andreapat> wyclif_ ok cool
|
21:16:01
|
<wyclif_> andreapat, did you look at the test in ConceptService method you copied from the code?
|
21:16:14
|
<wyclif_> andreapat, to see how they set up the test
|
21:19:54
|
<andreapat> wyclif, I did look at it after mine was written - will look again
|
21:23:35
|
*** lh has joined #openmrs
|
21:23:35
|
*** lh has joined #openmrs
|
21:28:29
|
*** h3llborn has quit IRC
|
21:32:21
|
*** RussellG has joined #openmrs
|
21:34:19
|
<RussellG> Hi, was wondering if anyone has seen this problem before...I'm using OpenMRS 1.9.3 with the latest REST module and its extension module. When I try to POST an encounter with an observation that has a value of Datetime, I'm getting unparseable date exception that I didn't with 1.8.4. For example, Unparseable date: "2013-04-18T14:48:25.488-0500"
|
21:39:31
|
*** lh has quit IRC
|
21:52:29
|
*** lh has joined #openmrs
|
21:53:50
|
*** dmulindwa has joined #openmrs
|
22:01:32
|
*** wyclif_ has quit IRC
|
22:04:31
|
*** dkayiwa has quit IRC
|
22:18:29
|
*** dmulindwa has quit IRC
|
22:25:34
|
*** sunbiz has joined #openmrs
|
22:25:34
|
*** ChanServ sets mode: +v sunbiz
|
22:27:17
|
*** jblaya has quit IRC
|
22:36:11
|
*** dmulindwa has joined #openmrs
|
23:11:04
|
*** sunbiz has left #openmrs
|
23:31:03
|
*** wyclif_ has joined #openmrs
|