IRC Chat : 2013-03-13 - OpenMRS

00:00:50 <h3llborn> naja was kann man machen haha
00:01:26 <h3llborn> hat er dass schon seit Jahrzehnten benutzt?
00:04:00 <elefone> ne, wahrscheinlich ein paar jahrhudnerten
00:04:08 <elefone> jahrhunderten*
00:04:16 <elefone> ugh, ich weiss das Wort nicht
00:04:34 <h3llborn> war schon richtig ahha
00:04:42 <elefone> also kannst du Deutsch und Englisch mit keinem Akzent?
00:04:48 <h3llborn> jepp
00:05:00 <elefone> was, ich bin neidisch (jealous?)
00:05:07 <elefone> ist das richtig? neidisch?
00:05:55 <h3llborn> jepp
00:22:17 *** mseaton1 has joined #openmrs
00:22:20 *** mseaton1 has left #openmrs
00:34:26 *** elefone has quit IRC
01:19:26 *** lh has joined #openmrs
02:13:04 *** shangxiao has joined #openmrs
02:42:06 *** Iome_ has quit IRC
02:42:32 *** Iome has joined #openmrs
02:55:41 *** Barry has joined #openmrs
03:04:41 *** Hasintha_i has joined #openmrs
03:11:45 <shangxiao> jkeiper are you there? :)
03:11:56 <jkeiper> shangxiao: yep, what's up?
03:12:15 <shangxiao> I've attempted to change the id on a sample xsn to match a form in openmrs but am still getting the formId mismatch exception
03:12:44 <shangxiao> I've changed template.xml defaults.xml and sampledata.xml
03:14:46 <jkeiper> shangxiao: ok, did you try just starting clean by opening the basic form then duplicating it?
03:14:54 <shangxiao> yep
03:15:17 <shangxiao> I'm trying to use the xsn as attached in FORM-140
03:15:34 <shangxiao> !ticket FORM-140
03:15:35 <OpenMRSBot> shangxiao: [#FORM-140] Allergy (concept) search widget improperly formats selected concept names - OpenMRS JIRA - https://tickets.openmrs.org/browse/FORM-140
03:15:55 <jkeiper> shangxiao: at this point you should not use an existing XSN but modify the one that comes with the form when it is duplicated
03:16:10 <shangxiao> oh
03:16:18 <jkeiper> shangxiao: so, duplicating basic form to one called "new form", then download that XSN and modify it
03:16:25 <jkeiper> shangxiao: to see the behavior you want to see
03:16:26 <shangxiao> i thought it would be as simple as changing the id
03:16:35 <jkeiper> shangxiao: in some cases it is
03:16:42 *** Barry has quit IRC
03:16:44 <jkeiper> shangxiao: but honestly, we always start by duplicating
03:16:49 <jkeiper> shangxiao: tricky business ;-)
03:17:02 <shangxiao> the problem is that we don't have Infopath so we'd have to set it up by hand
03:17:39 <jkeiper> shangxiao: that is a tough problem
03:17:45 <shangxiao> lol
03:17:48 <jkeiper> shangxiao: makes it almost impossible to work with formentry
03:17:59 <jkeiper> ;-)
03:18:32 <shangxiao> we may be able to do it as all we need is the "other allergy" concept lookup field
03:19:00 <shangxiao> damn Microsoft and their special office version ;)
03:26:41 *** harsz89 has quit IRC
03:31:07 <shangxiao> jkeiper: I've asked the problem reporter to supply a mysql dump of their database
03:31:17 <shangxiao> that way we don't have to mess around with Infopath
03:31:22 <shangxiao> and xsns
03:31:47 <jkeiper> shangxiao: aha
03:32:31 <jkeiper> shangxiao: i am the reporter, looks like
03:32:39 <shangxiao> oh lol
03:32:47 <shangxiao> i mean the ada yeung person :)
03:33:08 <jkeiper> shangxiao: haha ok
03:33:25 <jkeiper> shangxiao: that might be hard to get -- private data
03:33:29 <jkeiper> shangxiao: i work for AMPATH
03:33:31 <shangxiao> oh
03:33:36 <jkeiper> shangxiao: let me see ...
03:33:49 <shangxiao> all i really need is the rows for the forms 253 and 357
03:33:56 <shangxiao> and any associated tables
03:34:55 <shangxiao> and if the concept "skin rash" isn't in the demo data and is related to the problem then I may need that too
03:37:23 <jkeiper> shangxiao: i think you might want to ping wyclif on this one (he's not here right now)
03:37:31 <jkeiper> shangxiao: but perhaps see if you can mention him in a comment
03:37:39 <jkeiper> shangxiao: i think he knows the root cause
03:37:48 <jkeiper> shangxiao: and therefore how to mimic it in your environment
03:38:00 <jkeiper> shangxiao: i knew the root cause at one point, then i wrote the ticket and promptly forgot
03:45:57 <shangxiao> jkeiper: lol :) thx mate I'll try to contact him
03:48:38 <jkeiper> shangxiao: np, if I get some breathing room I'll try to revisit that issue
04:17:58 *** robbyoconnor has joined #openmrs
04:17:58 *** ChanServ sets mode: +v robbyoconnor
04:18:54 *** shangxiao has quit IRC
04:47:48 *** maninc has joined #openmrs
04:54:48 *** kishoreyekkanti has joined #openmrs
05:01:01 *** lh has quit IRC
05:10:46 *** GitHub99 has joined #openmrs
05:10:46 <GitHub99> [openmrs-core] wluyima opened pull request #245: Manage preferred status for PersonName, PersonAddress and PatientIdentifier in the API - TRUNK-2200 (master...TRUNK-2200) http://git.io/Dj-WNQ
05:10:46 *** GitHub99 has left #openmrs
05:12:21 *** GitHub170 has joined #openmrs
05:12:21 <GitHub170> [openmrs-core] wluyima opened pull request #246: Default values not recognized In the Locations --> "Manage Layout" - TRUNK-3564 (master...TRUNK-3564) http://git.io/NpFQuw
05:12:21 *** GitHub170 has left #openmrs
05:16:08 *** dan has joined #openmrs
05:39:28 *** Hasintha_i has quit IRC
06:03:26 *** davidpardz has joined #openmrs
06:15:43 *** evmw has quit IRC
06:22:15 *** shangxiao has joined #openmrs
06:25:59 *** shortend has quit IRC
06:30:49 *** robbyoconnor has quit IRC
06:36:34 *** robbyoconnor has joined #openmrs
06:36:34 *** ChanServ sets mode: +v robbyoconnor
07:05:43 *** dan has quit IRC
07:07:21 *** dan has joined #openmrs
07:09:25 *** ibewes has joined #openmrs
07:10:35 *** shangxiao has quit IRC
07:14:40 *** dmulindwa has joined #openmrs
07:15:42 *** dan has quit IRC
07:59:17 *** dkayiwa has joined #openmrs
08:10:05 *** dkayiwa has quit IRC
08:10:48 *** andrewdex has joined #openmrs
08:11:09 <andrewdex> hello
08:11:35 *** dkayiwa has joined #openmrs
08:12:28 *** andrewdex has quit IRC
09:15:17 *** arumugam has joined #openmrs
09:19:37 *** arumugam has quit IRC
09:24:20 *** upul has joined #openmrs
09:24:20 *** ChanServ sets mode: +v upul
09:26:53 *** r0bby has joined #openmrs
09:26:53 *** ChanServ sets mode: +v r0bby
09:27:41 *** h3llborn_ has joined #openmrs
09:36:20 *** robbyoconnor has quit IRC
09:36:20 *** h3llborn has quit IRC
09:36:22 *** h3llborn_ is now known as h3llborn
09:48:51 *** shangxiao has joined #openmrs
10:03:32 <shangxiao> jkeiper just realised that the data entry is using Infopath as well - I thought you guys were importing so that you could embed the form in the browser (which is easy to do since Infopath uses html)
10:13:04 *** dmulindwa has quit IRC
10:21:32 *** upul has quit IRC
10:25:02 *** r0bby_ has joined #openmrs
10:25:02 *** ChanServ sets mode: +v r0bby_
10:25:04 *** dkayiwa has quit IRC
10:29:00 *** r0bby has quit IRC
11:02:26 *** dkayiwa has joined #openmrs
11:12:28 *** dkayiwa has quit IRC
11:13:48 *** dkayiwa has joined #openmrs
11:15:04 *** davidpardz has quit IRC
11:25:57 *** dkayiwa_ has joined #openmrs
11:26:12 *** dkayiwa has quit IRC
11:26:13 *** dkayiwa_ is now known as dkayiwa
11:34:34 *** ibewes has quit IRC
11:59:35 *** shangxiao has quit IRC
12:21:49 *** harsz89 has joined #openmrs
12:29:37 *** harshadura has joined #openmrs
12:42:30 *** joeseff has joined #openmrs
12:45:45 <dkayiwa> hi joeseff
12:46:16 <joeseff> dkayiwa I'm fine, how are you?
12:46:54 <dkayiwa> joeseff: am good
12:47:27 <joeseff> dkayiwa Let me ask you a little bit about data entry, is that ok with you?
12:48:12 <dkayiwa> joeseff: ok
12:51:55 <joeseff> dkayiwa I'm building a form for a diabetes clinic. There is a section of the form where one is asked to fill in details of what drugs they are on, to which the answers must be yes or no. The problem I have is that while the MVP-CIEL dictionary defines the drugs such as Glibenclamide, it does not define question concepts for them. How does one ask questions about which drugs a patient is on? I want to avoid developing a lot of unique
12:53:45 *** GitHub139 has joined #openmrs
12:53:45 <GitHub139> [openmrs-core] dkayiwa pushed 1 new commit to 1.9.x: http://git.io/vli0zA
12:53:45 <GitHub139> openmrs-core/1.9.x 48a68e6 dkayiwa: Back porting to 1.9.x: View Logged In Users" visible to all users under...
12:53:45 *** GitHub139 has left #openmrs
12:55:51 <dkayiwa> joeseff: and you do not want to create new concepts?
12:56:58 <joeseff> dkayiwa yes, is there any other way? I only want to create new concepts as a last resort
12:58:44 *** sara__ has joined #openmrs
12:59:05 <dkayiwa> joeseff: you can ask on the implementers list. May be on there some body knows the exact concept you need to use for such :)
12:59:42 <dkayiwa> joeseff: i can see you are creating concepts as sparingly as advised :)
13:01:06 <joeseff> dkayiwa, thanks. Yes, I prefer to follow the advice of my predecessors. Do you know what channel the implementers are on? Or how can I contact the implementers?
13:01:08 <sara__> @dkayiwa hi
13:03:59 <dkayiwa> joeseff: are you on the implementers list already?
13:04:07 <dkayiwa> sara__: hi my namesake :)
13:04:52 <sara__> well i have used the formatter
13:06:03 <sara__> do i commit again?
13:06:29 <joeseff> dkayiwa: no I'm not on the implementers list yet, I imagine that with time perhaps I will. I've only worked on OpenMRS for two weeks.
13:06:49 <dkayiwa> joeseff: you should get there noowwwww :)
13:08:25 <joeseff> dkayiwa: Ok :-) Thanks for the help
13:09:04 <dkayiwa> joeseff: you are welcome :)
13:09:22 <dkayiwa> sara__: can you do a brand new commit?
13:09:22 <sara__> @dkayiwa shud i commit the files where i have included the coding conventions or shud i make a commit with all changes a fresh?
13:09:26 <dkayiwa> sara__: as in do it all over again
13:09:28 <joeseff> dkayiwa: Good day
13:09:35 <dkayiwa> joeseff: same to u
13:09:48 <sara__> okay!
13:12:40 *** shangxiao has joined #openmrs
13:17:38 *** mseaton1 has joined #openmrs
13:18:07 *** mseaton1 has left #openmrs
13:19:17 <jkeiper> shangxiao: ah, wish it was that easy ;-)
13:21:15 <shangxiao> with the form entry? :) yeah me too
13:21:53 <jkeiper> shangxiao: that's how xforms works, and it's great
13:22:16 *** maninc has quit IRC
13:22:16 <jkeiper> shangxiao: we just got familiar with using infopath for some fancy features and have pushed dkayiwa to keep implementing the ones we like in xforms ;-)
13:22:45 *** maninc has joined #openmrs
13:24:48 *** ChanServ sets mode: +v harshadura
13:28:23 *** joeseff has quit IRC
13:32:51 <shangxiao> jkeiper: HTML5 now allows people to do inline editing of pages - CKEditor 4 has taken advantage of this and added it to their wysiwyg editor so now you can edit forms on the fly
13:42:29 <jkeiper> shangxiao: agreed, we love that stuff ... would be neat to have something like that in a form entry module
13:47:44 <sara__> @dkayiwa committed!
13:48:19 *** maninc has quit IRC
13:56:41 <dkayiwa> sara__: ok
13:58:53 <dkayiwa> sara__: you are still using a wrong formatter
13:59:21 <sara__> m using OpenMRSFormatter?
14:00:32 <dkayiwa> sara__: can you send me a screen shot of your eclipse preference window for Java - Code Style -Formatter?
14:00:55 <dkayiwa> sara__: use http://snag.gy/
14:01:02 <dkayiwa> sara__: and then send me the url
14:01:11 <sara__> okay
14:01:40 <sara__> okay
14:02:04 *** wyclif_ has joined #openmrs
14:03:51 <cpower> Hello everyone
14:03:58 <cpower> Ready to scrum?
14:04:06 <sara__> @dkayiwa http://snag.gy/fbp4F.jpg
14:04:25 <cpower> !scrumon cpower
14:04:25 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
14:04:55 <cpower> Order: djazayeri , mseaton , dkayiwa , wyclif_ , and andrea when she appears
14:05:14 *** andreapat has joined #openmrs
14:05:50 <andreapat> cpower, are we scrumming?
14:05:54 <cpower> yep
14:06:22 <cpower> but so far we have the same response as I did to the University call
14:06:41 <andreapat> cpower, what a strange day
14:06:47 <cpower> I'm figuring djazayeri is working hard on his hospital
14:06:56 <cpower> mseaton: are you there?
14:07:17 <andreapat> cpower, yes re djazayeri do you know how it's going?
14:07:28 <cpower> nope
14:07:37 <cpower> dkayiwa: how about you?
14:07:58 <dkayiwa> Reviewed: Update Default XSLT for complex observations - XFRM-120
14:07:59 <dkayiwa> Reviewed and tested: On successful save of Concept one should go to View Concept Screen - TRUNK-3811
14:07:59 <dkayiwa> Reviewed: Formentry Proposed Concept in concept.jsp taskpane widget should not allow empty text - FORM-55
14:07:59 <dkayiwa> Did a minor review on: Address layout management is mislabeled in the application - TRUNK-3847
14:07:59 <dkayiwa> Reviewed, back ported and closed: View Logged In Users" visible to all users under Administration - TRUNK-3720
14:08:00 <dkayiwa> Now reviewing: Add column deathdate_estimated to person table - TRUNK-2768
14:08:00 <dkayiwa> No Blockers
14:08:09 <cpower> dkayiwa: thanks for being around!
14:08:18 <cpower> wyclif_: you are up
14:08:19 <dkayiwa> :D cpower
14:08:26 <wyclif_> Tuesday:
14:08:26 <wyclif_> TRUNK-2200 - Manage preferred status for PersonName, PersonAddress and PatientIdentifier in the API
14:08:26 <wyclif_> Review and apply pull requests
14:08:26 <wyclif_> Reviewed and tested TRUNK-3836 - Add search button to Concept search
14:08:26 <wyclif_> Started on - STAND-67 - Standalone includes tables for modules that are not installed
14:08:26 <wyclif_> Wednesday:
14:08:28 <wyclif_> Complete on - STAND-67 - Standalone includes tables for modules that are not installed
14:08:30 <wyclif_> design call
14:08:32 <wyclif_> pick another ticket
14:08:34 <wyclif_>
14:08:36 <wyclif_> Blockers: None
14:09:03 <cpower> and andreapat you are up
14:09:17 <cpower> wyclif_: thank you too for being around
14:09:20 <andreapat> Tuesday
14:09:20 <andreapat> Ticket: TRUNK-3289 Delete other order stuff before deleting current order
14:09:20 <andreapat> All refertial erros fixed Test dataset ok now
14:09:20 <andreapat> Still error in test
14:09:20 <andreapat> Had to leave early to get root canal
14:09:21 <andreapat> Wednesday
14:09:23 <andreapat> University call
14:09:25 <andreapat> Design call
14:09:27 <andreapat> Ticket: TRUNK-3289 - fix failing test
14:09:29 <andreapat> Prepare to demo OpenMRS to Merck people in Palo Alto
14:09:33 <andreapat> Discussion
14:09:35 <andreapat> re demo OpenMRS
14:09:37 <andreapat> Blocker
14:09:39 <andreapat> Had problem with git putting extra lines in my code and compile error:
14:09:41 <andreapat> The method purgeOrder(Order) of type OrderServiceImpl must override or implement a supertype
14:09:43 <andreapat> method
14:10:22 <cpower> Great, let's talk about andreapat blocker then her demo
14:11:10 <andreapat> cpower, asked Rafa to pair with me - but he is in conference - he said to try Wyclif or Daniel
14:11:20 <wyclif_> andreapat, i can help
14:11:31 <dkayiwa> wyclif_: thanks
14:11:33 <andreapat> wyclif_, good thanks
14:11:45 <cpower> good deal, then I'll let you to do that in a min. andreapat tell us about this demo!?!
14:12:33 *** r0bby_ has quit IRC
14:13:19 <andreapat> cpower, our Merck crew is moving to Palo Alto- Friday Kiran and Patrick and I are going to meet with Palo Alto people - they want me to demo Openmrs
14:13:39 <cpower> cool! Need any help?
14:13:58 <andreapat> cpower, yes - what should I show them?
14:14:03 <cpower> lol
14:14:33 <andreapat> cpower, come on - just the basic system - what is good for a demo?
14:14:36 <cpower> let's wrap up the scrum and let me think about that for a min and give you some helpful hints that could help
14:14:50 <andreapat> cpower, ok
14:14:52 <cpower> !scrumoff
14:14:52 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
14:14:58 <cpower> brb
14:15:36 <andreapat> cpower, Rafal set up adobe conference to pair - can you do that for Wyclif and I?
14:20:07 <andreapat> cpower?
14:20:48 <andreapat> wyclif_: when, how can we get together
14:21:15 <wyclif_> in 15min
14:21:24 <wyclif_> andreapat, in 15min
14:21:30 <andreapat> wyclif_ok
14:22:03 <cpower> okay I'm back
14:22:25 <andreapat> cpower, did you see my question re adobe conference?
14:23:10 <cpower> andreapat: yes the demo server is a great place to go. I would also recommend googling OpenMRS on slideshare and you will find more than a few presentations we've done in the past. Feel free to use any of it
14:23:24 <cpower> andreapat: sure thing
14:23:31 *** h3llborn has quit IRC
14:26:41 <cpower> ok wyclif_ and andreapat : use: http://connect.iu.edu/openmrspair/
14:27:35 <andreapat> cpower, thanks
14:27:59 <cpower> could you join it now so I can make you a host and you can then host wyclif when he jois
14:28:01 <cpower> joins
14:28:23 <andreapat> cpower, ok
14:29:25 *** kishoreyekkanti has quit IRC
14:30:00 <andreapat> cpower, I'm there
14:30:01 <cpower> ok now you and Daniel should be able to screen share.let me know if you need anything else
14:30:13 <andreapat> cpower, daniel?
14:30:22 <cpower> he was in the room
14:32:36 <dkayiwa> andreapat: yes iam
14:35:35 <andreapat> cpower, how do I share screen adobe connect is saying start webcam - I want to share screen
14:36:10 <dkayiwa> andreapat: you can share now
14:36:38 <andreapat> ok
14:37:37 <andreapat> cpower, can't hear
14:37:48 <cpower> your mic is working as I can hear you.
14:37:59 <cpower> you may need to setup your audio
14:42:48 *** k-joseph has joined #openmrs
14:45:19 <dkayiwa> andreapat: i can hear you but not clearly
14:45:31 <dkayiwa> andreapat: is it something wrong on my side?
14:45:41 <dkayiwa> andreapat: did you hear me clearly?
14:53:06 *** andreapat has quit IRC
15:05:24 <sara__> @dkayiwa http://snag.gy/fbp4F.jpg
15:06:52 <dkayiwa> sara__: that looks good. did you do any manual formatting?
15:07:02 <dkayiwa> sara__: or you just did an mvn clean install?
15:07:35 <sara__> just mvn clean install
15:07:54 <sara__> no manual formatting
15:07:55 <dkayiwa> sara__: no ctrl + shift + f ?
15:08:09 <sara__> nop
15:09:01 <dkayiwa> sara__: did you try restart eclipse?
15:09:12 <sara__> should i?
15:09:16 <sara__> no
15:09:28 <dkayiwa> sara__: yes do
15:09:40 <sara__> okay
15:10:56 *** kmithemanth has joined #openmrs
15:11:05 <sara__> @dkayiwa after restarting eclipse, should i create a fresh commit ?
15:11:33 <dkayiwa> sara__: before doing the commit, can you run mvn clean install?
15:12:41 <sara__> @dkayiwa okay i will restart and do a mvn clean install
15:14:37 <dkayiwa> sara__: after a restart of eclipse, do an mvn clean install before you do any changes for the ticket
15:15:30 <sara__> ok
15:18:27 *** Hasintha_i has joined #openmrs
15:21:05 *** h3llborn has joined #openmrs
15:22:56 *** elefone has joined #openmrs
15:23:32 *** dimuthuupe has joined #openmrs
15:28:53 *** andrea_pat has joined #openmrs
15:29:18 <andrea_pat> dkayiwa, now andrea_pat
15:29:28 <dkayiwa> andrea_pat: :D
15:29:29 *** k-joseph has quit IRC
15:29:53 <h3llborn> morning guys!
15:30:10 <dkayiwa> good evening
15:30:22 <h3llborn> :P
15:30:55 *** Echidna_ has quit IRC
15:31:11 *** Echidna has joined #openmrs
15:31:11 *** ChanServ sets mode: +v Echidna
15:35:51 <h3llborn> I'm about to go to class and you're about to sleep thats nuts haha
15:38:54 <andrea_pat> dkayiwa, mvn clean install still running - so slow
15:39:07 <dkayiwa> andrea_pat: ok
15:39:26 <andrea_pat> dkayiwa, what time is it there?
15:39:45 <dkayiwa> andrea_pat: 6:40pm
15:40:24 <andrea_pat> dkayiwa, wow - late 8:40 am here
15:40:42 <dkayiwa> andrea_pat: :)
15:42:29 <h3llborn> its 11:40 here
15:42:40 <h3llborn> andrea_pat: you west coast eh
15:44:12 <andrea_pat> h311born, where are you?
15:44:20 <h3llborn> Ontario hbu
15:45:33 <sara__> @dkayiwa restarted eclipse, mvn clean install, made changes to the files, should i commit ?
15:46:08 <dkayiwa> sara__: i wanted you check something before you make any changes
15:46:42 <sara__> okay
15:47:04 <sara__> shud i undo?
15:47:23 <dkayiwa> sara__: yes'
15:47:36 <sara__> okay
15:48:22 *** lh has joined #openmrs
15:48:22 *** lh has joined #openmrs
15:48:35 *** barry has joined #openmrs
15:48:42 <sara__> now?
15:48:47 <sara__> @dkayiwa i have undone the changes
15:49:09 <dkayiwa> sara__: do mvn clean install
15:49:16 <sara__> okay
15:53:25 *** Dimuthu has joined #openmrs
15:55:32 <andrea_pat> dkayiwa, mvn clean install still running - this is weird
15:56:20 <dkayiwa> andrea_pat: does it showw any progress
15:56:46 *** crazee has joined #openmrs
15:56:46 *** ChanServ sets mode: +v crazee
15:58:23 *** dimuthuupe has joined #openmrs
15:58:26 *** h3llborn has quit IRC
15:58:54 <andrea_pat> dkayiwa: redirected log to file - it is huge - bet there are a bunch of failing tests
15:59:36 *** Dimuthu has quit IRC
15:59:41 <dkayiwa> andrea_pat: can you create a brand new branch?
16:00:12 <andrea_pat> dkayiwa: ok
16:00:42 *** h3llborn has joined #openmrs
16:01:45 <andrea_pat> dkayiwa, created new branch TRUNK-3289a
16:02:18 <dkayiwa> andrea_pat: can you switch to that branch and then do mvn clean install?
16:02:35 <andrea_pat> dkayiwa, will do
16:07:42 <andrea_pat> dkayiwa, I still see my new code in Eclipse, that doesn't seem right
16:07:58 *** dmulindwa has joined #openmrs
16:08:21 <dkayiwa> andrea_pat: after switching to a new branch?
16:09:16 <andrea_pat> dkayiwa, yes
16:09:28 <andrea_pat> dkayiwa: $ git checkout TRUNK-3289a Switched to branch 'TRUNK-3289a'
16:10:04 <dkayiwa> andrea_pat: try reset hard
16:10:38 <andrea_pat> dkayiwa, ok
16:11:22 *** h3llborn has quit IRC
16:11:29 <andrea_pat> dkayiwa, git reset --hard or git reset --hard master?
16:11:35 <shangxiao> does anyone know how to setup Spring's DefaultAnnotationHandlerMapping when using mvc:annotation-driven
16:11:55 <dkayiwa> andrea_pat: try both :)
16:12:23 <sara__> @dkayiwa complted mvn clean install
16:12:39 <shangxiao> git reset hard will remove any changes to the current head
16:12:53 <dkayiwa> sara__: do you have any local changes?
16:13:01 <shangxiao> git reset --hard master will move the head to the master and remove changes
16:13:21 <sara__> not yet
16:13:42 <andrea_pat> dkayiwa, $ git reset --hard HEAD is now at 8ca961e TRUNK-3289 Add new method: deleteObsThatReference(order) patandre@USRYMRPATANDRE ~/workspace/openmrs-core-1 (TRUNK-3289a)
16:14:10 <dkayiwa> andrea_pat: do you now see your changes in?
16:14:39 <dkayiwa> sara__: can you try commit and see if you will actually commit any changes? :)
16:14:49 <dkayiwa> sara__: i mean just commit
16:15:08 <sara__> @dkayiwa u mean i check git status?
16:15:28 <dkayiwa> sara__: you seem to know more git than i do. :)
16:15:31 <dkayiwa> sara__: oh yes
16:15:40 <sara__> okay!
16:16:27 <sara__> @dkayiwa it shows me 2 files as modified when i havent actually modified them?
16:16:44 <andrea_pat> dkayiwa, git reset --hard master and refresh in Eclipse brought back old code - now doing mvn clean install
16:17:12 <dkayiwa> sara__: that should be the automatic formatting which happened when you did run maven. Can you commit and i have a look at them?
16:18:22 <dkayiwa> andrea_pat: how about? git pull reset --hard upstream/master
16:18:25 <sara__> @dkayiwa modified: api/src/main/java/org/openmrs/api/db/hibernate/HibernatePati entDAO.java # modified: api/src/test/java/org/openmrs/api/db/hibernate/HibernatePati entDAOTest.java
16:18:38 <dkayiwa> sara__: commit and i have a look
16:18:55 <andrea_pat> dkayiwa, will do that too
16:19:09 <sara__> @dkayiwa these are the same files which i had earlier committed by mistake
16:19:33 <dkayiwa> sara__: just commit what is in there now and i have a look
16:19:45 <andrea_pat> dkayiwa, you mean git pull --rebase upstream/master right?
16:19:47 <sara__> okay
16:20:07 <dkayiwa> andrea_pat: you can try that too
16:21:00 <andrea_pat> dkayiwa, which one is best - getting confusing
16:21:45 <dkayiwa> andrea_pat: am not yet a git expert. so try and we learn from what happens :)
16:23:33 <andrea_pat> dkayiwa, $ git pull --rebase upstream master From https://github.com/openmrs/openmrs-core * branch master -> FETCH_HEAD Current branch TRUNK-3289a is up to date.
16:23:53 <sara__> @dkayiwa committed at https://github.com/saramirza14/openmrs-core/commit/565dec0320540531a41654ca1977aa483249ab26
16:23:58 <OpenMRSBot> <http://ln-s.net/+oys> (at github.com)
16:24:13 <andrea_pat> dkayiwa, this looks ok, doesn't it?
16:24:25 <dkayiwa> andrea_pat: ok now: git reset --hard upstream/master
16:24:37 <dkayiwa> sara__: looking at it now
16:24:53 <sara__> @dkayiwa thanks!
16:26:02 <andrea_pat> dkayiwa, can you see my desktop? disn't like that last command
16:27:07 <andrea_pat> dkayiwa, actually I think it's ok
16:27:32 *** suranga has joined #openmrs
16:27:32 *** ChanServ sets mode: +v suranga
16:28:06 <andrea_pat> dkayiwa, $ git reset --hard upstream/master HEAD is now at 878bd36 Merge pull request #167 from gsluthra/TRUNK-2517
16:28:19 <andrea_pat> dkayiwa, what do you think?
16:29:13 <dkayiwa> andrea_pat: do you still see your changes
16:30:09 <djazayeri> hi all
16:32:03 <dkayiwa> djazayeri: hi
16:32:03 <andrea_pat> dkayiwa, no old code is there
16:32:15 <dkayiwa> andrea_pat: so it worked
16:32:27 <andrea_pat> dkayiwa, yes
16:32:41 <dkayiwa> andrea_pat: so which one worked? :)
16:32:57 <andrea_pat> djazayeri: hi - how is Mirebelais going?
16:33:29 <djazayeri> andrea_pat: well. we're all pretty tired though. :-)
16:33:58 <djazayeri> andrea_pat: they should be seeing patients this week; I'm working on reports...
16:34:42 <andrea_pat> djazayeri: great! very exciting!
16:34:58 <andrea_pat> dkayiwa, I think they both worked
16:35:09 <dkayiwa> andrea_pat: oh
16:35:27 <andrea_pat> dkayiwa, now mvn clean install again?
16:35:30 *** h3llborn has joined #openmrs
16:35:45 <dkayiwa> andrea_pat: yes
16:35:59 <andrea_pat> dkayiwa, ok will do
16:45:42 <andrea_pat> dkayiwa, clean install done - Build Success
16:46:12 <andrea_pat> dkayiwa, now put my changes back in?
16:46:18 <dkayiwa> andrea_pat: yes
16:47:14 <andrea_pat> dkayiwa, ok
16:48:55 *** barry has quit IRC
16:53:10 *** dmulindwa has quit IRC
16:56:58 *** GitHub152 has joined #openmrs
16:56:58 <GitHub152> [openmrs-core] dkayiwa pushed 1 new commit to master: http://git.io/loWbTA
16:56:58 <GitHub152> openmrs-core/master a7895e1 dkayiwa: Response to review comments for: Address layout management is mislabeled...
16:56:58 *** GitHub152 has left #openmrs
16:58:11 <wyclif_> hi dkayiwa
16:58:22 <wyclif_> dkayiwa, is the standalone mavenized
16:58:23 <dkayiwa> wyclif_: hi
16:58:27 <dkayiwa> wyclif_: yes
16:59:29 <wyclif_> dkayiwa, sorry, i meant to ask if it was moved to github
16:59:37 <dkayiwa> wyclif_: no
17:01:45 *** GitHub11 has joined #openmrs
17:01:45 <GitHub11> [openmrs-core] dkayiwa pushed 1 new commit to 1.9.x: http://git.io/FKV2xA
17:01:45 <GitHub11> openmrs-core/1.9.x 8b270f2 dkayiwa: Response to review comments for: Address layout management is mislabeled...
17:01:45 *** GitHub11 has left #openmrs
17:01:58 <andrea_pat> dkayiwa, Compile error in OrderServiceTest: The method purgeOrder(Order) in the type OrderService is not applicable for the arguments(Order, boolean) on this line Context.getOrderService().purgeOrder(ord, true);
17:02:40 <andrea_pat> dkayiwa, this is in my new test - need to set boolean to true to call my code
17:03:31 <dkayiwa> andrea_pat: that is after you put in your changes?
17:03:43 *** shangxiao has quit IRC
17:04:30 <andrea_pat> dkayiwa, yes - in my new test
17:04:56 <andrea_pat> dkayiwa, the method purgeOrder is overloaded
17:05:14 <dkayiwa> andrea_pat: can you commit your changes and i have a look at them?
17:05:37 <dkayiwa> sara__: hi
17:05:40 <andrea_pat> dkayiwa, there is purgeOrder(Order) and pyrgeOrder(Order, boolean)
17:05:52 <andrea_pat> dkayiwa - yes
17:10:25 *** travis-ci has joined #openmrs
17:10:25 <travis-ci> [travis-ci] [openmrs/openmrs-core] [a7895e1] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/5476807
17:10:25 *** travis-ci has left #openmrs
17:10:30 <OpenMRSBot> <http://ln-s.net/+p0A> (at travis-ci.org)
17:10:36 <andrea_pat> dkayiwa: $ git log commit 558454855234c20c11651ad33f9d75bb69c08768 Author: andreapat <apattson@earthlink.net> Date: Wed Mar 13 10:08:56 2013 -0700 TRUNK-3289a add new method deleteObsThatReference(Order order)
17:11:24 <dkayiwa> andrea_pat: can you give me the commit url?
17:11:45 <andrea_pat> dkayiwa, how do I find that?
17:11:56 <dkayiwa> andrea_pat: did you push?
17:12:09 <andrea_pat> dkayiwa, whoops - hang on
17:12:18 *** shangxiao has joined #openmrs
17:13:46 <shangxiao> burke?
17:14:14 <andrea_pat> dkayiwa: $ git push Username for 'https://github.com': Password for 'https://andreapat@github.com': Counting objects: 228, done. Delta compression using up to 4 threads. Compressing objects: 100% (64/64), done. Writing objects: 100% (141/141), 24.10 KiB, done. Total 141 (delta 75), reused 126 (delta 66) To https://github.com/andreapat/openmrs-core-1.git fe98f3a..8ca961e TRUNK-3289 -> TRUNK-3289 b6b58e5..d098d4d master -
17:14:25 *** harshadura_ has joined #openmrs
17:14:46 <andrea_pat> dkayiwa, so how do I find commit url?
17:15:32 <dkayiwa> andrea_pat: whats the branch name
17:15:33 *** shangxiao has quit IRC
17:16:03 <andrea_pat> dkayiwa, TRUNK-3289a
17:16:09 *** shangxiao has joined #openmrs
17:16:45 <dkayiwa> andrea_pat: did you push the branch?
17:16:50 *** harshadura has quit IRC
17:17:00 *** shangxiao has joined #openmrs
17:17:25 *** harshadura_ is now known as harshadura
17:17:41 <andrea_pat> dkayiwa, git says I am on branch TRUNK-3289a - I just did git push
17:18:01 <dkayiwa> andrea_pat: did you git push origin branchname?
17:18:59 <andrea_pat> dkayiwa, no thought git push was what I needed to do
17:19:23 *** shangxiao has quit IRC
17:19:26 *** k-joseph has joined #openmrs
17:19:37 <andrea_pat> dkayiwa, aahh I see - usually do that before checkout - will do
17:21:29 *** h3llborn has quit IRC
17:21:30 <andrea_pat> dkayiwa, $ git push origin TRUNK-3289a Username for 'https://github.com': Password for 'https://andreapat@github.com': Counting objects: 49, done. Delta compression using up to 4 threads. Compressing objects: 100% (23/23), done. Writing objects: 100% (27/27), 4.87 KiB, done. Total 27 (delta 14), reused 0 (delta 0) To https://github.com/andreapat/openmrs-core-1.git * [new branch] TRUNK-3289a -> TRUNK-3289a
17:22:01 <andrea_pat> dkayiwa, still don't know how to find url of commit
17:22:39 *** dmulindwa has joined #openmrs
17:24:56 <dkayiwa> andrea_pat: just click that url https://github.com/andreapat/openmrs-core-1.git
17:25:29 <dkayiwa> andrea_pat: then under branch, click the drop down and select the branch name
17:25:41 <dkayiwa> andrea_pat: try it and you will see what you have committed
17:27:09 <andrea_pat> dkayiwa: https://github.com/andreapat/openmrs-core-1/commits/TRUNK-3289a
17:27:16 <downey> djazayeri: FYI https://wiki.openmrs.org/pages/viewpage.action?pageId=37946424
17:27:21 <OpenMRSBot> <http://ln-s.net/+p0Y> (at github.com)
17:27:21 <andrea_pat> dkayiwa, is that right?
17:27:54 <dkayiwa> andrea_pat: you can select the actual commit which is: https://github.com/andreapat/openmrs-core-1/commit/558454855234c20c11651ad33f9d75bb69c08768
17:27:56 <OpenMRSBot> <http://ln-s.net/+p0a> (at github.com)
17:28:43 <andrea_pat> dkayiwa: ok thanks!
17:29:36 <dkayiwa> andrea_pat: is what you have committed the one that has a compiler error?
17:30:30 <andrea_pat> dkayiwa, yes error is in OrderServiceTest.java
17:30:59 <dkayiwa> andrea_pat: in which method?
17:31:06 <andrea_pat> dkayiwa: OrderService test line 596
17:31:36 <dkayiwa> andrea_pat: and what is the error message?
17:31:41 <sara__> @dkayiwa hi
17:31:42 <andrea_pat> dkayiwa: purgeOrder_shouldDeleteObsThatReference()
17:32:13 <dkayiwa> sara__: can you create a separate pull request for the formatting changes?
17:32:14 <andrea_pat> dkayiwa: The method purgeOrder(Order) in the type OrderService is not applicable for the arguments(Order, boolean)
17:32:28 <dkayiwa> sara__: the formatting that happens before you change anything
17:33:08 <sara__> @dkayiwa i didnt get u?
17:33:11 <dkayiwa> andrea_pat: because there is none that takes two arguments
17:33:24 <dkayiwa> andrea_pat: there is only one and which takes only Order
17:33:37 <dkayiwa> andrea_pat: with no boolean that you have specified as the second argument
17:34:00 <dkayiwa> sara__: can you create a separate pull request that has the formatting changes you committed?
17:34:28 <dkayiwa> sara__: that way the pull request for the ticket changes will also be a different ones that has exactly what you actually changed
17:34:34 <andrea_pat> dkayiwa: In OrderServiceImpl - public void purgeOrder(Order order, boolean cascade)
17:34:51 <sara__> @dkayiwa okay, but how will that help?
17:35:12 <andrea_pat> dkayiwa, method is overloaded and I need to set cascade to true to call my new method
17:35:23 <dkayiwa> andrea_pat: Context.getOrderService() is OrderService not OrderServiceImpl
17:35:42 <dkayiwa> andrea_pat: do you see the difference?
17:35:52 <sara__> @dkayiwa okay i will create a new pull request
17:35:58 <dkayiwa> andrea_pat: one is a public interface while the other is a private implementation
17:36:40 <dkayiwa> sara__: when i will be reviewing and merging the pull request, i will deal with only the changes that you have actually made, without the formatting issue
17:37:44 <dkayiwa> andrea_pat: so you will call only methods on the interface. not the concrete implementing class
17:37:49 <dkayiwa> andrea_pat: does that make sense?
17:37:54 <andrea_pat> dkayiwa, I understand - but how do I set cascade to true?
17:38:21 <dkayiwa> andrea_pat: you will need to create a new method in the interface, which has that extra boolean parameter
17:38:22 <sara__> @dkayiwa okay so what u mean is that TRUNK-3811 will have only the changes relevant to the ticket(ignoring the formatting issue) and another new pull request will address the formatting thing?
17:38:36 <dkayiwa> sara__: perfect
17:38:44 <sara__> :)
17:38:47 <dkayiwa> sara__: where the formatting pull request is the first
17:38:50 <dkayiwa> :)
17:39:20 <sara__> formatting pull request first meaning?
17:39:47 <andrea_pat> dkayiwa, ok - didn't know I could do that
17:39:56 <dkayiwa> sara__: ok just do a pull request
17:39:58 <dkayiwa> :)
17:40:06 <sara__> a new pull request!
17:40:08 <dkayiwa> sara__: two separate ones
17:40:20 <dkayiwa> sara__: one for formatting, the other for your changes
17:40:22 <sara__> both new?
17:40:25 <andrea_pat> dkayiwa, but I remember Darius saying he didn't want changes to the service
17:40:40 <dkayiwa> sara__: i do not mind as long as they are two separate ones :)
17:40:50 <sara__> @dkayiwa okay!
17:40:58 <djazayeri> sara__, dkayiwa what ticket?
17:40:59 <dkayiwa> andrea_pat: yes because the method should be in the DAO
17:41:08 <andrea_pat> dkayiwa, that's why I put new method in HibernateOrderDAO -
17:41:15 <dkayiwa> andrea_pat: where the error is happening you are not calling the DAO
17:41:20 <dkayiwa> andrea_pat: you are calling the service
17:41:30 <dkayiwa> sara__: can you give Darius the ticket number
17:41:43 <sara__> @djazayeri TRUNK 3811
17:41:57 <djazayeri> oh, sorry, I got mixed up, I read andrea_pat 's comment as being from sara__
17:41:59 <djazayeri> never mind
17:43:16 <dkayiwa> andrea_pat: can you give Darius the ticket number
17:43:23 <andrea_pat> dkayiwa, yes I understand - so is it ok to put new method OrderService?
17:43:36 <dkayiwa> andrea_pat: No
17:43:45 <dkayiwa> andrea_pat: only in the DAO
17:43:54 *** h3llborn has joined #openmrs
17:44:21 *** kishoreyekkanti has joined #openmrs
17:44:38 <dkayiwa> andrea_pat: in your unit test, you should call Context.getOrderService().purgeOrder(ord) instead of Context.getOrderService().purgeOrder(ord, true);
17:45:00 <andrea_pat> djazayeri, https://tickets.openmrs.org/browse/TRUNK-3289
17:45:27 *** ekow has joined #openmrs
17:45:42 <dkayiwa> andrea_pat: then in OrderServiceImpl, you call the DAO with a true cascade parameter
17:45:43 <andrea_pat> djazayeri: we've discussed this - do you see converstion between dkayiwa and I?
17:47:06 <ekow> @wyclif <logic 0.5.2 error> where do I find the property line to set to true. In which file? Please ?\.
17:47:33 <djazayeri> andrea_pat, dkayiwa : summarize the question please...
17:47:56 <dkayiwa> djazayeri: i have no question for you :)
17:48:33 <djazayeri> okay... dkayiwa , this comment seems wrong
17:48:33 <djazayeri> andrea_pat: in your unit test, you should call Context.getOrderService().purgeOrder(ord) instead of Context.getOrderService().purgeOrder(ord, true);
17:48:36 <andrea_pat> dkayiwa, See line 116 - I am calling new method when cascade is true
17:49:27 <dkayiwa> andrea_pat: 116 in which file?
17:50:04 <andrea_pat> dkayiwa: OrderServiceImpl.java
17:51:21 <dkayiwa> andrea_pat: what is the new method name?
17:52:29 <dkayiwa> andrea_pat: you do not need the cascade parameter in OrderServiceImpl
17:53:01 <andrea_pat> dkayiwa: deleteObsThatReference(Order order)
17:53:01 <ekow> Wyclif ...are you there?
17:53:26 <dkayiwa> andrea_pat: you do not need the cascade parameter
17:53:40 <djazayeri> dkayiwa: isn't the cascade parameter part of our API definition?
17:54:03 <andrea_pat> dkayiwa, something I saw made me think cascade was set to false -
17:54:30 <djazayeri> dkayiwa: doesn't every XyzService.purgeXyz(Xyz) also have a purgeXyz(Xyz, boolean)
17:54:35 <ekow> logic v0.5.2 error . Where is the the property file to change to true ...anyone?
17:55:00 <dkayiwa> djazayeri: not for purgeOrder
17:56:13 <djazayeri> dkayiwa: but we should add it if it isn't there
17:56:27 <djazayeri> dkayiwa: every purge(xyz) should also have purge(xyz, boolean cascade)
17:56:48 <dkayiwa> andrea_pat: djazayeri says you can add the method that takes the second boolean parameter to the interface
17:57:09 <andrea_pat> dkayiwa, djazayeri: ok will do!
17:59:06 <andrea_pat> dkayiwa, thank you so much! I need to run out for a short time
17:59:13 *** h3llborn has quit IRC
17:59:14 <dkayiwa> andrea_pat: ok
17:59:41 <ekow> Guys, which file contain the method "AdministrationService.saveGlobalproperty" please Darius...anyone !!
18:00:21 <dkayiwa> ekow: AdministrationService.java
18:00:43 <andrea_pat> dkayiwa, will add method and be in touch later - probably you will need to go. right?
18:00:58 <dkayiwa> andrea_pat: for the design call :)
18:01:38 <andrea_pat> dkayiwa, I almost forgot - thank you - guess I'm not going anywhere yet
18:01:57 <dkayiwa> andrea_pat: atleast not for the next two hours :)
18:02:26 *** kiruR has joined #openmrs
18:06:26 <dkayiwa> andrea_pat: you are free to go. pushed to next week :)
18:06:53 *** Hasintha_i has quit IRC
18:07:59 *** GitHub24 has joined #openmrs
18:07:59 <GitHub24> [openmrs-core] saramirza14 opened pull request #247: Solving Formatting Issues (master...FORMAT-3811) http://git.io/j2kOQg
18:07:59 *** GitHub24 has left #openmrs
18:08:44 <sara__> @dkayiwa new pull request with only formatting issues! https://github.com/openmrs/openmrs-core/pull/247
18:08:49 <OpenMRSBot> <http://ln-s.net/+p1Q> (at github.com)
18:08:51 <dkayiwa> sara__: yes seen it :0
18:08:53 <dkayiwa> :)
18:12:11 <sara__> @dkayiwa the other pull request regarding the ticket (ignoring formatting) is also on the way! :)
18:12:16 *** kiruR has quit IRC
18:13:26 <dkayiwa> sara__: looking forward to seeing it :)
18:13:35 <sara__> :)
18:19:02 *** dmulindwa has quit IRC
18:19:11 *** nribeka has quit IRC
18:26:48 <sara__> @dkayiwa pull request with only changes relavent to the ticket https://github.com/saramirza14/openmrs-core/commit/a3959ec9d89fd68271800dd7ac4879e192dd8fab
18:26:53 <OpenMRSBot> <http://ln-s.net/+p1z> (at github.com)
18:27:02 <dkayiwa> sara__: ok
18:27:56 *** jkeiper has quit IRC
18:28:07 *** djazayeri has quit IRC
18:28:18 <dkayiwa> sara__: include both pull requests on the ticket
18:28:27 <sara__> @dkayiwa okay!
18:28:41 *** downey has quit IRC
18:30:07 <sara__> @dkayiwa included both pull requests on the ticket
18:30:15 <dkayiwa> sara__: ok
18:31:32 *** Jeff_Norris has joined #openmrs
18:34:14 *** k-joseph_ has joined #openmrs
18:35:08 *** k-joseph has quit IRC
18:42:17 *** harsz89 has quit IRC
18:50:11 *** h3llborn has joined #openmrs
19:07:16 <k-joseph_> dkayiwa: hi
19:07:25 *** k-joseph_ is now known as k-joseph
19:07:25 <dkayiwa> k-joseph_: hi
19:08:05 <k-joseph> dkayiwa: i think i have cleared that up
19:08:18 <dkayiwa> k-joseph: ok good
19:14:38 *** andrea_pat has quit IRC
19:16:09 *** dkayiwa has quit IRC
19:18:44 *** kishoreyekkanti has quit IRC
19:19:22 *** kmithemanth has quit IRC
19:24:15 <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: App Framework Module 1.5 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=appframework&ampversion=&amp1.5>
19:31:41 <cpower> mseaton: you there?
19:35:02 *** sara__ has quit IRC
19:35:43 <mseaton> cpower: hey
19:47:48 *** k-joseph has quit IRC
19:49:30 *** r0bby_ has joined #openmrs
19:49:30 *** ChanServ sets mode: +v r0bby_
19:59:05 *** wyclif has joined #openmrs
19:59:05 *** wyclif_ has quit IRC
20:03:35 *** k-joseph has joined #openmrs
20:03:56 *** wyclif has quit IRC
20:04:26 *** wyclif has joined #openmrs
20:07:32 *** Jeff_Norris has quit IRC
20:07:37 *** andreapat has joined #openmrs
20:20:05 *** nribeka has joined #openmrs
20:20:05 *** ChanServ sets mode: +v nribeka
20:20:47 <andreapat> wyclif, am indeed getting sql error - you around?
20:24:49 *** djazayeri has joined #openmrs
20:24:52 *** jkeiper has joined #openmrs
20:24:52 *** ChanServ sets mode: +v jkeiper
20:25:48 <wyclif> hi andreapat
20:26:00 <andreapat> wyclif: hi
20:26:14 <wyclif> can you add a pastebin with the error logs
20:26:19 <wyclif> andreapat, can you add a pastebin with the error logs
20:26:27 <andreapat> wyclif, will do
20:27:58 <andreapat> wyclif: http://pastebin.com/siLJSRn1
20:29:04 *** downey has joined #openmrs
20:29:04 *** ChanServ sets mode: +o downey
20:29:25 *** Echidna has quit IRC
20:30:43 *** wyclif_ has joined #openmrs
20:37:46 <andreapat> wyclif_: think I might have bind variable and method variable reversed
20:37:59 <k-joseph> dkayiwa: hi
20:38:52 <k-joseph> :-p
20:40:51 <andreapat> wyclif: did you see my last message?
20:41:19 *** dimuthuupe has quit IRC
20:50:23 <andreapat> wyclif, you still here?
20:50:39 <wyclif> andreapat, let me check
20:50:51 <andreapat> wyclif, ok
20:52:16 <wyclif> andreapat, your colum n name is wrong in the query
20:52:56 <wyclif> andreapat, is your query a sql query, hql or criteria object?
20:54:08 <andreapat> wyclif, hql - hqldelete - was afraid I may be reversing names - how about if I paste method?
20:54:24 <wyclif> andreapat, sure
20:55:45 <andreapat> wyclif, http://pastebin.com/f6nwxAPv
20:56:03 <wyclif> andreapat, you always have to use look at the stacktrance and look for the 'Caused by:' for the actual cause of the problem, in those logs it is clearly saying you using a wrong column name
20:57:44 *** Echidna has joined #openmrs
20:57:44 *** ChanServ sets mode: +v Echidna
21:00:39 <andreapat> wyclif, yes see that
21:01:08 *** suranga has quit IRC
21:01:32 <wyclif> andreapat, in your code you are mixing up hql and sql which is wrong
21:02:29 <andreapat> wyclif: looking at this documentayion: http://docs.jboss.org/hibernate/orm/3.3/reference/en-US/html/batch.html#batch-direct
21:02:30 <OpenMRSBot> <http://ln-s.net/+muM> (at docs.jboss.org)
21:02:51 <andreapat> wyclif: under hqlDelete
21:03:24 <wyclif> andreapat, in your code you are mixing up hql and sql which is wrong
21:03:31 *** k-joseph has quit IRC
21:04:38 <andreapat> wyclif: Was following example in above doc for hqlDelete
21:06:38 <wyclif> andreapat, first of ll don't open session otherwise that will create obscure bugs, you want things to happen in the same session and transaction
21:06:42 <wyclif> andreapat, secondly
21:08:21 <wyclif> try to always copy code in core rather than from anywhere, the reason in that example he does open a session and transaction is because he assumes there is none open but in our code there is always one that was created by spring when the request came in
21:08:54 <wyclif> andreapat, and now to fix the issue
21:09:35 <andreapat> wyclif, ok
21:09:36 <wyclif> hibernate is an object relational tool meaning you reference things as java objects
21:09:46 <wyclif> andreapat, hibernate is an object relational tool meaning you reference things as java objects
21:10:24 <wyclif> andreapat, so in your query you need to do obs.order because order is the property name in obs class
21:11:56 <andreapat> wyclif, yes this is confusing - the order class is part of the obs class - yet when you look in Obs table - it is just orderid
21:12:38 <wyclif> andreapat, as i said with hibernate think of things as java classes and not db tables
21:13:03 <wyclif> andreapat, which means dont look in the DB and instead look at the java class
21:13:13 <andreapat> wyclif, yes but still confused on what query should be
21:13:29 <wyclif> andreapat, in the class obs and order and associated via the order property and that is what you need to use and not orderId
21:14:13 <wyclif> andreapat, the property in Obs class that is linked to Order is named order and not orderId, does this make sense?
21:16:30 <andreapat> wyclif, sort of - so how do I create obs for obs.order? Is there an example in core code?
21:16:35 <wyclif> see HibernateConceptDAO.deleteConceptWord(Concept), you need to copy that
21:16:52 <andreapat> wyclif, ok thanks
21:17:22 <wyclif> andreapat, basically you have to replace orderId with order in your query
21:18:12 <andreapat> wyclif, I understand - again was following example Darius pointed me to
21:19:22 <wyclif> andreapat, and get rid of that code that begins a transaction and session and just fetch the current session from the sessionFactory object like in the core code i have pointed you to
21:19:42 <andreapat> wyclif, ok!
21:31:27 *** dmulindwa has joined #openmrs
21:38:50 <wyclif> hi mseaton
21:38:56 <wyclif> hi djazayeri
21:39:19 <wyclif> mseaton, djazayeri, we dropped logic as a core module right
21:39:44 <djazayeri> wyclif: we're planning to...
21:40:10 <djazayeri> wyclif: I don't know if it has already been dropped in 1.10 or not
21:40:20 <wyclif> djazayeri, am working on that ticket for excluding module tables in demo data, so i should leave the tables if it is a core module
21:40:23 <djazayeri> wyclif: it's still in 1.9
21:40:57 <djazayeri> wyclif: if you drop the tables, logic will re-create them, right?
21:41:06 <djazayeri> wyclif: so just drop them
21:41:52 <wyclif> djazayeri, thr problem is that the liquibasechangelog entries will stay in the db meaning one might not be able to run module changesets succefully if they were already run in the demo data
21:42:22 <djazayeri> wyclif: can't you delete those?
21:42:50 <djazayeri> wyclif: those rows, I mean
21:43:56 <andreapat> wyclif, in HibernateConceptDAO.deleteConceptWord line 759 - what is c? Cannot find where c is coming from.
21:47:07 *** wyclif has quit IRC
21:47:07 *** wyclif_ is now known as wyclif
21:52:42 <andreapat> wyclif , one more - if I use obs.order how do I create obs?
22:17:01 <h3llborn> lalalala
22:22:54 *** dmulindwa has quit IRC
22:24:08 *** dmulindwa has joined #openmrs
22:30:18 *** dmulindwa has quit IRC
22:38:14 *** r0bby_ is now known as robbyoconnor
22:40:16 *** wyclif_ has joined #openmrs
22:43:29 <robbyoconnor> hey h3llborn
22:43:35 <robbyoconnor> how are you?
22:43:39 <h3llborn> pretty good man hbu?
22:53:40 *** robbyoconnor has quit IRC
23:02:00 *** robbyoconnor has joined #openmrs
23:02:00 *** ChanServ sets mode: +v robbyoconnor
23:02:55 <h3llborn> robbyoconnor: wb
23:10:49 *** robbyoconnor has quit IRC
23:19:22 <andreapat> resting
23:19:39 <andreapat> testing
23:20:46 <djazayeri> I see your messages.
23:37:11 <h3llborn> lol
23:50:11 <andreapat> djazayeri, just trying to find out if I'd been disconnected - it happens