00:02:30
|
*** sunbiz has quit IRC
|
00:07:13
|
*** Anuruddha has joined #openmrs
|
00:15:36
|
*** GitHub104 has joined #openmrs
|
00:15:36
|
<GitHub104> [openmrs-core] wluyima pushed 1 new commit to master: http://git.io/RiF3DA
|
00:15:36
|
<GitHub104> openmrs-core/master 4594353 wluyima: Manage Providers spinning status wheel turns before entering search...
|
00:15:36
|
*** GitHub104 has left #openmrs
|
00:20:27
|
*** GitHub97 has joined #openmrs
|
00:20:27
|
<GitHub97> [openmrs-core] wluyima pushed 1 new commit to 1.9.x: http://git.io/myeUmA
|
00:20:27
|
<GitHub97> openmrs-core/1.9.x 059c287 wluyima: Manage Providers spinning status wheel turns before entering search...
|
00:20:27
|
*** GitHub97 has left #openmrs
|
00:32:29
|
*** travis-ci has joined #openmrs
|
00:32:29
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [4594353] [wluyima] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/5300997
|
00:32:29
|
*** travis-ci has left #openmrs
|
00:32:34
|
<OpenMRSBot> <http://ln-s.net/+mU4> (at travis-ci.org)
|
01:29:44
|
*** harsz89 has quit IRC
|
01:36:44
|
*** tbharath has joined #openmrs
|
01:37:36
|
<tbharath> djazayeri, when I ran maven install using eclipse , I got this error http://pastebin.mozilla.org/2199514 , can you help from this?
|
01:38:48
|
<djazayeri1> tbharath: just wait for the build to finish. These are not test failures...
|
01:39:13
|
<djazayeri1> tbharath: they're bad-style logging of error messages during the build, but the tests are passing, at least in wha you sent
|
01:40:38
|
<tbharath> djazayeri, sorry I haven't paste the full trace here is my full trace http://pastebin.mozilla.org/2199521
|
01:40:48
|
<tbharath> djazayeri, it says build failure
|
01:41:04
|
<djazayeri1> tbharath: that paste is also cut off
|
01:41:11
|
<tbharath> djazayeri, yeah
|
01:42:03
|
<tbharath> djazayeri, ok after the download here is remaining section http://pastebin.mozilla.org/2199531
|
01:42:51
|
<djazayeri1> tbharath: oh, I've seen this before. I think it might have something to do with different maven default behaviors on different versions/platforms
|
01:42:54
|
<djazayeri1> tbharath: the key part is:
|
01:42:55
|
<djazayeri1> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-surefire-plugin:2.5:test (default-test) on project openmrs-release-test: No tests were executed! (Set -DfailIfNoTests=false to ignore this error.) -> [Help 1]
|
01:43:16
|
<djazayeri1> tbharath: if you set that -DfailIfNoTests=false flag, it should build right.
|
01:44:10
|
<tbharath> djazayeri, I have n't installed maven on my machine , will plugin be sufficient for this?
|
01:44:27
|
<djazayeri1> tbharath: there must be a way to set that flag via the eclipse plugin...
|
01:46:10
|
<djazayeri1> tbharath: but I don't know how, and can't check, as I use intellij
|
01:53:54
|
*** harshadura has joined #openmrs
|
02:13:45
|
*** GitHub106 has joined #openmrs
|
02:13:45
|
<GitHub106> [openmrs-core] wluyima pushed 1 new commit to master: http://git.io/5wOzCA
|
02:13:45
|
<GitHub106> openmrs-core/master 15b9e84 wluyima: Updated obs did not get displayed correctly on dashboard - TRUNK-3609...
|
02:13:45
|
*** GitHub106 has left #openmrs
|
02:17:56
|
<tbharath> djazayeri, I ran maven clean and then maven install now it gave build success
|
02:18:10
|
<djazayeri1> tbharath: great!
|
02:24:17
|
*** GitHub97 has joined #openmrs
|
02:24:17
|
<GitHub97> [openmrs-core] wluyima pushed 1 new commit to 1.9.x: http://git.io/Pj2pAQ
|
02:24:17
|
<GitHub97> openmrs-core/1.9.x 63d84ba wluyima: Updated obs did not get displayed correctly on dashboard - TRUNK-3609
|
02:24:17
|
*** GitHub97 has left #openmrs
|
02:31:28
|
<tbharath> djazayeri, the next step in https://wiki.openmrs.org/display/docs/Step+By+Step+Developer+Setup+Guide+%28Linux%29
|
02:31:29
|
<OpenMRSBot> <http://ln-s.net/8t1q> (at wiki.openmrs.org)
|
02:31:41
|
<tbharath> djazayeri, but I can't find maven build there
|
02:32:58
|
<djazayeri1> tbharath: I would not use that wiki page
|
02:33:13
|
<djazayeri1> tbharath: at least I don't think so.
|
02:33:45
|
<djazayeri1> tbharath: you should be able to get things running using the standard (non-OS-specific) instructions on linux too, as far as I know...
|
02:34:31
|
*** GitHub48 has joined #openmrs
|
02:34:31
|
<GitHub48> [openmrs-core] wluyima pushed 1 new commit to 1.8.x: http://git.io/6Q6dFA
|
02:34:31
|
<GitHub48> openmrs-core/1.8.x 3f05e81 wluyima: Updated obs did not get displayed correctly on dashboard - TRUNK-3609
|
02:34:31
|
*** GitHub48 has left #openmrs
|
02:40:46
|
*** GitHub58 has joined #openmrs
|
02:40:46
|
<GitHub58> [openmrs-core] wluyima pushed 1 new commit to 1.8.x: http://git.io/NyL97g
|
02:40:46
|
<GitHub58> openmrs-core/1.8.x 35ff9d9 wluyima: Fixed @since value - TRUNK-3609
|
02:40:46
|
*** GitHub58 has left #openmrs
|
02:42:51
|
*** GitHub185 has joined #openmrs
|
02:42:51
|
<GitHub185> [openmrs-core] wluyima pushed 1 new commit to 1.9.x: http://git.io/Gvlfmw
|
02:42:51
|
<GitHub185> openmrs-core/1.9.x 8928bd8 wluyima: Fixed @since value for drug.displayName - TRUNK-3609
|
02:42:51
|
*** GitHub185 has left #openmrs
|
02:44:29
|
*** GitHub172 has joined #openmrs
|
02:44:29
|
<GitHub172> [openmrs-core] wluyima pushed 1 new commit to master: http://git.io/0lbClQ
|
02:44:29
|
<GitHub172> openmrs-core/master 41994b3 wluyima: Fixed @since value for drug.displayName - TRUNK-3609
|
02:44:29
|
*** GitHub172 has left #openmrs
|
02:44:34
|
*** tbharath has quit IRC
|
02:51:53
|
*** travis-ci has joined #openmrs
|
02:51:53
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [15b9e84] [wluyima] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/5302826
|
02:51:53
|
*** travis-ci has left #openmrs
|
02:51:59
|
<OpenMRSBot> <http://ln-s.net/+mVp> (at travis-ci.org)
|
02:57:15
|
*** wyclif_ has quit IRC
|
02:59:19
|
*** travis-ci has joined #openmrs
|
02:59:19
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [41994b3] [wluyima] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/5303189
|
02:59:19
|
*** travis-ci has left #openmrs
|
02:59:24
|
<OpenMRSBot> <http://ln-s.net/+mVw> (at travis-ci.org)
|
03:02:44
|
*** robbyoconnor has joined #openmrs
|
03:02:44
|
*** ChanServ sets mode: +v robbyoconnor
|
03:07:01
|
*** zzz_jb360 is now known as jb360
|
03:07:45
|
*** robbyoconnor has quit IRC
|
03:35:56
|
*** Anuruddha has quit IRC
|
03:36:52
|
*** wyclif_ has joined #openmrs
|
03:42:02
|
*** andreap has quit IRC
|
03:50:23
|
*** mseaton has quit IRC
|
04:44:16
|
*** robbyoconnor has joined #openmrs
|
04:44:16
|
*** ChanServ sets mode: +v robbyoconnor
|
04:46:49
|
*** harshadura_ has joined #openmrs
|
05:15:16
|
*** jb360 is now known as zzz_jb360
|
05:17:22
|
*** lh has quit IRC
|
05:17:23
|
*** djazayeri1 has quit IRC
|
05:26:50
|
*** dmulindwa has joined #openmrs
|
05:32:27
|
*** djazayeri1 has joined #openmrs
|
05:51:42
|
*** harshadura_ has quit IRC
|
06:13:25
|
*** Hasintha_i has joined #openmrs
|
06:25:09
|
*** harshadura_ has joined #openmrs
|
06:33:20
|
*** djazayeri1 has quit IRC
|
06:36:05
|
*** shortend has joined #openmrs
|
06:51:15
|
*** Boniface has joined #openmrs
|
06:53:02
|
<Boniface> +nribeka hi ?
|
07:02:00
|
*** Boniface has quit IRC
|
07:09:53
|
*** harshadura_ has quit IRC
|
07:15:31
|
*** harshadura_ has joined #openmrs
|
07:29:33
|
*** dmulindwa has quit IRC
|
07:39:48
|
*** dkayiwa has joined #openmrs
|
07:43:14
|
*** dkayiwa has quit IRC
|
07:44:45
|
*** dkayiwa has joined #openmrs
|
08:55:11
|
*** dkayiwa_ has joined #openmrs
|
08:57:05
|
*** dkayiwa has quit IRC
|
08:57:05
|
*** dkayiwa_ is now known as dkayiwa
|
09:04:50
|
*** Hasintha_i has quit IRC
|
09:17:32
|
*** robbyoconnor has quit IRC
|
09:17:57
|
*** robbyoconnor has joined #openmrs
|
09:17:57
|
*** ChanServ sets mode: +v robbyoconnor
|
09:31:21
|
*** kishoreyekkanti has joined #openmrs
|
09:32:27
|
*** Hasintha_i has joined #openmrs
|
09:43:30
|
*** rkorytkowski has joined #openmrs
|
09:43:30
|
*** rkorytkowski is now known as rafa
|
09:43:30
|
*** ChanServ sets mode: +v rafa
|
09:49:12
|
*** harshadura_ has quit IRC
|
09:53:19
|
*** harshadura_ has joined #openmrs
|
09:58:04
|
*** k-joseph has joined #openmrs
|
09:58:16
|
*** dkayiwa has quit IRC
|
09:58:37
|
*** dkayiwa has joined #openmrs
|
10:12:16
|
<k-joseph> dkayiwa: hi
|
10:12:25
|
<dkayiwa> k-joseph: hi
|
10:13:34
|
<k-joseph> dkayiwa: i will inform you how it will go after this time, it may take me some time since am on utl, now
|
10:14:11
|
<dkayiwa> k-joseph: ok
|
10:17:39
|
*** harsz89 has joined #openmrs
|
10:17:51
|
<k-joseph> dkayiwa: can you estimate or tell the exact bytes, for i know it is >50 m but not sure the exact,
|
10:18:12
|
<dkayiwa> k-joseph: not very sure too
|
10:28:53
|
*** k-joseph has quit IRC
|
10:35:06
|
*** k-joseph has joined #openmrs
|
10:35:25
|
*** kishoreyekkanti_ has joined #openmrs
|
10:38:27
|
*** kishoreyekkanti has quit IRC
|
10:38:28
|
*** kishoreyekkanti_ is now known as kishoreyekkanti
|
10:57:50
|
*** kishoreyekkanti has quit IRC
|
11:04:26
|
*** harshadura_ has quit IRC
|
11:12:45
|
<shortend> Is there a way to get the main openmrs servlet to handle .js files?
|
11:15:49
|
*** k-joseph has quit IRC
|
11:25:38
|
<dkayiwa> shortend: am not so sure i understand what you are asking :)
|
11:34:14
|
<shortend> dkayiwa: I want to generate a dynamic JavaScript file.
|
11:34:41
|
<shortend> But the main openmrs servlet doesn't handle *.js files.
|
11:35:11
|
<shortend> ... although I'm seeing something about "interpretJstl" in the static content servlet.
|
11:35:16
|
<shortend> Maybe that's what I want?
|
11:35:29
|
*** DraggonZ has joined #openmrs
|
11:36:04
|
<dkayiwa> shortend: what could you be meaning by the openmrs servlet does not handle js files
|
11:36:13
|
<dkayiwa> shortend: do you mean your js files are not seen?
|
11:37:01
|
<shortend> dkayiwa: As far as I can tell, .js URIs are not mapped to any handler, and I'm not sure how to achieve this.
|
11:37:16
|
<shortend> dkayiwa: It will do *.form, *.list, *.htm... etc.
|
11:37:30
|
<shortend> But not *.js
|
11:38:25
|
<shortend> dkayiwa: I mean if I'm setting up a controller and .jsp file. Obviously it works if I put a static .js file in the webapp directory.
|
11:38:54
|
<dkayiwa> shortend: where doesn't it work?
|
11:40:36
|
<shortend> dkayiwa: I want to set up a controller, do @RequestMapping("/module/mymodule/something.js"), then go to mydomain.com/openmrs/module/mymodule/something.js
|
11:40:52
|
<shortend> And see JavaScript.
|
11:41:14
|
<dkayiwa> shortend: oh i see
|
11:41:24
|
<dkayiwa> shortend: and so far it does not work?
|
11:42:07
|
<shortend> dkayiwa: As I said, the main openmrs servlet does not map .js URIs to a handler by default.
|
11:42:19
|
<shortend> something.htm works, but not something.js
|
11:47:05
|
<shortend> dkayiwa: Do you know if there is a way to override OpenMRS's WEB-INF/web.xml at the module level?
|
11:49:38
|
<dkayiwa> shortend: even if you fool it by renaming the js to .form?
|
11:50:00
|
<dkayiwa> shortend: what could you be meaning by overriding it?
|
11:51:14
|
*** harshadura has quit IRC
|
11:51:15
|
<shortend> dkayiwa: I can get the JavaScript to display if I access it with .form, but then I can't do something like <openmrs:htmlInclude/>, because it doesn't know how to handle .form
|
11:51:18
|
<dkayiwa> shortend: do you mean having the module provider a filter that handles <url-pattern>/*.js</url-pattern>
|
11:51:32
|
<shortend> dkayiwa: Precisely.
|
11:51:56
|
<dkayiwa> shortend: can you just add a filter to your module?
|
11:52:33
|
<shortend> Could do. I was looking at another module that used a filter but wasn't sure if that was the best way to solve the problem.
|
11:52:54
|
<shortend> dkayiwa: Was hoping for something a little simpler, but that's not too bad, if I can figure it out.
|
11:53:13
|
<dkayiwa> shortend: you could possibly send an email to the dev list :)
|
12:02:02
|
*** k-joseph has joined #openmrs
|
12:04:11
|
<k-joseph> hi devs, i want to upgrade git from version 7 to 8, can some one help me so that i can do this, version 8 allows cloning only the master branch, i have tried google and i have not yet gotten help , thanks
|
12:05:05
|
*** Hasintha_i has quit IRC
|
12:10:00
|
*** robbyoconnor has quit IRC
|
12:23:12
|
*** k-joseph has quit IRC
|
12:36:18
|
*** mseaton has joined #openmrs
|
12:36:18
|
*** ChanServ sets mode: +v mseaton
|
12:41:28
|
*** mseaton has quit IRC
|
12:43:14
|
*** kishoreyekkanti has joined #openmrs
|
12:44:35
|
*** kishoreyekkanti has joined #openmrs
|
12:44:56
|
*** kishoreyekkanti has quit IRC
|
12:45:29
|
*** kishoreyekkanti has joined #openmrs
|
12:46:21
|
*** kishoreyekkanti has joined #openmrs
|
12:47:13
|
*** kishoreyekkanti has joined #openmrs
|
12:51:15
|
*** Kiru has joined #openmrs
|
12:51:35
|
*** kishoreyekkanti has joined #openmrs
|
12:52:30
|
*** kishoreyekkanti has joined #openmrs
|
12:52:52
|
*** kishoreyekkanti has quit IRC
|
12:52:53
|
*** Kiru has left #openmrs
|
12:53:24
|
*** kishoreyekkanti has joined #openmrs
|
12:54:16
|
*** kishoreyekkanti has joined #openmrs
|
12:55:09
|
*** kishoreyekkanti has joined #openmrs
|
12:56:02
|
*** kishoreyekkanti has joined #openmrs
|
12:56:55
|
*** kishoreyekkanti has joined #openmrs
|
12:57:47
|
*** kishoreyekkanti has joined #openmrs
|
12:58:40
|
*** kishoreyekkanti has joined #openmrs
|
12:58:50
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: OpenHMIS Cashier Module 1.1.2 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=openhmis.cashier&version=&1.1.2>
|
12:59:01
|
*** kishoreyekkanti has quit IRC
|
12:59:33
|
*** kishoreyekkanti has joined #openmrs
|
13:00:25
|
*** kishoreyekkanti has joined #openmrs
|
13:00:50
|
*** kishoreyekkanti has quit IRC
|
13:01:21
|
*** kishoreyekkanti has joined #openmrs
|
13:02:10
|
*** kishoreyekkanti has joined #openmrs
|
13:03:02
|
*** kishoreyekkanti has joined #openmrs
|
13:03:57
|
*** kishoreyekkanti has joined #openmrs
|
13:04:51
|
*** kishoreyekkanti has joined #openmrs
|
13:05:42
|
*** kishoreyekkanti has joined #openmrs
|
13:06:34
|
*** kishoreyekkanti has joined #openmrs
|
13:06:53
|
*** kishoreyekkanti has quit IRC
|
13:07:29
|
*** kishoreyekkanti has joined #openmrs
|
13:08:21
|
*** kishoreyekkanti has joined #openmrs
|
13:09:12
|
*** kishoreyekkanti has joined #openmrs
|
13:10:06
|
*** kishoreyekkanti has joined #openmrs
|
13:10:58
|
*** kishoreyekkanti has joined #openmrs
|
13:11:51
|
*** kishoreyekkanti has joined #openmrs
|
13:12:46
|
*** kishoreyekkanti has joined #openmrs
|
13:13:00
|
*** kishoreyekkanti has quit IRC
|
13:13:38
|
*** kishoreyekkanti has joined #openmrs
|
13:14:31
|
*** kishoreyekkanti has joined #openmrs
|
13:14:52
|
*** kishoreyekkanti has quit IRC
|
13:15:22
|
*** kishoreyekkanti has joined #openmrs
|
13:16:17
|
*** kishoreyekkanti has joined #openmrs
|
13:17:09
|
*** kishoreyekkanti has joined #openmrs
|
13:18:03
|
*** kishoreyekkanti has joined #openmrs
|
13:18:54
|
*** kishoreyekkanti has joined #openmrs
|
13:19:47
|
*** kishoreyekkanti has joined #openmrs
|
13:20:39
|
*** kishoreyekkanti has joined #openmrs
|
13:20:54
|
*** kishoreyekkanti has quit IRC
|
13:21:32
|
*** kishoreyekkanti has joined #openmrs
|
13:21:41
|
<dkayiwa> kishoreyekkanti: :D
|
13:21:46
|
*** kishoreyekkanti has quit IRC
|
13:22:26
|
*** kishoreyekkanti has joined #openmrs
|
13:22:30
|
<dkayiwa> kishoreyekkanti: do you have a Ugandan internet connection?
|
13:22:38
|
<dkayiwa> 9.9
|
13:22:40
|
*** kishoreyekkanti has quit IRC
|
13:23:19
|
*** kishoreyekkanti has joined #openmrs
|
13:24:12
|
*** kishoreyekkanti has joined #openmrs
|
13:24:56
|
*** kishoreyekkanti has quit IRC
|
13:25:04
|
*** kishoreyekkanti_ has joined #openmrs
|
13:25:56
|
*** kishoreyekkanti has joined #openmrs
|
13:26:49
|
*** kishoreyekkanti has joined #openmrs
|
13:27:02
|
*** kishoreyekkanti has quit IRC
|
13:27:42
|
*** kishoreyekkanti has joined #openmrs
|
13:28:35
|
*** kishoreyekkanti has joined #openmrs
|
13:28:56
|
*** kishoreyekkanti has quit IRC
|
13:29:28
|
*** kishoreyekkanti has joined #openmrs
|
13:30:21
|
*** kishoreyekkanti has joined #openmrs
|
13:31:13
|
*** kishoreyekkanti has joined #openmrs
|
13:32:06
|
*** kishoreyekkanti has joined #openmrs
|
13:32:59
|
*** kishoreyekkanti has joined #openmrs
|
13:33:52
|
*** kishoreyekkanti has joined #openmrs
|
13:34:45
|
*** kishoreyekkanti has joined #openmrs
|
13:35:03
|
*** kishoreyekkanti has quit IRC
|
13:35:38
|
*** kishoreyekkanti has joined #openmrs
|
13:36:33
|
*** kishoreyekkanti has joined #openmrs
|
13:37:23
|
*** kishoreyekkanti has joined #openmrs
|
13:37:37
|
*** wyclif_ has quit IRC
|
13:37:40
|
*** kishoreyekkanti has quit IRC
|
13:38:17
|
*** kishoreyekkanti has joined #openmrs
|
13:39:10
|
*** kishoreyekkanti has joined #openmrs
|
13:39:36
|
*** zzz_jb360 has quit IRC
|
13:40:01
|
*** kishoreyekkanti has joined #openmrs
|
13:40:55
|
*** kishoreyekkanti has joined #openmrs
|
13:41:10
|
*** kishoreyekkanti has quit IRC
|
13:41:47
|
*** kishoreyekkanti has joined #openmrs
|
13:42:38
|
*** Tarkaan has joined #openmrs
|
13:42:48
|
*** kishoreyekkanti has joined #openmrs
|
13:43:28
|
<Tarkaan> hi, does anyone here know what it's called when someone goes in for surgery when they have an existing infection? Like if they go in for heart surgery and they already have foot fungus?
|
13:43:33
|
*** kishoreyekkanti has joined #openmrs
|
13:43:35
|
<Tarkaan> in Portuguese, it's infecção à distância
|
13:43:46
|
*** kishoreyekkanti has quit IRC
|
13:44:25
|
*** kishoreyekkanti has joined #openmrs
|
13:45:19
|
*** kishoreyekkanti has joined #openmrs
|
13:46:06
|
<dkayiwa> Tarkaan: you could try google translation :)
|
13:46:13
|
*** kishoreyekkanti has joined #openmrs
|
13:46:50
|
<Tarkaan> is "infection distance' the correct term in English?
|
13:47:05
|
*** kishoreyekkanti has joined #openmrs
|
13:47:57
|
*** kishoreyekkanti has joined #openmrs
|
13:48:22
|
*** k-joseph has joined #openmrs
|
13:59:32
|
*** djazayeri1 has joined #openmrs
|
14:00:47
|
*** rfriedman has joined #openmrs
|
14:00:54
|
<rfriedman> rafa, hi
|
14:01:06
|
<rafa> rfriedman: hi
|
14:01:30
|
<rfriedman> rafa, I have an updated version of the table, but I need to double check it against the notes before I post it
|
14:01:40
|
<rafa> rfriedman: ok
|
14:01:47
|
<rafa> rfriedman: I left a comment on a ticket
|
14:02:00
|
<rafa> rfriedman: with the differences I found
|
14:02:23
|
<rfriedman> rafa, yes, I saw it. we did not agree to add the new collection, only to remove the existing one
|
14:02:42
|
<rafa> rfriedman: ok
|
14:03:04
|
<rfriedman> rafa, i also want to revisit one point ... i think we still need a method to get all concepts that reference a particular term
|
14:03:22
|
*** mseaton has joined #openmrs
|
14:03:22
|
*** ChanServ sets mode: +v mseaton
|
14:03:45
|
<rfriedman> rafa, it might be on the table already
|
14:03:57
|
<rafa> rfriedman: if it is a search that is not straightforward, I'll create a separate ticket for that and release 2.0 without it
|
14:04:24
|
<rfriedman> rafa, no, it would be quite straightforward, whatever it turns out to be
|
14:04:43
|
<rfriedman> rafa, in what class(es) did you put the searches?
|
14:04:53
|
<rafa> rfriedman: I haven't yet committed
|
14:05:00
|
<rafa> rfriedman: will do in an hour or two
|
14:05:14
|
<rfriedman> rafa, but there's an existing search using 311?
|
14:05:21
|
*** k-joseph has quit IRC
|
14:05:29
|
<rafa> rfriedman: yes, but that just one
|
14:05:38
|
<rfriedman> rafa, and in what class is it?
|
14:05:45
|
<rafa> rfriedman: ConceptByMappingSearchHandler
|
14:06:06
|
<rfriedman> rafa, the search annotations are method or class annotations?
|
14:06:48
|
<rafa> @WSDoc is method annotation
|
14:07:13
|
<rfriedman> rafa, do the search handlers have to be beans?
|
14:07:20
|
<rafa> rfriedman: yes
|
14:07:55
|
<rfriedman> rafa, then the annotations would be class annotations
|
14:08:09
|
<rafa> rfriedman: I don't understand what you mean
|
14:08:16
|
<rafa> rfriedman: you don't put any annotations on searchHandlers
|
14:08:30
|
*** Tarkaan has left #openmrs
|
14:08:30
|
<rfriedman> rafa, 1 handler = 1 bean = 1 class, right?
|
14:08:36
|
<rafa> rfriedman: they have getSearchDescription
|
14:08:50
|
<rfriedman> rafa, oh that's right, you chose an interface rather than annotations
|
14:09:29
|
<rfriedman> rafa, are you using RestService to do searches?
|
14:10:25
|
<rfriedman> rafa, or is all the data access handled in the handler class?
|
14:10:43
|
*** dkayiwa has quit IRC
|
14:11:18
|
<rfriedman> rafa, what i'm thinking about is that, as new DAO/service methods are needed, there should be a way that they would move into core at the next release
|
14:11:25
|
*** dkayiwa has joined #openmrs
|
14:11:26
|
*** GitHub120 has joined #openmrs
|
14:11:26
|
<GitHub120> [openmrs-core] wluyima pushed 1 new commit to 1.9.x: http://git.io/JIFBBQ
|
14:11:26
|
<GitHub120> openmrs-core/1.9.x 5410b7e wluyima: Fixed compilation error - TRUNK-3609
|
14:11:26
|
*** GitHub120 has left #openmrs
|
14:12:05
|
*** k-joseph has joined #openmrs
|
14:20:08
|
*** dkayiwa_ has joined #openmrs
|
14:21:52
|
*** dkayiwa has quit IRC
|
14:21:53
|
*** dkayiwa_ is now known as dkayiwa
|
14:23:54
|
*** wyclif_ has joined #openmrs
|
14:28:16
|
*** diadara has joined #openmrs
|
14:28:37
|
<rfriedman> rafa, have you already committed ConceptByMappingSearchHandler?
|
14:28:59
|
*** k_joseph has joined #openmrs
|
14:29:10
|
*** k-joseph has quit IRC
|
14:31:52
|
*** dmulindwa has joined #openmrs
|
14:33:37
|
*** k_joseph has quit IRC
|
14:34:35
|
*** k-joseph has joined #openmrs
|
14:39:01
|
*** harshadura has joined #openmrs
|
14:40:57
|
<jkeiper> mseaton: is mgoodrich the idgen authority?
|
14:41:32
|
<mseaton> jkeiper: i wrote the module. mgoodrich and djazayeri have been working on it lately a bit for mirebalais.
|
14:44:36
|
<jkeiper> mseaton: aha ... i'm working on MOH CCC number assignment for AMPATH, are you familiar with how those work?
|
14:45:00
|
<jkeiper> mseaton: basically [location code]-[6-digit 0-padded serial number] per location
|
14:45:05
|
<jkeiper> mseaton: like 12345-00001
|
14:45:27
|
<jkeiper> we, of course, assume when we get high enough we will just extend the serial number out automatically to 7,8,9 digits
|
14:45:48
|
<jkeiper> mseaton: like 12345-99999, 12345-100001, etc
|
14:45:58
|
<mseaton> jkeiper: ok, sure.
|
14:46:17
|
<jkeiper> mseaton: so, i just wonder if this is possible via idgen or i need to come up with my own solution :-D
|
14:46:27
|
<jkeiper> mseaton: without looking at it
|
14:46:32
|
<jkeiper> mseaton: (which would be the easy way)
|
14:46:50
|
<mseaton> jkeiper: yes it is possible. a few things:
|
14:46:58
|
<k-joseph> dkayiwa: hi
|
14:47:07
|
*** Hasintha_i has joined #openmrs
|
14:47:38
|
<dkayiwa> k-joseph: hi
|
14:47:44
|
<k-joseph> dkayiwa: mvn install is failing with error http://pastebin.com/TxADV4wn
|
14:48:36
|
<mseaton> jkeiper: 1. if you use the out of the box sequential identifier generator, this supports a fixed prefix followed by a fixed-length sequential number in the base of your choice. so that would seem to meet your needs assuming each server ran it's own generator (which I assume they will if each server represents one facility and that facilities location code guarantees the uniqueness of it's identifiers in relation to others)
|
14:48:37
|
<dkayiwa> k-joseph: do like i told you in the other email on the dev list
|
14:49:59
|
<mseaton> jkeiper: and if for whatever reason this doesn't work exactly like you need it to, you just need to implement a single new class that implements IdentifierSource (I'm pretty sure this is the case), and idgen will allow you to use this.
|
14:51:04
|
<mseaton> jkeiper: i'm pretty sure Dave Thomas did this in Rwanda. i'll find you a link to the code. his use case was similar to yours with the location code prefixes, but he wanted them all to be able to exist on the same server, due to sync.
|
14:51:23
|
<mseaton> jkeiper: so he did something with a custom identifier source and global property configuration unique to each child server
|
14:54:47
|
<jkeiper> mseaton: ah, ok ... thanks! the out-of-the-box sequential id generator increase beyond the "length" limit once you hit 99999?
|
14:54:51
|
<mseaton> jkeiper: so it looks like Dave used the standard Sequential Identifier Source, but added a custom IdentifierValidator that did what he needed: http://svn.openmrs.org/openmrs-modules/rwandaprimarycare/trunk/api/src/main/java/org/openmrs/module/rwandaprimarycare/validator/IdentifierValidatorRwanda.java
|
14:55:08
|
<mseaton> jkeiper: no, probably not.
|
14:55:23
|
<djazayeri1> jkeiper: no, it bombs when you run out
|
14:55:43
|
<jkeiper> djazayeri1: ooooh ...
|
14:55:44
|
<djazayeri1> jkeiper: want to add that functionality? :-)
|
14:55:48
|
<jkeiper> djazayeri1: yes, i do
|
14:55:49
|
<jkeiper> haha
|
14:56:14
|
<jkeiper> djazayeri1: I'll at least be adding it to a custom one, may as well be in the module itself
|
14:59:53
|
<jkeiper> djazayeri1, mseaton: is this functionality something we want in idgen, perhaps an extra boolean field for extending beyond the length?
|
15:00:18
|
<mseaton> jkeiper: i have no problem with that off the top of my head.
|
15:00:21
|
<djazayeri1> jkeiper: yeah, I think an extra boolean (defaulting to false) for autoextending.
|
15:00:38
|
<djazayeri1> jkeiper: or alternately have a minLength and maxLength?
|
15:01:04
|
*** maurya has joined #openmrs
|
15:01:15
|
<mseaton> jkeiper: djazayeri1: we could also instead of length + autoextending, have "minLength" and "maxLength" which could both be optional
|
15:01:16
|
<jkeiper> djazayeri1: boolean sounds more flexible ...
|
15:01:38
|
<mseaton> djazayeri1: nice thought :)
|
15:01:47
|
<djazayeri1> jkeiper: no, boolean is less flexible...
|
15:01:48
|
<jkeiper> mseaton: maxLength of null ==> no max, right?
|
15:01:50
|
<mseaton> jkeiper: i would think the minLength and maxLength is more flexible
|
15:01:59
|
<djazayeri1> mseaton: good point. :-)
|
15:02:10
|
<mseaton> djazayeri1 i'll stay out of this, you're doing fine :)
|
15:02:15
|
<jkeiper> hahaah
|
15:02:19
|
<jkeiper> ok, i'll write up the ticket
|
15:03:39
|
<k-joseph> dkayiwa: how do i add @ in a txt file = org.openmrs.module.formentry.test.PublishInfoPathTest.txt, this is the one failing
|
15:03:41
|
<k-joseph> ?
|
15:04:28
|
*** harshadura_ has joined #openmrs
|
15:04:31
|
<rfriedman> djazayeri1, mseaton , still can't access design docs, maybe google is trying to use a port which is not open on the CDC firewall
|
15:04:32
|
<dkayiwa> k-joseph: not in that file. but on the failing unit test. can you read the email instructions again? :)
|
15:04:42
|
<k-joseph> dkayiwa: i have seen that
|
15:05:12
|
<djazayeri1> rfriedman: hmm, that's odd. I can email it to you.
|
15:05:47
|
*** DraggonZ has quit IRC
|
15:07:04
|
<djazayeri1> rfriedman: looks like someone already did that
|
15:08:10
|
<rfriedman> djazayeri1, yep
|
15:08:18
|
<jkeiper> mseaton: https://tickets.openmrs.org/browse/IDGEN-25 ... let me know if that's right
|
15:09:43
|
<rfriedman> harshadura_, harshadura, thanks for posting
|
15:10:33
|
<harshadura> rfriedman, its okay Roger :)
|
15:10:47
|
*** harshadura_ has quit IRC
|
15:11:23
|
<k-joseph> dkayiwa: again failing after ignoring the previous failing test now failure trace is http://pastebin.com/BBUwJ4ag
|
15:12:01
|
*** Anuruddha has joined #openmrs
|
15:28:30
|
*** kmithemanth has joined #openmrs
|
15:32:50
|
*** dmulindwa has quit IRC
|
15:39:01
|
<k-joseph> dkayiwa: hi
|
15:39:13
|
<dkayiwa> k-joseph: hi
|
15:40:03
|
<k-joseph> dkayiwa: i have ignored all failing tests in the pom project but the release test project is still having errors
|
15:40:27
|
<dkayiwa> k-joseph: can you remove it?
|
15:41:34
|
<k-joseph> dkayiwa: do you mean so that i remain with only two projects in eclipse or in the git repository for the module, ?
|
15:42:44
|
<dkayiwa> k-joseph: remove release-tests from eclipse
|
15:43:30
|
<dkayiwa> k-joseph: remove it also from the pom under formentry
|
15:43:44
|
<dkayiwa> k-joseph: <module>release-tests</module>
|
15:43:54
|
*** andrea___ has joined #openmrs
|
15:49:38
|
*** andreapat has joined #openmrs
|
15:51:17
|
*** maurya has quit IRC
|
15:53:59
|
<jkeiper> mseaton: looking at this chunk of code: https://github.com/openmrs/openmrs-module-idgen/blob/master/api/src/main/java/org/openmrs/module/idgen/SequentialIdentifierGenerator.java#L42
|
15:54:03
|
<OpenMRSBot> <http://ln-s.net/+mh0> (at github.com)
|
15:54:21
|
<jkeiper> mseaton: shouldn't minLength be set to the minimum expected characters?
|
15:54:22
|
<k-joseph> dkayiwa: still failing with the message, missing class, here is the wholle trace http://pastebin.com/usmva6Wr
|
15:56:19
|
*** lh has joined #openmrs
|
15:58:15
|
<jkeiper> mseaton: if I setFirstIdentifierBase("00"), my tests pass for generating with a seed of 1.
|
15:58:19
|
<k-joseph> dkayiwa: is the class org/codehaus/plexus/archiver/AbstractArchiver supposed to be part of this module, why not located at github,
|
15:58:21
|
<k-joseph> ?
|
15:58:37
|
<jkeiper> mseaton: but if I leave firstIdentifierBase null, I do not get something with a length of 2
|
15:59:04
|
<dkayiwa> k-joseph: which version of maven are you running?
|
16:00:02
|
<k-joseph> dkayiwa: that was the issue that djazayeri was addressing here https://groups.google.com/a/openmrs.org/forum/?fromgroups=#!topic/dev/ddM6pG3NpXE, am using Apache Maven 3.0.4 (r1232337; 2012-01-17 11:44:56+0300
|
16:00:03
|
<jkeiper> mseaton: also, don't want to use liquibase.xml?
|
16:00:07
|
<OpenMRSBot> <http://ln-s.net/+mh+> (at groups.google.com)
|
16:04:40
|
<mseaton> jkeiper: reading above
|
16:05:34
|
<dkayiwa> k-joseph: can you try deleting this folder org/codehaus/plexus from your maven repository and try again
|
16:07:16
|
<jkeiper> mseaton: no worries on liquibase ... have the sqldiff done
|
16:07:23
|
<mseaton> jkeiper: what do you get if you leave first identifier base null?
|
16:07:42
|
<jkeiper> mseaton: getIdentifierForSeed(1) --> "1"
|
16:07:48
|
<jkeiper> even if minLength is set to 2
|
16:07:50
|
<jkeiper> (or length)
|
16:08:30
|
<mseaton> jkeiper: looks like a bug.
|
16:08:47
|
*** kmithemanth has quit IRC
|
16:08:53
|
<jkeiper> mseaton: ok ... i'll set minLength to max of minLength and firstidentifierbvase.length
|
16:09:08
|
<mseaton> djazayeri1: most recently worked on this. he took exception to how i interpreted "length". maybe he changed this? darius?
|
16:09:32
|
*** dmulindwa has joined #openmrs
|
16:10:12
|
<mseaton> jkeiper: it might be that it is up to you to configure first identifier base correctly to get the desired length. and then the length property is a sanity check for validating. not sure why this was done that way anymore or if it is a bug.
|
16:10:59
|
<mseaton> jkeiper: hang on. checking.
|
16:12:26
|
<jkeiper> mseaton: ok
|
16:14:15
|
<mseaton> jkeiper: right, i think i'm remembering.
|
16:15:54
|
<k-joseph> dkayiwa: it does not solve the problem, the error is re-produced again
|
16:16:01
|
*** diadara has quit IRC
|
16:16:42
|
<dkayiwa> k-joseph: can i look at the current log
|
16:17:08
|
<mseaton> the first identifier base is what determines the first identifier without any prefix or suffix, and it will always ensure it is padded to the length specified. the "length" property is to validate the overall length of the identifier, which will include any prefix, suffix, and checkdigit, and any other embellishment that the identifiervalidator wants to do. so it is there as a validation check to ensure that after all of these things have built an iden
|
16:17:35
|
<mseaton> jkeiper: ^^
|
16:17:48
|
<k-joseph> dkayiwa: http://pastebin.com/7pCwDYzf
|
16:18:25
|
<jkeiper> mseaton: ok
|
16:18:51
|
<dkayiwa> k-joseph: do u get the same error when you compile from eclipse
|
16:19:05
|
*** wyclif_ has quit IRC
|
16:20:11
|
<jkeiper> mseaton: that changes everything heheh
|
16:20:35
|
<mseaton> jkeiper: yeah. do you even need to change anything?
|
16:20:43
|
<mseaton> jkeiper: what if you just leave length == null?
|
16:21:07
|
<downey> jkeiper: like this
|
16:21:36
|
<jkeiper> mseaton: I'll look post lunch ... might not
|
16:22:06
|
<k-joseph> dkayiwa: running from eclipse gives a different error, http://pastebin.com/Agnm3xXG
|
16:22:15
|
*** kmithemanth has joined #openmrs
|
16:23:53
|
<mseaton> jkeiper: my guess is that you can configure a new SequentialIdentifierGenerator with prefix = "12345-", suffix = null, firstIdentifierBase="00001", length = null, baseCharacterSet="0123456789", and this should do what you want.
|
16:28:10
|
*** k-joseph has quit IRC
|
16:32:03
|
*** wyclif_ has joined #openmrs
|
16:37:24
|
*** davidpardz has joined #openmrs
|
16:43:10
|
*** dmulindwa has quit IRC
|
16:43:29
|
*** dmulindwa has joined #openmrs
|
16:45:46
|
*** Hasintha_i has quit IRC
|
16:46:06
|
*** kmithemanth has joined #openmrs
|
16:52:54
|
*** Anuruddha has quit IRC
|
17:05:48
|
*** k-joseph has joined #openmrs
|
17:06:09
|
*** mseaton has quit IRC
|
17:08:24
|
*** robbyoconnor has joined #openmrs
|
17:08:24
|
*** ChanServ sets mode: +v robbyoconnor
|
17:11:23
|
*** robbyoconnor has quit IRC
|
17:12:35
|
*** kishoreyekkanti has joined #openmrs
|
17:12:50
|
*** robbyoconnor has joined #openmrs
|
17:12:50
|
*** ChanServ sets mode: +v robbyoconnor
|
17:22:20
|
*** robbyoconnor has quit IRC
|
17:23:58
|
*** robbyoconnor has joined #openmrs
|
17:23:58
|
*** ChanServ sets mode: +v robbyoconnor
|
17:25:21
|
*** suranga has joined #openmrs
|
17:25:21
|
*** ChanServ sets mode: +v suranga
|
17:25:55
|
<suranga> wowwiee... just look at the ammount of people online today ! :)
|
17:28:29
|
<dkayiwa> suranga: yes its gsoc time :)
|
17:30:12
|
*** k-joseph has quit IRC
|
17:30:50
|
<suranga> dkayiwa, I suspect that harshadura and myself are responsible for at least some of these people :P
|
17:31:22
|
<dkayiwa> suranga: then u are bad guys :)
|
17:33:26
|
<suranga> dkayiwa, things will calm down in a month or two, i guess :P
|
17:33:39
|
<dkayiwa> suranga: lets see
|
17:34:32
|
*** kishoreyekkanti has quit IRC
|
17:39:16
|
*** robbyoconnor has quit IRC
|
17:40:25
|
*** robbyoconnor has joined #openmrs
|
17:40:25
|
*** ChanServ sets mode: +v robbyoconnor
|
17:40:28
|
*** k-joseph has joined #openmrs
|
17:42:15
|
*** andrea has joined #openmrs
|
17:42:34
|
<downey> 3 months until GSoC
|
17:42:38
|
*** andrea is now known as Guest79846
|
17:44:19
|
<k-joseph> dkayiwa: hi
|
17:45:46
|
*** andreapat has quit IRC
|
17:45:47
|
*** r0bby has joined #openmrs
|
17:45:47
|
*** ChanServ sets mode: +v r0bby
|
17:46:05
|
*** robbyoconnor has quit IRC
|
17:47:53
|
<dkayiwa> k-joseph: hi
|
17:50:16
|
*** r0bby has quit IRC
|
17:50:23
|
*** r0bby_ has joined #openmrs
|
17:50:23
|
*** ChanServ sets mode: +v r0bby_
|
17:55:17
|
*** r0bby_ has quit IRC
|
17:55:48
|
*** robbyoconnor has joined #openmrs
|
17:55:48
|
*** ChanServ sets mode: +v robbyoconnor
|
17:57:37
|
*** Hasintha_i has joined #openmrs
|
18:00:11
|
*** robbyoconnor has quit IRC
|
18:04:38
|
*** robbyoconnor has joined #openmrs
|
18:04:38
|
*** ChanServ sets mode: +v robbyoconnor
|
18:07:24
|
*** dmulindwa has quit IRC
|
18:10:51
|
*** wyclif_ has quit IRC
|
18:12:36
|
*** Hasintha_i has quit IRC
|
18:15:38
|
*** dmulindwa has joined #openmrs
|
18:17:53
|
*** diadara has joined #openmrs
|
18:22:10
|
<Guest79846> rafa, are you here?
|
18:22:29
|
*** Guest79846 is now known as andreap
|
18:22:44
|
<andreap> rafa, try again
|
18:23:54
|
<andreap> rafa, are you here?
|
18:24:12
|
*** dmulindwa has quit IRC
|
18:25:23
|
*** dmulindwa has joined #openmrs
|
18:26:22
|
*** wyclif_ has joined #openmrs
|
18:28:55
|
*** k_joseph has joined #openmrs
|
18:29:30
|
*** k-joseph has quit IRC
|
18:30:42
|
<dkayiwa> k_joseph: hi
|
18:30:59
|
<k_joseph> dkayiwa: hi
|
18:31:07
|
*** k_joseph is now known as k-joseph
|
18:32:23
|
<dkayiwa> k-joseph: in your maven repo, can you try delete this? org/openmrs/maven
|
18:32:28
|
<dkayiwa> k-joseph: then try again?
|
18:37:52
|
*** mseaton has joined #openmrs
|
18:37:52
|
*** ChanServ sets mode: +v mseaton
|
18:39:02
|
*** GitHub162 has joined #openmrs
|
18:39:02
|
<GitHub162> [openmrs-core] dkayiwa opened pull request #242: Liquibase fails to change column with foreign key in MySQL 5.6 - TRUNK-3909 (master...TRUNK-3909) http://git.io/uZTHrw
|
18:39:02
|
*** GitHub162 has left #openmrs
|
18:39:58
|
*** GitHub169 has joined #openmrs
|
18:39:58
|
<GitHub169> [openmrs-core] dkayiwa pushed 2 new commits to master: http://git.io/6MZW5w
|
18:39:58
|
<GitHub169> openmrs-core/master 167f705 dkayiwa: Liquibase fails to change column with foreign key in MySQL 5.6 -...
|
18:39:58
|
<GitHub169> openmrs-core/master 4dfc377 dkayiwa: Merge pull request #242 from dkayiwa/TRUNK-3909...
|
18:39:58
|
*** GitHub169 has left #openmrs
|
18:42:55
|
<k-joseph> dkayiwa: that has not still solved the problem, http://pastebin.com/8UTUAEfP
|
18:46:53
|
*** robbyoconnor has quit IRC
|
18:47:19
|
*** robbyoconnor has joined #openmrs
|
18:47:19
|
*** ChanServ sets mode: +v robbyoconnor
|
18:47:33
|
*** sunbiz has joined #openmrs
|
18:47:33
|
*** ChanServ sets mode: +v sunbiz
|
18:53:13
|
*** travis-ci has joined #openmrs
|
18:53:13
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [4dfc377] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/5321105
|
18:53:13
|
*** travis-ci has left #openmrs
|
18:53:16
|
<OpenMRSBot> <http://ln-s.net/+ml5> (at travis-ci.org)
|
19:05:31
|
<sunbiz> dkayiwa: Im looking at the changeset on the MySQL 5.6 ticket
|
19:06:21
|
<sunbiz> do u know why that changeset was actually making it varchar(50) in the first place?? that seems so odd... because all the columns from privilege were varchar(255)
|
19:06:49
|
<sunbiz> dkayiwa: I wonder how it was working in the first place :) and that changeset had me as the author
|
19:07:54
|
*** k-joseph has quit IRC
|
19:09:40
|
<sunbiz> cpower: u here??
|
19:14:09
|
<jkeiper> mseaton: `mvn clean install` should work on idgen, right? getting an error "No runnable methods" on TestTask
|
19:14:44
|
<dkayiwa> sunbiz: sorry had stepped out a bit
|
19:14:57
|
<djazayeri1> jkeiper: maybe there's a flag you need to set in the test runner (IDE I guess)?
|
19:15:07
|
<djazayeri1> about ignoring empty tests?
|
19:15:08
|
<jkeiper> djazayeri1: this is from the command line
|
19:15:27
|
<sunbiz> dkayiwa: have u been able tofigure why it was varchar(50) in the first place??
|
19:15:29
|
<djazayeri1> jkeiper: alternately, rename TestTask to something that doesn't start with Test?
|
19:15:36
|
*** maurya has joined #openmrs
|
19:15:44
|
<jkeiper> djazayeri1: that's what I was thinking ...
|
19:15:52
|
<dkayiwa> sunbiz: as in why you made it varchar(50) ? :)
|
19:15:56
|
<sunbiz> yes
|
19:16:01
|
<sunbiz> that looks so odd
|
19:16:02
|
<djazayeri1> jkeiper: not sure why you see this and CI doesn't though.
|
19:16:08
|
<dkayiwa> sunbiz: you must be knowing better :)
|
19:17:11
|
<jkeiper> djazayeri1: that worked .. renamed to MockTask :-)
|
19:17:11
|
<sunbiz> :) my memory isn't serving me well... as to why it must have been better
|
19:17:57
|
<dkayiwa> :)
|
19:18:08
|
<maurya> did anyone get an "error-404" while trying to access uploaded modules in openmrs 1.10.0 snapshot??
|
19:19:48
|
<sunbiz> maurya: which changeset?? is it current trunk??
|
19:21:19
|
<maurya> sunbiz: it is trunk,i just cloned it..i'm not quite sure of the meaning of changeset
|
19:23:34
|
<mseaton> jkeiper: not sure what's happening, but probably just need to mark that as @Ignore if there are not actual tests in that class
|
19:25:24
|
<jkeiper> mseaton: it's a timer task used as a bean in the test context and referenced in AuthenticatedTaskIT
|
19:26:33
|
<mseaton> jkeiper: i've been seeing other errors like this in other projects. not sure what it is that is causing some peoples environments to not care about these, and others to care. but it seems that there is something that is trying to run all classes with Test in the name in the test package, and complaining if there are none there.
|
19:26:47
|
<mseaton> jkeiper: so just throw an @Ignore annotation on it, and should probably work
|
19:28:00
|
<jkeiper> mseaton: yep, i'll try that
|
19:28:03
|
<jkeiper> mseaton: otherwise i'm done
|
19:28:34
|
<rafa> it depends on maven-surefire-plugin version
|
19:29:51
|
*** harsz89 has quit IRC
|
19:30:06
|
<jkeiper> rafa: oh ... is this good or bad behavior?
|
19:30:29
|
<rafa> jkeiper: if you care, you can specify a version in pom and get the samve behavior everywhere
|
19:30:46
|
<jkeiper> mseaton: also wondered why reporting and address hierarchy use the "old" scheduler username/password way of auth'ing for scheduled tasks (and not using daemon)
|
19:31:01
|
<rafa> jkeiper: otherwise maven uses whatever version is available locally
|
19:31:04
|
<jkeiper> rafa: at least it would be dependable ... up to mseaton et al for this module ;-)
|
19:32:51
|
<rafa> jkeiper: docs say you should specify version :) http://maven.apache.org/surefire/maven-surefire-plugin/plugin-info.html
|
19:32:58
|
<OpenMRSBot> <http://ln-s.net/+mlp> (at maven.apache.org)
|
19:33:32
|
<mseaton> jkeiper: it's all about 1.6 support
|
19:33:40
|
<mseaton> jkeiper: daemon is 1.7+
|
19:34:11
|
<mseaton> rafa: maven surefire strikes again!
|
19:34:20
|
<rafa> again?
|
19:34:34
|
<mseaton> (we're still on bad terms after yesterday. did you see my dev list mail last night?)
|
19:34:58
|
<rafa> ohh okay, see it now
|
19:35:22
|
<mseaton> rafa: do you know of any utility for converting a module sqldiff to a liquibase.xml file instead?
|
19:35:42
|
<rafa> mseaton: nope
|
19:36:39
|
<rafa> mseaton: it's tricky becasue you will have to add preconditions...
|
19:36:51
|
<rafa> mseaton: sqldiff doesn't have them
|
19:36:54
|
<jkeiper> mseaton: ah i see
|
19:37:13
|
<jkeiper> sqldiff is processed before liquibase
|
19:37:15
|
<jkeiper> so you can have both
|
19:37:27
|
<rafa> that's correct
|
19:37:28
|
<mseaton> rafa: yep. thanks.
|
19:37:45
|
<jkeiper> just need to put a lockdown on sqldiff changes :-D
|
19:37:50
|
<mseaton> jkeiper: that's good as a baby step. but sqldiff is good to get rid of
|
19:37:56
|
<jkeiper> mseaton: totally agree
|
19:38:00
|
<shortend> Hey, does anyone know an easy way to map a controller to a .js URI?
|
19:38:35
|
<shortend> .form, .list, and .htm just aren't cutting it for my dynamic JavaScript file.
|
19:39:27
|
<rafa> shortend: hard one
|
19:40:02
|
<shortend> rafa: Tell me about it... spent my whole day on it.
|
19:40:54
|
<shortend> Can I do it with a filter?
|
19:42:12
|
<shortend> I can create my own servlet... but it seems a bit overkill when the openmrs servlet already does everything I need.
|
19:42:44
|
<mseaton> dkayiwa: question for you on standaone?
|
19:42:50
|
<dkayiwa> mseaton: ok
|
19:43:13
|
<mseaton> dkayiwa: i'm trying to get sync module up to snuff for sprint starting, which is currently involving a lot of codebase cleanup, moving files around, curating tickets, etc.
|
19:43:27
|
<mseaton> dkayiwa: i was trying to setup a local sync environment by using 2 standalone instances
|
19:43:35
|
<dkayiwa> mseaton: ok
|
19:44:01
|
<mseaton> dkayiwa: and i found that the sync module failed to start due to sqldiff.xml failing (it works on my regular setup, not on the standalone).
|
19:44:23
|
<mseaton> dkayiwa: have you ever seen sqldiffs fail there? anything you can think of
|
19:44:38
|
<dkayiwa> mseaton: never experienced that
|
19:44:43
|
<rafa> djazayeri: how we do jquery.js?v=1.9.3... ?
|
19:44:46
|
<dkayiwa> mseaton: what kind of error?
|
19:45:02
|
<dkayiwa> mseaton: could it be the version of mysql in the standalone?
|
19:45:11
|
<rafa> djazayeri: do we have a servlet to resolve that?
|
19:45:26
|
<mseaton> basically, diff 0.1 creates a table with a column named "type" as one of the columns. and diff 0.2 tries to insert into that table, and it fails saying it doesn't know what the "type" column is
|
19:45:32
|
<mseaton> dkayiwa:
|
19:45:39
|
<mseaton> ^^
|
19:45:59
|
<dkayiwa> mseaton: that is strange
|
19:46:19
|
<dkayiwa> mseaton: can i try it here? which version of sync?
|
19:46:20
|
<djazayeri1> rafa, shortend: you need to really generate js using java? or merely js + access to our taglibs is eough?
|
19:46:34
|
<djazayeri1> shortend: eg. for message properties, locale, global properties, etc?
|
19:46:36
|
*** robbyoconnor has quit IRC
|
19:46:51
|
<mseaton> dkayiwa: clone latest from git, build it, and see if it loads without error. that would be great - thanks!
|
19:47:05
|
<dkayiwa> mseaton: which version of openmrs?
|
19:47:24
|
<mseaton> dkayiwa: i'm using the 1.9.3 standalone since i already had it on my computer after creating it
|
19:47:36
|
<dkayiwa> mseaton: ok let me try it out
|
19:48:27
|
<shortend> djazayeri1: Yes, essentially.
|
19:48:41
|
<shortend> djazayeri1: Ummm... sorry...
|
19:49:05
|
<shortend> djazayeri1: More specifically paths.
|
19:49:43
|
<shortend> djazayeri1: I need the contextPath, and the REST URI prefix.
|
19:50:41
|
<rafa> shortend: one way is to set these as js variables in a jsp and use these variables in the js file
|
19:51:34
|
<shortend> rafa: Right.
|
19:54:32
|
<andreap> rafa, hi
|
19:54:33
|
<mseaton> dkayiwa: just pushed up a small commit that you'll need.
|
19:54:35
|
<rafa> shortend: have a look at openmrsmessages.js.withjstl
|
19:54:48
|
<dkayiwa> mseaton: ok let me pull
|
19:54:48
|
<mseaton> dkayiwa: i had missed it. fixes a bug in pom that includes dependencies unnecessarily
|
19:54:56
|
<dkayiwa> mseaton: ok
|
19:55:05
|
<rafa> shortend: apparently .withjstl allows you to use jstl in a js file
|
19:55:10
|
<rafa> shortend: I'm not sure when it was added
|
19:55:17
|
<rafa> shortend: meaning which version of OpenMRS
|
19:55:54
|
<rafa> shortend: I have master checked out
|
19:56:22
|
<shortend> rafa: Yeah, I noticed .withjstl when looking through web.xml...
|
19:56:45
|
<shortend> rafa: I'll look into that.
|
19:57:39
|
<rafa> shortend: it may be quite old
|
19:57:41
|
<rafa> shortend: https://tickets.openmrs.org/browse/TRUNK-28
|
19:58:50
|
<andreap> rafa, was looking for you earlier
|
19:58:56
|
<rafa> andreap: hi
|
20:00:04
|
<andreap> rafa, hi - all code for TRUNK-3289 is long done but can't get it to build - also my test data set literally keeps disappearing form project
|
20:00:29
|
<rafa> !ticket TRUNK-3289
|
20:00:30
|
<OpenMRSBot> rafa: [#TRUNK-3289] Delete other order stuff before deleting current order - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3289
|
20:00:47
|
<andreap> rafa, yes
|
20:01:20
|
<rafa> andreap: not sure what you mean that ii keeps disapearing
|
20:01:37
|
<rafa> andreap: what error you get when you build?
|
20:01:41
|
<cpower> hello everyone
|
20:01:52
|
<cpower> Are we ready to scrum?
|
20:01:53
|
<rafa> andreap: hold on scrumtime
|
20:02:11
|
<cpower> !scrumon cpower
|
20:02:11
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
20:02:19
|
<andreap> rafa, ok
|
20:02:25
|
<cpower> a lot of people on today!
|
20:02:39
|
<jkeiper> cpower: welcome to GSoC season
|
20:02:55
|
<dkayiwa> :)
|
20:03:10
|
<cpower> Order: mseaton , rafa , suranga , andreap , djazayeri1 , and wyclif_
|
20:03:23
|
<cpower> jkeiper: indeed I love it!
|
20:04:00
|
<cpower> mseaton: start us off
|
20:04:40
|
<dkayiwa> cpower: since am not listed, i can start :)
|
20:04:42
|
<dkayiwa> Committed: type of data "Text Area" bug - XFRM-131
|
20:04:42
|
<dkayiwa> Did some work on: Table Widget - XFRM-42
|
20:04:42
|
<dkayiwa> Dev Call
|
20:04:43
|
<dkayiwa> Committed: Liquibase fails to change column with foreign key in MySQL 5.6 - TRUNK-3909
|
20:04:43
|
<dkayiwa> Now looking into why sync does not load on standalone
|
20:04:43
|
<dkayiwa> No Blockers
|
20:05:15
|
<cpower> dkayiwa: the list was so long I lost you
|
20:05:17
|
<cpower> sorry
|
20:05:24
|
<dkayiwa> :D
|
20:05:24
|
<cpower> ok rafa
|
20:05:27
|
<rafa> Today:
|
20:05:27
|
<rafa> * Added searches to RESTWS-267: Need to expose concept mappings and related domain objects
|
20:05:27
|
<rafa> https://tickets.openmrs.org/browse/RESTWS-267
|
20:05:27
|
<rafa> * Dev Call
|
20:05:27
|
<rafa> No blockers.
|
20:05:33
|
<mseaton> working on sync ticket cleanup, codebase cleanup, prep for sprint. no blockers.
|
20:05:54
|
<cpower> suranga: you have anything to share?
|
20:06:26
|
<cpower> Next andreap
|
20:06:39
|
<andreap> Wednesday
|
20:06:39
|
<andreap> ticket: TRUNK-3289 Delete other order stuff before deleting current order
|
20:06:39
|
<andreap> Trying to build project with mvn clean install
|
20:06:39
|
<andreap> Thursday
|
20:06:39
|
<andreap> TRUNK-3289 - try to build
|
20:06:40
|
<andreap> Build success with -DskipTests
|
20:06:42
|
<andreap> Blocker - project will not build with mvn clean install
|
20:06:44
|
<andreap> Yesterday: Tests run: 2265, Failures: 0, Errors: 1787, Skipped: 23
|
20:06:46
|
<andreap> Also made test dat set manually, copied to correct directory -
|
20:06:48
|
<andreap> shows up in project when hilte and file->properties - was getting <resource does not exist>
|
20:07:34
|
<cpower> anything else?
|
20:07:58
|
<cpower> djazayeri: or what ever your name is you are next
|
20:08:38
|
<djazayeri1> Working on Mirebalais. Soon, some reports. Particularly, implementing a Diagnosis cohort query in the emr module, to share.
|
20:08:40
|
<djazayeri1> no blockers
|
20:08:47
|
<cpower> and wyclif_
|
20:09:27
|
*** wluyima has joined #openmrs
|
20:09:28
|
<wluyima> Wednesday:
|
20:09:28
|
<wluyima> TODOs for a couple of reviewed tickets
|
20:09:28
|
<wluyima> Review and apply pull requests
|
20:09:30
|
<wluyima> design call
|
20:09:32
|
<wluyima> Thursday:
|
20:09:34
|
<wluyima> dev call
|
20:09:36
|
<wluyima> Meeting with Ada
|
20:09:38
|
<wluyima> Review and apply pull requests
|
20:09:42
|
<wluyima> pick another ticket
|
20:09:44
|
<wluyima>
|
20:09:46
|
<wluyima> Blockers: None
|
20:10:08
|
<cpower> blockers: andrea project will not build with mvn clean install
|
20:10:45
|
<cpower> can someone help her out?
|
20:11:36
|
<rafa> andreap: pastebin the error you get
|
20:11:45
|
<andreap> rafa, ok
|
20:12:22
|
*** shortend has quit IRC
|
20:12:35
|
<andreap> rafa: http://pastebin.com/TYaZUce0
|
20:13:34
|
<rafa> andreap: you have an open file
|
20:13:37
|
<andreap> rafa, ran that with -X
|
20:13:37
|
<rafa> ModuleUtilTest
|
20:13:47
|
<rafa> andreap: you need to close it so that maven can delete it
|
20:14:10
|
<andreap> rafa, ModuleUtilTest where is that?
|
20:14:22
|
<rafa> andreap: org.apache.maven.plugins:maven-clean-plugin:2.4.1:clean (default-clean) on project openmrs-api: Failed to clean project: Failed to delete C:\Users\patandre\workspace\openmrs-core-1\api\target\surefire-reports\org.openmrs.module.ModuleUtilTest.txt
|
20:14:43
|
<rafa> andreap: you just need to close notepad or whatever
|
20:14:52
|
<rafa> andreap: it holds a lock on this file
|
20:16:14
|
<rafa> andreap: you need to read error messages ;)
|
20:16:33
|
*** rfriedman has quit IRC
|
20:16:47
|
<andreap> rafa, weird - let me put up build from yesterday with: Tests run: 2265, Failures: 0, Errors: 1787, Skipped: 23
|
20:17:20
|
<rafa> andreap: why would I be interested in a build from yesterday? :)
|
20:17:23
|
<rafa> andreap: run it now
|
20:17:35
|
<cpower> !scrumoff
|
20:17:35
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
20:18:32
|
*** diadara has quit IRC
|
20:19:21
|
<andreap> rafa, running now - said yesterday because build takes long to run and I'm sure it will fail all those tests - nothing has changed
|
20:20:27
|
<rafa> andreap: yesterday was too long ago to be sure ;)
|
20:20:34
|
<andreap> rafa, does anything need to go into pom.xml or anywhere when creating custom tests manually?
|
20:20:35
|
<sunbiz> cpower: do u know if some1 has taken up the security sprint
|
20:21:11
|
*** dmulindwa has quit IRC
|
20:21:15
|
<rafa> andreap: no
|
20:21:23
|
<cpower> sunbiz: No as far as I'm aware we still need to do a sprint on the security items found
|
20:21:35
|
<rafa> andreap: not sure what you mean by custom tests though
|
20:21:35
|
*** k-joseph has joined #openmrs
|
20:21:52
|
*** kmithemanth has quit IRC
|
20:22:52
|
<andreap> rafa, like DRUG_ORDERS_DATASET_XML
|
20:23:25
|
<andreap> rafa, I made dataset: OBS_THAT_REFERENCE_ORDER_DATASET_XML
|
20:23:33
|
<sunbiz> cpower: I'd like to help with that...
|
20:23:45
|
<rafa> andreap: where did you put the xml?
|
20:24:07
|
<rafa> andreap: path?
|
20:24:10
|
<sunbiz> I've been through DHIS2 security certification based on OWASP... so this is interesting to me
|
20:24:19
|
<andreap> rafa, C:\Users\patandre\workspace\openmrs-core-1\api\target\test-classes\org\openmrs\api\include\
|
20:24:34
|
<rafa> andreap: you can't put files in target
|
20:24:48
|
<rafa> andreap: target is deleted when you run mvn clean
|
20:24:54
|
<cpower> sunbiz: Excellent. As a developer, someone to help build tickets and the plan (ie product owner) or as the lead developer (go to person for technical questions during the sprint)
|
20:25:02
|
<rafa> andreap: it contains compiled classes and resources
|
20:25:56
|
<andreap> rafa, well at least that explains it - where does it go?
|
20:26:18
|
<andreap> rafa, saw the other test like DRUG_ORDERS_DATASET_XML there
|
20:26:18
|
<sunbiz> wasnt there an external organization that did the report
|
20:26:25
|
<rafa> andreap: it should probably go in api\src\test\resources\api\include
|
20:26:27
|
<sunbiz> they might be a better product owner I thnk
|
20:26:47
|
<rafa> andreap: sorry api\src\test\resources\org\openmrs\api\include\
|
20:26:59
|
<sunbiz> cpower: but I'm fine with either of those...
|
20:27:42
|
<cpower> sunbiz: Yes there was a open community that put together a report for us, and I'm sure they will want to be kept in the loop, but we will need people on our side to organize, lead and well do the work.
|
20:27:52
|
<andreap> rafa, could be the problem - will puth there and rebuild
|
20:28:11
|
<rafa> andreap: yeah
|
20:28:35
|
<sunbiz> yes, so I can organize and work on making the tickets and the sprint
|
20:28:50
|
<sunbiz> and solve a few tickets as well...
|
20:29:33
|
<sunbiz> dkayiwa: I just closed that ticket... since you had already merged it. I hope that is fine??
|
20:29:46
|
<dkayiwa> sunbiz: oh yes thanks :)
|
20:29:55
|
<cpower> sunbiz: Sounds good. Could you email me cpower@openmrs.org with a quick note saying your interested in this and when you would have time for this? I'm a little flexible on when the sprint will be, but we do have the next two cycles scheduled
|
20:30:02
|
*** maurya has quit IRC
|
20:30:39
|
<cpower> sunbiz: also helps me remember this conversation tomorrow when I think about it again
|
20:30:46
|
<dkayiwa> mseaton: hi
|
20:31:06
|
<sunbiz> and OpenMRS still installs fine on postgres :)
|
20:31:57
|
*** sgithens_ has joined #openmrs
|
20:32:35
|
<sunbiz> dkayiwa: while mike was talking about standalone I remembered mxj was dead
|
20:32:36
|
*** dmulindwa has joined #openmrs
|
20:32:38
|
<sunbiz> sorry EOL!!
|
20:32:39
|
<downey> hey sgithens_
|
20:32:50
|
<dkayiwa> sunbiz: oh yes :)
|
20:33:07
|
<sunbiz> dkayiwa: so whats the plan with standalone?
|
20:33:32
|
<dkayiwa> sunbiz: not any for now :)
|
20:34:08
|
<dkayiwa> sunbiz: for short run, we have been fixing things ourselves :)
|
20:34:11
|
<OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: OpenMRS UI Framework 2.5.1 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=uiframework&version=&2.5.1>
|
20:35:05
|
<sunbiz> cpower: ok... will remind tomorrow
|
20:35:17
|
<dkayiwa> sunbiz: i was hoping to reach a stage where our liquibase changesets support atlease one inmemory db
|
20:36:42
|
<andreap> rafa, build failed again - will paste it
|
20:36:46
|
<sunbiz> dkayiwa: yea... I tried that once... needed too many changes for derby
|
20:36:57
|
<dkayiwa> sunbiz: ok
|
20:39:03
|
<dkayiwa> rafa: hi
|
20:39:11
|
<rafa> dkayiwa: hi
|
20:39:35
|
<dkayiwa> rafa: do you mind telling me a bit more about the checksum i missed? :)
|
20:40:09
|
<andreap> rafa, never mind - Failed to clean project: Failed to delete C:\Users\patandre\workspace\openmrs-core-1\api\target\surefire-reports\org.openmrs.api.FormServiceTest.txt
|
20:40:23
|
<dkayiwa> rafa: do you mean new changeset?
|
20:40:33
|
<rafa> dkayiwa: if someone ran the old changeset, he'll now get an error because checksums don't match
|
20:41:04
|
<dkayiwa> rafa: oh i see!!!
|
20:41:38
|
<rafa> dkayiwa: if you edit a changeset you must remember to include old and new checksums
|
20:41:40
|
<sunbiz> dkayiwa: yes... I forgot about that too
|
20:41:56
|
<sunbiz> when reviewing the ticket!! :(
|
20:41:57
|
<dkayiwa> rafa: sure :)
|
20:42:01
|
<dkayiwa> sunbiz: :)
|
20:42:51
|
<andreap> rafa, don't understand - it's not open - think I need to restart computer - seems like something is running
|
20:43:12
|
<rafa> andreap: not even in Eclipse?
|
20:43:43
|
*** lauren has joined #openmrs
|
20:43:51
|
<rafa> andreap: alternately you can try mvn install
|
20:43:55
|
<rafa> andreap: without cleaning
|
20:44:07
|
*** lauren is now known as Guest97427
|
20:44:13
|
<rafa> andreap: maybe previous tests are still running....
|
20:44:32
|
*** Guest97427 has quit IRC
|
20:44:56
|
<andreap> rafa, ok will try that -yes thinking previous tests must still be running
|
20:45:06
|
<rafa> andreap: so kill them
|
20:45:38
|
<andreap> rafa, looking in task manager - what are they called?
|
20:45:40
|
<rafa> andreap: look for a process consuming the most CPU in Windows Task Manager ;)
|
20:45:56
|
<mseaton> dkayiwa: hey
|
20:45:58
|
<rafa> andreap: java.exe
|
20:46:05
|
<mseaton> dkayiwa: fyi, i created https://tickets.openmrs.org/browse/SYNC-304
|
20:46:11
|
<rafa> andreap: or javaw.exe
|
20:46:38
|
<dkayiwa> mseaton: i looks as if those sql diffs are not executed in order
|
20:46:59
|
<dkayiwa> mseaton: the type field is first dropped before the insert sql statement
|
20:48:07
|
<mseaton> dkayiwa: odd. any idea why?
|
20:48:52
|
<dkayiwa> mseaton: very odd. no idea. how about removing the type field from the sql insert statment
|
20:49:01
|
<dkayiwa> mseaton: and then you make the field nullable
|
20:50:28
|
<andreap> rafa, just killed java.exe, javaw.exe - did mvn install this time
|
20:50:29
|
<mseaton> dkayiwa: i'm thinking about migrating this to liquibase, and would hope to fix it that way. but i'm still curious.
|
20:50:59
|
<dkayiwa> mseaton: ok
|
20:52:02
|
<mseaton> dkayiwa: interestingly, i see that SqlDiffFileParser uses a treemap with a comparator to figure out the order to run the scripts in - SortedMap<String, String> map = new TreeMap<String, String>(new VersionComparator());
|
20:52:29
|
<dkayiwa> mseaton: oh
|
20:52:34
|
<mseaton> i had another head scratching issue earlier this week while using a treemap with a comparator in the reporting module, where one of the elements was just lost
|
20:52:45
|
<mseaton> dkayiwa: i wonder what the deal is there.
|
20:52:53
|
<dkayiwa> mseaton: ummmm
|
20:53:06
|
<mseaton> dkayiwa: perhaps a java version issue? or sun java vs. openjdk?
|
20:53:22
|
<dkayiwa> mseaton: oh yes that could be :)
|
20:53:31
|
<mseaton> dkayiwa: what version of java is in the standalone?
|
20:53:45
|
<mseaton> or does it use whatever you run it with?
|
20:53:53
|
<dkayiwa> mseaton: it used whatever we run it with
|
20:54:12
|
<mseaton> hmmm. but you see the same issue i see, right?
|
20:54:15
|
<mseaton> dkayiwa: ?
|
20:54:21
|
<dkayiwa> mseaton: yes exactly
|
20:54:24
|
<mseaton> dkayiwa: and you are on a mac?
|
20:54:32
|
<dkayiwa> mseaton: yes 10.6
|
20:54:34
|
<mseaton> dkayiwa: i'm on ubuntu
|
20:54:54
|
<mseaton> dkayiwa: java version "1.6.0_27"
|
20:54:54
|
<mseaton> OpenJDK Runtime Environment (IcedTea6 1.12.3) (6b27-1.12.3-0ubuntu1~12.04.1)
|
20:54:54
|
<mseaton> OpenJDK 64-Bit Server VM (build 20.0-b12, mixed mode)
|
20:55:14
|
<dkayiwa> java version "1.6.0_41"
|
20:55:14
|
<dkayiwa> Java(TM) SE Runtime Environment (build 1.6.0_41-b02-445-10M4107)
|
20:55:15
|
<dkayiwa> Java HotSpot(TM) 64-Bit Server VM (build 20.14-b01-445, mixed mode)
|
20:55:35
|
<mseaton> hmm
|
20:59:58
|
<rafa> dkayiwa: maybe standalone does have the sync_class table...
|
21:00:13
|
<dkayiwa> rafa: it was a fresh install
|
21:00:49
|
<rafa> dkayiwa: did you verify that the column exists?
|
21:01:03
|
<dkayiwa> rafa: in the database?
|
21:01:06
|
<rafa> dkayiwa: yes
|
21:01:13
|
<dkayiwa> rafa: column was already dropped
|
21:01:50
|
<rafa> dkayiwa: I may be looking in a wrong place...
|
21:02:04
|
<rafa> dkayiwa: SYNC-304 is the 0.2 changset
|
21:02:27
|
<rafa> dkayiwa: as I see here https://github.com/openmrs/openmrs-module-sync/blob/master/api/src/main/resources/sqldiff.xml
|
21:02:31
|
<OpenMRSBot> <http://ln-s.net/+mni> (at github.com)
|
21:02:45
|
<rafa> dkayiwa: there's only 0.1 before
|
21:02:51
|
<rafa> dkayiwa: which creates tables
|
21:03:04
|
*** k-joseph has quit IRC
|
21:03:09
|
<dkayiwa> rafa: yes
|
21:03:09
|
<rafa> dkayiwa: am I missing something?
|
21:03:21
|
*** k-joseph has joined #openmrs
|
21:03:34
|
<dkayiwa> rafa: thats exactly what it si
|
21:03:36
|
<dkayiwa> is
|
21:04:05
|
<dkayiwa> rafa: so it looks like <version>0.4</version> is run before <version>0.2</version> :)
|
21:04:48
|
<rafa> dkayiwa: which option in standalone did you use?
|
21:04:50
|
<mseaton> rafa: can you reproduce? this is so similar to my reporting module bug the other day.
|
21:05:09
|
<dkayiwa> rafa: which options ?
|
21:05:23
|
<rafa> dkayiwa: yes, when you start it the first tie
|
21:05:23
|
<dkayiwa> rafa: i used demo data
|
21:05:50
|
<rafa> dkayiwa: that's what I'm saying, maybe demo data has some trash in it
|
21:06:04
|
<dkayiwa> rafa: oh i see
|
21:06:04
|
<rafa> dkayiwa: let me try
|
21:06:07
|
<dkayiwa> rafa: ok
|
21:14:33
|
<sunbiz> does any1 else see a bunch of org.directwebremoting.extend.MarshallException: Error marshalling java.lang.Integer: Format error converting Patient#3 errors like this
|
21:14:41
|
<sunbiz> there are many Marshalling errors happening for me
|
21:14:53
|
<mseaton> rafa: you genius!!
|
21:15:16
|
<downey> the demo data definitely has a lot of trash in it
|
21:15:18
|
<downey> :)
|
21:15:26
|
<mseaton> dkayiwa: firing up the standalone without any demo data or anything, i have tables there for sync, smartcontainer, etc
|
21:15:30
|
<downey> nribeka ^
|
21:15:38
|
<dkayiwa> mseaton: oh
|
21:15:43
|
<mseaton> dkayiwa: oops
|
21:16:00
|
<dkayiwa> mseaton: how did they get there???
|
21:16:28
|
<downey> I had to remove a scheduled reporting task to get it to work with 1.9.2+
|
21:16:33
|
<dkayiwa> mseaton: may be it is sharing the appdata folder with another instance???
|
21:16:33
|
<mseaton> dkayiwa: maybe i'm looking at the wrong one. i'm going to try again.
|
21:16:45
|
<dkayiwa> mseaton: ok
|
21:16:51
|
<jkeiper> mseaton, dkayiwa: downey had that problem earlier this week
|
21:17:01
|
<dkayiwa> jkeiper: oh
|
21:17:05
|
<downey> jkeiper: s/this/last/
|
21:17:05
|
<mseaton> downey: there are no user-visible scheduled tasks in reporting, so must be a stale one
|
21:17:11
|
<downey> mseaton: right
|
21:17:39
|
<rafa> mseaton, dkayiwa: I chose demostration mode and see sync tables
|
21:17:47
|
<dkayiwa> rafa: oh
|
21:18:15
|
<mseaton> rafa: dkayiwa ok, so it's not just me. cool. i guess we need to fix our setup scripts in the standalone
|
21:18:27
|
<dkayiwa> mseaton: sure
|
21:19:15
|
<rafa> sunbiz: can you pastebing the full stacktrace?
|
21:19:32
|
<rafa> sunbiz: where does it come from?
|
21:19:47
|
<mseaton> dkayiwa: so i have sync tables but no sync global properties (including no database_version)
|
21:20:01
|
<dkayiwa> mseaton: ok
|
21:20:12
|
*** robbyoconnor has joined #openmrs
|
21:20:12
|
*** ChanServ sets mode: +v robbyoconnor
|
21:20:19
|
<dkayiwa> mseaton: looks like our demo data has sync tables
|
21:21:00
|
<jkeiper> mseaton: i'm depending on reporting-api:0.7.5 in my module and context-related tests fail with this kind of error: http://pastebin.com/0LVPjanv
|
21:21:49
|
<jkeiper> mseaton: essentially saying BaseCalculation is missing ... not sure why that matters to my module ...
|
21:22:02
|
<jkeiper> mseaton: already deleted my local repo and tried a clean install
|
21:22:29
|
<sunbiz> rafa: I figured it was because of the Webservices.rest module
|
21:22:33
|
<rafa> jkeiper: you need to add calculation-api with test scope to pom.xml
|
21:22:34
|
<mseaton> jkeiper: just include the calculation api in your pom
|
21:22:39
|
<sunbiz> I removed the module and its working fine now
|
21:22:53
|
<jkeiper> rafa, mseaton: thanks!
|
21:23:05
|
<rafa> sunbiz: which version of webservices.rest?
|
21:23:11
|
<mseaton> rafa: any reason why test scope and not provided scope?
|
21:23:24
|
<rafa> mseaton: not much difference in this case
|
21:23:28
|
<sunbiz> I had made some custom changes to it Im guessing
|
21:23:38
|
<sunbiz> so... I am reverting all the changes
|
21:23:47
|
<sunbiz> and pulling the latest and checking
|
21:23:51
|
<rafa> mseaton: provided scope is if you want to reference calculation classes in your code
|
21:24:00
|
<mseaton> rafa: dkayiwa - what's our policy / process for releasing a new standalone for a released version of openmrs?
|
21:24:13
|
<jkeiper> rafa, mseaton: actually, I'm already depending on calculation-api:1.0 with scope=provided ... need to also include it as scope=test?
|
21:24:20
|
<dkayiwa> mseaton: we can just replace the 1.9.3 one
|
21:24:27
|
<rafa> jkeiper: no that should be enough...
|
21:24:31
|
<mseaton> dkayiwa: ok.
|
21:24:38
|
<jkeiper> rafa: in that case, I still have the probelm
|
21:24:54
|
<rafa> jkeiper: is your test in omod or api?
|
21:25:03
|
<mseaton> dkayiwa: rafa: andy had pinged me about whether or not i updated the mvp dictionary in the standalone when i did the original release (i didn't). might want to check on that.
|
21:25:21
|
<mseaton> thoughts on whether we should do this?
|
21:25:30
|
<rafa> mseaton: I think I answered you
|
21:25:38
|
<rafa> mseaton: and updated the release pages to do this
|
21:25:42
|
<rafa> mseaton: but next time ;)
|
21:25:46
|
<dkayiwa> :)
|
21:25:53
|
<jkeiper> rafa: ah, i didn't include calculation in the api pom ... trying that out
|
21:25:57
|
<mseaton> rafa: yes, but if we are _now_ going to re-do the 1.9.3 standalone due to this bug, then we could get it in.
|
21:26:10
|
<mseaton> that's my question
|
21:27:11
|
*** wyclif_ has quit IRC
|
21:27:16
|
<rafa> mseaton: yeah, if we are going to redo then it's best to ask Andy what to include
|
21:27:37
|
<jkeiper> rafa, mseaton: FYI including calculation-api in the api pom dependencies fixed the problem, thx
|
21:27:50
|
<mseaton> jkeiper: np
|
21:27:51
|
<rafa> np
|
21:29:09
|
*** wluyima has quit IRC
|
21:29:12
|
<rafa> mseaton: we don't have a separate process for releasing standalone...
|
21:30:08
|
<rafa> mseaton: we don't even version standalone properly
|
21:30:16
|
<rafa> mseaton: it's a bit messy thing ;)
|
21:30:31
|
<mseaton> rafa: yeah. it would be nice to be able to have different standalone versioning from openmrs core versioning. that would also allow us to release new standalones if things other than core change - mvp dictionary versions, module versions, etc.
|
21:30:54
|
<mseaton> rafa: any reason we can't just start a new line of version numbers ?
|
21:31:35
|
<mseaton> rafa: dkayiwa: i'll create a ticket for this issue in the standalone project. i'll mail the dev list regarding versioning and release process issues.
|
21:31:36
|
<rafa> mseaton: I think it's time for that ;)
|
21:31:48
|
<dkayiwa> mseaton: ok
|
21:32:12
|
<rafa> mseaton: the one problem with standalone is that it is currently built for a specific version of OpenMRS
|
21:32:37
|
<rafa> mseaton: so if we are to release a new version of standalone we would have to release it for all supported OpenMRS versions
|
21:32:55
|
<rafa> mseaton: it's because of the way we include demo and mvp data
|
21:32:56
|
<mseaton> rafa: i don't see why.
|
21:34:05
|
<dkayiwa> mseaton: rafa i also do not see why :)
|
21:34:20
|
<rafa> mseaton: so the demo data is now broken for all OpenMRS releases
|
21:34:41
|
<dkayiwa> rafa: how about fixing it only for the latest?
|
21:35:19
|
<downey> rafa: The version discussion happened on the dev list 21 June 2011
|
21:35:26
|
<mseaton> rafa: it's not like people update their standalone instances. once they have one, they need to work with the one they have. it's really for people starting from scratch. and i think it's fine for us to say that we maintain the latest version.
|
21:35:52
|
<downey> rafa: Actually it wasn't on dev@o.o looks like it was a private thread
|
21:36:43
|
<rafa> okay, I definitely like less work :D
|
21:36:53
|
<dkayiwa> rafa: me too :)
|
21:37:00
|
<rafa> so releasing just the latest is fine
|
21:37:35
|
<dkayiwa> rafa: and the bug is a problem only for the very few that use sync :)
|
21:37:53
|
<rafa> dkayiwa: I don't think anyone brave enough to use sync uses standalone :D
|
21:38:02
|
<dkayiwa> rafa: hahahahah :)
|
21:38:24
|
<dkayiwa> rafa: mseaton becomes the bravest. anyway he is just testing :)
|
21:40:18
|
<mseaton> dkayiwa: and rafa just wait until next week! you'll have your turn at being brave trying to set up a dev environment where you can test out sync :)
|
21:40:42
|
<dkayiwa> mseaton: hahaha :D
|
21:40:47
|
<mseaton> dkayiwa: https://tickets.openmrs.org/browse/STAND-67
|
21:40:56
|
<dkayiwa> mseaton: ok thanks
|
21:41:06
|
<mseaton> if i got anything wrong there, feel free to correct.
|
21:41:30
|
<rafa> mseaton: haha I'm on vacation :D
|
21:41:41
|
<mseaton> doh!
|
21:41:53
|
<dkayiwa> rafa: one day another sprint will come up syncy :)
|
21:42:34
|
*** wluyima has joined #openmrs
|
21:42:55
|
*** wyclif_ has joined #openmrs
|
21:43:54
|
*** dmulindwa has quit IRC
|
21:47:35
|
<andreap> rafa, would you believe that build just finished Tests run: 2231, Failures: 0, Errors: 1753, Skipped: 23
|
21:48:45
|
<rafa> andreap: that was long :D
|
21:48:52
|
<rafa> andreap: pastebin
|
21:49:05
|
<rafa> andreap: though I'm pretty tired and need to run in a sec
|
21:51:04
|
<rafa> andreap: ?
|
21:51:58
|
<dkayiwa> she could be pretty tired too :)
|
21:52:06
|
<rafa> yeah
|
21:52:18
|
<rafa> ok time for me
|
21:52:21
|
<rafa> see you tomorro!
|
21:52:24
|
<andreap> rafa. pastebin just had a problem - just tried again - think it's too big
|
21:52:57
|
<rafa> andreap: sorry I'm going off-line
|
21:53:01
|
*** dmulindwa has joined #openmrs
|
21:53:10
|
*** rafa has quit IRC
|
21:53:31
|
<andreap> rafa, ok - lots of failing tests -
|
21:56:35
|
*** mseaton has left #openmrs
|
22:04:12
|
*** dmulindwa has quit IRC
|
22:11:26
|
*** dmulindwa has joined #openmrs
|
22:25:12
|
*** sunbiz has quit IRC
|
22:32:45
|
*** dkayiwa_ has joined #openmrs
|
22:34:09
|
*** dkayiwa has quit IRC
|
22:34:09
|
*** dkayiwa_ is now known as dkayiwa
|
22:49:04
|
*** suranga has quit IRC
|
22:49:30
|
*** Anuruddha has joined #openmrs
|
22:53:39
|
*** Anuruddha has quit IRC
|
23:10:09
|
*** dmulindwa has quit IRC
|
23:15:42
|
*** dmulindwa has joined #openmrs
|
23:25:58
|
*** dmulindwa has quit IRC
|
23:28:43
|
*** dmulindwa has joined #openmrs
|
23:32:32
|
*** dkayiwa has quit IRC
|
23:35:44
|
*** andreap has quit IRC
|
23:36:25
|
<andrea___> djazayeri1,you here?
|
23:37:47
|
<djazayeri1> andrea___: yes
|
23:39:06
|
<andrea___> djazayeri1, have finished all code, tests and test datasets for TRUNK-3289 Delete other order stuff before deleting current order
|
23:39:35
|
<andrea___> djazayeri1, but haven't been able to get clean build
|
23:40:16
|
<andrea___> djazayeri1, just commented out all my code to see if build still fails - it does
|
23:41:07
|
<andrea___> djazayeri1, Tests run: 2264, Failures: 0, Errors: 1786, Skipped: 23 - what could be causing this?
|
23:41:42
|
<djazayeri1> andrea___: what are the error messages? With that many errors I would assume there's one wrong xml file somewhere that's breaking everything
|
23:44:21
|
<andrea___> djazayeri, put some of it here: http://pastebin.com/d4m428sB
|
23:51:01
|
<djazayeri1> andrea___: the full stack trace is relevant here, I think.
|
23:54:55
|
*** dmulindwa has quit IRC
|
23:57:41
|
<andrea___> dajazayeri, pastebin gets error when you paste in the trace - too big
|