IRC Chat : 2013-02-28 - OpenMRS

00:20:51 *** Jevity has joined #openmrs
00:21:10 *** Jevity has quit IRC
00:27:07 *** wyclif_ has joined #openmrs
00:27:07 *** wyclif has quit IRC
00:53:02 *** andreapat has quit IRC
00:58:29 *** dmulindwa has joined #openmrs
01:01:58 *** GitHub59 has joined #openmrs
01:01:58 <GitHub59> [openmrs-core] mseaton opened pull request #228: 1.9.x - Backport for TRUNK-3551: Merging persons incorrectly handles addresses and names (1.9.x...1.9.x) http://git.io/AIBGuQ
01:01:58 *** GitHub59 has left #openmrs
01:03:16 *** GitHub50 has joined #openmrs
01:03:16 <GitHub50> [openmrs-core] mseaton pushed 3 new commits to 1.9.x: http://git.io/lC-RMw
01:03:16 <GitHub50> openmrs-core/1.9.x a402549 Tom Ryan: TRUNK-3551 Merging Person and Address. Cherry-picking Tom Ryan's commit and fixing some failing unit tests...
01:03:16 <GitHub50> openmrs-core/1.9.x 2d8af36 Michael Seaton: TRUNK-3551 Merging Person and Address. Remove references to commons lang3 from import...
01:03:16 <GitHub50> openmrs-core/1.9.x aaee716 Michael Seaton: Merge pull request #228 from mseaton/1.9.x...
01:03:16 *** GitHub50 has left #openmrs
01:05:47 *** downey sets mode: +o djazayeri
01:05:47 *** ChanServ sets mode: -o djazayeri
01:25:00 *** Anuruddha has joined #openmrs
01:44:24 *** Castaldo has joined #openmrs
01:47:15 *** dmulindwa has quit IRC
01:56:57 *** djazayeri has quit IRC
02:02:27 *** Castaldo has left #openmrs
02:02:29 *** rkorytkowski has joined #openmrs
02:02:29 *** rkorytkowski is now known as rafa
02:02:29 *** ChanServ sets mode: +v rafa
02:19:16 *** rafa has quit IRC
02:22:36 *** Echidna_ has quit IRC
02:32:12 *** dmulindwa has joined #openmrs
02:38:59 *** Echidna has joined #openmrs
02:38:59 *** ChanServ sets mode: +v Echidna
03:08:00 *** harsz89 has joined #openmrs
03:11:13 *** DraggonZ has joined #openmrs
03:12:51 *** jkeiper has joined #openmrs
03:12:51 *** ChanServ sets mode: +v jkeiper
03:26:26 *** r0bby has joined #openmrs
03:26:26 *** ChanServ sets mode: +v r0bby
03:35:07 *** Anuruddha has quit IRC
03:35:23 *** dmulindwa has quit IRC
03:51:19 *** r0bby has quit IRC
03:52:20 *** wyclif_ has quit IRC
03:52:30 *** r0bby has joined #openmrs
03:52:30 *** ChanServ sets mode: +v r0bby
03:57:37 *** wyclif has joined #openmrs
04:05:47 *** GitHub92 has joined #openmrs
04:05:47 <GitHub92> [openmrs-core] DraggonZ opened pull request #229: Program state change displays wrong date in IE8 TRUNK-3482 (master...TRUNK-3482) http://git.io/BIhvwA
04:05:47 *** GitHub92 has left #openmrs
04:11:01 *** r0bby has quit IRC
04:12:53 *** mseaton has quit IRC
04:21:56 *** GitHub189 has joined #openmrs
04:21:56 <GitHub189> [openmrs-core] DraggonZ opened pull request #230: Patient Dashboard - Allergy shows as year 3912 in place of 2012 TRUNK-35... (master...TRUNK-3561) http://git.io/gAge7Q
04:21:56 *** GitHub189 has left #openmrs
04:42:47 *** harshadura has joined #openmrs
04:50:17 *** DraggonZ has left #openmrs
04:50:29 *** DraggonZ has joined #openmrs
04:50:44 *** DraggonZ has left #openmrs
05:07:50 *** shangxiao has joined #openmrs
05:17:57 *** r0bby has joined #openmrs
05:17:57 *** ChanServ sets mode: +v r0bby
05:22:15 *** r0bby_ has joined #openmrs
05:22:15 *** ChanServ sets mode: +v r0bby_
05:23:30 *** r0bby has quit IRC
05:32:57 *** ChanServ sets mode: +v harshadura
05:41:48 *** r0bby_ is now known as robbyoconnor
05:52:30 *** djadmin has joined #openmrs
05:52:36 *** dmulindwa has joined #openmrs
06:02:18 *** djazayeri has joined #openmrs
06:02:18 *** ChanServ sets mode: +o djazayeri
06:27:51 *** Hasintha_i has joined #openmrs
06:28:40 *** djadmin has quit IRC
06:34:20 *** djadmin has joined #openmrs
06:53:21 *** evmw has joined #openmrs
07:10:07 *** ibewes has joined #openmrs
07:16:49 *** johnsu01 has left #openmrs
07:19:18 *** dmulindwa has quit IRC
07:25:25 *** dmulindwa has joined #openmrs
07:27:38 *** djazayeri has quit IRC
07:34:17 *** dmulindwa has quit IRC
07:41:05 *** dmulindwa has joined #openmrs
07:41:29 *** harshadura has quit IRC
07:42:40 *** harshadura has joined #openmrs
07:52:30 *** shangxiao has quit IRC
07:56:57 *** shangxiao has joined #openmrs
07:58:09 *** shangxiao has quit IRC
08:05:03 *** djazayeri has joined #openmrs
08:05:03 *** ChanServ sets mode: +o djazayeri
08:21:56 *** djazayeri has quit IRC
08:27:46 *** dkayiwa has joined #openmrs
08:40:17 *** peacefulboy has joined #openmrs
08:42:22 *** djadmin has quit IRC
08:47:11 *** DraggonZ has joined #openmrs
08:48:38 *** djadmin has joined #openmrs
08:54:42 *** shangxiao has joined #openmrs
08:55:03 <peacefulboy> Hello -^^ I just started to study OpenMRS and I wanna know What Languages or skill should i learn before analyzing each modules in OpenMRS. Could you help me with this situation ? thanks!
08:58:49 <dkayiwa> peacefulboy, when you type, include my irc name such that my irc client alerts me
08:59:04 <dkayiwa> peacefulboy, that way you do not have to wait for hours before i respond to you :)
08:59:37 <dkayiwa> peacefulboy, the major language will be Java. Do you have any Java experience?
08:59:51 *** djadmin has quit IRC
09:01:20 <peacefulboy> dkayiwa, like this ~ ?
09:01:35 <dkayiwa> peacefulboy, excellent!!! :)
09:02:20 <peacefulboy> dkayiwa, thanks -^^. Yes I have developed some application by JAVA and also Android programming
09:02:56 <dkayiwa> peacefulboy, oh great
09:03:11 <dkayiwa> peacefulboy, do you already have openmrs running?
09:03:34 <peacefulboy> dkayiwa, so I'm sort of novice in Java but I think I can understand the code and the structure
09:04:03 <peacefulboy> dkayiwa, yes I have a server pc and already installed openmrs core here
09:04:23 <dkayiwa> peacefulboy, is it running?
09:04:55 <peacefulboy> dkaywa, yes it is~. but when i try to run another module, it occurs error
09:13:26 <dkayiwa> peacefulboy, i did not immediately see your last comment because you misspelled my name :)
09:13:36 <dkayiwa> peacefulboy, which IRC client are you using?
09:16:59 <peacefulboy> dkayiwa, IRC client ~?
09:17:19 <peacefulboy> dkayiwa, I'm sorry I have know idea about IRC client
09:17:44 <dkayiwa> peacefulboy, have you had a chance to look at our IRC wiki page?
09:21:30 *** sashrika has joined #openmrs
09:25:50 <peacefulboy> dkayiwa, not yet should I do it first ? :)
09:28:51 <dkayiwa> peacefulboy, yes
09:29:04 *** shangxiao has quit IRC
09:29:19 <peacefulboy> dkayiwa, alright I see
09:54:41 *** rkorytkowski has joined #openmrs
09:54:41 *** rkorytkowski is now known as rafa
09:54:41 *** ChanServ sets mode: +v rafa
09:54:51 *** shangxiao has joined #openmrs
09:57:10 *** dmulindwa has quit IRC
09:58:22 *** shangxiao has quit IRC
09:59:07 *** dmulindwa has joined #openmrs
10:00:09 <harshadura> hi rafa, pls dont get offended with me cz of my latency to submit the commit on my ticket, srry again
10:02:05 <rafa> harshadura: Hello! It's all good. Actually, I feel sorry every time I need to reclaim ticket, but we do have deadlines in open-source too :( so I needed to make sure that the functionality works.
10:04:07 <rafa> harshadura: again I'm sorry I didn't let you finish
10:04:52 <harshadura> its ok rafa, i understand
10:09:53 <dmulindwa> dkayiwa: Did you get a chance to look at my paste?
10:11:12 <dkayiwa> dkayiwa, looking at it shortly
10:12:00 *** shangxiao has joined #openmrs
10:12:00 <dmulindwa> dkayiwa. thanx will wait
10:12:43 <dkayiwa> dmulindwa, in the meantime feel free to jump onto another ticket :)
10:13:19 *** shortend has joined #openmrs
10:14:15 <dmulindwa> dkayiwa: am doing some preparation work on another ticket..download module and all..
10:14:57 <shangxiao> OpenMRS technology stack diagram for our module: https://plus.google.com/109401790963003582870/posts/iJDJpLsJyps
10:14:59 <OpenMRSBot> <http://ln-s.net/+je4> (at plus.google.com)
10:15:19 <dkayiwa> dmulindwa, ok cool
10:20:53 *** sashrika has quit IRC
10:24:33 *** harshadura has quit IRC
10:25:14 *** sashrika has joined #openmrs
10:25:48 <peacefulboy> dkayiwa, I still couldnt' find that one but I 'll try again tom^^, thanks for today
10:26:17 <dkayiwa> peacefulboy, ok
10:30:02 *** peacefulboy has quit IRC
10:37:49 *** Hasintha_i has quit IRC
10:38:47 *** ruks has joined #openmrs
10:40:41 <sashrika> nb
10:58:24 *** dmulindwa has quit IRC
11:11:25 *** dkayiwa has quit IRC
11:17:32 *** ruks has quit IRC
11:19:37 *** sashrika has quit IRC
11:21:16 *** applecool has joined #openmrs
11:21:16 *** ChanServ sets mode: +v applecool
11:34:13 *** shangxiao is now known as mango-hot
11:34:32 <mango-hot> yeah fruits with different temperature :D
11:37:02 *** dmulindwa has joined #openmrs
11:48:38 <DraggonZ> hello everyone!
11:48:52 *** mango-hot has quit IRC
11:49:14 <DraggonZ> Where I can find all OpenMRS Adobe Connect Playbacks?
11:56:48 *** evmw has quit IRC
11:58:12 *** dmulindwa has quit IRC
12:05:52 *** dmulindwa has joined #openmrs
12:06:18 *** kishoreyekkanti has joined #openmrs
12:13:00 *** evmw has joined #openmrs
12:14:44 *** kishoreyekkanti has quit IRC
12:15:08 *** robbyoconnor has quit IRC
12:17:28 *** kishoreyekkanti has joined #openmrs
12:19:32 *** xx_ has joined #openmrs
12:20:05 *** dmulindwa has quit IRC
12:26:30 *** kprochazka has joined #openmrs
12:30:34 *** dmulindwa has joined #openmrs
12:34:15 *** xx_ has quit IRC
12:35:16 <kprochazka> whois kprochazka
12:45:27 *** dmulindwa has quit IRC
12:54:13 *** thompcha has joined #openmrs
12:55:56 *** shangxiao has joined #openmrs
12:56:46 *** KHAYAM has joined #openmrs
12:58:07 <KHAYAM> I want to extract all string names(fields) in a class. How we can do this
13:01:31 *** evmw has quit IRC
13:03:23 *** shangxiao has quit IRC
13:08:14 *** jkeiper has quit IRC
13:08:29 *** djadmin has joined #openmrs
13:09:55 *** shangxiao has joined #openmrs
13:12:19 *** harsz89 has quit IRC
13:20:22 *** djadmin has quit IRC
13:23:14 *** KHAYAM has quit IRC
13:24:44 *** harsz89 has joined #openmrs
13:26:02 *** KAYAM has joined #openmrs
13:27:18 *** KAYAM has quit IRC
13:28:46 *** dkayiwa has joined #openmrs
13:29:08 *** khayamuddin31 has joined #openmrs
13:31:11 *** khayamuddin31 has quit IRC
13:42:55 *** evmw has joined #openmrs
13:49:18 *** wyclif has quit IRC
13:55:50 *** rfriedman has joined #openmrs
13:56:16 <rfriedman> hi rafa, bet you're busy getting ready for dog and pony show
13:56:25 <rafa> rfriedman: haha
13:56:46 <rafa> rfriedman: yes, trying to clean up the review queue ;)
13:57:29 *** mseaton has joined #openmrs
13:57:29 *** ChanServ sets mode: +v mseaton
13:57:30 <rfriedman> rafa, conceptreferencemap.java, .hbm.xml don't implement the term_a, term_b relationships as shown in the data model
13:58:10 <rafa> rfriedman: can you explain?
13:58:25 <rfriedman> they only implement the equivalent of term_a
13:59:02 <rfriedman> that is, the collection of concept reference term maps in concept reference contains only those where the term is the a-side of the map
13:59:31 <rafa> rfriedman: wait are you saying something is wrong in core or restws?
13:59:47 <rfriedman> rafa, in core
14:00:39 <rfriedman> rafa, so rest doesn't do anything to repair this
14:01:22 <rafa> rfriedman: what do you mean they don't implement the term_a, term_b relationships as shown in the data model
14:01:40 <rafa> rfriedman: what data model?
14:01:44 <rafa> rfriedman: have some link?
14:01:58 <rfriedman> rafa, the reference term has only one collection of term maps, containing those which are the a-side of the term map
14:02:17 <rfriedman> rafa, the data model shows two collections, one for each
14:02:17 <rafa> rfriedman: I'm not sure where you're looking but I see
14:02:22 <rafa> <many-to-one name="termA" class="ConceptReferenceTerm" column="term_a_id" not-null="true" />
14:02:22 <rafa> <many-to-one name="termB" class="ConceptReferenceTerm" column="term_b_id" not-null="true" />
14:03:13 <rfriedman> this is what i see:
14:03:13 <rfriedman> <set name="conceptReferenceTermMaps" inverse="true" cascade="all-delete-orphan, delete">
14:03:13 <rfriedman> <key column="term_a_id" not-null="true" />
14:03:13 <rfriedman> <one-to-many class="ConceptReferenceTermMap" />
14:03:13 <rfriedman> </set>
14:03:43 <rfriedman> i think you are looking in concept reference term map, I am looking at concept reference term
14:03:48 <rafa> rfriedman: you're looking at ConceptReferenceTerm
14:03:51 <rafa> rfriedman: correct
14:04:18 *** mseaton has quit IRC
14:04:28 <rafa> rfriedman: it does look smelly
14:04:50 <rafa> rfriedman: it's supposed to be undirectional relation
14:04:54 <rfriedman> rafa, i had made a single set that contained both a-side and b-side term maps
14:05:19 <rfriedman> rafa, but burke wanted two separate sets
14:05:19 <rafa> rfriedman: so all maps should be included that contain this reference term as term_a or term_b
14:05:37 <rfriedman> rafa, that's what i did but burke wanted them separate
14:06:13 <rafa> rfriedman: I think you should speak to wyclif, maybe he knows what's up with that
14:06:33 <rafa> rfriedman: I wasn't involved in these changes at all
14:06:49 <rafa> rfriedman: so it's hard to me to speak about the reasoning
14:06:57 <rafa> rfriedman: but still it doesn't look right...
14:07:12 <rfriedman> rafa, sry, thot you had done 2 and wyclif 2
14:07:59 <rafa> rfriedman: I think it was before I started to work for OpenMRS :)
14:08:22 <rfriedman> rafa, haha, you wish
14:08:47 <rafa> rfriedman: seriously :P
14:09:44 <rfriedman> rafa, there's an exchange on 267 on 2/14 about it
14:09:56 *** kishoreyekkanti has quit IRC
14:10:04 *** jkeiper has joined #openmrs
14:10:04 *** ChanServ sets mode: +v jkeiper
14:10:24 <rfriedman> rafa, don't worry, I'll write an e-mail, we can deal with it after scrum
14:10:39 <rfriedman> rafa, 2 pm ET today, right?
14:11:13 <rafa> rfriedman: yeah, something like that
14:12:19 <rafa> rfriedman: I don't think restws should fix that
14:12:23 <rafa> rfriedman: it must be fixed in core
14:14:07 <rfriedman> rafa, agreed, but when?
14:14:37 <rfriedman> rafa, if they are trying to get out 9.3 or whatever, we should move
14:15:02 <rafa> rfriedman: 1.9.3 will be out tomorrow ;)
14:15:17 <rfriedman> rafa, yes, but it won't work right away ;)
14:15:19 <rafa> rfriedman: do we even have a ticket for that?
14:15:40 <rfriedman> rafa, it's always been addressed in the context of 267
14:15:42 <rafa> rfriedman: I don't think conceptreferencetermmaps are used by anyone yet
14:15:51 <rafa> rfriedman: not by MVP
14:16:56 <rfriedman> rafa, well, it's their feature so what me worry
14:16:57 <rafa> rfriedman: I don't see anyone mentioning there's something wrong with conceptReferenceTermMaps there
14:17:09 *** mseaton has joined #openmrs
14:17:09 *** ChanServ sets mode: +v mseaton
14:17:51 <rafa> rfriedman: ohh actually found something you posted :)
14:17:57 <rafa> rfriedman: 1. Darius writes to Andy Kanter on dev list to get discussion going about why ConceptReferenceTermMaps are not bidirectional.
14:18:18 <rafa> rfriedman: so it's actually intentional...
14:19:40 <rafa> rfriedman: it's just that we can't access both directions from ConceptReferenceTerm right now
14:20:22 <rfriedman> rafa, that may be a different discussion ... the map types are not all reflexive like mother <-> daughter, there are things like directionality
14:20:45 <rafa> rfriedman: ok, I stop speculating then
14:20:55 <rafa> rfriedman: I'm not familiar with this at all
14:21:11 <downey> DraggonZ: Did you ever find your recorded Adobe Connect meetings?
14:21:30 <rfriedman> rafa, my code dealing with this is attached to 267
14:22:48 <rfriedman> rafa, i will e-mail the list -- what was the date of the darius-kanter post?
14:23:35 <rafa> rfriedman: I see something like conceptReferenceTermCrossmaps in your patch
14:23:58 <rafa> rfriedman: is this how you deal with the issue?
14:24:11 <rfriedman> rafa, yes, crossmaps is my name for b-side
14:24:22 <rafa> rfriedman: it wasn't reflected in diagrams
14:24:40 <rafa> rfriedman: I mean the final diagram
14:24:42 <rfriedman> rafa, it's the big difference between v.3 and v.4
14:25:37 <rafa> rfriedman: hmmm I see your point
14:27:04 <rafa> rfriedman: it looks like a quick change
14:27:17 <rfriedman> rafa, in any case, it's bigger than both of us, might as well sit tight until the e-mail goes out
14:27:41 <rafa> rfriedman: agree
14:31:09 <shangxiao> dog and pony show?
14:32:34 <downey> shangxiao: See: http://en.wikipedia.org/wiki/Dog_and_pony_show :-)
14:33:18 <shangxiao> lol
14:33:43 <shangxiao> so rafa i've been meaning to tell you that the omod reloader only seems to sometimes work
14:33:58 <shangxiao> occasionally it says "Error opening zip file"
14:34:14 <rafa> shangxiao: I haven't seen that, what OS are you using?
14:34:40 <shangxiao> Mint (debian)
14:35:01 <rafa> shangxiao: it sounds like it tries to reload an omod while it's still being created
14:35:11 <shangxiao> yes that's what I thought too
14:35:25 <rafa> shangxiao: I didn't add any delay...
14:35:51 <rafa> shangxiao: so as soon as the OS reports a file changed, it's picked up
14:36:03 <shangxiao> yes I saw your code :)
14:36:06 <rafa> shangxiao: patches welcome :)
14:36:17 <shangxiao> lol ok i'll have a play
14:36:57 <shangxiao> i needed to bring it up here though because you don't have issues enabled on GH ;)
14:37:07 <rafa> shangxiao: ohh, let me fix that
14:37:43 <rafa> shangxiao: done
14:38:37 *** wyclif has joined #openmrs
14:44:58 *** shangxiao has quit IRC
14:46:24 *** sashrika has joined #openmrs
14:46:27 *** ibewes has quit IRC
14:53:51 <downey> !devmtg
14:53:52 <OpenMRSBot> downey: "devmtg" --- Reminder: Developer Forum Thursday at 10:00 AM Eastern Time - https://wiki.openmrs.org/display/RES/Developers+Forum
14:54:48 <downey> dkayiwa: Were you able to make contact with Dan via e-mail?
14:56:58 <dkayiwa> downey, yes. He even came today on IRC :)
14:57:31 <downey> dkayiwa: cool, thanks again
14:59:02 *** dmulindwa has joined #openmrs
15:05:38 *** wyclif has quit IRC
15:05:48 *** djazayeri has joined #openmrs
15:05:48 *** ChanServ sets mode: +o djazayeri
15:11:58 *** djadmin has joined #openmrs
15:14:05 *** supungs has joined #openmrs
15:19:06 *** Areo has joined #openmrs
15:21:57 *** wyclif has joined #openmrs
15:32:41 *** shangxiao has joined #openmrs
15:32:58 *** cpower has quit IRC
15:33:55 *** cpower has joined #openmrs
15:38:05 *** cpower_ has joined #openmrs
15:39:50 <Areo> HI all, How to change ticket status from Waiting for Info to In-Progress? I can't find this in UI :)
15:40:36 *** cpower has quit IRC
15:47:20 <OpenMRSBot> Recent updates in the world of openmrs: Shazin Sadakath: Android Jelly Bean and Arduino Uno Communication with USB Shield <http://shazsterblog.blogspot.com/2013/02/android-jelly-bean-and-arduino-uno.html>
15:49:12 *** sashrika has quit IRC
15:50:29 <downey> hrm
16:01:10 *** DraggonZ has left #openmrs
16:02:13 <rafa> Areo: which ticket?
16:02:33 <Areo> Trunk-3204
16:03:23 *** supungs has left #openmrs
16:10:30 *** andrea_ has joined #openmrs
16:10:43 *** andrea_ is now known as andreap_
16:13:30 *** kprochazka has quit IRC
16:21:05 *** ekow has joined #openmrs
16:22:55 <ekow> Please help. Its 3 days and I cannot take this anymore. Mvn build in eclipse has been resulting in the following error. I swear I have /maven/jetty in eclipse and also maven installed. Please help..
16:23:18 <downey> ekow: What is the error?
16:27:56 *** sashrika has joined #openmrs
16:27:57 *** evmw has quit IRC
16:33:12 *** cpower_ has quit IRC
16:34:39 <Areo> rafa: https://tickets.openmrs.org/browse/TRUNK-3204, Thanks
16:35:06 *** cpower_ has joined #openmrs
16:37:46 <rafa> Areo: I changed it to ready for work
16:38:14 *** jkeiper has quit IRC
16:39:12 *** wyclif has quit IRC
16:46:02 *** harshadura has joined #openmrs
16:50:17 *** kprochazka has joined #openmrs
16:52:22 *** wyclif has joined #openmrs
16:53:51 *** sashrika has quit IRC
16:54:28 *** sashrika has joined #openmrs
17:01:24 <dkayiwa> hi dmulindwa
17:05:53 *** kishoreyekkanti has joined #openmrs
17:06:59 <dmulindwa> dkayiwa hi..hope am aot replying after an hour
17:07:27 <dkayiwa> dmulindwa, which irc client are you using? :)
17:07:54 <dmulindwa> dkatiwa : xchat..but its all new to me
17:09:02 *** kprochazka has quit IRC
17:09:14 <dkayiwa> dmulindwa, iam not called dkatiwa :)
17:09:36 <dmulindwa> dkayiwa xchat..just changed the setting to get beep alerts..let me see how that works out
17:09:37 <dkayiwa> dmulindwa, first tip, just type dk and then press the TAB key
17:09:55 <dkayiwa> dmulindwa, that was exactly going to be my second tip :)
17:10:04 <dmulindwa> dkayiwa : like this?
17:10:16 <dkayiwa> dmulindwa, oh yes
17:10:24 <dmulindwa> dkayiwa, thanx it workd like a charm
17:10:54 <dkayiwa> dmulindwa, i also turned on beep alerts in the settings and now everytime someone mentions me, i get a beep and the ka window flickers :)
17:11:14 *** shangxiao has quit IRC
17:11:17 <dkayiwa> dmulindwa, do you experience that too now?
17:11:26 <dmulindwa> dkayiwa, same here..
17:11:37 <dkayiwa> dmulindwa, excellent
17:11:57 <dkayiwa> dmulindwa, now i wanted to do some pair programming with you now regarding the other ticket
17:12:07 <dkayiwa> dmulindwa, do you have some free time?
17:12:18 <dmulindwa> dkayiwa, yes i do..
17:12:40 <dkayiwa> dmulindwa, ok good.
17:12:56 <dmulindwa> dkayiwa, do i need any special software installed on my computer?
17:13:22 <dkayiwa> dmulindwa, we have quite a number of options. but let me see what we can use
17:14:12 <dkayiwa> dmulindwa, can you go here? http://connect.iu.edu/omrsd
17:15:28 <dmulindwa> dkayiwa, on my way there
17:15:35 <dkayiwa> dmulindwa, ok
17:17:48 <dmulindwa> dkayiwa, failing to login with my openmrs ID..
17:18:05 <dkayiwa> dmulindwa, use a guest account
17:18:17 <dkayiwa> dmulindwa, where you should type in anything
17:21:44 <dmulindwa> dkayiwa, its taking some time..my connection isnt the fastest
17:22:05 <dkayiwa> dmulindwa, lets give it some time and see if it connects
17:23:51 <dmulindwa> dkayiwa, am there now..
17:24:23 <dkayiwa> dmulindwa, ok seen you
17:24:36 <dkayiwa> dmulindwa, can we use skype for voice?
17:26:39 <dmulindwa> dkayiwa, i have concerns on my poor link..dont we have another option
17:26:52 <dkayiwa> dmulindwa, for voice?
17:27:40 <dmulindwa> dkayiwa, for communication..
17:27:59 <dmulindwa> dkayiwa, taking chances with my skype for now
17:28:01 *** applecool has quit IRC
17:28:17 <dkayiwa> dmulindwa, try it out and we see
17:29:32 <dmulindwa> dkayiwa, i am logged in..my handle is dmulindwa
17:29:49 <dkayiwa> dmulindwa, on skype?
17:30:11 <dmulindwa> dkayiwa, yeah on skype
17:30:42 <dkayiwa> dmulindwa, sent you contact request
17:36:36 *** Hasintha_i has joined #openmrs
17:37:14 <dkayiwa> dmulindwa, do you see my screen on connect?
17:38:12 <dmulindwa> yes i do
17:41:20 <dkayiwa> dmulindwa, i did not notice that you had replied because you did not include my name
17:41:21 *** kishoreyekkanti has quit IRC
17:41:48 <dkayiwa> dmulindwa, do you see my eclipse compiling?
17:41:49 <dmulindwa> dkayiwa, sorry about that..i did
17:42:08 <dmulindwa> yeah i did..
17:42:21 <dmulindwa> dkayiwa, i did
17:42:33 <dkayiwa> dmulindwa, now if we can have your sound working, then i can start
17:43:17 <dmulindwa> dkayiwa, a minute..fixing that now
17:43:33 <dkayiwa> dmulindwa, ok. will wait for you
17:51:16 *** djadmin has quit IRC
17:52:45 *** kishoreyekkanti has joined #openmrs
17:54:25 <dkayiwa> dmulindwa, are you still on adobe connect?
17:54:36 <dmulindwa> dkayiwa, yes i am
17:54:48 <dkayiwa> dmulindwa, do you see my screen?
17:56:17 <dmulindwa> dkayiwa, waiting for it..i think its coming
17:56:25 *** sashrika has quit IRC
17:56:42 <dkayiwa> dmulindwa, ok tell me when ready
17:57:04 <dmulindwa> dkayiwa, sorry i cant see it right now..the screen icon has even changed
17:57:18 <dmulindwa> dkayiwa, sorry i can see it now
17:57:24 <dkayiwa> dmulindwa, ok good
18:00:29 *** jkeiper has joined #openmrs
18:00:29 *** ChanServ sets mode: +v jkeiper
18:02:07 *** Areo has quit IRC
18:02:40 *** kishoreyekkanti_ has joined #openmrs
18:03:12 *** rafa has quit IRC
18:04:51 *** kishoreyekkanti has quit IRC
18:04:52 *** kishoreyekkanti_ is now known as kishoreyekkanti
18:07:35 *** GitHub84 has joined #openmrs
18:07:35 <GitHub84> [openmrs-core] akolodziejski opened pull request #231: TRUNK-3204 : Add JUnit test for getting by null/true/false isPreferred i... (master...TRUNK-3204) http://git.io/iT_FEQ
18:07:35 *** GitHub84 has left #openmrs
18:21:13 *** dtharindu has joined #openmrs
18:24:04 *** rkorytkowski has joined #openmrs
18:24:04 *** rkorytkowski is now known as rafa
18:24:04 *** ChanServ sets mode: +v rafa
18:24:11 *** kprochazka has joined #openmrs
18:25:34 *** lauren has joined #openmrs
18:25:58 *** lauren is now known as Guest74131
18:27:17 *** lauren_s has joined #openmrs
18:28:11 <lauren_s> @dkayiwa, have a sec to answer a question? :)
18:29:15 *** rafa has quit IRC
18:32:19 *** jkeiper has quit IRC
18:33:38 *** jkeiper has joined #openmrs
18:33:38 *** ChanServ sets mode: +v jkeiper
18:33:51 *** shortend has quit IRC
18:33:59 <jkeiper> oh yes. irccloud++
18:34:09 *** shortend has joined #openmrs
18:34:15 <downey> irccloud++
18:39:26 *** k-joseph has joined #openmrs
18:50:08 <k-joseph> dkayiwa: hi
18:56:42 *** ekow has quit IRC
18:58:56 *** Hasintha_i has quit IRC
18:59:34 <dkayiwa> k-joseph, hi
19:00:10 <rfriedman> cpower_, sprinting today?
19:00:11 *** dkayiwa has quit IRC
19:01:14 <k-joseph> dkayiwa: http://pastebin.com/4CJ1N0MB is my commit on the current ticket TRUNK-3621
19:01:49 *** dkayiwa has joined #openmrs
19:02:21 *** dkayiwa has joined #openmrs
19:03:05 <dkayiwa> k-joseph, hi
19:03:13 <k-joseph> dkayiwa: hi
19:07:19 *** rkorytkowski has joined #openmrs
19:07:19 *** rkorytkowski is now known as rafa
19:07:19 *** ChanServ sets mode: +v rafa
19:11:47 *** djadmin has joined #openmrs
19:12:54 <rfriedman> rafa, no sign of cpower_
19:13:12 <rafa> rfriedman: ah you want scrum?
19:13:17 <rafa> rfriedman: it's an hour later
19:13:29 <rafa> rfriedman: sorry miscalculated
19:13:38 <rfriedman> rafa, you mean it's yet to come, or has already been?
19:13:45 <rafa> rfriedman: it's yet to come
19:13:51 <rfriedman> great, see u then
19:13:56 <rafa> rfriedman: see you :)
19:14:12 *** lauren_s has quit IRC
19:20:13 *** dmulindwa has quit IRC
19:21:27 *** dkayiwa has quit IRC
19:21:47 *** dkayiwa has joined #openmrs
19:23:07 <rfriedman> wyclif, did you do anything with ConceptSourceResource? The one I am seeing does not have the new annotations.
19:24:10 *** dtharindu has quit IRC
19:26:35 *** djadmin has quit IRC
19:32:41 <rfriedman> rafa, sorry to bother you, but i'm trying to find out if I'm looking at the right version of ConceptSourceResource. This one has no SupportedVersion annotation and no getResourceVersion method.
19:33:21 <rafa> rfriedman: have you pulled the latest code?
19:33:28 <rafa> rfriedman: I did a lot of clean up
19:33:45 <rafa> rfriedman: after pulling you will have to import webservices.rest to eclipse again
19:35:51 *** djadmin has joined #openmrs
19:36:36 *** evmw has joined #openmrs
19:40:34 <rfriedman> rafa, pull says i am up to date ... i did an eclipse refresh ... when i try to do import, it says it is already imported
19:41:04 <rfriedman> rafa, this was my pull: git pull origin sprint-201302
19:41:13 <rafa> rfriedman: origin?
19:41:24 <rafa> rfriedman: maybe upstream?
19:41:41 <rafa> typically origin is your fork
19:41:54 <rafa> upstream is openmrs repo
19:43:17 <rfriedman> rafa, worked better with upstream
19:43:23 *** djadmin has quit IRC
19:45:51 *** harsz89 has quit IRC
19:46:07 <k-joseph> dkayiwa: have you seen the previous pastebin link, is it ok ?
19:46:27 <dkayiwa> k-joseph, which one?
19:46:42 <k-joseph> dkayiwa: http://pastebin.com/4CJ1N0MB
19:51:15 *** djadmin has joined #openmrs
19:53:34 <dkayiwa> k-joseph, why do you store ConceptService as a class level variable?
19:56:39 *** kishoreyekkanti has quit IRC
19:57:36 <k-joseph> dkayiwa: can you please come again on what you exactly mean
19:57:57 *** shortend has quit IRC
19:58:25 <dkayiwa> k-joseph, why dont you just dirrectly call the service in the method without first storing it as a class lever variable. Since you use it in just one place.
19:59:58 <rafa> k-joseph: you shouldn't annotate ConceptDatatype with @Component either ;)
20:00:24 <cpower_> Hello!
20:00:30 <cpower_> Are we ready to scrum?
20:00:37 <cpower_> !scrumon cpower
20:00:37 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
20:01:06 <rafa> k-joseph: or nevermind it's a different ConceptDatatype than what I meant ;)
20:01:15 <cpower_> Order: wyclif, dkayiwa, andreap_, mseaton, rafa, djazayeri and others
20:01:38 <wyclif> Wednesday:
20:01:38 <wyclif> Fix catalog to work for reference terms and maps
20:01:38 <wyclif> design call
20:01:38 <wyclif> Code reviews
20:01:38 <wyclif> Thursday:
20:01:39 <wyclif> dev call
20:01:41 <wyclif> TRUNK-3738 - When a module activator's started() method throws an exception, the module should stop
20:01:43 <wyclif>
20:01:45 <wyclif> Blockers: None
20:02:15 <k-joseph> dkayiwa: so you mean i leave the @Component?
20:02:40 <rafa> k-joseph: hold on please :)
20:02:54 <rafa> k-joseph: we're scrumming
20:03:37 <cpower_> dkayiwa?
20:03:52 <cpower_> NEXT!
20:03:54 <dkayiwa> Reviewed: Unnecessary logged exceptions when saving forms (Save Handlers should ignore deprecated properties) - TRUNK-3862
20:03:55 <dkayiwa> Reviewed and pair programmed: ModuleUtil should not treat SNAPSHOT as 999. - TRUNK-3654
20:03:55 <dkayiwa> Reviewed but failed to reproduce: Patient Dashboard - Allergy shows as year 3912 in place of 2012 - TRUNK-3561
20:03:55 <dkayiwa> Dev Call
20:03:55 <dkayiwa> Now reviewing: Add JUnit test for getting by null/true/false isPreferred in HibernatePatientDAO.getPatientIdentifiers - TRUNK-3204
20:03:57 <dkayiwa> No Blockers
20:04:20 <andreap_> Wednesday
20:04:20 <andreap_> Design call
20:04:20 <andreap_> Look through tickets, code in openmrs core for Community Sprint
20:04:20 <andreap_> Claimed ticket: TRUNK-3289 Delete other order stuff before deleting current order
20:04:20 <andreap_> Thursday
20:04:21 <andreap_> Dev call
20:04:23 <andreap_> Work on ticket: TRUNK-3289 Delete other order stuff before deleting current order
20:04:25 <andreap_>
20:04:27 <andreap_> No blockers but may need further explanation re TRUNK-3289 Delete other order stuff before deleting current or
20:05:36 <cpower_> mseaton is most likely recovering from the leadership call, so NEXT!
20:05:57 <rafa> Today:
20:05:57 <rafa> * Wrapped up the RESTWS sprint (reviewing, testing, cleaning up)
20:05:57 <rafa> * Dev Call
20:05:57 <rafa> No blockers.
20:06:09 <djazayeri> Currently working on: (1) a report for mirebalais, (2) having Pulkit refactor App Framework module bofore our Reference Application sprint
20:06:11 <djazayeri> No blockers
20:06:19 <cpower_> Anyone else?
20:06:51 <rfriedman> just discussion items re REST on dev list
20:07:23 <cpower_> Ok Annoucements: We are currently on a Community Swimlane sprint for the next two weeks. Let me know if you have questions.
20:07:42 <cpower_> Otherwise thank you and have a good day
20:07:44 <cpower_> !scrumoff
20:07:44 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
20:08:07 <andreap_> cpower, would like quick explanation re TRUNK-3289
20:08:08 <rfriedman> djazayeri, wyclif, rafa, re resource versioning
20:08:24 <cpower_> andreap_, oops sorry
20:08:27 *** dmulindwa has joined #openmrs
20:08:39 <andreap_> cpower_: ok
20:08:43 <cpower_> Can someone work with andreap_?
20:08:54 *** xx_ has joined #openmrs
20:09:05 <andreap_> cpower, will be brief
20:09:20 <k-joseph> am sorry to have interrupted the scrum meeting
20:09:31 <wyclif> no problem k-joseph
20:09:33 <rfriedman> right now, concept source does not have any collections ... in the 1.9 version it should have a reference terms collection i believe
20:09:46 <k-joseph> rafa: so you mean i leave the @Component?
20:09:57 <wyclif> rfriedman, it should be a concept mappings collection
20:10:22 <wyclif> k-joseph, which rafa added in one of the tickets he worked on
20:10:22 <rfriedman> wyclif, no, it only contains reference terms which themselves have maps
20:10:23 <k-joseph> hi wyclif, thanks for accepting my request
20:10:42 <djazayeri> rfriedman: I would think that the terms would be subresources of the source, not a collection property
20:10:51 <djazayeri> rfriedman: because they're theoretically a huge list
20:11:00 <rafa> k-joseph: I'm sorry I don't know what you are doing precisely. If you need it to be a spring bean then you want @Component
20:11:16 <rfriedman> djazayeri, that wasn't what was decided on in 267
20:11:46 <k-joseph> rafa, am solving TRUNK-3621
20:11:46 <andreap_> cpower, looks like everyone is busy
20:11:55 <djazayeri> andreap_: remind me the ticket #?
20:12:12 <djazayeri> !ticket RESTWS-267
20:12:14 <OpenMRSBot> djazayeri: [#RESTWS-267] Need to expose concept mappings and related domain objects - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-267
20:12:18 <andreap_> djazayeri: TRUNK-3289 DElete other order stuff before deleting current order
20:12:29 <djazayeri> !ticket trunk-3289
20:12:30 <wyclif> rfriedman, conceptresource in 1.9 contains mappings where each mapping contains conceptReferenceTerm
20:12:30 <OpenMRSBot> djazayeri: [#TRUNK-3289] Delete other order stuff before deleting current order - OpenMRS JIRA - https://tickets.openmrs.org/browse/trunk-3289
20:12:50 <andreap_> djazayeri: right
20:13:07 <rfriedman> wyclif, those are concept maps, we're talking ConceptSource and its resource
20:13:15 *** dmulindwa has quit IRC
20:13:33 <andreap_> djazayeri: re Items to be deleted:
20:13:33 <andreap_> 1) Obs which has an order field
20:13:48 <wyclif> rfriedman, am confused what is your question again
20:13:53 <djazayeri> dkayiwa: you marked TRUNK-3289 as curated
20:14:07 <rafa> !ticket TRUNK-3621
20:14:08 <OpenMRSBot> rafa: [#TRUNK-3621] Create a custom data type and its associated handler for concepts - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3621
20:14:10 <djazayeri> dkayiwa: I disagree that this is sufficiently documented to work on...
20:14:21 <andreap_> djazayeri: how do you find which obs's have an order field?
20:14:30 <dkayiwa> !ticket TRUNK-3289
20:14:31 <rfriedman> ok, right now ConceptSource has no collections where it should have a collection of ConceptReferenceTerms
20:14:31 <OpenMRSBot> dkayiwa: [#TRUNK-3289] Delete other order stuff before deleting current order - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3289
20:14:42 <wyclif> rfriedman, quoting you "in the 1.9 version it should have a reference terms collection i believe" and am saying no it should contain terms but mappings
20:14:46 <k-joseph> dkayiwa: i have addressed your comment, http://pastebin.com/8QvGiRGG
20:14:46 <djazayeri> dkayiwa: can you help describe the ticket properly, for andreap_ ?
20:14:53 <rafa> k-joseph: yes, it needs to have @Component
20:15:01 <wyclif> rfriedman, quoting you "in the 1.9 version it should have a reference terms collection i believe" and am saying no it shouldn't contain terms but mappings
20:15:08 <k-joseph> rafa, ok
20:15:19 <djazayeri> alternately, andreap_ you could pick a different ticket that has a clearer description...
20:15:21 <rfriedman> wyclif, no, look at the version 4 picture on 267
20:15:30 <andreap_> djazayeri: thanks - thats what I'm looking for
20:15:58 <andreap_> djazayeri: thought this one would be good learning experience
20:16:14 <rfriedman> andreap_, learn how to curate a ticket :)
20:16:28 <wyclif> rfriedman, yes i am and i see no terms in concept resource
20:16:44 <rfriedman> wyclif, we are not looking at concept resource
20:16:51 <rfriedman> we are looking at concept source
20:16:55 <dkayiwa> djazayeri, ok
20:16:57 <rfriedman> top left corner
20:17:27 <wyclif> rfriedman, but you said concept ok, still concept source doesnt have a terms property neither does it have it in that image
20:17:43 <rfriedman> in 1.8 it should contain a collection of concept_maps, but that's blood under the bridge
20:17:58 <wyclif> rafa, what should contain it
20:18:00 <rfriedman> wyclif, collections properties are not shown in the field list, they are shown by the connections
20:18:05 <andreap_> rfriedman, would like to learn to curate a ticket but I have to understand what it means first
20:18:43 <andreap_> dkayiwa: can we discuss TRUNK-3289 DElete other order stuff before deleting current order?
20:19:00 <dkayiwa> andreap_, ok
20:19:02 <rafa> rfriedman: sorry why do you want a collection of concept reference terms in concept source?
20:19:09 <wyclif> rfriedman, tjhat bridge just show a relationship, which in this cae means that a term belongs to a concept source but a concept source doesnt have a list of terms belong to it
20:19:26 <andreap_> dkayiwa: Items to be deleted:
20:19:26 <rfriedman> because the terms belong to the source
20:19:26 <andreap_> 1) Obs which has an order field
20:19:55 <andreap_> dkayiwa: How do I find obs's with an order field
20:19:56 <wyclif> rfriedman, right but a concept source doesnt need to know about terms belonging to it
20:20:16 <rfriedman> rafa, wyclif at one point i believe i had terms as a subresource, but burke didn't like that and there were complications with having connections between subresources
20:20:49 <dkayiwa> andreap_, checking....
20:21:01 <andreap_> dkayiwa, thanks!
20:21:27 <rafa> rfriedman: I understand, but what's the purpose? Do you really want to list all concept reference terms for a concept source?
20:21:42 <rfriedman> rafa, yes
20:22:07 <rfriedman> source/code is strictly parent/child
20:22:19 <wyclif> rfriedman, we can let a user search for terms in a concept source but we are not adding terms belonging to a resource as a rep property
20:22:21 <djazayeri> rfriedman: sorry, we're talking about v4 now?
20:22:32 <rfriedman> djazayeri, yes
20:23:34 <wyclif> rfriedman, what i tried to push for is to actually support searching for terms in a source since there is an API method in core for this
20:23:41 <rfriedman> rafa, the thing is, in 1.8 we thought of a map from a concept to a source/code, not in the opposite direction ... code was data carried in the link table
20:24:05 <rafa> rfriedman: I understand, but we can't put such a huuuge list in concept_source
20:24:54 <rafa> rfriedman: we can provide a search for concept reference termy by concept source
20:24:57 <wyclif> rfriedman, are proposing to add capability to search for concepts by mapping via rest?
20:25:03 <rfriedman> rafa, i can see that ... perhaps wyclif's search suggestion is better
20:25:47 <wyclif> rfriedman, i agree that we might want to allow searching for terms in a given source and searching for concepts by mapping(i.e. source+term)
20:26:09 <wyclif> rafa, because they are already possible in the API, so we should expose them via rest
20:26:13 <rafa> wyclif: we have searching for concepts by mapping
20:26:22 <rafa> wyclif: source + code
20:26:27 <wyclif> rafa, cool , i thought so
20:26:53 <wyclif> rfriedman, so you want to search for terms in a source ,right?
20:27:27 <rfriedman> wyclif, yes ... although basing what we do on the api is a bit circular, because the api was based on what we thought we wanted to do
20:28:22 <rfriedman> what i'd really like to see is more consistency in the way we expose things
20:28:29 <dkayiwa> andreap_, i do not see any API for getting that
20:29:16 <rfriedman> why should the user have to guess whether to use a collection or a search?
20:29:28 <dkayiwa> andreap_, but i also do not think we should create one just for the sake of deleting. :)
20:29:36 <andreap_> dkayiwa, ok should I bypass that part for now
20:29:41 <wyclif> rfriedman, core that provides convenience API calls for fetch concept by mappings and to look up terms in concept sources and not really providng ways for people to get other sides of a relationship given one end
20:29:45 <rafa> rfriedman: no guessing here, go read docs
20:30:04 <andreap_> dkayiwa: what about 2) DrugOrder which has an order_id field
20:30:04 <andreap_> 3) And finally TestOrder which also has an order_id field
20:30:21 <dkayiwa> andreap_, looks like it is going to be the same for DrugOrder and TestOrder :)
20:30:26 <wyclif> rfriedman, i dont get how code gets circular
20:30:34 <andreap_> dkayiwa: these seem easier - probably I can figure them out
20:30:43 <dkayiwa> andreap_, can you?
20:30:47 <rafa> rfriedman: when I want to use some API, I read docs :) I don't guess or assume...
20:31:25 <andreap_> dkayiwa, will try - if not will pick another ticket I guess
20:31:37 <dkayiwa> andreap_, ok
20:31:39 <andreap_> dkayiwa, thanks!
20:31:52 <rfriedman> wyclif, the api methods were created by thinking of mappings as representing concepts ... when now there is really another level where the terms relate to each other and the maintenance of the terms and term maps is the important workflow
20:32:16 <rfriedman> rafa, gold star for you
20:32:48 <dkayiwa> k-joseph, hi
20:32:51 *** xx_ has quit IRC
20:33:10 <rfriedman> but i do agree, those who don't read the docs deserve what they get
20:33:27 <dkayiwa> k-joseph, your @see annotations have wrong values. Can you correct them?
20:34:04 *** GitHub191 has joined #openmrs
20:34:04 <GitHub191> [openmrs-core] wluyima pushed 1 new commit to master: http://git.io/jGSl1Q
20:34:04 <GitHub191> openmrs-core/master a0f3c86 wluyima: Applying auto format changes
20:34:04 *** GitHub191 has left #openmrs
20:34:59 <djazayeri> rfriedman, rafa, wyclif:
20:34:59 <djazayeri> (Sorry, I haven't read what you all are typing, as I'm on a hangout now, but I just wrote this out)
20:35:00 <djazayeri> Top-level resources:
20:35:00 <djazayeri> * concept
20:35:00 <djazayeri> * conceptsource
20:35:00 <djazayeri> * conceptmaptype
20:35:01 <djazayeri> Sub-resources
20:35:01 <djazayeri> * conceptreferenceterm is a subresource of conceptsource
20:35:02 <djazayeri> Other Details:
20:35:03 <djazayeri> * concept has mappings as a property
20:35:03 <djazayeri> * conceptreferenceterm has the crossmaps as a property
20:37:12 <rfriedman> djazayeri, conceptreferencemap has to be a subresource of concept to be like concept map which defined the api methods
20:37:45 <rafa> and conceptreferenceterm can't be a subresource of conceptsource then
20:38:00 <djazayeri> rfriedman: sorry, what is conceptreferencemap?
20:38:15 *** dmulindwa has joined #openmrs
20:38:16 <rfriedman> there was a problem with concept reference term being a subresource of concept source -- it had to do with having subresources as references in concept reference term map
20:38:32 <rfriedman> djazayeri, middle bottom of v4 picture
20:39:01 <djazayeri> In the core API, Concept has mappings (Collection<ConceptMap>)
20:39:15 <djazayeri> rfriedman: why can't that be a plain property in REST as it is now?
20:39:28 <rfriedman> djazayeri, it's because the name has been reused from the 1.8 version where it was concept map
20:39:43 <wyclif> rfriedman, djazayeri conceptreferencemap -> conceptmap
20:40:06 <wyclif> rfriedman, i think we are confusing something here
20:41:17 <rfriedman> in 1.8, concept mapped to source with code and comment as link table variables
20:41:28 <rafa> djazayeri: ConceptMap doesn't live on its own, you can't call saveConceptMap
20:41:38 <rafa> djazayeri: it's a subresource of Concept
20:41:44 <djazayeri> rafa: that's why I'm saying it's a plain property of Concept
20:42:00 <rfriedman> djazayeri, nope, it's cardinality is >1
20:42:00 <wyclif> djazayeri, so you are saying that we should expose terms as subresources of concept source since they exist on their own but SHOULD NOT expose terms belonging to a source in the concept resource representation
20:42:21 <rafa> djazayeri: what do you mean by plain property?
20:42:30 <k-joseph> dkayiwa: all other data types are keeping those values for @ see the same, what then is the right values? :(
20:42:30 <rafa> djazayeri: it must be either a resource or subresource
20:42:39 <wyclif> rfriedman, you keep on mixing up term with maps
20:42:40 <rafa> djazayeri: it can't be a resource
20:42:56 <rfriedman> wyclif, not me
20:43:01 <djazayeri> I'm saying that the concept resource should have a collection property called "mappings"
20:43:12 <rafa> djazayeri: yes it has
20:43:19 <dkayiwa> k-joseph, like which one? can you give me an example?
20:43:27 <rfriedman> and mappings can be added or deleted from that collection
20:43:39 <djazayeri> rafa: and I'm saying that beyond that, we don't need a resource or subresource for ConceptMap.
20:43:45 <wyclif> rfriedman, a concept from the API doesnt really directly connect to a term
20:44:03 *** travis-ci has joined #openmrs
20:44:03 <travis-ci> [travis-ci] [openmrs/openmrs-core] [a0f3c86] [wluyima] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/5143185
20:44:03 *** travis-ci has left #openmrs
20:44:06 <wyclif> the concept should only worry about the maps and ignore terms\
20:44:08 <OpenMRSBot> <http://ln-s.net/+jt2> (at travis-ci.org)
20:44:14 <rafa> djazayeri: I'm not following
20:44:30 <wyclif> djazayeri, rafa, rfriedman it would be good to have a skype chat on this
20:44:33 <djazayeri> hold on, let me open up restws in intellij and look for an example...
20:44:35 <rafa> djazayeri: if it's not a resource, nor a subresource, then how to define a representation of that
20:44:37 <djazayeri> hangout even...
20:44:55 <k-joseph> dkayiwa: actually you are right for the deserialize() , thanks
20:45:26 <dkayiwa> k-joseph, and for serialize?
20:46:24 <wyclif> djadmin, i think concept reference term cant be a subresource simply because it requires to be associated to a source otherwise encounter would a subresource of an encounter type, i thought something qualifies to be a subresource because it belongs to a child collection of a parent and cannot exist on its own in the DB
20:46:42 <wyclif> djazayeri, , rfriedman , i think concept reference term cant be a subresource simply because it requires to be associated to a source otherwise encounter would a subresource of an encounter type, i thought something qualifies to be a subresource because it belongs to a child collection of a parent and cannot exist on its own in the DB
20:46:53 <djazayeri> a concept reference term _is_ a child of a source
20:46:55 <djazayeri> can we do a hangout?
20:46:57 <djazayeri> or a skype call?
20:47:09 <djazayeri> or alternately, schedule this for next week's design call?
20:47:17 <k-joseph> dkayiwa: even for serialize(), i have corrected both of them here http://pastebin.com/cCLAKHjv
20:47:18 <rfriedman> wyclif, look at the connections and crow's feet from term to concept map to concept, it's just like the connection from source to concept map to concept in 1.8
20:47:48 <wyclif> rfriedman, djazayeri are yiu saying encounter is a subresource of encounter type
20:47:54 <djazayeri> no
20:48:02 <djazayeri> encounters do not belong to encounter types
20:48:08 <djazayeri> they reference them
20:48:18 <djazayeri> just like an Obs is not a subresource of a Concept
20:48:27 <djazayeri> and a PatientIdentifier is not a subresource of a PatientIdentifierType
20:48:45 <djazayeri> rafa: okay, so looking back at the code I see that we also implemented concept names and descriptions as subresources
20:49:01 <djazayeri> rafa: so I see why you're confused by what I was trying to say
20:49:26 <djazayeri> rafa: yes, mappings should be a subresource of the concept resource
20:49:35 <rfriedman> and they are
20:49:58 <rfriedman> how ever, in 1.8 they point to sources and in 1.9 they point to terms
20:50:23 <dkayiwa> k-joseph, can you remind me of the ticket number? :)
20:50:23 <djazayeri> rfriedman: okay, so we just have different implementations of them in 1.8 vs 1.9...
20:50:37 <wyclif> djazayeri, but a concept source doesn't know terms that are in it from the API , though i get what you are trying to say
20:50:47 <k-joseph> dkayiwa: TRUNK-3621
20:50:47 *** evmw has quit IRC
20:51:03 <rafa> the current state: https://wiki.openmrs.org/display/docs/REST+Web+Service+Resources+in+OpenMRS+1.9
20:51:07 <rafa> https://wiki.openmrs.org/display/docs/REST+Web+Service+Resources+in+OpenMRS+1.8
20:51:23 <rfriedman> so we have a display property for concept map that is source:code to satisfy people who are used to finding source
20:51:35 <dkayiwa> k-joseph, have you also created the handler?
20:51:41 <wyclif> djazayeri, so mappings are not subresources or concept but concept source?
20:51:47 <rfriedman> or, we have source and code properties just like we used to have
20:51:56 <djazayeri> ConceptMap is a subresource on concept
20:52:11 <rfriedman> djazayeri, +1
20:52:18 <djazayeri> the other type of mapping (the cross-map) needs to belong to ConceptReferenceTerm
20:52:45 <k-joseph> dkayiwa: yes, i have created it too http://pastebin.com/jukE6MUC
20:52:49 <rfriedman> djazayeri, that's what we had in v3, but the problem was the bidirectionality
20:53:19 <djazayeri> rfriedman: okay, fair point, so we need a top-level resource to represent the cross-map between two terms.
20:53:47 <rfriedman> djazayeri, and that's in v4
20:54:34 <rfriedman> djazayeri, but we're wandering a little ... the question is, do we need any collections in any version of concept_source?
20:54:46 <rafa> rfriedman: no
20:55:11 <rafa> rfriedman: if we put there any, it will be huuuuuuge one
20:55:15 <djazayeri> No collections in concept_source, but I would vote for making concept_reference_term be a subresource
20:55:17 <wyclif> djazayeri, rfriedman i think this can get complicated if we try to build resources/subresource using the way you guys are suggesting, i think we need to do it the way domain objects are setup in the API, i.e if a class has a collection of items that cant stand on their own
20:55:40 <wyclif> they they qualify to be its subresources
20:55:43 <rafa> djazayeri: there's saveConceptReferenceTerm method in ConceptService
20:55:53 <djazayeri> So, I'm going to bow out of this discussion. Apologies, but I can't handle this discussion over IRC...
20:55:54 <rafa> djazayeri: it means it can live on its own
20:56:05 <rfriedman> rafa, in most cases where we have 2 independent objects related, we have a collection
20:56:13 <djazayeri> I am happy to join in if we go voice, or else we can schedule this for the design call.
20:56:36 <wyclif> i suggest we look at how we have mapped things in hibernate and borrow that
20:56:41 <djazayeri> alternately, using a shared etherpad would be fine
20:57:11 <djazayeri> I was going to say though, that I think _even though we didn't model it this way in the API_ we should make concept_reference_term be a sub-resource of source
20:57:12 <rfriedman> djazayeri, i'd rather talk, but i don't google, i can skype or i can call each of you into a conference
20:57:28 <wyclif> am fine with skype
20:57:37 <rafa> I'll let you resolve that :) It's pretty late here.
20:57:56 <rafa> and I think like it can take more than an hour ;)
20:57:56 <rfriedman> so let's put it off until next Wed
20:58:12 <rfriedman> what can we do to clear away underbrush?
20:58:13 <dkayiwa> k-joseph, is your getValue() method correct?
20:58:54 <rfriedman> get examples of how similar relations are handled? find out what the problem was with relating subresources to resources?
20:58:58 <djazayeri> rfriedman, wyclif: a clear and *short* (Roger, I'm looking at you) description of the current state, and the proposed alternative.
20:59:09 <djazayeri> :-)
20:59:46 <rfriedman> djazayeri, a picture is worth 1000 words :)
21:00:02 <rafa> djazayeri: here you have it short: https://wiki.openmrs.org/display/docs/REST+Web+Service+Resources+in+OpenMRS+1.9
21:00:20 <djazayeri> rfriedman: can you do the picture just for 1.9, without the 1.8 mixed in?
21:00:35 <rfriedman> djazayeri, yes, that was what I was thinking
21:01:46 <rfriedman> tks rafa gnite
21:01:53 <rfriedman> tks djazayeri
21:01:59 <rfriedman> tks wyclif
21:06:16 <rafa> thank you, see you!
21:06:25 *** rafa has quit IRC
21:07:13 *** k-joseph has quit IRC
21:08:51 <downey> rfriedman: more of a microsoft fan than google? ;-)
21:11:35 <rfriedman> downey, i am pissed off at their privacy policy ... i have a Samsung III phone I am not using because of it
21:12:40 <rfriedman> downey, i am going to check out amazon, apparently i can get android apps there, i will see if their terms are any better
21:13:04 <downey> rfriedman: Yeah, I've heard good things about the amazon app store but haven't tried it
21:14:24 <downey> rfriedman: Also, it looks like your shirt arrived ;-)
21:14:49 <rfriedman> downey, can't wear it here, i'll get shot
21:14:56 <dkayiwa> hi andreap_
21:15:02 <downey> rfriedman: yeah it's hot property
21:15:34 <rfriedman> downey, no, i mean the neighborhood vigilantes
21:15:46 <downey> ha
21:16:09 <rfriedman> downey, if you're wearing a hoodie here, you better be walking a dog and pushing a baby carraige
21:16:34 <downey> rfriedman: yeah i guess you're close enough to florida to have the same problems ... just don't carry iced tea & skittles
21:17:12 <rfriedman> downey, you can't even give away skittles at halloween ... kiss of death
21:25:14 *** rfriedman has quit IRC
21:25:14 *** djadmin has quit IRC
21:25:29 *** isaac_ has joined #openmrs
21:27:29 <isaac_> am trying to install the openmrs 1.9.2 standalone version but it seems it reaches a stage where it looks like freezing and cont continue. i need your help on this
21:35:27 *** GitHub7 has joined #openmrs
21:35:27 <GitHub7> [openmrs-core] wluyima opened pull request #232: When a module activator's started() method throws an exception, the module should stop - TRUNK-3738 (master...TRUNK-3738) http://git.io/B9AFLQ
21:35:27 *** GitHub7 has left #openmrs
21:51:00 <andreap_> dkayiwa, just saw your hi - what's up?
21:51:30 <dkayiwa> andreap_, did you see Darius's comment on the ticket?
21:53:23 *** isaac_ has quit IRC
21:54:19 <andreap_> dkayiwa, no - let me look
21:57:27 <andreap_> dkayiwa, so looks like the thing to do is write: deleteObsThatReference(Order) method in OrderDAO.
21:59:56 <dkayiwa> andreap_, yes
22:00:27 <andreap_> djazayeri, swa comment on TRUNK-3829 re deleteObsThatReference(Order) method in OrderDAO
22:00:57 <andreap_> djazayeri, should I go ahead and do that?
22:01:48 <djazayeri> dkayiwa: do you have any comment on that? ^^
22:03:35 <dkayiwa> djazayeri, i think it makes perfect sense
22:03:43 <dkayiwa> andreap_, ^^
22:04:48 <andreap_> dkayiwa, what does ^^ mean?
22:05:13 <dkayiwa> andreap_, it means look at my answer above. :)
22:05:13 <andreap_> dkayiwa, ok - now I see earlier msg
22:05:43 <andreap_> dkayiwa, yes - will write that method
22:08:59 <dkayiwa> andreap_, ok
22:12:55 <andreap_> dkayiwa, djazayeri - thanks - will write method
22:26:06 *** dkayiwa has quit IRC
22:30:04 *** mseaton has left #openmrs
22:36:36 *** dmulindwa has quit IRC
22:40:58 *** wyclif has quit IRC
22:55:05 *** robbyoconnor has joined #openmrs
22:55:05 *** ChanServ sets mode: +v robbyoconnor
23:01:12 *** andrea_p has joined #openmrs
23:09:02 <andreap_> djazayeri, re new method deleteObsThatReference(Order)
23:09:13 <djazayeri> yes?
23:09:42 <andreap_> djazayeri, New method must go in:
23:09:43 <andreap_> OrderDAO.java (interface)
23:09:43 <andreap_> OrderService.java (interface)
23:09:43 <andreap_> OrderSeviceImpl.java
23:09:57 <djazayeri> andreap_: in OrderDAO
23:10:30 <andreap_> djazayeri, just OrderDAO? How will it be implemented?
23:10:31 <djazayeri> andreap_: I don't want it to be part of our public API (i.e. don't add it to the service), but it's an under-the-hood thing
23:10:40 <djazayeri> andreap_: and implement it in HibernateOrderDAO
23:11:09 <andreap_> djazayeri, ahh ok will do - thanks!
23:12:00 <djazayeri> np
23:20:11 *** robbyoconnor has quit IRC
23:23:22 *** mseaton has joined #openmrs
23:23:22 *** ChanServ sets mode: +v mseaton
23:23:29 *** mseaton has left #openmrs
23:51:00 *** kprochazka has quit IRC