00:21:21
|
*** sunbiz has left #openmrs
|
01:13:46
|
*** lh has quit IRC
|
01:15:10
|
*** djazayeri has quit IRC
|
01:44:37
|
*** andreap has quit IRC
|
01:58:02
|
*** djazayeri has joined #openmrs
|
01:58:02
|
*** ChanServ sets mode: +o djazayeri
|
02:02:59
|
*** DraggonZ has joined #openmrs
|
02:08:28
|
*** Anuruddha has joined #openmrs
|
02:15:48
|
*** Anuruddha has quit IRC
|
02:18:08
|
*** djadmin has joined #openmrs
|
02:26:26
|
*** robbyoconnor has joined #openmrs
|
02:26:26
|
*** ChanServ sets mode: +v robbyoconnor
|
02:34:45
|
*** r0bby has joined #openmrs
|
02:34:45
|
*** ChanServ sets mode: +v r0bby
|
02:36:02
|
*** downey has joined #openmrs
|
02:36:02
|
*** ChanServ sets mode: +o downey
|
02:36:02
|
*** OpenMRSBot sets mode: +o downey
|
02:37:23
|
*** robbyoconnor has quit IRC
|
02:47:00
|
*** Anuruddha has joined #openmrs
|
03:04:48
|
*** r0bby has quit IRC
|
03:07:41
|
*** r0bby has joined #openmrs
|
03:07:41
|
*** ChanServ sets mode: +v r0bby
|
03:10:37
|
*** edcalip has joined #openmrs
|
03:13:39
|
*** r0bby has quit IRC
|
03:16:06
|
*** djadmin has quit IRC
|
03:16:14
|
*** djadmin has joined #openmrs
|
03:25:27
|
*** edcalip has quit IRC
|
03:26:33
|
*** djadmin has quit IRC
|
03:33:03
|
*** Anuruddha has quit IRC
|
03:33:20
|
*** Anuruddha has joined #openmrs
|
03:34:09
|
*** downey has quit IRC
|
03:49:15
|
*** mseaton has joined #openmrs
|
03:49:15
|
*** ChanServ sets mode: +v mseaton
|
03:51:18
|
*** djadmin has joined #openmrs
|
03:53:37
|
*** DraggonZ has quit IRC
|
03:55:04
|
*** mseaton has quit IRC
|
03:55:40
|
*** DraggonZ has joined #openmrs
|
04:04:14
|
*** jb360 has joined #openmrs
|
04:11:39
|
*** r0bby has joined #openmrs
|
04:11:39
|
*** ChanServ sets mode: +v r0bby
|
04:13:41
|
*** djadmin has quit IRC
|
04:17:59
|
*** harsz89 has joined #openmrs
|
04:22:33
|
*** andrea_ has quit IRC
|
04:23:29
|
*** harsz89 has quit IRC
|
04:27:26
|
*** mseaton has joined #openmrs
|
04:27:26
|
*** ChanServ sets mode: +v mseaton
|
04:30:27
|
*** mseaton has quit IRC
|
04:32:11
|
*** djazayeri has quit IRC
|
04:33:11
|
*** djazayeri has joined #openmrs
|
04:33:11
|
*** ChanServ sets mode: +o djazayeri
|
04:38:25
|
*** shortend has joined #openmrs
|
04:42:31
|
*** mseaton has joined #openmrs
|
04:42:31
|
*** ChanServ sets mode: +v mseaton
|
04:49:37
|
*** shortend has quit IRC
|
05:03:46
|
*** Hasintha_i has joined #openmrs
|
05:05:43
|
*** evmw has quit IRC
|
05:20:03
|
*** kishoreyekkanti has joined #openmrs
|
05:21:12
|
*** Hasintha_i has quit IRC
|
05:27:46
|
*** kishoreyekkanti_ has joined #openmrs
|
05:30:17
|
*** kishoreyekkanti has quit IRC
|
05:30:18
|
*** kishoreyekkanti_ is now known as kishoreyekkanti
|
05:33:53
|
*** Anuruddha has quit IRC
|
05:37:47
|
*** mseaton has quit IRC
|
05:37:56
|
*** Anuruddha has joined #openmrs
|
05:43:20
|
*** djazayeri has quit IRC
|
05:49:25
|
*** Echidna has quit IRC
|
05:49:37
|
*** Echidna has joined #openmrs
|
05:49:37
|
*** ChanServ sets mode: +v Echidna
|
05:50:53
|
*** davidpardz has joined #openmrs
|
05:51:40
|
*** djazayeri has joined #openmrs
|
05:51:40
|
*** ChanServ sets mode: +o djazayeri
|
06:00:34
|
*** kishoreyekkanti has quit IRC
|
06:04:54
|
*** harshadura has quit IRC
|
06:05:04
|
*** harshadura has joined #openmrs
|
06:05:05
|
*** harshadura_ has joined #openmrs
|
06:13:45
|
*** evmw has joined #openmrs
|
06:14:49
|
*** harsz89 has joined #openmrs
|
06:17:44
|
<harsz89> rafa:thanks i'll wait till thursday
|
06:18:11
|
<harsz89> rafa:I was interested in rest api related things
|
06:18:26
|
<harsz89> rafa:i'll have a look till thursday
|
06:18:39
|
<harsz89> rafa:thank you!
|
06:19:48
|
*** Hasintha_i has joined #openmrs
|
06:48:02
|
*** DraggonZ has quit IRC
|
06:48:24
|
*** DraggonZ has joined #openmrs
|
06:51:35
|
*** kishoreyekkanti has joined #openmrs
|
06:54:16
|
*** DraggonZ has quit IRC
|
06:54:35
|
*** DraggonZ has joined #openmrs
|
06:56:12
|
*** kishoreyekkanti_ has joined #openmrs
|
06:56:24
|
*** DraggonZ has quit IRC
|
06:58:17
|
*** harshadura has quit IRC
|
06:59:47
|
*** kishoreyekkanti has quit IRC
|
06:59:49
|
*** kishoreyekkanti_ is now known as kishoreyekkanti
|
07:13:51
|
*** Hasintha_i has quit IRC
|
07:21:18
|
*** djazayeri has quit IRC
|
07:36:11
|
*** Echidna has quit IRC
|
07:36:26
|
*** Echidna has joined #openmrs
|
07:36:26
|
*** ChanServ sets mode: +v Echidna
|
07:58:15
|
*** davidpardz has left #openmrs
|
07:58:33
|
*** djadmin has joined #openmrs
|
07:59:05
|
*** harshadura has joined #openmrs
|
08:01:17
|
*** Anuruddha has quit IRC
|
08:05:11
|
*** Hasintha_i has joined #openmrs
|
08:14:54
|
*** dkayiwa has joined #openmrs
|
08:19:45
|
<harshadura> dkayiwa, can u help me to reduce my commit messages into 1 ? i didn got the right command to do it
|
08:20:21
|
<dkayiwa> harshadura, can you show me the urll
|
08:20:41
|
<harshadura> dkayiwa, did u mean the pull rqst url ?
|
08:20:58
|
<dkayiwa> harshadura, yes
|
08:21:20
|
<harshadura> dkayiwa: https://github.com/openmrs/openmrs-core/pull/222
|
08:21:21
|
<OpenMRSBot> <http://ln-s.net/+inM> (at github.com)
|
08:23:21
|
<dkayiwa> harshadura, step 1) backup your changes somewhere
|
08:23:34
|
<harshadura> ok dkayiwa
|
08:23:38
|
*** Echidna has quit IRC
|
08:23:47
|
*** Anuruddha has joined #openmrs
|
08:23:49
|
*** Echidna has joined #openmrs
|
08:23:49
|
*** ChanServ sets mode: +v Echidna
|
08:24:08
|
<dkayiwa> harshadura, 2) git checkout master
|
08:24:55
|
<dkayiwa> harshadura, 3) git reset --hard upstream/master
|
08:25:13
|
<harshadura> ohh
|
08:25:19
|
*** DraggonZ has joined #openmrs
|
08:25:21
|
<dkayiwa> 4) git pull upstream master
|
08:25:46
|
<dkayiwa> 5) mvn clean install
|
08:26:11
|
<dkayiwa> harshadura, tell me after step 5 for the next steps
|
08:26:56
|
<harshadura> ok dkayiwa thx but i tht it would be straight forward
|
08:27:02
|
<harshadura> something like git rebase
|
08:27:32
|
<harshadura> i didn gt the way to do it properly tho
|
08:27:44
|
<dkayiwa> harshadura, yes it is. this is simply beacause you have already messed it up :)
|
08:28:05
|
<dkayiwa> harshadura, so these are simply corrective messures
|
08:28:11
|
*** kishoreyekkanti has quit IRC
|
08:28:33
|
<harshadura> gotcha dkayiwa, can u tell me the other commands also nw
|
08:28:51
|
<dkayiwa> harshadura, in otherwards, all you needed was a simple git checkout master before you created your branch
|
08:29:34
|
<dkayiwa> harshadura, so missing just that one step is what has led to having to do all these many steps to correct what is nessed up
|
08:29:56
|
<dkayiwa> harshadura, does this make sense
|
08:30:51
|
<harshadura> ok dkayiwa
|
08:31:24
|
*** djadmin has quit IRC
|
08:33:55
|
<harshadura> dkayiwa, 3) git reset --hard upstream/master gives an error
|
08:34:08
|
<harshadura> fatal: ambiguous argument 'upstream/master': unknown revision or path not in the working tree.
|
08:34:08
|
<harshadura> Use '--' to separate paths from revisions
|
08:35:17
|
<dkayiwa> harshadura, from which folder are you executing it
|
08:35:39
|
<harshadura> dkayiwa, openmrs-core/
|
08:36:20
|
<dkayiwa> harshadura, paste here the exact command you used
|
08:37:06
|
<harshadura> harshadura@harshadura-azus:~/Desktop/openmrs-core$ git reset --hard upstream/master
|
08:37:06
|
<harshadura> fatal: ambiguous argument 'upstream/master': unknown revision or path not in the working tree.
|
08:37:06
|
<harshadura> Use '--' to separate paths from revisions
|
08:39:58
|
<dkayiwa> harshadura, how about: git reset --hard upstream master
|
08:41:33
|
<DraggonZ> Hi, folks! Is it normal that after 'mvn clean install' there are errors and failures in tests?
|
08:41:55
|
<DraggonZ> At api project
|
08:42:18
|
<harshadura> dkayiwa, it also gives an error
|
08:42:25
|
<DraggonZ> Because of this i can't build api project
|
08:42:26
|
<harshadura> harshadura@harshadura-azus:~/Desktop/openmrs-core$ git reset --hard upstream master
|
08:42:26
|
<harshadura> fatal: ambiguous argument 'upstream': unknown revision or path not in the working tree.
|
08:42:26
|
<harshadura> Use '--' to separate paths from revisions
|
08:43:00
|
<dkayiwa> harshadura, and how about: git pull upstream master
|
08:43:01
|
<harshadura> DraggonZ: use "mvn clean install -DskipTests"
|
08:43:24
|
<harshadura> so the tests will be skipped and ultimately project will be built
|
08:44:19
|
<DraggonZ> harshadura, thank you!
|
08:44:20
|
<harshadura> dkayiwa: harshadura@harshadura-azus:~/Desktop/openmrs-core$ git pull upstream master
|
08:44:20
|
<harshadura> fatal: 'upstream' does not appear to be a git repository
|
08:44:20
|
<harshadura> fatal: The remote end hung up unexpectedly
|
08:45:29
|
<dkayiwa> harshadura, did you add the master remote upstream as per the wiki instructions on using git?
|
08:47:40
|
*** DraggonZ has quit IRC
|
08:49:07
|
<harshadura> dkayiwa, srry i think i hv missed it, now step 3 works: git reset --hard upstream/master
|
08:49:07
|
<harshadura> done
|
08:49:28
|
<dkayiwa> harshadura, can you now go back to our steps
|
08:50:11
|
<harshadura> dkayiwa, i hv done all, mvn is building now, can u go start the rest
|
08:50:30
|
<dkayiwa> harshadura, tell me when it has completed
|
08:50:43
|
<harshadura> ok dkayiwa
|
08:50:44
|
*** DraggonZ has joined #openmrs
|
08:50:54
|
<DraggonZ> Another fail...
|
08:51:04
|
<DraggonZ> Failed to execute goal org.apache.maven.plugins:maven-dependency-plugin:2.1:unpack (unpack) on project openmrs-release-test: Execution unpack of goal org.apache.maven.plugins:maven-dependency-plugin:2.1:unpack failed: Plugin org.apache.maven.plugins:maven-dependency-plugin:2.1 or one of its dependencies could not be resolved: Failed to collect dependencies for org.apache.maven.plugins:maven-dependency-plugin:jar:2.1 (): Failed to read artifact descriptor
|
08:51:57
|
<harshadura> dkayiwa, its done
|
08:52:19
|
*** cube__ has joined #openmrs
|
08:52:24
|
<cube__> ,can some please tell me which platform does answers.openmrs.org use ?
|
08:52:42
|
<dkayiwa> harshadura, does it show any of our files (where you are going to make changes) as modified?
|
08:53:07
|
<harshadura> cube_: OSQA : http://www.osqa.net/
|
08:53:47
|
<cube__> harshadura: thank u
|
08:55:32
|
<harshadura> dkayiwa, did u mean aftr git pull upstream master ?
|
08:55:46
|
<dkayiwa> harshadura, after the clean install
|
08:55:49
|
<dkayiwa> mvn
|
08:57:09
|
<harshadura> no dkayiwa, it shows some other files as modified
|
08:57:11
|
<harshadura> # modified: api/src/main/java/org/openmrs/Concept.java
|
08:57:11
|
<harshadura> # modified: api/src/main/java/org/openmrs/ConceptName.java
|
08:57:11
|
<harshadura> # modified: api/src/test/java/org/openmrs/ConceptTest.java
|
08:57:11
|
<harshadura> # modified: api/src/test/java/org/openmrs/hl7/handler/ORUR01HandlerTest.java
|
08:57:11
|
<harshadura> # modified: web/src/main/java/org/openmrs/web/controller/ConceptFormController.java
|
08:57:12
|
<harshadura> # modified: web/src/test/java/org/openmrs/web/controller/ConceptFormControllerTest.java
|
08:57:28
|
<harshadura> i did a git status
|
08:58:43
|
<dkayiwa> harshadura, does that include any of the files where you are going to change?
|
08:59:04
|
<harshadura> no one dkayiwa
|
08:59:43
|
<dkayiwa> harshadura, now create a branch with a name \different from the old one
|
09:01:05
|
<harshadura> ok dkayiwa its done
|
09:01:15
|
<DraggonZ> oh, i'm stupid)
|
09:01:30
|
<dkayiwa> harshadura, switch to it and add in your changes
|
09:02:42
|
<harshadura> ok dkayiwa
|
09:02:55
|
<DraggonZ> my internet connection was lost, when i done 'clean install'
|
09:03:37
|
<dkayiwa> DraggonZ, you surely are a dragon :)
|
09:06:04
|
<cube__> is OpenMRS developing an app for mobile ?
|
09:06:20
|
*** dmulinwa has joined #openmrs
|
09:07:10
|
<dmulinwa> hi all..i am new to openmrs and unit testing in particular..
|
09:08:57
|
<dkayiwa> dkayiwa, ok
|
09:12:32
|
*** cube__ has quit IRC
|
09:13:16
|
<dmulinwa> i did a small fix for https://tickets.openmrs.org/browse/TRUNK-3654 and now i am trying to figure out how i should word the unit test. i have come up with something and was wondering if i wud be ok to call a unit test. "should throw ModuleException if number matching upper end of the require version with wild cards exceed the maximum Integer value (2^31)" Once again i am new to this kind of thing and will be gratefull for any he
|
09:13:36
|
<DraggonZ> dkayiwa, are you talking to yourself? :)
|
09:13:57
|
<dkayiwa> DraggonZ, ummmm :)
|
09:16:34
|
<dkayiwa> dmulinwa, have you looked at? ModuleUtilTest
|
09:18:18
|
<dmulinwa> dkayiwa: yes i have..
|
09:19:08
|
<dkayiwa> dmulinwa, so you can write a test where openmrsVersion has SNAPSHOT
|
09:19:31
|
<dkayiwa> dmulinwa, and then the test should prove that it will not be treated as 999
|
09:19:56
|
<dkayiwa> dmulinwa, this test should fail without your fix (e.g when your fix is commented out)
|
09:20:06
|
<dkayiwa> dmulinwa, but should pass when your fix is in
|
09:20:17
|
<dkayiwa> dmulinwa, does this throw some more light?
|
09:22:33
|
*** dmulinwa has quit IRC
|
09:22:56
|
*** dmulinwa has joined #openmrs
|
09:24:05
|
<dkayiwa> dmulinwa, so you can write a test where openmrsVersion has SNAPSHOT
|
09:24:06
|
<dkayiwa> <dkayiwa> dmulinwa, and then the test should prove that it will not be treated as 999
|
09:24:06
|
<dkayiwa> <dkayiwa> dmulinwa, this test should fail without your fix (e.g when your fix is commented out)
|
09:24:06
|
<dkayiwa> <dkayiwa> dmulinwa, but should pass when your fix is in
|
09:24:06
|
<dkayiwa> <dkayiwa> dmulinwa, does this throw some more light?
|
09:28:07
|
<dmulinwa> yes it does..
|
09:29:10
|
<dmulinwa> dkayiwa: yes it does shade some light
|
09:29:45
|
*** Echidna has quit IRC
|
09:29:49
|
<dkayiwa> dmulinwa, did you also have a look at where all this started? https://tickets.openmrs.org/browse/RESTWS-275
|
09:30:46
|
<DraggonZ> How to start learn developing OpenMRS: by resolving tickets or by writing own simple module?
|
09:31:21
|
<DraggonZ> Or may be i should learn SpringMVC first?
|
09:32:44
|
*** cube_ has joined #openmrs
|
09:32:52
|
<dkayiwa> DraggonZ, you could start by doing some intro tickets
|
09:33:56
|
<DraggonZ> dkayiwa, thank u again :)
|
09:34:41
|
<dkayiwa> DraggonZ, you are welcome to OpenMRS!!!
|
09:46:26
|
*** Boniface has joined #openmrs
|
10:15:08
|
*** harshadura has quit IRC
|
10:16:45
|
*** k-joseph has joined #openmrs
|
10:24:14
|
*** k_joseph has joined #openmrs
|
10:24:29
|
*** k-joseph has quit IRC
|
10:24:36
|
*** k_joseph has joined #openmrs
|
10:40:57
|
*** Echidna has joined #openmrs
|
10:40:57
|
*** ChanServ sets mode: +v Echidna
|
10:42:19
|
*** k_joseph is now known as k-joseph
|
10:59:06
|
*** cube_ has quit IRC
|
11:08:08
|
*** Echidna has quit IRC
|
11:08:08
|
*** Echidna_ has joined #openmrs
|
11:09:38
|
*** dmulinwa has quit IRC
|
11:16:17
|
*** k-joseph has quit IRC
|
11:16:20
|
*** Anuruddha has quit IRC
|
11:31:04
|
*** djadmin has joined #openmrs
|
11:36:48
|
*** shangxiao has joined #openmrs
|
11:45:33
|
*** Hasintha_i has quit IRC
|
11:48:52
|
*** k-joseph has joined #openmrs
|
11:50:42
|
*** harshadura has joined #openmrs
|
11:58:49
|
*** suranga has joined #openmrs
|
11:58:49
|
*** ChanServ sets mode: +v suranga
|
11:59:35
|
<suranga> mm... helooo dkayiwa :)
|
11:59:50
|
<dkayiwa> suranga, ummm :)
|
11:59:58
|
<suranga> dkayiwa, :)
|
12:00:18
|
<suranga> are you famiiar with the openmrs-search.js that we use to search by names / identifiers ? :0
|
12:00:36
|
<suranga> dkayiwa, sorry, i meant :), not :0
|
12:00:57
|
<dkayiwa> suranga, no
|
12:01:01
|
*** shangxiao has quit IRC
|
12:01:04
|
<suranga> dkayiwa, :(
|
12:01:11
|
<suranga> dkayiwa, who wrote it, Ben ?
|
12:01:25
|
<dkayiwa> suranga, maybe wyclif_
|
12:01:47
|
<suranga> dkayiwa, aha ! wyclif_ is still not here, is he ?
|
12:02:08
|
*** evmw has quit IRC
|
12:02:40
|
<dkayiwa> suranga, ask him :)
|
12:03:05
|
<suranga> dkayiwa, he hee.. will catch him when he gets here :P
|
12:07:29
|
*** k-joseph has quit IRC
|
12:08:26
|
*** evmw has joined #openmrs
|
12:09:45
|
*** ekow has joined #openmrs
|
12:10:59
|
<ekow> Hi Guys, just popped up openmrs from http://127.0.1:8080/initialsetup. I need to stop jetty from running. How do I do that i.e. STOP JETTY?
|
12:12:53
|
*** kishoreyekkanti has joined #openmrs
|
12:16:11
|
<suranga> hi ekow , to kill jetty, try ctrc + C
|
12:17:37
|
*** harshadura has quit IRC
|
12:18:25
|
*** harshadura has joined #openmrs
|
12:18:41
|
*** evmw has quit IRC
|
12:18:45
|
<ekow> <suranga>I did not start it from the terminal. It was started from eclipse ....
|
12:25:25
|
<dkayiwa> ekow, in eclipse there is a button for display selected console. do you see it
|
12:26:29
|
<dkayiwa> ekow, you can click it and then it will display the jetty log on console and you will see a red button you can click to stop it from running
|
12:32:51
|
*** moshon has joined #openmrs
|
12:37:43
|
*** evmw has joined #openmrs
|
12:48:00
|
*** denuwanthi has joined #openmrs
|
12:53:43
|
*** djadmin has quit IRC
|
12:56:50
|
*** kishoreyekkanti has quit IRC
|
12:58:52
|
*** kishoreyekkanti has joined #openmrs
|
12:59:31
|
*** shangxiao has joined #openmrs
|
13:00:31
|
*** harshadura has quit IRC
|
13:02:25
|
*** kishoreyekkanti has quit IRC
|
13:02:55
|
*** denuwanthi has quit IRC
|
13:10:19
|
*** harshadura has joined #openmrs
|
13:10:47
|
*** shangxiao has quit IRC
|
13:11:34
|
*** djadmin has joined #openmrs
|
13:12:01
|
*** mseaton has joined #openmrs
|
13:12:01
|
*** ChanServ sets mode: +v mseaton
|
13:16:45
|
*** djadmin has quit IRC
|
13:34:12
|
*** djadmin has joined #openmrs
|
13:36:06
|
*** wyclif_ has quit IRC
|
13:41:28
|
<harsz89> hi all!
|
13:41:32
|
<harsz89> i perform a rest call to /ws/rest/v1/catalog resource to check the response
|
13:41:41
|
<harsz89> but it not succeed
|
13:42:05
|
<harsz89> return with java.lang.NoSuchMethodError: org.openmrs.api.OrderService.getOrderType error
|
13:42:45
|
<harsz89> AFAIK the cotalog class display the available resources
|
13:44:42
|
<harsz89> i have able to send and recieve responses from other resources such as concept and etc
|
13:45:21
|
<harsz89> is something i'm doing wrong here?
|
13:46:10
|
<harsz89> i used soapui and tried with curl too
|
13:46:20
|
<harsz89> same error returned
|
13:46:33
|
*** djadmin has quit IRC
|
13:46:35
|
*** rkorytkowski has joined #openmrs
|
13:46:35
|
*** ChanServ sets mode: +v rkorytkowski
|
13:46:35
|
*** rkorytkowski is now known as rafa
|
13:47:57
|
*** GitHub9 has joined #openmrs
|
13:47:57
|
<GitHub9> [openmrs-core] dkayiwa pushed 1 new commit to 1.9.x: http://git.io/AtY52A
|
13:47:57
|
<GitHub9> openmrs-core/1.9.x cf2d378 Daniel Kayiwa: Retrieving a ProgramWorkflow by name in a the ModuleActivator started...
|
13:47:57
|
*** GitHub9 has left #openmrs
|
13:58:33
|
*** rkorytkowski has joined #openmrs
|
13:58:33
|
*** ChanServ sets mode: +v rkorytkowski
|
13:58:33
|
*** rafa is now known as Guest89074
|
13:58:45
|
*** k-joseph has joined #openmrs
|
13:58:48
|
*** Guest89074 has quit IRC
|
14:00:00
|
*** rkorytkowski is now known as rafa
|
14:17:16
|
*** k_joseph has joined #openmrs
|
14:17:39
|
*** k-joseph has quit IRC
|
14:20:09
|
*** harsz89 has quit IRC
|
14:21:29
|
*** downey has joined #openmrs
|
14:21:29
|
*** ChanServ sets mode: +o downey
|
14:21:29
|
*** OpenMRSBot sets mode: +o downey
|
14:22:01
|
<k_joseph> dkayiwa: hi
|
14:22:07
|
*** k_joseph is now known as k-joseph
|
14:22:21
|
<dkayiwa> k-joseph, hi
|
14:24:12
|
*** ekow has quit IRC
|
14:25:40
|
*** kishoreyekkanti has joined #openmrs
|
14:27:14
|
*** wyclif_ has joined #openmrs
|
14:27:57
|
*** lhawthor_ has joined #openmrs
|
14:28:54
|
*** lhawthor_ is now known as lh
|
14:29:10
|
*** jkeiper has quit IRC
|
14:30:06
|
*** kishoreyekkanti has quit IRC
|
14:30:18
|
*** kishoreyekkanti has joined #openmrs
|
14:32:05
|
*** lh has quit IRC
|
14:33:46
|
*** harsz89 has joined #openmrs
|
14:35:48
|
*** cosmas has joined #openmrs
|
14:44:13
|
*** cosmas has quit IRC
|
14:53:53
|
<harsz89> i have deploy the rest webservices module in my application data folder
|
14:53:59
|
<harsz89> and it's wokr fine
|
14:54:15
|
<harsz89> but when i try to access help page from the administration page
|
14:54:36
|
<harsz89> i got http://localhost:8080/openmrs/admin/module/webservices/rest/help.form not found error
|
14:54:59
|
<harsz89> i run openmrs on jetty
|
14:55:44
|
*** downey has quit IRC
|
14:56:40
|
*** downey has joined #openmrs
|
14:56:40
|
*** ChanServ sets mode: +o downey
|
14:58:20
|
*** rkorytkowski has joined #openmrs
|
14:58:20
|
*** ChanServ sets mode: +v rkorytkowski
|
14:58:20
|
*** rafa is now known as Guest46284
|
14:58:35
|
*** rkorytkowski is now known as rafa
|
15:00:34
|
<rafa> cpower: hi
|
15:00:36
|
<cpower> Hello everyone
|
15:00:46
|
<rafa> put me first please :)
|
15:01:04
|
<rafa> I have 10 minutes
|
15:01:15
|
<cpower> Well then let's get started!
|
15:01:21
|
<cpower> !scrumon cpower
|
15:01:21
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
15:01:23
|
*** k-joseph has quit IRC
|
15:01:50
|
<cpower> Order: rafa, mseaton, suranga, dkayiwa, wyclif_, and Andrea when she arrives
|
15:01:51
|
*** Guest46284 has quit IRC
|
15:02:00
|
<rafa> Today:
|
15:02:00
|
<rafa> * Reviewed and merged code
|
15:02:00
|
<rafa> * Reclaimed and completed:
|
15:02:00
|
<rafa> + RESTWS-339: Fix PersonAttributeControllerTest
|
15:02:00
|
<rafa> https://tickets.openmrs.org/browse/RESTWS-339
|
15:02:00
|
<rafa> + RESTWS-328: Fix EncounterControllerTest
|
15:02:00
|
<rafa> https://tickets.openmrs.org/browse/RESTWS-328
|
15:02:01
|
<rafa> * Started work on RESTWS-360: Document 2.0 resource and subresource annotations
|
15:02:01
|
<rafa> https://tickets.openmrs.org/browse/RESTWS-360
|
15:02:02
|
<rafa> * Univ Call
|
15:02:02
|
<rafa> No blockers.
|
15:02:47
|
<mseaton> nothing much to report. preparing for sync sprint and lots of calls.
|
15:02:55
|
<cpower> fair enough
|
15:02:58
|
<cpower> suranga?
|
15:03:10
|
*** k-joseph has joined #openmrs
|
15:04:04
|
<cpower> Next!
|
15:04:15
|
<dkayiwa> Back ported: Retrieving a ProgramWorkflow by name in a the ModuleActivator started method throws an error - TRUNK-3739
|
15:04:16
|
<dkayiwa> Committed: DateFormat error in XformBuilder - XFRM-130
|
15:04:16
|
<dkayiwa> Reviewing: Unnecessary logged exceptions when saving forms (Save Handlers should ignore deprecated properties) - TRUNK-3862
|
15:04:16
|
<dkayiwa> No Blockers
|
15:04:27
|
<wyclif_> Tuesday:
|
15:04:28
|
<wyclif_> Review TODOs for PersonControllerTesT and PatientControllerTest
|
15:04:28
|
<wyclif_> RevisiRESTWS-350 - Fix catalog to work with new resources and subresources
|
15:04:28
|
<wyclif_> Wednesday:
|
15:04:28
|
<wyclif_> Fix catalog to work for reference terms and maps
|
15:04:28
|
<wyclif_> Fix catalog to work custom datatypes
|
15:04:30
|
<wyclif_> design call
|
15:04:32
|
<wyclif_>
|
15:04:34
|
<wyclif_> Blockers: None
|
15:05:56
|
<rafa> sounds good!
|
15:06:12
|
<cpower> Any other updates?
|
15:06:43
|
<rafa> I'll be wrapping up a sprint tomorrow so today is the last day for commits.
|
15:06:50
|
<cpower> Announncements: Today is the last day for RESTWS, starting tomorrow is community driven while Kiran and I reload.
|
15:07:16
|
<cpower> Design call today: A little Sync and a little External Authentication
|
15:07:44
|
<cpower> and now under 10 mins for rafa.
|
15:07:55
|
<cpower> !scrumoff
|
15:07:55
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
15:07:56
|
<rafa> Thank you!
|
15:08:16
|
<rafa> I'll be back in a few hours
|
15:09:11
|
*** rafa has quit IRC
|
15:11:31
|
<k-joseph> dkayiwa: serialisation, helps me to store an object's property, which property in my case, is it a new property that am to define and store, or am to use the already existing object, i still need to know more what serealization is a bout, and relate it to de-serealization,
|
15:12:06
|
<k-joseph> dkayiwa: consider http://pastebin.com/4pKut13e
|
15:12:25
|
<dkayiwa> k-joseph, you return an object property's value and then the serialization framework stores that value for you
|
15:12:55
|
<dkayiwa> k-joseph, then during deserialization, the framework gives you that value for you to return its associated object
|
15:12:55
|
*** jkeiper has joined #openmrs
|
15:12:55
|
*** ChanServ sets mode: +v jkeiper
|
15:13:01
|
<dkayiwa> k-joseph, does this make some sense?
|
15:13:13
|
*** suranga has quit IRC
|
15:13:39
|
<k-joseph> dkayiwa: it makes sense
|
15:13:59
|
<dkayiwa> k-joseph, so can you do according to that and show me?
|
15:15:23
|
<k-joseph> dkayiwa: whose property then, is it for the class whose datatype we are writting? or the datatype its self
|
15:16:19
|
<dkayiwa> k-joseph, the ticket mentions the object you are dealing with
|
15:16:28
|
<dkayiwa> k-joseph, do you see it?
|
15:16:44
|
<k-joseph> dkayiwa: Concept
|
15:16:56
|
<dkayiwa> k-joseph, OK
|
15:16:58
|
<k-joseph> ?
|
15:17:03
|
<k-joseph> dkayiwa: ok
|
15:22:30
|
*** GitHub65 has joined #openmrs
|
15:22:30
|
<GitHub65> [openmrs-core] mseaton pushed 2 new commits to 1.9.x: http://git.io/Z-J2Ig
|
15:22:30
|
<GitHub65> openmrs-core/1.9.x 096ac4f Rowan Seymour: TRUNK-3768: drugOrder.drug should not be a mandatory field for drug order
|
15:22:30
|
<GitHub65> openmrs-core/1.9.x 85c1255 Michael Seaton: Merge pull request #223 from rowanseymour/1.9.x...
|
15:22:30
|
*** GitHub65 has left #openmrs
|
15:31:12
|
*** harshadura_ has joined #openmrs
|
15:32:51
|
*** GitHub169 has joined #openmrs
|
15:32:51
|
<GitHub169> [openmrs-core] dkayiwa pushed 2 new commits to master: http://git.io/VWLTrw
|
15:32:51
|
<GitHub169> openmrs-core/master e1ae35e Rowan Seymour: TRUNK-3862: Unnecessary logged exceptions when saving forms
|
15:32:51
|
<GitHub169> openmrs-core/master de7fd1b dkayiwa: Merge pull request #219 from rowanseymour/master...
|
15:32:51
|
*** GitHub169 has left #openmrs
|
15:38:33
|
<harsz89> dkayiwa, hi
|
15:38:52
|
<harsz89> dkayiwa, can i clarify something?
|
15:38:59
|
<dkayiwa> harsz89, ok
|
15:39:23
|
<harsz89> dkayiwa, i'm deploy the rest webservises module in openmrs
|
15:39:46
|
<harsz89> dkayiwa, and it succesfully working
|
15:40:13
|
<harsz89> dkayiwa, but when i try to goto help page of the module which is available as a link
|
15:40:20
|
<harsz89> dkayiwa, it not available
|
15:40:42
|
<harsz89> dkayiwa, ws my module deployment not correctly?
|
15:41:09
|
<dkayiwa> harsz89, which version of module and openmrs
|
15:41:44
|
<harsz89> dkayiwa, i build the openmrs and the rest services in my local repo
|
15:41:57
|
<harsz89> dkayiwa, openmrs running on jetty
|
15:42:45
|
<dkayiwa> harsz89, are you working on the sprint?
|
15:44:16
|
*** travis-ci has joined #openmrs
|
15:44:16
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [de7fd1b] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/5106057
|
15:44:16
|
*** travis-ci has left #openmrs
|
15:44:17
|
<harsz89> dkayiwa, nope i'm new to openmrs and trying to get familiar with rest web services module
|
15:44:22
|
<OpenMRSBot> <http://ln-s.net/+jIK> (at travis-ci.org)
|
15:45:00
|
<dkayiwa> harsz89, any errors on the console?
|
15:45:20
|
*** DraggonZ has left #openmrs
|
15:45:56
|
<harsz89> dkayiwa, fron end -The page "/openmrs/admin/module/webservices/rest/help.form" cannot be found. Check the link and try again.
|
15:46:39
|
<harsz89> dkayiwa, back end console-No mapping found for HTTP request with URI [/openmrs/admin/module/webservices/rest/help.form] in DispatcherServlet with name 'openmrs'
|
15:46:45
|
<dkayiwa> harsz89, any errors on eclipse console
|
15:47:27
|
<harsz89> dkayiwa, i'm runnig using mvn jetty:run
|
15:47:49
|
<k-joseph> this is giving much trouble solving it than i had thought, before, first of all hoping my serialize() is ok, am still having some complications on how to return the object value that is stored during serialization,
|
15:48:24
|
<dkayiwa> harsz89, running from eclipse?
|
15:48:45
|
*** supungs has joined #openmrs
|
15:49:01
|
<dkayiwa> k-joseph, you just chose any object property you can use to uniquely identify it
|
15:49:07
|
<dkayiwa> k-joseph, does that make sense?
|
15:49:38
|
<harsz89> dkayiwa, not by eclipse plugin
|
15:49:49
|
<dkayiwa> k-joseph, any property of the object, which can be used to uniquely identify it
|
15:50:08
|
<harsz89> dkayiwa, normal mvn jettty plugin from my bash console
|
15:50:25
|
<dkayiwa> harsz89, can you try the release version of the module and see if it gives you the same error?
|
15:50:42
|
<harsz89> dkayiwa, oki i'll hav a look
|
15:50:52
|
<harsz89> dkayiwa, thanks for the time
|
15:51:02
|
<harsz89> dkayiwa, :)
|
15:51:12
|
<k-joseph> dkayiwa: am using uuid, in this case
|
15:51:32
|
<dkayiwa> k-joseph, and what complication do you find with it?
|
15:54:43
|
*** GitHub158 has joined #openmrs
|
15:54:43
|
<GitHub158> [openmrs-core] wluyima pushed 1 new commit to master: http://git.io/g1Nvsw
|
15:54:43
|
<GitHub158> openmrs-core/master 70eb4f1 wluyima: Bad error message is displayed when reference term validation fails -...
|
15:54:43
|
*** GitHub158 has left #openmrs
|
15:54:46
|
<k-joseph> dkayiwa: returning the value for uuid, is during serialization is still tricky for me to hundle
|
15:55:12
|
<dkayiwa> k-joseph, do you mean you do not know how to return a uud from a concept?
|
15:56:47
|
*** Hasintha_i has joined #openmrs
|
15:59:48
|
*** evmw has quit IRC
|
16:00:19
|
*** kishoreyekkanti has quit IRC
|
16:00:42
|
*** GitHub177 has joined #openmrs
|
16:00:42
|
<GitHub177> [openmrs-core] wluyima pushed 1 new commit to 1.9.x: http://git.io/aBEKBQ
|
16:00:42
|
<GitHub177> openmrs-core/1.9.x 00a0e4e wluyima: Bad error message is displayed when reference term validation fails -...
|
16:00:42
|
*** GitHub177 has left #openmrs
|
16:01:15
|
*** applecool has joined #openmrs
|
16:01:15
|
*** ChanServ sets mode: +v applecool
|
16:01:33
|
<applecool> hi dkayiwa
|
16:02:00
|
<dkayiwa> applecool, hi
|
16:02:28
|
<applecool> i have created a branch as you told me to do it for the ticket
|
16:03:13
|
<applecool> and while selecting the files by using git add -i ! I just need to update the selected files and do git commit?
|
16:03:32
|
<applecool> is that it? or am i messing up anywhere?
|
16:03:50
|
<dkayiwa> applecool, you do not need to do any git add -i
|
16:03:57
|
<dkayiwa> applecool, why would you need it?
|
16:04:15
|
<applecool> because i have some more files which i changed
|
16:04:34
|
<applecool> so if i dont select the files. even those changes would be added to the commit right
|
16:05:20
|
<dkayiwa> applecool, are you using eclipse for committing?
|
16:05:29
|
<applecool> no using terminal
|
16:06:29
|
<dkayiwa> applecool, ok just commit and make pull request
|
16:06:43
|
<applecool> okay will do it in a moment
|
16:07:05
|
*** jkeiper is now known as applemeh
|
16:07:18
|
<applemeh> mrh
|
16:07:20
|
<applemeh> s/r/e
|
16:07:25
|
*** applemeh is now known as jkeiper
|
16:07:30
|
<dkayiwa> yikes!!! :)
|
16:08:19
|
<jkeiper> heh
|
16:08:47
|
<applecool> dkayiwa: done!
|
16:08:54
|
<applecool> jkeiper: applemeh ;)
|
16:09:02
|
<jkeiper> ;-)
|
16:09:16
|
<dkayiwa> applecool, where
|
16:09:32
|
*** travis-ci has joined #openmrs
|
16:09:32
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [70eb4f1] [wluyima] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/5106691
|
16:09:32
|
*** travis-ci has left #openmrs
|
16:09:36
|
<OpenMRSBot> <http://ln-s.net/+jIw> (at travis-ci.org)
|
16:09:46
|
*** supungs has left #openmrs
|
16:10:25
|
<applecool> https://github.com/applecool/openmrs-core/tree/TRUNK-3876 dkayiwa
|
16:10:29
|
<OpenMRSBot> <http://ln-s.net/+jIx> (at github.com)
|
16:11:11
|
*** dmulinwa has joined #openmrs
|
16:11:42
|
<dkayiwa> applecool, the pull request
|
16:13:02
|
<applecool> oh!
|
16:13:42
|
<applecool> if i do pull it is giving me "i have unstaged changes"
|
16:15:06
|
<dkayiwa> applecool, a patient fears to go to hospital because he may get an accident on the road. so he decides to stay home and die. :)
|
16:15:09
|
*** kishoreyekkanti has joined #openmrs
|
16:15:11
|
*** djadmin has joined #openmrs
|
16:15:37
|
<applecool> :P dkayiwa
|
16:15:45
|
<jkeiper> mseaton, i have certain cells in a row-per-patient report that i want to have multiple entries in (working with the Kenya MOH 361A register), like multiple pregnancy due dates. I haven't dug too deeply yet, but do you have / know of any example templates (excel or html) that render out this way? ultimately i'd like to export it as a PDF ...
|
16:16:04
|
<jkeiper> mseaton, in other words, one cell with multiple rows within it
|
16:16:31
|
<jkeiper> mseaton, for a single patient row
|
16:16:54
|
<jkeiper> mseaton, whenever you get back ... not a question i need answered right away
|
16:17:08
|
* jkeiper should have sent an email ... bleh
|
16:20:41
|
<applecool> dkayiwa: http://pastebin.com/8BdGRVa4
|
16:22:46
|
<dkayiwa> applecool, did you add your changes before doing a pull?
|
16:23:02
|
<applecool> yes
|
16:23:20
|
<dkayiwa> applecool, then you will get conflicts
|
16:23:43
|
<dkayiwa> applecool, you start by pulling and then put in your changes.
|
16:24:00
|
<applecool> ok
|
16:24:13
|
*** dmulinwa has quit IRC
|
16:24:21
|
*** GitHub49 has joined #openmrs
|
16:24:21
|
<GitHub49> [openmrs-core] wluyima force-pushed master from 70eb4f1 to de7fd1b: http://git.io/qDZrgg
|
16:24:21
|
*** GitHub49 has left #openmrs
|
16:26:50
|
*** djazayeri has joined #openmrs
|
16:26:50
|
*** ChanServ sets mode: +o djazayeri
|
16:27:09
|
*** GitHub138 has joined #openmrs
|
16:27:09
|
<GitHub138> [openmrs-core] wluyima force-pushed 1.9.x from 00a0e4e to 85c1255: http://git.io/Nn16PA
|
16:27:09
|
*** GitHub138 has left #openmrs
|
16:27:47
|
*** k-joseph has quit IRC
|
16:34:53
|
<mseaton> jkeiper: sorry, am back
|
16:35:51
|
<mseaton> jkeiper: with a text-based template, you have full access to a groovy or velocity scripting context, so you can likely do what you need to do that way
|
16:36:06
|
<jkeiper> mseaton, ah cool ... thanks :-D
|
16:37:12
|
<mseaton> jkeiper: and with the excel template, there is a way to apply a formatter to a cell value, so if you have a column value that is a List<Obs> or List<Date> for example, you could potentially apply a formatter to the cell that you are inserting the data into to have it appear in the right way. or take the default.
|
16:37:44
|
*** wyclif_ has quit IRC
|
16:37:58
|
<applecool> even pull is not working dkayiwa .
|
16:38:09
|
*** wyclif has joined #openmrs
|
16:38:15
|
<applecool> how to revert the conflicts? dkayiwa
|
16:38:31
|
*** suranga has joined #openmrs
|
16:38:31
|
*** ChanServ sets mode: +v suranga
|
16:38:36
|
<jkeiper> mseaton, awesome ... that's what i was thinking about ... not sure how excel would allow inserting cells within a cell, but i'm sure it's somehow possible
|
16:38:54
|
<jkeiper> mseaton, but using groovy or an xml -> pdf something-or-other would probably work
|
16:39:00
|
<dkayiwa> applecool, back up your changes some where. then do a git hard reset
|
16:39:17
|
<dkayiwa> applecool, finally pull from upstream and put in your changes
|
16:39:32
|
<dkayiwa> applecool, that may be easier and safer than resolving conflicts
|
16:39:43
|
<applecool> ok
|
16:44:00
|
<jkeiper> mseaton, to use the reporting request mechanism, i need to have an existing report definition in the database right? can i make one that refers to a class where i define the columns via code?
|
16:49:09
|
<jkeiper> dkayiwa, what is necessary for an xform to show up in the Form Entry tab of a patient dashboard?
|
16:49:15
|
<jkeiper> dkayiwa, it seems some do not appear in the list
|
16:49:28
|
<jkeiper> dkayiwa, and I do not see errors in the log
|
16:50:10
|
<dkayiwa> jkeiper, in the form designer, got to the design surface tab and ensure that you can see some widgets. then save. that should be all
|
16:52:14
|
<jkeiper> dkayiwa, ok, will try
|
16:55:58
|
<jkeiper> dkayiwa, after doing that it came back, but there is no actual design ... not sure if that is because the form was not designed yet prior to this error, but wondering if there is some way to look at archives to pull up the design and put it back. is that stored in the xforms_xform table?
|
16:56:32
|
<dkayiwa> jkeiper, yes
|
16:56:40
|
<jkeiper> dkayiwa, which column?
|
16:56:51
|
<dkayiwa> layout_xml
|
16:57:12
|
<mseaton> jkeiper: i do believe the to use the report request stuff you need to have a saved report definition in the db. we've had various discussions about how/whether to support this for years now, but don't have a great answer yet. i think the answer might be to add in a InMemoryDataSetDefinition / InMemoryDataSetEvaluator / InMemoryDataSetPersister. djazayeri might have more to add to this. would be more than happy to take this to th
|
16:57:12
|
<jkeiper> dkayiwa, thanks ... i'll see what we can do. :-D
|
16:58:08
|
<jkeiper> mseaton, cool ... if not, i'll just be replicating your queueing process in my module so i can build the reports, run them, persist the results and deliver the formatted final product on my own
|
16:58:12
|
<djazayeri> jkeiper, mseaton: I have done an in-memory DataSetPersister for Kenya EMR.
|
16:58:17
|
<jkeiper> mseaton, at least i have a solution ... but would love to use yours.
|
16:58:19
|
*** k-joseph has joined #openmrs
|
16:58:19
|
<djazayeri> I didn't use it to do report-requests though
|
16:58:52
|
<jkeiper> djazayeri, i think i remember seeing something in the KenyaEMR module checking for report definition uuids and replacing them?
|
16:59:08
|
<mseaton> djazayeri: did you also use in memory report definitions too ?
|
16:59:19
|
<djazayeri> jkeiper: here's the persister: https://github.com/I-TECH/openmrs-module-kenyaemr/blob/master/api/src/main/java/org/openmrs/module/kenyaemr/report/KenyaEmrDataSetDefinitionPersister.java
|
16:59:20
|
<jkeiper> djazayeri, mseaton i think i'll grok the Kenya EMR way of doing it before I try writing my own queue
|
16:59:23
|
<OpenMRSBot> <http://ln-s.net/+jK5> (at github.com)
|
16:59:32
|
<jkeiper> djazayeri, thanks :-)
|
16:59:40
|
<djazayeri> mseaton: we didn't do an in-memory report persister, but I assume that would work
|
17:00:10
|
<mseaton> djazayeri: ok, cool. jkeiper maybe you can roll the kenyaemr solution into the core module :)
|
17:00:47
|
<jkeiper> mseaton, I'll wrap my head around it and see what it would require ...
|
17:02:42
|
*** GitHub43 has joined #openmrs
|
17:02:42
|
<GitHub43> [openmrs-core] wluyima pushed 1 new commit to master: http://git.io/HJ1dlA
|
17:02:42
|
<GitHub43> openmrs-core/master 87903c9 draggonz: Bad error message is displayed when reference term validation fails -...
|
17:02:42
|
*** GitHub43 has left #openmrs
|
17:04:06
|
*** evmw has joined #openmrs
|
17:04:24
|
*** GitHub74 has joined #openmrs
|
17:04:24
|
<GitHub74> [openmrs-core] wluyima pushed 1 new commit to 1.9.x: http://git.io/w3NrbA
|
17:04:24
|
<GitHub74> openmrs-core/1.9.x 8616f05 draggonz: Bad error message is displayed when reference term validation fails -...
|
17:04:24
|
*** GitHub74 has left #openmrs
|
17:04:51
|
<harsz89> dkayiwa, hi i have look more bit on viewing links under module when loged in as admin
|
17:05:09
|
<harsz89> dkayiwa, when i log as admin to the administration page link will be
|
17:05:26
|
*** jaykrish has joined #openmrs
|
17:05:59
|
<harsz89> dkayiwa, http://localhost:8080/openmrs/admin/index.htm
|
17:06:24
|
*** dmulindwa has joined #openmrs
|
17:06:38
|
<harsz89> dkayiwa, and when access some link it will be- http://localhost:8080/openmrs/admin/module/webservices/rest/settings.form
|
17:07:06
|
<harsz89> dkayiwa, but when i remove the admin/ part page successfully appered
|
17:07:28
|
<dkayiwa> harsz89, ok
|
17:08:05
|
<harsz89> dkayiwa, i think this because web pages for a module deploy not in admin directory in WEB-INF
|
17:08:36
|
*** rfriedman has joined #openmrs
|
17:08:39
|
<harsz89> dkayiwa, :)
|
17:09:06
|
<rfriedman> djazayeri, got a minute?
|
17:09:25
|
<djazayeri> rfriedman: I'm on calls for the next 4 hours.
|
17:09:41
|
<djazayeri> rfriedman: I have a small number of background brain cycles
|
17:09:44
|
*** jaykrish has quit IRC
|
17:09:55
|
<rfriedman> djazayeri, guess not :) -- just have a look at the full rep of ConceptResource when you get a chance
|
17:15:37
|
*** travis-ci has joined #openmrs
|
17:15:37
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [87903c9] [draggonz] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/5108946
|
17:15:37
|
*** travis-ci has left #openmrs
|
17:15:43
|
<OpenMRSBot> <http://ln-s.net/+jKG> (at travis-ci.org)
|
17:16:48
|
<rfriedman> oh boy, a dialog between travis and the bot, pretty soon there'll be no need for humans at all
|
17:18:19
|
<downey> rfriedman: I for one welcome our new bot overlords
|
17:18:43
|
<rfriedman> downey, quisling
|
17:21:12
|
*** andrea_ has joined #openmrs
|
17:25:43
|
*** andrea__ has joined #openmrs
|
17:28:40
|
*** andrea_ has quit IRC
|
17:29:47
|
<andrea__> cpower, you here?
|
17:29:54
|
<k-joseph> dkayiwa: hi
|
17:30:19
|
<dkayiwa> k-joseph, hi
|
17:31:03
|
*** andrea__ has quit IRC
|
17:36:15
|
<k-joseph> dkayiwa: am while trying to return the uuid from a concept, am creating an instance for concept class and the calling getuuid() on the newly created instance for concept, this is what am having in mind over this issue, and it is not working out, the compiler is complaining; type mismatch: cannot convert from String to Concept, i have tried addressing this and am taking a lot of time on it yet not able to solve it, i kindly request for your assistance here
|
17:36:15
|
<k-joseph> please
|
17:37:11
|
<dkayiwa> k-joseph, can you pastebin what you have
|
17:38:29
|
<k-joseph> dkayiwa: http://pastebin.com/CJpwvDCi
|
17:39:18
|
<rfriedman> k-joseph, you need to have the concept you want to get the uuid of, this is not a class method
|
17:40:25
|
<rfriedman> k-joseph, the new concept will have a new uuid but it is missing required fields and can't be saved
|
17:40:48
|
<dkayiwa> k-joseph, do you remember what i shared with you as per what deserialize does?
|
17:41:41
|
*** dmulindwa has quit IRC
|
17:42:06
|
*** dmulindwa has joined #openmrs
|
17:42:59
|
<k-joseph> dkayiwa: i do remember, rfriedman: thanks,
|
17:43:14
|
<dkayiwa> k-joseph, what did we say?
|
17:43:49
|
*** harshadura has quit IRC
|
17:44:30
|
*** harshadura_ has quit IRC
|
17:45:38
|
<k-joseph> dkayiwa: the value i return during serialisaton is stored by the framework and is later returned back
|
17:46:15
|
<dkayiwa> k-joseph, returned back in what method call?
|
17:46:16
|
*** dmulindwa has quit IRC
|
17:46:47
|
<k-joseph> dkayiwa: then i can return the object for the value returned
|
17:48:16
|
<k-joseph> dkayiwa: returned back during deserialization, am not sure what method call, i thought it through the same as used during serialization
|
17:48:47
|
*** lh has joined #openmrs
|
17:48:47
|
*** lh has joined #openmrs
|
17:49:27
|
*** denuwanthi has joined #openmrs
|
17:50:13
|
<dkayiwa> k-joseph, the value which was stored is given to you as a parameter in te deserialize method
|
17:50:32
|
<dkayiwa> k-joseph, does this make sense?
|
17:53:20
|
*** djazayeri1 has joined #openmrs
|
17:53:23
|
<k-joseph> dkayiwa: a parameter under which method, forexaple, in this case?
|
17:54:04
|
<dkayiwa> k-joseph, the value which was stored is given to you as a parameter in te deserialize method
|
17:56:37
|
*** djazayeri has quit IRC
|
17:56:43
|
<k-joseph> dkayiwa: am getting what you mean in this concept forexample by concidering Boolean datatype, focusing on line return Boolean.valueOf(serializedValue);
|
17:57:23
|
<dkayiwa> do you see the deserialize method?
|
17:57:46
|
<k-joseph> dkayiwa: yes, i see it
|
17:58:02
|
<dkayiwa> k-joseph, do you see it parameter?
|
17:58:07
|
<dkayiwa> its
|
17:58:25
|
<k-joseph> dkayiwa: serializedValue
|
17:58:52
|
<dkayiwa> k-joseph, thats the value which was stored in the serialize method
|
17:59:06
|
<dkayiwa> k-joseph, does this make sense?
|
18:01:10
|
<k-joseph> dkayiwa: ok, it does, and how is this returned,
|
18:02:14
|
<dkayiwa> k-joseph, it is given to you as a parameter in the deserialize method such that you can use it to load the original object whose property value you stored
|
18:08:21
|
*** dmulindwa has joined #openmrs
|
18:08:28
|
<dkayiwa> k-joseph, does this make things any clearer
|
18:09:39
|
<k-joseph> dkayiwa: and then how is original object whose property value is stored using, typedValue.getUuid() to be loaded [ and what is this being loaded ] using this returned parameter, serializedVaule?
|
18:10:52
|
<dkayiwa> k-joseph, first of all what is the original object?
|
18:11:50
|
<k-joseph> dkayiwa: am taking it to be typed Value
|
18:12:08
|
<dkayiwa> k-joseph, as in it is of what class?
|
18:12:26
|
<k-joseph> dkayiwa: Concept
|
18:12:51
|
<dkayiwa> k-joseph, and what property of it was stored in serialize?
|
18:13:46
|
<k-joseph> dkayiwa: its uuid,
|
18:14:26
|
<dkayiwa> k-joseph, so deserialize gives you that uuid for you to load the original concept
|
18:14:32
|
<dkayiwa> k-joseph, does this make sense?
|
18:16:04
|
<k-joseph> dkayiwa: it makes sense,
|
18:17:07
|
<k-joseph> dkayiwa: dont i need to fetch this uuid under deserialize() in myy code?
|
18:18:29
|
<dkayiwa> dkayiwa> k-joseph, the value which was stored is given to you as a parameter in te deserialize method
|
18:18:53
|
<dkayiwa> k-joseph, did you understand that statement?
|
18:21:26
|
*** denuwanthi has quit IRC
|
18:23:05
|
<k-joseph> dkayiwa: i get it, then after the value is returned back to me, what then is my effort to do, in my code what is that am supposed to return to the deserialise method, having known that
|
18:24:38
|
<dkayiwa> k-joseph, all you need to do in the deserialize method is load and return the original concept using the given uuid
|
18:28:52
|
*** rkorytkowski has joined #openmrs
|
18:28:52
|
*** ChanServ sets mode: +v rkorytkowski
|
18:28:52
|
*** rkorytkowski is now known as rafa
|
18:29:39
|
*** downey sets mode: +o djazayeri1
|
18:29:39
|
*** ChanServ sets mode: -o djazayeri1
|
18:32:07
|
*** djazayeri1 is now known as djazayeri
|
18:34:56
|
<rfriedman> hey rafa
|
18:35:01
|
<rafa> rfriedman: hi
|
18:35:09
|
<dmulindwa> dkayiwa: can you look at my paste please? here http://pastebin.com/TZkCr9it
|
18:35:26
|
<rfriedman> rafa, take a look at the code for the full rep of concept resource
|
18:35:49
|
<rafa> rfriedman: open
|
18:36:02
|
<rafa> rfriedman: looking
|
18:36:47
|
<rafa> rfriedman: what's up?
|
18:36:58
|
<rfriedman> delegate.isNumeric?
|
18:37:15
|
<rfriedman> rafa, it's trying to test whether this is a conceptnumeric
|
18:37:23
|
<rafa> rfriedman: yes
|
18:37:52
|
<rafa> rfriedman: it should be probably implemented as a subclass handler
|
18:38:11
|
<rafa> rfriedman: but I guess it was before subclass handlers
|
18:38:38
|
<rfriedman> yes, but be that as it may, isNumeric on the resource? where's the isNumeric method coming from?
|
18:39:08
|
<rafa> rfriedman: from Concept.java
|
18:39:24
|
<rfriedman> rafa, oh, but the delegate is concept.java, not conceptresource.java
|
18:39:28
|
<rafa> rfriedman: yes
|
18:43:19
|
<rfriedman> rafa, when i look at concept, isNumeric always returns true, but ConceptNumeric returns true or false based on datatype
|
18:43:34
|
<rfriedman> rafa, shouldn't that be using isAssignableFrom or some such test?
|
18:43:48
|
<rafa> isNumeric on Concept always returns false
|
18:43:55
|
<rfriedman> rafa, or just return true
|
18:44:07
|
<rfriedman> rafa, yes, it's overridden in ConceptNumeric
|
18:44:32
|
*** applecool has quit IRC
|
18:44:33
|
<rafa> rfriedman: you can ask Hibernate to return you a Concept even though it's ConceptNumeric
|
18:44:47
|
*** Hasintha_i has quit IRC
|
18:44:49
|
<rafa> rfriedman: you might still want to know that it's a ConceptNumeric
|
18:44:57
|
<rafa> rfriedman: that's why it looks at the datatype
|
18:45:06
|
<rfriedman> public boolean isNumeric() {
|
18:45:07
|
<rfriedman> return (getDatatype().getName().equals("Numeric"));
|
18:45:07
|
<rfriedman> }
|
18:45:31
|
<djazayeri> rfriedman, rafa: I believe that back long long ago we may have done something incorrect in the way we handled Concept/ConceptNumeric in hibernate
|
18:45:31
|
<rafa> rfriedman: that's correct
|
18:45:48
|
<djazayeri> and that's why we have the getConceptNumeric(Concept) service method
|
18:46:40
|
<rafa> djazayeri: I've never looked at that
|
18:47:08
|
<rfriedman> djazayeri, such a joy looking at old code :)
|
18:48:13
|
<k-joseph> dkayiwa: i have looked at a method that returns Concept type but takes a String as its parameter in Concept and its superclasses that i can use for this purpose and am not seeing one, or am to approach this in a different way!!
|
18:48:25
|
<rfriedman> rafa, djazayeri, well, at least delegate.isNumeric() isn't as crazy as it first seemed to me
|
18:49:02
|
<dkayiwa> k-joseph, the concept service is the one responsible for that. did you look at it?
|
18:49:47
|
<k-joseph> dkayiwa: am looking at that now
|
18:50:45
|
<rafa> djazayeri: we don't seem to have getConceptNumeric(Concept) any longer
|
18:50:46
|
*** lh has quit IRC
|
18:50:52
|
<djazayeri> well, that's good
|
19:00:53
|
*** cpower has quit IRC
|
19:07:58
|
*** cpower has joined #openmrs
|
19:08:17
|
*** djadmin has quit IRC
|
19:09:51
|
<k-joseph> dkayiwa: while dealing with methods in java classes, if i wanted to make a reference to any method i make sure that it is either static or i create an instance of the class where the method is located and call the non static method on that instance, how about for interfaces,
|
19:11:16
|
<dkayiwa> k-joseph, the concept service should already be having a method which loads a concept given its uuid
|
19:15:01
|
<k-joseph> dkayiwa: otherwise am trying using public Concept getConceptByUuid(String uuid);
|
19:15:15
|
<dkayiwa> k-joseph, yes
|
19:15:38
|
<k-joseph> dkayiwa: that is why am asking
|
19:15:51
|
<k-joseph> while dealing with methods in java classes, if i wanted to make a reference to any method i make sure that it is either static or i create an instance of the class where the method is located and call the non static method on that instance, how about for interfaces,
|
19:16:52
|
<harsz89> hi rafa!
|
19:16:59
|
<rafa> harsz89: hi
|
19:17:13
|
<harsz89> rafa, i build the openmrs and rest services module in latest git master
|
19:18:01
|
<harsz89> rafa, i able to send request to resources through soapui successfully and got the responses
|
19:18:08
|
*** r0bby has quit IRC
|
19:18:42
|
<harsz89> rafa, but when i tried to send a request to /ws/rest/v1/catalog resource
|
19:19:15
|
<harsz89> rafa, i got a error java.lang.NoSuchMethodError: org.openmrs.api.OrderService.getOrderType(Ljava/lang/Integer;)Lorg/openmrs/OrderType
|
19:19:20
|
<k-joseph> dkayiwa: is my question meaningful
|
19:19:22
|
<rafa> harsz89: you built openmrs from master?
|
19:19:22
|
<k-joseph> ?
|
19:19:31
|
<rafa> harsz89: meaning you're running 1.10
|
19:19:33
|
<harsz89> rafa, yes
|
19:19:38
|
<harsz89> rafa, yep
|
19:19:44
|
<rafa> harsz89: https://tickets.openmrs.org/browse/RESTWS-283
|
19:20:01
|
<rafa> harsz89: there's a bug in the module when running 1.10
|
19:20:15
|
<rafa> harsz89: it works fine on 1.9.x
|
19:20:28
|
<harsz89> rafa, oh sorry i didn't saw that
|
19:20:41
|
<rafa> harsz89: no worries
|
19:20:47
|
<harsz89> rafa, i'll download 1.9.x and test it
|
19:20:57
|
<rafa> harsz89: all you have to do is:
|
19:21:00
|
<rafa> git fetch --alll
|
19:21:03
|
<rafa> sorry
|
19:21:08
|
<rafa> git fetch --all
|
19:21:11
|
<rafa> git checkout 1.9.x
|
19:21:20
|
<rafa> and then build openmrs again
|
19:21:26
|
<harsz89> rafa, ah got it
|
19:21:35
|
<harsz89> rafa, thank you
|
19:21:39
|
<rafa> harsz89: np
|
19:24:14
|
*** suranga has quit IRC
|
19:25:10
|
<dkayiwa> hi k-joseph
|
19:25:20
|
<k-joseph> dkayiwa: hi
|
19:25:38
|
<dkayiwa> k-joseph, are you asking how to use that service method?
|
19:26:25
|
<k-joseph> dkayiwa: yes, so that the compiler becomes quite and not keep on complaining
|
19:26:49
|
<dkayiwa> k-joseph, have you tried to do an eclispe search for files using that method?
|
19:27:19
|
<dkayiwa> k-joseph, that way you can see how a method is used/called
|
19:27:23
|
<dkayiwa> k-joseph, does this make sense?
|
19:27:34
|
<k-joseph> dkayiwa: how can i do that in eclipse?
|
19:28:07
|
<dkayiwa> k-joseph, from the Search menu
|
19:28:39
|
<dkayiwa> k-joseph, Search -> File
|
19:30:26
|
*** andreapat has joined #openmrs
|
19:37:54
|
*** k-joseph has quit IRC
|
19:38:25
|
*** dmulindwa has quit IRC
|
19:51:20
|
*** harsz89 has quit IRC
|
19:51:44
|
*** k-joseph has joined #openmrs
|
19:56:01
|
*** cpower has quit IRC
|
20:02:52
|
*** cpower has joined #openmrs
|
20:05:07
|
<k-joseph> dkayiwa: http://pastebin.com/mw934jpr
|
20:06:44
|
<dkayiwa> k-joseph, you call the ConceptService concept?
|
20:07:28
|
<jkeiper> djazayeri, off-line from the design call, respond whenever you can ... does Kenya EMR require 1.9 data model or do you think it's at all portable to 1.8.x?
|
20:07:58
|
*** GitHub140 has joined #openmrs
|
20:07:58
|
<GitHub140> [openmrs-core] akolodziejski opened pull request #226: TRUNK-3203 Add JUnit test for getting by patients for method HibernatePa... (master...TRUNK-3203) http://git.io/lL6aYg
|
20:07:58
|
*** GitHub140 has left #openmrs
|
20:10:19
|
*** dmulindwa has joined #openmrs
|
20:25:41
|
<k-joseph> dkayiwa: hi
|
20:26:19
|
<dkayiwa> k-joseph, hi
|
20:27:14
|
<k-joseph> dkayiwa: i get your question on the naming, changiing that to some thing better like, fetchConcept
|
20:27:52
|
<dkayiwa> k-joseph, is the service used only for fetching?
|
20:28:55
|
<k-joseph> dkayiwa: it is to get the concept by its uuid, as the name suggests
|
20:29:42
|
<dkayiwa> k-joseph, can you search in openmrs for examples of how they do the variable naming for a service?
|
20:41:13
|
*** k-joseph has quit IRC
|
20:42:55
|
*** k-joseph has joined #openmrs
|
20:47:29
|
*** GitHub90 has joined #openmrs
|
20:47:29
|
<GitHub90> [openmrs-core] wluyima pushed 1 new commit to master: http://git.io/n0DCjw
|
20:47:30
|
<GitHub90> openmrs-core/master 8f87954 wluyima: Revert "Retired concepts aren't showed as retired when listed as set members - TRUNK-3840"...
|
20:47:30
|
*** GitHub90 has left #openmrs
|
20:49:44
|
*** kishoreyekkanti has quit IRC
|
20:50:48
|
*** GitHub185 has joined #openmrs
|
20:50:48
|
<GitHub185> [openmrs-core] wluyima pushed 1 new commit to 1.9.x: http://git.io/FLgCsQ
|
20:50:48
|
<GitHub185> openmrs-core/1.9.x ac3cc3c wluyima: Revert "Retired concepts aren't showed as retired when listed as set members -"...
|
20:50:48
|
*** GitHub185 has left #openmrs
|
20:52:08
|
*** evmw has quit IRC
|
20:52:34
|
*** k_joseph has joined #openmrs
|
20:53:25
|
*** k-joseph has quit IRC
|
20:53:46
|
*** GitHub115 has joined #openmrs
|
20:53:46
|
<GitHub115> [openmrs-core] wluyima pushed 1 new commit to 1.8.x: http://git.io/nrgfCA
|
20:53:46
|
<GitHub115> openmrs-core/1.8.x b504d92 wluyima: Revert "Retired concepts aren't showed as retired when listed as set members -"...
|
20:53:46
|
*** GitHub115 has left #openmrs
|
20:58:45
|
*** travis-ci has joined #openmrs
|
20:58:45
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [8f87954] [wluyima] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/5114768
|
20:58:45
|
*** travis-ci has left #openmrs
|
20:58:49
|
<OpenMRSBot> <http://ln-s.net/+jOJ> (at travis-ci.org)
|
21:02:09
|
*** k_joseph has quit IRC
|
21:02:30
|
<andreapat> rafa, are you here?
|
21:03:04
|
<rafa> andreapat: yes
|
21:03:32
|
<andreapat> rafa, just sent you mail
|
21:03:49
|
<rafa> andreapat: just answered you
|
21:03:51
|
<rafa> andreapat: ;)
|
21:04:16
|
<andreapat> rafa, wow you're quick
|
21:04:41
|
<rafa> andreapat: ohh I answered you 8 minutes ago ;)
|
21:08:03
|
<andreapat> rafa, ok - see it - should have put a note on ticket that I finished
|
21:08:31
|
<rafa> andreapat: yeah, it would have helped
|
21:08:56
|
<andreapat> rafa, sorry - will always do so next time
|
21:09:04
|
<rafa> andreapat: no problem
|
21:09:30
|
<andreapat> rafa, ok cya later
|
21:09:42
|
<rafa> andreapat: probably tomorrow ;)
|
21:09:45
|
<rafa> andreapat: cya
|
21:21:37
|
<djazayeri> rafa: hey, if you're still there, is there a university screencast that shows submitting github pull requests?
|
21:22:07
|
<rafa> djazayeri: I don't think so
|
21:22:40
|
<djazayeri> rafa: that's too bad. Do you think you could create one as a side-effect of next week's University call?
|
21:22:58
|
<rafa> djazayeri: yes, I think I can fit it in.
|
21:23:06
|
<djazayeri> rafa: great, thanks!
|
21:24:54
|
*** rfriedman has quit IRC
|
21:26:53
|
*** dmulindwa has quit IRC
|
21:27:47
|
*** rafa has quit IRC
|
22:09:05
|
*** jkeiper has quit IRC
|
22:27:48
|
*** wyclif has quit IRC
|
22:40:16
|
*** johnsu01 has joined #openmrs
|
22:43:21
|
*** GitHub3 has joined #openmrs
|
22:43:21
|
<GitHub3> [openmrs-core] mseaton opened pull request #227: TRUNK-3351: Merging persons incorrectly handles addresses and names (master...master) http://git.io/xms80Q
|
22:43:21
|
*** GitHub3 has left #openmrs
|
22:44:29
|
*** GitHub44 has joined #openmrs
|
22:44:29
|
<GitHub44> [openmrs-core] mseaton pushed 3 new commits to master: http://git.io/lOqcmw
|
22:44:29
|
<GitHub44> openmrs-core/master cb78ceb Tom Ryan: TRUNK-3551 Merging Person and Address. Cherry-picking Tom Ryan's commit and fixing some failing unit tests
|
22:44:29
|
<GitHub44> openmrs-core/master a726e94 Michael Seaton: TRUNK-3551 Merging Person and Address. Remove references to commons lang3 from import
|
22:44:29
|
<GitHub44> openmrs-core/master ec07f0f Michael Seaton: Merge pull request #227 from mseaton/master...
|
22:44:29
|
*** GitHub44 has left #openmrs
|
22:50:06
|
<downey> Hi johnsu01 - will reply to your e-mail shortly
|
22:55:07
|
<johnsu01> downey: awesome, thanks :)
|
22:55:26
|
*** travis-ci has joined #openmrs
|
22:55:26
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [ec07f0f] [Michael Seaton] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/5118172
|
22:55:26
|
*** travis-ci has left #openmrs
|
22:55:30
|
<OpenMRSBot> <http://ln-s.net/+jSc> (at travis-ci.org)
|
23:01:50
|
*** dkayiwa has quit IRC
|
23:24:57
|
*** wyclif has joined #openmrs
|