IRC Chat : 2013-02-26 - OpenMRS

01:11:40 *** djadmin has joined #openmrs
01:34:03 *** djadmin has quit IRC
01:37:11 *** harshadura has joined #openmrs
01:47:09 *** sunbiz has quit IRC
02:00:31 *** jb360 has quit IRC
02:02:23 *** jb360 has joined #openmrs
02:05:48 *** Anuruddha has joined #openmrs
02:21:54 *** jkeiper has joined #openmrs
02:21:54 *** ChanServ sets mode: +v jkeiper
02:26:16 *** robbyoconnor has joined #openmrs
02:26:16 *** ChanServ sets mode: +v robbyoconnor
02:30:33 *** robbyoconnor has quit IRC
02:44:52 *** DraggonZ has joined #openmrs
02:47:55 *** DraggonZ has quit IRC
02:48:57 *** DraggonZ has joined #openmrs
02:50:47 <harshadura> hi jb360
02:50:55 *** Echidna has quit IRC
02:52:21 *** Echidna has joined #openmrs
02:52:21 *** ChanServ sets mode: +v Echidna
02:53:09 <harshadura> jb360, i hv a lil query regarding rest ws ticket, u thr?
03:04:50 *** harshadura has quit IRC
03:05:14 *** Anuruddha has quit IRC
03:17:33 *** harshadura has joined #openmrs
03:49:29 *** Anuruddha has joined #openmrs
03:53:26 *** Echidna has quit IRC
03:53:41 *** Echidna has joined #openmrs
03:53:41 *** ChanServ sets mode: +v Echidna
04:19:18 *** Echidna has quit IRC
04:19:29 *** Echidna has joined #openmrs
04:19:29 *** ChanServ sets mode: +v Echidna
04:31:10 *** robbyoconnor has joined #openmrs
04:31:10 *** ChanServ sets mode: +v robbyoconnor
04:34:32 *** Anuruddha has quit IRC
04:51:19 *** Echidna has quit IRC
04:51:22 *** Echidna has joined #openmrs
04:51:22 *** ChanServ sets mode: +v Echidna
04:58:13 *** Anuruddha has joined #openmrs
05:07:15 *** Anuruddha_ has joined #openmrs
05:09:40 *** Anuruddha has quit IRC
05:17:35 *** Echidna has quit IRC
05:17:50 *** Echidna has joined #openmrs
05:17:50 *** ChanServ sets mode: +v Echidna
06:04:03 *** Echidna has quit IRC
06:04:14 *** Echidna has joined #openmrs
06:04:14 *** ChanServ sets mode: +v Echidna
06:06:08 *** Anuruddha has joined #openmrs
06:06:24 *** Anuruddha_ has quit IRC
06:33:04 *** shortend has joined #openmrs
06:42:06 *** ibewes has joined #openmrs
06:42:46 *** GitHub51 has joined #openmrs
06:42:46 <GitHub51> [openmrs-core] rowanseymour opened pull request #223: TRUNK-3768: drugOrder.drug should not be a mandatory field for drug order (1.9.x...1.9.x) http://git.io/W2Ukfw
06:42:46 *** GitHub51 has left #openmrs
06:46:39 <ibewes> that's an odd issue. Seems like a drug order *should* require a drug... ?
06:48:40 *** shortend has quit IRC
06:49:38 *** shortend has joined #openmrs
06:55:45 *** DraggonZ has left #openmrs
06:59:26 *** Echidna has quit IRC
06:59:38 *** Echidna has joined #openmrs
06:59:38 *** ChanServ sets mode: +v Echidna
07:09:11 *** ibewes has quit IRC
07:09:39 *** ibewes has joined #openmrs
07:20:54 *** k-joseph has joined #openmrs
07:23:41 *** djazayeri has quit IRC
07:58:10 *** dkayiwa has joined #openmrs
08:03:14 *** Echidna has quit IRC
08:03:25 *** Echidna has joined #openmrs
08:03:25 *** ChanServ sets mode: +v Echidna
08:10:51 *** ibewes has quit IRC
08:11:19 *** ibewes has joined #openmrs
08:12:09 *** djadmin has joined #openmrs
08:20:56 *** djadmin has quit IRC
08:23:01 *** GitHub131 has joined #openmrs
08:23:01 <GitHub131> [openmrs-core] dcmul opened pull request #224: Max version value (master...TRUNK-3654) http://git.io/oVPCOQ
08:23:01 *** GitHub131 has left #openmrs
08:25:50 *** evmw has joined #openmrs
08:28:15 *** djadmin has joined #openmrs
08:29:13 *** evmw has quit IRC
08:29:23 *** evmw has joined #openmrs
08:32:59 *** djadmin has quit IRC
08:37:13 *** evmw has quit IRC
08:37:15 *** evmw_ has joined #openmrs
08:49:49 *** Anuruddha_ has joined #openmrs
08:52:27 *** Anuruddha has quit IRC
09:00:53 *** Anuruddha_ has quit IRC
09:11:54 *** evmw has joined #openmrs
09:11:57 *** evmw_ has quit IRC
09:11:58 *** k-joseph has quit IRC
09:29:55 *** harshadura has quit IRC
09:57:09 *** ibewes has quit IRC
10:18:01 *** k-joseph has joined #openmrs
10:21:17 *** Anuruddha_ has joined #openmrs
10:28:22 *** k-joseph has quit IRC
10:32:33 *** evmw has quit IRC
10:35:05 *** evmw has joined #openmrs
10:42:59 *** rkorytkowski has joined #openmrs
10:42:59 *** rkorytkowski is now known as rafa
10:42:59 *** ChanServ sets mode: +v rafa
10:48:02 *** dkayiwa has quit IRC
10:52:47 *** ibewes has joined #openmrs
10:53:31 *** dkayiwa has joined #openmrs
11:04:01 *** dkayiwa has joined #openmrs
11:09:23 *** Anuruddha has joined #openmrs
11:12:38 *** Anuruddha_ has quit IRC
11:14:22 *** djadmin has joined #openmrs
11:31:18 *** harsha has joined #openmrs
11:38:19 *** dkayiwa has quit IRC
11:44:04 *** dkayiwa has joined #openmrs
11:51:38 *** harsha_ has joined #openmrs
11:52:38 *** harsha has quit IRC
11:54:54 *** harsha_ has quit IRC
11:56:08 *** harsz89 has joined #openmrs
11:56:34 *** robbyoconnor has quit IRC
12:06:00 *** DraggonZ has joined #openmrs
12:14:32 <jb360> rafa you there?
12:14:38 <rafa> jb360: hi, yes
12:14:59 <jb360> hi. i was looking at working another ticket for the sprint
12:15:23 <jb360> restws-307?
12:15:36 <rafa> jb360: yes, it seems to be a quick one
12:15:53 <jb360> i'm green to openmrs and thought you might be able to point me in the right direction
12:16:10 <jb360> where does this "concatenation" take place?
12:16:25 <jb360> stupid question?
12:16:30 <rafa> jb360: not at all
12:16:46 <rafa> jb360: I think that it's in MetadataDelegatingCrudResource or something like that
12:16:49 <rafa> jb360: let me check
12:17:07 <jb360> i just don't have my head around the api yet. i don't know where the bodies are buried.
12:17:21 <rafa> jb360: yes, it implements getDisplayString, which is used by most of metadata
12:17:33 <rafa> jb360: it can be overriden in some
12:17:53 <jb360> in the openmrs-api module?
12:18:09 <rafa> jb360: not it's in the RESTWS module
12:18:32 <jb360> looking...
12:19:02 <rafa> jb360: so in openmrs we have model objects, which either implement OpenmrsMetadata or OpenmrsData
12:19:33 *** Echidna has quit IRC
12:19:45 <rafa> jb360: this ticket is about changing display string for rest resources that serve object implementing OpenmrsMetadata
12:19:51 *** Echidna has joined #openmrs
12:19:51 *** ChanServ sets mode: +v Echidna
12:20:13 <rafa> jb360: e.g. LocationResource
12:20:29 *** taygun has joined #openmrs
12:20:33 <rafa> jb360: it serves Location which implements OpenmrsMetadata
12:20:46 <jb360> okay
12:20:57 <rafa> jb360: if you look at LocationResourceTest
12:21:14 <jb360> will do
12:21:26 <rafa> jb360: you'll see that expected display property is "Never Never Land - This is never be found"
12:21:29 *** taygun has quit IRC
12:21:42 <jb360> one more time: when does the sprint wrap up?
12:21:50 <rafa> jb360: which is location.getName() + " - " + location.getDescription()
12:21:59 <rafa> jb360: we want it to be location.getName()
12:22:06 <jb360> understood.
12:22:22 <jb360> all of the tests will need to change as well?
12:22:35 <rafa> jb360: yes, those for metadata
12:23:23 <rafa> jb360: I'll include in the release only tickets committed today
12:23:54 <rafa> jb360: it's because I need to reserve a day to do testing and release
12:24:09 <rafa> jb360: but it doesn't mean you cannot complete your ticket after that
12:24:28 <rafa> jb360: it's just that it may be included in some later release
12:26:12 <jb360> okay
12:26:38 <jb360> this is in the 1.9 api
12:27:17 <jb360> no sorry common
12:29:20 *** evmw has quit IRC
12:29:59 *** evmw has joined #openmrs
12:30:56 <jb360> rafa: thank you
12:32:04 <jb360> i found it and claimed the ticket. I'll get things set up via git and try to knock it out today.
12:32:12 *** yony258 has joined #openmrs
12:32:48 *** evmw_ has joined #openmrs
12:32:53 <yony258> Hi guys, just wanted to ask if there is a wiki page containing OpenMRS standards (of development or any standards)
12:34:42 <rafa> yony258: there are many :)
12:34:57 <rafa> yony258: see https://wiki.openmrs.org/display/docs/Conventions
12:35:11 <rafa> yony258: and child pages too
12:35:33 *** evmw has quit IRC
12:35:33 *** evmw_ is now known as evmw
12:36:12 <jb360> rafa: time for another question?
12:36:20 <yony258> rafa: Thank you rafa, was looking for something more related to the workflow in OpenMRS
12:36:53 <jb360> yony258: you want dev pages?
12:37:04 <jb360> openmrs architecture?
12:42:11 *** djadmin has quit IRC
12:46:21 <yony258> jb360: Any info on OpenMRS standards of design would really help
12:46:25 <yony258> jb360: Thanks
12:49:58 <rafa> yony258: You're still not very precise. Maybe https://wiki.openmrs.org/display/docs/Technical+Overview
12:49:59 <OpenMRSBot> <http://ln-s.net/8jTj> (at wiki.openmrs.org)
12:50:59 *** harshadura has joined #openmrs
12:51:18 <rafa> yony258: I could say that anything in Developer Guide pretty much standards of desing :)
12:51:25 <ibewes> yony258: it seems like you are asking to two different things. Are you looking for coding standards or the high-level architecture?
12:51:27 <jb360> yony258: There are videos on youtube about openmrs
12:52:24 <jb360> rafa: does "git fetch --all" refresh my entire local repo with everything from upstream?
12:52:34 <jb360> upstream is configured properly.
12:52:48 <rafa> jb360: it only fetches everything from remote repos
12:53:02 <rafa> jb360: it doesn't update your repo
12:53:03 <jb360> including origin?
12:53:08 <rafa> jb360: yes
12:53:24 <jb360> what do you mean "it doesn't update your repo"?
12:53:39 <jb360> it pulls everything to my local repo right?
12:53:47 <rafa> jb360: I mean that you download all changes from remote repos, but they are not applied to your local repo
12:53:50 <jb360> all new changes that you have merged
12:54:17 <rafa> jb360: see http://stackoverflow.com/questions/292357/whats-the-difference-between-git-pull-and-git-fetch
12:54:21 <OpenMRSBot> <http://ln-s.net/+imG> (at stackoverflow.com)
12:54:45 <yony258> jb360: To be honest I am more than familiar with most of the standards and workflows of OpenMRS, I was asked to explain what are the standards of developing a module within OpenMRS community and I was looking for some official docs
12:55:00 <jb360> ahhh
12:55:20 <jb360> rafa: ty
12:55:40 <ibewes> yony258: but what do you mean by 'standards'?
12:56:29 <yony258> ibewes: Hmm, for example which design methods are being used in OpenMRS
12:56:38 <jb360> rafa: i have the local repo that I used to work on other tickets. now I want to pull in the latest changes which you have merged before I work on the next ticket.
12:56:52 <jb360> so I should execute a pull then?
12:57:06 <ibewes> yony258: does design methods = design patterns (as in Gamma et al)
12:57:09 <rafa> jb360: yes, just do git pull --rebase upstream sprint-201302
12:57:22 <jb360> rafa: ty sir
12:58:03 <jb360> rafa: does it matter which "branch" i have current locally (e.g. git checkout RESTWS-307)?
12:58:27 <rafa> jb360: yes, it will update the currently checked out branch
12:58:30 <jb360> rafa: before I perform the "git pull [...]"
12:58:35 <jb360> okay
12:58:59 <yony258> ibewes: Yes, sort of
13:01:06 <ibewes> yony258: there isn't much module-specific guidance (that I know of), but perhaps this might be what you're looking for:
13:01:07 <ibewes> https://wiki.openmrs.org/display/docs/Module+Conventions
13:02:59 <yony258> ibewes: Thank you, I think thats suffice for what I need
13:03:07 <yony258> ibewes++
13:06:47 *** kishoreyekkanti has joined #openmrs
13:07:20 *** harsz89 has quit IRC
13:15:29 *** boniface has joined #openmrs
13:16:10 <boniface> @dkayiwa you there?
13:16:26 <dkayiwa> boniface, hey
13:16:43 <dkayiwa> boniface, just seen your comment. will give you the fix in like one hour from now :)
13:16:47 <boniface> @dkayiwa cool
13:17:26 <boniface> @dkayiwa nice was cathcing up to see if you saw that .
13:17:28 <dkayiwa> boniface, can you stay on IRC? just incase i have some questions?
13:20:10 <dkayiwa> boniface, can you attach the tomcat stack trace on the ticket?
13:20:30 <dkayiwa> yony258, hi
13:20:55 <yony258> dkayiwa: Hi!, how are you?
13:21:07 <dkayiwa> yony258, long time. am cool :)
13:21:23 <yony258> dkayiwa: Yea, had some final exams :)
13:21:29 <yony258> dkayiwa: 1 semester to go :D
13:21:42 *** boniface has quit IRC
13:21:44 <dkayiwa> yony258, oh great!!! :)
13:44:12 <harshadura> hi rafa, i hv completed half of the ticket, sorry i had few problems with some Unit Tests, thats why couldnt complete it, is it okay if i commit my current changes ?
13:44:46 <rafa> harshadura: yes, go ahead and commit, someone will do the rest
13:44:49 <rafa> harshadura: thanks!
13:45:00 <harshadura> ok rafa
13:47:26 <harshadura> hi dkayiwa, jz curious did u got a moment to review my pull reqst
13:48:37 <dkayiwa> harshadura, sorry was not able to. but can do it now. what are the ticket numbers again?
13:49:57 <harshadura> dkayiwa : https://github.com/openmrs/openmrs-core/pull/222
13:50:02 <OpenMRSBot> <http://ln-s.net/+inM> (at github.com)
13:50:37 <DraggonZ> Hello. folks! Is there any persons related with GSoC? I want to participate this year and have chosen OpenMRS as my main target organization, because of you are really help people! Now I read http://en.flossmanuals.net/openmrs-guide to be more familiar with subject are, after thar I'm planning to watch Youtube videos, create simple module and resolve some introductory tickets. Do I go right way?
13:51:09 <dkayiwa> harshadura, did you test it out in the web interface?
13:51:26 *** supungs has joined #openmrs
13:51:27 <harshadura> yes dkayiwa, i did and it works
13:51:54 <dkayiwa> DraggonZ, you can always do whatever tickets you want any time :)
13:52:09 <dkayiwa> harshadura, ok reviewing now
13:52:50 <dkayiwa> harshadura, this pull request has lots of other commits
13:53:16 <dkayiwa> harshadura, can you make one which has just one commit?
13:53:29 <dkayiwa> harshadura, and do you know how?
13:53:29 *** yony258 has quit IRC
13:53:43 <harshadura> ok dkayiwa, i think only 2 commits :)
13:54:17 <harshadura> ok i will do it nw
13:54:50 <dkayiwa> harshadura, the other commit is the bad one :)
13:54:51 <jkeiper> hi dkayiwa :-D
13:55:02 <dkayiwa> jkeiper, hi :)
13:57:48 <DraggonZ> dkayiwa, Ok! :)
13:59:22 <jkeiper> dkayiwa, any word on XFRM-130? ... I wonder if it's something wrong with our instance ...
14:01:54 *** supungs has quit IRC
14:03:09 <dkayiwa> jkeiper, i suspect it being a bug in the module :)
14:03:30 <jkeiper> dkayiwa, ah ok ... anything i can do to help, let me know!
14:04:45 <dkayiwa> jkeiper, do you have the module checked out?
14:05:35 <dkayiwa> jkeiper, or do you have a way of sending me that form's schema?
14:06:01 <jkeiper> dkayiwa, i think i can get the schema
14:06:07 <jkeiper> dkayiwa, and i do have it checked out
14:06:22 <dkayiwa> jkeiper, can u send me the schema
14:06:23 <dkayiwa> ?
14:06:55 <dkayiwa> jkeiper, or simply put a debug line for me, compile, install and send me the log?
14:08:03 <dkayiwa> jkeiper, the line would be as simple as: System.out.println("Velocity Expression Value: " + value);
14:08:27 <dkayiwa> jkeiper, in XformBuilder at line 2612
14:09:26 <jkeiper> dkayiwa, ok ...
14:10:01 <dkayiwa> jkeiper, actually this would be better: System.out.println(name + " Velocity Expression Value: " + value);
14:10:04 <dkayiwa> System.out.println(name + " Velocity Expression Value: " + value);
14:10:46 <jkeiper> dkayiwa, ok ;-)
14:14:22 *** supungs has joined #openmrs
14:15:32 *** GitHub62 has joined #openmrs
14:15:32 <GitHub62> [openmrs-core] harshadura opened pull request #225: TRUNK-2498: Validate email address in user options page fixed (1.8.x...TRUNK2498) http://git.io/Be9MMw
14:15:32 *** GitHub62 has left #openmrs
14:16:07 <harshadura> hi dkayiwa, i hv added new pull reqst with jz one commit
14:16:19 <dkayiwa> harshadura, ok
14:17:33 *** jkeiper has quit IRC
14:17:36 *** jkeiper_ has joined #openmrs
14:17:59 *** ibewes has quit IRC
14:19:07 *** jblaya has joined #openmrs
14:21:05 *** meshack has joined #openmrs
14:23:54 *** boniface has joined #openmrs
14:23:57 <meshack> what is the aim of openmrs
14:24:27 <boniface> @dkayiwa hi? sorry i have been having connection issues
14:25:54 <jkeiper_> meshack, saving lives
14:26:00 *** jkeiper_ is now known as jkeiper
14:26:06 *** ChanServ sets mode: +v jkeiper
14:26:32 <meshack> thanks
14:30:09 <shortend> Haha, jkeiper... succinctly put.
14:31:02 <jkeiper> :-)
14:31:10 <meshack> how do we fill imprementer'form
14:32:59 <dkayiwa> meshack, https://wiki.openmrs.org/display/RES/Mailing+Lists
14:33:00 <OpenMRSBot> <http://ln-s.net/8ZWD> (at wiki.openmrs.org)
14:35:02 *** cpower has quit IRC
14:35:25 *** jb360 has quit IRC
14:36:31 *** shangxiao has joined #openmrs
14:36:33 <harshadura> dkayiwa u thr, was that commit ok ? :)
14:36:52 <dkayiwa> harshadura, can you show me the pull request url? :)
14:37:21 <harshadura> oops u jz missed it agin :(
14:37:30 <harshadura> http://git.io/Be9MMw
14:38:36 <dkayiwa> harshadura, did you delete some methods in OptionsFormControllerTest ?
14:38:53 <dkayiwa> harshadura, i see a number of lines in red in that class
14:40:22 <harshadura> dkyiwa, srry i hv again did the same mistake
14:42:35 <dkayiwa> harshadura, do you have the openmrs code formatter?
14:43:14 <harshadura> dkayiwa, i use IntelliJ that was the case, i will do it again
14:45:55 <supungs> guys, Im getting this error while trying to build
14:46:05 <supungs> [ERROR] Failed to execute goal org.apache.maven.plugins:maven-compiler-plugin:2.
14:46:05 <supungs> 1:compile (default-compile) on project openmrs-web: Compilation failure
14:46:05 <supungs> [ERROR] \DevProjects\GSOC\OpenMrs\openmrs-core-master\web\src\main\java\org\open
14:46:05 <supungs> mrs\web\controller\customdatatype\CustomValueController.java:[103,84] inconverti
14:46:05 <supungs> ble types
14:46:23 <meshack> dkayiwa,av only seen developer Guide
14:46:32 <dkayiwa> harshadura, you can do mvn install, and then see if it makes any formatting on those files before you make any change in them
14:47:00 <dkayiwa> meshack, subscribe to both the implementers and developers lists on that link i sent you
14:47:47 <meshack> dkayiwa, ok
14:47:53 <harshadura> dkayiwa, do maven format the code ?
14:48:13 <dkayiwa> harshadura, yes
14:48:26 <dkayiwa> harshadura, if it was not already formatted well
14:48:31 <harshadura> dkayiwa, thats awesome, i didn knw it before
14:48:54 *** djadmin has joined #openmrs
14:49:01 <jkeiper> dkayiwa, just updated XFRM-130
14:49:04 <jkeiper> fyi
14:49:04 <dkayiwa> harshadura, because we have a goal there which runs the openmrs formatter :)
14:49:13 <dkayiwa> jkeiper, looking at it now :)
14:49:23 <jkeiper> dkayiwa, thx
14:50:11 <jkeiper> dkayiwa, think it's the $ in $otherPerson.getBirthdate()
14:50:25 <dkayiwa> jkeiper, exactly :)
14:50:34 <jkeiper> dkayiwa, is that what wyclif added?
14:50:35 <jkeiper> ;-)
14:50:36 <boniface> @jkeiper and @dkayiwa , thanks for looking at XFRM-130
14:50:53 <jkeiper> boniface, karibu
14:56:11 <shangxiao> hi all, does any one know if basic auth is setup in the core code so that a module may expose a RESTful api?
14:56:13 *** boniface has quit IRC
14:58:26 *** cpower has joined #openmrs
15:00:08 <cpower> Hello!
15:01:07 *** supungs has left #openmrs
15:01:49 *** andrea_ has joined #openmrs
15:02:01 <cpower> Are we ready
15:02:05 <cpower> !scrumon cpower
15:02:05 * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
15:02:34 <cpower> Order: rafa, andrea_, dkayiwa, wyclif
15:02:59 <rafa> cpower: sorry I'll go last
15:04:01 <andrea_> Monday
15:04:01 <andrea_> Merck stuff
15:04:01 <andrea_> work on RESTWS-339 Fix PersonAttributeControllerTest
15:04:01 <andrea_> strange compile errors in program I had not touched
15:04:01 <andrea_> Had doctor's appointment - will make up time
15:04:01 <andrea_> Tuesday
15:04:05 <andrea_> RESTWS-339 Fix PersonAttributeControllerTest
15:04:07 <andrea_> Pick new ticket
15:04:09 <andrea_> Blocker - compile error in RestServiceImpl.java - wasn't even open in Eclipse
15:04:11 <andrea_> Also have som equestions on PersonAttributeControllerTest
15:05:13 <cpower> dkayiwa?
15:05:39 <dkayiwa> Reviewed: ModuleUtil should not treat SNAPSHOT as 999. - TRUNK-3654
15:05:39 <dkayiwa> Reviewed: drugOrder.drug should not be a mandatory field for drug order - TRUNK-3768
15:05:39 <dkayiwa> Reviewed: Validate email address in user options page - TRUNK-2498
15:05:40 <dkayiwa> Now fixing: DateFormat error in XformBuilder - XFRM-130
15:05:40 <dkayiwa> No Blockers
15:05:51 <wyclif> Monday:
15:05:51 <wyclif> Commit changes for RESTWS-341 - Fix PersonControllerTest
15:05:51 <wyclif> RESTWS-140 - Clean up representations of Cohort and CohortMember
15:05:51 <wyclif> Review TODOs for reviewed tickets
15:05:51 <wyclif> Tuesday:
15:05:51 <wyclif> More Review TODOs
15:05:55 <wyclif> Pick another sprint ticket
15:05:57 <wyclif>
15:05:59 <wyclif> Blockers: None
15:07:07 <rafa> Today:
15:07:07 <rafa> * Reviewed and merged code
15:07:07 <rafa> * Did more testing, discovered and fixed some bugs
15:07:07 <rafa> * Committed RESTWS-363: Create JUnit rule to run tests only on specified version of OpenMRS
15:07:07 <rafa> https://tickets.openmrs.org/browse/RESTWS-363
15:07:07 <rafa> * Created RESTWS-364: Reorganize module structure
15:07:08 <rafa> https://tickets.openmrs.org/browse/RESTWS-364 (will need to wait for others to complete work)
15:07:08 <rafa> No blockers.
15:07:16 <cpower> Anyone else?
15:07:40 <cpower> Ok Announcements
15:08:49 <cpower> 1. RestWS ends Thursday AM and becomes a Community Driven Sprint for 2 weeks. Darius is trying to get some focus help on a few things if you are interested, otherwise work with the Community Developers to hit bug tickets and most voted
15:09:52 *** shangxiao has quit IRC
15:09:55 *** meshack has quit IRC
15:10:07 <andrea_> cpower, what is Community Driven Sprint?
15:10:22 <rafa> I'd like to ask everyone to commit code by tomorrow so that I have time to wrap everything up
15:10:30 *** meshack has joined #openmrs
15:10:50 <cpower> 2. A volunteer named Jayanthi will be reaching out to some of you to help clean up tickets on the RESTWS sprint (making sure you logged some time on tickets completed etc)
15:10:57 <rafa> for most of you by tomorrow means you need to commit today
15:11:14 <andrea_> rafa, did you see my email re compile errors in REstServiceImpl?
15:11:24 <rafa> andrea_: didn't get any e-mail
15:11:36 <rafa> andrea_: did you send it to a dev list or me?
15:11:47 *** moshon has joined #openmrs
15:11:55 <cpower> 3. We need Design meeting topics for tomorrow, I'm hoping some of the External Authentication, Sync and Reference 2.0 people will be coming with questions for the group
15:12:01 <andrea_> rafa, sent this morning
15:12:09 <rafa> andrea_: ohh ok see it now
15:12:15 <andrea_> rafa, sent to you and dev list
15:12:31 <rafa> andrea_: you have a conflict
15:12:38 <rafa> andrea_: in the RestServiceImpl file
15:12:45 <andrea_> rafa, what conflicT/
15:12:46 <rafa> andrea_: did you modify it?
15:13:07 <cpower> andrea_: do you know what the community sprint is yet?
15:13:14 <andrea_> rafa, I did not modify it - it wasn't even open
15:13:34 <rafa> andrea_: if you didn't then you can just rever it
15:13:53 <andrea_> rafam how do I revert?
15:13:55 <rafa> andrea_: git checkout path/to/RestServiceImpl.java
15:14:14 <andrea_> rafa, ok will do that - thanks
15:14:55 <andrea_> cpower, re community sprint - no not sure
15:15:02 *** djadmin2 has joined #openmrs
15:15:44 <andrea_> rafa, will you be on irc for awhile?
15:15:48 *** djadmin has quit IRC
15:16:27 <cpower> andrea_: Ok, so when I don't have a sprint ready we have the developers work from 2 areas. Bug list (which you know well), and the most Voted. Darius also has sent out a reply to my email about pushing out sprints for two weeks with a request in which you can help him out with as well.
15:16:29 <rafa> andrea_: yes, just may need to eat at some point :)
15:16:51 <cpower> andrea_: Pretty much pick something in one of those 3 areas to work on and you will do fine
15:17:18 <rafa> andrea_: https://wiki.openmrs.org/display/RES/Community+Development+Swim+Lane
15:17:20 <cpower> !scrumoff
15:17:20 * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
15:17:34 <cpower> +1 to Rafa
15:17:48 <rafa> cpower: it's rafa++
15:17:53 <rafa> ;)
15:18:01 <cpower> good point
15:18:05 <cpower> rafa++
15:18:21 <rafa> hmmm
15:18:30 <cpower> damn Google influencing everything
15:19:05 <andrea_> rafa, cpower thanks
15:19:44 *** djadmin2 has quit IRC
15:19:45 <andrea_> rafa, you didn't answer - will you be on irc later?
15:20:06 <rafa> andrea_: I did
15:20:10 <rafa> ~-+78334184+-~7[16:16] rafa: andrea_: yes, just may need to eat at some point :)
15:20:33 <andrea_> rafa, sorry - I see it now
15:21:17 <andrea_> rafa, good - may have some questions re PersonAttributeControllerTest too
15:25:52 *** moshon has quit IRC
15:28:33 <jblaya> dkayiwa, I'm getting an error when I try to compile xforms from the source code
15:28:45 <jblaya> dkayiwa, [ERROR] Failed to execute goal on project xforms-api: Could not resolve dependencies for project org.openmrs.module:xforms-api:jar:4.1.0.0: The following artifacts could not be resolved: org.openmrs.api:openmrs-api:jar:1.6.5, org.openmrs.web:openmrs-web:jar:1.6.5, org.openmrs.api:openmrs-api:jar:tests:1.6.5: Could not find artifact org.openmrs.api:openmrs-api:jar:1.6.5 in openmrs-repo (http://mavenrepo.openmrs.org/nexus/content/repositories/publi
15:28:45 <jblaya> c) -> [Help 1
15:28:52 <jblaya> dkayiwa, do you have any idea how to solve it?
15:29:21 <jblaya> dkayiwa, in maven, we've forced the dependencies, and we do a clean install skipping the tests
15:29:47 <jblaya> dkayiwa, however, when I try to get to the urls for the mavenrepo, they don't work
15:30:06 <meshack> dkayiwa,thanks alot, am done
15:30:24 <dkayiwa> jblaya, am getting exactly the same
15:30:34 <dkayiwa> jblaya, let me look into it
15:30:38 <jblaya> dkayiwa, :-D
15:30:49 <jblaya> dkayiwa, my guess is that the URLs have stopped working
15:31:07 <jblaya> dkayiwa, they are in the warning section before the error
15:31:16 <dkayiwa> jblaya, ok
15:32:26 *** supungs has joined #openmrs
15:32:36 *** cpower has quit IRC
15:33:17 *** Anuruddha_ has joined #openmrs
15:35:29 *** dkayiwa has quit IRC
15:36:14 *** Anuruddha has quit IRC
15:37:15 *** Anuruddha has joined #openmrs
15:38:05 *** meshack has quit IRC
15:39:27 *** cpower has joined #openmrs
15:41:00 *** Anuruddha_ has quit IRC
15:41:20 *** andrea_ has quit IRC
15:41:46 *** andrea_ has joined #openmrs
15:46:19 *** djadmin has joined #openmrs
15:49:06 *** DraggonZ has left #openmrs
15:55:08 *** supungs has left #openmrs
15:55:58 *** djazayeri has joined #openmrs
15:55:58 *** ChanServ sets mode: +o djazayeri
15:56:00 *** jblaya has quit IRC
15:58:09 *** dmulinwa has joined #openmrs
16:08:35 *** jblaya has joined #openmrs
16:16:23 *** k-joseph has joined #openmrs
16:19:12 *** dmulinwa has quit IRC
16:24:45 *** suranga has joined #openmrs
16:24:45 *** ChanServ sets mode: +v suranga
16:27:08 *** k-joseph has quit IRC
16:28:00 *** k-joseph has joined #openmrs
16:32:53 *** djadmin has quit IRC
16:36:52 <rafa> jblaya: your problem with xforms is https://tickets.openmrs.org/browse/ITSM-2991
16:37:12 <rafa> jblaya: I don't know why Michael hasn't fixed it yet
16:37:17 <rafa> jblaya: let me ping him
16:37:51 *** djadmin has joined #openmrs
16:41:14 *** evmw has quit IRC
17:15:50 *** rfriedman has joined #openmrs
17:16:05 <rfriedman> rafa, hi
17:16:11 <rafa> rfriedman: hi
17:16:21 <rfriedman> rafa, re 306, I'm not sure what you're proposing
17:16:34 <rafa> 306?
17:16:47 <rfriedman> rafa, do mean just change the default display for metadata resources?
17:16:50 <rfriedman> rafa, sry, 307
17:17:09 <rafa> rfriedman: yes, just changing the default display to be simply the name
17:17:17 <rafa> rfriedman: without description
17:17:23 *** k-joseph has quit IRC
17:18:05 <rfriedman> rafa, how about a quick scan to see if any metadata resource without a display method needs both?
17:18:28 <rafa> rfriedman: I haven't seen any
17:18:49 <rfriedman> rafa, yeah, it was my impression that the default wasn't being used
17:19:51 <rafa> rfriedman: not sure what you mean. I think the default "name - description" is used by all
17:20:08 <rfriedman> rafa, no, i think it's being overridden by most if not all
17:20:54 <rafa> rfriedman: ohh you are right
17:21:09 <andrea_> rafa, hi
17:21:32 <rfriedman> rafa, also on lluis' xml ticket
17:22:04 <rfriedman> rafa, is that being tested with different reps and custom rep?
17:22:36 <rafa> rfriedman: I haven't looked closely at that
17:22:47 <andrea_> rafa, git will not let me checkout RestServiceImpl
17:22:51 <rafa> rfriedman: I don't think it makes much difference
17:22:58 <rfriedman> rafa, I thought we always did <names><name><firstname>xx</firstname>etc.</name>...</names>
17:23:24 <rfriedman> rafa, but in json of course
17:23:53 <rfriedman> rafa, i don't think it makes much difference because i think it has all been done by the time the simple object is ready to send
17:24:01 *** harsz89 has joined #openmrs
17:24:35 <rfriedman> rafa, but i'm not sure bcs of the way names was handled
17:26:19 *** andrea__ has joined #openmrs
17:26:34 <andrea_> rafa, while I did not change it before it got the compile error - I did take out one of the funny ">>>>> stashed changes" yesterday
17:26:42 *** evmw has joined #openmrs
17:27:10 <rafa> rfriedman: the json representation is "names": [ {"firstname" : "rafal"}, {"firstname": "roger"} ]
17:27:53 <rfriedman> rafa, and with a last name?
17:28:15 <rafa> "names": [ {"firstname" : "rafal", "lastname": "korytkowski"}, {"firstname": "roger"} ]
17:28:16 <rfriedman> rafa, i should just run the mofo
17:28:21 <rafa> rfriedman: yes :)
17:28:42 <rafa> rfriedman: I'm actually trying it on concept
17:29:49 <rfriedman> rafa, i am still unpacking from being at a meeting yesterday and goofing off all weekend, but hope to clear away the underbrush soon. Then I will return to 267 objects
17:30:56 <rafa> rfriedman: I understand. I didn't mean to rush you. I appreciate your help a lot!
17:31:07 <rfriedman> rafa, actually goofing off is not the right word, try "restoring domestic tranquility"
17:32:04 <rfriedman> andrea_, did you resolve the differences or just get rid of the >>> lines?
17:32:24 <jblaya> djazayeri, are boolean data types for concepts able to be used now?
17:32:41 <jblaya> djazayeri, because I remember you told me not to use them a while ago and I wanted to see if anything had changed
17:32:42 <djazayeri> jblaya: yes, but under the hood they are stored like coded concepts
17:33:06 <djazayeri> jblaya: I still would rarely use a boolean instead of a Coded with True and False as answers.
17:33:12 <jblaya> djazayeri, ok great
17:33:22 <djazayeri> jblaya: because you just _know_ that eventually someone will ask you to add an unkown option
17:33:29 <andrea_> rafa, have gotten rid of the >>> lines - still compile errors
17:33:40 <rafa> andrea_: why don't you just do what I suggested
17:33:49 <rafa> andrea_: revert the whole file
17:33:56 <rafa> andrea_: it does compile
17:33:59 <jblaya> djazayeri, :D ok, but right now if I save it as boolean it's the same as if I create a true and false concepts and place them as possible answers
17:34:03 <rafa> andrea_: CI says so and my pc too
17:34:10 <jblaya> djazayeri, the only problem will come in the future when I have to add a third option
17:34:15 <jblaya> djazayeri, right?
17:34:44 <djazayeri> jblaya: exactly
17:34:57 <andrea_> rafa, tried to checkout but got error: RestServicesImpl is unmerged
17:34:59 <jblaya> djazayeri, ok, great to know, thanks!
17:35:00 <rfriedman> jblaya, actually, the client is already expecting an unknown value, just didn't say it
17:35:17 <jblaya> rfriedman, :-D
17:35:36 <jblaya> rfriedman, that's right, we should know what the client wants before they say it
17:35:41 <jblaya> rfriedman, wish I was that good
17:36:03 <rfriedman> jblaya, how can you work in latin america where nobody tells the whole truth?
17:36:17 <rafa> andrea_: pastebin "git status"
17:36:21 <jblaya> rfriedman, it's been a learning experience, TRUST ME
17:36:50 <jblaya> rfriedman, how to decipher whether a yes, actually means yes or it actually means, what the hell are you thinking, of course we would never do that you &$(*%$$
17:36:52 <rfriedman> jblaya, what we need is a better class of client :)
17:38:11 <andrea_> rafa: pastebin.com/2AHUGB52
17:38:59 <rfriedman> rafa, resolving differences in git might be a good question for tomorrow morning
17:39:21 <rafa> andrea_: it doesn't say that RestServicesImpl is in conflict
17:39:31 <rafa> andrea_: are you sure you are in the right directory?
17:39:57 *** shortend has quit IRC
17:40:14 <rafa> rfriedman: sure, if you come and ask ;)
17:40:37 <andrea_> rafa, yes - let me go to other computer for irc
17:42:14 <andrea__> rafa: on work computer now - forgot about https://wiki.openmrs.org/display/IRC/Home - is XCHAT that only works on Merck network
17:43:03 <rafa> andrea__: if you are sure then pastebin git log
17:44:47 <andrea__> rafa: http://pastebin.com/3uxKQ3ey
17:45:27 <rafa> andrea_: ok, so you did git stash before pulling?
17:45:42 <rafa> andrea_: did you do git stash pop after pulling?
17:46:54 <andrea__> rafa, yes did stash but quite sure I did git stash pop too
17:47:25 <rafa> andrea_: ok, nevermind
17:47:38 <rafa> andrea_: just do git add omod/src/test/java/org/openmrs/module/webservices/rest/web/v
17:47:38 <rafa> 1_0/controller/openmrs1_8/PersonAttributeControllerTest.java
17:47:59 <andrea__> rafa, found log from yesterday - did pop
17:48:03 <rafa> andrea_: then git commit -m "RESTWS-333"
17:48:15 <rafa> andrea_: then git reset --hard
17:48:20 <andrea__> rafa, ok will add and commit - thanks
17:50:06 <rafa> andrea_: you don't have to pull if you are working on a single test
17:50:42 <rafa> andrea__: just do your work, commit at the end and then push
17:50:50 <rafa> andrea__: no need to merge with upstream that often
17:52:32 *** andrea__ has quit IRC
17:55:15 *** djadmin has quit IRC
17:55:30 *** djadmin has joined #openmrs
18:04:17 <andrea_> rafa: still unresolved conflict: pastebin.com/uQ8SRGEK
18:05:36 *** andrea__ has joined #openmrs
18:06:35 <andrea__> rafa?
18:10:11 <andrea_> rafa, will not pull anymore - what a mess
18:15:02 <andrea_> rafa, will it work to save my PersonAttributeControllerTest.java somewhere else
18:16:13 <andrea_> rafa, then do git reset --hard, then copy my PersonAttributeControllerTest back
18:28:51 <rafa> andrea_: yes, it will work
18:31:41 <andrea_> rafa, wil do - thanks!
18:39:00 <andrea_> rafa, ok I'm back - no more pulls - thanks!!!
18:45:00 *** Anuruddha has quit IRC
19:02:57 *** kishoreyekkanti has quit IRC
19:04:51 *** dmulinwa has joined #openmrs
19:17:53 *** djadmin has quit IRC
19:27:58 *** Hasintha_i has joined #openmrs
19:34:43 *** Hasintha_i has quit IRC
19:41:16 *** k-joseph has joined #openmrs
19:42:32 *** dmulinwa has quit IRC
19:47:29 <harsz89> hi
19:48:10 <harsz89> i'm thinking of working on RESTWS-284 ticket
19:48:37 <harsz89> i'm new to openmrs and i looked at implementations of openmrs
19:48:51 <harsz89> how can i get start with this ticket?
19:58:38 *** mseaton has joined #openmrs
19:58:38 *** ChanServ sets mode: +v mseaton
20:01:39 *** k-joseph has quit IRC
20:04:56 <rafa> !ticket RESTWS-284
20:04:57 <OpenMRSBot> rafa: [#RESTWS-284] catalog call show take parameters to limit output - OpenMRS JIRA - https://tickets.openmrs.org/browse/RESTWS-284
20:05:23 <rafa> hi harsz89
20:05:50 <rafa> harsz89: are you interested in this ticket for some particular reason?
20:06:53 <rafa> harsz89: this ticket will be ready for work only from Thursday or so
20:07:11 <rafa> harsz89: after we merge code from the current sprint
20:07:40 <rafa> harsz89: so if you want to work on this exact ticket please hold on a few days
20:07:53 *** dkayiwa has joined #openmrs
20:16:20 *** dkayiwa has quit IRC
20:16:37 *** dkayiwa has joined #openmrs
20:16:49 *** k-joseph has joined #openmrs
20:18:31 <jkeiper> mseaton, heyya
20:18:49 <mseaton> jkeiper: hey
20:18:50 <jkeiper> mseaton, does Reporting come with some custom logging settings?
20:19:20 <mseaton> jkeiper: don't think so, what are you seeing?
20:19:42 <jkeiper> mseaton, i see a ton of LoggingAdvice around Object.toString() during a scheduled task, with a bunch of ReportingSerializer lines sprinkled throughout
20:20:15 <mseaton> jkeiper: i hate LoggingAdvice. but that's core's fault.
20:20:24 <jkeiper> mseaton, agreed!
20:20:36 <mseaton> jkeiper: can you show me the output?
20:20:46 <jkeiper> mseaton, the whole thing terminates with an error too ... yep, one sec
20:22:54 *** dmulinwa has joined #openmrs
20:22:57 *** andrea__ has quit IRC
20:23:46 <jkeiper> mseaton, http://pastebin.com/VhHRCa8f
20:24:01 <jkeiper> mseaton, the Object.toString stuff could be another module ... lots running right now
20:24:12 <jkeiper> mseaton, but ... perhaps you know what's wrong with the error at the end
20:26:08 <mseaton> jkeiper: not sure why it is logging all that stuff. i'm guessing that is coming from the serialization xstream module, but might be coming from reporting serialize.
20:26:34 <jkeiper> mseaton, i'll check it out ... could be one of my modules has a stray log4j file
20:26:35 <mseaton> jkeiper: the key part of the error message it seems is "Column 'report_definition_uuid' cannot be null"
20:26:59 <jkeiper> mseaton, think i'm missing some linkage?
20:27:07 *** dmulinwa has quit IRC
20:27:13 <mseaton> jkeiper: are you creating a report in memory and trying to run it?
20:27:41 <jkeiper> mseaton, there are several on the server already ... i think this is coming from a cleanup task
20:28:01 <jkeiper> mseaton, but yes, the one i'm running from my module (which is not failing) is done in-memory
20:28:01 <mseaton> oh i see. you're right. from DeleteOldReportsTask
20:28:24 <mseaton> jkeiper: what version are you running?
20:28:28 <jkeiper> so, i guess at least one piece of a report lost its connection to another piece
20:28:33 <jkeiper> 0.7.5 now
20:28:43 <jkeiper> oh wait, my bad ... 0.7.0
20:29:56 <k-joseph> dkayiwa: hi
20:30:07 <dkayiwa> k-joseph, hi
20:32:02 <mseaton> jkeiper: when you run your "in memory" reports, what api method are you using to run them? reportservice.runReport or reportdefinitionservice.evaluateDefinition()?
20:33:41 <jkeiper> reportDefinitionService.evaluate(reportDefinition, evaluationContext)
20:33:46 <jkeiper> mseaton, --^
20:33:54 *** andrea has joined #openmrs
20:34:07 <k-joseph> dkayiwa: am having http://pastebin.com/4pKut13e as the datatype so far for TRUNK-3621
20:34:11 <andrea> wyclif, you there?
20:34:16 *** andrea is now known as Guest49634
20:34:31 *** Guest49634 is now known as andreap
20:35:47 <mseaton> jkeiper: are there any reportrequests in your table that refer to reportdefinitions that have since been deleted?
20:36:05 *** harsz89 has quit IRC
20:36:12 <dkayiwa> k-joseph, when serializing, what property of the object do you return?
20:36:19 <jblaya> rafa, in a database element how do I create an element for the age of the patient assuming that birthdate has been entered?
20:36:29 <mseaton> jkeiper: do you (or anyone) ever delete report definitions out of the serialized object table manually?
20:36:38 <jblaya> dkayiwa, any solution to the error during compilation?
20:36:46 <jkeiper> mseaton, haven't so far ...
20:36:52 <jkeiper> mseaton, at least nobody i know does ...
20:37:07 <dkayiwa> jblaya, was it working well before on the same computer?
20:37:08 <jkeiper> mseaton, there might be ... what are report requests?
20:37:20 <jblaya> dkayiwa, I'd never tried before on that computer
20:37:48 <jblaya> dkayiwa, but you mentioned that you had the same problem, no?
20:38:14 <dkayiwa> jblaya, it has all along been working for me. Am now temporarily using another computer and so there is a possibility that it could be my setup on this one
20:38:34 <jblaya> dkayiwa, ah, ok, and were you able to find a solution?
20:38:58 <dkayiwa> jblaya, so far not yet :)
20:39:06 <mseaton> jkeiper: when you run a report via the reporting module ui, you do so asynchronously. the first thing that happens is a report request is saved with the details of the report requested, the parameters, the renderer selected, etc. then a scheduled process comes along and runs it. and then the success or failure of that run is saved to the database and it is preserved in the table historically for a period of time. if it is not explicitly saved after t
20:39:40 <jblaya> dkayiwa, ok :) can you let me know when you do because we haven't figured it out either...
20:39:42 <rafa> jblaya: dkayiwa still discussin xforms compilation error?
20:39:46 <k-joseph> dkayiwa: hi
20:39:54 <jblaya> rafa, dkayiwa, yes
20:39:58 <k-joseph> dkayiwa: typedValue
20:40:00 <mseaton> jkeiper: so if a report was run in this way, and then the report definition was later purged somehow without causing a foreign key constraint issue against this table, then this could cause the problem you are seeing. or it could be hibernate being annoying...
20:40:04 <dkayiwa> :)
20:40:12 <rafa> someone/something deleted jars from our maven repo
20:40:28 <dkayiwa> k-joseph, is that a property of any object?
20:40:29 <rafa> you can't build modules which depend on 1.6.x
20:40:49 <dkayiwa> rafa, that saves our efforts to know the cause :)
20:41:00 <rafa> dkayiwa: jblaya I'll reupload jars tomorrow
20:41:40 <jblaya> rafa, ok, thanks, and can we try and figure out a way for it not to happen again?
20:41:45 <k-joseph> dkayiwa: a property of Concept, else i instantiate a new property
20:41:54 <rafa> jblaya: there's a thread on the dev list
20:42:14 <jblaya> rafa, ok, cool, thanks
20:42:20 <jblaya> dkayiwa, in a database element how do I create an element for the age of the patient assuming that birthdate has been entered?
20:42:30 <dkayiwa> k-joseph, does the concept class have any such property?
20:42:41 <jkeiper> mseaton, ah ... so i could just clear out the report requests and tell people to go request them again?
20:42:58 <jkeiper> mseaton, do any requests stick around, like a repeating task?
20:43:06 <rafa> jblaya: meanwhile you could try building with 1.7+
20:43:30 <jblaya> rafa, could you tell me how to do that
20:43:45 <jblaya> rafa, or a link with instructions examples
20:44:04 *** cpower has quit IRC
20:44:07 <rafa> jblaya: look for openMRSVersion in the main pom
20:44:20 <mseaton> jkeiper: report requests also represent scheduled reports. so if you requested a report be run on a repeating schedule, that's where it would go. if your are doing this the schedule property of the report request would be non-null...
20:44:21 <k-joseph> dkayiwa: no, it does not, i think i should have used ConceptDatatype datatype
20:44:21 <jblaya> rafa, ok cool
20:44:23 <dkayiwa> jblaya, instead of .....getBirthdate() use ....getAge()
20:44:34 <jblaya> dkayiwa, thanks!
20:44:37 <jblaya> rafa, will try that now
20:44:46 <rafa> jblaya: change it to 1.7.4 for example
20:45:06 <dkayiwa> k-joseph, did you understand my very first question?
20:45:09 <mseaton> jkeiper: if you are clearing out your report requests, you may also want to clear out your report results (which can get sizeable) which are stored in your .OpenMRS/REPORT_RESULTS folder
20:45:44 <jkeiper> mseaton, ok ... i'll put that on my list, will certainly help clean up the log (and db growth)
20:45:54 <jkeiper> mseaton, thanks!
20:46:02 <mseaton> jkeiper: no problem
20:46:45 <andreap> rafa, getting error on person_attribute in overwritten method getURI() - tried personattribute too -didn't work
20:46:55 <k-joseph> dkayiwa: in response to that first question, i now think you return the property of the Class whose datatype am writing
20:47:42 <andreap> rafa, where is that defined?
20:48:05 <dkayiwa> k-joseph, have you looked at all the existing handlers?
20:48:27 <k-joseph> dkayiwa: yes i have
20:48:57 <rafa> andreap: How can I know what error you're getting? ;)
20:49:20 <andreap> rafa: org.openmrs.api.APIException: Unknown resource: person_attribute
20:50:16 <rafa> andreap: the URI to fetch all person attributes is person/{personUuid}/attribute
20:50:52 <rafa> andreap: if you want to fetch a specifict attributes it's person/{personUuid}/attribute/{attributeUuid}
20:51:00 <rafa> *specific attribute
20:51:11 <jblaya> dkayiwa, rafa, ok, because 1.7.0 did not work either, but 1.8.0 did
20:53:44 <andreap> rafa: yes - see this PersonNameController: return "person/" + personUuid + "/name";
20:54:23 *** cpower has joined #openmrs
20:55:24 <rafa> andreap: yes and your error says you are trying to fetch person_attribute
20:55:29 <rafa> andreap: it doesn't exist
20:55:44 *** rfriedman has quit IRC
20:55:45 <rafa> andreap: what is the url you're using
20:56:56 <andreap> rafa?
20:57:12 <rafa> andreap?
20:57:40 <andreap> rafa, in getURI()?
20:57:46 <rafa> andreap: yes
20:59:36 *** harshadura has quit IRC
21:01:50 <rafa> andreap: still there?
21:02:44 <andreap> rafa, yes - guess it should be: "person/" + personUuid + attributeUuid "/attribute";
21:03:16 <rafa> andrea_: no getURI should be "person/" + personUuid + "/attribute"
21:03:18 <andreap> rafa: no not that
21:03:46 <rafa> I said it before :)
21:04:25 <andreap> rafa: looking at PersonNameController - getURI returns: return "person/" + personUuid + "/name";
21:04:35 *** k-joseph has quit IRC
21:04:45 <rafa> andreap: do you read what I write? :)
21:05:28 *** rafa has quit IRC
21:05:35 <andreap> rafa, yes - person/{personUuid}/attribute/{attributeUuid}
21:05:45 *** rkorytkowski has joined #openmrs
21:05:45 *** rkorytkowski is now known as rafa
21:05:45 *** ChanServ sets mode: +v rafa
21:05:55 <dkayiwa> jblaya, 1.8 has also worked for me
21:05:57 <rafa> andreap: sorry got disconnectec
21:06:21 <andreap> rafa , ok so person/{personUuid}/attribute/{attributeUuid}
21:06:52 <rafa> andreap: yes, it's how to fetch a single attribute
21:07:24 <rafa> andrea_: but getURI must say how to fetch any attribute(s)
21:07:28 <andreap> rafa, thanks, I would not have known that - so return exactly that?
21:07:31 <rafa> andreap: so person/{personUuid}/attribute/
21:07:39 <rafa> andrea_: sorry without / at the edn
21:08:31 <rafa> andreap: getURI() { return "person/" + personUuid + "/attribute"; }
21:08:33 <andreap> rafa, better - lookslike what I see in PersonNameController
21:08:57 <rafa> andreap: ok, it's pretty late here
21:09:01 <andreap> rafa, got ya - thanks again!
21:09:01 <rafa> andreap: I'm sining off
21:09:11 <rafa> andreap: happy coding ;)
21:09:13 <andreap> rafa, ok good night!
21:09:23 <rafa> andreap: you're welcome
21:09:28 <rafa> cya
21:09:36 <andreap> rafa, cyc
21:09:44 *** rafa has quit IRC
21:11:35 *** lh has joined #openmrs
21:11:59 *** harshadura has joined #openmrs
21:17:20 *** k-joseph has joined #openmrs
21:19:42 *** k_joseph has joined #openmrs
21:34:50 *** suranga has quit IRC
21:34:59 *** dmulinwa has joined #openmrs
21:45:03 *** k-joseph has quit IRC
21:45:07 *** k_joseph has quit IRC
21:56:18 *** wyclif_ has joined #openmrs
21:56:18 *** wyclif has quit IRC
22:02:11 *** mseaton has quit IRC
22:17:58 *** dmulinwa has quit IRC
22:26:18 *** sunbiz has joined #openmrs
22:26:18 *** ChanServ sets mode: +v sunbiz
22:34:16 *** jblaya has quit IRC
22:54:45 <wyclif_> hi djazayeri
22:55:46 <wyclif_> djazayeri, i have been trying to look at https://tickets.openmrs.org/browse/RESTWS-140 and i have found no way ot trying to display memberids ad Patients instead using the current conversion logic
22:56:19 <wyclif_> djazayeri, i have been trying to look at https://tickets.openmrs.org/browse/RESTWS-140 and i have found no way of trying to display memberids as Patients using the current conversion logic
23:05:40 <djazayeri> wyclif_: hmm.
23:05:53 <djazayeri> wyclif_: I don't know where to go from there...
23:07:00 <djazayeri> wyclif_: you can't handle this in the @PropertyGetter method for memberIds?
23:07:28 <wyclif_> djazayeri, the current logic looks at the property type
23:08:06 <djazayeri> wyclif_: actually…as long as the members sub-resource is doing the right thing, I'm fine if we leave memberIds as just a list of integers
23:08:24 <wyclif_> i think property getter is for fetching a property from a delagate and not on the represenatation
23:09:00 <djazayeri> wyclif_: propertygetter is for when you want the override the default resource behavior, which would be to just fetch the property from the delegate.
23:10:26 <djazayeri> wyclif_: but per my comment about being concerned about the performance of fetching all those patients from the database...
23:10:57 <djazayeri> wyclif_: I'm cool if we just leave it as memberIds, or even remove the memberIds property, and force people to go to the members subresource
23:15:32 <wyclif_> djazayeri, property getter will probabbly solve it but it might e expensive
23:16:07 <wyclif_> djazayeri, am fine with leaving the memberIds
23:16:26 <djazayeri> wyclif_: okay, let's do that, but do please verify that the members subresource is behaving right
23:16:37 <wyclif_> djazayeri, i think cohort member resource looks fine to me the way it is currently
23:18:14 <wyclif_> the member resource behaves just like any other subresource
23:18:35 <wyclif_> it allows removing, adding a member and listing all members
23:41:53 *** dkayiwa has quit IRC