| 00:16:56 | *** djazayeri1 has quit IRC |
| 00:27:00 | *** andreapat has quit IRC |
| 00:30:37 | *** robbyoconnor has joined #openmrs |
| 00:30:37 | *** ChanServ sets mode: +v robbyoconnor |
| 00:45:14 | *** robbyoconnor has quit IRC |
| 01:14:49 | *** mseaton has joined #openmrs |
| 01:14:49 | *** ChanServ sets mode: +v mseaton |
| 02:05:40 | *** jb360 has joined #openmrs |
| 02:14:14 | *** robbyoconnor has joined #openmrs |
| 02:14:14 | *** ChanServ sets mode: +v robbyoconnor |
| 02:53:56 | *** andreap_ has quit IRC |
| 02:54:04 | *** mseaton has quit IRC |
| 03:09:21 | <jb360> Anyone available by chance? |
| 03:12:12 | *** suranga has joined #openmrs |
| 03:12:12 | *** ChanServ sets mode: +v suranga |
| 03:29:11 | *** jkeiper has joined #openmrs |
| 03:29:11 | *** ChanServ sets mode: +v jkeiper |
| 04:24:12 | *** djazayeri has joined #openmrs |
| 04:24:12 | *** ChanServ sets mode: +o djazayeri |
| 04:52:20 | *** k-joseph has quit IRC |
| 05:05:14 | *** djadmin has joined #openmrs |
| 06:08:45 | *** rowanseymour has joined #openmrs |
| 06:29:49 | *** cpower has quit IRC |
| 06:30:49 | *** rowanseymour has quit IRC |
| 06:48:20 | *** rowanseymour has joined #openmrs |
| 06:51:55 | *** djazayeri has quit IRC |
| 06:59:05 | *** dkayiwa has joined #openmrs |
| 07:20:09 | *** dkayiwa has quit IRC |
| 07:37:31 | *** djadmin has quit IRC |
| 07:38:23 | *** rowanseymour has quit IRC |
| 08:45:58 | *** suranga_ has joined #openmrs |
| 08:56:12 | *** robbyoconnor has quit IRC |
| 09:13:13 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Reporting 0.7.5 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=reporting&version=&0.7.5> |
| 09:32:49 | *** evmw_ has joined #openmrs |
| 09:32:50 | *** evmw has quit IRC |
| 09:32:50 | *** evmw_ is now known as evmw |
| 10:04:44 | *** rkorytkowski has joined #openmrs |
| 10:04:44 | *** ChanServ sets mode: +v rkorytkowski |
| 10:04:44 | *** rkorytkowski is now known as rafa |
| 10:34:07 | *** k-joseph has joined #openmrs |
| 10:35:14 | *** k_joseph has joined #openmrs |
| 10:35:53 | *** dkayiwa has joined #openmrs |
| 10:37:13 | *** k-joseph has quit IRC |
| 10:43:16 | <dkayiwa> hi k_joseph |
| 10:44:07 | <k_joseph> dkayiwa: hi |
| 10:44:07 | *** k_joseph is now known as k-joseph |
| 10:44:41 | <dkayiwa> k-joseph: you will tell me when you get some free time and we try pair up to fix that problem |
| 10:45:24 | <k-joseph> dkayiwa: ok, thanks a lot for that |
| 10:50:29 | *** k-joseph has quit IRC |
| 11:07:44 | *** k-joseph has joined #openmrs |
| 11:09:03 | *** lh has joined #openmrs |
| 11:15:15 | *** k-joseph has quit IRC |
| 11:26:44 | *** k-joseph has joined #openmrs |
| 11:29:18 | *** kavuri has joined #openmrs |
| 11:31:22 | *** k-joseph has quit IRC |
| 11:39:19 | <kavuri> rafa: hi |
| 11:39:28 | <rafa> kavuri: hi! |
| 11:40:59 | <kavuri> rafa: basic question about writing unit test cases for rest methods. I implemented a Resource unit testcase for my resource and implemented the getUuidProperty(), which returns a random uuid |
| 11:41:30 | <kavuri> rafa: when I run the test, I get an error "newObject must not return null" |
| 11:41:45 | <kavuri> rafa: the newObject method retrieves the object by uuid, |
| 11:42:11 | <kavuri> rafa: can the uuid be any random uuid, or should the data be pre-loaded somewhere? |
| 11:42:17 | <rafa> kavuri: why getUuidProperty returns random uuid? |
| 11:42:32 | <rafa> kavuri: can I see the code? |
| 11:43:36 | <kavuri> rafa: here is the code: http://pastebin.com/1wiLe2gU |
| 11:44:23 | <rafa> kavuri: the object must exist in the db |
| 11:44:49 | <kavuri> rafa: how to pre-configure the db? |
| 11:45:43 | <rafa> kavuri: e.g. using dbunit |
| 11:46:04 | <rafa> kavuri: or you can create an object and save it to the db in a method annotated with @Before |
| 11:48:15 | <kavuri> rafa: like using an xml to load the data? |
| 11:48:22 | <rafa> kavuri: yes |
| 11:48:33 | <kavuri> rafa: ok. thanks. Will do so |
| 11:48:41 | <rafa> kavuri: np |
| 12:36:18 | *** djadmin has joined #openmrs |
| 12:39:53 | <suranga> rafa, hi, ive sent you one more patch... |
| 12:40:13 | <rafa> suranga: you're gold ;) |
| 12:40:22 | <dkayiwa> and silver :) |
| 12:40:22 | <suranga> rafa, :P |
| 12:40:40 | *** djadmin has quit IRC |
| 12:40:56 | <suranga> dkayiwa, rafa 2.5 years with omrs and im still not platinum ? (disapointed :P) |
| 12:41:13 | <dkayiwa> suranga: who says so? :) |
| 12:42:22 | *** djadmin has joined #openmrs |
| 12:52:48 | *** goutham has joined #openmrs |
| 12:55:58 | *** djadmin has quit IRC |
| 12:57:39 | <kavuri> rafa: what needs to be fixed in the unit testcases, for example, "Fix EncounterControllerTest" |
| 12:58:31 | <rafa> kavuri: the code needs to be uncommented and you need to call handle() instead of a method on a controller |
| 12:58:37 | <rafa> kavuri: we removed controllers |
| 13:00:45 | <kavuri> rafa: ok |
| 13:05:30 | *** k-joseph has joined #openmrs |
| 13:07:52 | <k-joseph> dkayiwa: hi |
| 13:21:36 | <dkayiwa> k-joseph: hi |
| 13:26:28 | <jkeiper> anyone know when 1.10 might come out? |
| 13:26:30 | <k-joseph> dkayiwa:hi,am importing the code now into eclipse, |
| 13:26:39 | <dkayiwa> k-joseph: ok |
| 13:28:02 | *** suranga__ has joined #openmrs |
| 13:29:17 | <k-joseph> dkayiwa: still the code has lots of errors, from eclipse |
| 13:29:29 | <k-joseph> dkayiwa: the cloned one |
| 13:29:58 | <dkayiwa> k-joseph: and at command line mvn clean intall |
| 13:31:15 | *** suranga_ has quit IRC |
| 13:31:16 | *** suranga has quit IRC |
| 13:31:59 | *** suranga has joined #openmrs |
| 13:33:55 | *** k-joseph has quit IRC |
| 13:34:01 | *** k_joseph has joined #openmrs |
| 13:39:48 | *** wyclif has quit IRC |
| 13:40:19 | *** k_joseph has quit IRC |
| 13:40:44 | *** kavuri has quit IRC |
| 13:43:46 | *** k-joseph has joined #openmrs |
| 13:44:03 | <k-joseph> dkayiwa: hi |
| 13:44:12 | <dkayiwa> k-joseph: hi |
| 13:44:23 | <k-joseph> dkayiwa: eclipse looks like http://snag.gy/3eq1A.jpg |
| 13:44:31 | *** k_joseph has joined #openmrs |
| 13:45:18 | <dkayiwa> k-joseph: can u expand description and resend |
| 13:49:56 | <k-joseph> dkayiwa: http://pastebin.com/3xh7hnJY http://snag.gy/22UhE.jpg http://snag.gy/qO0VA.jpg |
| 13:50:13 | <dkayiwa> k-joseph: which of those should i take? |
| 13:51:03 | <k-joseph> dkayiwa: all of them, i just couldnt use one sceen shot to capture the whole thing, may be the pastebin link us better |
| 13:52:01 | <dkayiwa> k-joseph: what does mvn clean install do? |
| 13:53:19 | <k-joseph> dkayiwa: it returns http://pastebin.com/yS2VAnRC |
| 13:55:17 | <dkayiwa> k-joseph: which version of maven? |
| 13:55:55 | <k-joseph> dkayiwa: Apache Maven 2.2.1 (rdebian-6) |
| 13:55:55 | <k-joseph> Java version: 1.6.0_24 |
| 13:56:03 | <k-joseph> dkayiwa |
| 13:56:07 | <dkayiwa> k-joseph: use 3 and above |
| 13:59:32 | <dkayiwa> k-joseph: does it make sense? |
| 14:01:09 | <k-joseph> dkayiwa: it does |
| 14:01:14 | <dkayiwa> k-joseph: ok |
| 14:06:41 | *** k-joseph has quit IRC |
| 14:12:28 | *** jkeiper has quit IRC |
| 14:17:01 | *** Anuruddha has joined #openmrs |
| 14:20:03 | *** wyclif has joined #openmrs |
| 14:26:00 | *** djazayeri has joined #openmrs |
| 14:26:00 | *** ChanServ sets mode: +o djazayeri |
| 14:28:07 | *** mseaton has joined #openmrs |
| 14:28:07 | *** ChanServ sets mode: +v mseaton |
| 14:31:12 | *** djazayeri has quit IRC |
| 14:35:35 | *** jb360 has quit IRC |
| 14:36:08 | <dkayiwa> hi rafa |
| 14:36:15 | <rafa> dkayiwa: hi |
| 14:36:31 | <dkayiwa> rafa: do we also back port to ticket Affect Versions? or only Fix Versions? :) |
| 14:37:00 | <dkayiwa> rafa: for instance am looking at TRUNK-3845 |
| 14:37:03 | <dkayiwa> !ticket TRUNK-3845 |
| 14:37:04 | <OpenMRSBot> dkayiwa: [#TRUNK-3845] Short class name in BaseOpenmrsObject toString - OpenMRS JIRA - https://tickets.openmrs.org/browse/TRUNK-3845 |
| 14:37:35 | <rafa> dkayiwa: that doesn't need to be back ported |
| 14:37:42 | <dkayiwa> rafa: ok |
| 14:38:04 | <rafa> dkayiwa: in general you only back port when you see fix versions |
| 14:38:15 | <dkayiwa> rafa: ok thanks! |
| 14:39:18 | <rafa> dkayiwa: but don't take for granted that fix versions are always correct |
| 14:39:29 | <dkayiwa> rafa: ok |
| 14:39:38 | <rafa> dkayiwa: if it's a serious bug and you feel it needs to be back ported then add it to fix versions |
| 14:39:46 | <dkayiwa> rafa: ok |
| 14:41:18 | <dkayiwa> rafa: that ticket uses guava-libraries. There was another ticket i saw where you say that if by the time 1.10 is released, if we see no need for this libraries, we remove them. Won't that affect this ticket too? (and possibly others) |
| 14:42:01 | <rafa> dkayiwa: yes it affects that ticket, but we don't need to take any action |
| 14:42:13 | <dkayiwa> rafa: ok |
| 14:42:19 | <rafa> dkayiwa: I'm pretty sure we will stick with guava ;) |
| 14:42:25 | <dkayiwa> rafa: ok :) |
| 14:42:31 | *** djadmin has joined #openmrs |
| 14:42:43 | *** suranga__ has quit IRC |
| 14:43:08 | *** suranga has quit IRC |
| 14:53:18 | *** hudayanga has joined #openmrs |
| 14:53:28 | *** hudayanga has joined #openmrs |
| 14:53:43 | *** hudayanga has joined #openmrs |
| 14:57:06 | *** hudayanga has quit IRC |
| 14:59:13 | *** djazayeri has joined #openmrs |
| 14:59:13 | *** ChanServ sets mode: +o djazayeri |
| 15:03:20 | *** andrea has joined #openmrs |
| 15:03:42 | *** andrea is now known as Guest52262 |
| 15:04:16 | *** Guest52262 is now known as andrea_ |
| 15:04:42 | *** andrea_ is now known as andreap_ |
| 15:08:10 | <andreap_> where is cpower? |
| 15:08:26 | <rafa> right, let's scrum |
| 15:08:33 | <rafa> !scrumon rafa |
| 15:08:33 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster rafa- you may begin when ready. |
| 15:08:52 | *** cpower has joined #openmrs |
| 15:08:57 | *** djadmin has quit IRC |
| 15:09:04 | <rafa> order: andreap_, rafa, wyclif, andreap_, dkayiwa, djazayeri, and anyone intersted |
| 15:09:15 | <rafa> cpower: I've already started the scrum meeting |
| 15:09:50 | <andreap_> Thursday |
| 15:09:51 | <andreap_> Design Call |
| 15:09:51 | <andreap_> Fixed more failing tests in REST-322 Fix ConceptClassControllerTest |
| 15:09:51 | <andreap_> Replaced shouldRetireAConceptClass() but is failing - don't know why. |
| 15:09:51 | <andreap_> Friday |
| 15:09:51 | <andreap_> 2 tests that need to be replaced with new ones. And |
| 15:09:51 | <rafa> andreap_: sorry I put you twice, you go first |
| 15:09:53 | <andreap_> shouldNotIncludeTheAuditInfoForTheDefaultRepresentation() |
| 15:09:55 | <andreap_> shouldNotIncludeTheAuditInfoForTheDefaultRepresentation() |
| 15:09:57 | <andreap_> Blocker |
| 15:09:59 | <andreap_> Run as JUNIT test not working in Eclipse |
| 15:10:15 | <rafa> Yesterday: |
| 15:10:15 | <rafa> * Reviewed and merged code |
| 15:10:15 | <rafa> * Dev Call |
| 15:10:15 | <rafa> * Cleanup in tests |
| 15:10:15 | <rafa> Today: |
| 15:10:16 | <rafa> * Reviewed and merged code |
| 15:10:16 | <rafa> * Started with RESTWS-355: Add ConceptReferenceTermMapResource and ConceptReferenceTermMapController |
| 15:10:17 | <rafa> https://tickets.openmrs.org/browse/RESTWS-355 |
| 15:10:17 | <rafa> Blockers: |
| 15:10:18 | <rafa> * I've caught a cold :( worked half day and need to step away. I'll do something over the weekend if I feel better. |
| 15:10:38 | <dkayiwa> sorry man!!! |
| 15:10:50 | <wyclif> Thursday: |
| 15:10:50 | <wyclif> dev call |
| 15:10:50 | <wyclif> Creating/linking sub tickets for RESTWS-267 - Need to expose concept_source |
| 15:10:50 | <wyclif> Review code for RESTWS-309 - Merge webservices.rest and webservices.rest19ext modules into one |
| 15:10:50 | <wyclif> RESTWS-353 - Add ConceptMapTypeResource and ConceptMapTypeController |
| 15:10:51 | <wyclif> RESTWS-354 - Add ConceptReferenceTermResource and ConceptReferenceTermController |
| 15:10:55 | <wyclif> Worked with Andrea on RESTWS-322 - Fix ConceptClassControllerTest |
| 15:10:57 | <wyclif> |
| 15:10:59 | <wyclif> Friday |
| 15:11:01 | <wyclif> Edit Serachable interface and update subclasses as suggested for RESTWS-267 |
| 15:11:03 | <wyclif> pick another sprint ticket |
| 15:11:05 | <wyclif> |
| 15:11:07 | <wyclif> Blockers: None |
| 15:11:12 | <dkayiwa> Reviewed and closed: Date Picker: Monday as start of the week - TRUNK-2776 |
| 15:11:12 | <andreap_> rafa, sorry about your cold - feel better |
| 15:11:13 | <dkayiwa> Reviewed and closed: Upgrade to the latest stable release of jquery - TRUNK-3054 |
| 15:11:13 | <dkayiwa> Closed: TRUNK-2467, TRUNK-2732, TRUNK-2548, TRUNK-2554, TRUNK-2556, TRUNK-2509 |
| 15:11:13 | <dkayiwa> Looked at: TRUNK-2467 |
| 15:11:14 | <dkayiwa> Reviewed and closed: Remove $ reference in jsp code - TRUNK-3408 |
| 15:11:14 | <dkayiwa> Reviewed: Upgrade xstream to 1.4.3 - TRUNK-3875 |
| 15:11:14 | <dkayiwa> Reviewed: Add WebUtil.getContextPath() - TRUNK-3615 |
| 15:11:15 | <dkayiwa> Reviewed: Add Patient.getPerson() so people can start programming defensively for a day when patient and person are not 1:1 - TRUNK-3656 |
| 15:11:15 | <dkayiwa> Reviewed and closed: Update module documentation to refer to github - TRUNK-3605 |
| 15:11:15 | <dkayiwa> Reviewed and closed: Short class name in BaseOpenmrsObject toString -TRUNK-3845 |
| 15:11:16 | <dkayiwa> Now back porting: Deleting a patient should not require name and identifier - TRUNK-3846 |
| 15:11:16 | <dkayiwa> No Blockers |
| 15:12:07 | <rafa> djazayeri: hi, anything to share? |
| 15:12:17 | *** jkeiper has joined #openmrs |
| 15:12:17 | *** ChanServ sets mode: +v jkeiper |
| 15:12:28 | <djazayeri> Nothing about RESTWS. On a call with some TWers about working on App Framework and Reference Application |
| 15:12:30 | <djazayeri> no blockers |
| 15:12:48 | <rafa> cpower: want to wrap up? |
| 15:13:34 | <andreap_> rafa, feel better |
| 15:14:09 | <rafa> okay, so I'll do it. andreap_ has one blocker with junit. andreap_ are you in position to pair right after the scrum? |
| 15:14:24 | <rafa> andreap_: thanks! |
| 15:14:27 | <andreap_> rafam yes |
| 15:14:40 | <andreap_> rafa, yes on Adobe connect? |
| 15:14:47 | <rafa> andreap_: sure |
| 15:14:53 | <rafa> ok thanks everyone! |
| 15:15:01 | <rafa> !scrumoff |
| 15:15:01 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 15:15:59 | <rafa> andreap_: please join http://connect.iu.edu/omrsu/ |
| 15:16:11 | <cpower> lol thanks guys meeting ran long |
| 15:16:14 | <cpower> good work |
| 15:16:34 | <andreap_> rafa, whoops do I need IE? |
| 15:16:41 | <rafa> IE or firefox |
| 15:16:54 | <andreap_> rafa, I am there in chrome |
| 15:17:07 | *** goutham has quit IRC |
| 15:17:16 | <rafa> andreap_: you can't share your screen from chrome so switch |
| 15:18:19 | <andreap_> rafa ok now I share my screen? |
| 15:18:27 | <rafa> andreap_: yes |
| 15:18:54 | <andreap_> rafa: can u see my screen? |
| 15:19:07 | <rafa> andreap_: yes |
| 15:19:22 | <rafa> andreap_: you don't hear me, do you? |
| 15:19:45 | <andreap_> rafa, I did hear you |
| 15:20:02 | <rafa> andreap_: ok perfect, so I'll just talk |
| 15:28:16 | *** djadmin has joined #openmrs |
| 15:32:05 | <jkeiper> anyone know when 1.10 might come out? |
| 15:39:02 | <wyclif> hi rafa djadmin |
| 15:39:10 | <wyclif> hi rafa djazayeri |
| 15:39:18 | <wyclif> hi rafa and djazayeri |
| 15:40:07 | <wyclif> rafa, djazayeri i thought sessionid is a cooke and not a request param |
| 15:40:17 | *** Anuruddha_ has joined #openmrs |
| 15:40:56 | *** dkayiwa has quit IRC |
| 15:41:32 | <djazayeri> wyclif: I believe that Java EE supports not having cookies enabled, if you include something like jsessionid as a request parameter |
| 15:41:45 | <djazayeri> wyclif: also, I think that at first login, sometimes there's a jsessionid request parameter |
| 15:42:17 | <wyclif> djazayeri, sometimes i see it |
| 15:43:00 | <wyclif> djazayeri, so we need to support both the cookie and param, right? |
| 15:43:07 | <djazayeri> wyclif: anyway, I think the point is that we should treat jsessionid (or whatever it's actual spelling and capitalization is) as a special parameter, that's not part of the rest request |
| 15:43:23 | <djazayeri> wyclif: is this in the ticket about deciding deciding what's a search and what's a getAll? |
| 15:43:32 | <wyclif> djazayeri, yes |
| 15:44:20 | <djazayeri> wyclif: I'm assuming someone made the comment because it's a meaningful issue, so I say we just add jsessionid to the special parameter list. |
| 16:00:53 | <wyclif> djazayeri, ok |
| 16:01:20 | <wyclif> djazayeri, why dont we add the query to the request context so that resources dont have to keep calling context.getRequest().getParameter("q") |
| 16:01:38 | <wyclif> djazayeri, so that we just have context.getQuery() |
| 16:05:49 | *** Anuruddha has quit IRC |
| 16:05:55 | <djazayeri> wyclif: because lots of queries don't have a meaningful "q" value. So it's not a special parameter in code, just by convention |
| 16:06:22 | <djazayeri> wyclif: did rafa say to get rid of the HttpServletRequest, and just have Context? |
| 16:07:18 | <djazayeri> wyclif, rafa: if we're doing that, let's make sure that context.getParameter(String) delegates to getting a parameter from the request. |
| 16:07:20 | <wyclif> djazayeri, the request was never ever part of the arguments, it is set on the context |
| 16:07:34 | <djazayeri> wyclif: really? Okay. |
| 16:07:56 | *** djadmin has quit IRC |
| 16:08:17 | <wyclif> djazayeri, there is no context.getParameter method, unless you are suggesting we add it |
| 16:08:28 | <djazayeri> wyclif: yes, I'm suggesting we add it. |
| 16:08:34 | <wyclif> djazayeri, pok |
| 16:08:58 | <djazayeri> wyclif: your point is correct, that it's inconvenient to have to say context.getRequest().getParameter("q") |
| 16:10:02 | <djazayeri> wyclif: so let's add a convenience method, for *all* parameters |
| 16:10:28 | <djazayeri> wyclif: it might be even better to also support context.getParameter(String name, Class asType) |
| 16:11:29 | *** djadmin has joined #openmrs |
| 16:11:37 | <rafa> andreap_: I've disconnected |
| 16:11:46 | <rafa> andreap_: are you all good now? |
| 16:14:22 | <andreap_> rafa, thanks! |
| 16:14:34 | <andreap_> rafa, yes I'm good |
| 16:15:18 | <rafa> andreap_: clean it up and do pull request |
| 16:15:22 | <rafa> andreap_: move to another ticket |
| 16:17:23 | <andreap_> rafa, will do |
| 16:22:25 | *** djadmin has quit IRC |
| 16:24:02 | *** djazayeri1 has joined #openmrs |
| 16:24:03 | *** djazayeri has quit IRC |
| 16:32:07 | *** Anuruddha_ is now known as apremalal |
| 16:38:55 | *** bhashitha has joined #openmrs |
| 16:50:58 | *** Taco_ has joined #openmrs |
| 16:51:55 | <Taco_> hello |
| 16:53:11 | <Taco_> ? |
| 16:55:37 | *** djadmin has joined #openmrs |
| 16:57:03 | *** rfriedman has joined #openmrs |
| 16:57:54 | <rfriedman> rafa, i am doing a git fetch from the sprint branch but it is not finding any updates even though i last downloaded last week. is something wrong? |
| 16:58:10 | <rafa> rfriedman: probably |
| 16:58:22 | <rafa> rfriedman: are you doing git fetch from upstream? |
| 16:58:31 | <rafa> rfriedman: actually why fetch and not just pull? |
| 16:59:03 | <rafa> Taco_: welcome |
| 17:00:34 | <rfriedman> rafa, i think it may be fetching from master, how do i make it fetch from upstream? |
| 17:00:54 | <rafa> rfriedman: normally you just do git pull --rebase upstream sprint-201302 |
| 17:01:09 | <rafa> rfriedman: assuming you have sprint-201302 checked out |
| 17:02:57 | *** help has joined #openmrs |
| 17:03:05 | *** help is now known as Guest85281 |
| 17:06:23 | *** ChanServ sets mode: +o Guest85281 |
| 17:06:39 | *** Guest85281 is now known as burke |
| 17:08:02 | *** burke has quit IRC |
| 17:08:04 | <rfriedman> rafa, i do have it checked out. however, when i try your pull command i get this: |
| 17:08:09 | <rfriedman> fatal: 'upstream' does not appear to be a git repository |
| 17:08:09 | <rfriedman> fatal: The remote end hung up unexpectedly |
| 17:08:28 | <rafa> rfriedman: type "git remote -v" and give me the output |
| 17:09:00 | <rfriedman> origin https://github.com/r-friedman/openmrs-module-webservices.rest.git (fetch) |
| 17:09:00 | <rfriedman> origin https://github.com/r-friedman/openmrs-module-webservices.rest.git (push) |
| 17:09:06 | <OpenMRSBot> <http://ln-s.net/+dhh> (at github.com) |
| 17:09:07 | <OpenMRSBot> <http://ln-s.net/+dhh> (at github.com) |
| 17:09:25 | <rafa> rfriedman: you didn't add upstream |
| 17:09:54 | <rafa> rfriedman: git remote add upstream https://github.com/openmrs/openmrs-module-webservices.rest.git |
| 17:09:57 | <OpenMRSBot> <http://ln-s.net/+dhi> (at github.com) |
| 17:10:40 | <rafa> rfriedman: then do the pull |
| 17:12:47 | <rfriedman> ok, that seems to have worked, tks |
| 17:13:36 | *** djazayeri has joined #openmrs |
| 17:13:36 | *** ChanServ sets mode: +o djazayeri |
| 17:13:36 | *** djazayeri1 has quit IRC |
| 17:15:02 | *** hybridivy has joined #openmrs |
| 17:17:40 | <rfriedman> rafa, wyclif, so either of the 2 problems i mention in 320 (parameters don't correspond to a search, parameter value not of expected type or out of range) should throw a RestClient Exception |
| 17:20:44 | <Taco_> does anyone know how to connect to the openmrs-standalone database from something like mysql navigator, or sql developer? I have tried the default values: host:localhost, port:3316, usr:admin, pass:test...anyone done this before? |
| 17:22:20 | *** djazayeri1 has joined #openmrs |
| 17:22:21 | *** djazayeri has quit IRC |
| 17:23:36 | <rfriedman> Taco_, is your standalone running? |
| 17:24:27 | <Taco_> yes |
| 17:25:00 | <rfriedman> Taco_, ok, look in your standalone directory for the runtime.properties file |
| 17:26:39 | <rfriedman> Taco_, it probably has a name like openmrs-standalone-runtime.properties |
| 17:26:48 | <Taco_> ah, yes i have found it |
| 17:26:57 | <rfriedman> ok, open in a text editor |
| 17:27:09 | <Taco_> yes let me try these settings |
| 17:27:22 | <rfriedman> should work, i do it with mysql workbench all the time |
| 17:27:39 | <Taco_> okay perfect. thank you so much |
| 17:27:52 | <rfriedman> Taco_, np, good luck |
| 17:31:28 | <wyclif> rafa, does restws start for you? |
| 17:31:53 | <rafa> wyclif: haven't tried for a day or two |
| 17:33:17 | <wyclif> rafa, it doesnt start, i think resources that have the same name e.g those with variations in 1.9 need to have an order value |
| 17:34:00 | <rafa> wyclif: it shouldn't be necessary if those for 1.8 have supportedOpenmrsVersion="1.8.*" defined |
| 17:34:12 | <wyclif> rafa, i can make the change and commit, what is the default order value, because i need to set a higher one for *1_9 resources |
| 17:34:56 | <wyclif> rafa, apparently that doesnt work |
| 17:34:57 | <rafa> wyclif: the order shouldn't be necessary |
| 17:35:34 | <rafa> wyclif: ok let me test |
| 17:35:44 | <wyclif> see the RestServiceImpl line 127 |
| 17:36:04 | <wyclif> rafa, it throws an exception if the order is the same |
| 17:36:42 | <rafa> wyclif: but there should be no resources which support the same type |
| 17:36:42 | *** mseaton1 has joined #openmrs |
| 17:36:55 | <rafa> wyclif: sorry there should be no 2 resources which support the same type |
| 17:37:23 | <rafa> wyclif: it means one is unnecessarily instantiated |
| 17:37:33 | <rafa> wyclif: just hold on |
| 17:37:36 | <rafa> wyclif: I test |
| 17:37:39 | *** mseaton has quit IRC |
| 17:37:48 | <rfriedman> rafa, wyclif, so either of the 2 problems i mention in 320 (parameters don't correspond to a search, parameter value not of expected type or out of range) should throw a RestClient Exception |
| 17:40:17 | <jkeiper> anyone know when 1.10 might come out? |
| 17:40:49 | <wyclif> not sure |
| 17:40:56 | <jkeiper> finally, an answer! |
| 17:40:56 | *** apremalal has quit IRC |
| 17:42:29 | <rfriedman> i heard a rumor it's arriving on the asteroid, jkeiper |
| 17:42:42 | <jkeiper> phew |
| 17:42:50 | <jkeiper> something to depend on |
| 17:42:51 | <jkeiper> :-D |
| 17:43:07 | <rafa> rfriedman: we can have an exception ;) |
| 17:43:32 | <rafa> jkeiper: I know that 1.9.3 will be soon |
| 17:43:50 | <rafa> jkeiper: in a month or two |
| 17:44:18 | <rfriedman> rafa, i know the exception exists, i just want to know if it's the right exception to throw or if we need a new exception type |
| 17:44:21 | <jkeiper> rafa, ok ... asking because AMPATH is wondering about timeframe, whether it is better to upgrade to 1.9 or 1.10 |
| 17:44:28 | <jkeiper> trying to plan |
| 17:45:03 | <rafa> jkeiper: cpower is probably the person to ask, he plans sprints |
| 17:45:13 | <rafa> jkeiper: a work around orders need to be completed before 1.10 is out |
| 17:45:15 | <jkeiper> rafa, k |
| 17:45:21 | <jkeiper> i see |
| 17:45:30 | <rafa> jkeiper: I'd also like new concept search in there |
| 17:45:49 | <rafa> jkeiper: but that can wait after 1.10 since nothing was merged |
| 17:46:00 | <jkeiper> rafa, ah |
| 17:46:05 | <jkeiper> rafa, lucene-based? |
| 17:46:09 | <rafa> jkeiper: yes |
| 17:46:14 | <jkeiper> rafa, yesssssssss |
| 17:47:01 | <rfriedman> jkeiper, you can thank me too, i annoyed them until they agreed to do it |
| 17:47:20 | <jkeiper> rfriedman, haha thanks |
| 17:47:41 | <rafa> haha |
| 17:48:00 | <rafa> rfriedman: I don't know about the exception |
| 17:48:52 | <rafa> rfriedman: ResourceDoesNotSupportOperationException sounds right |
| 17:50:38 | <rfriedman> rafa, i just noticed RestClientException is sping, not us |
| 17:50:51 | <rfriedman> psring |
| 17:50:53 | <rfriedman> spring |
| 18:00:16 | <rafa> wyclif: when I try to load an omod from the lastest code it hangs OpenMRS. No error. Not sure what happens... |
| 18:00:52 | <wyclif> rafa, hmm... |
| 18:01:27 | <wyclif> everything works for me just that it complains there are multiple resources with same name and order |
| 18:01:37 | <rafa> wyclif: do you know which? |
| 18:02:28 | <wyclif> location and encounter |
| 18:03:25 | <rafa> wyclif: strange |
| 18:03:49 | <rafa> wyclif: it worked for me before |
| 18:04:12 | <rafa> wyclif: and works in tests |
| 18:04:30 | <rafa> wyclif: are you running openmrs with jetty? |
| 18:04:44 | <wyclif> rafa, yes |
| 18:05:07 | <rafa> wyclif: can you check that OpenmrsContstants.OPENMRS_VERSION_SHORT is not null? |
| 18:05:11 | <wyclif> rafa, it works in tests |
| 18:05:17 | <rafa> in RestServiceImpl line 85 |
| 18:05:53 | <rafa> or 106 |
| 18:06:32 | <rafa> wyclif: will look into this later |
| 18:06:56 | <rafa> wyclif: I don't think clear right now |
| 18:07:07 | <rafa> wyclif: need to rest |
| 18:07:29 | <rafa> have a nice weekend! |
| 18:07:35 | <wyclif> rafa, i think i got it |
| 18:07:56 | <wyclif> rafa, it is because of OpenmrsContstants.OPENMRS_VERSION_SHOR being null in jetty |
| 18:08:02 | <wyclif> rafa, thanks |
| 18:08:07 | <wyclif> rafa, nice weekend too! |
| 18:08:25 | <rafa> wyclif: right, I always tested it with standalone |
| 18:10:51 | *** apb156 has joined #openmrs |
| 18:16:11 | *** mseaton has joined #openmrs |
| 18:16:11 | *** ChanServ sets mode: +v mseaton |
| 18:17:20 | *** GitHub193 has joined #openmrs |
| 18:17:20 | <GitHub193> [openmrs-core] bhashitha opened pull request #216: Fix for TRUNK-3836 (master...TRUNK-3836) http://git.io/ZvLz2g |
| 18:17:20 | *** GitHub193 has left #openmrs |
| 18:19:15 | *** mseaton1 has quit IRC |
| 18:22:39 | *** bhashitha has quit IRC |
| 18:25:02 | *** rfriedman has quit IRC |
| 18:30:01 | *** djadmin has quit IRC |
| 18:32:48 | *** djazayeri1 has quit IRC |
| 19:00:47 | *** apb156 has quit IRC |
| 19:18:17 | *** hybridivy has quit IRC |
| 19:24:27 | *** kishoreyekkanti has joined #openmrs |
| 19:31:32 | *** rafa has quit IRC |
| 19:32:05 | <jkeiper> Taco_, is your password "Taco"? |
| 19:42:34 | *** harshadura has joined #openmrs |
| 19:46:05 | *** mseaton has quit IRC |
| 19:54:58 | *** djazayeri has joined #openmrs |
| 19:54:58 | *** ChanServ sets mode: +o djazayeri |
| 19:55:49 | *** djazayeri has quit IRC |
| 20:02:06 | *** apb156 has joined #openmrs |
| 20:02:13 | *** kishoreyekkanti has quit IRC |
| 20:11:42 | <andreap_> jkeiper, wyclif - can anyone help with git error on push? |
| 20:12:37 | <wyclif> andreap_, what aeror are you getting? |
| 20:12:45 | <wyclif> andreap_, what error are you getting? |
| 20:13:33 | *** harshadura has quit IRC |
| 20:14:50 | <andreap_> wyclif, hi: error: The requested URL returned error: 403 while accessing https://github.com/ |
| 20:14:50 | <andreap_> openmrs/openmrs-module-webservices.rest.git/info/refs |
| 20:14:50 | <andreap_> fatal: HTTP request failed |
| 20:15:34 | <andreap_> wyclif, did git remote -v - all looks good |
| 20:16:00 | <andreap_> wyclif: git remote -v |
| 20:16:01 | <andreap_> origin https://github.com/andreapat/openmrs-module-webservices.rest.git (fetch) |
| 20:16:01 | <andreap_> origin https://github.com/andreapat/openmrs-module-webservices.rest.git (push) |
| 20:16:01 | <andreap_> upstream https://github.com/openmrs/openmrs-module-webservices.rest.git ( |
| 20:16:01 | <andreap_> fetch) |
| 20:16:01 | <andreap_> upstream https://github.com/openmrs/openmrs-module-webservices.rest.git ( |
| 20:16:03 | <andreap_> push) |
| 20:16:08 | <OpenMRSBot> <http://ln-s.net/+dko> (at github.com) |
| 20:16:09 | <OpenMRSBot> <http://ln-s.net/+dko> (at github.com) |
| 20:16:10 | <OpenMRSBot> <http://ln-s.net/+dhi> (at github.com) |
| 20:16:11 | <OpenMRSBot> <http://ln-s.net/+dhi> (at github.com) |
| 20:26:05 | *** Taco_ has quit IRC |
| 20:30:46 | <wyclif> andreap_, did you solve it? |
| 20:32:46 | <wyclif> andreap_, http code 403 means you are forbidden from pushing there, you probably have no commit privileges |
| 20:33:12 | <andreap_> wyclif: how would that happen? |
| 20:33:43 | <andreap_> wyclif: have never had this problem before |
| 20:33:48 | <wyclif> andreap_, i would say fork the module's repo on github, push to your repo and send a pull request so that someone else merges it for you |
| 20:34:09 | <wyclif> andreap_, becase you always push to your own repos |
| 20:34:18 | <wyclif> andreap_, where are you pushing to? |
| 20:34:49 | <andreap_> wyclif: https://andreapat@github.com |
| 20:35:58 | <wyclif> andreap_, and how are you pushing, with which command? |
| 20:36:25 | <andreap_> wyclif: git push and tried git push -f |
| 20:36:33 | <wyclif> andreap_, that is wrong |
| 20:36:54 | <wyclif> andreap_, you always have to specify a branch you are push to |
| 20:36:57 | <andreap_> wyclif: why? |
| 20:38:12 | <andreap_> wyclif: this is what I always do after commit (from workspace/openmrs-module-webservices.rest) |
| 20:38:16 | <wyclif> andreap_, with that it means you are pushing to all local changes in your repo to all branchses which probably includes openmrs/master that you have no priv too probably |
| 20:39:08 | <wyclif> andreap_, it is wrong, it has only been working because you probably have always been cloning projects from your forks and have no changes |
| 20:39:20 | <wyclif> andreap_, which is your upstream and origin? |
| 20:40:38 | <wyclif> andreap_, what do you see when you do git remote -v |
| 20:40:40 | <andreap_> wyclif: from git remote remote -v origin https://github.com/andreapat/openmrs-module-webservices.rest.git (push) |
| 20:40:40 | <andreap_> upstream https://github.com/openmrs/openmrs-module-webservices.rest.git ( |
| 20:40:40 | <OpenMRSBot> <http://ln-s.net/+dko> (at github.com) |
| 20:40:40 | <andreap_> fetch) |
| 20:40:41 | <OpenMRSBot> <http://ln-s.net/+dhi> (at github.com) |
| 20:41:10 | <andreap_> wyclif, looks ok - doesn't it? |
| 20:41:54 | <andreap_> wyclif here's git remote -v: |
| 20:41:54 | <wyclif> andreap_, and what is your branch name? is it sprint 201302 |
| 20:42:16 | <andreap_> wyclif: $ git remote -v |
| 20:42:16 | <andreap_> origin https://github.com/andreapat/openmrs-module-webservices.rest.git (fetch) |
| 20:42:16 | <andreap_> origin https://github.com/andreapat/openmrs-module-webservices.rest.git (push) |
| 20:42:16 | <andreap_> upstream https://github.com/openmrs/openmrs-module-webservices.rest.git ( |
| 20:42:16 | <andreap_> fetch) |
| 20:42:16 | <OpenMRSBot> <http://ln-s.net/+dko> (at github.com) |
| 20:42:17 | <andreap_> upstream https://github.com/openmrs/openmrs-module-webservices.rest.git ( |
| 20:42:18 | <OpenMRSBot> <http://ln-s.net/+dhi> (at github.com) |
| 20:42:19 | <andreap_> push) |
| 20:43:08 | <andreap_> wyclif, yes branch name is: sprint-201302 |
| 20:43:24 | <wyclif> so can you try git push origin sprint-201302 |
| 20:43:31 | <wyclif> andreap_, so can you try git push origin sprint-201302 |
| 20:43:50 | <andreap_> wyclif, will try |
| 20:44:23 | <wyclif> andreap_, make sure you have first run git pull --rebase upstream sprint-201302 first |
| 20:44:59 | <andreap_> wyclif, that worked |
| 20:45:38 | <andreap_> wyclif, never had to do that befor - even on Rafal's instructions it says: git push -f |
| 20:46:22 | <andreap_> wyclif, did git pull --rebase upstream sprint-201302 first |
| 20:46:32 | <andreap_> wyclif - thanks! |
| 20:47:09 | <andreap_> wyclif: one more think - where is link to RESTWS tickets that still meed to be done |
| 20:49:44 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Provider Management Module 1.1.3 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=providermanagement&version=&1.1.3> |
| 20:52:08 | <wyclif> andreap_, it is good practice to always specify the a combination of source(origin vs upstream) and branch name you are pulling from or pushing to otherwise you will screw up your local repo or get strange errors |
| 20:53:43 | <andreap_> wyclif, ok got ya |
| 20:53:59 | <wyclif> andreap_, the link is here https://tickets.openmrs.org/secure/RapidBoard.jspa?rapidView=25 you kind always find it on the sprint page, you can find the sprint page on the sprint schedule page |
| 20:54:45 | <andreap_> wyclif, thanks again |
| 20:56:21 | <wyclif> andreap_, i always just do a google search for "openmrs sprint schedule" to find the sprint schedule wiki and this is where you will find the current sprint's wiki page |
| 20:56:41 | *** djazayeri has joined #openmrs |
| 20:56:44 | *** ChanServ sets mode: +o djazayeri |
| 20:56:54 | <andreap_> ok - was missing "schedule" - thanks! |
| 21:00:52 | <wyclif> hi djazayeri was intentional on the rest ws wiki page at https://wiki.openmrs.org/display/docs/REST+Web+Service+Resources to say that for both !purge and purge urls the object gets deleted from the DB instead of saying that one just retires/voids it |
| 21:00:53 | <OpenMRSBot> <http://ln-s.net/8z-a> (at wiki.openmrs.org) |
| 21:01:12 | <djazayeri> wyclif: nope |
| 21:01:30 | *** apb156 has quit IRC |
| 21:01:45 | <wyclif> djazayeri, ok thanks |
| 21:02:09 | <wyclif> djazayeri, that means it should be retire/void for !purge |
| 21:03:50 | *** apb156 has joined #openmrs |
| 21:06:23 | *** mseaton has joined #openmrs |
| 21:06:23 | *** ChanServ sets mode: +v mseaton |
| 21:06:34 | *** mseaton has left #openmrs |
| 21:49:57 | <OpenMRSBot> Recent updates in the world of openmrs: OpenMRS Modules: Patient Summary 2.0 uploaded to OpenMRS Module Repository <https://modules.openmrs.org/modules/view.jsp?module=patientsummary&version=&2.0> |
| 21:50:59 | *** djazayeri has quit IRC |
| 21:54:19 | <wyclif> andreap_, what was the problem with the concept class tests? |
| 21:54:22 | *** cpower has quit IRC |
| 21:54:26 | *** djazayeri has joined #openmrs |
| 21:54:26 | *** ChanServ sets mode: +o djazayeri |
| 22:01:51 | *** cpower has joined #openmrs |
| 22:03:40 | *** jkeiper has quit IRC |
| 22:03:44 | *** djazayeri has quit IRC |
| 22:06:52 | <andreap_> wyclif: shouldRetireAConceptClass had a null pointer exception - couldn't find uuid |
| 22:07:37 | <andreap_> wyclif: got run as -> JUNIT test working - musch better |
| 22:08:10 | <wyclif> andreap_, cool |
| 22:08:26 | <wyclif> andreap_, seeing error logs is helpful |
| 22:09:04 | <andreap_> wyclif, yeah - again wish our pairing session hadn't been cut short - all would have been much smoother |
| 22:09:50 | <andreap_> wyclif, yes error logs help a lot |
| 22:10:31 | <andreap_> Wycliff, working on RESTWS-333 now |
| 22:10:47 | <wyclif> andreap_, cool |
| 22:33:21 | *** lh has quit IRC |
| 22:50:10 | *** wyclif has quit IRC |
| 23:33:22 | *** wyclif has joined #openmrs |
