| 01:03:24 | *** mseaton has joined #openmrs |
| 01:03:24 | *** ChanServ sets mode: +v mseaton |
| 02:02:32 | *** rkorytkowski has joined #openmrs |
| 02:02:32 | *** rkorytkowski is now known as rafa |
| 02:02:32 | *** ChanServ sets mode: +v rafa |
| 02:04:31 | *** wyclif has quit IRC |
| 02:07:18 | *** wyclif has joined #openmrs |
| 02:12:53 | *** andreap_ has quit IRC |
| 02:26:00 | *** wyclif_ has joined #openmrs |
| 02:26:00 | *** wyclif has quit IRC |
| 02:26:53 | *** rafa has quit IRC |
| 02:30:20 | *** wyclif has joined #openmrs |
| 02:30:20 | *** wyclif_ has quit IRC |
| 02:52:13 | *** mseaton has quit IRC |
| 03:16:25 | *** mseaton has joined #openmrs |
| 03:16:25 | *** ChanServ sets mode: +v mseaton |
| 03:25:22 | *** djadmin has joined #openmrs |
| 03:29:57 | *** djadmin has quit IRC |
| 03:41:00 | *** djadmin has joined #openmrs |
| 04:01:53 | *** Dheeraj has joined #openmrs |
| 04:03:09 | *** Dheeraj has quit IRC |
| 04:03:43 | <djadmin> Hello ! Is anyone up there? |
| 04:05:35 | *** djadmin has quit IRC |
| 04:05:59 | *** djadmin has joined #openmrs |
| 04:09:44 | *** jkeiper has joined #openmrs |
| 04:09:44 | *** ChanServ sets mode: +v jkeiper |
| 04:16:21 | <djadmin> Hello! I'm interested in taking up any projects based on PHP/ JS. Could anyone help me out? |
| 04:27:14 | *** djazayeri has joined #openmrs |
| 04:27:14 | *** ChanServ sets mode: +o djazayeri |
| 04:50:51 | *** mseaton has quit IRC |
| 05:08:47 | *** djadmin has quit IRC |
| 05:20:56 | *** djazayeri has quit IRC |
| 05:55:48 | *** djadmin has joined #openmrs |
| 06:53:48 | *** robbyoconnor has joined #openmrs |
| 06:53:48 | *** ChanServ sets mode: +v robbyoconnor |
| 06:57:36 | *** rowanseymour has joined #openmrs |
| 06:57:39 | *** suranga has joined #openmrs |
| 06:57:39 | *** ChanServ sets mode: +v suranga |
| 07:17:15 | *** djadmin has quit IRC |
| 07:27:55 | *** suranga_ has joined #openmrs |
| 07:30:06 | *** suranga has quit IRC |
| 07:37:37 | *** dkayiwa has joined #openmrs |
| 07:38:48 | *** djadmin has joined #openmrs |
| 07:43:16 | *** djadmin has quit IRC |
| 07:46:10 | *** djadmin has joined #openmrs |
| 08:14:18 | *** suranga_ has quit IRC |
| 08:22:08 | *** rowanseymour has quit IRC |
| 08:33:44 | *** pulasthi7 has joined #openmrs |
| 08:35:34 | *** suranga has joined #openmrs |
| 08:36:11 | <suranga> hi dkayiwa , r u working on the rest sprint ? :) |
| 08:36:18 | <dkayiwa> suranga: no |
| 08:36:34 | <suranga> dkayiwa, woops, no worries, will wait for rafa :) |
| 08:37:00 | <dkayiwa> suranga: 8) |
| 08:37:21 | <suranga> dkayiwa, as usual, i have good and bad news for him :D |
| 08:40:24 | *** magoo_ has joined #openmrs |
| 08:41:04 | <dkayiwa> suranga: he must be used to it :) |
| 08:41:50 | <suranga> dkayiwa, as a rule, I never tell anyone bad news unless I have some sort of good news to add. for example, I have patches for two tickets, but I cant seem to commit them to his branch :P |
| 08:44:13 | <dkayiwa> suranga: thats more good news than bad :) |
| 08:45:29 | *** rowanseymour has joined #openmrs |
| 09:12:31 | *** magoo_ has quit IRC |
| 09:17:08 | *** madhushi has joined #openmrs |
| 09:18:34 | *** pascal` has joined #openmrs |
| 09:18:34 | *** ChanServ sets mode: +v pascal` |
| 09:21:33 | *** dkayiwa has quit IRC |
| 09:23:47 | *** madhushi has quit IRC |
| 09:36:12 | *** pascal` has quit IRC |
| 09:39:21 | *** djadmin has quit IRC |
| 10:08:03 | *** rowanseymour has quit IRC |
| 10:09:33 | *** rkorytkowski has joined #openmrs |
| 10:09:33 | *** ChanServ sets mode: +v rkorytkowski |
| 10:10:08 | *** suranga has quit IRC |
| 10:15:14 | *** suranga has joined #openmrs |
| 10:30:40 | <suranga> hi rkorytkowski , I didnt see you. did you change your nick to hide from us ? :P |
| 10:30:46 | *** rkorytkowski is now known as rafa |
| 10:30:48 | <rafa> :) |
| 10:30:56 | <rafa> suranga: hi |
| 10:30:57 | <suranga> rafa, :P |
| 10:31:08 | <suranga> rafa, i have good news and bad news |
| 10:31:18 | <suranga> rafa, good news: I have two patches for you |
| 10:31:27 | <rafa> suranga: right on! |
| 10:31:33 | <suranga> rafa, bad news : Im having trouble commiting them :( |
| 10:31:53 | <rafa> suranga: okay, let's try to get you out of troubles |
| 10:31:58 | <rafa> suranga: what's the problem? |
| 10:32:18 | <suranga> rafa, i can commit my changes ok, but when i try to push them, it just vanishes. I get an 'everything is upto date' message :( |
| 10:32:32 | <suranga> rafa, i suspect its because I cant checkout the correct sprint branch properly |
| 10:32:46 | <rafa> suranga: do you have teamviewer? |
| 10:32:56 | <suranga> rafa, im afraid not :( |
| 10:33:05 | <rafa> suranga: please download |
| 10:33:14 | <rafa> http://www.teamviewer.com/en/index.aspx |
| 10:33:22 | <suranga> rafa, I suspect its because of this command, which is failing for me : git checkout sprint-201301 |
| 10:33:40 | <suranga> rafa, cool, will do that, and try buzzing you :-) |
| 10:33:54 | <rafa> suranga: probably you need to do git fetch --all first |
| 10:34:10 | <rafa> suranga: but let's try with teamviewer |
| 10:34:21 | <suranga> rafa, im doing that, but when I try the command, I get an 'error pathspec not found' message |
| 10:34:45 | <suranga> rafa, you dont like adobe connect ? :) |
| 10:35:05 | <rafa> suranga: does screen sharing for work you on adobe connec? |
| 10:35:24 | <suranga> hmm.. last i tried was a few months back |
| 10:35:30 | <suranga> rafa, ^ |
| 10:35:41 | <rafa> suranga: I'm fine with adobe connect |
| 10:35:47 | <rafa> join http://connect.iu.edu/omrsu |
| 10:36:31 | <suranga> hang on, will setup in a jiffy :) |
| 10:36:39 | <rafa> jiffy? |
| 10:37:04 | <rafa> ha! didn't hear that before |
| 10:39:38 | <rafa> suranga: are you still there? |
| 10:40:06 | <suranga> rafa, it seems that i have a problem :-( |
| 10:40:14 | <suranga> rafa, sorry |
| 10:40:22 | <rafa> with adobe connect? |
| 10:40:37 | <rafa> suranga: using firefox or chrome? |
| 10:40:51 | <suranga> rafa, chrome, now going to try with firefox |
| 10:41:05 | <rafa> suranga: it doesn't work with chrome ;) |
| 10:44:47 | <suranga> hi rafa can u see my screen now ? :) |
| 10:44:51 | <rafa> suranga: yes, I can |
| 10:44:58 | <suranga> I think you should be able to see the irc right ? |
| 10:45:02 | <rafa> yes |
| 10:45:14 | <suranga> ill now switch to the console, where you can see my commands, and where it has failed |
| 10:45:46 | <rafa> suranga: git checkout sprint-201302 |
| 10:46:08 | <rafa> suranga: you typed sprint-201301 |
| 10:46:35 | <suranga> rafa, sorry, that was a more recent mistake |
| 10:46:41 | <suranga> im afraid its the same with 02 :( |
| 10:46:46 | <rafa> can you try |
| 10:46:47 | <rafa> ? |
| 10:47:08 | <suranga> gaaaahm its workingggg |
| 10:47:16 | <suranga> rafa, Im stupiddddddddddddddddddddddddd |
| 10:47:20 | <rafa> suranga: good |
| 10:47:24 | <rafa> suranga: no |
| 10:47:29 | <rafa> suranga: where you have your code? |
| 10:47:31 | <suranga> im pretty sure I tried it out though... hmmm... :( |
| 10:47:34 | <rafa> suranga: I mean patches? |
| 10:47:57 | <suranga> rafa, ecure in notepad++ , just need to paste and commit |
| 10:47:59 | *** djadmin has joined #openmrs |
| 10:48:08 | <rafa> I see then go to the console and createa a local branch for your ticket |
| 10:48:18 | <rafa> git checkout -b RESTWS-??? |
| 10:48:45 | <suranga> rafa, will go upto the commiting bit, and buzz you :-) |
| 10:49:54 | <rafa> suranga: now run git pull --rebase upstream sprint-201302 |
| 10:50:18 | <suranga> rafa, i still need the git wiki doc for those :P |
| 10:50:25 | <rafa> lol |
| 10:50:52 | <rafa> suranga: all good now you can apply your changes and commit |
| 10:51:42 | <rafa> suranga: if you want to push your branch you need to say: git push origin restws-311 |
| 10:51:49 | *** k-joseph has joined #openmrs |
| 10:52:24 | <suranga> rafa, aha, thats probably the cause to my problem then ? mm... |
| 10:54:18 | <suranga> rafa, shoulnt I do a git commit first ? |
| 10:54:18 | <rafa> suranga: you need to stage changes |
| 10:54:25 | <rafa> suranga: git add -i |
| 10:55:07 | <suranga> it seems that my change has already been committed, it cant seem to find the file now |
| 10:55:11 | <rafa> suranga: did you save? |
| 10:55:42 | <suranga> rafa, on the IDE yes, so it probably went in with the last commit ? |
| 10:55:49 | <suranga> sorry, last push |
| 10:56:01 | <rafa> suranga: type git log |
| 10:56:24 | <rafa> suranga: no you haven't committed anything |
| 10:56:33 | <rafa> did you change the right file? |
| 10:56:56 | <suranga> rafa, apparently not |
| 10:57:05 | <suranga> rafa, terribly sorry, its just me being stupid |
| 10:57:13 | <suranga> I think I see the problem now |
| 10:57:37 | <rafa> suranga: you're too harsh on yourself ;) |
| 10:57:37 | <suranga> rafa, gimme 5 minutes :) |
| 10:57:41 | <rafa> suranga: okay |
| 10:57:58 | <suranga> rafa, im only thankful that I wasnt this stupid at the time I was applying for GSOC in 2011 |
| 10:58:07 | <suranga> :D |
| 10:59:01 | <rafa> suranga: we all have our brains off from time to time ;) |
| 10:59:06 | <rafa> suranga: nothing to worry |
| 10:59:15 | *** k-joseph has quit IRC |
| 10:59:44 | <suranga> rafa, in this case it seems i was suffering from temporary insanity :P |
| 11:00:52 | <suranga> to any potential gsoc students who may see this : <disclaimer>I used to be brighter when I applied for gsoc </disclaimer> |
| 11:02:57 | <rafa> suranga: hahaha |
| 11:09:42 | <suranga> rafa, hm.. just discovered that the command on the wiki page is using sprint-201301, not sprint-201302 |
| 11:09:46 | <suranga> rafa, will fix that now... |
| 11:09:53 | <rafa> suranga: thx |
| 11:10:41 | *** lh has joined #openmrs |
| 11:11:23 | *** rowanseymour has joined #openmrs |
| 11:12:51 | <rafa> suranga: btw I noticed you type in github credentials all the time |
| 11:12:59 | <rafa> suranga: you can store them in a file |
| 11:13:03 | <rafa> see https://confluence.atlassian.com/display/STASH/Permanently+authenticating+with+Git+repositories |
| 11:13:08 | <OpenMRSBot> <http://ln-s.net/+d$A> (at confluence.atlassian.com) |
| 11:13:21 | <suranga> rafa, is this via ssh, that u are referring to ? :) |
| 11:13:36 | <suranga> rafa, aha, i was about to ask for a link. thanks :-) |
| 11:13:37 | <rafa> suranga: Using the .netrc file |
| 11:13:51 | <rafa> suranga: it's the easiest way on Windows |
| 11:27:46 | *** djadmin has quit IRC |
| 11:30:06 | <rafa> suranga: you didn't send a pull request right |
| 11:30:16 | <suranga> rafa, um.. I just did |
| 11:30:26 | <rafa> suranga: you need to pick sprint-201302 as the base |
| 11:30:41 | <suranga> rafa, woooops |
| 11:30:46 | <suranga> um.... didnt we do that ? |
| 11:30:50 | <rafa> suranga: you sent it for master |
| 11:31:13 | <rafa> suranga: try again |
| 11:31:27 | <suranga> rafa, this is specified when im making the branch, right ? |
| 11:31:28 | <suranga> git checkout -b REPORT-123 sprint-201302 |
| 11:31:39 | <suranga> or when im pushing the committed code ? |
| 11:31:41 | <rafa> suranga: no you pick it when sending a pull request |
| 11:31:48 | <rafa> suranga: in github |
| 11:31:50 | <suranga> oooh, sorry sorrry |
| 11:31:56 | <rafa> suranga: no worries |
| 11:45:10 | <suranga> rafa, can you please check if https://github.com/openmrs/openmrs-module-webservices.rest/pull/10 is ok :) |
| 11:45:15 | <OpenMRSBot> <http://ln-s.net/+d$V> (at github.com) |
| 11:45:51 | <rafa> suranga: perfect |
| 11:46:11 | <suranga> rafa, hope the code is perfect too :P\ |
| 11:46:38 | <rafa> suranga: I'll review later |
| 11:47:38 | <suranga> rafa, cool :) |
| 11:48:40 | *** rowanseymour has quit IRC |
| 11:49:26 | *** rowanseymour has joined #openmrs |
| 12:03:15 | *** rowanseymour has quit IRC |
| 12:03:54 | *** rowanseymour has joined #openmrs |
| 12:10:02 | *** kavuri has joined #openmrs |
| 12:22:44 | *** dkayiwa has joined #openmrs |
| 12:27:43 | *** pulasthi7 has quit IRC |
| 12:29:46 | *** kavuri has quit IRC |
| 12:54:35 | *** suranga has quit IRC |
| 12:56:16 | *** jkeiper has quit IRC |
| 13:03:50 | *** rowanseymour has quit IRC |
| 13:11:16 | *** robbyoconnor has quit IRC |
| 13:12:33 | *** rowanseymour has joined #openmrs |
| 13:28:44 | *** jb360 has joined #openmrs |
| 13:35:39 | *** jb360 has quit IRC |
| 13:36:33 | *** wyclif has quit IRC |
| 13:41:08 | *** k-joseph has joined #openmrs |
| 13:42:00 | <k-joseph> dkayiwa: hi |
| 13:47:45 | <dkayiwa> k-joseph: hi |
| 13:57:32 | *** k_joseph has joined #openmrs |
| 13:58:20 | *** k-joseph has quit IRC |
| 14:02:27 | *** k-joseph has joined #openmrs |
| 14:03:00 | *** k_joseph has quit IRC |
| 14:12:58 | *** robbyoconnor has joined #openmrs |
| 14:12:58 | *** ChanServ sets mode: +v robbyoconnor |
| 14:15:15 | *** robbyoconnor has quit IRC |
| 14:19:48 | *** mseaton has joined #openmrs |
| 14:19:48 | *** ChanServ sets mode: +v mseaton |
| 14:20:28 | *** rowanseymour has quit IRC |
| 14:20:28 | *** jkeiper has joined #openmrs |
| 14:20:28 | *** ChanServ sets mode: +v jkeiper |
| 14:22:18 | *** rowanseymour has joined #openmrs |
| 14:23:21 | *** k_joseph has joined #openmrs |
| 14:24:04 | *** k-joseph has quit IRC |
| 14:25:14 | *** wyclif has joined #openmrs |
| 14:27:14 | *** djazayeri has joined #openmrs |
| 14:27:14 | *** ChanServ sets mode: +o djazayeri |
| 14:31:12 | <k_joseph> dkayiwa: am trying to clone openmrs though it is breaking down on the way due to small bundle probs, i think i need to do this on a further more stable connection, on the part of sharing openmrs projects in eclipse, what do you think is the cause for me to miss having git as an option to select? |
| 14:31:27 | *** k_joseph is now known as k-joseph |
| 14:32:07 | *** rowanseymour has quit IRC |
| 14:32:50 | <dkayiwa> k-joseph: so does that mean that cloning no longer gives the other problem? In otherwards the other problem was cause by the wrong url you were using? |
| 14:33:30 | <k-joseph> dkayiwa: yes |
| 14:34:51 | <dkayiwa> k-joseph: did you install the git eclipse plugin? |
| 14:35:37 | <k-joseph> dkayiwa: i installed Egit |
| 14:39:29 | <dkayiwa> k-joseph: can you try update the plugin? |
| 14:40:47 | <k-joseph> dkayiwa: ok, but the update button is not available(i mean it is there but does not allow being pressed) |
| 14:41:41 | <dkayiwa> k-joseph: under eclipse preferences, do you see Team -> Git? |
| 14:42:38 | <k-joseph> dkayiwa: git is not available |
| 14:43:01 | <dkayiwa> k-joseph: can you remove and install the plugin again |
| 14:43:16 | <k-joseph> dkayiwa: ok |
| 14:52:32 | <k-joseph> dkayiwa: that has solved that problem, |
| 14:52:47 | <dkayiwa> k-joseph: ok great |
| 14:53:24 | *** rowanseymour has joined #openmrs |
| 15:05:24 | *** wyclif has quit IRC |
| 15:08:55 | *** mseaton has quit IRC |
| 15:11:30 | *** rowanseymour has quit IRC |
| 15:17:55 | *** wyclif has joined #openmrs |
| 15:19:53 | *** rowanseymour has joined #openmrs |
| 15:24:23 | *** rowanseymour has quit IRC |
| 15:33:02 | *** mseaton has joined #openmrs |
| 15:33:02 | *** ChanServ sets mode: +v mseaton |
| 15:34:24 | *** djadmin has joined #openmrs |
| 15:40:32 | <rafa> wyclif: hey |
| 15:40:39 | <rafa> wyclif: the thing about RESTWS-267 |
| 15:40:43 | <wyclif> hi rafa |
| 15:40:55 | <rafa> wyclif: I can't think of a way to parallelize the work between devs |
| 15:41:02 | <rafa> wyclif: so even if we create sub-tasks |
| 15:41:10 | <rafa> wyclif: we will need to go with them one by one |
| 15:41:21 | <rafa> wyclif: meaning most likely one dev will do it |
| 15:41:47 | <rafa> wyclif: I was hoping you would go for it all! |
| 15:42:00 | <rafa> wyclif: it's either you or me actually |
| 15:42:01 | <wyclif> rafa, correct but you can see that i have worked on concept source without depending on another ticket, someone in this time could have been working on concept map type in the ematime |
| 15:42:24 | <wyclif> rafa, because concept map type and source and not related |
| 15:42:44 | <wyclif> rafa, i undertand some can't be done in parallel |
| 15:43:12 | *** rfriedman has joined #openmrs |
| 15:43:20 | <wyclif> rafa, but it is still nice to break down work into smaller units to promote the idea of committing early |
| 15:43:35 | <rfriedman> wyclif, anything i can do to help with this? |
| 15:43:37 | <rafa> wyclif: Ohh you do can commit early :) |
| 15:43:51 | <rafa> wyclif: how often you need |
| 15:44:25 | <rafa> wyclif: my point is we could parallelize it only between you and me |
| 15:44:32 | <wyclif> rafa, sure |
| 15:44:37 | <rfriedman> probably makes sense, i ended up working on this ticket for a month |
| 15:44:38 | <rafa> wyclif: and it's not really worth it |
| 15:44:55 | <rfriedman> the opposite of frequent commits |
| 15:45:10 | <rafa> wyclif: running into conflicts, etc... |
| 15:45:42 | <rafa> wyclif: if you don't like this ticket anymore I can take it over |
| 15:46:02 | <rafa> wyclif: you could try wih RESTWS-350 for instance |
| 15:46:04 | <wyclif> rafa, i know i didnt read the ticket description well which is my fault, but i just assumed this ticket was mainly about exposing concept resource |
| 15:46:05 | <rfriedman> rafa, we'll give you 2 hours for it |
| 15:46:13 | <rafa> rfriedman: haha :D |
| 15:46:18 | <rafa> rfriedman: you're so generous |
| 15:46:30 | <wyclif> so that means i can continue with something else and assume concept source is done, right rafa |
| 15:46:48 | <rafa> wyclif: right, concept source looks good |
| 15:46:58 | <rafa> wyclif: I can take it over from here |
| 15:47:11 | <rafa> wyclif: and free RESTWS-350 for you if you want |
| 15:48:45 | <rafa> wyclif: if you feel like you need to score more tickets you can go with Fix... test as well :D |
| 15:49:23 | <rafa> wyclif: they are like 20 minutes of work now |
| 15:49:55 | <wyclif> i can can do concept map type as you do concept reference term source |
| 15:50:06 | <wyclif> rafa, i can can do concept map type as you do concept reference term source |
| 15:50:42 | <wyclif> rafa, and then one of us can finish reference terms and mapping since they depend on each other |
| 15:50:54 | <rafa> wyclif: cool |
| 15:51:07 | <rafa> wyclif: would you mind creating these 3 subtasks? |
| 15:51:30 | <wyclif> rafa, i will create the sub tickets and set the depencency |
| 15:51:39 | <rafa> wyclif: perfect, thanks |
| 15:51:52 | <wyclif> rafa, thanks |
| 15:55:55 | *** rfriedman is now known as rfriedman-away |
| 15:55:55 | *** wyclif has quit IRC |
| 15:56:20 | *** wyclif has joined #openmrs |
| 15:59:34 | *** suranga has joined #openmrs |
| 15:59:34 | *** ChanServ sets mode: +v suranga |
| 16:02:00 | <suranga> hi rafa is it a must that we use the new methods that you highlighted in RESTWS-325 ? |
| 16:02:09 | <rafa> suranga: no |
| 16:02:28 | <suranga> rafa, oh, preferred, but not mandatory, right :) |
| 16:02:34 | <rafa> suranga: right |
| 16:13:05 | *** k-joseph has quit IRC |
| 16:13:23 | *** bhashitha has joined #openmrs |
| 16:24:16 | *** djazayeri1 has joined #openmrs |
| 16:24:16 | *** djazayeri has quit IRC |
| 16:27:52 | *** djadmin has quit IRC |
| 16:28:31 | *** djadmin has joined #openmrs |
| 16:28:59 | *** jkeiper has quit IRC |
| 16:29:05 | *** jkeiper has joined #openmrs |
| 16:29:05 | *** ChanServ sets mode: +v jkeiper |
| 16:33:02 | *** djadmin has quit IRC |
| 16:33:56 | *** djadmin has joined #openmrs |
| 16:35:31 | <wyclif> rafa, i have assigned you https://tickets.openmrs.org/browse/RESTWS-354 |
| 16:35:31 | <wyclif> rafa, am off for lunch |
| 16:39:16 | *** djadmin has joined #openmrs |
| 16:40:08 | *** wyclif has quit IRC |
| 16:53:19 | <suranga> rafa, you've got one more :P |
| 17:03:10 | *** rafa has quit IRC |
| 17:07:03 | <suranga> m.. hi dkayiwa , are you around by any chance ? :-) |
| 17:10:28 | *** djazayeri1 has quit IRC |
| 17:10:33 | <suranga> hm... hi jkeiper , are you around by any chance ? |
| 17:16:17 | *** djazayeri has joined #openmrs |
| 17:16:17 | *** ChanServ sets mode: +o djazayeri |
| 17:17:25 | *** djazayeri1 has joined #openmrs |
| 17:17:25 | *** djazayeri has quit IRC |
| 17:27:53 | <dkayiwa> suranga: oh by some chance :) |
| 17:28:15 | <suranga> dkayiwa, cool, you're back |
| 17:28:48 | *** bhashitha has quit IRC |
| 17:28:55 | <suranga> dkayiwa, its link this, remember a while back, I talked about overriding a core jsp page via a module, and we discussed doing that by overriding the url via the module ? |
| 17:29:28 | <dkayiwa> suranga: yes |
| 17:29:47 | <suranga> dkayiwa, a college told me that for this to work, we have to set a page priority number ? I've never heard od anything like that before, is that true ? :( |
| 17:30:00 | <suranga> dkayiwa, *a collegue told me |
| 17:30:14 | <dkayiwa> suranga: thats just one option :) |
| 17:31:03 | <suranga> dkayiwa, so you can set a priority number ? I didnt know that. is there an example of sorts around ? |
| 17:34:18 | <suranga> dkayiwa, um.. and what are the other options, if any ? :) |
| 17:34:56 | <dkayiwa> suranga: do you see the SimpleUrlHandlerMapping? |
| 17:35:48 | <suranga> dkayiwa, org.springframework.web.servlet.handler.SimpleUrlHandlerMapping ? |
| 17:36:23 | <dkayiwa> suranga: yes |
| 17:36:37 | <dkayiwa> suranga: http://static.springsource.org/spring/docs/3.0.0.M3/reference/html/ch16s04.html |
| 17:36:41 | <OpenMRSBot> <http://ln-s.net/+dJC> (at static.springsource.org) |
| 17:36:51 | <dkayiwa> suranga: you see the order property |
| 17:37:32 | <suranga> dkayiwa, so if I have two controllers for the same url, |
| 17:37:52 | <suranga> but if one of them has a higher priority via the order property, im good to go ? |
| 17:38:02 | <dkayiwa> suranga: yes |
| 17:38:23 | <suranga> dkayiwa, sorry, but is there some sort of example on how to do this in omrs ? |
| 17:39:30 | <dkayiwa> suranga: https://github.com/openmrs/openmrs-module-xforms/blob/master/omod/src/main/resources/webModuleApplicationContext.xml |
| 17:39:34 | <OpenMRSBot> <http://ln-s.net/+dJI> (at github.com) |
| 17:41:31 | <suranga> dkayiwa, ah, ha... so we need to do this in the application context. coool |
| 17:41:54 | <suranga> dkayiwa, um... if you do have 2-3 minutes more. what were our other options please ? :) |
| 17:43:10 | <dkayiwa> suranga: do you also see this one? https://github.com/openmrs/openmrs-core/blob/master/web/src/main/resources/openmrs-servlet.xml |
| 17:43:14 | <OpenMRSBot> <http://ln-s.net/+dJU> (at github.com) |
| 17:43:26 | <dkayiwa> suranga: this line: <bean id="urlMapping" class="org.springframework.web.servlet.handler.SimpleUrlHandlerMapping"> |
| 17:43:40 | <dkayiwa> suranga: and this property: <property name="order"><value>99</value></property> |
| 17:44:04 | <dkayiwa> suranga: so your order value has to be below 99 to override that in core |
| 17:44:23 | <dkayiwa> suranga: so that is the easier option |
| 17:44:27 | <suranga> dkayiwa, and anything below 99 wins, right ? very coool |
| 17:44:35 | <dkayiwa> suranga: correct |
| 17:45:05 | <suranga> dkayiwa, thanks a lot, I will try this out ! :-) :-) |
| 17:45:53 | <dkayiwa> suranga: an even hackier way is this: https://github.com/openmrs/openmrs-module-xforms/blob/master/omod/src/main/java/org/openmrs/module/xforms/web/controller/XformsUrlHandlerMapping.java |
| 17:45:56 | <OpenMRSBot> <http://ln-s.net/+dJc> (at github.com) |
| 17:46:41 | <dkayiwa> suranga: all request will go through the lookupHandler method |
| 17:47:04 | <dkayiwa> suranga: so in there, you can override each and every core one by simply returning yours :) |
| 17:47:40 | <dkayiwa> suranga: the advantage of the second option is that it is not hardcoded |
| 17:47:43 | <dkayiwa> suranga: its dynamic |
| 17:48:14 | <suranga> dkayiwa, since this controller extends SimpleUrlHandlerMapping, all the requests we make on the core go through this, is it ? |
| 17:48:40 | <dkayiwa> suranga: yes |
| 17:48:49 | <dkayiwa> suranga: thats exactly how i override patient registration with an xform whenever some one sets a certain global property's value to true |
| 17:49:12 | <suranga> dkayiwa, 'tis an ingenious scheme :) |
| 17:49:35 | <dkayiwa> suranga: so its dynamic in the sense that when one turns the global property's value back to false, it goes back to the default openmrs core form |
| 17:49:54 | <dkayiwa> suranga: and that dynamism is not possible with the order property (the first option) |
| 17:50:26 | <suranga> dkayiwa, yep, you're right. I think option 2 is also a whole lot easier |
| 17:50:34 | <suranga> dkayiwa, I hope my boss buys this idea :P |
| 17:51:02 | <dkayiwa> suranga: i hope he believes in hacky solutions :) |
| 17:51:41 | <suranga> dkayiwa, but with your second solution, we end up on a different url, dont we ? |
| 17:52:28 | <dkayiwa> suranga: url does not change, but the controller that handles it |
| 17:53:26 | <suranga> dkayiwa, hmm... in my case, I specifically need to change the patient search form function. I hope that would be possible :) |
| 17:53:51 | <dkayiwa> suranga: how do you wanna change it |
| 17:54:18 | <suranga> dkayiwa, we want to edit the search form that the core has |
| 17:54:26 | <suranga> dkayiwa, to add a lot of custom features |
| 17:54:50 | <dkayiwa> suranga: so you want to replace that form with yours? |
| 17:54:53 | <suranga> wayne doesnt want to introduce a new page for this, he wants to inject these changes into the existing page itself |
| 17:54:58 | <suranga> dkayiwa, yess :) |
| 17:55:16 | <dkayiwa> suranga: my hack completely replaces it |
| 17:56:06 | <suranga> dkayiwa, so we can introduce our own code and search thats way, I see :) |
| 17:56:51 | <dkayiwa> suranga: which part of it would you wanna change? ideally? |
| 17:57:35 | <suranga> dkayiwa, basically the search patient widget. we need to add more search criteria and display features... |
| 17:57:53 | <suranga> dkayiwa, so when you go to search, you will have more options to pick from... |
| 17:58:02 | <dkayiwa> suranga: ok |
| 17:58:26 | <suranga> dkayiwa, i think your solution should do the trick :) |
| 17:58:34 | <dkayiwa> :) |
| 18:00:00 | *** k-joseph has joined #openmrs |
| 18:03:31 | *** djadmin has quit IRC |
| 18:09:27 | <k-joseph> dkayiwa: how about what to do for: Incompatible JavaHL library loaded. 1.7.x or later required. s |
| 18:09:52 | <dkayiwa> k-joseph: did you install it? |
| 18:10:48 | <k-joseph> dkayiwa: installed version 0.9 |
| 18:11:11 | <dkayiwa> k-joseph: can you read the error message? :) |
| 18:11:55 | <k-joseph> dkayiwa: that is the latest version offered by my os software center |
| 18:12:22 | <k-joseph> dkayiwa: version 0.9 is its latest. the only one available |
| 18:12:32 | <dkayiwa> k-joseph: is that the only place you can get it from? |
| 18:14:02 | <k-joseph> dkayiwa: am not sure of any other place, yet |
| 18:14:54 | <dkayiwa> k-joseph: which operating system is that |
| 18:15:25 | <k-joseph> dkayiwa: linux mint |
| 18:15:51 | <dkayiwa> k-joseph: are there many people using it |
| 18:15:59 | <k-joseph> dkayiwa: its softwares work hand in hand with linux ubuntu |
| 18:16:10 | <dkayiwa> k-joseph: oh i see!!!! |
| 18:16:18 | <k-joseph> dkayiwa: yes, |
| 18:17:00 | <dkayiwa> k-joseph: have you googled about JavaHL for ubuntu or mint |
| 18:17:47 | <k-joseph> dkayiwa: i visited its support irc channels, but i was advised to install jdk 7, i did this, it did not solv the problem |
| 18:17:58 | *** downey has joined #openmrs |
| 18:17:58 | *** ChanServ sets mode: +o downey |
| 18:17:58 | *** OpenMRSBot sets mode: +o downey |
| 18:18:22 | <dkayiwa> k-joseph: can you google with this as the search key: javahl 1.7 ubuntu |
| 18:22:11 | *** wyclif has joined #openmrs |
| 18:22:31 | *** andrea has joined #openmrs |
| 18:22:53 | *** andrea is now known as Guest8968 |
| 18:30:50 | *** Guest8968 is now known as andreap_ |
| 18:34:22 | <k-joseph> dkayiwa: i have worked on that, |
| 18:34:34 | <dkayiwa> k-joseph: which one |
| 18:35:51 | *** GitHub9 has joined #openmrs |
| 18:35:51 | <GitHub9> [openmrs-core] dkayiwa opened pull request #215: Remove PatientSummarySpecification and PatientSummaryPortletController, which are leftover from a feature removed years ago - TRUNK-3371 (master...TRUNK-3371) http://git.io/BCGp4A |
| 18:35:51 | *** GitHub9 has left #openmrs |
| 18:36:18 | *** GitHub185 has joined #openmrs |
| 18:36:18 | <GitHub185> [openmrs-core] dkayiwa pushed 2 new commits to master: http://git.io/Ip13xQ |
| 18:36:18 | <GitHub185> openmrs-core/master 7f16052 Daniel Kayiwa: Remove PatientSummarySpecification and PatientSummaryPortletController,... |
| 18:36:18 | <GitHub185> openmrs-core/master 6456b6b dkayiwa: Merge pull request #215 from dkayiwa/TRUNK-3371... |
| 18:36:18 | *** GitHub185 has left #openmrs |
| 18:36:18 | <k-joseph> dkayiwa: upgrading javahl |
| 18:36:29 | <dkayiwa> k-joseph: so it worketh? |
| 18:36:45 | <downey> Do we like the GitHub updates here in the channel? |
| 18:36:55 | <k-joseph> dkayiwa: yes, |
| 18:37:05 | <dkayiwa> k-joseph: ok great |
| 18:37:26 | <k-joseph> dkayiwa: not warned when importing this time |
| 18:37:35 | <dkayiwa> k-joseph: excellent!!! |
| 18:41:16 | <dkayiwa> downey: am personally not offended by them :) |
| 18:42:31 | <downey> dkayiwa: BTW kudos for being the first mentor to apply for GSoC |
| 18:43:46 | *** djadmin has joined #openmrs |
| 18:43:55 | <dkayiwa> downey: lollllllll :D |
| 18:44:13 | <k-joseph> dkayiwa: where in eclipse can i get to know the current version of java hl |
| 18:49:49 | <k-joseph> dkayiwa: hi |
| 18:59:45 | *** djazayeri has joined #openmrs |
| 18:59:45 | *** ChanServ sets mode: +o djazayeri |
| 18:59:46 | *** djazayeri1 has quit IRC |
| 19:03:00 | *** mseaton has quit IRC |
| 19:09:17 | <dkayiwa> k-joseph: hi |
| 19:14:37 | *** djadmin has quit IRC |
| 19:18:29 | *** rowanseymour has joined #openmrs |
| 19:24:40 | *** rowanseymour has quit IRC |
| 19:32:17 | *** mseaton has joined #openmrs |
| 19:32:17 | *** ChanServ sets mode: +v mseaton |
| 19:42:33 | *** k-joseph has quit IRC |
| 20:07:07 | <andreap_> cpower, are we scrumming? |
| 20:10:01 | <cpower> Sorry yes |
| 20:10:08 | <cpower> !scrumon cpower |
| 20:10:08 | * OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready. |
| 20:10:16 | <cpower> Too many projects not enough time |
| 20:10:55 | <cpower> Order: wyclif, dkayiwa, andreap_, dkayiwa, suranga, mseaton, djazayeri, and anyone else who would like to give an update |
| 20:12:20 | *** mseaton has quit IRC |
| 20:12:21 | <wyclif> Wednesday: |
| 20:12:22 | <wyclif> RESTWS-329 - Fix EncounterTypeControllerTest |
| 20:12:22 | <wyclif> Paired with Andrea to work on - RESTWS-322 - Fix ConceptClassControllerTest |
| 20:12:22 | <wyclif> design call |
| 20:12:22 | <wyclif> Helped Bhashitha with TRUNK-3836 - Add search button to Concept search |
| 20:12:22 | <wyclif> |
| 20:12:24 | <wyclif> Thursday: |
| 20:12:26 | <wyclif> dev call |
| 20:12:29 | <wyclif> Creating/linking sub tickets for RESTWS-267 - Need to expose concept_source |
| 20:12:31 | <wyclif> Review code for RESTWS-309 - Merge webservices.rest and webservices.rest19ext modules into one |
| 20:12:32 | <wyclif> RESTWS-353 - Add ConceptMapTypeResource and ConceptMapTypeController |
| 20:12:34 | <wyclif> |
| 20:12:36 | <wyclif> Blockers: None |
| 20:12:40 | <dkayiwa> Reviewed and closed: Integrate form UUID in forms - XFRM-69 |
| 20:12:40 | <dkayiwa> Reviewed and closed: Integrate patient UUID in forms - XFRM-68 |
| 20:12:40 | <dkayiwa> Reviewed: Add SerializableComplexObsHandler interface for form processing methods - TRUNK-3886 |
| 20:12:41 | <dkayiwa> Reviewed and closed: providerDAO.getProvidersByPerson(person, false) returns only retired providers, when it should return only *non-retired* providers - TRUNK-3892 |
| 20:12:41 | <dkayiwa> Applied patch and closed: Remove PatientSummarySpecification and PatientSummaryPortletController, which are leftover from a feature removed years ago - TRUNK-3371 |
| 20:12:41 | <dkayiwa> Closed: TRUNK-3867, TRUNK-3014, TRUNK-3008 |
| 20:12:42 | <dkayiwa> Dev Call |
| 20:12:42 | <dkayiwa> Now reviewing: Upgrade to the latest stable release of jquery - TRUNK-3054 |
| 20:12:42 | <dkayiwa> No Blockers |
| 20:12:56 | <andreap_> Thursday |
| 20:12:56 | <andreap_> Design Call |
| 20:12:56 | <andreap_> Fix last failing test in REST-322 Fix ConceptClassControllerTest |
| 20:12:56 | <andreap_> Pick another REST-WS ticket |
| 20:12:56 | <andreap_> No Blockers but discussion with Wyclif re: req.addParameter("!purge", ""); |
| 20:12:56 | <andreap_> and |
| 20:12:58 | <andreap_> Tests in error: |
| 20:13:00 | <andreap_> purgeConceptClass_shouldPurgeAConceptClass(org.openmrs.module.webservices.rest |
| 20:13:02 | <andreap_> .web.v1_0.controller.openmrs1_8.ConceptClassControllerTest) |
| 20:14:34 | <wyclif> andreap_, is that test still failing? |
| 20:14:48 | <andreap_> wyclif_, yes |
| 20:15:03 | <dkayiwa> cpower: looks like am next :) |
| 20:15:15 | <wyclif> andreap_, i believe you are trying to delete a concept class that is in use, you need to use the uuid in the commented out test |
| 20:15:22 | <cpower> yep go |
| 20:15:48 | <dkayiwa> surely too many projects!!! :) ^^ |
| 20:16:04 | <cpower> lol |
| 20:16:20 | <cpower> Ok, nothing from djazayeri, or suranga? |
| 20:16:23 | <andreap_> wyclif, why don't I put method in pastebin? |
| 20:16:28 | <suranga> howdy |
| 20:16:30 | <djazayeri> Nothing about the sprint from me. |
| 20:16:31 | <wyclif> surean |
| 20:16:34 | <suranga> DID |
| 20:16:34 | <suranga> RESTWS-331 (ticket closed) |
| 20:16:34 | <wyclif> sure andreap_ |
| 20:16:34 | <suranga> RESTWS-332 (ticket closed) |
| 20:16:34 | <suranga> RESTWS-327 (for review) |
| 20:16:34 | <suranga> Reviewed RESTWS-326 |
| 20:16:35 | <suranga> TO DO |
| 20:16:37 | <suranga> RESTWS-346 |
| 20:16:39 | <suranga> Review RESTWS-325 |
| 20:16:57 | <suranga> NO BLOCKERS |
| 20:17:25 | <cpower> ok, Discussion is happening, no blockers I can see |
| 20:17:39 | <cpower> Annoucements: |
| 20:18:12 | <wyclif> andreap_, add here the pastebin link |
| 20:18:28 | <cpower> We will be extending RESTWS a week to get the work done that was scheduled and allow some more time for Sync and the first leg of Reference Module planned |
| 20:18:44 | <cpower> That makes Sync's start date 2/28 |
| 20:18:44 | <andreap_> wyclif: pastebin.com/wWanYj1X |
| 20:19:04 | <cpower> Thank you and have a great day |
| 20:19:10 | <cpower> !scrumoff |
| 20:19:10 | * OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin. |
| 20:19:58 | *** andreapat has joined #openmrs |
| 20:20:35 | <wyclif> andreap_, from the email and ticket comment i added, i said that if you look at MainCrudController, the parameter you add determines if you are retiring or purging, so you should be adding purge and not !purge because !purge means retire the concept class |
| 20:20:48 | <wyclif> andreap_, that change should make the test pass |
| 20:21:05 | <andreap_> wyclif_: ok |
| 20:21:25 | *** suranga has quit IRC |
| 20:22:45 | <wyclif> andreap_, and you are making one more error, you are calling getUuid in your assertion, you should be using the same uuid as that in the post, you need to look at the test i added to conceptsource test for purging for an example |
| 20:23:38 | <andreap_> wyclif_: just fixed it |
| 20:24:28 | <wyclif> andreap_, cool you should be using the uuid you are setting on the uuid variable and not call getUuid() anywhere inside that test |
| 20:25:04 | <wyclif> andreap_, can you actually add another assertion at the start of that test method to ensure that actually the concept class exists before trying to purge it |
| 20:25:09 | <cpower> wyclif, know of any intro tickets that are JS work that needs to be done? |
| 20:25:34 | <wyclif> cpower, in the current sprint? |
| 20:26:05 | <wyclif> cpower, or in any project? |
| 20:26:18 | <cpower> Current sprint would be great, but really intro, community swimlane, any would be fine |
| 20:26:23 | <andreap_> wyclif_, can you pastenin that?test method to ensure that actually the concept class exists before trying to purge it |
| 20:26:48 | <cpower> Mr. Downey will be sending you the new developer's request |
| 20:26:59 | <downey> wyclif: email on the way to you now |
| 20:27:05 | <wyclif> cpower, ok, i think we git a couple in the current sprint |
| 20:27:15 | <wyclif> cpower, git->got |
| 20:27:25 | <dkayiwa> :) |
| 20:27:34 | <cpower> wyclif, awesome as always Wyclif... |
| 20:27:50 | <wyclif> hmm...... |
| 20:27:52 | <dkayiwa> :D |
| 20:28:51 | *** mseaton has joined #openmrs |
| 20:28:51 | *** ChanServ sets mode: +v mseaton |
| 20:29:03 | <wyclif> andreap_, if you look at the pastebin you sent me, you need to add the same assert from line 11 to ensure that actually the concept class before making the call to purge] |
| 20:29:27 | <andreap_> wyclif: thanks - ok I got it |
| 20:29:58 | <wyclif> andreap_, you can look at ConceptSourceControllerTest.shouldPurgeAConceptSource and try to replicate that code |
| 20:30:59 | <wyclif> andreap_, actually i forgot to add it too, let me add it and oush |
| 20:32:32 | <andreap_> wyclif: where are you adding it? |
| 20:35:33 | <wyclif> andreap_, see https://github.com/openmrs/openmrs-module-webservices.rest/blob/sprint-201302/omod/src/test/java/org/openmrs/module/webservices/rest/web/v1_0/controller/openmrs1_8/ConceptSourceControllerTest.java |
| 20:35:37 | <OpenMRSBot> <http://ln-s.net/+dOD> (at github.com) |
| 20:36:07 | <wyclif> andreap_, see the shouldPurgeAConceptSource method |
| 20:36:13 | <andreap_> wyclif, thanks! |
| 20:37:52 | <wyclif> andreap_, you do see that i have two assertions, one is a sanity check that the class actually existed before writing the other lines, it ensures that your test is future proof in case that concept class was removed from the test dataset |
| 20:38:52 | <wyclif> andreap_, otherwise your test will always pass if a concept class with that uuid didnt exist or is removed from the test data |
| 20:39:29 | *** rfriedman-away is now known as rfriedman |
| 20:39:44 | <rfriedman> andreap_, did you get your answer about !purge? |
| 20:40:18 | <andreap_> wyclif_, I think I get - let me try it |
| 20:40:56 | <andreap_> rfriedman, yes - I forgot to take out ! in pastebin - it's out in code |
| 20:41:27 | <rfriedman> andreap_, so you understand that !purge means that there is no parameter named purge? |
| 20:42:14 | <andreap_> rfriedman, yes I think so |
| 20:42:37 | <rfriedman> andreap_, cool |
| 20:44:19 | *** rfriedman has quit IRC |
| 20:55:04 | <andreap_> wyclif: you still here? |
| 21:04:09 | *** travis-ci has joined #openmrs |
| 21:04:09 | <travis-ci> [travis-ci] [openmrs/openmrs-core] [6456b6b] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/4799700 |
| 21:04:09 | *** travis-ci has left #openmrs |
| 21:04:13 | <OpenMRSBot> <http://ln-s.net/+dP-> (at travis-ci.org) |
| 21:08:47 | *** k-joseph has joined #openmrs |
| 21:09:02 | <k-joseph> dkayiwa: hi |
| 21:09:11 | <dkayiwa> k-joseph: hi |
| 21:11:45 | <k-joseph> dkayiwa: it appeared as though the four commands i had run had solved the javahl issue, but no, i am still facing it, am trying them a gain, because that is what most sites are offering over that issue |
| 21:12:09 | <dkayiwa> k-joseph: ok |
| 21:15:55 | <andreap_> wyclif, test is still failing - I should be using the uuid variable and not call getUuid() right? |
| 21:17:14 | *** jkeiper has quit IRC |
| 21:18:05 | <k-joseph> dkayiwa: please what could have gone wrong here http://pastebin.com/RcuFKzsi |
| 21:20:33 | <dkayiwa> k-joseph: what does mvn clean install return at commandline |
| 21:20:42 | *** mseaton has left #openmrs |
| 21:23:20 | <k-joseph> dkayiwa: mvn clean install returns http://pastebin.com/qv5QB0bT |
| 21:29:23 | <wyclif> andreap_, yes |
| 21:30:01 | <wyclif> andreap_, don't call getUuid() anywhere in that purge test method |
| 21:32:30 | *** djazayeri has quit IRC |
| 21:32:43 | <andreap_> wyclif, I'm not |
| 21:32:54 | <wyclif> andreap_, can you send a paste bin? |
| 21:33:11 | <andreap_> wyclif - sure |
| 21:35:01 | *** lh has quit IRC |
| 21:35:18 | <andreap_> wyclif: pastebin.com/zR1TsGn1 |
| 21:36:36 | <wyclif> andreap_, you still have calls to getUuid() in your code, replace all of them with the uuid variable |
| 21:36:52 | <wyclif> andreap_, just for the test method, replace them |
| 21:37:08 | <andreap_> wyclif, they are commented ou |
| 21:38:52 | <wyclif> andreap_, there are two problems |
| 21:39:31 | <andreap_> wyclif: what are they? |
| 21:40:08 | <wyclif> andreap_, first of all your last assert is wrong it should assertNull because you have purged the concept class, second i recall saying that you need to copy the uuid value in the commented out purge method |
| 21:40:30 | <wyclif> andreap_, the one you are currently using isnt the one, so that is probably a concept class in use |
| 21:42:17 | <andreap_> wyclif, was looking at wrong purge method - too many comments |
| 21:43:16 | <wyclif> andreap_, basically your first assert should check that there is a concept class with that uuid and the second/last one should check that there is no concept class with that uuid since you have just deleted with a ws call |
| 21:44:13 | <andreap_> wyclif, I understand |
| 21:44:30 | <wyclif> andreap_, cool |
| 21:46:40 | *** cpower has quit IRC |
| 21:53:43 | *** cpower has joined #openmrs |
| 21:53:50 | *** robbyoconnor has joined #openmrs |
| 21:53:50 | *** ChanServ sets mode: +v robbyoconnor |
| 21:56:04 | <andreap_> wyclif, it is still failing - new paste bin with comment out method with uuid and new method |
| 21:56:29 | <wyclif> andreap_, let me see the pastebin |
| 21:56:36 | <wyclif> andreap_, what error are you getting |
| 21:56:40 | <dkayiwa> hi k-joseph |
| 21:56:44 | <andreap_> wyclif: pastebin.com/wxh4mBm7 |
| 21:57:06 | <andreap_> wyclif, same one - should I get a full stack trace? |
| 21:57:12 | <dkayiwa> k-joseph: can you sent the pastebin link for the mvn clean install results to the dev list? |
| 21:59:17 | <k-joseph> dkayiwa: :-( :( |
| 21:59:43 | <dkayiwa> k-joseph: the dev list will engage more developers for answers :) |
| 21:59:43 | <andreapat> wyclif: Tests in error: |
| 21:59:44 | <andreapat> shouldPurgeAConceptSource(org.openmrs.module.webservices.rest.web.v1_0.control |
| 21:59:44 | <andreapat> ler.openmrs1_8.ConceptClassControllerTest) |
| 22:00:03 | <andreapat> wyclif, switched to other computer now andreapat |
| 22:00:06 | <wyclif> andreap_, the test now lookd good, it is somethims else |
| 22:00:20 | <wyclif> andreap_, can you look at the stacktrace in the suresire report? |
| 22:00:53 | <andreap_> wyclif, yes will lokk at stacktrace - will be andreapat now (on other computer) |
| 22:01:04 | <wyclif> andreap_, ok |
| 22:05:26 | *** dkayiwa has quit IRC |
| 22:06:13 | *** djazayeri has joined #openmrs |
| 22:06:13 | *** ChanServ sets mode: +o djazayeri |
| 22:08:38 | <andreap_> wyclif, it is taking so long beacuase I am on Merck network - have to be to use irc on that computer |
| 22:12:04 | *** djazayeri1 has joined #openmrs |
| 22:12:05 | *** djazayeri has quit IRC |
| 22:13:37 | *** robbyoconnor has quit IRC |
| 22:13:59 | *** robbyoconnor has joined #openmrs |
| 22:13:59 | *** ChanServ sets mode: +v robbyoconnor |
| 22:14:36 | <andreapat> wyclif: http://pastebin.com/PPzRCrBd |
| 22:15:35 | <wyclif> andreap_, i mean the surefire logs |
| 22:16:34 | <andreap_> wyclif: running with -X - how do I find surefire logs - has been awhile |
| 22:16:44 | <wyclif> under omod/target |
| 22:17:52 | <wyclif> andreap_, i have seen the problem |
| 22:17:58 | <wyclif> andreap_, it is in the test |
| 22:18:17 | <andreapat> wyclif: running mvn -X clean install - see no omod/target |
| 22:18:56 | <wyclif> andreap_, you are working on concept class and not concept source, i said copy the code from conceptsource controller test but you were supposed to make the necessary edits sothat you deal with concept class and not source |
| 22:19:43 | <wyclif> andreap_, even the name of your test method is wrong, it should say concept class and no source |
| 22:22:16 | <andreapat> wyclif, I mentioned that earlier in pastebin - so cange name to shouldPurgeAConceptClass() |
| 22:23:06 | <wyclif> andreap_, ofcourse you are dealing with concept class, even you calls in the method are saying concept source which is wrong and this why tour tests are failing |
| 22:23:25 | <andreapat> wyclif - really confuse - did we change that yesterday? |
| 22:25:14 | <wyclif> andreap_, but you are dealing with concept class, you should't mention concept source anywhere in that code |
| 22:26:21 | <wyclif> andreap_, i just said your code should lok like that in conceptsource but should be exactly the same, can you add here the pastebin of the entire test class |
| 22:29:51 | <andreapat> wyclif: http://pastebin.com/h69WCrAb |
| 22:32:48 | <wyclif> andreap_, rename your test method to say concept class and not source, you also need to edit the code in it to deal with concept class and not concept source, so you get what i mean? |
| 22:33:37 | <wyclif> andreap_, it is the reason it is failing, you are looking up and purging a concept source instead of a concept class which is completely different from what we are testing |
| 22:34:24 | <wyclif> andreap_, you probably copied and pasted and forgot to rename things in that test |
| 22:35:06 | <andreap_> wyclif, changed names under // ConceptClass - do you see that? |
| 22:36:02 | <andreap_> wyclif - so sorry - I was hurry yesterday because of appt |
| 22:36:03 | *** robbyoconnor has quit IRC |
| 22:36:55 | <wyclif> andreap_, have you edited the code inside the test too to deal with concept classes instead? |
| 22:37:50 | <andreap_> wyclif, only whta is there in pastebin |
| 22:39:33 | <wyclif> andreap_, can you closely look at the code in your purge test method, you should see that you are looking up/purging a concept source which is wrong, that test class is entirely for concept classes |
| 22:42:51 | <andreapat> wyclif: http://pastebin.com/CQHYLcq2 |
| 22:43:15 | <wyclif> andreap_, did you understand my last text above? |
| 22:44:05 | <wyclif> andreap_, does it still fail? |
| 22:46:01 | *** djazayeri has joined #openmrs |
| 22:46:01 | *** ChanServ sets mode: +o djazayeri |
| 22:46:02 | *** djazayeri1 has quit IRC |
| 22:46:33 | <wyclif> andreap_, ? |
| 22:46:45 | <andreap_> wyclif, it works now - don't know how that happened |
| 22:47:10 | <andreap_> wyclif, so slow when on Merck network |
| 22:47:44 | <wyclif> it is after the changed or renaming you have just made, in your old code you were purging a concept source instead of a concept class |
| 22:48:46 | <andreapat> wyclif, yes I understand - don't remeber changing to a concept source yesterday |
| 22:49:45 | <andreapat> wyclif: so sorry for so much time - still don't understand how that happened |
| 22:51:27 | <andreapat> wyclif, should I remove commented out code, commit and pull now? |
| 23:00:42 | <andreapat> wyclif: thanks! |
| 23:05:11 | <wyclif> andreap_, yes you need to remove commented out code, make sure that all tests have new equivalent tests |
| 23:05:30 | <wyclif> andreap_, i.e that all functionality is still tested |
| 23:06:01 | *** Mkop has quit IRC |
| 23:06:02 | <wyclif> andreap_, the assumption is that you have replace every test with a new one |
| 23:06:14 | <wyclif> wyclif, am heading home, talk to u later |
| 23:07:20 | *** Mkop has joined #openmrs |
| 23:07:20 | *** ChanServ sets mode: +v Mkop |
| 23:09:03 | *** wyclif has quit IRC |
| 23:30:48 | *** djazayeri1 has joined #openmrs |
| 23:30:48 | *** djazayeri has quit IRC |
| 23:42:40 | *** downey has quit IRC |
| 23:53:42 | *** wyclif has joined #openmrs |