00:14:45
|
*** djazayeri has quit IRC
|
01:30:14
|
*** jkeiper has joined #openmrs
|
01:30:14
|
*** ChanServ sets mode: +v jkeiper
|
02:54:23
|
*** Echidna has quit IRC
|
03:00:33
|
*** Echidna has joined #openmrs
|
03:00:33
|
*** ChanServ sets mode: +v Echidna
|
03:15:21
|
*** djadmin has joined #openmrs
|
03:19:47
|
*** djazayeri has joined #openmrs
|
03:19:47
|
*** ChanServ sets mode: +o djazayeri
|
04:15:10
|
*** santom has joined #openmrs
|
04:18:11
|
*** djadmin has quit IRC
|
04:19:12
|
*** santom has quit IRC
|
04:25:09
|
*** djazayeri has quit IRC
|
04:52:20
|
*** djazayeri has joined #openmrs
|
04:52:20
|
*** ChanServ sets mode: +o djazayeri
|
04:53:51
|
*** santom has joined #openmrs
|
04:53:56
|
*** djazayeri has quit IRC
|
04:55:08
|
*** kishoreyekkanti has joined #openmrs
|
05:00:18
|
*** djazayeri has joined #openmrs
|
05:00:18
|
*** ChanServ sets mode: +o djazayeri
|
05:06:17
|
*** santom has quit IRC
|
05:14:40
|
*** djazayeri has quit IRC
|
05:28:39
|
*** Anuruddha has joined #openmrs
|
05:29:06
|
*** meuru has joined #openmrs
|
06:22:33
|
*** pulasthi7 has joined #openmrs
|
06:24:34
|
*** Nigel has joined #openmrs
|
06:24:55
|
*** ge has joined #openmrs
|
06:25:02
|
<Nigel> Herro?
|
06:25:24
|
*** Timothy_ has joined #openmrs
|
06:25:31
|
<Timothy_> how does this work?
|
06:25:49
|
*** Nigel has quit IRC
|
06:29:12
|
*** ge has quit IRC
|
06:29:37
|
*** Timothy_ has quit IRC
|
06:37:27
|
*** goutham has joined #openmrs
|
06:44:29
|
*** djadmin has joined #openmrs
|
07:09:11
|
*** dkayiwa has joined #openmrs
|
07:21:19
|
*** djadmin has quit IRC
|
07:36:41
|
*** djadmin has joined #openmrs
|
07:36:55
|
*** rowanseymour has joined #openmrs
|
07:37:21
|
*** dkayiwa has quit IRC
|
07:38:09
|
*** dkayiwa has joined #openmrs
|
07:44:12
|
*** kaviththiranga has joined #openmrs
|
07:53:47
|
*** meuru has quit IRC
|
08:02:57
|
*** GitHub173 has joined #openmrs
|
08:02:57
|
<GitHub173> [openmrs-core] dkayiwa pushed 3 new commits to master: http://git.io/Xh4UVw
|
08:02:57
|
<GitHub173> openmrs-core/master e374a4c Daniel Kayiwa: Encounter autocomplete should filter results by patient - TRUNK-3231...
|
08:02:57
|
<GitHub173> openmrs-core/master c8d49d7 wluyima: Follow up to move the @Transactional annotation to the serviceImpl -...
|
08:02:57
|
<GitHub173> openmrs-core/master cd2bf80 dkayiwa: Merge pull request #128 from wluyima/TRUNK-3231...
|
08:02:57
|
*** GitHub173 has left #openmrs
|
08:04:32
|
*** kaviththiranga has quit IRC
|
08:05:26
|
*** Anuruddha has quit IRC
|
08:06:20
|
*** rowanseymour has quit IRC
|
08:12:15
|
*** travis-ci has joined #openmrs
|
08:12:15
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [cd2bf80] [dkayiwa] The build was broken. - http://travis-ci.org/openmrs/openmrs-core/builds/4740312
|
08:12:15
|
*** travis-ci has left #openmrs
|
08:12:19
|
<OpenMRSBot> <http://ln-s.net/+cHI> (at travis-ci.org)
|
08:22:12
|
*** djadmin has quit IRC
|
08:22:30
|
*** Anuruddha has joined #openmrs
|
08:50:39
|
*** GitHub44 has joined #openmrs
|
08:50:39
|
<GitHub44> [openmrs-core] dkayiwa opened pull request #214: Fixing failing unit tests for: Encounter autocomplete should filter results by patient - TRUNK-3231 (master...TRUNK-3231) http://git.io/i58ouw
|
08:50:39
|
*** GitHub44 has left #openmrs
|
08:50:55
|
*** GitHub136 has joined #openmrs
|
08:50:55
|
<GitHub136> [openmrs-core] dkayiwa pushed 2 new commits to master: http://git.io/7y1exg
|
08:50:55
|
<GitHub136> openmrs-core/master 90fa765 Daniel Kayiwa: Fixing failing unit tests for: Encounter autocomplete should filter...
|
08:50:55
|
<GitHub136> openmrs-core/master 6998a8a dkayiwa: Merge pull request #214 from dkayiwa/TRUNK-3231...
|
08:50:55
|
*** GitHub136 has left #openmrs
|
09:02:36
|
*** travis-ci has joined #openmrs
|
09:02:36
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [6998a8a] [dkayiwa] The build was fixed. - http://travis-ci.org/openmrs/openmrs-core/builds/4740868
|
09:02:36
|
*** travis-ci has left #openmrs
|
09:02:39
|
<OpenMRSBot> <http://ln-s.net/+cI3> (at travis-ci.org)
|
09:22:41
|
*** k-joseph has joined #openmrs
|
09:30:58
|
*** Anuruddha has quit IRC
|
09:33:49
|
*** rowanseymour has joined #openmrs
|
09:37:47
|
*** kishoreyekkanti has quit IRC
|
09:40:49
|
*** rowanseymour has quit IRC
|
09:49:34
|
*** shady__ has joined #openmrs
|
09:51:00
|
*** k-joseph has quit IRC
|
10:44:32
|
*** rkorytkowski has joined #openmrs
|
10:44:32
|
*** ChanServ sets mode: +v rkorytkowski
|
10:44:43
|
*** rkorytkowski is now known as rafa
|
10:50:25
|
*** djadmin has joined #openmrs
|
10:59:11
|
*** djadmin has quit IRC
|
11:00:07
|
*** djadmin has joined #openmrs
|
11:07:20
|
*** pulasthi7 has quit IRC
|
11:17:01
|
<shady__> hi guys, am encountering this error
|
11:17:33
|
<shady__> java.lang.ArrayIndexOutOfBoundsException: 1 at Script1$_run_closure2.doCall(Script1.groovy:50) at Script1.run(Script1.groovy:23) at Script1$run.call(Unknown Source) at Script1$run.call(Unknown Source) at $Proxy1960.evaluate(Unknown Source) at $Proxy1961.evaluate(Unknown Source) at $Proxy1961.evaluate(Unknown Source)
|
11:17:56
|
<shady__> please help
|
11:22:50
|
*** rowanseymour has joined #openmrs
|
11:24:24
|
<dkayiwa> shady__: what are you trying to do?
|
11:26:03
|
<shady__> dkayiwa, am trying to run a groovy script
|
11:26:21
|
<dkayiwa> shady__: did you write the script yourself?
|
11:27:51
|
<shady__> dkayiwa, no, i got it from the wiki.
|
11:28:28
|
<dkayiwa> shady__: what does the script do?
|
11:29:59
|
<shady__> dkayiwa, Copy household addresses to resident records In the AMRS Mobile Forms Module data model, Households have address information. Somehow that data is not being used to generate person addresses. The following Groovy script generates SQL to create person addresses for each person in a household.
|
11:34:20
|
*** upul has joined #openmrs
|
11:34:20
|
*** ChanServ sets mode: +v upul
|
11:35:20
|
<dkayiwa> shady__: can you give me a link to the script wiki page?
|
11:36:30
|
<shady__> dkayiwa, https://wiki.ampath.or.ke/display/ampath/HCT+Data+Migration+Phase+I Copy household addresses to resident records
|
11:36:37
|
<OpenMRSBot> <http://ln-s.net/+cKv> (at wiki.ampath.or.ke)
|
11:54:28
|
*** hybridivy has joined #openmrs
|
11:56:43
|
<dkayiwa> shady__: can you send the error message to the dev list?
|
11:59:27
|
*** djadmin has quit IRC
|
12:04:35
|
*** suranga has joined #openmrs
|
12:04:35
|
*** ChanServ sets mode: +v suranga
|
12:05:23
|
<rowanseymour> @rafa - you working on MDS this week ?
|
12:05:41
|
<rafa> rowanseymour: on restws
|
12:06:01
|
<rowanseymour> Am really stuck with what I think is https://tickets.openmrs.org/browse/META-318
|
12:06:51
|
<rowanseymour> Think things broke after we upgraded CIEL and that introduced new concept names
|
12:07:07
|
<shady__> dkayiwa, this is the whole error message generated by catalina
|
12:07:16
|
<shady__> dkayiwa, INFO - LoggingAdvice.invoke(109) |2013-02-12 15:03:17,007| In method AdministrationService.executeSQL. Arguments: String= select household_id, village, sublocation, location, division, district, gps_location, created_by, date_created from mobileformentry_household , boolean=false, INFO - LoggingAdvice.invoke(134) |2013-02-12 15:03:17,719| Exiting method executeSQL
|
12:08:02
|
<rafa> rowanseymour: it seems like duplciate concept names have been added in CIEL
|
12:08:08
|
<dkayiwa> shady__: the one you gave me earlier on
|
12:08:13
|
<rowanseymour> rafa - question - is MIRROR mode in the API the same as MASTER mode in the UI ?
|
12:08:26
|
<rafa> rowanseymour: there's no MIRROR mode in the UI
|
12:08:35
|
<rafa> rowanseymour: MASTER is different
|
12:08:48
|
<rowanseymour> Why no mirror mode in UI ?
|
12:09:18
|
<rafa> rowanseymour: I've added it only for the publishing/subscribing dictionary
|
12:10:03
|
<rafa> rowanseymour: can you save 1066AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA?
|
12:10:19
|
<rafa> rowanseymour: when you go to the editing concept page?
|
12:11:16
|
<rowanseymour> Please fix all errors and try again.
|
12:11:17
|
<rowanseymour> The Fully Specified or Preferred name is a duplicate
|
12:11:33
|
<rowanseymour> good call - but I checked the concept in the db and it looked fine
|
12:11:51
|
<shady__> dkayiwa, the first i gave you was generated on the groovy's stacktrace
|
12:12:40
|
<dkayiwa> shady__: can you send the groovy trace to the dev list?
|
12:14:14
|
<rowanseymour> what is the actual problem with the names ?
|
12:14:16
|
<rowanseymour>
|
12:14:17
|
<rowanseymour> +------------+---------+--------+-------------------+------------------+
|
12:14:18
|
<rowanseymour>
|
12:14:19
|
<rowanseymour>
|
12:14:20
|
<rowanseymour>
|
12:14:21
|
<rowanseymour>
|
12:14:22
|
<rowanseymour>
|
12:14:23
|
<rowanseymour>
|
12:14:53
|
<rafa> rowanseymour: can you pastebin, because I see ????????
|
12:15:12
|
<rowanseymour> I see ???? in this SSH session
|
12:15:21
|
<rafa> rowanseymour: ohh ok
|
12:15:39
|
<rafa> rowanseymour: hmm this is ok
|
12:15:57
|
<rafa> rowanseymour: but there's probably another concept with the same name
|
12:16:04
|
<rowanseymour> Ah...
|
12:16:40
|
<rowanseymour> The UI won't let me see the TI, RW or RU locales
|
12:17:57
|
<rowanseymour> I've got an idea - maybe it really is ???? int he database because the dump didn't have the right encoding. That would lead to duplicate names...
|
12:18:20
|
<rafa> rowanseymour: you could try select * from concept_name where name = (select name from concept_name where concept_name_id = xxx)
|
12:20:20
|
<rafa> rowanseymour: unlikely, the error message in UI is correclty decoded
|
12:21:31
|
<rafa> rowanseymour: unfortunately Andy still uses OMRS 1.6.x to manage the dictionary
|
12:21:46
|
<rafa> rowanseymour: it has only a basic validation
|
12:22:02
|
<rafa> rowanseymour: very easy to introduce duplicate names through UI there
|
12:22:08
|
<shady__> dkayiwa, dev list is the email listing, at implementers?
|
12:22:39
|
<dkayiwa> shady__: dev is for developers, while implementers is for users
|
12:23:01
|
<rafa> rowanseymour: probably the best way to find duplicates will be to run the validation module
|
12:23:20
|
<rowanseymour> ok I'll try clean install of CIEL first to make sure this isn't something introduced via MDS
|
12:23:31
|
<rowanseymour> then validation module
|
12:24:17
|
<rowanseymour> really appreciate your help. Major release this week and suddenly import/export is broken
|
12:24:43
|
<rafa> rowanseymour: I would be surprised if MDS could introduce duplicates. It saves all through services so must pass validation.
|
12:25:16
|
<rafa> rowanseymour: but yeah let me know your findings
|
12:25:50
|
<rafa> rowanseymour: I'll be on the community swimlane from Feb, 21st I guess
|
12:26:10
|
<rafa> rowanseymour: will have more time to address any issues
|
12:26:26
|
<rowanseymour> And mirror mode - you don't think that should go into the UI ? We have a few dev servers and I want them to just mirror metadata - no merging etc
|
12:27:12
|
<rafa> rowanseymour: I see no problem with adding it to the UI, it just wasnt' a priority
|
12:27:16
|
*** rfriedman has joined #openmrs
|
12:29:25
|
<rfriedman> hey rafa
|
12:30:14
|
<dkayiwa> shady__: join the developers mailing list from here: https://wiki.openmrs.org/display/RES/Mailing+Lists
|
12:30:15
|
<OpenMRSBot> <http://ln-s.net/8ZWD> (at wiki.openmrs.org)
|
12:31:09
|
<rafa> rfriedman: hi
|
12:31:34
|
<rfriedman> rafa, is restws supposed to be working now?
|
12:31:53
|
<rafa> rfriedman: I haven't run anything but tests
|
12:31:56
|
<rafa> rfriedman: but yes
|
12:32:02
|
<rafa> rfriedman: any problem?
|
12:32:14
|
<rfriedman> rafa, i am running it from the test page and curl
|
12:32:43
|
<rfriedman> i just get errors, whether i go by patient uuid or patient name
|
12:32:58
|
<rfriedman> have the fixes not gotten that far?
|
12:33:21
|
<rafa> rfriedman: this part should be working
|
12:33:31
|
<rafa> rfriedman: I don't have a compiling state right now
|
12:33:41
|
<rafa> rfriedman: but let me get back to you in half an hour at most
|
12:33:44
|
<rafa> rfriedman: I'll test
|
12:33:46
|
<rfriedman> ok tks
|
12:35:47
|
*** suranga has quit IRC
|
12:37:47
|
<shady__> dkayiwa, i've posted it on dev listing . thanks
|
12:37:58
|
*** suranga has joined #openmrs
|
12:38:52
|
*** upul has quit IRC
|
12:45:53
|
*** suranga has quit IRC
|
12:46:59
|
<rafa> rfriedman: hmmm I've just tried /openmrs-standalone/ws/rest/v1/patient/dd553e53-1691-11df-97a5-7038c432aabf and it worked
|
12:47:06
|
<rafa> rfriedman: what uri are you calling?
|
12:48:22
|
*** goutham has quit IRC
|
12:50:27
|
<rfriedman> rafa, i am not using the test db
|
12:50:52
|
<rafa> rfriedman: that's fine, but what uri are you calling and what is the error?
|
12:50:56
|
<rfriedman> http://localhost:8080/openmrs/ws/rest/v1/patient?q=Castillo
|
12:51:10
|
<rafa> rfriedman: ohh q may not be working
|
12:51:16
|
<rafa> rfriedman: wyclif is still working on that
|
12:51:25
|
<rfriedman> doesn't work with uuid for castillo either
|
12:51:44
|
<rafa> rfriedman: what's the error?
|
12:54:05
|
<rfriedman> rafa, unknown:
|
12:54:06
|
<rfriedman> error!
|
12:54:06
|
<rfriedman> msg: error
|
12:54:06
|
<rfriedman> errorThrown: undefined
|
12:54:06
|
<rfriedman> req: [object XMLHttpRequest]
|
12:54:34
|
<rafa> rfriedman: are you sure you are using the latest code from sprint-201302?
|
12:55:02
|
<rfriedman> yes, downloaded it yesterday afternoon and compiled it
|
12:55:18
|
<rfriedman> loaded module version from target directory
|
12:56:12
|
<rafa> rfriedman: in the manage modules does it say 1.2-SNAPSHOT.920169 ?
|
12:56:35
|
<rfriedman> rafa, yes
|
12:57:00
|
<rafa> rfriedman: hmm and which version of omrs?
|
12:57:36
|
<rfriedman> rafa, 1.9.2-SNAPSHOT build 0
|
12:57:54
|
<rafa> rfriedman: strange
|
12:57:59
|
<rafa> rfriedman: we'll need stacktrace
|
12:58:15
|
<rfriedman> rafa, i don't see one on the console
|
12:58:41
|
<rafa> rfriedman: can you also test: /openmrs-standalone/ws/rest/v1/location
|
12:59:00
|
<rfriedman> i am not running standalone
|
12:59:05
|
<rafa> rfriedman: are you looking at the right console?
|
12:59:18
|
<rafa> rfriedman: yeah, I know just remove standalone
|
12:59:20
|
<rfriedman> yes, i am running openmrs via jetty
|
13:00:09
|
<rafa> rfriedman: ahh that may explain...
|
13:00:57
|
<rafa> rfriedman: I think OpenmrsConstants.OPENMRS_VERSION_SHORT is null when running a SNAPSHOT via jetty
|
13:01:11
|
<rafa> rfriedman: thus no resources are registered
|
13:01:17
|
<rfriedman> rafa, ok, location works from the browser window
|
13:01:24
|
<rowanseymour> rafa: you're right - its the latest CIEL dump that is broken
|
13:02:29
|
<rafa> rowanseymour: we need to contact Andy
|
13:02:34
|
<rfriedman> rafa, patient/uuid also works from browser window
|
13:02:50
|
<rowanseymour> sending email to dev list right now
|
13:03:11
|
<rafa> rfriedman: so it doesn't work from http://localhost:8081/openmrs-standalone/module/webservices/rest/test.htm ?
|
13:03:14
|
<rfriedman> rafa, q=Castillo also works from browser window
|
13:03:45
|
<rfriedman> rafa, right, let me check my /s in the global property and see if that's it
|
13:06:22
|
<rfriedman> rafa, must be something about how host setting and address are combined, with host setting empty and full url in test page url, works
|
13:07:26
|
<rafa> rfriedman: I never put the host part in URI on the test page
|
13:07:38
|
<rafa> rfriedman: just /openmrs/ws/rest/v1/location
|
13:08:24
|
<rfriedman> rafa, yes, that works also
|
13:09:02
|
<rafa> rfriedman: so I'm confused what doesn't work :)
|
13:09:40
|
<rfriedman> with /openmrs in host setting and ws/rest... in test url, it doesn't work
|
13:10:58
|
<rafa> rfriedman: in the test URI you must put either /openmrs/ws/rest/v1/location or http://localhost:8080/openmrs/ws/rest/v1/location
|
13:11:31
|
<rafa> rfriedman: it works for me all the time, even if host settings are screwed up
|
13:12:28
|
*** sunbiz has joined #openmrs
|
13:12:28
|
*** ChanServ sets mode: +v sunbiz
|
13:12:48
|
<rfriedman> well, it doesn't work for me regardless of what i put in host setting
|
13:13:07
|
<rfriedman> rafa, i have tried /openmrs, openmrs/, /openmrs/, openmrs
|
13:13:37
|
<rfriedman> rafa, although i do not have / in front of test line
|
13:14:25
|
<rafa> rfriedman: okay, I can't really reproduce it. If you think it's a problem, can you please ticket it?
|
13:14:35
|
<rfriedman> rafa, should be easy to determine underlying truth and make window text match it
|
13:14:49
|
<rowanseymour> Not an encouraging sign - validation module crashed!
|
13:14:57
|
<rowanseymour> Exception in thread "Thread-259" org.springframework.transaction.UnexpectedRollbackException: Transaction rolled back because it has been marked as rollback-only
|
13:14:57
|
<rowanseymour> at org.springframework.transaction.support.AbstractPlatformTransactionManager.commit(AbstractPlatformTransactionManager.java:717)
|
13:14:57
|
<rowanseymour> at org.springframework.transaction.interceptor.TransactionAspectSupport.commitTransactionAfterReturning(TransactionAspectSupport.java:393)
|
13:14:57
|
<rowanseymour> at org.springframework.transaction.interceptor.TransactionInterceptor.invoke(TransactionInterceptor.java:120)
|
13:14:57
|
<rowanseymour> at org.springframework.aop.framework.ReflectiveMethodInvocation.proceed(ReflectiveMethodInvocation.java:172)
|
13:14:57
|
<rowanseymour> at org.springframework.aop.framework.JdkDynamicAopProxy.invoke(JdkDynamicAopProxy.java:202)
|
13:15:04
|
<rowanseymour> at $Proxy315.validate(Unknown Source)
|
13:15:04
|
<rowanseymour> at org.openmrs.module.validation.ValidationThread.run(ValidationThread.java:94)
|
13:18:07
|
*** djadmin has joined #openmrs
|
13:21:15
|
<rfriedman> rafa, test page does not appear to use property setting at all
|
13:21:24
|
*** djazayeri has joined #openmrs
|
13:21:24
|
*** ChanServ sets mode: +o djazayeri
|
13:21:52
|
<rafa> rfriedman: yes, that's why I don't understand why it doesn't work for you
|
13:22:00
|
<rafa> rowanseymour: I haven't seen it before
|
13:22:16
|
<rfriedman> rafa, it doesn't work when i try to rely on the property to provide the front end of the uri
|
13:22:53
|
<rfriedman> rafa, what is the value of the property except for that?
|
13:23:27
|
<rfriedman> rafa, value in the sense of purpose
|
13:24:04
|
<rafa> rfriedman: for the links to full refs in response
|
13:24:58
|
<rfriedman> rafa, ok, misunderstanding, maybe i can clear it up in doc
|
13:33:23
|
*** djadmin has quit IRC
|
13:38:30
|
*** djazayeri has quit IRC
|
13:51:44
|
*** k-joseph has joined #openmrs
|
13:56:39
|
*** rfriedman has quit IRC
|
13:58:53
|
*** k-joseph has quit IRC
|
14:00:39
|
*** k-joseph has joined #openmrs
|
14:01:59
|
<k-joseph> dkayiwa: hi
|
14:02:06
|
<dkayiwa> k-joseph: hi
|
14:03:01
|
<k-joseph> dkayiwa: mvn clean install failed!!1
|
14:03:23
|
<dkayiwa> k-joseph: with what error
|
14:05:13
|
*** shady__ has quit IRC
|
14:06:06
|
<k-joseph> dkayiwa: actually, i lost the error log, am trying it, again, i also did it from eclipse, looking at project after project, api had so far failed, am just repeating that again, now,
|
14:08:25
|
<dkayiwa> ok
|
14:11:10
|
*** k-joseph has quit IRC
|
14:12:45
|
*** rfriedman has joined #openmrs
|
14:24:51
|
*** rowanseymour has quit IRC
|
14:29:57
|
<rfriedman> dkayiwa, will you be at scrum today?
|
14:30:18
|
<dkayiwa> rfriedman: yes. did you want to tell me something?
|
14:30:46
|
<rfriedman> dkayiwa, yes, i have a conflicting meeting, could you say that i am working on documentation?
|
14:31:08
|
<dkayiwa> rfriedman: which documentation?
|
14:31:14
|
<dkayiwa> rfriedman: ticket number???
|
14:31:40
|
<rfriedman> dkayiwa, first i am updating existing to include subclasses and named/custom representations
|
14:31:58
|
<dkayiwa> rfriedman: is that a particular ticket?
|
14:32:07
|
<rfriedman> dkayiwa, don't think so
|
14:32:36
|
<rfriedman> dkayiwa, RESTWS-268
|
14:32:54
|
*** djadmin has joined #openmrs
|
14:32:57
|
<rfriedman> dkayiwa, then i will revise that page to reflect new methods
|
14:33:05
|
<dkayiwa> rfriedman: what we normally do when you are going to be around during scrum time is send out an email to email addresses of those that participate in the scrum :)
|
14:33:21
|
<dkayiwa> rfriedman: i meant when one is not going to be around :)
|
14:33:38
|
*** rowanseymour has joined #openmrs
|
14:34:16
|
<rfriedman> dkayiwa, ok, np, don't have time for that
|
14:34:25
|
<rfriedman> dkayiwa, prob doesn't matter anyway :)
|
14:34:34
|
<dkayiwa> rfriedman: ok will update the team with what you have told me :)
|
14:35:02
|
*** GitHub118 has joined #openmrs
|
14:35:02
|
<GitHub118> [openmrs-core] dkayiwa pushed 2 new commits to master: http://git.io/ll2cng
|
14:35:02
|
<GitHub118> openmrs-core/master 7ed1e61 Nils Eckelt: handles empty short names and void the old ones instead of saving the empty ones
|
14:35:02
|
<GitHub118> openmrs-core/master bae3f32 dkayiwa: Merge pull request #207 from NilsEckelt/master...
|
14:35:02
|
*** GitHub118 has left #openmrs
|
14:38:04
|
*** rfriedman is now known as rfriedman-away
|
14:45:57
|
*** djazayeri has joined #openmrs
|
14:45:57
|
*** ChanServ sets mode: +o djazayeri
|
14:46:46
|
*** travis-ci has joined #openmrs
|
14:46:46
|
<travis-ci> [travis-ci] [openmrs/openmrs-core] [bae3f32] [dkayiwa] The build passed. - http://travis-ci.org/openmrs/openmrs-core/builds/4745981
|
14:46:46
|
*** travis-ci has left #openmrs
|
14:46:49
|
<OpenMRSBot> <http://ln-s.net/+cOa> (at travis-ci.org)
|
14:48:42
|
*** mseaton has joined #openmrs
|
14:48:42
|
*** ChanServ sets mode: +v mseaton
|
14:55:48
|
*** andrea_ has joined #openmrs
|
14:56:52
|
<wyclif> hi rafa
|
14:57:43
|
<wyclif> rafa, why does https://tickets.openmrs.org/browse/RESTWS-267 depend on RESTWS-309?
|
14:58:33
|
<rafa> wyclif: because it needs to be put in omod-1.9 and I needed to make sure it works correctly
|
14:58:39
|
<rafa> wyclif: I think it's unblocked now
|
14:58:51
|
<rafa> wyclif: I've just pushed some work for RESTWS-309
|
14:59:18
|
<wyclif> rafa, okay thanks
|
14:59:45
|
<andrea_> rafa, did you do REST-322 Fix ConceptClassControllerTest?
|
14:59:59
|
<rafa> andrea_: pardon?
|
15:00:05
|
<rafa> andrea_: it's your ticket, isn't it?
|
15:00:31
|
<rafa> andrea_: I left you a comment there
|
15:00:43
|
<rafa> andrea_: You looked at wrong classes
|
15:00:58
|
<andrea_> rafa, oh good
|
15:01:22
|
<andrea_> rafa, I thought that was possible -
|
15:01:30
|
*** hybridivy has quit IRC
|
15:02:13
|
*** cpower_ has joined #openmrs
|
15:02:31
|
<cpower_> Hello! Are we ready to start?
|
15:02:44
|
<cpower_> !scrumon cpower
|
15:02:44
|
* OpenMRSBot says the DAILY SCRUM MEETING is STARTING. This meeting should not last longer than 15 minutes. Please hold other comments until the end of the meeting, or message someone privately. Thank you! ScrumMaster cpower- you may begin when ready.
|
15:03:17
|
<cpower_> Order: wyclif, dkayiwa, andrea_, rafa, mseaton, djazayeri
|
15:06:20
|
<dkayiwa> Roger's update: first i am updating existing to include subclasses and named/custom representations - RESTWS-268
|
15:06:32
|
<dkayiwa> and mine below:
|
15:06:34
|
<dkayiwa> Reviewed: Retired Visit types appear on the New Visit form - TRUNK-3370
|
15:06:34
|
<dkayiwa> Reviewed: update all of these types of extension point links to use c:url so that we are consistent - TRUNK-3770
|
15:06:35
|
<dkayiwa> Reviewed and tested: Encounter autocomplete should filter results by patient - TRUNK-3231
|
15:06:35
|
<dkayiwa> Reviewed: Correct BaseOpenmrsObject equals - TRUNK-3844
|
15:06:35
|
<dkayiwa> Reviewed and tested: Erasing a short name in the edit concepts page should void it - TRUNK-3445
|
15:06:35
|
<dkayiwa> Now back porting: Erasing a short name in the edit concepts page should void it - TRUNK-3445
|
15:06:36
|
<dkayiwa> No Blockers
|
15:08:04
|
<rafa> andrea_: ?
|
15:08:21
|
<andrea_> Monday
|
15:08:21
|
<andrea_> Had to check out, rebuild code and
|
15:08:21
|
<andrea_> load REST module again due to computer problems.
|
15:08:21
|
<andrea_> Back working on REST-322 Fix ConceptClassControllerTest
|
15:08:21
|
<andrea_> Downloaded curl - Figure out how to test.
|
15:08:22
|
<andrea_> Tuesday
|
15:08:24
|
<andrea_> (I see Rafal's comment on tiket)
|
15:08:26
|
<andrea_> Work on REST-322 Fix ConceptClassControllerTest
|
15:08:28
|
<andrea_> No Blockers
|
15:08:43
|
<rafa> Today:
|
15:08:43
|
<rafa> * Reviewed tickets
|
15:08:43
|
<rafa> * Some IRC support
|
15:08:43
|
<rafa> * Committed most of RESTWS-309: Merge webservices.rest and webservices.rest19ext modules into one
|
15:08:43
|
<rafa> https://tickets.openmrs.org/browse/RESTWS-309 (will need a few more hours to adjust tests)
|
15:08:43
|
<rafa> No blockers.
|
15:09:09
|
<cpower_> next!
|
15:09:30
|
<cpower_> mseaton or djazayeri you around?
|
15:09:39
|
<mseaton> cpower_: i'm here
|
15:09:46
|
<cpower_> or still frozen in Boston ;-)
|
15:10:13
|
<cpower_> any updates or just getting home?
|
15:10:16
|
<mseaton> cpower_: nothing to update. will try to get a patientsummary synopsis out at some point soon.
|
15:11:16
|
<cpower_> Ok, annoucements. Reference 2.0 sprint 1 of many will not be happening next as planned. We need additional time to plan. So we are looking into other sprints to put in it's place, so stay tuned.
|
15:11:52
|
<cpower_> No blockers or discussion points, so have a good day everyone
|
15:11:57
|
<cpower_> !scrumoff
|
15:11:57
|
* OpenMRSBot says the DAILY SCRUM MEETING has ENDED. This channel is now returned to normal hacking operations. Post-scrum meeting follow-up conversations may now begin.
|
15:12:55
|
*** dkayiwa has quit IRC
|
15:13:10
|
<wyclif> did you leave me out
|
15:13:28
|
<jkeiper> oops
|
15:13:39
|
<rafa> andrea_: you don't have to use curl
|
15:13:50
|
<rafa> andrea_: the module has a built-in test tool
|
15:13:51
|
*** Mkop has joined #openmrs
|
15:13:51
|
*** ChanServ sets mode: +v Mkop
|
15:13:57
|
<rafa> andrea_: module/webservices/rest/test.htm
|
15:14:09
|
<rafa> andrea_: also for your ticket you don't even need to run openmrs
|
15:14:28
|
<rafa> andrea_: you just need to run junit
|
15:14:47
|
<andrea_> rafa, so I don't need curl
|
15:15:46
|
<andrea_> rafa - the ConceptClassControllerTest is totally commented out
|
15:15:53
|
<rafa> andrea_: that's correct
|
15:16:05
|
*** rowanseymour has quit IRC
|
15:16:18
|
<rafa> andrea_: it needs to be uncommented and fixed so that it compiles
|
15:16:25
|
<andrea_> rafa, so fix like allergy test?
|
15:16:30
|
<rafa> andrea_: yes
|
15:17:05
|
<andrea_> rafa, sorry I got the wrong class - was crazy with computer problems
|
15:17:17
|
<rafa> andrea_: no worries
|
15:18:10
|
<andrea_> rafa, had to take battery out and put it back on work computer to get it to start this am
|
15:25:12
|
*** k-joseph has joined #openmrs
|
15:30:43
|
*** djadmin has quit IRC
|
15:30:58
|
*** k-joseph has quit IRC
|
15:32:11
|
*** k-joseph has joined #openmrs
|
15:40:53
|
*** rafa has quit IRC
|
15:52:36
|
*** djadmin has joined #openmrs
|
16:10:34
|
*** djadmin has quit IRC
|
16:11:18
|
*** djadmin has joined #openmrs
|
16:15:58
|
*** djadmin2 has joined #openmrs
|
16:15:59
|
*** djadmin has quit IRC
|
16:20:58
|
*** k-joseph has quit IRC
|
16:22:37
|
*** k-joseph has joined #openmrs
|
16:59:55
|
<k-joseph> hi, to you all, i have recently changed from windows to linux where am going to be working on openmrs from, i installed all the packages and plugins required, and now while importing openmrs to eclipse, am getting errors, please help me to fix this, so that i may again keep going, here is the error http://snag.gy/epx2x.jpg thanks a lot :(
|
17:00:17
|
*** djadmin2 has quit IRC
|
17:06:41
|
*** hybridivy has joined #openmrs
|
17:09:25
|
*** djadmin has joined #openmrs
|
17:26:24
|
*** mseaton1 has joined #openmrs
|
17:28:28
|
*** mseaton has quit IRC
|
17:41:53
|
*** mseaton1 has quit IRC
|
17:48:47
|
*** hybridivy has quit IRC
|
17:50:32
|
*** mseaton has joined #openmrs
|
17:50:32
|
*** ChanServ sets mode: +v mseaton
|
17:51:18
|
*** mseaton has quit IRC
|
17:53:04
|
*** sunbiz has quit IRC
|
17:53:07
|
*** mseaton has joined #openmrs
|
17:53:07
|
*** ChanServ sets mode: +v mseaton
|
17:53:51
|
*** sunbiz has joined #openmrs
|
17:53:51
|
*** ChanServ sets mode: +v sunbiz
|
17:55:45
|
*** mseaton has quit IRC
|
17:56:29
|
*** rowanseymour has joined #openmrs
|
17:56:42
|
*** mseaton has joined #openmrs
|
17:56:44
|
*** ChanServ sets mode: +v mseaton
|
17:59:36
|
*** rowanseymour has quit IRC
|
18:01:30
|
*** djazayeri1 has joined #openmrs
|
18:01:32
|
*** djazayeri has quit IRC
|
18:02:44
|
*** rowanseymour has joined #openmrs
|
18:07:18
|
*** djazayeri1 has quit IRC
|
18:07:27
|
*** rowanseymour has quit IRC
|
18:10:46
|
*** rowanseymour has joined #openmrs
|
18:12:32
|
*** andrea__ has joined #openmrs
|
18:15:58
|
*** andrea_ has quit IRC
|
18:18:01
|
*** hybridivy has joined #openmrs
|
18:21:53
|
*** k-joseph has quit IRC
|
18:30:26
|
*** hybridivy has left #openmrs
|
18:31:36
|
*** rfriedman-away is now known as rfriedman
|
18:32:10
|
*** k-joseph has joined #openmrs
|
18:32:46
|
*** djazayeri has joined #openmrs
|
18:32:46
|
*** ChanServ sets mode: +o djazayeri
|
18:33:07
|
*** djadmin has quit IRC
|
18:34:05
|
*** rowanseymour has quit IRC
|
18:36:14
|
*** rowanseymour has joined #openmrs
|
18:36:14
|
*** djazayeri has quit IRC
|
18:36:31
|
*** djazayeri has joined #openmrs
|
18:36:31
|
*** ChanServ sets mode: +o djazayeri
|
18:38:17
|
*** rowanseymour has quit IRC
|
18:38:35
|
*** mseaton1 has joined #openmrs
|
18:39:04
|
*** rowanseymour has joined #openmrs
|
18:39:30
|
<rfriedman> mseaton1, hi
|
18:40:06
|
<mseaton1> rfriedman: hey
|
18:40:30
|
<rfriedman> mseaton, hey, I was at a seminar this morning and got to wondering if we did anything in reporting to optimize queries
|
18:40:48
|
<mseaton1> rfriedman: example?
|
18:41:33
|
<rfriedman> mseaton, for example, in composition cohorts using AND, do we evaluate both sides and then AND them or do we AND the cohorts, do the left side and then do the right side on the result
|
18:42:08
|
<rfriedman> mseaton, excuse, not clear
|
18:42:30
|
<mseaton1> rfriedman: in the current implementation we evaluate each query in full (on the base cohort supplied), and then intersect/union/etc in java
|
18:42:42
|
<rfriedman> option 1: calculate left side on its cohort, calculate right side on its cohort, then AND the cohorts
|
18:42:56
|
*** mseaton has quit IRC
|
18:43:14
|
<mseaton1> rfriedman: this could be changed if it were more efficient to reduce down base cohort as we go, but the tradeoff would be that caching would potentially be lost
|
18:43:18
|
*** mseaton1 is now known as mseaton
|
18:44:15
|
<rfriedman> mseaton1, ok, yes, but which is more important? or can we make it an option?
|
18:44:31
|
<mseaton> rfriedman: for example, right now if you do male + adult, then male + children, then female + adult, then female + children, you can reuse male, female, adult, child cached results as you go
|
18:45:19
|
*** rowanseymour has quit IRC
|
18:45:36
|
<rfriedman> mseaton, or what about, if you have A and B, and the criteria of A are more likely to eliminate patients than the criteria of B, make sure that A is done first
|
18:45:39
|
<mseaton> rfriedman: certainly could be modified to support the other approach. not sure how to make it configurable at runtime. a different implementation of a CompositionCohortDefinitionEvaluator could do it differently easily
|
18:46:28
|
<mseaton> rfriedman: yes, if that were something that could be detected.
|
18:46:39
|
<rfriedman> mseaton, what about things that can be done with the same table, like males >18, is there a way to handle that?
|
18:47:14
|
<rfriedman> mseaton, DBs keep statistics for query optimization, we could also
|
18:48:07
|
<mseaton> rfriedman: yes, good point. would be interesting to design in a way to store statistics around which queries are run most often, how long they take to run, etc.
|
18:48:52
|
<rfriedman> mseaton, i think it would be more table-based: count of encounters by encounter type; count of obs by id-value for coded obs
|
18:49:45
|
<rfriedman> mseaton, if we create an index on what we're interested in, the counts come with no DB accesses, only index accesses
|
18:50:01
|
*** djadmin has joined #openmrs
|
18:50:32
|
*** dkayiwa has joined #openmrs
|
18:52:16
|
<mseaton> rfriedman: the intention behind our design in the reporting module is to provide the framework for plugging in "definitions" and "evaluators" to produce "results", and then various tools around those. and so far, some bad UIs around them too. and when i have written many of the evaluators that are in place now, my goal often has been to get a reasonably efficient starting pass out the door that produces the right result, and then allowing us to iterat
|
18:52:57
|
<rfriedman> mseaton, understand, np, just had this idea, thought i wld pass it on
|
18:53:38
|
<mseaton> rfriedman: yeah, i'm on board. hopefully contributers with good db chops can get into that code and make it faster.
|
18:54:07
|
<mseaton> rfriedman: or design alternative techniques (data warehousing, indexing, etc) that can improve things
|
18:54:23
|
*** andrea has joined #openmrs
|
18:54:46
|
*** andrea is now known as Guest10726
|
18:57:34
|
*** andrea__ has quit IRC
|
18:58:00
|
*** Guest10726 is now known as andreap
|
19:04:44
|
*** djadmin has quit IRC
|
19:05:09
|
<k-joseph> hi, to you all, i have recently changed from windows to linux where am going to be working on openmrs from, i installed all the packages and plugins required, and now while importing openmrs to eclipse, am getting errors, please help me to fix this, so that i may again keep going, here is the error http://snag.gy/epx2x.jpg thanks a lot :(
|
19:05:37
|
<k-joseph> dkayiwa: hiii
|
19:19:41
|
*** djazayeri1 has joined #openmrs
|
19:24:54
|
*** djazayeri has quit IRC
|
19:26:07
|
*** rowanseymour has joined #openmrs
|
19:33:35
|
*** dkayiwa has quit IRC
|
19:34:49
|
*** rowanseymour has quit IRC
|
19:39:18
|
*** k-joseph has quit IRC
|
19:48:37
|
*** k-joseph has joined #openmrs
|
19:53:27
|
*** andreap has quit IRC
|
19:53:47
|
*** rkorytkowski has joined #openmrs
|
19:53:47
|
*** ChanServ sets mode: +v rkorytkowski
|
19:53:47
|
*** rkorytkowski is now known as rafa
|
20:11:21
|
*** dkayiwa has joined #openmrs
|
20:16:34
|
*** sunbiz has quit IRC
|
20:24:33
|
*** djazayeri has joined #openmrs
|
20:24:33
|
*** ChanServ sets mode: +o djazayeri
|
20:24:33
|
*** djazayeri1 has quit IRC
|
20:35:02
|
*** jkeiper has quit IRC
|
20:36:30
|
*** jkeiper has joined #openmrs
|
20:36:30
|
*** ChanServ sets mode: +v jkeiper
|
20:48:09
|
*** djazayeri1 has joined #openmrs
|
20:48:37
|
*** djazayeri has quit IRC
|
20:52:23
|
*** rfriedman has quit IRC
|
21:02:54
|
*** k-joseph has quit IRC
|
21:03:20
|
*** djadmin has joined #openmrs
|
21:13:20
|
*** djazayeri1 has quit IRC
|
21:15:20
|
*** djadmin has quit IRC
|
21:17:45
|
*** sunbiz has joined #openmrs
|
21:17:45
|
*** ChanServ sets mode: +v sunbiz
|
21:28:16
|
*** sunbiz has left #openmrs
|
21:33:09
|
*** rafa has quit IRC
|
21:36:08
|
*** cpower_ has quit IRC
|
21:56:05
|
*** djazayeri has joined #openmrs
|
21:56:05
|
*** ChanServ sets mode: +o djazayeri
|
22:08:09
|
*** dkayiwa has quit IRC
|
22:44:11
|
*** lh has quit IRC
|
23:04:52
|
*** djazayeri has quit IRC
|
23:07:56
|
*** djazayeri has joined #openmrs
|
23:07:56
|
*** ChanServ sets mode: +o djazayeri
|
23:08:01
|
*** djazayeri has quit IRC
|
23:12:01
|
*** mseaton has left #openmrs
|